{"action":"created","comment":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments/191134989","pull_request_review_id":123637383,"id":191134989,"diff_hunk":"@@ -141,85 +139,95 @@ def setup_platform(hass, config, add_devices, discovery_info=None):\n \n \n class RainMachineSwitch(RainMachineEntity, SwitchDevice):\n-    \"\"\"A class to represent a generic RainMachine entity.\"\"\"\n+    \"\"\"A class to represent a generic RainMachine switch.\"\"\"\n+\n+    def __init__(self, rainmachine, switch_type, obj):\n+        \"\"\"Initialize a generic RainMachine switch.\"\"\"\n+        super().__init__(rainmachine)\n \n-    def __init__(self, rainmachine, rainmachine_type, obj):\n-        \"\"\"Initialize a generic RainMachine entity.\"\"\"\n+        self._name = obj['name']\n         self._obj = obj\n-        self._type = rainmachine_type\n+        self._rainmachine_entity_id = obj['uid']\n+        self._switch_type = switch_type\n \n-        super().__init__(rainmachine, rainmachine_type, obj.get('uid'))\n+    @property\n+    def icon(self) -> str:\n+        \"\"\"Return the icon.\"\"\"\n+        return 'mdi:water'\n \n     @property\n     def is_enabled(self) -> bool:\n         \"\"\"Return whether the entity is enabled.\"\"\"\n         return self._obj.get('active')\n \n+    @property\n+    def should_poll(self):\n+        \"\"\"Enable polling.\"\"\"\n+        return True","path":"homeassistant/components/switch/rainmachine.py","position":53,"original_position":53,"commit_id":"3ba317683aead51063cedd2f793598d04b03bc2d","original_commit_id":"3ba317683aead51063cedd2f793598d04b03bc2d","user":{"login":"MartinHjelmare","id":3181692,"avatar_url":"https://avatars0.githubusercontent.com/u/3181692?v=4","gravatar_id":"","url":"https://api.github.com/users/MartinHjelmare","html_url":"https://github.com/MartinHjelmare","followers_url":"https://api.github.com/users/MartinHjelmare/followers","following_url":"https://api.github.com/users/MartinHjelmare/following{/other_user}","gists_url":"https://api.github.com/users/MartinHjelmare/gists{/gist_id}","starred_url":"https://api.github.com/users/MartinHjelmare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MartinHjelmare/subscriptions","organizations_url":"https://api.github.com/users/MartinHjelmare/orgs","repos_url":"https://api.github.com/users/MartinHjelmare/repos","events_url":"https://api.github.com/users/MartinHjelmare/events{/privacy}","received_events_url":"https://api.github.com/users/MartinHjelmare/received_events","type":"User","site_admin":false},"body":"This is the default for entity.","created_at":"2018-05-28T07:49:09Z","updated_at":"2018-05-28T07:50:07Z","html_url":"https://github.com/home-assistant/home-assistant/pull/14326#discussion_r191134989","pull_request_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/14326","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments/191134989"},"html":{"href":"https://github.com/home-assistant/home-assistant/pull/14326#discussion_r191134989"},"pull_request":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/14326"}}},"pull_request":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/14326","id":186247129,"html_url":"https://github.com/home-assistant/home-assistant/pull/14326","diff_url":"https://github.com/home-assistant/home-assistant/pull/14326.diff","patch_url":"https://github.com/home-assistant/home-assistant/pull/14326.patch","issue_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/14326","number":14326,"state":"open","locked":false,"title":"Adds sensors and services to RainMachine","user":{"login":"bachya","id":47216,"avatar_url":"https://avatars3.githubusercontent.com/u/47216?v=4","gravatar_id":"","url":"https://api.github.com/users/bachya","html_url":"https://github.com/bachya","followers_url":"https://api.github.com/users/bachya/followers","following_url":"https://api.github.com/users/bachya/following{/other_user}","gists_url":"https://api.github.com/users/bachya/gists{/gist_id}","starred_url":"https://api.github.com/users/bachya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bachya/subscriptions","organizations_url":"https://api.github.com/users/bachya/orgs","repos_url":"https://api.github.com/users/bachya/repos","events_url":"https://api.github.com/users/bachya/events{/privacy}","received_events_url":"https://api.github.com/users/bachya/received_events","type":"User","site_admin":false},"body":"## Description:\r\nAdds several (binary) sensors to the RainMachine component:\r\n\r\n- Binary Sensor: Extra Water on Hot Days\r\n- Binary Sensor: Freeze Protection\r\n- Binary Sensor: Freeze Restrictions\r\n- Binary Sensor: Hourly Restrictions\r\n- Binary Sensor: Month Restrictions\r\n- Binary Sensor: Rain Delay Restrictions\r\n- Binary Sensor: Rain Sensor Restrictions\r\n- Binary Sensor: Weekday Restrictions\r\n- Sensor: Freeze Protect Temperature\r\n\r\nAdditionally, this PR adds several services:\r\n\r\n- `start_program`\r\n- `start_zone`\r\n- `stop_all`\r\n- `stop_program`\r\n- `stop_zone`\r\n\r\n**Related issue (if applicable):** N/A\r\n\r\n**Pull request in [home-assistant.github.io](https://github.com/home-assistant/home-assistant.github.io) with documentation (if applicable):** https://github.com/home-assistant/home-assistant.github.io/pull/5322\r\n\r\n## Example entry for `configuration.yaml` (if applicable):\r\n```yaml\r\nrainmachine:\r\n  ip_address: 192.168.1.100\r\n  password: abc123\r\n```\r\n\r\n## Checklist:\r\n  - [x] The code change is tested and works locally.\r\n  - [x] Local tests pass with `tox`. **Your PR cannot be merged unless tests pass**\r\n\r\nIf user exposed functionality or configuration variables are added/changed:\r\n  - [x] Documentation added/updated in [home-assistant.github.io](https://github.com/home-assistant/home-assistant.github.io)\r\n\r\nIf the code communicates with devices, web services, or third-party tools:\r\n  ~- [ ] New dependencies have been added to the `REQUIREMENTS` variable ([example][ex-requir]).~\r\n  ~- [ ] New dependencies are only imported inside functions that use them ([example][ex-import]).~\r\n  ~- [ ] New dependencies have been added to `requirements_all.txt` by running `script/gen_requirements_all.py`.~\r\n  ~- [ ] New files were added to `.coveragerc`.~\r\n\r\n[ex-requir]: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/keyboard.py#L14\r\n[ex-import]: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/keyboard.py#L54\r\n","created_at":"2018-05-07T03:21:26Z","updated_at":"2018-05-28T07:50:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e49c456d43a5c55248de96c1a18b9b5e67f94b57","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":527871105,"url":"https://api.github.com/repos/home-assistant/home-assistant/labels/cla-signed","name":"cla-signed","color":"008000","default":false},{"id":914301406,"url":"https://api.github.com/repos/home-assistant/home-assistant/labels/component:%20rainmachine","name":"component: rainmachine","color":"ededed","default":false},{"id":526146744,"url":"https://api.github.com/repos/home-assistant/home-assistant/labels/new-platform","name":"new-platform","color":"ededed","default":false},{"id":924845460,"url":"https://api.github.com/repos/home-assistant/home-assistant/labels/platform:%20binary_sensor.rainmachine","name":"platform: binary_sensor.rainmachine","color":"ededed","default":false},{"id":924845461,"url":"https://api.github.com/repos/home-assistant/home-assistant/labels/platform:%20sensor.rainmachine","name":"platform: sensor.rainmachine","color":"ededed","default":false},{"id":662099535,"url":"https://api.github.com/repos/home-assistant/home-assistant/labels/platform:%20switch.rainmachine","name":"platform: switch.rainmachine","color":"ededed","default":false},{"id":526148046,"url":"https://api.github.com/repos/home-assistant/home-assistant/labels/remove-platform","name":"remove-platform","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/14326/commits","review_comments_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/14326/comments","review_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments{/number}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/14326/comments","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/3ba317683aead51063cedd2f793598d04b03bc2d","head":{"label":"bachya:rainmachine-3","ref":"rainmachine-3","sha":"3ba317683aead51063cedd2f793598d04b03bc2d","user":{"login":"bachya","id":47216,"avatar_url":"https://avatars3.githubusercontent.com/u/47216?v=4","gravatar_id":"","url":"https://api.github.com/users/bachya","html_url":"https://github.com/bachya","followers_url":"https://api.github.com/users/bachya/followers","following_url":"https://api.github.com/users/bachya/following{/other_user}","gists_url":"https://api.github.com/users/bachya/gists{/gist_id}","starred_url":"https://api.github.com/users/bachya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bachya/subscriptions","organizations_url":"https://api.github.com/users/bachya/orgs","repos_url":"https://api.github.com/users/bachya/repos","events_url":"https://api.github.com/users/bachya/events{/privacy}","received_events_url":"https://api.github.com/users/bachya/received_events","type":"User","site_admin":false},"repo":{"id":99717341,"name":"home-assistant","full_name":"bachya/home-assistant","owner":{"login":"bachya","id":47216,"avatar_url":"https://avatars3.githubusercontent.com/u/47216?v=4","gravatar_id":"","url":"https://api.github.com/users/bachya","html_url":"https://github.com/bachya","followers_url":"https://api.github.com/users/bachya/followers","following_url":"https://api.github.com/users/bachya/following{/other_user}","gists_url":"https://api.github.com/users/bachya/gists{/gist_id}","starred_url":"https://api.github.com/users/bachya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bachya/subscriptions","organizations_url":"https://api.github.com/users/bachya/orgs","repos_url":"https://api.github.com/users/bachya/repos","events_url":"https://api.github.com/users/bachya/events{/privacy}","received_events_url":"https://api.github.com/users/bachya/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bachya/home-assistant","description":":house_with_garden: Open-source home automation platform running on Python 3","fork":true,"url":"https://api.github.com/repos/bachya/home-assistant","forks_url":"https://api.github.com/repos/bachya/home-assistant/forks","keys_url":"https://api.github.com/repos/bachya/home-assistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bachya/home-assistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bachya/home-assistant/teams","hooks_url":"https://api.github.com/repos/bachya/home-assistant/hooks","issue_events_url":"https://api.github.com/repos/bachya/home-assistant/issues/events{/number}","events_url":"https://api.github.com/repos/bachya/home-assistant/events","assignees_url":"https://api.github.com/repos/bachya/home-assistant/assignees{/user}","branches_url":"https://api.github.com/repos/bachya/home-assistant/branches{/branch}","tags_url":"https://api.github.com/repos/bachya/home-assistant/tags","blobs_url":"https://api.github.com/repos/bachya/home-assistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bachya/home-assistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bachya/home-assistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/bachya/home-assistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bachya/home-assistant/statuses/{sha}","languages_url":"https://api.github.com/repos/bachya/home-assistant/languages","stargazers_url":"https://api.github.com/repos/bachya/home-assistant/stargazers","contributors_url":"https://api.github.com/repos/bachya/home-assistant/contributors","subscribers_url":"https://api.github.com/repos/bachya/home-assistant/subscribers","subscription_url":"https://api.github.com/repos/bachya/home-assistant/subscription","commits_url":"https://api.github.com/repos/bachya/home-assistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/bachya/home-assistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/bachya/home-assistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/bachya/home-assistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/bachya/home-assistant/contents/{+path}","compare_url":"https://api.github.com/repos/bachya/home-assistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bachya/home-assistant/merges","archive_url":"https://api.github.com/repos/bachya/home-assistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bachya/home-assistant/downloads","issues_url":"https://api.github.com/repos/bachya/home-assistant/issues{/number}","pulls_url":"https://api.github.com/repos/bachya/home-assistant/pulls{/number}","milestones_url":"https://api.github.com/repos/bachya/home-assistant/milestones{/number}","notifications_url":"https://api.github.com/repos/bachya/home-assistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bachya/home-assistant/labels{/name}","releases_url":"https://api.github.com/repos/bachya/home-assistant/releases{/id}","deployments_url":"https://api.github.com/repos/bachya/home-assistant/deployments","created_at":"2017-08-08T17:09:51Z","updated_at":"2018-05-23T15:52:32Z","pushed_at":"2018-05-28T03:17:49Z","git_url":"git://github.com/bachya/home-assistant.git","ssh_url":"git@github.com:bachya/home-assistant.git","clone_url":"https://github.com/bachya/home-assistant.git","svn_url":"https://github.com/bachya/home-assistant","homepage":"https://home-assistant.io","size":82589,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"home-assistant:dev","ref":"dev","sha":"d7640e6ec3c8c35fba648e29c4895d065158b3c1","user":{"login":"home-assistant","id":13844975,"avatar_url":"https://avatars3.githubusercontent.com/u/13844975?v=4","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"repo":{"id":12888993,"name":"home-assistant","full_name":"home-assistant/home-assistant","owner":{"login":"home-assistant","id":13844975,"avatar_url":"https://avatars3.githubusercontent.com/u/13844975?v=4","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/home-assistant/home-assistant","description":":house_with_garden: Open-source home automation platform running on Python 3","fork":false,"url":"https://api.github.com/repos/home-assistant/home-assistant","forks_url":"https://api.github.com/repos/home-assistant/home-assistant/forks","keys_url":"https://api.github.com/repos/home-assistant/home-assistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/home-assistant/home-assistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/home-assistant/home-assistant/teams","hooks_url":"https://api.github.com/repos/home-assistant/home-assistant/hooks","issue_events_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/events{/number}","events_url":"https://api.github.com/repos/home-assistant/home-assistant/events","assignees_url":"https://api.github.com/repos/home-assistant/home-assistant/assignees{/user}","branches_url":"https://api.github.com/repos/home-assistant/home-assistant/branches{/branch}","tags_url":"https://api.github.com/repos/home-assistant/home-assistant/tags","blobs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/home-assistant/home-assistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/home-assistant/home-assistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/{sha}","languages_url":"https://api.github.com/repos/home-assistant/home-assistant/languages","stargazers_url":"https://api.github.com/repos/home-assistant/home-assistant/stargazers","contributors_url":"https://api.github.com/repos/home-assistant/home-assistant/contributors","subscribers_url":"https://api.github.com/repos/home-assistant/home-assistant/subscribers","subscription_url":"https://api.github.com/repos/home-assistant/home-assistant/subscription","commits_url":"https://api.github.com/repos/home-assistant/home-assistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/home-assistant/home-assistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/home-assistant/home-assistant/contents/{+path}","compare_url":"https://api.github.com/repos/home-assistant/home-assistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/home-assistant/home-assistant/merges","archive_url":"https://api.github.com/repos/home-assistant/home-assistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/home-assistant/home-assistant/downloads","issues_url":"https://api.github.com/repos/home-assistant/home-assistant/issues{/number}","pulls_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls{/number}","milestones_url":"https://api.github.com/repos/home-assistant/home-assistant/milestones{/number}","notifications_url":"https://api.github.com/repos/home-assistant/home-assistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/home-assistant/home-assistant/labels{/name}","releases_url":"https://api.github.com/repos/home-assistant/home-assistant/releases{/id}","deployments_url":"https://api.github.com/repos/home-assistant/home-assistant/deployments","created_at":"2013-09-17T07:29:48Z","updated_at":"2018-05-28T07:06:51Z","pushed_at":"2018-05-28T07:35:31Z","git_url":"git://github.com/home-assistant/home-assistant.git","ssh_url":"git@github.com:home-assistant/home-assistant.git","clone_url":"https://github.com/home-assistant/home-assistant.git","svn_url":"https://github.com/home-assistant/home-assistant","homepage":"https://home-assistant.io","size":82583,"stargazers_count":14470,"watchers_count":14470,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4300,"mirror_url":null,"archived":false,"open_issues_count":842,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":4300,"open_issues":842,"watchers":14470,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/14326"},"html":{"href":"https://github.com/home-assistant/home-assistant/pull/14326"},"issue":{"href":"https://api.github.com/repos/home-assistant/home-assistant/issues/14326"},"comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant/issues/14326/comments"},"review_comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/14326/comments"},"review_comment":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/14326/commits"},"statuses":{"href":"https://api.github.com/repos/home-assistant/home-assistant/statuses/3ba317683aead51063cedd2f793598d04b03bc2d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"MartinHjelmare"}}