{"action":"created","comment":{"url":"https://api.github.com/repos/shinh/maloader/pulls/comments/185413862","pull_request_review_id":116795355,"id":185413862,"diff_hunk":"@@ -1563,3 +1563,14 @@ uint64_t kdebug_trace_string(uint32_t debugid, uint64_t str_id,\n                              const char *str) {\n   return 0;\n }\n+\n+void __darwin__ZNSt3__15mutex4lockEv() {","path":"libmac/mac.c","position":null,"original_position":5,"commit_id":"07b616023ab84cf9d5c447f36ed836d6885f965e","original_commit_id":"07b616023ab84cf9d5c447f36ed836d6885f965e","user":{"login":"shinh","id":29770,"avatar_url":"https://avatars1.githubusercontent.com/u/29770?v=4","gravatar_id":"","url":"https://api.github.com/users/shinh","html_url":"https://github.com/shinh","followers_url":"https://api.github.com/users/shinh/followers","following_url":"https://api.github.com/users/shinh/following{/other_user}","gists_url":"https://api.github.com/users/shinh/gists{/gist_id}","starred_url":"https://api.github.com/users/shinh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shinh/subscriptions","organizations_url":"https://api.github.com/users/shinh/orgs","repos_url":"https://api.github.com/users/shinh/repos","events_url":"https://api.github.com/users/shinh/events{/privacy}","received_events_url":"https://api.github.com/users/shinh/received_events","type":"User","site_admin":false},"body":"Any reason you used inline assembly instead of the first argument? I'm guessing\r\n\r\n```\r\nvoid __darwin__ZNSt3__15mutex4lockEv(struct __darwin_pthread_mutex_t *t) {\r\n  LOGF(\"std::mutex::lock: sig=%lx\", t->sig);\r\n  __darwin_pthread_mutex_lock(t);\r\n}\r\n```\r\n\r\nwould work.","created_at":"2018-05-02T07:38:25Z","updated_at":"2018-05-02T07:38:45Z","html_url":"https://github.com/shinh/maloader/pull/24#discussion_r185413862","pull_request_url":"https://api.github.com/repos/shinh/maloader/pulls/24","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/shinh/maloader/pulls/comments/185413862"},"html":{"href":"https://github.com/shinh/maloader/pull/24#discussion_r185413862"},"pull_request":{"href":"https://api.github.com/repos/shinh/maloader/pulls/24"}}},"pull_request":{"url":"https://api.github.com/repos/shinh/maloader/pulls/24","id":185348095,"html_url":"https://github.com/shinh/maloader/pull/24","diff_url":"https://github.com/shinh/maloader/pull/24.diff","patch_url":"https://github.com/shinh/maloader/pull/24.patch","issue_url":"https://api.github.com/repos/shinh/maloader/issues/24","number":24,"state":"open","locked":false,"title":"Support std::mutex::lock and add several kdebug_trace* functions.","user":{"login":"yoshisatoyanagisawa","id":11488631,"avatar_url":"https://avatars0.githubusercontent.com/u/11488631?v=4","gravatar_id":"","url":"https://api.github.com/users/yoshisatoyanagisawa","html_url":"https://github.com/yoshisatoyanagisawa","followers_url":"https://api.github.com/users/yoshisatoyanagisawa/followers","following_url":"https://api.github.com/users/yoshisatoyanagisawa/following{/other_user}","gists_url":"https://api.github.com/users/yoshisatoyanagisawa/gists{/gist_id}","starred_url":"https://api.github.com/users/yoshisatoyanagisawa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yoshisatoyanagisawa/subscriptions","organizations_url":"https://api.github.com/users/yoshisatoyanagisawa/orgs","repos_url":"https://api.github.com/users/yoshisatoyanagisawa/repos","events_url":"https://api.github.com/users/yoshisatoyanagisawa/events{/privacy}","received_events_url":"https://api.github.com/users/yoshisatoyanagisawa/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-05-02T06:42:48Z","updated_at":"2018-05-02T07:38:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"591732bc87c6a1d4cafec99682dce10897d7b285","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/shinh/maloader/pulls/24/commits","review_comments_url":"https://api.github.com/repos/shinh/maloader/pulls/24/comments","review_comment_url":"https://api.github.com/repos/shinh/maloader/pulls/comments{/number}","comments_url":"https://api.github.com/repos/shinh/maloader/issues/24/comments","statuses_url":"https://api.github.com/repos/shinh/maloader/statuses/07b616023ab84cf9d5c447f36ed836d6885f965e","head":{"label":"yoshisatoyanagisawa:mutexlock","ref":"mutexlock","sha":"07b616023ab84cf9d5c447f36ed836d6885f965e","user":{"login":"yoshisatoyanagisawa","id":11488631,"avatar_url":"https://avatars0.githubusercontent.com/u/11488631?v=4","gravatar_id":"","url":"https://api.github.com/users/yoshisatoyanagisawa","html_url":"https://github.com/yoshisatoyanagisawa","followers_url":"https://api.github.com/users/yoshisatoyanagisawa/followers","following_url":"https://api.github.com/users/yoshisatoyanagisawa/following{/other_user}","gists_url":"https://api.github.com/users/yoshisatoyanagisawa/gists{/gist_id}","starred_url":"https://api.github.com/users/yoshisatoyanagisawa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yoshisatoyanagisawa/subscriptions","organizations_url":"https://api.github.com/users/yoshisatoyanagisawa/orgs","repos_url":"https://api.github.com/users/yoshisatoyanagisawa/repos","events_url":"https://api.github.com/users/yoshisatoyanagisawa/events{/privacy}","received_events_url":"https://api.github.com/users/yoshisatoyanagisawa/received_events","type":"User","site_admin":false},"repo":{"id":92371946,"name":"maloader","full_name":"yoshisatoyanagisawa/maloader","owner":{"login":"yoshisatoyanagisawa","id":11488631,"avatar_url":"https://avatars0.githubusercontent.com/u/11488631?v=4","gravatar_id":"","url":"https://api.github.com/users/yoshisatoyanagisawa","html_url":"https://github.com/yoshisatoyanagisawa","followers_url":"https://api.github.com/users/yoshisatoyanagisawa/followers","following_url":"https://api.github.com/users/yoshisatoyanagisawa/following{/other_user}","gists_url":"https://api.github.com/users/yoshisatoyanagisawa/gists{/gist_id}","starred_url":"https://api.github.com/users/yoshisatoyanagisawa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yoshisatoyanagisawa/subscriptions","organizations_url":"https://api.github.com/users/yoshisatoyanagisawa/orgs","repos_url":"https://api.github.com/users/yoshisatoyanagisawa/repos","events_url":"https://api.github.com/users/yoshisatoyanagisawa/events{/privacy}","received_events_url":"https://api.github.com/users/yoshisatoyanagisawa/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yoshisatoyanagisawa/maloader","description":"mach-o loader for linux","fork":true,"url":"https://api.github.com/repos/yoshisatoyanagisawa/maloader","forks_url":"https://api.github.com/repos/yoshisatoyanagisawa/maloader/forks","keys_url":"https://api.github.com/repos/yoshisatoyanagisawa/maloader/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yoshisatoyanagisawa/maloader/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yoshisatoyanagisawa/maloader/teams","hooks_url":"https://api.github.com/repos/yoshisatoyanagisawa/maloader/hooks","issue_events_url":"https://api.github.com/repos/yoshisatoyanagisawa/maloader/issues/events{/number}","events_url":"https://api.github.com/repos/yoshisatoyanagisawa/maloader/events","assignees_url":"https://api.github.com/repos/yoshisatoyanagisawa/maloader/assignees{/user}","branches_url":"https://api.github.com/repos/yoshisatoyanagisawa/maloader/branches{/branch}","tags_url":"https://api.github.com/repos/yoshisatoyanagisawa/maloader/tags","blobs_url":"https://api.github.com/repos/yoshisatoyanagisawa/maloader/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yoshisatoyanagisawa/maloader/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yoshisatoyanagisawa/maloader/git/refs{/sha}","trees_url":"https://api.github.com/repos/yoshisatoyanagisawa/maloader/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yoshisatoyanagisawa/maloader/statuses/{sha}","languages_url":"https://api.github.com/repos/yoshisatoyanagisawa/maloader/languages","stargazers_url":"https://api.github.com/repos/yoshisatoyanagisawa/maloader/stargazers","contributors_url":"https://api.github.com/repos/yoshisatoyanagisawa/maloader/contributors","subscribers_url":"https://api.github.com/repos/yoshisatoyanagisawa/maloader/subscribers","subscription_url":"https://api.github.com/repos/yoshisatoyanagisawa/maloader/subscription","commits_url":"https://api.github.com/repos/yoshisatoyanagisawa/maloader/commits{/sha}","git_commits_url":"https://api.github.com/repos/yoshisatoyanagisawa/maloader/git/commits{/sha}","comments_url":"https://api.github.com/repos/yoshisatoyanagisawa/maloader/comments{/number}","issue_comment_url":"https://api.github.com/repos/yoshisatoyanagisawa/maloader/issues/comments{/number}","contents_url":"https://api.github.com/repos/yoshisatoyanagisawa/maloader/contents/{+path}","compare_url":"https://api.github.com/repos/yoshisatoyanagisawa/maloader/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yoshisatoyanagisawa/maloader/merges","archive_url":"https://api.github.com/repos/yoshisatoyanagisawa/maloader/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yoshisatoyanagisawa/maloader/downloads","issues_url":"https://api.github.com/repos/yoshisatoyanagisawa/maloader/issues{/number}","pulls_url":"https://api.github.com/repos/yoshisatoyanagisawa/maloader/pulls{/number}","milestones_url":"https://api.github.com/repos/yoshisatoyanagisawa/maloader/milestones{/number}","notifications_url":"https://api.github.com/repos/yoshisatoyanagisawa/maloader/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yoshisatoyanagisawa/maloader/labels{/name}","releases_url":"https://api.github.com/repos/yoshisatoyanagisawa/maloader/releases{/id}","deployments_url":"https://api.github.com/repos/yoshisatoyanagisawa/maloader/deployments","created_at":"2017-05-25T06:22:52Z","updated_at":"2018-05-02T06:35:39Z","pushed_at":"2018-05-02T06:41:55Z","git_url":"git://github.com/yoshisatoyanagisawa/maloader.git","ssh_url":"git@github.com:yoshisatoyanagisawa/maloader.git","clone_url":"https://github.com/yoshisatoyanagisawa/maloader.git","svn_url":"https://github.com/yoshisatoyanagisawa/maloader","homepage":"","size":363,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"shinh:master","ref":"master","sha":"bdff0a61952c13d88a474986cabce2304e6b8e61","user":{"login":"shinh","id":29770,"avatar_url":"https://avatars1.githubusercontent.com/u/29770?v=4","gravatar_id":"","url":"https://api.github.com/users/shinh","html_url":"https://github.com/shinh","followers_url":"https://api.github.com/users/shinh/followers","following_url":"https://api.github.com/users/shinh/following{/other_user}","gists_url":"https://api.github.com/users/shinh/gists{/gist_id}","starred_url":"https://api.github.com/users/shinh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shinh/subscriptions","organizations_url":"https://api.github.com/users/shinh/orgs","repos_url":"https://api.github.com/users/shinh/repos","events_url":"https://api.github.com/users/shinh/events{/privacy}","received_events_url":"https://api.github.com/users/shinh/received_events","type":"User","site_admin":false},"repo":{"id":1459463,"name":"maloader","full_name":"shinh/maloader","owner":{"login":"shinh","id":29770,"avatar_url":"https://avatars1.githubusercontent.com/u/29770?v=4","gravatar_id":"","url":"https://api.github.com/users/shinh","html_url":"https://github.com/shinh","followers_url":"https://api.github.com/users/shinh/followers","following_url":"https://api.github.com/users/shinh/following{/other_user}","gists_url":"https://api.github.com/users/shinh/gists{/gist_id}","starred_url":"https://api.github.com/users/shinh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shinh/subscriptions","organizations_url":"https://api.github.com/users/shinh/orgs","repos_url":"https://api.github.com/users/shinh/repos","events_url":"https://api.github.com/users/shinh/events{/privacy}","received_events_url":"https://api.github.com/users/shinh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shinh/maloader","description":"mach-o loader for linux","fork":false,"url":"https://api.github.com/repos/shinh/maloader","forks_url":"https://api.github.com/repos/shinh/maloader/forks","keys_url":"https://api.github.com/repos/shinh/maloader/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shinh/maloader/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shinh/maloader/teams","hooks_url":"https://api.github.com/repos/shinh/maloader/hooks","issue_events_url":"https://api.github.com/repos/shinh/maloader/issues/events{/number}","events_url":"https://api.github.com/repos/shinh/maloader/events","assignees_url":"https://api.github.com/repos/shinh/maloader/assignees{/user}","branches_url":"https://api.github.com/repos/shinh/maloader/branches{/branch}","tags_url":"https://api.github.com/repos/shinh/maloader/tags","blobs_url":"https://api.github.com/repos/shinh/maloader/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shinh/maloader/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shinh/maloader/git/refs{/sha}","trees_url":"https://api.github.com/repos/shinh/maloader/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shinh/maloader/statuses/{sha}","languages_url":"https://api.github.com/repos/shinh/maloader/languages","stargazers_url":"https://api.github.com/repos/shinh/maloader/stargazers","contributors_url":"https://api.github.com/repos/shinh/maloader/contributors","subscribers_url":"https://api.github.com/repos/shinh/maloader/subscribers","subscription_url":"https://api.github.com/repos/shinh/maloader/subscription","commits_url":"https://api.github.com/repos/shinh/maloader/commits{/sha}","git_commits_url":"https://api.github.com/repos/shinh/maloader/git/commits{/sha}","comments_url":"https://api.github.com/repos/shinh/maloader/comments{/number}","issue_comment_url":"https://api.github.com/repos/shinh/maloader/issues/comments{/number}","contents_url":"https://api.github.com/repos/shinh/maloader/contents/{+path}","compare_url":"https://api.github.com/repos/shinh/maloader/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shinh/maloader/merges","archive_url":"https://api.github.com/repos/shinh/maloader/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shinh/maloader/downloads","issues_url":"https://api.github.com/repos/shinh/maloader/issues{/number}","pulls_url":"https://api.github.com/repos/shinh/maloader/pulls{/number}","milestones_url":"https://api.github.com/repos/shinh/maloader/milestones{/number}","notifications_url":"https://api.github.com/repos/shinh/maloader/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shinh/maloader/labels{/name}","releases_url":"https://api.github.com/repos/shinh/maloader/releases{/id}","deployments_url":"https://api.github.com/repos/shinh/maloader/deployments","created_at":"2011-03-09T15:16:20Z","updated_at":"2018-04-23T15:37:23Z","pushed_at":"2018-05-02T06:42:49Z","git_url":"git://github.com/shinh/maloader.git","ssh_url":"git@github.com:shinh/maloader.git","clone_url":"https://github.com/shinh/maloader.git","svn_url":"https://github.com/shinh/maloader","homepage":"","size":358,"stargazers_count":394,"watchers_count":394,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":38,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":38,"open_issues":6,"watchers":394,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/shinh/maloader/pulls/24"},"html":{"href":"https://github.com/shinh/maloader/pull/24"},"issue":{"href":"https://api.github.com/repos/shinh/maloader/issues/24"},"comments":{"href":"https://api.github.com/repos/shinh/maloader/issues/24/comments"},"review_comments":{"href":"https://api.github.com/repos/shinh/maloader/pulls/24/comments"},"review_comment":{"href":"https://api.github.com/repos/shinh/maloader/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/shinh/maloader/pulls/24/commits"},"statuses":{"href":"https://api.github.com/repos/shinh/maloader/statuses/07b616023ab84cf9d5c447f36ed836d6885f965e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"shinh"}}