{"action":"created","comment":{"url":"https://api.github.com/repos/badges/shields/pulls/comments/245021824","pull_request_review_id":189039716,"id":245021824,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NTAyMTgyNA==","diff_hunk":"@@ -189,11 +190,15 @@ module.exports = class SymfonyInsight extends BaseXmlService {\n       },\n     }\n \n-    if (serverSecrets && serverSecrets.sl_insight_userUuid) {\n-      options.auth = {\n-        user: serverSecrets.sl_insight_userUuid,\n-        pass: serverSecrets.sl_insight_apiToken,\n-      }\n+    if (!serverSecrets.sl_insight_userUuid) {","path":"services/symfony/symfony-insight.service.js","position":193,"original_position":17,"commit_id":"0210cb0e91984cd8b152153b3272febc748866fe","original_commit_id":"d36fd22de7189572709b9f41f89e3f03eebd7443","user":{"login":"paulmelnikow","id":1487036,"node_id":"MDQ6VXNlcjE0ODcwMzY=","avatar_url":"https://avatars2.githubusercontent.com/u/1487036?v=4","gravatar_id":"","url":"https://api.github.com/users/paulmelnikow","html_url":"https://github.com/paulmelnikow","followers_url":"https://api.github.com/users/paulmelnikow/followers","following_url":"https://api.github.com/users/paulmelnikow/following{/other_user}","gists_url":"https://api.github.com/users/paulmelnikow/gists{/gist_id}","starred_url":"https://api.github.com/users/paulmelnikow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulmelnikow/subscriptions","organizations_url":"https://api.github.com/users/paulmelnikow/orgs","repos_url":"https://api.github.com/users/paulmelnikow/repos","events_url":"https://api.github.com/users/paulmelnikow/events{/privacy}","received_events_url":"https://api.github.com/users/paulmelnikow/received_events","type":"User","site_admin":false},"body":"Could you check both keys instead of just the one?","created_at":"2019-01-03T14:50:16Z","updated_at":"2019-01-03T14:50:17Z","html_url":"https://github.com/badges/shields/pull/2572#discussion_r245021824","pull_request_url":"https://api.github.com/repos/badges/shields/pulls/2572","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/badges/shields/pulls/comments/245021824"},"html":{"href":"https://github.com/badges/shields/pull/2572#discussion_r245021824"},"pull_request":{"href":"https://api.github.com/repos/badges/shields/pulls/2572"}}},"pull_request":{"url":"https://api.github.com/repos/badges/shields/pulls/2572","id":240386910,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwMzg2OTEw","html_url":"https://github.com/badges/shields/pull/2572","diff_url":"https://github.com/badges/shields/pull/2572.diff","patch_url":"https://github.com/badges/shields/pull/2572.patch","issue_url":"https://api.github.com/repos/badges/shields/issues/2572","number":2572,"state":"open","locked":false,"title":"Refactor [SymfonyInsight] to new service model and rename","user":{"login":"calebcartwright","id":13042488,"node_id":"MDQ6VXNlcjEzMDQyNDg4","avatar_url":"https://avatars0.githubusercontent.com/u/13042488?v=4","gravatar_id":"","url":"https://api.github.com/users/calebcartwright","html_url":"https://github.com/calebcartwright","followers_url":"https://api.github.com/users/calebcartwright/followers","following_url":"https://api.github.com/users/calebcartwright/following{/other_user}","gists_url":"https://api.github.com/users/calebcartwright/gists{/gist_id}","starred_url":"https://api.github.com/users/calebcartwright/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calebcartwright/subscriptions","organizations_url":"https://api.github.com/users/calebcartwright/orgs","repos_url":"https://api.github.com/users/calebcartwright/repos","events_url":"https://api.github.com/users/calebcartwright/events{/privacy}","received_events_url":"https://api.github.com/users/calebcartwright/received_events","type":"User","site_admin":false},"body":"Based on some discussion/feedback here, this PR now contains several changes:\r\n\r\n* Renames the `Sensiolabs` badge/service content to `SymfonyInsight` to reflect the rebranding of that product/service\r\n* Refactors the original service to the new service model (using `BaseXmlService`)\r\n* Updates the color scheme of the original/initial badge type (SymfonyInsight Grade) to more closely mirror the colors used by the vendor/service provider\r\n* Adds a new badge type (violation counts/summary) \r\n* Adds both mocked and live tests (there were none before) for both the grade & violation badges using the new path `symfony/i` as well as a couple tests for the old path `sensiolabs/i` to check for backwards compatibility\r\n\r\nRefs #1358 \r\n","created_at":"2018-12-21T06:50:31Z","updated_at":"2019-01-03T14:50:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2908bd75e155c7b127af90d2725c9088f72e445a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":316395868,"node_id":"MDU6TGFiZWwzMTYzOTU4Njg=","url":"https://api.github.com/repos/badges/shields/labels/service-badge","name":"service-badge","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/badges/shields/pulls/2572/commits","review_comments_url":"https://api.github.com/repos/badges/shields/pulls/2572/comments","review_comment_url":"https://api.github.com/repos/badges/shields/pulls/comments{/number}","comments_url":"https://api.github.com/repos/badges/shields/issues/2572/comments","statuses_url":"https://api.github.com/repos/badges/shields/statuses/0210cb0e91984cd8b152153b3272febc748866fe","head":{"label":"badges:sensiolabs-refactor","ref":"sensiolabs-refactor","sha":"0210cb0e91984cd8b152153b3272febc748866fe","user":{"login":"badges","id":6254238,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTQyMzg=","avatar_url":"https://avatars2.githubusercontent.com/u/6254238?v=4","gravatar_id":"","url":"https://api.github.com/users/badges","html_url":"https://github.com/badges","followers_url":"https://api.github.com/users/badges/followers","following_url":"https://api.github.com/users/badges/following{/other_user}","gists_url":"https://api.github.com/users/badges/gists{/gist_id}","starred_url":"https://api.github.com/users/badges/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/badges/subscriptions","organizations_url":"https://api.github.com/users/badges/orgs","repos_url":"https://api.github.com/users/badges/repos","events_url":"https://api.github.com/users/badges/events{/privacy}","received_events_url":"https://api.github.com/users/badges/received_events","type":"Organization","site_admin":false},"repo":{"id":7910045,"node_id":"MDEwOlJlcG9zaXRvcnk3OTEwMDQ1","name":"shields","full_name":"badges/shields","private":false,"owner":{"login":"badges","id":6254238,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTQyMzg=","avatar_url":"https://avatars2.githubusercontent.com/u/6254238?v=4","gravatar_id":"","url":"https://api.github.com/users/badges","html_url":"https://github.com/badges","followers_url":"https://api.github.com/users/badges/followers","following_url":"https://api.github.com/users/badges/following{/other_user}","gists_url":"https://api.github.com/users/badges/gists{/gist_id}","starred_url":"https://api.github.com/users/badges/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/badges/subscriptions","organizations_url":"https://api.github.com/users/badges/orgs","repos_url":"https://api.github.com/users/badges/repos","events_url":"https://api.github.com/users/badges/events{/privacy}","received_events_url":"https://api.github.com/users/badges/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/badges/shields","description":"Concise, consistent, and legible badges in SVG and raster format","fork":false,"url":"https://api.github.com/repos/badges/shields","forks_url":"https://api.github.com/repos/badges/shields/forks","keys_url":"https://api.github.com/repos/badges/shields/keys{/key_id}","collaborators_url":"https://api.github.com/repos/badges/shields/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/badges/shields/teams","hooks_url":"https://api.github.com/repos/badges/shields/hooks","issue_events_url":"https://api.github.com/repos/badges/shields/issues/events{/number}","events_url":"https://api.github.com/repos/badges/shields/events","assignees_url":"https://api.github.com/repos/badges/shields/assignees{/user}","branches_url":"https://api.github.com/repos/badges/shields/branches{/branch}","tags_url":"https://api.github.com/repos/badges/shields/tags","blobs_url":"https://api.github.com/repos/badges/shields/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/badges/shields/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/badges/shields/git/refs{/sha}","trees_url":"https://api.github.com/repos/badges/shields/git/trees{/sha}","statuses_url":"https://api.github.com/repos/badges/shields/statuses/{sha}","languages_url":"https://api.github.com/repos/badges/shields/languages","stargazers_url":"https://api.github.com/repos/badges/shields/stargazers","contributors_url":"https://api.github.com/repos/badges/shields/contributors","subscribers_url":"https://api.github.com/repos/badges/shields/subscribers","subscription_url":"https://api.github.com/repos/badges/shields/subscription","commits_url":"https://api.github.com/repos/badges/shields/commits{/sha}","git_commits_url":"https://api.github.com/repos/badges/shields/git/commits{/sha}","comments_url":"https://api.github.com/repos/badges/shields/comments{/number}","issue_comment_url":"https://api.github.com/repos/badges/shields/issues/comments{/number}","contents_url":"https://api.github.com/repos/badges/shields/contents/{+path}","compare_url":"https://api.github.com/repos/badges/shields/compare/{base}...{head}","merges_url":"https://api.github.com/repos/badges/shields/merges","archive_url":"https://api.github.com/repos/badges/shields/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/badges/shields/downloads","issues_url":"https://api.github.com/repos/badges/shields/issues{/number}","pulls_url":"https://api.github.com/repos/badges/shields/pulls{/number}","milestones_url":"https://api.github.com/repos/badges/shields/milestones{/number}","notifications_url":"https://api.github.com/repos/badges/shields/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/badges/shields/labels{/name}","releases_url":"https://api.github.com/repos/badges/shields/releases{/id}","deployments_url":"https://api.github.com/repos/badges/shields/deployments","created_at":"2013-01-30T07:41:54Z","updated_at":"2019-01-03T14:06:52Z","pushed_at":"2019-01-03T14:12:15Z","git_url":"git://github.com/badges/shields.git","ssh_url":"git@github.com:badges/shields.git","clone_url":"https://github.com/badges/shields.git","svn_url":"https://github.com/badges/shields","homepage":"https://shields.io","size":17588,"stargazers_count":6917,"watchers_count":6917,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1615,"mirror_url":null,"archived":false,"open_issues_count":196,"license":{"key":"cc0-1.0","name":"Creative Commons Zero v1.0 Universal","spdx_id":"CC0-1.0","url":"https://api.github.com/licenses/cc0-1.0","node_id":"MDc6TGljZW5zZTY="},"forks":1615,"open_issues":196,"watchers":6917,"default_branch":"master"}},"base":{"label":"badges:master","ref":"master","sha":"d96d8ae193213ff6f6166071fde1a0638bed2633","user":{"login":"badges","id":6254238,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTQyMzg=","avatar_url":"https://avatars2.githubusercontent.com/u/6254238?v=4","gravatar_id":"","url":"https://api.github.com/users/badges","html_url":"https://github.com/badges","followers_url":"https://api.github.com/users/badges/followers","following_url":"https://api.github.com/users/badges/following{/other_user}","gists_url":"https://api.github.com/users/badges/gists{/gist_id}","starred_url":"https://api.github.com/users/badges/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/badges/subscriptions","organizations_url":"https://api.github.com/users/badges/orgs","repos_url":"https://api.github.com/users/badges/repos","events_url":"https://api.github.com/users/badges/events{/privacy}","received_events_url":"https://api.github.com/users/badges/received_events","type":"Organization","site_admin":false},"repo":{"id":7910045,"node_id":"MDEwOlJlcG9zaXRvcnk3OTEwMDQ1","name":"shields","full_name":"badges/shields","private":false,"owner":{"login":"badges","id":6254238,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTQyMzg=","avatar_url":"https://avatars2.githubusercontent.com/u/6254238?v=4","gravatar_id":"","url":"https://api.github.com/users/badges","html_url":"https://github.com/badges","followers_url":"https://api.github.com/users/badges/followers","following_url":"https://api.github.com/users/badges/following{/other_user}","gists_url":"https://api.github.com/users/badges/gists{/gist_id}","starred_url":"https://api.github.com/users/badges/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/badges/subscriptions","organizations_url":"https://api.github.com/users/badges/orgs","repos_url":"https://api.github.com/users/badges/repos","events_url":"https://api.github.com/users/badges/events{/privacy}","received_events_url":"https://api.github.com/users/badges/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/badges/shields","description":"Concise, consistent, and legible badges in SVG and raster format","fork":false,"url":"https://api.github.com/repos/badges/shields","forks_url":"https://api.github.com/repos/badges/shields/forks","keys_url":"https://api.github.com/repos/badges/shields/keys{/key_id}","collaborators_url":"https://api.github.com/repos/badges/shields/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/badges/shields/teams","hooks_url":"https://api.github.com/repos/badges/shields/hooks","issue_events_url":"https://api.github.com/repos/badges/shields/issues/events{/number}","events_url":"https://api.github.com/repos/badges/shields/events","assignees_url":"https://api.github.com/repos/badges/shields/assignees{/user}","branches_url":"https://api.github.com/repos/badges/shields/branches{/branch}","tags_url":"https://api.github.com/repos/badges/shields/tags","blobs_url":"https://api.github.com/repos/badges/shields/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/badges/shields/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/badges/shields/git/refs{/sha}","trees_url":"https://api.github.com/repos/badges/shields/git/trees{/sha}","statuses_url":"https://api.github.com/repos/badges/shields/statuses/{sha}","languages_url":"https://api.github.com/repos/badges/shields/languages","stargazers_url":"https://api.github.com/repos/badges/shields/stargazers","contributors_url":"https://api.github.com/repos/badges/shields/contributors","subscribers_url":"https://api.github.com/repos/badges/shields/subscribers","subscription_url":"https://api.github.com/repos/badges/shields/subscription","commits_url":"https://api.github.com/repos/badges/shields/commits{/sha}","git_commits_url":"https://api.github.com/repos/badges/shields/git/commits{/sha}","comments_url":"https://api.github.com/repos/badges/shields/comments{/number}","issue_comment_url":"https://api.github.com/repos/badges/shields/issues/comments{/number}","contents_url":"https://api.github.com/repos/badges/shields/contents/{+path}","compare_url":"https://api.github.com/repos/badges/shields/compare/{base}...{head}","merges_url":"https://api.github.com/repos/badges/shields/merges","archive_url":"https://api.github.com/repos/badges/shields/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/badges/shields/downloads","issues_url":"https://api.github.com/repos/badges/shields/issues{/number}","pulls_url":"https://api.github.com/repos/badges/shields/pulls{/number}","milestones_url":"https://api.github.com/repos/badges/shields/milestones{/number}","notifications_url":"https://api.github.com/repos/badges/shields/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/badges/shields/labels{/name}","releases_url":"https://api.github.com/repos/badges/shields/releases{/id}","deployments_url":"https://api.github.com/repos/badges/shields/deployments","created_at":"2013-01-30T07:41:54Z","updated_at":"2019-01-03T14:06:52Z","pushed_at":"2019-01-03T14:12:15Z","git_url":"git://github.com/badges/shields.git","ssh_url":"git@github.com:badges/shields.git","clone_url":"https://github.com/badges/shields.git","svn_url":"https://github.com/badges/shields","homepage":"https://shields.io","size":17588,"stargazers_count":6917,"watchers_count":6917,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1615,"mirror_url":null,"archived":false,"open_issues_count":196,"license":{"key":"cc0-1.0","name":"Creative Commons Zero v1.0 Universal","spdx_id":"CC0-1.0","url":"https://api.github.com/licenses/cc0-1.0","node_id":"MDc6TGljZW5zZTY="},"forks":1615,"open_issues":196,"watchers":6917,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/badges/shields/pulls/2572"},"html":{"href":"https://github.com/badges/shields/pull/2572"},"issue":{"href":"https://api.github.com/repos/badges/shields/issues/2572"},"comments":{"href":"https://api.github.com/repos/badges/shields/issues/2572/comments"},"review_comments":{"href":"https://api.github.com/repos/badges/shields/pulls/2572/comments"},"review_comment":{"href":"https://api.github.com/repos/badges/shields/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/badges/shields/pulls/2572/commits"},"statuses":{"href":"https://api.github.com/repos/badges/shields/statuses/0210cb0e91984cd8b152153b3272febc748866fe"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"paulmelnikow"}}