{"action":"closed","number":15,"pull_request":{"url":"https://api.github.com/repos/PlusToolkit/ndicapi/pulls/15","id":172165991,"html_url":"https://github.com/PlusToolkit/ndicapi/pull/15","diff_url":"https://github.com/PlusToolkit/ndicapi/pull/15.diff","patch_url":"https://github.com/PlusToolkit/ndicapi/pull/15.patch","issue_url":"https://api.github.com/repos/PlusToolkit/ndicapi/issues/15","number":15,"state":"closed","locked":false,"title":"C extension module supports Python 3","user":{"login":"dzhoshkun","id":9197424,"avatar_url":"https://avatars2.githubusercontent.com/u/9197424?v=4","gravatar_id":"","url":"https://api.github.com/users/dzhoshkun","html_url":"https://github.com/dzhoshkun","followers_url":"https://api.github.com/users/dzhoshkun/followers","following_url":"https://api.github.com/users/dzhoshkun/following{/other_user}","gists_url":"https://api.github.com/users/dzhoshkun/gists{/gist_id}","starred_url":"https://api.github.com/users/dzhoshkun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dzhoshkun/subscriptions","organizations_url":"https://api.github.com/users/dzhoshkun/orgs","repos_url":"https://api.github.com/users/dzhoshkun/repos","events_url":"https://api.github.com/users/dzhoshkun/events{/privacy}","received_events_url":"https://api.github.com/users/dzhoshkun/received_events","type":"User","site_admin":false},"body":"@adamrankin Apologies for all the confusion I've induced by submitting three PRs about the same thing in a span of just a few days.\r\nAnd I don't know why GitHub still shows so many to-be-merged commits (77!) while there are only 34 or so.\r\n\r\nIn any case, this PR merges the changes introduced as part of dzhoshkun/ndicapi#14.\r\nThe ndicapi Python extension module can now be built and run with Python 3.\r\n\r\nReplicating some of the information from dzhoshkun/ndicapi#14 below for clarity.\r\n\r\n---\r\n\r\nThe C extension module has been refactored with C macros that enable conditional compilation based on the Python version.\r\nThe changes have been tested with both Python versions on:\r\n- Ubuntu 16.04.3 LTS 64-bit (Python 2.7.12 and 3.5.2)\r\n- macOS Sierra 10.12.6 (Python 2.7.14 and 3.6.3)\r\n\r\nOther notable changes this PR introduces:\r\n\r\n* The building and installation of the Python extension module has been decoupled from the building of the C++ library.\r\n   - The CMake configuration now merely generates the `setup.py` file.\r\n   - Also the installation instructions now only include a `pip install`. This is a cleaner way to install the extension module, as it takes care of removing all components (including the installed dynamic library file, i.e. `ndicapy.so` on Linux) when `pip install ndicapi` is called.\r\n* The CMake build option `BUILD_SHARED_LIBS` is now `ON` by default (the Python extension module requires a shared library).\r\n* The Python extension module has been renamed from `pyndicapi` to `ndicapy` as the latter is shorter and more Pythonic.","created_at":"2018-03-01T07:57:23Z","updated_at":"2018-03-01T14:55:26Z","closed_at":"2018-03-01T14:55:26Z","merged_at":"2018-03-01T14:55:26Z","merge_commit_sha":"b12a03af1cfa1a5f0745551f5538b88ad4917c12","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/PlusToolkit/ndicapi/pulls/15/commits","review_comments_url":"https://api.github.com/repos/PlusToolkit/ndicapi/pulls/15/comments","review_comment_url":"https://api.github.com/repos/PlusToolkit/ndicapi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PlusToolkit/ndicapi/issues/15/comments","statuses_url":"https://api.github.com/repos/PlusToolkit/ndicapi/statuses/5722114cc385b588511850e72334e30c53328362","head":{"label":"dzhoshkun:master","ref":"master","sha":"5722114cc385b588511850e72334e30c53328362","user":{"login":"dzhoshkun","id":9197424,"avatar_url":"https://avatars2.githubusercontent.com/u/9197424?v=4","gravatar_id":"","url":"https://api.github.com/users/dzhoshkun","html_url":"https://github.com/dzhoshkun","followers_url":"https://api.github.com/users/dzhoshkun/followers","following_url":"https://api.github.com/users/dzhoshkun/following{/other_user}","gists_url":"https://api.github.com/users/dzhoshkun/gists{/gist_id}","starred_url":"https://api.github.com/users/dzhoshkun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dzhoshkun/subscriptions","organizations_url":"https://api.github.com/users/dzhoshkun/orgs","repos_url":"https://api.github.com/users/dzhoshkun/repos","events_url":"https://api.github.com/users/dzhoshkun/events{/privacy}","received_events_url":"https://api.github.com/users/dzhoshkun/received_events","type":"User","site_admin":false},"repo":{"id":119688180,"name":"ndicapi","full_name":"dzhoshkun/ndicapi","owner":{"login":"dzhoshkun","id":9197424,"avatar_url":"https://avatars2.githubusercontent.com/u/9197424?v=4","gravatar_id":"","url":"https://api.github.com/users/dzhoshkun","html_url":"https://github.com/dzhoshkun","followers_url":"https://api.github.com/users/dzhoshkun/followers","following_url":"https://api.github.com/users/dzhoshkun/following{/other_user}","gists_url":"https://api.github.com/users/dzhoshkun/gists{/gist_id}","starred_url":"https://api.github.com/users/dzhoshkun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dzhoshkun/subscriptions","organizations_url":"https://api.github.com/users/dzhoshkun/orgs","repos_url":"https://api.github.com/users/dzhoshkun/repos","events_url":"https://api.github.com/users/dzhoshkun/events{/privacy}","received_events_url":"https://api.github.com/users/dzhoshkun/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dzhoshkun/ndicapi","description":"A common C API for communicating with NDI Polaris and Aurora devices","fork":true,"url":"https://api.github.com/repos/dzhoshkun/ndicapi","forks_url":"https://api.github.com/repos/dzhoshkun/ndicapi/forks","keys_url":"https://api.github.com/repos/dzhoshkun/ndicapi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dzhoshkun/ndicapi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dzhoshkun/ndicapi/teams","hooks_url":"https://api.github.com/repos/dzhoshkun/ndicapi/hooks","issue_events_url":"https://api.github.com/repos/dzhoshkun/ndicapi/issues/events{/number}","events_url":"https://api.github.com/repos/dzhoshkun/ndicapi/events","assignees_url":"https://api.github.com/repos/dzhoshkun/ndicapi/assignees{/user}","branches_url":"https://api.github.com/repos/dzhoshkun/ndicapi/branches{/branch}","tags_url":"https://api.github.com/repos/dzhoshkun/ndicapi/tags","blobs_url":"https://api.github.com/repos/dzhoshkun/ndicapi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dzhoshkun/ndicapi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dzhoshkun/ndicapi/git/refs{/sha}","trees_url":"https://api.github.com/repos/dzhoshkun/ndicapi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dzhoshkun/ndicapi/statuses/{sha}","languages_url":"https://api.github.com/repos/dzhoshkun/ndicapi/languages","stargazers_url":"https://api.github.com/repos/dzhoshkun/ndicapi/stargazers","contributors_url":"https://api.github.com/repos/dzhoshkun/ndicapi/contributors","subscribers_url":"https://api.github.com/repos/dzhoshkun/ndicapi/subscribers","subscription_url":"https://api.github.com/repos/dzhoshkun/ndicapi/subscription","commits_url":"https://api.github.com/repos/dzhoshkun/ndicapi/commits{/sha}","git_commits_url":"https://api.github.com/repos/dzhoshkun/ndicapi/git/commits{/sha}","comments_url":"https://api.github.com/repos/dzhoshkun/ndicapi/comments{/number}","issue_comment_url":"https://api.github.com/repos/dzhoshkun/ndicapi/issues/comments{/number}","contents_url":"https://api.github.com/repos/dzhoshkun/ndicapi/contents/{+path}","compare_url":"https://api.github.com/repos/dzhoshkun/ndicapi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dzhoshkun/ndicapi/merges","archive_url":"https://api.github.com/repos/dzhoshkun/ndicapi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dzhoshkun/ndicapi/downloads","issues_url":"https://api.github.com/repos/dzhoshkun/ndicapi/issues{/number}","pulls_url":"https://api.github.com/repos/dzhoshkun/ndicapi/pulls{/number}","milestones_url":"https://api.github.com/repos/dzhoshkun/ndicapi/milestones{/number}","notifications_url":"https://api.github.com/repos/dzhoshkun/ndicapi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dzhoshkun/ndicapi/labels{/name}","releases_url":"https://api.github.com/repos/dzhoshkun/ndicapi/releases{/id}","deployments_url":"https://api.github.com/repos/dzhoshkun/ndicapi/deployments","created_at":"2018-01-31T13:06:24Z","updated_at":"2018-02-15T12:05:55Z","pushed_at":"2018-03-01T07:44:20Z","git_url":"git://github.com/dzhoshkun/ndicapi.git","ssh_url":"git@github.com:dzhoshkun/ndicapi.git","clone_url":"https://github.com/dzhoshkun/ndicapi.git","svn_url":"https://github.com/dzhoshkun/ndicapi","homepage":null,"size":322,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"PlusToolkit:master","ref":"master","sha":"f128701e8cc2039354279f22ffbeb8166e55cb72","user":{"login":"PlusToolkit","id":16928228,"avatar_url":"https://avatars2.githubusercontent.com/u/16928228?v=4","gravatar_id":"","url":"https://api.github.com/users/PlusToolkit","html_url":"https://github.com/PlusToolkit","followers_url":"https://api.github.com/users/PlusToolkit/followers","following_url":"https://api.github.com/users/PlusToolkit/following{/other_user}","gists_url":"https://api.github.com/users/PlusToolkit/gists{/gist_id}","starred_url":"https://api.github.com/users/PlusToolkit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PlusToolkit/subscriptions","organizations_url":"https://api.github.com/users/PlusToolkit/orgs","repos_url":"https://api.github.com/users/PlusToolkit/repos","events_url":"https://api.github.com/users/PlusToolkit/events{/privacy}","received_events_url":"https://api.github.com/users/PlusToolkit/received_events","type":"Organization","site_admin":false},"repo":{"id":84345056,"name":"ndicapi","full_name":"PlusToolkit/ndicapi","owner":{"login":"PlusToolkit","id":16928228,"avatar_url":"https://avatars2.githubusercontent.com/u/16928228?v=4","gravatar_id":"","url":"https://api.github.com/users/PlusToolkit","html_url":"https://github.com/PlusToolkit","followers_url":"https://api.github.com/users/PlusToolkit/followers","following_url":"https://api.github.com/users/PlusToolkit/following{/other_user}","gists_url":"https://api.github.com/users/PlusToolkit/gists{/gist_id}","starred_url":"https://api.github.com/users/PlusToolkit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PlusToolkit/subscriptions","organizations_url":"https://api.github.com/users/PlusToolkit/orgs","repos_url":"https://api.github.com/users/PlusToolkit/repos","events_url":"https://api.github.com/users/PlusToolkit/events{/privacy}","received_events_url":"https://api.github.com/users/PlusToolkit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PlusToolkit/ndicapi","description":"A common C API for communicating with NDI Polaris and Aurora devices","fork":false,"url":"https://api.github.com/repos/PlusToolkit/ndicapi","forks_url":"https://api.github.com/repos/PlusToolkit/ndicapi/forks","keys_url":"https://api.github.com/repos/PlusToolkit/ndicapi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PlusToolkit/ndicapi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PlusToolkit/ndicapi/teams","hooks_url":"https://api.github.com/repos/PlusToolkit/ndicapi/hooks","issue_events_url":"https://api.github.com/repos/PlusToolkit/ndicapi/issues/events{/number}","events_url":"https://api.github.com/repos/PlusToolkit/ndicapi/events","assignees_url":"https://api.github.com/repos/PlusToolkit/ndicapi/assignees{/user}","branches_url":"https://api.github.com/repos/PlusToolkit/ndicapi/branches{/branch}","tags_url":"https://api.github.com/repos/PlusToolkit/ndicapi/tags","blobs_url":"https://api.github.com/repos/PlusToolkit/ndicapi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PlusToolkit/ndicapi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PlusToolkit/ndicapi/git/refs{/sha}","trees_url":"https://api.github.com/repos/PlusToolkit/ndicapi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PlusToolkit/ndicapi/statuses/{sha}","languages_url":"https://api.github.com/repos/PlusToolkit/ndicapi/languages","stargazers_url":"https://api.github.com/repos/PlusToolkit/ndicapi/stargazers","contributors_url":"https://api.github.com/repos/PlusToolkit/ndicapi/contributors","subscribers_url":"https://api.github.com/repos/PlusToolkit/ndicapi/subscribers","subscription_url":"https://api.github.com/repos/PlusToolkit/ndicapi/subscription","commits_url":"https://api.github.com/repos/PlusToolkit/ndicapi/commits{/sha}","git_commits_url":"https://api.github.com/repos/PlusToolkit/ndicapi/git/commits{/sha}","comments_url":"https://api.github.com/repos/PlusToolkit/ndicapi/comments{/number}","issue_comment_url":"https://api.github.com/repos/PlusToolkit/ndicapi/issues/comments{/number}","contents_url":"https://api.github.com/repos/PlusToolkit/ndicapi/contents/{+path}","compare_url":"https://api.github.com/repos/PlusToolkit/ndicapi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PlusToolkit/ndicapi/merges","archive_url":"https://api.github.com/repos/PlusToolkit/ndicapi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PlusToolkit/ndicapi/downloads","issues_url":"https://api.github.com/repos/PlusToolkit/ndicapi/issues{/number}","pulls_url":"https://api.github.com/repos/PlusToolkit/ndicapi/pulls{/number}","milestones_url":"https://api.github.com/repos/PlusToolkit/ndicapi/milestones{/number}","notifications_url":"https://api.github.com/repos/PlusToolkit/ndicapi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PlusToolkit/ndicapi/labels{/name}","releases_url":"https://api.github.com/repos/PlusToolkit/ndicapi/releases{/id}","deployments_url":"https://api.github.com/repos/PlusToolkit/ndicapi/deployments","created_at":"2017-03-08T16:57:44Z","updated_at":"2018-02-22T00:48:16Z","pushed_at":"2018-03-01T14:55:26Z","git_url":"git://github.com/PlusToolkit/ndicapi.git","ssh_url":"git@github.com:PlusToolkit/ndicapi.git","clone_url":"https://github.com/PlusToolkit/ndicapi.git","svn_url":"https://github.com/PlusToolkit/ndicapi","homepage":null,"size":200,"stargazers_count":8,"watchers_count":8,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":11,"open_issues":0,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PlusToolkit/ndicapi/pulls/15"},"html":{"href":"https://github.com/PlusToolkit/ndicapi/pull/15"},"issue":{"href":"https://api.github.com/repos/PlusToolkit/ndicapi/issues/15"},"comments":{"href":"https://api.github.com/repos/PlusToolkit/ndicapi/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/PlusToolkit/ndicapi/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/PlusToolkit/ndicapi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PlusToolkit/ndicapi/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/PlusToolkit/ndicapi/statuses/5722114cc385b588511850e72334e30c53328362"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"adamrankin","id":3210398,"avatar_url":"https://avatars0.githubusercontent.com/u/3210398?v=4","gravatar_id":"","url":"https://api.github.com/users/adamrankin","html_url":"https://github.com/adamrankin","followers_url":"https://api.github.com/users/adamrankin/followers","following_url":"https://api.github.com/users/adamrankin/following{/other_user}","gists_url":"https://api.github.com/users/adamrankin/gists{/gist_id}","starred_url":"https://api.github.com/users/adamrankin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamrankin/subscriptions","organizations_url":"https://api.github.com/users/adamrankin/orgs","repos_url":"https://api.github.com/users/adamrankin/repos","events_url":"https://api.github.com/users/adamrankin/events{/privacy}","received_events_url":"https://api.github.com/users/adamrankin/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":77,"additions":108,"deletions":74,"changed_files":5}}
{"actor":{"display_login":"adamrankin"}}