{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/pulls/comments/212518817","pull_request_review_id":149171095,"id":212518817,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjUxODgxNw==","diff_hunk":"@@ -77,31 +77,34 @@ def run(input)\n           end\n \n           # Load, resolve, and validate puppet config settings\n-          puppet = Config::Puppet.parse(config_path)\n+          settings_overrides = {}\n+          settings_overrides[:certname] = input['certname'] unless input['certname'].empty?","path":"lib/puppetserver/ca/action/generate.rb","position":6,"original_position":6,"commit_id":"1e9f36a19855d16e87a8f2cab241ef54074e4edf","original_commit_id":"1e9f36a19855d16e87a8f2cab241ef54074e4edf","user":{"login":"amysahli","id":36681391,"node_id":"MDQ6VXNlcjM2NjgxMzkx","avatar_url":"https://avatars3.githubusercontent.com/u/36681391?v=4","gravatar_id":"","url":"https://api.github.com/users/amysahli","html_url":"https://github.com/amysahli","followers_url":"https://api.github.com/users/amysahli/followers","following_url":"https://api.github.com/users/amysahli/following{/other_user}","gists_url":"https://api.github.com/users/amysahli/gists{/gist_id}","starred_url":"https://api.github.com/users/amysahli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amysahli/subscriptions","organizations_url":"https://api.github.com/users/amysahli/orgs","repos_url":"https://api.github.com/users/amysahli/repos","events_url":"https://api.github.com/users/amysahli/events{/privacy}","received_events_url":"https://api.github.com/users/amysahli/received_events","type":"User","site_admin":false},"body":"Do we want to add ca-name and certname to the USAGE above too?","created_at":"2018-08-24T04:28:05Z","updated_at":"2018-08-24T04:28:05Z","html_url":"https://github.com/puppetlabs/puppetserver-ca-cli/pull/24#discussion_r212518817","pull_request_url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/pulls/24","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/pulls/comments/212518817"},"html":{"href":"https://github.com/puppetlabs/puppetserver-ca-cli/pull/24#discussion_r212518817"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/pulls/24"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/pulls/24","id":210498221,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwNDk4MjIx","html_url":"https://github.com/puppetlabs/puppetserver-ca-cli/pull/24","diff_url":"https://github.com/puppetlabs/puppetserver-ca-cli/pull/24.diff","patch_url":"https://github.com/puppetlabs/puppetserver-ca-cli/pull/24.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/issues/24","number":24,"state":"open","locked":false,"title":"(SERVER-2293) Add flags for certname and ca_name to generate","user":{"login":"Magisus","id":839145,"node_id":"MDQ6VXNlcjgzOTE0NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/839145?v=4","gravatar_id":"","url":"https://api.github.com/users/Magisus","html_url":"https://github.com/Magisus","followers_url":"https://api.github.com/users/Magisus/followers","following_url":"https://api.github.com/users/Magisus/following{/other_user}","gists_url":"https://api.github.com/users/Magisus/gists{/gist_id}","starred_url":"https://api.github.com/users/Magisus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Magisus/subscriptions","organizations_url":"https://api.github.com/users/Magisus/orgs","repos_url":"https://api.github.com/users/Magisus/repos","events_url":"https://api.github.com/users/Magisus/events{/privacy}","received_events_url":"https://api.github.com/users/Magisus/received_events","type":"User","site_admin":false},"body":"This adds the ability to specify certname and ca_name from the\r\ncommand line when using the generate command. These will overwrite the\r\nvalues read from settings.\r\n\r\nIt also adds the ability to specify `certname` for the `import` command.","created_at":"2018-08-23T16:00:49Z","updated_at":"2018-08-24T04:28:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c36d09da383879718654dcd37b21e8dc23636b87","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/pulls/24/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/pulls/24/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/issues/24/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/statuses/1e9f36a19855d16e87a8f2cab241ef54074e4edf","head":{"label":"Magisus:configure-names","ref":"configure-names","sha":"1e9f36a19855d16e87a8f2cab241ef54074e4edf","user":{"login":"Magisus","id":839145,"node_id":"MDQ6VXNlcjgzOTE0NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/839145?v=4","gravatar_id":"","url":"https://api.github.com/users/Magisus","html_url":"https://github.com/Magisus","followers_url":"https://api.github.com/users/Magisus/followers","following_url":"https://api.github.com/users/Magisus/following{/other_user}","gists_url":"https://api.github.com/users/Magisus/gists{/gist_id}","starred_url":"https://api.github.com/users/Magisus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Magisus/subscriptions","organizations_url":"https://api.github.com/users/Magisus/orgs","repos_url":"https://api.github.com/users/Magisus/repos","events_url":"https://api.github.com/users/Magisus/events{/privacy}","received_events_url":"https://api.github.com/users/Magisus/received_events","type":"User","site_admin":false},"repo":{"id":141457836,"node_id":"MDEwOlJlcG9zaXRvcnkxNDE0NTc4MzY=","name":"puppetserver-ca-cli","full_name":"Magisus/puppetserver-ca-cli","owner":{"login":"Magisus","id":839145,"node_id":"MDQ6VXNlcjgzOTE0NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/839145?v=4","gravatar_id":"","url":"https://api.github.com/users/Magisus","html_url":"https://github.com/Magisus","followers_url":"https://api.github.com/users/Magisus/followers","following_url":"https://api.github.com/users/Magisus/following{/other_user}","gists_url":"https://api.github.com/users/Magisus/gists{/gist_id}","starred_url":"https://api.github.com/users/Magisus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Magisus/subscriptions","organizations_url":"https://api.github.com/users/Magisus/orgs","repos_url":"https://api.github.com/users/Magisus/repos","events_url":"https://api.github.com/users/Magisus/events{/privacy}","received_events_url":"https://api.github.com/users/Magisus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Magisus/puppetserver-ca-cli","description":"A simple Ruby CLI tool to interact with the Puppet Server's included Certificate Authority","fork":true,"url":"https://api.github.com/repos/Magisus/puppetserver-ca-cli","forks_url":"https://api.github.com/repos/Magisus/puppetserver-ca-cli/forks","keys_url":"https://api.github.com/repos/Magisus/puppetserver-ca-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Magisus/puppetserver-ca-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Magisus/puppetserver-ca-cli/teams","hooks_url":"https://api.github.com/repos/Magisus/puppetserver-ca-cli/hooks","issue_events_url":"https://api.github.com/repos/Magisus/puppetserver-ca-cli/issues/events{/number}","events_url":"https://api.github.com/repos/Magisus/puppetserver-ca-cli/events","assignees_url":"https://api.github.com/repos/Magisus/puppetserver-ca-cli/assignees{/user}","branches_url":"https://api.github.com/repos/Magisus/puppetserver-ca-cli/branches{/branch}","tags_url":"https://api.github.com/repos/Magisus/puppetserver-ca-cli/tags","blobs_url":"https://api.github.com/repos/Magisus/puppetserver-ca-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Magisus/puppetserver-ca-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Magisus/puppetserver-ca-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/Magisus/puppetserver-ca-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Magisus/puppetserver-ca-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/Magisus/puppetserver-ca-cli/languages","stargazers_url":"https://api.github.com/repos/Magisus/puppetserver-ca-cli/stargazers","contributors_url":"https://api.github.com/repos/Magisus/puppetserver-ca-cli/contributors","subscribers_url":"https://api.github.com/repos/Magisus/puppetserver-ca-cli/subscribers","subscription_url":"https://api.github.com/repos/Magisus/puppetserver-ca-cli/subscription","commits_url":"https://api.github.com/repos/Magisus/puppetserver-ca-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/Magisus/puppetserver-ca-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/Magisus/puppetserver-ca-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/Magisus/puppetserver-ca-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/Magisus/puppetserver-ca-cli/contents/{+path}","compare_url":"https://api.github.com/repos/Magisus/puppetserver-ca-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Magisus/puppetserver-ca-cli/merges","archive_url":"https://api.github.com/repos/Magisus/puppetserver-ca-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Magisus/puppetserver-ca-cli/downloads","issues_url":"https://api.github.com/repos/Magisus/puppetserver-ca-cli/issues{/number}","pulls_url":"https://api.github.com/repos/Magisus/puppetserver-ca-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/Magisus/puppetserver-ca-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/Magisus/puppetserver-ca-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Magisus/puppetserver-ca-cli/labels{/name}","releases_url":"https://api.github.com/repos/Magisus/puppetserver-ca-cli/releases{/id}","deployments_url":"https://api.github.com/repos/Magisus/puppetserver-ca-cli/deployments","created_at":"2018-07-18T15:58:09Z","updated_at":"2018-07-24T15:46:42Z","pushed_at":"2018-08-24T02:06:07Z","git_url":"git://github.com/Magisus/puppetserver-ca-cli.git","ssh_url":"git@github.com:Magisus/puppetserver-ca-cli.git","clone_url":"https://github.com/Magisus/puppetserver-ca-cli.git","svn_url":"https://github.com/Magisus/puppetserver-ca-cli","homepage":null,"size":260,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"837226206ca4cb446a66ee88a7ed131b719dbc30","user":{"login":"puppetlabs","id":234268,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNDI2OA==","avatar_url":"https://avatars0.githubusercontent.com/u/234268?v=4","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":135350068,"node_id":"MDEwOlJlcG9zaXRvcnkxMzUzNTAwNjg=","name":"puppetserver-ca-cli","full_name":"puppetlabs/puppetserver-ca-cli","owner":{"login":"puppetlabs","id":234268,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNDI2OA==","avatar_url":"https://avatars0.githubusercontent.com/u/234268?v=4","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppetserver-ca-cli","description":"A simple Ruby CLI tool to interact with the Puppet Server's included Certificate Authority","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli","forks_url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/releases{/id}","deployments_url":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/deployments","created_at":"2018-05-29T20:35:19Z","updated_at":"2018-08-22T18:45:04Z","pushed_at":"2018-08-24T02:06:09Z","git_url":"git://github.com/puppetlabs/puppetserver-ca-cli.git","ssh_url":"git@github.com:puppetlabs/puppetserver-ca-cli.git","clone_url":"https://github.com/puppetlabs/puppetserver-ca-cli.git","svn_url":"https://github.com/puppetlabs/puppetserver-ca-cli","homepage":null,"size":236,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":4,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/pulls/24"},"html":{"href":"https://github.com/puppetlabs/puppetserver-ca-cli/pull/24"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/issues/24"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/issues/24/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/pulls/24/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/pulls/24/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppetserver-ca-cli/statuses/1e9f36a19855d16e87a8f2cab241ef54074e4edf"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"amysahli"}}