{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/naf-janus-adapter/pulls/comments/206742164","pull_request_review_id":142213062,"id":206742164,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNjc0MjE2NA==","diff_hunk":"@@ -381,28 +390,36 @@ class JanusAdapter {\n     };\n   }\n \n-  configureSubscriberSdp(originalSdp) {\n+  configurePublisherSdp(jsep) {\n+    jsep.sdp = jsep.sdp.replace(/a=fmtp:(109|111).*\\r\\n/g, (line, pt) => {","path":"src/index.js","position":47,"original_position":47,"commit_id":"e3d33c6ebfe86264c7085f7c42230730262e39e0","original_commit_id":"e3d33c6ebfe86264c7085f7c42230730262e39e0","user":{"login":"gfodor","id":220020,"node_id":"MDQ6VXNlcjIyMDAyMA==","avatar_url":"https://avatars3.githubusercontent.com/u/220020?v=4","gravatar_id":"","url":"https://api.github.com/users/gfodor","html_url":"https://github.com/gfodor","followers_url":"https://api.github.com/users/gfodor/followers","following_url":"https://api.github.com/users/gfodor/following{/other_user}","gists_url":"https://api.github.com/users/gfodor/gists{/gist_id}","starred_url":"https://api.github.com/users/gfodor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gfodor/subscriptions","organizations_url":"https://api.github.com/users/gfodor/orgs","repos_url":"https://api.github.com/users/gfodor/repos","events_url":"https://api.github.com/users/gfodor/events{/privacy}","received_events_url":"https://api.github.com/users/gfodor/received_events","type":"User","site_admin":false},"body":"is the carriage return part of the spec?","created_at":"2018-08-01T02:53:27Z","updated_at":"2018-08-01T02:53:27Z","html_url":"https://github.com/mozilla/naf-janus-adapter/pull/50#discussion_r206742164","pull_request_url":"https://api.github.com/repos/mozilla/naf-janus-adapter/pulls/50","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mozilla/naf-janus-adapter/pulls/comments/206742164"},"html":{"href":"https://github.com/mozilla/naf-janus-adapter/pull/50#discussion_r206742164"},"pull_request":{"href":"https://api.github.com/repos/mozilla/naf-janus-adapter/pulls/50"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/naf-janus-adapter/pulls/50","id":205294743,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1Mjk0NzQz","html_url":"https://github.com/mozilla/naf-janus-adapter/pull/50","diff_url":"https://github.com/mozilla/naf-janus-adapter/pull/50.diff","patch_url":"https://github.com/mozilla/naf-janus-adapter/pull/50.patch","issue_url":"https://api.github.com/repos/mozilla/naf-janus-adapter/issues/50","number":50,"state":"open","locked":false,"title":"Enable DTX on outgoing audio","user":{"login":"mquander","id":428637,"node_id":"MDQ6VXNlcjQyODYzNw==","avatar_url":"https://avatars2.githubusercontent.com/u/428637?v=4","gravatar_id":"","url":"https://api.github.com/users/mquander","html_url":"https://github.com/mquander","followers_url":"https://api.github.com/users/mquander/followers","following_url":"https://api.github.com/users/mquander/following{/other_user}","gists_url":"https://api.github.com/users/mquander/gists{/gist_id}","starred_url":"https://api.github.com/users/mquander/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mquander/subscriptions","organizations_url":"https://api.github.com/users/mquander/orgs","repos_url":"https://api.github.com/users/mquander/repos","events_url":"https://api.github.com/users/mquander/events{/privacy}","received_events_url":"https://api.github.com/users/mquander/received_events","type":"User","site_admin":false},"body":"When used with a compatible Janus, this will cause silence frames to not be transmitted between clients, which is an enormous bandwidth optimization in typical use.\r\n\r\nThis currently only works with Chrome senders -- Firefox doesn't respect the `usedtx` parameter. Tracked in https://bugzilla.mozilla.org/show_bug.cgi?format=default&id=1418804. ","created_at":"2018-08-01T02:50:54Z","updated_at":"2018-08-01T02:53:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7635d14a49e081f479d64ca6ef9aa24bbcd46bd8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/naf-janus-adapter/pulls/50/commits","review_comments_url":"https://api.github.com/repos/mozilla/naf-janus-adapter/pulls/50/comments","review_comment_url":"https://api.github.com/repos/mozilla/naf-janus-adapter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/naf-janus-adapter/issues/50/comments","statuses_url":"https://api.github.com/repos/mozilla/naf-janus-adapter/statuses/e3d33c6ebfe86264c7085f7c42230730262e39e0","head":{"label":"mozilla:sdp-dtx","ref":"sdp-dtx","sha":"e3d33c6ebfe86264c7085f7c42230730262e39e0","user":{"login":"mozilla","id":131524,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTUyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":108075718,"node_id":"MDEwOlJlcG9zaXRvcnkxMDgwNzU3MTg=","name":"naf-janus-adapter","full_name":"mozilla/naf-janus-adapter","owner":{"login":"mozilla","id":131524,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTUyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/naf-janus-adapter","description":"networked-aframe Janus network adapter","fork":false,"url":"https://api.github.com/repos/mozilla/naf-janus-adapter","forks_url":"https://api.github.com/repos/mozilla/naf-janus-adapter/forks","keys_url":"https://api.github.com/repos/mozilla/naf-janus-adapter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/naf-janus-adapter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/naf-janus-adapter/teams","hooks_url":"https://api.github.com/repos/mozilla/naf-janus-adapter/hooks","issue_events_url":"https://api.github.com/repos/mozilla/naf-janus-adapter/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/naf-janus-adapter/events","assignees_url":"https://api.github.com/repos/mozilla/naf-janus-adapter/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/naf-janus-adapter/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/naf-janus-adapter/tags","blobs_url":"https://api.github.com/repos/mozilla/naf-janus-adapter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/naf-janus-adapter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/naf-janus-adapter/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/naf-janus-adapter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/naf-janus-adapter/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/naf-janus-adapter/languages","stargazers_url":"https://api.github.com/repos/mozilla/naf-janus-adapter/stargazers","contributors_url":"https://api.github.com/repos/mozilla/naf-janus-adapter/contributors","subscribers_url":"https://api.github.com/repos/mozilla/naf-janus-adapter/subscribers","subscription_url":"https://api.github.com/repos/mozilla/naf-janus-adapter/subscription","commits_url":"https://api.github.com/repos/mozilla/naf-janus-adapter/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/naf-janus-adapter/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/naf-janus-adapter/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/naf-janus-adapter/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/naf-janus-adapter/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/naf-janus-adapter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/naf-janus-adapter/merges","archive_url":"https://api.github.com/repos/mozilla/naf-janus-adapter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/naf-janus-adapter/downloads","issues_url":"https://api.github.com/repos/mozilla/naf-janus-adapter/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/naf-janus-adapter/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/naf-janus-adapter/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/naf-janus-adapter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/naf-janus-adapter/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/naf-janus-adapter/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/naf-janus-adapter/deployments","created_at":"2017-10-24T04:13:58Z","updated_at":"2018-08-01T02:30:55Z","pushed_at":"2018-08-01T02:50:54Z","git_url":"git://github.com/mozilla/naf-janus-adapter.git","ssh_url":"git@github.com:mozilla/naf-janus-adapter.git","clone_url":"https://github.com/mozilla/naf-janus-adapter.git","svn_url":"https://github.com/mozilla/naf-janus-adapter","homepage":null,"size":1731,"stargazers_count":7,"watchers_count":7,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":3,"open_issues":2,"watchers":7,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"8fb837b3342353abd0651c5e4eaeaec2a3dc11b7","user":{"login":"mozilla","id":131524,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTUyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":108075718,"node_id":"MDEwOlJlcG9zaXRvcnkxMDgwNzU3MTg=","name":"naf-janus-adapter","full_name":"mozilla/naf-janus-adapter","owner":{"login":"mozilla","id":131524,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTUyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/naf-janus-adapter","description":"networked-aframe Janus network adapter","fork":false,"url":"https://api.github.com/repos/mozilla/naf-janus-adapter","forks_url":"https://api.github.com/repos/mozilla/naf-janus-adapter/forks","keys_url":"https://api.github.com/repos/mozilla/naf-janus-adapter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/naf-janus-adapter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/naf-janus-adapter/teams","hooks_url":"https://api.github.com/repos/mozilla/naf-janus-adapter/hooks","issue_events_url":"https://api.github.com/repos/mozilla/naf-janus-adapter/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/naf-janus-adapter/events","assignees_url":"https://api.github.com/repos/mozilla/naf-janus-adapter/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/naf-janus-adapter/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/naf-janus-adapter/tags","blobs_url":"https://api.github.com/repos/mozilla/naf-janus-adapter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/naf-janus-adapter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/naf-janus-adapter/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/naf-janus-adapter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/naf-janus-adapter/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/naf-janus-adapter/languages","stargazers_url":"https://api.github.com/repos/mozilla/naf-janus-adapter/stargazers","contributors_url":"https://api.github.com/repos/mozilla/naf-janus-adapter/contributors","subscribers_url":"https://api.github.com/repos/mozilla/naf-janus-adapter/subscribers","subscription_url":"https://api.github.com/repos/mozilla/naf-janus-adapter/subscription","commits_url":"https://api.github.com/repos/mozilla/naf-janus-adapter/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/naf-janus-adapter/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/naf-janus-adapter/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/naf-janus-adapter/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/naf-janus-adapter/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/naf-janus-adapter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/naf-janus-adapter/merges","archive_url":"https://api.github.com/repos/mozilla/naf-janus-adapter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/naf-janus-adapter/downloads","issues_url":"https://api.github.com/repos/mozilla/naf-janus-adapter/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/naf-janus-adapter/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/naf-janus-adapter/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/naf-janus-adapter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/naf-janus-adapter/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/naf-janus-adapter/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/naf-janus-adapter/deployments","created_at":"2017-10-24T04:13:58Z","updated_at":"2018-08-01T02:30:55Z","pushed_at":"2018-08-01T02:50:54Z","git_url":"git://github.com/mozilla/naf-janus-adapter.git","ssh_url":"git@github.com:mozilla/naf-janus-adapter.git","clone_url":"https://github.com/mozilla/naf-janus-adapter.git","svn_url":"https://github.com/mozilla/naf-janus-adapter","homepage":null,"size":1731,"stargazers_count":7,"watchers_count":7,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":3,"open_issues":2,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/naf-janus-adapter/pulls/50"},"html":{"href":"https://github.com/mozilla/naf-janus-adapter/pull/50"},"issue":{"href":"https://api.github.com/repos/mozilla/naf-janus-adapter/issues/50"},"comments":{"href":"https://api.github.com/repos/mozilla/naf-janus-adapter/issues/50/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/naf-janus-adapter/pulls/50/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/naf-janus-adapter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/naf-janus-adapter/pulls/50/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/naf-janus-adapter/statuses/e3d33c6ebfe86264c7085f7c42230730262e39e0"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"gfodor"}}