{"action":"created","issue":{"url":"https://api.github.com/repos/rjkroege/edwood/issues/52","repository_url":"https://api.github.com/repos/rjkroege/edwood","labels_url":"https://api.github.com/repos/rjkroege/edwood/issues/52/labels{/name}","comments_url":"https://api.github.com/repos/rjkroege/edwood/issues/52/comments","events_url":"https://api.github.com/repos/rjkroege/edwood/issues/52/events","html_url":"https://github.com/rjkroege/edwood/issues/52","id":320289736,"node_id":"MDU6SXNzdWUzMjAyODk3MzY=","number":52,"title":"column drawing blackness","user":{"login":"rjkroege","id":749383,"node_id":"MDQ6VXNlcjc0OTM4Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/749383?v=4","gravatar_id":"","url":"https://api.github.com/users/rjkroege","html_url":"https://github.com/rjkroege","followers_url":"https://api.github.com/users/rjkroege/followers","following_url":"https://api.github.com/users/rjkroege/following{/other_user}","gists_url":"https://api.github.com/users/rjkroege/gists{/gist_id}","starred_url":"https://api.github.com/users/rjkroege/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjkroege/subscriptions","organizations_url":"https://api.github.com/users/rjkroege/orgs","repos_url":"https://api.github.com/users/rjkroege/repos","events_url":"https://api.github.com/users/rjkroege/events{/privacy}","received_events_url":"https://api.github.com/users/rjkroege/received_events","type":"User","site_admin":false},"labels":[{"id":885215531,"node_id":"MDU6TGFiZWw4ODUyMTU1MzE=","url":"https://api.github.com/repos/rjkroege/edwood/labels/useful%20blocker","name":"useful blocker","color":"e99695","default":false}],"state":"open","locked":false,"assignee":{"login":"paul-lalonde","id":1304784,"node_id":"MDQ6VXNlcjEzMDQ3ODQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1304784?v=4","gravatar_id":"","url":"https://api.github.com/users/paul-lalonde","html_url":"https://github.com/paul-lalonde","followers_url":"https://api.github.com/users/paul-lalonde/followers","following_url":"https://api.github.com/users/paul-lalonde/following{/other_user}","gists_url":"https://api.github.com/users/paul-lalonde/gists{/gist_id}","starred_url":"https://api.github.com/users/paul-lalonde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paul-lalonde/subscriptions","organizations_url":"https://api.github.com/users/paul-lalonde/orgs","repos_url":"https://api.github.com/users/paul-lalonde/repos","events_url":"https://api.github.com/users/paul-lalonde/events{/privacy}","received_events_url":"https://api.github.com/users/paul-lalonde/received_events","type":"User","site_admin":false},"assignees":[{"login":"paul-lalonde","id":1304784,"node_id":"MDQ6VXNlcjEzMDQ3ODQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1304784?v=4","gravatar_id":"","url":"https://api.github.com/users/paul-lalonde","html_url":"https://github.com/paul-lalonde","followers_url":"https://api.github.com/users/paul-lalonde/followers","following_url":"https://api.github.com/users/paul-lalonde/following{/other_user}","gists_url":"https://api.github.com/users/paul-lalonde/gists{/gist_id}","starred_url":"https://api.github.com/users/paul-lalonde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paul-lalonde/subscriptions","organizations_url":"https://api.github.com/users/paul-lalonde/orgs","repos_url":"https://api.github.com/users/paul-lalonde/repos","events_url":"https://api.github.com/users/paul-lalonde/events{/privacy}","received_events_url":"https://api.github.com/users/paul-lalonde/received_events","type":"User","site_admin":false}],"milestone":null,"comments":9,"created_at":"2018-05-04T14:09:27Z","updated_at":"2018-06-12T10:36:05Z","closed_at":null,"author_association":"OWNER","body":"When creating many Windows (e.g. `B *.go`) and then attempting to manipulate Windows, we get black regions. \r\n\r\n![bug1](https://user-images.githubusercontent.com/749383/39632381-ec4e096e-4f82-11e8-9430-c31c2d4cb1a0.png)\r\n\r\nThe presence of the thin black rectangle in the margin shows that new content is being added with `Frame.Insert` but that `Text.Redraw` has not been invoked to fill the entire padded rectangle.\r\n\r\nI think this might be a problem in the column code?"},"comment":{"url":"https://api.github.com/repos/rjkroege/edwood/issues/comments/396544612","html_url":"https://github.com/rjkroege/edwood/issues/52#issuecomment-396544612","issue_url":"https://api.github.com/repos/rjkroege/edwood/issues/52","id":396544612,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NjU0NDYxMg==","user":{"login":"paul-lalonde","id":1304784,"node_id":"MDQ6VXNlcjEzMDQ3ODQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1304784?v=4","gravatar_id":"","url":"https://api.github.com/users/paul-lalonde","html_url":"https://github.com/paul-lalonde","followers_url":"https://api.github.com/users/paul-lalonde/followers","following_url":"https://api.github.com/users/paul-lalonde/following{/other_user}","gists_url":"https://api.github.com/users/paul-lalonde/gists{/gist_id}","starred_url":"https://api.github.com/users/paul-lalonde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paul-lalonde/subscriptions","organizations_url":"https://api.github.com/users/paul-lalonde/orgs","repos_url":"https://api.github.com/users/paul-lalonde/repos","events_url":"https://api.github.com/users/paul-lalonde/events{/privacy}","received_events_url":"https://api.github.com/users/paul-lalonde/received_events","type":"User","site_admin":false},"created_at":"2018-06-12T10:36:04Z","updated_at":"2018-06-12T10:36:04Z","author_association":"COLLABORATOR","body":"The difference between MaxPixelHeight and Rect().Y is exactly Rect().Y %\nDefaultFontHeight().  Today MaxPixelHeight would be DefaultFontHeight() *\nMaxLines, but since you want to have variable line heights, I'd need\nMaxPixelHeight to get the \"correct\" size for the window, to make windows\nhave integral numbers of lines, which we should strive for in layout.\n\n\nOn Tue, Jun 12, 2018 at 6:28 AM Robert Kroeger <notifications@github.com>\nwrote:\n\n> I have several comments / questions.\n>\n> First, I went to write MaxPixelHeight and apparently don't understand\n> what you're looking for because wouldn't it Rect().Y serve? That's the\n> height of the Frame.\n>\n> Second, the (scaled) border issues: there's a some kind of \"insets\" widget\n> property that would seem to have only an ad hoc implementation in Edwood?\n> Maybe we need to separate the idea of structuring and layout from the\n> mechanics of event handling and draw?\n>\n> Third: the way that Frame leaves Rect().Y % DefaultFontHeight() at the\n> bottom of Rect() empty grates on me. Moreover, the code sometimes\n> conflates this \"fringe\" with \"insets\".\n>\n> —\n> You are receiving this because you were assigned.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/rjkroege/edwood/issues/52#issuecomment-396542905>, or mute\n> the thread\n> <https://github.com/notifications/unsubscribe-auth/ABPo0Dn1bbqmv5PC-iLtocKZ-FOTInc8ks5t75fngaJpZM4Tytrl>\n> .\n>\n"}}
{"actor":{"display_login":"paul-lalonde"}}