{"action":"created","issue":{"url":"https://api.github.com/repos/softdevteam/grmtools/issues/71","repository_url":"https://api.github.com/repos/softdevteam/grmtools","labels_url":"https://api.github.com/repos/softdevteam/grmtools/issues/71/labels{/name}","comments_url":"https://api.github.com/repos/softdevteam/grmtools/issues/71/comments","events_url":"https://api.github.com/repos/softdevteam/grmtools/issues/71/events","html_url":"https://github.com/softdevteam/grmtools/pull/71","id":391668824,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5MTEwOTI5","number":71,"title":"Quoted epp strings","user":{"login":"ltratt","id":20318,"node_id":"MDQ6VXNlcjIwMzE4","avatar_url":"https://avatars1.githubusercontent.com/u/20318?v=4","gravatar_id":"","url":"https://api.github.com/users/ltratt","html_url":"https://github.com/ltratt","followers_url":"https://api.github.com/users/ltratt/followers","following_url":"https://api.github.com/users/ltratt/following{/other_user}","gists_url":"https://api.github.com/users/ltratt/gists{/gist_id}","starred_url":"https://api.github.com/users/ltratt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ltratt/subscriptions","organizations_url":"https://api.github.com/users/ltratt/orgs","repos_url":"https://api.github.com/users/ltratt/repos","events_url":"https://api.github.com/users/ltratt/events{/privacy}","received_events_url":"https://api.github.com/users/ltratt/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"ptersilie","id":375552,"node_id":"MDQ6VXNlcjM3NTU1Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/375552?v=4","gravatar_id":"","url":"https://api.github.com/users/ptersilie","html_url":"https://github.com/ptersilie","followers_url":"https://api.github.com/users/ptersilie/followers","following_url":"https://api.github.com/users/ptersilie/following{/other_user}","gists_url":"https://api.github.com/users/ptersilie/gists{/gist_id}","starred_url":"https://api.github.com/users/ptersilie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ptersilie/subscriptions","organizations_url":"https://api.github.com/users/ptersilie/orgs","repos_url":"https://api.github.com/users/ptersilie/repos","events_url":"https://api.github.com/users/ptersilie/events{/privacy}","received_events_url":"https://api.github.com/users/ptersilie/received_events","type":"User","site_admin":false},"assignees":[{"login":"ptersilie","id":375552,"node_id":"MDQ6VXNlcjM3NTU1Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/375552?v=4","gravatar_id":"","url":"https://api.github.com/users/ptersilie","html_url":"https://github.com/ptersilie","followers_url":"https://api.github.com/users/ptersilie/followers","following_url":"https://api.github.com/users/ptersilie/following{/other_user}","gists_url":"https://api.github.com/users/ptersilie/gists{/gist_id}","starred_url":"https://api.github.com/users/ptersilie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ptersilie/subscriptions","organizations_url":"https://api.github.com/users/ptersilie/orgs","repos_url":"https://api.github.com/users/ptersilie/repos","events_url":"https://api.github.com/users/ptersilie/events{/privacy}","received_events_url":"https://api.github.com/users/ptersilie/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2018-12-17T11:26:21Z","updated_at":"2018-12-17T15:43:38Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/softdevteam/grmtools/pulls/71","html_url":"https://github.com/softdevteam/grmtools/pull/71","diff_url":"https://github.com/softdevteam/grmtools/pull/71.diff","patch_url":"https://github.com/softdevteam/grmtools/pull/71.patch"},"body":"This PR was originally intended to fix a bug which meant that `%epp` statements like:\r\n\r\n```\r\n%epp '\"string\"'\r\n```\r\n\r\ncaused a compile-time error (https://github.com/softdevteam/grmtools/commit/87a16197f54d9bdba130991d4ba2bba5333105f9). But I then realised that we can make the testing of compile-time code generation more robust so that we don't have to rely on bunging tests in the `calc_actions` example. So this PR separates out a new way of running full compile-time code generation in tests. The new file `tests/ct.rs` is a bit hard to read, but it does the job. The tests in there aren't run normally but are run if you do:\r\n\r\n```\r\n$ cargo test -- --ignored\r\n```\r\n\r\nthough note that doesn't run the normal tests! So if you want to run *all* the tests you need to do:\r\n\r\n```\r\n$ cargo test\r\n$ cargo test --ignored\r\n```\r\n\r\nwhich is what is now in `.travis.yml`."},"comment":{"url":"https://api.github.com/repos/softdevteam/grmtools/issues/comments/447890412","html_url":"https://github.com/softdevteam/grmtools/pull/71#issuecomment-447890412","issue_url":"https://api.github.com/repos/softdevteam/grmtools/issues/71","id":447890412,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0Nzg5MDQxMg==","user":{"login":"ltratt","id":20318,"node_id":"MDQ6VXNlcjIwMzE4","avatar_url":"https://avatars1.githubusercontent.com/u/20318?v=4","gravatar_id":"","url":"https://api.github.com/users/ltratt","html_url":"https://github.com/ltratt","followers_url":"https://api.github.com/users/ltratt/followers","following_url":"https://api.github.com/users/ltratt/following{/other_user}","gists_url":"https://api.github.com/users/ltratt/gists{/gist_id}","starred_url":"https://api.github.com/users/ltratt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ltratt/subscriptions","organizations_url":"https://api.github.com/users/ltratt/orgs","repos_url":"https://api.github.com/users/ltratt/repos","events_url":"https://api.github.com/users/ltratt/events{/privacy}","received_events_url":"https://api.github.com/users/ltratt/received_events","type":"User","site_admin":false},"created_at":"2018-12-17T15:43:38Z","updated_at":"2018-12-17T15:43:38Z","author_association":"MEMBER","body":"Squashed but... I've just noticed that `lazy_static` doesn't call `Drop`, so our test directory is not being deleted after tests are run :/ I think I should try and fix that before we try merging this PR if you're OK with that."}}
{"actor":{"display_login":"ltratt"}}