{"action":"created","issue":{"url":"https://api.github.com/repos/CorfuDB/CorfuDB/issues/1229","repository_url":"https://api.github.com/repos/CorfuDB/CorfuDB","labels_url":"https://api.github.com/repos/CorfuDB/CorfuDB/issues/1229/labels{/name}","comments_url":"https://api.github.com/repos/CorfuDB/CorfuDB/issues/1229/comments","events_url":"https://api.github.com/repos/CorfuDB/CorfuDB/issues/1229/events","html_url":"https://github.com/CorfuDB/CorfuDB/pull/1229","id":306684509,"number":1229,"title":"Fix object creation performance regression #1192","user":{"login":"zalokhan","id":10751367,"avatar_url":"https://avatars3.githubusercontent.com/u/10751367?v=4","gravatar_id":"","url":"https://api.github.com/users/zalokhan","html_url":"https://github.com/zalokhan","followers_url":"https://api.github.com/users/zalokhan/followers","following_url":"https://api.github.com/users/zalokhan/following{/other_user}","gists_url":"https://api.github.com/users/zalokhan/gists{/gist_id}","starred_url":"https://api.github.com/users/zalokhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalokhan/subscriptions","organizations_url":"https://api.github.com/users/zalokhan/orgs","repos_url":"https://api.github.com/users/zalokhan/repos","events_url":"https://api.github.com/users/zalokhan/events{/privacy}","received_events_url":"https://api.github.com/users/zalokhan/received_events","type":"User","site_admin":false},"labels":[{"id":267404100,"url":"https://api.github.com/repos/CorfuDB/CorfuDB/labels/Performance%20Testing","name":"Performance Testing","color":"fef2c0","default":false}],"state":"open","locked":false,"assignee":{"login":"zalokhan","id":10751367,"avatar_url":"https://avatars3.githubusercontent.com/u/10751367?v=4","gravatar_id":"","url":"https://api.github.com/users/zalokhan","html_url":"https://github.com/zalokhan","followers_url":"https://api.github.com/users/zalokhan/followers","following_url":"https://api.github.com/users/zalokhan/following{/other_user}","gists_url":"https://api.github.com/users/zalokhan/gists{/gist_id}","starred_url":"https://api.github.com/users/zalokhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalokhan/subscriptions","organizations_url":"https://api.github.com/users/zalokhan/orgs","repos_url":"https://api.github.com/users/zalokhan/repos","events_url":"https://api.github.com/users/zalokhan/events{/privacy}","received_events_url":"https://api.github.com/users/zalokhan/received_events","type":"User","site_admin":false},"assignees":[{"login":"zalokhan","id":10751367,"avatar_url":"https://avatars3.githubusercontent.com/u/10751367?v=4","gravatar_id":"","url":"https://api.github.com/users/zalokhan","html_url":"https://github.com/zalokhan","followers_url":"https://api.github.com/users/zalokhan/followers","following_url":"https://api.github.com/users/zalokhan/following{/other_user}","gists_url":"https://api.github.com/users/zalokhan/gists{/gist_id}","starred_url":"https://api.github.com/users/zalokhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalokhan/subscriptions","organizations_url":"https://api.github.com/users/zalokhan/orgs","repos_url":"https://api.github.com/users/zalokhan/repos","events_url":"https://api.github.com/users/zalokhan/events{/privacy}","received_events_url":"https://api.github.com/users/zalokhan/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-03-20T00:21:12Z","updated_at":"2018-03-21T00:28:03Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/CorfuDB/CorfuDB/pulls/1229","html_url":"https://github.com/CorfuDB/CorfuDB/pull/1229","diff_url":"https://github.com/CorfuDB/CorfuDB/pull/1229.diff","patch_url":"https://github.com/CorfuDB/CorfuDB/pull/1229.patch"},"body":"## Overview\r\n\r\nDescription:\r\nFixing performance. Instead of creating deep copies of the layout, reusing the layout reference in the RuntimeLayout constructor.\r\nIn the AbstractView, we now keep an atomic reference of the RuntimeLayout used and create new only if there is an epoch change. \r\n\r\nWhy should this be merged: Fixes performance drop introduced by #1192 \r\n\r\n## Checklist (Definition of Done):\r\n\r\n- [x] There are no TODOs left in the code\r\n- [x] [Coding conventions](https://github.com/CorfuDB/CorfuDB/wiki/Corfu-Style-Guidelines) (e.g. for logging, unit tests) have been followed\r\n- [x] Change is covered by automated tests\r\n- [x] Public API has Javadoc\r\n"},"comment":{"url":"https://api.github.com/repos/CorfuDB/CorfuDB/issues/comments/374802527","html_url":"https://github.com/CorfuDB/CorfuDB/pull/1229#issuecomment-374802527","issue_url":"https://api.github.com/repos/CorfuDB/CorfuDB/issues/1229","id":374802527,"user":{"login":"corfudb-performance","id":26096625,"avatar_url":"https://avatars1.githubusercontent.com/u/26096625?v=4","gravatar_id":"","url":"https://api.github.com/users/corfudb-performance","html_url":"https://github.com/corfudb-performance","followers_url":"https://api.github.com/users/corfudb-performance/followers","following_url":"https://api.github.com/users/corfudb-performance/following{/other_user}","gists_url":"https://api.github.com/users/corfudb-performance/gists{/gist_id}","starred_url":"https://api.github.com/users/corfudb-performance/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corfudb-performance/subscriptions","organizations_url":"https://api.github.com/users/corfudb-performance/orgs","repos_url":"https://api.github.com/users/corfudb-performance/repos","events_url":"https://api.github.com/users/corfudb-performance/events{/privacy}","received_events_url":"https://api.github.com/users/corfudb-performance/received_events","type":"User","site_admin":false},"created_at":"2018-03-21T00:28:03Z","updated_at":"2018-03-21T00:28:03Z","author_association":"COLLABORATOR","body":"Results automatically generated by _CorfuDB Benchmark Framework_ to assess the performance of this pull request for commit **a85bc12**.\n\n*** 0.0% transaction FAILURE rate for NonConflictingTx+Scan workload, 1 threads, Disk mode\n*** 0.0% transaction FAILURE rate for NonConflictingTx+Scan workload, 5 threads, Disk mode\n*** 0.0% transaction FAILURE rate for NonConflictingTx+Scan workload, 10 threads, Disk mode\n \n An interactive dashboard with Pull Request Performance Metrics for ALL cluster types and numbers of threads in run, is available at:\n [Pull Request #1229 Graphs ](https://snapshot.raintank.io/dashboard/snapshot/nVoMByk2S4OWaaZPA26XLOwmDhXbKKhP) "}}
{"actor":{"display_login":"corfudb-performance"}}