{"action":"created","issue":{"url":"https://api.github.com/repos/esp8266/Arduino/issues/5117","repository_url":"https://api.github.com/repos/esp8266/Arduino","labels_url":"https://api.github.com/repos/esp8266/Arduino/issues/5117/labels{/name}","comments_url":"https://api.github.com/repos/esp8266/Arduino/issues/5117/comments","events_url":"https://api.github.com/repos/esp8266/Arduino/issues/5117/events","html_url":"https://github.com/esp8266/Arduino/pull/5117","id":358647602,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0MzMyODYx","number":5117,"title":"Make unique sections for ICACHE_* variables","user":{"login":"jjsuwa","id":19825784,"node_id":"MDQ6VXNlcjE5ODI1Nzg0","avatar_url":"https://avatars3.githubusercontent.com/u/19825784?v=4","gravatar_id":"","url":"https://api.github.com/users/jjsuwa","html_url":"https://github.com/jjsuwa","followers_url":"https://api.github.com/users/jjsuwa/followers","following_url":"https://api.github.com/users/jjsuwa/following{/other_user}","gists_url":"https://api.github.com/users/jjsuwa/gists{/gist_id}","starred_url":"https://api.github.com/users/jjsuwa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjsuwa/subscriptions","organizations_url":"https://api.github.com/users/jjsuwa/orgs","repos_url":"https://api.github.com/users/jjsuwa/repos","events_url":"https://api.github.com/users/jjsuwa/events{/privacy}","received_events_url":"https://api.github.com/users/jjsuwa/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":13,"created_at":"2018-09-10T14:25:15Z","updated_at":"2018-09-12T17:03:52Z","closed_at":"2018-09-11T17:38:38Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/esp8266/Arduino/pulls/5117","html_url":"https://github.com/esp8266/Arduino/pull/5117","diff_url":"https://github.com/esp8266/Arduino/pull/5117.diff","patch_url":"https://github.com/esp8266/Arduino/pull/5117.patch"},"body":"Similar to PROGMEM changes, make the name of each ICACHE_* variable/fuction\r\nunique to avoid issues with section conflicts.\r\n\r\nFixes #5115 \r\n\r\nAdded `.irom0.text.*` and `.iram.text.*` to ldscript."},"comment":{"url":"https://api.github.com/repos/esp8266/Arduino/issues/comments/420723829","html_url":"https://github.com/esp8266/Arduino/pull/5117#issuecomment-420723829","issue_url":"https://api.github.com/repos/esp8266/Arduino/issues/5117","id":420723829,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMDcyMzgyOQ==","user":{"login":"earlephilhower","id":11875,"node_id":"MDQ6VXNlcjExODc1","avatar_url":"https://avatars0.githubusercontent.com/u/11875?v=4","gravatar_id":"","url":"https://api.github.com/users/earlephilhower","html_url":"https://github.com/earlephilhower","followers_url":"https://api.github.com/users/earlephilhower/followers","following_url":"https://api.github.com/users/earlephilhower/following{/other_user}","gists_url":"https://api.github.com/users/earlephilhower/gists{/gist_id}","starred_url":"https://api.github.com/users/earlephilhower/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/earlephilhower/subscriptions","organizations_url":"https://api.github.com/users/earlephilhower/orgs","repos_url":"https://api.github.com/users/earlephilhower/repos","events_url":"https://api.github.com/users/earlephilhower/events{/privacy}","received_events_url":"https://api.github.com/users/earlephilhower/received_events","type":"User","site_admin":false},"created_at":"2018-09-12T17:03:52Z","updated_at":"2018-09-12T17:03:52Z","author_association":"COLLABORATOR","body":"No joy yet.\r\n\r\nTools->Full flash erase:  Same failure\r\nChange in order of linker patterns:  Same failure\r\n\r\nThe only difference I think is left is the generic vs. WemosD1 variant.  I'll need to dig into the variant code a bit later."}}
{"actor":{"display_login":"earlephilhower"}}