{"action":"created","comment":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments/245329920","pull_request_review_id":189408379,"id":245329920,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NTMyOTkyMA==","diff_hunk":"@@ -83,6 +98,56 @@ def set_oscillating(self, value):\n                   ATTR_OSCILLATING: oscillating}\n         self.call_service(DOMAIN, SERVICE_OSCILLATE, params, oscillating)\n \n+    def set_speed_list(self, speed_list):","path":"homeassistant/components/homekit/type_fans.py","position":73,"original_position":73,"commit_id":"465c72938e8394238a13fd5094d4a36b491b5c8e","original_commit_id":"465c72938e8394238a13fd5094d4a36b491b5c8e","user":{"login":"cdce8p","id":30130371,"node_id":"MDQ6VXNlcjMwMTMwMzcx","avatar_url":"https://avatars2.githubusercontent.com/u/30130371?v=4","gravatar_id":"","url":"https://api.github.com/users/cdce8p","html_url":"https://github.com/cdce8p","followers_url":"https://api.github.com/users/cdce8p/followers","following_url":"https://api.github.com/users/cdce8p/following{/other_user}","gists_url":"https://api.github.com/users/cdce8p/gists{/gist_id}","starred_url":"https://api.github.com/users/cdce8p/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdce8p/subscriptions","organizations_url":"https://api.github.com/users/cdce8p/orgs","repos_url":"https://api.github.com/users/cdce8p/repos","events_url":"https://api.github.com/users/cdce8p/events{/privacy}","received_events_url":"https://api.github.com/users/cdce8p/received_events","type":"User","site_admin":false},"body":"We don't need to save the complete speed list inside the accessory. After the check the `speed_list_type` should be enough for the conversion later.","created_at":"2019-01-04T15:30:17Z","updated_at":"2019-01-04T15:41:34Z","html_url":"https://github.com/home-assistant/home-assistant/pull/19767#discussion_r245329920","pull_request_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/19767","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments/245329920"},"html":{"href":"https://github.com/home-assistant/home-assistant/pull/19767#discussion_r245329920"},"pull_request":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/19767"}}},"pull_request":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/19767","id":242274520,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQyMjc0NTIw","html_url":"https://github.com/home-assistant/home-assistant/pull/19767","diff_url":"https://github.com/home-assistant/home-assistant/pull/19767.diff","patch_url":"https://github.com/home-assistant/home-assistant/pull/19767.patch","issue_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/19767","number":19767,"state":"open","locked":false,"title":"Added HomeKit fan speed based on speed_list","user":{"login":"nd-net","id":8214480,"node_id":"MDQ6VXNlcjgyMTQ0ODA=","avatar_url":"https://avatars0.githubusercontent.com/u/8214480?v=4","gravatar_id":"","url":"https://api.github.com/users/nd-net","html_url":"https://github.com/nd-net","followers_url":"https://api.github.com/users/nd-net/followers","following_url":"https://api.github.com/users/nd-net/following{/other_user}","gists_url":"https://api.github.com/users/nd-net/gists{/gist_id}","starred_url":"https://api.github.com/users/nd-net/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nd-net/subscriptions","organizations_url":"https://api.github.com/users/nd-net/orgs","repos_url":"https://api.github.com/users/nd-net/repos","events_url":"https://api.github.com/users/nd-net/events{/privacy}","received_events_url":"https://api.github.com/users/nd-net/received_events","type":"User","site_admin":false},"body":"## Description:\r\n\r\n\r\nAdds support the `speed` of HomeKit fans. The commit uses `speed_list` to provide a mapping between the step-based `speed` of Home Assistant fans and the percentage-based `RotationSpeed` of HomeKit. Once [home-assistant/architecture#27](https://github.com/home-assistant/architecture/issues/27) changes the architecture, the `speed` should be retrieved via the new architecture.\r\n\r\n**Related issue (if applicable):** updates #14351\r\n\r\n**Pull request in home-assistant.github.io with documentation (if applicable):** home-assistant/home-assistant.io#8044\r\n\r\n## Checklist:\r\n  - [x] The code change is tested and works locally.\r\n  - [x] Local tests pass with `tox`. **Your PR cannot be merged unless tests pass**\r\n  - [x] There is no commented out code in this PR.\r\n  - [x] Documentation added/updated in [home-assistant.io](https://github.com/home-assistant/home-assistant.io)\r\n  - [x] Tests have been added to verify that the new code works.","created_at":"2019-01-04T14:19:11Z","updated_at":"2019-01-04T15:41:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3998c9bd5c1a16483064a3fae1a1aaaf87d6d661","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":527871105,"node_id":"MDU6TGFiZWw1Mjc4NzExMDU=","url":"https://api.github.com/repos/home-assistant/home-assistant/labels/cla-signed","name":"cla-signed","color":"008000","default":false},{"id":840363345,"node_id":"MDU6TGFiZWw4NDAzNjMzNDU=","url":"https://api.github.com/repos/home-assistant/home-assistant/labels/component:%20homekit","name":"component: homekit","color":"ededed","default":false},{"id":955422305,"node_id":"MDU6TGFiZWw5NTU0MjIzMDU=","url":"https://api.github.com/repos/home-assistant/home-assistant/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/19767/commits","review_comments_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/19767/comments","review_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments{/number}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/19767/comments","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/465c72938e8394238a13fd5094d4a36b491b5c8e","head":{"label":"nd-net:homekit-fan-speed-support","ref":"homekit-fan-speed-support","sha":"465c72938e8394238a13fd5094d4a36b491b5c8e","user":{"login":"nd-net","id":8214480,"node_id":"MDQ6VXNlcjgyMTQ0ODA=","avatar_url":"https://avatars0.githubusercontent.com/u/8214480?v=4","gravatar_id":"","url":"https://api.github.com/users/nd-net","html_url":"https://github.com/nd-net","followers_url":"https://api.github.com/users/nd-net/followers","following_url":"https://api.github.com/users/nd-net/following{/other_user}","gists_url":"https://api.github.com/users/nd-net/gists{/gist_id}","starred_url":"https://api.github.com/users/nd-net/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nd-net/subscriptions","organizations_url":"https://api.github.com/users/nd-net/orgs","repos_url":"https://api.github.com/users/nd-net/repos","events_url":"https://api.github.com/users/nd-net/events{/privacy}","received_events_url":"https://api.github.com/users/nd-net/received_events","type":"User","site_admin":false},"repo":{"id":164033510,"node_id":"MDEwOlJlcG9zaXRvcnkxNjQwMzM1MTA=","name":"home-assistant","full_name":"nd-net/home-assistant","private":false,"owner":{"login":"nd-net","id":8214480,"node_id":"MDQ6VXNlcjgyMTQ0ODA=","avatar_url":"https://avatars0.githubusercontent.com/u/8214480?v=4","gravatar_id":"","url":"https://api.github.com/users/nd-net","html_url":"https://github.com/nd-net","followers_url":"https://api.github.com/users/nd-net/followers","following_url":"https://api.github.com/users/nd-net/following{/other_user}","gists_url":"https://api.github.com/users/nd-net/gists{/gist_id}","starred_url":"https://api.github.com/users/nd-net/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nd-net/subscriptions","organizations_url":"https://api.github.com/users/nd-net/orgs","repos_url":"https://api.github.com/users/nd-net/repos","events_url":"https://api.github.com/users/nd-net/events{/privacy}","received_events_url":"https://api.github.com/users/nd-net/received_events","type":"User","site_admin":false},"html_url":"https://github.com/nd-net/home-assistant","description":":house_with_garden: Open source home automation that puts local control and privacy first","fork":true,"url":"https://api.github.com/repos/nd-net/home-assistant","forks_url":"https://api.github.com/repos/nd-net/home-assistant/forks","keys_url":"https://api.github.com/repos/nd-net/home-assistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nd-net/home-assistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nd-net/home-assistant/teams","hooks_url":"https://api.github.com/repos/nd-net/home-assistant/hooks","issue_events_url":"https://api.github.com/repos/nd-net/home-assistant/issues/events{/number}","events_url":"https://api.github.com/repos/nd-net/home-assistant/events","assignees_url":"https://api.github.com/repos/nd-net/home-assistant/assignees{/user}","branches_url":"https://api.github.com/repos/nd-net/home-assistant/branches{/branch}","tags_url":"https://api.github.com/repos/nd-net/home-assistant/tags","blobs_url":"https://api.github.com/repos/nd-net/home-assistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nd-net/home-assistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nd-net/home-assistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/nd-net/home-assistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nd-net/home-assistant/statuses/{sha}","languages_url":"https://api.github.com/repos/nd-net/home-assistant/languages","stargazers_url":"https://api.github.com/repos/nd-net/home-assistant/stargazers","contributors_url":"https://api.github.com/repos/nd-net/home-assistant/contributors","subscribers_url":"https://api.github.com/repos/nd-net/home-assistant/subscribers","subscription_url":"https://api.github.com/repos/nd-net/home-assistant/subscription","commits_url":"https://api.github.com/repos/nd-net/home-assistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/nd-net/home-assistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/nd-net/home-assistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/nd-net/home-assistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/nd-net/home-assistant/contents/{+path}","compare_url":"https://api.github.com/repos/nd-net/home-assistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nd-net/home-assistant/merges","archive_url":"https://api.github.com/repos/nd-net/home-assistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nd-net/home-assistant/downloads","issues_url":"https://api.github.com/repos/nd-net/home-assistant/issues{/number}","pulls_url":"https://api.github.com/repos/nd-net/home-assistant/pulls{/number}","milestones_url":"https://api.github.com/repos/nd-net/home-assistant/milestones{/number}","notifications_url":"https://api.github.com/repos/nd-net/home-assistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nd-net/home-assistant/labels{/name}","releases_url":"https://api.github.com/repos/nd-net/home-assistant/releases{/id}","deployments_url":"https://api.github.com/repos/nd-net/home-assistant/deployments","created_at":"2019-01-03T23:27:47Z","updated_at":"2019-01-03T23:27:58Z","pushed_at":"2019-01-04T13:45:33Z","git_url":"git://github.com/nd-net/home-assistant.git","ssh_url":"git@github.com:nd-net/home-assistant.git","clone_url":"https://github.com/nd-net/home-assistant.git","svn_url":"https://github.com/nd-net/home-assistant","homepage":"https://www.home-assistant.io","size":96456,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"home-assistant:dev","ref":"dev","sha":"ead38f60054162cd73e19ecf453e8b7933e82f14","user":{"login":"home-assistant","id":13844975,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzODQ0OTc1","avatar_url":"https://avatars3.githubusercontent.com/u/13844975?v=4","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"repo":{"id":12888993,"node_id":"MDEwOlJlcG9zaXRvcnkxMjg4ODk5Mw==","name":"home-assistant","full_name":"home-assistant/home-assistant","private":false,"owner":{"login":"home-assistant","id":13844975,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzODQ0OTc1","avatar_url":"https://avatars3.githubusercontent.com/u/13844975?v=4","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/home-assistant/home-assistant","description":":house_with_garden: Open source home automation that puts local control and privacy first","fork":false,"url":"https://api.github.com/repos/home-assistant/home-assistant","forks_url":"https://api.github.com/repos/home-assistant/home-assistant/forks","keys_url":"https://api.github.com/repos/home-assistant/home-assistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/home-assistant/home-assistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/home-assistant/home-assistant/teams","hooks_url":"https://api.github.com/repos/home-assistant/home-assistant/hooks","issue_events_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/events{/number}","events_url":"https://api.github.com/repos/home-assistant/home-assistant/events","assignees_url":"https://api.github.com/repos/home-assistant/home-assistant/assignees{/user}","branches_url":"https://api.github.com/repos/home-assistant/home-assistant/branches{/branch}","tags_url":"https://api.github.com/repos/home-assistant/home-assistant/tags","blobs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/home-assistant/home-assistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/home-assistant/home-assistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/{sha}","languages_url":"https://api.github.com/repos/home-assistant/home-assistant/languages","stargazers_url":"https://api.github.com/repos/home-assistant/home-assistant/stargazers","contributors_url":"https://api.github.com/repos/home-assistant/home-assistant/contributors","subscribers_url":"https://api.github.com/repos/home-assistant/home-assistant/subscribers","subscription_url":"https://api.github.com/repos/home-assistant/home-assistant/subscription","commits_url":"https://api.github.com/repos/home-assistant/home-assistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/home-assistant/home-assistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/home-assistant/home-assistant/contents/{+path}","compare_url":"https://api.github.com/repos/home-assistant/home-assistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/home-assistant/home-assistant/merges","archive_url":"https://api.github.com/repos/home-assistant/home-assistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/home-assistant/home-assistant/downloads","issues_url":"https://api.github.com/repos/home-assistant/home-assistant/issues{/number}","pulls_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls{/number}","milestones_url":"https://api.github.com/repos/home-assistant/home-assistant/milestones{/number}","notifications_url":"https://api.github.com/repos/home-assistant/home-assistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/home-assistant/home-assistant/labels{/name}","releases_url":"https://api.github.com/repos/home-assistant/home-assistant/releases{/id}","deployments_url":"https://api.github.com/repos/home-assistant/home-assistant/deployments","created_at":"2013-09-17T07:29:48Z","updated_at":"2019-01-04T15:22:04Z","pushed_at":"2019-01-04T15:29:58Z","git_url":"git://github.com/home-assistant/home-assistant.git","ssh_url":"git@github.com:home-assistant/home-assistant.git","clone_url":"https://github.com/home-assistant/home-assistant.git","svn_url":"https://github.com/home-assistant/home-assistant","homepage":"https://www.home-assistant.io","size":96451,"stargazers_count":20250,"watchers_count":20250,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5827,"mirror_url":null,"archived":false,"open_issues_count":983,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":5827,"open_issues":983,"watchers":20250,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/19767"},"html":{"href":"https://github.com/home-assistant/home-assistant/pull/19767"},"issue":{"href":"https://api.github.com/repos/home-assistant/home-assistant/issues/19767"},"comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant/issues/19767/comments"},"review_comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/19767/comments"},"review_comment":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/19767/commits"},"statuses":{"href":"https://api.github.com/repos/home-assistant/home-assistant/statuses/465c72938e8394238a13fd5094d4a36b491b5c8e"}},"author_association":"NONE"}}
{"actor":{"display_login":"cdce8p"}}