{"action":"created","comment":{"url":"https://api.github.com/repos/cozy/cozy-store/pulls/comments/243544525","pull_request_review_id":187343572,"id":243544525,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MzU0NDUyNQ==","diff_hunk":"@@ -626,29 +630,66 @@ export function uninstallApp(app) {\n   }\n }\n \n+async function _handleTerms(terms) {\n+  const { id, ...termsAttributes } = terms\n+  const docId = slugify(`${id}:${termsAttributes.version}`)","path":"src/ducks/apps/index.js","position":null,"original_position":37,"commit_id":"aa994fa6f751d603369c0371f68fb90887e19e12","original_commit_id":"c1a44134563098a44f93a2cb8a8f2442f554f405","user":{"login":"CPatchane","id":10224453,"node_id":"MDQ6VXNlcjEwMjI0NDUz","avatar_url":"https://avatars2.githubusercontent.com/u/10224453?v=4","gravatar_id":"","url":"https://api.github.com/users/CPatchane","html_url":"https://github.com/CPatchane","followers_url":"https://api.github.com/users/CPatchane/followers","following_url":"https://api.github.com/users/CPatchane/following{/other_user}","gists_url":"https://api.github.com/users/CPatchane/gists{/gist_id}","starred_url":"https://api.github.com/users/CPatchane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CPatchane/subscriptions","organizations_url":"https://api.github.com/users/CPatchane/orgs","repos_url":"https://api.github.com/users/CPatchane/repos","events_url":"https://api.github.com/users/CPatchane/events{/privacy}","received_events_url":"https://api.github.com/users/CPatchane/received_events","type":"User","site_admin":false},"body":"You're right. I was thinking that slugify will also replace special characters but it doesn't, so let use a simple replace with regexp to handle this case and remove it 👍 ","created_at":"2018-12-21T10:30:14Z","updated_at":"2018-12-21T10:30:15Z","html_url":"https://github.com/cozy/cozy-store/pull/496#discussion_r243544525","pull_request_url":"https://api.github.com/repos/cozy/cozy-store/pulls/496","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/cozy/cozy-store/pulls/comments/243544525"},"html":{"href":"https://github.com/cozy/cozy-store/pull/496#discussion_r243544525"},"pull_request":{"href":"https://api.github.com/repos/cozy/cozy-store/pulls/496"}},"in_reply_to_id":243519518},"pull_request":{"url":"https://api.github.com/repos/cozy/cozy-store/pulls/496","id":240255934,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwMjU1OTM0","html_url":"https://github.com/cozy/cozy-store/pull/496","diff_url":"https://github.com/cozy/cozy-store/pull/496.diff","patch_url":"https://github.com/cozy/cozy-store/pull/496.patch","issue_url":"https://api.github.com/repos/cozy/cozy-store/issues/496","number":496,"state":"open","locked":false,"title":"WIP: Handle app terms and partnership","user":{"login":"CPatchane","id":10224453,"node_id":"MDQ6VXNlcjEwMjI0NDUz","avatar_url":"https://avatars2.githubusercontent.com/u/10224453?v=4","gravatar_id":"","url":"https://api.github.com/users/CPatchane","html_url":"https://github.com/CPatchane","followers_url":"https://api.github.com/users/CPatchane/followers","following_url":"https://api.github.com/users/CPatchane/following{/other_user}","gists_url":"https://api.github.com/users/CPatchane/gists{/gist_id}","starred_url":"https://api.github.com/users/CPatchane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CPatchane/subscriptions","organizations_url":"https://api.github.com/users/CPatchane/orgs","repos_url":"https://api.github.com/users/CPatchane/repos","events_url":"https://api.github.com/users/CPatchane/events{/privacy}","received_events_url":"https://api.github.com/users/CPatchane/received_events","type":"User","site_admin":false},"body":"This PR is a little big but there all commits are atomic and there were some little cleanings to do.\r\n\r\n- Do not check the versions in the registry apps selector (already done on fetching)\r\n- Minor install/uninstall function refactoring to take directly the app object\r\n- Handle terms in the install modal\r\n- Save terms in database as `io.cozy.terms`\r\n- Make class names used by `<ReactMarkdownWrapper` more consistent\r\n- Handle partenship informations in the install modal\r\n- Some minor fixes and cleanings\r\n\r\n<img width=\"588\" alt=\"screenshot 2018-12-20 at 18 39 51\" src=\"https://user-images.githubusercontent.com/10224453/50302215-ba0dad80-0489-11e9-8b1d-a553dfcca38e.png\">\r\n","created_at":"2018-12-20T18:01:44Z","updated_at":"2018-12-21T10:30:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f816001dd1ada8e445f752994da83217e3eca4c4","assignee":{"login":"CPatchane","id":10224453,"node_id":"MDQ6VXNlcjEwMjI0NDUz","avatar_url":"https://avatars2.githubusercontent.com/u/10224453?v=4","gravatar_id":"","url":"https://api.github.com/users/CPatchane","html_url":"https://github.com/CPatchane","followers_url":"https://api.github.com/users/CPatchane/followers","following_url":"https://api.github.com/users/CPatchane/following{/other_user}","gists_url":"https://api.github.com/users/CPatchane/gists{/gist_id}","starred_url":"https://api.github.com/users/CPatchane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CPatchane/subscriptions","organizations_url":"https://api.github.com/users/CPatchane/orgs","repos_url":"https://api.github.com/users/CPatchane/repos","events_url":"https://api.github.com/users/CPatchane/events{/privacy}","received_events_url":"https://api.github.com/users/CPatchane/received_events","type":"User","site_admin":false},"assignees":[{"login":"CPatchane","id":10224453,"node_id":"MDQ6VXNlcjEwMjI0NDUz","avatar_url":"https://avatars2.githubusercontent.com/u/10224453?v=4","gravatar_id":"","url":"https://api.github.com/users/CPatchane","html_url":"https://github.com/CPatchane","followers_url":"https://api.github.com/users/CPatchane/followers","following_url":"https://api.github.com/users/CPatchane/following{/other_user}","gists_url":"https://api.github.com/users/CPatchane/gists{/gist_id}","starred_url":"https://api.github.com/users/CPatchane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CPatchane/subscriptions","organizations_url":"https://api.github.com/users/CPatchane/orgs","repos_url":"https://api.github.com/users/CPatchane/repos","events_url":"https://api.github.com/users/CPatchane/events{/privacy}","received_events_url":"https://api.github.com/users/CPatchane/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"gregorylegarec","id":776764,"node_id":"MDQ6VXNlcjc3Njc2NA==","avatar_url":"https://avatars3.githubusercontent.com/u/776764?v=4","gravatar_id":"","url":"https://api.github.com/users/gregorylegarec","html_url":"https://github.com/gregorylegarec","followers_url":"https://api.github.com/users/gregorylegarec/followers","following_url":"https://api.github.com/users/gregorylegarec/following{/other_user}","gists_url":"https://api.github.com/users/gregorylegarec/gists{/gist_id}","starred_url":"https://api.github.com/users/gregorylegarec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregorylegarec/subscriptions","organizations_url":"https://api.github.com/users/gregorylegarec/orgs","repos_url":"https://api.github.com/users/gregorylegarec/repos","events_url":"https://api.github.com/users/gregorylegarec/events{/privacy}","received_events_url":"https://api.github.com/users/gregorylegarec/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cozy/cozy-store/pulls/496/commits","review_comments_url":"https://api.github.com/repos/cozy/cozy-store/pulls/496/comments","review_comment_url":"https://api.github.com/repos/cozy/cozy-store/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cozy/cozy-store/issues/496/comments","statuses_url":"https://api.github.com/repos/cozy/cozy-store/statuses/aa994fa6f751d603369c0371f68fb90887e19e12","head":{"label":"CPatchane:handle_terms","ref":"handle_terms","sha":"aa994fa6f751d603369c0371f68fb90887e19e12","user":{"login":"CPatchane","id":10224453,"node_id":"MDQ6VXNlcjEwMjI0NDUz","avatar_url":"https://avatars2.githubusercontent.com/u/10224453?v=4","gravatar_id":"","url":"https://api.github.com/users/CPatchane","html_url":"https://github.com/CPatchane","followers_url":"https://api.github.com/users/CPatchane/followers","following_url":"https://api.github.com/users/CPatchane/following{/other_user}","gists_url":"https://api.github.com/users/CPatchane/gists{/gist_id}","starred_url":"https://api.github.com/users/CPatchane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CPatchane/subscriptions","organizations_url":"https://api.github.com/users/CPatchane/orgs","repos_url":"https://api.github.com/users/CPatchane/repos","events_url":"https://api.github.com/users/CPatchane/events{/privacy}","received_events_url":"https://api.github.com/users/CPatchane/received_events","type":"User","site_admin":false},"repo":{"id":101056595,"node_id":"MDEwOlJlcG9zaXRvcnkxMDEwNTY1OTU=","name":"cozy-store","full_name":"CPatchane/cozy-store","private":false,"owner":{"login":"CPatchane","id":10224453,"node_id":"MDQ6VXNlcjEwMjI0NDUz","avatar_url":"https://avatars2.githubusercontent.com/u/10224453?v=4","gravatar_id":"","url":"https://api.github.com/users/CPatchane","html_url":"https://github.com/CPatchane","followers_url":"https://api.github.com/users/CPatchane/followers","following_url":"https://api.github.com/users/CPatchane/following{/other_user}","gists_url":"https://api.github.com/users/CPatchane/gists{/gist_id}","starred_url":"https://api.github.com/users/CPatchane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CPatchane/subscriptions","organizations_url":"https://api.github.com/users/CPatchane/orgs","repos_url":"https://api.github.com/users/CPatchane/repos","events_url":"https://api.github.com/users/CPatchane/events{/privacy}","received_events_url":"https://api.github.com/users/CPatchane/received_events","type":"User","site_admin":false},"html_url":"https://github.com/CPatchane/cozy-store","description":"Marketplace app for Cozy Cloud v3","fork":true,"url":"https://api.github.com/repos/CPatchane/cozy-store","forks_url":"https://api.github.com/repos/CPatchane/cozy-store/forks","keys_url":"https://api.github.com/repos/CPatchane/cozy-store/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CPatchane/cozy-store/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CPatchane/cozy-store/teams","hooks_url":"https://api.github.com/repos/CPatchane/cozy-store/hooks","issue_events_url":"https://api.github.com/repos/CPatchane/cozy-store/issues/events{/number}","events_url":"https://api.github.com/repos/CPatchane/cozy-store/events","assignees_url":"https://api.github.com/repos/CPatchane/cozy-store/assignees{/user}","branches_url":"https://api.github.com/repos/CPatchane/cozy-store/branches{/branch}","tags_url":"https://api.github.com/repos/CPatchane/cozy-store/tags","blobs_url":"https://api.github.com/repos/CPatchane/cozy-store/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CPatchane/cozy-store/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CPatchane/cozy-store/git/refs{/sha}","trees_url":"https://api.github.com/repos/CPatchane/cozy-store/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CPatchane/cozy-store/statuses/{sha}","languages_url":"https://api.github.com/repos/CPatchane/cozy-store/languages","stargazers_url":"https://api.github.com/repos/CPatchane/cozy-store/stargazers","contributors_url":"https://api.github.com/repos/CPatchane/cozy-store/contributors","subscribers_url":"https://api.github.com/repos/CPatchane/cozy-store/subscribers","subscription_url":"https://api.github.com/repos/CPatchane/cozy-store/subscription","commits_url":"https://api.github.com/repos/CPatchane/cozy-store/commits{/sha}","git_commits_url":"https://api.github.com/repos/CPatchane/cozy-store/git/commits{/sha}","comments_url":"https://api.github.com/repos/CPatchane/cozy-store/comments{/number}","issue_comment_url":"https://api.github.com/repos/CPatchane/cozy-store/issues/comments{/number}","contents_url":"https://api.github.com/repos/CPatchane/cozy-store/contents/{+path}","compare_url":"https://api.github.com/repos/CPatchane/cozy-store/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CPatchane/cozy-store/merges","archive_url":"https://api.github.com/repos/CPatchane/cozy-store/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CPatchane/cozy-store/downloads","issues_url":"https://api.github.com/repos/CPatchane/cozy-store/issues{/number}","pulls_url":"https://api.github.com/repos/CPatchane/cozy-store/pulls{/number}","milestones_url":"https://api.github.com/repos/CPatchane/cozy-store/milestones{/number}","notifications_url":"https://api.github.com/repos/CPatchane/cozy-store/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CPatchane/cozy-store/labels{/name}","releases_url":"https://api.github.com/repos/CPatchane/cozy-store/releases{/id}","deployments_url":"https://api.github.com/repos/CPatchane/cozy-store/deployments","created_at":"2017-08-22T11:41:32Z","updated_at":"2018-10-12T15:21:06Z","pushed_at":"2018-12-21T10:07:12Z","git_url":"git://github.com/CPatchane/cozy-store.git","ssh_url":"git@github.com:CPatchane/cozy-store.git","clone_url":"https://github.com/CPatchane/cozy-store.git","svn_url":"https://github.com/CPatchane/cozy-store","homepage":null,"size":4387,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cozy:master","ref":"master","sha":"283a93381ee292d84d3944f584f0873b9c3ac0b4","user":{"login":"cozy","id":7690525,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2OTA1MjU=","avatar_url":"https://avatars0.githubusercontent.com/u/7690525?v=4","gravatar_id":"","url":"https://api.github.com/users/cozy","html_url":"https://github.com/cozy","followers_url":"https://api.github.com/users/cozy/followers","following_url":"https://api.github.com/users/cozy/following{/other_user}","gists_url":"https://api.github.com/users/cozy/gists{/gist_id}","starred_url":"https://api.github.com/users/cozy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cozy/subscriptions","organizations_url":"https://api.github.com/users/cozy/orgs","repos_url":"https://api.github.com/users/cozy/repos","events_url":"https://api.github.com/users/cozy/events{/privacy}","received_events_url":"https://api.github.com/users/cozy/received_events","type":"Organization","site_admin":false},"repo":{"id":98305803,"node_id":"MDEwOlJlcG9zaXRvcnk5ODMwNTgwMw==","name":"cozy-store","full_name":"cozy/cozy-store","private":false,"owner":{"login":"cozy","id":7690525,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2OTA1MjU=","avatar_url":"https://avatars0.githubusercontent.com/u/7690525?v=4","gravatar_id":"","url":"https://api.github.com/users/cozy","html_url":"https://github.com/cozy","followers_url":"https://api.github.com/users/cozy/followers","following_url":"https://api.github.com/users/cozy/following{/other_user}","gists_url":"https://api.github.com/users/cozy/gists{/gist_id}","starred_url":"https://api.github.com/users/cozy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cozy/subscriptions","organizations_url":"https://api.github.com/users/cozy/orgs","repos_url":"https://api.github.com/users/cozy/repos","events_url":"https://api.github.com/users/cozy/events{/privacy}","received_events_url":"https://api.github.com/users/cozy/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cozy/cozy-store","description":"Marketplace app for the Cozy platform","fork":false,"url":"https://api.github.com/repos/cozy/cozy-store","forks_url":"https://api.github.com/repos/cozy/cozy-store/forks","keys_url":"https://api.github.com/repos/cozy/cozy-store/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cozy/cozy-store/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cozy/cozy-store/teams","hooks_url":"https://api.github.com/repos/cozy/cozy-store/hooks","issue_events_url":"https://api.github.com/repos/cozy/cozy-store/issues/events{/number}","events_url":"https://api.github.com/repos/cozy/cozy-store/events","assignees_url":"https://api.github.com/repos/cozy/cozy-store/assignees{/user}","branches_url":"https://api.github.com/repos/cozy/cozy-store/branches{/branch}","tags_url":"https://api.github.com/repos/cozy/cozy-store/tags","blobs_url":"https://api.github.com/repos/cozy/cozy-store/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cozy/cozy-store/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cozy/cozy-store/git/refs{/sha}","trees_url":"https://api.github.com/repos/cozy/cozy-store/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cozy/cozy-store/statuses/{sha}","languages_url":"https://api.github.com/repos/cozy/cozy-store/languages","stargazers_url":"https://api.github.com/repos/cozy/cozy-store/stargazers","contributors_url":"https://api.github.com/repos/cozy/cozy-store/contributors","subscribers_url":"https://api.github.com/repos/cozy/cozy-store/subscribers","subscription_url":"https://api.github.com/repos/cozy/cozy-store/subscription","commits_url":"https://api.github.com/repos/cozy/cozy-store/commits{/sha}","git_commits_url":"https://api.github.com/repos/cozy/cozy-store/git/commits{/sha}","comments_url":"https://api.github.com/repos/cozy/cozy-store/comments{/number}","issue_comment_url":"https://api.github.com/repos/cozy/cozy-store/issues/comments{/number}","contents_url":"https://api.github.com/repos/cozy/cozy-store/contents/{+path}","compare_url":"https://api.github.com/repos/cozy/cozy-store/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cozy/cozy-store/merges","archive_url":"https://api.github.com/repos/cozy/cozy-store/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cozy/cozy-store/downloads","issues_url":"https://api.github.com/repos/cozy/cozy-store/issues{/number}","pulls_url":"https://api.github.com/repos/cozy/cozy-store/pulls{/number}","milestones_url":"https://api.github.com/repos/cozy/cozy-store/milestones{/number}","notifications_url":"https://api.github.com/repos/cozy/cozy-store/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cozy/cozy-store/labels{/name}","releases_url":"https://api.github.com/repos/cozy/cozy-store/releases{/id}","deployments_url":"https://api.github.com/repos/cozy/cozy-store/deployments","created_at":"2017-07-25T12:52:23Z","updated_at":"2018-12-20T16:14:06Z","pushed_at":"2018-12-21T10:07:13Z","git_url":"git://github.com/cozy/cozy-store.git","ssh_url":"git@github.com:cozy/cozy-store.git","clone_url":"https://github.com/cozy/cozy-store.git","svn_url":"https://github.com/cozy/cozy-store","homepage":"","size":13299,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":11,"open_issues":17,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cozy/cozy-store/pulls/496"},"html":{"href":"https://github.com/cozy/cozy-store/pull/496"},"issue":{"href":"https://api.github.com/repos/cozy/cozy-store/issues/496"},"comments":{"href":"https://api.github.com/repos/cozy/cozy-store/issues/496/comments"},"review_comments":{"href":"https://api.github.com/repos/cozy/cozy-store/pulls/496/comments"},"review_comment":{"href":"https://api.github.com/repos/cozy/cozy-store/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cozy/cozy-store/pulls/496/commits"},"statuses":{"href":"https://api.github.com/repos/cozy/cozy-store/statuses/aa994fa6f751d603369c0371f68fb90887e19e12"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"CPatchane"}}