{"action":"created","comment":{"url":"https://api.github.com/repos/prestodb/presto/pulls/comments/240427050","pull_request_review_id":183455771,"id":240427050,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MDQyNzA1MA==","diff_hunk":"@@ -71,4 +64,10 @@ private static Page createPage(List<? extends Type> types, boolean dictionary)\n     {\n         return dictionary ? createSequencePageWithDictionaryBlocks(types, POSITIONS) : createSequencePage(types, POSITIONS);\n     }\n+\n+    private PageProcessor createNewPageProcessor()","path":"presto-main/src/test/java/com/facebook/presto/operator/TestColumnarPageProcessor.java","position":41,"original_position":41,"commit_id":"ff001270738f946824be44becdc528a73b9918fb","original_commit_id":"ff001270738f946824be44becdc528a73b9918fb","user":{"login":"electrum","id":9230,"node_id":"MDQ6VXNlcjkyMzA=","avatar_url":"https://avatars1.githubusercontent.com/u/9230?v=4","gravatar_id":"","url":"https://api.github.com/users/electrum","html_url":"https://github.com/electrum","followers_url":"https://api.github.com/users/electrum/followers","following_url":"https://api.github.com/users/electrum/following{/other_user}","gists_url":"https://api.github.com/users/electrum/gists{/gist_id}","starred_url":"https://api.github.com/users/electrum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electrum/subscriptions","organizations_url":"https://api.github.com/users/electrum/orgs","repos_url":"https://api.github.com/users/electrum/repos","events_url":"https://api.github.com/users/electrum/events{/privacy}","received_events_url":"https://api.github.com/users/electrum/received_events","type":"User","site_admin":false},"body":"`createNew` is a bit redundant, I'd call this `newPageProcessor()`","created_at":"2018-12-10T23:52:50Z","updated_at":"2018-12-10T23:53:10Z","html_url":"https://github.com/prestodb/presto/pull/12045#discussion_r240427050","pull_request_url":"https://api.github.com/repos/prestodb/presto/pulls/12045","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/prestodb/presto/pulls/comments/240427050"},"html":{"href":"https://github.com/prestodb/presto/pull/12045#discussion_r240427050"},"pull_request":{"href":"https://api.github.com/repos/prestodb/presto/pulls/12045"}}},"pull_request":{"url":"https://api.github.com/repos/prestodb/presto/pulls/12045","id":237499774,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3NDk5Nzc0","html_url":"https://github.com/prestodb/presto/pull/12045","diff_url":"https://github.com/prestodb/presto/pull/12045.diff","patch_url":"https://github.com/prestodb/presto/pull/12045.patch","issue_url":"https://api.github.com/repos/prestodb/presto/issues/12045","number":12045,"state":"open","locked":false,"title":"Make sure TestColumnarPageProcessor runs on a single thread","user":{"login":"nezihyigitbasi","id":1223839,"node_id":"MDQ6VXNlcjEyMjM4Mzk=","avatar_url":"https://avatars3.githubusercontent.com/u/1223839?v=4","gravatar_id":"","url":"https://api.github.com/users/nezihyigitbasi","html_url":"https://github.com/nezihyigitbasi","followers_url":"https://api.github.com/users/nezihyigitbasi/followers","following_url":"https://api.github.com/users/nezihyigitbasi/following{/other_user}","gists_url":"https://api.github.com/users/nezihyigitbasi/gists{/gist_id}","starred_url":"https://api.github.com/users/nezihyigitbasi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nezihyigitbasi/subscriptions","organizations_url":"https://api.github.com/users/nezihyigitbasi/orgs","repos_url":"https://api.github.com/users/nezihyigitbasi/repos","events_url":"https://api.github.com/users/nezihyigitbasi/events{/privacy}","received_events_url":"https://api.github.com/users/nezihyigitbasi/received_events","type":"User","site_admin":false},"body":"Otherwise, the processor instance will still be shared by multiple\r\nthreads.\r\n\r\nFollow up for https://github.com/prestodb/presto/pull/12042 per @findepi's comment.","created_at":"2018-12-10T23:18:50Z","updated_at":"2018-12-10T23:53:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"24532012fe3c1f7f635afc049884412fb4399cf7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":196992743,"node_id":"MDU6TGFiZWwxOTY5OTI3NDM=","url":"https://api.github.com/repos/prestodb/presto/labels/CLA%20Signed","name":"CLA Signed","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/prestodb/presto/pulls/12045/commits","review_comments_url":"https://api.github.com/repos/prestodb/presto/pulls/12045/comments","review_comment_url":"https://api.github.com/repos/prestodb/presto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/prestodb/presto/issues/12045/comments","statuses_url":"https://api.github.com/repos/prestodb/presto/statuses/ff001270738f946824be44becdc528a73b9918fb","head":{"label":"nezihyigitbasi:fix-TestColumnarPageProcessor","ref":"fix-TestColumnarPageProcessor","sha":"ff001270738f946824be44becdc528a73b9918fb","user":{"login":"nezihyigitbasi","id":1223839,"node_id":"MDQ6VXNlcjEyMjM4Mzk=","avatar_url":"https://avatars3.githubusercontent.com/u/1223839?v=4","gravatar_id":"","url":"https://api.github.com/users/nezihyigitbasi","html_url":"https://github.com/nezihyigitbasi","followers_url":"https://api.github.com/users/nezihyigitbasi/followers","following_url":"https://api.github.com/users/nezihyigitbasi/following{/other_user}","gists_url":"https://api.github.com/users/nezihyigitbasi/gists{/gist_id}","starred_url":"https://api.github.com/users/nezihyigitbasi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nezihyigitbasi/subscriptions","organizations_url":"https://api.github.com/users/nezihyigitbasi/orgs","repos_url":"https://api.github.com/users/nezihyigitbasi/repos","events_url":"https://api.github.com/users/nezihyigitbasi/events{/privacy}","received_events_url":"https://api.github.com/users/nezihyigitbasi/received_events","type":"User","site_admin":false},"repo":{"id":20698188,"node_id":"MDEwOlJlcG9zaXRvcnkyMDY5ODE4OA==","name":"presto","full_name":"nezihyigitbasi/presto","private":false,"owner":{"login":"nezihyigitbasi","id":1223839,"node_id":"MDQ6VXNlcjEyMjM4Mzk=","avatar_url":"https://avatars3.githubusercontent.com/u/1223839?v=4","gravatar_id":"","url":"https://api.github.com/users/nezihyigitbasi","html_url":"https://github.com/nezihyigitbasi","followers_url":"https://api.github.com/users/nezihyigitbasi/followers","following_url":"https://api.github.com/users/nezihyigitbasi/following{/other_user}","gists_url":"https://api.github.com/users/nezihyigitbasi/gists{/gist_id}","starred_url":"https://api.github.com/users/nezihyigitbasi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nezihyigitbasi/subscriptions","organizations_url":"https://api.github.com/users/nezihyigitbasi/orgs","repos_url":"https://api.github.com/users/nezihyigitbasi/repos","events_url":"https://api.github.com/users/nezihyigitbasi/events{/privacy}","received_events_url":"https://api.github.com/users/nezihyigitbasi/received_events","type":"User","site_admin":false},"html_url":"https://github.com/nezihyigitbasi/presto","description":"Distributed SQL query engine for big data","fork":true,"url":"https://api.github.com/repos/nezihyigitbasi/presto","forks_url":"https://api.github.com/repos/nezihyigitbasi/presto/forks","keys_url":"https://api.github.com/repos/nezihyigitbasi/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nezihyigitbasi/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nezihyigitbasi/presto/teams","hooks_url":"https://api.github.com/repos/nezihyigitbasi/presto/hooks","issue_events_url":"https://api.github.com/repos/nezihyigitbasi/presto/issues/events{/number}","events_url":"https://api.github.com/repos/nezihyigitbasi/presto/events","assignees_url":"https://api.github.com/repos/nezihyigitbasi/presto/assignees{/user}","branches_url":"https://api.github.com/repos/nezihyigitbasi/presto/branches{/branch}","tags_url":"https://api.github.com/repos/nezihyigitbasi/presto/tags","blobs_url":"https://api.github.com/repos/nezihyigitbasi/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nezihyigitbasi/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nezihyigitbasi/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/nezihyigitbasi/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nezihyigitbasi/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/nezihyigitbasi/presto/languages","stargazers_url":"https://api.github.com/repos/nezihyigitbasi/presto/stargazers","contributors_url":"https://api.github.com/repos/nezihyigitbasi/presto/contributors","subscribers_url":"https://api.github.com/repos/nezihyigitbasi/presto/subscribers","subscription_url":"https://api.github.com/repos/nezihyigitbasi/presto/subscription","commits_url":"https://api.github.com/repos/nezihyigitbasi/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/nezihyigitbasi/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/nezihyigitbasi/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/nezihyigitbasi/presto/issues/comments{/number}","contents_url":"https://api.github.com/repos/nezihyigitbasi/presto/contents/{+path}","compare_url":"https://api.github.com/repos/nezihyigitbasi/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nezihyigitbasi/presto/merges","archive_url":"https://api.github.com/repos/nezihyigitbasi/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nezihyigitbasi/presto/downloads","issues_url":"https://api.github.com/repos/nezihyigitbasi/presto/issues{/number}","pulls_url":"https://api.github.com/repos/nezihyigitbasi/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/nezihyigitbasi/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/nezihyigitbasi/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nezihyigitbasi/presto/labels{/name}","releases_url":"https://api.github.com/repos/nezihyigitbasi/presto/releases{/id}","deployments_url":"https://api.github.com/repos/nezihyigitbasi/presto/deployments","created_at":"2014-06-10T19:14:21Z","updated_at":"2018-12-10T22:54:25Z","pushed_at":"2018-12-10T23:35:39Z","git_url":"git://github.com/nezihyigitbasi/presto.git","ssh_url":"git@github.com:nezihyigitbasi/presto.git","clone_url":"https://github.com/nezihyigitbasi/presto.git","svn_url":"https://github.com/nezihyigitbasi/presto","homepage":"http://prestodb.io/","size":104824,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"prestodb:master","ref":"master","sha":"75390c3c7cd92d02e3d68e70abe7199993e9d39d","user":{"login":"prestodb","id":6882181,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4ODIxODE=","avatar_url":"https://avatars0.githubusercontent.com/u/6882181?v=4","gravatar_id":"","url":"https://api.github.com/users/prestodb","html_url":"https://github.com/prestodb","followers_url":"https://api.github.com/users/prestodb/followers","following_url":"https://api.github.com/users/prestodb/following{/other_user}","gists_url":"https://api.github.com/users/prestodb/gists{/gist_id}","starred_url":"https://api.github.com/users/prestodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prestodb/subscriptions","organizations_url":"https://api.github.com/users/prestodb/orgs","repos_url":"https://api.github.com/users/prestodb/repos","events_url":"https://api.github.com/users/prestodb/events{/privacy}","received_events_url":"https://api.github.com/users/prestodb/received_events","type":"Organization","site_admin":false},"repo":{"id":5349565,"node_id":"MDEwOlJlcG9zaXRvcnk1MzQ5NTY1","name":"presto","full_name":"prestodb/presto","private":false,"owner":{"login":"prestodb","id":6882181,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4ODIxODE=","avatar_url":"https://avatars0.githubusercontent.com/u/6882181?v=4","gravatar_id":"","url":"https://api.github.com/users/prestodb","html_url":"https://github.com/prestodb","followers_url":"https://api.github.com/users/prestodb/followers","following_url":"https://api.github.com/users/prestodb/following{/other_user}","gists_url":"https://api.github.com/users/prestodb/gists{/gist_id}","starred_url":"https://api.github.com/users/prestodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prestodb/subscriptions","organizations_url":"https://api.github.com/users/prestodb/orgs","repos_url":"https://api.github.com/users/prestodb/repos","events_url":"https://api.github.com/users/prestodb/events{/privacy}","received_events_url":"https://api.github.com/users/prestodb/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/prestodb/presto","description":"Distributed SQL query engine for big data","fork":false,"url":"https://api.github.com/repos/prestodb/presto","forks_url":"https://api.github.com/repos/prestodb/presto/forks","keys_url":"https://api.github.com/repos/prestodb/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prestodb/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prestodb/presto/teams","hooks_url":"https://api.github.com/repos/prestodb/presto/hooks","issue_events_url":"https://api.github.com/repos/prestodb/presto/issues/events{/number}","events_url":"https://api.github.com/repos/prestodb/presto/events","assignees_url":"https://api.github.com/repos/prestodb/presto/assignees{/user}","branches_url":"https://api.github.com/repos/prestodb/presto/branches{/branch}","tags_url":"https://api.github.com/repos/prestodb/presto/tags","blobs_url":"https://api.github.com/repos/prestodb/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prestodb/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prestodb/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/prestodb/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prestodb/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/prestodb/presto/languages","stargazers_url":"https://api.github.com/repos/prestodb/presto/stargazers","contributors_url":"https://api.github.com/repos/prestodb/presto/contributors","subscribers_url":"https://api.github.com/repos/prestodb/presto/subscribers","subscription_url":"https://api.github.com/repos/prestodb/presto/subscription","commits_url":"https://api.github.com/repos/prestodb/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/prestodb/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/prestodb/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/prestodb/presto/issues/comments{/number}","contents_url":"https://api.github.com/repos/prestodb/presto/contents/{+path}","compare_url":"https://api.github.com/repos/prestodb/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prestodb/presto/merges","archive_url":"https://api.github.com/repos/prestodb/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prestodb/presto/downloads","issues_url":"https://api.github.com/repos/prestodb/presto/issues{/number}","pulls_url":"https://api.github.com/repos/prestodb/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/prestodb/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/prestodb/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prestodb/presto/labels{/name}","releases_url":"https://api.github.com/repos/prestodb/presto/releases{/id}","deployments_url":"https://api.github.com/repos/prestodb/presto/deployments","created_at":"2012-08-09T01:03:37Z","updated_at":"2018-12-10T21:38:43Z","pushed_at":"2018-12-10T23:35:41Z","git_url":"git://github.com/prestodb/presto.git","ssh_url":"git@github.com:prestodb/presto.git","clone_url":"https://github.com/prestodb/presto.git","svn_url":"https://github.com/prestodb/presto","homepage":"https://prestodb.io","size":104975,"stargazers_count":8405,"watchers_count":8405,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2857,"mirror_url":null,"archived":false,"open_issues_count":1485,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2857,"open_issues":1485,"watchers":8405,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prestodb/presto/pulls/12045"},"html":{"href":"https://github.com/prestodb/presto/pull/12045"},"issue":{"href":"https://api.github.com/repos/prestodb/presto/issues/12045"},"comments":{"href":"https://api.github.com/repos/prestodb/presto/issues/12045/comments"},"review_comments":{"href":"https://api.github.com/repos/prestodb/presto/pulls/12045/comments"},"review_comment":{"href":"https://api.github.com/repos/prestodb/presto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/prestodb/presto/pulls/12045/commits"},"statuses":{"href":"https://api.github.com/repos/prestodb/presto/statuses/ff001270738f946824be44becdc528a73b9918fb"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"electrum"}}