{"action":"created","comment":{"url":"https://api.github.com/repos/SergioBenitez/Rocket/pulls/comments/170582019","pull_request_review_id":99287254,"id":170582019,"diff_hunk":"@@ -0,0 +1,69 @@\n+#![feature(plugin, decl_macro)]\n+#![plugin(rocket_codegen)]\n+\n+extern crate rocket;\n+\n+use rocket::response::content;\n+\n+#[head(\"/\")]\n+fn index() -> content::Json<&'static str> {\n+    content::Json(\"{ 'test': 'dont strip before fairing' }\")","path":"lib/tests/fairing_before_head_strip-issue-546.rs","position":10,"original_position":10,"commit_id":"f19c74a73a197551310a81fc99e6a03fd5301ad4","original_commit_id":"f19c74a73a197551310a81fc99e6a03fd5301ad4","user":{"login":"SergioBenitez","id":1480321,"avatar_url":"https://avatars3.githubusercontent.com/u/1480321?v=4","gravatar_id":"","url":"https://api.github.com/users/SergioBenitez","html_url":"https://github.com/SergioBenitez","followers_url":"https://api.github.com/users/SergioBenitez/followers","following_url":"https://api.github.com/users/SergioBenitez/following{/other_user}","gists_url":"https://api.github.com/users/SergioBenitez/gists{/gist_id}","starred_url":"https://api.github.com/users/SergioBenitez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SergioBenitez/subscriptions","organizations_url":"https://api.github.com/users/SergioBenitez/orgs","repos_url":"https://api.github.com/users/SergioBenitez/repos","events_url":"https://api.github.com/users/SergioBenitez/events{/privacy}","received_events_url":"https://api.github.com/users/SergioBenitez/received_events","type":"User","site_admin":false},"body":"Also, is there a reason you're returning `Json` instead of just a `'static str`? It's better to keep it simple and focused on what we're trying to test.","created_at":"2018-02-26T12:56:43Z","updated_at":"2018-02-26T12:59:21Z","html_url":"https://github.com/SergioBenitez/Rocket/pull/557#discussion_r170582019","pull_request_url":"https://api.github.com/repos/SergioBenitez/Rocket/pulls/557","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/SergioBenitez/Rocket/pulls/comments/170582019"},"html":{"href":"https://github.com/SergioBenitez/Rocket/pull/557#discussion_r170582019"},"pull_request":{"href":"https://api.github.com/repos/SergioBenitez/Rocket/pulls/557"}},"in_reply_to_id":170581768},"pull_request":{"url":"https://api.github.com/repos/SergioBenitez/Rocket/pulls/557","id":167004668,"html_url":"https://github.com/SergioBenitez/Rocket/pull/557","diff_url":"https://github.com/SergioBenitez/Rocket/pull/557.diff","patch_url":"https://github.com/SergioBenitez/Rocket/pull/557.patch","issue_url":"https://api.github.com/repos/SergioBenitez/Rocket/issues/557","number":557,"state":"open","locked":false,"title":"HEAD response bodies are stripped before fairings are run","user":{"login":"teuron","id":10895206,"avatar_url":"https://avatars1.githubusercontent.com/u/10895206?v=4","gravatar_id":"","url":"https://api.github.com/users/teuron","html_url":"https://github.com/teuron","followers_url":"https://api.github.com/users/teuron/followers","following_url":"https://api.github.com/users/teuron/following{/other_user}","gists_url":"https://api.github.com/users/teuron/gists{/gist_id}","starred_url":"https://api.github.com/users/teuron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teuron/subscriptions","organizations_url":"https://api.github.com/users/teuron/orgs","repos_url":"https://api.github.com/users/teuron/repos","events_url":"https://api.github.com/users/teuron/events{/privacy}","received_events_url":"https://api.github.com/users/teuron/received_events","type":"User","site_admin":false},"body":"fixed #546 \r\n\r\nWhat needs to be implemented\r\n\r\n- [x]  Test: Fairings should only be called once per request/response pair.\r\n- [x]  Test: Response fairings see a `GET` request for auto-handled `HEAD` requests.\r\n- [x]  Request fairings should be called with the original request.\r\n- [x]  Update the docs to clarify the new constraints.","created_at":"2018-02-04T10:49:25Z","updated_at":"2018-02-26T12:59:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"93377a9b5cb01c5532608eeda93292ce698f5396","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SergioBenitez/Rocket/pulls/557/commits","review_comments_url":"https://api.github.com/repos/SergioBenitez/Rocket/pulls/557/comments","review_comment_url":"https://api.github.com/repos/SergioBenitez/Rocket/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SergioBenitez/Rocket/issues/557/comments","statuses_url":"https://api.github.com/repos/SergioBenitez/Rocket/statuses/f19c74a73a197551310a81fc99e6a03fd5301ad4","head":{"label":"teuron:issue-546","ref":"issue-546","sha":"f19c74a73a197551310a81fc99e6a03fd5301ad4","user":{"login":"teuron","id":10895206,"avatar_url":"https://avatars1.githubusercontent.com/u/10895206?v=4","gravatar_id":"","url":"https://api.github.com/users/teuron","html_url":"https://github.com/teuron","followers_url":"https://api.github.com/users/teuron/followers","following_url":"https://api.github.com/users/teuron/following{/other_user}","gists_url":"https://api.github.com/users/teuron/gists{/gist_id}","starred_url":"https://api.github.com/users/teuron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teuron/subscriptions","organizations_url":"https://api.github.com/users/teuron/orgs","repos_url":"https://api.github.com/users/teuron/repos","events_url":"https://api.github.com/users/teuron/events{/privacy}","received_events_url":"https://api.github.com/users/teuron/received_events","type":"User","site_admin":false},"repo":{"id":120173126,"name":"Rocket","full_name":"teuron/Rocket","owner":{"login":"teuron","id":10895206,"avatar_url":"https://avatars1.githubusercontent.com/u/10895206?v=4","gravatar_id":"","url":"https://api.github.com/users/teuron","html_url":"https://github.com/teuron","followers_url":"https://api.github.com/users/teuron/followers","following_url":"https://api.github.com/users/teuron/following{/other_user}","gists_url":"https://api.github.com/users/teuron/gists{/gist_id}","starred_url":"https://api.github.com/users/teuron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teuron/subscriptions","organizations_url":"https://api.github.com/users/teuron/orgs","repos_url":"https://api.github.com/users/teuron/repos","events_url":"https://api.github.com/users/teuron/events{/privacy}","received_events_url":"https://api.github.com/users/teuron/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/teuron/Rocket","description":"A web framework for Rust.","fork":true,"url":"https://api.github.com/repos/teuron/Rocket","forks_url":"https://api.github.com/repos/teuron/Rocket/forks","keys_url":"https://api.github.com/repos/teuron/Rocket/keys{/key_id}","collaborators_url":"https://api.github.com/repos/teuron/Rocket/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/teuron/Rocket/teams","hooks_url":"https://api.github.com/repos/teuron/Rocket/hooks","issue_events_url":"https://api.github.com/repos/teuron/Rocket/issues/events{/number}","events_url":"https://api.github.com/repos/teuron/Rocket/events","assignees_url":"https://api.github.com/repos/teuron/Rocket/assignees{/user}","branches_url":"https://api.github.com/repos/teuron/Rocket/branches{/branch}","tags_url":"https://api.github.com/repos/teuron/Rocket/tags","blobs_url":"https://api.github.com/repos/teuron/Rocket/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/teuron/Rocket/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/teuron/Rocket/git/refs{/sha}","trees_url":"https://api.github.com/repos/teuron/Rocket/git/trees{/sha}","statuses_url":"https://api.github.com/repos/teuron/Rocket/statuses/{sha}","languages_url":"https://api.github.com/repos/teuron/Rocket/languages","stargazers_url":"https://api.github.com/repos/teuron/Rocket/stargazers","contributors_url":"https://api.github.com/repos/teuron/Rocket/contributors","subscribers_url":"https://api.github.com/repos/teuron/Rocket/subscribers","subscription_url":"https://api.github.com/repos/teuron/Rocket/subscription","commits_url":"https://api.github.com/repos/teuron/Rocket/commits{/sha}","git_commits_url":"https://api.github.com/repos/teuron/Rocket/git/commits{/sha}","comments_url":"https://api.github.com/repos/teuron/Rocket/comments{/number}","issue_comment_url":"https://api.github.com/repos/teuron/Rocket/issues/comments{/number}","contents_url":"https://api.github.com/repos/teuron/Rocket/contents/{+path}","compare_url":"https://api.github.com/repos/teuron/Rocket/compare/{base}...{head}","merges_url":"https://api.github.com/repos/teuron/Rocket/merges","archive_url":"https://api.github.com/repos/teuron/Rocket/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/teuron/Rocket/downloads","issues_url":"https://api.github.com/repos/teuron/Rocket/issues{/number}","pulls_url":"https://api.github.com/repos/teuron/Rocket/pulls{/number}","milestones_url":"https://api.github.com/repos/teuron/Rocket/milestones{/number}","notifications_url":"https://api.github.com/repos/teuron/Rocket/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/teuron/Rocket/labels{/name}","releases_url":"https://api.github.com/repos/teuron/Rocket/releases{/id}","deployments_url":"https://api.github.com/repos/teuron/Rocket/deployments","created_at":"2018-02-04T09:58:49Z","updated_at":"2018-02-04T09:58:51Z","pushed_at":"2018-02-26T10:57:37Z","git_url":"git://github.com/teuron/Rocket.git","ssh_url":"git@github.com:teuron/Rocket.git","clone_url":"https://github.com/teuron/Rocket.git","svn_url":"https://github.com/teuron/Rocket","homepage":"https://rocket.rs","size":2149,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SergioBenitez:master","ref":"master","sha":"8b1aaed0cecb0a26dde8f1aa4ce89a2a4003f957","user":{"login":"SergioBenitez","id":1480321,"avatar_url":"https://avatars3.githubusercontent.com/u/1480321?v=4","gravatar_id":"","url":"https://api.github.com/users/SergioBenitez","html_url":"https://github.com/SergioBenitez","followers_url":"https://api.github.com/users/SergioBenitez/followers","following_url":"https://api.github.com/users/SergioBenitez/following{/other_user}","gists_url":"https://api.github.com/users/SergioBenitez/gists{/gist_id}","starred_url":"https://api.github.com/users/SergioBenitez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SergioBenitez/subscriptions","organizations_url":"https://api.github.com/users/SergioBenitez/orgs","repos_url":"https://api.github.com/users/SergioBenitez/repos","events_url":"https://api.github.com/users/SergioBenitez/events{/privacy}","received_events_url":"https://api.github.com/users/SergioBenitez/received_events","type":"User","site_admin":false},"repo":{"id":54168759,"name":"Rocket","full_name":"SergioBenitez/Rocket","owner":{"login":"SergioBenitez","id":1480321,"avatar_url":"https://avatars3.githubusercontent.com/u/1480321?v=4","gravatar_id":"","url":"https://api.github.com/users/SergioBenitez","html_url":"https://github.com/SergioBenitez","followers_url":"https://api.github.com/users/SergioBenitez/followers","following_url":"https://api.github.com/users/SergioBenitez/following{/other_user}","gists_url":"https://api.github.com/users/SergioBenitez/gists{/gist_id}","starred_url":"https://api.github.com/users/SergioBenitez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SergioBenitez/subscriptions","organizations_url":"https://api.github.com/users/SergioBenitez/orgs","repos_url":"https://api.github.com/users/SergioBenitez/repos","events_url":"https://api.github.com/users/SergioBenitez/events{/privacy}","received_events_url":"https://api.github.com/users/SergioBenitez/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SergioBenitez/Rocket","description":"A web framework for Rust.","fork":false,"url":"https://api.github.com/repos/SergioBenitez/Rocket","forks_url":"https://api.github.com/repos/SergioBenitez/Rocket/forks","keys_url":"https://api.github.com/repos/SergioBenitez/Rocket/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SergioBenitez/Rocket/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SergioBenitez/Rocket/teams","hooks_url":"https://api.github.com/repos/SergioBenitez/Rocket/hooks","issue_events_url":"https://api.github.com/repos/SergioBenitez/Rocket/issues/events{/number}","events_url":"https://api.github.com/repos/SergioBenitez/Rocket/events","assignees_url":"https://api.github.com/repos/SergioBenitez/Rocket/assignees{/user}","branches_url":"https://api.github.com/repos/SergioBenitez/Rocket/branches{/branch}","tags_url":"https://api.github.com/repos/SergioBenitez/Rocket/tags","blobs_url":"https://api.github.com/repos/SergioBenitez/Rocket/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SergioBenitez/Rocket/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SergioBenitez/Rocket/git/refs{/sha}","trees_url":"https://api.github.com/repos/SergioBenitez/Rocket/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SergioBenitez/Rocket/statuses/{sha}","languages_url":"https://api.github.com/repos/SergioBenitez/Rocket/languages","stargazers_url":"https://api.github.com/repos/SergioBenitez/Rocket/stargazers","contributors_url":"https://api.github.com/repos/SergioBenitez/Rocket/contributors","subscribers_url":"https://api.github.com/repos/SergioBenitez/Rocket/subscribers","subscription_url":"https://api.github.com/repos/SergioBenitez/Rocket/subscription","commits_url":"https://api.github.com/repos/SergioBenitez/Rocket/commits{/sha}","git_commits_url":"https://api.github.com/repos/SergioBenitez/Rocket/git/commits{/sha}","comments_url":"https://api.github.com/repos/SergioBenitez/Rocket/comments{/number}","issue_comment_url":"https://api.github.com/repos/SergioBenitez/Rocket/issues/comments{/number}","contents_url":"https://api.github.com/repos/SergioBenitez/Rocket/contents/{+path}","compare_url":"https://api.github.com/repos/SergioBenitez/Rocket/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SergioBenitez/Rocket/merges","archive_url":"https://api.github.com/repos/SergioBenitez/Rocket/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SergioBenitez/Rocket/downloads","issues_url":"https://api.github.com/repos/SergioBenitez/Rocket/issues{/number}","pulls_url":"https://api.github.com/repos/SergioBenitez/Rocket/pulls{/number}","milestones_url":"https://api.github.com/repos/SergioBenitez/Rocket/milestones{/number}","notifications_url":"https://api.github.com/repos/SergioBenitez/Rocket/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SergioBenitez/Rocket/labels{/name}","releases_url":"https://api.github.com/repos/SergioBenitez/Rocket/releases{/id}","deployments_url":"https://api.github.com/repos/SergioBenitez/Rocket/deployments","created_at":"2016-03-18T02:50:18Z","updated_at":"2018-02-26T11:43:40Z","pushed_at":"2018-02-26T10:57:40Z","git_url":"git://github.com/SergioBenitez/Rocket.git","ssh_url":"git@github.com:SergioBenitez/Rocket.git","clone_url":"https://github.com/SergioBenitez/Rocket.git","svn_url":"https://github.com/SergioBenitez/Rocket","homepage":"https://rocket.rs","size":2140,"stargazers_count":3854,"watchers_count":3854,"language":"Rust","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":253,"mirror_url":null,"archived":false,"open_issues_count":94,"license":null,"forks":253,"open_issues":94,"watchers":3854,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SergioBenitez/Rocket/pulls/557"},"html":{"href":"https://github.com/SergioBenitez/Rocket/pull/557"},"issue":{"href":"https://api.github.com/repos/SergioBenitez/Rocket/issues/557"},"comments":{"href":"https://api.github.com/repos/SergioBenitez/Rocket/issues/557/comments"},"review_comments":{"href":"https://api.github.com/repos/SergioBenitez/Rocket/pulls/557/comments"},"review_comment":{"href":"https://api.github.com/repos/SergioBenitez/Rocket/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SergioBenitez/Rocket/pulls/557/commits"},"statuses":{"href":"https://api.github.com/repos/SergioBenitez/Rocket/statuses/f19c74a73a197551310a81fc99e6a03fd5301ad4"}},"author_association":"NONE"}}
{"actor":{"display_login":"SergioBenitez"}}