{"action":"created","issue":{"url":"https://api.github.com/repos/pangeo-data/helm-chart/issues/33","repository_url":"https://api.github.com/repos/pangeo-data/helm-chart","labels_url":"https://api.github.com/repos/pangeo-data/helm-chart/issues/33/labels{/name}","comments_url":"https://api.github.com/repos/pangeo-data/helm-chart/issues/33/comments","events_url":"https://api.github.com/repos/pangeo-data/helm-chart/issues/33/events","html_url":"https://github.com/pangeo-data/helm-chart/pull/33","id":325512747,"number":33,"title":"remove resource specs","user":{"login":"rabernat","id":1197350,"avatar_url":"https://avatars1.githubusercontent.com/u/1197350?v=4","gravatar_id":"","url":"https://api.github.com/users/rabernat","html_url":"https://github.com/rabernat","followers_url":"https://api.github.com/users/rabernat/followers","following_url":"https://api.github.com/users/rabernat/following{/other_user}","gists_url":"https://api.github.com/users/rabernat/gists{/gist_id}","starred_url":"https://api.github.com/users/rabernat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rabernat/subscriptions","organizations_url":"https://api.github.com/users/rabernat/orgs","repos_url":"https://api.github.com/users/rabernat/repos","events_url":"https://api.github.com/users/rabernat/events{/privacy}","received_events_url":"https://api.github.com/users/rabernat/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-05-23T00:59:08Z","updated_at":"2018-05-23T08:56:00Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/pangeo-data/helm-chart/pulls/33","html_url":"https://github.com/pangeo-data/helm-chart/pull/33","diff_url":"https://github.com/pangeo-data/helm-chart/pull/33.diff","patch_url":"https://github.com/pangeo-data/helm-chart/pull/33.patch"},"body":"After some discussion with @tjcrone, I am starting to think that the resource specs should be specified in the deployment-specific config (e.g. [jupyter-config.yaml](https://github.com/pangeo-data/pangeo/blob/master/gce/jupyter-config.yaml) for pangeo.pydata.org), rather than here in the generic helm chart. We override them there already, so their presence here is confusing."},"comment":{"url":"https://api.github.com/repos/pangeo-data/helm-chart/issues/comments/391272833","html_url":"https://github.com/pangeo-data/helm-chart/pull/33#issuecomment-391272833","issue_url":"https://api.github.com/repos/pangeo-data/helm-chart/issues/33","id":391272833,"user":{"login":"jacobtomlinson","id":1610850,"avatar_url":"https://avatars3.githubusercontent.com/u/1610850?v=4","gravatar_id":"","url":"https://api.github.com/users/jacobtomlinson","html_url":"https://github.com/jacobtomlinson","followers_url":"https://api.github.com/users/jacobtomlinson/followers","following_url":"https://api.github.com/users/jacobtomlinson/following{/other_user}","gists_url":"https://api.github.com/users/jacobtomlinson/gists{/gist_id}","starred_url":"https://api.github.com/users/jacobtomlinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacobtomlinson/subscriptions","organizations_url":"https://api.github.com/users/jacobtomlinson/orgs","repos_url":"https://api.github.com/users/jacobtomlinson/repos","events_url":"https://api.github.com/users/jacobtomlinson/events{/privacy}","received_events_url":"https://api.github.com/users/jacobtomlinson/received_events","type":"User","site_admin":false},"created_at":"2018-05-23T08:56:00Z","updated_at":"2018-05-23T08:56:00Z","author_association":"CONTRIBUTOR","body":"I disagree that we should remove these as failing to set these specs can cause knock on issues such as autoscaling not working properly.\r\n\r\nI agree that it is unclear and that we override regularly but perhaps the values should be updated to be suit more use cases and the docs should be updated."}}
{"actor":{"display_login":"jacobtomlinson"}}