{"action":"created","issue":{"url":"https://api.github.com/repos/prometheus/node_exporter/issues/1124","repository_url":"https://api.github.com/repos/prometheus/node_exporter","labels_url":"https://api.github.com/repos/prometheus/node_exporter/issues/1124/labels{/name}","comments_url":"https://api.github.com/repos/prometheus/node_exporter/issues/1124/comments","events_url":"https://api.github.com/repos/prometheus/node_exporter/issues/1124/events","html_url":"https://github.com/prometheus/node_exporter/pull/1124","id":373324539,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1Mjc5Nzc3","number":1124,"title":"collector/bonding_linux: Monitor bond mii_status not link operstate","user":{"login":"nakato","id":1828822,"node_id":"MDQ6VXNlcjE4Mjg4MjI=","avatar_url":"https://avatars0.githubusercontent.com/u/1828822?v=4","gravatar_id":"","url":"https://api.github.com/users/nakato","html_url":"https://github.com/nakato","followers_url":"https://api.github.com/users/nakato/followers","following_url":"https://api.github.com/users/nakato/following{/other_user}","gists_url":"https://api.github.com/users/nakato/gists{/gist_id}","starred_url":"https://api.github.com/users/nakato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nakato/subscriptions","organizations_url":"https://api.github.com/users/nakato/orgs","repos_url":"https://api.github.com/users/nakato/repos","events_url":"https://api.github.com/users/nakato/events{/privacy}","received_events_url":"https://api.github.com/users/nakato/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-10-24T06:29:14Z","updated_at":"2018-11-01T11:21:09Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/prometheus/node_exporter/pulls/1124","html_url":"https://github.com/prometheus/node_exporter/pull/1124","diff_url":"https://github.com/prometheus/node_exporter/pull/1124.diff","patch_url":"https://github.com/prometheus/node_exporter/pull/1124.patch"},"body":"With a bond interface the state of the slave interface from the bond's\r\npoint of view is reflected in `mii_status` and is independent of the\r\nlink's `operstate`.\r\n\r\nWhen a bond is monitored with `miimon`, `mii_status` will reflect the\r\nstate of the physical link as configured via the operator.\r\n\r\nWhen a bond is monitored via `arp_interval` the `mii_status` will\r\nreflect the results of the bond ARP checking.  This means the link can\r\nbe down from the bond's point of view, but up from a physical\r\nconnection point of view.\r\n\r\nIf a bond is not monitored via miimon or arp, the `mii_status` should\r\nlikely be always `up`, however I have observed a case where this is not\r\ntrue and the `operstate` is `up` while `mii_status` is `down`.  Kernel\r\nbond documentation stresses that a bond should not be configured without\r\none of `mii_mon` or `arp_interval` configured however.\r\n\r\nThis change results in the metric 'node_bonding_active' matching the\r\nup/down state of the bond's point of view rather than operstate.\r\n\r\n---\r\n\r\n@SuperQ\r\n@discordianfish"},"comment":{"url":"https://api.github.com/repos/prometheus/node_exporter/issues/comments/435010834","html_url":"https://github.com/prometheus/node_exporter/pull/1124#issuecomment-435010834","issue_url":"https://api.github.com/repos/prometheus/node_exporter/issues/1124","id":435010834,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNTAxMDgzNA==","user":{"login":"SuperQ","id":1320667,"node_id":"MDQ6VXNlcjEzMjA2Njc=","avatar_url":"https://avatars1.githubusercontent.com/u/1320667?v=4","gravatar_id":"","url":"https://api.github.com/users/SuperQ","html_url":"https://github.com/SuperQ","followers_url":"https://api.github.com/users/SuperQ/followers","following_url":"https://api.github.com/users/SuperQ/following{/other_user}","gists_url":"https://api.github.com/users/SuperQ/gists{/gist_id}","starred_url":"https://api.github.com/users/SuperQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SuperQ/subscriptions","organizations_url":"https://api.github.com/users/SuperQ/orgs","repos_url":"https://api.github.com/users/SuperQ/repos","events_url":"https://api.github.com/users/SuperQ/events{/privacy}","received_events_url":"https://api.github.com/users/SuperQ/received_events","type":"User","site_admin":false},"created_at":"2018-11-01T11:21:09Z","updated_at":"2018-11-01T11:21:09Z","author_association":"MEMBER","body":"Yea, I also don't have very many systems with bonding. Maybe @rtreffer or @matthiasr can comment?"}}
{"actor":{"display_login":"SuperQ"}}