{"action":"created","comment":{"url":"https://api.github.com/repos/mono/mono/pulls/comments/199183598","pull_request_review_id":133255956,"id":199183598,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTE4MzU5OA==","diff_hunk":"@@ -3699,32 +3669,46 @@ mono_cominterop_get_com_interface (MonoObject *object, MonoClass *ic, MonoError\n \t\t\treturn NULL;\n \t\tklass = mono_object_class (object);\n \t\tif (!mono_class_is_transparent_proxy (klass)) {\n+\t\t\tif (icall)\n+\t\t\t\tg_assert_not_reached ();\n \t\t\tmono_error_set_invalid_operation (error, \"Class is not transparent\");\n \t\t\treturn NULL;\n \t\t}\n \n \t\treal_proxy = ((MonoTransparentProxy*)object)->rp;\n \t\tif (!real_proxy) {\n+\t\t\tif (icall)\n+\t\t\t\tg_assert_not_reached ();\n \t\t\tmono_error_set_invalid_operation (error, \"RealProxy is null\");\n \t\t\treturn NULL;\n \t\t}\n \n \t\tklass = mono_object_class (real_proxy);\n \t\tif (klass != mono_class_get_interop_proxy_class ()) {\n+\t\t\tif (icall)\n+\t\t\t\tg_assert_not_reached ();","path":"mono/metadata/cominterop.c","position":99,"original_position":99,"commit_id":"3a2d04e98e009e2173dafabf5eba4f48869bcd21","original_commit_id":"3a2d04e98e009e2173dafabf5eba4f48869bcd21","user":{"login":"lambdageek","id":480437,"node_id":"MDQ6VXNlcjQ4MDQzNw==","avatar_url":"https://avatars0.githubusercontent.com/u/480437?v=4","gravatar_id":"","url":"https://api.github.com/users/lambdageek","html_url":"https://github.com/lambdageek","followers_url":"https://api.github.com/users/lambdageek/followers","following_url":"https://api.github.com/users/lambdageek/following{/other_user}","gists_url":"https://api.github.com/users/lambdageek/gists{/gist_id}","starred_url":"https://api.github.com/users/lambdageek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lambdageek/subscriptions","organizations_url":"https://api.github.com/users/lambdageek/orgs","repos_url":"https://api.github.com/users/lambdageek/repos","events_url":"https://api.github.com/users/lambdageek/events{/privacy}","received_events_url":"https://api.github.com/users/lambdageek/received_events","type":"User","site_admin":false},"body":"Same.  Assert in `..._internal` and move the check to the caller.","created_at":"2018-06-29T14:48:02Z","updated_at":"2018-06-29T14:51:27Z","html_url":"https://github.com/mono/mono/pull/9374#discussion_r199183598","pull_request_url":"https://api.github.com/repos/mono/mono/pulls/9374","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/mono/mono/pulls/comments/199183598"},"html":{"href":"https://github.com/mono/mono/pull/9374#discussion_r199183598"},"pull_request":{"href":"https://api.github.com/repos/mono/mono/pulls/9374"}}},"pull_request":{"url":"https://api.github.com/repos/mono/mono/pulls/9374","id":198230038,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4MjMwMDM4","html_url":"https://github.com/mono/mono/pull/9374","diff_url":"https://github.com/mono/mono/pull/9374.diff","patch_url":"https://github.com/mono/mono/pull/9374.patch","issue_url":"https://api.github.com/repos/mono/mono/issues/9374","number":9374,"state":"open","locked":false,"title":"Combine mono_cominterop_get_com_interface and ves_icall_System_Runtime_InteropServices_Marshal_GetIUnknownForObjectInternal which are nearly identical.","user":{"login":"jaykrell","id":1635728,"node_id":"MDQ6VXNlcjE2MzU3Mjg=","avatar_url":"https://avatars1.githubusercontent.com/u/1635728?v=4","gravatar_id":"","url":"https://api.github.com/users/jaykrell","html_url":"https://github.com/jaykrell","followers_url":"https://api.github.com/users/jaykrell/followers","following_url":"https://api.github.com/users/jaykrell/following{/other_user}","gists_url":"https://api.github.com/users/jaykrell/gists{/gist_id}","starred_url":"https://api.github.com/users/jaykrell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaykrell/subscriptions","organizations_url":"https://api.github.com/users/jaykrell/orgs","repos_url":"https://api.github.com/users/jaykrell/repos","events_url":"https://api.github.com/users/jaykrell/events{/privacy}","received_events_url":"https://api.github.com/users/jaykrell/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-06-29T06:53:33Z","updated_at":"2018-06-29T14:51:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bf5ef590d7142717f2ab4645f59b20c50d920137","assignee":null,"assignees":[],"requested_reviewers":[{"login":"kumpera","id":5738,"node_id":"MDQ6VXNlcjU3Mzg=","avatar_url":"https://avatars0.githubusercontent.com/u/5738?v=4","gravatar_id":"","url":"https://api.github.com/users/kumpera","html_url":"https://github.com/kumpera","followers_url":"https://api.github.com/users/kumpera/followers","following_url":"https://api.github.com/users/kumpera/following{/other_user}","gists_url":"https://api.github.com/users/kumpera/gists{/gist_id}","starred_url":"https://api.github.com/users/kumpera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kumpera/subscriptions","organizations_url":"https://api.github.com/users/kumpera/orgs","repos_url":"https://api.github.com/users/kumpera/repos","events_url":"https://api.github.com/users/kumpera/events{/privacy}","received_events_url":"https://api.github.com/users/kumpera/received_events","type":"User","site_admin":false},{"login":"vargaz","id":186301,"node_id":"MDQ6VXNlcjE4NjMwMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/186301?v=4","gravatar_id":"","url":"https://api.github.com/users/vargaz","html_url":"https://github.com/vargaz","followers_url":"https://api.github.com/users/vargaz/followers","following_url":"https://api.github.com/users/vargaz/following{/other_user}","gists_url":"https://api.github.com/users/vargaz/gists{/gist_id}","starred_url":"https://api.github.com/users/vargaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vargaz/subscriptions","organizations_url":"https://api.github.com/users/vargaz/orgs","repos_url":"https://api.github.com/users/vargaz/repos","events_url":"https://api.github.com/users/vargaz/events{/privacy}","received_events_url":"https://api.github.com/users/vargaz/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mono/mono/pulls/9374/commits","review_comments_url":"https://api.github.com/repos/mono/mono/pulls/9374/comments","review_comment_url":"https://api.github.com/repos/mono/mono/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mono/mono/issues/9374/comments","statuses_url":"https://api.github.com/repos/mono/mono/statuses/3a2d04e98e009e2173dafabf5eba4f48869bcd21","head":{"label":"jaykrell:mono_cominterop_get_com_interface","ref":"mono_cominterop_get_com_interface","sha":"3a2d04e98e009e2173dafabf5eba4f48869bcd21","user":{"login":"jaykrell","id":1635728,"node_id":"MDQ6VXNlcjE2MzU3Mjg=","avatar_url":"https://avatars1.githubusercontent.com/u/1635728?v=4","gravatar_id":"","url":"https://api.github.com/users/jaykrell","html_url":"https://github.com/jaykrell","followers_url":"https://api.github.com/users/jaykrell/followers","following_url":"https://api.github.com/users/jaykrell/following{/other_user}","gists_url":"https://api.github.com/users/jaykrell/gists{/gist_id}","starred_url":"https://api.github.com/users/jaykrell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaykrell/subscriptions","organizations_url":"https://api.github.com/users/jaykrell/orgs","repos_url":"https://api.github.com/users/jaykrell/repos","events_url":"https://api.github.com/users/jaykrell/events{/privacy}","received_events_url":"https://api.github.com/users/jaykrell/received_events","type":"User","site_admin":false},"repo":{"id":104803217,"node_id":"MDEwOlJlcG9zaXRvcnkxMDQ4MDMyMTc=","name":"mono","full_name":"jaykrell/mono","owner":{"login":"jaykrell","id":1635728,"node_id":"MDQ6VXNlcjE2MzU3Mjg=","avatar_url":"https://avatars1.githubusercontent.com/u/1635728?v=4","gravatar_id":"","url":"https://api.github.com/users/jaykrell","html_url":"https://github.com/jaykrell","followers_url":"https://api.github.com/users/jaykrell/followers","following_url":"https://api.github.com/users/jaykrell/following{/other_user}","gists_url":"https://api.github.com/users/jaykrell/gists{/gist_id}","starred_url":"https://api.github.com/users/jaykrell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaykrell/subscriptions","organizations_url":"https://api.github.com/users/jaykrell/orgs","repos_url":"https://api.github.com/users/jaykrell/repos","events_url":"https://api.github.com/users/jaykrell/events{/privacy}","received_events_url":"https://api.github.com/users/jaykrell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jaykrell/mono","description":"Mono open source ECMA CLI, C# and .NET implementation.","fork":true,"url":"https://api.github.com/repos/jaykrell/mono","forks_url":"https://api.github.com/repos/jaykrell/mono/forks","keys_url":"https://api.github.com/repos/jaykrell/mono/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jaykrell/mono/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jaykrell/mono/teams","hooks_url":"https://api.github.com/repos/jaykrell/mono/hooks","issue_events_url":"https://api.github.com/repos/jaykrell/mono/issues/events{/number}","events_url":"https://api.github.com/repos/jaykrell/mono/events","assignees_url":"https://api.github.com/repos/jaykrell/mono/assignees{/user}","branches_url":"https://api.github.com/repos/jaykrell/mono/branches{/branch}","tags_url":"https://api.github.com/repos/jaykrell/mono/tags","blobs_url":"https://api.github.com/repos/jaykrell/mono/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jaykrell/mono/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jaykrell/mono/git/refs{/sha}","trees_url":"https://api.github.com/repos/jaykrell/mono/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jaykrell/mono/statuses/{sha}","languages_url":"https://api.github.com/repos/jaykrell/mono/languages","stargazers_url":"https://api.github.com/repos/jaykrell/mono/stargazers","contributors_url":"https://api.github.com/repos/jaykrell/mono/contributors","subscribers_url":"https://api.github.com/repos/jaykrell/mono/subscribers","subscription_url":"https://api.github.com/repos/jaykrell/mono/subscription","commits_url":"https://api.github.com/repos/jaykrell/mono/commits{/sha}","git_commits_url":"https://api.github.com/repos/jaykrell/mono/git/commits{/sha}","comments_url":"https://api.github.com/repos/jaykrell/mono/comments{/number}","issue_comment_url":"https://api.github.com/repos/jaykrell/mono/issues/comments{/number}","contents_url":"https://api.github.com/repos/jaykrell/mono/contents/{+path}","compare_url":"https://api.github.com/repos/jaykrell/mono/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jaykrell/mono/merges","archive_url":"https://api.github.com/repos/jaykrell/mono/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jaykrell/mono/downloads","issues_url":"https://api.github.com/repos/jaykrell/mono/issues{/number}","pulls_url":"https://api.github.com/repos/jaykrell/mono/pulls{/number}","milestones_url":"https://api.github.com/repos/jaykrell/mono/milestones{/number}","notifications_url":"https://api.github.com/repos/jaykrell/mono/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jaykrell/mono/labels{/name}","releases_url":"https://api.github.com/repos/jaykrell/mono/releases{/id}","deployments_url":"https://api.github.com/repos/jaykrell/mono/deployments","created_at":"2017-09-25T21:19:51Z","updated_at":"2018-05-24T09:03:06Z","pushed_at":"2018-06-29T11:54:47Z","git_url":"git://github.com/jaykrell/mono.git","ssh_url":"git@github.com:jaykrell/mono.git","clone_url":"https://github.com/jaykrell/mono.git","svn_url":"https://github.com/jaykrell/mono","homepage":"http://www.mono-project.com/","size":482881,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mono:master","ref":"master","sha":"e271c293ee7a364a853a30f8574830ea84e0481a","user":{"login":"mono","id":53395,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzMzk1","avatar_url":"https://avatars3.githubusercontent.com/u/53395?v=4","gravatar_id":"","url":"https://api.github.com/users/mono","html_url":"https://github.com/mono","followers_url":"https://api.github.com/users/mono/followers","following_url":"https://api.github.com/users/mono/following{/other_user}","gists_url":"https://api.github.com/users/mono/gists{/gist_id}","starred_url":"https://api.github.com/users/mono/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mono/subscriptions","organizations_url":"https://api.github.com/users/mono/orgs","repos_url":"https://api.github.com/users/mono/repos","events_url":"https://api.github.com/users/mono/events{/privacy}","received_events_url":"https://api.github.com/users/mono/received_events","type":"Organization","site_admin":false},"repo":{"id":791611,"node_id":"MDEwOlJlcG9zaXRvcnk3OTE2MTE=","name":"mono","full_name":"mono/mono","owner":{"login":"mono","id":53395,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzMzk1","avatar_url":"https://avatars3.githubusercontent.com/u/53395?v=4","gravatar_id":"","url":"https://api.github.com/users/mono","html_url":"https://github.com/mono","followers_url":"https://api.github.com/users/mono/followers","following_url":"https://api.github.com/users/mono/following{/other_user}","gists_url":"https://api.github.com/users/mono/gists{/gist_id}","starred_url":"https://api.github.com/users/mono/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mono/subscriptions","organizations_url":"https://api.github.com/users/mono/orgs","repos_url":"https://api.github.com/users/mono/repos","events_url":"https://api.github.com/users/mono/events{/privacy}","received_events_url":"https://api.github.com/users/mono/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mono/mono","description":"Mono open source ECMA CLI, C# and .NET implementation.","fork":false,"url":"https://api.github.com/repos/mono/mono","forks_url":"https://api.github.com/repos/mono/mono/forks","keys_url":"https://api.github.com/repos/mono/mono/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mono/mono/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mono/mono/teams","hooks_url":"https://api.github.com/repos/mono/mono/hooks","issue_events_url":"https://api.github.com/repos/mono/mono/issues/events{/number}","events_url":"https://api.github.com/repos/mono/mono/events","assignees_url":"https://api.github.com/repos/mono/mono/assignees{/user}","branches_url":"https://api.github.com/repos/mono/mono/branches{/branch}","tags_url":"https://api.github.com/repos/mono/mono/tags","blobs_url":"https://api.github.com/repos/mono/mono/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mono/mono/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mono/mono/git/refs{/sha}","trees_url":"https://api.github.com/repos/mono/mono/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mono/mono/statuses/{sha}","languages_url":"https://api.github.com/repos/mono/mono/languages","stargazers_url":"https://api.github.com/repos/mono/mono/stargazers","contributors_url":"https://api.github.com/repos/mono/mono/contributors","subscribers_url":"https://api.github.com/repos/mono/mono/subscribers","subscription_url":"https://api.github.com/repos/mono/mono/subscription","commits_url":"https://api.github.com/repos/mono/mono/commits{/sha}","git_commits_url":"https://api.github.com/repos/mono/mono/git/commits{/sha}","comments_url":"https://api.github.com/repos/mono/mono/comments{/number}","issue_comment_url":"https://api.github.com/repos/mono/mono/issues/comments{/number}","contents_url":"https://api.github.com/repos/mono/mono/contents/{+path}","compare_url":"https://api.github.com/repos/mono/mono/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mono/mono/merges","archive_url":"https://api.github.com/repos/mono/mono/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mono/mono/downloads","issues_url":"https://api.github.com/repos/mono/mono/issues{/number}","pulls_url":"https://api.github.com/repos/mono/mono/pulls{/number}","milestones_url":"https://api.github.com/repos/mono/mono/milestones{/number}","notifications_url":"https://api.github.com/repos/mono/mono/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mono/mono/labels{/name}","releases_url":"https://api.github.com/repos/mono/mono/releases{/id}","deployments_url":"https://api.github.com/repos/mono/mono/deployments","created_at":"2010-07-22T18:06:36Z","updated_at":"2018-06-29T14:20:13Z","pushed_at":"2018-06-29T14:43:09Z","git_url":"git://github.com/mono/mono.git","ssh_url":"git@github.com:mono/mono.git","clone_url":"https://github.com/mono/mono.git","svn_url":"https://github.com/mono/mono","homepage":"http://www.mono-project.com/","size":483464,"stargazers_count":6664,"watchers_count":6664,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":2902,"mirror_url":null,"archived":false,"open_issues_count":684,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2902,"open_issues":684,"watchers":6664,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mono/mono/pulls/9374"},"html":{"href":"https://github.com/mono/mono/pull/9374"},"issue":{"href":"https://api.github.com/repos/mono/mono/issues/9374"},"comments":{"href":"https://api.github.com/repos/mono/mono/issues/9374/comments"},"review_comments":{"href":"https://api.github.com/repos/mono/mono/pulls/9374/comments"},"review_comment":{"href":"https://api.github.com/repos/mono/mono/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mono/mono/pulls/9374/commits"},"statuses":{"href":"https://api.github.com/repos/mono/mono/statuses/3a2d04e98e009e2173dafabf5eba4f48869bcd21"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"lambdageek"}}