{"action":"created","comment":{"url":"https://api.github.com/repos/candlepin/candlepin/pulls/comments/219860104","pull_request_review_id":158134475,"id":219860104,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxOTg2MDEwNA==","diff_hunk":"@@ -57,27 +57,74 @@ def _add_attributes(self, node, attributes):\n             logger.debug(\"Setting %s to %s on %s\" % (k, v, node.name))\n             node.setProp(k, v)\n \n+    def _is_different_impl(self, cnode, nnode):\n+        logger.debug(\"Comparing nodes: %s and %s\" % (cnode.name, nnode.name))\n+\n+        # Check if the nodes have different names...\n+        if cnode.name != nnode.name:\n+            logger.debug(\"Node names differ: %s != %s\" % (cnode.name, nnode.name))\n+            return True\n+\n+        # Compare attributes immediately present on both nodes...\n+        cattribs = {}\n+        nattribs = {}\n+\n+        if cnode.properties:\n+            for prop in cnode.properties:","path":"server/bin/update-server-xml.py","position":null,"original_position":17,"commit_id":"12e15831854521bedaa203619057f6aab1dc203d","original_commit_id":"10a416afee7048558779edcfe6e7d61777881b76","user":{"login":"awood","id":17975,"node_id":"MDQ6VXNlcjE3OTc1","avatar_url":"https://avatars3.githubusercontent.com/u/17975?v=4","gravatar_id":"","url":"https://api.github.com/users/awood","html_url":"https://github.com/awood","followers_url":"https://api.github.com/users/awood/followers","following_url":"https://api.github.com/users/awood/following{/other_user}","gists_url":"https://api.github.com/users/awood/gists{/gist_id}","starred_url":"https://api.github.com/users/awood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awood/subscriptions","organizations_url":"https://api.github.com/users/awood/orgs","repos_url":"https://api.github.com/users/awood/repos","events_url":"https://api.github.com/users/awood/events{/privacy}","received_events_url":"https://api.github.com/users/awood/received_events","type":"User","site_admin":false},"body":"Yeah, sorry, I left out that the `if cnode.properties` needs to remain.","created_at":"2018-09-24T14:36:26Z","updated_at":"2018-09-24T14:36:26Z","html_url":"https://github.com/candlepin/candlepin/pull/2119#discussion_r219860104","pull_request_url":"https://api.github.com/repos/candlepin/candlepin/pulls/2119","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/candlepin/candlepin/pulls/comments/219860104"},"html":{"href":"https://github.com/candlepin/candlepin/pull/2119#discussion_r219860104"},"pull_request":{"href":"https://api.github.com/repos/candlepin/candlepin/pulls/2119"}},"in_reply_to_id":219573903},"pull_request":{"url":"https://api.github.com/repos/candlepin/candlepin/pulls/2119","id":217337292,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3MzM3Mjky","html_url":"https://github.com/candlepin/candlepin/pull/2119","diff_url":"https://github.com/candlepin/candlepin/pull/2119.diff","patch_url":"https://github.com/candlepin/candlepin/pull/2119.patch","issue_url":"https://api.github.com/repos/candlepin/candlepin/issues/2119","number":2119,"state":"open","locked":false,"title":"[M] Updated the update-server-xml script for changes required in F28","user":{"login":"Ceiu","id":6061522,"node_id":"MDQ6VXNlcjYwNjE1MjI=","avatar_url":"https://avatars0.githubusercontent.com/u/6061522?v=4","gravatar_id":"","url":"https://api.github.com/users/Ceiu","html_url":"https://github.com/Ceiu","followers_url":"https://api.github.com/users/Ceiu/followers","following_url":"https://api.github.com/users/Ceiu/following{/other_user}","gists_url":"https://api.github.com/users/Ceiu/gists{/gist_id}","starred_url":"https://api.github.com/users/Ceiu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ceiu/subscriptions","organizations_url":"https://api.github.com/users/Ceiu/orgs","repos_url":"https://api.github.com/users/Ceiu/repos","events_url":"https://api.github.com/users/Ceiu/events{/privacy}","received_events_url":"https://api.github.com/users/Ceiu/received_events","type":"User","site_admin":false},"body":"- Updated the update-server-xml.py script such that it generates\r\n  non-deprecated server configuration which does not function\r\n  when running Tomcat on Fedora 28\r\n- Updated the is_different method to check attributes and children\r\n- Attributes are now added to the node by the node editors themselves\r\n  rather than the methods provided by the AbstractBaseEditor","created_at":"2018-09-21T16:27:11Z","updated_at":"2018-09-24T14:36:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c51c0bfe71c7816175535877a3352ced56b516ff","assignee":{"login":"awood","id":17975,"node_id":"MDQ6VXNlcjE3OTc1","avatar_url":"https://avatars3.githubusercontent.com/u/17975?v=4","gravatar_id":"","url":"https://api.github.com/users/awood","html_url":"https://github.com/awood","followers_url":"https://api.github.com/users/awood/followers","following_url":"https://api.github.com/users/awood/following{/other_user}","gists_url":"https://api.github.com/users/awood/gists{/gist_id}","starred_url":"https://api.github.com/users/awood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awood/subscriptions","organizations_url":"https://api.github.com/users/awood/orgs","repos_url":"https://api.github.com/users/awood/repos","events_url":"https://api.github.com/users/awood/events{/privacy}","received_events_url":"https://api.github.com/users/awood/received_events","type":"User","site_admin":false},"assignees":[{"login":"awood","id":17975,"node_id":"MDQ6VXNlcjE3OTc1","avatar_url":"https://avatars3.githubusercontent.com/u/17975?v=4","gravatar_id":"","url":"https://api.github.com/users/awood","html_url":"https://github.com/awood","followers_url":"https://api.github.com/users/awood/followers","following_url":"https://api.github.com/users/awood/following{/other_user}","gists_url":"https://api.github.com/users/awood/gists{/gist_id}","starred_url":"https://api.github.com/users/awood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awood/subscriptions","organizations_url":"https://api.github.com/users/awood/orgs","repos_url":"https://api.github.com/users/awood/repos","events_url":"https://api.github.com/users/awood/events{/privacy}","received_events_url":"https://api.github.com/users/awood/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/candlepin/candlepin/pulls/2119/commits","review_comments_url":"https://api.github.com/repos/candlepin/candlepin/pulls/2119/comments","review_comment_url":"https://api.github.com/repos/candlepin/candlepin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/candlepin/candlepin/issues/2119/comments","statuses_url":"https://api.github.com/repos/candlepin/candlepin/statuses/12e15831854521bedaa203619057f6aab1dc203d","head":{"label":"candlepin:crog/m/update_serverxml_updater","ref":"crog/m/update_serverxml_updater","sha":"12e15831854521bedaa203619057f6aab1dc203d","user":{"login":"candlepin","id":1749632,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NDk2MzI=","avatar_url":"https://avatars1.githubusercontent.com/u/1749632?v=4","gravatar_id":"","url":"https://api.github.com/users/candlepin","html_url":"https://github.com/candlepin","followers_url":"https://api.github.com/users/candlepin/followers","following_url":"https://api.github.com/users/candlepin/following{/other_user}","gists_url":"https://api.github.com/users/candlepin/gists{/gist_id}","starred_url":"https://api.github.com/users/candlepin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/candlepin/subscriptions","organizations_url":"https://api.github.com/users/candlepin/orgs","repos_url":"https://api.github.com/users/candlepin/repos","events_url":"https://api.github.com/users/candlepin/events{/privacy}","received_events_url":"https://api.github.com/users/candlepin/received_events","type":"Organization","site_admin":false},"repo":{"id":4586516,"node_id":"MDEwOlJlcG9zaXRvcnk0NTg2NTE2","name":"candlepin","full_name":"candlepin/candlepin","private":false,"owner":{"login":"candlepin","id":1749632,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NDk2MzI=","avatar_url":"https://avatars1.githubusercontent.com/u/1749632?v=4","gravatar_id":"","url":"https://api.github.com/users/candlepin","html_url":"https://github.com/candlepin","followers_url":"https://api.github.com/users/candlepin/followers","following_url":"https://api.github.com/users/candlepin/following{/other_user}","gists_url":"https://api.github.com/users/candlepin/gists{/gist_id}","starred_url":"https://api.github.com/users/candlepin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/candlepin/subscriptions","organizations_url":"https://api.github.com/users/candlepin/orgs","repos_url":"https://api.github.com/users/candlepin/repos","events_url":"https://api.github.com/users/candlepin/events{/privacy}","received_events_url":"https://api.github.com/users/candlepin/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/candlepin/candlepin","description":"The Candlepin entitlement engine","fork":false,"url":"https://api.github.com/repos/candlepin/candlepin","forks_url":"https://api.github.com/repos/candlepin/candlepin/forks","keys_url":"https://api.github.com/repos/candlepin/candlepin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/candlepin/candlepin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/candlepin/candlepin/teams","hooks_url":"https://api.github.com/repos/candlepin/candlepin/hooks","issue_events_url":"https://api.github.com/repos/candlepin/candlepin/issues/events{/number}","events_url":"https://api.github.com/repos/candlepin/candlepin/events","assignees_url":"https://api.github.com/repos/candlepin/candlepin/assignees{/user}","branches_url":"https://api.github.com/repos/candlepin/candlepin/branches{/branch}","tags_url":"https://api.github.com/repos/candlepin/candlepin/tags","blobs_url":"https://api.github.com/repos/candlepin/candlepin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/candlepin/candlepin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/candlepin/candlepin/git/refs{/sha}","trees_url":"https://api.github.com/repos/candlepin/candlepin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/candlepin/candlepin/statuses/{sha}","languages_url":"https://api.github.com/repos/candlepin/candlepin/languages","stargazers_url":"https://api.github.com/repos/candlepin/candlepin/stargazers","contributors_url":"https://api.github.com/repos/candlepin/candlepin/contributors","subscribers_url":"https://api.github.com/repos/candlepin/candlepin/subscribers","subscription_url":"https://api.github.com/repos/candlepin/candlepin/subscription","commits_url":"https://api.github.com/repos/candlepin/candlepin/commits{/sha}","git_commits_url":"https://api.github.com/repos/candlepin/candlepin/git/commits{/sha}","comments_url":"https://api.github.com/repos/candlepin/candlepin/comments{/number}","issue_comment_url":"https://api.github.com/repos/candlepin/candlepin/issues/comments{/number}","contents_url":"https://api.github.com/repos/candlepin/candlepin/contents/{+path}","compare_url":"https://api.github.com/repos/candlepin/candlepin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/candlepin/candlepin/merges","archive_url":"https://api.github.com/repos/candlepin/candlepin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/candlepin/candlepin/downloads","issues_url":"https://api.github.com/repos/candlepin/candlepin/issues{/number}","pulls_url":"https://api.github.com/repos/candlepin/candlepin/pulls{/number}","milestones_url":"https://api.github.com/repos/candlepin/candlepin/milestones{/number}","notifications_url":"https://api.github.com/repos/candlepin/candlepin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/candlepin/candlepin/labels{/name}","releases_url":"https://api.github.com/repos/candlepin/candlepin/releases{/id}","deployments_url":"https://api.github.com/repos/candlepin/candlepin/deployments","created_at":"2012-06-07T14:58:35Z","updated_at":"2018-09-21T15:39:13Z","pushed_at":"2018-09-24T14:21:00Z","git_url":"git://github.com/candlepin/candlepin.git","ssh_url":"git@github.com:candlepin/candlepin.git","clone_url":"https://github.com/candlepin/candlepin.git","svn_url":"https://github.com/candlepin/candlepin","homepage":"http://candlepinproject.org","size":57068,"stargazers_count":51,"watchers_count":51,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":39,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":39,"open_issues":8,"watchers":51,"default_branch":"master"}},"base":{"label":"candlepin:master","ref":"master","sha":"48bf2f3e74beb577979163001665358ed6bdad08","user":{"login":"candlepin","id":1749632,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NDk2MzI=","avatar_url":"https://avatars1.githubusercontent.com/u/1749632?v=4","gravatar_id":"","url":"https://api.github.com/users/candlepin","html_url":"https://github.com/candlepin","followers_url":"https://api.github.com/users/candlepin/followers","following_url":"https://api.github.com/users/candlepin/following{/other_user}","gists_url":"https://api.github.com/users/candlepin/gists{/gist_id}","starred_url":"https://api.github.com/users/candlepin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/candlepin/subscriptions","organizations_url":"https://api.github.com/users/candlepin/orgs","repos_url":"https://api.github.com/users/candlepin/repos","events_url":"https://api.github.com/users/candlepin/events{/privacy}","received_events_url":"https://api.github.com/users/candlepin/received_events","type":"Organization","site_admin":false},"repo":{"id":4586516,"node_id":"MDEwOlJlcG9zaXRvcnk0NTg2NTE2","name":"candlepin","full_name":"candlepin/candlepin","private":false,"owner":{"login":"candlepin","id":1749632,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NDk2MzI=","avatar_url":"https://avatars1.githubusercontent.com/u/1749632?v=4","gravatar_id":"","url":"https://api.github.com/users/candlepin","html_url":"https://github.com/candlepin","followers_url":"https://api.github.com/users/candlepin/followers","following_url":"https://api.github.com/users/candlepin/following{/other_user}","gists_url":"https://api.github.com/users/candlepin/gists{/gist_id}","starred_url":"https://api.github.com/users/candlepin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/candlepin/subscriptions","organizations_url":"https://api.github.com/users/candlepin/orgs","repos_url":"https://api.github.com/users/candlepin/repos","events_url":"https://api.github.com/users/candlepin/events{/privacy}","received_events_url":"https://api.github.com/users/candlepin/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/candlepin/candlepin","description":"The Candlepin entitlement engine","fork":false,"url":"https://api.github.com/repos/candlepin/candlepin","forks_url":"https://api.github.com/repos/candlepin/candlepin/forks","keys_url":"https://api.github.com/repos/candlepin/candlepin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/candlepin/candlepin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/candlepin/candlepin/teams","hooks_url":"https://api.github.com/repos/candlepin/candlepin/hooks","issue_events_url":"https://api.github.com/repos/candlepin/candlepin/issues/events{/number}","events_url":"https://api.github.com/repos/candlepin/candlepin/events","assignees_url":"https://api.github.com/repos/candlepin/candlepin/assignees{/user}","branches_url":"https://api.github.com/repos/candlepin/candlepin/branches{/branch}","tags_url":"https://api.github.com/repos/candlepin/candlepin/tags","blobs_url":"https://api.github.com/repos/candlepin/candlepin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/candlepin/candlepin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/candlepin/candlepin/git/refs{/sha}","trees_url":"https://api.github.com/repos/candlepin/candlepin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/candlepin/candlepin/statuses/{sha}","languages_url":"https://api.github.com/repos/candlepin/candlepin/languages","stargazers_url":"https://api.github.com/repos/candlepin/candlepin/stargazers","contributors_url":"https://api.github.com/repos/candlepin/candlepin/contributors","subscribers_url":"https://api.github.com/repos/candlepin/candlepin/subscribers","subscription_url":"https://api.github.com/repos/candlepin/candlepin/subscription","commits_url":"https://api.github.com/repos/candlepin/candlepin/commits{/sha}","git_commits_url":"https://api.github.com/repos/candlepin/candlepin/git/commits{/sha}","comments_url":"https://api.github.com/repos/candlepin/candlepin/comments{/number}","issue_comment_url":"https://api.github.com/repos/candlepin/candlepin/issues/comments{/number}","contents_url":"https://api.github.com/repos/candlepin/candlepin/contents/{+path}","compare_url":"https://api.github.com/repos/candlepin/candlepin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/candlepin/candlepin/merges","archive_url":"https://api.github.com/repos/candlepin/candlepin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/candlepin/candlepin/downloads","issues_url":"https://api.github.com/repos/candlepin/candlepin/issues{/number}","pulls_url":"https://api.github.com/repos/candlepin/candlepin/pulls{/number}","milestones_url":"https://api.github.com/repos/candlepin/candlepin/milestones{/number}","notifications_url":"https://api.github.com/repos/candlepin/candlepin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/candlepin/candlepin/labels{/name}","releases_url":"https://api.github.com/repos/candlepin/candlepin/releases{/id}","deployments_url":"https://api.github.com/repos/candlepin/candlepin/deployments","created_at":"2012-06-07T14:58:35Z","updated_at":"2018-09-21T15:39:13Z","pushed_at":"2018-09-24T14:21:00Z","git_url":"git://github.com/candlepin/candlepin.git","ssh_url":"git@github.com:candlepin/candlepin.git","clone_url":"https://github.com/candlepin/candlepin.git","svn_url":"https://github.com/candlepin/candlepin","homepage":"http://candlepinproject.org","size":57068,"stargazers_count":51,"watchers_count":51,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":39,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":39,"open_issues":8,"watchers":51,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/candlepin/candlepin/pulls/2119"},"html":{"href":"https://github.com/candlepin/candlepin/pull/2119"},"issue":{"href":"https://api.github.com/repos/candlepin/candlepin/issues/2119"},"comments":{"href":"https://api.github.com/repos/candlepin/candlepin/issues/2119/comments"},"review_comments":{"href":"https://api.github.com/repos/candlepin/candlepin/pulls/2119/comments"},"review_comment":{"href":"https://api.github.com/repos/candlepin/candlepin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/candlepin/candlepin/pulls/2119/commits"},"statuses":{"href":"https://api.github.com/repos/candlepin/candlepin/statuses/12e15831854521bedaa203619057f6aab1dc203d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"awood"}}