{"action":"opened","number":1906,"pull_request":{"url":"https://api.github.com/repos/OpenRefine/OpenRefine/pulls/1906","id":237658034,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3NjU4MDM0","html_url":"https://github.com/OpenRefine/OpenRefine/pull/1906","diff_url":"https://github.com/OpenRefine/OpenRefine/pull/1906.diff","patch_url":"https://github.com/OpenRefine/OpenRefine/pull/1906.patch","issue_url":"https://api.github.com/repos/OpenRefine/OpenRefine/issues/1906","number":1906,"state":"open","locked":false,"title":"Make clustering extensible","user":{"login":"wetneb","id":309908,"node_id":"MDQ6VXNlcjMwOTkwOA==","avatar_url":"https://avatars1.githubusercontent.com/u/309908?v=4","gravatar_id":"","url":"https://api.github.com/users/wetneb","html_url":"https://github.com/wetneb","followers_url":"https://api.github.com/users/wetneb/followers","following_url":"https://api.github.com/users/wetneb/following{/other_user}","gists_url":"https://api.github.com/users/wetneb/gists{/gist_id}","starred_url":"https://api.github.com/users/wetneb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wetneb/subscriptions","organizations_url":"https://api.github.com/users/wetneb/orgs","repos_url":"https://api.github.com/users/wetneb/repos","events_url":"https://api.github.com/users/wetneb/events{/privacy}","received_events_url":"https://api.github.com/users/wetneb/received_events","type":"User","site_admin":false},"body":"This makes it possible for extensions to register custom fingerprint functions and clustering distances.\r\n\r\nBy doing so it exposes in the UI all such distances and fingerprints supported by the backend. This needs careful reviewing - why were these features not exposed in the UI before? For instance, are the various metaphone versions useful to have or should we only keep Metaphone3? It looks like the Soundex keyer was disabled for a good reason (not robust enough):\r\n```\r\n11:54:20.732 [                   refine] POST /command/core/compute-clusters (1507ms)\r\n11:54:20.733 [                  command] Exception caught (1ms)\r\njava.lang.IllegalArgumentException: The character is not mapped: À\r\n\tat org.apache.commons.codec.language.Soundex.map(Soundex.java:227)\r\n\tat org.apache.commons.codec.language.Soundex.getMappingCode(Soundex.java:181)\r\n\tat org.apache.commons.codec.language.Soundex.soundex(Soundex.java:265)\r\n\tat com.google.refine.clustering.binning.SoundexKeyer.key(SoundexKeyer.java:48)\r\n\tat com.google.refine.clustering.binning.BinningClusterer$BinningRowVisitor.visit(BinningClusterer.java:165)\r\n```\r\n\r\nSo we need to review these clustering methods and unregister the unwanted ones from the backend. Maybe @tfmorris has some insights to share about this?\r\n\r\nCloses #1893.","created_at":"2018-12-11T12:18:05Z","updated_at":"2018-12-11T12:18:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/OpenRefine/OpenRefine/pulls/1906/commits","review_comments_url":"https://api.github.com/repos/OpenRefine/OpenRefine/pulls/1906/comments","review_comment_url":"https://api.github.com/repos/OpenRefine/OpenRefine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenRefine/OpenRefine/issues/1906/comments","statuses_url":"https://api.github.com/repos/OpenRefine/OpenRefine/statuses/22cf0517b9165aac34e5cbd0e675dfc528ce8e2c","head":{"label":"OpenRefine:issue1893","ref":"issue1893","sha":"22cf0517b9165aac34e5cbd0e675dfc528ce8e2c","user":{"login":"OpenRefine","id":2538880,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1Mzg4ODA=","avatar_url":"https://avatars0.githubusercontent.com/u/2538880?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenRefine","html_url":"https://github.com/OpenRefine","followers_url":"https://api.github.com/users/OpenRefine/followers","following_url":"https://api.github.com/users/OpenRefine/following{/other_user}","gists_url":"https://api.github.com/users/OpenRefine/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenRefine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenRefine/subscriptions","organizations_url":"https://api.github.com/users/OpenRefine/orgs","repos_url":"https://api.github.com/users/OpenRefine/repos","events_url":"https://api.github.com/users/OpenRefine/events{/privacy}","received_events_url":"https://api.github.com/users/OpenRefine/received_events","type":"Organization","site_admin":false},"repo":{"id":6220644,"node_id":"MDEwOlJlcG9zaXRvcnk2MjIwNjQ0","name":"OpenRefine","full_name":"OpenRefine/OpenRefine","private":false,"owner":{"login":"OpenRefine","id":2538880,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1Mzg4ODA=","avatar_url":"https://avatars0.githubusercontent.com/u/2538880?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenRefine","html_url":"https://github.com/OpenRefine","followers_url":"https://api.github.com/users/OpenRefine/followers","following_url":"https://api.github.com/users/OpenRefine/following{/other_user}","gists_url":"https://api.github.com/users/OpenRefine/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenRefine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenRefine/subscriptions","organizations_url":"https://api.github.com/users/OpenRefine/orgs","repos_url":"https://api.github.com/users/OpenRefine/repos","events_url":"https://api.github.com/users/OpenRefine/events{/privacy}","received_events_url":"https://api.github.com/users/OpenRefine/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/OpenRefine/OpenRefine","description":"OpenRefine is a free, open source power tool for working with messy data and improving it","fork":false,"url":"https://api.github.com/repos/OpenRefine/OpenRefine","forks_url":"https://api.github.com/repos/OpenRefine/OpenRefine/forks","keys_url":"https://api.github.com/repos/OpenRefine/OpenRefine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenRefine/OpenRefine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenRefine/OpenRefine/teams","hooks_url":"https://api.github.com/repos/OpenRefine/OpenRefine/hooks","issue_events_url":"https://api.github.com/repos/OpenRefine/OpenRefine/issues/events{/number}","events_url":"https://api.github.com/repos/OpenRefine/OpenRefine/events","assignees_url":"https://api.github.com/repos/OpenRefine/OpenRefine/assignees{/user}","branches_url":"https://api.github.com/repos/OpenRefine/OpenRefine/branches{/branch}","tags_url":"https://api.github.com/repos/OpenRefine/OpenRefine/tags","blobs_url":"https://api.github.com/repos/OpenRefine/OpenRefine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenRefine/OpenRefine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenRefine/OpenRefine/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenRefine/OpenRefine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenRefine/OpenRefine/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenRefine/OpenRefine/languages","stargazers_url":"https://api.github.com/repos/OpenRefine/OpenRefine/stargazers","contributors_url":"https://api.github.com/repos/OpenRefine/OpenRefine/contributors","subscribers_url":"https://api.github.com/repos/OpenRefine/OpenRefine/subscribers","subscription_url":"https://api.github.com/repos/OpenRefine/OpenRefine/subscription","commits_url":"https://api.github.com/repos/OpenRefine/OpenRefine/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenRefine/OpenRefine/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenRefine/OpenRefine/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenRefine/OpenRefine/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenRefine/OpenRefine/contents/{+path}","compare_url":"https://api.github.com/repos/OpenRefine/OpenRefine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenRefine/OpenRefine/merges","archive_url":"https://api.github.com/repos/OpenRefine/OpenRefine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenRefine/OpenRefine/downloads","issues_url":"https://api.github.com/repos/OpenRefine/OpenRefine/issues{/number}","pulls_url":"https://api.github.com/repos/OpenRefine/OpenRefine/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenRefine/OpenRefine/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenRefine/OpenRefine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenRefine/OpenRefine/labels{/name}","releases_url":"https://api.github.com/repos/OpenRefine/OpenRefine/releases{/id}","deployments_url":"https://api.github.com/repos/OpenRefine/OpenRefine/deployments","created_at":"2012-10-15T02:22:48Z","updated_at":"2018-12-11T03:07:10Z","pushed_at":"2018-12-11T12:17:09Z","git_url":"git://github.com/OpenRefine/OpenRefine.git","ssh_url":"git@github.com:OpenRefine/OpenRefine.git","clone_url":"https://github.com/OpenRefine/OpenRefine.git","svn_url":"https://github.com/OpenRefine/OpenRefine","homepage":"http://openrefine.org/","size":363972,"stargazers_count":5786,"watchers_count":5786,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1029,"mirror_url":null,"archived":false,"open_issues_count":376,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":1029,"open_issues":376,"watchers":5786,"default_branch":"master"}},"base":{"label":"OpenRefine:master","ref":"master","sha":"8eb08f3985e2b42ffbb5a34b4a24f5c86b5047ef","user":{"login":"OpenRefine","id":2538880,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1Mzg4ODA=","avatar_url":"https://avatars0.githubusercontent.com/u/2538880?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenRefine","html_url":"https://github.com/OpenRefine","followers_url":"https://api.github.com/users/OpenRefine/followers","following_url":"https://api.github.com/users/OpenRefine/following{/other_user}","gists_url":"https://api.github.com/users/OpenRefine/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenRefine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenRefine/subscriptions","organizations_url":"https://api.github.com/users/OpenRefine/orgs","repos_url":"https://api.github.com/users/OpenRefine/repos","events_url":"https://api.github.com/users/OpenRefine/events{/privacy}","received_events_url":"https://api.github.com/users/OpenRefine/received_events","type":"Organization","site_admin":false},"repo":{"id":6220644,"node_id":"MDEwOlJlcG9zaXRvcnk2MjIwNjQ0","name":"OpenRefine","full_name":"OpenRefine/OpenRefine","private":false,"owner":{"login":"OpenRefine","id":2538880,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1Mzg4ODA=","avatar_url":"https://avatars0.githubusercontent.com/u/2538880?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenRefine","html_url":"https://github.com/OpenRefine","followers_url":"https://api.github.com/users/OpenRefine/followers","following_url":"https://api.github.com/users/OpenRefine/following{/other_user}","gists_url":"https://api.github.com/users/OpenRefine/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenRefine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenRefine/subscriptions","organizations_url":"https://api.github.com/users/OpenRefine/orgs","repos_url":"https://api.github.com/users/OpenRefine/repos","events_url":"https://api.github.com/users/OpenRefine/events{/privacy}","received_events_url":"https://api.github.com/users/OpenRefine/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/OpenRefine/OpenRefine","description":"OpenRefine is a free, open source power tool for working with messy data and improving it","fork":false,"url":"https://api.github.com/repos/OpenRefine/OpenRefine","forks_url":"https://api.github.com/repos/OpenRefine/OpenRefine/forks","keys_url":"https://api.github.com/repos/OpenRefine/OpenRefine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenRefine/OpenRefine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenRefine/OpenRefine/teams","hooks_url":"https://api.github.com/repos/OpenRefine/OpenRefine/hooks","issue_events_url":"https://api.github.com/repos/OpenRefine/OpenRefine/issues/events{/number}","events_url":"https://api.github.com/repos/OpenRefine/OpenRefine/events","assignees_url":"https://api.github.com/repos/OpenRefine/OpenRefine/assignees{/user}","branches_url":"https://api.github.com/repos/OpenRefine/OpenRefine/branches{/branch}","tags_url":"https://api.github.com/repos/OpenRefine/OpenRefine/tags","blobs_url":"https://api.github.com/repos/OpenRefine/OpenRefine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenRefine/OpenRefine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenRefine/OpenRefine/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenRefine/OpenRefine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenRefine/OpenRefine/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenRefine/OpenRefine/languages","stargazers_url":"https://api.github.com/repos/OpenRefine/OpenRefine/stargazers","contributors_url":"https://api.github.com/repos/OpenRefine/OpenRefine/contributors","subscribers_url":"https://api.github.com/repos/OpenRefine/OpenRefine/subscribers","subscription_url":"https://api.github.com/repos/OpenRefine/OpenRefine/subscription","commits_url":"https://api.github.com/repos/OpenRefine/OpenRefine/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenRefine/OpenRefine/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenRefine/OpenRefine/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenRefine/OpenRefine/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenRefine/OpenRefine/contents/{+path}","compare_url":"https://api.github.com/repos/OpenRefine/OpenRefine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenRefine/OpenRefine/merges","archive_url":"https://api.github.com/repos/OpenRefine/OpenRefine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenRefine/OpenRefine/downloads","issues_url":"https://api.github.com/repos/OpenRefine/OpenRefine/issues{/number}","pulls_url":"https://api.github.com/repos/OpenRefine/OpenRefine/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenRefine/OpenRefine/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenRefine/OpenRefine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenRefine/OpenRefine/labels{/name}","releases_url":"https://api.github.com/repos/OpenRefine/OpenRefine/releases{/id}","deployments_url":"https://api.github.com/repos/OpenRefine/OpenRefine/deployments","created_at":"2012-10-15T02:22:48Z","updated_at":"2018-12-11T03:07:10Z","pushed_at":"2018-12-11T12:17:09Z","git_url":"git://github.com/OpenRefine/OpenRefine.git","ssh_url":"git@github.com:OpenRefine/OpenRefine.git","clone_url":"https://github.com/OpenRefine/OpenRefine.git","svn_url":"https://github.com/OpenRefine/OpenRefine","homepage":"http://openrefine.org/","size":363972,"stargazers_count":5786,"watchers_count":5786,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1029,"mirror_url":null,"archived":false,"open_issues_count":376,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":1029,"open_issues":376,"watchers":5786,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenRefine/OpenRefine/pulls/1906"},"html":{"href":"https://github.com/OpenRefine/OpenRefine/pull/1906"},"issue":{"href":"https://api.github.com/repos/OpenRefine/OpenRefine/issues/1906"},"comments":{"href":"https://api.github.com/repos/OpenRefine/OpenRefine/issues/1906/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenRefine/OpenRefine/pulls/1906/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenRefine/OpenRefine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenRefine/OpenRefine/pulls/1906/commits"},"statuses":{"href":"https://api.github.com/repos/OpenRefine/OpenRefine/statuses/22cf0517b9165aac34e5cbd0e675dfc528ce8e2c"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":6,"additions":554,"deletions":145,"changed_files":26}}
{"actor":{"display_login":"wetneb"}}