{"action":"created","comment":{"url":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/pulls/comments/232769562","pull_request_review_id":174040665,"id":232769562,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjc2OTU2Mg==","diff_hunk":"@@ -181,7 +181,7 @@ PRIMARY KEY (`NodeId`)\n \r\n CREATE TABLE IF NOT EXISTS `Users` (\r\n `UserId` int(10) unsigned NOT NULL AUTO_INCREMENT,\r\n-`StudentCardId` int(10) unsigned NOT NULL,\r\n+`StudentCardId` int(10) unsigned NULL,\r","path":"dbCreate.sql","position":14,"original_position":14,"commit_id":"c163c3f85e7956ddb52318bb96157b2936422628","original_commit_id":"c163c3f85e7956ddb52318bb96157b2936422628","user":{"login":"JamieMac96","id":15239272,"node_id":"MDQ6VXNlcjE1MjM5Mjcy","avatar_url":"https://avatars3.githubusercontent.com/u/15239272?v=4","gravatar_id":"","url":"https://api.github.com/users/JamieMac96","html_url":"https://github.com/JamieMac96","followers_url":"https://api.github.com/users/JamieMac96/followers","following_url":"https://api.github.com/users/JamieMac96/following{/other_user}","gists_url":"https://api.github.com/users/JamieMac96/gists{/gist_id}","starred_url":"https://api.github.com/users/JamieMac96/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JamieMac96/subscriptions","organizations_url":"https://api.github.com/users/JamieMac96/orgs","repos_url":"https://api.github.com/users/JamieMac96/repos","events_url":"https://api.github.com/users/JamieMac96/events{/privacy}","received_events_url":"https://api.github.com/users/JamieMac96/received_events","type":"User","site_admin":false},"body":"I don't think the NULL is necessary here, you could set the default to NULL. I'm not sure what effect, if any, this will have but might be worth testing before we merge.","created_at":"2018-11-12T18:40:46Z","updated_at":"2018-11-12T18:47:44Z","html_url":"https://github.com/dannoonan/SystemsAnalysisDesignProject/pull/15#discussion_r232769562","pull_request_url":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/pulls/15","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/pulls/comments/232769562"},"html":{"href":"https://github.com/dannoonan/SystemsAnalysisDesignProject/pull/15#discussion_r232769562"},"pull_request":{"href":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/pulls/15"}}},"pull_request":{"url":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/pulls/15","id":230225675,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwMjI1Njc1","html_url":"https://github.com/dannoonan/SystemsAnalysisDesignProject/pull/15","diff_url":"https://github.com/dannoonan/SystemsAnalysisDesignProject/pull/15.diff","patch_url":"https://github.com/dannoonan/SystemsAnalysisDesignProject/pull/15.patch","issue_url":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/issues/15","number":15,"state":"open","locked":false,"title":"Updated DB script:","user":{"login":"RoryEgan","id":6561056,"node_id":"MDQ6VXNlcjY1NjEwNTY=","avatar_url":"https://avatars3.githubusercontent.com/u/6561056?v=4","gravatar_id":"","url":"https://api.github.com/users/RoryEgan","html_url":"https://github.com/RoryEgan","followers_url":"https://api.github.com/users/RoryEgan/followers","following_url":"https://api.github.com/users/RoryEgan/following{/other_user}","gists_url":"https://api.github.com/users/RoryEgan/gists{/gist_id}","starred_url":"https://api.github.com/users/RoryEgan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RoryEgan/subscriptions","organizations_url":"https://api.github.com/users/RoryEgan/orgs","repos_url":"https://api.github.com/users/RoryEgan/repos","events_url":"https://api.github.com/users/RoryEgan/events{/privacy}","received_events_url":"https://api.github.com/users/RoryEgan/received_events","type":"User","site_admin":false},"body":"StudentCard balance changed to float.\r\nStudentCardId foreign key in Users table can be optionally null.\r\nMinor changes to boolean names.\r\nAdded tables for collection and repair scheduling.","created_at":"2018-11-12T18:17:13Z","updated_at":"2018-11-12T18:47:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"02ded41663052ebc52dd4583998ed482ef764659","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/pulls/15/commits","review_comments_url":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/pulls/15/comments","review_comment_url":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/issues/15/comments","statuses_url":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/statuses/c163c3f85e7956ddb52318bb96157b2936422628","head":{"label":"dannoonan:refactor-db-script","ref":"refactor-db-script","sha":"c163c3f85e7956ddb52318bb96157b2936422628","user":{"login":"dannoonan","id":25910864,"node_id":"MDQ6VXNlcjI1OTEwODY0","avatar_url":"https://avatars2.githubusercontent.com/u/25910864?v=4","gravatar_id":"","url":"https://api.github.com/users/dannoonan","html_url":"https://github.com/dannoonan","followers_url":"https://api.github.com/users/dannoonan/followers","following_url":"https://api.github.com/users/dannoonan/following{/other_user}","gists_url":"https://api.github.com/users/dannoonan/gists{/gist_id}","starred_url":"https://api.github.com/users/dannoonan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dannoonan/subscriptions","organizations_url":"https://api.github.com/users/dannoonan/orgs","repos_url":"https://api.github.com/users/dannoonan/repos","events_url":"https://api.github.com/users/dannoonan/events{/privacy}","received_events_url":"https://api.github.com/users/dannoonan/received_events","type":"User","site_admin":false},"repo":{"id":150885838,"node_id":"MDEwOlJlcG9zaXRvcnkxNTA4ODU4Mzg=","name":"SystemsAnalysisDesignProject","full_name":"dannoonan/SystemsAnalysisDesignProject","private":false,"owner":{"login":"dannoonan","id":25910864,"node_id":"MDQ6VXNlcjI1OTEwODY0","avatar_url":"https://avatars2.githubusercontent.com/u/25910864?v=4","gravatar_id":"","url":"https://api.github.com/users/dannoonan","html_url":"https://github.com/dannoonan","followers_url":"https://api.github.com/users/dannoonan/followers","following_url":"https://api.github.com/users/dannoonan/following{/other_user}","gists_url":"https://api.github.com/users/dannoonan/gists{/gist_id}","starred_url":"https://api.github.com/users/dannoonan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dannoonan/subscriptions","organizations_url":"https://api.github.com/users/dannoonan/orgs","repos_url":"https://api.github.com/users/dannoonan/repos","events_url":"https://api.github.com/users/dannoonan/events{/privacy}","received_events_url":"https://api.github.com/users/dannoonan/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dannoonan/SystemsAnalysisDesignProject","description":null,"fork":false,"url":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject","forks_url":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/forks","keys_url":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/teams","hooks_url":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/hooks","issue_events_url":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/issues/events{/number}","events_url":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/events","assignees_url":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/assignees{/user}","branches_url":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/branches{/branch}","tags_url":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/tags","blobs_url":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/git/refs{/sha}","trees_url":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/statuses/{sha}","languages_url":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/languages","stargazers_url":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/stargazers","contributors_url":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/contributors","subscribers_url":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/subscribers","subscription_url":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/subscription","commits_url":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/commits{/sha}","git_commits_url":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/git/commits{/sha}","comments_url":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/comments{/number}","issue_comment_url":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/issues/comments{/number}","contents_url":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/contents/{+path}","compare_url":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/merges","archive_url":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/downloads","issues_url":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/issues{/number}","pulls_url":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/pulls{/number}","milestones_url":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/milestones{/number}","notifications_url":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/labels{/name}","releases_url":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/releases{/id}","deployments_url":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/deployments","created_at":"2018-09-29T17:08:40Z","updated_at":"2018-11-11T15:30:58Z","pushed_at":"2018-11-12T18:17:13Z","git_url":"git://github.com/dannoonan/SystemsAnalysisDesignProject.git","ssh_url":"git@github.com:dannoonan/SystemsAnalysisDesignProject.git","clone_url":"https://github.com/dannoonan/SystemsAnalysisDesignProject.git","svn_url":"https://github.com/dannoonan/SystemsAnalysisDesignProject","homepage":null,"size":83936,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":3,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"dannoonan:master","ref":"master","sha":"e373b3504089543f8d52a615e92deb3cacfdaa2e","user":{"login":"dannoonan","id":25910864,"node_id":"MDQ6VXNlcjI1OTEwODY0","avatar_url":"https://avatars2.githubusercontent.com/u/25910864?v=4","gravatar_id":"","url":"https://api.github.com/users/dannoonan","html_url":"https://github.com/dannoonan","followers_url":"https://api.github.com/users/dannoonan/followers","following_url":"https://api.github.com/users/dannoonan/following{/other_user}","gists_url":"https://api.github.com/users/dannoonan/gists{/gist_id}","starred_url":"https://api.github.com/users/dannoonan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dannoonan/subscriptions","organizations_url":"https://api.github.com/users/dannoonan/orgs","repos_url":"https://api.github.com/users/dannoonan/repos","events_url":"https://api.github.com/users/dannoonan/events{/privacy}","received_events_url":"https://api.github.com/users/dannoonan/received_events","type":"User","site_admin":false},"repo":{"id":150885838,"node_id":"MDEwOlJlcG9zaXRvcnkxNTA4ODU4Mzg=","name":"SystemsAnalysisDesignProject","full_name":"dannoonan/SystemsAnalysisDesignProject","private":false,"owner":{"login":"dannoonan","id":25910864,"node_id":"MDQ6VXNlcjI1OTEwODY0","avatar_url":"https://avatars2.githubusercontent.com/u/25910864?v=4","gravatar_id":"","url":"https://api.github.com/users/dannoonan","html_url":"https://github.com/dannoonan","followers_url":"https://api.github.com/users/dannoonan/followers","following_url":"https://api.github.com/users/dannoonan/following{/other_user}","gists_url":"https://api.github.com/users/dannoonan/gists{/gist_id}","starred_url":"https://api.github.com/users/dannoonan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dannoonan/subscriptions","organizations_url":"https://api.github.com/users/dannoonan/orgs","repos_url":"https://api.github.com/users/dannoonan/repos","events_url":"https://api.github.com/users/dannoonan/events{/privacy}","received_events_url":"https://api.github.com/users/dannoonan/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dannoonan/SystemsAnalysisDesignProject","description":null,"fork":false,"url":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject","forks_url":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/forks","keys_url":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/teams","hooks_url":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/hooks","issue_events_url":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/issues/events{/number}","events_url":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/events","assignees_url":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/assignees{/user}","branches_url":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/branches{/branch}","tags_url":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/tags","blobs_url":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/git/refs{/sha}","trees_url":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/statuses/{sha}","languages_url":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/languages","stargazers_url":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/stargazers","contributors_url":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/contributors","subscribers_url":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/subscribers","subscription_url":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/subscription","commits_url":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/commits{/sha}","git_commits_url":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/git/commits{/sha}","comments_url":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/comments{/number}","issue_comment_url":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/issues/comments{/number}","contents_url":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/contents/{+path}","compare_url":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/merges","archive_url":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/downloads","issues_url":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/issues{/number}","pulls_url":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/pulls{/number}","milestones_url":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/milestones{/number}","notifications_url":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/labels{/name}","releases_url":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/releases{/id}","deployments_url":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/deployments","created_at":"2018-09-29T17:08:40Z","updated_at":"2018-11-11T15:30:58Z","pushed_at":"2018-11-12T18:17:13Z","git_url":"git://github.com/dannoonan/SystemsAnalysisDesignProject.git","ssh_url":"git@github.com:dannoonan/SystemsAnalysisDesignProject.git","clone_url":"https://github.com/dannoonan/SystemsAnalysisDesignProject.git","svn_url":"https://github.com/dannoonan/SystemsAnalysisDesignProject","homepage":null,"size":83936,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":3,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/pulls/15"},"html":{"href":"https://github.com/dannoonan/SystemsAnalysisDesignProject/pull/15"},"issue":{"href":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/issues/15"},"comments":{"href":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/dannoonan/SystemsAnalysisDesignProject/statuses/c163c3f85e7956ddb52318bb96157b2936422628"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"JamieMac96"}}