{"action":"created","comment":{"url":"https://api.github.com/repos/m3db/m3msg/pulls/comments/180203303","pull_request_review_id":110584761,"id":180203303,"diff_hunk":"@@ -0,0 +1,317 @@\n+// Copyright (c) 2018 Uber Technologies, Inc.\n+//\n+// Permission is hereby granted, free of charge, to any person obtaining a copy\n+// of this software and associated documentation files (the \"Software\"), to deal\n+// in the Software without restriction, including without limitation the rights\n+// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell\n+// copies of the Software, and to permit persons to whom the Software is\n+// furnished to do so, subject to the following conditions:\n+//\n+// The above copyright notice and this permission notice shall be included in\n+// all copies or substantial portions of the Software.\n+//\n+// THE SOFTWARE IS PROVIDED \"AS IS\", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR\n+// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,\n+// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE\n+// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER\n+// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,\n+// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN\n+// THE SOFTWARE.\n+\n+package writer\n+\n+import (\n+\t\"fmt\"\n+\t\"net\"\n+\t\"sync\"\n+\t\"time\"\n+\n+\t\"github.com/m3db/m3msg/generated/proto/msgpb\"\n+\t\"github.com/m3db/m3msg/protocol/proto\"\n+\t\"github.com/m3db/m3x/clock\"\n+\t\"github.com/m3db/m3x/log\"\n+\t\"github.com/m3db/m3x/retry\"\n+\n+\t\"github.com/uber-go/tally\"\n+)\n+\n+const (\n+\tdefaultRetryForever = true\n+)\n+\n+var (\n+\tdefaultConn = new(net.TCPConn)\n+)\n+\n+type consumerWriter interface {\n+\t// Write writes the marshaler, it should be thread safe.\n+\tWrite(m proto.Marshaler) error\n+\n+\t// Init initializes the consumer writer.\n+\tInit()\n+\n+\t// Close closes the consumer writer.\n+\tClose()\n+}\n+\n+type consumerWriterMetrics struct {\n+\tackError          tally.Counter\n+\tdecodeError       tally.Counter\n+\tencodeError       tally.Counter\n+\tresetConn         tally.Counter\n+\tresetError        tally.Counter\n+\tconnectError      tally.Counter\n+\tsetKeepAliveError tally.Counter\n+}\n+\n+func newConsumerWriterMetrics(scope tally.Scope) consumerWriterMetrics {\n+\treturn consumerWriterMetrics{\n+\t\tackError:          scope.Counter(\"ack-error\"),\n+\t\tdecodeError:       scope.Counter(\"decode-error\"),\n+\t\tencodeError:       scope.Counter(\"encode-error\"),\n+\t\tresetConn:         scope.Counter(\"reset-conn\"),\n+\t\tresetError:        scope.Counter(\"reset-conn-error\"),\n+\t\tconnectError:      scope.Counter(\"connect-error\"),\n+\t\tsetKeepAliveError: scope.Counter(\"set-keep-alive-error\"),\n+\t}\n+}\n+\n+type connectFn func(addr string) (net.Conn, error)\n+\n+type consumerWriterImpl struct {\n+\tsync.RWMutex\n+\n+\t// encodeLock controls the access to the encode function.\n+\tencodeLock sync.Mutex\n+\t// decodeLock controls the access to the decode function.\n+\tdecodeLock sync.Mutex\n+\tencdec     proto.EncodeDecoder\n+\n+\taddr            string\n+\tretrier         retry.Retrier\n+\trouter          ackRouter\n+\topts            Options\n+\tresetDelayNanos int64\n+\tlogger          log.Logger\n+\n+\tlastResetNanos int64\n+\tclosed         bool\n+\tdoneCh         chan struct{}\n+\tresetCh        chan struct{}\n+\tcloseWG        sync.WaitGroup\n+\tm              consumerWriterMetrics\n+\n+\tnowFn     clock.NowFn\n+\tconnectFn connectFn\n+}\n+\n+// TODO: Remove the nolint comment after adding usage of this function.\n+// nolint: deadcode\n+func newConsumerWriter(\n+\taddr string,\n+\trouter ackRouter,\n+\topts Options,\n+) consumerWriter {\n+\tif opts == nil {\n+\t\topts = NewOptions()\n+\t}\n+\tw := &consumerWriterImpl{\n+\t\tencdec:          proto.NewEncodeDecoder(defaultConn, opts.EncodeDecoderOptions()),\n+\t\taddr:            addr,\n+\t\tretrier:         retry.NewRetrier(opts.ConnectionRetryOptions().SetForever(defaultRetryForever)),\n+\t\trouter:          router,\n+\t\topts:            opts,\n+\t\tresetDelayNanos: int64(opts.ConnectionResetDelay()),\n+\t\tlogger:          opts.InstrumentOptions().Logger(),\n+\t\tlastResetNanos:  0,\n+\t\tclosed:          false,\n+\t\tdoneCh:          make(chan struct{}),\n+\t\tresetCh:         make(chan struct{}, 1),\n+\t\tm:               newConsumerWriterMetrics(opts.InstrumentOptions().MetricsScope()),\n+\t\tnowFn:           time.Now,\n+\t}\n+\n+\tw.connectFn = w.connectOnce\n+\tif err := w.resetWithConnectFn(w.connectFn); err != nil {\n+\t\tw.signalReset()\n+\t}\n+\treturn w\n+}\n+\n+// Write should fail fast so that the write could be tried on other\n+// consumer writers that are sharing the data.\n+func (w *consumerWriterImpl) Write(m proto.Marshaler) error {\n+\tw.encodeLock.Lock()\n+\terr := w.encdec.Encode(m)\n+\tw.encodeLock.Unlock()\n+\tif err != nil {\n+\t\tw.m.encodeError.Inc(1)\n+\t\tw.signalReset()\n+\t}\n+\treturn err\n+}\n+\n+func (w *consumerWriterImpl) signalReset() {","path":"producer/writer/consumer_writer.go","position":153,"original_position":154,"commit_id":"6dead5c82eb8118b52d63aafe828911ada47fa98","original_commit_id":"e7e22328ab2193c48cecc952ac1d04606a5d24dc","user":{"login":"cw9","id":6710599,"avatar_url":"https://avatars0.githubusercontent.com/u/6710599?v=4","gravatar_id":"","url":"https://api.github.com/users/cw9","html_url":"https://github.com/cw9","followers_url":"https://api.github.com/users/cw9/followers","following_url":"https://api.github.com/users/cw9/following{/other_user}","gists_url":"https://api.github.com/users/cw9/gists{/gist_id}","starred_url":"https://api.github.com/users/cw9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cw9/subscriptions","organizations_url":"https://api.github.com/users/cw9/orgs","repos_url":"https://api.github.com/users/cw9/repos","events_url":"https://api.github.com/users/cw9/events{/privacy}","received_events_url":"https://api.github.com/users/cw9/received_events","type":"User","site_admin":false},"body":"Then the `Reset` function in `retryableConnection` needs to be something like this: \r\n```\r\nc.conn.Close() // To wake up any blocking encode/decode call\r\nc.Lock()\r\nc.conn = conn\r\nc.Unlock()\r\n```\r\nWhich is similar to the current `reset` function in `consumerWriterImpl` as well.\r\n\r\nI basically need to move all the connection reset related logic from `consumerWriter` into the `retryableConnection` object and add the lock needed in the `retryableConnection` which is also added to the hot path for both writes/reads. That RLock is purely for resetting the connection because it needs the `encodeLock` and `decodeLock` in `consumerWriter` to guard the accessibility to `write` and `read` functions. Not sure if this worth it performance wise.","created_at":"2018-04-09T19:26:06Z","updated_at":"2018-04-09T19:26:06Z","html_url":"https://github.com/m3db/m3msg/pull/7#discussion_r180203303","pull_request_url":"https://api.github.com/repos/m3db/m3msg/pulls/7","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/m3db/m3msg/pulls/comments/180203303"},"html":{"href":"https://github.com/m3db/m3msg/pull/7#discussion_r180203303"},"pull_request":{"href":"https://api.github.com/repos/m3db/m3msg/pulls/7"}},"in_reply_to_id":180140393},"pull_request":{"url":"https://api.github.com/repos/m3db/m3msg/pulls/7","id":179790193,"html_url":"https://github.com/m3db/m3msg/pull/7","diff_url":"https://github.com/m3db/m3msg/pull/7.diff","patch_url":"https://github.com/m3db/m3msg/pull/7.patch","issue_url":"https://api.github.com/repos/m3db/m3msg/issues/7","number":7,"state":"open","locked":false,"title":"Add consumer writer","user":{"login":"cw9","id":6710599,"avatar_url":"https://avatars0.githubusercontent.com/u/6710599?v=4","gravatar_id":"","url":"https://api.github.com/users/cw9","html_url":"https://github.com/cw9","followers_url":"https://api.github.com/users/cw9/followers","following_url":"https://api.github.com/users/cw9/following{/other_user}","gists_url":"https://api.github.com/users/cw9/gists{/gist_id}","starred_url":"https://api.github.com/users/cw9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cw9/subscriptions","organizations_url":"https://api.github.com/users/cw9/orgs","repos_url":"https://api.github.com/users/cw9/repos","events_url":"https://api.github.com/users/cw9/events{/privacy}","received_events_url":"https://api.github.com/users/cw9/received_events","type":"User","site_admin":false},"body":"`consumerWriter` is the end part of the `producer.Writer` that manages the connection to a consumer instance.\r\n\r\nIt takes live `Write` requests to write out and constantly decodes acks from the underlying connection then delegate to `ackRouter` for acking. In this diff `ackRouter` is mocked.\r\n\r\nAll the `encode` calls need to be guarded by a encode lock and all the `decode` calls need to be guarded by a decode lock, I also need a 3rd lock to guard the access to the connection during the resetting which made the concurrency control a bit complex.\r\n\r\nThis pr also adds `Options` which provides all the options that are needed by the `Writer`, only some of them is used by `consumerWriter` here so don't worry about the unused options.\r\n\r\n@xichen2020 @jeromefroe @m-sandusky @jskelcy ","created_at":"2018-04-05T20:39:44Z","updated_at":"2018-04-09T19:26:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"21eda5626b569be3c463f75dd505d80183183c40","assignee":{"login":"jskelcy","id":2659770,"avatar_url":"https://avatars3.githubusercontent.com/u/2659770?v=4","gravatar_id":"","url":"https://api.github.com/users/jskelcy","html_url":"https://github.com/jskelcy","followers_url":"https://api.github.com/users/jskelcy/followers","following_url":"https://api.github.com/users/jskelcy/following{/other_user}","gists_url":"https://api.github.com/users/jskelcy/gists{/gist_id}","starred_url":"https://api.github.com/users/jskelcy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jskelcy/subscriptions","organizations_url":"https://api.github.com/users/jskelcy/orgs","repos_url":"https://api.github.com/users/jskelcy/repos","events_url":"https://api.github.com/users/jskelcy/events{/privacy}","received_events_url":"https://api.github.com/users/jskelcy/received_events","type":"User","site_admin":false},"assignees":[{"login":"jskelcy","id":2659770,"avatar_url":"https://avatars3.githubusercontent.com/u/2659770?v=4","gravatar_id":"","url":"https://api.github.com/users/jskelcy","html_url":"https://github.com/jskelcy","followers_url":"https://api.github.com/users/jskelcy/followers","following_url":"https://api.github.com/users/jskelcy/following{/other_user}","gists_url":"https://api.github.com/users/jskelcy/gists{/gist_id}","starred_url":"https://api.github.com/users/jskelcy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jskelcy/subscriptions","organizations_url":"https://api.github.com/users/jskelcy/orgs","repos_url":"https://api.github.com/users/jskelcy/repos","events_url":"https://api.github.com/users/jskelcy/events{/privacy}","received_events_url":"https://api.github.com/users/jskelcy/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/m3db/m3msg/pulls/7/commits","review_comments_url":"https://api.github.com/repos/m3db/m3msg/pulls/7/comments","review_comment_url":"https://api.github.com/repos/m3db/m3msg/pulls/comments{/number}","comments_url":"https://api.github.com/repos/m3db/m3msg/issues/7/comments","statuses_url":"https://api.github.com/repos/m3db/m3msg/statuses/6dead5c82eb8118b52d63aafe828911ada47fa98","head":{"label":"m3db:chao-writer1","ref":"chao-writer1","sha":"6dead5c82eb8118b52d63aafe828911ada47fa98","user":{"login":"m3db","id":19937171,"avatar_url":"https://avatars0.githubusercontent.com/u/19937171?v=4","gravatar_id":"","url":"https://api.github.com/users/m3db","html_url":"https://github.com/m3db","followers_url":"https://api.github.com/users/m3db/followers","following_url":"https://api.github.com/users/m3db/following{/other_user}","gists_url":"https://api.github.com/users/m3db/gists{/gist_id}","starred_url":"https://api.github.com/users/m3db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m3db/subscriptions","organizations_url":"https://api.github.com/users/m3db/orgs","repos_url":"https://api.github.com/users/m3db/repos","events_url":"https://api.github.com/users/m3db/events{/privacy}","received_events_url":"https://api.github.com/users/m3db/received_events","type":"Organization","site_admin":false},"repo":{"id":126348256,"name":"m3msg","full_name":"m3db/m3msg","owner":{"login":"m3db","id":19937171,"avatar_url":"https://avatars0.githubusercontent.com/u/19937171?v=4","gravatar_id":"","url":"https://api.github.com/users/m3db","html_url":"https://github.com/m3db","followers_url":"https://api.github.com/users/m3db/followers","following_url":"https://api.github.com/users/m3db/following{/other_user}","gists_url":"https://api.github.com/users/m3db/gists{/gist_id}","starred_url":"https://api.github.com/users/m3db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m3db/subscriptions","organizations_url":"https://api.github.com/users/m3db/orgs","repos_url":"https://api.github.com/users/m3db/repos","events_url":"https://api.github.com/users/m3db/events{/privacy}","received_events_url":"https://api.github.com/users/m3db/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/m3db/m3msg","description":null,"fork":false,"url":"https://api.github.com/repos/m3db/m3msg","forks_url":"https://api.github.com/repos/m3db/m3msg/forks","keys_url":"https://api.github.com/repos/m3db/m3msg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/m3db/m3msg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/m3db/m3msg/teams","hooks_url":"https://api.github.com/repos/m3db/m3msg/hooks","issue_events_url":"https://api.github.com/repos/m3db/m3msg/issues/events{/number}","events_url":"https://api.github.com/repos/m3db/m3msg/events","assignees_url":"https://api.github.com/repos/m3db/m3msg/assignees{/user}","branches_url":"https://api.github.com/repos/m3db/m3msg/branches{/branch}","tags_url":"https://api.github.com/repos/m3db/m3msg/tags","blobs_url":"https://api.github.com/repos/m3db/m3msg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/m3db/m3msg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/m3db/m3msg/git/refs{/sha}","trees_url":"https://api.github.com/repos/m3db/m3msg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/m3db/m3msg/statuses/{sha}","languages_url":"https://api.github.com/repos/m3db/m3msg/languages","stargazers_url":"https://api.github.com/repos/m3db/m3msg/stargazers","contributors_url":"https://api.github.com/repos/m3db/m3msg/contributors","subscribers_url":"https://api.github.com/repos/m3db/m3msg/subscribers","subscription_url":"https://api.github.com/repos/m3db/m3msg/subscription","commits_url":"https://api.github.com/repos/m3db/m3msg/commits{/sha}","git_commits_url":"https://api.github.com/repos/m3db/m3msg/git/commits{/sha}","comments_url":"https://api.github.com/repos/m3db/m3msg/comments{/number}","issue_comment_url":"https://api.github.com/repos/m3db/m3msg/issues/comments{/number}","contents_url":"https://api.github.com/repos/m3db/m3msg/contents/{+path}","compare_url":"https://api.github.com/repos/m3db/m3msg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/m3db/m3msg/merges","archive_url":"https://api.github.com/repos/m3db/m3msg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/m3db/m3msg/downloads","issues_url":"https://api.github.com/repos/m3db/m3msg/issues{/number}","pulls_url":"https://api.github.com/repos/m3db/m3msg/pulls{/number}","milestones_url":"https://api.github.com/repos/m3db/m3msg/milestones{/number}","notifications_url":"https://api.github.com/repos/m3db/m3msg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/m3db/m3msg/labels{/name}","releases_url":"https://api.github.com/repos/m3db/m3msg/releases{/id}","deployments_url":"https://api.github.com/repos/m3db/m3msg/deployments","created_at":"2018-03-22T14:32:21Z","updated_at":"2018-04-05T18:34:51Z","pushed_at":"2018-04-09T17:46:47Z","git_url":"git://github.com/m3db/m3msg.git","ssh_url":"git@github.com:m3db/m3msg.git","clone_url":"https://github.com/m3db/m3msg.git","svn_url":"https://github.com/m3db/m3msg","homepage":null,"size":89,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"m3db:master","ref":"master","sha":"04e3a6eae403f51d45e9c250b73a6f2f3a3f1a96","user":{"login":"m3db","id":19937171,"avatar_url":"https://avatars0.githubusercontent.com/u/19937171?v=4","gravatar_id":"","url":"https://api.github.com/users/m3db","html_url":"https://github.com/m3db","followers_url":"https://api.github.com/users/m3db/followers","following_url":"https://api.github.com/users/m3db/following{/other_user}","gists_url":"https://api.github.com/users/m3db/gists{/gist_id}","starred_url":"https://api.github.com/users/m3db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m3db/subscriptions","organizations_url":"https://api.github.com/users/m3db/orgs","repos_url":"https://api.github.com/users/m3db/repos","events_url":"https://api.github.com/users/m3db/events{/privacy}","received_events_url":"https://api.github.com/users/m3db/received_events","type":"Organization","site_admin":false},"repo":{"id":126348256,"name":"m3msg","full_name":"m3db/m3msg","owner":{"login":"m3db","id":19937171,"avatar_url":"https://avatars0.githubusercontent.com/u/19937171?v=4","gravatar_id":"","url":"https://api.github.com/users/m3db","html_url":"https://github.com/m3db","followers_url":"https://api.github.com/users/m3db/followers","following_url":"https://api.github.com/users/m3db/following{/other_user}","gists_url":"https://api.github.com/users/m3db/gists{/gist_id}","starred_url":"https://api.github.com/users/m3db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m3db/subscriptions","organizations_url":"https://api.github.com/users/m3db/orgs","repos_url":"https://api.github.com/users/m3db/repos","events_url":"https://api.github.com/users/m3db/events{/privacy}","received_events_url":"https://api.github.com/users/m3db/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/m3db/m3msg","description":null,"fork":false,"url":"https://api.github.com/repos/m3db/m3msg","forks_url":"https://api.github.com/repos/m3db/m3msg/forks","keys_url":"https://api.github.com/repos/m3db/m3msg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/m3db/m3msg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/m3db/m3msg/teams","hooks_url":"https://api.github.com/repos/m3db/m3msg/hooks","issue_events_url":"https://api.github.com/repos/m3db/m3msg/issues/events{/number}","events_url":"https://api.github.com/repos/m3db/m3msg/events","assignees_url":"https://api.github.com/repos/m3db/m3msg/assignees{/user}","branches_url":"https://api.github.com/repos/m3db/m3msg/branches{/branch}","tags_url":"https://api.github.com/repos/m3db/m3msg/tags","blobs_url":"https://api.github.com/repos/m3db/m3msg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/m3db/m3msg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/m3db/m3msg/git/refs{/sha}","trees_url":"https://api.github.com/repos/m3db/m3msg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/m3db/m3msg/statuses/{sha}","languages_url":"https://api.github.com/repos/m3db/m3msg/languages","stargazers_url":"https://api.github.com/repos/m3db/m3msg/stargazers","contributors_url":"https://api.github.com/repos/m3db/m3msg/contributors","subscribers_url":"https://api.github.com/repos/m3db/m3msg/subscribers","subscription_url":"https://api.github.com/repos/m3db/m3msg/subscription","commits_url":"https://api.github.com/repos/m3db/m3msg/commits{/sha}","git_commits_url":"https://api.github.com/repos/m3db/m3msg/git/commits{/sha}","comments_url":"https://api.github.com/repos/m3db/m3msg/comments{/number}","issue_comment_url":"https://api.github.com/repos/m3db/m3msg/issues/comments{/number}","contents_url":"https://api.github.com/repos/m3db/m3msg/contents/{+path}","compare_url":"https://api.github.com/repos/m3db/m3msg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/m3db/m3msg/merges","archive_url":"https://api.github.com/repos/m3db/m3msg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/m3db/m3msg/downloads","issues_url":"https://api.github.com/repos/m3db/m3msg/issues{/number}","pulls_url":"https://api.github.com/repos/m3db/m3msg/pulls{/number}","milestones_url":"https://api.github.com/repos/m3db/m3msg/milestones{/number}","notifications_url":"https://api.github.com/repos/m3db/m3msg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/m3db/m3msg/labels{/name}","releases_url":"https://api.github.com/repos/m3db/m3msg/releases{/id}","deployments_url":"https://api.github.com/repos/m3db/m3msg/deployments","created_at":"2018-03-22T14:32:21Z","updated_at":"2018-04-05T18:34:51Z","pushed_at":"2018-04-09T17:46:47Z","git_url":"git://github.com/m3db/m3msg.git","ssh_url":"git@github.com:m3db/m3msg.git","clone_url":"https://github.com/m3db/m3msg.git","svn_url":"https://github.com/m3db/m3msg","homepage":null,"size":89,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/m3db/m3msg/pulls/7"},"html":{"href":"https://github.com/m3db/m3msg/pull/7"},"issue":{"href":"https://api.github.com/repos/m3db/m3msg/issues/7"},"comments":{"href":"https://api.github.com/repos/m3db/m3msg/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/m3db/m3msg/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/m3db/m3msg/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/m3db/m3msg/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/m3db/m3msg/statuses/6dead5c82eb8118b52d63aafe828911ada47fa98"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"cw9"}}