{"action":"created","issue":{"url":"https://api.github.com/repos/0xProject/0x.js/issues/389","repository_url":"https://api.github.com/repos/0xProject/0x.js","labels_url":"https://api.github.com/repos/0xProject/0x.js/issues/389/labels{/name}","comments_url":"https://api.github.com/repos/0xProject/0x.js/issues/389/comments","events_url":"https://api.github.com/repos/0xProject/0x.js/issues/389/events","html_url":"https://github.com/0xProject/0x.js/pull/389","id":296016310,"number":389,"title":"Fix NPM Inclusion Issues","user":{"login":"fabioberger","id":2151492,"avatar_url":"https://avatars2.githubusercontent.com/u/2151492?v=4","gravatar_id":"","url":"https://api.github.com/users/fabioberger","html_url":"https://github.com/fabioberger","followers_url":"https://api.github.com/users/fabioberger/followers","following_url":"https://api.github.com/users/fabioberger/following{/other_user}","gists_url":"https://api.github.com/users/fabioberger/gists{/gist_id}","starred_url":"https://api.github.com/users/fabioberger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabioberger/subscriptions","organizations_url":"https://api.github.com/users/fabioberger/orgs","repos_url":"https://api.github.com/users/fabioberger/repos","events_url":"https://api.github.com/users/fabioberger/events{/privacy}","received_events_url":"https://api.github.com/users/fabioberger/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-02-09T21:23:21Z","updated_at":"2018-02-09T22:00:04Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/0xProject/0x.js/pulls/389","html_url":"https://github.com/0xProject/0x.js/pull/389","diff_url":"https://github.com/0xProject/0x.js/pull/389.diff","patch_url":"https://github.com/0xProject/0x.js/pull/389.patch"},"body":"## Description\r\n\r\nCurrently many of our packages are not correctly ignoring src files, configs, etc... from NPM package publishing. This PR fixes that by adding a `.npmignore` file to each sub-package in the repo with the correct files/folders excluded.\r\n\r\nAdditionally, this PR adds TSLint checking to the `deployer` sub-package and fixes the existing issues.\r\n\r\n## Motivation and Context\r\n\r\nOur packages are much larger then they need to be. This reduces the size of almost all of them. This was an oversight on our part.\r\n\r\n## How Has This Been Tested?\r\n\r\nManually running `yarn pack` in each sub-package and inspecting the contents of the resulting package to ensure it only includes desired files/folders.\r\n\r\n## Types of changes\r\n\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n\r\n* [x] Bug fix (non-breaking change which fixes an issue)\r\n* [ ] New feature (non-breaking change which adds functionality)\r\n* [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n\r\n* [ ] Change requires a change to the documentation.\r\n* [ ] Added tests to cover my changes.\r\n* [x] Added new entries to the relevant CHANGELOGs.\r\n* [x] Updated the new versions of the changed packages in the relevant CHANGELOGs.\r\n* [ ] Labeled this PR with the 'WIP' label if it is a work in progress.\r\n* [ ] Labeled this PR with the labels corresponding to the changed package.\r\n"},"comment":{"url":"https://api.github.com/repos/0xProject/0x.js/issues/comments/364581549","html_url":"https://github.com/0xProject/0x.js/pull/389#issuecomment-364581549","issue_url":"https://api.github.com/repos/0xProject/0x.js/issues/389","id":364581549,"user":{"login":"fabioberger","id":2151492,"avatar_url":"https://avatars2.githubusercontent.com/u/2151492?v=4","gravatar_id":"","url":"https://api.github.com/users/fabioberger","html_url":"https://github.com/fabioberger","followers_url":"https://api.github.com/users/fabioberger/followers","following_url":"https://api.github.com/users/fabioberger/following{/other_user}","gists_url":"https://api.github.com/users/fabioberger/gists{/gist_id}","starred_url":"https://api.github.com/users/fabioberger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabioberger/subscriptions","organizations_url":"https://api.github.com/users/fabioberger/orgs","repos_url":"https://api.github.com/users/fabioberger/repos","events_url":"https://api.github.com/users/fabioberger/events{/privacy}","received_events_url":"https://api.github.com/users/fabioberger/received_events","type":"User","site_admin":false},"created_at":"2018-02-09T22:00:04Z","updated_at":"2018-02-09T22:00:04Z","author_association":"CONTRIBUTOR","body":"@LogvinovLeon Lerna by-design wants it to be in each individual sub-package: https://github.com/lerna/lerna/issues/296"}}
{"actor":{"display_login":"fabioberger"}}