{"action":"created","comment":{"url":"https://api.github.com/repos/solana-labs/solana/pulls/comments/204223717","pull_request_review_id":139271124,"id":204223717,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDIyMzcxNw==","diff_hunk":"@@ -389,28 +390,59 @@ fn test_multi_node_dynamic_network() {\n         send_tx_and_retry_get_balance(&leader_data, &alice, &bob_pubkey, Some(1000)).unwrap();\n     assert_eq!(leader_balance, 1000);\n \n-    let validators: Vec<(NodeInfo, FullNode)> = (0..N)\n+    let validators_per_thread = Arc::new(RwLock::new(Vec::new()));\n+    let threads: Vec<_> = (0..10)\n         .into_iter()\n-        .map(|n| {\n-            let keypair = KeyPair::new();\n-            let validator = TestNode::new_localhost_with_pubkey(keypair.pubkey());\n-            let rd = validator.data.clone();\n-            //send some tokens to the new validator\n-            let bal =\n-                send_tx_and_retry_get_balance(&leader_data, &alice, &keypair.pubkey(), Some(500));\n-            assert_eq!(bal, Some(500));\n-            let val = FullNode::new(\n-                validator,\n-                false,\n-                LedgerFile::Path(ledger_path.clone()),\n-                Some(keypair),\n-                Some(leader_data.contact_info.ncp),\n-            );\n-            info!(\"started[{}/{}] {:x}\", n, N, rd.debug_id());\n-            (rd, val)","path":"tests/multinode.rs","position":32,"original_position":32,"commit_id":"77bbf5dc0fb2baef9fa47d8f6b0a34b0092feefc","original_commit_id":"77bbf5dc0fb2baef9fa47d8f6b0a34b0092feefc","user":{"login":"pgarg66","id":40076733,"node_id":"MDQ6VXNlcjQwMDc2NzMz","avatar_url":"https://avatars1.githubusercontent.com/u/40076733?v=4","gravatar_id":"","url":"https://api.github.com/users/pgarg66","html_url":"https://github.com/pgarg66","followers_url":"https://api.github.com/users/pgarg66/followers","following_url":"https://api.github.com/users/pgarg66/following{/other_user}","gists_url":"https://api.github.com/users/pgarg66/gists{/gist_id}","starred_url":"https://api.github.com/users/pgarg66/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pgarg66/subscriptions","organizations_url":"https://api.github.com/users/pgarg66/orgs","repos_url":"https://api.github.com/users/pgarg66/repos","events_url":"https://api.github.com/users/pgarg66/events{/privacy}","received_events_url":"https://api.github.com/users/pgarg66/received_events","type":"User","site_admin":false},"body":"Thanks @aeyakovenko , that made it really simple.","created_at":"2018-07-21T23:03:19Z","updated_at":"2018-07-21T23:03:19Z","html_url":"https://github.com/solana-labs/solana/pull/722#discussion_r204223717","pull_request_url":"https://api.github.com/repos/solana-labs/solana/pulls/722","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/solana-labs/solana/pulls/comments/204223717"},"html":{"href":"https://github.com/solana-labs/solana/pull/722#discussion_r204223717"},"pull_request":{"href":"https://api.github.com/repos/solana-labs/solana/pulls/722"}},"in_reply_to_id":204200976},"pull_request":{"url":"https://api.github.com/repos/solana-labs/solana/pulls/722","id":202973342,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyOTczMzQy","html_url":"https://github.com/solana-labs/solana/pull/722","diff_url":"https://github.com/solana-labs/solana/pull/722.diff","patch_url":"https://github.com/solana-labs/solana/pull/722.patch","issue_url":"https://api.github.com/repos/solana-labs/solana/issues/722","number":722,"state":"open","locked":false,"title":"Updates to dynamic-network-test to start validators in parallel","user":{"login":"pgarg66","id":40076733,"node_id":"MDQ6VXNlcjQwMDc2NzMz","avatar_url":"https://avatars1.githubusercontent.com/u/40076733?v=4","gravatar_id":"","url":"https://api.github.com/users/pgarg66","html_url":"https://github.com/pgarg66","followers_url":"https://api.github.com/users/pgarg66/followers","following_url":"https://api.github.com/users/pgarg66/following{/other_user}","gists_url":"https://api.github.com/users/pgarg66/gists{/gist_id}","starred_url":"https://api.github.com/users/pgarg66/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pgarg66/subscriptions","organizations_url":"https://api.github.com/users/pgarg66/orgs","repos_url":"https://api.github.com/users/pgarg66/repos","events_url":"https://api.github.com/users/pgarg66/events{/privacy}","received_events_url":"https://api.github.com/users/pgarg66/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-07-20T22:56:11Z","updated_at":"2018-07-21T23:03:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f73b6029aea9430013ddee84cdba5b9475c9cc89","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":982887376,"node_id":"MDU6TGFiZWw5ODI4ODczNzY=","url":"https://api.github.com/repos/solana-labs/solana/labels/noCI","name":"noCI","color":"b60205","default":false},{"id":934588962,"node_id":"MDU6TGFiZWw5MzQ1ODg5NjI=","url":"https://api.github.com/repos/solana-labs/solana/labels/work%20in%20progress","name":"work in progress","color":"bf722a","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/solana-labs/solana/pulls/722/commits","review_comments_url":"https://api.github.com/repos/solana-labs/solana/pulls/722/comments","review_comment_url":"https://api.github.com/repos/solana-labs/solana/pulls/comments{/number}","comments_url":"https://api.github.com/repos/solana-labs/solana/issues/722/comments","statuses_url":"https://api.github.com/repos/solana-labs/solana/statuses/77bbf5dc0fb2baef9fa47d8f6b0a34b0092feefc","head":{"label":"pgarg66:dynamic-network-test","ref":"dynamic-network-test","sha":"77bbf5dc0fb2baef9fa47d8f6b0a34b0092feefc","user":{"login":"pgarg66","id":40076733,"node_id":"MDQ6VXNlcjQwMDc2NzMz","avatar_url":"https://avatars1.githubusercontent.com/u/40076733?v=4","gravatar_id":"","url":"https://api.github.com/users/pgarg66","html_url":"https://github.com/pgarg66","followers_url":"https://api.github.com/users/pgarg66/followers","following_url":"https://api.github.com/users/pgarg66/following{/other_user}","gists_url":"https://api.github.com/users/pgarg66/gists{/gist_id}","starred_url":"https://api.github.com/users/pgarg66/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pgarg66/subscriptions","organizations_url":"https://api.github.com/users/pgarg66/orgs","repos_url":"https://api.github.com/users/pgarg66/repos","events_url":"https://api.github.com/users/pgarg66/events{/privacy}","received_events_url":"https://api.github.com/users/pgarg66/received_events","type":"User","site_admin":false},"repo":{"id":141088287,"node_id":"MDEwOlJlcG9zaXRvcnkxNDEwODgyODc=","name":"solana","full_name":"pgarg66/solana","owner":{"login":"pgarg66","id":40076733,"node_id":"MDQ6VXNlcjQwMDc2NzMz","avatar_url":"https://avatars1.githubusercontent.com/u/40076733?v=4","gravatar_id":"","url":"https://api.github.com/users/pgarg66","html_url":"https://github.com/pgarg66","followers_url":"https://api.github.com/users/pgarg66/followers","following_url":"https://api.github.com/users/pgarg66/following{/other_user}","gists_url":"https://api.github.com/users/pgarg66/gists{/gist_id}","starred_url":"https://api.github.com/users/pgarg66/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pgarg66/subscriptions","organizations_url":"https://api.github.com/users/pgarg66/orgs","repos_url":"https://api.github.com/users/pgarg66/repos","events_url":"https://api.github.com/users/pgarg66/events{/privacy}","received_events_url":"https://api.github.com/users/pgarg66/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pgarg66/solana","description":"Blockchain, Rebuilt for Scale","fork":true,"url":"https://api.github.com/repos/pgarg66/solana","forks_url":"https://api.github.com/repos/pgarg66/solana/forks","keys_url":"https://api.github.com/repos/pgarg66/solana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pgarg66/solana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pgarg66/solana/teams","hooks_url":"https://api.github.com/repos/pgarg66/solana/hooks","issue_events_url":"https://api.github.com/repos/pgarg66/solana/issues/events{/number}","events_url":"https://api.github.com/repos/pgarg66/solana/events","assignees_url":"https://api.github.com/repos/pgarg66/solana/assignees{/user}","branches_url":"https://api.github.com/repos/pgarg66/solana/branches{/branch}","tags_url":"https://api.github.com/repos/pgarg66/solana/tags","blobs_url":"https://api.github.com/repos/pgarg66/solana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pgarg66/solana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pgarg66/solana/git/refs{/sha}","trees_url":"https://api.github.com/repos/pgarg66/solana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pgarg66/solana/statuses/{sha}","languages_url":"https://api.github.com/repos/pgarg66/solana/languages","stargazers_url":"https://api.github.com/repos/pgarg66/solana/stargazers","contributors_url":"https://api.github.com/repos/pgarg66/solana/contributors","subscribers_url":"https://api.github.com/repos/pgarg66/solana/subscribers","subscription_url":"https://api.github.com/repos/pgarg66/solana/subscription","commits_url":"https://api.github.com/repos/pgarg66/solana/commits{/sha}","git_commits_url":"https://api.github.com/repos/pgarg66/solana/git/commits{/sha}","comments_url":"https://api.github.com/repos/pgarg66/solana/comments{/number}","issue_comment_url":"https://api.github.com/repos/pgarg66/solana/issues/comments{/number}","contents_url":"https://api.github.com/repos/pgarg66/solana/contents/{+path}","compare_url":"https://api.github.com/repos/pgarg66/solana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pgarg66/solana/merges","archive_url":"https://api.github.com/repos/pgarg66/solana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pgarg66/solana/downloads","issues_url":"https://api.github.com/repos/pgarg66/solana/issues{/number}","pulls_url":"https://api.github.com/repos/pgarg66/solana/pulls{/number}","milestones_url":"https://api.github.com/repos/pgarg66/solana/milestones{/number}","notifications_url":"https://api.github.com/repos/pgarg66/solana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pgarg66/solana/labels{/name}","releases_url":"https://api.github.com/repos/pgarg66/solana/releases{/id}","deployments_url":"https://api.github.com/repos/pgarg66/solana/deployments","created_at":"2018-07-16T04:57:37Z","updated_at":"2018-07-19T21:27:27Z","pushed_at":"2018-07-20T22:53:29Z","git_url":"git://github.com/pgarg66/solana.git","ssh_url":"git@github.com:pgarg66/solana.git","clone_url":"https://github.com/pgarg66/solana.git","svn_url":"https://github.com/pgarg66/solana","homepage":"https://solana.com","size":9724,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"solana-labs:master","ref":"master","sha":"cba3b35ac99b2de7ba51cc3aef2ac6eec0b14008","user":{"login":"solana-labs","id":35608259,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NjA4MjU5","avatar_url":"https://avatars3.githubusercontent.com/u/35608259?v=4","gravatar_id":"","url":"https://api.github.com/users/solana-labs","html_url":"https://github.com/solana-labs","followers_url":"https://api.github.com/users/solana-labs/followers","following_url":"https://api.github.com/users/solana-labs/following{/other_user}","gists_url":"https://api.github.com/users/solana-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/solana-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solana-labs/subscriptions","organizations_url":"https://api.github.com/users/solana-labs/orgs","repos_url":"https://api.github.com/users/solana-labs/repos","events_url":"https://api.github.com/users/solana-labs/events{/privacy}","received_events_url":"https://api.github.com/users/solana-labs/received_events","type":"Organization","site_admin":false},"repo":{"id":121470383,"node_id":"MDEwOlJlcG9zaXRvcnkxMjE0NzAzODM=","name":"solana","full_name":"solana-labs/solana","owner":{"login":"solana-labs","id":35608259,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NjA4MjU5","avatar_url":"https://avatars3.githubusercontent.com/u/35608259?v=4","gravatar_id":"","url":"https://api.github.com/users/solana-labs","html_url":"https://github.com/solana-labs","followers_url":"https://api.github.com/users/solana-labs/followers","following_url":"https://api.github.com/users/solana-labs/following{/other_user}","gists_url":"https://api.github.com/users/solana-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/solana-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solana-labs/subscriptions","organizations_url":"https://api.github.com/users/solana-labs/orgs","repos_url":"https://api.github.com/users/solana-labs/repos","events_url":"https://api.github.com/users/solana-labs/events{/privacy}","received_events_url":"https://api.github.com/users/solana-labs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/solana-labs/solana","description":"Blockchain, Rebuilt for Scale","fork":false,"url":"https://api.github.com/repos/solana-labs/solana","forks_url":"https://api.github.com/repos/solana-labs/solana/forks","keys_url":"https://api.github.com/repos/solana-labs/solana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/solana-labs/solana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/solana-labs/solana/teams","hooks_url":"https://api.github.com/repos/solana-labs/solana/hooks","issue_events_url":"https://api.github.com/repos/solana-labs/solana/issues/events{/number}","events_url":"https://api.github.com/repos/solana-labs/solana/events","assignees_url":"https://api.github.com/repos/solana-labs/solana/assignees{/user}","branches_url":"https://api.github.com/repos/solana-labs/solana/branches{/branch}","tags_url":"https://api.github.com/repos/solana-labs/solana/tags","blobs_url":"https://api.github.com/repos/solana-labs/solana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/solana-labs/solana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/solana-labs/solana/git/refs{/sha}","trees_url":"https://api.github.com/repos/solana-labs/solana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/solana-labs/solana/statuses/{sha}","languages_url":"https://api.github.com/repos/solana-labs/solana/languages","stargazers_url":"https://api.github.com/repos/solana-labs/solana/stargazers","contributors_url":"https://api.github.com/repos/solana-labs/solana/contributors","subscribers_url":"https://api.github.com/repos/solana-labs/solana/subscribers","subscription_url":"https://api.github.com/repos/solana-labs/solana/subscription","commits_url":"https://api.github.com/repos/solana-labs/solana/commits{/sha}","git_commits_url":"https://api.github.com/repos/solana-labs/solana/git/commits{/sha}","comments_url":"https://api.github.com/repos/solana-labs/solana/comments{/number}","issue_comment_url":"https://api.github.com/repos/solana-labs/solana/issues/comments{/number}","contents_url":"https://api.github.com/repos/solana-labs/solana/contents/{+path}","compare_url":"https://api.github.com/repos/solana-labs/solana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/solana-labs/solana/merges","archive_url":"https://api.github.com/repos/solana-labs/solana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/solana-labs/solana/downloads","issues_url":"https://api.github.com/repos/solana-labs/solana/issues{/number}","pulls_url":"https://api.github.com/repos/solana-labs/solana/pulls{/number}","milestones_url":"https://api.github.com/repos/solana-labs/solana/milestones{/number}","notifications_url":"https://api.github.com/repos/solana-labs/solana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/solana-labs/solana/labels{/name}","releases_url":"https://api.github.com/repos/solana-labs/solana/releases{/id}","deployments_url":"https://api.github.com/repos/solana-labs/solana/deployments","created_at":"2018-02-14T04:26:27Z","updated_at":"2018-07-21T22:46:07Z","pushed_at":"2018-07-21T22:46:04Z","git_url":"git://github.com/solana-labs/solana.git","ssh_url":"git@github.com:solana-labs/solana.git","clone_url":"https://github.com/solana-labs/solana.git","svn_url":"https://github.com/solana-labs/solana","homepage":"https://solana.com","size":9750,"stargazers_count":284,"watchers_count":284,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":46,"mirror_url":null,"archived":false,"open_issues_count":67,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":46,"open_issues":67,"watchers":284,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/solana-labs/solana/pulls/722"},"html":{"href":"https://github.com/solana-labs/solana/pull/722"},"issue":{"href":"https://api.github.com/repos/solana-labs/solana/issues/722"},"comments":{"href":"https://api.github.com/repos/solana-labs/solana/issues/722/comments"},"review_comments":{"href":"https://api.github.com/repos/solana-labs/solana/pulls/722/comments"},"review_comment":{"href":"https://api.github.com/repos/solana-labs/solana/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/solana-labs/solana/pulls/722/commits"},"statuses":{"href":"https://api.github.com/repos/solana-labs/solana/statuses/77bbf5dc0fb2baef9fa47d8f6b0a34b0092feefc"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"pgarg66"}}