{"action":"created","issue":{"url":"https://api.github.com/repos/anastasija-stepanova/oop/issues/12","repository_url":"https://api.github.com/repos/anastasija-stepanova/oop","labels_url":"https://api.github.com/repos/anastasija-stepanova/oop/issues/12/labels{/name}","comments_url":"https://api.github.com/repos/anastasija-stepanova/oop/issues/12/comments","events_url":"https://api.github.com/repos/anastasija-stepanova/oop/issues/12/events","html_url":"https://github.com/anastasija-stepanova/oop/issues/12","id":325598105,"node_id":"MDU6SXNzdWUzMjU1OTgxMDU=","number":12,"title":"Замечания по программа HttpUrl","user":{"login":"oMystique","id":14878773,"node_id":"MDQ6VXNlcjE0ODc4Nzcz","avatar_url":"https://avatars3.githubusercontent.com/u/14878773?v=4","gravatar_id":"","url":"https://api.github.com/users/oMystique","html_url":"https://github.com/oMystique","followers_url":"https://api.github.com/users/oMystique/followers","following_url":"https://api.github.com/users/oMystique/following{/other_user}","gists_url":"https://api.github.com/users/oMystique/gists{/gist_id}","starred_url":"https://api.github.com/users/oMystique/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oMystique/subscriptions","organizations_url":"https://api.github.com/users/oMystique/orgs","repos_url":"https://api.github.com/users/oMystique/repos","events_url":"https://api.github.com/users/oMystique/events{/privacy}","received_events_url":"https://api.github.com/users/oMystique/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-05-23T08:21:41Z","updated_at":"2018-06-13T06:54:30Z","closed_at":null,"author_association":"NONE","body":"- [x] Лучше использовать scoped enum вместо обычного enum. Дело в области видимости. Прочитать можно в документации.\r\n- [x] Для хранения строковой репрезентации enum-протокола лучше создать std::map, где ключ - enum, а значение - строковое представление\r\n- [ ] Сейчас из названий тестов не понятно что тестируется конкретно: кто плохой, а кто хороший"},"comment":{"url":"https://api.github.com/repos/anastasija-stepanova/oop/issues/comments/396833672","html_url":"https://github.com/anastasija-stepanova/oop/issues/12#issuecomment-396833672","issue_url":"https://api.github.com/repos/anastasija-stepanova/oop/issues/12","id":396833672,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NjgzMzY3Mg==","user":{"login":"alexey-malov","id":6040682,"node_id":"MDQ6VXNlcjYwNDA2ODI=","avatar_url":"https://avatars3.githubusercontent.com/u/6040682?v=4","gravatar_id":"","url":"https://api.github.com/users/alexey-malov","html_url":"https://github.com/alexey-malov","followers_url":"https://api.github.com/users/alexey-malov/followers","following_url":"https://api.github.com/users/alexey-malov/following{/other_user}","gists_url":"https://api.github.com/users/alexey-malov/gists{/gist_id}","starred_url":"https://api.github.com/users/alexey-malov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexey-malov/subscriptions","organizations_url":"https://api.github.com/users/alexey-malov/orgs","repos_url":"https://api.github.com/users/alexey-malov/repos","events_url":"https://api.github.com/users/alexey-malov/events{/privacy}","received_events_url":"https://api.github.com/users/alexey-malov/received_events","type":"User","site_admin":false},"created_at":"2018-06-13T06:54:30Z","updated_at":"2018-06-13T06:54:30Z","author_association":"COLLABORATOR","body":"- [ ] Функция CheckNumberOfPort и метод CheckPortInRange дублируют друг друга. CheckPortInRange не использует данные класса и при этом не является статическим. Оставить только функцию."}}
{"actor":{"display_login":"alexey-malov"}}