{"action":"created","comment":{"url":"https://api.github.com/repos/measurement-factory/squid/pulls/comments/229742875","pull_request_review_id":170313804,"id":229742875,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTc0Mjg3NQ==","diff_hunk":"@@ -160,6 +221,11 @@ errorInitialize(void)\n     const char *text;\n     error_page_count = ERR_MAX + ErrorDynamicPages.size();\n     error_text = static_cast<char **>(xcalloc(error_page_count, sizeof(char *)));\n+    // error pages validator to use as base\n+    ErrTextValidator validator(\"ErrorPageFile\");\n+    validator.warn(DBG_CRITICAL);\n+    if (!reconfiguring)","path":"src/errorpage.cc","position":125,"original_position":133,"commit_id":"b048aada63f4b23158b52686fdcaf50226ad4d7a","original_commit_id":"58a45b10d9bf6fd2d8c235b2e99a15ae3b91ab77","user":{"login":"chtsanti","id":30215174,"node_id":"MDQ6VXNlcjMwMjE1MTc0","avatar_url":"https://avatars2.githubusercontent.com/u/30215174?v=4","gravatar_id":"","url":"https://api.github.com/users/chtsanti","html_url":"https://github.com/chtsanti","followers_url":"https://api.github.com/users/chtsanti/followers","following_url":"https://api.github.com/users/chtsanti/following{/other_user}","gists_url":"https://api.github.com/users/chtsanti/gists{/gist_id}","starred_url":"https://api.github.com/users/chtsanti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chtsanti/subscriptions","organizations_url":"https://api.github.com/users/chtsanti/orgs","repos_url":"https://api.github.com/users/chtsanti/repos","events_url":"https://api.github.com/users/chtsanti/events{/privacy}","received_events_url":"https://api.github.com/users/chtsanti/received_events","type":"User","site_admin":false},"body":"So I am keeping the \"!reconfiguring\" and marking this as resolved","created_at":"2018-10-31T15:23:46Z","updated_at":"2018-10-31T15:23:46Z","html_url":"https://github.com/measurement-factory/squid/pull/4#discussion_r229742875","pull_request_url":"https://api.github.com/repos/measurement-factory/squid/pulls/4","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/measurement-factory/squid/pulls/comments/229742875"},"html":{"href":"https://github.com/measurement-factory/squid/pull/4#discussion_r229742875"},"pull_request":{"href":"https://api.github.com/repos/measurement-factory/squid/pulls/4"}},"in_reply_to_id":227415433},"pull_request":{"url":"https://api.github.com/repos/measurement-factory/squid/pulls/4","id":186585041,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg2NTg1MDQx","html_url":"https://github.com/measurement-factory/squid/pull/4","diff_url":"https://github.com/measurement-factory/squid/pull/4.diff","patch_url":"https://github.com/measurement-factory/squid/pull/4.patch","issue_url":"https://api.github.com/repos/measurement-factory/squid/issues/4","number":4,"state":"open","locked":false,"title":"Support logformat %codes in error page templates","user":{"login":"chtsanti","id":30215174,"node_id":"MDQ6VXNlcjMwMjE1MTc0","avatar_url":"https://avatars2.githubusercontent.com/u/30215174?v=4","gravatar_id":"","url":"https://api.github.com/users/chtsanti","html_url":"https://github.com/chtsanti","followers_url":"https://api.github.com/users/chtsanti/followers","following_url":"https://api.github.com/users/chtsanti/following{/other_user}","gists_url":"https://api.github.com/users/chtsanti/gists{/gist_id}","starred_url":"https://api.github.com/users/chtsanti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chtsanti/subscriptions","organizations_url":"https://api.github.com/users/chtsanti/orgs","repos_url":"https://api.github.com/users/chtsanti/repos","events_url":"https://api.github.com/users/chtsanti/events{/privacy}","received_events_url":"https://api.github.com/users/chtsanti/received_events","type":"User","site_admin":false},"body":"... using `@Squid{%logformat}` syntax which allows Squid to distinguish classic (namespace-free) single-letter error page %codes like %M from new logformat %codes like %http::<rm.\r\n\r\nThis improvement gives error pages access to more information about the failed transaction and paves the way towards unifying the two partially duplicated %code interfaces (and underlying code).\r\n    \r\nSome single-letter error page %codes have similar logformat %codes. For example, error page %i will often be replaced with the same characters as `@Squid{%>a}`. However, admins should not rely on expansion equivalence because most codes may be rendered differently under some conditions, and the two rendering algorithms are not kept in sync. For example, error page %i does not account for log_uses_indirect_client.\r\n    \r\nOnly a few letters remain unused by the error page %codes. Most (possibly all) new codes should be added to the logformat instead, within an appropriate error_page:: namespace if needed.\r\n    \r\nThis is a Measurement Factory project.","created_at":"2018-05-08T10:04:49Z","updated_at":"2018-10-31T15:23:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"86f58e1fd87e7eff0d9adbb089cc906309548cd2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/measurement-factory/squid/pulls/4/commits","review_comments_url":"https://api.github.com/repos/measurement-factory/squid/pulls/4/comments","review_comment_url":"https://api.github.com/repos/measurement-factory/squid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/measurement-factory/squid/issues/4/comments","statuses_url":"https://api.github.com/repos/measurement-factory/squid/statuses/b048aada63f4b23158b52686fdcaf50226ad4d7a","head":{"label":"measurement-factory:SQUID-333-Enable-logformat-in-error-pages","ref":"SQUID-333-Enable-logformat-in-error-pages","sha":"b048aada63f4b23158b52686fdcaf50226ad4d7a","user":{"login":"measurement-factory","id":5461029,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0NjEwMjk=","avatar_url":"https://avatars1.githubusercontent.com/u/5461029?v=4","gravatar_id":"","url":"https://api.github.com/users/measurement-factory","html_url":"https://github.com/measurement-factory","followers_url":"https://api.github.com/users/measurement-factory/followers","following_url":"https://api.github.com/users/measurement-factory/following{/other_user}","gists_url":"https://api.github.com/users/measurement-factory/gists{/gist_id}","starred_url":"https://api.github.com/users/measurement-factory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/measurement-factory/subscriptions","organizations_url":"https://api.github.com/users/measurement-factory/orgs","repos_url":"https://api.github.com/users/measurement-factory/repos","events_url":"https://api.github.com/users/measurement-factory/events{/privacy}","received_events_url":"https://api.github.com/users/measurement-factory/received_events","type":"Organization","site_admin":false},"repo":{"id":97358214,"node_id":"MDEwOlJlcG9zaXRvcnk5NzM1ODIxNA==","name":"squid","full_name":"measurement-factory/squid","private":false,"owner":{"login":"measurement-factory","id":5461029,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0NjEwMjk=","avatar_url":"https://avatars1.githubusercontent.com/u/5461029?v=4","gravatar_id":"","url":"https://api.github.com/users/measurement-factory","html_url":"https://github.com/measurement-factory","followers_url":"https://api.github.com/users/measurement-factory/followers","following_url":"https://api.github.com/users/measurement-factory/following{/other_user}","gists_url":"https://api.github.com/users/measurement-factory/gists{/gist_id}","starred_url":"https://api.github.com/users/measurement-factory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/measurement-factory/subscriptions","organizations_url":"https://api.github.com/users/measurement-factory/orgs","repos_url":"https://api.github.com/users/measurement-factory/repos","events_url":"https://api.github.com/users/measurement-factory/events{/privacy}","received_events_url":"https://api.github.com/users/measurement-factory/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/measurement-factory/squid","description":"Squid Web Proxy Cache","fork":true,"url":"https://api.github.com/repos/measurement-factory/squid","forks_url":"https://api.github.com/repos/measurement-factory/squid/forks","keys_url":"https://api.github.com/repos/measurement-factory/squid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/measurement-factory/squid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/measurement-factory/squid/teams","hooks_url":"https://api.github.com/repos/measurement-factory/squid/hooks","issue_events_url":"https://api.github.com/repos/measurement-factory/squid/issues/events{/number}","events_url":"https://api.github.com/repos/measurement-factory/squid/events","assignees_url":"https://api.github.com/repos/measurement-factory/squid/assignees{/user}","branches_url":"https://api.github.com/repos/measurement-factory/squid/branches{/branch}","tags_url":"https://api.github.com/repos/measurement-factory/squid/tags","blobs_url":"https://api.github.com/repos/measurement-factory/squid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/measurement-factory/squid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/measurement-factory/squid/git/refs{/sha}","trees_url":"https://api.github.com/repos/measurement-factory/squid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/measurement-factory/squid/statuses/{sha}","languages_url":"https://api.github.com/repos/measurement-factory/squid/languages","stargazers_url":"https://api.github.com/repos/measurement-factory/squid/stargazers","contributors_url":"https://api.github.com/repos/measurement-factory/squid/contributors","subscribers_url":"https://api.github.com/repos/measurement-factory/squid/subscribers","subscription_url":"https://api.github.com/repos/measurement-factory/squid/subscription","commits_url":"https://api.github.com/repos/measurement-factory/squid/commits{/sha}","git_commits_url":"https://api.github.com/repos/measurement-factory/squid/git/commits{/sha}","comments_url":"https://api.github.com/repos/measurement-factory/squid/comments{/number}","issue_comment_url":"https://api.github.com/repos/measurement-factory/squid/issues/comments{/number}","contents_url":"https://api.github.com/repos/measurement-factory/squid/contents/{+path}","compare_url":"https://api.github.com/repos/measurement-factory/squid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/measurement-factory/squid/merges","archive_url":"https://api.github.com/repos/measurement-factory/squid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/measurement-factory/squid/downloads","issues_url":"https://api.github.com/repos/measurement-factory/squid/issues{/number}","pulls_url":"https://api.github.com/repos/measurement-factory/squid/pulls{/number}","milestones_url":"https://api.github.com/repos/measurement-factory/squid/milestones{/number}","notifications_url":"https://api.github.com/repos/measurement-factory/squid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/measurement-factory/squid/labels{/name}","releases_url":"https://api.github.com/repos/measurement-factory/squid/releases{/id}","deployments_url":"https://api.github.com/repos/measurement-factory/squid/deployments","created_at":"2017-07-16T03:46:50Z","updated_at":"2018-10-30T05:56:53Z","pushed_at":"2018-10-31T15:19:04Z","git_url":"git://github.com/measurement-factory/squid.git","ssh_url":"git@github.com:measurement-factory/squid.git","clone_url":"https://github.com/measurement-factory/squid.git","svn_url":"https://github.com/measurement-factory/squid","homepage":"http://www.squid-cache.org/","size":172299,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":13,"watchers":0,"default_branch":"master"}},"base":{"label":"measurement-factory:master","ref":"master","sha":"c8ab5ec6c34fbd6544cf8fac9fd6266e7651ffed","user":{"login":"measurement-factory","id":5461029,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0NjEwMjk=","avatar_url":"https://avatars1.githubusercontent.com/u/5461029?v=4","gravatar_id":"","url":"https://api.github.com/users/measurement-factory","html_url":"https://github.com/measurement-factory","followers_url":"https://api.github.com/users/measurement-factory/followers","following_url":"https://api.github.com/users/measurement-factory/following{/other_user}","gists_url":"https://api.github.com/users/measurement-factory/gists{/gist_id}","starred_url":"https://api.github.com/users/measurement-factory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/measurement-factory/subscriptions","organizations_url":"https://api.github.com/users/measurement-factory/orgs","repos_url":"https://api.github.com/users/measurement-factory/repos","events_url":"https://api.github.com/users/measurement-factory/events{/privacy}","received_events_url":"https://api.github.com/users/measurement-factory/received_events","type":"Organization","site_admin":false},"repo":{"id":97358214,"node_id":"MDEwOlJlcG9zaXRvcnk5NzM1ODIxNA==","name":"squid","full_name":"measurement-factory/squid","private":false,"owner":{"login":"measurement-factory","id":5461029,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0NjEwMjk=","avatar_url":"https://avatars1.githubusercontent.com/u/5461029?v=4","gravatar_id":"","url":"https://api.github.com/users/measurement-factory","html_url":"https://github.com/measurement-factory","followers_url":"https://api.github.com/users/measurement-factory/followers","following_url":"https://api.github.com/users/measurement-factory/following{/other_user}","gists_url":"https://api.github.com/users/measurement-factory/gists{/gist_id}","starred_url":"https://api.github.com/users/measurement-factory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/measurement-factory/subscriptions","organizations_url":"https://api.github.com/users/measurement-factory/orgs","repos_url":"https://api.github.com/users/measurement-factory/repos","events_url":"https://api.github.com/users/measurement-factory/events{/privacy}","received_events_url":"https://api.github.com/users/measurement-factory/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/measurement-factory/squid","description":"Squid Web Proxy Cache","fork":true,"url":"https://api.github.com/repos/measurement-factory/squid","forks_url":"https://api.github.com/repos/measurement-factory/squid/forks","keys_url":"https://api.github.com/repos/measurement-factory/squid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/measurement-factory/squid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/measurement-factory/squid/teams","hooks_url":"https://api.github.com/repos/measurement-factory/squid/hooks","issue_events_url":"https://api.github.com/repos/measurement-factory/squid/issues/events{/number}","events_url":"https://api.github.com/repos/measurement-factory/squid/events","assignees_url":"https://api.github.com/repos/measurement-factory/squid/assignees{/user}","branches_url":"https://api.github.com/repos/measurement-factory/squid/branches{/branch}","tags_url":"https://api.github.com/repos/measurement-factory/squid/tags","blobs_url":"https://api.github.com/repos/measurement-factory/squid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/measurement-factory/squid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/measurement-factory/squid/git/refs{/sha}","trees_url":"https://api.github.com/repos/measurement-factory/squid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/measurement-factory/squid/statuses/{sha}","languages_url":"https://api.github.com/repos/measurement-factory/squid/languages","stargazers_url":"https://api.github.com/repos/measurement-factory/squid/stargazers","contributors_url":"https://api.github.com/repos/measurement-factory/squid/contributors","subscribers_url":"https://api.github.com/repos/measurement-factory/squid/subscribers","subscription_url":"https://api.github.com/repos/measurement-factory/squid/subscription","commits_url":"https://api.github.com/repos/measurement-factory/squid/commits{/sha}","git_commits_url":"https://api.github.com/repos/measurement-factory/squid/git/commits{/sha}","comments_url":"https://api.github.com/repos/measurement-factory/squid/comments{/number}","issue_comment_url":"https://api.github.com/repos/measurement-factory/squid/issues/comments{/number}","contents_url":"https://api.github.com/repos/measurement-factory/squid/contents/{+path}","compare_url":"https://api.github.com/repos/measurement-factory/squid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/measurement-factory/squid/merges","archive_url":"https://api.github.com/repos/measurement-factory/squid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/measurement-factory/squid/downloads","issues_url":"https://api.github.com/repos/measurement-factory/squid/issues{/number}","pulls_url":"https://api.github.com/repos/measurement-factory/squid/pulls{/number}","milestones_url":"https://api.github.com/repos/measurement-factory/squid/milestones{/number}","notifications_url":"https://api.github.com/repos/measurement-factory/squid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/measurement-factory/squid/labels{/name}","releases_url":"https://api.github.com/repos/measurement-factory/squid/releases{/id}","deployments_url":"https://api.github.com/repos/measurement-factory/squid/deployments","created_at":"2017-07-16T03:46:50Z","updated_at":"2018-10-30T05:56:53Z","pushed_at":"2018-10-31T15:19:04Z","git_url":"git://github.com/measurement-factory/squid.git","ssh_url":"git@github.com:measurement-factory/squid.git","clone_url":"https://github.com/measurement-factory/squid.git","svn_url":"https://github.com/measurement-factory/squid","homepage":"http://www.squid-cache.org/","size":172299,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":13,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/measurement-factory/squid/pulls/4"},"html":{"href":"https://github.com/measurement-factory/squid/pull/4"},"issue":{"href":"https://api.github.com/repos/measurement-factory/squid/issues/4"},"comments":{"href":"https://api.github.com/repos/measurement-factory/squid/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/measurement-factory/squid/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/measurement-factory/squid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/measurement-factory/squid/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/measurement-factory/squid/statuses/b048aada63f4b23158b52686fdcaf50226ad4d7a"}},"author_association":"NONE"}}
{"actor":{"display_login":"chtsanti"}}