{"action":"closed","issue":{"url":"https://api.github.com/repos/pupil-labs/pupil/issues/1394","repository_url":"https://api.github.com/repos/pupil-labs/pupil","labels_url":"https://api.github.com/repos/pupil-labs/pupil/issues/1394/labels{/name}","comments_url":"https://api.github.com/repos/pupil-labs/pupil/issues/1394/comments","events_url":"https://api.github.com/repos/pupil-labs/pupil/issues/1394/events","html_url":"https://github.com/pupil-labs/pupil/issues/1394","id":382938710,"node_id":"MDU6SXNzdWUzODI5Mzg3MTA=","number":1394,"title":"Errors in fixation_report.csv -  incorrect unit for `min_duration` and missing `max_duration` key, value","user":{"login":"willpatera","id":1407224,"node_id":"MDQ6VXNlcjE0MDcyMjQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1407224?v=4","gravatar_id":"","url":"https://api.github.com/users/willpatera","html_url":"https://github.com/willpatera","followers_url":"https://api.github.com/users/willpatera/followers","following_url":"https://api.github.com/users/willpatera/following{/other_user}","gists_url":"https://api.github.com/users/willpatera/gists{/gist_id}","starred_url":"https://api.github.com/users/willpatera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willpatera/subscriptions","organizations_url":"https://api.github.com/users/willpatera/orgs","repos_url":"https://api.github.com/users/willpatera/repos","events_url":"https://api.github.com/users/willpatera/events{/privacy}","received_events_url":"https://api.github.com/users/willpatera/received_events","type":"User","site_admin":false},"labels":[{"id":52428140,"node_id":"MDU6TGFiZWw1MjQyODE0MA==","url":"https://api.github.com/repos/pupil-labs/pupil/labels/bug","name":"bug","color":"c4524a","default":true},{"id":301365475,"node_id":"MDU6TGFiZWwzMDEzNjU0NzU=","url":"https://api.github.com/repos/pupil-labs/pupil/labels/priority:high","name":"priority:high","color":"fad8c7","default":false}],"state":"closed","locked":false,"assignee":{"login":"papr","id":168390,"node_id":"MDQ6VXNlcjE2ODM5MA==","avatar_url":"https://avatars3.githubusercontent.com/u/168390?v=4","gravatar_id":"","url":"https://api.github.com/users/papr","html_url":"https://github.com/papr","followers_url":"https://api.github.com/users/papr/followers","following_url":"https://api.github.com/users/papr/following{/other_user}","gists_url":"https://api.github.com/users/papr/gists{/gist_id}","starred_url":"https://api.github.com/users/papr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/papr/subscriptions","organizations_url":"https://api.github.com/users/papr/orgs","repos_url":"https://api.github.com/users/papr/repos","events_url":"https://api.github.com/users/papr/events{/privacy}","received_events_url":"https://api.github.com/users/papr/received_events","type":"User","site_admin":false},"assignees":[{"login":"papr","id":168390,"node_id":"MDQ6VXNlcjE2ODM5MA==","avatar_url":"https://avatars3.githubusercontent.com/u/168390?v=4","gravatar_id":"","url":"https://api.github.com/users/papr","html_url":"https://github.com/papr","followers_url":"https://api.github.com/users/papr/followers","following_url":"https://api.github.com/users/papr/following{/other_user}","gists_url":"https://api.github.com/users/papr/gists{/gist_id}","starred_url":"https://api.github.com/users/papr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/papr/subscriptions","organizations_url":"https://api.github.com/users/papr/orgs","repos_url":"https://api.github.com/users/papr/repos","events_url":"https://api.github.com/users/papr/events{/privacy}","received_events_url":"https://api.github.com/users/papr/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/pupil-labs/pupil/milestones/17","html_url":"https://github.com/pupil-labs/pupil/milestone/17","labels_url":"https://api.github.com/repos/pupil-labs/pupil/milestones/17/labels","id":3723816,"node_id":"MDk6TWlsZXN0b25lMzcyMzgxNg==","number":17,"title":"v1.10","description":"","creator":{"login":"papr","id":168390,"node_id":"MDQ6VXNlcjE2ODM5MA==","avatar_url":"https://avatars3.githubusercontent.com/u/168390?v=4","gravatar_id":"","url":"https://api.github.com/users/papr","html_url":"https://github.com/papr","followers_url":"https://api.github.com/users/papr/followers","following_url":"https://api.github.com/users/papr/following{/other_user}","gists_url":"https://api.github.com/users/papr/gists{/gist_id}","starred_url":"https://api.github.com/users/papr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/papr/subscriptions","organizations_url":"https://api.github.com/users/papr/orgs","repos_url":"https://api.github.com/users/papr/repos","events_url":"https://api.github.com/users/papr/events{/privacy}","received_events_url":"https://api.github.com/users/papr/received_events","type":"User","site_admin":false},"open_issues":13,"closed_issues":8,"state":"open","created_at":"2018-10-09T11:24:29Z","updated_at":"2018-11-22T09:18:31Z","due_on":null,"closed_at":null},"comments":0,"created_at":"2018-11-21T03:21:21Z","updated_at":"2018-11-22T09:18:31Z","closed_at":"2018-11-22T09:18:31Z","author_association":"MEMBER","body":"## Overview\r\nThere are a few inconsistencies and errors present in the `fixation_report.csv` when exported from Pupil Player.\r\n\r\n- incorrect `min_duration` value unit - `min_duration` value unit in `fixation_report.csv` is `sec`. In Pupil Player interface the units are `ms`. When I set `min_duration` to `300.00` in in Pupil Player Fixation Detector plugin, I would expect to see the same unit in the export **or** at least equivalent conversion (e.g. 300.00 ms or 0.3 sec).\r\n- missing `max_duration` key and value - the key and value are missing/absent, and should be in the report.\r\n\r\n## Reference to Error\r\nhttps://github.com/pupil-labs/pupil/blob/1fdc80a87f076eb146c54b0ca660e9fc7e9f23ad/pupil_src/shared_modules/fixation_detector.py#L654\r\n\r\n## Proposed fix\r\n```\r\ncsv_writer.writerow((\"min_duration\", \"{:0.3f} ms\".format(self.min_duration)))\r\ncsv_writer.writerow((\"max_duration\", \"{:0.3f} ms\".format(self.max_duration)))\r\n```"}}
{"actor":{"display_login":"papr"}}