{"action":"created","issue":{"url":"https://api.github.com/repos/saltstack/salt/issues/45160","repository_url":"https://api.github.com/repos/saltstack/salt","labels_url":"https://api.github.com/repos/saltstack/salt/issues/45160/labels{/name}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/45160/comments","events_url":"https://api.github.com/repos/saltstack/salt/issues/45160/events","html_url":"https://github.com/saltstack/salt/pull/45160","id":284397481,"number":45160,"title":"Backport #44944 to develop","user":{"login":"lomeroe","id":8835244,"avatar_url":"https://avatars0.githubusercontent.com/u/8835244?v=4","gravatar_id":"","url":"https://api.github.com/users/lomeroe","html_url":"https://github.com/lomeroe","followers_url":"https://api.github.com/users/lomeroe/followers","following_url":"https://api.github.com/users/lomeroe/following{/other_user}","gists_url":"https://api.github.com/users/lomeroe/gists{/gist_id}","starred_url":"https://api.github.com/users/lomeroe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lomeroe/subscriptions","organizations_url":"https://api.github.com/users/lomeroe/orgs","repos_url":"https://api.github.com/users/lomeroe/repos","events_url":"https://api.github.com/users/lomeroe/events{/privacy}","received_events_url":"https://api.github.com/users/lomeroe/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-12-25T03:07:57Z","updated_at":"2018-02-06T20:46:59Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/saltstack/salt/pulls/45160","html_url":"https://github.com/saltstack/salt/pull/45160","diff_url":"https://github.com/saltstack/salt/pull/45160.diff","patch_url":"https://github.com/saltstack/salt/pull/45160.patch"},"body":"### What does this PR do?\r\nBackport #44944 to develop\r\n\r\n### What issues does this PR fix or reference?\r\n#44516\r\n\r\n### Previous Behavior\r\nEncoding errors would be returned on py3 for items whose data item where a unicode surrogate when attempting to encode, the same would happen on py2 when attempting to decode a surrogate value that existed in the registry.pol file.\r\n\r\n### New Behavior\r\nData items are not encoded/decoded unless necessary resulting in no need to ignore surrogates/etc (i.e. data is compared as byte objects instead of converting to more human friendly/readable objects)\r\n\r\n### Tests written?\r\nNo\r\n\r\n### Commits signed with GPG?\r\nNo\r\n\r\nPlease review [Salt's Contributing Guide](https://docs.saltstack.com/en/latest/topics/development/contributing.html) for best practices.\r\n\r\nSee GitHub's [page on GPG signing](https://help.github.com/articles/signing-commits-using-gpg/) for more information about signing commits with GPG.\r\n"},"comment":{"url":"https://api.github.com/repos/saltstack/salt/issues/comments/363559713","html_url":"https://github.com/saltstack/salt/pull/45160#issuecomment-363559713","issue_url":"https://api.github.com/repos/saltstack/salt/issues/45160","id":363559713,"user":{"login":"lomeroe","id":8835244,"avatar_url":"https://avatars0.githubusercontent.com/u/8835244?v=4","gravatar_id":"","url":"https://api.github.com/users/lomeroe","html_url":"https://github.com/lomeroe","followers_url":"https://api.github.com/users/lomeroe/followers","following_url":"https://api.github.com/users/lomeroe/following{/other_user}","gists_url":"https://api.github.com/users/lomeroe/gists{/gist_id}","starred_url":"https://api.github.com/users/lomeroe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lomeroe/subscriptions","organizations_url":"https://api.github.com/users/lomeroe/orgs","repos_url":"https://api.github.com/users/lomeroe/repos","events_url":"https://api.github.com/users/lomeroe/events{/privacy}","received_events_url":"https://api.github.com/users/lomeroe/received_events","type":"User","site_admin":false},"created_at":"2018-02-06T20:46:59Z","updated_at":"2018-02-06T20:46:59Z","author_association":"CONTRIBUTOR","body":"yep, those have happened now, so you are right"}}
{"actor":{"display_login":"lomeroe"}}