{"action":"created","comment":{"url":"https://api.github.com/repos/angular/material2/pulls/comments/176273742","pull_request_review_id":105947627,"id":176273742,"diff_hunk":"@@ -29,7 +31,131 @@ import {MatDatepickerIntl} from './datepicker-intl';\n import {MatMonthView} from './month-view';\n import {MatMultiYearView, yearsPerPage} from './multi-year-view';\n import {MatYearView} from './year-view';\n+import {ComponentPortal, ComponentType, Portal} from '@angular/cdk/portal';\n+import {Subject} from 'rxjs/Subject';\n+import {takeUntil} from 'rxjs/operators/takeUntil';\n \n+/** Default header for MatCalendar */\n+@Component({\n+  moduleId: module.id,\n+  selector: 'mat-calendar-header',\n+  templateUrl: 'calendar-header.html',\n+  encapsulation: ViewEncapsulation.None,\n+  preserveWhitespaces: false,\n+  changeDetection: ChangeDetectionStrategy.OnPush,\n+})\n+export class MatCalendarHeader<D> implements OnDestroy {\n+  /** Subject that emits when the component has been destroyed. */\n+  private _destroyed = new Subject<void>();","path":"src/lib/datepicker/calendar.ts","position":41,"original_position":28,"commit_id":"1ee0f93dc97f10b789d2d3d7c0fd6f44599d31ac","original_commit_id":"ba4e839275847f8582c423fd64da002a9e3d1549","user":{"login":"mmalerba","id":14793288,"avatar_url":"https://avatars1.githubusercontent.com/u/14793288?v=4","gravatar_id":"","url":"https://api.github.com/users/mmalerba","html_url":"https://github.com/mmalerba","followers_url":"https://api.github.com/users/mmalerba/followers","following_url":"https://api.github.com/users/mmalerba/following{/other_user}","gists_url":"https://api.github.com/users/mmalerba/gists{/gist_id}","starred_url":"https://api.github.com/users/mmalerba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmalerba/subscriptions","organizations_url":"https://api.github.com/users/mmalerba/orgs","repos_url":"https://api.github.com/users/mmalerba/repos","events_url":"https://api.github.com/users/mmalerba/events{/privacy}","received_events_url":"https://api.github.com/users/mmalerba/received_events","type":"User","site_admin":false},"body":"I have seen some of the `_destroyed` subjects in our code marked `readonly`, but to me it feels unnecessary for `private` properties. ","created_at":"2018-03-21T23:45:02Z","updated_at":"2018-03-21T23:45:02Z","html_url":"https://github.com/angular/material2/pull/9639#discussion_r176273742","pull_request_url":"https://api.github.com/repos/angular/material2/pulls/9639","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/angular/material2/pulls/comments/176273742"},"html":{"href":"https://github.com/angular/material2/pull/9639#discussion_r176273742"},"pull_request":{"href":"https://api.github.com/repos/angular/material2/pulls/9639"}},"in_reply_to_id":176252838},"pull_request":{"url":"https://api.github.com/repos/angular/material2/pulls/9639","id":165517250,"html_url":"https://github.com/angular/material2/pull/9639","diff_url":"https://github.com/angular/material2/pull/9639.diff","patch_url":"https://github.com/angular/material2/pull/9639.patch","issue_url":"https://api.github.com/repos/angular/material2/issues/9639","number":9639,"state":"open","locked":false,"title":"feat(datepicker): Add Custom Header to DatePicker","user":{"login":"tobiasschweizer","id":6000023,"avatar_url":"https://avatars3.githubusercontent.com/u/6000023?v=4","gravatar_id":"","url":"https://api.github.com/users/tobiasschweizer","html_url":"https://github.com/tobiasschweizer","followers_url":"https://api.github.com/users/tobiasschweizer/followers","following_url":"https://api.github.com/users/tobiasschweizer/following{/other_user}","gists_url":"https://api.github.com/users/tobiasschweizer/gists{/gist_id}","starred_url":"https://api.github.com/users/tobiasschweizer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobiasschweizer/subscriptions","organizations_url":"https://api.github.com/users/tobiasschweizer/orgs","repos_url":"https://api.github.com/users/tobiasschweizer/repos","events_url":"https://api.github.com/users/tobiasschweizer/events{/privacy}","received_events_url":"https://api.github.com/users/tobiasschweizer/received_events","type":"User","site_admin":false},"body":"This PR provides a new input for DatePicker so that a custom header component can be added to mat-calendar.\r\n\r\nI intend to add a custom header from which date formats can be converted (see #2519).\r\n\r\n","created_at":"2018-01-27T13:05:27Z","updated_at":"2018-03-21T23:45:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4997e2349467b2fdc271b99db9e0a4e2cbb11dec","assignee":{"login":"mmalerba","id":14793288,"avatar_url":"https://avatars1.githubusercontent.com/u/14793288?v=4","gravatar_id":"","url":"https://api.github.com/users/mmalerba","html_url":"https://github.com/mmalerba","followers_url":"https://api.github.com/users/mmalerba/followers","following_url":"https://api.github.com/users/mmalerba/following{/other_user}","gists_url":"https://api.github.com/users/mmalerba/gists{/gist_id}","starred_url":"https://api.github.com/users/mmalerba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmalerba/subscriptions","organizations_url":"https://api.github.com/users/mmalerba/orgs","repos_url":"https://api.github.com/users/mmalerba/repos","events_url":"https://api.github.com/users/mmalerba/events{/privacy}","received_events_url":"https://api.github.com/users/mmalerba/received_events","type":"User","site_admin":false},"assignees":[{"login":"mmalerba","id":14793288,"avatar_url":"https://avatars1.githubusercontent.com/u/14793288?v=4","gravatar_id":"","url":"https://api.github.com/users/mmalerba","html_url":"https://github.com/mmalerba","followers_url":"https://api.github.com/users/mmalerba/followers","following_url":"https://api.github.com/users/mmalerba/following{/other_user}","gists_url":"https://api.github.com/users/mmalerba/gists{/gist_id}","starred_url":"https://api.github.com/users/mmalerba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmalerba/subscriptions","organizations_url":"https://api.github.com/users/mmalerba/orgs","repos_url":"https://api.github.com/users/mmalerba/repos","events_url":"https://api.github.com/users/mmalerba/events{/privacy}","received_events_url":"https://api.github.com/users/mmalerba/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"jelbourn","id":838736,"avatar_url":"https://avatars3.githubusercontent.com/u/838736?v=4","gravatar_id":"","url":"https://api.github.com/users/jelbourn","html_url":"https://github.com/jelbourn","followers_url":"https://api.github.com/users/jelbourn/followers","following_url":"https://api.github.com/users/jelbourn/following{/other_user}","gists_url":"https://api.github.com/users/jelbourn/gists{/gist_id}","starred_url":"https://api.github.com/users/jelbourn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jelbourn/subscriptions","organizations_url":"https://api.github.com/users/jelbourn/orgs","repos_url":"https://api.github.com/users/jelbourn/repos","events_url":"https://api.github.com/users/jelbourn/events{/privacy}","received_events_url":"https://api.github.com/users/jelbourn/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":308798701,"url":"https://api.github.com/repos/angular/material2/labels/cla:%20yes","name":"cla: yes","color":"009800","default":false},{"id":311422716,"url":"https://api.github.com/repos/angular/material2/labels/pr:%20lgtm","name":"pr: lgtm","color":"009800","default":false},{"id":408329699,"url":"https://api.github.com/repos/angular/material2/labels/pr:%20merge%20ready","name":"pr: merge ready","color":"a3f579","default":false},{"id":770558815,"url":"https://api.github.com/repos/angular/material2/labels/release:%20minor","name":"release: minor","color":"35b7ce","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/angular/material2/pulls/9639/commits","review_comments_url":"https://api.github.com/repos/angular/material2/pulls/9639/comments","review_comment_url":"https://api.github.com/repos/angular/material2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/material2/issues/9639/comments","statuses_url":"https://api.github.com/repos/angular/material2/statuses/1ee0f93dc97f10b789d2d3d7c0fd6f44599d31ac","head":{"label":"dhlab-basel:tobiasschweizer/calendar-header-comp","ref":"tobiasschweizer/calendar-header-comp","sha":"1ee0f93dc97f10b789d2d3d7c0fd6f44599d31ac","user":{"login":"dhlab-basel","id":16879914,"avatar_url":"https://avatars0.githubusercontent.com/u/16879914?v=4","gravatar_id":"","url":"https://api.github.com/users/dhlab-basel","html_url":"https://github.com/dhlab-basel","followers_url":"https://api.github.com/users/dhlab-basel/followers","following_url":"https://api.github.com/users/dhlab-basel/following{/other_user}","gists_url":"https://api.github.com/users/dhlab-basel/gists{/gist_id}","starred_url":"https://api.github.com/users/dhlab-basel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhlab-basel/subscriptions","organizations_url":"https://api.github.com/users/dhlab-basel/orgs","repos_url":"https://api.github.com/users/dhlab-basel/repos","events_url":"https://api.github.com/users/dhlab-basel/events{/privacy}","received_events_url":"https://api.github.com/users/dhlab-basel/received_events","type":"Organization","site_admin":false},"repo":{"id":113205740,"name":"material2","full_name":"dhlab-basel/material2","owner":{"login":"dhlab-basel","id":16879914,"avatar_url":"https://avatars0.githubusercontent.com/u/16879914?v=4","gravatar_id":"","url":"https://api.github.com/users/dhlab-basel","html_url":"https://github.com/dhlab-basel","followers_url":"https://api.github.com/users/dhlab-basel/followers","following_url":"https://api.github.com/users/dhlab-basel/following{/other_user}","gists_url":"https://api.github.com/users/dhlab-basel/gists{/gist_id}","starred_url":"https://api.github.com/users/dhlab-basel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhlab-basel/subscriptions","organizations_url":"https://api.github.com/users/dhlab-basel/orgs","repos_url":"https://api.github.com/users/dhlab-basel/repos","events_url":"https://api.github.com/users/dhlab-basel/events{/privacy}","received_events_url":"https://api.github.com/users/dhlab-basel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dhlab-basel/material2","description":"Material Design components for Angular","fork":true,"url":"https://api.github.com/repos/dhlab-basel/material2","forks_url":"https://api.github.com/repos/dhlab-basel/material2/forks","keys_url":"https://api.github.com/repos/dhlab-basel/material2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dhlab-basel/material2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dhlab-basel/material2/teams","hooks_url":"https://api.github.com/repos/dhlab-basel/material2/hooks","issue_events_url":"https://api.github.com/repos/dhlab-basel/material2/issues/events{/number}","events_url":"https://api.github.com/repos/dhlab-basel/material2/events","assignees_url":"https://api.github.com/repos/dhlab-basel/material2/assignees{/user}","branches_url":"https://api.github.com/repos/dhlab-basel/material2/branches{/branch}","tags_url":"https://api.github.com/repos/dhlab-basel/material2/tags","blobs_url":"https://api.github.com/repos/dhlab-basel/material2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dhlab-basel/material2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dhlab-basel/material2/git/refs{/sha}","trees_url":"https://api.github.com/repos/dhlab-basel/material2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dhlab-basel/material2/statuses/{sha}","languages_url":"https://api.github.com/repos/dhlab-basel/material2/languages","stargazers_url":"https://api.github.com/repos/dhlab-basel/material2/stargazers","contributors_url":"https://api.github.com/repos/dhlab-basel/material2/contributors","subscribers_url":"https://api.github.com/repos/dhlab-basel/material2/subscribers","subscription_url":"https://api.github.com/repos/dhlab-basel/material2/subscription","commits_url":"https://api.github.com/repos/dhlab-basel/material2/commits{/sha}","git_commits_url":"https://api.github.com/repos/dhlab-basel/material2/git/commits{/sha}","comments_url":"https://api.github.com/repos/dhlab-basel/material2/comments{/number}","issue_comment_url":"https://api.github.com/repos/dhlab-basel/material2/issues/comments{/number}","contents_url":"https://api.github.com/repos/dhlab-basel/material2/contents/{+path}","compare_url":"https://api.github.com/repos/dhlab-basel/material2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dhlab-basel/material2/merges","archive_url":"https://api.github.com/repos/dhlab-basel/material2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dhlab-basel/material2/downloads","issues_url":"https://api.github.com/repos/dhlab-basel/material2/issues{/number}","pulls_url":"https://api.github.com/repos/dhlab-basel/material2/pulls{/number}","milestones_url":"https://api.github.com/repos/dhlab-basel/material2/milestones{/number}","notifications_url":"https://api.github.com/repos/dhlab-basel/material2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dhlab-basel/material2/labels{/name}","releases_url":"https://api.github.com/repos/dhlab-basel/material2/releases{/id}","deployments_url":"https://api.github.com/repos/dhlab-basel/material2/deployments","created_at":"2017-12-05T16:23:16Z","updated_at":"2018-03-21T16:32:20Z","pushed_at":"2018-03-21T23:36:40Z","git_url":"git://github.com/dhlab-basel/material2.git","ssh_url":"git@github.com:dhlab-basel/material2.git","clone_url":"https://github.com/dhlab-basel/material2.git","svn_url":"https://github.com/dhlab-basel/material2","homepage":"https://material.angular.io","size":13700,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"f7b5d3444926bd75603969be464cf0b6aad6c42a","user":{"login":"angular","id":139426,"avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":49016322,"name":"material2","full_name":"angular/material2","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/material2","description":"Material Design components for Angular","fork":false,"url":"https://api.github.com/repos/angular/material2","forks_url":"https://api.github.com/repos/angular/material2/forks","keys_url":"https://api.github.com/repos/angular/material2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/material2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/material2/teams","hooks_url":"https://api.github.com/repos/angular/material2/hooks","issue_events_url":"https://api.github.com/repos/angular/material2/issues/events{/number}","events_url":"https://api.github.com/repos/angular/material2/events","assignees_url":"https://api.github.com/repos/angular/material2/assignees{/user}","branches_url":"https://api.github.com/repos/angular/material2/branches{/branch}","tags_url":"https://api.github.com/repos/angular/material2/tags","blobs_url":"https://api.github.com/repos/angular/material2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/material2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/material2/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/material2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/material2/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/material2/languages","stargazers_url":"https://api.github.com/repos/angular/material2/stargazers","contributors_url":"https://api.github.com/repos/angular/material2/contributors","subscribers_url":"https://api.github.com/repos/angular/material2/subscribers","subscription_url":"https://api.github.com/repos/angular/material2/subscription","commits_url":"https://api.github.com/repos/angular/material2/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/material2/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/material2/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/material2/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/material2/contents/{+path}","compare_url":"https://api.github.com/repos/angular/material2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/material2/merges","archive_url":"https://api.github.com/repos/angular/material2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/material2/downloads","issues_url":"https://api.github.com/repos/angular/material2/issues{/number}","pulls_url":"https://api.github.com/repos/angular/material2/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/material2/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/material2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/material2/labels{/name}","releases_url":"https://api.github.com/repos/angular/material2/releases{/id}","deployments_url":"https://api.github.com/repos/angular/material2/deployments","created_at":"2016-01-04T18:50:02Z","updated_at":"2018-03-21T23:05:34Z","pushed_at":"2018-03-21T23:36:47Z","git_url":"git://github.com/angular/material2.git","ssh_url":"git@github.com:angular/material2.git","clone_url":"https://github.com/angular/material2.git","svn_url":"https://github.com/angular/material2","homepage":"https://material.angular.io","size":13551,"stargazers_count":13564,"watchers_count":13564,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3330,"mirror_url":null,"archived":false,"open_issues_count":945,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":3330,"open_issues":945,"watchers":13564,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/material2/pulls/9639"},"html":{"href":"https://github.com/angular/material2/pull/9639"},"issue":{"href":"https://api.github.com/repos/angular/material2/issues/9639"},"comments":{"href":"https://api.github.com/repos/angular/material2/issues/9639/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/material2/pulls/9639/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/material2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/material2/pulls/9639/commits"},"statuses":{"href":"https://api.github.com/repos/angular/material2/statuses/1ee0f93dc97f10b789d2d3d7c0fd6f44599d31ac"}},"author_association":"NONE"}}
{"actor":{"display_login":"mmalerba"}}