{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/pulls/comments/242471953","pull_request_review_id":185987187,"id":242471953,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MjQ3MTk1Mw==","diff_hunk":"@@ -0,0 +1,170 @@\n+# Federation DNS for Ingress and Service\n+This tutorial describes how to set up a federation cluster DNS with [ExternalDNS](https://github.com/kubernetes-incubator/external-dns/) based on [CoreDNS](https://github.com/coredns/coredns) in [minikube](https://github.com/kubernetes/minikube) clusters. You need to:","path":"docs/dns-minikube.md","position":2,"original_position":2,"commit_id":"d275f305a80545e1ffa77f8f6dd042ae90f4f5d9","original_commit_id":"d275f305a80545e1ffa77f8f6dd042ae90f4f5d9","user":{"login":"xunpan","id":42633647,"node_id":"MDQ6VXNlcjQyNjMzNjQ3","avatar_url":"https://avatars3.githubusercontent.com/u/42633647?v=4","gravatar_id":"","url":"https://api.github.com/users/xunpan","html_url":"https://github.com/xunpan","followers_url":"https://api.github.com/users/xunpan/followers","following_url":"https://api.github.com/users/xunpan/following{/other_user}","gists_url":"https://api.github.com/users/xunpan/gists{/gist_id}","starred_url":"https://api.github.com/users/xunpan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xunpan/subscriptions","organizations_url":"https://api.github.com/users/xunpan/orgs","repos_url":"https://api.github.com/users/xunpan/repos","events_url":"https://api.github.com/users/xunpan/events{/privacy}","received_events_url":"https://api.github.com/users/xunpan/received_events","type":"User","site_admin":false},"body":"I use it to replace 'This tutorial' to avoid duplicating with 1st sentence. ","created_at":"2018-12-18T10:00:43Z","updated_at":"2018-12-18T10:00:43Z","html_url":"https://github.com/kubernetes-sigs/federation-v2/pull/519#discussion_r242471953","pull_request_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/pulls/519","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kubernetes-sigs/federation-v2/pulls/comments/242471953"},"html":{"href":"https://github.com/kubernetes-sigs/federation-v2/pull/519#discussion_r242471953"},"pull_request":{"href":"https://api.github.com/repos/kubernetes-sigs/federation-v2/pulls/519"}},"in_reply_to_id":242050691},"pull_request":{"url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/pulls/519","id":239033573,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5MDMzNTcz","html_url":"https://github.com/kubernetes-sigs/federation-v2/pull/519","diff_url":"https://github.com/kubernetes-sigs/federation-v2/pull/519.diff","patch_url":"https://github.com/kubernetes-sigs/federation-v2/pull/519.patch","issue_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/issues/519","number":519,"state":"open","locked":false,"title":"DNS with external-dns based on CoreDNS in minikube","user":{"login":"xunpan","id":42633647,"node_id":"MDQ6VXNlcjQyNjMzNjQ3","avatar_url":"https://avatars3.githubusercontent.com/u/42633647?v=4","gravatar_id":"","url":"https://api.github.com/users/xunpan","html_url":"https://github.com/xunpan","followers_url":"https://api.github.com/users/xunpan/followers","following_url":"https://api.github.com/users/xunpan/following{/other_user}","gists_url":"https://api.github.com/users/xunpan/gists{/gist_id}","starred_url":"https://api.github.com/users/xunpan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xunpan/subscriptions","organizations_url":"https://api.github.com/users/xunpan/orgs","repos_url":"https://api.github.com/users/xunpan/repos","events_url":"https://api.github.com/users/xunpan/events{/privacy}","received_events_url":"https://api.github.com/users/xunpan/received_events","type":"User","site_admin":false},"body":"Fix issue #448\r\n\r\nAdd guide for Ingress and Service DNS in minikube federation cluster\r\n\r\nCurrently, coredns has issues in handling obsolete records.  #464 is logged to trace this issue. However, it does not impact how to set up external-dns in minikube with CoreDNS.","created_at":"2018-12-17T05:50:30Z","updated_at":"2018-12-18T10:00:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"19cd5a282649c85eaa5401b3e4f33bc0a2f08990","assignee":null,"assignees":[],"requested_reviewers":[{"login":"danehans","id":1878195,"node_id":"MDQ6VXNlcjE4NzgxOTU=","avatar_url":"https://avatars3.githubusercontent.com/u/1878195?v=4","gravatar_id":"","url":"https://api.github.com/users/danehans","html_url":"https://github.com/danehans","followers_url":"https://api.github.com/users/danehans/followers","following_url":"https://api.github.com/users/danehans/following{/other_user}","gists_url":"https://api.github.com/users/danehans/gists{/gist_id}","starred_url":"https://api.github.com/users/danehans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danehans/subscriptions","organizations_url":"https://api.github.com/users/danehans/orgs","repos_url":"https://api.github.com/users/danehans/repos","events_url":"https://api.github.com/users/danehans/events{/privacy}","received_events_url":"https://api.github.com/users/danehans/received_events","type":"User","site_admin":false},{"login":"font","id":3596535,"node_id":"MDQ6VXNlcjM1OTY1MzU=","avatar_url":"https://avatars3.githubusercontent.com/u/3596535?v=4","gravatar_id":"","url":"https://api.github.com/users/font","html_url":"https://github.com/font","followers_url":"https://api.github.com/users/font/followers","following_url":"https://api.github.com/users/font/following{/other_user}","gists_url":"https://api.github.com/users/font/gists{/gist_id}","starred_url":"https://api.github.com/users/font/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/font/subscriptions","organizations_url":"https://api.github.com/users/font/orgs","repos_url":"https://api.github.com/users/font/repos","events_url":"https://api.github.com/users/font/events{/privacy}","received_events_url":"https://api.github.com/users/font/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":888036019,"node_id":"MDU6TGFiZWw4ODgwMzYwMTk=","url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":1086814658,"node_id":"MDU6TGFiZWwxMDg2ODE0NjU4","url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/labels/ok-to-test","name":"ok-to-test","color":"15dd18","default":false},{"id":907889168,"node_id":"MDU6TGFiZWw5MDc4ODkxNjg=","url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/labels/size/L","name":"size/L","color":"ee9900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/pulls/519/commits","review_comments_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/pulls/519/comments","review_comment_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/issues/519/comments","statuses_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/statuses/d275f305a80545e1ffa77f8f6dd042ae90f4f5d9","head":{"label":"xunpan:exdns-coredns","ref":"exdns-coredns","sha":"d275f305a80545e1ffa77f8f6dd042ae90f4f5d9","user":{"login":"xunpan","id":42633647,"node_id":"MDQ6VXNlcjQyNjMzNjQ3","avatar_url":"https://avatars3.githubusercontent.com/u/42633647?v=4","gravatar_id":"","url":"https://api.github.com/users/xunpan","html_url":"https://github.com/xunpan","followers_url":"https://api.github.com/users/xunpan/followers","following_url":"https://api.github.com/users/xunpan/following{/other_user}","gists_url":"https://api.github.com/users/xunpan/gists{/gist_id}","starred_url":"https://api.github.com/users/xunpan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xunpan/subscriptions","organizations_url":"https://api.github.com/users/xunpan/orgs","repos_url":"https://api.github.com/users/xunpan/repos","events_url":"https://api.github.com/users/xunpan/events{/privacy}","received_events_url":"https://api.github.com/users/xunpan/received_events","type":"User","site_admin":false},"repo":{"id":159435129,"node_id":"MDEwOlJlcG9zaXRvcnkxNTk0MzUxMjk=","name":"federation-v2","full_name":"xunpan/federation-v2","private":false,"owner":{"login":"xunpan","id":42633647,"node_id":"MDQ6VXNlcjQyNjMzNjQ3","avatar_url":"https://avatars3.githubusercontent.com/u/42633647?v=4","gravatar_id":"","url":"https://api.github.com/users/xunpan","html_url":"https://github.com/xunpan","followers_url":"https://api.github.com/users/xunpan/followers","following_url":"https://api.github.com/users/xunpan/following{/other_user}","gists_url":"https://api.github.com/users/xunpan/gists{/gist_id}","starred_url":"https://api.github.com/users/xunpan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xunpan/subscriptions","organizations_url":"https://api.github.com/users/xunpan/orgs","repos_url":"https://api.github.com/users/xunpan/repos","events_url":"https://api.github.com/users/xunpan/events{/privacy}","received_events_url":"https://api.github.com/users/xunpan/received_events","type":"User","site_admin":false},"html_url":"https://github.com/xunpan/federation-v2","description":"Kubernetes Federation v2 Prototype","fork":true,"url":"https://api.github.com/repos/xunpan/federation-v2","forks_url":"https://api.github.com/repos/xunpan/federation-v2/forks","keys_url":"https://api.github.com/repos/xunpan/federation-v2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xunpan/federation-v2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xunpan/federation-v2/teams","hooks_url":"https://api.github.com/repos/xunpan/federation-v2/hooks","issue_events_url":"https://api.github.com/repos/xunpan/federation-v2/issues/events{/number}","events_url":"https://api.github.com/repos/xunpan/federation-v2/events","assignees_url":"https://api.github.com/repos/xunpan/federation-v2/assignees{/user}","branches_url":"https://api.github.com/repos/xunpan/federation-v2/branches{/branch}","tags_url":"https://api.github.com/repos/xunpan/federation-v2/tags","blobs_url":"https://api.github.com/repos/xunpan/federation-v2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xunpan/federation-v2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xunpan/federation-v2/git/refs{/sha}","trees_url":"https://api.github.com/repos/xunpan/federation-v2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xunpan/federation-v2/statuses/{sha}","languages_url":"https://api.github.com/repos/xunpan/federation-v2/languages","stargazers_url":"https://api.github.com/repos/xunpan/federation-v2/stargazers","contributors_url":"https://api.github.com/repos/xunpan/federation-v2/contributors","subscribers_url":"https://api.github.com/repos/xunpan/federation-v2/subscribers","subscription_url":"https://api.github.com/repos/xunpan/federation-v2/subscription","commits_url":"https://api.github.com/repos/xunpan/federation-v2/commits{/sha}","git_commits_url":"https://api.github.com/repos/xunpan/federation-v2/git/commits{/sha}","comments_url":"https://api.github.com/repos/xunpan/federation-v2/comments{/number}","issue_comment_url":"https://api.github.com/repos/xunpan/federation-v2/issues/comments{/number}","contents_url":"https://api.github.com/repos/xunpan/federation-v2/contents/{+path}","compare_url":"https://api.github.com/repos/xunpan/federation-v2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xunpan/federation-v2/merges","archive_url":"https://api.github.com/repos/xunpan/federation-v2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xunpan/federation-v2/downloads","issues_url":"https://api.github.com/repos/xunpan/federation-v2/issues{/number}","pulls_url":"https://api.github.com/repos/xunpan/federation-v2/pulls{/number}","milestones_url":"https://api.github.com/repos/xunpan/federation-v2/milestones{/number}","notifications_url":"https://api.github.com/repos/xunpan/federation-v2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xunpan/federation-v2/labels{/name}","releases_url":"https://api.github.com/repos/xunpan/federation-v2/releases{/id}","deployments_url":"https://api.github.com/repos/xunpan/federation-v2/deployments","created_at":"2018-11-28T03:01:38Z","updated_at":"2018-11-28T03:01:41Z","pushed_at":"2018-12-18T09:57:10Z","git_url":"git://github.com/xunpan/federation-v2.git","ssh_url":"git@github.com:xunpan/federation-v2.git","clone_url":"https://github.com/xunpan/federation-v2.git","svn_url":"https://github.com/xunpan/federation-v2","homepage":"","size":76592,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes-sigs:master","ref":"master","sha":"eaa74f57d0b2085596234a2206a5cd08c8bac408","user":{"login":"kubernetes-sigs","id":36015203,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MDE1MjAz","avatar_url":"https://avatars1.githubusercontent.com/u/36015203?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes-sigs","html_url":"https://github.com/kubernetes-sigs","followers_url":"https://api.github.com/users/kubernetes-sigs/followers","following_url":"https://api.github.com/users/kubernetes-sigs/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-sigs/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-sigs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-sigs/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-sigs/orgs","repos_url":"https://api.github.com/users/kubernetes-sigs/repos","events_url":"https://api.github.com/users/kubernetes-sigs/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-sigs/received_events","type":"Organization","site_admin":false},"repo":{"id":116825580,"node_id":"MDEwOlJlcG9zaXRvcnkxMTY4MjU1ODA=","name":"federation-v2","full_name":"kubernetes-sigs/federation-v2","private":false,"owner":{"login":"kubernetes-sigs","id":36015203,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MDE1MjAz","avatar_url":"https://avatars1.githubusercontent.com/u/36015203?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes-sigs","html_url":"https://github.com/kubernetes-sigs","followers_url":"https://api.github.com/users/kubernetes-sigs/followers","following_url":"https://api.github.com/users/kubernetes-sigs/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-sigs/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-sigs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-sigs/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-sigs/orgs","repos_url":"https://api.github.com/users/kubernetes-sigs/repos","events_url":"https://api.github.com/users/kubernetes-sigs/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-sigs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kubernetes-sigs/federation-v2","description":"Kubernetes Federation v2 Prototype","fork":false,"url":"https://api.github.com/repos/kubernetes-sigs/federation-v2","forks_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/forks","keys_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/teams","hooks_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/hooks","issue_events_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/events","assignees_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/tags","blobs_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/languages","stargazers_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/stargazers","contributors_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/contributors","subscribers_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/subscribers","subscription_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/subscription","commits_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/merges","archive_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/downloads","issues_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes-sigs/federation-v2/deployments","created_at":"2018-01-09T14:21:03Z","updated_at":"2018-12-18T05:42:56Z","pushed_at":"2018-12-18T09:57:12Z","git_url":"git://github.com/kubernetes-sigs/federation-v2.git","ssh_url":"git@github.com:kubernetes-sigs/federation-v2.git","clone_url":"https://github.com/kubernetes-sigs/federation-v2.git","svn_url":"https://github.com/kubernetes-sigs/federation-v2","homepage":"","size":76614,"stargazers_count":147,"watchers_count":147,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":54,"mirror_url":null,"archived":false,"open_issues_count":83,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":54,"open_issues":83,"watchers":147,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes-sigs/federation-v2/pulls/519"},"html":{"href":"https://github.com/kubernetes-sigs/federation-v2/pull/519"},"issue":{"href":"https://api.github.com/repos/kubernetes-sigs/federation-v2/issues/519"},"comments":{"href":"https://api.github.com/repos/kubernetes-sigs/federation-v2/issues/519/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes-sigs/federation-v2/pulls/519/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes-sigs/federation-v2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes-sigs/federation-v2/pulls/519/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes-sigs/federation-v2/statuses/d275f305a80545e1ffa77f8f6dd042ae90f4f5d9"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"xunpan"}}