{"action":"created","comment":{"url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/pulls/comments/193265757","pull_request_review_id":125784479,"id":193265757,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MzI2NTc1Nw==","diff_hunk":"@@ -660,3 +728,35 @@ func validateArmVirtualNetworkGatewayExpressRouteSku() schema.SchemaValidateFunc\n \t\tstring(network.VirtualNetworkGatewaySkuTierUltraPerformance),\n \t}, true)\n }\n+\n+func resourceArmVirtualNetworkGatewayCustomizeDiff(diff *schema.ResourceDiff, v interface{}) error {\n+\n+\tif vpnClient, ok := diff.GetOk(\"vpn_client_configuration\"); ok {\n+\t\tif vpnClientConfig, ok := vpnClient.([]interface{})[0].(map[string]interface{}); ok {\n+\t\t\tif vpnClientConfig[\"radius_server_address\"] != \"\" {\n+\t\t\t\tif !validIP4(vpnClientConfig[\"radius_server_address\"].(string)) {\n+\t\t\t\t\treturn fmt.Errorf(\"radius_server_address is not an IPv4 address\")\n+\t\t\t\t}\n+\t\t\t\tif vpnClientConfig[\"radius_server_secret\"] == \"\" {","path":"azurerm/resource_arm_virtual_network_gateway.go","position":140,"original_position":140,"commit_id":"eda1b597331ce9bb86d877d2186a6660f3ff7bd5","original_commit_id":"eda1b597331ce9bb86d877d2186a6660f3ff7bd5","user":{"login":"katbyte","id":1638467,"node_id":"MDQ6VXNlcjE2Mzg0Njc=","avatar_url":"https://avatars2.githubusercontent.com/u/1638467?v=4","gravatar_id":"","url":"https://api.github.com/users/katbyte","html_url":"https://github.com/katbyte","followers_url":"https://api.github.com/users/katbyte/followers","following_url":"https://api.github.com/users/katbyte/following{/other_user}","gists_url":"https://api.github.com/users/katbyte/gists{/gist_id}","starred_url":"https://api.github.com/users/katbyte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/katbyte/subscriptions","organizations_url":"https://api.github.com/users/katbyte/orgs","repos_url":"https://api.github.com/users/katbyte/repos","events_url":"https://api.github.com/users/katbyte/events{/privacy}","received_events_url":"https://api.github.com/users/katbyte/received_events","type":"User","site_admin":false},"body":"as above, could be validated by schema & regex","created_at":"2018-06-06T01:02:29Z","updated_at":"2018-06-06T01:10:12Z","html_url":"https://github.com/terraform-providers/terraform-provider-azurerm/pull/946#discussion_r193265757","pull_request_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/pulls/946","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/pulls/comments/193265757"},"html":{"href":"https://github.com/terraform-providers/terraform-provider-azurerm/pull/946#discussion_r193265757"},"pull_request":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/pulls/946"}}},"pull_request":{"url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/pulls/946","id":173366188,"node_id":"MDExOlB1bGxSZXF1ZXN0MTczMzY2MTg4","html_url":"https://github.com/terraform-providers/terraform-provider-azurerm/pull/946","diff_url":"https://github.com/terraform-providers/terraform-provider-azurerm/pull/946.diff","patch_url":"https://github.com/terraform-providers/terraform-provider-azurerm/pull/946.patch","issue_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/issues/946","number":946,"state":"open","locked":false,"title":"Add vpn client protocol support for virtual network gateway","user":{"login":"dcaro","id":6418658,"node_id":"MDQ6VXNlcjY0MTg2NTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6418658?v=4","gravatar_id":"","url":"https://api.github.com/users/dcaro","html_url":"https://github.com/dcaro","followers_url":"https://api.github.com/users/dcaro/followers","following_url":"https://api.github.com/users/dcaro/following{/other_user}","gists_url":"https://api.github.com/users/dcaro/gists{/gist_id}","starred_url":"https://api.github.com/users/dcaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcaro/subscriptions","organizations_url":"https://api.github.com/users/dcaro/orgs","repos_url":"https://api.github.com/users/dcaro/repos","events_url":"https://api.github.com/users/dcaro/events{/privacy}","received_events_url":"https://api.github.com/users/dcaro/received_events","type":"User","site_admin":false},"body":"Added support for vpn client protocol and radius server with the following fields: \r\nvpn_client_protocol\r\nradius_server_address\r\nradius_server_secret\r\n","created_at":"2018-03-07T06:47:55Z","updated_at":"2018-06-06T01:10:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fe5998880d1e06147b4257e3207ccd01ea1582ad","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":620326282,"node_id":"MDU6TGFiZWw2MjAzMjYyODI=","url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/labels/enhancement","name":"enhancement","color":"e6e600","default":true},{"id":817373150,"node_id":"MDU6TGFiZWw4MTczNzMxNTA=","url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/labels/service/virtual-network-gateway","name":"service/virtual-network-gateway","color":"00e673","default":false},{"id":625921437,"node_id":"MDU6TGFiZWw2MjU5MjE0Mzc=","url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/labels/waiting-response","name":"waiting-response","color":"865dee","default":false}],"milestone":{"url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/milestones/17","html_url":"https://github.com/terraform-providers/terraform-provider-azurerm/milestone/17","labels_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/milestones/17/labels","id":3361956,"node_id":"MDk6TWlsZXN0b25lMzM2MTk1Ng==","number":17,"title":"1.7.0","description":"","creator":{"login":"tombuildsstuff","id":666005,"node_id":"MDQ6VXNlcjY2NjAwNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/666005?v=4","gravatar_id":"","url":"https://api.github.com/users/tombuildsstuff","html_url":"https://github.com/tombuildsstuff","followers_url":"https://api.github.com/users/tombuildsstuff/followers","following_url":"https://api.github.com/users/tombuildsstuff/following{/other_user}","gists_url":"https://api.github.com/users/tombuildsstuff/gists{/gist_id}","starred_url":"https://api.github.com/users/tombuildsstuff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tombuildsstuff/subscriptions","organizations_url":"https://api.github.com/users/tombuildsstuff/orgs","repos_url":"https://api.github.com/users/tombuildsstuff/repos","events_url":"https://api.github.com/users/tombuildsstuff/events{/privacy}","received_events_url":"https://api.github.com/users/tombuildsstuff/received_events","type":"User","site_admin":false},"open_issues":16,"closed_issues":11,"state":"open","created_at":"2018-05-21T16:27:45Z","updated_at":"2018-06-05T22:57:54Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/pulls/946/commits","review_comments_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/pulls/946/comments","review_comment_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/issues/946/comments","statuses_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/statuses/eda1b597331ce9bb86d877d2186a6660f3ff7bd5","head":{"label":"dcaro:add-vpn-client-protocol","ref":"add-vpn-client-protocol","sha":"eda1b597331ce9bb86d877d2186a6660f3ff7bd5","user":{"login":"dcaro","id":6418658,"node_id":"MDQ6VXNlcjY0MTg2NTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6418658?v=4","gravatar_id":"","url":"https://api.github.com/users/dcaro","html_url":"https://github.com/dcaro","followers_url":"https://api.github.com/users/dcaro/followers","following_url":"https://api.github.com/users/dcaro/following{/other_user}","gists_url":"https://api.github.com/users/dcaro/gists{/gist_id}","starred_url":"https://api.github.com/users/dcaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcaro/subscriptions","organizations_url":"https://api.github.com/users/dcaro/orgs","repos_url":"https://api.github.com/users/dcaro/repos","events_url":"https://api.github.com/users/dcaro/events{/privacy}","received_events_url":"https://api.github.com/users/dcaro/received_events","type":"User","site_admin":false},"repo":{"id":108594853,"node_id":"MDEwOlJlcG9zaXRvcnkxMDg1OTQ4NTM=","name":"terraform-provider-azurerm","full_name":"dcaro/terraform-provider-azurerm","owner":{"login":"dcaro","id":6418658,"node_id":"MDQ6VXNlcjY0MTg2NTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6418658?v=4","gravatar_id":"","url":"https://api.github.com/users/dcaro","html_url":"https://github.com/dcaro","followers_url":"https://api.github.com/users/dcaro/followers","following_url":"https://api.github.com/users/dcaro/following{/other_user}","gists_url":"https://api.github.com/users/dcaro/gists{/gist_id}","starred_url":"https://api.github.com/users/dcaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcaro/subscriptions","organizations_url":"https://api.github.com/users/dcaro/orgs","repos_url":"https://api.github.com/users/dcaro/repos","events_url":"https://api.github.com/users/dcaro/events{/privacy}","received_events_url":"https://api.github.com/users/dcaro/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dcaro/terraform-provider-azurerm","description":"Terraform azurerm provider","fork":true,"url":"https://api.github.com/repos/dcaro/terraform-provider-azurerm","forks_url":"https://api.github.com/repos/dcaro/terraform-provider-azurerm/forks","keys_url":"https://api.github.com/repos/dcaro/terraform-provider-azurerm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dcaro/terraform-provider-azurerm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dcaro/terraform-provider-azurerm/teams","hooks_url":"https://api.github.com/repos/dcaro/terraform-provider-azurerm/hooks","issue_events_url":"https://api.github.com/repos/dcaro/terraform-provider-azurerm/issues/events{/number}","events_url":"https://api.github.com/repos/dcaro/terraform-provider-azurerm/events","assignees_url":"https://api.github.com/repos/dcaro/terraform-provider-azurerm/assignees{/user}","branches_url":"https://api.github.com/repos/dcaro/terraform-provider-azurerm/branches{/branch}","tags_url":"https://api.github.com/repos/dcaro/terraform-provider-azurerm/tags","blobs_url":"https://api.github.com/repos/dcaro/terraform-provider-azurerm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dcaro/terraform-provider-azurerm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dcaro/terraform-provider-azurerm/git/refs{/sha}","trees_url":"https://api.github.com/repos/dcaro/terraform-provider-azurerm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dcaro/terraform-provider-azurerm/statuses/{sha}","languages_url":"https://api.github.com/repos/dcaro/terraform-provider-azurerm/languages","stargazers_url":"https://api.github.com/repos/dcaro/terraform-provider-azurerm/stargazers","contributors_url":"https://api.github.com/repos/dcaro/terraform-provider-azurerm/contributors","subscribers_url":"https://api.github.com/repos/dcaro/terraform-provider-azurerm/subscribers","subscription_url":"https://api.github.com/repos/dcaro/terraform-provider-azurerm/subscription","commits_url":"https://api.github.com/repos/dcaro/terraform-provider-azurerm/commits{/sha}","git_commits_url":"https://api.github.com/repos/dcaro/terraform-provider-azurerm/git/commits{/sha}","comments_url":"https://api.github.com/repos/dcaro/terraform-provider-azurerm/comments{/number}","issue_comment_url":"https://api.github.com/repos/dcaro/terraform-provider-azurerm/issues/comments{/number}","contents_url":"https://api.github.com/repos/dcaro/terraform-provider-azurerm/contents/{+path}","compare_url":"https://api.github.com/repos/dcaro/terraform-provider-azurerm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dcaro/terraform-provider-azurerm/merges","archive_url":"https://api.github.com/repos/dcaro/terraform-provider-azurerm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dcaro/terraform-provider-azurerm/downloads","issues_url":"https://api.github.com/repos/dcaro/terraform-provider-azurerm/issues{/number}","pulls_url":"https://api.github.com/repos/dcaro/terraform-provider-azurerm/pulls{/number}","milestones_url":"https://api.github.com/repos/dcaro/terraform-provider-azurerm/milestones{/number}","notifications_url":"https://api.github.com/repos/dcaro/terraform-provider-azurerm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dcaro/terraform-provider-azurerm/labels{/name}","releases_url":"https://api.github.com/repos/dcaro/terraform-provider-azurerm/releases{/id}","deployments_url":"https://api.github.com/repos/dcaro/terraform-provider-azurerm/deployments","created_at":"2017-10-27T20:55:26Z","updated_at":"2018-05-08T06:15:31Z","pushed_at":"2018-06-04T22:21:56Z","git_url":"git://github.com/dcaro/terraform-provider-azurerm.git","ssh_url":"git@github.com:dcaro/terraform-provider-azurerm.git","clone_url":"https://github.com/dcaro/terraform-provider-azurerm.git","svn_url":"https://github.com/dcaro/terraform-provider-azurerm","homepage":"","size":16216,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"terraform-providers:master","ref":"master","sha":"a4001cf5c804f1fa579bac50d2cd8fbfda2a94f5","user":{"login":"terraform-providers","id":29154831,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5MTU0ODMx","avatar_url":"https://avatars0.githubusercontent.com/u/29154831?v=4","gravatar_id":"","url":"https://api.github.com/users/terraform-providers","html_url":"https://github.com/terraform-providers","followers_url":"https://api.github.com/users/terraform-providers/followers","following_url":"https://api.github.com/users/terraform-providers/following{/other_user}","gists_url":"https://api.github.com/users/terraform-providers/gists{/gist_id}","starred_url":"https://api.github.com/users/terraform-providers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terraform-providers/subscriptions","organizations_url":"https://api.github.com/users/terraform-providers/orgs","repos_url":"https://api.github.com/users/terraform-providers/repos","events_url":"https://api.github.com/users/terraform-providers/events{/privacy}","received_events_url":"https://api.github.com/users/terraform-providers/received_events","type":"Organization","site_admin":false},"repo":{"id":93446042,"node_id":"MDEwOlJlcG9zaXRvcnk5MzQ0NjA0Mg==","name":"terraform-provider-azurerm","full_name":"terraform-providers/terraform-provider-azurerm","owner":{"login":"terraform-providers","id":29154831,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5MTU0ODMx","avatar_url":"https://avatars0.githubusercontent.com/u/29154831?v=4","gravatar_id":"","url":"https://api.github.com/users/terraform-providers","html_url":"https://github.com/terraform-providers","followers_url":"https://api.github.com/users/terraform-providers/followers","following_url":"https://api.github.com/users/terraform-providers/following{/other_user}","gists_url":"https://api.github.com/users/terraform-providers/gists{/gist_id}","starred_url":"https://api.github.com/users/terraform-providers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terraform-providers/subscriptions","organizations_url":"https://api.github.com/users/terraform-providers/orgs","repos_url":"https://api.github.com/users/terraform-providers/repos","events_url":"https://api.github.com/users/terraform-providers/events{/privacy}","received_events_url":"https://api.github.com/users/terraform-providers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/terraform-providers/terraform-provider-azurerm","description":"Terraform Azure Resource Manager provider","fork":false,"url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm","forks_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/forks","keys_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/teams","hooks_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/hooks","issue_events_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/issues/events{/number}","events_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/events","assignees_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/assignees{/user}","branches_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/branches{/branch}","tags_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/tags","blobs_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/git/refs{/sha}","trees_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/statuses/{sha}","languages_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/languages","stargazers_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/stargazers","contributors_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/contributors","subscribers_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/subscribers","subscription_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/subscription","commits_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/commits{/sha}","git_commits_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/git/commits{/sha}","comments_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/comments{/number}","issue_comment_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/issues/comments{/number}","contents_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/contents/{+path}","compare_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/merges","archive_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/downloads","issues_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/issues{/number}","pulls_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/pulls{/number}","milestones_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/milestones{/number}","notifications_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/labels{/name}","releases_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/releases{/id}","deployments_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/deployments","created_at":"2017-06-05T20:53:54Z","updated_at":"2018-06-06T00:44:10Z","pushed_at":"2018-06-06T00:26:43Z","git_url":"git://github.com/terraform-providers/terraform-provider-azurerm.git","ssh_url":"git@github.com:terraform-providers/terraform-provider-azurerm.git","clone_url":"https://github.com/terraform-providers/terraform-provider-azurerm.git","svn_url":"https://github.com/terraform-providers/terraform-provider-azurerm","homepage":"https://www.terraform.io/docs/providers/azurerm/","size":16894,"stargazers_count":343,"watchers_count":343,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":295,"mirror_url":null,"archived":false,"open_issues_count":244,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":295,"open_issues":244,"watchers":343,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/pulls/946"},"html":{"href":"https://github.com/terraform-providers/terraform-provider-azurerm/pull/946"},"issue":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/issues/946"},"comments":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/issues/946/comments"},"review_comments":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/pulls/946/comments"},"review_comment":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/pulls/946/commits"},"statuses":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/statuses/eda1b597331ce9bb86d877d2186a6660f3ff7bd5"}},"author_association":"NONE"}}
{"actor":{"display_login":"katbyte"}}