{"action":"closed","number":790,"pull_request":{"url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/pulls/790","id":191189513,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxMTg5NTEz","html_url":"https://github.com/webpack-contrib/extract-text-webpack-plugin/pull/790","diff_url":"https://github.com/webpack-contrib/extract-text-webpack-plugin/pull/790.diff","patch_url":"https://github.com/webpack-contrib/extract-text-webpack-plugin/pull/790.patch","issue_url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/issues/790","number":790,"state":"closed","locked":false,"title":"fix(package): remove `webpack =< v3.0.0` (`peerDependencies`)","user":{"login":"aliai","id":5068004,"node_id":"MDQ6VXNlcjUwNjgwMDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5068004?v=4","gravatar_id":"","url":"https://api.github.com/users/aliai","html_url":"https://github.com/aliai","followers_url":"https://api.github.com/users/aliai/followers","following_url":"https://api.github.com/users/aliai/following{/other_user}","gists_url":"https://api.github.com/users/aliai/gists{/gist_id}","starred_url":"https://api.github.com/users/aliai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aliai/subscriptions","organizations_url":"https://api.github.com/users/aliai/orgs","repos_url":"https://api.github.com/users/aliai/repos","events_url":"https://api.github.com/users/aliai/events{/privacy}","received_events_url":"https://api.github.com/users/aliai/received_events","type":"User","site_admin":false},"body":"We should remove webpack@3.0.0 as a \"peerDependencies\" to this version of extract-text-webpack-plugin.\r\n\r\n### problem\r\n\r\nextract-text-webpack@next (4.0.0-beta.0) is not compatible with webpack 3.x. I am assuming this is the direction you are going with this plugin (correct me if I am wrong). For example, this is the incompatibility line I faced that is problematic if `webpack@3.x` is used:\r\n\r\nhttps://github.com/webpack-contrib/extract-text-webpack-plugin/blob/34e508342df9c4fb3fb2a3ddef4700c5a58f9fb0/src/index.js#L222\r\n\r\n### why we need this change\r\nLet's assume you have an application that uses `webpack@3.x` and a packages `A` that uses `webpack@4.x` and `extract-text-webpack@next`. When installing the dependencies, `extract-text-webpack` gets installed in the root `node_modules` not `node_modules/A/node_modules`. This obviously forces `extract-text-webpack` to load `webpack@3.x` from the root and breaks the build in package `A` :(\r\n\r\nI can provide an example application to demonstrate that behaviour, though it is cumbersome to prove this point, especially if there is no plan to support `webpack@3.x` in `extract-text-webpack@next`.\r\n\r\n<!--\r\n1. [Read and sign the CLA](https://cla.js.foundation/webpack/webpack.js.org). This needs to be done only once. PRs that haven't signed it won't be accepted.\r\n2. Check out the [development guide](https://webpack.js.org/development/) for the API and development guidelines.\r\n3. Read through the PR diff carefully as sometimes this can reveal issues. The work will be reviewed, but this can save some effort.\r\n-->\r\n","created_at":"2018-05-29T15:41:27Z","updated_at":"2018-10-18T22:18:28Z","closed_at":"2018-10-18T22:18:28Z","merged_at":"2018-10-18T22:18:28Z","merge_commit_sha":"88c4b6d38dbdd91c1bb4ea8dc56eddf6a3ed6c03","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":584691288,"node_id":"MDU6TGFiZWw1ODQ2OTEyODg=","url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/labels/semver:%20Patch","name":"semver: Patch","color":"006b75","default":false},{"id":595392862,"node_id":"MDU6TGFiZWw1OTUzOTI4NjI=","url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/labels/status:%20Approved","name":"status: Approved","color":"0e8a16","default":false},{"id":77325622,"node_id":"MDU6TGFiZWw3NzMyNTYyMg==","url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/labels/type:%20Bug","name":"type: Bug","color":"FC4349","default":false}],"milestone":{"url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/milestones/3","html_url":"https://github.com/webpack-contrib/extract-text-webpack-plugin/milestone/3","labels_url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/milestones/3/labels","id":2474115,"node_id":"MDk6TWlsZXN0b25lMjQ3NDExNQ==","number":3,"title":"4.0.0","description":"Breaking Release (:label: Major)","creator":{"login":"michael-ciniawsky","id":5419992,"node_id":"MDQ6VXNlcjU0MTk5OTI=","avatar_url":"https://avatars0.githubusercontent.com/u/5419992?v=4","gravatar_id":"","url":"https://api.github.com/users/michael-ciniawsky","html_url":"https://github.com/michael-ciniawsky","followers_url":"https://api.github.com/users/michael-ciniawsky/followers","following_url":"https://api.github.com/users/michael-ciniawsky/following{/other_user}","gists_url":"https://api.github.com/users/michael-ciniawsky/gists{/gist_id}","starred_url":"https://api.github.com/users/michael-ciniawsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michael-ciniawsky/subscriptions","organizations_url":"https://api.github.com/users/michael-ciniawsky/orgs","repos_url":"https://api.github.com/users/michael-ciniawsky/repos","events_url":"https://api.github.com/users/michael-ciniawsky/events{/privacy}","received_events_url":"https://api.github.com/users/michael-ciniawsky/received_events","type":"User","site_admin":false},"open_issues":0,"closed_issues":9,"state":"open","created_at":"2017-04-22T19:41:55Z","updated_at":"2018-10-18T22:18:28Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/pulls/790/commits","review_comments_url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/pulls/790/comments","review_comment_url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/issues/790/comments","statuses_url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/statuses/4afaab1b436666470abe4364a2776bbd19e6e61f","head":{"label":"aliai:patch-1","ref":"patch-1","sha":"4afaab1b436666470abe4364a2776bbd19e6e61f","user":{"login":"aliai","id":5068004,"node_id":"MDQ6VXNlcjUwNjgwMDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5068004?v=4","gravatar_id":"","url":"https://api.github.com/users/aliai","html_url":"https://github.com/aliai","followers_url":"https://api.github.com/users/aliai/followers","following_url":"https://api.github.com/users/aliai/following{/other_user}","gists_url":"https://api.github.com/users/aliai/gists{/gist_id}","starred_url":"https://api.github.com/users/aliai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aliai/subscriptions","organizations_url":"https://api.github.com/users/aliai/orgs","repos_url":"https://api.github.com/users/aliai/repos","events_url":"https://api.github.com/users/aliai/events{/privacy}","received_events_url":"https://api.github.com/users/aliai/received_events","type":"User","site_admin":false},"repo":{"id":135315576,"node_id":"MDEwOlJlcG9zaXRvcnkxMzUzMTU1NzY=","name":"extract-text-webpack-plugin","full_name":"aliai/extract-text-webpack-plugin","private":false,"owner":{"login":"aliai","id":5068004,"node_id":"MDQ6VXNlcjUwNjgwMDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5068004?v=4","gravatar_id":"","url":"https://api.github.com/users/aliai","html_url":"https://github.com/aliai","followers_url":"https://api.github.com/users/aliai/followers","following_url":"https://api.github.com/users/aliai/following{/other_user}","gists_url":"https://api.github.com/users/aliai/gists{/gist_id}","starred_url":"https://api.github.com/users/aliai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aliai/subscriptions","organizations_url":"https://api.github.com/users/aliai/orgs","repos_url":"https://api.github.com/users/aliai/repos","events_url":"https://api.github.com/users/aliai/events{/privacy}","received_events_url":"https://api.github.com/users/aliai/received_events","type":"User","site_admin":false},"html_url":"https://github.com/aliai/extract-text-webpack-plugin","description":"Extracts text from bundle into a file","fork":true,"url":"https://api.github.com/repos/aliai/extract-text-webpack-plugin","forks_url":"https://api.github.com/repos/aliai/extract-text-webpack-plugin/forks","keys_url":"https://api.github.com/repos/aliai/extract-text-webpack-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aliai/extract-text-webpack-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aliai/extract-text-webpack-plugin/teams","hooks_url":"https://api.github.com/repos/aliai/extract-text-webpack-plugin/hooks","issue_events_url":"https://api.github.com/repos/aliai/extract-text-webpack-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/aliai/extract-text-webpack-plugin/events","assignees_url":"https://api.github.com/repos/aliai/extract-text-webpack-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/aliai/extract-text-webpack-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/aliai/extract-text-webpack-plugin/tags","blobs_url":"https://api.github.com/repos/aliai/extract-text-webpack-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aliai/extract-text-webpack-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aliai/extract-text-webpack-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/aliai/extract-text-webpack-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aliai/extract-text-webpack-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/aliai/extract-text-webpack-plugin/languages","stargazers_url":"https://api.github.com/repos/aliai/extract-text-webpack-plugin/stargazers","contributors_url":"https://api.github.com/repos/aliai/extract-text-webpack-plugin/contributors","subscribers_url":"https://api.github.com/repos/aliai/extract-text-webpack-plugin/subscribers","subscription_url":"https://api.github.com/repos/aliai/extract-text-webpack-plugin/subscription","commits_url":"https://api.github.com/repos/aliai/extract-text-webpack-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/aliai/extract-text-webpack-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/aliai/extract-text-webpack-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/aliai/extract-text-webpack-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/aliai/extract-text-webpack-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/aliai/extract-text-webpack-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aliai/extract-text-webpack-plugin/merges","archive_url":"https://api.github.com/repos/aliai/extract-text-webpack-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aliai/extract-text-webpack-plugin/downloads","issues_url":"https://api.github.com/repos/aliai/extract-text-webpack-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/aliai/extract-text-webpack-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/aliai/extract-text-webpack-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/aliai/extract-text-webpack-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aliai/extract-text-webpack-plugin/labels{/name}","releases_url":"https://api.github.com/repos/aliai/extract-text-webpack-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/aliai/extract-text-webpack-plugin/deployments","created_at":"2018-05-29T15:21:47Z","updated_at":"2018-05-29T15:21:49Z","pushed_at":"2018-05-29T15:40:47Z","git_url":"git://github.com/aliai/extract-text-webpack-plugin.git","ssh_url":"git@github.com:aliai/extract-text-webpack-plugin.git","clone_url":"https://github.com/aliai/extract-text-webpack-plugin.git","svn_url":"https://github.com/aliai/extract-text-webpack-plugin","homepage":"https://www.npmjs.com/package/extract-text-webpack-plugin","size":752,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"webpack-contrib:next","ref":"next","sha":"34e508342df9c4fb3fb2a3ddef4700c5a58f9fb0","user":{"login":"webpack-contrib","id":25012217,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MDEyMjE3","avatar_url":"https://avatars3.githubusercontent.com/u/25012217?v=4","gravatar_id":"","url":"https://api.github.com/users/webpack-contrib","html_url":"https://github.com/webpack-contrib","followers_url":"https://api.github.com/users/webpack-contrib/followers","following_url":"https://api.github.com/users/webpack-contrib/following{/other_user}","gists_url":"https://api.github.com/users/webpack-contrib/gists{/gist_id}","starred_url":"https://api.github.com/users/webpack-contrib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webpack-contrib/subscriptions","organizations_url":"https://api.github.com/users/webpack-contrib/orgs","repos_url":"https://api.github.com/users/webpack-contrib/repos","events_url":"https://api.github.com/users/webpack-contrib/events{/privacy}","received_events_url":"https://api.github.com/users/webpack-contrib/received_events","type":"Organization","site_admin":false},"repo":{"id":16297741,"node_id":"MDEwOlJlcG9zaXRvcnkxNjI5Nzc0MQ==","name":"extract-text-webpack-plugin","full_name":"webpack-contrib/extract-text-webpack-plugin","private":false,"owner":{"login":"webpack-contrib","id":25012217,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MDEyMjE3","avatar_url":"https://avatars3.githubusercontent.com/u/25012217?v=4","gravatar_id":"","url":"https://api.github.com/users/webpack-contrib","html_url":"https://github.com/webpack-contrib","followers_url":"https://api.github.com/users/webpack-contrib/followers","following_url":"https://api.github.com/users/webpack-contrib/following{/other_user}","gists_url":"https://api.github.com/users/webpack-contrib/gists{/gist_id}","starred_url":"https://api.github.com/users/webpack-contrib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webpack-contrib/subscriptions","organizations_url":"https://api.github.com/users/webpack-contrib/orgs","repos_url":"https://api.github.com/users/webpack-contrib/repos","events_url":"https://api.github.com/users/webpack-contrib/events{/privacy}","received_events_url":"https://api.github.com/users/webpack-contrib/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/webpack-contrib/extract-text-webpack-plugin","description":"Extracts text from bundle into a file","fork":false,"url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin","forks_url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/forks","keys_url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/teams","hooks_url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/hooks","issue_events_url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/events","assignees_url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/tags","blobs_url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/languages","stargazers_url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/stargazers","contributors_url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/contributors","subscribers_url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/subscribers","subscription_url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/subscription","commits_url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/merges","archive_url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/downloads","issues_url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/labels{/name}","releases_url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/deployments","created_at":"2014-01-28T00:28:36Z","updated_at":"2018-10-18T18:57:20Z","pushed_at":"2018-10-18T22:18:28Z","git_url":"git://github.com/webpack-contrib/extract-text-webpack-plugin.git","ssh_url":"git@github.com:webpack-contrib/extract-text-webpack-plugin.git","clone_url":"https://github.com/webpack-contrib/extract-text-webpack-plugin.git","svn_url":"https://github.com/webpack-contrib/extract-text-webpack-plugin","homepage":"https://www.npmjs.com/package/extract-text-webpack-plugin","size":749,"stargazers_count":3790,"watchers_count":3790,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":516,"mirror_url":null,"archived":false,"open_issues_count":57,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":516,"open_issues":57,"watchers":3790,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/pulls/790"},"html":{"href":"https://github.com/webpack-contrib/extract-text-webpack-plugin/pull/790"},"issue":{"href":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/issues/790"},"comments":{"href":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/issues/790/comments"},"review_comments":{"href":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/pulls/790/comments"},"review_comment":{"href":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/pulls/790/commits"},"statuses":{"href":"https://api.github.com/repos/webpack-contrib/extract-text-webpack-plugin/statuses/4afaab1b436666470abe4364a2776bbd19e6e61f"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"michael-ciniawsky","id":5419992,"node_id":"MDQ6VXNlcjU0MTk5OTI=","avatar_url":"https://avatars0.githubusercontent.com/u/5419992?v=4","gravatar_id":"","url":"https://api.github.com/users/michael-ciniawsky","html_url":"https://github.com/michael-ciniawsky","followers_url":"https://api.github.com/users/michael-ciniawsky/followers","following_url":"https://api.github.com/users/michael-ciniawsky/following{/other_user}","gists_url":"https://api.github.com/users/michael-ciniawsky/gists{/gist_id}","starred_url":"https://api.github.com/users/michael-ciniawsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michael-ciniawsky/subscriptions","organizations_url":"https://api.github.com/users/michael-ciniawsky/orgs","repos_url":"https://api.github.com/users/michael-ciniawsky/repos","events_url":"https://api.github.com/users/michael-ciniawsky/events{/privacy}","received_events_url":"https://api.github.com/users/michael-ciniawsky/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"michael-ciniawsky"}}