{"action":"opened","issue":{"url":"https://api.github.com/repos/jasaunders/SecretRecipeCookbook/issues/2","repository_url":"https://api.github.com/repos/jasaunders/SecretRecipeCookbook","labels_url":"https://api.github.com/repos/jasaunders/SecretRecipeCookbook/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/jasaunders/SecretRecipeCookbook/issues/2/comments","events_url":"https://api.github.com/repos/jasaunders/SecretRecipeCookbook/issues/2/events","html_url":"https://github.com/jasaunders/SecretRecipeCookbook/issues/2","id":299476290,"number":2,"title":"Project review of Joanne by Dennis","user":{"login":"dennisfhelt","id":31455409,"avatar_url":"https://avatars3.githubusercontent.com/u/31455409?v=4","gravatar_id":"","url":"https://api.github.com/users/dennisfhelt","html_url":"https://github.com/dennisfhelt","followers_url":"https://api.github.com/users/dennisfhelt/followers","following_url":"https://api.github.com/users/dennisfhelt/following{/other_user}","gists_url":"https://api.github.com/users/dennisfhelt/gists{/gist_id}","starred_url":"https://api.github.com/users/dennisfhelt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dennisfhelt/subscriptions","organizations_url":"https://api.github.com/users/dennisfhelt/orgs","repos_url":"https://api.github.com/users/dennisfhelt/repos","events_url":"https://api.github.com/users/dennisfhelt/events{/privacy}","received_events_url":"https://api.github.com/users/dennisfhelt/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-02-22T19:23:30Z","updated_at":"2018-02-22T19:23:30Z","closed_at":null,"author_association":"NONE","body":"# Design/Code Review 1\r\n\r\n## Project:\r\n\r\n### Developer:\r\n\r\n### Reviewer:\r\n\r\n|Item |Considerations| Comments/Suggestions|\r\n|--------|---------|---|\r\n|||Reviewer comments and suggestions go here. Each item should have *at least* one \"kudos\" and two suggestions for improvement|\r\n|**Problem Statement**|1. Accurately describes project purpose<br> 2. Is professional and free of typos, slang, etc.<br> 3. Fully explains the problem and the solution<br> 4. Is understandable by the average person|Joanne described a recipe website where individuals could sign-up and share the recipes that they were willing to share, and keep recipes on file for themselves. She also expected to implement metric measurement conversion. |\r\n|**Design Documentation**|1. Navigation/flow through the application is logical and easy to use. <br>2. The order in which values are displayed are logical and easy to understand/use <br>3. The order in which the form fields entered are logical and easy to understand/use<br>4. All data discussed/documented (problem statement, flow, db design, etc.) is represented on the screens |Joanne created a home screen and many screens to which she could link all on a menu bar, including Sign_Up, Sign-In, Edit Recipe, etc. Navigation was easy for me. |\r\n|**Data model/Database**|1. Everything on the screens and problem statement/flow is represented in the model <br> 2. There is at least one 1-to-many relationship.<br> 3. The model represents good database design <br>|There was the required 1-to-many relationship. Database design still needs to be done. |\r\n|**Code**|1. Proper Maven project structure is used<br> 2. a .gitignore file for IntelliJ Java projects has been implemented <br> 3. There is not any redundant or copy/paste code in the JSPs or classes<br> 4. Classes are appropriately-sized (no monster classes)<br> Property files are used appropriately: no hard-coded values <br> 5. Logging statements are used rather than System.out.println and printStackTrace.<br> 6. There are appropriate unit tests/code coverages. | .gitignore file is there. Logging statements there. |  \r\n  "}}
{"actor":{"display_login":"dennisfhelt"}}