{"action":"created","comment":{"url":"https://api.github.com/repos/quasar-analytics/quasar/pulls/comments/180847403","pull_request_review_id":111342339,"id":180847403,"diff_hunk":"@@ -52,6 +52,11 @@ package object scalaz {\n       OptionT(self.run.run.map(_.join))\n   }\n \n+  implicit final class Nested3FunctorsOps[F[_], G[_], H[_], A](val self: F[G[H[A]]]) extends AnyVal {","path":"foundation/src/main/scala/quasar/contrib/scalaz/package.scala","position":4,"original_position":4,"commit_id":"54e532bc6773d7be0ddf054dd0625c2b760e563c","original_commit_id":"54e532bc6773d7be0ddf054dd0625c2b760e563c","user":{"login":"jedesah","id":1780116,"avatar_url":"https://avatars3.githubusercontent.com/u/1780116?v=4","gravatar_id":"","url":"https://api.github.com/users/jedesah","html_url":"https://github.com/jedesah","followers_url":"https://api.github.com/users/jedesah/followers","following_url":"https://api.github.com/users/jedesah/following{/other_user}","gists_url":"https://api.github.com/users/jedesah/gists{/gist_id}","starred_url":"https://api.github.com/users/jedesah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jedesah/subscriptions","organizations_url":"https://api.github.com/users/jedesah/orgs","repos_url":"https://api.github.com/users/jedesah/repos","events_url":"https://api.github.com/users/jedesah/events{/privacy}","received_events_url":"https://api.github.com/users/jedesah/received_events","type":"User","site_admin":false},"body":"Good point. Although, I still think this is useful in terms of making the usage site concise and thus more readable","created_at":"2018-04-11T18:07:29Z","updated_at":"2018-04-11T18:07:29Z","html_url":"https://github.com/quasar-analytics/quasar/pull/3536#discussion_r180847403","pull_request_url":"https://api.github.com/repos/quasar-analytics/quasar/pulls/3536","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/quasar-analytics/quasar/pulls/comments/180847403"},"html":{"href":"https://github.com/quasar-analytics/quasar/pull/3536#discussion_r180847403"},"pull_request":{"href":"https://api.github.com/repos/quasar-analytics/quasar/pulls/3536"}},"in_reply_to_id":180814295},"pull_request":{"url":"https://api.github.com/repos/quasar-analytics/quasar/pulls/3536","id":178762689,"html_url":"https://github.com/quasar-analytics/quasar/pull/3536","diff_url":"https://github.com/quasar-analytics/quasar/pull/3536.diff","patch_url":"https://github.com/quasar-analytics/quasar/pull/3536.patch","issue_url":"https://api.github.com/repos/quasar-analytics/quasar/issues/3536","number":3536,"state":"open","locked":false,"title":"Fix discrepancy between view and inline query","user":{"login":"jedesah","id":1780116,"avatar_url":"https://avatars3.githubusercontent.com/u/1780116?v=4","gravatar_id":"","url":"https://api.github.com/users/jedesah","html_url":"https://github.com/jedesah","followers_url":"https://api.github.com/users/jedesah/followers","following_url":"https://api.github.com/users/jedesah/following{/other_user}","gists_url":"https://api.github.com/users/jedesah/gists{/gist_id}","starred_url":"https://api.github.com/users/jedesah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jedesah/subscriptions","organizations_url":"https://api.github.com/users/jedesah/orgs","repos_url":"https://api.github.com/users/jedesah/repos","events_url":"https://api.github.com/users/jedesah/events{/privacy}","received_events_url":"https://api.github.com/users/jedesah/received_events","type":"User","site_admin":false},"body":"This is sort of a double negative makes one positive where the removal of typechecks in the \"inline\" query when resolving views (ironically the inline query has no views) masks the bug in the compiler by removing a non-sensical typecheck.\r\n\r\nSo although going through the view produces the wrong result, that's because there is only one bug in play as opposed to two canceling each other out.\r\n\r\nAdding a simplifier for the equal operation fixes the problem of the erroneous typecheck though I'm not sure it's the proper fix. Looking for feedback on that as well as my question in the comment regarding why we remove typechecks when resolving views in the first place.\r\n\r\n#qz-3656 Done","created_at":"2018-04-02T02:39:44Z","updated_at":"2018-04-11T18:07:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7bf0f4b2969bb47dbc50dd8db09bdcbb9f792bf2","assignee":{"login":"wemrysi","id":32185,"avatar_url":"https://avatars3.githubusercontent.com/u/32185?v=4","gravatar_id":"","url":"https://api.github.com/users/wemrysi","html_url":"https://github.com/wemrysi","followers_url":"https://api.github.com/users/wemrysi/followers","following_url":"https://api.github.com/users/wemrysi/following{/other_user}","gists_url":"https://api.github.com/users/wemrysi/gists{/gist_id}","starred_url":"https://api.github.com/users/wemrysi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wemrysi/subscriptions","organizations_url":"https://api.github.com/users/wemrysi/orgs","repos_url":"https://api.github.com/users/wemrysi/repos","events_url":"https://api.github.com/users/wemrysi/events{/privacy}","received_events_url":"https://api.github.com/users/wemrysi/received_events","type":"User","site_admin":false},"assignees":[{"login":"wemrysi","id":32185,"avatar_url":"https://avatars3.githubusercontent.com/u/32185?v=4","gravatar_id":"","url":"https://api.github.com/users/wemrysi","html_url":"https://github.com/wemrysi","followers_url":"https://api.github.com/users/wemrysi/followers","following_url":"https://api.github.com/users/wemrysi/following{/other_user}","gists_url":"https://api.github.com/users/wemrysi/gists{/gist_id}","starred_url":"https://api.github.com/users/wemrysi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wemrysi/subscriptions","organizations_url":"https://api.github.com/users/wemrysi/orgs","repos_url":"https://api.github.com/users/wemrysi/repos","events_url":"https://api.github.com/users/wemrysi/events{/privacy}","received_events_url":"https://api.github.com/users/wemrysi/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":513635755,"url":"https://api.github.com/repos/quasar-analytics/quasar/labels/version:%20revision","name":"version: revision","color":"c5def5","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/quasar-analytics/quasar/pulls/3536/commits","review_comments_url":"https://api.github.com/repos/quasar-analytics/quasar/pulls/3536/comments","review_comment_url":"https://api.github.com/repos/quasar-analytics/quasar/pulls/comments{/number}","comments_url":"https://api.github.com/repos/quasar-analytics/quasar/issues/3536/comments","statuses_url":"https://api.github.com/repos/quasar-analytics/quasar/statuses/54e532bc6773d7be0ddf054dd0625c2b760e563c","head":{"label":"jedesah:topic/qz-3656","ref":"topic/qz-3656","sha":"54e532bc6773d7be0ddf054dd0625c2b760e563c","user":{"login":"jedesah","id":1780116,"avatar_url":"https://avatars3.githubusercontent.com/u/1780116?v=4","gravatar_id":"","url":"https://api.github.com/users/jedesah","html_url":"https://github.com/jedesah","followers_url":"https://api.github.com/users/jedesah/followers","following_url":"https://api.github.com/users/jedesah/following{/other_user}","gists_url":"https://api.github.com/users/jedesah/gists{/gist_id}","starred_url":"https://api.github.com/users/jedesah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jedesah/subscriptions","organizations_url":"https://api.github.com/users/jedesah/orgs","repos_url":"https://api.github.com/users/jedesah/repos","events_url":"https://api.github.com/users/jedesah/events{/privacy}","received_events_url":"https://api.github.com/users/jedesah/received_events","type":"User","site_admin":false},"repo":{"id":39122146,"name":"Quasar","full_name":"jedesah/Quasar","owner":{"login":"jedesah","id":1780116,"avatar_url":"https://avatars3.githubusercontent.com/u/1780116?v=4","gravatar_id":"","url":"https://api.github.com/users/jedesah","html_url":"https://github.com/jedesah","followers_url":"https://api.github.com/users/jedesah/followers","following_url":"https://api.github.com/users/jedesah/following{/other_user}","gists_url":"https://api.github.com/users/jedesah/gists{/gist_id}","starred_url":"https://api.github.com/users/jedesah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jedesah/subscriptions","organizations_url":"https://api.github.com/users/jedesah/orgs","repos_url":"https://api.github.com/users/jedesah/repos","events_url":"https://api.github.com/users/jedesah/events{/privacy}","received_events_url":"https://api.github.com/users/jedesah/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jedesah/Quasar","description":"The engine for SlamData","fork":true,"url":"https://api.github.com/repos/jedesah/Quasar","forks_url":"https://api.github.com/repos/jedesah/Quasar/forks","keys_url":"https://api.github.com/repos/jedesah/Quasar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jedesah/Quasar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jedesah/Quasar/teams","hooks_url":"https://api.github.com/repos/jedesah/Quasar/hooks","issue_events_url":"https://api.github.com/repos/jedesah/Quasar/issues/events{/number}","events_url":"https://api.github.com/repos/jedesah/Quasar/events","assignees_url":"https://api.github.com/repos/jedesah/Quasar/assignees{/user}","branches_url":"https://api.github.com/repos/jedesah/Quasar/branches{/branch}","tags_url":"https://api.github.com/repos/jedesah/Quasar/tags","blobs_url":"https://api.github.com/repos/jedesah/Quasar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jedesah/Quasar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jedesah/Quasar/git/refs{/sha}","trees_url":"https://api.github.com/repos/jedesah/Quasar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jedesah/Quasar/statuses/{sha}","languages_url":"https://api.github.com/repos/jedesah/Quasar/languages","stargazers_url":"https://api.github.com/repos/jedesah/Quasar/stargazers","contributors_url":"https://api.github.com/repos/jedesah/Quasar/contributors","subscribers_url":"https://api.github.com/repos/jedesah/Quasar/subscribers","subscription_url":"https://api.github.com/repos/jedesah/Quasar/subscription","commits_url":"https://api.github.com/repos/jedesah/Quasar/commits{/sha}","git_commits_url":"https://api.github.com/repos/jedesah/Quasar/git/commits{/sha}","comments_url":"https://api.github.com/repos/jedesah/Quasar/comments{/number}","issue_comment_url":"https://api.github.com/repos/jedesah/Quasar/issues/comments{/number}","contents_url":"https://api.github.com/repos/jedesah/Quasar/contents/{+path}","compare_url":"https://api.github.com/repos/jedesah/Quasar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jedesah/Quasar/merges","archive_url":"https://api.github.com/repos/jedesah/Quasar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jedesah/Quasar/downloads","issues_url":"https://api.github.com/repos/jedesah/Quasar/issues{/number}","pulls_url":"https://api.github.com/repos/jedesah/Quasar/pulls{/number}","milestones_url":"https://api.github.com/repos/jedesah/Quasar/milestones{/number}","notifications_url":"https://api.github.com/repos/jedesah/Quasar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jedesah/Quasar/labels{/name}","releases_url":"https://api.github.com/repos/jedesah/Quasar/releases{/id}","deployments_url":"https://api.github.com/repos/jedesah/Quasar/deployments","created_at":"2015-07-15T07:12:13Z","updated_at":"2018-04-10T17:39:19Z","pushed_at":"2018-04-10T17:46:10Z","git_url":"git://github.com/jedesah/Quasar.git","ssh_url":"git@github.com:jedesah/Quasar.git","clone_url":"https://github.com/jedesah/Quasar.git","svn_url":"https://github.com/jedesah/Quasar","homepage":null,"size":70434,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"quasar-analytics:master","ref":"master","sha":"bcfb4466e1eb0e925264c03db37575353e070233","user":{"login":"quasar-analytics","id":15095906,"avatar_url":"https://avatars1.githubusercontent.com/u/15095906?v=4","gravatar_id":"","url":"https://api.github.com/users/quasar-analytics","html_url":"https://github.com/quasar-analytics","followers_url":"https://api.github.com/users/quasar-analytics/followers","following_url":"https://api.github.com/users/quasar-analytics/following{/other_user}","gists_url":"https://api.github.com/users/quasar-analytics/gists{/gist_id}","starred_url":"https://api.github.com/users/quasar-analytics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quasar-analytics/subscriptions","organizations_url":"https://api.github.com/users/quasar-analytics/orgs","repos_url":"https://api.github.com/users/quasar-analytics/repos","events_url":"https://api.github.com/users/quasar-analytics/events{/privacy}","received_events_url":"https://api.github.com/users/quasar-analytics/received_events","type":"Organization","site_admin":false},"repo":{"id":16515058,"name":"quasar","full_name":"quasar-analytics/quasar","owner":{"login":"quasar-analytics","id":15095906,"avatar_url":"https://avatars1.githubusercontent.com/u/15095906?v=4","gravatar_id":"","url":"https://api.github.com/users/quasar-analytics","html_url":"https://github.com/quasar-analytics","followers_url":"https://api.github.com/users/quasar-analytics/followers","following_url":"https://api.github.com/users/quasar-analytics/following{/other_user}","gists_url":"https://api.github.com/users/quasar-analytics/gists{/gist_id}","starred_url":"https://api.github.com/users/quasar-analytics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quasar-analytics/subscriptions","organizations_url":"https://api.github.com/users/quasar-analytics/orgs","repos_url":"https://api.github.com/users/quasar-analytics/repos","events_url":"https://api.github.com/users/quasar-analytics/events{/privacy}","received_events_url":"https://api.github.com/users/quasar-analytics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/quasar-analytics/quasar","description":"Quasar Analytics is a general-purpose compiler for translating data processing and analytics over semi-structured data into efficient plans that run 100% in the target infrastructure.","fork":false,"url":"https://api.github.com/repos/quasar-analytics/quasar","forks_url":"https://api.github.com/repos/quasar-analytics/quasar/forks","keys_url":"https://api.github.com/repos/quasar-analytics/quasar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/quasar-analytics/quasar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/quasar-analytics/quasar/teams","hooks_url":"https://api.github.com/repos/quasar-analytics/quasar/hooks","issue_events_url":"https://api.github.com/repos/quasar-analytics/quasar/issues/events{/number}","events_url":"https://api.github.com/repos/quasar-analytics/quasar/events","assignees_url":"https://api.github.com/repos/quasar-analytics/quasar/assignees{/user}","branches_url":"https://api.github.com/repos/quasar-analytics/quasar/branches{/branch}","tags_url":"https://api.github.com/repos/quasar-analytics/quasar/tags","blobs_url":"https://api.github.com/repos/quasar-analytics/quasar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/quasar-analytics/quasar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/quasar-analytics/quasar/git/refs{/sha}","trees_url":"https://api.github.com/repos/quasar-analytics/quasar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/quasar-analytics/quasar/statuses/{sha}","languages_url":"https://api.github.com/repos/quasar-analytics/quasar/languages","stargazers_url":"https://api.github.com/repos/quasar-analytics/quasar/stargazers","contributors_url":"https://api.github.com/repos/quasar-analytics/quasar/contributors","subscribers_url":"https://api.github.com/repos/quasar-analytics/quasar/subscribers","subscription_url":"https://api.github.com/repos/quasar-analytics/quasar/subscription","commits_url":"https://api.github.com/repos/quasar-analytics/quasar/commits{/sha}","git_commits_url":"https://api.github.com/repos/quasar-analytics/quasar/git/commits{/sha}","comments_url":"https://api.github.com/repos/quasar-analytics/quasar/comments{/number}","issue_comment_url":"https://api.github.com/repos/quasar-analytics/quasar/issues/comments{/number}","contents_url":"https://api.github.com/repos/quasar-analytics/quasar/contents/{+path}","compare_url":"https://api.github.com/repos/quasar-analytics/quasar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/quasar-analytics/quasar/merges","archive_url":"https://api.github.com/repos/quasar-analytics/quasar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/quasar-analytics/quasar/downloads","issues_url":"https://api.github.com/repos/quasar-analytics/quasar/issues{/number}","pulls_url":"https://api.github.com/repos/quasar-analytics/quasar/pulls{/number}","milestones_url":"https://api.github.com/repos/quasar-analytics/quasar/milestones{/number}","notifications_url":"https://api.github.com/repos/quasar-analytics/quasar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/quasar-analytics/quasar/labels{/name}","releases_url":"https://api.github.com/repos/quasar-analytics/quasar/releases{/id}","deployments_url":"https://api.github.com/repos/quasar-analytics/quasar/deployments","created_at":"2014-02-04T15:01:27Z","updated_at":"2018-04-11T16:09:51Z","pushed_at":"2018-04-11T16:41:40Z","git_url":"git://github.com/quasar-analytics/quasar.git","ssh_url":"git@github.com:quasar-analytics/quasar.git","clone_url":"https://github.com/quasar-analytics/quasar.git","svn_url":"https://github.com/quasar-analytics/quasar","homepage":"http://quasar-analytics.org","size":70511,"stargazers_count":627,"watchers_count":627,"language":"Scala","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":91,"mirror_url":null,"archived":false,"open_issues_count":400,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":91,"open_issues":400,"watchers":627,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/quasar-analytics/quasar/pulls/3536"},"html":{"href":"https://github.com/quasar-analytics/quasar/pull/3536"},"issue":{"href":"https://api.github.com/repos/quasar-analytics/quasar/issues/3536"},"comments":{"href":"https://api.github.com/repos/quasar-analytics/quasar/issues/3536/comments"},"review_comments":{"href":"https://api.github.com/repos/quasar-analytics/quasar/pulls/3536/comments"},"review_comment":{"href":"https://api.github.com/repos/quasar-analytics/quasar/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/quasar-analytics/quasar/pulls/3536/commits"},"statuses":{"href":"https://api.github.com/repos/quasar-analytics/quasar/statuses/54e532bc6773d7be0ddf054dd0625c2b760e563c"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"jedesah"}}