{"action":"opened","number":1949,"pull_request":{"url":"https://api.github.com/repos/PhantomBot/PhantomBot/pulls/1949","id":181185602,"html_url":"https://github.com/PhantomBot/PhantomBot/pull/1949","diff_url":"https://github.com/PhantomBot/PhantomBot/pull/1949.diff","patch_url":"https://github.com/PhantomBot/PhantomBot/pull/1949.patch","issue_url":"https://api.github.com/repos/PhantomBot/PhantomBot/issues/1949","number":1949,"state":"open","locked":false,"title":"Fixed (useronly=) and (gameonly=)","user":{"login":"DakodaAtTwitch","id":9284733,"avatar_url":"https://avatars1.githubusercontent.com/u/9284733?v=4","gravatar_id":"","url":"https://api.github.com/users/DakodaAtTwitch","html_url":"https://github.com/DakodaAtTwitch","followers_url":"https://api.github.com/users/DakodaAtTwitch/followers","following_url":"https://api.github.com/users/DakodaAtTwitch/following{/other_user}","gists_url":"https://api.github.com/users/DakodaAtTwitch/gists{/gist_id}","starred_url":"https://api.github.com/users/DakodaAtTwitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DakodaAtTwitch/subscriptions","organizations_url":"https://api.github.com/users/DakodaAtTwitch/orgs","repos_url":"https://api.github.com/users/DakodaAtTwitch/repos","events_url":"https://api.github.com/users/DakodaAtTwitch/events{/privacy}","received_events_url":"https://api.github.com/users/DakodaAtTwitch/received_events","type":"User","site_admin":false},"body":"this will fix it so that (alert) and (playsound) will work with (useronly=) and (gameonly=)\r\n\r\ni used (useronly=test) in this demo\r\n\r\n**Before**\r\n[04-12-2018 @ 13:21:15.255 BST] dakoda: !demo\r\n[04-12-2018 @ 13:21:15.271 BST] [CHAT] Played sound goodgood\r\n\r\n**After**\r\n[04-12-2018 @ 13:22:54.096 BST] dakoda: !demo\r\n\r\n**Please read, especially if your first time contributing to PhantomBot:**\r\n\r\nThank you for contributing to PhantomBot! Hopefully you followed the code style guide:\r\nhttps://github.com/PhantomBot/PhantomBot/blob/master/CODESTYLE.md\r\n\r\nIf you added in code from a third party, it must have a license that is compatible with PhantomBot.  If it is not, we will reject the merge request.  The development team takes this very seriously.  If you add in access to an API and PhantomBot would use that API improperly, we will reject the merge request.  Again, the development team takes this very seriously.\r\n\r\nYou must provide test results for your change.  If test results are not provided we will do one of two things. We will ask you for test results or we will just reject the change.  Test results convince us that you performed a unit test and verified your change.\r\n\r\nWe reserve the right to reject a change for any reason at all.  Typically, we will provide a reason but if we do not, that is at our discretion.  There are some reasons for which we will reject changes, other than the ones given above (but they will be repeated):\r\n\r\n- Code style does not match.\r\n- Incompatible license/improper use of license of third party software/API.\r\n- No test results.\r\n- Potential performance issues.\r\n- Design changes that go against the core design philosophy.\r\n- Items with potential to spam or consume the outgoing message queue.\r\n- Poorly architected items.\r\n- Item is supported in chat but no update for the Control Panel.\r\n- Any command that would violate the Twitch Terms of Service or the Terms of Service of any provider.\r\n\r\nYou are not to harass the development team if a pull request is rejected.  You may discuss and argue why you disagree with a rejection.  We do ask that you stay professional and amicable in your argument and discussion.\r\n\r\nAll pull requests will be reviewed by at least two PhantomBot developers. Please be patient while two developers take the time to do so.  We understand that this adds time to an approval, but it is to ensure that the development team is not missing anything.\r\n\r\n**You may delete this entire text from your Pull Request if you so desire. It is acceptable if you leave it in place as well.**\r\n","created_at":"2018-04-12T12:25:52Z","updated_at":"2018-04-12T12:25:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/PhantomBot/PhantomBot/pulls/1949/commits","review_comments_url":"https://api.github.com/repos/PhantomBot/PhantomBot/pulls/1949/comments","review_comment_url":"https://api.github.com/repos/PhantomBot/PhantomBot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PhantomBot/PhantomBot/issues/1949/comments","statuses_url":"https://api.github.com/repos/PhantomBot/PhantomBot/statuses/c4916fd32fd8f1e0bfc0f63e6e26c5f049d58bf6","head":{"label":"DakodaAtTwitch:patch-2","ref":"patch-2","sha":"c4916fd32fd8f1e0bfc0f63e6e26c5f049d58bf6","user":{"login":"DakodaAtTwitch","id":9284733,"avatar_url":"https://avatars1.githubusercontent.com/u/9284733?v=4","gravatar_id":"","url":"https://api.github.com/users/DakodaAtTwitch","html_url":"https://github.com/DakodaAtTwitch","followers_url":"https://api.github.com/users/DakodaAtTwitch/followers","following_url":"https://api.github.com/users/DakodaAtTwitch/following{/other_user}","gists_url":"https://api.github.com/users/DakodaAtTwitch/gists{/gist_id}","starred_url":"https://api.github.com/users/DakodaAtTwitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DakodaAtTwitch/subscriptions","organizations_url":"https://api.github.com/users/DakodaAtTwitch/orgs","repos_url":"https://api.github.com/users/DakodaAtTwitch/repos","events_url":"https://api.github.com/users/DakodaAtTwitch/events{/privacy}","received_events_url":"https://api.github.com/users/DakodaAtTwitch/received_events","type":"User","site_admin":false},"repo":{"id":123148100,"name":"PhantomBot","full_name":"DakodaAtTwitch/PhantomBot","owner":{"login":"DakodaAtTwitch","id":9284733,"avatar_url":"https://avatars1.githubusercontent.com/u/9284733?v=4","gravatar_id":"","url":"https://api.github.com/users/DakodaAtTwitch","html_url":"https://github.com/DakodaAtTwitch","followers_url":"https://api.github.com/users/DakodaAtTwitch/followers","following_url":"https://api.github.com/users/DakodaAtTwitch/following{/other_user}","gists_url":"https://api.github.com/users/DakodaAtTwitch/gists{/gist_id}","starred_url":"https://api.github.com/users/DakodaAtTwitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DakodaAtTwitch/subscriptions","organizations_url":"https://api.github.com/users/DakodaAtTwitch/orgs","repos_url":"https://api.github.com/users/DakodaAtTwitch/repos","events_url":"https://api.github.com/users/DakodaAtTwitch/events{/privacy}","received_events_url":"https://api.github.com/users/DakodaAtTwitch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DakodaAtTwitch/PhantomBot","description":"PhantomBot is an actively developed open source interactive Twitch bot with a vibrant community that provides entertainment and moderation for your channel, allowing you to focus on what matters the most to you - your game and your viewers.","fork":true,"url":"https://api.github.com/repos/DakodaAtTwitch/PhantomBot","forks_url":"https://api.github.com/repos/DakodaAtTwitch/PhantomBot/forks","keys_url":"https://api.github.com/repos/DakodaAtTwitch/PhantomBot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DakodaAtTwitch/PhantomBot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DakodaAtTwitch/PhantomBot/teams","hooks_url":"https://api.github.com/repos/DakodaAtTwitch/PhantomBot/hooks","issue_events_url":"https://api.github.com/repos/DakodaAtTwitch/PhantomBot/issues/events{/number}","events_url":"https://api.github.com/repos/DakodaAtTwitch/PhantomBot/events","assignees_url":"https://api.github.com/repos/DakodaAtTwitch/PhantomBot/assignees{/user}","branches_url":"https://api.github.com/repos/DakodaAtTwitch/PhantomBot/branches{/branch}","tags_url":"https://api.github.com/repos/DakodaAtTwitch/PhantomBot/tags","blobs_url":"https://api.github.com/repos/DakodaAtTwitch/PhantomBot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DakodaAtTwitch/PhantomBot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DakodaAtTwitch/PhantomBot/git/refs{/sha}","trees_url":"https://api.github.com/repos/DakodaAtTwitch/PhantomBot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DakodaAtTwitch/PhantomBot/statuses/{sha}","languages_url":"https://api.github.com/repos/DakodaAtTwitch/PhantomBot/languages","stargazers_url":"https://api.github.com/repos/DakodaAtTwitch/PhantomBot/stargazers","contributors_url":"https://api.github.com/repos/DakodaAtTwitch/PhantomBot/contributors","subscribers_url":"https://api.github.com/repos/DakodaAtTwitch/PhantomBot/subscribers","subscription_url":"https://api.github.com/repos/DakodaAtTwitch/PhantomBot/subscription","commits_url":"https://api.github.com/repos/DakodaAtTwitch/PhantomBot/commits{/sha}","git_commits_url":"https://api.github.com/repos/DakodaAtTwitch/PhantomBot/git/commits{/sha}","comments_url":"https://api.github.com/repos/DakodaAtTwitch/PhantomBot/comments{/number}","issue_comment_url":"https://api.github.com/repos/DakodaAtTwitch/PhantomBot/issues/comments{/number}","contents_url":"https://api.github.com/repos/DakodaAtTwitch/PhantomBot/contents/{+path}","compare_url":"https://api.github.com/repos/DakodaAtTwitch/PhantomBot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DakodaAtTwitch/PhantomBot/merges","archive_url":"https://api.github.com/repos/DakodaAtTwitch/PhantomBot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DakodaAtTwitch/PhantomBot/downloads","issues_url":"https://api.github.com/repos/DakodaAtTwitch/PhantomBot/issues{/number}","pulls_url":"https://api.github.com/repos/DakodaAtTwitch/PhantomBot/pulls{/number}","milestones_url":"https://api.github.com/repos/DakodaAtTwitch/PhantomBot/milestones{/number}","notifications_url":"https://api.github.com/repos/DakodaAtTwitch/PhantomBot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DakodaAtTwitch/PhantomBot/labels{/name}","releases_url":"https://api.github.com/repos/DakodaAtTwitch/PhantomBot/releases{/id}","deployments_url":"https://api.github.com/repos/DakodaAtTwitch/PhantomBot/deployments","created_at":"2018-02-27T15:23:52Z","updated_at":"2018-04-06T13:10:08Z","pushed_at":"2018-04-12T12:25:43Z","git_url":"git://github.com/DakodaAtTwitch/PhantomBot.git","ssh_url":"git@github.com:DakodaAtTwitch/PhantomBot.git","clone_url":"https://github.com/DakodaAtTwitch/PhantomBot.git","svn_url":"https://github.com/DakodaAtTwitch/PhantomBot","homepage":"https://phantombot.tv/","size":91823,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PhantomBot:master","ref":"master","sha":"89fe91a9b12d87396718a4a427127fb0c70c095c","user":{"login":"PhantomBot","id":16204955,"avatar_url":"https://avatars3.githubusercontent.com/u/16204955?v=4","gravatar_id":"","url":"https://api.github.com/users/PhantomBot","html_url":"https://github.com/PhantomBot","followers_url":"https://api.github.com/users/PhantomBot/followers","following_url":"https://api.github.com/users/PhantomBot/following{/other_user}","gists_url":"https://api.github.com/users/PhantomBot/gists{/gist_id}","starred_url":"https://api.github.com/users/PhantomBot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PhantomBot/subscriptions","organizations_url":"https://api.github.com/users/PhantomBot/orgs","repos_url":"https://api.github.com/users/PhantomBot/repos","events_url":"https://api.github.com/users/PhantomBot/events{/privacy}","received_events_url":"https://api.github.com/users/PhantomBot/received_events","type":"Organization","site_admin":false},"repo":{"id":50057257,"name":"PhantomBot","full_name":"PhantomBot/PhantomBot","owner":{"login":"PhantomBot","id":16204955,"avatar_url":"https://avatars3.githubusercontent.com/u/16204955?v=4","gravatar_id":"","url":"https://api.github.com/users/PhantomBot","html_url":"https://github.com/PhantomBot","followers_url":"https://api.github.com/users/PhantomBot/followers","following_url":"https://api.github.com/users/PhantomBot/following{/other_user}","gists_url":"https://api.github.com/users/PhantomBot/gists{/gist_id}","starred_url":"https://api.github.com/users/PhantomBot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PhantomBot/subscriptions","organizations_url":"https://api.github.com/users/PhantomBot/orgs","repos_url":"https://api.github.com/users/PhantomBot/repos","events_url":"https://api.github.com/users/PhantomBot/events{/privacy}","received_events_url":"https://api.github.com/users/PhantomBot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PhantomBot/PhantomBot","description":"PhantomBot is an actively developed open source interactive Twitch bot with a vibrant community that provides entertainment and moderation for your channel, allowing you to focus on what matters the most to you - your game and your viewers.","fork":false,"url":"https://api.github.com/repos/PhantomBot/PhantomBot","forks_url":"https://api.github.com/repos/PhantomBot/PhantomBot/forks","keys_url":"https://api.github.com/repos/PhantomBot/PhantomBot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PhantomBot/PhantomBot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PhantomBot/PhantomBot/teams","hooks_url":"https://api.github.com/repos/PhantomBot/PhantomBot/hooks","issue_events_url":"https://api.github.com/repos/PhantomBot/PhantomBot/issues/events{/number}","events_url":"https://api.github.com/repos/PhantomBot/PhantomBot/events","assignees_url":"https://api.github.com/repos/PhantomBot/PhantomBot/assignees{/user}","branches_url":"https://api.github.com/repos/PhantomBot/PhantomBot/branches{/branch}","tags_url":"https://api.github.com/repos/PhantomBot/PhantomBot/tags","blobs_url":"https://api.github.com/repos/PhantomBot/PhantomBot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PhantomBot/PhantomBot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PhantomBot/PhantomBot/git/refs{/sha}","trees_url":"https://api.github.com/repos/PhantomBot/PhantomBot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PhantomBot/PhantomBot/statuses/{sha}","languages_url":"https://api.github.com/repos/PhantomBot/PhantomBot/languages","stargazers_url":"https://api.github.com/repos/PhantomBot/PhantomBot/stargazers","contributors_url":"https://api.github.com/repos/PhantomBot/PhantomBot/contributors","subscribers_url":"https://api.github.com/repos/PhantomBot/PhantomBot/subscribers","subscription_url":"https://api.github.com/repos/PhantomBot/PhantomBot/subscription","commits_url":"https://api.github.com/repos/PhantomBot/PhantomBot/commits{/sha}","git_commits_url":"https://api.github.com/repos/PhantomBot/PhantomBot/git/commits{/sha}","comments_url":"https://api.github.com/repos/PhantomBot/PhantomBot/comments{/number}","issue_comment_url":"https://api.github.com/repos/PhantomBot/PhantomBot/issues/comments{/number}","contents_url":"https://api.github.com/repos/PhantomBot/PhantomBot/contents/{+path}","compare_url":"https://api.github.com/repos/PhantomBot/PhantomBot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PhantomBot/PhantomBot/merges","archive_url":"https://api.github.com/repos/PhantomBot/PhantomBot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PhantomBot/PhantomBot/downloads","issues_url":"https://api.github.com/repos/PhantomBot/PhantomBot/issues{/number}","pulls_url":"https://api.github.com/repos/PhantomBot/PhantomBot/pulls{/number}","milestones_url":"https://api.github.com/repos/PhantomBot/PhantomBot/milestones{/number}","notifications_url":"https://api.github.com/repos/PhantomBot/PhantomBot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PhantomBot/PhantomBot/labels{/name}","releases_url":"https://api.github.com/repos/PhantomBot/PhantomBot/releases{/id}","deployments_url":"https://api.github.com/repos/PhantomBot/PhantomBot/deployments","created_at":"2016-01-20T20:13:31Z","updated_at":"2018-04-12T00:07:04Z","pushed_at":"2018-04-12T00:07:03Z","git_url":"git://github.com/PhantomBot/PhantomBot.git","ssh_url":"git@github.com:PhantomBot/PhantomBot.git","clone_url":"https://github.com/PhantomBot/PhantomBot.git","svn_url":"https://github.com/PhantomBot/PhantomBot","homepage":"https://phantombot.tv/","size":91938,"stargazers_count":283,"watchers_count":283,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":166,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":166,"open_issues":1,"watchers":283,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PhantomBot/PhantomBot/pulls/1949"},"html":{"href":"https://github.com/PhantomBot/PhantomBot/pull/1949"},"issue":{"href":"https://api.github.com/repos/PhantomBot/PhantomBot/issues/1949"},"comments":{"href":"https://api.github.com/repos/PhantomBot/PhantomBot/issues/1949/comments"},"review_comments":{"href":"https://api.github.com/repos/PhantomBot/PhantomBot/pulls/1949/comments"},"review_comment":{"href":"https://api.github.com/repos/PhantomBot/PhantomBot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PhantomBot/PhantomBot/pulls/1949/commits"},"statuses":{"href":"https://api.github.com/repos/PhantomBot/PhantomBot/statuses/c4916fd32fd8f1e0bfc0f63e6e26c5f049d58bf6"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":7,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"DakodaAtTwitch"}}