{"action":"created","comment":{"url":"https://api.github.com/repos/gfx-rs/gfx/pulls/comments/166316103","pull_request_review_id":94358991,"id":166316103,"diff_hunk":"@@ -215,8 +215,8 @@ macro_rules! surface_types {\n // ident { num_bits, aspects, dim, (color, alpha, ..) }\n surface_types! {\n     R4_G4               {   8, COLOR, (1, 1), color: 8 },\n-    R4_G4_B4_A4         {  32, COLOR, (1, 1), color: 24, alpha: 4 },\n-    B4_G4_R4_A4         {  32, COLOR, (1, 1), color: 24, alpha: 4 },\n+    R4_G4_B4_A4         {  16, COLOR, (1, 1), color: 12, alpha: 4 },","path":"src/hal/src/format.rs","position":6,"original_position":6,"commit_id":"0c61a74d78b1f9dba2cc64cee1cfb821e6fa7b75","original_commit_id":"0c61a74d78b1f9dba2cc64cee1cfb821e6fa7b75","user":{"login":"kvark","id":107301,"avatar_url":"https://avatars1.githubusercontent.com/u/107301?v=4","gravatar_id":"","url":"https://api.github.com/users/kvark","html_url":"https://github.com/kvark","followers_url":"https://api.github.com/users/kvark/followers","following_url":"https://api.github.com/users/kvark/following{/other_user}","gists_url":"https://api.github.com/users/kvark/gists{/gist_id}","starred_url":"https://api.github.com/users/kvark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kvark/subscriptions","organizations_url":"https://api.github.com/users/kvark/orgs","repos_url":"https://api.github.com/users/kvark/repos","events_url":"https://api.github.com/users/kvark/events{/privacy}","received_events_url":"https://api.github.com/users/kvark/received_events","type":"User","site_admin":false},"body":"uh oh","created_at":"2018-02-06T14:24:50Z","updated_at":"2018-02-06T14:24:53Z","html_url":"https://github.com/gfx-rs/gfx/pull/1795#discussion_r166316103","pull_request_url":"https://api.github.com/repos/gfx-rs/gfx/pulls/1795","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/gfx-rs/gfx/pulls/comments/166316103"},"html":{"href":"https://github.com/gfx-rs/gfx/pull/1795#discussion_r166316103"},"pull_request":{"href":"https://api.github.com/repos/gfx-rs/gfx/pulls/1795"}}},"pull_request":{"url":"https://api.github.com/repos/gfx-rs/gfx/pulls/1795","id":167166617,"html_url":"https://github.com/gfx-rs/gfx/pull/1795","diff_url":"https://github.com/gfx-rs/gfx/pull/1795.diff","patch_url":"https://github.com/gfx-rs/gfx/pull/1795.patch","issue_url":"https://api.github.com/repos/gfx-rs/gfx/issues/1795","number":1795,"state":"open","locked":false,"title":"dx12 : format properties","user":{"login":"msiglreith","id":7253845,"avatar_url":"https://avatars0.githubusercontent.com/u/7253845?v=4","gravatar_id":"","url":"https://api.github.com/users/msiglreith","html_url":"https://github.com/msiglreith","followers_url":"https://api.github.com/users/msiglreith/followers","following_url":"https://api.github.com/users/msiglreith/following{/other_user}","gists_url":"https://api.github.com/users/msiglreith/gists{/gist_id}","starred_url":"https://api.github.com/users/msiglreith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msiglreith/subscriptions","organizations_url":"https://api.github.com/users/msiglreith/orgs","repos_url":"https://api.github.com/users/msiglreith/repos","events_url":"https://api.github.com/users/msiglreith/events{/privacy}","received_events_url":"https://api.github.com/users/msiglreith/received_events","type":"User","site_admin":false},"body":"Implementing format properties in dx12, mostly all formats are unsupported for now. Need to gradually implement more over the time..\r\nAnother point is to try merging format conversion and format properties in a follow up.\r\n\r\nPR checklist:\r\n- [x] `make reftests` succeeds (might be temporarily impossible, WIP)\r\n- [x] tested examples with the following backends: dx12\r\n","created_at":"2018-02-05T15:00:48Z","updated_at":"2018-02-06T14:24:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ff46f47d6802b5574d86906cbb9f85cddb4f9434","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/gfx-rs/gfx/pulls/1795/commits","review_comments_url":"https://api.github.com/repos/gfx-rs/gfx/pulls/1795/comments","review_comment_url":"https://api.github.com/repos/gfx-rs/gfx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gfx-rs/gfx/issues/1795/comments","statuses_url":"https://api.github.com/repos/gfx-rs/gfx/statuses/0c61a74d78b1f9dba2cc64cee1cfb821e6fa7b75","head":{"label":"msiglreith:dx12_formats","ref":"dx12_formats","sha":"0c61a74d78b1f9dba2cc64cee1cfb821e6fa7b75","user":{"login":"msiglreith","id":7253845,"avatar_url":"https://avatars0.githubusercontent.com/u/7253845?v=4","gravatar_id":"","url":"https://api.github.com/users/msiglreith","html_url":"https://github.com/msiglreith","followers_url":"https://api.github.com/users/msiglreith/followers","following_url":"https://api.github.com/users/msiglreith/following{/other_user}","gists_url":"https://api.github.com/users/msiglreith/gists{/gist_id}","starred_url":"https://api.github.com/users/msiglreith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msiglreith/subscriptions","organizations_url":"https://api.github.com/users/msiglreith/orgs","repos_url":"https://api.github.com/users/msiglreith/repos","events_url":"https://api.github.com/users/msiglreith/events{/privacy}","received_events_url":"https://api.github.com/users/msiglreith/received_events","type":"User","site_admin":false},"repo":{"id":64920512,"name":"gfx","full_name":"msiglreith/gfx","owner":{"login":"msiglreith","id":7253845,"avatar_url":"https://avatars0.githubusercontent.com/u/7253845?v=4","gravatar_id":"","url":"https://api.github.com/users/msiglreith","html_url":"https://github.com/msiglreith","followers_url":"https://api.github.com/users/msiglreith/followers","following_url":"https://api.github.com/users/msiglreith/following{/other_user}","gists_url":"https://api.github.com/users/msiglreith/gists{/gist_id}","starred_url":"https://api.github.com/users/msiglreith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msiglreith/subscriptions","organizations_url":"https://api.github.com/users/msiglreith/orgs","repos_url":"https://api.github.com/users/msiglreith/repos","events_url":"https://api.github.com/users/msiglreith/events{/privacy}","received_events_url":"https://api.github.com/users/msiglreith/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/msiglreith/gfx","description":"A high-performance, bindless graphics API for Rust.","fork":true,"url":"https://api.github.com/repos/msiglreith/gfx","forks_url":"https://api.github.com/repos/msiglreith/gfx/forks","keys_url":"https://api.github.com/repos/msiglreith/gfx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/msiglreith/gfx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/msiglreith/gfx/teams","hooks_url":"https://api.github.com/repos/msiglreith/gfx/hooks","issue_events_url":"https://api.github.com/repos/msiglreith/gfx/issues/events{/number}","events_url":"https://api.github.com/repos/msiglreith/gfx/events","assignees_url":"https://api.github.com/repos/msiglreith/gfx/assignees{/user}","branches_url":"https://api.github.com/repos/msiglreith/gfx/branches{/branch}","tags_url":"https://api.github.com/repos/msiglreith/gfx/tags","blobs_url":"https://api.github.com/repos/msiglreith/gfx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/msiglreith/gfx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/msiglreith/gfx/git/refs{/sha}","trees_url":"https://api.github.com/repos/msiglreith/gfx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/msiglreith/gfx/statuses/{sha}","languages_url":"https://api.github.com/repos/msiglreith/gfx/languages","stargazers_url":"https://api.github.com/repos/msiglreith/gfx/stargazers","contributors_url":"https://api.github.com/repos/msiglreith/gfx/contributors","subscribers_url":"https://api.github.com/repos/msiglreith/gfx/subscribers","subscription_url":"https://api.github.com/repos/msiglreith/gfx/subscription","commits_url":"https://api.github.com/repos/msiglreith/gfx/commits{/sha}","git_commits_url":"https://api.github.com/repos/msiglreith/gfx/git/commits{/sha}","comments_url":"https://api.github.com/repos/msiglreith/gfx/comments{/number}","issue_comment_url":"https://api.github.com/repos/msiglreith/gfx/issues/comments{/number}","contents_url":"https://api.github.com/repos/msiglreith/gfx/contents/{+path}","compare_url":"https://api.github.com/repos/msiglreith/gfx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/msiglreith/gfx/merges","archive_url":"https://api.github.com/repos/msiglreith/gfx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/msiglreith/gfx/downloads","issues_url":"https://api.github.com/repos/msiglreith/gfx/issues{/number}","pulls_url":"https://api.github.com/repos/msiglreith/gfx/pulls{/number}","milestones_url":"https://api.github.com/repos/msiglreith/gfx/milestones{/number}","notifications_url":"https://api.github.com/repos/msiglreith/gfx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/msiglreith/gfx/labels{/name}","releases_url":"https://api.github.com/repos/msiglreith/gfx/releases{/id}","deployments_url":"https://api.github.com/repos/msiglreith/gfx/deployments","created_at":"2016-08-04T09:12:32Z","updated_at":"2016-08-04T09:12:34Z","pushed_at":"2018-02-05T14:56:53Z","git_url":"git://github.com/msiglreith/gfx.git","ssh_url":"git@github.com:msiglreith/gfx.git","clone_url":"https://github.com/msiglreith/gfx.git","svn_url":"https://github.com/msiglreith/gfx","homepage":"http://gfx-rs.github.io/","size":24759,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gfx-rs:master","ref":"master","sha":"cd4cc2d70e9e60b13179ad9953def01d81f13c7b","user":{"login":"gfx-rs","id":8213174,"avatar_url":"https://avatars3.githubusercontent.com/u/8213174?v=4","gravatar_id":"","url":"https://api.github.com/users/gfx-rs","html_url":"https://github.com/gfx-rs","followers_url":"https://api.github.com/users/gfx-rs/followers","following_url":"https://api.github.com/users/gfx-rs/following{/other_user}","gists_url":"https://api.github.com/users/gfx-rs/gists{/gist_id}","starred_url":"https://api.github.com/users/gfx-rs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gfx-rs/subscriptions","organizations_url":"https://api.github.com/users/gfx-rs/orgs","repos_url":"https://api.github.com/users/gfx-rs/repos","events_url":"https://api.github.com/users/gfx-rs/events{/privacy}","received_events_url":"https://api.github.com/users/gfx-rs/received_events","type":"Organization","site_admin":false},"repo":{"id":13847975,"name":"gfx","full_name":"gfx-rs/gfx","owner":{"login":"gfx-rs","id":8213174,"avatar_url":"https://avatars3.githubusercontent.com/u/8213174?v=4","gravatar_id":"","url":"https://api.github.com/users/gfx-rs","html_url":"https://github.com/gfx-rs","followers_url":"https://api.github.com/users/gfx-rs/followers","following_url":"https://api.github.com/users/gfx-rs/following{/other_user}","gists_url":"https://api.github.com/users/gfx-rs/gists{/gist_id}","starred_url":"https://api.github.com/users/gfx-rs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gfx-rs/subscriptions","organizations_url":"https://api.github.com/users/gfx-rs/orgs","repos_url":"https://api.github.com/users/gfx-rs/repos","events_url":"https://api.github.com/users/gfx-rs/events{/privacy}","received_events_url":"https://api.github.com/users/gfx-rs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gfx-rs/gfx","description":"A high-performance, bindless graphics API for Rust.","fork":false,"url":"https://api.github.com/repos/gfx-rs/gfx","forks_url":"https://api.github.com/repos/gfx-rs/gfx/forks","keys_url":"https://api.github.com/repos/gfx-rs/gfx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gfx-rs/gfx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gfx-rs/gfx/teams","hooks_url":"https://api.github.com/repos/gfx-rs/gfx/hooks","issue_events_url":"https://api.github.com/repos/gfx-rs/gfx/issues/events{/number}","events_url":"https://api.github.com/repos/gfx-rs/gfx/events","assignees_url":"https://api.github.com/repos/gfx-rs/gfx/assignees{/user}","branches_url":"https://api.github.com/repos/gfx-rs/gfx/branches{/branch}","tags_url":"https://api.github.com/repos/gfx-rs/gfx/tags","blobs_url":"https://api.github.com/repos/gfx-rs/gfx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gfx-rs/gfx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gfx-rs/gfx/git/refs{/sha}","trees_url":"https://api.github.com/repos/gfx-rs/gfx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gfx-rs/gfx/statuses/{sha}","languages_url":"https://api.github.com/repos/gfx-rs/gfx/languages","stargazers_url":"https://api.github.com/repos/gfx-rs/gfx/stargazers","contributors_url":"https://api.github.com/repos/gfx-rs/gfx/contributors","subscribers_url":"https://api.github.com/repos/gfx-rs/gfx/subscribers","subscription_url":"https://api.github.com/repos/gfx-rs/gfx/subscription","commits_url":"https://api.github.com/repos/gfx-rs/gfx/commits{/sha}","git_commits_url":"https://api.github.com/repos/gfx-rs/gfx/git/commits{/sha}","comments_url":"https://api.github.com/repos/gfx-rs/gfx/comments{/number}","issue_comment_url":"https://api.github.com/repos/gfx-rs/gfx/issues/comments{/number}","contents_url":"https://api.github.com/repos/gfx-rs/gfx/contents/{+path}","compare_url":"https://api.github.com/repos/gfx-rs/gfx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gfx-rs/gfx/merges","archive_url":"https://api.github.com/repos/gfx-rs/gfx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gfx-rs/gfx/downloads","issues_url":"https://api.github.com/repos/gfx-rs/gfx/issues{/number}","pulls_url":"https://api.github.com/repos/gfx-rs/gfx/pulls{/number}","milestones_url":"https://api.github.com/repos/gfx-rs/gfx/milestones{/number}","notifications_url":"https://api.github.com/repos/gfx-rs/gfx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gfx-rs/gfx/labels{/name}","releases_url":"https://api.github.com/repos/gfx-rs/gfx/releases{/id}","deployments_url":"https://api.github.com/repos/gfx-rs/gfx/deployments","created_at":"2013-10-25T00:35:35Z","updated_at":"2018-02-06T08:36:16Z","pushed_at":"2018-02-06T14:19:31Z","git_url":"git://github.com/gfx-rs/gfx.git","ssh_url":"git@github.com:gfx-rs/gfx.git","clone_url":"https://github.com/gfx-rs/gfx.git","svn_url":"https://github.com/gfx-rs/gfx","homepage":"http://gfx-rs.github.io/","size":28525,"stargazers_count":1402,"watchers_count":1402,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":213,"mirror_url":null,"archived":false,"open_issues_count":191,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":213,"open_issues":191,"watchers":1402,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gfx-rs/gfx/pulls/1795"},"html":{"href":"https://github.com/gfx-rs/gfx/pull/1795"},"issue":{"href":"https://api.github.com/repos/gfx-rs/gfx/issues/1795"},"comments":{"href":"https://api.github.com/repos/gfx-rs/gfx/issues/1795/comments"},"review_comments":{"href":"https://api.github.com/repos/gfx-rs/gfx/pulls/1795/comments"},"review_comment":{"href":"https://api.github.com/repos/gfx-rs/gfx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gfx-rs/gfx/pulls/1795/commits"},"statuses":{"href":"https://api.github.com/repos/gfx-rs/gfx/statuses/0c61a74d78b1f9dba2cc64cee1cfb821e6fa7b75"}},"author_association":"OWNER"}}
{"actor":{"display_login":"kvark"}}