{"action":"closed","issue":{"url":"https://api.github.com/repos/dart-lang/angular/issues/1319","repository_url":"https://api.github.com/repos/dart-lang/angular","labels_url":"https://api.github.com/repos/dart-lang/angular/issues/1319/labels{/name}","comments_url":"https://api.github.com/repos/dart-lang/angular/issues/1319/comments","events_url":"https://api.github.com/repos/dart-lang/angular/issues/1319/events","html_url":"https://github.com/dart-lang/angular/issues/1319","id":323833240,"node_id":"MDU6SXNzdWUzMjM4MzMyNDA=","number":1319,"title":"Where should pageloader bindings/examples live?","user":{"login":"matanlurey","id":168174,"node_id":"MDQ6VXNlcjE2ODE3NA==","avatar_url":"https://avatars2.githubusercontent.com/u/168174?v=4","gravatar_id":"","url":"https://api.github.com/users/matanlurey","html_url":"https://github.com/matanlurey","followers_url":"https://api.github.com/users/matanlurey/followers","following_url":"https://api.github.com/users/matanlurey/following{/other_user}","gists_url":"https://api.github.com/users/matanlurey/gists{/gist_id}","starred_url":"https://api.github.com/users/matanlurey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matanlurey/subscriptions","organizations_url":"https://api.github.com/users/matanlurey/orgs","repos_url":"https://api.github.com/users/matanlurey/repos","events_url":"https://api.github.com/users/matanlurey/events{/privacy}","received_events_url":"https://api.github.com/users/matanlurey/received_events","type":"User","site_admin":false},"labels":[{"id":623415559,"node_id":"MDU6TGFiZWw2MjM0MTU1NTk=","url":"https://api.github.com/repos/dart-lang/angular/labels/%E2%9B%B9%20feedback:%20discussion","name":"⛹ feedback: discussion","color":"cc317c","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-05-17T00:35:17Z","updated_at":"2018-06-06T00:54:32Z","closed_at":"2018-06-06T00:54:32Z","author_association":"CONTRIBUTOR","body":"For context, here is ~approximately the code required to use `angular_test`+`pageloader`:\r\n\r\n```dart\r\nNgTestFixture testFixture = ...;\r\n\r\nfinal pageLoader = new HtmlPageLoaderElement.createForElement(\r\n  testFixture.rootElement,\r\n  externalSyncFn: testFixture.update,\r\n)\r\n\r\n// You can now use `pageLoader`.\r\n```\r\n\r\n## Option 1: No where. Just publish at least one example of using it.\r\n\r\nBasically, something like the above. It's about ~3 lines of boilerplate, at most.\r\n\r\n## Option 2: Create `angular_pageloader` package with a helper:\r\n\r\n```dart\r\nHtmlPageLoaderElement pageLoader(NgTestFixture<void> testFixture) => ...\r\n```\r\n\r\n## Option 2B: Same, but inside of `angular_components_test`\r\n\r\n... which will be needed *anyway* to host page objects and testing infra.\r\n\r\n## Option 3: Add a `pageLoader` function to `NgTestFixture`:\r\n\r\n(We used to do this with PL2)\r\n\r\n```dart\r\nabstract class NgTestFixture<T> {\r\n  HtmlPageLoaderElement pageLoader() => ...\r\n}\r\n```\r\n\r\nThis would include:\r\n\r\n```yaml\r\ndependencies:\r\n  build: ^0.12.0\r\n  built_value: ^5.1.0\r\n  matcher: ^0.12.0+1\r\n  quiver: ^0.29.0\r\n  source_gen: ^0.8.0\r\n  webdriver: ^2.0.0-beta\r\n```\r\n\r\n... as dependencies on every package that uses `angular_test`."}}
{"actor":{"display_login":"matanlurey"}}