{"action":"created","comment":{"url":"https://api.github.com/repos/cakephp/cakephp/pulls/comments/188918877","pull_request_review_id":120991906,"id":188918877,"diff_hunk":"@@ -1559,6 +1559,40 @@ public static function hexColor($check)\n         return static::_check($check, '/^#[0-9a-f]{6}$/iD');\n     }\n \n+    /**\n+     * Check that the input value is a valid IBAN number\n+     *\n+     * @param string $check The value to check\n+     * @return bool Success\n+     */\n+    public static function iban($check)","path":"src/Validation/Validation.php","position":10,"original_position":10,"commit_id":"b1a13e07dec7f841f938e3ce58df224afb4ce905","original_commit_id":"b1a13e07dec7f841f938e3ce58df224afb4ce905","user":{"login":"inoas","id":20972207,"avatar_url":"https://avatars0.githubusercontent.com/u/20972207?v=4","gravatar_id":"","url":"https://api.github.com/users/inoas","html_url":"https://github.com/inoas","followers_url":"https://api.github.com/users/inoas/followers","following_url":"https://api.github.com/users/inoas/following{/other_user}","gists_url":"https://api.github.com/users/inoas/gists{/gist_id}","starred_url":"https://api.github.com/users/inoas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inoas/subscriptions","organizations_url":"https://api.github.com/users/inoas/orgs","repos_url":"https://api.github.com/users/inoas/repos","events_url":"https://api.github.com/users/inoas/events{/privacy}","received_events_url":"https://api.github.com/users/inoas/received_events","type":"User","site_admin":false},"body":"it does nothing more than that. it does not validate an iban(). If it were it would be required to check the country code against the length, and possibly even the national bank codes against a database https://en.wikipedia.org/wiki/International_Bank_Account_Number#IBAN_formats_by_country\r\n\r\nIt is a pure stateless syntax check with. Validating an IBAN *for real* requires much more work. Thus `ibanSyntax()` hints you very clearly that you are only checking the form (uppercase, no whitespaces, max length, country code exists at right spot, checksum exists at right spot, body matches against checksum via Luhn)","created_at":"2018-05-17T11:02:22Z","updated_at":"2018-05-17T11:02:22Z","html_url":"https://github.com/cakephp/cakephp/pull/12092#discussion_r188918877","pull_request_url":"https://api.github.com/repos/cakephp/cakephp/pulls/12092","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/cakephp/cakephp/pulls/comments/188918877"},"html":{"href":"https://github.com/cakephp/cakephp/pull/12092#discussion_r188918877"},"pull_request":{"href":"https://api.github.com/repos/cakephp/cakephp/pulls/12092"}},"in_reply_to_id":188912077},"pull_request":{"url":"https://api.github.com/repos/cakephp/cakephp/pulls/12092","id":188641141,"html_url":"https://github.com/cakephp/cakephp/pull/12092","diff_url":"https://github.com/cakephp/cakephp/pull/12092.diff","patch_url":"https://github.com/cakephp/cakephp/pull/12092.patch","issue_url":"https://api.github.com/repos/cakephp/cakephp/issues/12092","number":12092,"state":"open","locked":false,"title":"IBAN validation + test added","user":{"login":"philsweb","id":26385192,"avatar_url":"https://avatars3.githubusercontent.com/u/26385192?v=4","gravatar_id":"","url":"https://api.github.com/users/philsweb","html_url":"https://github.com/philsweb","followers_url":"https://api.github.com/users/philsweb/followers","following_url":"https://api.github.com/users/philsweb/following{/other_user}","gists_url":"https://api.github.com/users/philsweb/gists{/gist_id}","starred_url":"https://api.github.com/users/philsweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philsweb/subscriptions","organizations_url":"https://api.github.com/users/philsweb/orgs","repos_url":"https://api.github.com/users/philsweb/repos","events_url":"https://api.github.com/users/philsweb/events{/privacy}","received_events_url":"https://api.github.com/users/philsweb/received_events","type":"User","site_admin":false},"body":"Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.\r\n\r\nThe best way to propose a feature is to open an issue first and discuss your ideas there before implementing them.\r\n\r\nAlways follow the [contribution guidelines](https://github.com/cakephp/cakephp/blob/master/.github/CONTRIBUTING.md) when submitting a pull request. In particular, make sure existing tests still pass, and add tests for all new behavior. When fixing a bug, you may want to add a test to verify the fix.\r\n","created_at":"2018-05-17T07:06:06Z","updated_at":"2018-05-17T11:02:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"743f6d55867f533530d38ac72d49b5e717328474","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cakephp/cakephp/pulls/12092/commits","review_comments_url":"https://api.github.com/repos/cakephp/cakephp/pulls/12092/comments","review_comment_url":"https://api.github.com/repos/cakephp/cakephp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cakephp/cakephp/issues/12092/comments","statuses_url":"https://api.github.com/repos/cakephp/cakephp/statuses/b1a13e07dec7f841f938e3ce58df224afb4ce905","head":{"label":"philsweb:master","ref":"master","sha":"b1a13e07dec7f841f938e3ce58df224afb4ce905","user":{"login":"philsweb","id":26385192,"avatar_url":"https://avatars3.githubusercontent.com/u/26385192?v=4","gravatar_id":"","url":"https://api.github.com/users/philsweb","html_url":"https://github.com/philsweb","followers_url":"https://api.github.com/users/philsweb/followers","following_url":"https://api.github.com/users/philsweb/following{/other_user}","gists_url":"https://api.github.com/users/philsweb/gists{/gist_id}","starred_url":"https://api.github.com/users/philsweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philsweb/subscriptions","organizations_url":"https://api.github.com/users/philsweb/orgs","repos_url":"https://api.github.com/users/philsweb/repos","events_url":"https://api.github.com/users/philsweb/events{/privacy}","received_events_url":"https://api.github.com/users/philsweb/received_events","type":"User","site_admin":false},"repo":{"id":133769683,"name":"cakephp","full_name":"philsweb/cakephp","owner":{"login":"philsweb","id":26385192,"avatar_url":"https://avatars3.githubusercontent.com/u/26385192?v=4","gravatar_id":"","url":"https://api.github.com/users/philsweb","html_url":"https://github.com/philsweb","followers_url":"https://api.github.com/users/philsweb/followers","following_url":"https://api.github.com/users/philsweb/following{/other_user}","gists_url":"https://api.github.com/users/philsweb/gists{/gist_id}","starred_url":"https://api.github.com/users/philsweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philsweb/subscriptions","organizations_url":"https://api.github.com/users/philsweb/orgs","repos_url":"https://api.github.com/users/philsweb/repos","events_url":"https://api.github.com/users/philsweb/events{/privacy}","received_events_url":"https://api.github.com/users/philsweb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/philsweb/cakephp","description":"CakePHP: The Rapid Development Framework for PHP - Official Repository","fork":true,"url":"https://api.github.com/repos/philsweb/cakephp","forks_url":"https://api.github.com/repos/philsweb/cakephp/forks","keys_url":"https://api.github.com/repos/philsweb/cakephp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/philsweb/cakephp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/philsweb/cakephp/teams","hooks_url":"https://api.github.com/repos/philsweb/cakephp/hooks","issue_events_url":"https://api.github.com/repos/philsweb/cakephp/issues/events{/number}","events_url":"https://api.github.com/repos/philsweb/cakephp/events","assignees_url":"https://api.github.com/repos/philsweb/cakephp/assignees{/user}","branches_url":"https://api.github.com/repos/philsweb/cakephp/branches{/branch}","tags_url":"https://api.github.com/repos/philsweb/cakephp/tags","blobs_url":"https://api.github.com/repos/philsweb/cakephp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/philsweb/cakephp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/philsweb/cakephp/git/refs{/sha}","trees_url":"https://api.github.com/repos/philsweb/cakephp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/philsweb/cakephp/statuses/{sha}","languages_url":"https://api.github.com/repos/philsweb/cakephp/languages","stargazers_url":"https://api.github.com/repos/philsweb/cakephp/stargazers","contributors_url":"https://api.github.com/repos/philsweb/cakephp/contributors","subscribers_url":"https://api.github.com/repos/philsweb/cakephp/subscribers","subscription_url":"https://api.github.com/repos/philsweb/cakephp/subscription","commits_url":"https://api.github.com/repos/philsweb/cakephp/commits{/sha}","git_commits_url":"https://api.github.com/repos/philsweb/cakephp/git/commits{/sha}","comments_url":"https://api.github.com/repos/philsweb/cakephp/comments{/number}","issue_comment_url":"https://api.github.com/repos/philsweb/cakephp/issues/comments{/number}","contents_url":"https://api.github.com/repos/philsweb/cakephp/contents/{+path}","compare_url":"https://api.github.com/repos/philsweb/cakephp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/philsweb/cakephp/merges","archive_url":"https://api.github.com/repos/philsweb/cakephp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/philsweb/cakephp/downloads","issues_url":"https://api.github.com/repos/philsweb/cakephp/issues{/number}","pulls_url":"https://api.github.com/repos/philsweb/cakephp/pulls{/number}","milestones_url":"https://api.github.com/repos/philsweb/cakephp/milestones{/number}","notifications_url":"https://api.github.com/repos/philsweb/cakephp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/philsweb/cakephp/labels{/name}","releases_url":"https://api.github.com/repos/philsweb/cakephp/releases{/id}","deployments_url":"https://api.github.com/repos/philsweb/cakephp/deployments","created_at":"2018-05-17T06:35:16Z","updated_at":"2018-05-17T10:04:02Z","pushed_at":"2018-05-17T10:03:59Z","git_url":"git://github.com/philsweb/cakephp.git","ssh_url":"git@github.com:philsweb/cakephp.git","clone_url":"https://github.com/philsweb/cakephp.git","svn_url":"https://github.com/philsweb/cakephp","homepage":"http://cakephp.org","size":77589,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cakephp:master","ref":"master","sha":"55e8a1e8897f6e0bf23dc25368f3fdf83f6159b6","user":{"login":"cakephp","id":23666,"avatar_url":"https://avatars0.githubusercontent.com/u/23666?v=4","gravatar_id":"","url":"https://api.github.com/users/cakephp","html_url":"https://github.com/cakephp","followers_url":"https://api.github.com/users/cakephp/followers","following_url":"https://api.github.com/users/cakephp/following{/other_user}","gists_url":"https://api.github.com/users/cakephp/gists{/gist_id}","starred_url":"https://api.github.com/users/cakephp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cakephp/subscriptions","organizations_url":"https://api.github.com/users/cakephp/orgs","repos_url":"https://api.github.com/users/cakephp/repos","events_url":"https://api.github.com/users/cakephp/events{/privacy}","received_events_url":"https://api.github.com/users/cakephp/received_events","type":"Organization","site_admin":false},"repo":{"id":656494,"name":"cakephp","full_name":"cakephp/cakephp","owner":{"login":"cakephp","id":23666,"avatar_url":"https://avatars0.githubusercontent.com/u/23666?v=4","gravatar_id":"","url":"https://api.github.com/users/cakephp","html_url":"https://github.com/cakephp","followers_url":"https://api.github.com/users/cakephp/followers","following_url":"https://api.github.com/users/cakephp/following{/other_user}","gists_url":"https://api.github.com/users/cakephp/gists{/gist_id}","starred_url":"https://api.github.com/users/cakephp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cakephp/subscriptions","organizations_url":"https://api.github.com/users/cakephp/orgs","repos_url":"https://api.github.com/users/cakephp/repos","events_url":"https://api.github.com/users/cakephp/events{/privacy}","received_events_url":"https://api.github.com/users/cakephp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cakephp/cakephp","description":"CakePHP: The Rapid Development Framework for PHP - Official Repository","fork":false,"url":"https://api.github.com/repos/cakephp/cakephp","forks_url":"https://api.github.com/repos/cakephp/cakephp/forks","keys_url":"https://api.github.com/repos/cakephp/cakephp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cakephp/cakephp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cakephp/cakephp/teams","hooks_url":"https://api.github.com/repos/cakephp/cakephp/hooks","issue_events_url":"https://api.github.com/repos/cakephp/cakephp/issues/events{/number}","events_url":"https://api.github.com/repos/cakephp/cakephp/events","assignees_url":"https://api.github.com/repos/cakephp/cakephp/assignees{/user}","branches_url":"https://api.github.com/repos/cakephp/cakephp/branches{/branch}","tags_url":"https://api.github.com/repos/cakephp/cakephp/tags","blobs_url":"https://api.github.com/repos/cakephp/cakephp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cakephp/cakephp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cakephp/cakephp/git/refs{/sha}","trees_url":"https://api.github.com/repos/cakephp/cakephp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cakephp/cakephp/statuses/{sha}","languages_url":"https://api.github.com/repos/cakephp/cakephp/languages","stargazers_url":"https://api.github.com/repos/cakephp/cakephp/stargazers","contributors_url":"https://api.github.com/repos/cakephp/cakephp/contributors","subscribers_url":"https://api.github.com/repos/cakephp/cakephp/subscribers","subscription_url":"https://api.github.com/repos/cakephp/cakephp/subscription","commits_url":"https://api.github.com/repos/cakephp/cakephp/commits{/sha}","git_commits_url":"https://api.github.com/repos/cakephp/cakephp/git/commits{/sha}","comments_url":"https://api.github.com/repos/cakephp/cakephp/comments{/number}","issue_comment_url":"https://api.github.com/repos/cakephp/cakephp/issues/comments{/number}","contents_url":"https://api.github.com/repos/cakephp/cakephp/contents/{+path}","compare_url":"https://api.github.com/repos/cakephp/cakephp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cakephp/cakephp/merges","archive_url":"https://api.github.com/repos/cakephp/cakephp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cakephp/cakephp/downloads","issues_url":"https://api.github.com/repos/cakephp/cakephp/issues{/number}","pulls_url":"https://api.github.com/repos/cakephp/cakephp/pulls{/number}","milestones_url":"https://api.github.com/repos/cakephp/cakephp/milestones{/number}","notifications_url":"https://api.github.com/repos/cakephp/cakephp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cakephp/cakephp/labels{/name}","releases_url":"https://api.github.com/repos/cakephp/cakephp/releases{/id}","deployments_url":"https://api.github.com/repos/cakephp/cakephp/deployments","created_at":"2010-05-08T14:38:22Z","updated_at":"2018-05-16T18:05:40Z","pushed_at":"2018-05-17T10:04:01Z","git_url":"git://github.com/cakephp/cakephp.git","ssh_url":"git@github.com:cakephp/cakephp.git","clone_url":"https://github.com/cakephp/cakephp.git","svn_url":"https://github.com/cakephp/cakephp","homepage":"http://cakephp.org","size":77503,"stargazers_count":7537,"watchers_count":7537,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3321,"mirror_url":null,"archived":false,"open_issues_count":241,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":3321,"open_issues":241,"watchers":7537,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cakephp/cakephp/pulls/12092"},"html":{"href":"https://github.com/cakephp/cakephp/pull/12092"},"issue":{"href":"https://api.github.com/repos/cakephp/cakephp/issues/12092"},"comments":{"href":"https://api.github.com/repos/cakephp/cakephp/issues/12092/comments"},"review_comments":{"href":"https://api.github.com/repos/cakephp/cakephp/pulls/12092/comments"},"review_comment":{"href":"https://api.github.com/repos/cakephp/cakephp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cakephp/cakephp/pulls/12092/commits"},"statuses":{"href":"https://api.github.com/repos/cakephp/cakephp/statuses/b1a13e07dec7f841f938e3ce58df224afb4ce905"}},"author_association":"NONE"}}
{"actor":{"display_login":"inoas"}}