{"action":"created","issue":{"url":"https://api.github.com/repos/zcash/zcash/issues/3303","repository_url":"https://api.github.com/repos/zcash/zcash","labels_url":"https://api.github.com/repos/zcash/zcash/issues/3303/labels{/name}","comments_url":"https://api.github.com/repos/zcash/zcash/issues/3303/comments","events_url":"https://api.github.com/repos/zcash/zcash/issues/3303/events","html_url":"https://github.com/zcash/zcash/pull/3303","id":326177552,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkwMzMzMDEw","number":3303,"title":"(rpc-test) accurately account for fee without rounding error","user":{"login":"LarryRuane","id":8321330,"node_id":"MDQ6VXNlcjgzMjEzMzA=","avatar_url":"https://avatars2.githubusercontent.com/u/8321330?v=4","gravatar_id":"","url":"https://api.github.com/users/LarryRuane","html_url":"https://github.com/LarryRuane","followers_url":"https://api.github.com/users/LarryRuane/followers","following_url":"https://api.github.com/users/LarryRuane/following{/other_user}","gists_url":"https://api.github.com/users/LarryRuane/gists{/gist_id}","starred_url":"https://api.github.com/users/LarryRuane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LarryRuane/subscriptions","organizations_url":"https://api.github.com/users/LarryRuane/orgs","repos_url":"https://api.github.com/users/LarryRuane/repos","events_url":"https://api.github.com/users/LarryRuane/events{/privacy}","received_events_url":"https://api.github.com/users/LarryRuane/received_events","type":"User","site_admin":false},"labels":[{"id":163608997,"node_id":"MDU6TGFiZWwxNjM2MDg5OTc=","url":"https://api.github.com/repos/zcash/zcash/labels/testing","name":"testing","color":"939977","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/zcash/zcash/milestones/72","html_url":"https://github.com/zcash/zcash/milestone/72","labels_url":"https://api.github.com/repos/zcash/zcash/milestones/72/labels","id":3126582,"node_id":"MDk6TWlsZXN0b25lMzEyNjU4Mg==","number":72,"title":"v1.1.2","description":"","creator":{"login":"str4d","id":4993799,"node_id":"MDQ6VXNlcjQ5OTM3OTk=","avatar_url":"https://avatars0.githubusercontent.com/u/4993799?v=4","gravatar_id":"","url":"https://api.github.com/users/str4d","html_url":"https://github.com/str4d","followers_url":"https://api.github.com/users/str4d/followers","following_url":"https://api.github.com/users/str4d/following{/other_user}","gists_url":"https://api.github.com/users/str4d/gists{/gist_id}","starred_url":"https://api.github.com/users/str4d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/str4d/subscriptions","organizations_url":"https://api.github.com/users/str4d/orgs","repos_url":"https://api.github.com/users/str4d/repos","events_url":"https://api.github.com/users/str4d/events{/privacy}","received_events_url":"https://api.github.com/users/str4d/received_events","type":"User","site_admin":false},"open_issues":45,"closed_issues":17,"state":"open","created_at":"2018-02-19T11:17:43Z","updated_at":"2018-06-22T18:14:02Z","due_on":"2018-07-02T07:00:00Z","closed_at":null},"comments":10,"created_at":"2018-05-24T15:35:27Z","updated_at":"2018-06-22T21:01:43Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/zcash/zcash/pulls/3303","html_url":"https://github.com/zcash/zcash/pull/3303","diff_url":"https://github.com/zcash/zcash/pull/3303.diff","patch_url":"https://github.com/zcash/zcash/pull/3303.patch"},"body":"Fix for #2807, this test compares balances after doing key exports and imports, and expects these balances to be equal. But they are not exactly equal due to transaction fees, so the test makes them \"equal\" by rounding a value that has had fees taken out up to the nearest hundredth of a unit (which is much more than the default fee). This obviously is somewhat sloppy. It also converts a balance to float, which really should never be used due to loss of precision (use Decimal instead).\r\n\r\nThis change makes the test accurately account for the fee using precise comparisons, and removes the use of float. This test doesn't depend on the default fee (0.0001) but instead sets the fee (to that value). This way, if the default fee changes in the future, this test will continue to run. While testing these changes, I set the fee to various values (up to the max, 0.0190), and the test still passes."},"comment":{"url":"https://api.github.com/repos/zcash/zcash/issues/comments/399581046","html_url":"https://github.com/zcash/zcash/pull/3303#issuecomment-399581046","issue_url":"https://api.github.com/repos/zcash/zcash/issues/3303","id":399581046,"node_id":"MDEyOklzc3VlQ29tbWVudDM5OTU4MTA0Ng==","user":{"login":"zkbot","id":17032253,"node_id":"MDQ6VXNlcjE3MDMyMjUz","avatar_url":"https://avatars2.githubusercontent.com/u/17032253?v=4","gravatar_id":"","url":"https://api.github.com/users/zkbot","html_url":"https://github.com/zkbot","followers_url":"https://api.github.com/users/zkbot/followers","following_url":"https://api.github.com/users/zkbot/following{/other_user}","gists_url":"https://api.github.com/users/zkbot/gists{/gist_id}","starred_url":"https://api.github.com/users/zkbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zkbot/subscriptions","organizations_url":"https://api.github.com/users/zkbot/orgs","repos_url":"https://api.github.com/users/zkbot/repos","events_url":"https://api.github.com/users/zkbot/events{/privacy}","received_events_url":"https://api.github.com/users/zkbot/received_events","type":"User","site_admin":false},"created_at":"2018-06-22T21:01:43Z","updated_at":"2018-06-22T21:01:43Z","author_association":"CONTRIBUTOR","body":":pushpin: Commit a4ff089 has been approved by `bitcartel`\n\n<!-- @zkbot r=bitcartel a4ff089b2a91c9af0fa89a0e0cfed04363d18891 -->"}}
{"actor":{"display_login":"zkbot"}}