{"action":"created","issue":{"url":"https://api.github.com/repos/devtools-html/perf.html/issues/952","repository_url":"https://api.github.com/repos/devtools-html/perf.html","labels_url":"https://api.github.com/repos/devtools-html/perf.html/issues/952/labels{/name}","comments_url":"https://api.github.com/repos/devtools-html/perf.html/issues/952/comments","events_url":"https://api.github.com/repos/devtools-html/perf.html/issues/952/events","html_url":"https://github.com/devtools-html/perf.html/pull/952","id":316113929,"number":952,"title":"Fix 422: \"Display duration of time range in the breadcrumbs bar\"","user":{"login":"MarcelloNicoletti","id":1910383,"avatar_url":"https://avatars2.githubusercontent.com/u/1910383?v=4","gravatar_id":"","url":"https://api.github.com/users/MarcelloNicoletti","html_url":"https://github.com/MarcelloNicoletti","followers_url":"https://api.github.com/users/MarcelloNicoletti/followers","following_url":"https://api.github.com/users/MarcelloNicoletti/following{/other_user}","gists_url":"https://api.github.com/users/MarcelloNicoletti/gists{/gist_id}","starred_url":"https://api.github.com/users/MarcelloNicoletti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarcelloNicoletti/subscriptions","organizations_url":"https://api.github.com/users/MarcelloNicoletti/orgs","repos_url":"https://api.github.com/users/MarcelloNicoletti/repos","events_url":"https://api.github.com/users/MarcelloNicoletti/events{/privacy}","received_events_url":"https://api.github.com/users/MarcelloNicoletti/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-04-20T03:22:53Z","updated_at":"2018-04-23T16:48:39Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/devtools-html/perf.html/pulls/952","html_url":"https://github.com/devtools-html/perf.html/pull/952","diff_url":"https://github.com/devtools-html/perf.html/pull/952.diff","patch_url":"https://github.com/devtools-html/perf.html/pull/952.patch"},"body":"This fixes #422.\r\n\r\nI worked on this in collarboration with @mojac\r\n\r\nWe added a new item to the `FilterNavigatorBar` that conditionally shows when there is a selection in the profile viewer. This new element reflects the duration of the selection persistantly in addition to the current one which hides when the seleciton is not being edited.\r\n\r\nWe aren't sure what kind of styling we should apply to this new item. As it is now, we did not create any new CSS classes, electing to reuse existing ones. In order to be able to add the new item conditionally we wrapped the original `<ol>` in a surrounding `<div>` with the same classes. This means that the new `<div>` flexes to the full width *and* the `<ol>` inside it does as well. This puts our newly added item all the way to the right of the free space, right next to the \"Share...\" button.\r\n\r\n<img width=\"808\" alt=\"demo\" src=\"https://user-images.githubusercontent.com/1910383/39029110-5fba5730-4417-11e8-9147-b472de3c8470.png\">\r\n"},"comment":{"url":"https://api.github.com/repos/devtools-html/perf.html/issues/comments/383644362","html_url":"https://github.com/devtools-html/perf.html/pull/952#issuecomment-383644362","issue_url":"https://api.github.com/repos/devtools-html/perf.html/issues/952","id":383644362,"user":{"login":"julienw","id":454175,"avatar_url":"https://avatars0.githubusercontent.com/u/454175?v=4","gravatar_id":"","url":"https://api.github.com/users/julienw","html_url":"https://github.com/julienw","followers_url":"https://api.github.com/users/julienw/followers","following_url":"https://api.github.com/users/julienw/following{/other_user}","gists_url":"https://api.github.com/users/julienw/gists{/gist_id}","starred_url":"https://api.github.com/users/julienw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julienw/subscriptions","organizations_url":"https://api.github.com/users/julienw/orgs","repos_url":"https://api.github.com/users/julienw/repos","events_url":"https://api.github.com/users/julienw/events{/privacy}","received_events_url":"https://api.github.com/users/julienw/received_events","type":"User","site_admin":false},"created_at":"2018-04-23T16:48:39Z","updated_at":"2018-04-23T16:48:39Z","author_association":"COLLABORATOR","body":"> If so maybe we could instead animate it's opacity from pale to solid? I'll have to try it out and see how it looks with the current animation before I judge it though\r\n\r\nYes I think that's a good idea, if you can try it !\r\n\r\n> For example, setting it to 'undefined' inside mapStateToProps does update the item when unsetting the selection.\r\n\r\nI guess you mean `doesn't update` here, right ? That's a good finding, I wasn't aware of this. As a workaround I can suggest using `null` or, as you did, `''`.\r\n\r\n(More comments coming with a review)"}}
{"actor":{"display_login":"julienw"}}