{"action":"created","comment":{"url":"https://api.github.com/repos/PyCQA/astroid/pulls/comments/177323673","pull_request_review_id":107169289,"id":177323673,"diff_hunk":"@@ -832,3 +835,17 @@ def instance_getitem(self, index, context=None):\n             node=self, index=index, context=context))\n \n bases.Instance.getitem = instance_getitem\n+\n+\n+def _set_explicit_context_for_call(call, context):","path":"astroid/inference.py","position":23,"original_position":23,"commit_id":"4f6fbbd7cb448da305ffb5f5f9ef22653f359544","original_commit_id":"4f6fbbd7cb448da305ffb5f5f9ef22653f359544","user":{"login":"PCManticore","id":448166,"avatar_url":"https://avatars1.githubusercontent.com/u/448166?v=4","gravatar_id":"","url":"https://api.github.com/users/PCManticore","html_url":"https://github.com/PCManticore","followers_url":"https://api.github.com/users/PCManticore/followers","following_url":"https://api.github.com/users/PCManticore/following{/other_user}","gists_url":"https://api.github.com/users/PCManticore/gists{/gist_id}","starred_url":"https://api.github.com/users/PCManticore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PCManticore/subscriptions","organizations_url":"https://api.github.com/users/PCManticore/orgs","repos_url":"https://api.github.com/users/PCManticore/repos","events_url":"https://api.github.com/users/PCManticore/events{/privacy}","received_events_url":"https://api.github.com/users/PCManticore/received_events","type":"User","site_admin":false},"body":"One problem I have with this is that it mutates the underlying nodes with a context. While we do that for the explicit inference, I'd like us to start considering the nodes as immutable, with as few as possible places where we'd have to mutate them (right now another one apart of `explicit_inference` would be mutating `.locals`). It would make more sense to push these values inside the context itself, after which we could modify the inference to look for the nested values of a context when inferring values. This way we keep nodes untouched, we only pass the modified context.","created_at":"2018-03-27T06:54:25Z","updated_at":"2018-03-27T06:55:26Z","html_url":"https://github.com/PyCQA/astroid/pull/518#discussion_r177323673","pull_request_url":"https://api.github.com/repos/PyCQA/astroid/pulls/518","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/PyCQA/astroid/pulls/comments/177323673"},"html":{"href":"https://github.com/PyCQA/astroid/pull/518#discussion_r177323673"},"pull_request":{"href":"https://api.github.com/repos/PyCQA/astroid/pulls/518"}}},"pull_request":{"url":"https://api.github.com/repos/PyCQA/astroid/pulls/518","id":175715214,"html_url":"https://github.com/PyCQA/astroid/pull/518","diff_url":"https://github.com/PyCQA/astroid/pull/518.diff","patch_url":"https://github.com/PyCQA/astroid/pull/518.patch","issue_url":"https://api.github.com/repos/PyCQA/astroid/issues/518","number":518,"state":"open","locked":false,"title":"Fix call context propagation","user":{"login":"brycepg","id":441800,"avatar_url":"https://avatars0.githubusercontent.com/u/441800?v=4","gravatar_id":"","url":"https://api.github.com/users/brycepg","html_url":"https://github.com/brycepg","followers_url":"https://api.github.com/users/brycepg/followers","following_url":"https://api.github.com/users/brycepg/following{/other_user}","gists_url":"https://api.github.com/users/brycepg/gists{/gist_id}","starred_url":"https://api.github.com/users/brycepg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brycepg/subscriptions","organizations_url":"https://api.github.com/users/brycepg/orgs","repos_url":"https://api.github.com/users/brycepg/repos","events_url":"https://api.github.com/users/brycepg/events{/privacy}","received_events_url":"https://api.github.com/users/brycepg/received_events","type":"User","site_admin":false},"body":"Fix inference of call arguments\r\n\r\nClose #177\r\nClose #404 \r\nClose PyCQA/pylint#224\r\nClose PyCQA/pylint#1660\r\n","created_at":"2018-03-17T18:48:52Z","updated_at":"2018-03-27T06:55:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"484fd207ab7f5fe33c3bd97bbc310d05b5c89a8f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/PyCQA/astroid/pulls/518/commits","review_comments_url":"https://api.github.com/repos/PyCQA/astroid/pulls/518/comments","review_comment_url":"https://api.github.com/repos/PyCQA/astroid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PyCQA/astroid/issues/518/comments","statuses_url":"https://api.github.com/repos/PyCQA/astroid/statuses/4f6fbbd7cb448da305ffb5f5f9ef22653f359544","head":{"label":"brycepg:call-context-propagation","ref":"call-context-propagation","sha":"4f6fbbd7cb448da305ffb5f5f9ef22653f359544","user":{"login":"brycepg","id":441800,"avatar_url":"https://avatars0.githubusercontent.com/u/441800?v=4","gravatar_id":"","url":"https://api.github.com/users/brycepg","html_url":"https://github.com/brycepg","followers_url":"https://api.github.com/users/brycepg/followers","following_url":"https://api.github.com/users/brycepg/following{/other_user}","gists_url":"https://api.github.com/users/brycepg/gists{/gist_id}","starred_url":"https://api.github.com/users/brycepg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brycepg/subscriptions","organizations_url":"https://api.github.com/users/brycepg/orgs","repos_url":"https://api.github.com/users/brycepg/repos","events_url":"https://api.github.com/users/brycepg/events{/privacy}","received_events_url":"https://api.github.com/users/brycepg/received_events","type":"User","site_admin":false},"repo":{"id":108808235,"name":"astroid","full_name":"brycepg/astroid","owner":{"login":"brycepg","id":441800,"avatar_url":"https://avatars0.githubusercontent.com/u/441800?v=4","gravatar_id":"","url":"https://api.github.com/users/brycepg","html_url":"https://github.com/brycepg","followers_url":"https://api.github.com/users/brycepg/followers","following_url":"https://api.github.com/users/brycepg/following{/other_user}","gists_url":"https://api.github.com/users/brycepg/gists{/gist_id}","starred_url":"https://api.github.com/users/brycepg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brycepg/subscriptions","organizations_url":"https://api.github.com/users/brycepg/orgs","repos_url":"https://api.github.com/users/brycepg/repos","events_url":"https://api.github.com/users/brycepg/events{/privacy}","received_events_url":"https://api.github.com/users/brycepg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brycepg/astroid","description":"A common base representation of python source code for pylint and other projects","fork":true,"url":"https://api.github.com/repos/brycepg/astroid","forks_url":"https://api.github.com/repos/brycepg/astroid/forks","keys_url":"https://api.github.com/repos/brycepg/astroid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brycepg/astroid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brycepg/astroid/teams","hooks_url":"https://api.github.com/repos/brycepg/astroid/hooks","issue_events_url":"https://api.github.com/repos/brycepg/astroid/issues/events{/number}","events_url":"https://api.github.com/repos/brycepg/astroid/events","assignees_url":"https://api.github.com/repos/brycepg/astroid/assignees{/user}","branches_url":"https://api.github.com/repos/brycepg/astroid/branches{/branch}","tags_url":"https://api.github.com/repos/brycepg/astroid/tags","blobs_url":"https://api.github.com/repos/brycepg/astroid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brycepg/astroid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brycepg/astroid/git/refs{/sha}","trees_url":"https://api.github.com/repos/brycepg/astroid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brycepg/astroid/statuses/{sha}","languages_url":"https://api.github.com/repos/brycepg/astroid/languages","stargazers_url":"https://api.github.com/repos/brycepg/astroid/stargazers","contributors_url":"https://api.github.com/repos/brycepg/astroid/contributors","subscribers_url":"https://api.github.com/repos/brycepg/astroid/subscribers","subscription_url":"https://api.github.com/repos/brycepg/astroid/subscription","commits_url":"https://api.github.com/repos/brycepg/astroid/commits{/sha}","git_commits_url":"https://api.github.com/repos/brycepg/astroid/git/commits{/sha}","comments_url":"https://api.github.com/repos/brycepg/astroid/comments{/number}","issue_comment_url":"https://api.github.com/repos/brycepg/astroid/issues/comments{/number}","contents_url":"https://api.github.com/repos/brycepg/astroid/contents/{+path}","compare_url":"https://api.github.com/repos/brycepg/astroid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brycepg/astroid/merges","archive_url":"https://api.github.com/repos/brycepg/astroid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brycepg/astroid/downloads","issues_url":"https://api.github.com/repos/brycepg/astroid/issues{/number}","pulls_url":"https://api.github.com/repos/brycepg/astroid/pulls{/number}","milestones_url":"https://api.github.com/repos/brycepg/astroid/milestones{/number}","notifications_url":"https://api.github.com/repos/brycepg/astroid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brycepg/astroid/labels{/name}","releases_url":"https://api.github.com/repos/brycepg/astroid/releases{/id}","deployments_url":"https://api.github.com/repos/brycepg/astroid/deployments","created_at":"2017-10-30T06:00:39Z","updated_at":"2017-10-30T06:00:41Z","pushed_at":"2018-03-27T05:10:19Z","git_url":"git://github.com/brycepg/astroid.git","ssh_url":"git@github.com:brycepg/astroid.git","clone_url":"https://github.com/brycepg/astroid.git","svn_url":"https://github.com/brycepg/astroid","homepage":null,"size":12764,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PyCQA:master","ref":"master","sha":"ac3e0adee1ac0669592df9106c3b90288f2ea98f","user":{"login":"PyCQA","id":8749848,"avatar_url":"https://avatars0.githubusercontent.com/u/8749848?v=4","gravatar_id":"","url":"https://api.github.com/users/PyCQA","html_url":"https://github.com/PyCQA","followers_url":"https://api.github.com/users/PyCQA/followers","following_url":"https://api.github.com/users/PyCQA/following{/other_user}","gists_url":"https://api.github.com/users/PyCQA/gists{/gist_id}","starred_url":"https://api.github.com/users/PyCQA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PyCQA/subscriptions","organizations_url":"https://api.github.com/users/PyCQA/orgs","repos_url":"https://api.github.com/users/PyCQA/repos","events_url":"https://api.github.com/users/PyCQA/events{/privacy}","received_events_url":"https://api.github.com/users/PyCQA/received_events","type":"Organization","site_admin":false},"repo":{"id":47649855,"name":"astroid","full_name":"PyCQA/astroid","owner":{"login":"PyCQA","id":8749848,"avatar_url":"https://avatars0.githubusercontent.com/u/8749848?v=4","gravatar_id":"","url":"https://api.github.com/users/PyCQA","html_url":"https://github.com/PyCQA","followers_url":"https://api.github.com/users/PyCQA/followers","following_url":"https://api.github.com/users/PyCQA/following{/other_user}","gists_url":"https://api.github.com/users/PyCQA/gists{/gist_id}","starred_url":"https://api.github.com/users/PyCQA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PyCQA/subscriptions","organizations_url":"https://api.github.com/users/PyCQA/orgs","repos_url":"https://api.github.com/users/PyCQA/repos","events_url":"https://api.github.com/users/PyCQA/events{/privacy}","received_events_url":"https://api.github.com/users/PyCQA/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PyCQA/astroid","description":"A common base representation of python source code for pylint and other projects","fork":false,"url":"https://api.github.com/repos/PyCQA/astroid","forks_url":"https://api.github.com/repos/PyCQA/astroid/forks","keys_url":"https://api.github.com/repos/PyCQA/astroid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PyCQA/astroid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PyCQA/astroid/teams","hooks_url":"https://api.github.com/repos/PyCQA/astroid/hooks","issue_events_url":"https://api.github.com/repos/PyCQA/astroid/issues/events{/number}","events_url":"https://api.github.com/repos/PyCQA/astroid/events","assignees_url":"https://api.github.com/repos/PyCQA/astroid/assignees{/user}","branches_url":"https://api.github.com/repos/PyCQA/astroid/branches{/branch}","tags_url":"https://api.github.com/repos/PyCQA/astroid/tags","blobs_url":"https://api.github.com/repos/PyCQA/astroid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PyCQA/astroid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PyCQA/astroid/git/refs{/sha}","trees_url":"https://api.github.com/repos/PyCQA/astroid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PyCQA/astroid/statuses/{sha}","languages_url":"https://api.github.com/repos/PyCQA/astroid/languages","stargazers_url":"https://api.github.com/repos/PyCQA/astroid/stargazers","contributors_url":"https://api.github.com/repos/PyCQA/astroid/contributors","subscribers_url":"https://api.github.com/repos/PyCQA/astroid/subscribers","subscription_url":"https://api.github.com/repos/PyCQA/astroid/subscription","commits_url":"https://api.github.com/repos/PyCQA/astroid/commits{/sha}","git_commits_url":"https://api.github.com/repos/PyCQA/astroid/git/commits{/sha}","comments_url":"https://api.github.com/repos/PyCQA/astroid/comments{/number}","issue_comment_url":"https://api.github.com/repos/PyCQA/astroid/issues/comments{/number}","contents_url":"https://api.github.com/repos/PyCQA/astroid/contents/{+path}","compare_url":"https://api.github.com/repos/PyCQA/astroid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PyCQA/astroid/merges","archive_url":"https://api.github.com/repos/PyCQA/astroid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PyCQA/astroid/downloads","issues_url":"https://api.github.com/repos/PyCQA/astroid/issues{/number}","pulls_url":"https://api.github.com/repos/PyCQA/astroid/pulls{/number}","milestones_url":"https://api.github.com/repos/PyCQA/astroid/milestones{/number}","notifications_url":"https://api.github.com/repos/PyCQA/astroid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PyCQA/astroid/labels{/name}","releases_url":"https://api.github.com/repos/PyCQA/astroid/releases{/id}","deployments_url":"https://api.github.com/repos/PyCQA/astroid/deployments","created_at":"2015-12-08T21:12:00Z","updated_at":"2018-03-27T05:10:19Z","pushed_at":"2018-03-27T05:10:15Z","git_url":"git://github.com/PyCQA/astroid.git","ssh_url":"git@github.com:PyCQA/astroid.git","clone_url":"https://github.com/PyCQA/astroid.git","svn_url":"https://github.com/PyCQA/astroid","homepage":null,"size":12790,"stargazers_count":131,"watchers_count":131,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":65,"mirror_url":null,"archived":false,"open_issues_count":138,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1"},"forks":65,"open_issues":138,"watchers":131,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PyCQA/astroid/pulls/518"},"html":{"href":"https://github.com/PyCQA/astroid/pull/518"},"issue":{"href":"https://api.github.com/repos/PyCQA/astroid/issues/518"},"comments":{"href":"https://api.github.com/repos/PyCQA/astroid/issues/518/comments"},"review_comments":{"href":"https://api.github.com/repos/PyCQA/astroid/pulls/518/comments"},"review_comment":{"href":"https://api.github.com/repos/PyCQA/astroid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PyCQA/astroid/pulls/518/commits"},"statuses":{"href":"https://api.github.com/repos/PyCQA/astroid/statuses/4f6fbbd7cb448da305ffb5f5f9ef22653f359544"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"PCManticore"}}