{"action":"opened","number":2863,"pull_request":{"url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/pulls/2863","id":196334587,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2MzM0NTg3","html_url":"https://github.com/rust-lang-nursery/rust-clippy/pull/2863","diff_url":"https://github.com/rust-lang-nursery/rust-clippy/pull/2863.diff","patch_url":"https://github.com/rust-lang-nursery/rust-clippy/pull/2863.patch","issue_url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/issues/2863","number":2863,"state":"open","locked":false,"title":"Ensure a non-zero value is returned by clippy if compilation fails","user":{"login":"Fraser999","id":190532,"node_id":"MDQ6VXNlcjE5MDUzMg==","avatar_url":"https://avatars3.githubusercontent.com/u/190532?v=4","gravatar_id":"","url":"https://api.github.com/users/Fraser999","html_url":"https://github.com/Fraser999","followers_url":"https://api.github.com/users/Fraser999/followers","following_url":"https://api.github.com/users/Fraser999/following{/other_user}","gists_url":"https://api.github.com/users/Fraser999/gists{/gist_id}","starred_url":"https://api.github.com/users/Fraser999/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fraser999/subscriptions","organizations_url":"https://api.github.com/users/Fraser999/orgs","repos_url":"https://api.github.com/users/Fraser999/repos","events_url":"https://api.github.com/users/Fraser999/events{/privacy}","received_events_url":"https://api.github.com/users/Fraser999/received_events","type":"User","site_admin":false},"body":"https://github.com/rust-lang-nursery/rust-clippy/commit/b45fb35ec4cff21d027fa25dd31b5045867ccf03 changed the behaviour of clippy to always return 0 even if compilation failed; specifically the removal of the `rustc_driver::run()` call.\r\n\r\nThis PR may not be the best way to fix this issue as I've not worked with `rustc_driver`, but it at least logs the issue and appears to replicate the previous behaviour.\r\n\r\nI also haven't had time to create a regression test for this issue.  If someone wants to point me to where such a test should live and ideally a similar test, I can look at adding that too?","created_at":"2018-06-21T04:44:08Z","updated_at":"2018-06-21T04:44:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/pulls/2863/commits","review_comments_url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/pulls/2863/comments","review_comment_url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/issues/2863/comments","statuses_url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/statuses/5be00bcd1835145ff71ec3539c2bf849da0e37ed","head":{"label":"Fraser999:exit_code","ref":"exit_code","sha":"5be00bcd1835145ff71ec3539c2bf849da0e37ed","user":{"login":"Fraser999","id":190532,"node_id":"MDQ6VXNlcjE5MDUzMg==","avatar_url":"https://avatars3.githubusercontent.com/u/190532?v=4","gravatar_id":"","url":"https://api.github.com/users/Fraser999","html_url":"https://github.com/Fraser999","followers_url":"https://api.github.com/users/Fraser999/followers","following_url":"https://api.github.com/users/Fraser999/following{/other_user}","gists_url":"https://api.github.com/users/Fraser999/gists{/gist_id}","starred_url":"https://api.github.com/users/Fraser999/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fraser999/subscriptions","organizations_url":"https://api.github.com/users/Fraser999/orgs","repos_url":"https://api.github.com/users/Fraser999/repos","events_url":"https://api.github.com/users/Fraser999/events{/privacy}","received_events_url":"https://api.github.com/users/Fraser999/received_events","type":"User","site_admin":false},"repo":{"id":138118007,"node_id":"MDEwOlJlcG9zaXRvcnkxMzgxMTgwMDc=","name":"rust-clippy","full_name":"Fraser999/rust-clippy","owner":{"login":"Fraser999","id":190532,"node_id":"MDQ6VXNlcjE5MDUzMg==","avatar_url":"https://avatars3.githubusercontent.com/u/190532?v=4","gravatar_id":"","url":"https://api.github.com/users/Fraser999","html_url":"https://github.com/Fraser999","followers_url":"https://api.github.com/users/Fraser999/followers","following_url":"https://api.github.com/users/Fraser999/following{/other_user}","gists_url":"https://api.github.com/users/Fraser999/gists{/gist_id}","starred_url":"https://api.github.com/users/Fraser999/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fraser999/subscriptions","organizations_url":"https://api.github.com/users/Fraser999/orgs","repos_url":"https://api.github.com/users/Fraser999/repos","events_url":"https://api.github.com/users/Fraser999/events{/privacy}","received_events_url":"https://api.github.com/users/Fraser999/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Fraser999/rust-clippy","description":"A bunch of lints to catch common mistakes and improve your Rust code","fork":true,"url":"https://api.github.com/repos/Fraser999/rust-clippy","forks_url":"https://api.github.com/repos/Fraser999/rust-clippy/forks","keys_url":"https://api.github.com/repos/Fraser999/rust-clippy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Fraser999/rust-clippy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Fraser999/rust-clippy/teams","hooks_url":"https://api.github.com/repos/Fraser999/rust-clippy/hooks","issue_events_url":"https://api.github.com/repos/Fraser999/rust-clippy/issues/events{/number}","events_url":"https://api.github.com/repos/Fraser999/rust-clippy/events","assignees_url":"https://api.github.com/repos/Fraser999/rust-clippy/assignees{/user}","branches_url":"https://api.github.com/repos/Fraser999/rust-clippy/branches{/branch}","tags_url":"https://api.github.com/repos/Fraser999/rust-clippy/tags","blobs_url":"https://api.github.com/repos/Fraser999/rust-clippy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Fraser999/rust-clippy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Fraser999/rust-clippy/git/refs{/sha}","trees_url":"https://api.github.com/repos/Fraser999/rust-clippy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Fraser999/rust-clippy/statuses/{sha}","languages_url":"https://api.github.com/repos/Fraser999/rust-clippy/languages","stargazers_url":"https://api.github.com/repos/Fraser999/rust-clippy/stargazers","contributors_url":"https://api.github.com/repos/Fraser999/rust-clippy/contributors","subscribers_url":"https://api.github.com/repos/Fraser999/rust-clippy/subscribers","subscription_url":"https://api.github.com/repos/Fraser999/rust-clippy/subscription","commits_url":"https://api.github.com/repos/Fraser999/rust-clippy/commits{/sha}","git_commits_url":"https://api.github.com/repos/Fraser999/rust-clippy/git/commits{/sha}","comments_url":"https://api.github.com/repos/Fraser999/rust-clippy/comments{/number}","issue_comment_url":"https://api.github.com/repos/Fraser999/rust-clippy/issues/comments{/number}","contents_url":"https://api.github.com/repos/Fraser999/rust-clippy/contents/{+path}","compare_url":"https://api.github.com/repos/Fraser999/rust-clippy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Fraser999/rust-clippy/merges","archive_url":"https://api.github.com/repos/Fraser999/rust-clippy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Fraser999/rust-clippy/downloads","issues_url":"https://api.github.com/repos/Fraser999/rust-clippy/issues{/number}","pulls_url":"https://api.github.com/repos/Fraser999/rust-clippy/pulls{/number}","milestones_url":"https://api.github.com/repos/Fraser999/rust-clippy/milestones{/number}","notifications_url":"https://api.github.com/repos/Fraser999/rust-clippy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Fraser999/rust-clippy/labels{/name}","releases_url":"https://api.github.com/repos/Fraser999/rust-clippy/releases{/id}","deployments_url":"https://api.github.com/repos/Fraser999/rust-clippy/deployments","created_at":"2018-06-21T04:11:34Z","updated_at":"2018-06-21T04:11:37Z","pushed_at":"2018-06-21T04:20:26Z","git_url":"git://github.com/Fraser999/rust-clippy.git","ssh_url":"git@github.com:Fraser999/rust-clippy.git","clone_url":"https://github.com/Fraser999/rust-clippy.git","svn_url":"https://github.com/Fraser999/rust-clippy","homepage":"https://rust-lang-nursery.github.io/rust-clippy","size":9179,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang-nursery:master","ref":"master","sha":"cd90441a73e52166bad2bba80040b1d2ed59efee","user":{"login":"rust-lang-nursery","id":14631425,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0NjMxNDI1","avatar_url":"https://avatars1.githubusercontent.com/u/14631425?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang-nursery","html_url":"https://github.com/rust-lang-nursery","followers_url":"https://api.github.com/users/rust-lang-nursery/followers","following_url":"https://api.github.com/users/rust-lang-nursery/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang-nursery/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang-nursery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang-nursery/subscriptions","organizations_url":"https://api.github.com/users/rust-lang-nursery/orgs","repos_url":"https://api.github.com/users/rust-lang-nursery/repos","events_url":"https://api.github.com/users/rust-lang-nursery/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang-nursery/received_events","type":"Organization","site_admin":false},"repo":{"id":26850443,"node_id":"MDEwOlJlcG9zaXRvcnkyNjg1MDQ0Mw==","name":"rust-clippy","full_name":"rust-lang-nursery/rust-clippy","owner":{"login":"rust-lang-nursery","id":14631425,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0NjMxNDI1","avatar_url":"https://avatars1.githubusercontent.com/u/14631425?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang-nursery","html_url":"https://github.com/rust-lang-nursery","followers_url":"https://api.github.com/users/rust-lang-nursery/followers","following_url":"https://api.github.com/users/rust-lang-nursery/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang-nursery/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang-nursery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang-nursery/subscriptions","organizations_url":"https://api.github.com/users/rust-lang-nursery/orgs","repos_url":"https://api.github.com/users/rust-lang-nursery/repos","events_url":"https://api.github.com/users/rust-lang-nursery/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang-nursery/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang-nursery/rust-clippy","description":"A bunch of lints to catch common mistakes and improve your Rust code","fork":false,"url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy","forks_url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/forks","keys_url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/teams","hooks_url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/hooks","issue_events_url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/events","assignees_url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/tags","blobs_url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/languages","stargazers_url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/stargazers","contributors_url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/contributors","subscribers_url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/subscribers","subscription_url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/subscription","commits_url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/merges","archive_url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/downloads","issues_url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/deployments","created_at":"2014-11-19T07:49:21Z","updated_at":"2018-06-21T03:24:46Z","pushed_at":"2018-06-21T02:43:50Z","git_url":"git://github.com/rust-lang-nursery/rust-clippy.git","ssh_url":"git@github.com:rust-lang-nursery/rust-clippy.git","clone_url":"https://github.com/rust-lang-nursery/rust-clippy.git","svn_url":"https://github.com/rust-lang-nursery/rust-clippy","homepage":"https://rust-lang-nursery.github.io/rust-clippy","size":9179,"stargazers_count":2220,"watchers_count":2220,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":308,"mirror_url":null,"archived":false,"open_issues_count":716,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":308,"open_issues":716,"watchers":2220,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/pulls/2863"},"html":{"href":"https://github.com/rust-lang-nursery/rust-clippy/pull/2863"},"issue":{"href":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/issues/2863"},"comments":{"href":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/issues/2863/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/pulls/2863/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/pulls/2863/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/statuses/5be00bcd1835145ff71ec3539c2bf849da0e37ed"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":7,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"Fraser999"}}