{"action":"created","comment":{"url":"https://api.github.com/repos/apple/swift/pulls/comments/183790313","pull_request_review_id":114855910,"id":183790313,"diff_hunk":"@@ -300,18 +300,250 @@ getStringLiteralIfNotInterpolated(Parser &P, SourceLoc Loc, const Token &Tok,\n                                                  Segments.front().Length));\n }\n \n-bool Parser::parseSpecializeAttribute(swift::tok ClosingBrace, SourceLoc AtLoc,\n-                                      SourceLoc Loc, SpecializeAttr *&Attr) {\n-  assert(ClosingBrace == tok::r_paren || ClosingBrace == tok::r_square);\n-  SourceLoc lParenLoc = consumeToken();\n-  bool DiscardAttribute = false;\n-  StringRef AttrName = \"_specialize\";\n+AvailableAttr *Parser::parseExtendedAvailabilitySpecList(\n+    SourceLoc AtLoc, SourceLoc AttrStartLoc, StringRef Platform,\n+    StringRef AttrName, SourceLoc AttrLoc, bool &DiscardAttribute) {","path":"lib/Parse/ParseDecl.cpp","position":12,"original_position":12,"commit_id":"5a346204045025f718243dab505d47771927f838","original_commit_id":"5a346204045025f718243dab505d47771927f838","user":{"login":"ahoppen","id":4062178,"avatar_url":"https://avatars3.githubusercontent.com/u/4062178?v=4","gravatar_id":"","url":"https://api.github.com/users/ahoppen","html_url":"https://github.com/ahoppen","followers_url":"https://api.github.com/users/ahoppen/followers","following_url":"https://api.github.com/users/ahoppen/following{/other_user}","gists_url":"https://api.github.com/users/ahoppen/gists{/gist_id}","starred_url":"https://api.github.com/users/ahoppen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahoppen/subscriptions","organizations_url":"https://api.github.com/users/ahoppen/orgs","repos_url":"https://api.github.com/users/ahoppen/repos","events_url":"https://api.github.com/users/ahoppen/events{/privacy}","received_events_url":"https://api.github.com/users/ahoppen/received_events","type":"User","site_admin":false},"body":"OK, it does seem to work. I'm pretty sure I tried before and it didn't but maybe I'm mixing things up. It's not needed though since I keep the parsing logic for `)` outside of the refactored function.","created_at":"2018-04-24T16:03:58Z","updated_at":"2018-04-24T16:03:58Z","html_url":"https://github.com/apple/swift/pull/16117#discussion_r183790313","pull_request_url":"https://api.github.com/repos/apple/swift/pulls/16117","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/comments/183790313"},"html":{"href":"https://github.com/apple/swift/pull/16117#discussion_r183790313"},"pull_request":{"href":"https://api.github.com/repos/apple/swift/pulls/16117"}},"in_reply_to_id":183650003},"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/16117","id":183589114,"html_url":"https://github.com/apple/swift/pull/16117","diff_url":"https://github.com/apple/swift/pull/16117.diff","patch_url":"https://github.com/apple/swift/pull/16117.patch","issue_url":"https://api.github.com/repos/apple/swift/issues/16117","number":16117,"state":"open","locked":false,"title":"[libSyntax] Make parsing of attributes more structured","user":{"login":"ahoppen","id":4062178,"avatar_url":"https://avatars3.githubusercontent.com/u/4062178?v=4","gravatar_id":"","url":"https://api.github.com/users/ahoppen","html_url":"https://github.com/ahoppen","followers_url":"https://api.github.com/users/ahoppen/followers","following_url":"https://api.github.com/users/ahoppen/following{/other_user}","gists_url":"https://api.github.com/users/ahoppen/gists{/gist_id}","starred_url":"https://api.github.com/users/ahoppen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahoppen/subscriptions","organizations_url":"https://api.github.com/users/ahoppen/orgs","repos_url":"https://api.github.com/users/ahoppen/repos","events_url":"https://api.github.com/users/ahoppen/events{/privacy}","received_events_url":"https://api.github.com/users/ahoppen/received_events","type":"User","site_admin":false},"body":"Add significantly more structure to the way the attributes are parsed in libSyntax by no longer parsing the arguments as a `TokenList`. This way we can also parse `@_specialize` attributes correctly which can have a `GenericWhereClause` as one of its arguments.","created_at":"2018-04-24T00:08:57Z","updated_at":"2018-04-24T16:03:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"32e1963e812538dfd77ec1c6c24536c289ba9f0c","assignee":{"login":"rintaro","id":142081,"avatar_url":"https://avatars1.githubusercontent.com/u/142081?v=4","gravatar_id":"","url":"https://api.github.com/users/rintaro","html_url":"https://github.com/rintaro","followers_url":"https://api.github.com/users/rintaro/followers","following_url":"https://api.github.com/users/rintaro/following{/other_user}","gists_url":"https://api.github.com/users/rintaro/gists{/gist_id}","starred_url":"https://api.github.com/users/rintaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rintaro/subscriptions","organizations_url":"https://api.github.com/users/rintaro/orgs","repos_url":"https://api.github.com/users/rintaro/repos","events_url":"https://api.github.com/users/rintaro/events{/privacy}","received_events_url":"https://api.github.com/users/rintaro/received_events","type":"User","site_admin":false},"assignees":[{"login":"rintaro","id":142081,"avatar_url":"https://avatars1.githubusercontent.com/u/142081?v=4","gravatar_id":"","url":"https://api.github.com/users/rintaro","html_url":"https://github.com/rintaro","followers_url":"https://api.github.com/users/rintaro/followers","following_url":"https://api.github.com/users/rintaro/following{/other_user}","gists_url":"https://api.github.com/users/rintaro/gists{/gist_id}","starred_url":"https://api.github.com/users/rintaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rintaro/subscriptions","organizations_url":"https://api.github.com/users/rintaro/orgs","repos_url":"https://api.github.com/users/rintaro/repos","events_url":"https://api.github.com/users/rintaro/events{/privacy}","received_events_url":"https://api.github.com/users/rintaro/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"nkcsgexi","id":2191945,"avatar_url":"https://avatars0.githubusercontent.com/u/2191945?v=4","gravatar_id":"","url":"https://api.github.com/users/nkcsgexi","html_url":"https://github.com/nkcsgexi","followers_url":"https://api.github.com/users/nkcsgexi/followers","following_url":"https://api.github.com/users/nkcsgexi/following{/other_user}","gists_url":"https://api.github.com/users/nkcsgexi/gists{/gist_id}","starred_url":"https://api.github.com/users/nkcsgexi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nkcsgexi/subscriptions","organizations_url":"https://api.github.com/users/nkcsgexi/orgs","repos_url":"https://api.github.com/users/nkcsgexi/repos","events_url":"https://api.github.com/users/nkcsgexi/events{/privacy}","received_events_url":"https://api.github.com/users/nkcsgexi/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift/pulls/16117/commits","review_comments_url":"https://api.github.com/repos/apple/swift/pulls/16117/comments","review_comment_url":"https://api.github.com/repos/apple/swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift/issues/16117/comments","statuses_url":"https://api.github.com/repos/apple/swift/statuses/5a346204045025f718243dab505d47771927f838","head":{"label":"ahoppen:attributes","ref":"attributes","sha":"5a346204045025f718243dab505d47771927f838","user":{"login":"ahoppen","id":4062178,"avatar_url":"https://avatars3.githubusercontent.com/u/4062178?v=4","gravatar_id":"","url":"https://api.github.com/users/ahoppen","html_url":"https://github.com/ahoppen","followers_url":"https://api.github.com/users/ahoppen/followers","following_url":"https://api.github.com/users/ahoppen/following{/other_user}","gists_url":"https://api.github.com/users/ahoppen/gists{/gist_id}","starred_url":"https://api.github.com/users/ahoppen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahoppen/subscriptions","organizations_url":"https://api.github.com/users/ahoppen/orgs","repos_url":"https://api.github.com/users/ahoppen/repos","events_url":"https://api.github.com/users/ahoppen/events{/privacy}","received_events_url":"https://api.github.com/users/ahoppen/received_events","type":"User","site_admin":false},"repo":{"id":50429743,"name":"swift","full_name":"ahoppen/swift","owner":{"login":"ahoppen","id":4062178,"avatar_url":"https://avatars3.githubusercontent.com/u/4062178?v=4","gravatar_id":"","url":"https://api.github.com/users/ahoppen","html_url":"https://github.com/ahoppen","followers_url":"https://api.github.com/users/ahoppen/followers","following_url":"https://api.github.com/users/ahoppen/following{/other_user}","gists_url":"https://api.github.com/users/ahoppen/gists{/gist_id}","starred_url":"https://api.github.com/users/ahoppen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahoppen/subscriptions","organizations_url":"https://api.github.com/users/ahoppen/orgs","repos_url":"https://api.github.com/users/ahoppen/repos","events_url":"https://api.github.com/users/ahoppen/events{/privacy}","received_events_url":"https://api.github.com/users/ahoppen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ahoppen/swift","description":"The Swift Programming Language","fork":true,"url":"https://api.github.com/repos/ahoppen/swift","forks_url":"https://api.github.com/repos/ahoppen/swift/forks","keys_url":"https://api.github.com/repos/ahoppen/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ahoppen/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ahoppen/swift/teams","hooks_url":"https://api.github.com/repos/ahoppen/swift/hooks","issue_events_url":"https://api.github.com/repos/ahoppen/swift/issues/events{/number}","events_url":"https://api.github.com/repos/ahoppen/swift/events","assignees_url":"https://api.github.com/repos/ahoppen/swift/assignees{/user}","branches_url":"https://api.github.com/repos/ahoppen/swift/branches{/branch}","tags_url":"https://api.github.com/repos/ahoppen/swift/tags","blobs_url":"https://api.github.com/repos/ahoppen/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ahoppen/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ahoppen/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/ahoppen/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ahoppen/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/ahoppen/swift/languages","stargazers_url":"https://api.github.com/repos/ahoppen/swift/stargazers","contributors_url":"https://api.github.com/repos/ahoppen/swift/contributors","subscribers_url":"https://api.github.com/repos/ahoppen/swift/subscribers","subscription_url":"https://api.github.com/repos/ahoppen/swift/subscription","commits_url":"https://api.github.com/repos/ahoppen/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/ahoppen/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/ahoppen/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/ahoppen/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/ahoppen/swift/contents/{+path}","compare_url":"https://api.github.com/repos/ahoppen/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ahoppen/swift/merges","archive_url":"https://api.github.com/repos/ahoppen/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ahoppen/swift/downloads","issues_url":"https://api.github.com/repos/ahoppen/swift/issues{/number}","pulls_url":"https://api.github.com/repos/ahoppen/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/ahoppen/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/ahoppen/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ahoppen/swift/labels{/name}","releases_url":"https://api.github.com/repos/ahoppen/swift/releases{/id}","deployments_url":"https://api.github.com/repos/ahoppen/swift/deployments","created_at":"2016-01-26T13:18:54Z","updated_at":"2016-01-26T13:19:10Z","pushed_at":"2018-04-24T01:35:08Z","git_url":"git://github.com/ahoppen/swift.git","ssh_url":"git@github.com:ahoppen/swift.git","clone_url":"https://github.com/ahoppen/swift.git","svn_url":"https://github.com/ahoppen/swift","homepage":"https://swift.org/","size":275476,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"06c528d9a42430f706e2df0c9ee5f37511d0d91f","user":{"login":"apple","id":10639145,"avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44838949,"name":"swift","full_name":"apple/swift","owner":{"login":"apple","id":10639145,"avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/swift","description":"The Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift","forks_url":"https://api.github.com/repos/apple/swift/forks","keys_url":"https://api.github.com/repos/apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift/teams","hooks_url":"https://api.github.com/repos/apple/swift/hooks","issue_events_url":"https://api.github.com/repos/apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift/events","assignees_url":"https://api.github.com/repos/apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift/tags","blobs_url":"https://api.github.com/repos/apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift/languages","stargazers_url":"https://api.github.com/repos/apple/swift/stargazers","contributors_url":"https://api.github.com/repos/apple/swift/contributors","subscribers_url":"https://api.github.com/repos/apple/swift/subscribers","subscription_url":"https://api.github.com/repos/apple/swift/subscription","commits_url":"https://api.github.com/repos/apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift/merges","archive_url":"https://api.github.com/repos/apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift/downloads","issues_url":"https://api.github.com/repos/apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift/deployments","created_at":"2015-10-23T21:15:07Z","updated_at":"2018-04-24T14:57:33Z","pushed_at":"2018-04-24T15:50:38Z","git_url":"git://github.com/apple/swift.git","ssh_url":"git@github.com:apple/swift.git","clone_url":"https://github.com/apple/swift.git","svn_url":"https://github.com/apple/swift","homepage":"https://swift.org/","size":282178,"stargazers_count":43553,"watchers_count":43553,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6828,"mirror_url":null,"archived":false,"open_issues_count":306,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":6828,"open_issues":306,"watchers":43553,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/16117"},"html":{"href":"https://github.com/apple/swift/pull/16117"},"issue":{"href":"https://api.github.com/repos/apple/swift/issues/16117"},"comments":{"href":"https://api.github.com/repos/apple/swift/issues/16117/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift/pulls/16117/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift/pulls/16117/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift/statuses/5a346204045025f718243dab505d47771927f838"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"ahoppen"}}