{"push_id":2449321962,"size":61,"distinct_size":61,"ref":"refs/heads/master","head":"299a157b4abfddb0daa18e8ffe3fbc3f53925b61","before":"d431a82afdd90443e5f0584fea1745cc5b991d87","commits":[{"sha":"67ffb921aeaf85d4231d8be0e2b3bd0fd9c66e37","author":{"name":"Nikhil Benesch","email":"8468d930edb919b09d0b65aa1babaecbdcaf13cc@gmail.com"},"message":"teamcity-trigger: trigger stress builds on every release branch\n\nRework teamcity-trigger so that it can trigger the stress build on every\nactive release branch. (The actual branches are provided by TeamCity as\narguments to the command.)\n\nRelease note: None","distinct":true,"url":"https://api.github.com/repos/a-robinson/cockroach/commits/67ffb921aeaf85d4231d8be0e2b3bd0fd9c66e37"},{"sha":"ea64eb3fc12957e9d5df5ca4e337973ad7d130c9","author":{"name":"Justin Jaffray","email":"eed2bcb50b307b84ffae47fb7f0b80508b902de9@cockroachlabs.com"},"message":"sql: handle inverted index queries involving NULL\n\nI will plan on backporting this to 2.0.\n\nFixes #24244.\n\nRelease note (bug fix): inverted index queries involving NULL are now\nproperly handled.","distinct":true,"url":"https://api.github.com/repos/a-robinson/cockroach/commits/ea64eb3fc12957e9d5df5ca4e337973ad7d130c9"},{"sha":"2494cf59bff6ba73b19a04bfc80e200457977c1f","author":{"name":"Raphael 'kena' Poss","email":"7541742341763867a641aada528529ea551ae635@cockroachlabs.com"},"message":"sql: clean up / improve the diagram generation rules\n\nThis also ensures that the generated SVG data does not contain blank\nlines or lines starting with multiple spaces, which otherwise confuse\na Markdown parser.\n\nRelease note: none","distinct":true,"url":"https://api.github.com/repos/a-robinson/cockroach/commits/2494cf59bff6ba73b19a04bfc80e200457977c1f"},{"sha":"bc5014b03c17b28c89d65f22ccd6d8b65835c458","author":{"name":"Justin Jaffray","email":"eed2bcb50b307b84ffae47fb7f0b80508b902de9@cockroachlabs.com"},"message":"opt: fix merge skew with interning+generation\n\nAlso fix lint error.\n\nRelease note: None","distinct":true,"url":"https://api.github.com/repos/a-robinson/cockroach/commits/bc5014b03c17b28c89d65f22ccd6d8b65835c458"},{"sha":"17d6fca544adeebd2c43d00b0c8d48184a5a0aa0","author":{"name":"craig[bot]","email":"7a721f9f0277d772cdbc02c0e78ebd692006c77c@users.noreply.github.com"},"message":"Merge #24339\n\n24339: opt: fix merge skew with interning+generation r=rytaft a=justinj\n\nRelease note: None","distinct":true,"url":"https://api.github.com/repos/a-robinson/cockroach/commits/17d6fca544adeebd2c43d00b0c8d48184a5a0aa0"},{"sha":"5c7b7705f90a17469c71dada2d2dc155bac92978","author":{"name":"Masha Schneider","email":"e12f29ac8e500248214555bd98da71b34b8905e7@cockroachlabs.com"},"message":"storage: fix lease application race condition\n\nBefore this change a replica could recieve a lease request which was\nevaluated against one lease but applied against a different one. For\nexample if we had three leases A, B, and C with A being the current lease for a\nrange. If a replica then recieved lease requests B and C evaluated\nagainst A and B was a lease extension for A, both requests would succeed.\nThe check to apply lease C would only check to see if the sequence\nnumber associated with the previous lease was the same as the current\nlease which it would be because B was an extension and extensions don't\nincrement sequence numbers. However this check should fail because\nthe lease has been updated after the lease request was evaluated.\n\nWe're now adding the previous proposal timestamp to the\nReplicatedEvalResult which gets changed when a lease is extended so that\nwe can make sure that we're actually applying a least request against\nthe correct lease.\n\ncloses #23574\n\nRelease note: None","distinct":true,"url":"https://api.github.com/repos/a-robinson/cockroach/commits/5c7b7705f90a17469c71dada2d2dc155bac92978"},{"sha":"325e8fca57aed0cf453962a8e65afec4fd497aff","author":{"name":"Bram Gruneir","email":"c2c698b5c4e9a832f8becb94b691e2846d059921@cockroachlabs.com"},"message":"sql: Add one extra validation check before writing a table descriptor.\n\nIssue #21421 showed some extremely strange and broken table descriptors. This\nadds one extra validation check before writing all table descriptors to the db.\nWhile it does not address the root cause of what created the strange\ndescriptors, it will prevent anything like that from happening in the future.\n\nSadly is not possible to do a full validate call here, as checking the\ncross-table references at this point fails circumstances such as self-\nreferenential tables and some other similar situations.\n\nCloses #21421.\n\nRelease note: None","distinct":true,"url":"https://api.github.com/repos/a-robinson/cockroach/commits/325e8fca57aed0cf453962a8e65afec4fd497aff"},{"sha":"b1f1f20bfaba74199aa9bb87fe4e0e4307f8f561","author":{"name":"Masha Schneider","email":"e12f29ac8e500248214555bd98da71b34b8905e7@cockroachlabs.com"},"message":"Merge pull request #24228 from m-schneider/leaseracefix\n\nstorage: fix lease application race condition","distinct":true,"url":"https://api.github.com/repos/a-robinson/cockroach/commits/b1f1f20bfaba74199aa9bb87fe4e0e4307f8f561"},{"sha":"c668b200143dce46f44f52c76d8ca8a503c5cfba","author":{"name":"Nathan VanBenschoten","email":"b4a34fbdb14efbe352ced896f3acfafd868eb64f@gmail.com"},"message":"sqlbase: fix lint error about variable declaration\n\nI had a build fail with:\n\n```\nshould omit type error from declaration of var QueryCanceledError; it will be inferred from the right-hand side\n```\n\nI'm not sure why this wasn't caught earlier.\n\nRelease note: None","distinct":true,"url":"https://api.github.com/repos/a-robinson/cockroach/commits/c668b200143dce46f44f52c76d8ca8a503c5cfba"},{"sha":"0745fb939b6d033f55c4f06a3db3bc0dad275152","author":{"name":"Rebecca Taft","email":"cf1c6a908f9fa5514dea9705e3b322d10cff616e@cockroachlabs.com"},"message":"optbuilder: Fix bugs with subqueries, DISTINCT, and ORDER BY\n\nThis commit fixes several miscellaneous issues.\n\n1. Subqueries with aggregation and without a FROM clause were\n   causing the outer query to incorrectly act as if it were in\n   a grouping context. This commit fixes the issue by making\n   sure the scope of the subquery is different than the scope\n   of the outer query.\n2. Queries with DISTINCT and ORDER BY in which the ORDER BY\n   was ordering on an expression that was also part of the\n   SELECT list were failing. This commit fixes the issue by\n   reusing the existing projection for the ORDER BY column.\n3. Several redundant columns were previously being synthesized\n   for identical expressions. This commit fixes the issue by\n   reusing existing columns wherever possible.\n\nRelease note: None","distinct":true,"url":"https://api.github.com/repos/a-robinson/cockroach/commits/0745fb939b6d033f55c4f06a3db3bc0dad275152"},{"sha":"f260e0027684dd364241ae6f77d3a080f08a4bfc","author":{"name":"craig[bot]","email":"7a721f9f0277d772cdbc02c0e78ebd692006c77c@users.noreply.github.com"},"message":"Merge #24155\n\n24155: sql: Add one extra validation check before writing a table descriptor. r=andreimatei a=BramGruneir\n\nIssue #21421 showed some extremely strange and broken table descriptors. This\r\nadds one extra validation check before writing all table descriptors to the db.\r\nWhile it does not address the root cause of what created the strange\r\ndescriptors, it will prevent anything like that from happening in the future.\r\n\r\nSadly is not possible to do a full validate call here, as checking the\r\ncross-table references at this point fails circumstances such as self-\r\nreferenential tables and some other similar situations.\r\n\r\nCloses #21421.\r\n\r\nRelease note: None","distinct":true,"url":"https://api.github.com/repos/a-robinson/cockroach/commits/f260e0027684dd364241ae6f77d3a080f08a4bfc"},{"sha":"701f3701faa467e2c7844c763d916ab78947c4cf","author":{"name":"Andrew Kimball","email":"93f5b0eff4aa8069432e5aa46db497a274729656@cockroachlabs.com"},"message":"opt: Move files to new norm package\n\nThis is prep for the next commit which changes the files, making that\ncommit easier to review.\n\nRelease note: None","distinct":true,"url":"https://api.github.com/repos/a-robinson/cockroach/commits/701f3701faa467e2c7844c763d916ab78947c4cf"},{"sha":"232eba6a7cc71492be24e7e9c233cb5ebc7272b9","author":{"name":"Andrew Kimball","email":"93f5b0eff4aa8069432e5aa46db497a274729656@cockroachlabs.com"},"message":"opt: Create separate norm package for normalization rules\n\nThe idxconstraints package needs to use the normalizing factory to create\nremainder expressions. But idxcontraints needs to be used by explore rules.\nThis causes a package dependency cycle (xform => idxconstraints => xform).\nThis PR breaks the cycle by extracting the normalizing factory into its\nown package. Now the factory can be constructed and used independently\nfrom the optimizer.\n\nRelease note: None","distinct":true,"url":"https://api.github.com/repos/a-robinson/cockroach/commits/232eba6a7cc71492be24e7e9c233cb5ebc7272b9"},{"sha":"6fcb3db983c55bd5799a880038c222911d2e1dbf","author":{"name":"Nathan VanBenschoten","email":"b4a34fbdb14efbe352ced896f3acfafd868eb64f@gmail.com"},"message":"storage: don't require consensus for no-op requests\n\nFixes #23942.\n\nDuring evaluation, a request can result in having no effect for a variety\nof reasons. For instance, a PushTxnRequest may arrive at a transaction\nrecord to find that it is already ABORTED, in which case there's nothing\nfor it to do.\n\nBefore this change, we were still requiring that these empty results be\nproposed through Raft. This change fixes this by detecting empty results\nand bypassing consensus completely.\n\nRelease note (performance improvement): Write requests that result in\nno-ops are no longer proposed through Raft.","distinct":true,"url":"https://api.github.com/repos/a-robinson/cockroach/commits/6fcb3db983c55bd5799a880038c222911d2e1dbf"},{"sha":"feaee5c003f2cdfe44f8b8a3d64eb3eec7172efd","author":{"name":"Nathan VanBenschoten","email":"b4a34fbdb14efbe352ced896f3acfafd868eb64f@gmail.com"},"message":"storage: rename ProposalData.finishRaftApplication to finishApplication\n\nRelease note: None","distinct":true,"url":"https://api.github.com/repos/a-robinson/cockroach/commits/feaee5c003f2cdfe44f8b8a3d64eb3eec7172efd"},{"sha":"d761da2991e958dae5b7052241b7e2c1033532e3","author":{"name":"craig[bot]","email":"7a721f9f0277d772cdbc02c0e78ebd692006c77c@users.noreply.github.com"},"message":"Merge #24309 #24345\n\n24309: optbuilder: Fix bugs with subqueries, DISTINCT, and ORDER BY r=RaduBerinde a=rytaft\n\nThis commit fixes several miscellaneous issues.\r\n\r\n1. Subqueries with aggregation and without a `FROM` clause were\r\n   causing the outer query to incorrectly act as if it were in\r\n   a grouping context. This commit fixes the issue by making\r\n   sure the scope of the subquery is different than the scope\r\n   of the outer query.\r\n2. Queries with `DISTINCT` and `ORDER BY` in which the `ORDER BY`\r\n   was ordering on an expression that was also part of the\r\n   `SELECT` list were failing. This commit fixes the issue by\r\n   reusing the existing projection for the `ORDER BY` column.\r\n3. Several redundant columns were previously being synthesized\r\n   for identical expressions. This commit fixes the issue by\r\n   reusing existing columns wherever possible.\r\n\r\nRelease note: None\n\n24345: storage: don't require consensus for no-op requests r=tschottdorf a=nvanbenschoten\n\nFixes #23942.\r\n\r\nDuring evaluation, a request can result in having no effect for a variety\r\nof reasons. For instance, a PushTxnRequest may arrive at a transaction\r\nrecord to find that it is already ABORTED, in which case there's nothing\r\nfor it to do.\r\n\r\nBefore this change, we were still requiring that these empty results be\r\nproposed through Raft. This change fixes this by detecting empty results\r\nand bypassing consensus completely.\r\n\r\nRelease note (performance improvement): Write requests that result in\r\nno-ops are no longer proposed through Raft.","distinct":true,"url":"https://api.github.com/repos/a-robinson/cockroach/commits/d761da2991e958dae5b7052241b7e2c1033532e3"},{"sha":"bc2a27bb63cdaaeedac1e37b4ca0e6a0d54b6457","author":{"name":"Alfonso Subiotto Marqués","email":"ad5e8c807ec81ce4be6e8a830a15a28d4cc384f4@cockroachlabs.com"},"message":"distsql: add log.Scope to BenchmarkTableReader\n\nTo avoid stderr output messing with the benchmark output.\n\nRelease note: None","distinct":true,"url":"https://api.github.com/repos/a-robinson/cockroach/commits/bc2a27bb63cdaaeedac1e37b4ca0e6a0d54b6457"},{"sha":"c18ad15ad120f3f5167d716eabc9382840337c94","author":{"name":"Andy Kimball","email":"93f5b0eff4aa8069432e5aa46db497a274729656@cockroachlabs.com"},"message":"Merge pull request #24312 from andy-kimball/norm\n\nopt: Create separate norm package for normalization rules","distinct":true,"url":"https://api.github.com/repos/a-robinson/cockroach/commits/c18ad15ad120f3f5167d716eabc9382840337c94"},{"sha":"05e3b7a6c31cdb03e4838552a13471f203ff88da","author":{"name":"Nathan VanBenschoten","email":"b4a34fbdb14efbe352ced896f3acfafd868eb64f@gmail.com"},"message":"all: clean up ResponseCache and SequenceCache legacy\n\nWhat is now called the \"AbortSpan\" has had a long and twisted history.\nIt began life as the `ResponseCache`, which cached `BatchResponses` for\nall requests. #3100 migrated the structure to storing sequence numbers\nfor all txn operations and renamed it to the \"SequenceCache\" along the\nway. Its name was briefly changed to \"SequenceSpan\" in #3116, but that\nwas quickly reverted. #5626 simplified the structure even more by reducing\nit to only be written on failed intent resolution. In doing so, it renamed\nthe abstraction once more to the \"AbortCache\". Finally, #19401 performed\na rename without any associated logic changes to create what we have\ntoday - the \"AbortSpan\".\n\nThis series of renames has taken a toll on our codebase, and this PR\ndoes its best to clean up what they have left behind. The goal is for\nno one else to get confused about all of these different caches without\nrealizing that they are all part of the same lineage.\n\nThe only place that these names were not removed was in historical RFCs,\nas any modification there would obscure past decisions and quite literally\nrewrite history.\n\nRelease note: None","distinct":true,"url":"https://api.github.com/repos/a-robinson/cockroach/commits/05e3b7a6c31cdb03e4838552a13471f203ff88da"},{"sha":"7549f11c218ab67526c30b98c4d4b905353dd906","author":{"name":"Nathan VanBenschoten","email":"b4a34fbdb14efbe352ced896f3acfafd868eb64f@gmail.com"},"message":"storage: avoid AbortSpan operations when possible\n\nFixes #23943.\n\nBefore this change, requests would operate on the AbortSpan without\nchecking if any changes were actually needed. This prevented certain\noperations, like duplicate `ResolveIntentRequest`, from avoiding Raft.\nThis change fixes this by checking the AbortSpan before writing to it\nto detect when no changes are needed.\n\nRelease note: None","distinct":true,"url":"https://api.github.com/repos/a-robinson/cockroach/commits/7549f11c218ab67526c30b98c4d4b905353dd906"}]}
{"actor":{"display_login":"a-robinson"}}