{"action":"created","comment":{"url":"https://api.github.com/repos/metabase/metabase/pulls/comments/187780551","pull_request_review_id":119634132,"id":187780551,"diff_hunk":"@@ -300,14 +301,20 @@\n                              e)))\n       nil)))\n \n+(defn- trim-trailing-slash\n+  [s]\n+  (if (str/ends-with? s \"/\")","path":"src/metabase/automagic_dashboards/rules.clj","position":103,"original_position":43,"commit_id":"9d0666b2c87fd5d69c21f179cbc39398d09dc17f","original_commit_id":"cb268df4d0f4bf258e74cda292d7655235766ff3","user":{"login":"sbelak","id":178038,"avatar_url":"https://avatars2.githubusercontent.com/u/178038?v=4","gravatar_id":"","url":"https://api.github.com/users/sbelak","html_url":"https://github.com/sbelak","followers_url":"https://api.github.com/users/sbelak/followers","following_url":"https://api.github.com/users/sbelak/following{/other_user}","gists_url":"https://api.github.com/users/sbelak/gists{/gist_id}","starred_url":"https://api.github.com/users/sbelak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbelak/subscriptions","organizations_url":"https://api.github.com/users/sbelak/orgs","repos_url":"https://api.github.com/users/sbelak/repos","events_url":"https://api.github.com/users/sbelak/events{/privacy}","received_events_url":"https://api.github.com/users/sbelak/received_events","type":"User","site_admin":false},"body":"Part of the changes in this PR is also, that we always throw rather than return nil.","created_at":"2018-05-12T18:58:34Z","updated_at":"2018-05-12T18:58:34Z","html_url":"https://github.com/metabase/metabase/pull/7631#discussion_r187780551","pull_request_url":"https://api.github.com/repos/metabase/metabase/pulls/7631","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/metabase/metabase/pulls/comments/187780551"},"html":{"href":"https://github.com/metabase/metabase/pull/7631#discussion_r187780551"},"pull_request":{"href":"https://api.github.com/repos/metabase/metabase/pulls/7631"}},"in_reply_to_id":187776110},"pull_request":{"url":"https://api.github.com/repos/metabase/metabase/pulls/7631","id":187619686,"html_url":"https://github.com/metabase/metabase/pull/7631","diff_url":"https://github.com/metabase/metabase/pull/7631.diff","patch_url":"https://github.com/metabase/metabase/pull/7631.patch","issue_url":"https://api.github.com/repos/metabase/metabase/issues/7631","number":7631,"state":"closed","locked":false,"title":"Fix rule loading","user":{"login":"sbelak","id":178038,"avatar_url":"https://avatars2.githubusercontent.com/u/178038?v=4","gravatar_id":"","url":"https://api.github.com/users/sbelak","html_url":"https://github.com/sbelak","followers_url":"https://api.github.com/users/sbelak/followers","following_url":"https://api.github.com/users/sbelak/following{/other_user}","gists_url":"https://api.github.com/users/sbelak/gists{/gist_id}","starred_url":"https://api.github.com/users/sbelak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbelak/subscriptions","organizations_url":"https://api.github.com/users/sbelak/orgs","repos_url":"https://api.github.com/users/sbelak/repos","events_url":"https://api.github.com/users/sbelak/events{/privacy}","received_events_url":"https://api.github.com/users/sbelak/received_events","type":"User","site_admin":false},"body":"Fixes broken xrays in 29.2 and adds some additional validation and circuit breakers. /api/automagic-dashboards/* will now 500 instead of returning nil if no dashboard can be made.\r\n\r\nRegression happened because for some unfathomable reason behaviour of `Path/getFileName` for directories changed between Java 8 and 10. In the former it returns directory name with trailing slash, in the latter without. This patch trims the slash if present, making code work in both versions.","created_at":"2018-05-12T12:43:20Z","updated_at":"2018-05-12T18:58:34Z","closed_at":"2018-05-12T18:24:31Z","merged_at":"2018-05-12T18:24:31Z","merge_commit_sha":"0de4585407432f8c497624084b87c6090d6b8972","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/metabase/metabase/milestones/65","html_url":"https://github.com/metabase/metabase/milestone/65","labels_url":"https://api.github.com/repos/metabase/metabase/milestones/65/labels","id":3341348,"number":65,"title":"0.29.3","description":"","creator":{"login":"salsakran","id":107439,"avatar_url":"https://avatars0.githubusercontent.com/u/107439?v=4","gravatar_id":"","url":"https://api.github.com/users/salsakran","html_url":"https://github.com/salsakran","followers_url":"https://api.github.com/users/salsakran/followers","following_url":"https://api.github.com/users/salsakran/following{/other_user}","gists_url":"https://api.github.com/users/salsakran/gists{/gist_id}","starred_url":"https://api.github.com/users/salsakran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/salsakran/subscriptions","organizations_url":"https://api.github.com/users/salsakran/orgs","repos_url":"https://api.github.com/users/salsakran/repos","events_url":"https://api.github.com/users/salsakran/events{/privacy}","received_events_url":"https://api.github.com/users/salsakran/received_events","type":"User","site_admin":false},"open_issues":0,"closed_issues":1,"state":"closed","created_at":"2018-05-12T18:15:31Z","updated_at":"2018-05-12T18:29:12Z","due_on":null,"closed_at":"2018-05-12T18:29:12Z"},"commits_url":"https://api.github.com/repos/metabase/metabase/pulls/7631/commits","review_comments_url":"https://api.github.com/repos/metabase/metabase/pulls/7631/comments","review_comment_url":"https://api.github.com/repos/metabase/metabase/pulls/comments{/number}","comments_url":"https://api.github.com/repos/metabase/metabase/issues/7631/comments","statuses_url":"https://api.github.com/repos/metabase/metabase/statuses/9d0666b2c87fd5d69c21f179cbc39398d09dc17f","head":{"label":"metabase:fix-rule-loading","ref":"fix-rule-loading","sha":"9d0666b2c87fd5d69c21f179cbc39398d09dc17f","user":{"login":"metabase","id":10520629,"avatar_url":"https://avatars1.githubusercontent.com/u/10520629?v=4","gravatar_id":"","url":"https://api.github.com/users/metabase","html_url":"https://github.com/metabase","followers_url":"https://api.github.com/users/metabase/followers","following_url":"https://api.github.com/users/metabase/following{/other_user}","gists_url":"https://api.github.com/users/metabase/gists{/gist_id}","starred_url":"https://api.github.com/users/metabase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metabase/subscriptions","organizations_url":"https://api.github.com/users/metabase/orgs","repos_url":"https://api.github.com/users/metabase/repos","events_url":"https://api.github.com/users/metabase/events{/privacy}","received_events_url":"https://api.github.com/users/metabase/received_events","type":"Organization","site_admin":false},"repo":{"id":30203935,"name":"metabase","full_name":"metabase/metabase","owner":{"login":"metabase","id":10520629,"avatar_url":"https://avatars1.githubusercontent.com/u/10520629?v=4","gravatar_id":"","url":"https://api.github.com/users/metabase","html_url":"https://github.com/metabase","followers_url":"https://api.github.com/users/metabase/followers","following_url":"https://api.github.com/users/metabase/following{/other_user}","gists_url":"https://api.github.com/users/metabase/gists{/gist_id}","starred_url":"https://api.github.com/users/metabase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metabase/subscriptions","organizations_url":"https://api.github.com/users/metabase/orgs","repos_url":"https://api.github.com/users/metabase/repos","events_url":"https://api.github.com/users/metabase/events{/privacy}","received_events_url":"https://api.github.com/users/metabase/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/metabase/metabase","description":"The simplest, fastest way to get business intelligence and analytics  to everyone in your company :yum:","fork":false,"url":"https://api.github.com/repos/metabase/metabase","forks_url":"https://api.github.com/repos/metabase/metabase/forks","keys_url":"https://api.github.com/repos/metabase/metabase/keys{/key_id}","collaborators_url":"https://api.github.com/repos/metabase/metabase/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/metabase/metabase/teams","hooks_url":"https://api.github.com/repos/metabase/metabase/hooks","issue_events_url":"https://api.github.com/repos/metabase/metabase/issues/events{/number}","events_url":"https://api.github.com/repos/metabase/metabase/events","assignees_url":"https://api.github.com/repos/metabase/metabase/assignees{/user}","branches_url":"https://api.github.com/repos/metabase/metabase/branches{/branch}","tags_url":"https://api.github.com/repos/metabase/metabase/tags","blobs_url":"https://api.github.com/repos/metabase/metabase/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/metabase/metabase/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/metabase/metabase/git/refs{/sha}","trees_url":"https://api.github.com/repos/metabase/metabase/git/trees{/sha}","statuses_url":"https://api.github.com/repos/metabase/metabase/statuses/{sha}","languages_url":"https://api.github.com/repos/metabase/metabase/languages","stargazers_url":"https://api.github.com/repos/metabase/metabase/stargazers","contributors_url":"https://api.github.com/repos/metabase/metabase/contributors","subscribers_url":"https://api.github.com/repos/metabase/metabase/subscribers","subscription_url":"https://api.github.com/repos/metabase/metabase/subscription","commits_url":"https://api.github.com/repos/metabase/metabase/commits{/sha}","git_commits_url":"https://api.github.com/repos/metabase/metabase/git/commits{/sha}","comments_url":"https://api.github.com/repos/metabase/metabase/comments{/number}","issue_comment_url":"https://api.github.com/repos/metabase/metabase/issues/comments{/number}","contents_url":"https://api.github.com/repos/metabase/metabase/contents/{+path}","compare_url":"https://api.github.com/repos/metabase/metabase/compare/{base}...{head}","merges_url":"https://api.github.com/repos/metabase/metabase/merges","archive_url":"https://api.github.com/repos/metabase/metabase/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/metabase/metabase/downloads","issues_url":"https://api.github.com/repos/metabase/metabase/issues{/number}","pulls_url":"https://api.github.com/repos/metabase/metabase/pulls{/number}","milestones_url":"https://api.github.com/repos/metabase/metabase/milestones{/number}","notifications_url":"https://api.github.com/repos/metabase/metabase/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/metabase/metabase/labels{/name}","releases_url":"https://api.github.com/repos/metabase/metabase/releases{/id}","deployments_url":"https://api.github.com/repos/metabase/metabase/deployments","created_at":"2015-02-02T19:25:47Z","updated_at":"2018-05-12T11:32:13Z","pushed_at":"2018-05-12T18:25:09Z","git_url":"git://github.com/metabase/metabase.git","ssh_url":"git@github.com:metabase/metabase.git","clone_url":"https://github.com/metabase/metabase.git","svn_url":"https://github.com/metabase/metabase","homepage":"https://metabase.com","size":71921,"stargazers_count":9803,"watchers_count":9803,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1212,"mirror_url":null,"archived":false,"open_issues_count":1700,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1212,"open_issues":1700,"watchers":9803,"default_branch":"master"}},"base":{"label":"metabase:release-0.29.3","ref":"release-0.29.3","sha":"746b2c1f4b77e2dff85a5ebdb79ee6c1b198d493","user":{"login":"metabase","id":10520629,"avatar_url":"https://avatars1.githubusercontent.com/u/10520629?v=4","gravatar_id":"","url":"https://api.github.com/users/metabase","html_url":"https://github.com/metabase","followers_url":"https://api.github.com/users/metabase/followers","following_url":"https://api.github.com/users/metabase/following{/other_user}","gists_url":"https://api.github.com/users/metabase/gists{/gist_id}","starred_url":"https://api.github.com/users/metabase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metabase/subscriptions","organizations_url":"https://api.github.com/users/metabase/orgs","repos_url":"https://api.github.com/users/metabase/repos","events_url":"https://api.github.com/users/metabase/events{/privacy}","received_events_url":"https://api.github.com/users/metabase/received_events","type":"Organization","site_admin":false},"repo":{"id":30203935,"name":"metabase","full_name":"metabase/metabase","owner":{"login":"metabase","id":10520629,"avatar_url":"https://avatars1.githubusercontent.com/u/10520629?v=4","gravatar_id":"","url":"https://api.github.com/users/metabase","html_url":"https://github.com/metabase","followers_url":"https://api.github.com/users/metabase/followers","following_url":"https://api.github.com/users/metabase/following{/other_user}","gists_url":"https://api.github.com/users/metabase/gists{/gist_id}","starred_url":"https://api.github.com/users/metabase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metabase/subscriptions","organizations_url":"https://api.github.com/users/metabase/orgs","repos_url":"https://api.github.com/users/metabase/repos","events_url":"https://api.github.com/users/metabase/events{/privacy}","received_events_url":"https://api.github.com/users/metabase/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/metabase/metabase","description":"The simplest, fastest way to get business intelligence and analytics  to everyone in your company :yum:","fork":false,"url":"https://api.github.com/repos/metabase/metabase","forks_url":"https://api.github.com/repos/metabase/metabase/forks","keys_url":"https://api.github.com/repos/metabase/metabase/keys{/key_id}","collaborators_url":"https://api.github.com/repos/metabase/metabase/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/metabase/metabase/teams","hooks_url":"https://api.github.com/repos/metabase/metabase/hooks","issue_events_url":"https://api.github.com/repos/metabase/metabase/issues/events{/number}","events_url":"https://api.github.com/repos/metabase/metabase/events","assignees_url":"https://api.github.com/repos/metabase/metabase/assignees{/user}","branches_url":"https://api.github.com/repos/metabase/metabase/branches{/branch}","tags_url":"https://api.github.com/repos/metabase/metabase/tags","blobs_url":"https://api.github.com/repos/metabase/metabase/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/metabase/metabase/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/metabase/metabase/git/refs{/sha}","trees_url":"https://api.github.com/repos/metabase/metabase/git/trees{/sha}","statuses_url":"https://api.github.com/repos/metabase/metabase/statuses/{sha}","languages_url":"https://api.github.com/repos/metabase/metabase/languages","stargazers_url":"https://api.github.com/repos/metabase/metabase/stargazers","contributors_url":"https://api.github.com/repos/metabase/metabase/contributors","subscribers_url":"https://api.github.com/repos/metabase/metabase/subscribers","subscription_url":"https://api.github.com/repos/metabase/metabase/subscription","commits_url":"https://api.github.com/repos/metabase/metabase/commits{/sha}","git_commits_url":"https://api.github.com/repos/metabase/metabase/git/commits{/sha}","comments_url":"https://api.github.com/repos/metabase/metabase/comments{/number}","issue_comment_url":"https://api.github.com/repos/metabase/metabase/issues/comments{/number}","contents_url":"https://api.github.com/repos/metabase/metabase/contents/{+path}","compare_url":"https://api.github.com/repos/metabase/metabase/compare/{base}...{head}","merges_url":"https://api.github.com/repos/metabase/metabase/merges","archive_url":"https://api.github.com/repos/metabase/metabase/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/metabase/metabase/downloads","issues_url":"https://api.github.com/repos/metabase/metabase/issues{/number}","pulls_url":"https://api.github.com/repos/metabase/metabase/pulls{/number}","milestones_url":"https://api.github.com/repos/metabase/metabase/milestones{/number}","notifications_url":"https://api.github.com/repos/metabase/metabase/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/metabase/metabase/labels{/name}","releases_url":"https://api.github.com/repos/metabase/metabase/releases{/id}","deployments_url":"https://api.github.com/repos/metabase/metabase/deployments","created_at":"2015-02-02T19:25:47Z","updated_at":"2018-05-12T11:32:13Z","pushed_at":"2018-05-12T18:25:09Z","git_url":"git://github.com/metabase/metabase.git","ssh_url":"git@github.com:metabase/metabase.git","clone_url":"https://github.com/metabase/metabase.git","svn_url":"https://github.com/metabase/metabase","homepage":"https://metabase.com","size":71921,"stargazers_count":9803,"watchers_count":9803,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1212,"mirror_url":null,"archived":false,"open_issues_count":1700,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1212,"open_issues":1700,"watchers":9803,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/metabase/metabase/pulls/7631"},"html":{"href":"https://github.com/metabase/metabase/pull/7631"},"issue":{"href":"https://api.github.com/repos/metabase/metabase/issues/7631"},"comments":{"href":"https://api.github.com/repos/metabase/metabase/issues/7631/comments"},"review_comments":{"href":"https://api.github.com/repos/metabase/metabase/pulls/7631/comments"},"review_comment":{"href":"https://api.github.com/repos/metabase/metabase/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/metabase/metabase/pulls/7631/commits"},"statuses":{"href":"https://api.github.com/repos/metabase/metabase/statuses/9d0666b2c87fd5d69c21f179cbc39398d09dc17f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"sbelak"}}