{"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/jetty.project/pulls/comments/236991561","pull_request_review_id":179182126,"id":236991561,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjk5MTU2MQ==","diff_hunk":"@@ -0,0 +1,247 @@\n+//\n+//  ========================================================================\n+//  Copyright (c) 1995-2018 Mort Bay Consulting Pty. Ltd.\n+//  ------------------------------------------------------------------------\n+//  All rights reserved. This program and the accompanying materials\n+//  are made available under the terms of the Eclipse Public License v1.0\n+//  and Apache License v2.0 which accompanies this distribution.\n+//\n+//      The Eclipse Public License is available at\n+//      http://www.eclipse.org/legal/epl-v10.html\n+//\n+//      The Apache License v2.0 is available at\n+//      http://www.opensource.org/licenses/apache2.0.php\n+//\n+//  You may elect to redistribute this code under either of these licenses.\n+//  ========================================================================\n+//\n+\n+package org.eclipse.jetty.server;\n+\n+import java.io.IOException;\n+import java.io.OutputStream;\n+import java.io.OutputStreamWriter;\n+import java.io.Writer;\n+import java.util.TimeZone;\n+\n+import org.eclipse.jetty.util.RolloverFileOutputStream;\n+import org.eclipse.jetty.util.component.AbstractLifeCycle;\n+import org.eclipse.jetty.util.log.Log;\n+import org.eclipse.jetty.util.log.Logger;\n+\n+/**\n+ * Writer which outputs pre-formatted request log strings to a file using {@link RolloverFileOutputStream}.\n+ */\n+public class RequestLogWriter extends AbstractLifeCycle implements RequestLog.Writer\n+{\n+    private static final Logger LOG = Log.getLogger(RequestLogWriter.class);\n+\n+    private String _filename;\n+    private boolean _append;\n+    private int _retainDays;\n+    private boolean _closeOut;\n+    private String _timeZone = \"GMT\";\n+    private String _filenameDateFormat = null;\n+    private transient OutputStream _out;\n+    private transient OutputStream _fileOut;\n+    private transient Writer _writer;\n+\n+    public RequestLogWriter()\n+    {\n+        this(null);\n+    }\n+\n+    public RequestLogWriter(String filename)\n+    {\n+        setAppend(true);\n+        setRetainDays(31);\n+\n+        if (filename != null)\n+            setFilename(filename);\n+    }\n+\n+    /**\n+     * Set the output file name of the request log.\n+     * The file name may be in the format expected by\n+     * {@link RolloverFileOutputStream}.\n+     *\n+     * @param filename file name of the request log\n+     */\n+    public void setFilename(String filename)\n+    {\n+        if (filename != null)\n+        {\n+            filename = filename.trim();\n+            if (filename.length() == 0)\n+                filename = null;\n+        }\n+        _filename = filename;\n+    }\n+\n+    /**\n+     * Retrieve the output file name of the request log.\n+     *\n+     * @return file name of the request log\n+     */\n+    public String getFileName()","path":"jetty-server/src/main/java/org/eclipse/jetty/server/RequestLogWriter.java","position":86,"original_position":86,"commit_id":"8aa3655c5525434f4360b6dc41030b1c2ae2c9b2","original_commit_id":"8aa3655c5525434f4360b6dc41030b1c2ae2c9b2","user":{"login":"gregw","id":70829,"node_id":"MDQ6VXNlcjcwODI5","avatar_url":"https://avatars2.githubusercontent.com/u/70829?v=4","gravatar_id":"","url":"https://api.github.com/users/gregw","html_url":"https://github.com/gregw","followers_url":"https://api.github.com/users/gregw/followers","following_url":"https://api.github.com/users/gregw/following{/other_user}","gists_url":"https://api.github.com/users/gregw/gists{/gist_id}","starred_url":"https://api.github.com/users/gregw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregw/subscriptions","organizations_url":"https://api.github.com/users/gregw/orgs","repos_url":"https://api.github.com/users/gregw/repos","events_url":"https://api.github.com/users/gregw/events{/privacy}","received_events_url":"https://api.github.com/users/gregw/received_events","type":"User","site_admin":false},"body":"make a managed attribute","created_at":"2018-11-28T09:02:48Z","updated_at":"2018-11-28T09:06:32Z","html_url":"https://github.com/eclipse/jetty.project/pull/3144#discussion_r236991561","pull_request_url":"https://api.github.com/repos/eclipse/jetty.project/pulls/3144","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/eclipse/jetty.project/pulls/comments/236991561"},"html":{"href":"https://github.com/eclipse/jetty.project/pull/3144#discussion_r236991561"},"pull_request":{"href":"https://api.github.com/repos/eclipse/jetty.project/pulls/3144"}}},"pull_request":{"url":"https://api.github.com/repos/eclipse/jetty.project/pulls/3144","id":233310264,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzMzEwMjY0","html_url":"https://github.com/eclipse/jetty.project/pull/3144","diff_url":"https://github.com/eclipse/jetty.project/pull/3144.diff","patch_url":"https://github.com/eclipse/jetty.project/pull/3144.patch","issue_url":"https://api.github.com/repos/eclipse/jetty.project/issues/3144","number":3144,"state":"open","locked":false,"title":"Issue #113 - CustomRequestLog","user":{"login":"lachlan-roberts","id":19250643,"node_id":"MDQ6VXNlcjE5MjUwNjQz","avatar_url":"https://avatars0.githubusercontent.com/u/19250643?v=4","gravatar_id":"","url":"https://api.github.com/users/lachlan-roberts","html_url":"https://github.com/lachlan-roberts","followers_url":"https://api.github.com/users/lachlan-roberts/followers","following_url":"https://api.github.com/users/lachlan-roberts/following{/other_user}","gists_url":"https://api.github.com/users/lachlan-roberts/gists{/gist_id}","starred_url":"https://api.github.com/users/lachlan-roberts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lachlan-roberts/subscriptions","organizations_url":"https://api.github.com/users/lachlan-roberts/orgs","repos_url":"https://api.github.com/users/lachlan-roberts/repos","events_url":"https://api.github.com/users/lachlan-roberts/events{/privacy}","received_events_url":"https://api.github.com/users/lachlan-roberts/received_events","type":"User","site_admin":false},"body":"#113","created_at":"2018-11-24T09:32:35Z","updated_at":"2018-11-28T09:06:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"40a0cc4100a254083bf79a346206535ec5aef7d9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/jetty.project/pulls/3144/commits","review_comments_url":"https://api.github.com/repos/eclipse/jetty.project/pulls/3144/comments","review_comment_url":"https://api.github.com/repos/eclipse/jetty.project/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/jetty.project/issues/3144/comments","statuses_url":"https://api.github.com/repos/eclipse/jetty.project/statuses/8aa3655c5525434f4360b6dc41030b1c2ae2c9b2","head":{"label":"lachlan-roberts:jetty-9.4.x","ref":"jetty-9.4.x","sha":"8aa3655c5525434f4360b6dc41030b1c2ae2c9b2","user":{"login":"lachlan-roberts","id":19250643,"node_id":"MDQ6VXNlcjE5MjUwNjQz","avatar_url":"https://avatars0.githubusercontent.com/u/19250643?v=4","gravatar_id":"","url":"https://api.github.com/users/lachlan-roberts","html_url":"https://github.com/lachlan-roberts","followers_url":"https://api.github.com/users/lachlan-roberts/followers","following_url":"https://api.github.com/users/lachlan-roberts/following{/other_user}","gists_url":"https://api.github.com/users/lachlan-roberts/gists{/gist_id}","starred_url":"https://api.github.com/users/lachlan-roberts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lachlan-roberts/subscriptions","organizations_url":"https://api.github.com/users/lachlan-roberts/orgs","repos_url":"https://api.github.com/users/lachlan-roberts/repos","events_url":"https://api.github.com/users/lachlan-roberts/events{/privacy}","received_events_url":"https://api.github.com/users/lachlan-roberts/received_events","type":"User","site_admin":false},"repo":{"id":123038728,"node_id":"MDEwOlJlcG9zaXRvcnkxMjMwMzg3Mjg=","name":"jetty.project","full_name":"lachlan-roberts/jetty.project","private":false,"owner":{"login":"lachlan-roberts","id":19250643,"node_id":"MDQ6VXNlcjE5MjUwNjQz","avatar_url":"https://avatars0.githubusercontent.com/u/19250643?v=4","gravatar_id":"","url":"https://api.github.com/users/lachlan-roberts","html_url":"https://github.com/lachlan-roberts","followers_url":"https://api.github.com/users/lachlan-roberts/followers","following_url":"https://api.github.com/users/lachlan-roberts/following{/other_user}","gists_url":"https://api.github.com/users/lachlan-roberts/gists{/gist_id}","starred_url":"https://api.github.com/users/lachlan-roberts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lachlan-roberts/subscriptions","organizations_url":"https://api.github.com/users/lachlan-roberts/orgs","repos_url":"https://api.github.com/users/lachlan-roberts/repos","events_url":"https://api.github.com/users/lachlan-roberts/events{/privacy}","received_events_url":"https://api.github.com/users/lachlan-roberts/received_events","type":"User","site_admin":false},"html_url":"https://github.com/lachlan-roberts/jetty.project","description":"Eclipse Jetty® - Web Container & Clients - supports HTTP/2, HTTP/1.1, HTTP/1.0, websocket, servlets, and more","fork":true,"url":"https://api.github.com/repos/lachlan-roberts/jetty.project","forks_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/forks","keys_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/teams","hooks_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/hooks","issue_events_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/issues/events{/number}","events_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/events","assignees_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/assignees{/user}","branches_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/branches{/branch}","tags_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/tags","blobs_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/git/refs{/sha}","trees_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/statuses/{sha}","languages_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/languages","stargazers_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/stargazers","contributors_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/contributors","subscribers_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/subscribers","subscription_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/subscription","commits_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/commits{/sha}","git_commits_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/git/commits{/sha}","comments_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/comments{/number}","issue_comment_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/issues/comments{/number}","contents_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/contents/{+path}","compare_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/merges","archive_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/downloads","issues_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/issues{/number}","pulls_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/pulls{/number}","milestones_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/milestones{/number}","notifications_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/labels{/name}","releases_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/releases{/id}","deployments_url":"https://api.github.com/repos/lachlan-roberts/jetty.project/deployments","created_at":"2018-02-26T22:23:22Z","updated_at":"2018-11-28T08:27:18Z","pushed_at":"2018-11-28T08:27:15Z","git_url":"git://github.com/lachlan-roberts/jetty.project.git","ssh_url":"git@github.com:lachlan-roberts/jetty.project.git","clone_url":"https://github.com/lachlan-roberts/jetty.project.git","svn_url":"https://github.com/lachlan-roberts/jetty.project","homepage":"https://www.eclipse.org/jetty","size":118685,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"jetty-9.4.x"}},"base":{"label":"eclipse:jetty-9.4.x","ref":"jetty-9.4.x","sha":"f5445a759e798d908118c2191487e278cebd3b08","user":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":2045207,"node_id":"MDEwOlJlcG9zaXRvcnkyMDQ1MjA3","name":"jetty.project","full_name":"eclipse/jetty.project","private":false,"owner":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/eclipse/jetty.project","description":"Eclipse Jetty® - Web Container & Clients - supports HTTP/2, HTTP/1.1, HTTP/1.0, websocket, servlets, and more","fork":false,"url":"https://api.github.com/repos/eclipse/jetty.project","forks_url":"https://api.github.com/repos/eclipse/jetty.project/forks","keys_url":"https://api.github.com/repos/eclipse/jetty.project/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/jetty.project/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/jetty.project/teams","hooks_url":"https://api.github.com/repos/eclipse/jetty.project/hooks","issue_events_url":"https://api.github.com/repos/eclipse/jetty.project/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/jetty.project/events","assignees_url":"https://api.github.com/repos/eclipse/jetty.project/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/jetty.project/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/jetty.project/tags","blobs_url":"https://api.github.com/repos/eclipse/jetty.project/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/jetty.project/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/jetty.project/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/jetty.project/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/jetty.project/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/jetty.project/languages","stargazers_url":"https://api.github.com/repos/eclipse/jetty.project/stargazers","contributors_url":"https://api.github.com/repos/eclipse/jetty.project/contributors","subscribers_url":"https://api.github.com/repos/eclipse/jetty.project/subscribers","subscription_url":"https://api.github.com/repos/eclipse/jetty.project/subscription","commits_url":"https://api.github.com/repos/eclipse/jetty.project/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/jetty.project/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/jetty.project/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/jetty.project/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/jetty.project/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/jetty.project/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/jetty.project/merges","archive_url":"https://api.github.com/repos/eclipse/jetty.project/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/jetty.project/downloads","issues_url":"https://api.github.com/repos/eclipse/jetty.project/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/jetty.project/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/jetty.project/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/jetty.project/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/jetty.project/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/jetty.project/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/jetty.project/deployments","created_at":"2011-07-14T01:11:57Z","updated_at":"2018-11-28T06:01:37Z","pushed_at":"2018-11-28T08:27:18Z","git_url":"git://github.com/eclipse/jetty.project.git","ssh_url":"git@github.com:eclipse/jetty.project.git","clone_url":"https://github.com/eclipse/jetty.project.git","svn_url":"https://github.com/eclipse/jetty.project","homepage":"https://www.eclipse.org/jetty","size":118831,"stargazers_count":2262,"watchers_count":2262,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1277,"mirror_url":null,"archived":false,"open_issues_count":381,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1277,"open_issues":381,"watchers":2262,"default_branch":"jetty-9.4.x"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/jetty.project/pulls/3144"},"html":{"href":"https://github.com/eclipse/jetty.project/pull/3144"},"issue":{"href":"https://api.github.com/repos/eclipse/jetty.project/issues/3144"},"comments":{"href":"https://api.github.com/repos/eclipse/jetty.project/issues/3144/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/jetty.project/pulls/3144/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/jetty.project/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/jetty.project/pulls/3144/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/jetty.project/statuses/8aa3655c5525434f4360b6dc41030b1c2ae2c9b2"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"gregw"}}