{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq-api-client-python/pulls/comments/166459330","pull_request_review_id":94524575,"id":166459330,"diff_hunk":"@@ -587,7 +587,7 @@ def collection(self):\n \n     def __getattr__(self, attr):\n         self.reload()\n-        if not hasattr(self, attr):\n+        if attr not in self.__dict__:\n             raise AttributeError(\"No such action {}\".format(attr))\n         return getattr(self, attr)","path":"src/manageiq_client/api.py","position":7,"original_position":7,"commit_id":"49a04e108ab7f9b2e3d67d2b1f0928b1617a85f5","original_commit_id":"49a04e108ab7f9b2e3d67d2b1f0928b1617a85f5","user":{"login":"cben","id":273688,"avatar_url":"https://avatars2.githubusercontent.com/u/273688?v=4","gravatar_id":"","url":"https://api.github.com/users/cben","html_url":"https://github.com/cben","followers_url":"https://api.github.com/users/cben/followers","following_url":"https://api.github.com/users/cben/following{/other_user}","gists_url":"https://api.github.com/users/cben/gists{/gist_id}","starred_url":"https://api.github.com/users/cben/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cben/subscriptions","organizations_url":"https://api.github.com/users/cben/orgs","repos_url":"https://api.github.com/users/cben/repos","events_url":"https://api.github.com/users/cben/events{/privacy}","received_events_url":"https://api.github.com/users/cben/received_events","type":"User","site_admin":false},"body":"consider rewriting this line too as `self.__dict__[attr]` to explicitly avoid recursion.\r\n(not really necessary, getattr is not supposed to call __getattr__ if the attribute exists, just for readabily)","created_at":"2018-02-06T22:12:40Z","updated_at":"2018-02-06T22:12:40Z","html_url":"https://github.com/ManageIQ/manageiq-api-client-python/pull/34#discussion_r166459330","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq-api-client-python/pulls/34","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq-api-client-python/pulls/comments/166459330"},"html":{"href":"https://github.com/ManageIQ/manageiq-api-client-python/pull/34#discussion_r166459330"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq-api-client-python/pulls/34"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq-api-client-python/pulls/34","id":167427616,"html_url":"https://github.com/ManageIQ/manageiq-api-client-python/pull/34","diff_url":"https://github.com/ManageIQ/manageiq-api-client-python/pull/34.diff","patch_url":"https://github.com/ManageIQ/manageiq-api-client-python/pull/34.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq-api-client-python/issues/34","number":34,"state":"open","locked":false,"title":"fix recursion error when getting an invalid action object attribute","user":{"login":"rywillia","id":3375653,"avatar_url":"https://avatars1.githubusercontent.com/u/3375653?v=4","gravatar_id":"","url":"https://api.github.com/users/rywillia","html_url":"https://github.com/rywillia","followers_url":"https://api.github.com/users/rywillia/followers","following_url":"https://api.github.com/users/rywillia/following{/other_user}","gists_url":"https://api.github.com/users/rywillia/gists{/gist_id}","starred_url":"https://api.github.com/users/rywillia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rywillia/subscriptions","organizations_url":"https://api.github.com/users/rywillia/orgs","repos_url":"https://api.github.com/users/rywillia/repos","events_url":"https://api.github.com/users/rywillia/events{/privacy}","received_events_url":"https://api.github.com/users/rywillia/received_events","type":"User","site_admin":false},"body":"This commit updates the ActionContainer __getattr__ method to not use\r\nhasattr to determine if the attribute does not exist. When running\r\nwith Python 3, this was causing the method to call itself since\r\nhasattr calls getattr. This update will remove using hasattr and\r\nnow use the in keyword. Now if action getattr is called with an\r\ninvalid attribute, an attribute error will be rasied.\r\n\r\nCloses #33","created_at":"2018-02-06T14:24:36Z","updated_at":"2018-02-06T22:12:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"566fd7ae31131ac5dde85efad0445ce6043e6c2b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq-api-client-python/pulls/34/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq-api-client-python/pulls/34/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq-api-client-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq-api-client-python/issues/34/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq-api-client-python/statuses/49a04e108ab7f9b2e3d67d2b1f0928b1617a85f5","head":{"label":"rywillia:recursion-error-fix","ref":"recursion-error-fix","sha":"49a04e108ab7f9b2e3d67d2b1f0928b1617a85f5","user":{"login":"rywillia","id":3375653,"avatar_url":"https://avatars1.githubusercontent.com/u/3375653?v=4","gravatar_id":"","url":"https://api.github.com/users/rywillia","html_url":"https://github.com/rywillia","followers_url":"https://api.github.com/users/rywillia/followers","following_url":"https://api.github.com/users/rywillia/following{/other_user}","gists_url":"https://api.github.com/users/rywillia/gists{/gist_id}","starred_url":"https://api.github.com/users/rywillia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rywillia/subscriptions","organizations_url":"https://api.github.com/users/rywillia/orgs","repos_url":"https://api.github.com/users/rywillia/repos","events_url":"https://api.github.com/users/rywillia/events{/privacy}","received_events_url":"https://api.github.com/users/rywillia/received_events","type":"User","site_admin":false},"repo":{"id":120456670,"name":"manageiq-api-client-python","full_name":"rywillia/manageiq-api-client-python","owner":{"login":"rywillia","id":3375653,"avatar_url":"https://avatars1.githubusercontent.com/u/3375653?v=4","gravatar_id":"","url":"https://api.github.com/users/rywillia","html_url":"https://github.com/rywillia","followers_url":"https://api.github.com/users/rywillia/followers","following_url":"https://api.github.com/users/rywillia/following{/other_user}","gists_url":"https://api.github.com/users/rywillia/gists{/gist_id}","starred_url":"https://api.github.com/users/rywillia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rywillia/subscriptions","organizations_url":"https://api.github.com/users/rywillia/orgs","repos_url":"https://api.github.com/users/rywillia/repos","events_url":"https://api.github.com/users/rywillia/events{/privacy}","received_events_url":"https://api.github.com/users/rywillia/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rywillia/manageiq-api-client-python","description":null,"fork":true,"url":"https://api.github.com/repos/rywillia/manageiq-api-client-python","forks_url":"https://api.github.com/repos/rywillia/manageiq-api-client-python/forks","keys_url":"https://api.github.com/repos/rywillia/manageiq-api-client-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rywillia/manageiq-api-client-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rywillia/manageiq-api-client-python/teams","hooks_url":"https://api.github.com/repos/rywillia/manageiq-api-client-python/hooks","issue_events_url":"https://api.github.com/repos/rywillia/manageiq-api-client-python/issues/events{/number}","events_url":"https://api.github.com/repos/rywillia/manageiq-api-client-python/events","assignees_url":"https://api.github.com/repos/rywillia/manageiq-api-client-python/assignees{/user}","branches_url":"https://api.github.com/repos/rywillia/manageiq-api-client-python/branches{/branch}","tags_url":"https://api.github.com/repos/rywillia/manageiq-api-client-python/tags","blobs_url":"https://api.github.com/repos/rywillia/manageiq-api-client-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rywillia/manageiq-api-client-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rywillia/manageiq-api-client-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/rywillia/manageiq-api-client-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rywillia/manageiq-api-client-python/statuses/{sha}","languages_url":"https://api.github.com/repos/rywillia/manageiq-api-client-python/languages","stargazers_url":"https://api.github.com/repos/rywillia/manageiq-api-client-python/stargazers","contributors_url":"https://api.github.com/repos/rywillia/manageiq-api-client-python/contributors","subscribers_url":"https://api.github.com/repos/rywillia/manageiq-api-client-python/subscribers","subscription_url":"https://api.github.com/repos/rywillia/manageiq-api-client-python/subscription","commits_url":"https://api.github.com/repos/rywillia/manageiq-api-client-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/rywillia/manageiq-api-client-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/rywillia/manageiq-api-client-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/rywillia/manageiq-api-client-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/rywillia/manageiq-api-client-python/contents/{+path}","compare_url":"https://api.github.com/repos/rywillia/manageiq-api-client-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rywillia/manageiq-api-client-python/merges","archive_url":"https://api.github.com/repos/rywillia/manageiq-api-client-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rywillia/manageiq-api-client-python/downloads","issues_url":"https://api.github.com/repos/rywillia/manageiq-api-client-python/issues{/number}","pulls_url":"https://api.github.com/repos/rywillia/manageiq-api-client-python/pulls{/number}","milestones_url":"https://api.github.com/repos/rywillia/manageiq-api-client-python/milestones{/number}","notifications_url":"https://api.github.com/repos/rywillia/manageiq-api-client-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rywillia/manageiq-api-client-python/labels{/name}","releases_url":"https://api.github.com/repos/rywillia/manageiq-api-client-python/releases{/id}","deployments_url":"https://api.github.com/repos/rywillia/manageiq-api-client-python/deployments","created_at":"2018-02-06T12:57:47Z","updated_at":"2018-02-06T12:57:49Z","pushed_at":"2018-02-06T14:22:42Z","git_url":"git://github.com/rywillia/manageiq-api-client-python.git","ssh_url":"git@github.com:rywillia/manageiq-api-client-python.git","clone_url":"https://github.com/rywillia/manageiq-api-client-python.git","svn_url":"https://github.com/rywillia/manageiq-api-client-python","homepage":null,"size":103,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"fd3893d51a0a25daffb9db7723dc15feb2877c42","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars0.githubusercontent.com/u/1125575?v=4","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":65400013,"name":"manageiq-api-client-python","full_name":"ManageIQ/manageiq-api-client-python","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars0.githubusercontent.com/u/1125575?v=4","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq-api-client-python","description":null,"fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq-api-client-python","forks_url":"https://api.github.com/repos/ManageIQ/manageiq-api-client-python/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq-api-client-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq-api-client-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq-api-client-python/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq-api-client-python/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq-api-client-python/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq-api-client-python/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq-api-client-python/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq-api-client-python/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq-api-client-python/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq-api-client-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq-api-client-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq-api-client-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq-api-client-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq-api-client-python/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq-api-client-python/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq-api-client-python/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq-api-client-python/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq-api-client-python/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq-api-client-python/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq-api-client-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq-api-client-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq-api-client-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq-api-client-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq-api-client-python/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq-api-client-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq-api-client-python/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq-api-client-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq-api-client-python/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq-api-client-python/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq-api-client-python/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq-api-client-python/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq-api-client-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq-api-client-python/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq-api-client-python/releases{/id}","deployments_url":"https://api.github.com/repos/ManageIQ/manageiq-api-client-python/deployments","created_at":"2016-08-10T16:50:30Z","updated_at":"2017-12-20T17:07:29Z","pushed_at":"2018-02-06T14:24:36Z","git_url":"git://github.com/ManageIQ/manageiq-api-client-python.git","ssh_url":"git@github.com:ManageIQ/manageiq-api-client-python.git","clone_url":"https://github.com/ManageIQ/manageiq-api-client-python.git","svn_url":"https://github.com/ManageIQ/manageiq-api-client-python","homepage":null,"size":102,"stargazers_count":8,"watchers_count":8,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":18,"open_issues":6,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq-api-client-python/pulls/34"},"html":{"href":"https://github.com/ManageIQ/manageiq-api-client-python/pull/34"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq-api-client-python/issues/34"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq-api-client-python/issues/34/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq-api-client-python/pulls/34/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq-api-client-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq-api-client-python/pulls/34/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq-api-client-python/statuses/49a04e108ab7f9b2e3d67d2b1f0928b1617a85f5"}},"author_association":"NONE"}}
{"actor":{"display_login":"cben"}}