{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/Docusaurus/issues/713","repository_url":"https://api.github.com/repos/facebook/Docusaurus","labels_url":"https://api.github.com/repos/facebook/Docusaurus/issues/713/labels{/name}","comments_url":"https://api.github.com/repos/facebook/Docusaurus/issues/713/comments","events_url":"https://api.github.com/repos/facebook/Docusaurus/issues/713/events","html_url":"https://github.com/facebook/Docusaurus/issues/713","id":328026889,"node_id":"MDU6SXNzdWUzMjgwMjY4ODk=","number":713,"title":"Unable to change docs title","user":{"login":"endiliey","id":17883920,"node_id":"MDQ6VXNlcjE3ODgzOTIw","avatar_url":"https://avatars3.githubusercontent.com/u/17883920?v=4","gravatar_id":"","url":"https://api.github.com/users/endiliey","html_url":"https://github.com/endiliey","followers_url":"https://api.github.com/users/endiliey/followers","following_url":"https://api.github.com/users/endiliey/following{/other_user}","gists_url":"https://api.github.com/users/endiliey/gists{/gist_id}","starred_url":"https://api.github.com/users/endiliey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endiliey/subscriptions","organizations_url":"https://api.github.com/users/endiliey/orgs","repos_url":"https://api.github.com/users/endiliey/repos","events_url":"https://api.github.com/users/endiliey/events{/privacy}","received_events_url":"https://api.github.com/users/endiliey/received_events","type":"User","site_admin":false},"labels":[{"id":776956179,"node_id":"MDU6TGFiZWw3NzY5NTYxNzk=","url":"https://api.github.com/repos/facebook/Docusaurus/labels/RFC","name":"RFC","color":"c5def5","default":false},{"id":630651493,"node_id":"MDU6TGFiZWw2MzA2NTE0OTM=","url":"https://api.github.com/repos/facebook/Docusaurus/labels/bug","name":"bug","color":"ee0701","default":true}],"state":"open","locked":false,"assignee":{"login":"yangshun","id":1315101,"node_id":"MDQ6VXNlcjEzMTUxMDE=","avatar_url":"https://avatars3.githubusercontent.com/u/1315101?v=4","gravatar_id":"","url":"https://api.github.com/users/yangshun","html_url":"https://github.com/yangshun","followers_url":"https://api.github.com/users/yangshun/followers","following_url":"https://api.github.com/users/yangshun/following{/other_user}","gists_url":"https://api.github.com/users/yangshun/gists{/gist_id}","starred_url":"https://api.github.com/users/yangshun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yangshun/subscriptions","organizations_url":"https://api.github.com/users/yangshun/orgs","repos_url":"https://api.github.com/users/yangshun/repos","events_url":"https://api.github.com/users/yangshun/events{/privacy}","received_events_url":"https://api.github.com/users/yangshun/received_events","type":"User","site_admin":false},"assignees":[{"login":"yangshun","id":1315101,"node_id":"MDQ6VXNlcjEzMTUxMDE=","avatar_url":"https://avatars3.githubusercontent.com/u/1315101?v=4","gravatar_id":"","url":"https://api.github.com/users/yangshun","html_url":"https://github.com/yangshun","followers_url":"https://api.github.com/users/yangshun/followers","following_url":"https://api.github.com/users/yangshun/following{/other_user}","gists_url":"https://api.github.com/users/yangshun/gists{/gist_id}","starred_url":"https://api.github.com/users/yangshun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yangshun/subscriptions","organizations_url":"https://api.github.com/users/yangshun/orgs","repos_url":"https://api.github.com/users/yangshun/repos","events_url":"https://api.github.com/users/yangshun/events{/privacy}","received_events_url":"https://api.github.com/users/yangshun/received_events","type":"User","site_admin":false},{"login":"JoelMarcey","id":3757713,"node_id":"MDQ6VXNlcjM3NTc3MTM=","avatar_url":"https://avatars2.githubusercontent.com/u/3757713?v=4","gravatar_id":"","url":"https://api.github.com/users/JoelMarcey","html_url":"https://github.com/JoelMarcey","followers_url":"https://api.github.com/users/JoelMarcey/followers","following_url":"https://api.github.com/users/JoelMarcey/following{/other_user}","gists_url":"https://api.github.com/users/JoelMarcey/gists{/gist_id}","starred_url":"https://api.github.com/users/JoelMarcey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoelMarcey/subscriptions","organizations_url":"https://api.github.com/users/JoelMarcey/orgs","repos_url":"https://api.github.com/users/JoelMarcey/repos","events_url":"https://api.github.com/users/JoelMarcey/events{/privacy}","received_events_url":"https://api.github.com/users/JoelMarcey/received_events","type":"User","site_admin":false},{"login":"rickyvetter","id":4370652,"node_id":"MDQ6VXNlcjQzNzA2NTI=","avatar_url":"https://avatars2.githubusercontent.com/u/4370652?v=4","gravatar_id":"","url":"https://api.github.com/users/rickyvetter","html_url":"https://github.com/rickyvetter","followers_url":"https://api.github.com/users/rickyvetter/followers","following_url":"https://api.github.com/users/rickyvetter/following{/other_user}","gists_url":"https://api.github.com/users/rickyvetter/gists{/gist_id}","starred_url":"https://api.github.com/users/rickyvetter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rickyvetter/subscriptions","organizations_url":"https://api.github.com/users/rickyvetter/orgs","repos_url":"https://api.github.com/users/rickyvetter/repos","events_url":"https://api.github.com/users/rickyvetter/events{/privacy}","received_events_url":"https://api.github.com/users/rickyvetter/received_events","type":"User","site_admin":false},{"login":"endiliey","id":17883920,"node_id":"MDQ6VXNlcjE3ODgzOTIw","avatar_url":"https://avatars3.githubusercontent.com/u/17883920?v=4","gravatar_id":"","url":"https://api.github.com/users/endiliey","html_url":"https://github.com/endiliey","followers_url":"https://api.github.com/users/endiliey/followers","following_url":"https://api.github.com/users/endiliey/following{/other_user}","gists_url":"https://api.github.com/users/endiliey/gists{/gist_id}","starred_url":"https://api.github.com/users/endiliey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endiliey/subscriptions","organizations_url":"https://api.github.com/users/endiliey/orgs","repos_url":"https://api.github.com/users/endiliey/repos","events_url":"https://api.github.com/users/endiliey/events{/privacy}","received_events_url":"https://api.github.com/users/endiliey/received_events","type":"User","site_admin":false}],"milestone":null,"comments":12,"created_at":"2018-05-31T07:37:09Z","updated_at":"2018-06-13T05:35:09Z","closed_at":null,"author_association":"COLLABORATOR","body":"### Is this a bug report?\r\n\r\nYes\r\n\r\n### Have you read the [Contributing Guidelines on issues](https://github.com/facebook/Docusaurus/blob/master/CONTRIBUTING.md#reporting-new-issues)?\r\n\r\nYes\r\n\r\n### Environment\r\n\r\nPlatform Agnostic\r\nLatest Docusaurus (master branch)\r\n\r\n### Steps to Reproduce / Reproducible Demo\r\n\r\n1. Use latest master branch of [Docusaurus](https://github.com/facebook/Docusaurus) & install\r\n2. Start server\r\n```\r\ncd website\r\nyarn start\r\n```\r\n3. Go to http://localhost:3000/docs/en/next/installation.html\r\n4. Change `docs/getting-started-installation.md` title to \r\n`Installation asdf`\r\n\r\n<img width=\"191\" alt=\"change\" src=\"https://user-images.githubusercontent.com/17883920/40767067-fd2078f0-64e3-11e8-9351-1e16347d6c58.PNG\">\r\n\r\n5. Stop the server and start it again with `yarn start`\r\n6. Go to http://localhost:3000/docs/en/next/installation.html\r\n\r\n### Expected Behavior\r\n\r\n<img width=\"725\" alt=\"title_change\" src=\"https://user-images.githubusercontent.com/17883920/40767150-3a3b04b2-64e4-11e8-8cd0-1035d6d3874f.PNG\">\r\n\r\n### Actual Behavior\r\n\r\n<img width=\"609\" alt=\"title_no_change\" src=\"https://user-images.githubusercontent.com/17883920/40767163-455c54ea-64e4-11e8-9b3a-602692349d16.PNG\">\r\n\r\n### Investigation\r\nThis happen after PR #710 \r\nPrior to this, `i18n/en.json` is always newly generated\r\nAfter this, `i18n/en.json` will persist and override newly generated  `i18n/en.json`\r\nHence, title is not changing\r\n\r\nBut PR #710 is correct because it fixes bug from #158 that allow user allow overriding of english strings\r\n\r\n### Workaround\r\nDelete  `i18n/en.json` when changing title"},"comment":{"url":"https://api.github.com/repos/facebook/Docusaurus/issues/comments/396818837","html_url":"https://github.com/facebook/Docusaurus/issues/713#issuecomment-396818837","issue_url":"https://api.github.com/repos/facebook/Docusaurus/issues/713","id":396818837,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NjgxODgzNw==","user":{"login":"endiliey","id":17883920,"node_id":"MDQ6VXNlcjE3ODgzOTIw","avatar_url":"https://avatars3.githubusercontent.com/u/17883920?v=4","gravatar_id":"","url":"https://api.github.com/users/endiliey","html_url":"https://github.com/endiliey","followers_url":"https://api.github.com/users/endiliey/followers","following_url":"https://api.github.com/users/endiliey/following{/other_user}","gists_url":"https://api.github.com/users/endiliey/gists{/gist_id}","starred_url":"https://api.github.com/users/endiliey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endiliey/subscriptions","organizations_url":"https://api.github.com/users/endiliey/orgs","repos_url":"https://api.github.com/users/endiliey/repos","events_url":"https://api.github.com/users/endiliey/events{/privacy}","received_events_url":"https://api.github.com/users/endiliey/received_events","type":"User","site_admin":false},"created_at":"2018-06-13T05:35:09Z","updated_at":"2018-06-13T05:35:09Z","author_association":"COLLABORATOR","body":"I have few alternatives\r\n1. Don't allow custom strings. This is like 1.1.5\r\n\r\nDelete\r\nhttps://github.com/facebook/Docusaurus/blob/fa20c93d5c1b5a9369cf1c5909955fc58f0dcb8e/lib/write-translations.js#L27-L31\r\n\r\nhttps://github.com/facebook/Docusaurus/blob/fa20c93d5c1b5a9369cf1c5909955fc58f0dcb8e/lib/write-translations.js#L158-L164\r\n\r\n2. Allow custom string but maybe user has to explicitly name it `custom-en.json`\r\n\r\nhttps://github.com/facebook/Docusaurus/blob/fa20c93d5c1b5a9369cf1c5909955fc58f0dcb8e/lib/write-translations.js#L27-L3q"}}
{"actor":{"display_login":"endiliey"}}