{"action":"created","issue":{"url":"https://api.github.com/repos/eclipse/jetty.project/issues/874","repository_url":"https://api.github.com/repos/eclipse/jetty.project","labels_url":"https://api.github.com/repos/eclipse/jetty.project/issues/874/labels{/name}","comments_url":"https://api.github.com/repos/eclipse/jetty.project/issues/874/comments","events_url":"https://api.github.com/repos/eclipse/jetty.project/issues/874/events","html_url":"https://github.com/eclipse/jetty.project/issues/874","id":173960424,"number":874,"title":"Jetty client hangs if less than 5 max threads in executor","user":{"login":"dmitrymurashenkov","id":18661137,"avatar_url":"https://avatars3.githubusercontent.com/u/18661137?v=4","gravatar_id":"","url":"https://api.github.com/users/dmitrymurashenkov","html_url":"https://github.com/dmitrymurashenkov","followers_url":"https://api.github.com/users/dmitrymurashenkov/followers","following_url":"https://api.github.com/users/dmitrymurashenkov/following{/other_user}","gists_url":"https://api.github.com/users/dmitrymurashenkov/gists{/gist_id}","starred_url":"https://api.github.com/users/dmitrymurashenkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmitrymurashenkov/subscriptions","organizations_url":"https://api.github.com/users/dmitrymurashenkov/orgs","repos_url":"https://api.github.com/users/dmitrymurashenkov/repos","events_url":"https://api.github.com/users/dmitrymurashenkov/events{/privacy}","received_events_url":"https://api.github.com/users/dmitrymurashenkov/received_events","type":"User","site_admin":false},"labels":[{"id":326417667,"url":"https://api.github.com/repos/eclipse/jetty.project/labels/Enhancement","name":"Enhancement","color":"d4c5f9","default":false},{"id":350154659,"url":"https://api.github.com/repos/eclipse/jetty.project/labels/Question","name":"Question","color":"006b75","default":false}],"state":"closed","locked":false,"assignee":{"login":"sbordet","id":414681,"avatar_url":"https://avatars3.githubusercontent.com/u/414681?v=4","gravatar_id":"","url":"https://api.github.com/users/sbordet","html_url":"https://github.com/sbordet","followers_url":"https://api.github.com/users/sbordet/followers","following_url":"https://api.github.com/users/sbordet/following{/other_user}","gists_url":"https://api.github.com/users/sbordet/gists{/gist_id}","starred_url":"https://api.github.com/users/sbordet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbordet/subscriptions","organizations_url":"https://api.github.com/users/sbordet/orgs","repos_url":"https://api.github.com/users/sbordet/repos","events_url":"https://api.github.com/users/sbordet/events{/privacy}","received_events_url":"https://api.github.com/users/sbordet/received_events","type":"User","site_admin":false},"assignees":[{"login":"sbordet","id":414681,"avatar_url":"https://avatars3.githubusercontent.com/u/414681?v=4","gravatar_id":"","url":"https://api.github.com/users/sbordet","html_url":"https://github.com/sbordet","followers_url":"https://api.github.com/users/sbordet/followers","following_url":"https://api.github.com/users/sbordet/following{/other_user}","gists_url":"https://api.github.com/users/sbordet/gists{/gist_id}","starred_url":"https://api.github.com/users/sbordet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbordet/subscriptions","organizations_url":"https://api.github.com/users/sbordet/orgs","repos_url":"https://api.github.com/users/sbordet/repos","events_url":"https://api.github.com/users/sbordet/events{/privacy}","received_events_url":"https://api.github.com/users/sbordet/received_events","type":"User","site_admin":false}],"milestone":null,"comments":15,"created_at":"2016-08-30T08:35:37Z","updated_at":"2018-04-27T15:39:20Z","closed_at":"2017-10-06T14:30:53Z","author_association":"NONE","body":"Following example hangs with <5 threads and passes if 5+ threads in pool.\n\n```\n    public static void main(String[] args) throws Exception\n    {\n        int threads = 4;\n        HttpClient client = new HttpClient();\n        client.setMaxConnectionsPerDestination(1);\n        client.setExecutor(Executors.newFixedThreadPool(threads));\n        client.start();\n        int status = client.GET(\"http://google.com\").getStatus();\n        System.out.println(status);\n    }\n```\n"},"comment":{"url":"https://api.github.com/repos/eclipse/jetty.project/issues/comments/385008630","html_url":"https://github.com/eclipse/jetty.project/issues/874#issuecomment-385008630","issue_url":"https://api.github.com/repos/eclipse/jetty.project/issues/874","id":385008630,"user":{"login":"bradical","id":191132,"avatar_url":"https://avatars2.githubusercontent.com/u/191132?v=4","gravatar_id":"","url":"https://api.github.com/users/bradical","html_url":"https://github.com/bradical","followers_url":"https://api.github.com/users/bradical/followers","following_url":"https://api.github.com/users/bradical/following{/other_user}","gists_url":"https://api.github.com/users/bradical/gists{/gist_id}","starred_url":"https://api.github.com/users/bradical/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradical/subscriptions","organizations_url":"https://api.github.com/users/bradical/orgs","repos_url":"https://api.github.com/users/bradical/repos","events_url":"https://api.github.com/users/bradical/events{/privacy}","received_events_url":"https://api.github.com/users/bradical/received_events","type":"User","site_admin":false},"created_at":"2018-04-27T15:39:20Z","updated_at":"2018-04-27T15:39:20Z","author_association":"NONE","body":"@sbordet:\r\n\r\n> that you never call `HttpClient.stop()` in your CI is not ideal - you should stop the HttpClient when you're done using it.\r\n\r\nSo we have an HttpClient on standby to make requests to user-submitted URLs and to fetch data from those URLs. Are you saying that when that's not actively being used we should be stopping `HttpClient` and starting it again? Is there some threshold of how frequently we use this client where it makes sense to shut it down or keep it running all the time? What would be the downside to leaving it running all of the time?"}}
{"actor":{"display_login":"bradical"}}