{"action":"closed","number":2141,"pull_request":{"url":"https://api.github.com/repos/confluentinc/ksql/pulls/2141","id":229838914,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5ODM4OTE0","html_url":"https://github.com/confluentinc/ksql/pull/2141","diff_url":"https://github.com/confluentinc/ksql/pull/2141.diff","patch_url":"https://github.com/confluentinc/ksql/pull/2141.patch","issue_url":"https://api.github.com/repos/confluentinc/ksql/issues/2141","number":2141,"state":"closed","locked":false,"title":"Fixes to allow upgrade of spotbugs","user":{"login":"ewencp","id":47366,"node_id":"MDQ6VXNlcjQ3MzY2","avatar_url":"https://avatars3.githubusercontent.com/u/47366?v=4","gravatar_id":"","url":"https://api.github.com/users/ewencp","html_url":"https://github.com/ewencp","followers_url":"https://api.github.com/users/ewencp/followers","following_url":"https://api.github.com/users/ewencp/following{/other_user}","gists_url":"https://api.github.com/users/ewencp/gists{/gist_id}","starred_url":"https://api.github.com/users/ewencp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ewencp/subscriptions","organizations_url":"https://api.github.com/users/ewencp/orgs","repos_url":"https://api.github.com/users/ewencp/repos","events_url":"https://api.github.com/users/ewencp/events{/privacy}","received_events_url":"https://api.github.com/users/ewencp/received_events","type":"User","site_admin":false},"body":"### Description \r\nThis fixes one minor bug affecting JDK 11 builds and adds a few suppressions (due to https://github.com/spotbugs/spotbugs/issues/600, which it doesn't look like there's active progress being made on it). The suppressions are only an issue in KSQL since it's failing more aggressively. An upgrade to spotbugs is required to move forward with general JDK 11 support.\r\n\r\n### Testing done \r\nRan unit tests\r\n\r\n### Reviewer checklist\r\n- [ ] Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).\r\n- [ ] Ensure relevant issues are linked (description should include text like \"Fixes #<issue number>\")\r\n\r\n","created_at":"2018-11-09T22:38:58Z","updated_at":"2018-11-14T21:21:38Z","closed_at":"2018-11-14T21:21:38Z","merged_at":null,"merge_commit_sha":"6227ca7360ceb1dd84b29a7c43c360d2eb580b09","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/confluentinc/ksql/pulls/2141/commits","review_comments_url":"https://api.github.com/repos/confluentinc/ksql/pulls/2141/comments","review_comment_url":"https://api.github.com/repos/confluentinc/ksql/pulls/comments{/number}","comments_url":"https://api.github.com/repos/confluentinc/ksql/issues/2141/comments","statuses_url":"https://api.github.com/repos/confluentinc/ksql/statuses/c3f3d8576313aae7cb12a706c6f6a81e270af2fb","head":{"label":"ewencp:upgrade-spotbugs","ref":"upgrade-spotbugs","sha":"c3f3d8576313aae7cb12a706c6f6a81e270af2fb","user":{"login":"ewencp","id":47366,"node_id":"MDQ6VXNlcjQ3MzY2","avatar_url":"https://avatars3.githubusercontent.com/u/47366?v=4","gravatar_id":"","url":"https://api.github.com/users/ewencp","html_url":"https://github.com/ewencp","followers_url":"https://api.github.com/users/ewencp/followers","following_url":"https://api.github.com/users/ewencp/following{/other_user}","gists_url":"https://api.github.com/users/ewencp/gists{/gist_id}","starred_url":"https://api.github.com/users/ewencp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ewencp/subscriptions","organizations_url":"https://api.github.com/users/ewencp/orgs","repos_url":"https://api.github.com/users/ewencp/repos","events_url":"https://api.github.com/users/ewencp/events{/privacy}","received_events_url":"https://api.github.com/users/ewencp/received_events","type":"User","site_admin":false},"repo":{"id":103584353,"node_id":"MDEwOlJlcG9zaXRvcnkxMDM1ODQzNTM=","name":"ksql","full_name":"ewencp/ksql","private":false,"owner":{"login":"ewencp","id":47366,"node_id":"MDQ6VXNlcjQ3MzY2","avatar_url":"https://avatars3.githubusercontent.com/u/47366?v=4","gravatar_id":"","url":"https://api.github.com/users/ewencp","html_url":"https://github.com/ewencp","followers_url":"https://api.github.com/users/ewencp/followers","following_url":"https://api.github.com/users/ewencp/following{/other_user}","gists_url":"https://api.github.com/users/ewencp/gists{/gist_id}","starred_url":"https://api.github.com/users/ewencp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ewencp/subscriptions","organizations_url":"https://api.github.com/users/ewencp/orgs","repos_url":"https://api.github.com/users/ewencp/repos","events_url":"https://api.github.com/users/ewencp/events{/privacy}","received_events_url":"https://api.github.com/users/ewencp/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ewencp/ksql","description":"KSQL - a Streaming SQL Engine for Apache Kafka ","fork":true,"url":"https://api.github.com/repos/ewencp/ksql","forks_url":"https://api.github.com/repos/ewencp/ksql/forks","keys_url":"https://api.github.com/repos/ewencp/ksql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ewencp/ksql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ewencp/ksql/teams","hooks_url":"https://api.github.com/repos/ewencp/ksql/hooks","issue_events_url":"https://api.github.com/repos/ewencp/ksql/issues/events{/number}","events_url":"https://api.github.com/repos/ewencp/ksql/events","assignees_url":"https://api.github.com/repos/ewencp/ksql/assignees{/user}","branches_url":"https://api.github.com/repos/ewencp/ksql/branches{/branch}","tags_url":"https://api.github.com/repos/ewencp/ksql/tags","blobs_url":"https://api.github.com/repos/ewencp/ksql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ewencp/ksql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ewencp/ksql/git/refs{/sha}","trees_url":"https://api.github.com/repos/ewencp/ksql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ewencp/ksql/statuses/{sha}","languages_url":"https://api.github.com/repos/ewencp/ksql/languages","stargazers_url":"https://api.github.com/repos/ewencp/ksql/stargazers","contributors_url":"https://api.github.com/repos/ewencp/ksql/contributors","subscribers_url":"https://api.github.com/repos/ewencp/ksql/subscribers","subscription_url":"https://api.github.com/repos/ewencp/ksql/subscription","commits_url":"https://api.github.com/repos/ewencp/ksql/commits{/sha}","git_commits_url":"https://api.github.com/repos/ewencp/ksql/git/commits{/sha}","comments_url":"https://api.github.com/repos/ewencp/ksql/comments{/number}","issue_comment_url":"https://api.github.com/repos/ewencp/ksql/issues/comments{/number}","contents_url":"https://api.github.com/repos/ewencp/ksql/contents/{+path}","compare_url":"https://api.github.com/repos/ewencp/ksql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ewencp/ksql/merges","archive_url":"https://api.github.com/repos/ewencp/ksql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ewencp/ksql/downloads","issues_url":"https://api.github.com/repos/ewencp/ksql/issues{/number}","pulls_url":"https://api.github.com/repos/ewencp/ksql/pulls{/number}","milestones_url":"https://api.github.com/repos/ewencp/ksql/milestones{/number}","notifications_url":"https://api.github.com/repos/ewencp/ksql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ewencp/ksql/labels{/name}","releases_url":"https://api.github.com/repos/ewencp/ksql/releases{/id}","deployments_url":"https://api.github.com/repos/ewencp/ksql/deployments","created_at":"2017-09-14T21:39:49Z","updated_at":"2017-09-14T21:39:52Z","pushed_at":"2018-11-09T19:59:14Z","git_url":"git://github.com/ewencp/ksql.git","ssh_url":"git@github.com:ewencp/ksql.git","clone_url":"https://github.com/ewencp/ksql.git","svn_url":"https://github.com/ewencp/ksql","homepage":"","size":10949,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"0.1.x"}},"base":{"label":"confluentinc:5.1.x","ref":"5.1.x","sha":"0f59a8bb4810c4058c038a625f79a53ee92bf31c","user":{"login":"confluentinc","id":9439498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0Mzk0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/9439498?v=4","gravatar_id":"","url":"https://api.github.com/users/confluentinc","html_url":"https://github.com/confluentinc","followers_url":"https://api.github.com/users/confluentinc/followers","following_url":"https://api.github.com/users/confluentinc/following{/other_user}","gists_url":"https://api.github.com/users/confluentinc/gists{/gist_id}","starred_url":"https://api.github.com/users/confluentinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/confluentinc/subscriptions","organizations_url":"https://api.github.com/users/confluentinc/orgs","repos_url":"https://api.github.com/users/confluentinc/repos","events_url":"https://api.github.com/users/confluentinc/events{/privacy}","received_events_url":"https://api.github.com/users/confluentinc/received_events","type":"Organization","site_admin":false},"repo":{"id":69400326,"node_id":"MDEwOlJlcG9zaXRvcnk2OTQwMDMyNg==","name":"ksql","full_name":"confluentinc/ksql","private":false,"owner":{"login":"confluentinc","id":9439498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0Mzk0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/9439498?v=4","gravatar_id":"","url":"https://api.github.com/users/confluentinc","html_url":"https://github.com/confluentinc","followers_url":"https://api.github.com/users/confluentinc/followers","following_url":"https://api.github.com/users/confluentinc/following{/other_user}","gists_url":"https://api.github.com/users/confluentinc/gists{/gist_id}","starred_url":"https://api.github.com/users/confluentinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/confluentinc/subscriptions","organizations_url":"https://api.github.com/users/confluentinc/orgs","repos_url":"https://api.github.com/users/confluentinc/repos","events_url":"https://api.github.com/users/confluentinc/events{/privacy}","received_events_url":"https://api.github.com/users/confluentinc/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/confluentinc/ksql","description":"KSQL - the Streaming SQL Engine for Apache Kafka ","fork":false,"url":"https://api.github.com/repos/confluentinc/ksql","forks_url":"https://api.github.com/repos/confluentinc/ksql/forks","keys_url":"https://api.github.com/repos/confluentinc/ksql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/confluentinc/ksql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/confluentinc/ksql/teams","hooks_url":"https://api.github.com/repos/confluentinc/ksql/hooks","issue_events_url":"https://api.github.com/repos/confluentinc/ksql/issues/events{/number}","events_url":"https://api.github.com/repos/confluentinc/ksql/events","assignees_url":"https://api.github.com/repos/confluentinc/ksql/assignees{/user}","branches_url":"https://api.github.com/repos/confluentinc/ksql/branches{/branch}","tags_url":"https://api.github.com/repos/confluentinc/ksql/tags","blobs_url":"https://api.github.com/repos/confluentinc/ksql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/confluentinc/ksql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/confluentinc/ksql/git/refs{/sha}","trees_url":"https://api.github.com/repos/confluentinc/ksql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/confluentinc/ksql/statuses/{sha}","languages_url":"https://api.github.com/repos/confluentinc/ksql/languages","stargazers_url":"https://api.github.com/repos/confluentinc/ksql/stargazers","contributors_url":"https://api.github.com/repos/confluentinc/ksql/contributors","subscribers_url":"https://api.github.com/repos/confluentinc/ksql/subscribers","subscription_url":"https://api.github.com/repos/confluentinc/ksql/subscription","commits_url":"https://api.github.com/repos/confluentinc/ksql/commits{/sha}","git_commits_url":"https://api.github.com/repos/confluentinc/ksql/git/commits{/sha}","comments_url":"https://api.github.com/repos/confluentinc/ksql/comments{/number}","issue_comment_url":"https://api.github.com/repos/confluentinc/ksql/issues/comments{/number}","contents_url":"https://api.github.com/repos/confluentinc/ksql/contents/{+path}","compare_url":"https://api.github.com/repos/confluentinc/ksql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/confluentinc/ksql/merges","archive_url":"https://api.github.com/repos/confluentinc/ksql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/confluentinc/ksql/downloads","issues_url":"https://api.github.com/repos/confluentinc/ksql/issues{/number}","pulls_url":"https://api.github.com/repos/confluentinc/ksql/pulls{/number}","milestones_url":"https://api.github.com/repos/confluentinc/ksql/milestones{/number}","notifications_url":"https://api.github.com/repos/confluentinc/ksql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/confluentinc/ksql/labels{/name}","releases_url":"https://api.github.com/repos/confluentinc/ksql/releases{/id}","deployments_url":"https://api.github.com/repos/confluentinc/ksql/deployments","created_at":"2016-09-27T21:30:15Z","updated_at":"2018-11-14T20:51:07Z","pushed_at":"2018-11-14T21:17:09Z","git_url":"git://github.com/confluentinc/ksql.git","ssh_url":"git@github.com:confluentinc/ksql.git","clone_url":"https://github.com/confluentinc/ksql.git","svn_url":"https://github.com/confluentinc/ksql","homepage":"","size":12043,"stargazers_count":2012,"watchers_count":2012,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":376,"mirror_url":null,"archived":false,"open_issues_count":396,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":376,"open_issues":396,"watchers":2012,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/confluentinc/ksql/pulls/2141"},"html":{"href":"https://github.com/confluentinc/ksql/pull/2141"},"issue":{"href":"https://api.github.com/repos/confluentinc/ksql/issues/2141"},"comments":{"href":"https://api.github.com/repos/confluentinc/ksql/issues/2141/comments"},"review_comments":{"href":"https://api.github.com/repos/confluentinc/ksql/pulls/2141/comments"},"review_comment":{"href":"https://api.github.com/repos/confluentinc/ksql/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/confluentinc/ksql/pulls/2141/commits"},"statuses":{"href":"https://api.github.com/repos/confluentinc/ksql/statuses/c3f3d8576313aae7cb12a706c6f6a81e270af2fb"}},"author_association":"MEMBER","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":25,"deletions":1,"changed_files":7}}
{"actor":{"display_login":"ewencp"}}