{"action":"created","comment":{"url":"https://api.github.com/repos/EBIvariation/metadata-ws/pulls/comments/227433917","pull_request_review_id":167472619,"id":227433917,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNzQzMzkxNw==","diff_hunk":"@@ -18,19 +18,19 @@\n package uk.ac.ebi.ampt2d.metadata.persistence.idconverter;\n \n import org.springframework.core.convert.converter.Converter;\n-import uk.ac.ebi.ampt2d.metadata.persistence.entities.AccessionVersionEntityId;\n+import uk.ac.ebi.ampt2d.metadata.persistence.entities.AccessionVersionId;\n \n-public class CustomBackendIdConverter implements Converter<String, AccessionVersionEntityId> {\n+public class CustomBackendIdConverter implements Converter<String, AccessionVersionId> {","path":"src/main/java/uk/ac/ebi/ampt2d/metadata/persistence/idconverter/CustomBackendIdConverter.java","position":8,"original_position":8,"commit_id":"62c3f26cc2d409c3711ebccedfe2635a2a8adf02","original_commit_id":"62c3f26cc2d409c3711ebccedfe2635a2a8adf02","user":{"login":"selvaebi","id":33631243,"node_id":"MDQ6VXNlcjMzNjMxMjQz","avatar_url":"https://avatars2.githubusercontent.com/u/33631243?v=4","gravatar_id":"","url":"https://api.github.com/users/selvaebi","html_url":"https://github.com/selvaebi","followers_url":"https://api.github.com/users/selvaebi/followers","following_url":"https://api.github.com/users/selvaebi/following{/other_user}","gists_url":"https://api.github.com/users/selvaebi/gists{/gist_id}","starred_url":"https://api.github.com/users/selvaebi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/selvaebi/subscriptions","organizations_url":"https://api.github.com/users/selvaebi/orgs","repos_url":"https://api.github.com/users/selvaebi/repos","events_url":"https://api.github.com/users/selvaebi/events{/privacy}","received_events_url":"https://api.github.com/users/selvaebi/received_events","type":"User","site_admin":false},"body":"it is used for querydsl queries , like below \r\n``` \r\nmockMvc.perform(get(\"/studies?accessionVersionId=EGAS0001\")).andExpect(status().is4xxClientError())\r\n                .andExpect(jsonPath(\"$\" +\r\n                \".message\").value(\"Please provide an ID in the form accession.version\")); \r\n``` . If we don't need these we can remove it as i guess.","created_at":"2018-10-23T15:00:33Z","updated_at":"2018-10-23T15:00:34Z","html_url":"https://github.com/EBIvariation/metadata-ws/pull/36#discussion_r227433917","pull_request_url":"https://api.github.com/repos/EBIvariation/metadata-ws/pulls/36","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/EBIvariation/metadata-ws/pulls/comments/227433917"},"html":{"href":"https://github.com/EBIvariation/metadata-ws/pull/36#discussion_r227433917"},"pull_request":{"href":"https://api.github.com/repos/EBIvariation/metadata-ws/pulls/36"}},"in_reply_to_id":227319771},"pull_request":{"url":"https://api.github.com/repos/EBIvariation/metadata-ws/pulls/36","id":224645426,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0NjQ1NDI2","html_url":"https://github.com/EBIvariation/metadata-ws/pull/36","diff_url":"https://github.com/EBIvariation/metadata-ws/pull/36.diff","patch_url":"https://github.com/EBIvariation/metadata-ws/pull/36.patch","issue_url":"https://api.github.com/repos/EBIvariation/metadata-ws/issues/36","number":36,"state":"open","locked":false,"title":"T2D-218 added auto generated id and unique constraints","user":{"login":"selvaebi","id":33631243,"node_id":"MDQ6VXNlcjMzNjMxMjQz","avatar_url":"https://avatars2.githubusercontent.com/u/33631243?v=4","gravatar_id":"","url":"https://api.github.com/users/selvaebi","html_url":"https://github.com/selvaebi","followers_url":"https://api.github.com/users/selvaebi/followers","following_url":"https://api.github.com/users/selvaebi/following{/other_user}","gists_url":"https://api.github.com/users/selvaebi/gists{/gist_id}","starred_url":"https://api.github.com/users/selvaebi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/selvaebi/subscriptions","organizations_url":"https://api.github.com/users/selvaebi/orgs","repos_url":"https://api.github.com/users/selvaebi/repos","events_url":"https://api.github.com/users/selvaebi/events{/privacy}","received_events_url":"https://api.github.com/users/selvaebi/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-10-22T10:54:43Z","updated_at":"2018-10-23T15:00:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"06331186f76723829a00ac731eabe41d0b49ffa1","assignee":null,"assignees":[],"requested_reviewers":[{"login":"cyenyxe","id":1433407,"node_id":"MDQ6VXNlcjE0MzM0MDc=","avatar_url":"https://avatars0.githubusercontent.com/u/1433407?v=4","gravatar_id":"","url":"https://api.github.com/users/cyenyxe","html_url":"https://github.com/cyenyxe","followers_url":"https://api.github.com/users/cyenyxe/followers","following_url":"https://api.github.com/users/cyenyxe/following{/other_user}","gists_url":"https://api.github.com/users/cyenyxe/gists{/gist_id}","starred_url":"https://api.github.com/users/cyenyxe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyenyxe/subscriptions","organizations_url":"https://api.github.com/users/cyenyxe/orgs","repos_url":"https://api.github.com/users/cyenyxe/repos","events_url":"https://api.github.com/users/cyenyxe/events{/privacy}","received_events_url":"https://api.github.com/users/cyenyxe/received_events","type":"User","site_admin":false},{"login":"iyangar","id":43437020,"node_id":"MDQ6VXNlcjQzNDM3MDIw","avatar_url":"https://avatars3.githubusercontent.com/u/43437020?v=4","gravatar_id":"","url":"https://api.github.com/users/iyangar","html_url":"https://github.com/iyangar","followers_url":"https://api.github.com/users/iyangar/followers","following_url":"https://api.github.com/users/iyangar/following{/other_user}","gists_url":"https://api.github.com/users/iyangar/gists{/gist_id}","starred_url":"https://api.github.com/users/iyangar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iyangar/subscriptions","organizations_url":"https://api.github.com/users/iyangar/orgs","repos_url":"https://api.github.com/users/iyangar/repos","events_url":"https://api.github.com/users/iyangar/events{/privacy}","received_events_url":"https://api.github.com/users/iyangar/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/EBIvariation/metadata-ws/pulls/36/commits","review_comments_url":"https://api.github.com/repos/EBIvariation/metadata-ws/pulls/36/comments","review_comment_url":"https://api.github.com/repos/EBIvariation/metadata-ws/pulls/comments{/number}","comments_url":"https://api.github.com/repos/EBIvariation/metadata-ws/issues/36/comments","statuses_url":"https://api.github.com/repos/EBIvariation/metadata-ws/statuses/62c3f26cc2d409c3711ebccedfe2635a2a8adf02","head":{"label":"selvaebi:T2D-218InconsistentPost","ref":"T2D-218InconsistentPost","sha":"62c3f26cc2d409c3711ebccedfe2635a2a8adf02","user":{"login":"selvaebi","id":33631243,"node_id":"MDQ6VXNlcjMzNjMxMjQz","avatar_url":"https://avatars2.githubusercontent.com/u/33631243?v=4","gravatar_id":"","url":"https://api.github.com/users/selvaebi","html_url":"https://github.com/selvaebi","followers_url":"https://api.github.com/users/selvaebi/followers","following_url":"https://api.github.com/users/selvaebi/following{/other_user}","gists_url":"https://api.github.com/users/selvaebi/gists{/gist_id}","starred_url":"https://api.github.com/users/selvaebi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/selvaebi/subscriptions","organizations_url":"https://api.github.com/users/selvaebi/orgs","repos_url":"https://api.github.com/users/selvaebi/repos","events_url":"https://api.github.com/users/selvaebi/events{/privacy}","received_events_url":"https://api.github.com/users/selvaebi/received_events","type":"User","site_admin":false},"repo":{"id":133343909,"node_id":"MDEwOlJlcG9zaXRvcnkxMzMzNDM5MDk=","name":"metadata-ws","full_name":"selvaebi/metadata-ws","private":false,"owner":{"login":"selvaebi","id":33631243,"node_id":"MDQ6VXNlcjMzNjMxMjQz","avatar_url":"https://avatars2.githubusercontent.com/u/33631243?v=4","gravatar_id":"","url":"https://api.github.com/users/selvaebi","html_url":"https://github.com/selvaebi","followers_url":"https://api.github.com/users/selvaebi/followers","following_url":"https://api.github.com/users/selvaebi/following{/other_user}","gists_url":"https://api.github.com/users/selvaebi/gists{/gist_id}","starred_url":"https://api.github.com/users/selvaebi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/selvaebi/subscriptions","organizations_url":"https://api.github.com/users/selvaebi/orgs","repos_url":"https://api.github.com/users/selvaebi/repos","events_url":"https://api.github.com/users/selvaebi/events{/privacy}","received_events_url":"https://api.github.com/users/selvaebi/received_events","type":"User","site_admin":false},"html_url":"https://github.com/selvaebi/metadata-ws","description":"Generic REST API for submission metadata objects (usable by AMP T2D, EGA and EVA)","fork":true,"url":"https://api.github.com/repos/selvaebi/metadata-ws","forks_url":"https://api.github.com/repos/selvaebi/metadata-ws/forks","keys_url":"https://api.github.com/repos/selvaebi/metadata-ws/keys{/key_id}","collaborators_url":"https://api.github.com/repos/selvaebi/metadata-ws/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/selvaebi/metadata-ws/teams","hooks_url":"https://api.github.com/repos/selvaebi/metadata-ws/hooks","issue_events_url":"https://api.github.com/repos/selvaebi/metadata-ws/issues/events{/number}","events_url":"https://api.github.com/repos/selvaebi/metadata-ws/events","assignees_url":"https://api.github.com/repos/selvaebi/metadata-ws/assignees{/user}","branches_url":"https://api.github.com/repos/selvaebi/metadata-ws/branches{/branch}","tags_url":"https://api.github.com/repos/selvaebi/metadata-ws/tags","blobs_url":"https://api.github.com/repos/selvaebi/metadata-ws/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/selvaebi/metadata-ws/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/selvaebi/metadata-ws/git/refs{/sha}","trees_url":"https://api.github.com/repos/selvaebi/metadata-ws/git/trees{/sha}","statuses_url":"https://api.github.com/repos/selvaebi/metadata-ws/statuses/{sha}","languages_url":"https://api.github.com/repos/selvaebi/metadata-ws/languages","stargazers_url":"https://api.github.com/repos/selvaebi/metadata-ws/stargazers","contributors_url":"https://api.github.com/repos/selvaebi/metadata-ws/contributors","subscribers_url":"https://api.github.com/repos/selvaebi/metadata-ws/subscribers","subscription_url":"https://api.github.com/repos/selvaebi/metadata-ws/subscription","commits_url":"https://api.github.com/repos/selvaebi/metadata-ws/commits{/sha}","git_commits_url":"https://api.github.com/repos/selvaebi/metadata-ws/git/commits{/sha}","comments_url":"https://api.github.com/repos/selvaebi/metadata-ws/comments{/number}","issue_comment_url":"https://api.github.com/repos/selvaebi/metadata-ws/issues/comments{/number}","contents_url":"https://api.github.com/repos/selvaebi/metadata-ws/contents/{+path}","compare_url":"https://api.github.com/repos/selvaebi/metadata-ws/compare/{base}...{head}","merges_url":"https://api.github.com/repos/selvaebi/metadata-ws/merges","archive_url":"https://api.github.com/repos/selvaebi/metadata-ws/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/selvaebi/metadata-ws/downloads","issues_url":"https://api.github.com/repos/selvaebi/metadata-ws/issues{/number}","pulls_url":"https://api.github.com/repos/selvaebi/metadata-ws/pulls{/number}","milestones_url":"https://api.github.com/repos/selvaebi/metadata-ws/milestones{/number}","notifications_url":"https://api.github.com/repos/selvaebi/metadata-ws/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/selvaebi/metadata-ws/labels{/name}","releases_url":"https://api.github.com/repos/selvaebi/metadata-ws/releases{/id}","deployments_url":"https://api.github.com/repos/selvaebi/metadata-ws/deployments","created_at":"2018-05-14T10:24:32Z","updated_at":"2018-07-03T13:44:36Z","pushed_at":"2018-10-22T10:42:48Z","git_url":"git://github.com/selvaebi/metadata-ws.git","ssh_url":"git@github.com:selvaebi/metadata-ws.git","clone_url":"https://github.com/selvaebi/metadata-ws.git","svn_url":"https://github.com/selvaebi/metadata-ws","homepage":"","size":309,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"EBIvariation:master","ref":"master","sha":"ef1d58e6961597697e79b3bbcddd26ae047b62ec","user":{"login":"EBIvariation","id":6419333,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0MTkzMzM=","avatar_url":"https://avatars1.githubusercontent.com/u/6419333?v=4","gravatar_id":"","url":"https://api.github.com/users/EBIvariation","html_url":"https://github.com/EBIvariation","followers_url":"https://api.github.com/users/EBIvariation/followers","following_url":"https://api.github.com/users/EBIvariation/following{/other_user}","gists_url":"https://api.github.com/users/EBIvariation/gists{/gist_id}","starred_url":"https://api.github.com/users/EBIvariation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EBIvariation/subscriptions","organizations_url":"https://api.github.com/users/EBIvariation/orgs","repos_url":"https://api.github.com/users/EBIvariation/repos","events_url":"https://api.github.com/users/EBIvariation/events{/privacy}","received_events_url":"https://api.github.com/users/EBIvariation/received_events","type":"Organization","site_admin":false},"repo":{"id":125524220,"node_id":"MDEwOlJlcG9zaXRvcnkxMjU1MjQyMjA=","name":"metadata-ws","full_name":"EBIvariation/metadata-ws","private":false,"owner":{"login":"EBIvariation","id":6419333,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0MTkzMzM=","avatar_url":"https://avatars1.githubusercontent.com/u/6419333?v=4","gravatar_id":"","url":"https://api.github.com/users/EBIvariation","html_url":"https://github.com/EBIvariation","followers_url":"https://api.github.com/users/EBIvariation/followers","following_url":"https://api.github.com/users/EBIvariation/following{/other_user}","gists_url":"https://api.github.com/users/EBIvariation/gists{/gist_id}","starred_url":"https://api.github.com/users/EBIvariation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EBIvariation/subscriptions","organizations_url":"https://api.github.com/users/EBIvariation/orgs","repos_url":"https://api.github.com/users/EBIvariation/repos","events_url":"https://api.github.com/users/EBIvariation/events{/privacy}","received_events_url":"https://api.github.com/users/EBIvariation/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/EBIvariation/metadata-ws","description":"Generic REST API for submission metadata objects (usable by AMP T2D, EGA and EVA)","fork":false,"url":"https://api.github.com/repos/EBIvariation/metadata-ws","forks_url":"https://api.github.com/repos/EBIvariation/metadata-ws/forks","keys_url":"https://api.github.com/repos/EBIvariation/metadata-ws/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EBIvariation/metadata-ws/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EBIvariation/metadata-ws/teams","hooks_url":"https://api.github.com/repos/EBIvariation/metadata-ws/hooks","issue_events_url":"https://api.github.com/repos/EBIvariation/metadata-ws/issues/events{/number}","events_url":"https://api.github.com/repos/EBIvariation/metadata-ws/events","assignees_url":"https://api.github.com/repos/EBIvariation/metadata-ws/assignees{/user}","branches_url":"https://api.github.com/repos/EBIvariation/metadata-ws/branches{/branch}","tags_url":"https://api.github.com/repos/EBIvariation/metadata-ws/tags","blobs_url":"https://api.github.com/repos/EBIvariation/metadata-ws/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EBIvariation/metadata-ws/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EBIvariation/metadata-ws/git/refs{/sha}","trees_url":"https://api.github.com/repos/EBIvariation/metadata-ws/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EBIvariation/metadata-ws/statuses/{sha}","languages_url":"https://api.github.com/repos/EBIvariation/metadata-ws/languages","stargazers_url":"https://api.github.com/repos/EBIvariation/metadata-ws/stargazers","contributors_url":"https://api.github.com/repos/EBIvariation/metadata-ws/contributors","subscribers_url":"https://api.github.com/repos/EBIvariation/metadata-ws/subscribers","subscription_url":"https://api.github.com/repos/EBIvariation/metadata-ws/subscription","commits_url":"https://api.github.com/repos/EBIvariation/metadata-ws/commits{/sha}","git_commits_url":"https://api.github.com/repos/EBIvariation/metadata-ws/git/commits{/sha}","comments_url":"https://api.github.com/repos/EBIvariation/metadata-ws/comments{/number}","issue_comment_url":"https://api.github.com/repos/EBIvariation/metadata-ws/issues/comments{/number}","contents_url":"https://api.github.com/repos/EBIvariation/metadata-ws/contents/{+path}","compare_url":"https://api.github.com/repos/EBIvariation/metadata-ws/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EBIvariation/metadata-ws/merges","archive_url":"https://api.github.com/repos/EBIvariation/metadata-ws/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EBIvariation/metadata-ws/downloads","issues_url":"https://api.github.com/repos/EBIvariation/metadata-ws/issues{/number}","pulls_url":"https://api.github.com/repos/EBIvariation/metadata-ws/pulls{/number}","milestones_url":"https://api.github.com/repos/EBIvariation/metadata-ws/milestones{/number}","notifications_url":"https://api.github.com/repos/EBIvariation/metadata-ws/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EBIvariation/metadata-ws/labels{/name}","releases_url":"https://api.github.com/repos/EBIvariation/metadata-ws/releases{/id}","deployments_url":"https://api.github.com/repos/EBIvariation/metadata-ws/deployments","created_at":"2018-03-16T14:05:01Z","updated_at":"2018-10-19T12:36:50Z","pushed_at":"2018-10-23T11:30:53Z","git_url":"git://github.com/EBIvariation/metadata-ws.git","ssh_url":"git@github.com:EBIvariation/metadata-ws.git","clone_url":"https://github.com/EBIvariation/metadata-ws.git","svn_url":"https://github.com/EBIvariation/metadata-ws","homepage":"","size":300,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":5,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/EBIvariation/metadata-ws/pulls/36"},"html":{"href":"https://github.com/EBIvariation/metadata-ws/pull/36"},"issue":{"href":"https://api.github.com/repos/EBIvariation/metadata-ws/issues/36"},"comments":{"href":"https://api.github.com/repos/EBIvariation/metadata-ws/issues/36/comments"},"review_comments":{"href":"https://api.github.com/repos/EBIvariation/metadata-ws/pulls/36/comments"},"review_comment":{"href":"https://api.github.com/repos/EBIvariation/metadata-ws/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/EBIvariation/metadata-ws/pulls/36/commits"},"statuses":{"href":"https://api.github.com/repos/EBIvariation/metadata-ws/statuses/62c3f26cc2d409c3711ebccedfe2635a2a8adf02"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"selvaebi"}}