{"action":"created","comment":{"url":"https://api.github.com/repos/smartdevicelink/sdl_android/pulls/comments/190297479","pull_request_review_id":122645746,"id":190297479,"diff_hunk":"@@ -0,0 +1,158 @@\n+package com.smartdevicelink.proxy.rpc;\n+\n+import com.smartdevicelink.proxy.RPCStruct;\n+import java.util.Hashtable;\n+\n+/**\n+ *  A color class that stores RGB values\n+ * <p><b> Parameter List</b></p>\n+ * <table border=\"1\" rules=\"all\">\n+ * \t\t<tr>\n+ * \t\t\t<th>Name</th>\n+ * \t\t\t<th>Type</th>\n+ * \t\t    <th>Reg.</th>\n+ * \t\t    <th>Notes</th>\n+ * \t\t\t<th>Version Available</th>\n+ * \t\t</tr>\n+ * \t\t<tr>\n+ * \t\t\t<td>red</td>\n+ * \t\t\t<td>Integer</td>\n+ * \t\t\t<td>Y</td>\n+ * \t\t\t<td>\n+ * \t\t\t\t\t<ul>\n+ * \t\t\t\t\t<li>minvalue=\"0\"</li>\n+ * \t\t\t\t    <li>maxvalue=\"255\"</li>\n+ *\t\t\t\t\t</ul>\n+ *\t\t\t</td>\n+ * \t\t\t<td>SmartDeviceLink 4.7</td>\n+ * \t\t</tr>\n+ * \t\t<tr>\n+ * \t\t\t<td>green</td>\n+ * \t\t\t<td>Integer</td>\n+ * \t\t\t<td>Y</td>\n+ * \t\t\t<td>\n+ * \t\t\t\t\t<ul>\n+ * \t\t\t\t\t<li>minvalue=\"0\"</li>\n+ * \t\t\t\t    <li>maxvalue=\"255\"</li>\n+ *\t\t\t\t\t</ul>\n+ *\t\t\t</td>\n+ * \t\t\t<td>SmartDeviceLink 4.7</td>\n+ * \t\t</tr>\n+ * \t\t<tr>\n+ * \t\t\t<td>blue</td>\n+ * \t\t\t<td>Integer</td>\n+ * \t\t\t<td>Y</td>\n+ * \t\t\t<td>\n+ * \t\t\t\t\t<ul>\n+ * \t\t\t\t\t<li>minvalue=\"0\"</li>\n+ * \t\t\t\t    <li>maxvalue=\"255\"</li>\n+ *\t\t\t\t\t</ul>\n+ *\t\t\t</td>\n+ * \t\t\t<td>SmartDeviceLink 4.7</td>\n+ * \t\t</tr>\n+ * </table>\n+ * @since SmartDeviceLink 4.7\n+ */\n+public class RGBColor extends RPCStruct{\n+    public static final String KEY_RED = \"red\";\n+    public static final String KEY_GREEN = \"green\";\n+    public static final String KEY_BLUE = \"blue\";\n+    private static Integer minValue = 0;\n+    private static Integer maxValue = 255;","path":"sdl_android/src/main/java/com/smartdevicelink/proxy/rpc/RGBColor.java","position":61,"original_position":61,"commit_id":"c59ac056f39a76c0ae2b4fd4cfd49d6ea8e90433","original_commit_id":"c59ac056f39a76c0ae2b4fd4cfd49d6ea8e90433","user":{"login":"joeygrover","id":6579474,"avatar_url":"https://avatars1.githubusercontent.com/u/6579474?v=4","gravatar_id":"","url":"https://api.github.com/users/joeygrover","html_url":"https://github.com/joeygrover","followers_url":"https://api.github.com/users/joeygrover/followers","following_url":"https://api.github.com/users/joeygrover/following{/other_user}","gists_url":"https://api.github.com/users/joeygrover/gists{/gist_id}","starred_url":"https://api.github.com/users/joeygrover/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joeygrover/subscriptions","organizations_url":"https://api.github.com/users/joeygrover/orgs","repos_url":"https://api.github.com/users/joeygrover/repos","events_url":"https://api.github.com/users/joeygrover/events{/privacy}","received_events_url":"https://api.github.com/users/joeygrover/received_events","type":"User","site_admin":false},"body":"this can be a single line as well as including `final` modifier ","created_at":"2018-05-23T15:38:28Z","updated_at":"2018-05-23T15:38:29Z","html_url":"https://github.com/smartdevicelink/sdl_android/pull/744#discussion_r190297479","pull_request_url":"https://api.github.com/repos/smartdevicelink/sdl_android/pulls/744","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/smartdevicelink/sdl_android/pulls/comments/190297479"},"html":{"href":"https://github.com/smartdevicelink/sdl_android/pull/744#discussion_r190297479"},"pull_request":{"href":"https://api.github.com/repos/smartdevicelink/sdl_android/pulls/744"}}},"pull_request":{"url":"https://api.github.com/repos/smartdevicelink/sdl_android/pulls/744","id":184438217,"html_url":"https://github.com/smartdevicelink/sdl_android/pull/744","diff_url":"https://github.com/smartdevicelink/sdl_android/pull/744.diff","patch_url":"https://github.com/smartdevicelink/sdl_android/pull/744.patch","issue_url":"https://api.github.com/repos/smartdevicelink/sdl_android/issues/744","number":744,"state":"open","locked":false,"title":"Feature/issue 715  - [SDL 0147] Template Improvements: Color Scheme","user":{"login":"bilal-alsharifi","id":599206,"avatar_url":"https://avatars2.githubusercontent.com/u/599206?v=4","gravatar_id":"","url":"https://api.github.com/users/bilal-alsharifi","html_url":"https://github.com/bilal-alsharifi","followers_url":"https://api.github.com/users/bilal-alsharifi/followers","following_url":"https://api.github.com/users/bilal-alsharifi/following{/other_user}","gists_url":"https://api.github.com/users/bilal-alsharifi/gists{/gist_id}","starred_url":"https://api.github.com/users/bilal-alsharifi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bilal-alsharifi/subscriptions","organizations_url":"https://api.github.com/users/bilal-alsharifi/orgs","repos_url":"https://api.github.com/users/bilal-alsharifi/repos","events_url":"https://api.github.com/users/bilal-alsharifi/events{/privacy}","received_events_url":"https://api.github.com/users/bilal-alsharifi/received_events","type":"User","site_admin":false},"body":"Fixes #715\r\n\r\nThis PR is **ready** for review.\r\n\r\n### Risk\r\nThis PR makes **minor** API changes.\r\n\r\n### Testing Plan\r\n* Updated the unit tests and added new ones to test  template color schemes\r\n* Printed the JSON request to make sure that colors are included in the request\r\n\r\n### Summary\r\nThis PR implements the template color scheme as described in the proposal\r\n\r\n### CLA\r\n- [x] I have signed [the CLA](https://docs.google.com/forms/d/e/1FAIpQLSdsgJY33VByaX482zHzi-xUm49JNnmuJOyAM6uegPQ2LXYVfA/viewform)","created_at":"2018-04-26T19:17:51Z","updated_at":"2018-05-23T15:38:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0e867c15762ec3593a46f0096a5d2a823021b169","assignee":null,"assignees":[],"requested_reviewers":[{"login":"brettywhite","id":3911458,"avatar_url":"https://avatars0.githubusercontent.com/u/3911458?v=4","gravatar_id":"","url":"https://api.github.com/users/brettywhite","html_url":"https://github.com/brettywhite","followers_url":"https://api.github.com/users/brettywhite/followers","following_url":"https://api.github.com/users/brettywhite/following{/other_user}","gists_url":"https://api.github.com/users/brettywhite/gists{/gist_id}","starred_url":"https://api.github.com/users/brettywhite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brettywhite/subscriptions","organizations_url":"https://api.github.com/users/brettywhite/orgs","repos_url":"https://api.github.com/users/brettywhite/repos","events_url":"https://api.github.com/users/brettywhite/events{/privacy}","received_events_url":"https://api.github.com/users/brettywhite/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/smartdevicelink/sdl_android/pulls/744/commits","review_comments_url":"https://api.github.com/repos/smartdevicelink/sdl_android/pulls/744/comments","review_comment_url":"https://api.github.com/repos/smartdevicelink/sdl_android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/smartdevicelink/sdl_android/issues/744/comments","statuses_url":"https://api.github.com/repos/smartdevicelink/sdl_android/statuses/c59ac056f39a76c0ae2b4fd4cfd49d6ea8e90433","head":{"label":"smartdevicelink:feature/issue_715","ref":"feature/issue_715","sha":"c59ac056f39a76c0ae2b4fd4cfd49d6ea8e90433","user":{"login":"smartdevicelink","id":8671397,"avatar_url":"https://avatars3.githubusercontent.com/u/8671397?v=4","gravatar_id":"","url":"https://api.github.com/users/smartdevicelink","html_url":"https://github.com/smartdevicelink","followers_url":"https://api.github.com/users/smartdevicelink/followers","following_url":"https://api.github.com/users/smartdevicelink/following{/other_user}","gists_url":"https://api.github.com/users/smartdevicelink/gists{/gist_id}","starred_url":"https://api.github.com/users/smartdevicelink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartdevicelink/subscriptions","organizations_url":"https://api.github.com/users/smartdevicelink/orgs","repos_url":"https://api.github.com/users/smartdevicelink/repos","events_url":"https://api.github.com/users/smartdevicelink/events{/privacy}","received_events_url":"https://api.github.com/users/smartdevicelink/received_events","type":"Organization","site_admin":false},"repo":{"id":24610319,"name":"sdl_android","full_name":"smartdevicelink/sdl_android","owner":{"login":"smartdevicelink","id":8671397,"avatar_url":"https://avatars3.githubusercontent.com/u/8671397?v=4","gravatar_id":"","url":"https://api.github.com/users/smartdevicelink","html_url":"https://github.com/smartdevicelink","followers_url":"https://api.github.com/users/smartdevicelink/followers","following_url":"https://api.github.com/users/smartdevicelink/following{/other_user}","gists_url":"https://api.github.com/users/smartdevicelink/gists{/gist_id}","starred_url":"https://api.github.com/users/smartdevicelink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartdevicelink/subscriptions","organizations_url":"https://api.github.com/users/smartdevicelink/orgs","repos_url":"https://api.github.com/users/smartdevicelink/repos","events_url":"https://api.github.com/users/smartdevicelink/events{/privacy}","received_events_url":"https://api.github.com/users/smartdevicelink/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/smartdevicelink/sdl_android","description":"SmartDeviceLink mobile library for Android","fork":false,"url":"https://api.github.com/repos/smartdevicelink/sdl_android","forks_url":"https://api.github.com/repos/smartdevicelink/sdl_android/forks","keys_url":"https://api.github.com/repos/smartdevicelink/sdl_android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smartdevicelink/sdl_android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smartdevicelink/sdl_android/teams","hooks_url":"https://api.github.com/repos/smartdevicelink/sdl_android/hooks","issue_events_url":"https://api.github.com/repos/smartdevicelink/sdl_android/issues/events{/number}","events_url":"https://api.github.com/repos/smartdevicelink/sdl_android/events","assignees_url":"https://api.github.com/repos/smartdevicelink/sdl_android/assignees{/user}","branches_url":"https://api.github.com/repos/smartdevicelink/sdl_android/branches{/branch}","tags_url":"https://api.github.com/repos/smartdevicelink/sdl_android/tags","blobs_url":"https://api.github.com/repos/smartdevicelink/sdl_android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smartdevicelink/sdl_android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smartdevicelink/sdl_android/git/refs{/sha}","trees_url":"https://api.github.com/repos/smartdevicelink/sdl_android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smartdevicelink/sdl_android/statuses/{sha}","languages_url":"https://api.github.com/repos/smartdevicelink/sdl_android/languages","stargazers_url":"https://api.github.com/repos/smartdevicelink/sdl_android/stargazers","contributors_url":"https://api.github.com/repos/smartdevicelink/sdl_android/contributors","subscribers_url":"https://api.github.com/repos/smartdevicelink/sdl_android/subscribers","subscription_url":"https://api.github.com/repos/smartdevicelink/sdl_android/subscription","commits_url":"https://api.github.com/repos/smartdevicelink/sdl_android/commits{/sha}","git_commits_url":"https://api.github.com/repos/smartdevicelink/sdl_android/git/commits{/sha}","comments_url":"https://api.github.com/repos/smartdevicelink/sdl_android/comments{/number}","issue_comment_url":"https://api.github.com/repos/smartdevicelink/sdl_android/issues/comments{/number}","contents_url":"https://api.github.com/repos/smartdevicelink/sdl_android/contents/{+path}","compare_url":"https://api.github.com/repos/smartdevicelink/sdl_android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smartdevicelink/sdl_android/merges","archive_url":"https://api.github.com/repos/smartdevicelink/sdl_android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smartdevicelink/sdl_android/downloads","issues_url":"https://api.github.com/repos/smartdevicelink/sdl_android/issues{/number}","pulls_url":"https://api.github.com/repos/smartdevicelink/sdl_android/pulls{/number}","milestones_url":"https://api.github.com/repos/smartdevicelink/sdl_android/milestones{/number}","notifications_url":"https://api.github.com/repos/smartdevicelink/sdl_android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smartdevicelink/sdl_android/labels{/name}","releases_url":"https://api.github.com/repos/smartdevicelink/sdl_android/releases{/id}","deployments_url":"https://api.github.com/repos/smartdevicelink/sdl_android/deployments","created_at":"2014-09-29T19:49:09Z","updated_at":"2018-05-10T09:50:41Z","pushed_at":"2018-05-23T15:19:11Z","git_url":"git://github.com/smartdevicelink/sdl_android.git","ssh_url":"git@github.com:smartdevicelink/sdl_android.git","clone_url":"https://github.com/smartdevicelink/sdl_android.git","svn_url":"https://github.com/smartdevicelink/sdl_android","homepage":"","size":6770,"stargazers_count":110,"watchers_count":110,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":78,"mirror_url":null,"archived":false,"open_issues_count":140,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":78,"open_issues":140,"watchers":110,"default_branch":"master"}},"base":{"label":"smartdevicelink:develop","ref":"develop","sha":"4bc9649b311958520bd71ac555d373dc7d9676ea","user":{"login":"smartdevicelink","id":8671397,"avatar_url":"https://avatars3.githubusercontent.com/u/8671397?v=4","gravatar_id":"","url":"https://api.github.com/users/smartdevicelink","html_url":"https://github.com/smartdevicelink","followers_url":"https://api.github.com/users/smartdevicelink/followers","following_url":"https://api.github.com/users/smartdevicelink/following{/other_user}","gists_url":"https://api.github.com/users/smartdevicelink/gists{/gist_id}","starred_url":"https://api.github.com/users/smartdevicelink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartdevicelink/subscriptions","organizations_url":"https://api.github.com/users/smartdevicelink/orgs","repos_url":"https://api.github.com/users/smartdevicelink/repos","events_url":"https://api.github.com/users/smartdevicelink/events{/privacy}","received_events_url":"https://api.github.com/users/smartdevicelink/received_events","type":"Organization","site_admin":false},"repo":{"id":24610319,"name":"sdl_android","full_name":"smartdevicelink/sdl_android","owner":{"login":"smartdevicelink","id":8671397,"avatar_url":"https://avatars3.githubusercontent.com/u/8671397?v=4","gravatar_id":"","url":"https://api.github.com/users/smartdevicelink","html_url":"https://github.com/smartdevicelink","followers_url":"https://api.github.com/users/smartdevicelink/followers","following_url":"https://api.github.com/users/smartdevicelink/following{/other_user}","gists_url":"https://api.github.com/users/smartdevicelink/gists{/gist_id}","starred_url":"https://api.github.com/users/smartdevicelink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartdevicelink/subscriptions","organizations_url":"https://api.github.com/users/smartdevicelink/orgs","repos_url":"https://api.github.com/users/smartdevicelink/repos","events_url":"https://api.github.com/users/smartdevicelink/events{/privacy}","received_events_url":"https://api.github.com/users/smartdevicelink/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/smartdevicelink/sdl_android","description":"SmartDeviceLink mobile library for Android","fork":false,"url":"https://api.github.com/repos/smartdevicelink/sdl_android","forks_url":"https://api.github.com/repos/smartdevicelink/sdl_android/forks","keys_url":"https://api.github.com/repos/smartdevicelink/sdl_android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smartdevicelink/sdl_android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smartdevicelink/sdl_android/teams","hooks_url":"https://api.github.com/repos/smartdevicelink/sdl_android/hooks","issue_events_url":"https://api.github.com/repos/smartdevicelink/sdl_android/issues/events{/number}","events_url":"https://api.github.com/repos/smartdevicelink/sdl_android/events","assignees_url":"https://api.github.com/repos/smartdevicelink/sdl_android/assignees{/user}","branches_url":"https://api.github.com/repos/smartdevicelink/sdl_android/branches{/branch}","tags_url":"https://api.github.com/repos/smartdevicelink/sdl_android/tags","blobs_url":"https://api.github.com/repos/smartdevicelink/sdl_android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smartdevicelink/sdl_android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smartdevicelink/sdl_android/git/refs{/sha}","trees_url":"https://api.github.com/repos/smartdevicelink/sdl_android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smartdevicelink/sdl_android/statuses/{sha}","languages_url":"https://api.github.com/repos/smartdevicelink/sdl_android/languages","stargazers_url":"https://api.github.com/repos/smartdevicelink/sdl_android/stargazers","contributors_url":"https://api.github.com/repos/smartdevicelink/sdl_android/contributors","subscribers_url":"https://api.github.com/repos/smartdevicelink/sdl_android/subscribers","subscription_url":"https://api.github.com/repos/smartdevicelink/sdl_android/subscription","commits_url":"https://api.github.com/repos/smartdevicelink/sdl_android/commits{/sha}","git_commits_url":"https://api.github.com/repos/smartdevicelink/sdl_android/git/commits{/sha}","comments_url":"https://api.github.com/repos/smartdevicelink/sdl_android/comments{/number}","issue_comment_url":"https://api.github.com/repos/smartdevicelink/sdl_android/issues/comments{/number}","contents_url":"https://api.github.com/repos/smartdevicelink/sdl_android/contents/{+path}","compare_url":"https://api.github.com/repos/smartdevicelink/sdl_android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smartdevicelink/sdl_android/merges","archive_url":"https://api.github.com/repos/smartdevicelink/sdl_android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smartdevicelink/sdl_android/downloads","issues_url":"https://api.github.com/repos/smartdevicelink/sdl_android/issues{/number}","pulls_url":"https://api.github.com/repos/smartdevicelink/sdl_android/pulls{/number}","milestones_url":"https://api.github.com/repos/smartdevicelink/sdl_android/milestones{/number}","notifications_url":"https://api.github.com/repos/smartdevicelink/sdl_android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smartdevicelink/sdl_android/labels{/name}","releases_url":"https://api.github.com/repos/smartdevicelink/sdl_android/releases{/id}","deployments_url":"https://api.github.com/repos/smartdevicelink/sdl_android/deployments","created_at":"2014-09-29T19:49:09Z","updated_at":"2018-05-10T09:50:41Z","pushed_at":"2018-05-23T15:19:11Z","git_url":"git://github.com/smartdevicelink/sdl_android.git","ssh_url":"git@github.com:smartdevicelink/sdl_android.git","clone_url":"https://github.com/smartdevicelink/sdl_android.git","svn_url":"https://github.com/smartdevicelink/sdl_android","homepage":"","size":6770,"stargazers_count":110,"watchers_count":110,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":78,"mirror_url":null,"archived":false,"open_issues_count":140,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":78,"open_issues":140,"watchers":110,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/smartdevicelink/sdl_android/pulls/744"},"html":{"href":"https://github.com/smartdevicelink/sdl_android/pull/744"},"issue":{"href":"https://api.github.com/repos/smartdevicelink/sdl_android/issues/744"},"comments":{"href":"https://api.github.com/repos/smartdevicelink/sdl_android/issues/744/comments"},"review_comments":{"href":"https://api.github.com/repos/smartdevicelink/sdl_android/pulls/744/comments"},"review_comment":{"href":"https://api.github.com/repos/smartdevicelink/sdl_android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/smartdevicelink/sdl_android/pulls/744/commits"},"statuses":{"href":"https://api.github.com/repos/smartdevicelink/sdl_android/statuses/c59ac056f39a76c0ae2b4fd4cfd49d6ea8e90433"}},"author_association":"NONE"}}
{"actor":{"display_login":"joeygrover"}}