{"action":"created","issue":{"url":"https://api.github.com/repos/pejulian/romcal/issues/10","repository_url":"https://api.github.com/repos/pejulian/romcal","labels_url":"https://api.github.com/repos/pejulian/romcal/issues/10/labels{/name}","comments_url":"https://api.github.com/repos/pejulian/romcal/issues/10/comments","events_url":"https://api.github.com/repos/pejulian/romcal/issues/10/events","html_url":"https://github.com/pejulian/romcal/issues/10","id":302078427,"number":10,"title":"duplicate feasts: Sts Cyril and Methodius (Slovakian calendar) and others","user":{"login":"tukusejssirs","id":5111894,"avatar_url":"https://avatars1.githubusercontent.com/u/5111894?v=4","gravatar_id":"","url":"https://api.github.com/users/tukusejssirs","html_url":"https://github.com/tukusejssirs","followers_url":"https://api.github.com/users/tukusejssirs/followers","following_url":"https://api.github.com/users/tukusejssirs/following{/other_user}","gists_url":"https://api.github.com/users/tukusejssirs/gists{/gist_id}","starred_url":"https://api.github.com/users/tukusejssirs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tukusejssirs/subscriptions","organizations_url":"https://api.github.com/users/tukusejssirs/orgs","repos_url":"https://api.github.com/users/tukusejssirs/repos","events_url":"https://api.github.com/users/tukusejssirs/events{/privacy}","received_events_url":"https://api.github.com/users/tukusejssirs/received_events","type":"User","site_admin":false},"labels":[{"id":116837225,"url":"https://api.github.com/repos/pejulian/romcal/labels/bug","name":"bug","color":"fc2929","default":true}],"state":"open","locked":false,"assignee":{"login":"pejulian","id":4044311,"avatar_url":"https://avatars3.githubusercontent.com/u/4044311?v=4","gravatar_id":"","url":"https://api.github.com/users/pejulian","html_url":"https://github.com/pejulian","followers_url":"https://api.github.com/users/pejulian/followers","following_url":"https://api.github.com/users/pejulian/following{/other_user}","gists_url":"https://api.github.com/users/pejulian/gists{/gist_id}","starred_url":"https://api.github.com/users/pejulian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pejulian/subscriptions","organizations_url":"https://api.github.com/users/pejulian/orgs","repos_url":"https://api.github.com/users/pejulian/repos","events_url":"https://api.github.com/users/pejulian/events{/privacy}","received_events_url":"https://api.github.com/users/pejulian/received_events","type":"User","site_admin":false},"assignees":[{"login":"pejulian","id":4044311,"avatar_url":"https://avatars3.githubusercontent.com/u/4044311?v=4","gravatar_id":"","url":"https://api.github.com/users/pejulian","html_url":"https://github.com/pejulian","followers_url":"https://api.github.com/users/pejulian/followers","following_url":"https://api.github.com/users/pejulian/following{/other_user}","gists_url":"https://api.github.com/users/pejulian/gists{/gist_id}","starred_url":"https://api.github.com/users/pejulian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pejulian/subscriptions","organizations_url":"https://api.github.com/users/pejulian/orgs","repos_url":"https://api.github.com/users/pejulian/repos","events_url":"https://api.github.com/users/pejulian/events{/privacy}","received_events_url":"https://api.github.com/users/pejulian/received_events","type":"User","site_admin":false}],"milestone":null,"comments":14,"created_at":"2018-03-04T11:35:29Z","updated_at":"2018-03-05T11:27:28Z","closed_at":null,"author_association":"NONE","body":"I’ve just found out that the Sts Cyril and Methodius have two feast days in the output of `romcal`. One is according to General Roman Calendar on 14th February (which is never celebrated in Slovakia) and the other on 5th July (which is always celebrated in Slovakia, as it is a feast and public holiday in Slovakia).\r\n\r\nHere are the lines I found:\r\n\r\n```bash\r\n$ cat calendars/slovakia.js | grep -nA4 -B2 Cyril\r\n14-    var dates = [\r\n15-      {\r\n16:        \"key\": \"saintsCyrilMonkAndMethodiusBishop\",\r\n17-        \"type\": Types[4],\r\n18-        \"moment\": moment.utc({ year: arguments[0], month: 1, day: 14 }),\r\n19-        \"data\": {\r\n20-          \"meta\": {\r\n--\r\n105-      },\r\n106-      {\r\n107:        \"key\": \"saintsCyrilAndMethodiusSlavicMissionaries\",\r\n108-        \"type\": Types[0],\r\n109-        \"moment\": moment.utc({ year: arguments[0], month: 6, day: 5 }),\r\n110-        \"data\": {}\r\n111-      },\r\n```\r\n\r\nI suggest to remove the first one from the Slovakian calendar (`calendar/slovakia.js`)."},"comment":{"url":"https://api.github.com/repos/pejulian/romcal/issues/comments/370390745","html_url":"https://github.com/pejulian/romcal/issues/10#issuecomment-370390745","issue_url":"https://api.github.com/repos/pejulian/romcal/issues/10","id":370390745,"user":{"login":"tukusejssirs","id":5111894,"avatar_url":"https://avatars1.githubusercontent.com/u/5111894?v=4","gravatar_id":"","url":"https://api.github.com/users/tukusejssirs","html_url":"https://github.com/tukusejssirs","followers_url":"https://api.github.com/users/tukusejssirs/followers","following_url":"https://api.github.com/users/tukusejssirs/following{/other_user}","gists_url":"https://api.github.com/users/tukusejssirs/gists{/gist_id}","starred_url":"https://api.github.com/users/tukusejssirs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tukusejssirs/subscriptions","organizations_url":"https://api.github.com/users/tukusejssirs/orgs","repos_url":"https://api.github.com/users/tukusejssirs/repos","events_url":"https://api.github.com/users/tukusejssirs/events{/privacy}","received_events_url":"https://api.github.com/users/tukusejssirs/received_events","type":"User","site_admin":false},"created_at":"2018-03-05T11:27:28Z","updated_at":"2018-03-05T11:27:28Z","author_association":"NONE","body":"$ cat en.mjs | grep -in alexandr\r\n143:    \"saintCyrilOfAlexandriaBishopAndDoctor\": \"Saint Cyril of Alexandria, Bishop and Doctor\",\r\n236:    \"saintCatherineOfAlexandriaVirginAndMartyr\": \"Saint Catherine of Alexandria, Virgin and Martyr\",\r\n497:    \"saintCyrilOfAlexandriaBishopAndDoctor\": \"Saint Cyril of Alexandria, Bishop and Doctor\",\r\n616:    \"saintCatherineOfAlexandriaVirginAndMartyr\": \"Saint Catherine of Alexandria, Virgin and Martyr\","}}
{"actor":{"display_login":"tukusejssirs"}}