{"action":"created","comment":{"url":"https://api.github.com/repos/QCoDeS/Qcodes/pulls/comments/213008827","pull_request_review_id":149752514,"id":213008827,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMzAwODgyNw==","diff_hunk":"@@ -918,3 +1017,95 @@ def _set_sensitivity(self, s):\n             return self._VOLT_TO_N[s]\n         else:\n             return self._CURR_TO_N[s]\n+\n+    def get_values(self, *parameter_names: str) -> Tuple[float, ...]:\n+        \"\"\"\n+        Get values of 2 or 3 parameters that are measured by the lock-in\n+        amplifier. These values are guaranteed to come from the same\n+        measurement cycle as opposed to getting values of parameters one by\n+        one (for example, by calling `sr.X()`, and then `sr.Y()`.\n+\n+        Args:\n+            *parameter_names\n+                2 or 3 names of parameters for which the values are\n+                requested; valid names can be found in `PARAMETER_NAMES`\n+                attribute of the driver class\n+\n+        Returns:\n+            a tuple of 2 or 3 floating point values\n+\n+        \"\"\"\n+        if not 2 <= len(parameter_names) <= 3:\n+            raise KeyError(\n+                'It is possible to request values of only 2 or 3 parameters '\n+                'at a time.')\n+\n+        for name in parameter_names:\n+            if name not in self.PARAMETER_NAMES:\n+                raise KeyError(f'{name} is not a valid parameter name. Refer '\n+                               f'to `_PARAMETER_NAMES` for a list of valid '","path":"qcodes/instrument_drivers/stanford_research/SR86x.py","position":162,"original_position":162,"commit_id":"7465f0ca5b8ed92887206fcb7c17a3aa962d4012","original_commit_id":"7465f0ca5b8ed92887206fcb7c17a3aa962d4012","user":{"login":"astafan8","id":15662810,"node_id":"MDQ6VXNlcjE1NjYyODEw","avatar_url":"https://avatars3.githubusercontent.com/u/15662810?v=4","gravatar_id":"","url":"https://api.github.com/users/astafan8","html_url":"https://github.com/astafan8","followers_url":"https://api.github.com/users/astafan8/followers","following_url":"https://api.github.com/users/astafan8/following{/other_user}","gists_url":"https://api.github.com/users/astafan8/gists{/gist_id}","starred_url":"https://api.github.com/users/astafan8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astafan8/subscriptions","organizations_url":"https://api.github.com/users/astafan8/orgs","repos_url":"https://api.github.com/users/astafan8/repos","events_url":"https://api.github.com/users/astafan8/events{/privacy}","received_events_url":"https://api.github.com/users/astafan8/received_events","type":"User","site_admin":false},"body":"oops. you're right.","created_at":"2018-08-27T15:06:14Z","updated_at":"2018-08-27T15:06:14Z","html_url":"https://github.com/QCoDeS/Qcodes/pull/1245#discussion_r213008827","pull_request_url":"https://api.github.com/repos/QCoDeS/Qcodes/pulls/1245","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/QCoDeS/Qcodes/pulls/comments/213008827"},"html":{"href":"https://github.com/QCoDeS/Qcodes/pull/1245#discussion_r213008827"},"pull_request":{"href":"https://api.github.com/repos/QCoDeS/Qcodes/pulls/1245"}},"in_reply_to_id":212993923},"pull_request":{"url":"https://api.github.com/repos/QCoDeS/Qcodes/pulls/1245","id":210523732,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwNTIzNzMy","html_url":"https://github.com/QCoDeS/Qcodes/pull/1245","diff_url":"https://github.com/QCoDeS/Qcodes/pull/1245.diff","patch_url":"https://github.com/QCoDeS/Qcodes/pull/1245.patch","issue_url":"https://api.github.com/repos/QCoDeS/Qcodes/issues/1245","number":1245,"state":"open","locked":false,"title":"SR86x lockin: get values of many parameters at once","user":{"login":"astafan8","id":15662810,"node_id":"MDQ6VXNlcjE1NjYyODEw","avatar_url":"https://avatars3.githubusercontent.com/u/15662810?v=4","gravatar_id":"","url":"https://api.github.com/users/astafan8","html_url":"https://github.com/astafan8","followers_url":"https://api.github.com/users/astafan8/followers","following_url":"https://api.github.com/users/astafan8/following{/other_user}","gists_url":"https://api.github.com/users/astafan8/gists{/gist_id}","starred_url":"https://api.github.com/users/astafan8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astafan8/subscriptions","organizations_url":"https://api.github.com/users/astafan8/orgs","repos_url":"https://api.github.com/users/astafan8/repos","events_url":"https://api.github.com/users/astafan8/events{/privacy}","received_events_url":"https://api.github.com/users/astafan8/received_events","type":"User","site_admin":false},"body":"Adds the possibility to return multiple measured values at the same time, `get_values` by implementing corresponding visa commands. Also, add data channels, `data_channels`, which also allow to return 4 values of parameters assigned to them at once.\r\n\r\nToDo:\r\n- [x] final testing on device\r\n- [x] update example notebook\r\n","created_at":"2018-08-23T17:39:10Z","updated_at":"2018-08-27T15:06:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f8de79b42e6174be279b44febeadfd085df9198d","assignee":{"login":"astafan8","id":15662810,"node_id":"MDQ6VXNlcjE1NjYyODEw","avatar_url":"https://avatars3.githubusercontent.com/u/15662810?v=4","gravatar_id":"","url":"https://api.github.com/users/astafan8","html_url":"https://github.com/astafan8","followers_url":"https://api.github.com/users/astafan8/followers","following_url":"https://api.github.com/users/astafan8/following{/other_user}","gists_url":"https://api.github.com/users/astafan8/gists{/gist_id}","starred_url":"https://api.github.com/users/astafan8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astafan8/subscriptions","organizations_url":"https://api.github.com/users/astafan8/orgs","repos_url":"https://api.github.com/users/astafan8/repos","events_url":"https://api.github.com/users/astafan8/events{/privacy}","received_events_url":"https://api.github.com/users/astafan8/received_events","type":"User","site_admin":false},"assignees":[{"login":"astafan8","id":15662810,"node_id":"MDQ6VXNlcjE1NjYyODEw","avatar_url":"https://avatars3.githubusercontent.com/u/15662810?v=4","gravatar_id":"","url":"https://api.github.com/users/astafan8","html_url":"https://github.com/astafan8","followers_url":"https://api.github.com/users/astafan8/followers","following_url":"https://api.github.com/users/astafan8/following{/other_user}","gists_url":"https://api.github.com/users/astafan8/gists{/gist_id}","starred_url":"https://api.github.com/users/astafan8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astafan8/subscriptions","organizations_url":"https://api.github.com/users/astafan8/orgs","repos_url":"https://api.github.com/users/astafan8/repos","events_url":"https://api.github.com/users/astafan8/events{/privacy}","received_events_url":"https://api.github.com/users/astafan8/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"WilliamHPNielsen","id":23165537,"node_id":"MDQ6VXNlcjIzMTY1NTM3","avatar_url":"https://avatars3.githubusercontent.com/u/23165537?v=4","gravatar_id":"","url":"https://api.github.com/users/WilliamHPNielsen","html_url":"https://github.com/WilliamHPNielsen","followers_url":"https://api.github.com/users/WilliamHPNielsen/followers","following_url":"https://api.github.com/users/WilliamHPNielsen/following{/other_user}","gists_url":"https://api.github.com/users/WilliamHPNielsen/gists{/gist_id}","starred_url":"https://api.github.com/users/WilliamHPNielsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WilliamHPNielsen/subscriptions","organizations_url":"https://api.github.com/users/WilliamHPNielsen/orgs","repos_url":"https://api.github.com/users/WilliamHPNielsen/repos","events_url":"https://api.github.com/users/WilliamHPNielsen/events{/privacy}","received_events_url":"https://api.github.com/users/WilliamHPNielsen/received_events","type":"User","site_admin":false},{"login":"Dominik-Vogel","id":30660470,"node_id":"MDQ6VXNlcjMwNjYwNDcw","avatar_url":"https://avatars2.githubusercontent.com/u/30660470?v=4","gravatar_id":"","url":"https://api.github.com/users/Dominik-Vogel","html_url":"https://github.com/Dominik-Vogel","followers_url":"https://api.github.com/users/Dominik-Vogel/followers","following_url":"https://api.github.com/users/Dominik-Vogel/following{/other_user}","gists_url":"https://api.github.com/users/Dominik-Vogel/gists{/gist_id}","starred_url":"https://api.github.com/users/Dominik-Vogel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dominik-Vogel/subscriptions","organizations_url":"https://api.github.com/users/Dominik-Vogel/orgs","repos_url":"https://api.github.com/users/Dominik-Vogel/repos","events_url":"https://api.github.com/users/Dominik-Vogel/events{/privacy}","received_events_url":"https://api.github.com/users/Dominik-Vogel/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":443708179,"node_id":"MDU6TGFiZWw0NDM3MDgxNzk=","url":"https://api.github.com/repos/QCoDeS/Qcodes/labels/driver","name":"driver","color":"c5def5","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/QCoDeS/Qcodes/pulls/1245/commits","review_comments_url":"https://api.github.com/repos/QCoDeS/Qcodes/pulls/1245/comments","review_comment_url":"https://api.github.com/repos/QCoDeS/Qcodes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/QCoDeS/Qcodes/issues/1245/comments","statuses_url":"https://api.github.com/repos/QCoDeS/Qcodes/statuses/7465f0ca5b8ed92887206fcb7c17a3aa962d4012","head":{"label":"astafan8:driver/SR86x/get-many-values-at-once","ref":"driver/SR86x/get-many-values-at-once","sha":"7465f0ca5b8ed92887206fcb7c17a3aa962d4012","user":{"login":"astafan8","id":15662810,"node_id":"MDQ6VXNlcjE1NjYyODEw","avatar_url":"https://avatars3.githubusercontent.com/u/15662810?v=4","gravatar_id":"","url":"https://api.github.com/users/astafan8","html_url":"https://github.com/astafan8","followers_url":"https://api.github.com/users/astafan8/followers","following_url":"https://api.github.com/users/astafan8/following{/other_user}","gists_url":"https://api.github.com/users/astafan8/gists{/gist_id}","starred_url":"https://api.github.com/users/astafan8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astafan8/subscriptions","organizations_url":"https://api.github.com/users/astafan8/orgs","repos_url":"https://api.github.com/users/astafan8/repos","events_url":"https://api.github.com/users/astafan8/events{/privacy}","received_events_url":"https://api.github.com/users/astafan8/received_events","type":"User","site_admin":false},"repo":{"id":136181997,"node_id":"MDEwOlJlcG9zaXRvcnkxMzYxODE5OTc=","name":"Qcodes","full_name":"astafan8/Qcodes","owner":{"login":"astafan8","id":15662810,"node_id":"MDQ6VXNlcjE1NjYyODEw","avatar_url":"https://avatars3.githubusercontent.com/u/15662810?v=4","gravatar_id":"","url":"https://api.github.com/users/astafan8","html_url":"https://github.com/astafan8","followers_url":"https://api.github.com/users/astafan8/followers","following_url":"https://api.github.com/users/astafan8/following{/other_user}","gists_url":"https://api.github.com/users/astafan8/gists{/gist_id}","starred_url":"https://api.github.com/users/astafan8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astafan8/subscriptions","organizations_url":"https://api.github.com/users/astafan8/orgs","repos_url":"https://api.github.com/users/astafan8/repos","events_url":"https://api.github.com/users/astafan8/events{/privacy}","received_events_url":"https://api.github.com/users/astafan8/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/astafan8/Qcodes","description":"Modular data acquisition framework","fork":true,"url":"https://api.github.com/repos/astafan8/Qcodes","forks_url":"https://api.github.com/repos/astafan8/Qcodes/forks","keys_url":"https://api.github.com/repos/astafan8/Qcodes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/astafan8/Qcodes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/astafan8/Qcodes/teams","hooks_url":"https://api.github.com/repos/astafan8/Qcodes/hooks","issue_events_url":"https://api.github.com/repos/astafan8/Qcodes/issues/events{/number}","events_url":"https://api.github.com/repos/astafan8/Qcodes/events","assignees_url":"https://api.github.com/repos/astafan8/Qcodes/assignees{/user}","branches_url":"https://api.github.com/repos/astafan8/Qcodes/branches{/branch}","tags_url":"https://api.github.com/repos/astafan8/Qcodes/tags","blobs_url":"https://api.github.com/repos/astafan8/Qcodes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/astafan8/Qcodes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/astafan8/Qcodes/git/refs{/sha}","trees_url":"https://api.github.com/repos/astafan8/Qcodes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/astafan8/Qcodes/statuses/{sha}","languages_url":"https://api.github.com/repos/astafan8/Qcodes/languages","stargazers_url":"https://api.github.com/repos/astafan8/Qcodes/stargazers","contributors_url":"https://api.github.com/repos/astafan8/Qcodes/contributors","subscribers_url":"https://api.github.com/repos/astafan8/Qcodes/subscribers","subscription_url":"https://api.github.com/repos/astafan8/Qcodes/subscription","commits_url":"https://api.github.com/repos/astafan8/Qcodes/commits{/sha}","git_commits_url":"https://api.github.com/repos/astafan8/Qcodes/git/commits{/sha}","comments_url":"https://api.github.com/repos/astafan8/Qcodes/comments{/number}","issue_comment_url":"https://api.github.com/repos/astafan8/Qcodes/issues/comments{/number}","contents_url":"https://api.github.com/repos/astafan8/Qcodes/contents/{+path}","compare_url":"https://api.github.com/repos/astafan8/Qcodes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/astafan8/Qcodes/merges","archive_url":"https://api.github.com/repos/astafan8/Qcodes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/astafan8/Qcodes/downloads","issues_url":"https://api.github.com/repos/astafan8/Qcodes/issues{/number}","pulls_url":"https://api.github.com/repos/astafan8/Qcodes/pulls{/number}","milestones_url":"https://api.github.com/repos/astafan8/Qcodes/milestones{/number}","notifications_url":"https://api.github.com/repos/astafan8/Qcodes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/astafan8/Qcodes/labels{/name}","releases_url":"https://api.github.com/repos/astafan8/Qcodes/releases{/id}","deployments_url":"https://api.github.com/repos/astafan8/Qcodes/deployments","created_at":"2018-06-05T13:31:12Z","updated_at":"2018-08-21T15:58:14Z","pushed_at":"2018-08-24T10:25:48Z","git_url":"git://github.com/astafan8/Qcodes.git","ssh_url":"git@github.com:astafan8/Qcodes.git","clone_url":"https://github.com/astafan8/Qcodes.git","svn_url":"https://github.com/astafan8/Qcodes","homepage":"http://qcodes.github.io/Qcodes","size":19320,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"QCoDeS:master","ref":"master","sha":"c190d9ff703a1ebbb5bdd549df773ed299a5732e","user":{"login":"QCoDeS","id":20478252,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNDc4MjUy","avatar_url":"https://avatars3.githubusercontent.com/u/20478252?v=4","gravatar_id":"","url":"https://api.github.com/users/QCoDeS","html_url":"https://github.com/QCoDeS","followers_url":"https://api.github.com/users/QCoDeS/followers","following_url":"https://api.github.com/users/QCoDeS/following{/other_user}","gists_url":"https://api.github.com/users/QCoDeS/gists{/gist_id}","starred_url":"https://api.github.com/users/QCoDeS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QCoDeS/subscriptions","organizations_url":"https://api.github.com/users/QCoDeS/orgs","repos_url":"https://api.github.com/users/QCoDeS/repos","events_url":"https://api.github.com/users/QCoDeS/events{/privacy}","received_events_url":"https://api.github.com/users/QCoDeS/received_events","type":"Organization","site_admin":false},"repo":{"id":37137879,"node_id":"MDEwOlJlcG9zaXRvcnkzNzEzNzg3OQ==","name":"Qcodes","full_name":"QCoDeS/Qcodes","owner":{"login":"QCoDeS","id":20478252,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNDc4MjUy","avatar_url":"https://avatars3.githubusercontent.com/u/20478252?v=4","gravatar_id":"","url":"https://api.github.com/users/QCoDeS","html_url":"https://github.com/QCoDeS","followers_url":"https://api.github.com/users/QCoDeS/followers","following_url":"https://api.github.com/users/QCoDeS/following{/other_user}","gists_url":"https://api.github.com/users/QCoDeS/gists{/gist_id}","starred_url":"https://api.github.com/users/QCoDeS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QCoDeS/subscriptions","organizations_url":"https://api.github.com/users/QCoDeS/orgs","repos_url":"https://api.github.com/users/QCoDeS/repos","events_url":"https://api.github.com/users/QCoDeS/events{/privacy}","received_events_url":"https://api.github.com/users/QCoDeS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/QCoDeS/Qcodes","description":"Modular data acquisition framework","fork":false,"url":"https://api.github.com/repos/QCoDeS/Qcodes","forks_url":"https://api.github.com/repos/QCoDeS/Qcodes/forks","keys_url":"https://api.github.com/repos/QCoDeS/Qcodes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/QCoDeS/Qcodes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/QCoDeS/Qcodes/teams","hooks_url":"https://api.github.com/repos/QCoDeS/Qcodes/hooks","issue_events_url":"https://api.github.com/repos/QCoDeS/Qcodes/issues/events{/number}","events_url":"https://api.github.com/repos/QCoDeS/Qcodes/events","assignees_url":"https://api.github.com/repos/QCoDeS/Qcodes/assignees{/user}","branches_url":"https://api.github.com/repos/QCoDeS/Qcodes/branches{/branch}","tags_url":"https://api.github.com/repos/QCoDeS/Qcodes/tags","blobs_url":"https://api.github.com/repos/QCoDeS/Qcodes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/QCoDeS/Qcodes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/QCoDeS/Qcodes/git/refs{/sha}","trees_url":"https://api.github.com/repos/QCoDeS/Qcodes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/QCoDeS/Qcodes/statuses/{sha}","languages_url":"https://api.github.com/repos/QCoDeS/Qcodes/languages","stargazers_url":"https://api.github.com/repos/QCoDeS/Qcodes/stargazers","contributors_url":"https://api.github.com/repos/QCoDeS/Qcodes/contributors","subscribers_url":"https://api.github.com/repos/QCoDeS/Qcodes/subscribers","subscription_url":"https://api.github.com/repos/QCoDeS/Qcodes/subscription","commits_url":"https://api.github.com/repos/QCoDeS/Qcodes/commits{/sha}","git_commits_url":"https://api.github.com/repos/QCoDeS/Qcodes/git/commits{/sha}","comments_url":"https://api.github.com/repos/QCoDeS/Qcodes/comments{/number}","issue_comment_url":"https://api.github.com/repos/QCoDeS/Qcodes/issues/comments{/number}","contents_url":"https://api.github.com/repos/QCoDeS/Qcodes/contents/{+path}","compare_url":"https://api.github.com/repos/QCoDeS/Qcodes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/QCoDeS/Qcodes/merges","archive_url":"https://api.github.com/repos/QCoDeS/Qcodes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/QCoDeS/Qcodes/downloads","issues_url":"https://api.github.com/repos/QCoDeS/Qcodes/issues{/number}","pulls_url":"https://api.github.com/repos/QCoDeS/Qcodes/pulls{/number}","milestones_url":"https://api.github.com/repos/QCoDeS/Qcodes/milestones{/number}","notifications_url":"https://api.github.com/repos/QCoDeS/Qcodes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/QCoDeS/Qcodes/labels{/name}","releases_url":"https://api.github.com/repos/QCoDeS/Qcodes/releases{/id}","deployments_url":"https://api.github.com/repos/QCoDeS/Qcodes/deployments","created_at":"2015-06-09T14:42:14Z","updated_at":"2018-08-24T12:45:02Z","pushed_at":"2018-08-27T14:27:37Z","git_url":"git://github.com/QCoDeS/Qcodes.git","ssh_url":"git@github.com:QCoDeS/Qcodes.git","clone_url":"https://github.com/QCoDeS/Qcodes.git","svn_url":"https://github.com/QCoDeS/Qcodes","homepage":"http://qcodes.github.io/Qcodes","size":49440,"stargazers_count":57,"watchers_count":57,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":73,"mirror_url":null,"archived":false,"open_issues_count":215,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":73,"open_issues":215,"watchers":57,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/QCoDeS/Qcodes/pulls/1245"},"html":{"href":"https://github.com/QCoDeS/Qcodes/pull/1245"},"issue":{"href":"https://api.github.com/repos/QCoDeS/Qcodes/issues/1245"},"comments":{"href":"https://api.github.com/repos/QCoDeS/Qcodes/issues/1245/comments"},"review_comments":{"href":"https://api.github.com/repos/QCoDeS/Qcodes/pulls/1245/comments"},"review_comment":{"href":"https://api.github.com/repos/QCoDeS/Qcodes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/QCoDeS/Qcodes/pulls/1245/commits"},"statuses":{"href":"https://api.github.com/repos/QCoDeS/Qcodes/statuses/7465f0ca5b8ed92887206fcb7c17a3aa962d4012"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"astafan8"}}