{"action":"created","issue":{"url":"https://api.github.com/repos/brave/browser-laptop/issues/14981","repository_url":"https://api.github.com/repos/brave/browser-laptop","labels_url":"https://api.github.com/repos/brave/browser-laptop/issues/14981/labels{/name}","comments_url":"https://api.github.com/repos/brave/browser-laptop/issues/14981/comments","events_url":"https://api.github.com/repos/brave/browser-laptop/issues/14981/events","html_url":"https://github.com/brave/browser-laptop/issues/14981","id":349263672,"node_id":"MDU6SXNzdWUzNDkyNjM2NzI=","number":14981,"title":"password modal being prompted after already adding a password several times when initially enabling","user":{"login":"kjozwiak","id":2602313,"node_id":"MDQ6VXNlcjI2MDIzMTM=","avatar_url":"https://avatars0.githubusercontent.com/u/2602313?v=4","gravatar_id":"","url":"https://api.github.com/users/kjozwiak","html_url":"https://github.com/kjozwiak","followers_url":"https://api.github.com/users/kjozwiak/followers","following_url":"https://api.github.com/users/kjozwiak/following{/other_user}","gists_url":"https://api.github.com/users/kjozwiak/gists{/gist_id}","starred_url":"https://api.github.com/users/kjozwiak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kjozwiak/subscriptions","organizations_url":"https://api.github.com/users/kjozwiak/orgs","repos_url":"https://api.github.com/users/kjozwiak/repos","events_url":"https://api.github.com/users/kjozwiak/events{/privacy}","received_events_url":"https://api.github.com/users/kjozwiak/received_events","type":"User","site_admin":false},"labels":[{"id":433043709,"node_id":"MDU6TGFiZWw0MzMwNDM3MDk=","url":"https://api.github.com/repos/brave/browser-laptop/labels/QA/checked-Win64","name":"QA/checked-Win64","color":"0e8a16","default":false},{"id":291742587,"node_id":"MDU6TGFiZWwyOTE3NDI1ODc=","url":"https://api.github.com/repos/brave/browser-laptop/labels/bug","name":"bug","color":"fc2929","default":true},{"id":1002729440,"node_id":"MDU6TGFiZWwxMDAyNzI5NDQw","url":"https://api.github.com/repos/brave/browser-laptop/labels/feature/ETH-Wallet","name":"feature/ETH-Wallet","color":"444444","default":false},{"id":690558021,"node_id":"MDU6TGFiZWw2OTA1NTgwMjE=","url":"https://api.github.com/repos/brave/browser-laptop/labels/priority/P4","name":"priority/P4","color":"c5def5","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/brave/browser-laptop/milestones/121","html_url":"https://github.com/brave/browser-laptop/milestone/121","labels_url":"https://api.github.com/repos/brave/browser-laptop/milestones/121/labels","id":3523574,"node_id":"MDk6TWlsZXN0b25lMzUyMzU3NA==","number":121,"title":"0.23.x Release 6 (ETH Wallet - Beta Channel)","description":"","creator":{"login":"bsclifton","id":4733304,"node_id":"MDQ6VXNlcjQ3MzMzMDQ=","avatar_url":"https://avatars3.githubusercontent.com/u/4733304?v=4","gravatar_id":"","url":"https://api.github.com/users/bsclifton","html_url":"https://github.com/bsclifton","followers_url":"https://api.github.com/users/bsclifton/followers","following_url":"https://api.github.com/users/bsclifton/following{/other_user}","gists_url":"https://api.github.com/users/bsclifton/gists{/gist_id}","starred_url":"https://api.github.com/users/bsclifton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsclifton/subscriptions","organizations_url":"https://api.github.com/users/bsclifton/orgs","repos_url":"https://api.github.com/users/bsclifton/repos","events_url":"https://api.github.com/users/bsclifton/events{/privacy}","received_events_url":"https://api.github.com/users/bsclifton/received_events","type":"User","site_admin":false},"open_issues":41,"closed_issues":38,"state":"open","created_at":"2018-07-25T17:52:27Z","updated_at":"2018-08-14T07:17:46Z","due_on":null,"closed_at":null},"comments":4,"created_at":"2018-08-09T19:42:47Z","updated_at":"2018-08-14T10:16:18Z","closed_at":"2018-08-09T22:16:39Z","author_association":"MEMBER","body":"<!--\r\nHave you searched for similar issues? We have received a lot of feedback and bug reports that we have closed as duplicates. Before submitting this issue, please visit our community site for common ones: https://community.brave.com/c/common-issues\r\n-->\r\n\r\n### Description\r\n<!--\r\n[Description of the issue]\r\n-->\r\n\r\nWhen you initially start Brave with `ETH Wallet`, enabling the `ETH Wallet` feature will display a required password modal. However, once you add a password and switch to another preference page and come back to the ETH Wallet, you're prompted again to `Add a new password`.\r\n\r\n### Steps to Reproduce\r\n<!--\r\nPlease add a series of steps to reproduce the problem. See https://stackoverflow.com/help/mcve for in depth information on how to create a minimal, complete, and verifiable example.\r\n-->\r\n\r\n  1. launch brave with the eth wallet feature (used source - f20fdca)\r\n  2. enable the eth wallet via `about:preferences#ethwallet`\r\n  3. once enabled, type in the mandatory password and click on `OK`\r\n  4. switch to another preference page like `Payments` and go back to `ETH Wallet`\r\n\r\nYou'll be prompted to create another password despite already doing it.\r\n\r\n**Actual result:**\r\n<!--\r\nPlease add screenshots if needed.\r\n-->\r\n\r\n![ethunresponsive](https://user-images.githubusercontent.com/2602313/43921735-a16e4e54-9bea-11e8-9d15-6fecb8a16103.gif)\r\n\r\n**Expected result:**\r\n\r\nOnce I've added my `master` password, brave should remember it and not prompt me again.\r\n\r\n**Reproduces how often:**\r\n<!--\r\nWhat percentage of the time does it reproduce?\r\n-->\r\n\r\n100% reproducible using the above STR.\r\n\r\n### Brave Version\r\n\r\n**about:brave info:**\r\n<!--\r\nPlease open about:brave, copy the version information, and paste it.\r\n-->\r\n \r\n```\r\nBrave: 0.25.0 \r\nV8: 6.8.275.24 \r\nrev: f20fdca85a585f0f3b11e5710a913b66e5798885 \r\nMuon: 8.0.6 \r\nOS Release: 17.7.0 \r\nUpdate Channel:  \r\nOS Architecture: x64 \r\nOS Platform: macOS \r\nNode.js: 7.9.0 \r\nBrave Sync: v1.4.2 \r\nlibchromiumcontent: 68.0.3440.84\r\n```\r\n\r\n**Reproducible on current live release:**\r\n<!--\r\nIs this a problem with the live build? It matters for triage reasons.\r\n-->\r\n\r\nNo, this feature hasn't been release and isn't available in the latest released version.\r\n\r\n### Additional Information\r\n<!--\r\nAny additional information, related issues, extra QA steps, configuration or data that might be necessary to reproduce the issue.\r\n-->\r\n\r\nAlso reproduced by @srirambv via Windows 10 x64."},"comment":{"url":"https://api.github.com/repos/brave/browser-laptop/issues/comments/412824064","html_url":"https://github.com/brave/browser-laptop/issues/14981#issuecomment-412824064","issue_url":"https://api.github.com/repos/brave/browser-laptop/issues/14981","id":412824064,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMjgyNDA2NA==","user":{"login":"GeetaSarvadnya","id":38657976,"node_id":"MDQ6VXNlcjM4NjU3OTc2","avatar_url":"https://avatars3.githubusercontent.com/u/38657976?v=4","gravatar_id":"","url":"https://api.github.com/users/GeetaSarvadnya","html_url":"https://github.com/GeetaSarvadnya","followers_url":"https://api.github.com/users/GeetaSarvadnya/followers","following_url":"https://api.github.com/users/GeetaSarvadnya/following{/other_user}","gists_url":"https://api.github.com/users/GeetaSarvadnya/gists{/gist_id}","starred_url":"https://api.github.com/users/GeetaSarvadnya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GeetaSarvadnya/subscriptions","organizations_url":"https://api.github.com/users/GeetaSarvadnya/orgs","repos_url":"https://api.github.com/users/GeetaSarvadnya/repos","events_url":"https://api.github.com/users/GeetaSarvadnya/events{/privacy}","received_events_url":"https://api.github.com/users/GeetaSarvadnya/received_events","type":"User","site_admin":false},"created_at":"2018-08-14T10:16:18Z","updated_at":"2018-08-14T10:16:18Z","author_association":"COLLABORATOR","body":"Verified on Windows x64 with\r\n• 0.23.100 5e197a1a877c9967aecc838b9a7ca528ee5b46bd\r\n• Muon 8.0.8\r\n• libchromiumcontent 68.0.3440.84\r\n"}}
{"actor":{"display_login":"GeetaSarvadnya"}}