{"action":"opened","number":1863,"pull_request":{"url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/pulls/1863","id":188086484,"html_url":"https://github.com/openstreetmap/openstreetmap-website/pull/1863","diff_url":"https://github.com/openstreetmap/openstreetmap-website/pull/1863.diff","patch_url":"https://github.com/openstreetmap/openstreetmap-website/pull/1863.patch","issue_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/issues/1863","number":1863,"state":"open","locked":false,"title":"Messages controller method renaming for show and destroy","user":{"login":"gravitystorm","id":360803,"avatar_url":"https://avatars1.githubusercontent.com/u/360803?v=4","gravatar_id":"","url":"https://api.github.com/users/gravitystorm","html_url":"https://github.com/gravitystorm","followers_url":"https://api.github.com/users/gravitystorm/followers","following_url":"https://api.github.com/users/gravitystorm/following{/other_user}","gists_url":"https://api.github.com/users/gravitystorm/gists{/gist_id}","starred_url":"https://api.github.com/users/gravitystorm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gravitystorm/subscriptions","organizations_url":"https://api.github.com/users/gravitystorm/orgs","repos_url":"https://api.github.com/users/gravitystorm/repos","events_url":"https://api.github.com/users/gravitystorm/events{/privacy}","received_events_url":"https://api.github.com/users/gravitystorm/received_events","type":"User","site_admin":false},"body":"This PR renames the old #read and #delete methods of the messages controller methods, to #show and #destroy respectively. This brings them into line with rails standard naming conventions, laying some groundwork for future resourceful routing.\r\n\r\n@Nikerabbit this PR contains some more translation key renaming, namely:\r\n\r\n* `messages.read.*` becomes `messages.show.*`\r\n* `messages.show.delete_button` then becomes `messages.show.destroy_button`\r\n* `messages.sent_message_summary.delete_button` becomes `messages.sent_message_summary.destroy_button`\r\n* `messages.message_summary.delete_button` becomes `messages.message_summary.destroy_button`\r\n* `messages.delete.deleted` becomes `messages.destroy.destroyed`","created_at":"2018-05-15T10:45:55Z","updated_at":"2018-05-15T10:45:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/pulls/1863/commits","review_comments_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/pulls/1863/comments","review_comment_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/issues/1863/comments","statuses_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/statuses/84fa437d509002c783af33d219bed0c2115786df","head":{"label":"gravitystorm:messages5","ref":"messages5","sha":"84fa437d509002c783af33d219bed0c2115786df","user":{"login":"gravitystorm","id":360803,"avatar_url":"https://avatars1.githubusercontent.com/u/360803?v=4","gravatar_id":"","url":"https://api.github.com/users/gravitystorm","html_url":"https://github.com/gravitystorm","followers_url":"https://api.github.com/users/gravitystorm/followers","following_url":"https://api.github.com/users/gravitystorm/following{/other_user}","gists_url":"https://api.github.com/users/gravitystorm/gists{/gist_id}","starred_url":"https://api.github.com/users/gravitystorm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gravitystorm/subscriptions","organizations_url":"https://api.github.com/users/gravitystorm/orgs","repos_url":"https://api.github.com/users/gravitystorm/repos","events_url":"https://api.github.com/users/gravitystorm/events{/privacy}","received_events_url":"https://api.github.com/users/gravitystorm/received_events","type":"User","site_admin":false},"repo":{"id":1174982,"name":"openstreetmap-website","full_name":"gravitystorm/openstreetmap-website","owner":{"login":"gravitystorm","id":360803,"avatar_url":"https://avatars1.githubusercontent.com/u/360803?v=4","gravatar_id":"","url":"https://api.github.com/users/gravitystorm","html_url":"https://github.com/gravitystorm","followers_url":"https://api.github.com/users/gravitystorm/followers","following_url":"https://api.github.com/users/gravitystorm/following{/other_user}","gists_url":"https://api.github.com/users/gravitystorm/gists{/gist_id}","starred_url":"https://api.github.com/users/gravitystorm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gravitystorm/subscriptions","organizations_url":"https://api.github.com/users/gravitystorm/orgs","repos_url":"https://api.github.com/users/gravitystorm/repos","events_url":"https://api.github.com/users/gravitystorm/events{/privacy}","received_events_url":"https://api.github.com/users/gravitystorm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gravitystorm/openstreetmap-website","description":"The Rails application powering OpenStreetMap","fork":true,"url":"https://api.github.com/repos/gravitystorm/openstreetmap-website","forks_url":"https://api.github.com/repos/gravitystorm/openstreetmap-website/forks","keys_url":"https://api.github.com/repos/gravitystorm/openstreetmap-website/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gravitystorm/openstreetmap-website/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gravitystorm/openstreetmap-website/teams","hooks_url":"https://api.github.com/repos/gravitystorm/openstreetmap-website/hooks","issue_events_url":"https://api.github.com/repos/gravitystorm/openstreetmap-website/issues/events{/number}","events_url":"https://api.github.com/repos/gravitystorm/openstreetmap-website/events","assignees_url":"https://api.github.com/repos/gravitystorm/openstreetmap-website/assignees{/user}","branches_url":"https://api.github.com/repos/gravitystorm/openstreetmap-website/branches{/branch}","tags_url":"https://api.github.com/repos/gravitystorm/openstreetmap-website/tags","blobs_url":"https://api.github.com/repos/gravitystorm/openstreetmap-website/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gravitystorm/openstreetmap-website/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gravitystorm/openstreetmap-website/git/refs{/sha}","trees_url":"https://api.github.com/repos/gravitystorm/openstreetmap-website/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gravitystorm/openstreetmap-website/statuses/{sha}","languages_url":"https://api.github.com/repos/gravitystorm/openstreetmap-website/languages","stargazers_url":"https://api.github.com/repos/gravitystorm/openstreetmap-website/stargazers","contributors_url":"https://api.github.com/repos/gravitystorm/openstreetmap-website/contributors","subscribers_url":"https://api.github.com/repos/gravitystorm/openstreetmap-website/subscribers","subscription_url":"https://api.github.com/repos/gravitystorm/openstreetmap-website/subscription","commits_url":"https://api.github.com/repos/gravitystorm/openstreetmap-website/commits{/sha}","git_commits_url":"https://api.github.com/repos/gravitystorm/openstreetmap-website/git/commits{/sha}","comments_url":"https://api.github.com/repos/gravitystorm/openstreetmap-website/comments{/number}","issue_comment_url":"https://api.github.com/repos/gravitystorm/openstreetmap-website/issues/comments{/number}","contents_url":"https://api.github.com/repos/gravitystorm/openstreetmap-website/contents/{+path}","compare_url":"https://api.github.com/repos/gravitystorm/openstreetmap-website/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gravitystorm/openstreetmap-website/merges","archive_url":"https://api.github.com/repos/gravitystorm/openstreetmap-website/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gravitystorm/openstreetmap-website/downloads","issues_url":"https://api.github.com/repos/gravitystorm/openstreetmap-website/issues{/number}","pulls_url":"https://api.github.com/repos/gravitystorm/openstreetmap-website/pulls{/number}","milestones_url":"https://api.github.com/repos/gravitystorm/openstreetmap-website/milestones{/number}","notifications_url":"https://api.github.com/repos/gravitystorm/openstreetmap-website/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gravitystorm/openstreetmap-website/labels{/name}","releases_url":"https://api.github.com/repos/gravitystorm/openstreetmap-website/releases{/id}","deployments_url":"https://api.github.com/repos/gravitystorm/openstreetmap-website/deployments","created_at":"2010-12-16T19:10:32Z","updated_at":"2018-05-15T06:58:10Z","pushed_at":"2018-05-15T10:32:57Z","git_url":"git://github.com/gravitystorm/openstreetmap-website.git","ssh_url":"git@github.com:gravitystorm/openstreetmap-website.git","clone_url":"https://github.com/gravitystorm/openstreetmap-website.git","svn_url":"https://github.com/gravitystorm/openstreetmap-website","homepage":"http://www.openstreetmap.org/","size":290356,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":1,"open_issues":13,"watchers":2,"default_branch":"master"}},"base":{"label":"openstreetmap:master","ref":"master","sha":"2fd0d2304f05bdac456e654681cd26565c2d7f08","user":{"login":"openstreetmap","id":261431,"avatar_url":"https://avatars3.githubusercontent.com/u/261431?v=4","gravatar_id":"","url":"https://api.github.com/users/openstreetmap","html_url":"https://github.com/openstreetmap","followers_url":"https://api.github.com/users/openstreetmap/followers","following_url":"https://api.github.com/users/openstreetmap/following{/other_user}","gists_url":"https://api.github.com/users/openstreetmap/gists{/gist_id}","starred_url":"https://api.github.com/users/openstreetmap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openstreetmap/subscriptions","organizations_url":"https://api.github.com/users/openstreetmap/orgs","repos_url":"https://api.github.com/users/openstreetmap/repos","events_url":"https://api.github.com/users/openstreetmap/events{/privacy}","received_events_url":"https://api.github.com/users/openstreetmap/received_events","type":"Organization","site_admin":false},"repo":{"id":641512,"name":"openstreetmap-website","full_name":"openstreetmap/openstreetmap-website","owner":{"login":"openstreetmap","id":261431,"avatar_url":"https://avatars3.githubusercontent.com/u/261431?v=4","gravatar_id":"","url":"https://api.github.com/users/openstreetmap","html_url":"https://github.com/openstreetmap","followers_url":"https://api.github.com/users/openstreetmap/followers","following_url":"https://api.github.com/users/openstreetmap/following{/other_user}","gists_url":"https://api.github.com/users/openstreetmap/gists{/gist_id}","starred_url":"https://api.github.com/users/openstreetmap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openstreetmap/subscriptions","organizations_url":"https://api.github.com/users/openstreetmap/orgs","repos_url":"https://api.github.com/users/openstreetmap/repos","events_url":"https://api.github.com/users/openstreetmap/events{/privacy}","received_events_url":"https://api.github.com/users/openstreetmap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openstreetmap/openstreetmap-website","description":"The rails application powering http://www.openstreetmap.org/","fork":false,"url":"https://api.github.com/repos/openstreetmap/openstreetmap-website","forks_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/forks","keys_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/teams","hooks_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/hooks","issue_events_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/issues/events{/number}","events_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/events","assignees_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/assignees{/user}","branches_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/branches{/branch}","tags_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/tags","blobs_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/git/refs{/sha}","trees_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/statuses/{sha}","languages_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/languages","stargazers_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/stargazers","contributors_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/contributors","subscribers_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/subscribers","subscription_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/subscription","commits_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/commits{/sha}","git_commits_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/git/commits{/sha}","comments_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/comments{/number}","issue_comment_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/issues/comments{/number}","contents_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/contents/{+path}","compare_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/merges","archive_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/downloads","issues_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/issues{/number}","pulls_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/pulls{/number}","milestones_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/milestones{/number}","notifications_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/labels{/name}","releases_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/releases{/id}","deployments_url":"https://api.github.com/repos/openstreetmap/openstreetmap-website/deployments","created_at":"2010-05-01T16:22:12Z","updated_at":"2018-05-15T08:35:01Z","pushed_at":"2018-05-15T08:34:52Z","git_url":"git://github.com/openstreetmap/openstreetmap-website.git","ssh_url":"git@github.com:openstreetmap/openstreetmap-website.git","clone_url":"https://github.com/openstreetmap/openstreetmap-website.git","svn_url":"https://github.com/openstreetmap/openstreetmap-website","homepage":"","size":290050,"stargazers_count":762,"watchers_count":762,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":472,"mirror_url":null,"archived":false,"open_issues_count":334,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":472,"open_issues":334,"watchers":762,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openstreetmap/openstreetmap-website/pulls/1863"},"html":{"href":"https://github.com/openstreetmap/openstreetmap-website/pull/1863"},"issue":{"href":"https://api.github.com/repos/openstreetmap/openstreetmap-website/issues/1863"},"comments":{"href":"https://api.github.com/repos/openstreetmap/openstreetmap-website/issues/1863/comments"},"review_comments":{"href":"https://api.github.com/repos/openstreetmap/openstreetmap-website/pulls/1863/comments"},"review_comment":{"href":"https://api.github.com/repos/openstreetmap/openstreetmap-website/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openstreetmap/openstreetmap-website/pulls/1863/commits"},"statuses":{"href":"https://api.github.com/repos/openstreetmap/openstreetmap-website/statuses/84fa437d509002c783af33d219bed0c2115786df"}},"author_association":"COLLABORATOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":4,"additions":50,"deletions":54,"changed_files":9}}
{"actor":{"display_login":"gravitystorm"}}