{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/frakti/pulls/comments/201634822","pull_request_review_id":136171514,"id":201634822,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTYzNDgyMg==","diff_hunk":"@@ -244,3 +246,62 @@ func (p *Init) resume(ctx context.Context) error {\n \t}\n \treturn nil\n }\n+\n+// exec returns a new exec'd process\n+func (p *Init) exec(context context.Context, id string, conf *ExecConfig) (Process, error) {\n+\tvar spec specs.Process\n+\tif err := json.Unmarshal(conf.Spec.Value, &spec); err != nil {\n+\t\treturn nil, err\n+\t}\n+\tspec.Terminal = conf.Terminal\n+\n+\tcapabilities := vc.LinuxCapabilities{\n+\t\tBounding:    spec.Capabilities.Bounding,\n+\t\tEffective:   spec.Capabilities.Effective,\n+\t\tInheritable: spec.Capabilities.Inheritable,\n+\t\tPermitted:   spec.Capabilities.Permitted,\n+\t\tAmbient:     spec.Capabilities.Ambient,\n+\t}\n+\n+\tcmd := vc.Cmd{\n+\t\tArgs:            spec.Args,\n+\t\tEnvs:            []vc.EnvVar{},\n+\t\tUser:            string(spec.User.UID),\n+\t\tPrimaryGroup:    string(spec.User.GID),\n+\t\tWorkDir:         spec.Cwd,\n+\t\tCapabilities:    capabilities,\n+\t\tInteractive:     spec.Terminal,\n+\t\tDetach:          !spec.Terminal,\n+\t\tNoNewPrivileges: spec.NoNewPrivileges,\n+\t}\n+\n+\t_, process, err := p.sandbox.EnterContainer(p.sandbox.ID(), cmd)\n+\tif err != nil {\n+\t\treturn nil, errors.Wrapf(err, \"cannot enter container %s\", p.sandbox.ID())\n+\t}\n+\n+\tstdin, stdout, stderr, err := p.sandbox.IOStream(p.sandbox.ID(), process.Token)","path":"pkg/kata/proc/init.go","position":70,"original_position":70,"commit_id":"97f80d250f1f892665ac338cc7fb125b9c52dfbb","original_commit_id":"97f80d250f1f892665ac338cc7fb125b9c52dfbb","user":{"login":"bergwolf","id":88972,"node_id":"MDQ6VXNlcjg4OTcy","avatar_url":"https://avatars0.githubusercontent.com/u/88972?v=4","gravatar_id":"","url":"https://api.github.com/users/bergwolf","html_url":"https://github.com/bergwolf","followers_url":"https://api.github.com/users/bergwolf/followers","following_url":"https://api.github.com/users/bergwolf/following{/other_user}","gists_url":"https://api.github.com/users/bergwolf/gists{/gist_id}","starred_url":"https://api.github.com/users/bergwolf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bergwolf/subscriptions","organizations_url":"https://api.github.com/users/bergwolf/orgs","repos_url":"https://api.github.com/users/bergwolf/repos","events_url":"https://api.github.com/users/bergwolf/events{/privacy}","received_events_url":"https://api.github.com/users/bergwolf/received_events","type":"User","site_admin":false},"body":"same here.","created_at":"2018-07-11T10:07:06Z","updated_at":"2018-07-11T10:15:45Z","html_url":"https://github.com/kubernetes/frakti/pull/338#discussion_r201634822","pull_request_url":"https://api.github.com/repos/kubernetes/frakti/pulls/338","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/frakti/pulls/comments/201634822"},"html":{"href":"https://github.com/kubernetes/frakti/pull/338#discussion_r201634822"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/frakti/pulls/338"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/frakti/pulls/338","id":199628410,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5NjI4NDEw","html_url":"https://github.com/kubernetes/frakti/pull/338","diff_url":"https://github.com/kubernetes/frakti/pull/338.diff","patch_url":"https://github.com/kubernetes/frakti/pull/338.patch","issue_url":"https://api.github.com/repos/kubernetes/frakti/issues/338","number":338,"state":"open","locked":false,"title":"Add ExecProcess related functionalities","user":{"login":"ZeroMagic","id":12582312,"node_id":"MDQ6VXNlcjEyNTgyMzEy","avatar_url":"https://avatars3.githubusercontent.com/u/12582312?v=4","gravatar_id":"","url":"https://api.github.com/users/ZeroMagic","html_url":"https://github.com/ZeroMagic","followers_url":"https://api.github.com/users/ZeroMagic/followers","following_url":"https://api.github.com/users/ZeroMagic/following{/other_user}","gists_url":"https://api.github.com/users/ZeroMagic/gists{/gist_id}","starred_url":"https://api.github.com/users/ZeroMagic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZeroMagic/subscriptions","organizations_url":"https://api.github.com/users/ZeroMagic/orgs","repos_url":"https://api.github.com/users/ZeroMagic/repos","events_url":"https://api.github.com/users/ZeroMagic/events{/privacy}","received_events_url":"https://api.github.com/users/ZeroMagic/received_events","type":"User","site_admin":false},"body":"-  Exec() adds a process into the container\r\n\r\n- DeleteProcess() deletes a specific exec process via its id\r\n\r\n- change `execProcess` to `ExecProcess`","created_at":"2018-07-06T02:12:51Z","updated_at":"2018-07-11T10:15:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"549359786c953a5c903357da8f83d545b9e98f69","assignee":null,"assignees":[],"requested_reviewers":[{"login":"resouer","id":1701782,"node_id":"MDQ6VXNlcjE3MDE3ODI=","avatar_url":"https://avatars3.githubusercontent.com/u/1701782?v=4","gravatar_id":"","url":"https://api.github.com/users/resouer","html_url":"https://github.com/resouer","followers_url":"https://api.github.com/users/resouer/followers","following_url":"https://api.github.com/users/resouer/following{/other_user}","gists_url":"https://api.github.com/users/resouer/gists{/gist_id}","starred_url":"https://api.github.com/users/resouer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/resouer/subscriptions","organizations_url":"https://api.github.com/users/resouer/orgs","repos_url":"https://api.github.com/users/resouer/repos","events_url":"https://api.github.com/users/resouer/events{/privacy}","received_events_url":"https://api.github.com/users/resouer/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":485882754,"node_id":"MDU6TGFiZWw0ODU4ODI3NTQ=","url":"https://api.github.com/repos/kubernetes/frakti/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":677343533,"node_id":"MDU6TGFiZWw2NzczNDM1MzM=","url":"https://api.github.com/repos/kubernetes/frakti/labels/size/L","name":"size/L","color":"ee9900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/frakti/pulls/338/commits","review_comments_url":"https://api.github.com/repos/kubernetes/frakti/pulls/338/comments","review_comment_url":"https://api.github.com/repos/kubernetes/frakti/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/frakti/issues/338/comments","statuses_url":"https://api.github.com/repos/kubernetes/frakti/statuses/97f80d250f1f892665ac338cc7fb125b9c52dfbb","head":{"label":"ZeroMagic:gsoc18","ref":"gsoc18","sha":"97f80d250f1f892665ac338cc7fb125b9c52dfbb","user":{"login":"ZeroMagic","id":12582312,"node_id":"MDQ6VXNlcjEyNTgyMzEy","avatar_url":"https://avatars3.githubusercontent.com/u/12582312?v=4","gravatar_id":"","url":"https://api.github.com/users/ZeroMagic","html_url":"https://github.com/ZeroMagic","followers_url":"https://api.github.com/users/ZeroMagic/followers","following_url":"https://api.github.com/users/ZeroMagic/following{/other_user}","gists_url":"https://api.github.com/users/ZeroMagic/gists{/gist_id}","starred_url":"https://api.github.com/users/ZeroMagic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZeroMagic/subscriptions","organizations_url":"https://api.github.com/users/ZeroMagic/orgs","repos_url":"https://api.github.com/users/ZeroMagic/repos","events_url":"https://api.github.com/users/ZeroMagic/events{/privacy}","received_events_url":"https://api.github.com/users/ZeroMagic/received_events","type":"User","site_admin":false},"repo":{"id":129023718,"node_id":"MDEwOlJlcG9zaXRvcnkxMjkwMjM3MTg=","name":"frakti","full_name":"ZeroMagic/frakti","owner":{"login":"ZeroMagic","id":12582312,"node_id":"MDQ6VXNlcjEyNTgyMzEy","avatar_url":"https://avatars3.githubusercontent.com/u/12582312?v=4","gravatar_id":"","url":"https://api.github.com/users/ZeroMagic","html_url":"https://github.com/ZeroMagic","followers_url":"https://api.github.com/users/ZeroMagic/followers","following_url":"https://api.github.com/users/ZeroMagic/following{/other_user}","gists_url":"https://api.github.com/users/ZeroMagic/gists{/gist_id}","starred_url":"https://api.github.com/users/ZeroMagic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZeroMagic/subscriptions","organizations_url":"https://api.github.com/users/ZeroMagic/orgs","repos_url":"https://api.github.com/users/ZeroMagic/repos","events_url":"https://api.github.com/users/ZeroMagic/events{/privacy}","received_events_url":"https://api.github.com/users/ZeroMagic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ZeroMagic/frakti","description":"The hypervisor-based container runtime for Kubernetes.","fork":true,"url":"https://api.github.com/repos/ZeroMagic/frakti","forks_url":"https://api.github.com/repos/ZeroMagic/frakti/forks","keys_url":"https://api.github.com/repos/ZeroMagic/frakti/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ZeroMagic/frakti/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ZeroMagic/frakti/teams","hooks_url":"https://api.github.com/repos/ZeroMagic/frakti/hooks","issue_events_url":"https://api.github.com/repos/ZeroMagic/frakti/issues/events{/number}","events_url":"https://api.github.com/repos/ZeroMagic/frakti/events","assignees_url":"https://api.github.com/repos/ZeroMagic/frakti/assignees{/user}","branches_url":"https://api.github.com/repos/ZeroMagic/frakti/branches{/branch}","tags_url":"https://api.github.com/repos/ZeroMagic/frakti/tags","blobs_url":"https://api.github.com/repos/ZeroMagic/frakti/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ZeroMagic/frakti/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ZeroMagic/frakti/git/refs{/sha}","trees_url":"https://api.github.com/repos/ZeroMagic/frakti/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ZeroMagic/frakti/statuses/{sha}","languages_url":"https://api.github.com/repos/ZeroMagic/frakti/languages","stargazers_url":"https://api.github.com/repos/ZeroMagic/frakti/stargazers","contributors_url":"https://api.github.com/repos/ZeroMagic/frakti/contributors","subscribers_url":"https://api.github.com/repos/ZeroMagic/frakti/subscribers","subscription_url":"https://api.github.com/repos/ZeroMagic/frakti/subscription","commits_url":"https://api.github.com/repos/ZeroMagic/frakti/commits{/sha}","git_commits_url":"https://api.github.com/repos/ZeroMagic/frakti/git/commits{/sha}","comments_url":"https://api.github.com/repos/ZeroMagic/frakti/comments{/number}","issue_comment_url":"https://api.github.com/repos/ZeroMagic/frakti/issues/comments{/number}","contents_url":"https://api.github.com/repos/ZeroMagic/frakti/contents/{+path}","compare_url":"https://api.github.com/repos/ZeroMagic/frakti/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ZeroMagic/frakti/merges","archive_url":"https://api.github.com/repos/ZeroMagic/frakti/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ZeroMagic/frakti/downloads","issues_url":"https://api.github.com/repos/ZeroMagic/frakti/issues{/number}","pulls_url":"https://api.github.com/repos/ZeroMagic/frakti/pulls{/number}","milestones_url":"https://api.github.com/repos/ZeroMagic/frakti/milestones{/number}","notifications_url":"https://api.github.com/repos/ZeroMagic/frakti/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ZeroMagic/frakti/labels{/name}","releases_url":"https://api.github.com/repos/ZeroMagic/frakti/releases{/id}","deployments_url":"https://api.github.com/repos/ZeroMagic/frakti/deployments","created_at":"2018-04-11T02:40:58Z","updated_at":"2018-04-11T02:41:01Z","pushed_at":"2018-07-10T06:40:20Z","git_url":"git://github.com/ZeroMagic/frakti.git","ssh_url":"git@github.com:ZeroMagic/frakti.git","clone_url":"https://github.com/ZeroMagic/frakti.git","svn_url":"https://github.com/ZeroMagic/frakti","homepage":"","size":57048,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:containerd-kata","ref":"containerd-kata","sha":"fd6c631dcabb6401ee43c411b07142ea4d99f000","user":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":62069434,"node_id":"MDEwOlJlcG9zaXRvcnk2MjA2OTQzNA==","name":"frakti","full_name":"kubernetes/frakti","owner":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/frakti","description":"The hypervisor-based container runtime for Kubernetes.","fork":false,"url":"https://api.github.com/repos/kubernetes/frakti","forks_url":"https://api.github.com/repos/kubernetes/frakti/forks","keys_url":"https://api.github.com/repos/kubernetes/frakti/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/frakti/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/frakti/teams","hooks_url":"https://api.github.com/repos/kubernetes/frakti/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/frakti/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/frakti/events","assignees_url":"https://api.github.com/repos/kubernetes/frakti/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/frakti/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/frakti/tags","blobs_url":"https://api.github.com/repos/kubernetes/frakti/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/frakti/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/frakti/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/frakti/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/frakti/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/frakti/languages","stargazers_url":"https://api.github.com/repos/kubernetes/frakti/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/frakti/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/frakti/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/frakti/subscription","commits_url":"https://api.github.com/repos/kubernetes/frakti/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/frakti/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/frakti/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/frakti/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/frakti/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/frakti/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/frakti/merges","archive_url":"https://api.github.com/repos/kubernetes/frakti/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/frakti/downloads","issues_url":"https://api.github.com/repos/kubernetes/frakti/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/frakti/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/frakti/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/frakti/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/frakti/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/frakti/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/frakti/deployments","created_at":"2016-06-27T16:04:23Z","updated_at":"2018-07-11T09:08:29Z","pushed_at":"2018-07-11T09:08:27Z","git_url":"git://github.com/kubernetes/frakti.git","ssh_url":"git@github.com:kubernetes/frakti.git","clone_url":"https://github.com/kubernetes/frakti.git","svn_url":"https://github.com/kubernetes/frakti","homepage":"","size":56588,"stargazers_count":341,"watchers_count":341,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":71,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":71,"open_issues":9,"watchers":341,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/frakti/pulls/338"},"html":{"href":"https://github.com/kubernetes/frakti/pull/338"},"issue":{"href":"https://api.github.com/repos/kubernetes/frakti/issues/338"},"comments":{"href":"https://api.github.com/repos/kubernetes/frakti/issues/338/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/frakti/pulls/338/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/frakti/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/frakti/pulls/338/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/frakti/statuses/97f80d250f1f892665ac338cc7fb125b9c52dfbb"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"bergwolf"}}