{"action":"created","issue":{"url":"https://api.github.com/repos/pact-foundation/pact-node/issues/86","repository_url":"https://api.github.com/repos/pact-foundation/pact-node","labels_url":"https://api.github.com/repos/pact-foundation/pact-node/issues/86/labels{/name}","comments_url":"https://api.github.com/repos/pact-foundation/pact-node/issues/86/comments","events_url":"https://api.github.com/repos/pact-foundation/pact-node/issues/86/events","html_url":"https://github.com/pact-foundation/pact-node/pull/86","id":313175413,"number":86,"title":"Ability to specify formatter","user":{"login":"joshhendo","id":1961112,"avatar_url":"https://avatars0.githubusercontent.com/u/1961112?v=4","gravatar_id":"","url":"https://api.github.com/users/joshhendo","html_url":"https://github.com/joshhendo","followers_url":"https://api.github.com/users/joshhendo/followers","following_url":"https://api.github.com/users/joshhendo/following{/other_user}","gists_url":"https://api.github.com/users/joshhendo/gists{/gist_id}","starred_url":"https://api.github.com/users/joshhendo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshhendo/subscriptions","organizations_url":"https://api.github.com/users/joshhendo/orgs","repos_url":"https://api.github.com/users/joshhendo/repos","events_url":"https://api.github.com/users/joshhendo/events{/privacy}","received_events_url":"https://api.github.com/users/joshhendo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":14,"created_at":"2018-04-11T05:09:49Z","updated_at":"2018-04-18T23:34:49Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/pact-foundation/pact-node/pulls/86","html_url":"https://github.com/pact-foundation/pact-node/pull/86","diff_url":"https://github.com/pact-foundation/pact-node/pull/86.diff","patch_url":"https://github.com/pact-foundation/pact-node/pull/86.patch"},"body":"This is a proof of concept PR to start the discussion behind this feature. It certainly need agreement and tests added in before it is ready to be merged."},"comment":{"url":"https://api.github.com/repos/pact-foundation/pact-node/issues/comments/382561873","html_url":"https://github.com/pact-foundation/pact-node/pull/86#issuecomment-382561873","issue_url":"https://api.github.com/repos/pact-foundation/pact-node/issues/86","id":382561873,"user":{"login":"joshhendo","id":1961112,"avatar_url":"https://avatars0.githubusercontent.com/u/1961112?v=4","gravatar_id":"","url":"https://api.github.com/users/joshhendo","html_url":"https://github.com/joshhendo","followers_url":"https://api.github.com/users/joshhendo/followers","following_url":"https://api.github.com/users/joshhendo/following{/other_user}","gists_url":"https://api.github.com/users/joshhendo/gists{/gist_id}","starred_url":"https://api.github.com/users/joshhendo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshhendo/subscriptions","organizations_url":"https://api.github.com/users/joshhendo/orgs","repos_url":"https://api.github.com/users/joshhendo/repos","events_url":"https://api.github.com/users/joshhendo/events{/privacy}","received_events_url":"https://api.github.com/users/joshhendo/received_events","type":"User","site_admin":false},"created_at":"2018-04-18T23:34:49Z","updated_at":"2018-04-18T23:34:49Z","author_association":"NONE","body":"@mboudreau I'm using it through the node api, basically the way this example does it:\r\nhttps://github.com/pact-foundation/pact-js/blob/master/examples/e2e/test/provider.spec.js#L61\r\n\r\nThe way I see it is, at the moment 2 streams are merged into 1. For proof of concept I just excluded the error stream to show it worked, but I agree that's not something we'd want people to regularly do. If building from scratch, I'd contemplate designing the interface to be able to return the result and error strings separately, giving the best of both worlds (the `stdout` can be parsed to JSON, but we don't sacrifice any important error messages from `stderr`)\r\n\r\nWriting to file when used via node-js is a bit clunky and certainly not as clean as streaming the result from `stdout` (but file is better when using it via CLI). However, given we can do write to file without changing interfaces, it is certainly workable (write to a temp file and make sure they're in `.gitignore`) and is easier to implement here -- I'll update the PR to implement this."}}
{"actor":{"display_login":"joshhendo"}}