{"action":"created","issue":{"url":"https://api.github.com/repos/rust-lang/rust/issues/51833","repository_url":"https://api.github.com/repos/rust-lang/rust","labels_url":"https://api.github.com/repos/rust-lang/rust/issues/51833/labels{/name}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/51833/comments","events_url":"https://api.github.com/repos/rust-lang/rust/issues/51833/events","html_url":"https://github.com/rust-lang/rust/pull/51833","id":336070187,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3NjExMTk5","number":51833,"title":"Speed up compilation of large constant arrays","user":{"login":"wesleywiser","id":831192,"node_id":"MDQ6VXNlcjgzMTE5Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/831192?v=4","gravatar_id":"","url":"https://api.github.com/users/wesleywiser","html_url":"https://github.com/wesleywiser","followers_url":"https://api.github.com/users/wesleywiser/followers","following_url":"https://api.github.com/users/wesleywiser/following{/other_user}","gists_url":"https://api.github.com/users/wesleywiser/gists{/gist_id}","starred_url":"https://api.github.com/users/wesleywiser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wesleywiser/subscriptions","organizations_url":"https://api.github.com/users/wesleywiser/orgs","repos_url":"https://api.github.com/users/wesleywiser/repos","events_url":"https://api.github.com/users/wesleywiser/events{/privacy}","received_events_url":"https://api.github.com/users/wesleywiser/received_events","type":"User","site_admin":false},"labels":[{"id":583426710,"node_id":"MDU6TGFiZWw1ODM0MjY3MTA=","url":"https://api.github.com/repos/rust-lang/rust/labels/S-waiting-on-review","name":"S-waiting-on-review","color":"d3dddd","default":false}],"state":"open","locked":false,"assignee":{"login":"oli-obk","id":332036,"node_id":"MDQ6VXNlcjMzMjAzNg==","avatar_url":"https://avatars2.githubusercontent.com/u/332036?v=4","gravatar_id":"","url":"https://api.github.com/users/oli-obk","html_url":"https://github.com/oli-obk","followers_url":"https://api.github.com/users/oli-obk/followers","following_url":"https://api.github.com/users/oli-obk/following{/other_user}","gists_url":"https://api.github.com/users/oli-obk/gists{/gist_id}","starred_url":"https://api.github.com/users/oli-obk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oli-obk/subscriptions","organizations_url":"https://api.github.com/users/oli-obk/orgs","repos_url":"https://api.github.com/users/oli-obk/repos","events_url":"https://api.github.com/users/oli-obk/events{/privacy}","received_events_url":"https://api.github.com/users/oli-obk/received_events","type":"User","site_admin":false},"assignees":[{"login":"oli-obk","id":332036,"node_id":"MDQ6VXNlcjMzMjAzNg==","avatar_url":"https://avatars2.githubusercontent.com/u/332036?v=4","gravatar_id":"","url":"https://api.github.com/users/oli-obk","html_url":"https://github.com/oli-obk","followers_url":"https://api.github.com/users/oli-obk/followers","following_url":"https://api.github.com/users/oli-obk/following{/other_user}","gists_url":"https://api.github.com/users/oli-obk/gists{/gist_id}","starred_url":"https://api.github.com/users/oli-obk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oli-obk/subscriptions","organizations_url":"https://api.github.com/users/oli-obk/orgs","repos_url":"https://api.github.com/users/oli-obk/repos","events_url":"https://api.github.com/users/oli-obk/events{/privacy}","received_events_url":"https://api.github.com/users/oli-obk/received_events","type":"User","site_admin":false}],"milestone":null,"comments":11,"created_at":"2018-06-27T04:06:44Z","updated_at":"2018-07-01T15:11:46Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/51833","html_url":"https://github.com/rust-lang/rust/pull/51833","diff_url":"https://github.com/rust-lang/rust/pull/51833.diff","patch_url":"https://github.com/rust-lang/rust/pull/51833.patch"},"body":"This is a different approach to #51672 as suggested by @oli-obk. Rather\r\nthan write each repeated value one-by-one, we write the first one and\r\nthen copy its value directly into the remaining memory.\r\n\r\nWith this change, the [toy program](https://github.com/rust-lang/rust/blob/c2f4744d2db4e162df824d0bd0b093ba4b351545/src/test/run-pass/mir_heavy_promoted.rs) goes from 63 seconds to 19 seconds on my machine.\r\n\r\nEdit: Inlining `Size::bytes()` saves an additional 6 seconds dropping the total time to 13 seconds on my machine.\r\n\r\nEdit2: Now down to 2.8 seconds.\r\n\r\nr? @oli-obk \r\n\r\ncc @nnethercote @eddyb "},"comment":{"url":"https://api.github.com/repos/rust-lang/rust/issues/comments/401612879","html_url":"https://github.com/rust-lang/rust/pull/51833#issuecomment-401612879","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/51833","id":401612879,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMTYxMjg3OQ==","user":{"login":"wesleywiser","id":831192,"node_id":"MDQ6VXNlcjgzMTE5Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/831192?v=4","gravatar_id":"","url":"https://api.github.com/users/wesleywiser","html_url":"https://github.com/wesleywiser","followers_url":"https://api.github.com/users/wesleywiser/followers","following_url":"https://api.github.com/users/wesleywiser/following{/other_user}","gists_url":"https://api.github.com/users/wesleywiser/gists{/gist_id}","starred_url":"https://api.github.com/users/wesleywiser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wesleywiser/subscriptions","organizations_url":"https://api.github.com/users/wesleywiser/orgs","repos_url":"https://api.github.com/users/wesleywiser/repos","events_url":"https://api.github.com/users/wesleywiser/events{/privacy}","received_events_url":"https://api.github.com/users/wesleywiser/received_events","type":"User","site_admin":false},"created_at":"2018-07-01T15:11:46Z","updated_at":"2018-07-01T15:11:46Z","author_association":"MEMBER","body":"Fixed tidy"}}
{"actor":{"display_login":"wesleywiser"}}