{"action":"closed","number":28943,"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/28943","id":210053964,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwMDUzOTY0","html_url":"https://github.com/cockroachdb/cockroach/pull/28943","diff_url":"https://github.com/cockroachdb/cockroach/pull/28943.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/28943.patch","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/28943","number":28943,"state":"closed","locked":false,"title":"sqlbase: add the missing comments and group functions by purpose","user":{"login":"knz","id":642886,"node_id":"MDQ6VXNlcjY0Mjg4Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/642886?v=4","gravatar_id":"","url":"https://api.github.com/users/knz","html_url":"https://github.com/knz","followers_url":"https://api.github.com/users/knz/followers","following_url":"https://api.github.com/users/knz/following{/other_user}","gists_url":"https://api.github.com/users/knz/gists{/gist_id}","starred_url":"https://api.github.com/users/knz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knz/subscriptions","organizations_url":"https://api.github.com/users/knz/orgs","repos_url":"https://api.github.com/users/knz/repos","events_url":"https://api.github.com/users/knz/events{/privacy}","received_events_url":"https://api.github.com/users/knz/received_events","type":"User","site_admin":false},"body":"First commits from #28942 and priors.\r\nForked from #28690.\r\n\r\nThe file `table.go` was getting unwieldy and was containing functions\r\nfrom different area of concern. This was making maintenance\r\nparticularly burdensome.\r\n\r\nThis patch splits the functionality in the following files:\r\n\r\n- `index_encoding.go`: index key prefixes, differences between primary\r\n  and secondary encodings, how to organize columns in an index.\r\n\r\n- `column_type_encoding.go`: encoding of SQL values into bytes\r\n  towards KV.\r\n\r\n- `column_type_properties.go`: conversions between various\r\n  representations of types in the SQL layer; derivation of properties\r\n  from SQL types.\r\n\r\n- `datum_alloc.go`: the `DatumAlloc` helper.\r\n\r\nRelease note: None\r\n","created_at":"2018-08-22T08:20:45Z","updated_at":"2018-08-23T09:29:28Z","closed_at":"2018-08-23T09:29:28Z","merged_at":"2018-08-23T09:29:28Z","merge_commit_sha":"c534d68b39ee8e9a0a114132d105e414506b07b2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[{"name":"sql-wiring-prs","id":2437978,"node_id":"MDQ6VGVhbTI0Mzc5Nzg=","slug":"sql-wiring-prs","description":"Join this team for notifications about SQL wiring PRs","privacy":"closed","url":"https://api.github.com/teams/2437978","members_url":"https://api.github.com/teams/2437978/members{/member}","repositories_url":"https://api.github.com/teams/2437978/repos","permission":"pull"},{"name":"sql-execution-prs","id":2437984,"node_id":"MDQ6VGVhbTI0Mzc5ODQ=","slug":"sql-execution-prs","description":"Join this team for notifications about SQL execution PRs","privacy":"closed","url":"https://api.github.com/teams/2437984","members_url":"https://api.github.com/teams/2437984/members{/member}","repositories_url":"https://api.github.com/teams/2437984/repos","permission":"pull"},{"name":"sql-planning-prs","id":2437986,"node_id":"MDQ6VGVhbTI0Mzc5ODY=","slug":"sql-planning-prs","description":"Join this team for notifications about SQL planning PRs","privacy":"closed","url":"https://api.github.com/teams/2437986","members_url":"https://api.github.com/teams/2437986/members{/member}","repositories_url":"https://api.github.com/teams/2437986/repos","permission":"pull"},{"name":"sql-async-prs","id":2437987,"node_id":"MDQ6VGVhbTI0Mzc5ODc=","slug":"sql-async-prs","description":"Join this team for notifications about SQL async PRs","privacy":"closed","url":"https://api.github.com/teams/2437987","members_url":"https://api.github.com/teams/2437987/members{/member}","repositories_url":"https://api.github.com/teams/2437987/repos","permission":"pull"},{"name":"distsql-prs","id":2437988,"node_id":"MDQ6VGVhbTI0Mzc5ODg=","slug":"distsql-prs","description":"Join this team for notifications about DistSQL PRs","privacy":"closed","url":"https://api.github.com/teams/2437988","members_url":"https://api.github.com/teams/2437988/members{/member}","repositories_url":"https://api.github.com/teams/2437988/repos","permission":"pull"},{"name":"sql-bulk-prs","id":2672383,"node_id":"MDQ6VGVhbTI2NzIzODM=","slug":"sql-bulk-prs","description":"","privacy":"closed","url":"https://api.github.com/teams/2672383","members_url":"https://api.github.com/teams/2672383/members{/member}","repositories_url":"https://api.github.com/teams/2672383/repos","permission":"pull"}],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/28943/commits","review_comments_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/28943/comments","review_comment_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/28943/comments","statuses_url":"https://api.github.com/repos/cockroachdb/cockroach/statuses/c534d68b39ee8e9a0a114132d105e414506b07b2","head":{"label":"knz:20180822-c5-separate-files","ref":"20180822-c5-separate-files","sha":"c534d68b39ee8e9a0a114132d105e414506b07b2","user":{"login":"knz","id":642886,"node_id":"MDQ6VXNlcjY0Mjg4Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/642886?v=4","gravatar_id":"","url":"https://api.github.com/users/knz","html_url":"https://github.com/knz","followers_url":"https://api.github.com/users/knz/followers","following_url":"https://api.github.com/users/knz/following{/other_user}","gists_url":"https://api.github.com/users/knz/gists{/gist_id}","starred_url":"https://api.github.com/users/knz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knz/subscriptions","organizations_url":"https://api.github.com/users/knz/orgs","repos_url":"https://api.github.com/users/knz/repos","events_url":"https://api.github.com/users/knz/events{/privacy}","received_events_url":"https://api.github.com/users/knz/received_events","type":"User","site_admin":false},"repo":{"id":49441405,"node_id":"MDEwOlJlcG9zaXRvcnk0OTQ0MTQwNQ==","name":"cockroach","full_name":"knz/cockroach","owner":{"login":"knz","id":642886,"node_id":"MDQ6VXNlcjY0Mjg4Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/642886?v=4","gravatar_id":"","url":"https://api.github.com/users/knz","html_url":"https://github.com/knz","followers_url":"https://api.github.com/users/knz/followers","following_url":"https://api.github.com/users/knz/following{/other_user}","gists_url":"https://api.github.com/users/knz/gists{/gist_id}","starred_url":"https://api.github.com/users/knz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knz/subscriptions","organizations_url":"https://api.github.com/users/knz/orgs","repos_url":"https://api.github.com/users/knz/repos","events_url":"https://api.github.com/users/knz/events{/privacy}","received_events_url":"https://api.github.com/users/knz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/knz/cockroach","description":"A Scalable, Survivable, Strongly-Consistent SQL Database","fork":true,"url":"https://api.github.com/repos/knz/cockroach","forks_url":"https://api.github.com/repos/knz/cockroach/forks","keys_url":"https://api.github.com/repos/knz/cockroach/keys{/key_id}","collaborators_url":"https://api.github.com/repos/knz/cockroach/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/knz/cockroach/teams","hooks_url":"https://api.github.com/repos/knz/cockroach/hooks","issue_events_url":"https://api.github.com/repos/knz/cockroach/issues/events{/number}","events_url":"https://api.github.com/repos/knz/cockroach/events","assignees_url":"https://api.github.com/repos/knz/cockroach/assignees{/user}","branches_url":"https://api.github.com/repos/knz/cockroach/branches{/branch}","tags_url":"https://api.github.com/repos/knz/cockroach/tags","blobs_url":"https://api.github.com/repos/knz/cockroach/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/knz/cockroach/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/knz/cockroach/git/refs{/sha}","trees_url":"https://api.github.com/repos/knz/cockroach/git/trees{/sha}","statuses_url":"https://api.github.com/repos/knz/cockroach/statuses/{sha}","languages_url":"https://api.github.com/repos/knz/cockroach/languages","stargazers_url":"https://api.github.com/repos/knz/cockroach/stargazers","contributors_url":"https://api.github.com/repos/knz/cockroach/contributors","subscribers_url":"https://api.github.com/repos/knz/cockroach/subscribers","subscription_url":"https://api.github.com/repos/knz/cockroach/subscription","commits_url":"https://api.github.com/repos/knz/cockroach/commits{/sha}","git_commits_url":"https://api.github.com/repos/knz/cockroach/git/commits{/sha}","comments_url":"https://api.github.com/repos/knz/cockroach/comments{/number}","issue_comment_url":"https://api.github.com/repos/knz/cockroach/issues/comments{/number}","contents_url":"https://api.github.com/repos/knz/cockroach/contents/{+path}","compare_url":"https://api.github.com/repos/knz/cockroach/compare/{base}...{head}","merges_url":"https://api.github.com/repos/knz/cockroach/merges","archive_url":"https://api.github.com/repos/knz/cockroach/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/knz/cockroach/downloads","issues_url":"https://api.github.com/repos/knz/cockroach/issues{/number}","pulls_url":"https://api.github.com/repos/knz/cockroach/pulls{/number}","milestones_url":"https://api.github.com/repos/knz/cockroach/milestones{/number}","notifications_url":"https://api.github.com/repos/knz/cockroach/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/knz/cockroach/labels{/name}","releases_url":"https://api.github.com/repos/knz/cockroach/releases{/id}","deployments_url":"https://api.github.com/repos/knz/cockroach/deployments","created_at":"2016-01-11T17:11:07Z","updated_at":"2018-08-17T07:09:56Z","pushed_at":"2018-08-23T09:09:04Z","git_url":"git://github.com/knz/cockroach.git","ssh_url":"git@github.com:knz/cockroach.git","clone_url":"https://github.com/knz/cockroach.git","svn_url":"https://github.com/knz/cockroach","homepage":"http://www.cockroachlabs.com","size":532831,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cockroachdb:master","ref":"master","sha":"caeed57eb00bc6dd85f447b08fc9a897a1bd7257","user":{"login":"cockroachdb","id":6748139,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NDgxMzk=","avatar_url":"https://avatars3.githubusercontent.com/u/6748139?v=4","gravatar_id":"","url":"https://api.github.com/users/cockroachdb","html_url":"https://github.com/cockroachdb","followers_url":"https://api.github.com/users/cockroachdb/followers","following_url":"https://api.github.com/users/cockroachdb/following{/other_user}","gists_url":"https://api.github.com/users/cockroachdb/gists{/gist_id}","starred_url":"https://api.github.com/users/cockroachdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockroachdb/subscriptions","organizations_url":"https://api.github.com/users/cockroachdb/orgs","repos_url":"https://api.github.com/users/cockroachdb/repos","events_url":"https://api.github.com/users/cockroachdb/events{/privacy}","received_events_url":"https://api.github.com/users/cockroachdb/received_events","type":"Organization","site_admin":false},"repo":{"id":16563587,"node_id":"MDEwOlJlcG9zaXRvcnkxNjU2MzU4Nw==","name":"cockroach","full_name":"cockroachdb/cockroach","owner":{"login":"cockroachdb","id":6748139,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NDgxMzk=","avatar_url":"https://avatars3.githubusercontent.com/u/6748139?v=4","gravatar_id":"","url":"https://api.github.com/users/cockroachdb","html_url":"https://github.com/cockroachdb","followers_url":"https://api.github.com/users/cockroachdb/followers","following_url":"https://api.github.com/users/cockroachdb/following{/other_user}","gists_url":"https://api.github.com/users/cockroachdb/gists{/gist_id}","starred_url":"https://api.github.com/users/cockroachdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockroachdb/subscriptions","organizations_url":"https://api.github.com/users/cockroachdb/orgs","repos_url":"https://api.github.com/users/cockroachdb/repos","events_url":"https://api.github.com/users/cockroachdb/events{/privacy}","received_events_url":"https://api.github.com/users/cockroachdb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cockroachdb/cockroach","description":"CockroachDB - the open source, cloud-native SQL database.","fork":false,"url":"https://api.github.com/repos/cockroachdb/cockroach","forks_url":"https://api.github.com/repos/cockroachdb/cockroach/forks","keys_url":"https://api.github.com/repos/cockroachdb/cockroach/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cockroachdb/cockroach/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cockroachdb/cockroach/teams","hooks_url":"https://api.github.com/repos/cockroachdb/cockroach/hooks","issue_events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/events{/number}","events_url":"https://api.github.com/repos/cockroachdb/cockroach/events","assignees_url":"https://api.github.com/repos/cockroachdb/cockroach/assignees{/user}","branches_url":"https://api.github.com/repos/cockroachdb/cockroach/branches{/branch}","tags_url":"https://api.github.com/repos/cockroachdb/cockroach/tags","blobs_url":"https://api.github.com/repos/cockroachdb/cockroach/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cockroachdb/cockroach/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cockroachdb/cockroach/git/refs{/sha}","trees_url":"https://api.github.com/repos/cockroachdb/cockroach/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cockroachdb/cockroach/statuses/{sha}","languages_url":"https://api.github.com/repos/cockroachdb/cockroach/languages","stargazers_url":"https://api.github.com/repos/cockroachdb/cockroach/stargazers","contributors_url":"https://api.github.com/repos/cockroachdb/cockroach/contributors","subscribers_url":"https://api.github.com/repos/cockroachdb/cockroach/subscribers","subscription_url":"https://api.github.com/repos/cockroachdb/cockroach/subscription","commits_url":"https://api.github.com/repos/cockroachdb/cockroach/commits{/sha}","git_commits_url":"https://api.github.com/repos/cockroachdb/cockroach/git/commits{/sha}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/comments{/number}","issue_comment_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments{/number}","contents_url":"https://api.github.com/repos/cockroachdb/cockroach/contents/{+path}","compare_url":"https://api.github.com/repos/cockroachdb/cockroach/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cockroachdb/cockroach/merges","archive_url":"https://api.github.com/repos/cockroachdb/cockroach/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cockroachdb/cockroach/downloads","issues_url":"https://api.github.com/repos/cockroachdb/cockroach/issues{/number}","pulls_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls{/number}","milestones_url":"https://api.github.com/repos/cockroachdb/cockroach/milestones{/number}","notifications_url":"https://api.github.com/repos/cockroachdb/cockroach/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/labels{/name}","releases_url":"https://api.github.com/repos/cockroachdb/cockroach/releases{/id}","deployments_url":"https://api.github.com/repos/cockroachdb/cockroach/deployments","created_at":"2014-02-06T00:18:47Z","updated_at":"2018-08-23T08:41:12Z","pushed_at":"2018-08-23T09:28:57Z","git_url":"git://github.com/cockroachdb/cockroach.git","ssh_url":"git@github.com:cockroachdb/cockroach.git","clone_url":"https://github.com/cockroachdb/cockroach.git","svn_url":"https://github.com/cockroachdb/cockroach","homepage":"https://www.cockroachlabs.com","size":1043867,"stargazers_count":14108,"watchers_count":14108,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1476,"mirror_url":null,"archived":false,"open_issues_count":1865,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1476,"open_issues":1865,"watchers":14108,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/28943"},"html":{"href":"https://github.com/cockroachdb/cockroach/pull/28943"},"issue":{"href":"https://api.github.com/repos/cockroachdb/cockroach/issues/28943"},"comments":{"href":"https://api.github.com/repos/cockroachdb/cockroach/issues/28943/comments"},"review_comments":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/28943/comments"},"review_comment":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/28943/commits"},"statuses":{"href":"https://api.github.com/repos/cockroachdb/cockroach/statuses/c534d68b39ee8e9a0a114132d105e414506b07b2"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"craig[bot]","id":37807150,"node_id":"MDM6Qm90Mzc4MDcxNTA=","avatar_url":"https://avatars0.githubusercontent.com/in/10419?v=4","gravatar_id":"","url":"https://api.github.com/users/craig%5Bbot%5D","html_url":"https://github.com/apps/craig","followers_url":"https://api.github.com/users/craig%5Bbot%5D/followers","following_url":"https://api.github.com/users/craig%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/craig%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/craig%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craig%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/craig%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/craig%5Bbot%5D/repos","events_url":"https://api.github.com/users/craig%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/craig%5Bbot%5D/received_events","type":"Bot","site_admin":false},"comments":7,"review_comments":0,"maintainer_can_modify":false,"commits":17,"additions":3276,"deletions":2980,"changed_files":20}}
{"actor":{"display_login":"craig"}}