{"action":"created","issue":{"url":"https://api.github.com/repos/friendica/friendica/issues/4440","repository_url":"https://api.github.com/repos/friendica/friendica","labels_url":"https://api.github.com/repos/friendica/friendica/issues/4440/labels{/name}","comments_url":"https://api.github.com/repos/friendica/friendica/issues/4440/comments","events_url":"https://api.github.com/repos/friendica/friendica/issues/4440/events","html_url":"https://github.com/friendica/friendica/pull/4440","id":296253369,"number":4440,"title":"fix undeclared variables or wrong variable names (/mod) part 2","user":{"login":"rabuzarus","id":3750381,"avatar_url":"https://avatars0.githubusercontent.com/u/3750381?v=4","gravatar_id":"","url":"https://api.github.com/users/rabuzarus","html_url":"https://github.com/rabuzarus","followers_url":"https://api.github.com/users/rabuzarus/followers","following_url":"https://api.github.com/users/rabuzarus/following{/other_user}","gists_url":"https://api.github.com/users/rabuzarus/gists{/gist_id}","starred_url":"https://api.github.com/users/rabuzarus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rabuzarus/subscriptions","organizations_url":"https://api.github.com/users/rabuzarus/orgs","repos_url":"https://api.github.com/users/rabuzarus/repos","events_url":"https://api.github.com/users/rabuzarus/events{/privacy}","received_events_url":"https://api.github.com/users/rabuzarus/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-02-12T02:43:28Z","updated_at":"2018-02-12T03:38:57Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/friendica/friendica/pulls/4440","html_url":"https://github.com/friendica/friendica/pull/4440","diff_url":"https://github.com/friendica/friendica/pull/4440.diff","patch_url":"https://github.com/friendica/friendica/pull/4440.patch"},"body":"Some variables were not declared. Some variables were not available. And some variables were did have a typo.\r\nThis PR fixes this issue for the files in the /mod directory.\r\n\r\nI couldn't solve following \"undeclared variable\" issues in /mod:\r\n1.) /mod/editpost.php\r\nL66 - https://github.com/friendica/friendica/blob/develop/mod/editpost.php#L64\r\nHow do we get the `$groups` variable? (does also affect L143)\r\n\r\n2.) /mod/follow.php\r\nL47 - https://github.com/friendica/friendica/blob/develop/mod/follow.php#L47\r\n`$contact_id` isn't declared. But I don't know the intended beavior so I couldn't fix it.\r\n\r\n3.) /mod/poke.php.\r\nL144 - https://github.com/friendica/friendica/blob/develop/mod/poke.php#L144\r\nWe have `$item_id` but what is `$post_id` and from where should we get it?\r\n\r\nNote:\r\nBy adding missing variables the code should be fixed but it could have an impact on how the code will work. Keep this in mind when reviewing the PR."},"comment":{"url":"https://api.github.com/repos/friendica/friendica/issues/comments/364822048","html_url":"https://github.com/friendica/friendica/pull/4440#issuecomment-364822048","issue_url":"https://api.github.com/repos/friendica/friendica/issues/4440","id":364822048,"user":{"login":"MrPetovan","id":925415,"avatar_url":"https://avatars1.githubusercontent.com/u/925415?v=4","gravatar_id":"","url":"https://api.github.com/users/MrPetovan","html_url":"https://github.com/MrPetovan","followers_url":"https://api.github.com/users/MrPetovan/followers","following_url":"https://api.github.com/users/MrPetovan/following{/other_user}","gists_url":"https://api.github.com/users/MrPetovan/gists{/gist_id}","starred_url":"https://api.github.com/users/MrPetovan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrPetovan/subscriptions","organizations_url":"https://api.github.com/users/MrPetovan/orgs","repos_url":"https://api.github.com/users/MrPetovan/repos","events_url":"https://api.github.com/users/MrPetovan/events{/privacy}","received_events_url":"https://api.github.com/users/MrPetovan/received_events","type":"User","site_admin":false},"created_at":"2018-02-12T03:38:57Z","updated_at":"2018-02-12T03:38:57Z","author_association":"COLLABORATOR","body":"I can merge right now, do you want me to wait for other people to take a look at it?"}}
{"actor":{"display_login":"MrPetovan"}}