{"action":"created","issue":{"url":"https://api.github.com/repos/jruby/activerecord-jdbc-adapter/issues/875","repository_url":"https://api.github.com/repos/jruby/activerecord-jdbc-adapter","labels_url":"https://api.github.com/repos/jruby/activerecord-jdbc-adapter/issues/875/labels{/name}","comments_url":"https://api.github.com/repos/jruby/activerecord-jdbc-adapter/issues/875/comments","events_url":"https://api.github.com/repos/jruby/activerecord-jdbc-adapter/issues/875/events","html_url":"https://github.com/jruby/activerecord-jdbc-adapter/pull/875","id":307818232,"number":875,"title":"WIP: Provide a standard Result object","user":{"login":"rdubya","id":572868,"avatar_url":"https://avatars0.githubusercontent.com/u/572868?v=4","gravatar_id":"","url":"https://api.github.com/users/rdubya","html_url":"https://github.com/rdubya","followers_url":"https://api.github.com/users/rdubya/followers","following_url":"https://api.github.com/users/rdubya/following{/other_user}","gists_url":"https://api.github.com/users/rdubya/gists{/gist_id}","starred_url":"https://api.github.com/users/rdubya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdubya/subscriptions","organizations_url":"https://api.github.com/users/rdubya/orgs","repos_url":"https://api.github.com/users/rdubya/repos","events_url":"https://api.github.com/users/rdubya/events{/privacy}","received_events_url":"https://api.github.com/users/rdubya/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-03-22T21:17:46Z","updated_at":"2018-03-22T21:22:11Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/jruby/activerecord-jdbc-adapter/pulls/875","html_url":"https://github.com/jruby/activerecord-jdbc-adapter/pull/875","diff_url":"https://github.com/jruby/activerecord-jdbc-adapter/pull/875.diff","patch_url":"https://github.com/jruby/activerecord-jdbc-adapter/pull/875.patch"},"body":"This creates a standard JdbcResult object that can be returned for \"raw\" results similar to the driver objects for the other adapters (i.e. PG::Result)\r\n\r\nIt moves all of the Java -> Ruby object conversion into dedicated column type classes. This helps to shrink down the size of the adapter classes as well as make it a little easier to follow where things are happening and what adapters are using what conversion types (I hope lol)\r\n\r\nThese changes fix a couple of rails tests and should be able to be back ported to the 50-stable branch. \r\n\r\nI plan on converting the mysql and sqlite adapters as well but wanted to get this up so that it could be reviewed before I spent waayyyy too much time on it. :)"},"comment":{"url":"https://api.github.com/repos/jruby/activerecord-jdbc-adapter/issues/comments/375461740","html_url":"https://github.com/jruby/activerecord-jdbc-adapter/pull/875#issuecomment-375461740","issue_url":"https://api.github.com/repos/jruby/activerecord-jdbc-adapter/issues/875","id":375461740,"user":{"login":"rdubya","id":572868,"avatar_url":"https://avatars0.githubusercontent.com/u/572868?v=4","gravatar_id":"","url":"https://api.github.com/users/rdubya","html_url":"https://github.com/rdubya","followers_url":"https://api.github.com/users/rdubya/followers","following_url":"https://api.github.com/users/rdubya/following{/other_user}","gists_url":"https://api.github.com/users/rdubya/gists{/gist_id}","starred_url":"https://api.github.com/users/rdubya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdubya/subscriptions","organizations_url":"https://api.github.com/users/rdubya/orgs","repos_url":"https://api.github.com/users/rdubya/repos","events_url":"https://api.github.com/users/rdubya/events{/privacy}","received_events_url":"https://api.github.com/users/rdubya/received_events","type":"User","site_admin":false},"created_at":"2018-03-22T21:22:11Z","updated_at":"2018-03-22T21:22:11Z","author_association":"COLLABORATOR","body":"Another thing that came up while doing these changeovers: If I leave arrays and time/timestamps as strings, it actually fixes some postgres related test failures. Do we need to try to parse these? I'm not sure we actually have enough data to parse the arrays reliably enough, so I think we should leave those as strings. But, can we do the same thing for dates/times? "}}
{"actor":{"display_login":"rdubya"}}