{"action":"created","comment":{"url":"https://api.github.com/repos/PopulateTools/gobierto/pulls/comments/173427518","pull_request_review_id":102618372,"id":173427518,"diff_hunk":"@@ -26,15 +26,25 @@ def render(context)\n     return \"\"\n   end\n \n+  def gobierto_cms_page_or_news_path(page, options = {})\n+    url_helpers = Rails.application.routes.url_helpers\n+    if page.collection.item_type == \"GobiertoCms::Page\"\n+      url_helpers.gobierto_cms_page_path(page.slug, options)\n+    elsif page.collection.item_type == \"GobiertoCms::News\"","path":"lib/liquid/gobierto_cms/tags/list_children_pages.rb","position":8,"original_position":8,"commit_id":"72c3755e2742efffbd9dc984ec439b88ecdf67e6","original_commit_id":"72c3755e2742efffbd9dc984ec439b88ecdf67e6","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Prefer single-quoted strings when you don't need string interpolation or special symbols.","created_at":"2018-03-09T11:32:09Z","updated_at":"2018-03-09T11:32:10Z","html_url":"https://github.com/PopulateTools/gobierto/pull/1509#discussion_r173427518","pull_request_url":"https://api.github.com/repos/PopulateTools/gobierto/pulls/1509","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/PopulateTools/gobierto/pulls/comments/173427518"},"html":{"href":"https://github.com/PopulateTools/gobierto/pull/1509#discussion_r173427518"},"pull_request":{"href":"https://api.github.com/repos/PopulateTools/gobierto/pulls/1509"}}},"pull_request":{"url":"https://api.github.com/repos/PopulateTools/gobierto/pulls/1509","id":173982864,"html_url":"https://github.com/PopulateTools/gobierto/pull/1509","diff_url":"https://github.com/PopulateTools/gobierto/pull/1509.diff","patch_url":"https://github.com/PopulateTools/gobierto/pull/1509.patch","issue_url":"https://api.github.com/repos/PopulateTools/gobierto/issues/1509","number":1509,"state":"open","locked":false,"title":"286 wrong links for liquid generated","user":{"login":"apradillap","id":69764,"avatar_url":"https://avatars0.githubusercontent.com/u/69764?v=4","gravatar_id":"","url":"https://api.github.com/users/apradillap","html_url":"https://github.com/apradillap","followers_url":"https://api.github.com/users/apradillap/followers","following_url":"https://api.github.com/users/apradillap/following{/other_user}","gists_url":"https://api.github.com/users/apradillap/gists{/gist_id}","starred_url":"https://api.github.com/users/apradillap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apradillap/subscriptions","organizations_url":"https://api.github.com/users/apradillap/orgs","repos_url":"https://api.github.com/users/apradillap/repos","events_url":"https://api.github.com/users/apradillap/events{/privacy}","received_events_url":"https://api.github.com/users/apradillap/received_events","type":"User","site_admin":false},"body":"Closes https://github.com/PopulateTools/issues/issues/286\r\n\r\n## :v: What does this PR do?\r\n\r\nFixed the liquid tag for the generation of links to the child pages.\r\n\r\n## :mag: How should this be manually tested?\r\n\r\nAdding the tag in a page (with page-slug) with childrens.\r\n{% list_children_pages page-slug %}\r\n\r\n## :eyes: Screenshots\r\n\r\n### Before this PR\r\n\r\nLiquid Error\r\n\r\n### After this PR\r\n\r\n<img width=\"1440\" alt=\"captura de pantalla 2018-03-09 a las 12 29 04\" src=\"https://user-images.githubusercontent.com/69764/37205585-900a9f3c-2395-11e8-85e1-0c157fff3496.png\">\r\n\r\n## :shipit: Does this PR changes any configuration file?\r\n\r\nNo","created_at":"2018-03-09T11:31:57Z","updated_at":"2018-03-09T11:32:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"96b881292f966e72791c3db93058113a8433b434","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/PopulateTools/gobierto/pulls/1509/commits","review_comments_url":"https://api.github.com/repos/PopulateTools/gobierto/pulls/1509/comments","review_comment_url":"https://api.github.com/repos/PopulateTools/gobierto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PopulateTools/gobierto/issues/1509/comments","statuses_url":"https://api.github.com/repos/PopulateTools/gobierto/statuses/72c3755e2742efffbd9dc984ec439b88ecdf67e6","head":{"label":"PopulateTools:286-wrong-links-for_liquid-generated","ref":"286-wrong-links-for_liquid-generated","sha":"72c3755e2742efffbd9dc984ec439b88ecdf67e6","user":{"login":"PopulateTools","id":12809868,"avatar_url":"https://avatars2.githubusercontent.com/u/12809868?v=4","gravatar_id":"","url":"https://api.github.com/users/PopulateTools","html_url":"https://github.com/PopulateTools","followers_url":"https://api.github.com/users/PopulateTools/followers","following_url":"https://api.github.com/users/PopulateTools/following{/other_user}","gists_url":"https://api.github.com/users/PopulateTools/gists{/gist_id}","starred_url":"https://api.github.com/users/PopulateTools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PopulateTools/subscriptions","organizations_url":"https://api.github.com/users/PopulateTools/orgs","repos_url":"https://api.github.com/users/PopulateTools/repos","events_url":"https://api.github.com/users/PopulateTools/events{/privacy}","received_events_url":"https://api.github.com/users/PopulateTools/received_events","type":"Organization","site_admin":false},"repo":{"id":71801692,"name":"gobierto","full_name":"PopulateTools/gobierto","owner":{"login":"PopulateTools","id":12809868,"avatar_url":"https://avatars2.githubusercontent.com/u/12809868?v=4","gravatar_id":"","url":"https://api.github.com/users/PopulateTools","html_url":"https://github.com/PopulateTools","followers_url":"https://api.github.com/users/PopulateTools/followers","following_url":"https://api.github.com/users/PopulateTools/following{/other_user}","gists_url":"https://api.github.com/users/PopulateTools/gists{/gist_id}","starred_url":"https://api.github.com/users/PopulateTools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PopulateTools/subscriptions","organizations_url":"https://api.github.com/users/PopulateTools/orgs","repos_url":"https://api.github.com/users/PopulateTools/repos","events_url":"https://api.github.com/users/PopulateTools/events{/privacy}","received_events_url":"https://api.github.com/users/PopulateTools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PopulateTools/gobierto","description":"Plataforma de gobierno abierto open source","fork":false,"url":"https://api.github.com/repos/PopulateTools/gobierto","forks_url":"https://api.github.com/repos/PopulateTools/gobierto/forks","keys_url":"https://api.github.com/repos/PopulateTools/gobierto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PopulateTools/gobierto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PopulateTools/gobierto/teams","hooks_url":"https://api.github.com/repos/PopulateTools/gobierto/hooks","issue_events_url":"https://api.github.com/repos/PopulateTools/gobierto/issues/events{/number}","events_url":"https://api.github.com/repos/PopulateTools/gobierto/events","assignees_url":"https://api.github.com/repos/PopulateTools/gobierto/assignees{/user}","branches_url":"https://api.github.com/repos/PopulateTools/gobierto/branches{/branch}","tags_url":"https://api.github.com/repos/PopulateTools/gobierto/tags","blobs_url":"https://api.github.com/repos/PopulateTools/gobierto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PopulateTools/gobierto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PopulateTools/gobierto/git/refs{/sha}","trees_url":"https://api.github.com/repos/PopulateTools/gobierto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PopulateTools/gobierto/statuses/{sha}","languages_url":"https://api.github.com/repos/PopulateTools/gobierto/languages","stargazers_url":"https://api.github.com/repos/PopulateTools/gobierto/stargazers","contributors_url":"https://api.github.com/repos/PopulateTools/gobierto/contributors","subscribers_url":"https://api.github.com/repos/PopulateTools/gobierto/subscribers","subscription_url":"https://api.github.com/repos/PopulateTools/gobierto/subscription","commits_url":"https://api.github.com/repos/PopulateTools/gobierto/commits{/sha}","git_commits_url":"https://api.github.com/repos/PopulateTools/gobierto/git/commits{/sha}","comments_url":"https://api.github.com/repos/PopulateTools/gobierto/comments{/number}","issue_comment_url":"https://api.github.com/repos/PopulateTools/gobierto/issues/comments{/number}","contents_url":"https://api.github.com/repos/PopulateTools/gobierto/contents/{+path}","compare_url":"https://api.github.com/repos/PopulateTools/gobierto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PopulateTools/gobierto/merges","archive_url":"https://api.github.com/repos/PopulateTools/gobierto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PopulateTools/gobierto/downloads","issues_url":"https://api.github.com/repos/PopulateTools/gobierto/issues{/number}","pulls_url":"https://api.github.com/repos/PopulateTools/gobierto/pulls{/number}","milestones_url":"https://api.github.com/repos/PopulateTools/gobierto/milestones{/number}","notifications_url":"https://api.github.com/repos/PopulateTools/gobierto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PopulateTools/gobierto/labels{/name}","releases_url":"https://api.github.com/repos/PopulateTools/gobierto/releases{/id}","deployments_url":"https://api.github.com/repos/PopulateTools/gobierto/deployments","created_at":"2016-10-24T15:13:26Z","updated_at":"2018-02-12T15:17:59Z","pushed_at":"2018-03-09T11:31:58Z","git_url":"git://github.com/PopulateTools/gobierto.git","ssh_url":"git@github.com:PopulateTools/gobierto.git","clone_url":"https://github.com/PopulateTools/gobierto.git","svn_url":"https://github.com/PopulateTools/gobierto","homepage":"https://gobierto.es","size":19908,"stargazers_count":30,"watchers_count":30,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":96,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":8,"open_issues":96,"watchers":30,"default_branch":"master"}},"base":{"label":"PopulateTools:master","ref":"master","sha":"d1646e33be82f251fcf579483b30f790b2e64cbe","user":{"login":"PopulateTools","id":12809868,"avatar_url":"https://avatars2.githubusercontent.com/u/12809868?v=4","gravatar_id":"","url":"https://api.github.com/users/PopulateTools","html_url":"https://github.com/PopulateTools","followers_url":"https://api.github.com/users/PopulateTools/followers","following_url":"https://api.github.com/users/PopulateTools/following{/other_user}","gists_url":"https://api.github.com/users/PopulateTools/gists{/gist_id}","starred_url":"https://api.github.com/users/PopulateTools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PopulateTools/subscriptions","organizations_url":"https://api.github.com/users/PopulateTools/orgs","repos_url":"https://api.github.com/users/PopulateTools/repos","events_url":"https://api.github.com/users/PopulateTools/events{/privacy}","received_events_url":"https://api.github.com/users/PopulateTools/received_events","type":"Organization","site_admin":false},"repo":{"id":71801692,"name":"gobierto","full_name":"PopulateTools/gobierto","owner":{"login":"PopulateTools","id":12809868,"avatar_url":"https://avatars2.githubusercontent.com/u/12809868?v=4","gravatar_id":"","url":"https://api.github.com/users/PopulateTools","html_url":"https://github.com/PopulateTools","followers_url":"https://api.github.com/users/PopulateTools/followers","following_url":"https://api.github.com/users/PopulateTools/following{/other_user}","gists_url":"https://api.github.com/users/PopulateTools/gists{/gist_id}","starred_url":"https://api.github.com/users/PopulateTools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PopulateTools/subscriptions","organizations_url":"https://api.github.com/users/PopulateTools/orgs","repos_url":"https://api.github.com/users/PopulateTools/repos","events_url":"https://api.github.com/users/PopulateTools/events{/privacy}","received_events_url":"https://api.github.com/users/PopulateTools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PopulateTools/gobierto","description":"Plataforma de gobierno abierto open source","fork":false,"url":"https://api.github.com/repos/PopulateTools/gobierto","forks_url":"https://api.github.com/repos/PopulateTools/gobierto/forks","keys_url":"https://api.github.com/repos/PopulateTools/gobierto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PopulateTools/gobierto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PopulateTools/gobierto/teams","hooks_url":"https://api.github.com/repos/PopulateTools/gobierto/hooks","issue_events_url":"https://api.github.com/repos/PopulateTools/gobierto/issues/events{/number}","events_url":"https://api.github.com/repos/PopulateTools/gobierto/events","assignees_url":"https://api.github.com/repos/PopulateTools/gobierto/assignees{/user}","branches_url":"https://api.github.com/repos/PopulateTools/gobierto/branches{/branch}","tags_url":"https://api.github.com/repos/PopulateTools/gobierto/tags","blobs_url":"https://api.github.com/repos/PopulateTools/gobierto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PopulateTools/gobierto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PopulateTools/gobierto/git/refs{/sha}","trees_url":"https://api.github.com/repos/PopulateTools/gobierto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PopulateTools/gobierto/statuses/{sha}","languages_url":"https://api.github.com/repos/PopulateTools/gobierto/languages","stargazers_url":"https://api.github.com/repos/PopulateTools/gobierto/stargazers","contributors_url":"https://api.github.com/repos/PopulateTools/gobierto/contributors","subscribers_url":"https://api.github.com/repos/PopulateTools/gobierto/subscribers","subscription_url":"https://api.github.com/repos/PopulateTools/gobierto/subscription","commits_url":"https://api.github.com/repos/PopulateTools/gobierto/commits{/sha}","git_commits_url":"https://api.github.com/repos/PopulateTools/gobierto/git/commits{/sha}","comments_url":"https://api.github.com/repos/PopulateTools/gobierto/comments{/number}","issue_comment_url":"https://api.github.com/repos/PopulateTools/gobierto/issues/comments{/number}","contents_url":"https://api.github.com/repos/PopulateTools/gobierto/contents/{+path}","compare_url":"https://api.github.com/repos/PopulateTools/gobierto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PopulateTools/gobierto/merges","archive_url":"https://api.github.com/repos/PopulateTools/gobierto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PopulateTools/gobierto/downloads","issues_url":"https://api.github.com/repos/PopulateTools/gobierto/issues{/number}","pulls_url":"https://api.github.com/repos/PopulateTools/gobierto/pulls{/number}","milestones_url":"https://api.github.com/repos/PopulateTools/gobierto/milestones{/number}","notifications_url":"https://api.github.com/repos/PopulateTools/gobierto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PopulateTools/gobierto/labels{/name}","releases_url":"https://api.github.com/repos/PopulateTools/gobierto/releases{/id}","deployments_url":"https://api.github.com/repos/PopulateTools/gobierto/deployments","created_at":"2016-10-24T15:13:26Z","updated_at":"2018-02-12T15:17:59Z","pushed_at":"2018-03-09T11:31:58Z","git_url":"git://github.com/PopulateTools/gobierto.git","ssh_url":"git@github.com:PopulateTools/gobierto.git","clone_url":"https://github.com/PopulateTools/gobierto.git","svn_url":"https://github.com/PopulateTools/gobierto","homepage":"https://gobierto.es","size":19908,"stargazers_count":30,"watchers_count":30,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":96,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":8,"open_issues":96,"watchers":30,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PopulateTools/gobierto/pulls/1509"},"html":{"href":"https://github.com/PopulateTools/gobierto/pull/1509"},"issue":{"href":"https://api.github.com/repos/PopulateTools/gobierto/issues/1509"},"comments":{"href":"https://api.github.com/repos/PopulateTools/gobierto/issues/1509/comments"},"review_comments":{"href":"https://api.github.com/repos/PopulateTools/gobierto/pulls/1509/comments"},"review_comment":{"href":"https://api.github.com/repos/PopulateTools/gobierto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PopulateTools/gobierto/pulls/1509/commits"},"statuses":{"href":"https://api.github.com/repos/PopulateTools/gobierto/statuses/72c3755e2742efffbd9dc984ec439b88ecdf67e6"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"houndci-bot"}}