{"action":"opened","number":36,"pull_request":{"url":"https://api.github.com/repos/logdna/nodejs/pulls/36","id":200761083,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwNzYxMDgz","html_url":"https://github.com/logdna/nodejs/pull/36","diff_url":"https://github.com/logdna/nodejs/pull/36.diff","patch_url":"https://github.com/logdna/nodejs/pull/36.patch","issue_url":"https://api.github.com/repos/logdna/nodejs/issues/36","number":36,"state":"open","locked":false,"title":"Set withCredentials explicitly to support MeteorJS","user":{"login":"FatalTouch","id":8601052,"node_id":"MDQ6VXNlcjg2MDEwNTI=","avatar_url":"https://avatars0.githubusercontent.com/u/8601052?v=4","gravatar_id":"","url":"https://api.github.com/users/FatalTouch","html_url":"https://github.com/FatalTouch","followers_url":"https://api.github.com/users/FatalTouch/followers","following_url":"https://api.github.com/users/FatalTouch/following{/other_user}","gists_url":"https://api.github.com/users/FatalTouch/gists{/gist_id}","starred_url":"https://api.github.com/users/FatalTouch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FatalTouch/subscriptions","organizations_url":"https://api.github.com/users/FatalTouch/orgs","repos_url":"https://api.github.com/users/FatalTouch/repos","events_url":"https://api.github.com/users/FatalTouch/events{/privacy}","received_events_url":"https://api.github.com/users/FatalTouch/received_events","type":"User","site_admin":false},"body":"There is a CORS issue when using this library with Meteor.\r\n\r\n`Failed to load https://logs.logdna.com/logs/ingest?hostname=localhost&now=1531324286589: Response to preflight request doesn't pass access control check: The value of the 'Access-Control-Allow-Origin' header in the response must not be the wildcard '*' when the request's credentials mode is 'include'. Origin 'http://localhost:3000' is therefore not allowed access. The credentials mode of requests initiated by the XMLHttpRequest is controlled by the withCredentials attribute.`\r\n\r\nThe same issue was reported in another library and was fixed by setting withCredentials to false explicitly.\r\n\r\nhttps://github.com/GetStream/stream-js/issues/99\r\n\r\nI tested the fix and was able to log normally after setting the withCredentials to false in the request made by this library.\r\n\r\nThis shouldn't have any effect on existing functionality and will fix the problem with Meteor.","created_at":"2018-07-11T16:40:00Z","updated_at":"2018-07-11T16:40:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/logdna/nodejs/pulls/36/commits","review_comments_url":"https://api.github.com/repos/logdna/nodejs/pulls/36/comments","review_comment_url":"https://api.github.com/repos/logdna/nodejs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/logdna/nodejs/issues/36/comments","statuses_url":"https://api.github.com/repos/logdna/nodejs/statuses/fa6627d73c8f0502a96ff88d40dc0abcc66d0976","head":{"label":"FatalTouch:meteor-fix-2018-07-11","ref":"meteor-fix-2018-07-11","sha":"fa6627d73c8f0502a96ff88d40dc0abcc66d0976","user":{"login":"FatalTouch","id":8601052,"node_id":"MDQ6VXNlcjg2MDEwNTI=","avatar_url":"https://avatars0.githubusercontent.com/u/8601052?v=4","gravatar_id":"","url":"https://api.github.com/users/FatalTouch","html_url":"https://github.com/FatalTouch","followers_url":"https://api.github.com/users/FatalTouch/followers","following_url":"https://api.github.com/users/FatalTouch/following{/other_user}","gists_url":"https://api.github.com/users/FatalTouch/gists{/gist_id}","starred_url":"https://api.github.com/users/FatalTouch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FatalTouch/subscriptions","organizations_url":"https://api.github.com/users/FatalTouch/orgs","repos_url":"https://api.github.com/users/FatalTouch/repos","events_url":"https://api.github.com/users/FatalTouch/events{/privacy}","received_events_url":"https://api.github.com/users/FatalTouch/received_events","type":"User","site_admin":false},"repo":{"id":140601885,"node_id":"MDEwOlJlcG9zaXRvcnkxNDA2MDE4ODU=","name":"nodejs","full_name":"FatalTouch/nodejs","owner":{"login":"FatalTouch","id":8601052,"node_id":"MDQ6VXNlcjg2MDEwNTI=","avatar_url":"https://avatars0.githubusercontent.com/u/8601052?v=4","gravatar_id":"","url":"https://api.github.com/users/FatalTouch","html_url":"https://github.com/FatalTouch","followers_url":"https://api.github.com/users/FatalTouch/followers","following_url":"https://api.github.com/users/FatalTouch/following{/other_user}","gists_url":"https://api.github.com/users/FatalTouch/gists{/gist_id}","starred_url":"https://api.github.com/users/FatalTouch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FatalTouch/subscriptions","organizations_url":"https://api.github.com/users/FatalTouch/orgs","repos_url":"https://api.github.com/users/FatalTouch/repos","events_url":"https://api.github.com/users/FatalTouch/events{/privacy}","received_events_url":"https://api.github.com/users/FatalTouch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/FatalTouch/nodejs","description":"Node.js library for logging to LogDNA","fork":true,"url":"https://api.github.com/repos/FatalTouch/nodejs","forks_url":"https://api.github.com/repos/FatalTouch/nodejs/forks","keys_url":"https://api.github.com/repos/FatalTouch/nodejs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FatalTouch/nodejs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FatalTouch/nodejs/teams","hooks_url":"https://api.github.com/repos/FatalTouch/nodejs/hooks","issue_events_url":"https://api.github.com/repos/FatalTouch/nodejs/issues/events{/number}","events_url":"https://api.github.com/repos/FatalTouch/nodejs/events","assignees_url":"https://api.github.com/repos/FatalTouch/nodejs/assignees{/user}","branches_url":"https://api.github.com/repos/FatalTouch/nodejs/branches{/branch}","tags_url":"https://api.github.com/repos/FatalTouch/nodejs/tags","blobs_url":"https://api.github.com/repos/FatalTouch/nodejs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FatalTouch/nodejs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FatalTouch/nodejs/git/refs{/sha}","trees_url":"https://api.github.com/repos/FatalTouch/nodejs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FatalTouch/nodejs/statuses/{sha}","languages_url":"https://api.github.com/repos/FatalTouch/nodejs/languages","stargazers_url":"https://api.github.com/repos/FatalTouch/nodejs/stargazers","contributors_url":"https://api.github.com/repos/FatalTouch/nodejs/contributors","subscribers_url":"https://api.github.com/repos/FatalTouch/nodejs/subscribers","subscription_url":"https://api.github.com/repos/FatalTouch/nodejs/subscription","commits_url":"https://api.github.com/repos/FatalTouch/nodejs/commits{/sha}","git_commits_url":"https://api.github.com/repos/FatalTouch/nodejs/git/commits{/sha}","comments_url":"https://api.github.com/repos/FatalTouch/nodejs/comments{/number}","issue_comment_url":"https://api.github.com/repos/FatalTouch/nodejs/issues/comments{/number}","contents_url":"https://api.github.com/repos/FatalTouch/nodejs/contents/{+path}","compare_url":"https://api.github.com/repos/FatalTouch/nodejs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FatalTouch/nodejs/merges","archive_url":"https://api.github.com/repos/FatalTouch/nodejs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FatalTouch/nodejs/downloads","issues_url":"https://api.github.com/repos/FatalTouch/nodejs/issues{/number}","pulls_url":"https://api.github.com/repos/FatalTouch/nodejs/pulls{/number}","milestones_url":"https://api.github.com/repos/FatalTouch/nodejs/milestones{/number}","notifications_url":"https://api.github.com/repos/FatalTouch/nodejs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FatalTouch/nodejs/labels{/name}","releases_url":"https://api.github.com/repos/FatalTouch/nodejs/releases{/id}","deployments_url":"https://api.github.com/repos/FatalTouch/nodejs/deployments","created_at":"2018-07-11T16:28:06Z","updated_at":"2018-07-11T16:28:08Z","pushed_at":"2018-07-11T16:33:45Z","git_url":"git://github.com/FatalTouch/nodejs.git","ssh_url":"git@github.com:FatalTouch/nodejs.git","clone_url":"https://github.com/FatalTouch/nodejs.git","svn_url":"https://github.com/FatalTouch/nodejs","homepage":null,"size":93,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"logdna:master","ref":"master","sha":"9e2ad6917cb577422781cef0caa2ffe6e00683d8","user":{"login":"logdna","id":17461937,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NDYxOTM3","avatar_url":"https://avatars3.githubusercontent.com/u/17461937?v=4","gravatar_id":"","url":"https://api.github.com/users/logdna","html_url":"https://github.com/logdna","followers_url":"https://api.github.com/users/logdna/followers","following_url":"https://api.github.com/users/logdna/following{/other_user}","gists_url":"https://api.github.com/users/logdna/gists{/gist_id}","starred_url":"https://api.github.com/users/logdna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/logdna/subscriptions","organizations_url":"https://api.github.com/users/logdna/orgs","repos_url":"https://api.github.com/users/logdna/repos","events_url":"https://api.github.com/users/logdna/events{/privacy}","received_events_url":"https://api.github.com/users/logdna/received_events","type":"Organization","site_admin":false},"repo":{"id":63717341,"node_id":"MDEwOlJlcG9zaXRvcnk2MzcxNzM0MQ==","name":"nodejs","full_name":"logdna/nodejs","owner":{"login":"logdna","id":17461937,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NDYxOTM3","avatar_url":"https://avatars3.githubusercontent.com/u/17461937?v=4","gravatar_id":"","url":"https://api.github.com/users/logdna","html_url":"https://github.com/logdna","followers_url":"https://api.github.com/users/logdna/followers","following_url":"https://api.github.com/users/logdna/following{/other_user}","gists_url":"https://api.github.com/users/logdna/gists{/gist_id}","starred_url":"https://api.github.com/users/logdna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/logdna/subscriptions","organizations_url":"https://api.github.com/users/logdna/orgs","repos_url":"https://api.github.com/users/logdna/repos","events_url":"https://api.github.com/users/logdna/events{/privacy}","received_events_url":"https://api.github.com/users/logdna/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/logdna/nodejs","description":"Node.js library for logging to LogDNA","fork":false,"url":"https://api.github.com/repos/logdna/nodejs","forks_url":"https://api.github.com/repos/logdna/nodejs/forks","keys_url":"https://api.github.com/repos/logdna/nodejs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/logdna/nodejs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/logdna/nodejs/teams","hooks_url":"https://api.github.com/repos/logdna/nodejs/hooks","issue_events_url":"https://api.github.com/repos/logdna/nodejs/issues/events{/number}","events_url":"https://api.github.com/repos/logdna/nodejs/events","assignees_url":"https://api.github.com/repos/logdna/nodejs/assignees{/user}","branches_url":"https://api.github.com/repos/logdna/nodejs/branches{/branch}","tags_url":"https://api.github.com/repos/logdna/nodejs/tags","blobs_url":"https://api.github.com/repos/logdna/nodejs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/logdna/nodejs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/logdna/nodejs/git/refs{/sha}","trees_url":"https://api.github.com/repos/logdna/nodejs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/logdna/nodejs/statuses/{sha}","languages_url":"https://api.github.com/repos/logdna/nodejs/languages","stargazers_url":"https://api.github.com/repos/logdna/nodejs/stargazers","contributors_url":"https://api.github.com/repos/logdna/nodejs/contributors","subscribers_url":"https://api.github.com/repos/logdna/nodejs/subscribers","subscription_url":"https://api.github.com/repos/logdna/nodejs/subscription","commits_url":"https://api.github.com/repos/logdna/nodejs/commits{/sha}","git_commits_url":"https://api.github.com/repos/logdna/nodejs/git/commits{/sha}","comments_url":"https://api.github.com/repos/logdna/nodejs/comments{/number}","issue_comment_url":"https://api.github.com/repos/logdna/nodejs/issues/comments{/number}","contents_url":"https://api.github.com/repos/logdna/nodejs/contents/{+path}","compare_url":"https://api.github.com/repos/logdna/nodejs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/logdna/nodejs/merges","archive_url":"https://api.github.com/repos/logdna/nodejs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/logdna/nodejs/downloads","issues_url":"https://api.github.com/repos/logdna/nodejs/issues{/number}","pulls_url":"https://api.github.com/repos/logdna/nodejs/pulls{/number}","milestones_url":"https://api.github.com/repos/logdna/nodejs/milestones{/number}","notifications_url":"https://api.github.com/repos/logdna/nodejs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/logdna/nodejs/labels{/name}","releases_url":"https://api.github.com/repos/logdna/nodejs/releases{/id}","deployments_url":"https://api.github.com/repos/logdna/nodejs/deployments","created_at":"2016-07-19T18:12:52Z","updated_at":"2018-07-03T11:41:20Z","pushed_at":"2018-05-18T20:57:47Z","git_url":"git://github.com/logdna/nodejs.git","ssh_url":"git@github.com:logdna/nodejs.git","clone_url":"https://github.com/logdna/nodejs.git","svn_url":"https://github.com/logdna/nodejs","homepage":null,"size":93,"stargazers_count":20,"watchers_count":20,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":18,"open_issues":5,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/logdna/nodejs/pulls/36"},"html":{"href":"https://github.com/logdna/nodejs/pull/36"},"issue":{"href":"https://api.github.com/repos/logdna/nodejs/issues/36"},"comments":{"href":"https://api.github.com/repos/logdna/nodejs/issues/36/comments"},"review_comments":{"href":"https://api.github.com/repos/logdna/nodejs/pulls/36/comments"},"review_comment":{"href":"https://api.github.com/repos/logdna/nodejs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/logdna/nodejs/pulls/36/commits"},"statuses":{"href":"https://api.github.com/repos/logdna/nodejs/statuses/fa6627d73c8f0502a96ff88d40dc0abcc66d0976"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":2,"deletions":0,"changed_files":2}}
{"actor":{"display_login":"FatalTouch"}}