{"push_id":2584651080,"size":6,"distinct_size":6,"ref":"refs/heads/staging","head":"81f3b0136fbd45449aa81af1cd26791d69922373","before":"e9991b8f6a320403d22b5f8f895fec6cb6eda334","commits":[{"sha":"36c1f98869d7f67a96166643ce1425104731e717","author":{"name":"Solon Gordon","email":"d094ebad5aad5ff73e8bc3d2d3255e9c9f2f189a@cockroachlabs.com"},"message":"distsql: support lookup join on secondary index\n\njoinReader now supports lookup joins on secondary indexes. This was a\ntrivial change for queries where all the output columns are included in\nthe secondary index. I just modified the physical planner to specify the\nsecondary index in the JoinReaderSpec and removed checks which prevented\nsecondary indexes from being used.\n\nThe more complicated situation is when we want to do a lookup join\nagainst a non-covering index. In this case, the logical planner plans an\nindex join before the inner join, but we want to perform the lookup join\nfirst. We now handle this by only planning the lookup join during\nphysical planning, not the index join. During execution, the joinReader\ndetects that there are output columns not covered by the secondary\nindex, and it performs primary index lookups as necessary to retrieve\nthe additional columns.\n\nFixes #25431\n\nRelease note (sql change): The experimental lookup join feature now\nsupports secondary indexes.","distinct":true,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/36c1f98869d7f67a96166643ce1425104731e717"},{"sha":"c138ab71b396962dd207048d9e2dbefe4a9f7a50","author":{"name":"Pete Vilter","email":"bff6eb38fad1cf5d6b7237e52df7fff6aecbd405@cockroachlabs.com"},"message":"ui: add top-level LoginContainer: require login before rendering anything\n\nRelease note: None","distinct":true,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/c138ab71b396962dd207048d9e2dbefe4a9f7a50"},{"sha":"c840d73d7cf39dcb6d7906f3649cda9b61959b71","author":{"name":"Andrew Couch","email":"02e0a999c50b1f88df7a8f5a04e1b76b35ea6a88@cockroachlabs.com"},"message":"ui: refactor LoginState to manage enabled/disabled\n\nThis allows us to have one object representing both \"is login enabled?\"\nand \"does this user have access?\" state questions.\n\nRelease note: None","distinct":true,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/c840d73d7cf39dcb6d7906f3649cda9b61959b71"},{"sha":"29db67403dbea39c4229651cdffc4987c9ad3269","author":{"name":"Andrew Couch","email":"02e0a999c50b1f88df7a8f5a04e1b76b35ea6a88@cockroachlabs.com"},"message":"ui: redirect to login page when not authned\n\nPreviously, the login page was swapped in for the content of a page if\na user was not logged in.  This changes the behavior to instead redirect\nto a free standing login page.\n\nThe original URL accessed is stashed in the query parameter redirectTo,\nand after authentication the user is returned to that page.\n\nRelease note: None.","distinct":true,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/29db67403dbea39c4229651cdffc4987c9ad3269"},{"sha":"c0ee127fcafc5c233dde562f4ba8421387029012","author":{"name":"Andrew Couch","email":"02e0a999c50b1f88df7a8f5a04e1b76b35ea6a88@cockroachlabs.com"},"message":"ui: redact URLs encoded in query parameters\n\nPrevent URLs from slipping though the analytics redactions if the are\nencoded in a query parameter, as with the login redirect param.\n\nRelease note: None","distinct":true,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/c0ee127fcafc5c233dde562f4ba8421387029012"},{"sha":"81f3b0136fbd45449aa81af1cd26791d69922373","author":{"name":"craig[bot]","email":"3a2c29237f73c7cf88424b80e427b1884f346b35@cockroachlabs.com"},"message":"Merge #25005 #25628\n\n25005: ui: add top-level LoginContainer: require login before rendering anything r=couchand a=vilterp\n\nDepends on #25057 \r\nTouches #24939\r\n\r\n![](https://user-images.githubusercontent.com/7341/39150096-38b4cd28-470f-11e8-9d67-e1832d35a211.gif)\r\n\r\nShown above:\r\n1. go to admin UI; see login screen\r\n2. error message when you type in the wrong password\r\n3. you can't hit an authenticated endpoint because you don't have a valid session (this checking is turned on by #24944, only in secure mode)\r\n4. once you login with the right password, you can see the UI (the temporary \"connection lost\" banner shouldn't be there)\r\n5. now you (and the UI itself) can hit endpoints, because you have a valid session\r\n\r\nTodos:\r\n- [ ] redirect to login page instead of current wrapper component switching thing\r\n- [ ] logout\r\n    - [ ] logout button (make API call; redirect to login & blow away redux store)\r\n    - [ ] log out other tabs (if they get a 403, redirect to login & blow away redux store)\r\n- [ ] styling\r\n\r\nRelease note: None\n\n25628: distsql: support lookup join on secondary index r=solongordon a=solongordon\n\njoinReader now supports lookup joins on secondary indexes. This was a\r\ntrivial change for queries where all the output columns are included in\r\nthe secondary index. I just modified the physical planner to specify the\r\nsecondary index in the JoinReaderSpec and removed checks which prevented\r\nsecondary indexes from being used.\r\n\r\nThe more complicated situation is when we want to do a lookup join\r\nagainst a non-covering index. In this case, the logical planner plans an\r\nindex join before the inner join, but we want to perform the lookup join\r\nfirst. We now handle this by only planning the lookup join during\r\nphysical planning, not the index join. During execution, the joinReader\r\ndetects that there are output columns not covered by the secondary\r\nindex, and it performs primary index lookups as necessary to retrieve\r\nthe additional columns.\r\n\r\nFixes #25431\n\nCo-authored-by: Pete Vilter <vilterp@cockroachlabs.com>\nCo-authored-by: Andrew Couch <andrew@cockroachlabs.com>\nCo-authored-by: Solon Gordon <solon@cockroachlabs.com>","distinct":true,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/81f3b0136fbd45449aa81af1cd26791d69922373"}]}
{"actor":{"display_login":"craig"}}