{"action":"created","issue":{"url":"https://api.github.com/repos/angular/protractor/issues/4732","repository_url":"https://api.github.com/repos/angular/protractor","labels_url":"https://api.github.com/repos/angular/protractor/issues/4732/labels{/name}","comments_url":"https://api.github.com/repos/angular/protractor/issues/4732/comments","events_url":"https://api.github.com/repos/angular/protractor/issues/4732/events","html_url":"https://github.com/angular/protractor/pull/4732","id":304990195,"number":4732,"title":"docs(page_objects): Remove unnecessary \"return await\"","user":{"login":"jonhermansen","id":660911,"avatar_url":"https://avatars0.githubusercontent.com/u/660911?v=4","gravatar_id":"","url":"https://api.github.com/users/jonhermansen","html_url":"https://github.com/jonhermansen","followers_url":"https://api.github.com/users/jonhermansen/followers","following_url":"https://api.github.com/users/jonhermansen/following{/other_user}","gists_url":"https://api.github.com/users/jonhermansen/gists{/gist_id}","starred_url":"https://api.github.com/users/jonhermansen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonhermansen/subscriptions","organizations_url":"https://api.github.com/users/jonhermansen/orgs","repos_url":"https://api.github.com/users/jonhermansen/repos","events_url":"https://api.github.com/users/jonhermansen/events{/privacy}","received_events_url":"https://api.github.com/users/jonhermansen/received_events","type":"User","site_admin":false},"labels":[{"id":70978687,"url":"https://api.github.com/repos/angular/protractor/labels/cla:%20yes","name":"cla: yes","color":"c7def8","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-03-14T01:17:52Z","updated_at":"2018-03-20T05:15:53Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/angular/protractor/pulls/4732","html_url":"https://github.com/angular/protractor/pull/4732","diff_url":"https://github.com/angular/protractor/pull/4732.diff","patch_url":"https://github.com/angular/protractor/pull/4732.patch"},"body":"Fixes #4730 \r\n\r\nMore info here: https://eslint.org/docs/rules/no-return-await"},"comment":{"url":"https://api.github.com/repos/angular/protractor/issues/comments/374478897","html_url":"https://github.com/angular/protractor/pull/4732#issuecomment-374478897","issue_url":"https://api.github.com/repos/angular/protractor/issues/4732","id":374478897,"user":{"login":"jonhermansen","id":660911,"avatar_url":"https://avatars0.githubusercontent.com/u/660911?v=4","gravatar_id":"","url":"https://api.github.com/users/jonhermansen","html_url":"https://github.com/jonhermansen","followers_url":"https://api.github.com/users/jonhermansen/followers","following_url":"https://api.github.com/users/jonhermansen/following{/other_user}","gists_url":"https://api.github.com/users/jonhermansen/gists{/gist_id}","starred_url":"https://api.github.com/users/jonhermansen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonhermansen/subscriptions","organizations_url":"https://api.github.com/users/jonhermansen/orgs","repos_url":"https://api.github.com/users/jonhermansen/repos","events_url":"https://api.github.com/users/jonhermansen/events{/privacy}","received_events_url":"https://api.github.com/users/jonhermansen/received_events","type":"User","site_admin":false},"created_at":"2018-03-20T05:15:53Z","updated_at":"2018-03-20T05:15:53Z","author_association":"NONE","body":"@qiyigg I just pushed a commit to make getGreetingText synchronous as well. Makes sense to me. The async/await version of the code prefixes the function call with `await`, and Jasmine's expect() is able to resolve the promise anyway in the non async/await version. I agree that the function doesn't need to be async now +1"}}
{"actor":{"display_login":"jonhermansen"}}