{"action":"created","comment":{"url":"https://api.github.com/repos/line/armeria/pulls/comments/190209420","pull_request_review_id":122537912,"id":190209420,"diff_hunk":"@@ -552,6 +579,22 @@ static String toString(\n         buf.append(\", accessLogWriter: \");\n         buf.append(accessLogWriter);\n         buf.append(')');\n+        buf.append(\", channelOptions: {\");\n+        channelOptions.forEach((k, v) -> {\n+            buf.append(k);\n+            buf.append('=');\n+            buf.append(v);\n+            buf.append(\", \");\n+        });\n+        buf.append('}');\n+        buf.append(\", childChannelOptions: {\");\n+        childChannelOptions.forEach((k, v) -> {\n+            buf.append(k);\n+            buf.append('=');\n+            buf.append(v);\n+            buf.append(\", \");","path":"core/src/main/java/com/linecorp/armeria/server/ServerConfig.java","position":null,"original_position":111,"commit_id":"d82f452f0601e6d0a8449d8786138e93b1e3d749","original_commit_id":"f08b1db4ba8a8d8b91f183440b427f9135f04008","user":{"login":"huydx","id":535718,"avatar_url":"https://avatars0.githubusercontent.com/u/535718?v=4","gravatar_id":"","url":"https://api.github.com/users/huydx","html_url":"https://github.com/huydx","followers_url":"https://api.github.com/users/huydx/followers","following_url":"https://api.github.com/users/huydx/following{/other_user}","gists_url":"https://api.github.com/users/huydx/gists{/gist_id}","starred_url":"https://api.github.com/users/huydx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huydx/subscriptions","organizations_url":"https://api.github.com/users/huydx/orgs","repos_url":"https://api.github.com/users/huydx/repos","events_url":"https://api.github.com/users/huydx/events{/privacy}","received_events_url":"https://api.github.com/users/huydx/received_events","type":"User","site_admin":false},"body":">.< I was just stupid, fixed!","created_at":"2018-05-23T11:19:13Z","updated_at":"2018-05-23T11:19:14Z","html_url":"https://github.com/line/armeria/pull/1189#discussion_r190209420","pull_request_url":"https://api.github.com/repos/line/armeria/pulls/1189","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/line/armeria/pulls/comments/190209420"},"html":{"href":"https://github.com/line/armeria/pull/1189#discussion_r190209420"},"pull_request":{"href":"https://api.github.com/repos/line/armeria/pulls/1189"}},"in_reply_to_id":190204802},"pull_request":{"url":"https://api.github.com/repos/line/armeria/pulls/1189","id":186870004,"html_url":"https://github.com/line/armeria/pull/1189","diff_url":"https://github.com/line/armeria/pull/1189.diff","patch_url":"https://github.com/line/armeria/pull/1189.patch","issue_url":"https://api.github.com/repos/line/armeria/issues/1189","number":1189,"state":"open","locked":false,"title":"Provide a way to specify Netty ChannelOptions for Server","user":{"login":"huydx","id":535718,"avatar_url":"https://avatars0.githubusercontent.com/u/535718?v=4","gravatar_id":"","url":"https://api.github.com/users/huydx","html_url":"https://github.com/huydx","followers_url":"https://api.github.com/users/huydx/followers","following_url":"https://api.github.com/users/huydx/following{/other_user}","gists_url":"https://api.github.com/users/huydx/gists{/gist_id}","starred_url":"https://api.github.com/users/huydx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huydx/subscriptions","organizations_url":"https://api.github.com/users/huydx/orgs","repos_url":"https://api.github.com/users/huydx/repos","events_url":"https://api.github.com/users/huydx/events{/privacy}","received_events_url":"https://api.github.com/users/huydx/received_events","type":"User","site_admin":false},"body":"solve https://github.com/line/armeria/issues/1009","created_at":"2018-05-09T09:46:15Z","updated_at":"2018-05-23T11:19:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1968716eedfabe702d983b10c58d642fc1010516","assignee":null,"assignees":[],"requested_reviewers":[{"login":"hyangtack","id":8417787,"avatar_url":"https://avatars1.githubusercontent.com/u/8417787?v=4","gravatar_id":"","url":"https://api.github.com/users/hyangtack","html_url":"https://github.com/hyangtack","followers_url":"https://api.github.com/users/hyangtack/followers","following_url":"https://api.github.com/users/hyangtack/following{/other_user}","gists_url":"https://api.github.com/users/hyangtack/gists{/gist_id}","starred_url":"https://api.github.com/users/hyangtack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyangtack/subscriptions","organizations_url":"https://api.github.com/users/hyangtack/orgs","repos_url":"https://api.github.com/users/hyangtack/repos","events_url":"https://api.github.com/users/hyangtack/events{/privacy}","received_events_url":"https://api.github.com/users/hyangtack/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":287373881,"url":"https://api.github.com/repos/line/armeria/labels/new-feature","name":"new-feature","color":"009800","default":false}],"milestone":{"url":"https://api.github.com/repos/line/armeria/milestones/103","html_url":"https://github.com/line/armeria/milestone/103","labels_url":"https://api.github.com/repos/line/armeria/milestones/103/labels","id":3359895,"number":103,"title":"0.65.0","description":null,"creator":{"login":"trustin","id":173918,"avatar_url":"https://avatars0.githubusercontent.com/u/173918?v=4","gravatar_id":"","url":"https://api.github.com/users/trustin","html_url":"https://github.com/trustin","followers_url":"https://api.github.com/users/trustin/followers","following_url":"https://api.github.com/users/trustin/following{/other_user}","gists_url":"https://api.github.com/users/trustin/gists{/gist_id}","starred_url":"https://api.github.com/users/trustin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trustin/subscriptions","organizations_url":"https://api.github.com/users/trustin/orgs","repos_url":"https://api.github.com/users/trustin/repos","events_url":"https://api.github.com/users/trustin/events{/privacy}","received_events_url":"https://api.github.com/users/trustin/received_events","type":"User","site_admin":false},"open_issues":8,"closed_issues":5,"state":"open","created_at":"2018-05-21T01:00:38Z","updated_at":"2018-05-23T08:40:43Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/line/armeria/pulls/1189/commits","review_comments_url":"https://api.github.com/repos/line/armeria/pulls/1189/comments","review_comment_url":"https://api.github.com/repos/line/armeria/pulls/comments{/number}","comments_url":"https://api.github.com/repos/line/armeria/issues/1189/comments","statuses_url":"https://api.github.com/repos/line/armeria/statuses/d82f452f0601e6d0a8449d8786138e93b1e3d749","head":{"label":"huydx:huydx-netty-custom","ref":"huydx-netty-custom","sha":"d82f452f0601e6d0a8449d8786138e93b1e3d749","user":{"login":"huydx","id":535718,"avatar_url":"https://avatars0.githubusercontent.com/u/535718?v=4","gravatar_id":"","url":"https://api.github.com/users/huydx","html_url":"https://github.com/huydx","followers_url":"https://api.github.com/users/huydx/followers","following_url":"https://api.github.com/users/huydx/following{/other_user}","gists_url":"https://api.github.com/users/huydx/gists{/gist_id}","starred_url":"https://api.github.com/users/huydx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huydx/subscriptions","organizations_url":"https://api.github.com/users/huydx/orgs","repos_url":"https://api.github.com/users/huydx/repos","events_url":"https://api.github.com/users/huydx/events{/privacy}","received_events_url":"https://api.github.com/users/huydx/received_events","type":"User","site_admin":false},"repo":{"id":68875039,"name":"armeria","full_name":"huydx/armeria","owner":{"login":"huydx","id":535718,"avatar_url":"https://avatars0.githubusercontent.com/u/535718?v=4","gravatar_id":"","url":"https://api.github.com/users/huydx","html_url":"https://github.com/huydx","followers_url":"https://api.github.com/users/huydx/followers","following_url":"https://api.github.com/users/huydx/following{/other_user}","gists_url":"https://api.github.com/users/huydx/gists{/gist_id}","starred_url":"https://api.github.com/users/huydx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huydx/subscriptions","organizations_url":"https://api.github.com/users/huydx/orgs","repos_url":"https://api.github.com/users/huydx/repos","events_url":"https://api.github.com/users/huydx/events{/privacy}","received_events_url":"https://api.github.com/users/huydx/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/huydx/armeria","description":"Asynchronous RPC/API client/server library built on top of Java 8, Netty 4.1, HTTP/2, and Thrift","fork":true,"url":"https://api.github.com/repos/huydx/armeria","forks_url":"https://api.github.com/repos/huydx/armeria/forks","keys_url":"https://api.github.com/repos/huydx/armeria/keys{/key_id}","collaborators_url":"https://api.github.com/repos/huydx/armeria/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/huydx/armeria/teams","hooks_url":"https://api.github.com/repos/huydx/armeria/hooks","issue_events_url":"https://api.github.com/repos/huydx/armeria/issues/events{/number}","events_url":"https://api.github.com/repos/huydx/armeria/events","assignees_url":"https://api.github.com/repos/huydx/armeria/assignees{/user}","branches_url":"https://api.github.com/repos/huydx/armeria/branches{/branch}","tags_url":"https://api.github.com/repos/huydx/armeria/tags","blobs_url":"https://api.github.com/repos/huydx/armeria/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/huydx/armeria/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/huydx/armeria/git/refs{/sha}","trees_url":"https://api.github.com/repos/huydx/armeria/git/trees{/sha}","statuses_url":"https://api.github.com/repos/huydx/armeria/statuses/{sha}","languages_url":"https://api.github.com/repos/huydx/armeria/languages","stargazers_url":"https://api.github.com/repos/huydx/armeria/stargazers","contributors_url":"https://api.github.com/repos/huydx/armeria/contributors","subscribers_url":"https://api.github.com/repos/huydx/armeria/subscribers","subscription_url":"https://api.github.com/repos/huydx/armeria/subscription","commits_url":"https://api.github.com/repos/huydx/armeria/commits{/sha}","git_commits_url":"https://api.github.com/repos/huydx/armeria/git/commits{/sha}","comments_url":"https://api.github.com/repos/huydx/armeria/comments{/number}","issue_comment_url":"https://api.github.com/repos/huydx/armeria/issues/comments{/number}","contents_url":"https://api.github.com/repos/huydx/armeria/contents/{+path}","compare_url":"https://api.github.com/repos/huydx/armeria/compare/{base}...{head}","merges_url":"https://api.github.com/repos/huydx/armeria/merges","archive_url":"https://api.github.com/repos/huydx/armeria/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/huydx/armeria/downloads","issues_url":"https://api.github.com/repos/huydx/armeria/issues{/number}","pulls_url":"https://api.github.com/repos/huydx/armeria/pulls{/number}","milestones_url":"https://api.github.com/repos/huydx/armeria/milestones{/number}","notifications_url":"https://api.github.com/repos/huydx/armeria/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/huydx/armeria/labels{/name}","releases_url":"https://api.github.com/repos/huydx/armeria/releases{/id}","deployments_url":"https://api.github.com/repos/huydx/armeria/deployments","created_at":"2016-09-22T02:05:38Z","updated_at":"2018-05-01T10:05:27Z","pushed_at":"2018-05-23T11:19:06Z","git_url":"git://github.com/huydx/armeria.git","ssh_url":"git@github.com:huydx/armeria.git","clone_url":"https://github.com/huydx/armeria.git","svn_url":"https://github.com/huydx/armeria","homepage":"http://line.github.io/armeria/","size":52928,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"line:master","ref":"master","sha":"5e6a9ec12728e418341a37fc3d2a7469dd0340af","user":{"login":"line","id":13128444,"avatar_url":"https://avatars2.githubusercontent.com/u/13128444?v=4","gravatar_id":"","url":"https://api.github.com/users/line","html_url":"https://github.com/line","followers_url":"https://api.github.com/users/line/followers","following_url":"https://api.github.com/users/line/following{/other_user}","gists_url":"https://api.github.com/users/line/gists{/gist_id}","starred_url":"https://api.github.com/users/line/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/line/subscriptions","organizations_url":"https://api.github.com/users/line/orgs","repos_url":"https://api.github.com/users/line/repos","events_url":"https://api.github.com/users/line/events{/privacy}","received_events_url":"https://api.github.com/users/line/received_events","type":"Organization","site_admin":false},"repo":{"id":46251204,"name":"armeria","full_name":"line/armeria","owner":{"login":"line","id":13128444,"avatar_url":"https://avatars2.githubusercontent.com/u/13128444?v=4","gravatar_id":"","url":"https://api.github.com/users/line","html_url":"https://github.com/line","followers_url":"https://api.github.com/users/line/followers","following_url":"https://api.github.com/users/line/following{/other_user}","gists_url":"https://api.github.com/users/line/gists{/gist_id}","starred_url":"https://api.github.com/users/line/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/line/subscriptions","organizations_url":"https://api.github.com/users/line/orgs","repos_url":"https://api.github.com/users/line/repos","events_url":"https://api.github.com/users/line/events{/privacy}","received_events_url":"https://api.github.com/users/line/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/line/armeria","description":"Asynchronous RPC/REST library built on top of Java 8, Netty, HTTP/2, Thrift and gRPC","fork":false,"url":"https://api.github.com/repos/line/armeria","forks_url":"https://api.github.com/repos/line/armeria/forks","keys_url":"https://api.github.com/repos/line/armeria/keys{/key_id}","collaborators_url":"https://api.github.com/repos/line/armeria/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/line/armeria/teams","hooks_url":"https://api.github.com/repos/line/armeria/hooks","issue_events_url":"https://api.github.com/repos/line/armeria/issues/events{/number}","events_url":"https://api.github.com/repos/line/armeria/events","assignees_url":"https://api.github.com/repos/line/armeria/assignees{/user}","branches_url":"https://api.github.com/repos/line/armeria/branches{/branch}","tags_url":"https://api.github.com/repos/line/armeria/tags","blobs_url":"https://api.github.com/repos/line/armeria/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/line/armeria/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/line/armeria/git/refs{/sha}","trees_url":"https://api.github.com/repos/line/armeria/git/trees{/sha}","statuses_url":"https://api.github.com/repos/line/armeria/statuses/{sha}","languages_url":"https://api.github.com/repos/line/armeria/languages","stargazers_url":"https://api.github.com/repos/line/armeria/stargazers","contributors_url":"https://api.github.com/repos/line/armeria/contributors","subscribers_url":"https://api.github.com/repos/line/armeria/subscribers","subscription_url":"https://api.github.com/repos/line/armeria/subscription","commits_url":"https://api.github.com/repos/line/armeria/commits{/sha}","git_commits_url":"https://api.github.com/repos/line/armeria/git/commits{/sha}","comments_url":"https://api.github.com/repos/line/armeria/comments{/number}","issue_comment_url":"https://api.github.com/repos/line/armeria/issues/comments{/number}","contents_url":"https://api.github.com/repos/line/armeria/contents/{+path}","compare_url":"https://api.github.com/repos/line/armeria/compare/{base}...{head}","merges_url":"https://api.github.com/repos/line/armeria/merges","archive_url":"https://api.github.com/repos/line/armeria/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/line/armeria/downloads","issues_url":"https://api.github.com/repos/line/armeria/issues{/number}","pulls_url":"https://api.github.com/repos/line/armeria/pulls{/number}","milestones_url":"https://api.github.com/repos/line/armeria/milestones{/number}","notifications_url":"https://api.github.com/repos/line/armeria/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/line/armeria/labels{/name}","releases_url":"https://api.github.com/repos/line/armeria/releases{/id}","deployments_url":"https://api.github.com/repos/line/armeria/deployments","created_at":"2015-11-16T04:04:01Z","updated_at":"2018-05-23T11:15:09Z","pushed_at":"2018-05-23T11:19:07Z","git_url":"git://github.com/line/armeria.git","ssh_url":"git@github.com:line/armeria.git","clone_url":"https://github.com/line/armeria.git","svn_url":"https://github.com/line/armeria","homepage":"https://line.github.io/armeria/","size":56338,"stargazers_count":1245,"watchers_count":1245,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":284,"mirror_url":null,"archived":false,"open_issues_count":111,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":284,"open_issues":111,"watchers":1245,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/line/armeria/pulls/1189"},"html":{"href":"https://github.com/line/armeria/pull/1189"},"issue":{"href":"https://api.github.com/repos/line/armeria/issues/1189"},"comments":{"href":"https://api.github.com/repos/line/armeria/issues/1189/comments"},"review_comments":{"href":"https://api.github.com/repos/line/armeria/pulls/1189/comments"},"review_comment":{"href":"https://api.github.com/repos/line/armeria/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/line/armeria/pulls/1189/commits"},"statuses":{"href":"https://api.github.com/repos/line/armeria/statuses/d82f452f0601e6d0a8449d8786138e93b1e3d749"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"huydx"}}