{"action":"created","comment":{"url":"https://api.github.com/repos/ec-europa/europa-component-library/pulls/comments/193415385","pull_request_review_id":126381711,"id":193415385,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MzQxNTM4NQ==","diff_hunk":"@@ -41,23 +49,48 @@\n   }\n \n   .ecl-message__title {\n+    @supports (display: grid) {\n+      grid-column-start: 1;\n+    }\n+\n     font-weight: bold;\n     margin-bottom: map-get($ecl-spacing, 'xs');\n   }\n \n   .ecl-message__body {\n+    @supports (display: grid) {\n+      grid-column-start: 1;\n+    }\n+\n     margin: 0;\n     padding-left: map-get($ecl-spacing, 'xs');\n   }\n \n   .ecl-message__dismiss {\n-    background: transparent url($ecl-assets-path+'images/close.svg') no-repeat\n-      center center;\n+    @include ecl-focus-outline-border(\n+      $thicknes: 3px,\n+      $color: map-get($ecl-colors, 'yellow-100'),\n+      $offset: 3px\n+    );\n+\n+    @supports (display: grid) {\n+      align-self: self-start;\n+      grid-column-start: 2;\n+      grid-row-end: span 2;\n+      grid-row-start: 1;\n+      position: relative;\n+      right: auto;\n+      top: auto;\n+    }\n+\n+    align-items: center;\n+    background-color: transparent;\n     border-width: 0;\n-    color: transparent;\n-    display: block;\n-    font-size: map-get($ecl-font-size, 'xxl');\n-    line-height: map-get($ecl-font-size, 'l');\n+    color: #000;\n+    display: flex;\n+    font-size: map-get($ecl-font-size, 'xs');\n+    height: 1.5rem;\n+    line-height: 1.1;","path":"src/generic/generic-component-message/generic-component-message.scss","position":78,"original_position":78,"commit_id":"02b9f68266622c937acad10f683192e5d6450c7b","original_commit_id":"02b9f68266622c937acad10f683192e5d6450c7b","user":{"login":"yhuard","id":3524389,"node_id":"MDQ6VXNlcjM1MjQzODk=","avatar_url":"https://avatars3.githubusercontent.com/u/3524389?v=4","gravatar_id":"","url":"https://api.github.com/users/yhuard","html_url":"https://github.com/yhuard","followers_url":"https://api.github.com/users/yhuard/followers","following_url":"https://api.github.com/users/yhuard/following{/other_user}","gists_url":"https://api.github.com/users/yhuard/gists{/gist_id}","starred_url":"https://api.github.com/users/yhuard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yhuard/subscriptions","organizations_url":"https://api.github.com/users/yhuard/orgs","repos_url":"https://api.github.com/users/yhuard/repos","events_url":"https://api.github.com/users/yhuard/events{/privacy}","received_events_url":"https://api.github.com/users/yhuard/received_events","type":"User","site_admin":false},"body":"`1.15` would have been better","created_at":"2018-06-06T13:46:25Z","updated_at":"2018-06-06T13:53:01Z","html_url":"https://github.com/ec-europa/europa-component-library/pull/698#discussion_r193415385","pull_request_url":"https://api.github.com/repos/ec-europa/europa-component-library/pulls/698","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ec-europa/europa-component-library/pulls/comments/193415385"},"html":{"href":"https://github.com/ec-europa/europa-component-library/pull/698#discussion_r193415385"},"pull_request":{"href":"https://api.github.com/repos/ec-europa/europa-component-library/pulls/698"}}},"pull_request":{"url":"https://api.github.com/repos/ec-europa/europa-component-library/pulls/698","id":191739271,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxNzM5Mjcx","html_url":"https://github.com/ec-europa/europa-component-library/pull/698","diff_url":"https://github.com/ec-europa/europa-component-library/pull/698.diff","patch_url":"https://github.com/ec-europa/europa-component-library/pull/698.patch","issue_url":"https://api.github.com/repos/ec-europa/europa-component-library/issues/698","number":698,"state":"open","locked":false,"title":"refactor(messages): add text label next to close button - INNO-1047","user":{"login":"raduchiriac","id":1213284,"node_id":"MDQ6VXNlcjEyMTMyODQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1213284?v=4","gravatar_id":"","url":"https://api.github.com/users/raduchiriac","html_url":"https://github.com/raduchiriac","followers_url":"https://api.github.com/users/raduchiriac/followers","following_url":"https://api.github.com/users/raduchiriac/following{/other_user}","gists_url":"https://api.github.com/users/raduchiriac/gists{/gist_id}","starred_url":"https://api.github.com/users/raduchiriac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raduchiriac/subscriptions","organizations_url":"https://api.github.com/users/raduchiriac/orgs","repos_url":"https://api.github.com/users/raduchiriac/repos","events_url":"https://api.github.com/users/raduchiriac/events{/privacy}","received_events_url":"https://api.github.com/users/raduchiriac/received_events","type":"User","site_admin":false},"body":"# PR description\r\n\r\nPlease drop a few lines about the PR: what it does, how to test it, etc.\r\n\r\n## QA Checklist\r\n\r\nIn order to ensure a safe and quick review, please check that your PR follow those guidelines:\r\n\r\n* [x] `package.json` is up-to-date and `@ecl/[system]-base` is part of the dependencies\r\n* [x] I have checked the dependencies\r\n* [ ] I have given the fractal status “ready” to my component\r\n* [ ] I have declared `@define mycomponent` in the SCSS file\r\n* [ ] I have specified `margin: 0;` on the CSS component\r\n* [x] I have provided tests\r\n* [x] I follow the naming guidelines\r\n* [x] the component supports composition\r\n* [x] there are no hardcoded strings (all content come from the context)\r\n* [ ] I have filled the README.md file (at least a few lines)\r\n* [x] My component is listed in the root README\r\n* [x] My PR has the right label(s)\r\n","created_at":"2018-05-31T12:33:23Z","updated_at":"2018-06-06T13:53:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a8d091e603cf08a8991049df37e8b92afd506aa7","assignee":{"login":"yhuard","id":3524389,"node_id":"MDQ6VXNlcjM1MjQzODk=","avatar_url":"https://avatars3.githubusercontent.com/u/3524389?v=4","gravatar_id":"","url":"https://api.github.com/users/yhuard","html_url":"https://github.com/yhuard","followers_url":"https://api.github.com/users/yhuard/followers","following_url":"https://api.github.com/users/yhuard/following{/other_user}","gists_url":"https://api.github.com/users/yhuard/gists{/gist_id}","starred_url":"https://api.github.com/users/yhuard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yhuard/subscriptions","organizations_url":"https://api.github.com/users/yhuard/orgs","repos_url":"https://api.github.com/users/yhuard/repos","events_url":"https://api.github.com/users/yhuard/events{/privacy}","received_events_url":"https://api.github.com/users/yhuard/received_events","type":"User","site_admin":false},"assignees":[{"login":"yhuard","id":3524389,"node_id":"MDQ6VXNlcjM1MjQzODk=","avatar_url":"https://avatars3.githubusercontent.com/u/3524389?v=4","gravatar_id":"","url":"https://api.github.com/users/yhuard","html_url":"https://github.com/yhuard","followers_url":"https://api.github.com/users/yhuard/followers","following_url":"https://api.github.com/users/yhuard/following{/other_user}","gists_url":"https://api.github.com/users/yhuard/gists{/gist_id}","starred_url":"https://api.github.com/users/yhuard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yhuard/subscriptions","organizations_url":"https://api.github.com/users/yhuard/orgs","repos_url":"https://api.github.com/users/yhuard/repos","events_url":"https://api.github.com/users/yhuard/events{/privacy}","received_events_url":"https://api.github.com/users/yhuard/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":673988832,"node_id":"MDU6TGFiZWw2NzM5ODg4MzI=","url":"https://api.github.com/repos/ec-europa/europa-component-library/labels/process:%20review%20needed","name":"process: review needed","color":"1d76db","default":false},{"id":586380469,"node_id":"MDU6TGFiZWw1ODYzODA0Njk=","url":"https://api.github.com/repos/ec-europa/europa-component-library/labels/tag:%20enhancement","name":"tag: enhancement","color":"1d76db","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ec-europa/europa-component-library/pulls/698/commits","review_comments_url":"https://api.github.com/repos/ec-europa/europa-component-library/pulls/698/comments","review_comment_url":"https://api.github.com/repos/ec-europa/europa-component-library/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ec-europa/europa-component-library/issues/698/comments","statuses_url":"https://api.github.com/repos/ec-europa/europa-component-library/statuses/02b9f68266622c937acad10f683192e5d6450c7b","head":{"label":"ec-europa:feat/add-text-label-next-to-close-button-INNO-1047","ref":"feat/add-text-label-next-to-close-button-INNO-1047","sha":"02b9f68266622c937acad10f683192e5d6450c7b","user":{"login":"ec-europa","id":10885565,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwODg1NTY1","avatar_url":"https://avatars1.githubusercontent.com/u/10885565?v=4","gravatar_id":"","url":"https://api.github.com/users/ec-europa","html_url":"https://github.com/ec-europa","followers_url":"https://api.github.com/users/ec-europa/followers","following_url":"https://api.github.com/users/ec-europa/following{/other_user}","gists_url":"https://api.github.com/users/ec-europa/gists{/gist_id}","starred_url":"https://api.github.com/users/ec-europa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ec-europa/subscriptions","organizations_url":"https://api.github.com/users/ec-europa/orgs","repos_url":"https://api.github.com/users/ec-europa/repos","events_url":"https://api.github.com/users/ec-europa/events{/privacy}","received_events_url":"https://api.github.com/users/ec-europa/received_events","type":"Organization","site_admin":false},"repo":{"id":80430477,"node_id":"MDEwOlJlcG9zaXRvcnk4MDQzMDQ3Nw==","name":"europa-component-library","full_name":"ec-europa/europa-component-library","owner":{"login":"ec-europa","id":10885565,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwODg1NTY1","avatar_url":"https://avatars1.githubusercontent.com/u/10885565?v=4","gravatar_id":"","url":"https://api.github.com/users/ec-europa","html_url":"https://github.com/ec-europa","followers_url":"https://api.github.com/users/ec-europa/followers","following_url":"https://api.github.com/users/ec-europa/following{/other_user}","gists_url":"https://api.github.com/users/ec-europa/gists{/gist_id}","starred_url":"https://api.github.com/users/ec-europa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ec-europa/subscriptions","organizations_url":"https://api.github.com/users/ec-europa/orgs","repos_url":"https://api.github.com/users/ec-europa/repos","events_url":"https://api.github.com/users/ec-europa/events{/privacy}","received_events_url":"https://api.github.com/users/ec-europa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ec-europa/europa-component-library","description":"ECL - Europa Component Library","fork":false,"url":"https://api.github.com/repos/ec-europa/europa-component-library","forks_url":"https://api.github.com/repos/ec-europa/europa-component-library/forks","keys_url":"https://api.github.com/repos/ec-europa/europa-component-library/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ec-europa/europa-component-library/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ec-europa/europa-component-library/teams","hooks_url":"https://api.github.com/repos/ec-europa/europa-component-library/hooks","issue_events_url":"https://api.github.com/repos/ec-europa/europa-component-library/issues/events{/number}","events_url":"https://api.github.com/repos/ec-europa/europa-component-library/events","assignees_url":"https://api.github.com/repos/ec-europa/europa-component-library/assignees{/user}","branches_url":"https://api.github.com/repos/ec-europa/europa-component-library/branches{/branch}","tags_url":"https://api.github.com/repos/ec-europa/europa-component-library/tags","blobs_url":"https://api.github.com/repos/ec-europa/europa-component-library/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ec-europa/europa-component-library/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ec-europa/europa-component-library/git/refs{/sha}","trees_url":"https://api.github.com/repos/ec-europa/europa-component-library/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ec-europa/europa-component-library/statuses/{sha}","languages_url":"https://api.github.com/repos/ec-europa/europa-component-library/languages","stargazers_url":"https://api.github.com/repos/ec-europa/europa-component-library/stargazers","contributors_url":"https://api.github.com/repos/ec-europa/europa-component-library/contributors","subscribers_url":"https://api.github.com/repos/ec-europa/europa-component-library/subscribers","subscription_url":"https://api.github.com/repos/ec-europa/europa-component-library/subscription","commits_url":"https://api.github.com/repos/ec-europa/europa-component-library/commits{/sha}","git_commits_url":"https://api.github.com/repos/ec-europa/europa-component-library/git/commits{/sha}","comments_url":"https://api.github.com/repos/ec-europa/europa-component-library/comments{/number}","issue_comment_url":"https://api.github.com/repos/ec-europa/europa-component-library/issues/comments{/number}","contents_url":"https://api.github.com/repos/ec-europa/europa-component-library/contents/{+path}","compare_url":"https://api.github.com/repos/ec-europa/europa-component-library/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ec-europa/europa-component-library/merges","archive_url":"https://api.github.com/repos/ec-europa/europa-component-library/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ec-europa/europa-component-library/downloads","issues_url":"https://api.github.com/repos/ec-europa/europa-component-library/issues{/number}","pulls_url":"https://api.github.com/repos/ec-europa/europa-component-library/pulls{/number}","milestones_url":"https://api.github.com/repos/ec-europa/europa-component-library/milestones{/number}","notifications_url":"https://api.github.com/repos/ec-europa/europa-component-library/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ec-europa/europa-component-library/labels{/name}","releases_url":"https://api.github.com/repos/ec-europa/europa-component-library/releases{/id}","deployments_url":"https://api.github.com/repos/ec-europa/europa-component-library/deployments","created_at":"2017-01-30T14:52:06Z","updated_at":"2018-06-04T12:43:33Z","pushed_at":"2018-06-06T11:54:33Z","git_url":"git://github.com/ec-europa/europa-component-library.git","ssh_url":"git@github.com:ec-europa/europa-component-library.git","clone_url":"https://github.com/ec-europa/europa-component-library.git","svn_url":"https://github.com/ec-europa/europa-component-library","homepage":"https://ec-europa.github.io/europa-component-library/ec/","size":389585,"stargazers_count":15,"watchers_count":15,"language":"HTML","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"eupl-1.1","name":"European Union Public License 1.1","spdx_id":"EUPL-1.1","url":"https://api.github.com/licenses/eupl-1.1","node_id":"MDc6TGljZW5zZTI0"},"forks":9,"open_issues":7,"watchers":15,"default_branch":"master"}},"base":{"label":"ec-europa:master","ref":"master","sha":"3c204494b57e9d3d574849ea202801614224c133","user":{"login":"ec-europa","id":10885565,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwODg1NTY1","avatar_url":"https://avatars1.githubusercontent.com/u/10885565?v=4","gravatar_id":"","url":"https://api.github.com/users/ec-europa","html_url":"https://github.com/ec-europa","followers_url":"https://api.github.com/users/ec-europa/followers","following_url":"https://api.github.com/users/ec-europa/following{/other_user}","gists_url":"https://api.github.com/users/ec-europa/gists{/gist_id}","starred_url":"https://api.github.com/users/ec-europa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ec-europa/subscriptions","organizations_url":"https://api.github.com/users/ec-europa/orgs","repos_url":"https://api.github.com/users/ec-europa/repos","events_url":"https://api.github.com/users/ec-europa/events{/privacy}","received_events_url":"https://api.github.com/users/ec-europa/received_events","type":"Organization","site_admin":false},"repo":{"id":80430477,"node_id":"MDEwOlJlcG9zaXRvcnk4MDQzMDQ3Nw==","name":"europa-component-library","full_name":"ec-europa/europa-component-library","owner":{"login":"ec-europa","id":10885565,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwODg1NTY1","avatar_url":"https://avatars1.githubusercontent.com/u/10885565?v=4","gravatar_id":"","url":"https://api.github.com/users/ec-europa","html_url":"https://github.com/ec-europa","followers_url":"https://api.github.com/users/ec-europa/followers","following_url":"https://api.github.com/users/ec-europa/following{/other_user}","gists_url":"https://api.github.com/users/ec-europa/gists{/gist_id}","starred_url":"https://api.github.com/users/ec-europa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ec-europa/subscriptions","organizations_url":"https://api.github.com/users/ec-europa/orgs","repos_url":"https://api.github.com/users/ec-europa/repos","events_url":"https://api.github.com/users/ec-europa/events{/privacy}","received_events_url":"https://api.github.com/users/ec-europa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ec-europa/europa-component-library","description":"ECL - Europa Component Library","fork":false,"url":"https://api.github.com/repos/ec-europa/europa-component-library","forks_url":"https://api.github.com/repos/ec-europa/europa-component-library/forks","keys_url":"https://api.github.com/repos/ec-europa/europa-component-library/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ec-europa/europa-component-library/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ec-europa/europa-component-library/teams","hooks_url":"https://api.github.com/repos/ec-europa/europa-component-library/hooks","issue_events_url":"https://api.github.com/repos/ec-europa/europa-component-library/issues/events{/number}","events_url":"https://api.github.com/repos/ec-europa/europa-component-library/events","assignees_url":"https://api.github.com/repos/ec-europa/europa-component-library/assignees{/user}","branches_url":"https://api.github.com/repos/ec-europa/europa-component-library/branches{/branch}","tags_url":"https://api.github.com/repos/ec-europa/europa-component-library/tags","blobs_url":"https://api.github.com/repos/ec-europa/europa-component-library/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ec-europa/europa-component-library/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ec-europa/europa-component-library/git/refs{/sha}","trees_url":"https://api.github.com/repos/ec-europa/europa-component-library/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ec-europa/europa-component-library/statuses/{sha}","languages_url":"https://api.github.com/repos/ec-europa/europa-component-library/languages","stargazers_url":"https://api.github.com/repos/ec-europa/europa-component-library/stargazers","contributors_url":"https://api.github.com/repos/ec-europa/europa-component-library/contributors","subscribers_url":"https://api.github.com/repos/ec-europa/europa-component-library/subscribers","subscription_url":"https://api.github.com/repos/ec-europa/europa-component-library/subscription","commits_url":"https://api.github.com/repos/ec-europa/europa-component-library/commits{/sha}","git_commits_url":"https://api.github.com/repos/ec-europa/europa-component-library/git/commits{/sha}","comments_url":"https://api.github.com/repos/ec-europa/europa-component-library/comments{/number}","issue_comment_url":"https://api.github.com/repos/ec-europa/europa-component-library/issues/comments{/number}","contents_url":"https://api.github.com/repos/ec-europa/europa-component-library/contents/{+path}","compare_url":"https://api.github.com/repos/ec-europa/europa-component-library/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ec-europa/europa-component-library/merges","archive_url":"https://api.github.com/repos/ec-europa/europa-component-library/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ec-europa/europa-component-library/downloads","issues_url":"https://api.github.com/repos/ec-europa/europa-component-library/issues{/number}","pulls_url":"https://api.github.com/repos/ec-europa/europa-component-library/pulls{/number}","milestones_url":"https://api.github.com/repos/ec-europa/europa-component-library/milestones{/number}","notifications_url":"https://api.github.com/repos/ec-europa/europa-component-library/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ec-europa/europa-component-library/labels{/name}","releases_url":"https://api.github.com/repos/ec-europa/europa-component-library/releases{/id}","deployments_url":"https://api.github.com/repos/ec-europa/europa-component-library/deployments","created_at":"2017-01-30T14:52:06Z","updated_at":"2018-06-04T12:43:33Z","pushed_at":"2018-06-06T11:54:33Z","git_url":"git://github.com/ec-europa/europa-component-library.git","ssh_url":"git@github.com:ec-europa/europa-component-library.git","clone_url":"https://github.com/ec-europa/europa-component-library.git","svn_url":"https://github.com/ec-europa/europa-component-library","homepage":"https://ec-europa.github.io/europa-component-library/ec/","size":389585,"stargazers_count":15,"watchers_count":15,"language":"HTML","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"eupl-1.1","name":"European Union Public License 1.1","spdx_id":"EUPL-1.1","url":"https://api.github.com/licenses/eupl-1.1","node_id":"MDc6TGljZW5zZTI0"},"forks":9,"open_issues":7,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ec-europa/europa-component-library/pulls/698"},"html":{"href":"https://github.com/ec-europa/europa-component-library/pull/698"},"issue":{"href":"https://api.github.com/repos/ec-europa/europa-component-library/issues/698"},"comments":{"href":"https://api.github.com/repos/ec-europa/europa-component-library/issues/698/comments"},"review_comments":{"href":"https://api.github.com/repos/ec-europa/europa-component-library/pulls/698/comments"},"review_comment":{"href":"https://api.github.com/repos/ec-europa/europa-component-library/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ec-europa/europa-component-library/pulls/698/commits"},"statuses":{"href":"https://api.github.com/repos/ec-europa/europa-component-library/statuses/02b9f68266622c937acad10f683192e5d6450c7b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"yhuard"}}