{"action":"created","comment":{"url":"https://api.github.com/repos/rafaprax/liferay-portal/pulls/comments/184155859","pull_request_review_id":115292943,"id":184155859,"diff_hunk":"@@ -345,32 +471,30 @@ protected DDMFormRenderingContext createDDMFormRenderingContext() {\n \t\treturn ddmFormRenderingContext;\n \t}\n \n-\tprotected OrderByComparator<DDMDataProviderInstance>\n-\t\tgetDDMDataProviderInstanceOrderByComparator(\n-\t\t\tString orderByCol, String orderByType) {\n+\tprotected Consumer<DropdownItem> getCreationMenuDropdownItem(\n+\t\tString ddmDataProviderType) {\n \n-\t\tboolean orderByAsc = false;\n+\t\tHttpServletRequest request = PortalUtil.getHttpServletRequest(\n+\t\t\t_renderRequest);\n \n-\t\tif (orderByType.equals(\"asc\")) {\n-\t\t\torderByAsc = true;\n-\t\t}\n+\t\tThemeDisplay themeDisplay = (ThemeDisplay)request.getAttribute(\n+\t\t\tWebKeys.THEME_DISPLAY);\n \n-\t\tOrderByComparator<DDMDataProviderInstance> orderByComparator = null;\n+\t\treturn dropdownItem -> {\n+\t\t\tdropdownItem.setHref(\n+\t\t\t\t_renderResponse.createRenderURL(), \"mvcPath\",\n+\t\t\t\t\"/edit_data_provider.jsp\", \"redirect\",\n+\t\t\t\tPortalUtil.getCurrentURL(request), \"groupId\",","path":"modules/apps/forms-and-workflow/dynamic-data-mapping/dynamic-data-mapping-data-provider-web/src/main/java/com/liferay/dynamic/data/mapping/data/provider/web/internal/display/context/DDMDataProviderDisplayContext.java","position":317,"original_position":317,"commit_id":"407269072b971a781256d62349d26b0f95bcb7cd","original_commit_id":"407269072b971a781256d62349d26b0f95bcb7cd","user":{"login":"pedroqueiroz","id":14281960,"avatar_url":"https://avatars0.githubusercontent.com/u/14281960?v=4","gravatar_id":"","url":"https://api.github.com/users/pedroqueiroz","html_url":"https://github.com/pedroqueiroz","followers_url":"https://api.github.com/users/pedroqueiroz/followers","following_url":"https://api.github.com/users/pedroqueiroz/following{/other_user}","gists_url":"https://api.github.com/users/pedroqueiroz/gists{/gist_id}","starred_url":"https://api.github.com/users/pedroqueiroz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pedroqueiroz/subscriptions","organizations_url":"https://api.github.com/users/pedroqueiroz/orgs","repos_url":"https://api.github.com/users/pedroqueiroz/repos","events_url":"https://api.github.com/users/pedroqueiroz/events{/privacy}","received_events_url":"https://api.github.com/users/pedroqueiroz/received_events","type":"User","site_admin":false},"body":"use _formAdminRequestHelper.getRequest() instead","created_at":"2018-04-25T18:05:37Z","updated_at":"2018-04-25T18:05:37Z","html_url":"https://github.com/rafaprax/liferay-portal/pull/528#discussion_r184155859","pull_request_url":"https://api.github.com/repos/rafaprax/liferay-portal/pulls/528","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/rafaprax/liferay-portal/pulls/comments/184155859"},"html":{"href":"https://github.com/rafaprax/liferay-portal/pull/528#discussion_r184155859"},"pull_request":{"href":"https://api.github.com/repos/rafaprax/liferay-portal/pulls/528"}}},"pull_request":{"url":"https://api.github.com/repos/rafaprax/liferay-portal/pulls/528","id":183879534,"html_url":"https://github.com/rafaprax/liferay-portal/pull/528","diff_url":"https://github.com/rafaprax/liferay-portal/pull/528.diff","patch_url":"https://github.com/rafaprax/liferay-portal/pull/528.patch","issue_url":"https://api.github.com/repos/rafaprax/liferay-portal/issues/528","number":528,"state":"open","locked":false,"title":"LPS-78361 Apply new Management Bar","user":{"login":"pedroqueiroz","id":14281960,"avatar_url":"https://avatars0.githubusercontent.com/u/14281960?v=4","gravatar_id":"","url":"https://api.github.com/users/pedroqueiroz","html_url":"https://github.com/pedroqueiroz","followers_url":"https://api.github.com/users/pedroqueiroz/followers","following_url":"https://api.github.com/users/pedroqueiroz/following{/other_user}","gists_url":"https://api.github.com/users/pedroqueiroz/gists{/gist_id}","starred_url":"https://api.github.com/users/pedroqueiroz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pedroqueiroz/subscriptions","organizations_url":"https://api.github.com/users/pedroqueiroz/orgs","repos_url":"https://api.github.com/users/pedroqueiroz/repos","events_url":"https://api.github.com/users/pedroqueiroz/events{/privacy}","received_events_url":"https://api.github.com/users/pedroqueiroz/received_events","type":"User","site_admin":false},"body":null,"created_at":"2018-04-24T22:16:34Z","updated_at":"2018-04-25T18:05:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"df333dd2d589b9eddf48be8d0099163637fcdd0b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":868717042,"url":"https://api.github.com/repos/rafaprax/liferay-portal/labels/ci:test%20-%20failure","name":"ci:test - failure","color":"fccdcc","default":false},{"id":908973299,"url":"https://api.github.com/repos/rafaprax/liferay-portal/labels/ci:test:relevant%20-%20failure","name":"ci:test:relevant - failure","color":"fccdcc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/rafaprax/liferay-portal/pulls/528/commits","review_comments_url":"https://api.github.com/repos/rafaprax/liferay-portal/pulls/528/comments","review_comment_url":"https://api.github.com/repos/rafaprax/liferay-portal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rafaprax/liferay-portal/issues/528/comments","statuses_url":"https://api.github.com/repos/rafaprax/liferay-portal/statuses/407269072b971a781256d62349d26b0f95bcb7cd","head":{"label":"pedroqueiroz:LPS-78361","ref":"LPS-78361","sha":"407269072b971a781256d62349d26b0f95bcb7cd","user":{"login":"pedroqueiroz","id":14281960,"avatar_url":"https://avatars0.githubusercontent.com/u/14281960?v=4","gravatar_id":"","url":"https://api.github.com/users/pedroqueiroz","html_url":"https://github.com/pedroqueiroz","followers_url":"https://api.github.com/users/pedroqueiroz/followers","following_url":"https://api.github.com/users/pedroqueiroz/following{/other_user}","gists_url":"https://api.github.com/users/pedroqueiroz/gists{/gist_id}","starred_url":"https://api.github.com/users/pedroqueiroz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pedroqueiroz/subscriptions","organizations_url":"https://api.github.com/users/pedroqueiroz/orgs","repos_url":"https://api.github.com/users/pedroqueiroz/repos","events_url":"https://api.github.com/users/pedroqueiroz/events{/privacy}","received_events_url":"https://api.github.com/users/pedroqueiroz/received_events","type":"User","site_admin":false},"repo":{"id":42536438,"name":"liferay-portal","full_name":"pedroqueiroz/liferay-portal","owner":{"login":"pedroqueiroz","id":14281960,"avatar_url":"https://avatars0.githubusercontent.com/u/14281960?v=4","gravatar_id":"","url":"https://api.github.com/users/pedroqueiroz","html_url":"https://github.com/pedroqueiroz","followers_url":"https://api.github.com/users/pedroqueiroz/followers","following_url":"https://api.github.com/users/pedroqueiroz/following{/other_user}","gists_url":"https://api.github.com/users/pedroqueiroz/gists{/gist_id}","starred_url":"https://api.github.com/users/pedroqueiroz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pedroqueiroz/subscriptions","organizations_url":"https://api.github.com/users/pedroqueiroz/orgs","repos_url":"https://api.github.com/users/pedroqueiroz/repos","events_url":"https://api.github.com/users/pedroqueiroz/events{/privacy}","received_events_url":"https://api.github.com/users/pedroqueiroz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pedroqueiroz/liferay-portal","description":null,"fork":true,"url":"https://api.github.com/repos/pedroqueiroz/liferay-portal","forks_url":"https://api.github.com/repos/pedroqueiroz/liferay-portal/forks","keys_url":"https://api.github.com/repos/pedroqueiroz/liferay-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pedroqueiroz/liferay-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pedroqueiroz/liferay-portal/teams","hooks_url":"https://api.github.com/repos/pedroqueiroz/liferay-portal/hooks","issue_events_url":"https://api.github.com/repos/pedroqueiroz/liferay-portal/issues/events{/number}","events_url":"https://api.github.com/repos/pedroqueiroz/liferay-portal/events","assignees_url":"https://api.github.com/repos/pedroqueiroz/liferay-portal/assignees{/user}","branches_url":"https://api.github.com/repos/pedroqueiroz/liferay-portal/branches{/branch}","tags_url":"https://api.github.com/repos/pedroqueiroz/liferay-portal/tags","blobs_url":"https://api.github.com/repos/pedroqueiroz/liferay-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pedroqueiroz/liferay-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pedroqueiroz/liferay-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/pedroqueiroz/liferay-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pedroqueiroz/liferay-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/pedroqueiroz/liferay-portal/languages","stargazers_url":"https://api.github.com/repos/pedroqueiroz/liferay-portal/stargazers","contributors_url":"https://api.github.com/repos/pedroqueiroz/liferay-portal/contributors","subscribers_url":"https://api.github.com/repos/pedroqueiroz/liferay-portal/subscribers","subscription_url":"https://api.github.com/repos/pedroqueiroz/liferay-portal/subscription","commits_url":"https://api.github.com/repos/pedroqueiroz/liferay-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/pedroqueiroz/liferay-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/pedroqueiroz/liferay-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/pedroqueiroz/liferay-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/pedroqueiroz/liferay-portal/contents/{+path}","compare_url":"https://api.github.com/repos/pedroqueiroz/liferay-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pedroqueiroz/liferay-portal/merges","archive_url":"https://api.github.com/repos/pedroqueiroz/liferay-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pedroqueiroz/liferay-portal/downloads","issues_url":"https://api.github.com/repos/pedroqueiroz/liferay-portal/issues{/number}","pulls_url":"https://api.github.com/repos/pedroqueiroz/liferay-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/pedroqueiroz/liferay-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/pedroqueiroz/liferay-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pedroqueiroz/liferay-portal/labels{/name}","releases_url":"https://api.github.com/repos/pedroqueiroz/liferay-portal/releases{/id}","deployments_url":"https://api.github.com/repos/pedroqueiroz/liferay-portal/deployments","created_at":"2015-09-15T17:51:34Z","updated_at":"2018-04-25T17:24:24Z","pushed_at":"2018-04-25T17:24:27Z","git_url":"git://github.com/pedroqueiroz/liferay-portal.git","ssh_url":"git@github.com:pedroqueiroz/liferay-portal.git","clone_url":"https://github.com/pedroqueiroz/liferay-portal.git","svn_url":"https://github.com/pedroqueiroz/liferay-portal","homepage":"http://liferay.com","size":12556080,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"base":{"label":"rafaprax:master","ref":"master","sha":"edea8e98e4935617081eca50b6200ac26f89bd79","user":{"login":"rafaprax","id":9324099,"avatar_url":"https://avatars0.githubusercontent.com/u/9324099?v=4","gravatar_id":"","url":"https://api.github.com/users/rafaprax","html_url":"https://github.com/rafaprax","followers_url":"https://api.github.com/users/rafaprax/followers","following_url":"https://api.github.com/users/rafaprax/following{/other_user}","gists_url":"https://api.github.com/users/rafaprax/gists{/gist_id}","starred_url":"https://api.github.com/users/rafaprax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafaprax/subscriptions","organizations_url":"https://api.github.com/users/rafaprax/orgs","repos_url":"https://api.github.com/users/rafaprax/repos","events_url":"https://api.github.com/users/rafaprax/events{/privacy}","received_events_url":"https://api.github.com/users/rafaprax/received_events","type":"User","site_admin":false},"repo":{"id":36665866,"name":"liferay-portal","full_name":"rafaprax/liferay-portal","owner":{"login":"rafaprax","id":9324099,"avatar_url":"https://avatars0.githubusercontent.com/u/9324099?v=4","gravatar_id":"","url":"https://api.github.com/users/rafaprax","html_url":"https://github.com/rafaprax","followers_url":"https://api.github.com/users/rafaprax/followers","following_url":"https://api.github.com/users/rafaprax/following{/other_user}","gists_url":"https://api.github.com/users/rafaprax/gists{/gist_id}","starred_url":"https://api.github.com/users/rafaprax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafaprax/subscriptions","organizations_url":"https://api.github.com/users/rafaprax/orgs","repos_url":"https://api.github.com/users/rafaprax/repos","events_url":"https://api.github.com/users/rafaprax/events{/privacy}","received_events_url":"https://api.github.com/users/rafaprax/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rafaprax/liferay-portal","description":null,"fork":true,"url":"https://api.github.com/repos/rafaprax/liferay-portal","forks_url":"https://api.github.com/repos/rafaprax/liferay-portal/forks","keys_url":"https://api.github.com/repos/rafaprax/liferay-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rafaprax/liferay-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rafaprax/liferay-portal/teams","hooks_url":"https://api.github.com/repos/rafaprax/liferay-portal/hooks","issue_events_url":"https://api.github.com/repos/rafaprax/liferay-portal/issues/events{/number}","events_url":"https://api.github.com/repos/rafaprax/liferay-portal/events","assignees_url":"https://api.github.com/repos/rafaprax/liferay-portal/assignees{/user}","branches_url":"https://api.github.com/repos/rafaprax/liferay-portal/branches{/branch}","tags_url":"https://api.github.com/repos/rafaprax/liferay-portal/tags","blobs_url":"https://api.github.com/repos/rafaprax/liferay-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rafaprax/liferay-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rafaprax/liferay-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/rafaprax/liferay-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rafaprax/liferay-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/rafaprax/liferay-portal/languages","stargazers_url":"https://api.github.com/repos/rafaprax/liferay-portal/stargazers","contributors_url":"https://api.github.com/repos/rafaprax/liferay-portal/contributors","subscribers_url":"https://api.github.com/repos/rafaprax/liferay-portal/subscribers","subscription_url":"https://api.github.com/repos/rafaprax/liferay-portal/subscription","commits_url":"https://api.github.com/repos/rafaprax/liferay-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/rafaprax/liferay-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/rafaprax/liferay-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/rafaprax/liferay-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/rafaprax/liferay-portal/contents/{+path}","compare_url":"https://api.github.com/repos/rafaprax/liferay-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rafaprax/liferay-portal/merges","archive_url":"https://api.github.com/repos/rafaprax/liferay-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rafaprax/liferay-portal/downloads","issues_url":"https://api.github.com/repos/rafaprax/liferay-portal/issues{/number}","pulls_url":"https://api.github.com/repos/rafaprax/liferay-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/rafaprax/liferay-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/rafaprax/liferay-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rafaprax/liferay-portal/labels{/name}","releases_url":"https://api.github.com/repos/rafaprax/liferay-portal/releases{/id}","deployments_url":"https://api.github.com/repos/rafaprax/liferay-portal/deployments","created_at":"2015-06-01T14:25:20Z","updated_at":"2018-04-25T17:24:47Z","pushed_at":"2018-04-25T17:56:24Z","git_url":"git://github.com/rafaprax/liferay-portal.git","ssh_url":"git@github.com:rafaprax/liferay-portal.git","clone_url":"https://github.com/rafaprax/liferay-portal.git","svn_url":"https://github.com/rafaprax/liferay-portal","homepage":"http://liferay.com","size":12567199,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1,"open_issues":7,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rafaprax/liferay-portal/pulls/528"},"html":{"href":"https://github.com/rafaprax/liferay-portal/pull/528"},"issue":{"href":"https://api.github.com/repos/rafaprax/liferay-portal/issues/528"},"comments":{"href":"https://api.github.com/repos/rafaprax/liferay-portal/issues/528/comments"},"review_comments":{"href":"https://api.github.com/repos/rafaprax/liferay-portal/pulls/528/comments"},"review_comment":{"href":"https://api.github.com/repos/rafaprax/liferay-portal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rafaprax/liferay-portal/pulls/528/commits"},"statuses":{"href":"https://api.github.com/repos/rafaprax/liferay-portal/statuses/407269072b971a781256d62349d26b0f95bcb7cd"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"pedroqueiroz"}}