{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/pulls/comments/180599322","pull_request_review_id":111048283,"id":180599322,"diff_hunk":"@@ -107,6 +107,30 @@ The `send` method sends a cloud-to-device message to the service, intended for d\n \n **SRS_NODE_IOTHUB_CLIENT_16_030: [** The `send` method shall not throw if the `done` callback is falsy. **]**\n \n+sendToModule(deviceId: string, moduleId: string, inputName: string, message: Message | Message.BufferConvertible, done?: Callback<results.MessageEnqueued>): void;\n+The `sendToModule` method sends a message to the service, intended for delivery to the given input on the given module on the given device\n+\n+**SRS_NODE_IOTHUB_CLIENT_18_007: [** The `sendToModule` method shall throw `ReferenceError` if the deviceId, moduleId, inputName, or message arguments are falsy. **]**\n+\n+**SRS_NODE_IOTHUB_CLIENT_18_008: [** The `sendToModule` method shall convert the message object to type azure-iot-common.Message if necessary. **]**","path":"service/devdoc/iothub_client_requirements.md","position":9,"original_position":9,"commit_id":"7a959f61e3f729782a8f3c37ecdf7103eb069be6","original_commit_id":"7a959f61e3f729782a8f3c37ecdf7103eb069be6","user":{"login":"pierreca","id":4979572,"avatar_url":"https://avatars2.githubusercontent.com/u/4979572?v=4","gravatar_id":"","url":"https://api.github.com/users/pierreca","html_url":"https://github.com/pierreca","followers_url":"https://api.github.com/users/pierreca/followers","following_url":"https://api.github.com/users/pierreca/following{/other_user}","gists_url":"https://api.github.com/users/pierreca/gists{/gist_id}","starred_url":"https://api.github.com/users/pierreca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pierreca/subscriptions","organizations_url":"https://api.github.com/users/pierreca/orgs","repos_url":"https://api.github.com/users/pierreca/repos","events_url":"https://api.github.com/users/pierreca/events{/privacy}","received_events_url":"https://api.github.com/users/pierreca/received_events","type":"User","site_admin":false},"body":">The `sendToModule` method shall convert the message object to type azure-iot-common.Message if necessary.  [](start = 37, length = 106)\r\n\r\nisn't that the responsibility of the transport?","created_at":"2018-04-10T23:44:18Z","updated_at":"2018-04-10T23:44:18Z","html_url":"https://github.com/Azure/azure-iot-sdk-node/pull/271#discussion_r180599322","pull_request_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/pulls/271","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-iot-sdk-node/pulls/comments/180599322"},"html":{"href":"https://github.com/Azure/azure-iot-sdk-node/pull/271#discussion_r180599322"},"pull_request":{"href":"https://api.github.com/repos/Azure/azure-iot-sdk-node/pulls/271"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/pulls/271","id":180695668,"html_url":"https://github.com/Azure/azure-iot-sdk-node/pull/271","diff_url":"https://github.com/Azure/azure-iot-sdk-node/pull/271.diff","patch_url":"https://github.com/Azure/azure-iot-sdk-node/pull/271.patch","issue_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/issues/271","number":271,"state":"open","locked":false,"title":"Modules over AMQP","user":{"login":"BertKleewein","id":8028738,"avatar_url":"https://avatars0.githubusercontent.com/u/8028738?v=4","gravatar_id":"","url":"https://api.github.com/users/BertKleewein","html_url":"https://github.com/BertKleewein","followers_url":"https://api.github.com/users/BertKleewein/followers","following_url":"https://api.github.com/users/BertKleewein/following{/other_user}","gists_url":"https://api.github.com/users/BertKleewein/gists{/gist_id}","starred_url":"https://api.github.com/users/BertKleewein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BertKleewein/subscriptions","organizations_url":"https://api.github.com/users/BertKleewein/orgs","repos_url":"https://api.github.com/users/BertKleewein/repos","events_url":"https://api.github.com/users/BertKleewein/events{/privacy}","received_events_url":"https://api.github.com/users/BertKleewein/received_events","type":"User","site_admin":false},"body":"AMQP protocol support for modules.","created_at":"2018-04-10T18:53:05Z","updated_at":"2018-04-10T23:44:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b11a6d215be345c55597340d35055f8d8464d9fa","assignee":null,"assignees":[],"requested_reviewers":[{"login":"anthonyvercolano","id":9854568,"avatar_url":"https://avatars0.githubusercontent.com/u/9854568?v=4","gravatar_id":"","url":"https://api.github.com/users/anthonyvercolano","html_url":"https://github.com/anthonyvercolano","followers_url":"https://api.github.com/users/anthonyvercolano/followers","following_url":"https://api.github.com/users/anthonyvercolano/following{/other_user}","gists_url":"https://api.github.com/users/anthonyvercolano/gists{/gist_id}","starred_url":"https://api.github.com/users/anthonyvercolano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthonyvercolano/subscriptions","organizations_url":"https://api.github.com/users/anthonyvercolano/orgs","repos_url":"https://api.github.com/users/anthonyvercolano/repos","events_url":"https://api.github.com/users/anthonyvercolano/events{/privacy}","received_events_url":"https://api.github.com/users/anthonyvercolano/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/pulls/271/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/pulls/271/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/issues/271/comments","statuses_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/statuses/7a959f61e3f729782a8f3c37ecdf7103eb069be6","head":{"label":"BertKleewein:modules-amqp","ref":"modules-amqp","sha":"7a959f61e3f729782a8f3c37ecdf7103eb069be6","user":{"login":"BertKleewein","id":8028738,"avatar_url":"https://avatars0.githubusercontent.com/u/8028738?v=4","gravatar_id":"","url":"https://api.github.com/users/BertKleewein","html_url":"https://github.com/BertKleewein","followers_url":"https://api.github.com/users/BertKleewein/followers","following_url":"https://api.github.com/users/BertKleewein/following{/other_user}","gists_url":"https://api.github.com/users/BertKleewein/gists{/gist_id}","starred_url":"https://api.github.com/users/BertKleewein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BertKleewein/subscriptions","organizations_url":"https://api.github.com/users/BertKleewein/orgs","repos_url":"https://api.github.com/users/BertKleewein/repos","events_url":"https://api.github.com/users/BertKleewein/events{/privacy}","received_events_url":"https://api.github.com/users/BertKleewein/received_events","type":"User","site_admin":false},"repo":{"id":103567942,"name":"azure-iot-sdk-node","full_name":"BertKleewein/azure-iot-sdk-node","owner":{"login":"BertKleewein","id":8028738,"avatar_url":"https://avatars0.githubusercontent.com/u/8028738?v=4","gravatar_id":"","url":"https://api.github.com/users/BertKleewein","html_url":"https://github.com/BertKleewein","followers_url":"https://api.github.com/users/BertKleewein/followers","following_url":"https://api.github.com/users/BertKleewein/following{/other_user}","gists_url":"https://api.github.com/users/BertKleewein/gists{/gist_id}","starred_url":"https://api.github.com/users/BertKleewein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BertKleewein/subscriptions","organizations_url":"https://api.github.com/users/BertKleewein/orgs","repos_url":"https://api.github.com/users/BertKleewein/repos","events_url":"https://api.github.com/users/BertKleewein/events{/privacy}","received_events_url":"https://api.github.com/users/BertKleewein/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/BertKleewein/azure-iot-sdk-node","description":"A Node.js SDK for connecting devices to Microsoft Azure IoT services","fork":true,"url":"https://api.github.com/repos/BertKleewein/azure-iot-sdk-node","forks_url":"https://api.github.com/repos/BertKleewein/azure-iot-sdk-node/forks","keys_url":"https://api.github.com/repos/BertKleewein/azure-iot-sdk-node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BertKleewein/azure-iot-sdk-node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BertKleewein/azure-iot-sdk-node/teams","hooks_url":"https://api.github.com/repos/BertKleewein/azure-iot-sdk-node/hooks","issue_events_url":"https://api.github.com/repos/BertKleewein/azure-iot-sdk-node/issues/events{/number}","events_url":"https://api.github.com/repos/BertKleewein/azure-iot-sdk-node/events","assignees_url":"https://api.github.com/repos/BertKleewein/azure-iot-sdk-node/assignees{/user}","branches_url":"https://api.github.com/repos/BertKleewein/azure-iot-sdk-node/branches{/branch}","tags_url":"https://api.github.com/repos/BertKleewein/azure-iot-sdk-node/tags","blobs_url":"https://api.github.com/repos/BertKleewein/azure-iot-sdk-node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BertKleewein/azure-iot-sdk-node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BertKleewein/azure-iot-sdk-node/git/refs{/sha}","trees_url":"https://api.github.com/repos/BertKleewein/azure-iot-sdk-node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BertKleewein/azure-iot-sdk-node/statuses/{sha}","languages_url":"https://api.github.com/repos/BertKleewein/azure-iot-sdk-node/languages","stargazers_url":"https://api.github.com/repos/BertKleewein/azure-iot-sdk-node/stargazers","contributors_url":"https://api.github.com/repos/BertKleewein/azure-iot-sdk-node/contributors","subscribers_url":"https://api.github.com/repos/BertKleewein/azure-iot-sdk-node/subscribers","subscription_url":"https://api.github.com/repos/BertKleewein/azure-iot-sdk-node/subscription","commits_url":"https://api.github.com/repos/BertKleewein/azure-iot-sdk-node/commits{/sha}","git_commits_url":"https://api.github.com/repos/BertKleewein/azure-iot-sdk-node/git/commits{/sha}","comments_url":"https://api.github.com/repos/BertKleewein/azure-iot-sdk-node/comments{/number}","issue_comment_url":"https://api.github.com/repos/BertKleewein/azure-iot-sdk-node/issues/comments{/number}","contents_url":"https://api.github.com/repos/BertKleewein/azure-iot-sdk-node/contents/{+path}","compare_url":"https://api.github.com/repos/BertKleewein/azure-iot-sdk-node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BertKleewein/azure-iot-sdk-node/merges","archive_url":"https://api.github.com/repos/BertKleewein/azure-iot-sdk-node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BertKleewein/azure-iot-sdk-node/downloads","issues_url":"https://api.github.com/repos/BertKleewein/azure-iot-sdk-node/issues{/number}","pulls_url":"https://api.github.com/repos/BertKleewein/azure-iot-sdk-node/pulls{/number}","milestones_url":"https://api.github.com/repos/BertKleewein/azure-iot-sdk-node/milestones{/number}","notifications_url":"https://api.github.com/repos/BertKleewein/azure-iot-sdk-node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BertKleewein/azure-iot-sdk-node/labels{/name}","releases_url":"https://api.github.com/repos/BertKleewein/azure-iot-sdk-node/releases{/id}","deployments_url":"https://api.github.com/repos/BertKleewein/azure-iot-sdk-node/deployments","created_at":"2017-09-14T18:33:09Z","updated_at":"2018-04-09T16:41:42Z","pushed_at":"2018-04-10T20:20:07Z","git_url":"git://github.com/BertKleewein/azure-iot-sdk-node.git","ssh_url":"git@github.com:BertKleewein/azure-iot-sdk-node.git","clone_url":"https://github.com/BertKleewein/azure-iot-sdk-node.git","svn_url":"https://github.com/BertKleewein/azure-iot-sdk-node","homepage":"https://azure.github.io/azure-iot-sdk-node/","size":42457,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Azure:modules-preview","ref":"modules-preview","sha":"8b4ab99a954dba929dc584c37747794b579203e5","user":{"login":"Azure","id":6844498,"avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":70935002,"name":"azure-iot-sdk-node","full_name":"Azure/azure-iot-sdk-node","owner":{"login":"Azure","id":6844498,"avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/azure-iot-sdk-node","description":"A Node.js SDK for connecting devices to Microsoft Azure IoT services","fork":false,"url":"https://api.github.com/repos/Azure/azure-iot-sdk-node","forks_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/forks","keys_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/teams","hooks_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/events","assignees_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/tags","blobs_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/subscription","commits_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/merges","archive_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/downloads","issues_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-iot-sdk-node/deployments","created_at":"2016-10-14T18:03:43Z","updated_at":"2018-04-10T17:22:17Z","pushed_at":"2018-04-10T21:03:09Z","git_url":"git://github.com/Azure/azure-iot-sdk-node.git","ssh_url":"git@github.com:Azure/azure-iot-sdk-node.git","clone_url":"https://github.com/Azure/azure-iot-sdk-node.git","svn_url":"https://github.com/Azure/azure-iot-sdk-node","homepage":"https://docs.microsoft.com/en-us/azure/iot-hub/","size":43467,"stargazers_count":95,"watchers_count":95,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":79,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":79,"open_issues":4,"watchers":95,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-iot-sdk-node/pulls/271"},"html":{"href":"https://github.com/Azure/azure-iot-sdk-node/pull/271"},"issue":{"href":"https://api.github.com/repos/Azure/azure-iot-sdk-node/issues/271"},"comments":{"href":"https://api.github.com/repos/Azure/azure-iot-sdk-node/issues/271/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-iot-sdk-node/pulls/271/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-iot-sdk-node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-iot-sdk-node/pulls/271/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-iot-sdk-node/statuses/7a959f61e3f729782a8f3c37ecdf7103eb069be6"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"pierreca"}}