{"action":"created","issue":{"url":"https://api.github.com/repos/chapel-lang/chapel/issues/10091","repository_url":"https://api.github.com/repos/chapel-lang/chapel","labels_url":"https://api.github.com/repos/chapel-lang/chapel/issues/10091/labels{/name}","comments_url":"https://api.github.com/repos/chapel-lang/chapel/issues/10091/comments","events_url":"https://api.github.com/repos/chapel-lang/chapel/issues/10091/events","html_url":"https://github.com/chapel-lang/chapel/pull/10091","id":336840844,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4MTk5MzQw","number":10091,"title":"Switch to atomic counters for gasnet's comm diagnostics","user":{"login":"ronawho","id":1588337,"node_id":"MDQ6VXNlcjE1ODgzMzc=","avatar_url":"https://avatars1.githubusercontent.com/u/1588337?v=4","gravatar_id":"","url":"https://api.github.com/users/ronawho","html_url":"https://github.com/ronawho","followers_url":"https://api.github.com/users/ronawho/followers","following_url":"https://api.github.com/users/ronawho/following{/other_user}","gists_url":"https://api.github.com/users/ronawho/gists{/gist_id}","starred_url":"https://api.github.com/users/ronawho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ronawho/subscriptions","organizations_url":"https://api.github.com/users/ronawho/orgs","repos_url":"https://api.github.com/users/ronawho/repos","events_url":"https://api.github.com/users/ronawho/events{/privacy}","received_events_url":"https://api.github.com/users/ronawho/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-06-29T02:25:11Z","updated_at":"2018-07-02T15:48:26Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/chapel-lang/chapel/pulls/10091","html_url":"https://github.com/chapel-lang/chapel/pull/10091","diff_url":"https://github.com/chapel-lang/chapel/pull/10091.diff","patch_url":"https://github.com/chapel-lang/chapel/pull/10091.patch"},"body":"Previously, our gasnet shim used non-atomic variables with access protected by\r\na chpl_sync_lock()/chpl_sync_unlock(). This seems extremely heavyweight, so\r\njust convert to atomic counters like we do with ugni.\r\n\r\nThis makes comm diagnostics much more lightweight under gasnet, and cleans up\r\nthe code to gather diagnostics. I noticed this while making some changes to\r\nchpl_sync_lock()/chpl_sync_unlock(), which motivated me to look at uses of\r\nthese routines in the runtime.\r\n\r\nThis closes https://github.com/chapel-lang/chapel/issues/10089"},"comment":{"url":"https://api.github.com/repos/chapel-lang/chapel/issues/comments/401849154","html_url":"https://github.com/chapel-lang/chapel/pull/10091#issuecomment-401849154","issue_url":"https://api.github.com/repos/chapel-lang/chapel/issues/10091","id":401849154,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMTg0OTE1NA==","user":{"login":"gbtitus","id":7740880,"node_id":"MDQ6VXNlcjc3NDA4ODA=","avatar_url":"https://avatars3.githubusercontent.com/u/7740880?v=4","gravatar_id":"","url":"https://api.github.com/users/gbtitus","html_url":"https://github.com/gbtitus","followers_url":"https://api.github.com/users/gbtitus/followers","following_url":"https://api.github.com/users/gbtitus/following{/other_user}","gists_url":"https://api.github.com/users/gbtitus/gists{/gist_id}","starred_url":"https://api.github.com/users/gbtitus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gbtitus/subscriptions","organizations_url":"https://api.github.com/users/gbtitus/orgs","repos_url":"https://api.github.com/users/gbtitus/repos","events_url":"https://api.github.com/users/gbtitus/events{/privacy}","received_events_url":"https://api.github.com/users/gbtitus/received_events","type":"User","site_admin":false},"created_at":"2018-07-02T15:48:26Z","updated_at":"2018-07-02T15:48:26Z","author_association":"MEMBER","body":"Have you considered adding counters for the network atomics calls?  It's an obvious extension.  I think we've avoided it mainly because of the pervasive impact on .good files etc. but that's not actually maybe more of an excuse than a reason, especially now that we don't print zero values."}}
{"actor":{"display_login":"gbtitus"}}