{"action":"created","comment":{"url":"https://api.github.com/repos/diesel-rs/diesel/pulls/comments/167427237","pull_request_review_id":95648344,"id":167427237,"diff_hunk":"@@ -875,8 +875,10 @@ impl<T: Table> QueryDsl for T {}\n pub trait RunQueryDsl<Conn>: Sized {\n     /// Executes the given command, returning the number of rows affected.\n     ///\n-    /// Used in conjunction with [`insert_into`](../fn.insert_into.html),\n-    /// [`update`](../fn.update.html) and [`delete`](../fn.delete.html)\n+    /// `execute` is usually used in conjunction with [`insert_into`](../fn.insert_into.html),\n+    /// [`update`](../fn.update.html) and [`delete`](../fn.delete.html) where the number of\n+    /// affected rows is often enough information. When asking the database to return information","path":"diesel/src/query_dsl/mod.rs","position":8,"original_position":8,"commit_id":"74b54e4e8dc0b9b74821e4b396e8519b76528fcd","original_commit_id":"74b54e4e8dc0b9b74821e4b396e8519b76528fcd","user":{"login":"retep007","id":6537500,"avatar_url":"https://avatars3.githubusercontent.com/u/6537500?v=4","gravatar_id":"","url":"https://api.github.com/users/retep007","html_url":"https://github.com/retep007","followers_url":"https://api.github.com/users/retep007/followers","following_url":"https://api.github.com/users/retep007/following{/other_user}","gists_url":"https://api.github.com/users/retep007/gists{/gist_id}","starred_url":"https://api.github.com/users/retep007/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/retep007/subscriptions","organizations_url":"https://api.github.com/users/retep007/orgs","repos_url":"https://api.github.com/users/retep007/repos","events_url":"https://api.github.com/users/retep007/events{/privacy}","received_events_url":"https://api.github.com/users/retep007/received_events","type":"User","site_admin":false},"body":"Could you move `When asking...` on a new line?\r\n\r\nAlso what you say on `When asking the database to return data from query`.\r\n\r\n- Information is also a number of the affected rows\r\n- Operation feels to me a bit too much agnostic\r\n","created_at":"2018-02-11T09:12:45Z","updated_at":"2018-02-11T09:12:46Z","html_url":"https://github.com/diesel-rs/diesel/pull/1548#discussion_r167427237","pull_request_url":"https://api.github.com/repos/diesel-rs/diesel/pulls/1548","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/diesel-rs/diesel/pulls/comments/167427237"},"html":{"href":"https://github.com/diesel-rs/diesel/pull/1548#discussion_r167427237"},"pull_request":{"href":"https://api.github.com/repos/diesel-rs/diesel/pulls/1548"}}},"pull_request":{"url":"https://api.github.com/repos/diesel-rs/diesel/pulls/1548","id":167877536,"html_url":"https://github.com/diesel-rs/diesel/pull/1548","diff_url":"https://github.com/diesel-rs/diesel/pull/1548.diff","patch_url":"https://github.com/diesel-rs/diesel/pull/1548.patch","issue_url":"https://api.github.com/repos/diesel-rs/diesel/issues/1548","number":1548,"state":"open","locked":false,"title":"Clarify use of `execute` versus `load` in documentation","user":{"login":"brandur","id":96890,"avatar_url":"https://avatars1.githubusercontent.com/u/96890?v=4","gravatar_id":"","url":"https://api.github.com/users/brandur","html_url":"https://github.com/brandur","followers_url":"https://api.github.com/users/brandur/followers","following_url":"https://api.github.com/users/brandur/following{/other_user}","gists_url":"https://api.github.com/users/brandur/gists{/gist_id}","starred_url":"https://api.github.com/users/brandur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brandur/subscriptions","organizations_url":"https://api.github.com/users/brandur/orgs","repos_url":"https://api.github.com/users/brandur/repos","events_url":"https://api.github.com/users/brandur/events{/privacy}","received_events_url":"https://api.github.com/users/brandur/received_events","type":"User","site_admin":false},"body":"Adds cross-references to the documentation of the `execute` and `load`\nfunctions that help clarify when it's appropriate to use each one, and\nsuggests the use of the other when it's not.\n\nFixes #1136.","created_at":"2018-02-08T04:54:16Z","updated_at":"2018-02-11T09:12:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3cef3c8935408d9a9394d84cd663878691bf87b6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/diesel-rs/diesel/pulls/1548/commits","review_comments_url":"https://api.github.com/repos/diesel-rs/diesel/pulls/1548/comments","review_comment_url":"https://api.github.com/repos/diesel-rs/diesel/pulls/comments{/number}","comments_url":"https://api.github.com/repos/diesel-rs/diesel/issues/1548/comments","statuses_url":"https://api.github.com/repos/diesel-rs/diesel/statuses/74b54e4e8dc0b9b74821e4b396e8519b76528fcd","head":{"label":"brandur:brandur-execute-vs-load","ref":"brandur-execute-vs-load","sha":"74b54e4e8dc0b9b74821e4b396e8519b76528fcd","user":{"login":"brandur","id":96890,"avatar_url":"https://avatars1.githubusercontent.com/u/96890?v=4","gravatar_id":"","url":"https://api.github.com/users/brandur","html_url":"https://github.com/brandur","followers_url":"https://api.github.com/users/brandur/followers","following_url":"https://api.github.com/users/brandur/following{/other_user}","gists_url":"https://api.github.com/users/brandur/gists{/gist_id}","starred_url":"https://api.github.com/users/brandur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brandur/subscriptions","organizations_url":"https://api.github.com/users/brandur/orgs","repos_url":"https://api.github.com/users/brandur/repos","events_url":"https://api.github.com/users/brandur/events{/privacy}","received_events_url":"https://api.github.com/users/brandur/received_events","type":"User","site_admin":false},"repo":{"id":120712582,"name":"diesel","full_name":"brandur/diesel","owner":{"login":"brandur","id":96890,"avatar_url":"https://avatars1.githubusercontent.com/u/96890?v=4","gravatar_id":"","url":"https://api.github.com/users/brandur","html_url":"https://github.com/brandur","followers_url":"https://api.github.com/users/brandur/followers","following_url":"https://api.github.com/users/brandur/following{/other_user}","gists_url":"https://api.github.com/users/brandur/gists{/gist_id}","starred_url":"https://api.github.com/users/brandur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brandur/subscriptions","organizations_url":"https://api.github.com/users/brandur/orgs","repos_url":"https://api.github.com/users/brandur/repos","events_url":"https://api.github.com/users/brandur/events{/privacy}","received_events_url":"https://api.github.com/users/brandur/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brandur/diesel","description":"A safe, extensible ORM and Query Builder for Rust","fork":true,"url":"https://api.github.com/repos/brandur/diesel","forks_url":"https://api.github.com/repos/brandur/diesel/forks","keys_url":"https://api.github.com/repos/brandur/diesel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brandur/diesel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brandur/diesel/teams","hooks_url":"https://api.github.com/repos/brandur/diesel/hooks","issue_events_url":"https://api.github.com/repos/brandur/diesel/issues/events{/number}","events_url":"https://api.github.com/repos/brandur/diesel/events","assignees_url":"https://api.github.com/repos/brandur/diesel/assignees{/user}","branches_url":"https://api.github.com/repos/brandur/diesel/branches{/branch}","tags_url":"https://api.github.com/repos/brandur/diesel/tags","blobs_url":"https://api.github.com/repos/brandur/diesel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brandur/diesel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brandur/diesel/git/refs{/sha}","trees_url":"https://api.github.com/repos/brandur/diesel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brandur/diesel/statuses/{sha}","languages_url":"https://api.github.com/repos/brandur/diesel/languages","stargazers_url":"https://api.github.com/repos/brandur/diesel/stargazers","contributors_url":"https://api.github.com/repos/brandur/diesel/contributors","subscribers_url":"https://api.github.com/repos/brandur/diesel/subscribers","subscription_url":"https://api.github.com/repos/brandur/diesel/subscription","commits_url":"https://api.github.com/repos/brandur/diesel/commits{/sha}","git_commits_url":"https://api.github.com/repos/brandur/diesel/git/commits{/sha}","comments_url":"https://api.github.com/repos/brandur/diesel/comments{/number}","issue_comment_url":"https://api.github.com/repos/brandur/diesel/issues/comments{/number}","contents_url":"https://api.github.com/repos/brandur/diesel/contents/{+path}","compare_url":"https://api.github.com/repos/brandur/diesel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brandur/diesel/merges","archive_url":"https://api.github.com/repos/brandur/diesel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brandur/diesel/downloads","issues_url":"https://api.github.com/repos/brandur/diesel/issues{/number}","pulls_url":"https://api.github.com/repos/brandur/diesel/pulls{/number}","milestones_url":"https://api.github.com/repos/brandur/diesel/milestones{/number}","notifications_url":"https://api.github.com/repos/brandur/diesel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brandur/diesel/labels{/name}","releases_url":"https://api.github.com/repos/brandur/diesel/releases{/id}","deployments_url":"https://api.github.com/repos/brandur/diesel/deployments","created_at":"2018-02-08T04:52:00Z","updated_at":"2018-02-08T04:52:03Z","pushed_at":"2018-02-08T04:54:04Z","git_url":"git://github.com/brandur/diesel.git","ssh_url":"git@github.com:brandur/diesel.git","clone_url":"https://github.com/brandur/diesel.git","svn_url":"https://github.com/brandur/diesel","homepage":"http://diesel.rs","size":16907,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"diesel-rs:master","ref":"master","sha":"eacf6788b1dfcb54abfadb22444bd70455fa0a3a","user":{"login":"diesel-rs","id":16763251,"avatar_url":"https://avatars2.githubusercontent.com/u/16763251?v=4","gravatar_id":"","url":"https://api.github.com/users/diesel-rs","html_url":"https://github.com/diesel-rs","followers_url":"https://api.github.com/users/diesel-rs/followers","following_url":"https://api.github.com/users/diesel-rs/following{/other_user}","gists_url":"https://api.github.com/users/diesel-rs/gists{/gist_id}","starred_url":"https://api.github.com/users/diesel-rs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diesel-rs/subscriptions","organizations_url":"https://api.github.com/users/diesel-rs/orgs","repos_url":"https://api.github.com/users/diesel-rs/repos","events_url":"https://api.github.com/users/diesel-rs/events{/privacy}","received_events_url":"https://api.github.com/users/diesel-rs/received_events","type":"Organization","site_admin":false},"repo":{"id":41609775,"name":"diesel","full_name":"diesel-rs/diesel","owner":{"login":"diesel-rs","id":16763251,"avatar_url":"https://avatars2.githubusercontent.com/u/16763251?v=4","gravatar_id":"","url":"https://api.github.com/users/diesel-rs","html_url":"https://github.com/diesel-rs","followers_url":"https://api.github.com/users/diesel-rs/followers","following_url":"https://api.github.com/users/diesel-rs/following{/other_user}","gists_url":"https://api.github.com/users/diesel-rs/gists{/gist_id}","starred_url":"https://api.github.com/users/diesel-rs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diesel-rs/subscriptions","organizations_url":"https://api.github.com/users/diesel-rs/orgs","repos_url":"https://api.github.com/users/diesel-rs/repos","events_url":"https://api.github.com/users/diesel-rs/events{/privacy}","received_events_url":"https://api.github.com/users/diesel-rs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/diesel-rs/diesel","description":"A safe, extensible ORM and Query Builder for Rust","fork":false,"url":"https://api.github.com/repos/diesel-rs/diesel","forks_url":"https://api.github.com/repos/diesel-rs/diesel/forks","keys_url":"https://api.github.com/repos/diesel-rs/diesel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/diesel-rs/diesel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/diesel-rs/diesel/teams","hooks_url":"https://api.github.com/repos/diesel-rs/diesel/hooks","issue_events_url":"https://api.github.com/repos/diesel-rs/diesel/issues/events{/number}","events_url":"https://api.github.com/repos/diesel-rs/diesel/events","assignees_url":"https://api.github.com/repos/diesel-rs/diesel/assignees{/user}","branches_url":"https://api.github.com/repos/diesel-rs/diesel/branches{/branch}","tags_url":"https://api.github.com/repos/diesel-rs/diesel/tags","blobs_url":"https://api.github.com/repos/diesel-rs/diesel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/diesel-rs/diesel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/diesel-rs/diesel/git/refs{/sha}","trees_url":"https://api.github.com/repos/diesel-rs/diesel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/diesel-rs/diesel/statuses/{sha}","languages_url":"https://api.github.com/repos/diesel-rs/diesel/languages","stargazers_url":"https://api.github.com/repos/diesel-rs/diesel/stargazers","contributors_url":"https://api.github.com/repos/diesel-rs/diesel/contributors","subscribers_url":"https://api.github.com/repos/diesel-rs/diesel/subscribers","subscription_url":"https://api.github.com/repos/diesel-rs/diesel/subscription","commits_url":"https://api.github.com/repos/diesel-rs/diesel/commits{/sha}","git_commits_url":"https://api.github.com/repos/diesel-rs/diesel/git/commits{/sha}","comments_url":"https://api.github.com/repos/diesel-rs/diesel/comments{/number}","issue_comment_url":"https://api.github.com/repos/diesel-rs/diesel/issues/comments{/number}","contents_url":"https://api.github.com/repos/diesel-rs/diesel/contents/{+path}","compare_url":"https://api.github.com/repos/diesel-rs/diesel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/diesel-rs/diesel/merges","archive_url":"https://api.github.com/repos/diesel-rs/diesel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/diesel-rs/diesel/downloads","issues_url":"https://api.github.com/repos/diesel-rs/diesel/issues{/number}","pulls_url":"https://api.github.com/repos/diesel-rs/diesel/pulls{/number}","milestones_url":"https://api.github.com/repos/diesel-rs/diesel/milestones{/number}","notifications_url":"https://api.github.com/repos/diesel-rs/diesel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/diesel-rs/diesel/labels{/name}","releases_url":"https://api.github.com/repos/diesel-rs/diesel/releases{/id}","deployments_url":"https://api.github.com/repos/diesel-rs/diesel/deployments","created_at":"2015-08-29T22:51:00Z","updated_at":"2018-02-10T16:28:11Z","pushed_at":"2018-02-10T23:08:48Z","git_url":"git://github.com/diesel-rs/diesel.git","ssh_url":"git@github.com:diesel-rs/diesel.git","clone_url":"https://github.com/diesel-rs/diesel.git","svn_url":"https://github.com/diesel-rs/diesel","homepage":"http://diesel.rs","size":16941,"stargazers_count":2393,"watchers_count":2393,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":226,"mirror_url":null,"archived":false,"open_issues_count":85,"license":null,"forks":226,"open_issues":85,"watchers":2393,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/diesel-rs/diesel/pulls/1548"},"html":{"href":"https://github.com/diesel-rs/diesel/pull/1548"},"issue":{"href":"https://api.github.com/repos/diesel-rs/diesel/issues/1548"},"comments":{"href":"https://api.github.com/repos/diesel-rs/diesel/issues/1548/comments"},"review_comments":{"href":"https://api.github.com/repos/diesel-rs/diesel/pulls/1548/comments"},"review_comment":{"href":"https://api.github.com/repos/diesel-rs/diesel/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/diesel-rs/diesel/pulls/1548/commits"},"statuses":{"href":"https://api.github.com/repos/diesel-rs/diesel/statuses/74b54e4e8dc0b9b74821e4b396e8519b76528fcd"}},"author_association":"NONE"}}
{"actor":{"display_login":"retep007"}}