{"action":"created","comment":{"url":"https://api.github.com/repos/staltz/xstream/pulls/comments/244645018","pull_request_review_id":188565122,"id":244645018,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDY0NTAxOA==","diff_hunk":"@@ -24,10 +22,10 @@ describe('xs.from', () => {\n   });\n \n   it('should convert a rejected promise to a stream', (done: any) => {\n-    const stream = xs.from(Promise.reject('no'));\n+    const stream = xs.from<string>(Promise.reject('no'));","path":"tests/factory/from.ts","position":11,"original_position":11,"commit_id":"58805ad4ff9c329504f9641185e74b21ec9a0f17","original_commit_id":"58805ad4ff9c329504f9641185e74b21ec9a0f17","user":{"login":"Sinewyk","id":1826366,"node_id":"MDQ6VXNlcjE4MjYzNjY=","avatar_url":"https://avatars2.githubusercontent.com/u/1826366?v=4","gravatar_id":"","url":"https://api.github.com/users/Sinewyk","html_url":"https://github.com/Sinewyk","followers_url":"https://api.github.com/users/Sinewyk/followers","following_url":"https://api.github.com/users/Sinewyk/following{/other_user}","gists_url":"https://api.github.com/users/Sinewyk/gists{/gist_id}","starred_url":"https://api.github.com/users/Sinewyk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sinewyk/subscriptions","organizations_url":"https://api.github.com/users/Sinewyk/orgs","repos_url":"https://api.github.com/users/Sinewyk/repos","events_url":"https://api.github.com/users/Sinewyk/events{/privacy}","received_events_url":"https://api.github.com/users/Sinewyk/received_events","type":"User","site_admin":false},"body":"Haha, actually this one no, I must have gone through the error list, it first errored later because x was unused line 30, I removed it, so there's no need for the type hint anymore =D.","created_at":"2019-01-01T18:51:04Z","updated_at":"2019-01-01T18:51:05Z","html_url":"https://github.com/staltz/xstream/pull/268#discussion_r244645018","pull_request_url":"https://api.github.com/repos/staltz/xstream/pulls/268","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/staltz/xstream/pulls/comments/244645018"},"html":{"href":"https://github.com/staltz/xstream/pull/268#discussion_r244645018"},"pull_request":{"href":"https://api.github.com/repos/staltz/xstream/pulls/268"}},"in_reply_to_id":244644763},"pull_request":{"url":"https://api.github.com/repos/staltz/xstream/pulls/268","id":240641824,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwNjQxODI0","html_url":"https://github.com/staltz/xstream/pull/268","diff_url":"https://github.com/staltz/xstream/pull/268.diff","patch_url":"https://github.com/staltz/xstream/pull/268.patch","issue_url":"https://api.github.com/repos/staltz/xstream/issues/268","number":268,"state":"open","locked":false,"title":" refactor(compile): Activate typescript strict features","user":{"login":"Sinewyk","id":1826366,"node_id":"MDQ6VXNlcjE4MjYzNjY=","avatar_url":"https://avatars2.githubusercontent.com/u/1826366?v=4","gravatar_id":"","url":"https://api.github.com/users/Sinewyk","html_url":"https://github.com/Sinewyk","followers_url":"https://api.github.com/users/Sinewyk/followers","following_url":"https://api.github.com/users/Sinewyk/following{/other_user}","gists_url":"https://api.github.com/users/Sinewyk/gists{/gist_id}","starred_url":"https://api.github.com/users/Sinewyk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sinewyk/subscriptions","organizations_url":"https://api.github.com/users/Sinewyk/orgs","repos_url":"https://api.github.com/users/Sinewyk/repos","events_url":"https://api.github.com/users/Sinewyk/events{/privacy}","received_events_url":"https://api.github.com/users/Sinewyk/received_events","type":"User","site_admin":false},"body":"Just a cleanup in preparation of trying to fix https://github.com/staltz/xstream/issues/262\r\n\r\nActual line that we need to make compile after: https://github.com/Sinewyk/xstream/blob/2299e8f3441ed3b0723e830cfd2000b684858faa/tests/operator/flatten.ts#L338-L341\r\n","created_at":"2018-12-22T16:02:01Z","updated_at":"2019-01-01T18:51:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ee67e7d84b9ee1e16a10dd50b0a320f053e820d2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/staltz/xstream/pulls/268/commits","review_comments_url":"https://api.github.com/repos/staltz/xstream/pulls/268/comments","review_comment_url":"https://api.github.com/repos/staltz/xstream/pulls/comments{/number}","comments_url":"https://api.github.com/repos/staltz/xstream/issues/268/comments","statuses_url":"https://api.github.com/repos/staltz/xstream/statuses/58805ad4ff9c329504f9641185e74b21ec9a0f17","head":{"label":"Sinewyk:add_strictness","ref":"add_strictness","sha":"58805ad4ff9c329504f9641185e74b21ec9a0f17","user":{"login":"Sinewyk","id":1826366,"node_id":"MDQ6VXNlcjE4MjYzNjY=","avatar_url":"https://avatars2.githubusercontent.com/u/1826366?v=4","gravatar_id":"","url":"https://api.github.com/users/Sinewyk","html_url":"https://github.com/Sinewyk","followers_url":"https://api.github.com/users/Sinewyk/followers","following_url":"https://api.github.com/users/Sinewyk/following{/other_user}","gists_url":"https://api.github.com/users/Sinewyk/gists{/gist_id}","starred_url":"https://api.github.com/users/Sinewyk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sinewyk/subscriptions","organizations_url":"https://api.github.com/users/Sinewyk/orgs","repos_url":"https://api.github.com/users/Sinewyk/repos","events_url":"https://api.github.com/users/Sinewyk/events{/privacy}","received_events_url":"https://api.github.com/users/Sinewyk/received_events","type":"User","site_admin":false},"repo":{"id":162779023,"node_id":"MDEwOlJlcG9zaXRvcnkxNjI3NzkwMjM=","name":"xstream","full_name":"Sinewyk/xstream","private":false,"owner":{"login":"Sinewyk","id":1826366,"node_id":"MDQ6VXNlcjE4MjYzNjY=","avatar_url":"https://avatars2.githubusercontent.com/u/1826366?v=4","gravatar_id":"","url":"https://api.github.com/users/Sinewyk","html_url":"https://github.com/Sinewyk","followers_url":"https://api.github.com/users/Sinewyk/followers","following_url":"https://api.github.com/users/Sinewyk/following{/other_user}","gists_url":"https://api.github.com/users/Sinewyk/gists{/gist_id}","starred_url":"https://api.github.com/users/Sinewyk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sinewyk/subscriptions","organizations_url":"https://api.github.com/users/Sinewyk/orgs","repos_url":"https://api.github.com/users/Sinewyk/repos","events_url":"https://api.github.com/users/Sinewyk/events{/privacy}","received_events_url":"https://api.github.com/users/Sinewyk/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Sinewyk/xstream","description":"An extremely intuitive, small, and fast functional reactive stream library for JavaScript","fork":true,"url":"https://api.github.com/repos/Sinewyk/xstream","forks_url":"https://api.github.com/repos/Sinewyk/xstream/forks","keys_url":"https://api.github.com/repos/Sinewyk/xstream/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Sinewyk/xstream/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Sinewyk/xstream/teams","hooks_url":"https://api.github.com/repos/Sinewyk/xstream/hooks","issue_events_url":"https://api.github.com/repos/Sinewyk/xstream/issues/events{/number}","events_url":"https://api.github.com/repos/Sinewyk/xstream/events","assignees_url":"https://api.github.com/repos/Sinewyk/xstream/assignees{/user}","branches_url":"https://api.github.com/repos/Sinewyk/xstream/branches{/branch}","tags_url":"https://api.github.com/repos/Sinewyk/xstream/tags","blobs_url":"https://api.github.com/repos/Sinewyk/xstream/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Sinewyk/xstream/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Sinewyk/xstream/git/refs{/sha}","trees_url":"https://api.github.com/repos/Sinewyk/xstream/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Sinewyk/xstream/statuses/{sha}","languages_url":"https://api.github.com/repos/Sinewyk/xstream/languages","stargazers_url":"https://api.github.com/repos/Sinewyk/xstream/stargazers","contributors_url":"https://api.github.com/repos/Sinewyk/xstream/contributors","subscribers_url":"https://api.github.com/repos/Sinewyk/xstream/subscribers","subscription_url":"https://api.github.com/repos/Sinewyk/xstream/subscription","commits_url":"https://api.github.com/repos/Sinewyk/xstream/commits{/sha}","git_commits_url":"https://api.github.com/repos/Sinewyk/xstream/git/commits{/sha}","comments_url":"https://api.github.com/repos/Sinewyk/xstream/comments{/number}","issue_comment_url":"https://api.github.com/repos/Sinewyk/xstream/issues/comments{/number}","contents_url":"https://api.github.com/repos/Sinewyk/xstream/contents/{+path}","compare_url":"https://api.github.com/repos/Sinewyk/xstream/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Sinewyk/xstream/merges","archive_url":"https://api.github.com/repos/Sinewyk/xstream/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Sinewyk/xstream/downloads","issues_url":"https://api.github.com/repos/Sinewyk/xstream/issues{/number}","pulls_url":"https://api.github.com/repos/Sinewyk/xstream/pulls{/number}","milestones_url":"https://api.github.com/repos/Sinewyk/xstream/milestones{/number}","notifications_url":"https://api.github.com/repos/Sinewyk/xstream/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Sinewyk/xstream/labels{/name}","releases_url":"https://api.github.com/repos/Sinewyk/xstream/releases{/id}","deployments_url":"https://api.github.com/repos/Sinewyk/xstream/deployments","created_at":"2018-12-22T03:39:01Z","updated_at":"2018-12-22T03:39:03Z","pushed_at":"2018-12-28T11:23:48Z","git_url":"git://github.com/Sinewyk/xstream.git","ssh_url":"git@github.com:Sinewyk/xstream.git","clone_url":"https://github.com/Sinewyk/xstream.git","svn_url":"https://github.com/Sinewyk/xstream","homepage":"http://staltz.github.io/xstream/","size":1267,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"staltz:master","ref":"master","sha":"0c3a855a1170e7cb42ec47587eb2659d0e8072ee","user":{"login":"staltz","id":90512,"node_id":"MDQ6VXNlcjkwNTEy","avatar_url":"https://avatars3.githubusercontent.com/u/90512?v=4","gravatar_id":"","url":"https://api.github.com/users/staltz","html_url":"https://github.com/staltz","followers_url":"https://api.github.com/users/staltz/followers","following_url":"https://api.github.com/users/staltz/following{/other_user}","gists_url":"https://api.github.com/users/staltz/gists{/gist_id}","starred_url":"https://api.github.com/users/staltz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/staltz/subscriptions","organizations_url":"https://api.github.com/users/staltz/orgs","repos_url":"https://api.github.com/users/staltz/repos","events_url":"https://api.github.com/users/staltz/events{/privacy}","received_events_url":"https://api.github.com/users/staltz/received_events","type":"User","site_admin":false},"repo":{"id":56880047,"node_id":"MDEwOlJlcG9zaXRvcnk1Njg4MDA0Nw==","name":"xstream","full_name":"staltz/xstream","private":false,"owner":{"login":"staltz","id":90512,"node_id":"MDQ6VXNlcjkwNTEy","avatar_url":"https://avatars3.githubusercontent.com/u/90512?v=4","gravatar_id":"","url":"https://api.github.com/users/staltz","html_url":"https://github.com/staltz","followers_url":"https://api.github.com/users/staltz/followers","following_url":"https://api.github.com/users/staltz/following{/other_user}","gists_url":"https://api.github.com/users/staltz/gists{/gist_id}","starred_url":"https://api.github.com/users/staltz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/staltz/subscriptions","organizations_url":"https://api.github.com/users/staltz/orgs","repos_url":"https://api.github.com/users/staltz/repos","events_url":"https://api.github.com/users/staltz/events{/privacy}","received_events_url":"https://api.github.com/users/staltz/received_events","type":"User","site_admin":false},"html_url":"https://github.com/staltz/xstream","description":"An extremely intuitive, small, and fast functional reactive stream library for JavaScript","fork":false,"url":"https://api.github.com/repos/staltz/xstream","forks_url":"https://api.github.com/repos/staltz/xstream/forks","keys_url":"https://api.github.com/repos/staltz/xstream/keys{/key_id}","collaborators_url":"https://api.github.com/repos/staltz/xstream/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/staltz/xstream/teams","hooks_url":"https://api.github.com/repos/staltz/xstream/hooks","issue_events_url":"https://api.github.com/repos/staltz/xstream/issues/events{/number}","events_url":"https://api.github.com/repos/staltz/xstream/events","assignees_url":"https://api.github.com/repos/staltz/xstream/assignees{/user}","branches_url":"https://api.github.com/repos/staltz/xstream/branches{/branch}","tags_url":"https://api.github.com/repos/staltz/xstream/tags","blobs_url":"https://api.github.com/repos/staltz/xstream/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/staltz/xstream/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/staltz/xstream/git/refs{/sha}","trees_url":"https://api.github.com/repos/staltz/xstream/git/trees{/sha}","statuses_url":"https://api.github.com/repos/staltz/xstream/statuses/{sha}","languages_url":"https://api.github.com/repos/staltz/xstream/languages","stargazers_url":"https://api.github.com/repos/staltz/xstream/stargazers","contributors_url":"https://api.github.com/repos/staltz/xstream/contributors","subscribers_url":"https://api.github.com/repos/staltz/xstream/subscribers","subscription_url":"https://api.github.com/repos/staltz/xstream/subscription","commits_url":"https://api.github.com/repos/staltz/xstream/commits{/sha}","git_commits_url":"https://api.github.com/repos/staltz/xstream/git/commits{/sha}","comments_url":"https://api.github.com/repos/staltz/xstream/comments{/number}","issue_comment_url":"https://api.github.com/repos/staltz/xstream/issues/comments{/number}","contents_url":"https://api.github.com/repos/staltz/xstream/contents/{+path}","compare_url":"https://api.github.com/repos/staltz/xstream/compare/{base}...{head}","merges_url":"https://api.github.com/repos/staltz/xstream/merges","archive_url":"https://api.github.com/repos/staltz/xstream/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/staltz/xstream/downloads","issues_url":"https://api.github.com/repos/staltz/xstream/issues{/number}","pulls_url":"https://api.github.com/repos/staltz/xstream/pulls{/number}","milestones_url":"https://api.github.com/repos/staltz/xstream/milestones{/number}","notifications_url":"https://api.github.com/repos/staltz/xstream/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/staltz/xstream/labels{/name}","releases_url":"https://api.github.com/repos/staltz/xstream/releases{/id}","deployments_url":"https://api.github.com/repos/staltz/xstream/deployments","created_at":"2016-04-22T19:25:41Z","updated_at":"2018-12-29T15:30:20Z","pushed_at":"2018-12-28T11:23:49Z","git_url":"git://github.com/staltz/xstream.git","ssh_url":"git@github.com:staltz/xstream.git","clone_url":"https://github.com/staltz/xstream.git","svn_url":"https://github.com/staltz/xstream","homepage":"http://staltz.github.io/xstream/","size":1256,"stargazers_count":1755,"watchers_count":1755,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":115,"mirror_url":null,"archived":false,"open_issues_count":33,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":115,"open_issues":33,"watchers":1755,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/staltz/xstream/pulls/268"},"html":{"href":"https://github.com/staltz/xstream/pull/268"},"issue":{"href":"https://api.github.com/repos/staltz/xstream/issues/268"},"comments":{"href":"https://api.github.com/repos/staltz/xstream/issues/268/comments"},"review_comments":{"href":"https://api.github.com/repos/staltz/xstream/pulls/268/comments"},"review_comment":{"href":"https://api.github.com/repos/staltz/xstream/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/staltz/xstream/pulls/268/commits"},"statuses":{"href":"https://api.github.com/repos/staltz/xstream/statuses/58805ad4ff9c329504f9641185e74b21ec9a0f17"}},"author_association":"NONE"}}
{"actor":{"display_login":"Sinewyk"}}