{"action":"created","issue":{"url":"https://api.github.com/repos/floooh/fips/issues/195","repository_url":"https://api.github.com/repos/floooh/fips","labels_url":"https://api.github.com/repos/floooh/fips/issues/195/labels{/name}","comments_url":"https://api.github.com/repos/floooh/fips/issues/195/comments","events_url":"https://api.github.com/repos/floooh/fips/issues/195/events","html_url":"https://github.com/floooh/fips/issues/195","id":338266845,"node_id":"MDU6SXNzdWUzMzgyNjY4NDU=","number":195,"title":"Python3 issue when checking out a 'versioned' dependency.","user":{"login":"floooh","id":1699414,"node_id":"MDQ6VXNlcjE2OTk0MTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1699414?v=4","gravatar_id":"","url":"https://api.github.com/users/floooh","html_url":"https://github.com/floooh","followers_url":"https://api.github.com/users/floooh/followers","following_url":"https://api.github.com/users/floooh/following{/other_user}","gists_url":"https://api.github.com/users/floooh/gists{/gist_id}","starred_url":"https://api.github.com/users/floooh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/floooh/subscriptions","organizations_url":"https://api.github.com/users/floooh/orgs","repos_url":"https://api.github.com/users/floooh/repos","events_url":"https://api.github.com/users/floooh/events{/privacy}","received_events_url":"https://api.github.com/users/floooh/received_events","type":"User","site_admin":false},"labels":[{"id":155751436,"node_id":"MDU6TGFiZWwxNTU3NTE0MzY=","url":"https://api.github.com/repos/floooh/fips/labels/bug","name":"bug","color":"fc2929","default":true}],"state":"closed","locked":false,"assignee":{"login":"floooh","id":1699414,"node_id":"MDQ6VXNlcjE2OTk0MTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1699414?v=4","gravatar_id":"","url":"https://api.github.com/users/floooh","html_url":"https://github.com/floooh","followers_url":"https://api.github.com/users/floooh/followers","following_url":"https://api.github.com/users/floooh/following{/other_user}","gists_url":"https://api.github.com/users/floooh/gists{/gist_id}","starred_url":"https://api.github.com/users/floooh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/floooh/subscriptions","organizations_url":"https://api.github.com/users/floooh/orgs","repos_url":"https://api.github.com/users/floooh/repos","events_url":"https://api.github.com/users/floooh/events{/privacy}","received_events_url":"https://api.github.com/users/floooh/received_events","type":"User","site_admin":false},"assignees":[{"login":"floooh","id":1699414,"node_id":"MDQ6VXNlcjE2OTk0MTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1699414?v=4","gravatar_id":"","url":"https://api.github.com/users/floooh","html_url":"https://github.com/floooh","followers_url":"https://api.github.com/users/floooh/followers","following_url":"https://api.github.com/users/floooh/following{/other_user}","gists_url":"https://api.github.com/users/floooh/gists{/gist_id}","starred_url":"https://api.github.com/users/floooh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/floooh/subscriptions","organizations_url":"https://api.github.com/users/floooh/orgs","repos_url":"https://api.github.com/users/floooh/repos","events_url":"https://api.github.com/users/floooh/events{/privacy}","received_events_url":"https://api.github.com/users/floooh/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2018-07-04T13:00:29Z","updated_at":"2018-07-04T17:30:10Z","closed_at":"2018-07-04T15:15:30Z","author_association":"OWNER","body":"Originally reported here: https://github.com/floooh/fips-hello-world/issues/2\r\n\r\nWhen fetching fips-hello-world dependencies:\r\n\r\n```\r\n$ ./fips build\r\n=== dependency: 'fips-hello-dep1':\r\nCloning into 'fips-hello-dep1'...\r\nremote: Counting objects: 53, done.\r\nremote: Compressing objects: 100% (35/35), done.\r\nremote: Total 53 (delta 14), reused 52 (delta 14), pack-reused 0\r\nUnpacking objects: 100% (53/53), done.\r\n=== dependency: 'fips-hello-dep2':\r\nCloning into 'fips-hello-dep2'...\r\nremote: Counting objects: 62, done.\r\nremote: Compressing objects: 100% (38/38), done.\r\nremote: Total 62 (delta 17), reused 62 (delta 17), pack-reused 0\r\nUnpacking objects: 100% (62/62), done.\r\n=== dependency: 'fips-hello-dep3':\r\nCloning into 'fips-hello-dep3'...\r\nremote: Counting objects: 85, done.\r\nremote: Total 85 (delta 0), reused 0 (delta 0), pack-reused 85\r\nUnpacking objects: 100% (85/85), done.\r\n=== revision: '191f59f0':\r\nNote: checking out '191f59f0'.\r\n\r\nYou are in 'detached HEAD' state. You can look around, make experimental                                              \r\nchanges and commit them, and you can discard any commits you make in this                                             \r\nstate without impacting any branches by performing another checkout.                                                  \r\n\r\nIf you want to create a new branch to retain commits you create, you may                                              \r\ndo so (now or later) by using -b with the checkout command again. Example:                                            \r\n\r\n  git checkout -b <new-branch-name>\r\n\r\nHEAD is now at 191f59f First commit - working version 1\r\nTraceback (most recent call last):\r\n  File \"./fips\", line 17, in <module>\r\n    fips.run(fips_path, proj_path, sys.argv)\r\n  File \"/home/spacepluk/hacking/fips/mod/fips.py\", line 49, in run                                                    \r\n    verb.verbs[verb_name].run(fips_path, proj_path, verb_args)                                                        \r\n  File \"/home/spacepluk/hacking/fips/verbs/build.py\", line 19, in run                                                 \r\n    project.build(fips_dir, proj_dir, cfg_name)\r\n  File \"/home/spacepluk/hacking/fips/mod/project.py\", line 229, in build                                              \r\n    dep.fetch_imports(fips_dir, proj_dir)\r\n  File \"/home/spacepluk/hacking/fips/mod/dep.py\", line 228, in fetch_imports                                          \r\n    _rec_fetch_imports(fips_dir, proj_dir, [])\r\n  File \"/home/spacepluk/hacking/fips/mod/dep.py\", line 204, in _rec_fetch_imports                                     \r\n    dep_ok = git.checkout(dep_proj_dir, git_commit)\r\n  File \"/home/spacepluk/hacking/fips/mod/tools/git.py\", line 188, in checkout                                         \r\n    return output.split(':')[0] != 'error'\r\nTypeError: a bytes-like object is required, not 'str'\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/floooh/fips/issues/comments/402531405","html_url":"https://github.com/floooh/fips/issues/195#issuecomment-402531405","issue_url":"https://api.github.com/repos/floooh/fips/issues/195","id":402531405,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMjUzMTQwNQ==","user":{"login":"floooh","id":1699414,"node_id":"MDQ6VXNlcjE2OTk0MTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1699414?v=4","gravatar_id":"","url":"https://api.github.com/users/floooh","html_url":"https://github.com/floooh","followers_url":"https://api.github.com/users/floooh/followers","following_url":"https://api.github.com/users/floooh/following{/other_user}","gists_url":"https://api.github.com/users/floooh/gists{/gist_id}","starred_url":"https://api.github.com/users/floooh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/floooh/subscriptions","organizations_url":"https://api.github.com/users/floooh/orgs","repos_url":"https://api.github.com/users/floooh/repos","events_url":"https://api.github.com/users/floooh/events{/privacy}","received_events_url":"https://api.github.com/users/floooh/received_events","type":"User","site_admin":false},"created_at":"2018-07-04T17:30:10Z","updated_at":"2018-07-04T17:30:10Z","author_association":"OWNER","body":"Hmm how do I reproduce that? I was testing with ```python3 fips build``` on the fips-hello-world project, and this was running through all the way on MacOS (python version 3.7.0). I'll fix the bug nonetheless (there are parantheses missing around the print)."}}
{"actor":{"display_login":"floooh"}}