{"action":"created","comment":{"url":"https://api.github.com/repos/ilya-epifanov/kafka-tool/pulls/comments/171508668","pull_request_review_id":100369838,"id":171508668,"diff_hunk":"@@ -41,5 +41,14 @@ class Opts(arguments: Seq[String]) extends ScallopConf(arguments) {\n   val listSuperfluousTopics = new Subcommand(\"list-superfluous-topics\")\n   addSubcommand(listSuperfluousTopics)\n \n+\n+  val aclUpdate = new Subcommand(\"update-acls\") {","path":"src/main/scala/com/libertyglobal/odh/kafkatool/Opts.scala","position":5,"original_position":5,"commit_id":"8f99d3f2e8e95b03e0a908284779fa6d93f367e0","original_commit_id":"8f99d3f2e8e95b03e0a908284779fa6d93f367e0","user":{"login":"ilya-epifanov","id":92526,"avatar_url":"https://avatars0.githubusercontent.com/u/92526?v=4","gravatar_id":"","url":"https://api.github.com/users/ilya-epifanov","html_url":"https://github.com/ilya-epifanov","followers_url":"https://api.github.com/users/ilya-epifanov/followers","following_url":"https://api.github.com/users/ilya-epifanov/following{/other_user}","gists_url":"https://api.github.com/users/ilya-epifanov/gists{/gist_id}","starred_url":"https://api.github.com/users/ilya-epifanov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilya-epifanov/subscriptions","organizations_url":"https://api.github.com/users/ilya-epifanov/orgs","repos_url":"https://api.github.com/users/ilya-epifanov/repos","events_url":"https://api.github.com/users/ilya-epifanov/events{/privacy}","received_events_url":"https://api.github.com/users/ilya-epifanov/received_events","type":"User","site_admin":false},"body":"why not `val updateAcls` ?","created_at":"2018-03-01T09:54:22Z","updated_at":"2018-03-01T09:58:16Z","html_url":"https://github.com/ilya-epifanov/kafka-tool/pull/1#discussion_r171508668","pull_request_url":"https://api.github.com/repos/ilya-epifanov/kafka-tool/pulls/1","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/ilya-epifanov/kafka-tool/pulls/comments/171508668"},"html":{"href":"https://github.com/ilya-epifanov/kafka-tool/pull/1#discussion_r171508668"},"pull_request":{"href":"https://api.github.com/repos/ilya-epifanov/kafka-tool/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/ilya-epifanov/kafka-tool/pulls/1","id":171709062,"html_url":"https://github.com/ilya-epifanov/kafka-tool/pull/1","diff_url":"https://github.com/ilya-epifanov/kafka-tool/pull/1.diff","patch_url":"https://github.com/ilya-epifanov/kafka-tool/pull/1.patch","issue_url":"https://api.github.com/repos/ilya-epifanov/kafka-tool/issues/1","number":1,"state":"open","locked":false,"title":"Kafka ACLs support","user":{"login":"BenjaminDebotte","id":4532729,"avatar_url":"https://avatars1.githubusercontent.com/u/4532729?v=4","gravatar_id":"","url":"https://api.github.com/users/BenjaminDebotte","html_url":"https://github.com/BenjaminDebotte","followers_url":"https://api.github.com/users/BenjaminDebotte/followers","following_url":"https://api.github.com/users/BenjaminDebotte/following{/other_user}","gists_url":"https://api.github.com/users/BenjaminDebotte/gists{/gist_id}","starred_url":"https://api.github.com/users/BenjaminDebotte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BenjaminDebotte/subscriptions","organizations_url":"https://api.github.com/users/BenjaminDebotte/orgs","repos_url":"https://api.github.com/users/BenjaminDebotte/repos","events_url":"https://api.github.com/users/BenjaminDebotte/events{/privacy}","received_events_url":"https://api.github.com/users/BenjaminDebotte/received_events","type":"User","site_admin":false},"body":"\r\n# Extract of application.conf\r\n```\r\n    # spark jobs\r\n    \"kafka-topic-1\" {\r\n      accessControlEntries = [\r\n        {\r\n          principal =\"User\"\r\n          name = \"bdebotte\"\r\n          hosts = [\"*\"]\r\n          operations = [\r\n            \"READ\",\r\n            \"WRITE\"\r\n          ]\r\n          permissions = [\r\n            \"ALLOW\"\r\n          ]\r\n        }\r\n      ]\r\n    },\r\n    \"kafka-topic-1\" {\r\n      accessControlEntries = [\r\n        {\r\n          principal =\"User\"\r\n          name = \"admin\"\r\n          hosts = [\"*\"]\r\n          operations = [\r\n            \"READ\",\r\n            \"WRITE\",\r\n            \"CREATE\"\r\n          ]\r\n          permissions = [\r\n            \"DENY\"\r\n          ]\r\n        }\r\n      ]\r\n    },\r\n```","created_at":"2018-02-27T16:09:27Z","updated_at":"2018-03-01T09:58:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a315e0933915a76eaf73f270d96a08a35dcde896","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ilya-epifanov/kafka-tool/pulls/1/commits","review_comments_url":"https://api.github.com/repos/ilya-epifanov/kafka-tool/pulls/1/comments","review_comment_url":"https://api.github.com/repos/ilya-epifanov/kafka-tool/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ilya-epifanov/kafka-tool/issues/1/comments","statuses_url":"https://api.github.com/repos/ilya-epifanov/kafka-tool/statuses/8f99d3f2e8e95b03e0a908284779fa6d93f367e0","head":{"label":"BenjaminDebotte:kafka-acl","ref":"kafka-acl","sha":"8f99d3f2e8e95b03e0a908284779fa6d93f367e0","user":{"login":"BenjaminDebotte","id":4532729,"avatar_url":"https://avatars1.githubusercontent.com/u/4532729?v=4","gravatar_id":"","url":"https://api.github.com/users/BenjaminDebotte","html_url":"https://github.com/BenjaminDebotte","followers_url":"https://api.github.com/users/BenjaminDebotte/followers","following_url":"https://api.github.com/users/BenjaminDebotte/following{/other_user}","gists_url":"https://api.github.com/users/BenjaminDebotte/gists{/gist_id}","starred_url":"https://api.github.com/users/BenjaminDebotte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BenjaminDebotte/subscriptions","organizations_url":"https://api.github.com/users/BenjaminDebotte/orgs","repos_url":"https://api.github.com/users/BenjaminDebotte/repos","events_url":"https://api.github.com/users/BenjaminDebotte/events{/privacy}","received_events_url":"https://api.github.com/users/BenjaminDebotte/received_events","type":"User","site_admin":false},"repo":{"id":123153729,"name":"kafka-tool","full_name":"BenjaminDebotte/kafka-tool","owner":{"login":"BenjaminDebotte","id":4532729,"avatar_url":"https://avatars1.githubusercontent.com/u/4532729?v=4","gravatar_id":"","url":"https://api.github.com/users/BenjaminDebotte","html_url":"https://github.com/BenjaminDebotte","followers_url":"https://api.github.com/users/BenjaminDebotte/followers","following_url":"https://api.github.com/users/BenjaminDebotte/following{/other_user}","gists_url":"https://api.github.com/users/BenjaminDebotte/gists{/gist_id}","starred_url":"https://api.github.com/users/BenjaminDebotte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BenjaminDebotte/subscriptions","organizations_url":"https://api.github.com/users/BenjaminDebotte/orgs","repos_url":"https://api.github.com/users/BenjaminDebotte/repos","events_url":"https://api.github.com/users/BenjaminDebotte/events{/privacy}","received_events_url":"https://api.github.com/users/BenjaminDebotte/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/BenjaminDebotte/kafka-tool","description":null,"fork":true,"url":"https://api.github.com/repos/BenjaminDebotte/kafka-tool","forks_url":"https://api.github.com/repos/BenjaminDebotte/kafka-tool/forks","keys_url":"https://api.github.com/repos/BenjaminDebotte/kafka-tool/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BenjaminDebotte/kafka-tool/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BenjaminDebotte/kafka-tool/teams","hooks_url":"https://api.github.com/repos/BenjaminDebotte/kafka-tool/hooks","issue_events_url":"https://api.github.com/repos/BenjaminDebotte/kafka-tool/issues/events{/number}","events_url":"https://api.github.com/repos/BenjaminDebotte/kafka-tool/events","assignees_url":"https://api.github.com/repos/BenjaminDebotte/kafka-tool/assignees{/user}","branches_url":"https://api.github.com/repos/BenjaminDebotte/kafka-tool/branches{/branch}","tags_url":"https://api.github.com/repos/BenjaminDebotte/kafka-tool/tags","blobs_url":"https://api.github.com/repos/BenjaminDebotte/kafka-tool/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BenjaminDebotte/kafka-tool/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BenjaminDebotte/kafka-tool/git/refs{/sha}","trees_url":"https://api.github.com/repos/BenjaminDebotte/kafka-tool/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BenjaminDebotte/kafka-tool/statuses/{sha}","languages_url":"https://api.github.com/repos/BenjaminDebotte/kafka-tool/languages","stargazers_url":"https://api.github.com/repos/BenjaminDebotte/kafka-tool/stargazers","contributors_url":"https://api.github.com/repos/BenjaminDebotte/kafka-tool/contributors","subscribers_url":"https://api.github.com/repos/BenjaminDebotte/kafka-tool/subscribers","subscription_url":"https://api.github.com/repos/BenjaminDebotte/kafka-tool/subscription","commits_url":"https://api.github.com/repos/BenjaminDebotte/kafka-tool/commits{/sha}","git_commits_url":"https://api.github.com/repos/BenjaminDebotte/kafka-tool/git/commits{/sha}","comments_url":"https://api.github.com/repos/BenjaminDebotte/kafka-tool/comments{/number}","issue_comment_url":"https://api.github.com/repos/BenjaminDebotte/kafka-tool/issues/comments{/number}","contents_url":"https://api.github.com/repos/BenjaminDebotte/kafka-tool/contents/{+path}","compare_url":"https://api.github.com/repos/BenjaminDebotte/kafka-tool/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BenjaminDebotte/kafka-tool/merges","archive_url":"https://api.github.com/repos/BenjaminDebotte/kafka-tool/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BenjaminDebotte/kafka-tool/downloads","issues_url":"https://api.github.com/repos/BenjaminDebotte/kafka-tool/issues{/number}","pulls_url":"https://api.github.com/repos/BenjaminDebotte/kafka-tool/pulls{/number}","milestones_url":"https://api.github.com/repos/BenjaminDebotte/kafka-tool/milestones{/number}","notifications_url":"https://api.github.com/repos/BenjaminDebotte/kafka-tool/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BenjaminDebotte/kafka-tool/labels{/name}","releases_url":"https://api.github.com/repos/BenjaminDebotte/kafka-tool/releases{/id}","deployments_url":"https://api.github.com/repos/BenjaminDebotte/kafka-tool/deployments","created_at":"2018-02-27T16:05:24Z","updated_at":"2018-02-27T16:05:26Z","pushed_at":"2018-03-01T09:50:40Z","git_url":"git://github.com/BenjaminDebotte/kafka-tool.git","ssh_url":"git@github.com:BenjaminDebotte/kafka-tool.git","clone_url":"https://github.com/BenjaminDebotte/kafka-tool.git","svn_url":"https://github.com/BenjaminDebotte/kafka-tool","homepage":null,"size":69,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ilya-epifanov:master","ref":"master","sha":"d21af882ec9d1b0627551c2ce665d80e38f99f63","user":{"login":"ilya-epifanov","id":92526,"avatar_url":"https://avatars0.githubusercontent.com/u/92526?v=4","gravatar_id":"","url":"https://api.github.com/users/ilya-epifanov","html_url":"https://github.com/ilya-epifanov","followers_url":"https://api.github.com/users/ilya-epifanov/followers","following_url":"https://api.github.com/users/ilya-epifanov/following{/other_user}","gists_url":"https://api.github.com/users/ilya-epifanov/gists{/gist_id}","starred_url":"https://api.github.com/users/ilya-epifanov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilya-epifanov/subscriptions","organizations_url":"https://api.github.com/users/ilya-epifanov/orgs","repos_url":"https://api.github.com/users/ilya-epifanov/repos","events_url":"https://api.github.com/users/ilya-epifanov/events{/privacy}","received_events_url":"https://api.github.com/users/ilya-epifanov/received_events","type":"User","site_admin":false},"repo":{"id":114780722,"name":"kafka-tool","full_name":"ilya-epifanov/kafka-tool","owner":{"login":"ilya-epifanov","id":92526,"avatar_url":"https://avatars0.githubusercontent.com/u/92526?v=4","gravatar_id":"","url":"https://api.github.com/users/ilya-epifanov","html_url":"https://github.com/ilya-epifanov","followers_url":"https://api.github.com/users/ilya-epifanov/followers","following_url":"https://api.github.com/users/ilya-epifanov/following{/other_user}","gists_url":"https://api.github.com/users/ilya-epifanov/gists{/gist_id}","starred_url":"https://api.github.com/users/ilya-epifanov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilya-epifanov/subscriptions","organizations_url":"https://api.github.com/users/ilya-epifanov/orgs","repos_url":"https://api.github.com/users/ilya-epifanov/repos","events_url":"https://api.github.com/users/ilya-epifanov/events{/privacy}","received_events_url":"https://api.github.com/users/ilya-epifanov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ilya-epifanov/kafka-tool","description":null,"fork":false,"url":"https://api.github.com/repos/ilya-epifanov/kafka-tool","forks_url":"https://api.github.com/repos/ilya-epifanov/kafka-tool/forks","keys_url":"https://api.github.com/repos/ilya-epifanov/kafka-tool/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ilya-epifanov/kafka-tool/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ilya-epifanov/kafka-tool/teams","hooks_url":"https://api.github.com/repos/ilya-epifanov/kafka-tool/hooks","issue_events_url":"https://api.github.com/repos/ilya-epifanov/kafka-tool/issues/events{/number}","events_url":"https://api.github.com/repos/ilya-epifanov/kafka-tool/events","assignees_url":"https://api.github.com/repos/ilya-epifanov/kafka-tool/assignees{/user}","branches_url":"https://api.github.com/repos/ilya-epifanov/kafka-tool/branches{/branch}","tags_url":"https://api.github.com/repos/ilya-epifanov/kafka-tool/tags","blobs_url":"https://api.github.com/repos/ilya-epifanov/kafka-tool/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ilya-epifanov/kafka-tool/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ilya-epifanov/kafka-tool/git/refs{/sha}","trees_url":"https://api.github.com/repos/ilya-epifanov/kafka-tool/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ilya-epifanov/kafka-tool/statuses/{sha}","languages_url":"https://api.github.com/repos/ilya-epifanov/kafka-tool/languages","stargazers_url":"https://api.github.com/repos/ilya-epifanov/kafka-tool/stargazers","contributors_url":"https://api.github.com/repos/ilya-epifanov/kafka-tool/contributors","subscribers_url":"https://api.github.com/repos/ilya-epifanov/kafka-tool/subscribers","subscription_url":"https://api.github.com/repos/ilya-epifanov/kafka-tool/subscription","commits_url":"https://api.github.com/repos/ilya-epifanov/kafka-tool/commits{/sha}","git_commits_url":"https://api.github.com/repos/ilya-epifanov/kafka-tool/git/commits{/sha}","comments_url":"https://api.github.com/repos/ilya-epifanov/kafka-tool/comments{/number}","issue_comment_url":"https://api.github.com/repos/ilya-epifanov/kafka-tool/issues/comments{/number}","contents_url":"https://api.github.com/repos/ilya-epifanov/kafka-tool/contents/{+path}","compare_url":"https://api.github.com/repos/ilya-epifanov/kafka-tool/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ilya-epifanov/kafka-tool/merges","archive_url":"https://api.github.com/repos/ilya-epifanov/kafka-tool/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ilya-epifanov/kafka-tool/downloads","issues_url":"https://api.github.com/repos/ilya-epifanov/kafka-tool/issues{/number}","pulls_url":"https://api.github.com/repos/ilya-epifanov/kafka-tool/pulls{/number}","milestones_url":"https://api.github.com/repos/ilya-epifanov/kafka-tool/milestones{/number}","notifications_url":"https://api.github.com/repos/ilya-epifanov/kafka-tool/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ilya-epifanov/kafka-tool/labels{/name}","releases_url":"https://api.github.com/repos/ilya-epifanov/kafka-tool/releases{/id}","deployments_url":"https://api.github.com/repos/ilya-epifanov/kafka-tool/deployments","created_at":"2017-12-19T15:22:18Z","updated_at":"2017-12-20T12:19:19Z","pushed_at":"2018-03-01T09:50:42Z","git_url":"git://github.com/ilya-epifanov/kafka-tool.git","ssh_url":"git@github.com:ilya-epifanov/kafka-tool.git","clone_url":"https://github.com/ilya-epifanov/kafka-tool.git","svn_url":"https://github.com/ilya-epifanov/kafka-tool","homepage":null,"size":22,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ilya-epifanov/kafka-tool/pulls/1"},"html":{"href":"https://github.com/ilya-epifanov/kafka-tool/pull/1"},"issue":{"href":"https://api.github.com/repos/ilya-epifanov/kafka-tool/issues/1"},"comments":{"href":"https://api.github.com/repos/ilya-epifanov/kafka-tool/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/ilya-epifanov/kafka-tool/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/ilya-epifanov/kafka-tool/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ilya-epifanov/kafka-tool/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/ilya-epifanov/kafka-tool/statuses/8f99d3f2e8e95b03e0a908284779fa6d93f367e0"}},"author_association":"NONE"}}
{"actor":{"display_login":"ilya-epifanov"}}