{"action":"created","issue":{"url":"https://api.github.com/repos/aspnet/EntityFrameworkCore/issues/14160","repository_url":"https://api.github.com/repos/aspnet/EntityFrameworkCore","labels_url":"https://api.github.com/repos/aspnet/EntityFrameworkCore/issues/14160/labels{/name}","comments_url":"https://api.github.com/repos/aspnet/EntityFrameworkCore/issues/14160/comments","events_url":"https://api.github.com/repos/aspnet/EntityFrameworkCore/issues/14160/events","html_url":"https://github.com/aspnet/EntityFrameworkCore/issues/14160","id":390806745,"node_id":"MDU6SXNzdWUzOTA4MDY3NDU=","number":14160,"title":"RevEng: Fixed Length facet incorrect in ScaffoldingTypeMapper","user":{"login":"smitpatel","id":1528107,"node_id":"MDQ6VXNlcjE1MjgxMDc=","avatar_url":"https://avatars0.githubusercontent.com/u/1528107?v=4","gravatar_id":"","url":"https://api.github.com/users/smitpatel","html_url":"https://github.com/smitpatel","followers_url":"https://api.github.com/users/smitpatel/followers","following_url":"https://api.github.com/users/smitpatel/following{/other_user}","gists_url":"https://api.github.com/users/smitpatel/gists{/gist_id}","starred_url":"https://api.github.com/users/smitpatel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smitpatel/subscriptions","organizations_url":"https://api.github.com/users/smitpatel/orgs","repos_url":"https://api.github.com/users/smitpatel/repos","events_url":"https://api.github.com/users/smitpatel/events{/privacy}","received_events_url":"https://api.github.com/users/smitpatel/received_events","type":"User","site_admin":false},"labels":[{"id":1127980372,"node_id":"MDU6TGFiZWwxMTI3OTgwMzcy","url":"https://api.github.com/repos/aspnet/EntityFrameworkCore/labels/shay-as-a-label","name":"shay-as-a-label","color":"a3f7aa","default":false},{"id":76481852,"node_id":"MDU6TGFiZWw3NjQ4MTg1Mg==","url":"https://api.github.com/repos/aspnet/EntityFrameworkCore/labels/type-bug","name":"type-bug","color":"f7c6c7","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-12-13T18:36:21Z","updated_at":"2018-12-13T19:03:48Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"https://github.com/aspnet/EntityFrameworkCore/blob/8e7402701ea1416b7fe55e1863ae65b3147c02c7/src/EFCore.Design/Scaffolding/Internal/ScaffoldingTypeMapper.cs#L117-L125\r\n\r\nAbove code is supposed to pass in default value for Fixed Length and compare type mapping to figure out if the value is same as default (hence no need to scaffold). Default for Fixed length is false and _not_ true."},"comment":{"url":"https://api.github.com/repos/aspnet/EntityFrameworkCore/issues/comments/447082587","html_url":"https://github.com/aspnet/EntityFrameworkCore/issues/14160#issuecomment-447082587","issue_url":"https://api.github.com/repos/aspnet/EntityFrameworkCore/issues/14160","id":447082587,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NzA4MjU4Nw==","user":{"login":"ajcvickers","id":1430078,"node_id":"MDQ6VXNlcjE0MzAwNzg=","avatar_url":"https://avatars1.githubusercontent.com/u/1430078?v=4","gravatar_id":"","url":"https://api.github.com/users/ajcvickers","html_url":"https://github.com/ajcvickers","followers_url":"https://api.github.com/users/ajcvickers/followers","following_url":"https://api.github.com/users/ajcvickers/following{/other_user}","gists_url":"https://api.github.com/users/ajcvickers/gists{/gist_id}","starred_url":"https://api.github.com/users/ajcvickers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajcvickers/subscriptions","organizations_url":"https://api.github.com/users/ajcvickers/orgs","repos_url":"https://api.github.com/users/ajcvickers/repos","events_url":"https://api.github.com/users/ajcvickers/events{/privacy}","received_events_url":"https://api.github.com/users/ajcvickers/received_events","type":"User","site_admin":false},"created_at":"2018-12-13T19:03:48Z","updated_at":"2018-12-13T19:03:48Z","author_association":"MEMBER","body":"Presumably we are missing tests for this. Is this because of the general test debt for rev-eng, or was this just something we missed? /cc @bricelam "}}
{"actor":{"display_login":"ajcvickers"}}