{"action":"created","comment":{"url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/pulls/comments/207227327","pull_request_review_id":142794933,"id":207227327,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNzIyNzMyNw==","diff_hunk":"@@ -153,13 +153,44 @@ def compute(self, inputs, outputs):\n         prob['area3'] = 0.0005\n         prob.run_driver()\n \n-        # Note, GA doesn't do so well with the continunous vars, naturally, so we reduce the space\n-        # as much as we can. Objective is stll rather random, but it is close. GA does a great job\n+        # Note, GA doesn't do so well with the continuous vars, naturally, so we reduce the space\n+        # as much as we can. Objective is still rather random, but it is close. GA does a great job\n         # of picking the correct values for the integer desvars though.\n         self.assertLess(prob['mass'], 6.0)\n         assert_rel_error(self, prob['mat1'], 3, 1e-5)\n         assert_rel_error(self, prob['mat2'], 3, 1e-5)\n-        #Material 3 can be anything\n+        # Material 3 can be anything\n+\n+    def test_analysis_error(self):\n+        np.random.seed(1)\n+\n+        class ValueErrorComp(ExplicitComponent):\n+            \"\"\"\n+            Raises value error. AnalysisError should return the original error.","path":"openmdao/drivers/tests/test_genetic_algorithm_driver.py","position":20,"original_position":20,"commit_id":"e573919f90246d42739d12aeca5a5b4476324864","original_commit_id":"e573919f90246d42739d12aeca5a5b4476324864","user":{"login":"naylor-b","id":701448,"node_id":"MDQ6VXNlcjcwMTQ0OA==","avatar_url":"https://avatars0.githubusercontent.com/u/701448?v=4","gravatar_id":"","url":"https://api.github.com/users/naylor-b","html_url":"https://github.com/naylor-b","followers_url":"https://api.github.com/users/naylor-b/followers","following_url":"https://api.github.com/users/naylor-b/following{/other_user}","gists_url":"https://api.github.com/users/naylor-b/gists{/gist_id}","starred_url":"https://api.github.com/users/naylor-b/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/naylor-b/subscriptions","organizations_url":"https://api.github.com/users/naylor-b/orgs","repos_url":"https://api.github.com/users/naylor-b/repos","events_url":"https://api.github.com/users/naylor-b/events{/privacy}","received_events_url":"https://api.github.com/users/naylor-b/received_events","type":"User","site_admin":false},"body":"This comment isn't quite right.  A solver can raise an AnalysisError if it fails to converge, or certain components will generate AnalysisErrors, but in the case of ValueErrorComp, it will simply raise its ValueError and no AnalysisError will ever be involved.  I would just remove this comment since it will probably cause confusion.","created_at":"2018-08-02T13:35:29Z","updated_at":"2018-08-02T13:37:18Z","html_url":"https://github.com/OpenMDAO/OpenMDAO/pull/710#discussion_r207227327","pull_request_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/pulls/710","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/OpenMDAO/OpenMDAO/pulls/comments/207227327"},"html":{"href":"https://github.com/OpenMDAO/OpenMDAO/pull/710#discussion_r207227327"},"pull_request":{"href":"https://api.github.com/repos/OpenMDAO/OpenMDAO/pulls/710"}}},"pull_request":{"url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/pulls/710","id":205721879,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1NzIxODc5","html_url":"https://github.com/OpenMDAO/OpenMDAO/pull/710","diff_url":"https://github.com/OpenMDAO/OpenMDAO/pull/710.diff","patch_url":"https://github.com/OpenMDAO/OpenMDAO/pull/710.patch","issue_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/issues/710","number":710,"state":"open","locked":false,"title":"SimpleGADriver AnalysisError import error fixed","user":{"login":"onodip","id":34424189,"node_id":"MDQ6VXNlcjM0NDI0MTg5","avatar_url":"https://avatars0.githubusercontent.com/u/34424189?v=4","gravatar_id":"","url":"https://api.github.com/users/onodip","html_url":"https://github.com/onodip","followers_url":"https://api.github.com/users/onodip/followers","following_url":"https://api.github.com/users/onodip/following{/other_user}","gists_url":"https://api.github.com/users/onodip/gists{/gist_id}","starred_url":"https://api.github.com/users/onodip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onodip/subscriptions","organizations_url":"https://api.github.com/users/onodip/orgs","repos_url":"https://api.github.com/users/onodip/repos","events_url":"https://api.github.com/users/onodip/events{/privacy}","received_events_url":"https://api.github.com/users/onodip/received_events","type":"User","site_admin":false},"body":"In genetic_algorithm_driver AnalysisError import error fixed by adding import statement for AnalysisError. \r\nPreviously SimpleGADriver failed with NameError and did not return the original error from the model if an exception was raised during the execution of run_driver()\r\nIn test_genetic_algorithm_driver.py  test_analysis_error() test function added, which checks the type of the exception.","created_at":"2018-08-02T12:45:19Z","updated_at":"2018-08-02T13:37:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1f73f9f257d44b9bac03ab9368a37e9ec3da0517","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/pulls/710/commits","review_comments_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/pulls/710/comments","review_comment_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/issues/710/comments","statuses_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/statuses/e573919f90246d42739d12aeca5a5b4476324864","head":{"label":"onodip:development","ref":"development","sha":"e573919f90246d42739d12aeca5a5b4476324864","user":{"login":"onodip","id":34424189,"node_id":"MDQ6VXNlcjM0NDI0MTg5","avatar_url":"https://avatars0.githubusercontent.com/u/34424189?v=4","gravatar_id":"","url":"https://api.github.com/users/onodip","html_url":"https://github.com/onodip","followers_url":"https://api.github.com/users/onodip/followers","following_url":"https://api.github.com/users/onodip/following{/other_user}","gists_url":"https://api.github.com/users/onodip/gists{/gist_id}","starred_url":"https://api.github.com/users/onodip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onodip/subscriptions","organizations_url":"https://api.github.com/users/onodip/orgs","repos_url":"https://api.github.com/users/onodip/repos","events_url":"https://api.github.com/users/onodip/events{/privacy}","received_events_url":"https://api.github.com/users/onodip/received_events","type":"User","site_admin":false},"repo":{"id":143284836,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMyODQ4MzY=","name":"OpenMDAO","full_name":"onodip/OpenMDAO","owner":{"login":"onodip","id":34424189,"node_id":"MDQ6VXNlcjM0NDI0MTg5","avatar_url":"https://avatars0.githubusercontent.com/u/34424189?v=4","gravatar_id":"","url":"https://api.github.com/users/onodip","html_url":"https://github.com/onodip","followers_url":"https://api.github.com/users/onodip/followers","following_url":"https://api.github.com/users/onodip/following{/other_user}","gists_url":"https://api.github.com/users/onodip/gists{/gist_id}","starred_url":"https://api.github.com/users/onodip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onodip/subscriptions","organizations_url":"https://api.github.com/users/onodip/orgs","repos_url":"https://api.github.com/users/onodip/repos","events_url":"https://api.github.com/users/onodip/events{/privacy}","received_events_url":"https://api.github.com/users/onodip/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/onodip/OpenMDAO","description":"OpenMDAO 2.0 repository. ","fork":true,"url":"https://api.github.com/repos/onodip/OpenMDAO","forks_url":"https://api.github.com/repos/onodip/OpenMDAO/forks","keys_url":"https://api.github.com/repos/onodip/OpenMDAO/keys{/key_id}","collaborators_url":"https://api.github.com/repos/onodip/OpenMDAO/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/onodip/OpenMDAO/teams","hooks_url":"https://api.github.com/repos/onodip/OpenMDAO/hooks","issue_events_url":"https://api.github.com/repos/onodip/OpenMDAO/issues/events{/number}","events_url":"https://api.github.com/repos/onodip/OpenMDAO/events","assignees_url":"https://api.github.com/repos/onodip/OpenMDAO/assignees{/user}","branches_url":"https://api.github.com/repos/onodip/OpenMDAO/branches{/branch}","tags_url":"https://api.github.com/repos/onodip/OpenMDAO/tags","blobs_url":"https://api.github.com/repos/onodip/OpenMDAO/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/onodip/OpenMDAO/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/onodip/OpenMDAO/git/refs{/sha}","trees_url":"https://api.github.com/repos/onodip/OpenMDAO/git/trees{/sha}","statuses_url":"https://api.github.com/repos/onodip/OpenMDAO/statuses/{sha}","languages_url":"https://api.github.com/repos/onodip/OpenMDAO/languages","stargazers_url":"https://api.github.com/repos/onodip/OpenMDAO/stargazers","contributors_url":"https://api.github.com/repos/onodip/OpenMDAO/contributors","subscribers_url":"https://api.github.com/repos/onodip/OpenMDAO/subscribers","subscription_url":"https://api.github.com/repos/onodip/OpenMDAO/subscription","commits_url":"https://api.github.com/repos/onodip/OpenMDAO/commits{/sha}","git_commits_url":"https://api.github.com/repos/onodip/OpenMDAO/git/commits{/sha}","comments_url":"https://api.github.com/repos/onodip/OpenMDAO/comments{/number}","issue_comment_url":"https://api.github.com/repos/onodip/OpenMDAO/issues/comments{/number}","contents_url":"https://api.github.com/repos/onodip/OpenMDAO/contents/{+path}","compare_url":"https://api.github.com/repos/onodip/OpenMDAO/compare/{base}...{head}","merges_url":"https://api.github.com/repos/onodip/OpenMDAO/merges","archive_url":"https://api.github.com/repos/onodip/OpenMDAO/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/onodip/OpenMDAO/downloads","issues_url":"https://api.github.com/repos/onodip/OpenMDAO/issues{/number}","pulls_url":"https://api.github.com/repos/onodip/OpenMDAO/pulls{/number}","milestones_url":"https://api.github.com/repos/onodip/OpenMDAO/milestones{/number}","notifications_url":"https://api.github.com/repos/onodip/OpenMDAO/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/onodip/OpenMDAO/labels{/name}","releases_url":"https://api.github.com/repos/onodip/OpenMDAO/releases{/id}","deployments_url":"https://api.github.com/repos/onodip/OpenMDAO/deployments","created_at":"2018-08-02T11:19:27Z","updated_at":"2018-08-02T11:19:31Z","pushed_at":"2018-08-02T12:39:43Z","git_url":"git://github.com/onodip/OpenMDAO.git","ssh_url":"git@github.com:onodip/OpenMDAO.git","clone_url":"https://github.com/onodip/OpenMDAO.git","svn_url":"https://github.com/onodip/OpenMDAO","homepage":"http://openmdao.org","size":13992,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OpenMDAO:master","ref":"master","sha":"96a99806fb3a547b881d2ad3da2733bca9978567","user":{"login":"OpenMDAO","id":861615,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2MTYxNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/861615?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenMDAO","html_url":"https://github.com/OpenMDAO","followers_url":"https://api.github.com/users/OpenMDAO/followers","following_url":"https://api.github.com/users/OpenMDAO/following{/other_user}","gists_url":"https://api.github.com/users/OpenMDAO/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenMDAO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenMDAO/subscriptions","organizations_url":"https://api.github.com/users/OpenMDAO/orgs","repos_url":"https://api.github.com/users/OpenMDAO/repos","events_url":"https://api.github.com/users/OpenMDAO/events{/privacy}","received_events_url":"https://api.github.com/users/OpenMDAO/received_events","type":"Organization","site_admin":false},"repo":{"id":66572302,"node_id":"MDEwOlJlcG9zaXRvcnk2NjU3MjMwMg==","name":"OpenMDAO","full_name":"OpenMDAO/OpenMDAO","owner":{"login":"OpenMDAO","id":861615,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2MTYxNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/861615?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenMDAO","html_url":"https://github.com/OpenMDAO","followers_url":"https://api.github.com/users/OpenMDAO/followers","following_url":"https://api.github.com/users/OpenMDAO/following{/other_user}","gists_url":"https://api.github.com/users/OpenMDAO/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenMDAO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenMDAO/subscriptions","organizations_url":"https://api.github.com/users/OpenMDAO/orgs","repos_url":"https://api.github.com/users/OpenMDAO/repos","events_url":"https://api.github.com/users/OpenMDAO/events{/privacy}","received_events_url":"https://api.github.com/users/OpenMDAO/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenMDAO/OpenMDAO","description":"OpenMDAO 2.0 repository. ","fork":false,"url":"https://api.github.com/repos/OpenMDAO/OpenMDAO","forks_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/forks","keys_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/teams","hooks_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/hooks","issue_events_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/issues/events{/number}","events_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/events","assignees_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/assignees{/user}","branches_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/branches{/branch}","tags_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/tags","blobs_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/languages","stargazers_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/stargazers","contributors_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/contributors","subscribers_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/subscribers","subscription_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/subscription","commits_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/contents/{+path}","compare_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/merges","archive_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/downloads","issues_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/issues{/number}","pulls_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/labels{/name}","releases_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/releases{/id}","deployments_url":"https://api.github.com/repos/OpenMDAO/OpenMDAO/deployments","created_at":"2016-08-25T15:53:25Z","updated_at":"2018-08-02T12:50:13Z","pushed_at":"2018-08-02T12:45:19Z","git_url":"git://github.com/OpenMDAO/OpenMDAO.git","ssh_url":"git@github.com:OpenMDAO/OpenMDAO.git","clone_url":"https://github.com/OpenMDAO/OpenMDAO.git","svn_url":"https://github.com/OpenMDAO/OpenMDAO","homepage":"http://openmdao.org","size":13992,"stargazers_count":53,"watchers_count":53,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":41,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":41,"open_issues":6,"watchers":53,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenMDAO/OpenMDAO/pulls/710"},"html":{"href":"https://github.com/OpenMDAO/OpenMDAO/pull/710"},"issue":{"href":"https://api.github.com/repos/OpenMDAO/OpenMDAO/issues/710"},"comments":{"href":"https://api.github.com/repos/OpenMDAO/OpenMDAO/issues/710/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenMDAO/OpenMDAO/pulls/710/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenMDAO/OpenMDAO/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenMDAO/OpenMDAO/pulls/710/commits"},"statuses":{"href":"https://api.github.com/repos/OpenMDAO/OpenMDAO/statuses/e573919f90246d42739d12aeca5a5b4476324864"}},"author_association":"NONE"}}
{"actor":{"display_login":"naylor-b"}}