{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/comments/175910476","pull_request_review_id":105521600,"id":175910476,"diff_hunk":"@@ -43,7 +43,10 @@ def current_username(self):\n \n     @property\n     def current_fullname(self):\n-        return self.settings.text.strip().split('|', 1)[0].strip()\n+        try:\n+            return self.settings.text.strip().split('|', 1)[0].strip()\n+        except AttributeError:","path":"cfme/base/login.py","position":7,"original_position":7,"commit_id":"20fa867f69b6dc121e1f2adc1322267a3515b022","original_commit_id":"20fa867f69b6dc121e1f2adc1322267a3515b022","user":{"login":"mshriver","id":21315076,"avatar_url":"https://avatars3.githubusercontent.com/u/21315076?v=4","gravatar_id":"","url":"https://api.github.com/users/mshriver","html_url":"https://github.com/mshriver","followers_url":"https://api.github.com/users/mshriver/followers","following_url":"https://api.github.com/users/mshriver/following{/other_user}","gists_url":"https://api.github.com/users/mshriver/gists{/gist_id}","starred_url":"https://api.github.com/users/mshriver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mshriver/subscriptions","organizations_url":"https://api.github.com/users/mshriver/orgs","repos_url":"https://api.github.com/users/mshriver/repos","events_url":"https://api.github.com/users/mshriver/events{/privacy}","received_events_url":"https://api.github.com/users/mshriver/received_events","type":"User","site_admin":false},"body":"As in the methods above, it ends up happening because there's no check that the view is actually displayed.  An AttributeError is raised because `self.settings.text` is None, which has no `strip()` attr. Will put in comment.","created_at":"2018-03-20T20:24:50Z","updated_at":"2018-03-20T20:24:50Z","html_url":"https://github.com/ManageIQ/integration_tests/pull/6929#discussion_r175910476","pull_request_url":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/6929","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/comments/175910476"},"html":{"href":"https://github.com/ManageIQ/integration_tests/pull/6929#discussion_r175910476"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/6929"}},"in_reply_to_id":175906563},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/6929","id":176293320,"html_url":"https://github.com/ManageIQ/integration_tests/pull/6929","diff_url":"https://github.com/ManageIQ/integration_tests/pull/6929.diff","patch_url":"https://github.com/ManageIQ/integration_tests/pull/6929.patch","issue_url":"https://api.github.com/repos/ManageIQ/integration_tests/issues/6929","number":6929,"state":"open","locked":false,"title":"[RFR] Tweak base login and ui for exception handling","user":{"login":"mshriver","id":21315076,"avatar_url":"https://avatars3.githubusercontent.com/u/21315076?v=4","gravatar_id":"","url":"https://api.github.com/users/mshriver","html_url":"https://github.com/mshriver","followers_url":"https://api.github.com/users/mshriver/followers","following_url":"https://api.github.com/users/mshriver/following{/other_user}","gists_url":"https://api.github.com/users/mshriver/gists{/gist_id}","starred_url":"https://api.github.com/users/mshriver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mshriver/subscriptions","organizations_url":"https://api.github.com/users/mshriver/orgs","repos_url":"https://api.github.com/users/mshriver/repos","events_url":"https://api.github.com/users/mshriver/events{/privacy}","received_events_url":"https://api.github.com/users/mshriver/received_events","type":"User","site_admin":false},"body":"Was producing an exception because the view isn't actually displayed.\r\n\r\n```python\r\n>               appliance.server.login(user, method='click_on_login')\r\n\r\ncfme/tests/integration/test_cfme_auth.py:183: \r\n_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ \r\n/usr/lib/python2.7/site-packages/sentaku/context.py:132: in __call__\r\n    return bound_method(*k, **kw)\r\ncfme/base/ui.py:189: in login\r\n    user.name = logged_in_view.current_fullname\r\n_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ \r\n\r\nself = <cfme.base.login.BaseLoggedInPage object at 0x7fcd42f2f610>\r\n\r\n    @property\r\n    def current_fullname(self):\r\n>       return self.settings.text.strip().split('|', 1)[0].strip()\r\nE       AttributeError: 'NoneType' object has no attribute 'strip'\r\n\r\ncfme/base/login.py:46: AttributeError\r\n```","created_at":"2018-03-20T19:08:27Z","updated_at":"2018-03-20T20:24:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8e1c176776cdef89db9095a7551f6678cc3e6b68","assignee":null,"assignees":[],"requested_reviewers":[{"login":"quarckster","id":1011257,"avatar_url":"https://avatars0.githubusercontent.com/u/1011257?v=4","gravatar_id":"","url":"https://api.github.com/users/quarckster","html_url":"https://github.com/quarckster","followers_url":"https://api.github.com/users/quarckster/followers","following_url":"https://api.github.com/users/quarckster/following{/other_user}","gists_url":"https://api.github.com/users/quarckster/gists{/gist_id}","starred_url":"https://api.github.com/users/quarckster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quarckster/subscriptions","organizations_url":"https://api.github.com/users/quarckster/orgs","repos_url":"https://api.github.com/users/quarckster/repos","events_url":"https://api.github.com/users/quarckster/events{/privacy}","received_events_url":"https://api.github.com/users/quarckster/received_events","type":"User","site_admin":false},{"login":"psav","id":5639745,"avatar_url":"https://avatars0.githubusercontent.com/u/5639745?v=4","gravatar_id":"","url":"https://api.github.com/users/psav","html_url":"https://github.com/psav","followers_url":"https://api.github.com/users/psav/followers","following_url":"https://api.github.com/users/psav/following{/other_user}","gists_url":"https://api.github.com/users/psav/gists{/gist_id}","starred_url":"https://api.github.com/users/psav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psav/subscriptions","organizations_url":"https://api.github.com/users/psav/orgs","repos_url":"https://api.github.com/users/psav/repos","events_url":"https://api.github.com/users/psav/events{/privacy}","received_events_url":"https://api.github.com/users/psav/received_events","type":"User","site_admin":false},{"login":"rlbabyuk","id":26601785,"avatar_url":"https://avatars2.githubusercontent.com/u/26601785?v=4","gravatar_id":"","url":"https://api.github.com/users/rlbabyuk","html_url":"https://github.com/rlbabyuk","followers_url":"https://api.github.com/users/rlbabyuk/followers","following_url":"https://api.github.com/users/rlbabyuk/following{/other_user}","gists_url":"https://api.github.com/users/rlbabyuk/gists{/gist_id}","starred_url":"https://api.github.com/users/rlbabyuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rlbabyuk/subscriptions","organizations_url":"https://api.github.com/users/rlbabyuk/orgs","repos_url":"https://api.github.com/users/rlbabyuk/repos","events_url":"https://api.github.com/users/rlbabyuk/events{/privacy}","received_events_url":"https://api.github.com/users/rlbabyuk/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":469084577,"url":"https://api.github.com/repos/ManageIQ/integration_tests/labels/fix-framework","name":"fix-framework","color":"0e8a16","default":false},{"id":118710104,"url":"https://api.github.com/repos/ManageIQ/integration_tests/labels/lint-ok","name":"lint-ok","color":"ffffff","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/6929/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/6929/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/integration_tests/issues/6929/comments","statuses_url":"https://api.github.com/repos/ManageIQ/integration_tests/statuses/20fa867f69b6dc121e1f2adc1322267a3515b022","head":{"label":"mshriver:fix-login-user-check","ref":"fix-login-user-check","sha":"20fa867f69b6dc121e1f2adc1322267a3515b022","user":{"login":"mshriver","id":21315076,"avatar_url":"https://avatars3.githubusercontent.com/u/21315076?v=4","gravatar_id":"","url":"https://api.github.com/users/mshriver","html_url":"https://github.com/mshriver","followers_url":"https://api.github.com/users/mshriver/followers","following_url":"https://api.github.com/users/mshriver/following{/other_user}","gists_url":"https://api.github.com/users/mshriver/gists{/gist_id}","starred_url":"https://api.github.com/users/mshriver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mshriver/subscriptions","organizations_url":"https://api.github.com/users/mshriver/orgs","repos_url":"https://api.github.com/users/mshriver/repos","events_url":"https://api.github.com/users/mshriver/events{/privacy}","received_events_url":"https://api.github.com/users/mshriver/received_events","type":"User","site_admin":false},"repo":{"id":66964301,"name":"integration_tests","full_name":"mshriver/integration_tests","owner":{"login":"mshriver","id":21315076,"avatar_url":"https://avatars3.githubusercontent.com/u/21315076?v=4","gravatar_id":"","url":"https://api.github.com/users/mshriver","html_url":"https://github.com/mshriver","followers_url":"https://api.github.com/users/mshriver/followers","following_url":"https://api.github.com/users/mshriver/following{/other_user}","gists_url":"https://api.github.com/users/mshriver/gists{/gist_id}","starred_url":"https://api.github.com/users/mshriver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mshriver/subscriptions","organizations_url":"https://api.github.com/users/mshriver/orgs","repos_url":"https://api.github.com/users/mshriver/repos","events_url":"https://api.github.com/users/mshriver/events{/privacy}","received_events_url":"https://api.github.com/users/mshriver/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mshriver/integration_tests","description":"ManageIQ integration tests","fork":true,"url":"https://api.github.com/repos/mshriver/integration_tests","forks_url":"https://api.github.com/repos/mshriver/integration_tests/forks","keys_url":"https://api.github.com/repos/mshriver/integration_tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mshriver/integration_tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mshriver/integration_tests/teams","hooks_url":"https://api.github.com/repos/mshriver/integration_tests/hooks","issue_events_url":"https://api.github.com/repos/mshriver/integration_tests/issues/events{/number}","events_url":"https://api.github.com/repos/mshriver/integration_tests/events","assignees_url":"https://api.github.com/repos/mshriver/integration_tests/assignees{/user}","branches_url":"https://api.github.com/repos/mshriver/integration_tests/branches{/branch}","tags_url":"https://api.github.com/repos/mshriver/integration_tests/tags","blobs_url":"https://api.github.com/repos/mshriver/integration_tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mshriver/integration_tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mshriver/integration_tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/mshriver/integration_tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mshriver/integration_tests/statuses/{sha}","languages_url":"https://api.github.com/repos/mshriver/integration_tests/languages","stargazers_url":"https://api.github.com/repos/mshriver/integration_tests/stargazers","contributors_url":"https://api.github.com/repos/mshriver/integration_tests/contributors","subscribers_url":"https://api.github.com/repos/mshriver/integration_tests/subscribers","subscription_url":"https://api.github.com/repos/mshriver/integration_tests/subscription","commits_url":"https://api.github.com/repos/mshriver/integration_tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/mshriver/integration_tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/mshriver/integration_tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/mshriver/integration_tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/mshriver/integration_tests/contents/{+path}","compare_url":"https://api.github.com/repos/mshriver/integration_tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mshriver/integration_tests/merges","archive_url":"https://api.github.com/repos/mshriver/integration_tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mshriver/integration_tests/downloads","issues_url":"https://api.github.com/repos/mshriver/integration_tests/issues{/number}","pulls_url":"https://api.github.com/repos/mshriver/integration_tests/pulls{/number}","milestones_url":"https://api.github.com/repos/mshriver/integration_tests/milestones{/number}","notifications_url":"https://api.github.com/repos/mshriver/integration_tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mshriver/integration_tests/labels{/name}","releases_url":"https://api.github.com/repos/mshriver/integration_tests/releases{/id}","deployments_url":"https://api.github.com/repos/mshriver/integration_tests/deployments","created_at":"2016-08-30T17:50:47Z","updated_at":"2018-03-20T16:31:13Z","pushed_at":"2018-03-20T19:50:19Z","git_url":"git://github.com/mshriver/integration_tests.git","ssh_url":"git@github.com:mshriver/integration_tests.git","clone_url":"https://github.com/mshriver/integration_tests.git","svn_url":"https://github.com/mshriver/integration_tests","homepage":"","size":25092,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"a5cdb48d7d9b66c1d975254288af7cef14d152f0","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars0.githubusercontent.com/u/1125575?v=4","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":8061086,"name":"integration_tests","full_name":"ManageIQ/integration_tests","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars0.githubusercontent.com/u/1125575?v=4","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/integration_tests","description":"ManageIQ integration tests","fork":false,"url":"https://api.github.com/repos/ManageIQ/integration_tests","forks_url":"https://api.github.com/repos/ManageIQ/integration_tests/forks","keys_url":"https://api.github.com/repos/ManageIQ/integration_tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/integration_tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/integration_tests/teams","hooks_url":"https://api.github.com/repos/ManageIQ/integration_tests/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/integration_tests/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/integration_tests/events","assignees_url":"https://api.github.com/repos/ManageIQ/integration_tests/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/integration_tests/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/integration_tests/tags","blobs_url":"https://api.github.com/repos/ManageIQ/integration_tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/integration_tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/integration_tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/integration_tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/integration_tests/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/integration_tests/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/integration_tests/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/integration_tests/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/integration_tests/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/integration_tests/subscription","commits_url":"https://api.github.com/repos/ManageIQ/integration_tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/integration_tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/integration_tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/integration_tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/integration_tests/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/integration_tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/integration_tests/merges","archive_url":"https://api.github.com/repos/ManageIQ/integration_tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/integration_tests/downloads","issues_url":"https://api.github.com/repos/ManageIQ/integration_tests/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/integration_tests/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/integration_tests/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/integration_tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/integration_tests/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/integration_tests/releases{/id}","deployments_url":"https://api.github.com/repos/ManageIQ/integration_tests/deployments","created_at":"2013-02-06T21:59:17Z","updated_at":"2018-03-20T18:02:40Z","pushed_at":"2018-03-20T19:50:21Z","git_url":"git://github.com/ManageIQ/integration_tests.git","ssh_url":"git@github.com:ManageIQ/integration_tests.git","clone_url":"https://github.com/ManageIQ/integration_tests.git","svn_url":"https://github.com/ManageIQ/integration_tests","homepage":"","size":24732,"stargazers_count":56,"watchers_count":56,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":121,"mirror_url":null,"archived":false,"open_issues_count":163,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":121,"open_issues":163,"watchers":56,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/6929"},"html":{"href":"https://github.com/ManageIQ/integration_tests/pull/6929"},"issue":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/issues/6929"},"comments":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/issues/6929/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/6929/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/pulls/6929/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/integration_tests/statuses/20fa867f69b6dc121e1f2adc1322267a3515b022"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"mshriver"}}