{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/installer/pulls/comments/223505774","pull_request_review_id":162650402,"id":223505774,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzUwNTc3NA==","diff_hunk":"@@ -25,6 +33,41 @@ func (s *StoreImpl) Fetch(asset Asset) error {\n \treturn s.fetch(asset, \"\")\n }\n \n+// Load retrieves the state from the state file present in the given directory\n+// and returns the assets map\n+func (s *StoreImpl) Load(dir string) error {","path":"pkg/asset/store.go","position":null,"original_position":37,"commit_id":"7a63bf995f5c32980a7ee6c75423fa71dbd36b61","original_commit_id":"1ae330b982112f34a7a2e6bfff92e3487bfd0b9e","user":{"login":"abhinavdahiya","id":3481311,"node_id":"MDQ6VXNlcjM0ODEzMTE=","avatar_url":"https://avatars2.githubusercontent.com/u/3481311?v=4","gravatar_id":"","url":"https://api.github.com/users/abhinavdahiya","html_url":"https://github.com/abhinavdahiya","followers_url":"https://api.github.com/users/abhinavdahiya/followers","following_url":"https://api.github.com/users/abhinavdahiya/following{/other_user}","gists_url":"https://api.github.com/users/abhinavdahiya/gists{/gist_id}","starred_url":"https://api.github.com/users/abhinavdahiya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhinavdahiya/subscriptions","organizations_url":"https://api.github.com/users/abhinavdahiya/orgs","repos_url":"https://api.github.com/users/abhinavdahiya/repos","events_url":"https://api.github.com/users/abhinavdahiya/events{/privacy}","received_events_url":"https://api.github.com/users/abhinavdahiya/received_events","type":"User","site_admin":false},"body":"this function doesn't seem to be doing anything ? it loads the state where ?","created_at":"2018-10-08T21:45:05Z","updated_at":"2018-10-08T21:45:05Z","html_url":"https://github.com/openshift/installer/pull/388#discussion_r223505774","pull_request_url":"https://api.github.com/repos/openshift/installer/pulls/388","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/openshift/installer/pulls/comments/223505774"},"html":{"href":"https://github.com/openshift/installer/pull/388#discussion_r223505774"},"pull_request":{"href":"https://api.github.com/repos/openshift/installer/pulls/388"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/installer/pulls/388","id":219534679,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5NTM0Njc5","html_url":"https://github.com/openshift/installer/pull/388","diff_url":"https://github.com/openshift/installer/pull/388.diff","patch_url":"https://github.com/openshift/installer/pull/388.patch","issue_url":"https://api.github.com/repos/openshift/installer/issues/388","number":388,"state":"open","locked":false,"title":"Save assets in a state file on disk","user":{"login":"rajatchopra","id":982221,"node_id":"MDQ6VXNlcjk4MjIyMQ==","avatar_url":"https://avatars2.githubusercontent.com/u/982221?v=4","gravatar_id":"","url":"https://api.github.com/users/rajatchopra","html_url":"https://github.com/rajatchopra","followers_url":"https://api.github.com/users/rajatchopra/followers","following_url":"https://api.github.com/users/rajatchopra/following{/other_user}","gists_url":"https://api.github.com/users/rajatchopra/gists{/gist_id}","starred_url":"https://api.github.com/users/rajatchopra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajatchopra/subscriptions","organizations_url":"https://api.github.com/users/rajatchopra/orgs","repos_url":"https://api.github.com/users/rajatchopra/repos","events_url":"https://api.github.com/users/rajatchopra/events{/privacy}","received_events_url":"https://api.github.com/users/rajatchopra/received_events","type":"User","site_admin":false},"body":"pkg/asset:\r\n\r\nImplement new funtions Save/Load for saving and loading the asset states\r\n\r\ncmd/openshift-install:\r\n\r\nCall out on the Save function to persist the state file of all assets in a constant state file","created_at":"2018-10-01T22:26:49Z","updated_at":"2018-10-08T21:45:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"809185e83447c30eda243d778a30a7e5f19f57bc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":959732229,"node_id":"MDU6TGFiZWw5NTk3MzIyMjk=","url":"https://api.github.com/repos/openshift/installer/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":959732835,"node_id":"MDU6TGFiZWw5NTk3MzI4MzU=","url":"https://api.github.com/repos/openshift/installer/labels/size/L","name":"size/L","color":"ee9900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/installer/pulls/388/commits","review_comments_url":"https://api.github.com/repos/openshift/installer/pulls/388/comments","review_comment_url":"https://api.github.com/repos/openshift/installer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/installer/issues/388/comments","statuses_url":"https://api.github.com/repos/openshift/installer/statuses/7a63bf995f5c32980a7ee6c75423fa71dbd36b61","head":{"label":"rajatchopra:state_file","ref":"state_file","sha":"7a63bf995f5c32980a7ee6c75423fa71dbd36b61","user":{"login":"rajatchopra","id":982221,"node_id":"MDQ6VXNlcjk4MjIyMQ==","avatar_url":"https://avatars2.githubusercontent.com/u/982221?v=4","gravatar_id":"","url":"https://api.github.com/users/rajatchopra","html_url":"https://github.com/rajatchopra","followers_url":"https://api.github.com/users/rajatchopra/followers","following_url":"https://api.github.com/users/rajatchopra/following{/other_user}","gists_url":"https://api.github.com/users/rajatchopra/gists{/gist_id}","starred_url":"https://api.github.com/users/rajatchopra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajatchopra/subscriptions","organizations_url":"https://api.github.com/users/rajatchopra/orgs","repos_url":"https://api.github.com/users/rajatchopra/repos","events_url":"https://api.github.com/users/rajatchopra/events{/privacy}","received_events_url":"https://api.github.com/users/rajatchopra/received_events","type":"User","site_admin":false},"repo":{"id":143057825,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMwNTc4MjU=","name":"installer","full_name":"rajatchopra/installer","private":false,"owner":{"login":"rajatchopra","id":982221,"node_id":"MDQ6VXNlcjk4MjIyMQ==","avatar_url":"https://avatars2.githubusercontent.com/u/982221?v=4","gravatar_id":"","url":"https://api.github.com/users/rajatchopra","html_url":"https://github.com/rajatchopra","followers_url":"https://api.github.com/users/rajatchopra/followers","following_url":"https://api.github.com/users/rajatchopra/following{/other_user}","gists_url":"https://api.github.com/users/rajatchopra/gists{/gist_id}","starred_url":"https://api.github.com/users/rajatchopra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajatchopra/subscriptions","organizations_url":"https://api.github.com/users/rajatchopra/orgs","repos_url":"https://api.github.com/users/rajatchopra/repos","events_url":"https://api.github.com/users/rajatchopra/events{/privacy}","received_events_url":"https://api.github.com/users/rajatchopra/received_events","type":"User","site_admin":false},"html_url":"https://github.com/rajatchopra/installer","description":"Install an OpenShift cluster","fork":true,"url":"https://api.github.com/repos/rajatchopra/installer","forks_url":"https://api.github.com/repos/rajatchopra/installer/forks","keys_url":"https://api.github.com/repos/rajatchopra/installer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rajatchopra/installer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rajatchopra/installer/teams","hooks_url":"https://api.github.com/repos/rajatchopra/installer/hooks","issue_events_url":"https://api.github.com/repos/rajatchopra/installer/issues/events{/number}","events_url":"https://api.github.com/repos/rajatchopra/installer/events","assignees_url":"https://api.github.com/repos/rajatchopra/installer/assignees{/user}","branches_url":"https://api.github.com/repos/rajatchopra/installer/branches{/branch}","tags_url":"https://api.github.com/repos/rajatchopra/installer/tags","blobs_url":"https://api.github.com/repos/rajatchopra/installer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rajatchopra/installer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rajatchopra/installer/git/refs{/sha}","trees_url":"https://api.github.com/repos/rajatchopra/installer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rajatchopra/installer/statuses/{sha}","languages_url":"https://api.github.com/repos/rajatchopra/installer/languages","stargazers_url":"https://api.github.com/repos/rajatchopra/installer/stargazers","contributors_url":"https://api.github.com/repos/rajatchopra/installer/contributors","subscribers_url":"https://api.github.com/repos/rajatchopra/installer/subscribers","subscription_url":"https://api.github.com/repos/rajatchopra/installer/subscription","commits_url":"https://api.github.com/repos/rajatchopra/installer/commits{/sha}","git_commits_url":"https://api.github.com/repos/rajatchopra/installer/git/commits{/sha}","comments_url":"https://api.github.com/repos/rajatchopra/installer/comments{/number}","issue_comment_url":"https://api.github.com/repos/rajatchopra/installer/issues/comments{/number}","contents_url":"https://api.github.com/repos/rajatchopra/installer/contents/{+path}","compare_url":"https://api.github.com/repos/rajatchopra/installer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rajatchopra/installer/merges","archive_url":"https://api.github.com/repos/rajatchopra/installer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rajatchopra/installer/downloads","issues_url":"https://api.github.com/repos/rajatchopra/installer/issues{/number}","pulls_url":"https://api.github.com/repos/rajatchopra/installer/pulls{/number}","milestones_url":"https://api.github.com/repos/rajatchopra/installer/milestones{/number}","notifications_url":"https://api.github.com/repos/rajatchopra/installer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rajatchopra/installer/labels{/name}","releases_url":"https://api.github.com/repos/rajatchopra/installer/releases{/id}","deployments_url":"https://api.github.com/repos/rajatchopra/installer/deployments","created_at":"2018-07-31T19:24:28Z","updated_at":"2018-08-10T23:29:03Z","pushed_at":"2018-10-08T21:26:28Z","git_url":"git://github.com/rajatchopra/installer.git","ssh_url":"git@github.com:rajatchopra/installer.git","clone_url":"https://github.com/rajatchopra/installer.git","svn_url":"https://github.com/rajatchopra/installer","homepage":"","size":40615,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"c0331204949479b41010ff7553297075a777bc2a","user":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":136633680,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY2MzM2ODA=","name":"installer","full_name":"openshift/installer","private":false,"owner":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/openshift/installer","description":"Install an OpenShift cluster","fork":false,"url":"https://api.github.com/repos/openshift/installer","forks_url":"https://api.github.com/repos/openshift/installer/forks","keys_url":"https://api.github.com/repos/openshift/installer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/installer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/installer/teams","hooks_url":"https://api.github.com/repos/openshift/installer/hooks","issue_events_url":"https://api.github.com/repos/openshift/installer/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/installer/events","assignees_url":"https://api.github.com/repos/openshift/installer/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/installer/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/installer/tags","blobs_url":"https://api.github.com/repos/openshift/installer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/installer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/installer/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/installer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/installer/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/installer/languages","stargazers_url":"https://api.github.com/repos/openshift/installer/stargazers","contributors_url":"https://api.github.com/repos/openshift/installer/contributors","subscribers_url":"https://api.github.com/repos/openshift/installer/subscribers","subscription_url":"https://api.github.com/repos/openshift/installer/subscription","commits_url":"https://api.github.com/repos/openshift/installer/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/installer/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/installer/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/installer/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/installer/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/installer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/installer/merges","archive_url":"https://api.github.com/repos/openshift/installer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/installer/downloads","issues_url":"https://api.github.com/repos/openshift/installer/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/installer/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/installer/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/installer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/installer/labels{/name}","releases_url":"https://api.github.com/repos/openshift/installer/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/installer/deployments","created_at":"2018-06-08T15:04:41Z","updated_at":"2018-10-08T20:29:32Z","pushed_at":"2018-10-08T21:26:29Z","git_url":"git://github.com/openshift/installer.git","ssh_url":"git@github.com:openshift/installer.git","clone_url":"https://github.com/openshift/installer.git","svn_url":"https://github.com/openshift/installer","homepage":"","size":40588,"stargazers_count":66,"watchers_count":66,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":68,"mirror_url":null,"archived":false,"open_issues_count":34,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":68,"open_issues":34,"watchers":66,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/installer/pulls/388"},"html":{"href":"https://github.com/openshift/installer/pull/388"},"issue":{"href":"https://api.github.com/repos/openshift/installer/issues/388"},"comments":{"href":"https://api.github.com/repos/openshift/installer/issues/388/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/installer/pulls/388/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/installer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/installer/pulls/388/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/installer/statuses/7a63bf995f5c32980a7ee6c75423fa71dbd36b61"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"abhinavdahiya"}}