{"action":"created","issue":{"url":"https://api.github.com/repos/rust-lang/rust/issues/55093","repository_url":"https://api.github.com/repos/rust-lang/rust","labels_url":"https://api.github.com/repos/rust-lang/rust/issues/55093/labels{/name}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/55093/comments","events_url":"https://api.github.com/repos/rust-lang/rust/issues/55093/events","html_url":"https://github.com/rust-lang/rust/pull/55093","id":370153759,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyODk4NzAz","number":55093,"title":"nll type annotations in multisegment path","user":{"login":"nikomatsakis","id":155238,"node_id":"MDQ6VXNlcjE1NTIzOA==","avatar_url":"https://avatars0.githubusercontent.com/u/155238?v=4","gravatar_id":"","url":"https://api.github.com/users/nikomatsakis","html_url":"https://github.com/nikomatsakis","followers_url":"https://api.github.com/users/nikomatsakis/followers","following_url":"https://api.github.com/users/nikomatsakis/following{/other_user}","gists_url":"https://api.github.com/users/nikomatsakis/gists{/gist_id}","starred_url":"https://api.github.com/users/nikomatsakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikomatsakis/subscriptions","organizations_url":"https://api.github.com/users/nikomatsakis/orgs","repos_url":"https://api.github.com/users/nikomatsakis/repos","events_url":"https://api.github.com/users/nikomatsakis/events{/privacy}","received_events_url":"https://api.github.com/users/nikomatsakis/received_events","type":"User","site_admin":false},"labels":[{"id":583426710,"node_id":"MDU6TGFiZWw1ODM0MjY3MTA=","url":"https://api.github.com/repos/rust-lang/rust/labels/S-waiting-on-review","name":"S-waiting-on-review","color":"d3dddd","default":false}],"state":"open","locked":false,"assignee":{"login":"matthewjasper","id":20113453,"node_id":"MDQ6VXNlcjIwMTEzNDUz","avatar_url":"https://avatars1.githubusercontent.com/u/20113453?v=4","gravatar_id":"","url":"https://api.github.com/users/matthewjasper","html_url":"https://github.com/matthewjasper","followers_url":"https://api.github.com/users/matthewjasper/followers","following_url":"https://api.github.com/users/matthewjasper/following{/other_user}","gists_url":"https://api.github.com/users/matthewjasper/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewjasper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewjasper/subscriptions","organizations_url":"https://api.github.com/users/matthewjasper/orgs","repos_url":"https://api.github.com/users/matthewjasper/repos","events_url":"https://api.github.com/users/matthewjasper/events{/privacy}","received_events_url":"https://api.github.com/users/matthewjasper/received_events","type":"User","site_admin":false},"assignees":[{"login":"matthewjasper","id":20113453,"node_id":"MDQ6VXNlcjIwMTEzNDUz","avatar_url":"https://avatars1.githubusercontent.com/u/20113453?v=4","gravatar_id":"","url":"https://api.github.com/users/matthewjasper","html_url":"https://github.com/matthewjasper","followers_url":"https://api.github.com/users/matthewjasper/followers","following_url":"https://api.github.com/users/matthewjasper/following{/other_user}","gists_url":"https://api.github.com/users/matthewjasper/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewjasper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewjasper/subscriptions","organizations_url":"https://api.github.com/users/matthewjasper/orgs","repos_url":"https://api.github.com/users/matthewjasper/repos","events_url":"https://api.github.com/users/matthewjasper/events{/privacy}","received_events_url":"https://api.github.com/users/matthewjasper/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2018-10-15T13:05:13Z","updated_at":"2018-10-16T14:50:41Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/55093","html_url":"https://github.com/rust-lang/rust/pull/55093","diff_url":"https://github.com/rust-lang/rust/pull/55093.diff","patch_url":"https://github.com/rust-lang/rust/pull/55093.patch"},"body":"This turned out to be sort of tricky. The problem is that if you have a path like\r\n\r\n```\r\n<Foo<&'static u32>>::bar\r\n```\r\n\r\nand it comes from an impl like `impl<T> Foo<T>` then the self-type the user gave doesn't *directly* map to the substitutions that the impl wants. To handle this, then, we have to preserve not just the \"user-given substs\" we used to do, but also a \"user-given self-ty\", which we have to apply later. This PR makes those changes.\r\n\r\nIt also removes the code from NLL relate-ops that handled canonical variables and moves to use normal inference variables instead. This simplifies a few things and gives us a bit more flexibility (for example, I predict we are going to have to start normalizing at some point, and it would be easy now).\r\n\r\nr? @matthewjasper -- you were just touching this code, do you feel comfortable reviewing this?\r\n\r\nFixes #54574 "},"comment":{"url":"https://api.github.com/repos/rust-lang/rust/issues/comments/430268163","html_url":"https://github.com/rust-lang/rust/pull/55093#issuecomment-430268163","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/55093","id":430268163,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMDI2ODE2Mw==","user":{"login":"nikomatsakis","id":155238,"node_id":"MDQ6VXNlcjE1NTIzOA==","avatar_url":"https://avatars0.githubusercontent.com/u/155238?v=4","gravatar_id":"","url":"https://api.github.com/users/nikomatsakis","html_url":"https://github.com/nikomatsakis","followers_url":"https://api.github.com/users/nikomatsakis/followers","following_url":"https://api.github.com/users/nikomatsakis/following{/other_user}","gists_url":"https://api.github.com/users/nikomatsakis/gists{/gist_id}","starred_url":"https://api.github.com/users/nikomatsakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikomatsakis/subscriptions","organizations_url":"https://api.github.com/users/nikomatsakis/orgs","repos_url":"https://api.github.com/users/nikomatsakis/repos","events_url":"https://api.github.com/users/nikomatsakis/events{/privacy}","received_events_url":"https://api.github.com/users/nikomatsakis/received_events","type":"User","site_admin":false},"created_at":"2018-10-16T14:50:41Z","updated_at":"2018-10-16T14:50:41Z","author_association":"CONTRIBUTOR","body":"r? @pnkfelix "}}
{"actor":{"display_login":"nikomatsakis"}}