{"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/243303250","pull_request_review_id":187036911,"id":243303250,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MzMwMzI1MA==","diff_hunk":"@@ -36,22 +36,25 @@ with python'.pkgs;\n \n buildPythonApplication rec {\n   pname = \"FlexGet\";\n-  version = \"2.17.14\";\n+  version = \"2.17.20\";\n \n   src = fetchPypi {\n     inherit pname version;\n-    sha256 = \"1wh12nspjzsgb0a7qp67s4k8wssbhhf500s8x8mx2smb1mgy4xzz\";\n+    sha256 = \"1hw16rn3wsc3adkx5ja16cxc9ic7jv2hhkcbxfb7wkym5r4gk7m0\";\n   };\n \n   postPatch = ''\n     # remove dependency constraints\n     sed 's/==\\([0-9]\\.\\?\\)\\+//' -i requirements.txt\n+    # Set python to 3.6\n+    sed -i -e 's/py27/py36/g' setup.cfg\n   '';\n \n   # ~400 failures\n   doCheck = false;\n \n   propagatedBuildInputs = [\n+    python27","path":"pkgs/applications/networking/flexget/default.nix","position":39,"original_position":39,"commit_id":"828eb2c2a621fdd1f4f301e0868698d182993cab","original_commit_id":"828eb2c2a621fdd1f4f301e0868698d182993cab","user":{"login":"sjau","id":848812,"node_id":"MDQ6VXNlcjg0ODgxMg==","avatar_url":"https://avatars0.githubusercontent.com/u/848812?v=4","gravatar_id":"","url":"https://api.github.com/users/sjau","html_url":"https://github.com/sjau","followers_url":"https://api.github.com/users/sjau/followers","following_url":"https://api.github.com/users/sjau/following{/other_user}","gists_url":"https://api.github.com/users/sjau/gists{/gist_id}","starred_url":"https://api.github.com/users/sjau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjau/subscriptions","organizations_url":"https://api.github.com/users/sjau/orgs","repos_url":"https://api.github.com/users/sjau/repos","events_url":"https://api.github.com/users/sjau/events{/privacy}","received_events_url":"https://api.github.com/users/sjau/received_events","type":"User","site_admin":false},"body":"try to build it without. Then try to build it with it. I don't speak python. I'm just a user of flexget.","created_at":"2018-12-20T15:04:37Z","updated_at":"2018-12-20T15:04:37Z","html_url":"https://github.com/NixOS/nixpkgs/pull/52529#discussion_r243303250","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/52529","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/243303250"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/52529#discussion_r243303250"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/52529"}},"in_reply_to_id":242973402},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/52529","id":239887578,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5ODg3NTc4","html_url":"https://github.com/NixOS/nixpkgs/pull/52529","diff_url":"https://github.com/NixOS/nixpkgs/pull/52529.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/52529.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/52529","number":52529,"state":"open","locked":false,"title":"Flexget: 2.17.14 -> 2.17.20 & Python: 2.7 -> 3.6","user":{"login":"sjau","id":848812,"node_id":"MDQ6VXNlcjg0ODgxMg==","avatar_url":"https://avatars0.githubusercontent.com/u/848812?v=4","gravatar_id":"","url":"https://api.github.com/users/sjau","html_url":"https://github.com/sjau","followers_url":"https://api.github.com/users/sjau/followers","following_url":"https://api.github.com/users/sjau/following{/other_user}","gists_url":"https://api.github.com/users/sjau/gists{/gist_id}","starred_url":"https://api.github.com/users/sjau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjau/subscriptions","organizations_url":"https://api.github.com/users/sjau/orgs","repos_url":"https://api.github.com/users/sjau/repos","events_url":"https://api.github.com/users/sjau/events{/privacy}","received_events_url":"https://api.github.com/users/sjau/received_events","type":"User","site_admin":false},"body":"###### Motivation for this change\r\n\r\nFlexget fails on current master because of Cherrypy for python 2.7, so updated flexget to using python 3.6 and updated it to v2.17.20\r\n\r\n###### Things done\r\n\r\n<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->\r\n\r\n- [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)\r\n- Built on platform(s)\r\n   - [x] NixOS\r\n   - [ ] macOS\r\n   - [ ] other Linux distributions\r\n- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [ ] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)\r\n- [ ] Assured whether relevant documentation is up to date\r\n- [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n","created_at":"2018-12-19T16:00:13Z","updated_at":"2018-12-20T15:04:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"12d0d83d23aa74d1e09811d7be56f8a0292e24eb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":731735222,"node_id":"MDU6TGFiZWw3MzE3MzUyMjI=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-darwin:%201-10","name":"10.rebuild-darwin: 1-10","color":"eeffee","default":false},{"id":731733923,"node_id":"MDU6TGFiZWw3MzE3MzM5MjM=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-linux:%201-10","name":"10.rebuild-linux: 1-10","color":"eeffee","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/52529/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/52529/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/52529/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/828eb2c2a621fdd1f4f301e0868698d182993cab","head":{"label":"sjau:flexget_2.17.20","ref":"flexget_2.17.20","sha":"828eb2c2a621fdd1f4f301e0868698d182993cab","user":{"login":"sjau","id":848812,"node_id":"MDQ6VXNlcjg0ODgxMg==","avatar_url":"https://avatars0.githubusercontent.com/u/848812?v=4","gravatar_id":"","url":"https://api.github.com/users/sjau","html_url":"https://github.com/sjau","followers_url":"https://api.github.com/users/sjau/followers","following_url":"https://api.github.com/users/sjau/following{/other_user}","gists_url":"https://api.github.com/users/sjau/gists{/gist_id}","starred_url":"https://api.github.com/users/sjau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjau/subscriptions","organizations_url":"https://api.github.com/users/sjau/orgs","repos_url":"https://api.github.com/users/sjau/repos","events_url":"https://api.github.com/users/sjau/events{/privacy}","received_events_url":"https://api.github.com/users/sjau/received_events","type":"User","site_admin":false},"repo":{"id":152031295,"node_id":"MDEwOlJlcG9zaXRvcnkxNTIwMzEyOTU=","name":"nixpkgs","full_name":"sjau/nixpkgs","private":false,"owner":{"login":"sjau","id":848812,"node_id":"MDQ6VXNlcjg0ODgxMg==","avatar_url":"https://avatars0.githubusercontent.com/u/848812?v=4","gravatar_id":"","url":"https://api.github.com/users/sjau","html_url":"https://github.com/sjau","followers_url":"https://api.github.com/users/sjau/followers","following_url":"https://api.github.com/users/sjau/following{/other_user}","gists_url":"https://api.github.com/users/sjau/gists{/gist_id}","starred_url":"https://api.github.com/users/sjau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjau/subscriptions","organizations_url":"https://api.github.com/users/sjau/orgs","repos_url":"https://api.github.com/users/sjau/repos","events_url":"https://api.github.com/users/sjau/events{/privacy}","received_events_url":"https://api.github.com/users/sjau/received_events","type":"User","site_admin":false},"html_url":"https://github.com/sjau/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/sjau/nixpkgs","forks_url":"https://api.github.com/repos/sjau/nixpkgs/forks","keys_url":"https://api.github.com/repos/sjau/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sjau/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sjau/nixpkgs/teams","hooks_url":"https://api.github.com/repos/sjau/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/sjau/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/sjau/nixpkgs/events","assignees_url":"https://api.github.com/repos/sjau/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/sjau/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/sjau/nixpkgs/tags","blobs_url":"https://api.github.com/repos/sjau/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sjau/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sjau/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/sjau/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sjau/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/sjau/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/sjau/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/sjau/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/sjau/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/sjau/nixpkgs/subscription","commits_url":"https://api.github.com/repos/sjau/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/sjau/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/sjau/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/sjau/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/sjau/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/sjau/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sjau/nixpkgs/merges","archive_url":"https://api.github.com/repos/sjau/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sjau/nixpkgs/downloads","issues_url":"https://api.github.com/repos/sjau/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/sjau/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/sjau/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/sjau/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sjau/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/sjau/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/sjau/nixpkgs/deployments","created_at":"2018-10-08T06:47:50Z","updated_at":"2018-12-19T15:59:35Z","pushed_at":"2018-12-19T15:58:39Z","git_url":"git://github.com/sjau/nixpkgs.git","ssh_url":"git@github.com:sjau/nixpkgs.git","clone_url":"https://github.com/sjau/nixpkgs.git","svn_url":"https://github.com/sjau/nixpkgs","homepage":null,"size":890499,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"b7355e6f7a03623dc10858e9ddcc74bf9637792c","user":{"login":"NixOS","id":487568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzU2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"node_id":"MDEwOlJlcG9zaXRvcnk0NTQyNzE2","name":"nixpkgs","full_name":"NixOS/nixpkgs","private":false,"owner":{"login":"NixOS","id":487568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzU2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2018-12-20T14:53:57Z","pushed_at":"2018-12-20T14:58:04Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":903505,"stargazers_count":3110,"watchers_count":3110,"language":"Nix","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3262,"mirror_url":null,"archived":false,"open_issues_count":3413,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":3262,"open_issues":3413,"watchers":3110,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/52529"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/52529"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/52529"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/52529/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/52529/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/52529/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/828eb2c2a621fdd1f4f301e0868698d182993cab"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"sjau"}}