{"action":"created","comment":{"url":"https://api.github.com/repos/cerner/terra-framework/pulls/comments/196194851","pull_request_review_id":129643909,"id":196194851,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NjE5NDg1MQ==","diff_hunk":"@@ -0,0 +1,78 @@\n+# Terra Dialog Modal\n+\n+The Dialog Modal would allow for dynamic height modals. Dialog modal would be a limited use case, as dynamic heights breaks with more complicated DOM structures. If content is too complicated, the terra-modal-manager should be used. The components is placed at an 8000 z-index. The dialog supports release and request focus props similar to terra-popup and terra-date-picker, so it can be presented from another modal with focus.","path":"packages/terra-dialog-modal/docs/README.md","position":3,"original_position":3,"commit_id":"a0a0a9d3b8ef269abf12552275baf81280b23efe","original_commit_id":"a0a0a9d3b8ef269abf12552275baf81280b23efe","user":{"login":"Blackop778","id":11130785,"node_id":"MDQ6VXNlcjExMTMwNzg1","avatar_url":"https://avatars3.githubusercontent.com/u/11130785?v=4","gravatar_id":"","url":"https://api.github.com/users/Blackop778","html_url":"https://github.com/Blackop778","followers_url":"https://api.github.com/users/Blackop778/followers","following_url":"https://api.github.com/users/Blackop778/following{/other_user}","gists_url":"https://api.github.com/users/Blackop778/gists{/gist_id}","starred_url":"https://api.github.com/users/Blackop778/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Blackop778/subscriptions","organizations_url":"https://api.github.com/users/Blackop778/orgs","repos_url":"https://api.github.com/users/Blackop778/repos","events_url":"https://api.github.com/users/Blackop778/events{/privacy}","received_events_url":"https://api.github.com/users/Blackop778/received_events","type":"User","site_admin":false},"body":"nit: Don't use future tense to describe what the component does.","created_at":"2018-06-18T19:20:36Z","updated_at":"2018-06-18T19:23:53Z","html_url":"https://github.com/cerner/terra-framework/pull/178#discussion_r196194851","pull_request_url":"https://api.github.com/repos/cerner/terra-framework/pulls/178","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/cerner/terra-framework/pulls/comments/196194851"},"html":{"href":"https://github.com/cerner/terra-framework/pull/178#discussion_r196194851"},"pull_request":{"href":"https://api.github.com/repos/cerner/terra-framework/pulls/178"}}},"pull_request":{"url":"https://api.github.com/repos/cerner/terra-framework/pulls/178","id":187296527,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg3Mjk2NTI3","html_url":"https://github.com/cerner/terra-framework/pull/178","diff_url":"https://github.com/cerner/terra-framework/pull/178.diff","patch_url":"https://github.com/cerner/terra-framework/pull/178.patch","issue_url":"https://api.github.com/repos/cerner/terra-framework/issues/178","number":178,"state":"open","locked":false,"title":"Create Dialog modal","user":{"login":"rakshith91","id":14154054,"node_id":"MDQ6VXNlcjE0MTU0MDU0","avatar_url":"https://avatars1.githubusercontent.com/u/14154054?v=4","gravatar_id":"","url":"https://api.github.com/users/rakshith91","html_url":"https://github.com/rakshith91","followers_url":"https://api.github.com/users/rakshith91/followers","following_url":"https://api.github.com/users/rakshith91/following{/other_user}","gists_url":"https://api.github.com/users/rakshith91/gists{/gist_id}","starred_url":"https://api.github.com/users/rakshith91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rakshith91/subscriptions","organizations_url":"https://api.github.com/users/rakshith91/orgs","repos_url":"https://api.github.com/users/rakshith91/repos","events_url":"https://api.github.com/users/rakshith91/events{/privacy}","received_events_url":"https://api.github.com/users/rakshith91/received_events","type":"User","site_admin":false},"body":"### Summary\r\nThe Dialog Modal would allow for dynamic height modals. Dialog modal would be a limited use case, as dynamic heights breaks with more complicated DOM structures. If content is too complicated, the terra-modal-manager should be used. The components should be placed above the 6000 z-index, but below the 8000 z-index. The dialog will need to support release and request focus props similar to terra-popup and terra-date-picker, so it can be presented from another modal with focus. The dialog modal will not support popups/date pickers, if those are needed use the terra-modal-manager.\r\n\r\n### Additional Details\r\nResolves #167 \r\n\r\nThanks for contributing to Terra. \r\n@cerner/terra\r\n\r\n### Deployment\r\n- https://terra-framework-deploye-pr-178.herokuapp.com/#/site/components/dialog-modal/index\r\n- https://terra-framework-deploye-pr-178.herokuapp.com/#/tests/dialog-modal\r\n","created_at":"2018-05-10T20:21:12Z","updated_at":"2018-06-18T19:23:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ca08d1bdf37bbafd9d1d470ffce02ed8d5b04ce6","assignee":{"login":"rakshith91","id":14154054,"node_id":"MDQ6VXNlcjE0MTU0MDU0","avatar_url":"https://avatars1.githubusercontent.com/u/14154054?v=4","gravatar_id":"","url":"https://api.github.com/users/rakshith91","html_url":"https://github.com/rakshith91","followers_url":"https://api.github.com/users/rakshith91/followers","following_url":"https://api.github.com/users/rakshith91/following{/other_user}","gists_url":"https://api.github.com/users/rakshith91/gists{/gist_id}","starred_url":"https://api.github.com/users/rakshith91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rakshith91/subscriptions","organizations_url":"https://api.github.com/users/rakshith91/orgs","repos_url":"https://api.github.com/users/rakshith91/repos","events_url":"https://api.github.com/users/rakshith91/events{/privacy}","received_events_url":"https://api.github.com/users/rakshith91/received_events","type":"User","site_admin":false},"assignees":[{"login":"rakshith91","id":14154054,"node_id":"MDQ6VXNlcjE0MTU0MDU0","avatar_url":"https://avatars1.githubusercontent.com/u/14154054?v=4","gravatar_id":"","url":"https://api.github.com/users/rakshith91","html_url":"https://github.com/rakshith91","followers_url":"https://api.github.com/users/rakshith91/followers","following_url":"https://api.github.com/users/rakshith91/following{/other_user}","gists_url":"https://api.github.com/users/rakshith91/gists{/gist_id}","starred_url":"https://api.github.com/users/rakshith91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rakshith91/subscriptions","organizations_url":"https://api.github.com/users/rakshith91/orgs","repos_url":"https://api.github.com/users/rakshith91/repos","events_url":"https://api.github.com/users/rakshith91/events{/privacy}","received_events_url":"https://api.github.com/users/rakshith91/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"JakeLaCombe","id":2552573,"node_id":"MDQ6VXNlcjI1NTI1NzM=","avatar_url":"https://avatars3.githubusercontent.com/u/2552573?v=4","gravatar_id":"","url":"https://api.github.com/users/JakeLaCombe","html_url":"https://github.com/JakeLaCombe","followers_url":"https://api.github.com/users/JakeLaCombe/followers","following_url":"https://api.github.com/users/JakeLaCombe/following{/other_user}","gists_url":"https://api.github.com/users/JakeLaCombe/gists{/gist_id}","starred_url":"https://api.github.com/users/JakeLaCombe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JakeLaCombe/subscriptions","organizations_url":"https://api.github.com/users/JakeLaCombe/orgs","repos_url":"https://api.github.com/users/JakeLaCombe/repos","events_url":"https://api.github.com/users/JakeLaCombe/events{/privacy}","received_events_url":"https://api.github.com/users/JakeLaCombe/received_events","type":"User","site_admin":false},{"login":"ryanthemanuel","id":4873279,"node_id":"MDQ6VXNlcjQ4NzMyNzk=","avatar_url":"https://avatars3.githubusercontent.com/u/4873279?v=4","gravatar_id":"","url":"https://api.github.com/users/ryanthemanuel","html_url":"https://github.com/ryanthemanuel","followers_url":"https://api.github.com/users/ryanthemanuel/followers","following_url":"https://api.github.com/users/ryanthemanuel/following{/other_user}","gists_url":"https://api.github.com/users/ryanthemanuel/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanthemanuel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanthemanuel/subscriptions","organizations_url":"https://api.github.com/users/ryanthemanuel/orgs","repos_url":"https://api.github.com/users/ryanthemanuel/repos","events_url":"https://api.github.com/users/ryanthemanuel/events{/privacy}","received_events_url":"https://api.github.com/users/ryanthemanuel/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":746652831,"node_id":"MDU6TGFiZWw3NDY2NTI4MzE=","url":"https://api.github.com/repos/cerner/terra-framework/labels/Needs%20UX%20review","name":"Needs UX review","color":"d93f0b","default":false},{"id":746652222,"node_id":"MDU6TGFiZWw3NDY2NTIyMjI=","url":"https://api.github.com/repos/cerner/terra-framework/labels/Needs%20functional%20review","name":"Needs functional review","color":"d93f0b","default":false},{"id":918578499,"node_id":"MDU6TGFiZWw5MTg1Nzg0OTk=","url":"https://api.github.com/repos/cerner/terra-framework/labels/dialog-modal","name":"dialog-modal","color":"dbfcae","default":false},{"id":729695080,"node_id":"MDU6TGFiZWw3Mjk2OTUwODA=","url":"https://api.github.com/repos/cerner/terra-framework/labels/new%20feature","name":"new feature","color":"3b47b5","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/cerner/terra-framework/pulls/178/commits","review_comments_url":"https://api.github.com/repos/cerner/terra-framework/pulls/178/comments","review_comment_url":"https://api.github.com/repos/cerner/terra-framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cerner/terra-framework/issues/178/comments","statuses_url":"https://api.github.com/repos/cerner/terra-framework/statuses/a0a0a9d3b8ef269abf12552275baf81280b23efe","head":{"label":"cerner:dialog-modal","ref":"dialog-modal","sha":"a0a0a9d3b8ef269abf12552275baf81280b23efe","user":{"login":"cerner","id":1873208,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NzMyMDg=","avatar_url":"https://avatars1.githubusercontent.com/u/1873208?v=4","gravatar_id":"","url":"https://api.github.com/users/cerner","html_url":"https://github.com/cerner","followers_url":"https://api.github.com/users/cerner/followers","following_url":"https://api.github.com/users/cerner/following{/other_user}","gists_url":"https://api.github.com/users/cerner/gists{/gist_id}","starred_url":"https://api.github.com/users/cerner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cerner/subscriptions","organizations_url":"https://api.github.com/users/cerner/orgs","repos_url":"https://api.github.com/users/cerner/repos","events_url":"https://api.github.com/users/cerner/events{/privacy}","received_events_url":"https://api.github.com/users/cerner/received_events","type":"Organization","site_admin":false},"repo":{"id":107724721,"node_id":"MDEwOlJlcG9zaXRvcnkxMDc3MjQ3MjE=","name":"terra-framework","full_name":"cerner/terra-framework","owner":{"login":"cerner","id":1873208,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NzMyMDg=","avatar_url":"https://avatars1.githubusercontent.com/u/1873208?v=4","gravatar_id":"","url":"https://api.github.com/users/cerner","html_url":"https://github.com/cerner","followers_url":"https://api.github.com/users/cerner/followers","following_url":"https://api.github.com/users/cerner/following{/other_user}","gists_url":"https://api.github.com/users/cerner/gists{/gist_id}","starred_url":"https://api.github.com/users/cerner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cerner/subscriptions","organizations_url":"https://api.github.com/users/cerner/orgs","repos_url":"https://api.github.com/users/cerner/repos","events_url":"https://api.github.com/users/cerner/events{/privacy}","received_events_url":"https://api.github.com/users/cerner/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cerner/terra-framework","description":"Terra framework houses higher order opinionated react components to help developers quickly build out new applications.","fork":false,"url":"https://api.github.com/repos/cerner/terra-framework","forks_url":"https://api.github.com/repos/cerner/terra-framework/forks","keys_url":"https://api.github.com/repos/cerner/terra-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cerner/terra-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cerner/terra-framework/teams","hooks_url":"https://api.github.com/repos/cerner/terra-framework/hooks","issue_events_url":"https://api.github.com/repos/cerner/terra-framework/issues/events{/number}","events_url":"https://api.github.com/repos/cerner/terra-framework/events","assignees_url":"https://api.github.com/repos/cerner/terra-framework/assignees{/user}","branches_url":"https://api.github.com/repos/cerner/terra-framework/branches{/branch}","tags_url":"https://api.github.com/repos/cerner/terra-framework/tags","blobs_url":"https://api.github.com/repos/cerner/terra-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cerner/terra-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cerner/terra-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/cerner/terra-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cerner/terra-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/cerner/terra-framework/languages","stargazers_url":"https://api.github.com/repos/cerner/terra-framework/stargazers","contributors_url":"https://api.github.com/repos/cerner/terra-framework/contributors","subscribers_url":"https://api.github.com/repos/cerner/terra-framework/subscribers","subscription_url":"https://api.github.com/repos/cerner/terra-framework/subscription","commits_url":"https://api.github.com/repos/cerner/terra-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/cerner/terra-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/cerner/terra-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/cerner/terra-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/cerner/terra-framework/contents/{+path}","compare_url":"https://api.github.com/repos/cerner/terra-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cerner/terra-framework/merges","archive_url":"https://api.github.com/repos/cerner/terra-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cerner/terra-framework/downloads","issues_url":"https://api.github.com/repos/cerner/terra-framework/issues{/number}","pulls_url":"https://api.github.com/repos/cerner/terra-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/cerner/terra-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/cerner/terra-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cerner/terra-framework/labels{/name}","releases_url":"https://api.github.com/repos/cerner/terra-framework/releases{/id}","deployments_url":"https://api.github.com/repos/cerner/terra-framework/deployments","created_at":"2017-10-20T20:43:46Z","updated_at":"2018-06-15T18:04:29Z","pushed_at":"2018-06-18T13:12:42Z","git_url":"git://github.com/cerner/terra-framework.git","ssh_url":"git@github.com:cerner/terra-framework.git","clone_url":"https://github.com/cerner/terra-framework.git","svn_url":"https://github.com/cerner/terra-framework","homepage":"http://engineering.cerner.com/terra-framework/","size":22219,"stargazers_count":16,"watchers_count":16,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":25,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":5,"open_issues":25,"watchers":16,"default_branch":"master"}},"base":{"label":"cerner:master","ref":"master","sha":"cccea7df51692ee790bea58d282037cf6e1041ed","user":{"login":"cerner","id":1873208,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NzMyMDg=","avatar_url":"https://avatars1.githubusercontent.com/u/1873208?v=4","gravatar_id":"","url":"https://api.github.com/users/cerner","html_url":"https://github.com/cerner","followers_url":"https://api.github.com/users/cerner/followers","following_url":"https://api.github.com/users/cerner/following{/other_user}","gists_url":"https://api.github.com/users/cerner/gists{/gist_id}","starred_url":"https://api.github.com/users/cerner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cerner/subscriptions","organizations_url":"https://api.github.com/users/cerner/orgs","repos_url":"https://api.github.com/users/cerner/repos","events_url":"https://api.github.com/users/cerner/events{/privacy}","received_events_url":"https://api.github.com/users/cerner/received_events","type":"Organization","site_admin":false},"repo":{"id":107724721,"node_id":"MDEwOlJlcG9zaXRvcnkxMDc3MjQ3MjE=","name":"terra-framework","full_name":"cerner/terra-framework","owner":{"login":"cerner","id":1873208,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NzMyMDg=","avatar_url":"https://avatars1.githubusercontent.com/u/1873208?v=4","gravatar_id":"","url":"https://api.github.com/users/cerner","html_url":"https://github.com/cerner","followers_url":"https://api.github.com/users/cerner/followers","following_url":"https://api.github.com/users/cerner/following{/other_user}","gists_url":"https://api.github.com/users/cerner/gists{/gist_id}","starred_url":"https://api.github.com/users/cerner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cerner/subscriptions","organizations_url":"https://api.github.com/users/cerner/orgs","repos_url":"https://api.github.com/users/cerner/repos","events_url":"https://api.github.com/users/cerner/events{/privacy}","received_events_url":"https://api.github.com/users/cerner/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cerner/terra-framework","description":"Terra framework houses higher order opinionated react components to help developers quickly build out new applications.","fork":false,"url":"https://api.github.com/repos/cerner/terra-framework","forks_url":"https://api.github.com/repos/cerner/terra-framework/forks","keys_url":"https://api.github.com/repos/cerner/terra-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cerner/terra-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cerner/terra-framework/teams","hooks_url":"https://api.github.com/repos/cerner/terra-framework/hooks","issue_events_url":"https://api.github.com/repos/cerner/terra-framework/issues/events{/number}","events_url":"https://api.github.com/repos/cerner/terra-framework/events","assignees_url":"https://api.github.com/repos/cerner/terra-framework/assignees{/user}","branches_url":"https://api.github.com/repos/cerner/terra-framework/branches{/branch}","tags_url":"https://api.github.com/repos/cerner/terra-framework/tags","blobs_url":"https://api.github.com/repos/cerner/terra-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cerner/terra-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cerner/terra-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/cerner/terra-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cerner/terra-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/cerner/terra-framework/languages","stargazers_url":"https://api.github.com/repos/cerner/terra-framework/stargazers","contributors_url":"https://api.github.com/repos/cerner/terra-framework/contributors","subscribers_url":"https://api.github.com/repos/cerner/terra-framework/subscribers","subscription_url":"https://api.github.com/repos/cerner/terra-framework/subscription","commits_url":"https://api.github.com/repos/cerner/terra-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/cerner/terra-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/cerner/terra-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/cerner/terra-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/cerner/terra-framework/contents/{+path}","compare_url":"https://api.github.com/repos/cerner/terra-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cerner/terra-framework/merges","archive_url":"https://api.github.com/repos/cerner/terra-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cerner/terra-framework/downloads","issues_url":"https://api.github.com/repos/cerner/terra-framework/issues{/number}","pulls_url":"https://api.github.com/repos/cerner/terra-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/cerner/terra-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/cerner/terra-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cerner/terra-framework/labels{/name}","releases_url":"https://api.github.com/repos/cerner/terra-framework/releases{/id}","deployments_url":"https://api.github.com/repos/cerner/terra-framework/deployments","created_at":"2017-10-20T20:43:46Z","updated_at":"2018-06-15T18:04:29Z","pushed_at":"2018-06-18T13:12:42Z","git_url":"git://github.com/cerner/terra-framework.git","ssh_url":"git@github.com:cerner/terra-framework.git","clone_url":"https://github.com/cerner/terra-framework.git","svn_url":"https://github.com/cerner/terra-framework","homepage":"http://engineering.cerner.com/terra-framework/","size":22219,"stargazers_count":16,"watchers_count":16,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":25,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":5,"open_issues":25,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cerner/terra-framework/pulls/178"},"html":{"href":"https://github.com/cerner/terra-framework/pull/178"},"issue":{"href":"https://api.github.com/repos/cerner/terra-framework/issues/178"},"comments":{"href":"https://api.github.com/repos/cerner/terra-framework/issues/178/comments"},"review_comments":{"href":"https://api.github.com/repos/cerner/terra-framework/pulls/178/comments"},"review_comment":{"href":"https://api.github.com/repos/cerner/terra-framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cerner/terra-framework/pulls/178/commits"},"statuses":{"href":"https://api.github.com/repos/cerner/terra-framework/statuses/a0a0a9d3b8ef269abf12552275baf81280b23efe"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"Blackop778"}}