{"action":"created","issue":{"url":"https://api.github.com/repos/chapel-lang/chapel/issues/11255","repository_url":"https://api.github.com/repos/chapel-lang/chapel","labels_url":"https://api.github.com/repos/chapel-lang/chapel/issues/11255/labels{/name}","comments_url":"https://api.github.com/repos/chapel-lang/chapel/issues/11255/comments","events_url":"https://api.github.com/repos/chapel-lang/chapel/issues/11255/events","html_url":"https://github.com/chapel-lang/chapel/pull/11255","id":365005680,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5MDU4NTk4","number":11255,"title":"Avoid handling overrides where parent has 'where false'","user":{"login":"mppf","id":3653132,"node_id":"MDQ6VXNlcjM2NTMxMzI=","avatar_url":"https://avatars3.githubusercontent.com/u/3653132?v=4","gravatar_id":"","url":"https://api.github.com/users/mppf","html_url":"https://github.com/mppf","followers_url":"https://api.github.com/users/mppf/followers","following_url":"https://api.github.com/users/mppf/following{/other_user}","gists_url":"https://api.github.com/users/mppf/gists{/gist_id}","starred_url":"https://api.github.com/users/mppf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mppf/subscriptions","organizations_url":"https://api.github.com/users/mppf/orgs","repos_url":"https://api.github.com/users/mppf/repos","events_url":"https://api.github.com/users/mppf/events{/privacy}","received_events_url":"https://api.github.com/users/mppf/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-09-28T19:04:12Z","updated_at":"2018-09-28T20:19:38Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/chapel-lang/chapel/pulls/11255","html_url":"https://github.com/chapel-lang/chapel/pull/11255","diff_url":"https://github.com/chapel-lang/chapel/pull/11255.diff","patch_url":"https://github.com/chapel-lang/chapel/pull/11255.patch"},"body":"This PR helps to solve a problem with override checking that came up when the compiler was adjusted to resolve concrete functions.\r\n\r\nIt adjusts override processing to not consider it an override if the parent function has a `where` clause evaluating to false. Such functions cannot be called so there's no possibility that they'll need to be virtually dispatched. As a result, child functions matching such a parent function should not be considered overrides, subject to override errors, or added to the virtual methods map.\r\n\r\n- [x] passed full local testing"},"comment":{"url":"https://api.github.com/repos/chapel-lang/chapel/issues/comments/425554429","html_url":"https://github.com/chapel-lang/chapel/pull/11255#issuecomment-425554429","issue_url":"https://api.github.com/repos/chapel-lang/chapel/issues/11255","id":425554429,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNTU1NDQyOQ==","user":{"login":"bradcray","id":7536222,"node_id":"MDQ6VXNlcjc1MzYyMjI=","avatar_url":"https://avatars0.githubusercontent.com/u/7536222?v=4","gravatar_id":"","url":"https://api.github.com/users/bradcray","html_url":"https://github.com/bradcray","followers_url":"https://api.github.com/users/bradcray/followers","following_url":"https://api.github.com/users/bradcray/following{/other_user}","gists_url":"https://api.github.com/users/bradcray/gists{/gist_id}","starred_url":"https://api.github.com/users/bradcray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradcray/subscriptions","organizations_url":"https://api.github.com/users/bradcray/orgs","repos_url":"https://api.github.com/users/bradcray/repos","events_url":"https://api.github.com/users/bradcray/events{/privacy}","received_events_url":"https://api.github.com/users/bradcray/received_events","type":"User","site_admin":false},"created_at":"2018-09-28T20:19:38Z","updated_at":"2018-09-28T20:19:38Z","author_association":"MEMBER","body":"This looks good to me!  Just noting for posterity, \"where false\" here doesn't literally mean \"where false\" but more generally \"where <some param expression evaluating to false>\"."}}
{"actor":{"display_login":"bradcray"}}