{"action":"created","comment":{"url":"https://api.github.com/repos/mimblewimble/secp256k1-zkp/pulls/comments/215595099","pull_request_review_id":152891355,"id":215595099,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNTU5NTA5OQ==","diff_hunk":"@@ -29,6 +29,7 @@ void test_aggsig_api(void) {\n     unsigned char sec_nonces[5][32];\n     secp256k1_pubkey pub_nonces[5];\n     unsigned char orig_sig;\n+    unsigned char orig_msg;","path":"src/modules/aggsig/tests_impl.h","position":4,"original_position":4,"commit_id":"bfd194a1683d5b8fb832c2e3a9be3e1ea2e243f3","original_commit_id":"3cc111527af65245b32578a0de3c9f14e08ca34a","user":{"login":"garyyu","id":1852227,"node_id":"MDQ6VXNlcjE4NTIyMjc=","avatar_url":"https://avatars3.githubusercontent.com/u/1852227?v=4","gravatar_id":"","url":"https://api.github.com/users/garyyu","html_url":"https://github.com/garyyu","followers_url":"https://api.github.com/users/garyyu/followers","following_url":"https://api.github.com/users/garyyu/following{/other_user}","gists_url":"https://api.github.com/users/garyyu/gists{/gist_id}","starred_url":"https://api.github.com/users/garyyu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garyyu/subscriptions","organizations_url":"https://api.github.com/users/garyyu/orgs","repos_url":"https://api.github.com/users/garyyu/repos","events_url":"https://api.github.com/users/garyyu/events{/privacy}","received_events_url":"https://api.github.com/users/garyyu/received_events","type":"User","site_admin":false},"body":"OK","created_at":"2018-09-06T11:46:30Z","updated_at":"2018-09-06T11:46:30Z","html_url":"https://github.com/mimblewimble/secp256k1-zkp/pull/22#discussion_r215595099","pull_request_url":"https://api.github.com/repos/mimblewimble/secp256k1-zkp/pulls/22","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mimblewimble/secp256k1-zkp/pulls/comments/215595099"},"html":{"href":"https://github.com/mimblewimble/secp256k1-zkp/pull/22#discussion_r215595099"},"pull_request":{"href":"https://api.github.com/repos/mimblewimble/secp256k1-zkp/pulls/22"}},"in_reply_to_id":215507073},"pull_request":{"url":"https://api.github.com/repos/mimblewimble/secp256k1-zkp/pulls/22","id":210975301,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwOTc1MzAx","html_url":"https://github.com/mimblewimble/secp256k1-zkp/pull/22","diff_url":"https://github.com/mimblewimble/secp256k1-zkp/pull/22.diff","patch_url":"https://github.com/mimblewimble/secp256k1-zkp/pull/22.patch","issue_url":"https://api.github.com/repos/mimblewimble/secp256k1-zkp/issues/22","number":22,"state":"open","locked":false,"title":"[WIP] Add public key to aggsig challenge","user":{"login":"jaspervdm","id":761205,"node_id":"MDQ6VXNlcjc2MTIwNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/761205?v=4","gravatar_id":"","url":"https://api.github.com/users/jaspervdm","html_url":"https://github.com/jaspervdm","followers_url":"https://api.github.com/users/jaspervdm/followers","following_url":"https://api.github.com/users/jaspervdm/following{/other_user}","gists_url":"https://api.github.com/users/jaspervdm/gists{/gist_id}","starred_url":"https://api.github.com/users/jaspervdm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaspervdm/subscriptions","organizations_url":"https://api.github.com/users/jaspervdm/orgs","repos_url":"https://api.github.com/users/jaspervdm/repos","events_url":"https://api.github.com/users/jaspervdm/events{/privacy}","received_events_url":"https://api.github.com/users/jaspervdm/received_events","type":"User","site_admin":false},"body":"Optionally add a public key to the aggsig challenge in both the creation and verification of the signature. Also fixes https://github.com/mimblewimble/secp256k1-zkp/pull/21 and fixes https://github.com/mimblewimble/secp256k1-zkp/pull/23\r\n\r\nWork in progress, please do not merge. ","created_at":"2018-08-26T22:46:50Z","updated_at":"2018-09-06T11:46:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"681a5ace2f0c94f5b841c19978b6972d6755159b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mimblewimble/secp256k1-zkp/pulls/22/commits","review_comments_url":"https://api.github.com/repos/mimblewimble/secp256k1-zkp/pulls/22/comments","review_comment_url":"https://api.github.com/repos/mimblewimble/secp256k1-zkp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mimblewimble/secp256k1-zkp/issues/22/comments","statuses_url":"https://api.github.com/repos/mimblewimble/secp256k1-zkp/statuses/bfd194a1683d5b8fb832c2e3a9be3e1ea2e243f3","head":{"label":"jaspervdm:sig","ref":"sig","sha":"bfd194a1683d5b8fb832c2e3a9be3e1ea2e243f3","user":{"login":"jaspervdm","id":761205,"node_id":"MDQ6VXNlcjc2MTIwNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/761205?v=4","gravatar_id":"","url":"https://api.github.com/users/jaspervdm","html_url":"https://github.com/jaspervdm","followers_url":"https://api.github.com/users/jaspervdm/followers","following_url":"https://api.github.com/users/jaspervdm/following{/other_user}","gists_url":"https://api.github.com/users/jaspervdm/gists{/gist_id}","starred_url":"https://api.github.com/users/jaspervdm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaspervdm/subscriptions","organizations_url":"https://api.github.com/users/jaspervdm/orgs","repos_url":"https://api.github.com/users/jaspervdm/repos","events_url":"https://api.github.com/users/jaspervdm/events{/privacy}","received_events_url":"https://api.github.com/users/jaspervdm/received_events","type":"User","site_admin":false},"repo":{"id":144079176,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQwNzkxNzY=","name":"secp256k1-zkp","full_name":"jaspervdm/secp256k1-zkp","owner":{"login":"jaspervdm","id":761205,"node_id":"MDQ6VXNlcjc2MTIwNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/761205?v=4","gravatar_id":"","url":"https://api.github.com/users/jaspervdm","html_url":"https://github.com/jaspervdm","followers_url":"https://api.github.com/users/jaspervdm/followers","following_url":"https://api.github.com/users/jaspervdm/following{/other_user}","gists_url":"https://api.github.com/users/jaspervdm/gists{/gist_id}","starred_url":"https://api.github.com/users/jaspervdm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaspervdm/subscriptions","organizations_url":"https://api.github.com/users/jaspervdm/orgs","repos_url":"https://api.github.com/users/jaspervdm/repos","events_url":"https://api.github.com/users/jaspervdm/events{/privacy}","received_events_url":"https://api.github.com/users/jaspervdm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jaspervdm/secp256k1-zkp","description":"Fork of secp256k1-zkp for the Grin/MimbleWimble project","fork":true,"url":"https://api.github.com/repos/jaspervdm/secp256k1-zkp","forks_url":"https://api.github.com/repos/jaspervdm/secp256k1-zkp/forks","keys_url":"https://api.github.com/repos/jaspervdm/secp256k1-zkp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jaspervdm/secp256k1-zkp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jaspervdm/secp256k1-zkp/teams","hooks_url":"https://api.github.com/repos/jaspervdm/secp256k1-zkp/hooks","issue_events_url":"https://api.github.com/repos/jaspervdm/secp256k1-zkp/issues/events{/number}","events_url":"https://api.github.com/repos/jaspervdm/secp256k1-zkp/events","assignees_url":"https://api.github.com/repos/jaspervdm/secp256k1-zkp/assignees{/user}","branches_url":"https://api.github.com/repos/jaspervdm/secp256k1-zkp/branches{/branch}","tags_url":"https://api.github.com/repos/jaspervdm/secp256k1-zkp/tags","blobs_url":"https://api.github.com/repos/jaspervdm/secp256k1-zkp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jaspervdm/secp256k1-zkp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jaspervdm/secp256k1-zkp/git/refs{/sha}","trees_url":"https://api.github.com/repos/jaspervdm/secp256k1-zkp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jaspervdm/secp256k1-zkp/statuses/{sha}","languages_url":"https://api.github.com/repos/jaspervdm/secp256k1-zkp/languages","stargazers_url":"https://api.github.com/repos/jaspervdm/secp256k1-zkp/stargazers","contributors_url":"https://api.github.com/repos/jaspervdm/secp256k1-zkp/contributors","subscribers_url":"https://api.github.com/repos/jaspervdm/secp256k1-zkp/subscribers","subscription_url":"https://api.github.com/repos/jaspervdm/secp256k1-zkp/subscription","commits_url":"https://api.github.com/repos/jaspervdm/secp256k1-zkp/commits{/sha}","git_commits_url":"https://api.github.com/repos/jaspervdm/secp256k1-zkp/git/commits{/sha}","comments_url":"https://api.github.com/repos/jaspervdm/secp256k1-zkp/comments{/number}","issue_comment_url":"https://api.github.com/repos/jaspervdm/secp256k1-zkp/issues/comments{/number}","contents_url":"https://api.github.com/repos/jaspervdm/secp256k1-zkp/contents/{+path}","compare_url":"https://api.github.com/repos/jaspervdm/secp256k1-zkp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jaspervdm/secp256k1-zkp/merges","archive_url":"https://api.github.com/repos/jaspervdm/secp256k1-zkp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jaspervdm/secp256k1-zkp/downloads","issues_url":"https://api.github.com/repos/jaspervdm/secp256k1-zkp/issues{/number}","pulls_url":"https://api.github.com/repos/jaspervdm/secp256k1-zkp/pulls{/number}","milestones_url":"https://api.github.com/repos/jaspervdm/secp256k1-zkp/milestones{/number}","notifications_url":"https://api.github.com/repos/jaspervdm/secp256k1-zkp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jaspervdm/secp256k1-zkp/labels{/name}","releases_url":"https://api.github.com/repos/jaspervdm/secp256k1-zkp/releases{/id}","deployments_url":"https://api.github.com/repos/jaspervdm/secp256k1-zkp/deployments","created_at":"2018-08-08T23:49:16Z","updated_at":"2018-08-26T20:04:46Z","pushed_at":"2018-09-06T11:00:18Z","git_url":"git://github.com/jaspervdm/secp256k1-zkp.git","ssh_url":"git@github.com:jaspervdm/secp256k1-zkp.git","clone_url":"https://github.com/jaspervdm/secp256k1-zkp.git","svn_url":"https://github.com/jaspervdm/secp256k1-zkp","homepage":null,"size":11207,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mimblewimble:master","ref":"master","sha":"c9b3446d30a62e67943beba4e337aef3eb2ee7b0","user":{"login":"mimblewimble","id":23646132,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNjQ2MTMy","avatar_url":"https://avatars0.githubusercontent.com/u/23646132?v=4","gravatar_id":"","url":"https://api.github.com/users/mimblewimble","html_url":"https://github.com/mimblewimble","followers_url":"https://api.github.com/users/mimblewimble/followers","following_url":"https://api.github.com/users/mimblewimble/following{/other_user}","gists_url":"https://api.github.com/users/mimblewimble/gists{/gist_id}","starred_url":"https://api.github.com/users/mimblewimble/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mimblewimble/subscriptions","organizations_url":"https://api.github.com/users/mimblewimble/orgs","repos_url":"https://api.github.com/users/mimblewimble/repos","events_url":"https://api.github.com/users/mimblewimble/events{/privacy}","received_events_url":"https://api.github.com/users/mimblewimble/received_events","type":"Organization","site_admin":false},"repo":{"id":103335924,"node_id":"MDEwOlJlcG9zaXRvcnkxMDMzMzU5MjQ=","name":"secp256k1-zkp","full_name":"mimblewimble/secp256k1-zkp","owner":{"login":"mimblewimble","id":23646132,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNjQ2MTMy","avatar_url":"https://avatars0.githubusercontent.com/u/23646132?v=4","gravatar_id":"","url":"https://api.github.com/users/mimblewimble","html_url":"https://github.com/mimblewimble","followers_url":"https://api.github.com/users/mimblewimble/followers","following_url":"https://api.github.com/users/mimblewimble/following{/other_user}","gists_url":"https://api.github.com/users/mimblewimble/gists{/gist_id}","starred_url":"https://api.github.com/users/mimblewimble/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mimblewimble/subscriptions","organizations_url":"https://api.github.com/users/mimblewimble/orgs","repos_url":"https://api.github.com/users/mimblewimble/repos","events_url":"https://api.github.com/users/mimblewimble/events{/privacy}","received_events_url":"https://api.github.com/users/mimblewimble/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mimblewimble/secp256k1-zkp","description":"Fork of secp256k1-zkp for the Grin/MimbleWimble project","fork":false,"url":"https://api.github.com/repos/mimblewimble/secp256k1-zkp","forks_url":"https://api.github.com/repos/mimblewimble/secp256k1-zkp/forks","keys_url":"https://api.github.com/repos/mimblewimble/secp256k1-zkp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mimblewimble/secp256k1-zkp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mimblewimble/secp256k1-zkp/teams","hooks_url":"https://api.github.com/repos/mimblewimble/secp256k1-zkp/hooks","issue_events_url":"https://api.github.com/repos/mimblewimble/secp256k1-zkp/issues/events{/number}","events_url":"https://api.github.com/repos/mimblewimble/secp256k1-zkp/events","assignees_url":"https://api.github.com/repos/mimblewimble/secp256k1-zkp/assignees{/user}","branches_url":"https://api.github.com/repos/mimblewimble/secp256k1-zkp/branches{/branch}","tags_url":"https://api.github.com/repos/mimblewimble/secp256k1-zkp/tags","blobs_url":"https://api.github.com/repos/mimblewimble/secp256k1-zkp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mimblewimble/secp256k1-zkp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mimblewimble/secp256k1-zkp/git/refs{/sha}","trees_url":"https://api.github.com/repos/mimblewimble/secp256k1-zkp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mimblewimble/secp256k1-zkp/statuses/{sha}","languages_url":"https://api.github.com/repos/mimblewimble/secp256k1-zkp/languages","stargazers_url":"https://api.github.com/repos/mimblewimble/secp256k1-zkp/stargazers","contributors_url":"https://api.github.com/repos/mimblewimble/secp256k1-zkp/contributors","subscribers_url":"https://api.github.com/repos/mimblewimble/secp256k1-zkp/subscribers","subscription_url":"https://api.github.com/repos/mimblewimble/secp256k1-zkp/subscription","commits_url":"https://api.github.com/repos/mimblewimble/secp256k1-zkp/commits{/sha}","git_commits_url":"https://api.github.com/repos/mimblewimble/secp256k1-zkp/git/commits{/sha}","comments_url":"https://api.github.com/repos/mimblewimble/secp256k1-zkp/comments{/number}","issue_comment_url":"https://api.github.com/repos/mimblewimble/secp256k1-zkp/issues/comments{/number}","contents_url":"https://api.github.com/repos/mimblewimble/secp256k1-zkp/contents/{+path}","compare_url":"https://api.github.com/repos/mimblewimble/secp256k1-zkp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mimblewimble/secp256k1-zkp/merges","archive_url":"https://api.github.com/repos/mimblewimble/secp256k1-zkp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mimblewimble/secp256k1-zkp/downloads","issues_url":"https://api.github.com/repos/mimblewimble/secp256k1-zkp/issues{/number}","pulls_url":"https://api.github.com/repos/mimblewimble/secp256k1-zkp/pulls{/number}","milestones_url":"https://api.github.com/repos/mimblewimble/secp256k1-zkp/milestones{/number}","notifications_url":"https://api.github.com/repos/mimblewimble/secp256k1-zkp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mimblewimble/secp256k1-zkp/labels{/name}","releases_url":"https://api.github.com/repos/mimblewimble/secp256k1-zkp/releases{/id}","deployments_url":"https://api.github.com/repos/mimblewimble/secp256k1-zkp/deployments","created_at":"2017-09-13T00:57:39Z","updated_at":"2018-09-06T11:31:10Z","pushed_at":"2018-09-06T11:31:07Z","git_url":"git://github.com/mimblewimble/secp256k1-zkp.git","ssh_url":"git@github.com:mimblewimble/secp256k1-zkp.git","clone_url":"https://github.com/mimblewimble/secp256k1-zkp.git","svn_url":"https://github.com/mimblewimble/secp256k1-zkp","homepage":null,"size":11138,"stargazers_count":8,"watchers_count":8,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":5,"open_issues":4,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mimblewimble/secp256k1-zkp/pulls/22"},"html":{"href":"https://github.com/mimblewimble/secp256k1-zkp/pull/22"},"issue":{"href":"https://api.github.com/repos/mimblewimble/secp256k1-zkp/issues/22"},"comments":{"href":"https://api.github.com/repos/mimblewimble/secp256k1-zkp/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/mimblewimble/secp256k1-zkp/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/mimblewimble/secp256k1-zkp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mimblewimble/secp256k1-zkp/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/mimblewimble/secp256k1-zkp/statuses/bfd194a1683d5b8fb832c2e3a9be3e1ea2e243f3"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"garyyu"}}