{"action":"created","comment":{"url":"https://api.github.com/repos/openucx/ucx/pulls/comments/172041555","pull_request_review_id":100999092,"id":172041555,"diff_hunk":"@@ -109,13 +121,39 @@ class test_ucp_sockaddr : public ucp_test {\n         ep_params.sockaddr.addrlen = sizeof(*connect_addr);\n         sender().connect(&receiver(), ep_params);\n \n-        tag_send_recv(sender(), receiver());\n-\n-        /* wait for reverse ep to appear */\n-        while (receiver().get_num_eps() == 0) {\n+        if (wakeup) {","path":"test/gtest/ucp/test_ucp_sockaddr.cc","position":72,"original_position":72,"commit_id":"6ee3b42bbbed8d7d375ff770d78ba16984744911","original_commit_id":"6ee3b42bbbed8d7d375ff770d78ba16984744911","user":{"login":"yosefe","id":2255631,"avatar_url":"https://avatars0.githubusercontent.com/u/2255631?v=4","gravatar_id":"","url":"https://api.github.com/users/yosefe","html_url":"https://github.com/yosefe","followers_url":"https://api.github.com/users/yosefe/followers","following_url":"https://api.github.com/users/yosefe/following{/other_user}","gists_url":"https://api.github.com/users/yosefe/gists{/gist_id}","starred_url":"https://api.github.com/users/yosefe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yosefe/subscriptions","organizations_url":"https://api.github.com/users/yosefe/orgs","repos_url":"https://api.github.com/users/yosefe/repos","events_url":"https://api.github.com/users/yosefe/events{/privacy}","received_events_url":"https://api.github.com/users/yosefe/received_events","type":"User","site_admin":false},"body":"there should not be any different path for \"wait\" in this function, only \"wait()\" function should be different.\r\nwhy need to do wait/progress here if it's already done in wait()?","created_at":"2018-03-04T08:59:25Z","updated_at":"2018-03-04T08:59:34Z","html_url":"https://github.com/openucx/ucx/pull/2348#discussion_r172041555","pull_request_url":"https://api.github.com/repos/openucx/ucx/pulls/2348","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/openucx/ucx/pulls/comments/172041555"},"html":{"href":"https://github.com/openucx/ucx/pull/2348#discussion_r172041555"},"pull_request":{"href":"https://api.github.com/repos/openucx/ucx/pulls/2348"}}},"pull_request":{"url":"https://api.github.com/repos/openucx/ucx/pulls/2348","id":171437480,"html_url":"https://github.com/openucx/ucx/pull/2348","diff_url":"https://github.com/openucx/ucx/pull/2348.diff","patch_url":"https://github.com/openucx/ucx/pull/2348.patch","issue_url":"https://api.github.com/repos/openucx/ucx/issues/2348","number":2348,"state":"open","locked":false,"title":"UCP/GTEST: Support the wakeup mechanism with client-server and test it.","user":{"login":"alinask","id":2405183,"avatar_url":"https://avatars1.githubusercontent.com/u/2405183?v=4","gravatar_id":"","url":"https://api.github.com/users/alinask","html_url":"https://github.com/alinask","followers_url":"https://api.github.com/users/alinask/followers","following_url":"https://api.github.com/users/alinask/following{/other_user}","gists_url":"https://api.github.com/users/alinask/gists{/gist_id}","starred_url":"https://api.github.com/users/alinask/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alinask/subscriptions","organizations_url":"https://api.github.com/users/alinask/orgs","repos_url":"https://api.github.com/users/alinask/repos","events_url":"https://api.github.com/users/alinask/events{/privacy}","received_events_url":"https://api.github.com/users/alinask/received_events","type":"User","site_admin":false},"body":null,"created_at":"2018-02-26T17:14:53Z","updated_at":"2018-03-04T08:59:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8797669daa968dfe739e2813939050f7dd463a94","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":273707362,"url":"https://api.github.com/repos/openucx/ucx/labels/documentation","name":"documentation","color":"fbca04","default":false},{"id":138949043,"url":"https://api.github.com/repos/openucx/ucx/labels/feature","name":"feature","color":"84b6eb","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openucx/ucx/pulls/2348/commits","review_comments_url":"https://api.github.com/repos/openucx/ucx/pulls/2348/comments","review_comment_url":"https://api.github.com/repos/openucx/ucx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openucx/ucx/issues/2348/comments","statuses_url":"https://api.github.com/repos/openucx/ucx/statuses/6ee3b42bbbed8d7d375ff770d78ba16984744911","head":{"label":"alinask:topic/ucp-client-server-wakeup","ref":"topic/ucp-client-server-wakeup","sha":"6ee3b42bbbed8d7d375ff770d78ba16984744911","user":{"login":"alinask","id":2405183,"avatar_url":"https://avatars1.githubusercontent.com/u/2405183?v=4","gravatar_id":"","url":"https://api.github.com/users/alinask","html_url":"https://github.com/alinask","followers_url":"https://api.github.com/users/alinask/followers","following_url":"https://api.github.com/users/alinask/following{/other_user}","gists_url":"https://api.github.com/users/alinask/gists{/gist_id}","starred_url":"https://api.github.com/users/alinask/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alinask/subscriptions","organizations_url":"https://api.github.com/users/alinask/orgs","repos_url":"https://api.github.com/users/alinask/repos","events_url":"https://api.github.com/users/alinask/events{/privacy}","received_events_url":"https://api.github.com/users/alinask/received_events","type":"User","site_admin":false},"repo":{"id":39071172,"name":"ucx","full_name":"alinask/ucx","owner":{"login":"alinask","id":2405183,"avatar_url":"https://avatars1.githubusercontent.com/u/2405183?v=4","gravatar_id":"","url":"https://api.github.com/users/alinask","html_url":"https://github.com/alinask","followers_url":"https://api.github.com/users/alinask/followers","following_url":"https://api.github.com/users/alinask/following{/other_user}","gists_url":"https://api.github.com/users/alinask/gists{/gist_id}","starred_url":"https://api.github.com/users/alinask/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alinask/subscriptions","organizations_url":"https://api.github.com/users/alinask/orgs","repos_url":"https://api.github.com/users/alinask/repos","events_url":"https://api.github.com/users/alinask/events{/privacy}","received_events_url":"https://api.github.com/users/alinask/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alinask/ucx","description":"Unified Communication X : ","fork":true,"url":"https://api.github.com/repos/alinask/ucx","forks_url":"https://api.github.com/repos/alinask/ucx/forks","keys_url":"https://api.github.com/repos/alinask/ucx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alinask/ucx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alinask/ucx/teams","hooks_url":"https://api.github.com/repos/alinask/ucx/hooks","issue_events_url":"https://api.github.com/repos/alinask/ucx/issues/events{/number}","events_url":"https://api.github.com/repos/alinask/ucx/events","assignees_url":"https://api.github.com/repos/alinask/ucx/assignees{/user}","branches_url":"https://api.github.com/repos/alinask/ucx/branches{/branch}","tags_url":"https://api.github.com/repos/alinask/ucx/tags","blobs_url":"https://api.github.com/repos/alinask/ucx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alinask/ucx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alinask/ucx/git/refs{/sha}","trees_url":"https://api.github.com/repos/alinask/ucx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alinask/ucx/statuses/{sha}","languages_url":"https://api.github.com/repos/alinask/ucx/languages","stargazers_url":"https://api.github.com/repos/alinask/ucx/stargazers","contributors_url":"https://api.github.com/repos/alinask/ucx/contributors","subscribers_url":"https://api.github.com/repos/alinask/ucx/subscribers","subscription_url":"https://api.github.com/repos/alinask/ucx/subscription","commits_url":"https://api.github.com/repos/alinask/ucx/commits{/sha}","git_commits_url":"https://api.github.com/repos/alinask/ucx/git/commits{/sha}","comments_url":"https://api.github.com/repos/alinask/ucx/comments{/number}","issue_comment_url":"https://api.github.com/repos/alinask/ucx/issues/comments{/number}","contents_url":"https://api.github.com/repos/alinask/ucx/contents/{+path}","compare_url":"https://api.github.com/repos/alinask/ucx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alinask/ucx/merges","archive_url":"https://api.github.com/repos/alinask/ucx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alinask/ucx/downloads","issues_url":"https://api.github.com/repos/alinask/ucx/issues{/number}","pulls_url":"https://api.github.com/repos/alinask/ucx/pulls{/number}","milestones_url":"https://api.github.com/repos/alinask/ucx/milestones{/number}","notifications_url":"https://api.github.com/repos/alinask/ucx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alinask/ucx/labels{/name}","releases_url":"https://api.github.com/repos/alinask/ucx/releases{/id}","deployments_url":"https://api.github.com/repos/alinask/ucx/deployments","created_at":"2015-07-14T11:34:14Z","updated_at":"2016-02-29T14:42:56Z","pushed_at":"2018-03-01T16:42:16Z","git_url":"git://github.com/alinask/ucx.git","ssh_url":"git@github.com:alinask/ucx.git","clone_url":"https://github.com/alinask/ucx.git","svn_url":"https://github.com/alinask/ucx","homepage":" http://www.openucx.org","size":11751,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openucx:master","ref":"master","sha":"eb21215b62cbe38f2740c2d40b1c81eafa13e7bc","user":{"login":"openucx","id":13118737,"avatar_url":"https://avatars2.githubusercontent.com/u/13118737?v=4","gravatar_id":"","url":"https://api.github.com/users/openucx","html_url":"https://github.com/openucx","followers_url":"https://api.github.com/users/openucx/followers","following_url":"https://api.github.com/users/openucx/following{/other_user}","gists_url":"https://api.github.com/users/openucx/gists{/gist_id}","starred_url":"https://api.github.com/users/openucx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openucx/subscriptions","organizations_url":"https://api.github.com/users/openucx/orgs","repos_url":"https://api.github.com/users/openucx/repos","events_url":"https://api.github.com/users/openucx/events{/privacy}","received_events_url":"https://api.github.com/users/openucx/received_events","type":"Organization","site_admin":false},"repo":{"id":25379390,"name":"ucx","full_name":"openucx/ucx","owner":{"login":"openucx","id":13118737,"avatar_url":"https://avatars2.githubusercontent.com/u/13118737?v=4","gravatar_id":"","url":"https://api.github.com/users/openucx","html_url":"https://github.com/openucx","followers_url":"https://api.github.com/users/openucx/followers","following_url":"https://api.github.com/users/openucx/following{/other_user}","gists_url":"https://api.github.com/users/openucx/gists{/gist_id}","starred_url":"https://api.github.com/users/openucx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openucx/subscriptions","organizations_url":"https://api.github.com/users/openucx/orgs","repos_url":"https://api.github.com/users/openucx/repos","events_url":"https://api.github.com/users/openucx/events{/privacy}","received_events_url":"https://api.github.com/users/openucx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openucx/ucx","description":"Unified Communication X  (mailing list - https://elist.ornl.gov/mailman/listinfo/ucx-group): ","fork":false,"url":"https://api.github.com/repos/openucx/ucx","forks_url":"https://api.github.com/repos/openucx/ucx/forks","keys_url":"https://api.github.com/repos/openucx/ucx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openucx/ucx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openucx/ucx/teams","hooks_url":"https://api.github.com/repos/openucx/ucx/hooks","issue_events_url":"https://api.github.com/repos/openucx/ucx/issues/events{/number}","events_url":"https://api.github.com/repos/openucx/ucx/events","assignees_url":"https://api.github.com/repos/openucx/ucx/assignees{/user}","branches_url":"https://api.github.com/repos/openucx/ucx/branches{/branch}","tags_url":"https://api.github.com/repos/openucx/ucx/tags","blobs_url":"https://api.github.com/repos/openucx/ucx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openucx/ucx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openucx/ucx/git/refs{/sha}","trees_url":"https://api.github.com/repos/openucx/ucx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openucx/ucx/statuses/{sha}","languages_url":"https://api.github.com/repos/openucx/ucx/languages","stargazers_url":"https://api.github.com/repos/openucx/ucx/stargazers","contributors_url":"https://api.github.com/repos/openucx/ucx/contributors","subscribers_url":"https://api.github.com/repos/openucx/ucx/subscribers","subscription_url":"https://api.github.com/repos/openucx/ucx/subscription","commits_url":"https://api.github.com/repos/openucx/ucx/commits{/sha}","git_commits_url":"https://api.github.com/repos/openucx/ucx/git/commits{/sha}","comments_url":"https://api.github.com/repos/openucx/ucx/comments{/number}","issue_comment_url":"https://api.github.com/repos/openucx/ucx/issues/comments{/number}","contents_url":"https://api.github.com/repos/openucx/ucx/contents/{+path}","compare_url":"https://api.github.com/repos/openucx/ucx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openucx/ucx/merges","archive_url":"https://api.github.com/repos/openucx/ucx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openucx/ucx/downloads","issues_url":"https://api.github.com/repos/openucx/ucx/issues{/number}","pulls_url":"https://api.github.com/repos/openucx/ucx/pulls{/number}","milestones_url":"https://api.github.com/repos/openucx/ucx/milestones{/number}","notifications_url":"https://api.github.com/repos/openucx/ucx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openucx/ucx/labels{/name}","releases_url":"https://api.github.com/repos/openucx/ucx/releases{/id}","deployments_url":"https://api.github.com/repos/openucx/ucx/deployments","created_at":"2014-10-17T22:17:24Z","updated_at":"2018-02-28T07:17:50Z","pushed_at":"2018-03-03T05:32:23Z","git_url":"git://github.com/openucx/ucx.git","ssh_url":"git@github.com:openucx/ucx.git","clone_url":"https://github.com/openucx/ucx.git","svn_url":"https://github.com/openucx/ucx","homepage":"http://www.openucx.org","size":11821,"stargazers_count":102,"watchers_count":102,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":65,"mirror_url":null,"archived":false,"open_issues_count":128,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":65,"open_issues":128,"watchers":102,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openucx/ucx/pulls/2348"},"html":{"href":"https://github.com/openucx/ucx/pull/2348"},"issue":{"href":"https://api.github.com/repos/openucx/ucx/issues/2348"},"comments":{"href":"https://api.github.com/repos/openucx/ucx/issues/2348/comments"},"review_comments":{"href":"https://api.github.com/repos/openucx/ucx/pulls/2348/comments"},"review_comment":{"href":"https://api.github.com/repos/openucx/ucx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openucx/ucx/pulls/2348/commits"},"statuses":{"href":"https://api.github.com/repos/openucx/ucx/statuses/6ee3b42bbbed8d7d375ff770d78ba16984744911"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"yosefe"}}