{"action":"created","issue":{"url":"https://api.github.com/repos/matplotlib/matplotlib/issues/10428","repository_url":"https://api.github.com/repos/matplotlib/matplotlib","labels_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/10428/labels{/name}","comments_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/10428/comments","events_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/10428/events","html_url":"https://github.com/matplotlib/matplotlib/pull/10428","id":296276722,"number":10428,"title":"Fix wx canvas type injection.","user":{"login":"anntzer","id":1322974,"avatar_url":"https://avatars0.githubusercontent.com/u/1322974?v=4","gravatar_id":"","url":"https://api.github.com/users/anntzer","html_url":"https://github.com/anntzer","followers_url":"https://api.github.com/users/anntzer/followers","following_url":"https://api.github.com/users/anntzer/following{/other_user}","gists_url":"https://api.github.com/users/anntzer/gists{/gist_id}","starred_url":"https://api.github.com/users/anntzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anntzer/subscriptions","organizations_url":"https://api.github.com/users/anntzer/orgs","repos_url":"https://api.github.com/users/anntzer/repos","events_url":"https://api.github.com/users/anntzer/events{/privacy}","received_events_url":"https://api.github.com/users/anntzer/received_events","type":"User","site_admin":false},"labels":[{"id":151678852,"url":"https://api.github.com/repos/matplotlib/matplotlib/labels/GUI/wx","name":"GUI/wx","color":"d4c5f9","default":false},{"id":155360,"url":"https://api.github.com/repos/matplotlib/matplotlib/labels/Release%20critical","name":"Release critical","color":"b60205","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/matplotlib/matplotlib/milestones/31","html_url":"https://github.com/matplotlib/matplotlib/milestone/31","labels_url":"https://api.github.com/repos/matplotlib/matplotlib/milestones/31/labels","id":3106571,"number":31,"title":"v2.2.0","description":"Release of v2.2.0 final release.\r\n\r\non-merge: backport to v2.2.x","creator":{"login":"tacaswell","id":199813,"avatar_url":"https://avatars3.githubusercontent.com/u/199813?v=4","gravatar_id":"","url":"https://api.github.com/users/tacaswell","html_url":"https://github.com/tacaswell","followers_url":"https://api.github.com/users/tacaswell/followers","following_url":"https://api.github.com/users/tacaswell/following{/other_user}","gists_url":"https://api.github.com/users/tacaswell/gists{/gist_id}","starred_url":"https://api.github.com/users/tacaswell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tacaswell/subscriptions","organizations_url":"https://api.github.com/users/tacaswell/orgs","repos_url":"https://api.github.com/users/tacaswell/repos","events_url":"https://api.github.com/users/tacaswell/events{/privacy}","received_events_url":"https://api.github.com/users/tacaswell/received_events","type":"User","site_admin":false},"open_issues":13,"closed_issues":478,"state":"open","created_at":"2018-02-12T03:21:01Z","updated_at":"2018-02-17T00:29:05Z","due_on":"2018-03-02T08:00:00Z","closed_at":null},"comments":1,"created_at":"2018-02-12T06:23:17Z","updated_at":"2018-02-17T01:25:10Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/10428","html_url":"https://github.com/matplotlib/matplotlib/pull/10428","diff_url":"https://github.com/matplotlib/matplotlib/pull/10428.diff","patch_url":"https://github.com/matplotlib/matplotlib/pull/10428.patch"},"body":"NavigationToolbar2Wx should use `type(self.canvas)` when instantiating\r\nthe canvas to make it work with all of wx, wxagg, wxcairo (instantiating\r\nthe corresponding canvas class in each case).  Conversely, FigureFrameWx\r\nshould explicitly use FigureCanvasWx; other backends (wxagg, wxcairo)\r\noverride the method accordingly.\r\n\r\nI got these inverted in my previous PR and this breaks the wx backend.\r\n\r\n## PR Summary\r\n\r\n## PR Checklist\r\n\r\n- [ ] Has Pytest style unit tests\r\n- [ ] Code is PEP 8 compliant\r\n- [ ] New features are documented, with examples if plot related\r\n- [ ] Documentation is sphinx and numpydoc compliant\r\n- [ ] Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)\r\n- [ ] Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way\r\n\r\n<!--\r\nThank you so much for your PR!  To help us review your contribution, please\r\nconsider the following points:\r\n\r\n- A development guide is available at https://matplotlib.org/devdocs/devel/index.html.\r\n\r\n- Help with git and github is available at\r\n  https://matplotlib.org/devel/gitwash/development_workflow.html.\r\n\r\n- Do not create the PR out of master, but out of a separate branch.\r\n\r\n- The PR title should summarize the changes, for example \"Raise ValueError on\r\n  non-numeric input to set_xlim\".  Avoid non-descriptive titles such as\r\n  \"Addresses issue #8576\".\r\n\r\n- The summary should provide at least 1-2 sentences describing the pull request\r\n  in detail (Why is this change required?  What problem does it solve?) and\r\n  link to any relevant issues.\r\n\r\n- If you are contributing fixes to docstrings, please pay attention to\r\n  http://matplotlib.org/devel/documenting_mpl.html#formatting.  In particular,\r\n  note the difference between using single backquotes, double backquotes, and\r\n  asterisks in the markup.\r\n\r\nWe understand that PRs can sometimes be overwhelming, especially as the\r\nreviews start coming in.  Please let us know if the reviews are unclear or\r\nthe recommended next step seems overly demanding, if you would like help in\r\naddressing a reviewer's comments, or if you have been waiting too long to hear\r\nback on your PR.\r\n-->\r\n"},"comment":{"url":"https://api.github.com/repos/matplotlib/matplotlib/issues/comments/366403550","html_url":"https://github.com/matplotlib/matplotlib/pull/10428#issuecomment-366403550","issue_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/10428","id":366403550,"user":{"login":"anntzer","id":1322974,"avatar_url":"https://avatars0.githubusercontent.com/u/1322974?v=4","gravatar_id":"","url":"https://api.github.com/users/anntzer","html_url":"https://github.com/anntzer","followers_url":"https://api.github.com/users/anntzer/followers","following_url":"https://api.github.com/users/anntzer/following{/other_user}","gists_url":"https://api.github.com/users/anntzer/gists{/gist_id}","starred_url":"https://api.github.com/users/anntzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anntzer/subscriptions","organizations_url":"https://api.github.com/users/anntzer/orgs","repos_url":"https://api.github.com/users/anntzer/repos","events_url":"https://api.github.com/users/anntzer/events{/privacy}","received_events_url":"https://api.github.com/users/anntzer/received_events","type":"User","site_admin":false},"created_at":"2018-02-17T01:25:10Z","updated_at":"2018-02-17T01:25:10Z","author_association":"CONTRIBUTOR","body":"Removal of the Toolbar alias came in in #9938 and I would support either keeping it out (and fixing the example), or, if we want to have it back, it should be present for all backends (as a \"standard backend interface\").\r\n\r\nI would prefer keeping a single class to make it easier to write renderer-independent code.  (And yes, having a single alias for Toolbar would also help that purpose, but again in that case it seems preferable to let all relevant backends have it.)"}}
{"actor":{"display_login":"anntzer"}}