{"action":"created","issue":{"url":"https://api.github.com/repos/UptakeOpenSource/uptasticsearch/issues/66","repository_url":"https://api.github.com/repos/UptakeOpenSource/uptasticsearch","labels_url":"https://api.github.com/repos/UptakeOpenSource/uptasticsearch/issues/66/labels{/name}","comments_url":"https://api.github.com/repos/UptakeOpenSource/uptasticsearch/issues/66/comments","events_url":"https://api.github.com/repos/UptakeOpenSource/uptasticsearch/issues/66/events","html_url":"https://github.com/UptakeOpenSource/uptasticsearch/pull/66","id":325134598,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg5NTQzMTgw","number":66,"title":"Add integration tests and make tests easier to develop","user":{"login":"jameslamb","id":7608904,"node_id":"MDQ6VXNlcjc2MDg5MDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/7608904?v=4","gravatar_id":"","url":"https://api.github.com/users/jameslamb","html_url":"https://github.com/jameslamb","followers_url":"https://api.github.com/users/jameslamb/followers","following_url":"https://api.github.com/users/jameslamb/following{/other_user}","gists_url":"https://api.github.com/users/jameslamb/gists{/gist_id}","starred_url":"https://api.github.com/users/jameslamb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jameslamb/subscriptions","organizations_url":"https://api.github.com/users/jameslamb/orgs","repos_url":"https://api.github.com/users/jameslamb/repos","events_url":"https://api.github.com/users/jameslamb/events{/privacy}","received_events_url":"https://api.github.com/users/jameslamb/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-05-22T04:11:01Z","updated_at":"2018-06-05T23:14:47Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/UptakeOpenSource/uptasticsearch/pulls/66","html_url":"https://github.com/UptakeOpenSource/uptasticsearch/pull/66","diff_url":"https://github.com/UptakeOpenSource/uptasticsearch/pull/66.diff","patch_url":"https://github.com/UptakeOpenSource/uptasticsearch/pull/66.patch"},"body":"This PR adds a bunch of integration tests and makes it easier to test locally.\r\n\r\n* added creation of an empty index so we can test the \"your query was valid but returned nothing\" code\r\n* wrapped all `return(NULL)` in `return(invisible(NULL))` to avoid phantom NULLs in logs\r\n* changed strategy for scrolling requests. Scrolling queries are not working on ES6 right now. They changed ES6 to [this structure](https://www.elastic.co/guide/en/elasticsearch/reference/6.x/search-request-scroll.html).\r\n* related to that...moved stuff needed for `scroll_url` down into `.keep_on_pullin` so that thing can figure out how to format scrolls. This is a cleaner place to handle that anyway\r\n* added a bunch of integration tests. Including **an actual test on scrolling which we somehow never had before**\r\n* added a `docker-compose.yml` and supporting gnarly bash scripts to make it easier to develop tests locally\r\n\r\nTest coverage as of this PR:\r\n\r\n![image](https://user-images.githubusercontent.com/7608904/40341684-21c70dee-5d4c-11e8-8a43-15e1114db466.png)\r\n\r\nI think it's important we get this PR reviewed and working before the next release. Addresses #33 , #36 , and to some extent #43 "},"comment":{"url":"https://api.github.com/repos/UptakeOpenSource/uptasticsearch/issues/comments/394889908","html_url":"https://github.com/UptakeOpenSource/uptasticsearch/pull/66#issuecomment-394889908","issue_url":"https://api.github.com/repos/UptakeOpenSource/uptasticsearch/issues/66","id":394889908,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NDg4OTkwOA==","user":{"login":"jameslamb","id":7608904,"node_id":"MDQ6VXNlcjc2MDg5MDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/7608904?v=4","gravatar_id":"","url":"https://api.github.com/users/jameslamb","html_url":"https://github.com/jameslamb","followers_url":"https://api.github.com/users/jameslamb/followers","following_url":"https://api.github.com/users/jameslamb/following{/other_user}","gists_url":"https://api.github.com/users/jameslamb/gists{/gist_id}","starred_url":"https://api.github.com/users/jameslamb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jameslamb/subscriptions","organizations_url":"https://api.github.com/users/jameslamb/orgs","repos_url":"https://api.github.com/users/jameslamb/repos","events_url":"https://api.github.com/users/jameslamb/events{/privacy}","received_events_url":"https://api.github.com/users/jameslamb/received_events","type":"User","site_admin":false},"created_at":"2018-06-05T23:14:47Z","updated_at":"2018-06-05T23:14:47Z","author_association":"COLLABORATOR","body":"Hey thanks @austin3dickey for looking it over!! Gonna merge it up"}}
{"actor":{"display_login":"jameslamb"}}