{"action":"created","issue":{"url":"https://api.github.com/repos/HewlettPackard/netperf/issues/10","repository_url":"https://api.github.com/repos/HewlettPackard/netperf","labels_url":"https://api.github.com/repos/HewlettPackard/netperf/issues/10/labels{/name}","comments_url":"https://api.github.com/repos/HewlettPackard/netperf/issues/10/comments","events_url":"https://api.github.com/repos/HewlettPackard/netperf/issues/10/events","html_url":"https://github.com/HewlettPackard/netperf/pull/10","id":295569948,"node_id":"MDExOlB1bGxSZXF1ZXN0MTY4MDE1Mjkw","number":10,"title":"netserver: use mkstemp to create/open debug file","user":{"login":"grundlerchromium","id":36247368,"node_id":"MDQ6VXNlcjM2MjQ3MzY4","avatar_url":"https://avatars2.githubusercontent.com/u/36247368?v=4","gravatar_id":"","url":"https://api.github.com/users/grundlerchromium","html_url":"https://github.com/grundlerchromium","followers_url":"https://api.github.com/users/grundlerchromium/followers","following_url":"https://api.github.com/users/grundlerchromium/following{/other_user}","gists_url":"https://api.github.com/users/grundlerchromium/gists{/gist_id}","starred_url":"https://api.github.com/users/grundlerchromium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grundlerchromium/subscriptions","organizations_url":"https://api.github.com/users/grundlerchromium/orgs","repos_url":"https://api.github.com/users/grundlerchromium/repos","events_url":"https://api.github.com/users/grundlerchromium/events{/privacy}","received_events_url":"https://api.github.com/users/grundlerchromium/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-02-08T16:07:59Z","updated_at":"2018-05-30T20:42:22Z","closed_at":"2018-03-07T20:18:43Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/HewlettPackard/netperf/pulls/10","html_url":"https://github.com/HewlettPackard/netperf/pull/10","diff_url":"https://github.com/HewlettPackard/netperf/pull/10.diff","patch_url":"https://github.com/HewlettPackard/netperf/pull/10.patch"},"body":"This is another attempt to address the primary issue:\r\n    https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=413658\r\n\r\nsimilar to the original patch proposed:\r\n    https://bugs.debian.org/cgi-bin/bugreport.cgi?att=1;bug=413658;filename=CVE-2007-1444.patch;msg=35"},"comment":{"url":"https://api.github.com/repos/HewlettPackard/netperf/issues/comments/393312153","html_url":"https://github.com/HewlettPackard/netperf/pull/10#issuecomment-393312153","issue_url":"https://api.github.com/repos/HewlettPackard/netperf/issues/10","id":393312153,"node_id":"MDEyOklzc3VlQ29tbWVudDM5MzMxMjE1Mw==","user":{"login":"marceloleitner","id":370788,"node_id":"MDQ6VXNlcjM3MDc4OA==","avatar_url":"https://avatars3.githubusercontent.com/u/370788?v=4","gravatar_id":"","url":"https://api.github.com/users/marceloleitner","html_url":"https://github.com/marceloleitner","followers_url":"https://api.github.com/users/marceloleitner/followers","following_url":"https://api.github.com/users/marceloleitner/following{/other_user}","gists_url":"https://api.github.com/users/marceloleitner/gists{/gist_id}","starred_url":"https://api.github.com/users/marceloleitner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marceloleitner/subscriptions","organizations_url":"https://api.github.com/users/marceloleitner/orgs","repos_url":"https://api.github.com/users/marceloleitner/repos","events_url":"https://api.github.com/users/marceloleitner/events{/privacy}","received_events_url":"https://api.github.com/users/marceloleitner/received_events","type":"User","site_admin":false},"created_at":"2018-05-30T20:42:22Z","updated_at":"2018-05-30T20:42:22Z","author_association":"CONTRIBUTOR","body":"On Wed, May 30, 2018 at 05:37:14PM +0000, grundlerchromium wrote:\n> > There is a difference on \"log file\" and \"temporary file\".\n> >\n> \n> Indeed - this is a log file and according to FHS, belongs in /var/log. The\n> use of mkstemp() is to prevent file name collisions and some security\n> issues.\n\nI can see why you think that it is a log file. But if you consider the\napplication and the file contents, it makes no sense to store it in\n/var/log.\n\nnetserver is often used as an user and with this change you're\nbreaking lots of scripts around, including a couple here, for no good\nreason.\n\nLet me extrapolate your point: any perf record (which generates a\nperf.data in local dir) should also be considered a \"log file\" because\nit contains a trace of what was executed. So now we have to store\nperf.data in /var/log? Please, no.\n\nI can agree /tmp was a bad choice. But /var/log is no better.\n\n> \n> Would you like to add a parameter to allow the user to specify the \"LOGDIR\"?\n> Or maybe a flag to suppress LOG file creation?\n\nMaybe the other way around: this file is empty unless one enables\ndebug output. So why create the file in the first place, if normally\nthe debug output is not requested?\n\nThen, if debug is enabled, IMO it should just create the log file in\ncurrent dir, unless otherwise specified. Seriously, please consider\nwho uses this application when working on this.\n\nThank you,\nMarcelo\n"}}
{"actor":{"display_login":"marceloleitner"}}