{"action":"created","comment":{"url":"https://api.github.com/repos/kubevirt/kubevirt/pulls/comments/206331726","pull_request_review_id":141727397,"id":206331726,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNjMzMTcyNg==","diff_hunk":"@@ -237,3 +251,124 @@ func NewDomain(dom cli.VirDomain) (*api.Domain, error) {\n \tdomain.GetObjectMeta().SetUID(domain.Spec.Metadata.KubeVirt.UID)\n \treturn domain, nil\n }\n+\n+// ForkAndMonitor itself to give qemu an extra grace period to properly terminate\n+// in case of virt-launcher crashes\n+func ForkAndMonitor(commandNamePrefix string) error {","path":"pkg/virt-launcher/virtwrap/util/libvirt_helper.go","position":53,"original_position":53,"commit_id":"aa86e12283ffb46f63b132a28a980c0c1bfe3a6c","original_commit_id":"aa86e12283ffb46f63b132a28a980c0c1bfe3a6c","user":{"login":"davidvossel","id":683713,"node_id":"MDQ6VXNlcjY4MzcxMw==","avatar_url":"https://avatars0.githubusercontent.com/u/683713?v=4","gravatar_id":"","url":"https://api.github.com/users/davidvossel","html_url":"https://github.com/davidvossel","followers_url":"https://api.github.com/users/davidvossel/followers","following_url":"https://api.github.com/users/davidvossel/following{/other_user}","gists_url":"https://api.github.com/users/davidvossel/gists{/gist_id}","starred_url":"https://api.github.com/users/davidvossel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidvossel/subscriptions","organizations_url":"https://api.github.com/users/davidvossel/orgs","repos_url":"https://api.github.com/users/davidvossel/repos","events_url":"https://api.github.com/users/davidvossel/events{/privacy}","received_events_url":"https://api.github.com/users/davidvossel/received_events","type":"User","site_admin":false},"body":"is there a reason this needs to be in libvirt_helper.go? This is kind of specific to virt-launcher and not exactly libvirt. ","created_at":"2018-07-30T21:41:45Z","updated_at":"2018-07-30T21:46:05Z","html_url":"https://github.com/kubevirt/kubevirt/pull/1386#discussion_r206331726","pull_request_url":"https://api.github.com/repos/kubevirt/kubevirt/pulls/1386","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kubevirt/kubevirt/pulls/comments/206331726"},"html":{"href":"https://github.com/kubevirt/kubevirt/pull/1386#discussion_r206331726"},"pull_request":{"href":"https://api.github.com/repos/kubevirt/kubevirt/pulls/1386"}}},"pull_request":{"url":"https://api.github.com/repos/kubevirt/kubevirt/pulls/1386","id":204728337,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0NzI4MzM3","html_url":"https://github.com/kubevirt/kubevirt/pull/1386","diff_url":"https://github.com/kubevirt/kubevirt/pull/1386.diff","patch_url":"https://github.com/kubevirt/kubevirt/pull/1386.patch","issue_url":"https://api.github.com/repos/kubevirt/kubevirt/issues/1386","number":1386,"state":"open","locked":false,"title":"Simplify containers/packaging for virt-launcher","user":{"login":"rmohr","id":4534621,"node_id":"MDQ6VXNlcjQ1MzQ2MjE=","avatar_url":"https://avatars3.githubusercontent.com/u/4534621?v=4","gravatar_id":"","url":"https://api.github.com/users/rmohr","html_url":"https://github.com/rmohr","followers_url":"https://api.github.com/users/rmohr/followers","following_url":"https://api.github.com/users/rmohr/following{/other_user}","gists_url":"https://api.github.com/users/rmohr/gists{/gist_id}","starred_url":"https://api.github.com/users/rmohr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmohr/subscriptions","organizations_url":"https://api.github.com/users/rmohr/orgs","repos_url":"https://api.github.com/users/rmohr/repos","events_url":"https://api.github.com/users/rmohr/events{/privacy}","received_events_url":"https://api.github.com/users/rmohr/received_events","type":"User","site_admin":false},"body":"**What this PR does / why we need it**:\r\n\r\nPart of a series to reduce our dependency footprint and to remove our bash hacks from the containers.\r\nAt the end only one go binary + additional yum dependencies are going to be installed in each container.\r\n\r\nAs a consequence building and maintaining containers in different ways becomes much simpler and on the long run our startup code maintainability should reduce too.\r\n\r\n**Release note**:\r\n```release-note\r\nNONE\r\n```","created_at":"2018-07-30T08:23:24Z","updated_at":"2018-07-30T21:46:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5c37f0a634181ba496879eec9b8e91540b752360","assignee":null,"assignees":[],"requested_reviewers":[{"login":"cynepco3hahue","id":4704810,"node_id":"MDQ6VXNlcjQ3MDQ4MTA=","avatar_url":"https://avatars0.githubusercontent.com/u/4704810?v=4","gravatar_id":"","url":"https://api.github.com/users/cynepco3hahue","html_url":"https://github.com/cynepco3hahue","followers_url":"https://api.github.com/users/cynepco3hahue/followers","following_url":"https://api.github.com/users/cynepco3hahue/following{/other_user}","gists_url":"https://api.github.com/users/cynepco3hahue/gists{/gist_id}","starred_url":"https://api.github.com/users/cynepco3hahue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cynepco3hahue/subscriptions","organizations_url":"https://api.github.com/users/cynepco3hahue/orgs","repos_url":"https://api.github.com/users/cynepco3hahue/repos","events_url":"https://api.github.com/users/cynepco3hahue/events{/privacy}","received_events_url":"https://api.github.com/users/cynepco3hahue/received_events","type":"User","site_admin":false},{"login":"stu-gott","id":7397746,"node_id":"MDQ6VXNlcjczOTc3NDY=","avatar_url":"https://avatars1.githubusercontent.com/u/7397746?v=4","gravatar_id":"","url":"https://api.github.com/users/stu-gott","html_url":"https://github.com/stu-gott","followers_url":"https://api.github.com/users/stu-gott/followers","following_url":"https://api.github.com/users/stu-gott/following{/other_user}","gists_url":"https://api.github.com/users/stu-gott/gists{/gist_id}","starred_url":"https://api.github.com/users/stu-gott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stu-gott/subscriptions","organizations_url":"https://api.github.com/users/stu-gott/orgs","repos_url":"https://api.github.com/users/stu-gott/repos","events_url":"https://api.github.com/users/stu-gott/events{/privacy}","received_events_url":"https://api.github.com/users/stu-gott/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":583175137,"node_id":"MDU6TGFiZWw1ODMxNzUxMzc=","url":"https://api.github.com/repos/kubevirt/kubevirt/labels/size/L","name":"size/L","color":"ee9900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubevirt/kubevirt/pulls/1386/commits","review_comments_url":"https://api.github.com/repos/kubevirt/kubevirt/pulls/1386/comments","review_comment_url":"https://api.github.com/repos/kubevirt/kubevirt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubevirt/kubevirt/issues/1386/comments","statuses_url":"https://api.github.com/repos/kubevirt/kubevirt/statuses/aa86e12283ffb46f63b132a28a980c0c1bfe3a6c","head":{"label":"rmohr:packaging","ref":"packaging","sha":"aa86e12283ffb46f63b132a28a980c0c1bfe3a6c","user":{"login":"rmohr","id":4534621,"node_id":"MDQ6VXNlcjQ1MzQ2MjE=","avatar_url":"https://avatars3.githubusercontent.com/u/4534621?v=4","gravatar_id":"","url":"https://api.github.com/users/rmohr","html_url":"https://github.com/rmohr","followers_url":"https://api.github.com/users/rmohr/followers","following_url":"https://api.github.com/users/rmohr/following{/other_user}","gists_url":"https://api.github.com/users/rmohr/gists{/gist_id}","starred_url":"https://api.github.com/users/rmohr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmohr/subscriptions","organizations_url":"https://api.github.com/users/rmohr/orgs","repos_url":"https://api.github.com/users/rmohr/repos","events_url":"https://api.github.com/users/rmohr/events{/privacy}","received_events_url":"https://api.github.com/users/rmohr/received_events","type":"User","site_admin":false},"repo":{"id":76846344,"node_id":"MDEwOlJlcG9zaXRvcnk3Njg0NjM0NA==","name":"kubevirt","full_name":"rmohr/kubevirt","owner":{"login":"rmohr","id":4534621,"node_id":"MDQ6VXNlcjQ1MzQ2MjE=","avatar_url":"https://avatars3.githubusercontent.com/u/4534621?v=4","gravatar_id":"","url":"https://api.github.com/users/rmohr","html_url":"https://github.com/rmohr","followers_url":"https://api.github.com/users/rmohr/followers","following_url":"https://api.github.com/users/rmohr/following{/other_user}","gists_url":"https://api.github.com/users/rmohr/gists{/gist_id}","starred_url":"https://api.github.com/users/rmohr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmohr/subscriptions","organizations_url":"https://api.github.com/users/rmohr/orgs","repos_url":"https://api.github.com/users/rmohr/repos","events_url":"https://api.github.com/users/rmohr/events{/privacy}","received_events_url":"https://api.github.com/users/rmohr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rmohr/kubevirt","description":"KubeVirt is a virtual machine management architecture built around Kubernetes.","fork":true,"url":"https://api.github.com/repos/rmohr/kubevirt","forks_url":"https://api.github.com/repos/rmohr/kubevirt/forks","keys_url":"https://api.github.com/repos/rmohr/kubevirt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rmohr/kubevirt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rmohr/kubevirt/teams","hooks_url":"https://api.github.com/repos/rmohr/kubevirt/hooks","issue_events_url":"https://api.github.com/repos/rmohr/kubevirt/issues/events{/number}","events_url":"https://api.github.com/repos/rmohr/kubevirt/events","assignees_url":"https://api.github.com/repos/rmohr/kubevirt/assignees{/user}","branches_url":"https://api.github.com/repos/rmohr/kubevirt/branches{/branch}","tags_url":"https://api.github.com/repos/rmohr/kubevirt/tags","blobs_url":"https://api.github.com/repos/rmohr/kubevirt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rmohr/kubevirt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rmohr/kubevirt/git/refs{/sha}","trees_url":"https://api.github.com/repos/rmohr/kubevirt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rmohr/kubevirt/statuses/{sha}","languages_url":"https://api.github.com/repos/rmohr/kubevirt/languages","stargazers_url":"https://api.github.com/repos/rmohr/kubevirt/stargazers","contributors_url":"https://api.github.com/repos/rmohr/kubevirt/contributors","subscribers_url":"https://api.github.com/repos/rmohr/kubevirt/subscribers","subscription_url":"https://api.github.com/repos/rmohr/kubevirt/subscription","commits_url":"https://api.github.com/repos/rmohr/kubevirt/commits{/sha}","git_commits_url":"https://api.github.com/repos/rmohr/kubevirt/git/commits{/sha}","comments_url":"https://api.github.com/repos/rmohr/kubevirt/comments{/number}","issue_comment_url":"https://api.github.com/repos/rmohr/kubevirt/issues/comments{/number}","contents_url":"https://api.github.com/repos/rmohr/kubevirt/contents/{+path}","compare_url":"https://api.github.com/repos/rmohr/kubevirt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rmohr/kubevirt/merges","archive_url":"https://api.github.com/repos/rmohr/kubevirt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rmohr/kubevirt/downloads","issues_url":"https://api.github.com/repos/rmohr/kubevirt/issues{/number}","pulls_url":"https://api.github.com/repos/rmohr/kubevirt/pulls{/number}","milestones_url":"https://api.github.com/repos/rmohr/kubevirt/milestones{/number}","notifications_url":"https://api.github.com/repos/rmohr/kubevirt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rmohr/kubevirt/labels{/name}","releases_url":"https://api.github.com/repos/rmohr/kubevirt/releases{/id}","deployments_url":"https://api.github.com/repos/rmohr/kubevirt/deployments","created_at":"2016-12-19T09:10:20Z","updated_at":"2018-06-18T07:10:57Z","pushed_at":"2018-07-30T12:43:43Z","git_url":"git://github.com/rmohr/kubevirt.git","ssh_url":"git@github.com:rmohr/kubevirt.git","clone_url":"https://github.com/rmohr/kubevirt.git","svn_url":"https://github.com/rmohr/kubevirt","homepage":null,"size":99253,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":7,"watchers":0,"default_branch":"master"}},"base":{"label":"kubevirt:master","ref":"master","sha":"91b6ae4614d4d3039d4b7216f5a70c0f29b6ba7e","user":{"login":"kubevirt","id":18700703,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NzAwNzAz","avatar_url":"https://avatars1.githubusercontent.com/u/18700703?v=4","gravatar_id":"","url":"https://api.github.com/users/kubevirt","html_url":"https://github.com/kubevirt","followers_url":"https://api.github.com/users/kubevirt/followers","following_url":"https://api.github.com/users/kubevirt/following{/other_user}","gists_url":"https://api.github.com/users/kubevirt/gists{/gist_id}","starred_url":"https://api.github.com/users/kubevirt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubevirt/subscriptions","organizations_url":"https://api.github.com/users/kubevirt/orgs","repos_url":"https://api.github.com/users/kubevirt/repos","events_url":"https://api.github.com/users/kubevirt/events{/privacy}","received_events_url":"https://api.github.com/users/kubevirt/received_events","type":"Organization","site_admin":false},"repo":{"id":76686583,"node_id":"MDEwOlJlcG9zaXRvcnk3NjY4NjU4Mw==","name":"kubevirt","full_name":"kubevirt/kubevirt","owner":{"login":"kubevirt","id":18700703,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NzAwNzAz","avatar_url":"https://avatars1.githubusercontent.com/u/18700703?v=4","gravatar_id":"","url":"https://api.github.com/users/kubevirt","html_url":"https://github.com/kubevirt","followers_url":"https://api.github.com/users/kubevirt/followers","following_url":"https://api.github.com/users/kubevirt/following{/other_user}","gists_url":"https://api.github.com/users/kubevirt/gists{/gist_id}","starred_url":"https://api.github.com/users/kubevirt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubevirt/subscriptions","organizations_url":"https://api.github.com/users/kubevirt/orgs","repos_url":"https://api.github.com/users/kubevirt/repos","events_url":"https://api.github.com/users/kubevirt/events{/privacy}","received_events_url":"https://api.github.com/users/kubevirt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubevirt/kubevirt","description":"Kubernetes Virtualization Operator with API and runtime in order to define and manage virtual machines.","fork":false,"url":"https://api.github.com/repos/kubevirt/kubevirt","forks_url":"https://api.github.com/repos/kubevirt/kubevirt/forks","keys_url":"https://api.github.com/repos/kubevirt/kubevirt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubevirt/kubevirt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubevirt/kubevirt/teams","hooks_url":"https://api.github.com/repos/kubevirt/kubevirt/hooks","issue_events_url":"https://api.github.com/repos/kubevirt/kubevirt/issues/events{/number}","events_url":"https://api.github.com/repos/kubevirt/kubevirt/events","assignees_url":"https://api.github.com/repos/kubevirt/kubevirt/assignees{/user}","branches_url":"https://api.github.com/repos/kubevirt/kubevirt/branches{/branch}","tags_url":"https://api.github.com/repos/kubevirt/kubevirt/tags","blobs_url":"https://api.github.com/repos/kubevirt/kubevirt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubevirt/kubevirt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubevirt/kubevirt/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubevirt/kubevirt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubevirt/kubevirt/statuses/{sha}","languages_url":"https://api.github.com/repos/kubevirt/kubevirt/languages","stargazers_url":"https://api.github.com/repos/kubevirt/kubevirt/stargazers","contributors_url":"https://api.github.com/repos/kubevirt/kubevirt/contributors","subscribers_url":"https://api.github.com/repos/kubevirt/kubevirt/subscribers","subscription_url":"https://api.github.com/repos/kubevirt/kubevirt/subscription","commits_url":"https://api.github.com/repos/kubevirt/kubevirt/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubevirt/kubevirt/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubevirt/kubevirt/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubevirt/kubevirt/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubevirt/kubevirt/contents/{+path}","compare_url":"https://api.github.com/repos/kubevirt/kubevirt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubevirt/kubevirt/merges","archive_url":"https://api.github.com/repos/kubevirt/kubevirt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubevirt/kubevirt/downloads","issues_url":"https://api.github.com/repos/kubevirt/kubevirt/issues{/number}","pulls_url":"https://api.github.com/repos/kubevirt/kubevirt/pulls{/number}","milestones_url":"https://api.github.com/repos/kubevirt/kubevirt/milestones{/number}","notifications_url":"https://api.github.com/repos/kubevirt/kubevirt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubevirt/kubevirt/labels{/name}","releases_url":"https://api.github.com/repos/kubevirt/kubevirt/releases{/id}","deployments_url":"https://api.github.com/repos/kubevirt/kubevirt/deployments","created_at":"2016-12-16T21:24:26Z","updated_at":"2018-07-30T19:15:11Z","pushed_at":"2018-07-30T18:48:28Z","git_url":"git://github.com/kubevirt/kubevirt.git","ssh_url":"git@github.com:kubevirt/kubevirt.git","clone_url":"https://github.com/kubevirt/kubevirt.git","svn_url":"https://github.com/kubevirt/kubevirt","homepage":"","size":83561,"stargazers_count":770,"watchers_count":770,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":162,"mirror_url":null,"archived":false,"open_issues_count":154,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":162,"open_issues":154,"watchers":770,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubevirt/kubevirt/pulls/1386"},"html":{"href":"https://github.com/kubevirt/kubevirt/pull/1386"},"issue":{"href":"https://api.github.com/repos/kubevirt/kubevirt/issues/1386"},"comments":{"href":"https://api.github.com/repos/kubevirt/kubevirt/issues/1386/comments"},"review_comments":{"href":"https://api.github.com/repos/kubevirt/kubevirt/pulls/1386/comments"},"review_comment":{"href":"https://api.github.com/repos/kubevirt/kubevirt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubevirt/kubevirt/pulls/1386/commits"},"statuses":{"href":"https://api.github.com/repos/kubevirt/kubevirt/statuses/aa86e12283ffb46f63b132a28a980c0c1bfe3a6c"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"davidvossel"}}