{"action":"created","comment":{"url":"https://api.github.com/repos/iotaledger/entangled/pulls/comments/236335444","pull_request_review_id":178387445,"id":236335444,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjMzNTQ0NA==","diff_hunk":"@@ -300,16 +307,22 @@ retcode_t mam2_send_msg(mam2_send_msg_context *cfg, trits_t *msg) {\n       err_guard(!(trits_size(*msg) < msg_size), RC_MAM2_BUFFER_TOO_SMALL);\n     b = msg;\n \n-    if (cfg->ep)\n-      mss_skn(cfg->ep->m, skn);\n-    else\n-      mss_skn(cfg->ch->m, skn);\n+    // FIXME (@tsvisabo) - uncomment\n+    if (cfg->ep) {\n+      // mss_skn(cfg->ep->m, skn);\n+    } else {\n+      // mss_skn(cfg->ch->m, skn);\n+    }\n \n     // TODO Remove when mam handles flex_trits\n-    trits_t cfg_ch = mam2_channel_name(cfg->ch);\n-    TRIT_ARRAY_MAKE_FROM_RAW(ch, cfg_ch.n - cfg_ch.d, cfg_ch.p + cfg_ch.d);\n-    trits_t cfg_ep = cfg->ep ? mam2_endpoint_name(cfg->ep) : trits_null();\n-    TRIT_ARRAY_MAKE_FROM_RAW(ep, cfg_ep.n - cfg_ep.d, cfg_ep.p + cfg_ep.d);\n+    trit_array_t ch = mam2_channel_name(cfg->ch);\n+    trit_array_t ep;\n+    if (cfg->ep) {\n+      ep = mam2_endpoint_name(cfg->ep);\n+    } else {\n+      ep.num_trits = 0;\n+      ep.trits = 0;","path":"mam/v2/mam.c","position":129,"original_position":129,"commit_id":"c8f1329f43a4086a686c4f84792c99e3882877ef","original_commit_id":"c8f1329f43a4086a686c4f84792c99e3882877ef","user":{"login":"thibault-martinez","id":3305068,"node_id":"MDQ6VXNlcjMzMDUwNjg=","avatar_url":"https://avatars1.githubusercontent.com/u/3305068?v=4","gravatar_id":"","url":"https://api.github.com/users/thibault-martinez","html_url":"https://github.com/thibault-martinez","followers_url":"https://api.github.com/users/thibault-martinez/followers","following_url":"https://api.github.com/users/thibault-martinez/following{/other_user}","gists_url":"https://api.github.com/users/thibault-martinez/gists{/gist_id}","starred_url":"https://api.github.com/users/thibault-martinez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thibault-martinez/subscriptions","organizations_url":"https://api.github.com/users/thibault-martinez/orgs","repos_url":"https://api.github.com/users/thibault-martinez/repos","events_url":"https://api.github.com/users/thibault-martinez/events{/privacy}","received_events_url":"https://api.github.com/users/thibault-martinez/received_events","type":"User","site_admin":false},"body":"Maybe set `ep.num_bytes = 0` as well in case we rely on it ?\r\nAlso, `ep.trits = NULL;`","created_at":"2018-11-26T16:48:25Z","updated_at":"2018-11-26T16:59:12Z","html_url":"https://github.com/iotaledger/entangled/pull/563#discussion_r236335444","pull_request_url":"https://api.github.com/repos/iotaledger/entangled/pulls/563","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/iotaledger/entangled/pulls/comments/236335444"},"html":{"href":"https://github.com/iotaledger/entangled/pull/563#discussion_r236335444"},"pull_request":{"href":"https://api.github.com/repos/iotaledger/entangled/pulls/563"}}},"pull_request":{"url":"https://api.github.com/repos/iotaledger/entangled/pulls/563","id":233566807,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzNTY2ODA3","html_url":"https://github.com/iotaledger/entangled/pull/563","diff_url":"https://github.com/iotaledger/entangled/pull/563.diff","patch_url":"https://github.com/iotaledger/entangled/pull/563.patch","issue_url":"https://api.github.com/repos/iotaledger/entangled/issues/563","number":563,"state":"open","locked":false,"title":"Mam mss verify and sign","user":{"login":"tsvisabo","id":37177579,"node_id":"MDQ6VXNlcjM3MTc3NTc5","avatar_url":"https://avatars3.githubusercontent.com/u/37177579?v=4","gravatar_id":"","url":"https://api.github.com/users/tsvisabo","html_url":"https://github.com/tsvisabo","followers_url":"https://api.github.com/users/tsvisabo/followers","following_url":"https://api.github.com/users/tsvisabo/following{/other_user}","gists_url":"https://api.github.com/users/tsvisabo/gists{/gist_id}","starred_url":"https://api.github.com/users/tsvisabo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsvisabo/subscriptions","organizations_url":"https://api.github.com/users/tsvisabo/orgs","repos_url":"https://api.github.com/users/tsvisabo/repos","events_url":"https://api.github.com/users/tsvisabo/events{/privacy}","received_events_url":"https://api.github.com/users/tsvisabo/received_events","type":"User","site_admin":false},"body":"- A bunch of trits_t replaced by flex_trits","created_at":"2018-11-26T13:58:15Z","updated_at":"2018-11-26T16:59:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"51004286916fdfb5f77121afb0aff17d8192dfbb","assignee":null,"assignees":[],"requested_reviewers":[{"login":"th0br0","id":30996,"node_id":"MDQ6VXNlcjMwOTk2","avatar_url":"https://avatars0.githubusercontent.com/u/30996?v=4","gravatar_id":"","url":"https://api.github.com/users/th0br0","html_url":"https://github.com/th0br0","followers_url":"https://api.github.com/users/th0br0/followers","following_url":"https://api.github.com/users/th0br0/following{/other_user}","gists_url":"https://api.github.com/users/th0br0/gists{/gist_id}","starred_url":"https://api.github.com/users/th0br0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/th0br0/subscriptions","organizations_url":"https://api.github.com/users/th0br0/orgs","repos_url":"https://api.github.com/users/th0br0/repos","events_url":"https://api.github.com/users/th0br0/events{/privacy}","received_events_url":"https://api.github.com/users/th0br0/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/iotaledger/entangled/pulls/563/commits","review_comments_url":"https://api.github.com/repos/iotaledger/entangled/pulls/563/comments","review_comment_url":"https://api.github.com/repos/iotaledger/entangled/pulls/comments{/number}","comments_url":"https://api.github.com/repos/iotaledger/entangled/issues/563/comments","statuses_url":"https://api.github.com/repos/iotaledger/entangled/statuses/c8f1329f43a4086a686c4f84792c99e3882877ef","head":{"label":"tsvisabo:mam_mss_verify_and_sign","ref":"mam_mss_verify_and_sign","sha":"c8f1329f43a4086a686c4f84792c99e3882877ef","user":{"login":"tsvisabo","id":37177579,"node_id":"MDQ6VXNlcjM3MTc3NTc5","avatar_url":"https://avatars3.githubusercontent.com/u/37177579?v=4","gravatar_id":"","url":"https://api.github.com/users/tsvisabo","html_url":"https://github.com/tsvisabo","followers_url":"https://api.github.com/users/tsvisabo/followers","following_url":"https://api.github.com/users/tsvisabo/following{/other_user}","gists_url":"https://api.github.com/users/tsvisabo/gists{/gist_id}","starred_url":"https://api.github.com/users/tsvisabo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsvisabo/subscriptions","organizations_url":"https://api.github.com/users/tsvisabo/orgs","repos_url":"https://api.github.com/users/tsvisabo/repos","events_url":"https://api.github.com/users/tsvisabo/events{/privacy}","received_events_url":"https://api.github.com/users/tsvisabo/received_events","type":"User","site_admin":false},"repo":{"id":137086877,"node_id":"MDEwOlJlcG9zaXRvcnkxMzcwODY4Nzc=","name":"entangled","full_name":"tsvisabo/entangled","private":false,"owner":{"login":"tsvisabo","id":37177579,"node_id":"MDQ6VXNlcjM3MTc3NTc5","avatar_url":"https://avatars3.githubusercontent.com/u/37177579?v=4","gravatar_id":"","url":"https://api.github.com/users/tsvisabo","html_url":"https://github.com/tsvisabo","followers_url":"https://api.github.com/users/tsvisabo/followers","following_url":"https://api.github.com/users/tsvisabo/following{/other_user}","gists_url":"https://api.github.com/users/tsvisabo/gists{/gist_id}","starred_url":"https://api.github.com/users/tsvisabo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsvisabo/subscriptions","organizations_url":"https://api.github.com/users/tsvisabo/orgs","repos_url":"https://api.github.com/users/tsvisabo/repos","events_url":"https://api.github.com/users/tsvisabo/events{/privacy}","received_events_url":"https://api.github.com/users/tsvisabo/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tsvisabo/entangled","description":null,"fork":true,"url":"https://api.github.com/repos/tsvisabo/entangled","forks_url":"https://api.github.com/repos/tsvisabo/entangled/forks","keys_url":"https://api.github.com/repos/tsvisabo/entangled/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tsvisabo/entangled/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tsvisabo/entangled/teams","hooks_url":"https://api.github.com/repos/tsvisabo/entangled/hooks","issue_events_url":"https://api.github.com/repos/tsvisabo/entangled/issues/events{/number}","events_url":"https://api.github.com/repos/tsvisabo/entangled/events","assignees_url":"https://api.github.com/repos/tsvisabo/entangled/assignees{/user}","branches_url":"https://api.github.com/repos/tsvisabo/entangled/branches{/branch}","tags_url":"https://api.github.com/repos/tsvisabo/entangled/tags","blobs_url":"https://api.github.com/repos/tsvisabo/entangled/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tsvisabo/entangled/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tsvisabo/entangled/git/refs{/sha}","trees_url":"https://api.github.com/repos/tsvisabo/entangled/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tsvisabo/entangled/statuses/{sha}","languages_url":"https://api.github.com/repos/tsvisabo/entangled/languages","stargazers_url":"https://api.github.com/repos/tsvisabo/entangled/stargazers","contributors_url":"https://api.github.com/repos/tsvisabo/entangled/contributors","subscribers_url":"https://api.github.com/repos/tsvisabo/entangled/subscribers","subscription_url":"https://api.github.com/repos/tsvisabo/entangled/subscription","commits_url":"https://api.github.com/repos/tsvisabo/entangled/commits{/sha}","git_commits_url":"https://api.github.com/repos/tsvisabo/entangled/git/commits{/sha}","comments_url":"https://api.github.com/repos/tsvisabo/entangled/comments{/number}","issue_comment_url":"https://api.github.com/repos/tsvisabo/entangled/issues/comments{/number}","contents_url":"https://api.github.com/repos/tsvisabo/entangled/contents/{+path}","compare_url":"https://api.github.com/repos/tsvisabo/entangled/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tsvisabo/entangled/merges","archive_url":"https://api.github.com/repos/tsvisabo/entangled/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tsvisabo/entangled/downloads","issues_url":"https://api.github.com/repos/tsvisabo/entangled/issues{/number}","pulls_url":"https://api.github.com/repos/tsvisabo/entangled/pulls{/number}","milestones_url":"https://api.github.com/repos/tsvisabo/entangled/milestones{/number}","notifications_url":"https://api.github.com/repos/tsvisabo/entangled/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tsvisabo/entangled/labels{/name}","releases_url":"https://api.github.com/repos/tsvisabo/entangled/releases{/id}","deployments_url":"https://api.github.com/repos/tsvisabo/entangled/deployments","created_at":"2018-06-12T14:51:30Z","updated_at":"2018-07-03T08:59:13Z","pushed_at":"2018-11-26T15:11:43Z","git_url":"git://github.com/tsvisabo/entangled.git","ssh_url":"git@github.com:tsvisabo/entangled.git","clone_url":"https://github.com/tsvisabo/entangled.git","svn_url":"https://github.com/tsvisabo/entangled","homepage":null,"size":3208,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"iotaledger:develop","ref":"develop","sha":"678aaae05f79566e12adcd343ee15ef6cdf32dfd","user":{"login":"iotaledger","id":20126597,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMTI2NTk3","avatar_url":"https://avatars3.githubusercontent.com/u/20126597?v=4","gravatar_id":"","url":"https://api.github.com/users/iotaledger","html_url":"https://github.com/iotaledger","followers_url":"https://api.github.com/users/iotaledger/followers","following_url":"https://api.github.com/users/iotaledger/following{/other_user}","gists_url":"https://api.github.com/users/iotaledger/gists{/gist_id}","starred_url":"https://api.github.com/users/iotaledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iotaledger/subscriptions","organizations_url":"https://api.github.com/users/iotaledger/orgs","repos_url":"https://api.github.com/users/iotaledger/repos","events_url":"https://api.github.com/users/iotaledger/events{/privacy}","received_events_url":"https://api.github.com/users/iotaledger/received_events","type":"Organization","site_admin":false},"repo":{"id":137051507,"node_id":"MDEwOlJlcG9zaXRvcnkxMzcwNTE1MDc=","name":"entangled","full_name":"iotaledger/entangled","private":false,"owner":{"login":"iotaledger","id":20126597,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMTI2NTk3","avatar_url":"https://avatars3.githubusercontent.com/u/20126597?v=4","gravatar_id":"","url":"https://api.github.com/users/iotaledger","html_url":"https://github.com/iotaledger","followers_url":"https://api.github.com/users/iotaledger/followers","following_url":"https://api.github.com/users/iotaledger/following{/other_user}","gists_url":"https://api.github.com/users/iotaledger/gists{/gist_id}","starred_url":"https://api.github.com/users/iotaledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iotaledger/subscriptions","organizations_url":"https://api.github.com/users/iotaledger/orgs","repos_url":"https://api.github.com/users/iotaledger/repos","events_url":"https://api.github.com/users/iotaledger/events{/privacy}","received_events_url":"https://api.github.com/users/iotaledger/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/iotaledger/entangled","description":"enTangle'd is an amalgamation of all things Tangle","fork":false,"url":"https://api.github.com/repos/iotaledger/entangled","forks_url":"https://api.github.com/repos/iotaledger/entangled/forks","keys_url":"https://api.github.com/repos/iotaledger/entangled/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iotaledger/entangled/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iotaledger/entangled/teams","hooks_url":"https://api.github.com/repos/iotaledger/entangled/hooks","issue_events_url":"https://api.github.com/repos/iotaledger/entangled/issues/events{/number}","events_url":"https://api.github.com/repos/iotaledger/entangled/events","assignees_url":"https://api.github.com/repos/iotaledger/entangled/assignees{/user}","branches_url":"https://api.github.com/repos/iotaledger/entangled/branches{/branch}","tags_url":"https://api.github.com/repos/iotaledger/entangled/tags","blobs_url":"https://api.github.com/repos/iotaledger/entangled/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iotaledger/entangled/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iotaledger/entangled/git/refs{/sha}","trees_url":"https://api.github.com/repos/iotaledger/entangled/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iotaledger/entangled/statuses/{sha}","languages_url":"https://api.github.com/repos/iotaledger/entangled/languages","stargazers_url":"https://api.github.com/repos/iotaledger/entangled/stargazers","contributors_url":"https://api.github.com/repos/iotaledger/entangled/contributors","subscribers_url":"https://api.github.com/repos/iotaledger/entangled/subscribers","subscription_url":"https://api.github.com/repos/iotaledger/entangled/subscription","commits_url":"https://api.github.com/repos/iotaledger/entangled/commits{/sha}","git_commits_url":"https://api.github.com/repos/iotaledger/entangled/git/commits{/sha}","comments_url":"https://api.github.com/repos/iotaledger/entangled/comments{/number}","issue_comment_url":"https://api.github.com/repos/iotaledger/entangled/issues/comments{/number}","contents_url":"https://api.github.com/repos/iotaledger/entangled/contents/{+path}","compare_url":"https://api.github.com/repos/iotaledger/entangled/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iotaledger/entangled/merges","archive_url":"https://api.github.com/repos/iotaledger/entangled/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iotaledger/entangled/downloads","issues_url":"https://api.github.com/repos/iotaledger/entangled/issues{/number}","pulls_url":"https://api.github.com/repos/iotaledger/entangled/pulls{/number}","milestones_url":"https://api.github.com/repos/iotaledger/entangled/milestones{/number}","notifications_url":"https://api.github.com/repos/iotaledger/entangled/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iotaledger/entangled/labels{/name}","releases_url":"https://api.github.com/repos/iotaledger/entangled/releases{/id}","deployments_url":"https://api.github.com/repos/iotaledger/entangled/deployments","created_at":"2018-06-12T09:49:47Z","updated_at":"2018-11-26T08:05:45Z","pushed_at":"2018-11-26T15:11:45Z","git_url":"git://github.com/iotaledger/entangled.git","ssh_url":"git@github.com:iotaledger/entangled.git","clone_url":"https://github.com/iotaledger/entangled.git","svn_url":"https://github.com/iotaledger/entangled","homepage":"","size":2197,"stargazers_count":44,"watchers_count":44,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":36,"mirror_url":null,"archived":false,"open_issues_count":111,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":36,"open_issues":111,"watchers":44,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/iotaledger/entangled/pulls/563"},"html":{"href":"https://github.com/iotaledger/entangled/pull/563"},"issue":{"href":"https://api.github.com/repos/iotaledger/entangled/issues/563"},"comments":{"href":"https://api.github.com/repos/iotaledger/entangled/issues/563/comments"},"review_comments":{"href":"https://api.github.com/repos/iotaledger/entangled/pulls/563/comments"},"review_comment":{"href":"https://api.github.com/repos/iotaledger/entangled/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/iotaledger/entangled/pulls/563/commits"},"statuses":{"href":"https://api.github.com/repos/iotaledger/entangled/statuses/c8f1329f43a4086a686c4f84792c99e3882877ef"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"thibault-martinez"}}