{"action":"created","comment":{"url":"https://api.github.com/repos/Perryvw/TypescriptToLua/pulls/comments/205939203","pull_request_review_id":141313221,"id":205939203,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNTkzOTIwMw==","diff_hunk":"@@ -0,0 +1,31 @@\n+import { Expect, Test, TestCase } from \"alsatian\";\n+import * as util from \"../src/util\";\n+import { LuaTarget } from \"../../src/Transpiler\";\n+\n+export class AssignmentDestructuringTests {\n+    \n+    private readonly assignmentDestruturingTs = `\n+    declare function myFunc(): [number, string];","path":"test/unit/assignmentDestructuring.spec.ts","position":8,"original_position":8,"commit_id":"4b5a78710641bf27a036fa450459d98673382242","original_commit_id":"4b5a78710641bf27a036fa450459d98673382242","user":{"login":"Janne252","id":4705573,"node_id":"MDQ6VXNlcjQ3MDU1NzM=","avatar_url":"https://avatars3.githubusercontent.com/u/4705573?v=4","gravatar_id":"","url":"https://api.github.com/users/Janne252","html_url":"https://github.com/Janne252","followers_url":"https://api.github.com/users/Janne252/followers","following_url":"https://api.github.com/users/Janne252/following{/other_user}","gists_url":"https://api.github.com/users/Janne252/gists{/gist_id}","starred_url":"https://api.github.com/users/Janne252/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Janne252/subscriptions","organizations_url":"https://api.github.com/users/Janne252/orgs","repos_url":"https://api.github.com/users/Janne252/repos","events_url":"https://api.github.com/users/Janne252/events{/privacy}","received_events_url":"https://api.github.com/users/Janne252/received_events","type":"User","site_admin":false},"body":"Is it okay to disable `tslint` for `./test` for now (as demonstrated above)? I'm using VS Code and it's rather obtrusive to have the test files full of errors. Unless a path's severity can be forced to \"suggestion\"?","created_at":"2018-07-28T10:00:27Z","updated_at":"2018-07-28T10:00:27Z","html_url":"https://github.com/Perryvw/TypescriptToLua/pull/158#discussion_r205939203","pull_request_url":"https://api.github.com/repos/Perryvw/TypescriptToLua/pulls/158","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Perryvw/TypescriptToLua/pulls/comments/205939203"},"html":{"href":"https://github.com/Perryvw/TypescriptToLua/pull/158#discussion_r205939203"},"pull_request":{"href":"https://api.github.com/repos/Perryvw/TypescriptToLua/pulls/158"}},"in_reply_to_id":205937975},"pull_request":{"url":"https://api.github.com/repos/Perryvw/TypescriptToLua/pulls/158","id":204561244,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0NTYxMjQ0","html_url":"https://github.com/Perryvw/TypescriptToLua/pull/158","diff_url":"https://github.com/Perryvw/TypescriptToLua/pull/158.diff","patch_url":"https://github.com/Perryvw/TypescriptToLua/pull/158.patch","issue_url":"https://api.github.com/repos/Perryvw/TypescriptToLua/issues/158","number":158,"state":"open","locked":false,"title":"Fix variable destructuring compatibility issue with lua 5.1","user":{"login":"Janne252","id":4705573,"node_id":"MDQ6VXNlcjQ3MDU1NzM=","avatar_url":"https://avatars3.githubusercontent.com/u/4705573?v=4","gravatar_id":"","url":"https://api.github.com/users/Janne252","html_url":"https://github.com/Janne252","followers_url":"https://api.github.com/users/Janne252/followers","following_url":"https://api.github.com/users/Janne252/following{/other_user}","gists_url":"https://api.github.com/users/Janne252/gists{/gist_id}","starred_url":"https://api.github.com/users/Janne252/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Janne252/subscriptions","organizations_url":"https://api.github.com/users/Janne252/orgs","repos_url":"https://api.github.com/users/Janne252/repos","events_url":"https://api.github.com/users/Janne252/events{/privacy}","received_events_url":"https://api.github.com/users/Janne252/received_events","type":"User","site_admin":false},"body":"Fixes:\r\n - https://github.com/Perryvw/TypescriptToLua/issues/157\r\n\r\nReplaces:\r\n- https://github.com/Perryvw/TypescriptToLua/pull/141\r\n\r\n\r\nI added tests for `luaTarget` **5.1**, **5.2**, **5.3**, and **JIT**. Technically only the tests for 5.1 and 5.2 matter as Transpilers 5.3 and JIT don't override `transpileVariableDestructuring`, so they might be a bit excessive.\r\n\r\nEdit: There seems to be an issue reported by `continuous-integration/appveyor/p`, that error didn't occur while running `npm run test-threaded`, only with `npm run test`. Investigating...","created_at":"2018-07-27T23:33:28Z","updated_at":"2018-07-28T10:00:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f4b9fb3552e84d11ac7c5392d2d25c3003a39d2a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Perryvw/TypescriptToLua/pulls/158/commits","review_comments_url":"https://api.github.com/repos/Perryvw/TypescriptToLua/pulls/158/comments","review_comment_url":"https://api.github.com/repos/Perryvw/TypescriptToLua/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Perryvw/TypescriptToLua/issues/158/comments","statuses_url":"https://api.github.com/repos/Perryvw/TypescriptToLua/statuses/4b5a78710641bf27a036fa450459d98673382242","head":{"label":"Janne252:master","ref":"master","sha":"4b5a78710641bf27a036fa450459d98673382242","user":{"login":"Janne252","id":4705573,"node_id":"MDQ6VXNlcjQ3MDU1NzM=","avatar_url":"https://avatars3.githubusercontent.com/u/4705573?v=4","gravatar_id":"","url":"https://api.github.com/users/Janne252","html_url":"https://github.com/Janne252","followers_url":"https://api.github.com/users/Janne252/followers","following_url":"https://api.github.com/users/Janne252/following{/other_user}","gists_url":"https://api.github.com/users/Janne252/gists{/gist_id}","starred_url":"https://api.github.com/users/Janne252/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Janne252/subscriptions","organizations_url":"https://api.github.com/users/Janne252/orgs","repos_url":"https://api.github.com/users/Janne252/repos","events_url":"https://api.github.com/users/Janne252/events{/privacy}","received_events_url":"https://api.github.com/users/Janne252/received_events","type":"User","site_admin":false},"repo":{"id":142631599,"node_id":"MDEwOlJlcG9zaXRvcnkxNDI2MzE1OTk=","name":"TypescriptToLua","full_name":"Janne252/TypescriptToLua","owner":{"login":"Janne252","id":4705573,"node_id":"MDQ6VXNlcjQ3MDU1NzM=","avatar_url":"https://avatars3.githubusercontent.com/u/4705573?v=4","gravatar_id":"","url":"https://api.github.com/users/Janne252","html_url":"https://github.com/Janne252","followers_url":"https://api.github.com/users/Janne252/followers","following_url":"https://api.github.com/users/Janne252/following{/other_user}","gists_url":"https://api.github.com/users/Janne252/gists{/gist_id}","starred_url":"https://api.github.com/users/Janne252/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Janne252/subscriptions","organizations_url":"https://api.github.com/users/Janne252/orgs","repos_url":"https://api.github.com/users/Janne252/repos","events_url":"https://api.github.com/users/Janne252/events{/privacy}","received_events_url":"https://api.github.com/users/Janne252/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Janne252/TypescriptToLua","description":"Typescript to lua transpiler.","fork":true,"url":"https://api.github.com/repos/Janne252/TypescriptToLua","forks_url":"https://api.github.com/repos/Janne252/TypescriptToLua/forks","keys_url":"https://api.github.com/repos/Janne252/TypescriptToLua/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Janne252/TypescriptToLua/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Janne252/TypescriptToLua/teams","hooks_url":"https://api.github.com/repos/Janne252/TypescriptToLua/hooks","issue_events_url":"https://api.github.com/repos/Janne252/TypescriptToLua/issues/events{/number}","events_url":"https://api.github.com/repos/Janne252/TypescriptToLua/events","assignees_url":"https://api.github.com/repos/Janne252/TypescriptToLua/assignees{/user}","branches_url":"https://api.github.com/repos/Janne252/TypescriptToLua/branches{/branch}","tags_url":"https://api.github.com/repos/Janne252/TypescriptToLua/tags","blobs_url":"https://api.github.com/repos/Janne252/TypescriptToLua/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Janne252/TypescriptToLua/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Janne252/TypescriptToLua/git/refs{/sha}","trees_url":"https://api.github.com/repos/Janne252/TypescriptToLua/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Janne252/TypescriptToLua/statuses/{sha}","languages_url":"https://api.github.com/repos/Janne252/TypescriptToLua/languages","stargazers_url":"https://api.github.com/repos/Janne252/TypescriptToLua/stargazers","contributors_url":"https://api.github.com/repos/Janne252/TypescriptToLua/contributors","subscribers_url":"https://api.github.com/repos/Janne252/TypescriptToLua/subscribers","subscription_url":"https://api.github.com/repos/Janne252/TypescriptToLua/subscription","commits_url":"https://api.github.com/repos/Janne252/TypescriptToLua/commits{/sha}","git_commits_url":"https://api.github.com/repos/Janne252/TypescriptToLua/git/commits{/sha}","comments_url":"https://api.github.com/repos/Janne252/TypescriptToLua/comments{/number}","issue_comment_url":"https://api.github.com/repos/Janne252/TypescriptToLua/issues/comments{/number}","contents_url":"https://api.github.com/repos/Janne252/TypescriptToLua/contents/{+path}","compare_url":"https://api.github.com/repos/Janne252/TypescriptToLua/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Janne252/TypescriptToLua/merges","archive_url":"https://api.github.com/repos/Janne252/TypescriptToLua/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Janne252/TypescriptToLua/downloads","issues_url":"https://api.github.com/repos/Janne252/TypescriptToLua/issues{/number}","pulls_url":"https://api.github.com/repos/Janne252/TypescriptToLua/pulls{/number}","milestones_url":"https://api.github.com/repos/Janne252/TypescriptToLua/milestones{/number}","notifications_url":"https://api.github.com/repos/Janne252/TypescriptToLua/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Janne252/TypescriptToLua/labels{/name}","releases_url":"https://api.github.com/repos/Janne252/TypescriptToLua/releases{/id}","deployments_url":"https://api.github.com/repos/Janne252/TypescriptToLua/deployments","created_at":"2018-07-27T23:27:35Z","updated_at":"2018-07-28T06:26:24Z","pushed_at":"2018-07-28T06:26:22Z","git_url":"git://github.com/Janne252/TypescriptToLua.git","ssh_url":"git@github.com:Janne252/TypescriptToLua.git","clone_url":"https://github.com/Janne252/TypescriptToLua.git","svn_url":"https://github.com/Janne252/TypescriptToLua","homepage":null,"size":939,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Perryvw:master","ref":"master","sha":"fda1683f0ad4d69a4d962ef2ba27f287cf3e590e","user":{"login":"Perryvw","id":7956873,"node_id":"MDQ6VXNlcjc5NTY4NzM=","avatar_url":"https://avatars1.githubusercontent.com/u/7956873?v=4","gravatar_id":"","url":"https://api.github.com/users/Perryvw","html_url":"https://github.com/Perryvw","followers_url":"https://api.github.com/users/Perryvw/followers","following_url":"https://api.github.com/users/Perryvw/following{/other_user}","gists_url":"https://api.github.com/users/Perryvw/gists{/gist_id}","starred_url":"https://api.github.com/users/Perryvw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Perryvw/subscriptions","organizations_url":"https://api.github.com/users/Perryvw/orgs","repos_url":"https://api.github.com/users/Perryvw/repos","events_url":"https://api.github.com/users/Perryvw/events{/privacy}","received_events_url":"https://api.github.com/users/Perryvw/received_events","type":"User","site_admin":false},"repo":{"id":115876595,"node_id":"MDEwOlJlcG9zaXRvcnkxMTU4NzY1OTU=","name":"TypescriptToLua","full_name":"Perryvw/TypescriptToLua","owner":{"login":"Perryvw","id":7956873,"node_id":"MDQ6VXNlcjc5NTY4NzM=","avatar_url":"https://avatars1.githubusercontent.com/u/7956873?v=4","gravatar_id":"","url":"https://api.github.com/users/Perryvw","html_url":"https://github.com/Perryvw","followers_url":"https://api.github.com/users/Perryvw/followers","following_url":"https://api.github.com/users/Perryvw/following{/other_user}","gists_url":"https://api.github.com/users/Perryvw/gists{/gist_id}","starred_url":"https://api.github.com/users/Perryvw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Perryvw/subscriptions","organizations_url":"https://api.github.com/users/Perryvw/orgs","repos_url":"https://api.github.com/users/Perryvw/repos","events_url":"https://api.github.com/users/Perryvw/events{/privacy}","received_events_url":"https://api.github.com/users/Perryvw/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Perryvw/TypescriptToLua","description":"Typescript to lua transpiler.","fork":false,"url":"https://api.github.com/repos/Perryvw/TypescriptToLua","forks_url":"https://api.github.com/repos/Perryvw/TypescriptToLua/forks","keys_url":"https://api.github.com/repos/Perryvw/TypescriptToLua/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Perryvw/TypescriptToLua/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Perryvw/TypescriptToLua/teams","hooks_url":"https://api.github.com/repos/Perryvw/TypescriptToLua/hooks","issue_events_url":"https://api.github.com/repos/Perryvw/TypescriptToLua/issues/events{/number}","events_url":"https://api.github.com/repos/Perryvw/TypescriptToLua/events","assignees_url":"https://api.github.com/repos/Perryvw/TypescriptToLua/assignees{/user}","branches_url":"https://api.github.com/repos/Perryvw/TypescriptToLua/branches{/branch}","tags_url":"https://api.github.com/repos/Perryvw/TypescriptToLua/tags","blobs_url":"https://api.github.com/repos/Perryvw/TypescriptToLua/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Perryvw/TypescriptToLua/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Perryvw/TypescriptToLua/git/refs{/sha}","trees_url":"https://api.github.com/repos/Perryvw/TypescriptToLua/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Perryvw/TypescriptToLua/statuses/{sha}","languages_url":"https://api.github.com/repos/Perryvw/TypescriptToLua/languages","stargazers_url":"https://api.github.com/repos/Perryvw/TypescriptToLua/stargazers","contributors_url":"https://api.github.com/repos/Perryvw/TypescriptToLua/contributors","subscribers_url":"https://api.github.com/repos/Perryvw/TypescriptToLua/subscribers","subscription_url":"https://api.github.com/repos/Perryvw/TypescriptToLua/subscription","commits_url":"https://api.github.com/repos/Perryvw/TypescriptToLua/commits{/sha}","git_commits_url":"https://api.github.com/repos/Perryvw/TypescriptToLua/git/commits{/sha}","comments_url":"https://api.github.com/repos/Perryvw/TypescriptToLua/comments{/number}","issue_comment_url":"https://api.github.com/repos/Perryvw/TypescriptToLua/issues/comments{/number}","contents_url":"https://api.github.com/repos/Perryvw/TypescriptToLua/contents/{+path}","compare_url":"https://api.github.com/repos/Perryvw/TypescriptToLua/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Perryvw/TypescriptToLua/merges","archive_url":"https://api.github.com/repos/Perryvw/TypescriptToLua/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Perryvw/TypescriptToLua/downloads","issues_url":"https://api.github.com/repos/Perryvw/TypescriptToLua/issues{/number}","pulls_url":"https://api.github.com/repos/Perryvw/TypescriptToLua/pulls{/number}","milestones_url":"https://api.github.com/repos/Perryvw/TypescriptToLua/milestones{/number}","notifications_url":"https://api.github.com/repos/Perryvw/TypescriptToLua/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Perryvw/TypescriptToLua/labels{/name}","releases_url":"https://api.github.com/repos/Perryvw/TypescriptToLua/releases{/id}","deployments_url":"https://api.github.com/repos/Perryvw/TypescriptToLua/deployments","created_at":"2017-12-31T17:26:03Z","updated_at":"2018-07-22T19:32:18Z","pushed_at":"2018-07-28T09:40:21Z","git_url":"git://github.com/Perryvw/TypescriptToLua.git","ssh_url":"git@github.com:Perryvw/TypescriptToLua.git","clone_url":"https://github.com/Perryvw/TypescriptToLua.git","svn_url":"https://github.com/Perryvw/TypescriptToLua","homepage":null,"size":919,"stargazers_count":42,"watchers_count":42,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":11,"open_issues":16,"watchers":42,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Perryvw/TypescriptToLua/pulls/158"},"html":{"href":"https://github.com/Perryvw/TypescriptToLua/pull/158"},"issue":{"href":"https://api.github.com/repos/Perryvw/TypescriptToLua/issues/158"},"comments":{"href":"https://api.github.com/repos/Perryvw/TypescriptToLua/issues/158/comments"},"review_comments":{"href":"https://api.github.com/repos/Perryvw/TypescriptToLua/pulls/158/comments"},"review_comment":{"href":"https://api.github.com/repos/Perryvw/TypescriptToLua/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Perryvw/TypescriptToLua/pulls/158/commits"},"statuses":{"href":"https://api.github.com/repos/Perryvw/TypescriptToLua/statuses/4b5a78710641bf27a036fa450459d98673382242"}},"author_association":"NONE"}}
{"actor":{"display_login":"Janne252"}}