{"action":"created","comment":{"url":"https://api.github.com/repos/ElementsProject/lightning/pulls/comments/198485545","pull_request_review_id":132422531,"id":198485545,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODQ4NTU0NQ==","diff_hunk":"@@ -150,6 +150,8 @@ static void json_getinfo(struct command *cmd,\n \n \tjson_object_start(response, NULL);\n \tjson_add_pubkey(response, \"id\", &cmd->ld->id);\n+\tjson_add_string(response, \"alias\", (const char *)cmd->ld->alias);\n+\tjson_add_hex(response, \"color\", (const void *)cmd->ld->rgb, 3);","path":"lightningd/jsonrpc.c","position":5,"original_position":5,"commit_id":"876892dd81afa066094d0e1fdb99a708bf3d63af","original_commit_id":"876892dd81afa066094d0e1fdb99a708bf3d63af","user":{"login":"cdecker","id":120117,"node_id":"MDQ6VXNlcjEyMDExNw==","avatar_url":"https://avatars2.githubusercontent.com/u/120117?v=4","gravatar_id":"","url":"https://api.github.com/users/cdecker","html_url":"https://github.com/cdecker","followers_url":"https://api.github.com/users/cdecker/followers","following_url":"https://api.github.com/users/cdecker/following{/other_user}","gists_url":"https://api.github.com/users/cdecker/gists{/gist_id}","starred_url":"https://api.github.com/users/cdecker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdecker/subscriptions","organizations_url":"https://api.github.com/users/cdecker/orgs","repos_url":"https://api.github.com/users/cdecker/repos","events_url":"https://api.github.com/users/cdecker/events{/privacy}","received_events_url":"https://api.github.com/users/cdecker/received_events","type":"User","site_admin":false},"body":"The cast is not needed here, and the length should use `tal_len`. Notice also that both of these fields may be NULL (though they commonly aren't).","created_at":"2018-06-27T13:02:15Z","updated_at":"2018-06-27T13:02:55Z","html_url":"https://github.com/ElementsProject/lightning/pull/1633#discussion_r198485545","pull_request_url":"https://api.github.com/repos/ElementsProject/lightning/pulls/1633","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ElementsProject/lightning/pulls/comments/198485545"},"html":{"href":"https://github.com/ElementsProject/lightning/pull/1633#discussion_r198485545"},"pull_request":{"href":"https://api.github.com/repos/ElementsProject/lightning/pulls/1633"}}},"pull_request":{"url":"https://api.github.com/repos/ElementsProject/lightning/pulls/1633","id":197638719,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3NjM4NzE5","html_url":"https://github.com/ElementsProject/lightning/pull/1633","diff_url":"https://github.com/ElementsProject/lightning/pull/1633.diff","patch_url":"https://github.com/ElementsProject/lightning/pull/1633.patch","issue_url":"https://api.github.com/repos/ElementsProject/lightning/issues/1633","number":1633,"state":"open","locked":false,"title":"add alias and color to getinfo","user":{"login":"arowser","id":541066,"node_id":"MDQ6VXNlcjU0MTA2Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/541066?v=4","gravatar_id":"","url":"https://api.github.com/users/arowser","html_url":"https://github.com/arowser","followers_url":"https://api.github.com/users/arowser/followers","following_url":"https://api.github.com/users/arowser/following{/other_user}","gists_url":"https://api.github.com/users/arowser/gists{/gist_id}","starred_url":"https://api.github.com/users/arowser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arowser/subscriptions","organizations_url":"https://api.github.com/users/arowser/orgs","repos_url":"https://api.github.com/users/arowser/repos","events_url":"https://api.github.com/users/arowser/events{/privacy}","received_events_url":"https://api.github.com/users/arowser/received_events","type":"User","site_admin":false},"body":"Fixes #1627 \r\n\r\n```sh\r\n$./lightning-cli getinfo     \r\n{\r\n  \"id\": \"03cd0d4e43e3c36507cb42479a0c3c7cc843f26146a4c81c274c796017a2205919\", \r\n  \"alias\": \"LOUDSCAN-v0.6-2-g50efe34-modded\", \r\n  \"color\": \"03cd0d\", \r\n  \"port\": 9735, \r\n  \"address\": [\r\n  ], \r\n  \"binding\": [\r\n    {\r\n      \"type\": \"ipv6\", \r\n      \"address\": \"::\", \r\n      \"port\": 9735\r\n    }\r\n  ], \r\n  \"version\": \"v0.6-2-g50efe34-modded\", \r\n  \"blockheight\": 494785, \r\n  \"network\": \"testnet\"\r\n}\r\n\r\n```","created_at":"2018-06-27T07:24:54Z","updated_at":"2018-06-27T13:02:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"34f0b723c2816698a502eca8c9d89f38809df4a2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ElementsProject/lightning/pulls/1633/commits","review_comments_url":"https://api.github.com/repos/ElementsProject/lightning/pulls/1633/comments","review_comment_url":"https://api.github.com/repos/ElementsProject/lightning/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ElementsProject/lightning/issues/1633/comments","statuses_url":"https://api.github.com/repos/ElementsProject/lightning/statuses/876892dd81afa066094d0e1fdb99a708bf3d63af","head":{"label":"arowser:get_info","ref":"get_info","sha":"876892dd81afa066094d0e1fdb99a708bf3d63af","user":{"login":"arowser","id":541066,"node_id":"MDQ6VXNlcjU0MTA2Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/541066?v=4","gravatar_id":"","url":"https://api.github.com/users/arowser","html_url":"https://github.com/arowser","followers_url":"https://api.github.com/users/arowser/followers","following_url":"https://api.github.com/users/arowser/following{/other_user}","gists_url":"https://api.github.com/users/arowser/gists{/gist_id}","starred_url":"https://api.github.com/users/arowser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arowser/subscriptions","organizations_url":"https://api.github.com/users/arowser/orgs","repos_url":"https://api.github.com/users/arowser/repos","events_url":"https://api.github.com/users/arowser/events{/privacy}","received_events_url":"https://api.github.com/users/arowser/received_events","type":"User","site_admin":false},"repo":{"id":122569367,"node_id":"MDEwOlJlcG9zaXRvcnkxMjI1NjkzNjc=","name":"lightning","full_name":"arowser/lightning","owner":{"login":"arowser","id":541066,"node_id":"MDQ6VXNlcjU0MTA2Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/541066?v=4","gravatar_id":"","url":"https://api.github.com/users/arowser","html_url":"https://github.com/arowser","followers_url":"https://api.github.com/users/arowser/followers","following_url":"https://api.github.com/users/arowser/following{/other_user}","gists_url":"https://api.github.com/users/arowser/gists{/gist_id}","starred_url":"https://api.github.com/users/arowser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arowser/subscriptions","organizations_url":"https://api.github.com/users/arowser/orgs","repos_url":"https://api.github.com/users/arowser/repos","events_url":"https://api.github.com/users/arowser/events{/privacy}","received_events_url":"https://api.github.com/users/arowser/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/arowser/lightning","description":"c-lightning — a Lightning Network implementation in C","fork":true,"url":"https://api.github.com/repos/arowser/lightning","forks_url":"https://api.github.com/repos/arowser/lightning/forks","keys_url":"https://api.github.com/repos/arowser/lightning/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arowser/lightning/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arowser/lightning/teams","hooks_url":"https://api.github.com/repos/arowser/lightning/hooks","issue_events_url":"https://api.github.com/repos/arowser/lightning/issues/events{/number}","events_url":"https://api.github.com/repos/arowser/lightning/events","assignees_url":"https://api.github.com/repos/arowser/lightning/assignees{/user}","branches_url":"https://api.github.com/repos/arowser/lightning/branches{/branch}","tags_url":"https://api.github.com/repos/arowser/lightning/tags","blobs_url":"https://api.github.com/repos/arowser/lightning/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arowser/lightning/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arowser/lightning/git/refs{/sha}","trees_url":"https://api.github.com/repos/arowser/lightning/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arowser/lightning/statuses/{sha}","languages_url":"https://api.github.com/repos/arowser/lightning/languages","stargazers_url":"https://api.github.com/repos/arowser/lightning/stargazers","contributors_url":"https://api.github.com/repos/arowser/lightning/contributors","subscribers_url":"https://api.github.com/repos/arowser/lightning/subscribers","subscription_url":"https://api.github.com/repos/arowser/lightning/subscription","commits_url":"https://api.github.com/repos/arowser/lightning/commits{/sha}","git_commits_url":"https://api.github.com/repos/arowser/lightning/git/commits{/sha}","comments_url":"https://api.github.com/repos/arowser/lightning/comments{/number}","issue_comment_url":"https://api.github.com/repos/arowser/lightning/issues/comments{/number}","contents_url":"https://api.github.com/repos/arowser/lightning/contents/{+path}","compare_url":"https://api.github.com/repos/arowser/lightning/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arowser/lightning/merges","archive_url":"https://api.github.com/repos/arowser/lightning/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arowser/lightning/downloads","issues_url":"https://api.github.com/repos/arowser/lightning/issues{/number}","pulls_url":"https://api.github.com/repos/arowser/lightning/pulls{/number}","milestones_url":"https://api.github.com/repos/arowser/lightning/milestones{/number}","notifications_url":"https://api.github.com/repos/arowser/lightning/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arowser/lightning/labels{/name}","releases_url":"https://api.github.com/repos/arowser/lightning/releases{/id}","deployments_url":"https://api.github.com/repos/arowser/lightning/deployments","created_at":"2018-02-23T03:35:17Z","updated_at":"2018-02-23T03:35:20Z","pushed_at":"2018-06-27T07:23:35Z","git_url":"git://github.com/arowser/lightning.git","ssh_url":"git@github.com:arowser/lightning.git","clone_url":"https://github.com/arowser/lightning.git","svn_url":"https://github.com/arowser/lightning","homepage":"","size":16249,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ElementsProject:master","ref":"master","sha":"50efe34e3b247def991cd6bdd03deee1ce7d1b85","user":{"login":"ElementsProject","id":12729539,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNzI5NTM5","avatar_url":"https://avatars2.githubusercontent.com/u/12729539?v=4","gravatar_id":"","url":"https://api.github.com/users/ElementsProject","html_url":"https://github.com/ElementsProject","followers_url":"https://api.github.com/users/ElementsProject/followers","following_url":"https://api.github.com/users/ElementsProject/following{/other_user}","gists_url":"https://api.github.com/users/ElementsProject/gists{/gist_id}","starred_url":"https://api.github.com/users/ElementsProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ElementsProject/subscriptions","organizations_url":"https://api.github.com/users/ElementsProject/orgs","repos_url":"https://api.github.com/users/ElementsProject/repos","events_url":"https://api.github.com/users/ElementsProject/events{/privacy}","received_events_url":"https://api.github.com/users/ElementsProject/received_events","type":"Organization","site_admin":false},"repo":{"id":37350472,"node_id":"MDEwOlJlcG9zaXRvcnkzNzM1MDQ3Mg==","name":"lightning","full_name":"ElementsProject/lightning","owner":{"login":"ElementsProject","id":12729539,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNzI5NTM5","avatar_url":"https://avatars2.githubusercontent.com/u/12729539?v=4","gravatar_id":"","url":"https://api.github.com/users/ElementsProject","html_url":"https://github.com/ElementsProject","followers_url":"https://api.github.com/users/ElementsProject/followers","following_url":"https://api.github.com/users/ElementsProject/following{/other_user}","gists_url":"https://api.github.com/users/ElementsProject/gists{/gist_id}","starred_url":"https://api.github.com/users/ElementsProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ElementsProject/subscriptions","organizations_url":"https://api.github.com/users/ElementsProject/orgs","repos_url":"https://api.github.com/users/ElementsProject/repos","events_url":"https://api.github.com/users/ElementsProject/events{/privacy}","received_events_url":"https://api.github.com/users/ElementsProject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ElementsProject/lightning","description":"c-lightning — a Lightning Network implementation in C","fork":false,"url":"https://api.github.com/repos/ElementsProject/lightning","forks_url":"https://api.github.com/repos/ElementsProject/lightning/forks","keys_url":"https://api.github.com/repos/ElementsProject/lightning/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ElementsProject/lightning/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ElementsProject/lightning/teams","hooks_url":"https://api.github.com/repos/ElementsProject/lightning/hooks","issue_events_url":"https://api.github.com/repos/ElementsProject/lightning/issues/events{/number}","events_url":"https://api.github.com/repos/ElementsProject/lightning/events","assignees_url":"https://api.github.com/repos/ElementsProject/lightning/assignees{/user}","branches_url":"https://api.github.com/repos/ElementsProject/lightning/branches{/branch}","tags_url":"https://api.github.com/repos/ElementsProject/lightning/tags","blobs_url":"https://api.github.com/repos/ElementsProject/lightning/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ElementsProject/lightning/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ElementsProject/lightning/git/refs{/sha}","trees_url":"https://api.github.com/repos/ElementsProject/lightning/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ElementsProject/lightning/statuses/{sha}","languages_url":"https://api.github.com/repos/ElementsProject/lightning/languages","stargazers_url":"https://api.github.com/repos/ElementsProject/lightning/stargazers","contributors_url":"https://api.github.com/repos/ElementsProject/lightning/contributors","subscribers_url":"https://api.github.com/repos/ElementsProject/lightning/subscribers","subscription_url":"https://api.github.com/repos/ElementsProject/lightning/subscription","commits_url":"https://api.github.com/repos/ElementsProject/lightning/commits{/sha}","git_commits_url":"https://api.github.com/repos/ElementsProject/lightning/git/commits{/sha}","comments_url":"https://api.github.com/repos/ElementsProject/lightning/comments{/number}","issue_comment_url":"https://api.github.com/repos/ElementsProject/lightning/issues/comments{/number}","contents_url":"https://api.github.com/repos/ElementsProject/lightning/contents/{+path}","compare_url":"https://api.github.com/repos/ElementsProject/lightning/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ElementsProject/lightning/merges","archive_url":"https://api.github.com/repos/ElementsProject/lightning/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ElementsProject/lightning/downloads","issues_url":"https://api.github.com/repos/ElementsProject/lightning/issues{/number}","pulls_url":"https://api.github.com/repos/ElementsProject/lightning/pulls{/number}","milestones_url":"https://api.github.com/repos/ElementsProject/lightning/milestones{/number}","notifications_url":"https://api.github.com/repos/ElementsProject/lightning/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ElementsProject/lightning/labels{/name}","releases_url":"https://api.github.com/repos/ElementsProject/lightning/releases{/id}","deployments_url":"https://api.github.com/repos/ElementsProject/lightning/deployments","created_at":"2015-06-13T00:04:22Z","updated_at":"2018-06-27T11:40:07Z","pushed_at":"2018-06-27T11:40:04Z","git_url":"git://github.com/ElementsProject/lightning.git","ssh_url":"git@github.com:ElementsProject/lightning.git","clone_url":"https://github.com/ElementsProject/lightning.git","svn_url":"https://github.com/ElementsProject/lightning","homepage":"","size":16253,"stargazers_count":994,"watchers_count":994,"language":"C","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":276,"mirror_url":null,"archived":false,"open_issues_count":108,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":276,"open_issues":108,"watchers":994,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ElementsProject/lightning/pulls/1633"},"html":{"href":"https://github.com/ElementsProject/lightning/pull/1633"},"issue":{"href":"https://api.github.com/repos/ElementsProject/lightning/issues/1633"},"comments":{"href":"https://api.github.com/repos/ElementsProject/lightning/issues/1633/comments"},"review_comments":{"href":"https://api.github.com/repos/ElementsProject/lightning/pulls/1633/comments"},"review_comment":{"href":"https://api.github.com/repos/ElementsProject/lightning/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ElementsProject/lightning/pulls/1633/commits"},"statuses":{"href":"https://api.github.com/repos/ElementsProject/lightning/statuses/876892dd81afa066094d0e1fdb99a708bf3d63af"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"cdecker"}}