{"action":"created","comment":{"url":"https://api.github.com/repos/MarlinFirmware/Marlin/pulls/comments/196657648","pull_request_review_id":130250493,"id":196657648,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NjY1NzY0OA==","diff_hunk":"@@ -554,20 +554,16 @@ void Endstops::update() {\n       endstop_poll_count = 7;\n       old_live_state = live_state;\n     }\n-    else if (endstop_poll_count && !--endstop_poll_count)\n-      validated_live_state = live_state;\n-\n-  #else\n+    else if (endstop_poll_count && --endstop_poll_count) return;","path":"Marlin/src/module/endstops.cpp","position":154,"original_position":153,"commit_id":"0202abaa056ebb260b1563e86af7c040473f9998","original_commit_id":"1e2050d149221877136ed04fd9c589a1122a5386","user":{"login":"ejtagle","id":831601,"node_id":"MDQ6VXNlcjgzMTYwMQ==","avatar_url":"https://avatars2.githubusercontent.com/u/831601?v=4","gravatar_id":"","url":"https://api.github.com/users/ejtagle","html_url":"https://github.com/ejtagle","followers_url":"https://api.github.com/users/ejtagle/followers","following_url":"https://api.github.com/users/ejtagle/following{/other_user}","gists_url":"https://api.github.com/users/ejtagle/gists{/gist_id}","starred_url":"https://api.github.com/users/ejtagle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ejtagle/subscriptions","organizations_url":"https://api.github.com/users/ejtagle/orgs","repos_url":"https://api.github.com/users/ejtagle/repos","events_url":"https://api.github.com/users/ejtagle/events{/privacy}","received_events_url":"https://api.github.com/users/ejtagle/received_events","type":"User","site_admin":false},"body":"This specific change is right. If state was not validated... No, i am not sure. The logic is sound, but Marlin counts on endstop_triggered() being call at all times ... Otherwise blocks will not be cancelled if forcing an endstop... ","created_at":"2018-06-20T06:10:22Z","updated_at":"2018-06-20T06:10:23Z","html_url":"https://github.com/MarlinFirmware/Marlin/pull/11066#discussion_r196657648","pull_request_url":"https://api.github.com/repos/MarlinFirmware/Marlin/pulls/11066","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/MarlinFirmware/Marlin/pulls/comments/196657648"},"html":{"href":"https://github.com/MarlinFirmware/Marlin/pull/11066#discussion_r196657648"},"pull_request":{"href":"https://api.github.com/repos/MarlinFirmware/Marlin/pulls/11066"}},"in_reply_to_id":196656600},"pull_request":{"url":"https://api.github.com/repos/MarlinFirmware/Marlin/pulls/11066","id":196021667,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2MDIxNjY3","html_url":"https://github.com/MarlinFirmware/Marlin/pull/11066","diff_url":"https://github.com/MarlinFirmware/Marlin/pull/11066.diff","patch_url":"https://github.com/MarlinFirmware/Marlin/pull/11066.patch","issue_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/11066","number":11066,"state":"open","locked":false,"title":"[2.0.x] Maintain low-level endstops state at all times","user":{"login":"thinkyhead","id":698003,"node_id":"MDQ6VXNlcjY5ODAwMw==","avatar_url":"https://avatars2.githubusercontent.com/u/698003?v=4","gravatar_id":"","url":"https://api.github.com/users/thinkyhead","html_url":"https://github.com/thinkyhead","followers_url":"https://api.github.com/users/thinkyhead/followers","following_url":"https://api.github.com/users/thinkyhead/following{/other_user}","gists_url":"https://api.github.com/users/thinkyhead/gists{/gist_id}","starred_url":"https://api.github.com/users/thinkyhead/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thinkyhead/subscriptions","organizations_url":"https://api.github.com/users/thinkyhead/orgs","repos_url":"https://api.github.com/users/thinkyhead/repos","events_url":"https://api.github.com/users/thinkyhead/events{/privacy}","received_events_url":"https://api.github.com/users/thinkyhead/received_events","type":"User","site_admin":false},"body":"In reference to #11056…\r\n\r\nInstead of only updating the endstops state after 7 samples while endstops are enabled, maintain the current state at all times.","created_at":"2018-06-20T04:53:52Z","updated_at":"2018-06-20T06:10:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"20fdb04b2bb5f0fc9684c69a78cab1563190f054","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":196934261,"node_id":"MDU6TGFiZWwxOTY5MzQyNjE=","url":"https://api.github.com/repos/MarlinFirmware/Marlin/labels/PR:%20Bug%20Fix","name":"PR: Bug Fix","color":"bfe5bf","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/MarlinFirmware/Marlin/pulls/11066/commits","review_comments_url":"https://api.github.com/repos/MarlinFirmware/Marlin/pulls/11066/comments","review_comment_url":"https://api.github.com/repos/MarlinFirmware/Marlin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/11066/comments","statuses_url":"https://api.github.com/repos/MarlinFirmware/Marlin/statuses/0202abaa056ebb260b1563e86af7c040473f9998","head":{"label":"thinkyhead:bf2_endstops_filtering","ref":"bf2_endstops_filtering","sha":"0202abaa056ebb260b1563e86af7c040473f9998","user":{"login":"thinkyhead","id":698003,"node_id":"MDQ6VXNlcjY5ODAwMw==","avatar_url":"https://avatars2.githubusercontent.com/u/698003?v=4","gravatar_id":"","url":"https://api.github.com/users/thinkyhead","html_url":"https://github.com/thinkyhead","followers_url":"https://api.github.com/users/thinkyhead/followers","following_url":"https://api.github.com/users/thinkyhead/following{/other_user}","gists_url":"https://api.github.com/users/thinkyhead/gists{/gist_id}","starred_url":"https://api.github.com/users/thinkyhead/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thinkyhead/subscriptions","organizations_url":"https://api.github.com/users/thinkyhead/orgs","repos_url":"https://api.github.com/users/thinkyhead/repos","events_url":"https://api.github.com/users/thinkyhead/events{/privacy}","received_events_url":"https://api.github.com/users/thinkyhead/received_events","type":"User","site_admin":false},"repo":{"id":24809835,"node_id":"MDEwOlJlcG9zaXRvcnkyNDgwOTgzNQ==","name":"Marlin","full_name":"thinkyhead/Marlin","owner":{"login":"thinkyhead","id":698003,"node_id":"MDQ6VXNlcjY5ODAwMw==","avatar_url":"https://avatars2.githubusercontent.com/u/698003?v=4","gravatar_id":"","url":"https://api.github.com/users/thinkyhead","html_url":"https://github.com/thinkyhead","followers_url":"https://api.github.com/users/thinkyhead/followers","following_url":"https://api.github.com/users/thinkyhead/following{/other_user}","gists_url":"https://api.github.com/users/thinkyhead/gists{/gist_id}","starred_url":"https://api.github.com/users/thinkyhead/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thinkyhead/subscriptions","organizations_url":"https://api.github.com/users/thinkyhead/orgs","repos_url":"https://api.github.com/users/thinkyhead/repos","events_url":"https://api.github.com/users/thinkyhead/events{/privacy}","received_events_url":"https://api.github.com/users/thinkyhead/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/thinkyhead/Marlin","description":"This fork is a primary contributor to the MarlinFirmware/Marlin release branch, frequently pushing bug fixes, new features, and code cleanup. See the Wiki page for details. If any of the experimental branches here look interesting please contribute! Branches with \"i3_millie\" in the name include all the latest goodies, optimized for my RAMPS-based Prusa i3.","fork":true,"url":"https://api.github.com/repos/thinkyhead/Marlin","forks_url":"https://api.github.com/repos/thinkyhead/Marlin/forks","keys_url":"https://api.github.com/repos/thinkyhead/Marlin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thinkyhead/Marlin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thinkyhead/Marlin/teams","hooks_url":"https://api.github.com/repos/thinkyhead/Marlin/hooks","issue_events_url":"https://api.github.com/repos/thinkyhead/Marlin/issues/events{/number}","events_url":"https://api.github.com/repos/thinkyhead/Marlin/events","assignees_url":"https://api.github.com/repos/thinkyhead/Marlin/assignees{/user}","branches_url":"https://api.github.com/repos/thinkyhead/Marlin/branches{/branch}","tags_url":"https://api.github.com/repos/thinkyhead/Marlin/tags","blobs_url":"https://api.github.com/repos/thinkyhead/Marlin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thinkyhead/Marlin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thinkyhead/Marlin/git/refs{/sha}","trees_url":"https://api.github.com/repos/thinkyhead/Marlin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thinkyhead/Marlin/statuses/{sha}","languages_url":"https://api.github.com/repos/thinkyhead/Marlin/languages","stargazers_url":"https://api.github.com/repos/thinkyhead/Marlin/stargazers","contributors_url":"https://api.github.com/repos/thinkyhead/Marlin/contributors","subscribers_url":"https://api.github.com/repos/thinkyhead/Marlin/subscribers","subscription_url":"https://api.github.com/repos/thinkyhead/Marlin/subscription","commits_url":"https://api.github.com/repos/thinkyhead/Marlin/commits{/sha}","git_commits_url":"https://api.github.com/repos/thinkyhead/Marlin/git/commits{/sha}","comments_url":"https://api.github.com/repos/thinkyhead/Marlin/comments{/number}","issue_comment_url":"https://api.github.com/repos/thinkyhead/Marlin/issues/comments{/number}","contents_url":"https://api.github.com/repos/thinkyhead/Marlin/contents/{+path}","compare_url":"https://api.github.com/repos/thinkyhead/Marlin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thinkyhead/Marlin/merges","archive_url":"https://api.github.com/repos/thinkyhead/Marlin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thinkyhead/Marlin/downloads","issues_url":"https://api.github.com/repos/thinkyhead/Marlin/issues{/number}","pulls_url":"https://api.github.com/repos/thinkyhead/Marlin/pulls{/number}","milestones_url":"https://api.github.com/repos/thinkyhead/Marlin/milestones{/number}","notifications_url":"https://api.github.com/repos/thinkyhead/Marlin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thinkyhead/Marlin/labels{/name}","releases_url":"https://api.github.com/repos/thinkyhead/Marlin/releases{/id}","deployments_url":"https://api.github.com/repos/thinkyhead/Marlin/deployments","created_at":"2014-10-05T06:17:14Z","updated_at":"2018-04-24T03:22:25Z","pushed_at":"2018-06-20T06:10:16Z","git_url":"git://github.com/thinkyhead/Marlin.git","ssh_url":"git@github.com:thinkyhead/Marlin.git","clone_url":"https://github.com/thinkyhead/Marlin.git","svn_url":"https://github.com/thinkyhead/Marlin","homepage":"http://www.thinkyhead.com/","size":75183,"stargazers_count":13,"watchers_count":13,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":3,"open_issues":0,"watchers":13,"default_branch":"bugfix-1.1.x"}},"base":{"label":"MarlinFirmware:bugfix-2.0.x","ref":"bugfix-2.0.x","sha":"4d54a560498f64501063e342849b47b469ef6941","user":{"login":"MarlinFirmware","id":10418365,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNDE4MzY1","avatar_url":"https://avatars3.githubusercontent.com/u/10418365?v=4","gravatar_id":"","url":"https://api.github.com/users/MarlinFirmware","html_url":"https://github.com/MarlinFirmware","followers_url":"https://api.github.com/users/MarlinFirmware/followers","following_url":"https://api.github.com/users/MarlinFirmware/following{/other_user}","gists_url":"https://api.github.com/users/MarlinFirmware/gists{/gist_id}","starred_url":"https://api.github.com/users/MarlinFirmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarlinFirmware/subscriptions","organizations_url":"https://api.github.com/users/MarlinFirmware/orgs","repos_url":"https://api.github.com/users/MarlinFirmware/repos","events_url":"https://api.github.com/users/MarlinFirmware/events{/privacy}","received_events_url":"https://api.github.com/users/MarlinFirmware/received_events","type":"Organization","site_admin":false},"repo":{"id":2200856,"node_id":"MDEwOlJlcG9zaXRvcnkyMjAwODU2","name":"Marlin","full_name":"MarlinFirmware/Marlin","owner":{"login":"MarlinFirmware","id":10418365,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNDE4MzY1","avatar_url":"https://avatars3.githubusercontent.com/u/10418365?v=4","gravatar_id":"","url":"https://api.github.com/users/MarlinFirmware","html_url":"https://github.com/MarlinFirmware","followers_url":"https://api.github.com/users/MarlinFirmware/followers","following_url":"https://api.github.com/users/MarlinFirmware/following{/other_user}","gists_url":"https://api.github.com/users/MarlinFirmware/gists{/gist_id}","starred_url":"https://api.github.com/users/MarlinFirmware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarlinFirmware/subscriptions","organizations_url":"https://api.github.com/users/MarlinFirmware/orgs","repos_url":"https://api.github.com/users/MarlinFirmware/repos","events_url":"https://api.github.com/users/MarlinFirmware/events{/privacy}","received_events_url":"https://api.github.com/users/MarlinFirmware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MarlinFirmware/Marlin","description":"Optimized firmware for RepRap 3D printers based on the Arduino platform.","fork":false,"url":"https://api.github.com/repos/MarlinFirmware/Marlin","forks_url":"https://api.github.com/repos/MarlinFirmware/Marlin/forks","keys_url":"https://api.github.com/repos/MarlinFirmware/Marlin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MarlinFirmware/Marlin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MarlinFirmware/Marlin/teams","hooks_url":"https://api.github.com/repos/MarlinFirmware/Marlin/hooks","issue_events_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/events{/number}","events_url":"https://api.github.com/repos/MarlinFirmware/Marlin/events","assignees_url":"https://api.github.com/repos/MarlinFirmware/Marlin/assignees{/user}","branches_url":"https://api.github.com/repos/MarlinFirmware/Marlin/branches{/branch}","tags_url":"https://api.github.com/repos/MarlinFirmware/Marlin/tags","blobs_url":"https://api.github.com/repos/MarlinFirmware/Marlin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MarlinFirmware/Marlin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MarlinFirmware/Marlin/git/refs{/sha}","trees_url":"https://api.github.com/repos/MarlinFirmware/Marlin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MarlinFirmware/Marlin/statuses/{sha}","languages_url":"https://api.github.com/repos/MarlinFirmware/Marlin/languages","stargazers_url":"https://api.github.com/repos/MarlinFirmware/Marlin/stargazers","contributors_url":"https://api.github.com/repos/MarlinFirmware/Marlin/contributors","subscribers_url":"https://api.github.com/repos/MarlinFirmware/Marlin/subscribers","subscription_url":"https://api.github.com/repos/MarlinFirmware/Marlin/subscription","commits_url":"https://api.github.com/repos/MarlinFirmware/Marlin/commits{/sha}","git_commits_url":"https://api.github.com/repos/MarlinFirmware/Marlin/git/commits{/sha}","comments_url":"https://api.github.com/repos/MarlinFirmware/Marlin/comments{/number}","issue_comment_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/comments{/number}","contents_url":"https://api.github.com/repos/MarlinFirmware/Marlin/contents/{+path}","compare_url":"https://api.github.com/repos/MarlinFirmware/Marlin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MarlinFirmware/Marlin/merges","archive_url":"https://api.github.com/repos/MarlinFirmware/Marlin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MarlinFirmware/Marlin/downloads","issues_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues{/number}","pulls_url":"https://api.github.com/repos/MarlinFirmware/Marlin/pulls{/number}","milestones_url":"https://api.github.com/repos/MarlinFirmware/Marlin/milestones{/number}","notifications_url":"https://api.github.com/repos/MarlinFirmware/Marlin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MarlinFirmware/Marlin/labels{/name}","releases_url":"https://api.github.com/repos/MarlinFirmware/Marlin/releases{/id}","deployments_url":"https://api.github.com/repos/MarlinFirmware/Marlin/deployments","created_at":"2011-08-13T08:07:20Z","updated_at":"2018-06-20T06:04:06Z","pushed_at":"2018-06-20T06:10:18Z","git_url":"git://github.com/MarlinFirmware/Marlin.git","ssh_url":"git@github.com:MarlinFirmware/Marlin.git","clone_url":"https://github.com/MarlinFirmware/Marlin.git","svn_url":"https://github.com/MarlinFirmware/Marlin","homepage":"http://www.marlinfw.org/","size":79101,"stargazers_count":3878,"watchers_count":3878,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5642,"mirror_url":null,"archived":false,"open_issues_count":643,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":5642,"open_issues":643,"watchers":3878,"default_branch":"1.1.x"}},"_links":{"self":{"href":"https://api.github.com/repos/MarlinFirmware/Marlin/pulls/11066"},"html":{"href":"https://github.com/MarlinFirmware/Marlin/pull/11066"},"issue":{"href":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/11066"},"comments":{"href":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/11066/comments"},"review_comments":{"href":"https://api.github.com/repos/MarlinFirmware/Marlin/pulls/11066/comments"},"review_comment":{"href":"https://api.github.com/repos/MarlinFirmware/Marlin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MarlinFirmware/Marlin/pulls/11066/commits"},"statuses":{"href":"https://api.github.com/repos/MarlinFirmware/Marlin/statuses/0202abaa056ebb260b1563e86af7c040473f9998"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"ejtagle"}}