{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/177548778","pull_request_review_id":107439536,"id":177548778,"diff_hunk":"@@ -1239,96 +1242,126 @@ private bool IsRefStruct(out bool isRefFollowedByStructOrPartialStruct, out bool\n             return isTypeDeclaration && nextToken.Kind == SyntaxKind.StructKeyword;\n         }\n \n-        private static bool CanFollowTypeName(SyntaxKind kind)\n+        private static bool IsContextualModifier(SyntaxToken token)\n         {\n-            switch (kind)\n+            switch (token.ContextualKind)\n             {\n-                case SyntaxKind.DotToken:                   // partial.     qualified\n-                case SyntaxKind.ColonColonToken:            // partial::    alias\n-                case SyntaxKind.LessThanToken:              // partial<     generic type\n-                case SyntaxKind.OpenBracketToken:           // partial[     array\n+                case SyntaxKind.PartialKeyword:\n+                case SyntaxKind.AsyncKeyword:\n                     return true;\n             }\n \n             return false;\n         }\n \n-        private static bool CanFollowMemberName(SyntaxKind kind)\n+        // Returns true if the current token is probably a modifier.\n+        // To avoid further lookahead, caller is responsible to disambiguate some edge cases.","path":"src/Compilers/CSharp/Portable/Parser/LanguageParser.cs","position":null,"original_position":66,"commit_id":"0e44ae18bfda4fd931373fc4fdad46e2fa1fc3dd","original_commit_id":"27349caa6ed676e2e998789aa9c77b31a23badb5","user":{"login":"CyrusNajmabadi","id":4564579,"avatar_url":"https://avatars3.githubusercontent.com/u/4564579?v=4","gravatar_id":"","url":"https://api.github.com/users/CyrusNajmabadi","html_url":"https://github.com/CyrusNajmabadi","followers_url":"https://api.github.com/users/CyrusNajmabadi/followers","following_url":"https://api.github.com/users/CyrusNajmabadi/following{/other_user}","gists_url":"https://api.github.com/users/CyrusNajmabadi/gists{/gist_id}","starred_url":"https://api.github.com/users/CyrusNajmabadi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CyrusNajmabadi/subscriptions","organizations_url":"https://api.github.com/users/CyrusNajmabadi/orgs","repos_url":"https://api.github.com/users/CyrusNajmabadi/repos","events_url":"https://api.github.com/users/CyrusNajmabadi/events{/privacy}","received_events_url":"https://api.github.com/users/CyrusNajmabadi/received_events","type":"User","site_admin":false},"body":"You're right.  I think my only concern is that this is just a random helper hanging out in the middle of nowhere.  If it really is only used by your ScanPartial... method, i would prefer it be isolated only to that. in which case, it would make more sense (to me at least).  I retract my original complaint as this makes more sense now.  But i would like to see if it could be clearer with a little bit of reorganization.","created_at":"2018-03-27T19:42:17Z","updated_at":"2018-03-27T19:42:17Z","html_url":"https://github.com/dotnet/roslyn/pull/23533#discussion_r177548778","pull_request_url":"https://api.github.com/repos/dotnet/roslyn/pulls/23533","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/177548778"},"html":{"href":"https://github.com/dotnet/roslyn/pull/23533#discussion_r177548778"},"pull_request":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/23533"}},"in_reply_to_id":177541523},"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/23533","id":156032847,"html_url":"https://github.com/dotnet/roslyn/pull/23533","diff_url":"https://github.com/dotnet/roslyn/pull/23533.diff","patch_url":"https://github.com/dotnet/roslyn/pull/23533.patch","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/23533","number":23533,"state":"open","locked":false,"title":"Relax ordering constraints around 'ref' and 'partial' modifiers on type declarations","user":{"login":"alrz","id":3105979,"avatar_url":"https://avatars2.githubusercontent.com/u/3105979?v=4","gravatar_id":"","url":"https://api.github.com/users/alrz","html_url":"https://github.com/alrz","followers_url":"https://api.github.com/users/alrz/followers","following_url":"https://api.github.com/users/alrz/following{/other_user}","gists_url":"https://api.github.com/users/alrz/gists{/gist_id}","starred_url":"https://api.github.com/users/alrz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alrz/subscriptions","organizations_url":"https://api.github.com/users/alrz/orgs","repos_url":"https://api.github.com/users/alrz/repos","events_url":"https://api.github.com/users/alrz/events{/privacy}","received_events_url":"https://api.github.com/users/alrz/received_events","type":"User","site_admin":false},"body":"Proposal: https://github.com/dotnet/csharplang/issues/946 (as part of C# 7.3)\r\n\r\nAlso related: https://github.com/dotnet/csharplang/issues/1022\r\n\r\n\r\n\r\n","created_at":"2017-12-02T21:42:54Z","updated_at":"2018-03-27T19:42:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"df1fdc97eeb3dea237a803e49dd7b4dae70a823d","assignee":{"login":"jaredpar","id":146967,"avatar_url":"https://avatars0.githubusercontent.com/u/146967?v=4","gravatar_id":"","url":"https://api.github.com/users/jaredpar","html_url":"https://github.com/jaredpar","followers_url":"https://api.github.com/users/jaredpar/followers","following_url":"https://api.github.com/users/jaredpar/following{/other_user}","gists_url":"https://api.github.com/users/jaredpar/gists{/gist_id}","starred_url":"https://api.github.com/users/jaredpar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaredpar/subscriptions","organizations_url":"https://api.github.com/users/jaredpar/orgs","repos_url":"https://api.github.com/users/jaredpar/repos","events_url":"https://api.github.com/users/jaredpar/events{/privacy}","received_events_url":"https://api.github.com/users/jaredpar/received_events","type":"User","site_admin":false},"assignees":[{"login":"jaredpar","id":146967,"avatar_url":"https://avatars0.githubusercontent.com/u/146967?v=4","gravatar_id":"","url":"https://api.github.com/users/jaredpar","html_url":"https://github.com/jaredpar","followers_url":"https://api.github.com/users/jaredpar/followers","following_url":"https://api.github.com/users/jaredpar/following{/other_user}","gists_url":"https://api.github.com/users/jaredpar/gists{/gist_id}","starred_url":"https://api.github.com/users/jaredpar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaredpar/subscriptions","organizations_url":"https://api.github.com/users/jaredpar/orgs","repos_url":"https://api.github.com/users/jaredpar/repos","events_url":"https://api.github.com/users/jaredpar/events{/privacy}","received_events_url":"https://api.github.com/users/jaredpar/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":166673288,"url":"https://api.github.com/repos/dotnet/roslyn/labels/Area-Compilers","name":"Area-Compilers","color":"5319e7","default":false},{"id":288147422,"url":"https://api.github.com/repos/dotnet/roslyn/labels/Community","name":"Community","color":"0e8a16","default":false}],"milestone":{"url":"https://api.github.com/repos/dotnet/roslyn/milestones/32","html_url":"https://github.com/dotnet/roslyn/milestone/32","labels_url":"https://api.github.com/repos/dotnet/roslyn/milestones/32/labels","id":2817494,"number":32,"title":"15.7","description":null,"creator":{"login":"sharwell","id":1408396,"avatar_url":"https://avatars1.githubusercontent.com/u/1408396?v=4","gravatar_id":"","url":"https://api.github.com/users/sharwell","html_url":"https://github.com/sharwell","followers_url":"https://api.github.com/users/sharwell/followers","following_url":"https://api.github.com/users/sharwell/following{/other_user}","gists_url":"https://api.github.com/users/sharwell/gists{/gist_id}","starred_url":"https://api.github.com/users/sharwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sharwell/subscriptions","organizations_url":"https://api.github.com/users/sharwell/orgs","repos_url":"https://api.github.com/users/sharwell/repos","events_url":"https://api.github.com/users/sharwell/events{/privacy}","received_events_url":"https://api.github.com/users/sharwell/received_events","type":"User","site_admin":false},"open_issues":225,"closed_issues":272,"state":"open","created_at":"2017-10-05T14:58:29Z","updated_at":"2018-03-27T19:36:26Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/dotnet/roslyn/pulls/23533/commits","review_comments_url":"https://api.github.com/repos/dotnet/roslyn/pulls/23533/comments","review_comment_url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/23533/comments","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/0e44ae18bfda4fd931373fc4fdad46e2fa1fc3dd","head":{"label":"alrz:mod-ordering","ref":"mod-ordering","sha":"0e44ae18bfda4fd931373fc4fdad46e2fa1fc3dd","user":{"login":"alrz","id":3105979,"avatar_url":"https://avatars2.githubusercontent.com/u/3105979?v=4","gravatar_id":"","url":"https://api.github.com/users/alrz","html_url":"https://github.com/alrz","followers_url":"https://api.github.com/users/alrz/followers","following_url":"https://api.github.com/users/alrz/following{/other_user}","gists_url":"https://api.github.com/users/alrz/gists{/gist_id}","starred_url":"https://api.github.com/users/alrz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alrz/subscriptions","organizations_url":"https://api.github.com/users/alrz/orgs","repos_url":"https://api.github.com/users/alrz/repos","events_url":"https://api.github.com/users/alrz/events{/privacy}","received_events_url":"https://api.github.com/users/alrz/received_events","type":"User","site_admin":false},"repo":{"id":54348191,"name":"roslyn","full_name":"alrz/roslyn","owner":{"login":"alrz","id":3105979,"avatar_url":"https://avatars2.githubusercontent.com/u/3105979?v=4","gravatar_id":"","url":"https://api.github.com/users/alrz","html_url":"https://github.com/alrz","followers_url":"https://api.github.com/users/alrz/followers","following_url":"https://api.github.com/users/alrz/following{/other_user}","gists_url":"https://api.github.com/users/alrz/gists{/gist_id}","starred_url":"https://api.github.com/users/alrz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alrz/subscriptions","organizations_url":"https://api.github.com/users/alrz/orgs","repos_url":"https://api.github.com/users/alrz/repos","events_url":"https://api.github.com/users/alrz/events{/privacy}","received_events_url":"https://api.github.com/users/alrz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alrz/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":true,"url":"https://api.github.com/repos/alrz/roslyn","forks_url":"https://api.github.com/repos/alrz/roslyn/forks","keys_url":"https://api.github.com/repos/alrz/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alrz/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alrz/roslyn/teams","hooks_url":"https://api.github.com/repos/alrz/roslyn/hooks","issue_events_url":"https://api.github.com/repos/alrz/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/alrz/roslyn/events","assignees_url":"https://api.github.com/repos/alrz/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/alrz/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/alrz/roslyn/tags","blobs_url":"https://api.github.com/repos/alrz/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alrz/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alrz/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/alrz/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alrz/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/alrz/roslyn/languages","stargazers_url":"https://api.github.com/repos/alrz/roslyn/stargazers","contributors_url":"https://api.github.com/repos/alrz/roslyn/contributors","subscribers_url":"https://api.github.com/repos/alrz/roslyn/subscribers","subscription_url":"https://api.github.com/repos/alrz/roslyn/subscription","commits_url":"https://api.github.com/repos/alrz/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/alrz/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/alrz/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/alrz/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/alrz/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/alrz/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alrz/roslyn/merges","archive_url":"https://api.github.com/repos/alrz/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alrz/roslyn/downloads","issues_url":"https://api.github.com/repos/alrz/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/alrz/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/alrz/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/alrz/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alrz/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/alrz/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/alrz/roslyn/deployments","created_at":"2016-03-21T00:28:36Z","updated_at":"2016-03-21T00:29:08Z","pushed_at":"2018-03-27T17:20:18Z","git_url":"git://github.com/alrz/roslyn.git","ssh_url":"git@github.com:alrz/roslyn.git","clone_url":"https://github.com/alrz/roslyn.git","svn_url":"https://github.com/alrz/roslyn","homepage":"","size":297594,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:dev15.7.x","ref":"dev15.7.x","sha":"ebb3e37d1783b2922615d1e78e400970585a72ee","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":29078997,"name":"roslyn","full_name":"dotnet/roslyn","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":false,"url":"https://api.github.com/repos/dotnet/roslyn","forks_url":"https://api.github.com/repos/dotnet/roslyn/forks","keys_url":"https://api.github.com/repos/dotnet/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/roslyn/teams","hooks_url":"https://api.github.com/repos/dotnet/roslyn/hooks","issue_events_url":"https://api.github.com/repos/dotnet/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/roslyn/events","assignees_url":"https://api.github.com/repos/dotnet/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/roslyn/tags","blobs_url":"https://api.github.com/repos/dotnet/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/roslyn/languages","stargazers_url":"https://api.github.com/repos/dotnet/roslyn/stargazers","contributors_url":"https://api.github.com/repos/dotnet/roslyn/contributors","subscribers_url":"https://api.github.com/repos/dotnet/roslyn/subscribers","subscription_url":"https://api.github.com/repos/dotnet/roslyn/subscription","commits_url":"https://api.github.com/repos/dotnet/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/roslyn/merges","archive_url":"https://api.github.com/repos/dotnet/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/roslyn/downloads","issues_url":"https://api.github.com/repos/dotnet/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/roslyn/deployments","created_at":"2015-01-11T02:39:03Z","updated_at":"2018-03-27T19:37:09Z","pushed_at":"2018-03-27T19:36:26Z","git_url":"git://github.com/dotnet/roslyn.git","ssh_url":"git@github.com:dotnet/roslyn.git","clone_url":"https://github.com/dotnet/roslyn.git","svn_url":"https://github.com/dotnet/roslyn","homepage":"","size":323508,"stargazers_count":9058,"watchers_count":9058,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2181,"mirror_url":null,"archived":false,"open_issues_count":4669,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":2181,"open_issues":4669,"watchers":9058,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/23533"},"html":{"href":"https://github.com/dotnet/roslyn/pull/23533"},"issue":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/23533"},"comments":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/23533/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/23533/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/23533/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/roslyn/statuses/0e44ae18bfda4fd931373fc4fdad46e2fa1fc3dd"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"CyrusNajmabadi"}}