{"action":"created","issue":{"url":"https://api.github.com/repos/louthy/language-ext/issues/355","repository_url":"https://api.github.com/repos/louthy/language-ext","labels_url":"https://api.github.com/repos/louthy/language-ext/issues/355/labels{/name}","comments_url":"https://api.github.com/repos/louthy/language-ext/issues/355/comments","events_url":"https://api.github.com/repos/louthy/language-ext/issues/355/events","html_url":"https://github.com/louthy/language-ext/issues/355","id":295318722,"number":355,"title":"Record<RECORDTYPE> comparison operators doesn't use CompareTo override","user":{"login":"faeriedust","id":3753000,"avatar_url":"https://avatars3.githubusercontent.com/u/3753000?v=4","gravatar_id":"","url":"https://api.github.com/users/faeriedust","html_url":"https://github.com/faeriedust","followers_url":"https://api.github.com/users/faeriedust/followers","following_url":"https://api.github.com/users/faeriedust/following{/other_user}","gists_url":"https://api.github.com/users/faeriedust/gists{/gist_id}","starred_url":"https://api.github.com/users/faeriedust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/faeriedust/subscriptions","organizations_url":"https://api.github.com/users/faeriedust/orgs","repos_url":"https://api.github.com/users/faeriedust/repos","events_url":"https://api.github.com/users/faeriedust/events{/privacy}","received_events_url":"https://api.github.com/users/faeriedust/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-02-07T22:36:35Z","updated_at":"2018-02-08T23:49:43Z","closed_at":null,"author_association":"NONE","body":"I made a class public class `VersionNumber : Record<VersionNumber>` and overrode `CompareTo` and called the following code, and it didn't call my ovveride?\r\n\r\n`var a = new VersionNumber();\r\nvar b = new VersionNumber();\r\nvar c = a < b;`\r\n\r\nI also couldn't tell from the code with ease or the documentation whether it was supposed to call my override or not, but I feel it's inconsistent that the CompareTo method is virtual and the comparison operators are defined but don't use the CompareTo method.\r\n"},"comment":{"url":"https://api.github.com/repos/louthy/language-ext/issues/comments/364288168","html_url":"https://github.com/louthy/language-ext/issues/355#issuecomment-364288168","issue_url":"https://api.github.com/repos/louthy/language-ext/issues/355","id":364288168,"user":{"login":"faeriedust","id":3753000,"avatar_url":"https://avatars3.githubusercontent.com/u/3753000?v=4","gravatar_id":"","url":"https://api.github.com/users/faeriedust","html_url":"https://github.com/faeriedust","followers_url":"https://api.github.com/users/faeriedust/followers","following_url":"https://api.github.com/users/faeriedust/following{/other_user}","gists_url":"https://api.github.com/users/faeriedust/gists{/gist_id}","starred_url":"https://api.github.com/users/faeriedust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/faeriedust/subscriptions","organizations_url":"https://api.github.com/users/faeriedust/orgs","repos_url":"https://api.github.com/users/faeriedust/repos","events_url":"https://api.github.com/users/faeriedust/events{/privacy}","received_events_url":"https://api.github.com/users/faeriedust/received_events","type":"User","site_admin":false},"created_at":"2018-02-08T23:49:43Z","updated_at":"2018-02-08T23:49:43Z","author_association":"NONE","body":"Can we at least make it more clear via documentation what the implementations for the operators are doing then, if not calling .CompareTo?\r\n\r\nThere was no documentation, so I stared at the code for like 10 min before giving up, lol.\r\n\r\nIs there a reason they can't call the .CompareTo method? Isn't calling .CompareTo normally the expected thing to do for those operators?"}}
{"actor":{"display_login":"faeriedust"}}