{"action":"created","comment":{"url":"https://api.github.com/repos/webmapper/amaps/pulls/comments/185719351","pull_request_review_id":117163716,"id":185719351,"diff_hunk":"@@ -22,14 +25,23 @@\n     \"nodemon\": \"^1.17.3\",\n     \"pa11y\": \"^5.0.3\",\n     \"puppeteer\": \"^1.2.0\",\n+    \"rollup\": \"^0.58.2\",\n+    \"rollup-plugin-commonjs\": \"^9.1.2\",\n+    \"rollup-plugin-json\": \"^2.3.0\",\n+    \"rollup-plugin-node-resolve\": \"^3.3.0\",\n     \"serve-static\": \"^1.13.2\",\n+    \"shx\": \"^0.2.2\",\n     \"tap\": \"^11.1.3\"\n   },\n   \"scripts\": {\n     \"test\": \"node scripts/serve\",\n     \"watch-test\": \"nodemon --watch scripts --watch test -e js,html scripts/serve.js\",\n-    \"lint\": \"eslint test scripts\",\n-    \"serve\": \"http-server test\"\n+    \"serve\": \"http-server test\",\n+    \"lint\": \"eslint test scripts && eslint -c .eslintrc-amaps.js src\",","path":"package.json","position":null,"original_position":33,"commit_id":"32924517bc15733dc3dbde75f74fdced592c2084","original_commit_id":"3fb5ea87e66f7d4488c0d0b4ae34ee111ceafd5f","user":{"login":"hpfast","id":3658858,"avatar_url":"https://avatars2.githubusercontent.com/u/3658858?v=4","gravatar_id":"","url":"https://api.github.com/users/hpfast","html_url":"https://github.com/hpfast","followers_url":"https://api.github.com/users/hpfast/followers","following_url":"https://api.github.com/users/hpfast/following{/other_user}","gists_url":"https://api.github.com/users/hpfast/gists{/gist_id}","starred_url":"https://api.github.com/users/hpfast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpfast/subscriptions","organizations_url":"https://api.github.com/users/hpfast/orgs","repos_url":"https://api.github.com/users/hpfast/repos","events_url":"https://api.github.com/users/hpfast/events{/privacy}","received_events_url":"https://api.github.com/users/hpfast/received_events","type":"User","site_admin":false},"body":"Good one! done.","created_at":"2018-05-03T07:58:11Z","updated_at":"2018-05-03T07:58:11Z","html_url":"https://github.com/webmapper/amaps/pull/12#discussion_r185719351","pull_request_url":"https://api.github.com/repos/webmapper/amaps/pulls/12","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/webmapper/amaps/pulls/comments/185719351"},"html":{"href":"https://github.com/webmapper/amaps/pull/12#discussion_r185719351"},"pull_request":{"href":"https://api.github.com/repos/webmapper/amaps/pulls/12"}},"in_reply_to_id":185522825},"pull_request":{"url":"https://api.github.com/repos/webmapper/amaps/pulls/12","id":185186460,"html_url":"https://github.com/webmapper/amaps/pull/12","diff_url":"https://github.com/webmapper/amaps/pull/12.diff","patch_url":"https://github.com/webmapper/amaps/pull/12.patch","issue_url":"https://api.github.com/repos/webmapper/amaps/issues/12","number":12,"state":"open","locked":false,"title":"Amaps as library","user":{"login":"hpfast","id":3658858,"avatar_url":"https://avatars2.githubusercontent.com/u/3658858?v=4","gravatar_id":"","url":"https://api.github.com/users/hpfast","html_url":"https://github.com/hpfast","followers_url":"https://api.github.com/users/hpfast/followers","following_url":"https://api.github.com/users/hpfast/following{/other_user}","gists_url":"https://api.github.com/users/hpfast/gists{/gist_id}","starred_url":"https://api.github.com/users/hpfast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpfast/subscriptions","organizations_url":"https://api.github.com/users/hpfast/orgs","repos_url":"https://api.github.com/users/hpfast/repos","events_url":"https://api.github.com/users/hpfast/events{/privacy}","received_events_url":"https://api.github.com/users/hpfast/received_events","type":"User","site_admin":false},"body":"An amaps library added, which gets built with new npm scripts. Naming of npm scripts can be discussed, or altered later.\r\n\r\nthe amaps library (src/index.js) contains code required to format and parse requests/responses from Amsterdam's BAG API. This includes encapsulating the coordinate transformation with proj4.","created_at":"2018-05-01T14:11:29Z","updated_at":"2018-05-03T07:58:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0f7a8c2b4bb11cd8fdfbe254a46797f1b5efe880","assignee":null,"assignees":[],"requested_reviewers":[{"login":"stvno","id":394323,"avatar_url":"https://avatars3.githubusercontent.com/u/394323?v=4","gravatar_id":"","url":"https://api.github.com/users/stvno","html_url":"https://github.com/stvno","followers_url":"https://api.github.com/users/stvno/followers","following_url":"https://api.github.com/users/stvno/following{/other_user}","gists_url":"https://api.github.com/users/stvno/gists{/gist_id}","starred_url":"https://api.github.com/users/stvno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stvno/subscriptions","organizations_url":"https://api.github.com/users/stvno/orgs","repos_url":"https://api.github.com/users/stvno/repos","events_url":"https://api.github.com/users/stvno/events{/privacy}","received_events_url":"https://api.github.com/users/stvno/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/webmapper/amaps/pulls/12/commits","review_comments_url":"https://api.github.com/repos/webmapper/amaps/pulls/12/comments","review_comment_url":"https://api.github.com/repos/webmapper/amaps/pulls/comments{/number}","comments_url":"https://api.github.com/repos/webmapper/amaps/issues/12/comments","statuses_url":"https://api.github.com/repos/webmapper/amaps/statuses/32924517bc15733dc3dbde75f74fdced592c2084","head":{"label":"webmapper:amaps-as-library","ref":"amaps-as-library","sha":"32924517bc15733dc3dbde75f74fdced592c2084","user":{"login":"webmapper","id":2046880,"avatar_url":"https://avatars3.githubusercontent.com/u/2046880?v=4","gravatar_id":"","url":"https://api.github.com/users/webmapper","html_url":"https://github.com/webmapper","followers_url":"https://api.github.com/users/webmapper/followers","following_url":"https://api.github.com/users/webmapper/following{/other_user}","gists_url":"https://api.github.com/users/webmapper/gists{/gist_id}","starred_url":"https://api.github.com/users/webmapper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webmapper/subscriptions","organizations_url":"https://api.github.com/users/webmapper/orgs","repos_url":"https://api.github.com/users/webmapper/repos","events_url":"https://api.github.com/users/webmapper/events{/privacy}","received_events_url":"https://api.github.com/users/webmapper/received_events","type":"Organization","site_admin":false},"repo":{"id":128740939,"name":"amaps","full_name":"webmapper/amaps","owner":{"login":"webmapper","id":2046880,"avatar_url":"https://avatars3.githubusercontent.com/u/2046880?v=4","gravatar_id":"","url":"https://api.github.com/users/webmapper","html_url":"https://github.com/webmapper","followers_url":"https://api.github.com/users/webmapper/followers","following_url":"https://api.github.com/users/webmapper/following{/other_user}","gists_url":"https://api.github.com/users/webmapper/gists{/gist_id}","starred_url":"https://api.github.com/users/webmapper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webmapper/subscriptions","organizations_url":"https://api.github.com/users/webmapper/orgs","repos_url":"https://api.github.com/users/webmapper/repos","events_url":"https://api.github.com/users/webmapper/events{/privacy}","received_events_url":"https://api.github.com/users/webmapper/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/webmapper/amaps","description":"implementation of nlmaps for Amsterdam","fork":false,"url":"https://api.github.com/repos/webmapper/amaps","forks_url":"https://api.github.com/repos/webmapper/amaps/forks","keys_url":"https://api.github.com/repos/webmapper/amaps/keys{/key_id}","collaborators_url":"https://api.github.com/repos/webmapper/amaps/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/webmapper/amaps/teams","hooks_url":"https://api.github.com/repos/webmapper/amaps/hooks","issue_events_url":"https://api.github.com/repos/webmapper/amaps/issues/events{/number}","events_url":"https://api.github.com/repos/webmapper/amaps/events","assignees_url":"https://api.github.com/repos/webmapper/amaps/assignees{/user}","branches_url":"https://api.github.com/repos/webmapper/amaps/branches{/branch}","tags_url":"https://api.github.com/repos/webmapper/amaps/tags","blobs_url":"https://api.github.com/repos/webmapper/amaps/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/webmapper/amaps/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/webmapper/amaps/git/refs{/sha}","trees_url":"https://api.github.com/repos/webmapper/amaps/git/trees{/sha}","statuses_url":"https://api.github.com/repos/webmapper/amaps/statuses/{sha}","languages_url":"https://api.github.com/repos/webmapper/amaps/languages","stargazers_url":"https://api.github.com/repos/webmapper/amaps/stargazers","contributors_url":"https://api.github.com/repos/webmapper/amaps/contributors","subscribers_url":"https://api.github.com/repos/webmapper/amaps/subscribers","subscription_url":"https://api.github.com/repos/webmapper/amaps/subscription","commits_url":"https://api.github.com/repos/webmapper/amaps/commits{/sha}","git_commits_url":"https://api.github.com/repos/webmapper/amaps/git/commits{/sha}","comments_url":"https://api.github.com/repos/webmapper/amaps/comments{/number}","issue_comment_url":"https://api.github.com/repos/webmapper/amaps/issues/comments{/number}","contents_url":"https://api.github.com/repos/webmapper/amaps/contents/{+path}","compare_url":"https://api.github.com/repos/webmapper/amaps/compare/{base}...{head}","merges_url":"https://api.github.com/repos/webmapper/amaps/merges","archive_url":"https://api.github.com/repos/webmapper/amaps/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/webmapper/amaps/downloads","issues_url":"https://api.github.com/repos/webmapper/amaps/issues{/number}","pulls_url":"https://api.github.com/repos/webmapper/amaps/pulls{/number}","milestones_url":"https://api.github.com/repos/webmapper/amaps/milestones{/number}","notifications_url":"https://api.github.com/repos/webmapper/amaps/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/webmapper/amaps/labels{/name}","releases_url":"https://api.github.com/repos/webmapper/amaps/releases{/id}","deployments_url":"https://api.github.com/repos/webmapper/amaps/deployments","created_at":"2018-04-09T08:40:19Z","updated_at":"2018-05-03T07:18:19Z","pushed_at":"2018-05-03T07:56:57Z","git_url":"git://github.com/webmapper/amaps.git","ssh_url":"git@github.com:webmapper/amaps.git","clone_url":"https://github.com/webmapper/amaps.git","svn_url":"https://github.com/webmapper/amaps","homepage":null,"size":374,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"webmapper:master","ref":"master","sha":"9a7a42129515a7869d6f6eee51d559f99a335200","user":{"login":"webmapper","id":2046880,"avatar_url":"https://avatars3.githubusercontent.com/u/2046880?v=4","gravatar_id":"","url":"https://api.github.com/users/webmapper","html_url":"https://github.com/webmapper","followers_url":"https://api.github.com/users/webmapper/followers","following_url":"https://api.github.com/users/webmapper/following{/other_user}","gists_url":"https://api.github.com/users/webmapper/gists{/gist_id}","starred_url":"https://api.github.com/users/webmapper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webmapper/subscriptions","organizations_url":"https://api.github.com/users/webmapper/orgs","repos_url":"https://api.github.com/users/webmapper/repos","events_url":"https://api.github.com/users/webmapper/events{/privacy}","received_events_url":"https://api.github.com/users/webmapper/received_events","type":"Organization","site_admin":false},"repo":{"id":128740939,"name":"amaps","full_name":"webmapper/amaps","owner":{"login":"webmapper","id":2046880,"avatar_url":"https://avatars3.githubusercontent.com/u/2046880?v=4","gravatar_id":"","url":"https://api.github.com/users/webmapper","html_url":"https://github.com/webmapper","followers_url":"https://api.github.com/users/webmapper/followers","following_url":"https://api.github.com/users/webmapper/following{/other_user}","gists_url":"https://api.github.com/users/webmapper/gists{/gist_id}","starred_url":"https://api.github.com/users/webmapper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webmapper/subscriptions","organizations_url":"https://api.github.com/users/webmapper/orgs","repos_url":"https://api.github.com/users/webmapper/repos","events_url":"https://api.github.com/users/webmapper/events{/privacy}","received_events_url":"https://api.github.com/users/webmapper/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/webmapper/amaps","description":"implementation of nlmaps for Amsterdam","fork":false,"url":"https://api.github.com/repos/webmapper/amaps","forks_url":"https://api.github.com/repos/webmapper/amaps/forks","keys_url":"https://api.github.com/repos/webmapper/amaps/keys{/key_id}","collaborators_url":"https://api.github.com/repos/webmapper/amaps/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/webmapper/amaps/teams","hooks_url":"https://api.github.com/repos/webmapper/amaps/hooks","issue_events_url":"https://api.github.com/repos/webmapper/amaps/issues/events{/number}","events_url":"https://api.github.com/repos/webmapper/amaps/events","assignees_url":"https://api.github.com/repos/webmapper/amaps/assignees{/user}","branches_url":"https://api.github.com/repos/webmapper/amaps/branches{/branch}","tags_url":"https://api.github.com/repos/webmapper/amaps/tags","blobs_url":"https://api.github.com/repos/webmapper/amaps/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/webmapper/amaps/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/webmapper/amaps/git/refs{/sha}","trees_url":"https://api.github.com/repos/webmapper/amaps/git/trees{/sha}","statuses_url":"https://api.github.com/repos/webmapper/amaps/statuses/{sha}","languages_url":"https://api.github.com/repos/webmapper/amaps/languages","stargazers_url":"https://api.github.com/repos/webmapper/amaps/stargazers","contributors_url":"https://api.github.com/repos/webmapper/amaps/contributors","subscribers_url":"https://api.github.com/repos/webmapper/amaps/subscribers","subscription_url":"https://api.github.com/repos/webmapper/amaps/subscription","commits_url":"https://api.github.com/repos/webmapper/amaps/commits{/sha}","git_commits_url":"https://api.github.com/repos/webmapper/amaps/git/commits{/sha}","comments_url":"https://api.github.com/repos/webmapper/amaps/comments{/number}","issue_comment_url":"https://api.github.com/repos/webmapper/amaps/issues/comments{/number}","contents_url":"https://api.github.com/repos/webmapper/amaps/contents/{+path}","compare_url":"https://api.github.com/repos/webmapper/amaps/compare/{base}...{head}","merges_url":"https://api.github.com/repos/webmapper/amaps/merges","archive_url":"https://api.github.com/repos/webmapper/amaps/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/webmapper/amaps/downloads","issues_url":"https://api.github.com/repos/webmapper/amaps/issues{/number}","pulls_url":"https://api.github.com/repos/webmapper/amaps/pulls{/number}","milestones_url":"https://api.github.com/repos/webmapper/amaps/milestones{/number}","notifications_url":"https://api.github.com/repos/webmapper/amaps/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/webmapper/amaps/labels{/name}","releases_url":"https://api.github.com/repos/webmapper/amaps/releases{/id}","deployments_url":"https://api.github.com/repos/webmapper/amaps/deployments","created_at":"2018-04-09T08:40:19Z","updated_at":"2018-05-03T07:18:19Z","pushed_at":"2018-05-03T07:56:57Z","git_url":"git://github.com/webmapper/amaps.git","ssh_url":"git@github.com:webmapper/amaps.git","clone_url":"https://github.com/webmapper/amaps.git","svn_url":"https://github.com/webmapper/amaps","homepage":null,"size":374,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/webmapper/amaps/pulls/12"},"html":{"href":"https://github.com/webmapper/amaps/pull/12"},"issue":{"href":"https://api.github.com/repos/webmapper/amaps/issues/12"},"comments":{"href":"https://api.github.com/repos/webmapper/amaps/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/webmapper/amaps/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/webmapper/amaps/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/webmapper/amaps/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/webmapper/amaps/statuses/32924517bc15733dc3dbde75f74fdced592c2084"}},"author_association":"OWNER"}}
{"actor":{"display_login":"hpfast"}}