{"action":"created","comment":{"url":"https://api.github.com/repos/google/flatbuffers/pulls/comments/232336049","pull_request_review_id":173517848,"id":232336049,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjMzNjA0OQ==","diff_hunk":"@@ -337,6 +337,17 @@ class Map : public Vector {\n   bool IsTheEmptyMap() const { return data_ == EmptyMap().data_; }\n };\n \n+template<typename T>\n+void AppendToString(std::string &s, T &&v, bool keys_quoted)\n+{\n+    s += \"[ \";\n+    for (size_t i = 0; i < v.size(); i++) {\n+      v[i].ToString(true, keys_quoted, s);\n+      if (i < v.size() - 1) s += \", \";","path":"include/flatbuffers/flexbuffers.h","position":null,"original_position":10,"commit_id":"2c3a92e3c16ff731d9adb6a84c40f36286f7613f","original_commit_id":"1ee0a69a45d6737dcbe7e0c059efba76ca7613a1","user":{"login":"aardappel","id":4663648,"node_id":"MDQ6VXNlcjQ2NjM2NDg=","avatar_url":"https://avatars2.githubusercontent.com/u/4663648?v=4","gravatar_id":"","url":"https://api.github.com/users/aardappel","html_url":"https://github.com/aardappel","followers_url":"https://api.github.com/users/aardappel/followers","following_url":"https://api.github.com/users/aardappel/following{/other_user}","gists_url":"https://api.github.com/users/aardappel/gists{/gist_id}","starred_url":"https://api.github.com/users/aardappel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aardappel/subscriptions","organizations_url":"https://api.github.com/users/aardappel/orgs","repos_url":"https://api.github.com/users/aardappel/repos","events_url":"https://api.github.com/users/aardappel/events{/privacy}","received_events_url":"https://api.github.com/users/aardappel/received_events","type":"User","site_admin":false},"body":"If you don't understand, ask, don't ignore :)\r\n\r\nHow about:\r\n```\r\n      if (i) s += \", \";\r\n      v[i].ToString(true, keys_quoted, s);\r\n```","created_at":"2018-11-09T17:42:48Z","updated_at":"2018-11-09T17:42:49Z","html_url":"https://github.com/google/flatbuffers/pull/4947#discussion_r232336049","pull_request_url":"https://api.github.com/repos/google/flatbuffers/pulls/4947","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/google/flatbuffers/pulls/comments/232336049"},"html":{"href":"https://github.com/google/flatbuffers/pull/4947#discussion_r232336049"},"pull_request":{"href":"https://api.github.com/repos/google/flatbuffers/pulls/4947"}},"in_reply_to_id":223504817},"pull_request":{"url":"https://api.github.com/repos/google/flatbuffers/pulls/4947","id":218251362,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4MjUxMzYy","html_url":"https://github.com/google/flatbuffers/pull/4947","diff_url":"https://github.com/google/flatbuffers/pull/4947.diff","patch_url":"https://github.com/google/flatbuffers/pull/4947.patch","issue_url":"https://api.github.com/repos/google/flatbuffers/issues/4947","number":4947,"state":"open","locked":false,"title":"FlexBuffer to JSON convertor for typed and fixedTypedvectors","user":{"login":"shivendra14","id":3680192,"node_id":"MDQ6VXNlcjM2ODAxOTI=","avatar_url":"https://avatars1.githubusercontent.com/u/3680192?v=4","gravatar_id":"","url":"https://api.github.com/users/shivendra14","html_url":"https://github.com/shivendra14","followers_url":"https://api.github.com/users/shivendra14/followers","following_url":"https://api.github.com/users/shivendra14/following{/other_user}","gists_url":"https://api.github.com/users/shivendra14/gists{/gist_id}","starred_url":"https://api.github.com/users/shivendra14/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shivendra14/subscriptions","organizations_url":"https://api.github.com/users/shivendra14/orgs","repos_url":"https://api.github.com/users/shivendra14/repos","events_url":"https://api.github.com/users/shivendra14/events{/privacy}","received_events_url":"https://api.github.com/users/shivendra14/received_events","type":"User","site_admin":false},"body":"fix for https://github.com/google/flatbuffers/issues/4889","created_at":"2018-09-26T09:45:30Z","updated_at":"2018-11-09T17:42:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"39e5fe85d064f3fd6a6c090f1f18475a0462bfef","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/google/flatbuffers/pulls/4947/commits","review_comments_url":"https://api.github.com/repos/google/flatbuffers/pulls/4947/comments","review_comment_url":"https://api.github.com/repos/google/flatbuffers/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/flatbuffers/issues/4947/comments","statuses_url":"https://api.github.com/repos/google/flatbuffers/statuses/2c3a92e3c16ff731d9adb6a84c40f36286f7613f","head":{"label":"shivendra14:master","ref":"master","sha":"2c3a92e3c16ff731d9adb6a84c40f36286f7613f","user":{"login":"shivendra14","id":3680192,"node_id":"MDQ6VXNlcjM2ODAxOTI=","avatar_url":"https://avatars1.githubusercontent.com/u/3680192?v=4","gravatar_id":"","url":"https://api.github.com/users/shivendra14","html_url":"https://github.com/shivendra14","followers_url":"https://api.github.com/users/shivendra14/followers","following_url":"https://api.github.com/users/shivendra14/following{/other_user}","gists_url":"https://api.github.com/users/shivendra14/gists{/gist_id}","starred_url":"https://api.github.com/users/shivendra14/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shivendra14/subscriptions","organizations_url":"https://api.github.com/users/shivendra14/orgs","repos_url":"https://api.github.com/users/shivendra14/repos","events_url":"https://api.github.com/users/shivendra14/events{/privacy}","received_events_url":"https://api.github.com/users/shivendra14/received_events","type":"User","site_admin":false},"repo":{"id":136917672,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY5MTc2NzI=","name":"flatbuffers","full_name":"shivendra14/flatbuffers","private":false,"owner":{"login":"shivendra14","id":3680192,"node_id":"MDQ6VXNlcjM2ODAxOTI=","avatar_url":"https://avatars1.githubusercontent.com/u/3680192?v=4","gravatar_id":"","url":"https://api.github.com/users/shivendra14","html_url":"https://github.com/shivendra14","followers_url":"https://api.github.com/users/shivendra14/followers","following_url":"https://api.github.com/users/shivendra14/following{/other_user}","gists_url":"https://api.github.com/users/shivendra14/gists{/gist_id}","starred_url":"https://api.github.com/users/shivendra14/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shivendra14/subscriptions","organizations_url":"https://api.github.com/users/shivendra14/orgs","repos_url":"https://api.github.com/users/shivendra14/repos","events_url":"https://api.github.com/users/shivendra14/events{/privacy}","received_events_url":"https://api.github.com/users/shivendra14/received_events","type":"User","site_admin":false},"html_url":"https://github.com/shivendra14/flatbuffers","description":"Memory Efficient Serialization Library","fork":true,"url":"https://api.github.com/repos/shivendra14/flatbuffers","forks_url":"https://api.github.com/repos/shivendra14/flatbuffers/forks","keys_url":"https://api.github.com/repos/shivendra14/flatbuffers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shivendra14/flatbuffers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shivendra14/flatbuffers/teams","hooks_url":"https://api.github.com/repos/shivendra14/flatbuffers/hooks","issue_events_url":"https://api.github.com/repos/shivendra14/flatbuffers/issues/events{/number}","events_url":"https://api.github.com/repos/shivendra14/flatbuffers/events","assignees_url":"https://api.github.com/repos/shivendra14/flatbuffers/assignees{/user}","branches_url":"https://api.github.com/repos/shivendra14/flatbuffers/branches{/branch}","tags_url":"https://api.github.com/repos/shivendra14/flatbuffers/tags","blobs_url":"https://api.github.com/repos/shivendra14/flatbuffers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shivendra14/flatbuffers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shivendra14/flatbuffers/git/refs{/sha}","trees_url":"https://api.github.com/repos/shivendra14/flatbuffers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shivendra14/flatbuffers/statuses/{sha}","languages_url":"https://api.github.com/repos/shivendra14/flatbuffers/languages","stargazers_url":"https://api.github.com/repos/shivendra14/flatbuffers/stargazers","contributors_url":"https://api.github.com/repos/shivendra14/flatbuffers/contributors","subscribers_url":"https://api.github.com/repos/shivendra14/flatbuffers/subscribers","subscription_url":"https://api.github.com/repos/shivendra14/flatbuffers/subscription","commits_url":"https://api.github.com/repos/shivendra14/flatbuffers/commits{/sha}","git_commits_url":"https://api.github.com/repos/shivendra14/flatbuffers/git/commits{/sha}","comments_url":"https://api.github.com/repos/shivendra14/flatbuffers/comments{/number}","issue_comment_url":"https://api.github.com/repos/shivendra14/flatbuffers/issues/comments{/number}","contents_url":"https://api.github.com/repos/shivendra14/flatbuffers/contents/{+path}","compare_url":"https://api.github.com/repos/shivendra14/flatbuffers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shivendra14/flatbuffers/merges","archive_url":"https://api.github.com/repos/shivendra14/flatbuffers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shivendra14/flatbuffers/downloads","issues_url":"https://api.github.com/repos/shivendra14/flatbuffers/issues{/number}","pulls_url":"https://api.github.com/repos/shivendra14/flatbuffers/pulls{/number}","milestones_url":"https://api.github.com/repos/shivendra14/flatbuffers/milestones{/number}","notifications_url":"https://api.github.com/repos/shivendra14/flatbuffers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shivendra14/flatbuffers/labels{/name}","releases_url":"https://api.github.com/repos/shivendra14/flatbuffers/releases{/id}","deployments_url":"https://api.github.com/repos/shivendra14/flatbuffers/deployments","created_at":"2018-06-11T11:36:02Z","updated_at":"2018-11-08T11:22:50Z","pushed_at":"2018-11-08T11:22:46Z","git_url":"git://github.com/shivendra14/flatbuffers.git","ssh_url":"git@github.com:shivendra14/flatbuffers.git","clone_url":"https://github.com/shivendra14/flatbuffers.git","svn_url":"https://github.com/shivendra14/flatbuffers","homepage":"http://google.github.io/flatbuffers/","size":7582,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"b6c3d7b8994ee1bcb389f0deb890cfa97c8f5ba7","user":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":19953044,"node_id":"MDEwOlJlcG9zaXRvcnkxOTk1MzA0NA==","name":"flatbuffers","full_name":"google/flatbuffers","private":false,"owner":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/google/flatbuffers","description":"Memory Efficient Serialization Library","fork":false,"url":"https://api.github.com/repos/google/flatbuffers","forks_url":"https://api.github.com/repos/google/flatbuffers/forks","keys_url":"https://api.github.com/repos/google/flatbuffers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/flatbuffers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/flatbuffers/teams","hooks_url":"https://api.github.com/repos/google/flatbuffers/hooks","issue_events_url":"https://api.github.com/repos/google/flatbuffers/issues/events{/number}","events_url":"https://api.github.com/repos/google/flatbuffers/events","assignees_url":"https://api.github.com/repos/google/flatbuffers/assignees{/user}","branches_url":"https://api.github.com/repos/google/flatbuffers/branches{/branch}","tags_url":"https://api.github.com/repos/google/flatbuffers/tags","blobs_url":"https://api.github.com/repos/google/flatbuffers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/flatbuffers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/flatbuffers/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/flatbuffers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/flatbuffers/statuses/{sha}","languages_url":"https://api.github.com/repos/google/flatbuffers/languages","stargazers_url":"https://api.github.com/repos/google/flatbuffers/stargazers","contributors_url":"https://api.github.com/repos/google/flatbuffers/contributors","subscribers_url":"https://api.github.com/repos/google/flatbuffers/subscribers","subscription_url":"https://api.github.com/repos/google/flatbuffers/subscription","commits_url":"https://api.github.com/repos/google/flatbuffers/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/flatbuffers/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/flatbuffers/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/flatbuffers/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/flatbuffers/contents/{+path}","compare_url":"https://api.github.com/repos/google/flatbuffers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/flatbuffers/merges","archive_url":"https://api.github.com/repos/google/flatbuffers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/flatbuffers/downloads","issues_url":"https://api.github.com/repos/google/flatbuffers/issues{/number}","pulls_url":"https://api.github.com/repos/google/flatbuffers/pulls{/number}","milestones_url":"https://api.github.com/repos/google/flatbuffers/milestones{/number}","notifications_url":"https://api.github.com/repos/google/flatbuffers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/flatbuffers/labels{/name}","releases_url":"https://api.github.com/repos/google/flatbuffers/releases{/id}","deployments_url":"https://api.github.com/repos/google/flatbuffers/deployments","created_at":"2014-05-19T18:33:01Z","updated_at":"2018-11-09T11:47:18Z","pushed_at":"2018-11-08T11:22:47Z","git_url":"git://github.com/google/flatbuffers.git","ssh_url":"git@github.com:google/flatbuffers.git","clone_url":"https://github.com/google/flatbuffers.git","svn_url":"https://github.com/google/flatbuffers","homepage":"http://google.github.io/flatbuffers/","size":7747,"stargazers_count":10700,"watchers_count":10700,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1690,"mirror_url":null,"archived":false,"open_issues_count":312,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1690,"open_issues":312,"watchers":10700,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/flatbuffers/pulls/4947"},"html":{"href":"https://github.com/google/flatbuffers/pull/4947"},"issue":{"href":"https://api.github.com/repos/google/flatbuffers/issues/4947"},"comments":{"href":"https://api.github.com/repos/google/flatbuffers/issues/4947/comments"},"review_comments":{"href":"https://api.github.com/repos/google/flatbuffers/pulls/4947/comments"},"review_comment":{"href":"https://api.github.com/repos/google/flatbuffers/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/flatbuffers/pulls/4947/commits"},"statuses":{"href":"https://api.github.com/repos/google/flatbuffers/statuses/2c3a92e3c16ff731d9adb6a84c40f36286f7613f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"aardappel"}}