{"action":"created","comment":{"url":"https://api.github.com/repos/mawww/kakoune/pulls/comments/191739864","pull_request_review_id":124369192,"id":191739864,"diff_hunk":"@@ -70,6 +80,10 @@ define-command -hidden lint-show %{\n         fi\n     } }\n \n+define-command -hidden lint-show-counters %{\n+    echo -markup linting results:{red} %opt{lint_error_count} error(s){yellow} %opt{lint_warning_count} warning(s)","path":"rc/base/lint.kak","position":51,"original_position":51,"commit_id":"712feed7e5de4327031265ad3a50398f458c8128","original_commit_id":"712feed7e5de4327031265ad3a50398f458c8128","user":{"login":"Delapouite","id":39315,"avatar_url":"https://avatars0.githubusercontent.com/u/39315?v=4","gravatar_id":"","url":"https://api.github.com/users/Delapouite","html_url":"https://github.com/Delapouite","followers_url":"https://api.github.com/users/Delapouite/followers","following_url":"https://api.github.com/users/Delapouite/following{/other_user}","gists_url":"https://api.github.com/users/Delapouite/gists{/gist_id}","starred_url":"https://api.github.com/users/Delapouite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Delapouite/subscriptions","organizations_url":"https://api.github.com/users/Delapouite/orgs","repos_url":"https://api.github.com/users/Delapouite/repos","events_url":"https://api.github.com/users/Delapouite/events{/privacy}","received_events_url":"https://api.github.com/users/Delapouite/received_events","type":"User","site_admin":false},"body":"I used explicit `{red}` and `{yellow}` colors to mirror the same hardcoded value of the `█` blocks in the gutter:\r\n```\r\nflags = flags \":\" $2 \"|{red}█\"\r\nflags = flags \":\" $2 \"|{yellow}█\"\r\n```\r\n\r\nIn default.kak:\r\n```\r\nface global Information black,yellow\r\nface global Error black,red\r\n```\r\nthese two faces use yellow and red as background, but `█` needs it as foreground.","created_at":"2018-05-30T12:04:31Z","updated_at":"2018-05-30T12:04:31Z","html_url":"https://github.com/mawww/kakoune/pull/2085#discussion_r191739864","pull_request_url":"https://api.github.com/repos/mawww/kakoune/pulls/2085","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mawww/kakoune/pulls/comments/191739864"},"html":{"href":"https://github.com/mawww/kakoune/pull/2085#discussion_r191739864"},"pull_request":{"href":"https://api.github.com/repos/mawww/kakoune/pulls/2085"}},"in_reply_to_id":191064031},"pull_request":{"url":"https://api.github.com/repos/mawww/kakoune/pulls/2085","id":190736121,"html_url":"https://github.com/mawww/kakoune/pull/2085","diff_url":"https://github.com/mawww/kakoune/pull/2085.diff","patch_url":"https://github.com/mawww/kakoune/pull/2085.patch","issue_url":"https://api.github.com/repos/mawww/kakoune/issues/2085","number":2085,"state":"open","locked":false,"title":"Display a more comprehensive status message for lint command","user":{"login":"Delapouite","id":39315,"avatar_url":"https://avatars0.githubusercontent.com/u/39315?v=4","gravatar_id":"","url":"https://api.github.com/users/Delapouite","html_url":"https://github.com/Delapouite","followers_url":"https://api.github.com/users/Delapouite/followers","following_url":"https://api.github.com/users/Delapouite/following{/other_user}","gists_url":"https://api.github.com/users/Delapouite/gists{/gist_id}","starred_url":"https://api.github.com/users/Delapouite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Delapouite/subscriptions","organizations_url":"https://api.github.com/users/Delapouite/orgs","repos_url":"https://api.github.com/users/Delapouite/repos","events_url":"https://api.github.com/users/Delapouite/events{/privacy}","received_events_url":"https://api.github.com/users/Delapouite/received_events","type":"User","site_admin":false},"body":"Hi\r\n\r\nCurrently, after a linting operation a bland `linting done` message pops in the status bar.\r\n\r\nWith this PR, the message gives more useful indications: `linting results: 2 error(s) 11 warning(s)` (see bottom of screenshot below).\r\n\r\n## Other benefits giving more control to users\r\n\r\n- 2 options are available `lint_error_count` and `lint_warning_count`, so users can use them elsewhere. For example to permanently display their values in `modelinefmt` or do other calculations.\r\n- if users don't remember how many errors/warnings were displayed in the status, they can run the `lint-show-counters` again.\r\n- if users don't want to be annoyed with the status message, they can alias `lint-show-counters` as `nop`.\r\n- users can `-override` `lint-show-counters` for their needs (if they don't like the default colors or the formatting).\r\n\r\n![lint-status](https://user-images.githubusercontent.com/39315/40575157-c28258b0-60df-11e8-8202-1a185443bae9.png)\r\n\r\n\r\n\r\n\r\n","created_at":"2018-05-26T10:30:58Z","updated_at":"2018-05-30T12:04:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a40add0740f921ef553e3e0f925e6f8fa2f983ee","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mawww/kakoune/pulls/2085/commits","review_comments_url":"https://api.github.com/repos/mawww/kakoune/pulls/2085/comments","review_comment_url":"https://api.github.com/repos/mawww/kakoune/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mawww/kakoune/issues/2085/comments","statuses_url":"https://api.github.com/repos/mawww/kakoune/statuses/712feed7e5de4327031265ad3a50398f458c8128","head":{"label":"Delapouite:lint-counters","ref":"lint-counters","sha":"712feed7e5de4327031265ad3a50398f458c8128","user":{"login":"Delapouite","id":39315,"avatar_url":"https://avatars0.githubusercontent.com/u/39315?v=4","gravatar_id":"","url":"https://api.github.com/users/Delapouite","html_url":"https://github.com/Delapouite","followers_url":"https://api.github.com/users/Delapouite/followers","following_url":"https://api.github.com/users/Delapouite/following{/other_user}","gists_url":"https://api.github.com/users/Delapouite/gists{/gist_id}","starred_url":"https://api.github.com/users/Delapouite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Delapouite/subscriptions","organizations_url":"https://api.github.com/users/Delapouite/orgs","repos_url":"https://api.github.com/users/Delapouite/repos","events_url":"https://api.github.com/users/Delapouite/events{/privacy}","received_events_url":"https://api.github.com/users/Delapouite/received_events","type":"User","site_admin":false},"repo":{"id":53215593,"name":"kakoune","full_name":"Delapouite/kakoune","owner":{"login":"Delapouite","id":39315,"avatar_url":"https://avatars0.githubusercontent.com/u/39315?v=4","gravatar_id":"","url":"https://api.github.com/users/Delapouite","html_url":"https://github.com/Delapouite","followers_url":"https://api.github.com/users/Delapouite/followers","following_url":"https://api.github.com/users/Delapouite/following{/other_user}","gists_url":"https://api.github.com/users/Delapouite/gists{/gist_id}","starred_url":"https://api.github.com/users/Delapouite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Delapouite/subscriptions","organizations_url":"https://api.github.com/users/Delapouite/orgs","repos_url":"https://api.github.com/users/Delapouite/repos","events_url":"https://api.github.com/users/Delapouite/events{/privacy}","received_events_url":"https://api.github.com/users/Delapouite/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Delapouite/kakoune","description":"mawww's experiment for a better code editor","fork":true,"url":"https://api.github.com/repos/Delapouite/kakoune","forks_url":"https://api.github.com/repos/Delapouite/kakoune/forks","keys_url":"https://api.github.com/repos/Delapouite/kakoune/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Delapouite/kakoune/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Delapouite/kakoune/teams","hooks_url":"https://api.github.com/repos/Delapouite/kakoune/hooks","issue_events_url":"https://api.github.com/repos/Delapouite/kakoune/issues/events{/number}","events_url":"https://api.github.com/repos/Delapouite/kakoune/events","assignees_url":"https://api.github.com/repos/Delapouite/kakoune/assignees{/user}","branches_url":"https://api.github.com/repos/Delapouite/kakoune/branches{/branch}","tags_url":"https://api.github.com/repos/Delapouite/kakoune/tags","blobs_url":"https://api.github.com/repos/Delapouite/kakoune/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Delapouite/kakoune/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Delapouite/kakoune/git/refs{/sha}","trees_url":"https://api.github.com/repos/Delapouite/kakoune/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Delapouite/kakoune/statuses/{sha}","languages_url":"https://api.github.com/repos/Delapouite/kakoune/languages","stargazers_url":"https://api.github.com/repos/Delapouite/kakoune/stargazers","contributors_url":"https://api.github.com/repos/Delapouite/kakoune/contributors","subscribers_url":"https://api.github.com/repos/Delapouite/kakoune/subscribers","subscription_url":"https://api.github.com/repos/Delapouite/kakoune/subscription","commits_url":"https://api.github.com/repos/Delapouite/kakoune/commits{/sha}","git_commits_url":"https://api.github.com/repos/Delapouite/kakoune/git/commits{/sha}","comments_url":"https://api.github.com/repos/Delapouite/kakoune/comments{/number}","issue_comment_url":"https://api.github.com/repos/Delapouite/kakoune/issues/comments{/number}","contents_url":"https://api.github.com/repos/Delapouite/kakoune/contents/{+path}","compare_url":"https://api.github.com/repos/Delapouite/kakoune/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Delapouite/kakoune/merges","archive_url":"https://api.github.com/repos/Delapouite/kakoune/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Delapouite/kakoune/downloads","issues_url":"https://api.github.com/repos/Delapouite/kakoune/issues{/number}","pulls_url":"https://api.github.com/repos/Delapouite/kakoune/pulls{/number}","milestones_url":"https://api.github.com/repos/Delapouite/kakoune/milestones{/number}","notifications_url":"https://api.github.com/repos/Delapouite/kakoune/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Delapouite/kakoune/labels{/name}","releases_url":"https://api.github.com/repos/Delapouite/kakoune/releases{/id}","deployments_url":"https://api.github.com/repos/Delapouite/kakoune/deployments","created_at":"2016-03-05T18:08:22Z","updated_at":"2018-05-26T10:02:49Z","pushed_at":"2018-05-26T10:30:33Z","git_url":"git://github.com/Delapouite/kakoune.git","ssh_url":"git@github.com:Delapouite/kakoune.git","clone_url":"https://github.com/Delapouite/kakoune.git","svn_url":"https://github.com/Delapouite/kakoune","homepage":"","size":33232,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"unlicense","name":"The Unlicense","spdx_id":"Unlicense","url":"https://api.github.com/licenses/unlicense"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mawww:master","ref":"master","sha":"54b62cbef7a534fed6278cc42c4df1f9ddc6b57a","user":{"login":"mawww","id":51221,"avatar_url":"https://avatars1.githubusercontent.com/u/51221?v=4","gravatar_id":"","url":"https://api.github.com/users/mawww","html_url":"https://github.com/mawww","followers_url":"https://api.github.com/users/mawww/followers","following_url":"https://api.github.com/users/mawww/following{/other_user}","gists_url":"https://api.github.com/users/mawww/gists{/gist_id}","starred_url":"https://api.github.com/users/mawww/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mawww/subscriptions","organizations_url":"https://api.github.com/users/mawww/orgs","repos_url":"https://api.github.com/users/mawww/repos","events_url":"https://api.github.com/users/mawww/events{/privacy}","received_events_url":"https://api.github.com/users/mawww/received_events","type":"User","site_admin":false},"repo":{"id":2701888,"name":"kakoune","full_name":"mawww/kakoune","owner":{"login":"mawww","id":51221,"avatar_url":"https://avatars1.githubusercontent.com/u/51221?v=4","gravatar_id":"","url":"https://api.github.com/users/mawww","html_url":"https://github.com/mawww","followers_url":"https://api.github.com/users/mawww/followers","following_url":"https://api.github.com/users/mawww/following{/other_user}","gists_url":"https://api.github.com/users/mawww/gists{/gist_id}","starred_url":"https://api.github.com/users/mawww/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mawww/subscriptions","organizations_url":"https://api.github.com/users/mawww/orgs","repos_url":"https://api.github.com/users/mawww/repos","events_url":"https://api.github.com/users/mawww/events{/privacy}","received_events_url":"https://api.github.com/users/mawww/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mawww/kakoune","description":"mawww's experiment for a better code editor","fork":false,"url":"https://api.github.com/repos/mawww/kakoune","forks_url":"https://api.github.com/repos/mawww/kakoune/forks","keys_url":"https://api.github.com/repos/mawww/kakoune/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mawww/kakoune/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mawww/kakoune/teams","hooks_url":"https://api.github.com/repos/mawww/kakoune/hooks","issue_events_url":"https://api.github.com/repos/mawww/kakoune/issues/events{/number}","events_url":"https://api.github.com/repos/mawww/kakoune/events","assignees_url":"https://api.github.com/repos/mawww/kakoune/assignees{/user}","branches_url":"https://api.github.com/repos/mawww/kakoune/branches{/branch}","tags_url":"https://api.github.com/repos/mawww/kakoune/tags","blobs_url":"https://api.github.com/repos/mawww/kakoune/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mawww/kakoune/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mawww/kakoune/git/refs{/sha}","trees_url":"https://api.github.com/repos/mawww/kakoune/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mawww/kakoune/statuses/{sha}","languages_url":"https://api.github.com/repos/mawww/kakoune/languages","stargazers_url":"https://api.github.com/repos/mawww/kakoune/stargazers","contributors_url":"https://api.github.com/repos/mawww/kakoune/contributors","subscribers_url":"https://api.github.com/repos/mawww/kakoune/subscribers","subscription_url":"https://api.github.com/repos/mawww/kakoune/subscription","commits_url":"https://api.github.com/repos/mawww/kakoune/commits{/sha}","git_commits_url":"https://api.github.com/repos/mawww/kakoune/git/commits{/sha}","comments_url":"https://api.github.com/repos/mawww/kakoune/comments{/number}","issue_comment_url":"https://api.github.com/repos/mawww/kakoune/issues/comments{/number}","contents_url":"https://api.github.com/repos/mawww/kakoune/contents/{+path}","compare_url":"https://api.github.com/repos/mawww/kakoune/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mawww/kakoune/merges","archive_url":"https://api.github.com/repos/mawww/kakoune/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mawww/kakoune/downloads","issues_url":"https://api.github.com/repos/mawww/kakoune/issues{/number}","pulls_url":"https://api.github.com/repos/mawww/kakoune/pulls{/number}","milestones_url":"https://api.github.com/repos/mawww/kakoune/milestones{/number}","notifications_url":"https://api.github.com/repos/mawww/kakoune/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mawww/kakoune/labels{/name}","releases_url":"https://api.github.com/repos/mawww/kakoune/releases{/id}","deployments_url":"https://api.github.com/repos/mawww/kakoune/deployments","created_at":"2011-11-03T12:43:55Z","updated_at":"2018-05-30T03:43:14Z","pushed_at":"2018-05-28T11:19:54Z","git_url":"git://github.com/mawww/kakoune.git","ssh_url":"git@github.com:mawww/kakoune.git","clone_url":"https://github.com/mawww/kakoune.git","svn_url":"https://github.com/mawww/kakoune","homepage":"http://kakoune.org","size":35411,"stargazers_count":3415,"watchers_count":3415,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":230,"mirror_url":null,"archived":false,"open_issues_count":210,"license":{"key":"unlicense","name":"The Unlicense","spdx_id":"Unlicense","url":"https://api.github.com/licenses/unlicense"},"forks":230,"open_issues":210,"watchers":3415,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mawww/kakoune/pulls/2085"},"html":{"href":"https://github.com/mawww/kakoune/pull/2085"},"issue":{"href":"https://api.github.com/repos/mawww/kakoune/issues/2085"},"comments":{"href":"https://api.github.com/repos/mawww/kakoune/issues/2085/comments"},"review_comments":{"href":"https://api.github.com/repos/mawww/kakoune/pulls/2085/comments"},"review_comment":{"href":"https://api.github.com/repos/mawww/kakoune/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mawww/kakoune/pulls/2085/commits"},"statuses":{"href":"https://api.github.com/repos/mawww/kakoune/statuses/712feed7e5de4327031265ad3a50398f458c8128"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Delapouite"}}