{"action":"created","issue":{"url":"https://api.github.com/repos/elastic/elasticsearch/issues/33721","repository_url":"https://api.github.com/repos/elastic/elasticsearch","labels_url":"https://api.github.com/repos/elastic/elasticsearch/issues/33721/labels{/name}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/issues/33721/comments","events_url":"https://api.github.com/repos/elastic/elasticsearch/issues/33721/events","html_url":"https://github.com/elastic/elasticsearch/pull/33721","id":360355167,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1NjMzNzY1","number":33721,"title":"[GCE Discovery] Automatically set project-id and zone","user":{"login":"vladimirdolzhenko","id":209440,"node_id":"MDQ6VXNlcjIwOTQ0MA==","avatar_url":"https://avatars0.githubusercontent.com/u/209440?v=4","gravatar_id":"","url":"https://api.github.com/users/vladimirdolzhenko","html_url":"https://github.com/vladimirdolzhenko","followers_url":"https://api.github.com/users/vladimirdolzhenko/followers","following_url":"https://api.github.com/users/vladimirdolzhenko/following{/other_user}","gists_url":"https://api.github.com/users/vladimirdolzhenko/gists{/gist_id}","starred_url":"https://api.github.com/users/vladimirdolzhenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vladimirdolzhenko/subscriptions","organizations_url":"https://api.github.com/users/vladimirdolzhenko/orgs","repos_url":"https://api.github.com/users/vladimirdolzhenko/repos","events_url":"https://api.github.com/users/vladimirdolzhenko/events{/privacy}","received_events_url":"https://api.github.com/users/vladimirdolzhenko/received_events","type":"User","site_admin":false},"labels":[{"id":160579278,"node_id":"MDU6TGFiZWwxNjA1NzkyNzg=","url":"https://api.github.com/repos/elastic/elasticsearch/labels/:Distributed/Discovery-Plugins","name":":Distributed/Discovery-Plugins","color":"0e8a16","default":false},{"id":23174,"node_id":"MDU6TGFiZWwyMzE3NA==","url":"https://api.github.com/repos/elastic/elasticsearch/labels/%3Eenhancement","name":">enhancement","color":"4a4ea8","default":false},{"id":484855464,"node_id":"MDU6TGFiZWw0ODQ4NTU0NjQ=","url":"https://api.github.com/repos/elastic/elasticsearch/labels/v7.0.0","name":"v7.0.0","color":"dddddd","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-09-14T15:36:46Z","updated_at":"2018-09-19T11:40:57Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/33721","html_url":"https://github.com/elastic/elasticsearch/pull/33721","diff_url":"https://github.com/elastic/elasticsearch/pull/33721.diff","patch_url":"https://github.com/elastic/elasticsearch/pull/33721.patch"},"body":"Settings `cloud.gce.project_id`, `cloud.gce.zone` are not mandatory - they could be automatically set from a gce metadata server.  Picking up the default zone is useful for cases like a single region. \r\n\r\nDetails on impl differences with GCE:\r\n[com.google.cloud.ServiceOptions#getDefaultProjectId ](https://github.com/GoogleCloudPlatform/google-cloud-java/blob/master/google-cloud-clients/google-cloud-core/src/main/java/com/google/cloud/ServiceOptions.java#L333) tries to resolve project based on\r\n* system property `GOOGLE_CLOUD_PROJECT` (or legacy system property `GCLOUD_PROJECT`) \r\n* environment variable `GOOGLE_CLOUD_PROJECT` or `GCLOUD_PROJECT` \r\n* from `http://metadata.google.internal/computeMetadata/v1/project/project-id`\r\n\r\nThis PR allows without settings to fallback to retrieve info from gce metadata server  \r\n\r\nCloses #13618"},"comment":{"url":"https://api.github.com/repos/elastic/elasticsearch/issues/comments/422768867","html_url":"https://github.com/elastic/elasticsearch/pull/33721#issuecomment-422768867","issue_url":"https://api.github.com/repos/elastic/elasticsearch/issues/33721","id":422768867,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMjc2ODg2Nw==","user":{"login":"dadoonet","id":274222,"node_id":"MDQ6VXNlcjI3NDIyMg==","avatar_url":"https://avatars3.githubusercontent.com/u/274222?v=4","gravatar_id":"","url":"https://api.github.com/users/dadoonet","html_url":"https://github.com/dadoonet","followers_url":"https://api.github.com/users/dadoonet/followers","following_url":"https://api.github.com/users/dadoonet/following{/other_user}","gists_url":"https://api.github.com/users/dadoonet/gists{/gist_id}","starred_url":"https://api.github.com/users/dadoonet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dadoonet/subscriptions","organizations_url":"https://api.github.com/users/dadoonet/orgs","repos_url":"https://api.github.com/users/dadoonet/repos","events_url":"https://api.github.com/users/dadoonet/events{/privacy}","received_events_url":"https://api.github.com/users/dadoonet/received_events","type":"User","site_admin":false},"created_at":"2018-09-19T11:40:57Z","updated_at":"2018-09-19T11:40:57Z","author_association":"MEMBER","body":"May be that change since I opened the original issue. :) "}}
{"actor":{"display_login":"dadoonet"}}