{"action":"created","comment":{"url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/comments/175317444","pull_request_review_id":104825285,"id":175317444,"diff_hunk":"@@ -57,6 +64,15 @@ public EntityPlayerMP getPlayer()\n         return player;\n     }\n \n+    /**\n+     * The world of the chunk.\n+     * @return\n+     */\n+    public World getWorld()","path":"src/main/java/net/minecraftforge/event/world/ChunkWatchEvent.java","position":49,"original_position":44,"commit_id":"3cb072b379df89dda48a8cd315f1d51c2a1ad14c","original_commit_id":"b9974bab4a56d75bfc8ca7f704337a723aeb239d","user":{"login":"mezz","id":916092,"avatar_url":"https://avatars1.githubusercontent.com/u/916092?v=4","gravatar_id":"","url":"https://api.github.com/users/mezz","html_url":"https://github.com/mezz","followers_url":"https://api.github.com/users/mezz/followers","following_url":"https://api.github.com/users/mezz/following{/other_user}","gists_url":"https://api.github.com/users/mezz/gists{/gist_id}","starred_url":"https://api.github.com/users/mezz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mezz/subscriptions","organizations_url":"https://api.github.com/users/mezz/orgs","repos_url":"https://api.github.com/users/mezz/repos","events_url":"https://api.github.com/users/mezz/events{/privacy}","received_events_url":"https://api.github.com/users/mezz/received_events","type":"User","site_admin":false},"body":"To be completely safe you can mark it nullable with a comment saying to remove the nullable annotation when the old constructor is removed.","created_at":"2018-03-19T02:06:45Z","updated_at":"2018-03-19T02:06:45Z","html_url":"https://github.com/MinecraftForge/MinecraftForge/pull/4805#discussion_r175317444","pull_request_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/4805","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/comments/175317444"},"html":{"href":"https://github.com/MinecraftForge/MinecraftForge/pull/4805#discussion_r175317444"},"pull_request":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/4805"}},"in_reply_to_id":175272728},"pull_request":{"url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/4805","id":175718602,"html_url":"https://github.com/MinecraftForge/MinecraftForge/pull/4805","diff_url":"https://github.com/MinecraftForge/MinecraftForge/pull/4805.diff","patch_url":"https://github.com/MinecraftForge/MinecraftForge/pull/4805.patch","issue_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/4805","number":4805,"state":"open","locked":false,"title":"Added chunk's world reference to ChunkWatchEvent","user":{"login":"TheCyberBrick","id":2338519,"avatar_url":"https://avatars2.githubusercontent.com/u/2338519?v=4","gravatar_id":"","url":"https://api.github.com/users/TheCyberBrick","html_url":"https://github.com/TheCyberBrick","followers_url":"https://api.github.com/users/TheCyberBrick/followers","following_url":"https://api.github.com/users/TheCyberBrick/following{/other_user}","gists_url":"https://api.github.com/users/TheCyberBrick/gists{/gist_id}","starred_url":"https://api.github.com/users/TheCyberBrick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheCyberBrick/subscriptions","organizations_url":"https://api.github.com/users/TheCyberBrick/orgs","repos_url":"https://api.github.com/users/TheCyberBrick/repos","events_url":"https://api.github.com/users/TheCyberBrick/events{/privacy}","received_events_url":"https://api.github.com/users/TheCyberBrick/received_events","type":"User","site_admin":false},"body":"This PR adds a getter for the world of the chunk that was un-/watched.\r\nThis is useful because when the player is teleported to another dimension with `PlayerList#transferPlayerToDimension` the player's world is set to the new dimension before the ChunkWatchEvent.UnWatch events are called. Because of that there's no way of actually knowing in which world the chunk was unwatched by just using the event.\r\nSpecifically mods that need to keep track of which players are watching which chunks need this.\r\nThe additional getter and comment should also make it clear that the player's world may not be the same as the world of the chunk that was unwatched.\r\n","created_at":"2018-03-17T20:01:18Z","updated_at":"2018-03-19T02:06:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"37d38b2872a67a14745af7fb568e3a4395cfe5c8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/4805/commits","review_comments_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/4805/comments","review_comment_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/4805/comments","statuses_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/statuses/3cb072b379df89dda48a8cd315f1d51c2a1ad14c","head":{"label":"TheCyberBrick:unwatch-event-dim","ref":"unwatch-event-dim","sha":"3cb072b379df89dda48a8cd315f1d51c2a1ad14c","user":{"login":"TheCyberBrick","id":2338519,"avatar_url":"https://avatars2.githubusercontent.com/u/2338519?v=4","gravatar_id":"","url":"https://api.github.com/users/TheCyberBrick","html_url":"https://github.com/TheCyberBrick","followers_url":"https://api.github.com/users/TheCyberBrick/followers","following_url":"https://api.github.com/users/TheCyberBrick/following{/other_user}","gists_url":"https://api.github.com/users/TheCyberBrick/gists{/gist_id}","starred_url":"https://api.github.com/users/TheCyberBrick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheCyberBrick/subscriptions","organizations_url":"https://api.github.com/users/TheCyberBrick/orgs","repos_url":"https://api.github.com/users/TheCyberBrick/repos","events_url":"https://api.github.com/users/TheCyberBrick/events{/privacy}","received_events_url":"https://api.github.com/users/TheCyberBrick/received_events","type":"User","site_admin":false},"repo":{"id":125651328,"name":"MinecraftForge","full_name":"TheCyberBrick/MinecraftForge","owner":{"login":"TheCyberBrick","id":2338519,"avatar_url":"https://avatars2.githubusercontent.com/u/2338519?v=4","gravatar_id":"","url":"https://api.github.com/users/TheCyberBrick","html_url":"https://github.com/TheCyberBrick","followers_url":"https://api.github.com/users/TheCyberBrick/followers","following_url":"https://api.github.com/users/TheCyberBrick/following{/other_user}","gists_url":"https://api.github.com/users/TheCyberBrick/gists{/gist_id}","starred_url":"https://api.github.com/users/TheCyberBrick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheCyberBrick/subscriptions","organizations_url":"https://api.github.com/users/TheCyberBrick/orgs","repos_url":"https://api.github.com/users/TheCyberBrick/repos","events_url":"https://api.github.com/users/TheCyberBrick/events{/privacy}","received_events_url":"https://api.github.com/users/TheCyberBrick/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TheCyberBrick/MinecraftForge","description":"Modifications to the Minecraft base files to assist in compatibility between mods.","fork":true,"url":"https://api.github.com/repos/TheCyberBrick/MinecraftForge","forks_url":"https://api.github.com/repos/TheCyberBrick/MinecraftForge/forks","keys_url":"https://api.github.com/repos/TheCyberBrick/MinecraftForge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TheCyberBrick/MinecraftForge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TheCyberBrick/MinecraftForge/teams","hooks_url":"https://api.github.com/repos/TheCyberBrick/MinecraftForge/hooks","issue_events_url":"https://api.github.com/repos/TheCyberBrick/MinecraftForge/issues/events{/number}","events_url":"https://api.github.com/repos/TheCyberBrick/MinecraftForge/events","assignees_url":"https://api.github.com/repos/TheCyberBrick/MinecraftForge/assignees{/user}","branches_url":"https://api.github.com/repos/TheCyberBrick/MinecraftForge/branches{/branch}","tags_url":"https://api.github.com/repos/TheCyberBrick/MinecraftForge/tags","blobs_url":"https://api.github.com/repos/TheCyberBrick/MinecraftForge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TheCyberBrick/MinecraftForge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TheCyberBrick/MinecraftForge/git/refs{/sha}","trees_url":"https://api.github.com/repos/TheCyberBrick/MinecraftForge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TheCyberBrick/MinecraftForge/statuses/{sha}","languages_url":"https://api.github.com/repos/TheCyberBrick/MinecraftForge/languages","stargazers_url":"https://api.github.com/repos/TheCyberBrick/MinecraftForge/stargazers","contributors_url":"https://api.github.com/repos/TheCyberBrick/MinecraftForge/contributors","subscribers_url":"https://api.github.com/repos/TheCyberBrick/MinecraftForge/subscribers","subscription_url":"https://api.github.com/repos/TheCyberBrick/MinecraftForge/subscription","commits_url":"https://api.github.com/repos/TheCyberBrick/MinecraftForge/commits{/sha}","git_commits_url":"https://api.github.com/repos/TheCyberBrick/MinecraftForge/git/commits{/sha}","comments_url":"https://api.github.com/repos/TheCyberBrick/MinecraftForge/comments{/number}","issue_comment_url":"https://api.github.com/repos/TheCyberBrick/MinecraftForge/issues/comments{/number}","contents_url":"https://api.github.com/repos/TheCyberBrick/MinecraftForge/contents/{+path}","compare_url":"https://api.github.com/repos/TheCyberBrick/MinecraftForge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TheCyberBrick/MinecraftForge/merges","archive_url":"https://api.github.com/repos/TheCyberBrick/MinecraftForge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TheCyberBrick/MinecraftForge/downloads","issues_url":"https://api.github.com/repos/TheCyberBrick/MinecraftForge/issues{/number}","pulls_url":"https://api.github.com/repos/TheCyberBrick/MinecraftForge/pulls{/number}","milestones_url":"https://api.github.com/repos/TheCyberBrick/MinecraftForge/milestones{/number}","notifications_url":"https://api.github.com/repos/TheCyberBrick/MinecraftForge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TheCyberBrick/MinecraftForge/labels{/name}","releases_url":"https://api.github.com/repos/TheCyberBrick/MinecraftForge/releases{/id}","deployments_url":"https://api.github.com/repos/TheCyberBrick/MinecraftForge/deployments","created_at":"2018-03-17T17:04:24Z","updated_at":"2018-03-17T17:04:30Z","pushed_at":"2018-03-17T22:32:15Z","git_url":"git://github.com/TheCyberBrick/MinecraftForge.git","ssh_url":"git@github.com:TheCyberBrick/MinecraftForge.git","clone_url":"https://github.com/TheCyberBrick/MinecraftForge.git","svn_url":"https://github.com/TheCyberBrick/MinecraftForge","homepage":"","size":91515,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"1.12.x"}},"base":{"label":"MinecraftForge:1.12.x","ref":"1.12.x","sha":"5ace86da121feafd20ed1f2d3e34ad99fee0599a","user":{"login":"MinecraftForge","id":1390178,"avatar_url":"https://avatars2.githubusercontent.com/u/1390178?v=4","gravatar_id":"","url":"https://api.github.com/users/MinecraftForge","html_url":"https://github.com/MinecraftForge","followers_url":"https://api.github.com/users/MinecraftForge/followers","following_url":"https://api.github.com/users/MinecraftForge/following{/other_user}","gists_url":"https://api.github.com/users/MinecraftForge/gists{/gist_id}","starred_url":"https://api.github.com/users/MinecraftForge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MinecraftForge/subscriptions","organizations_url":"https://api.github.com/users/MinecraftForge/orgs","repos_url":"https://api.github.com/users/MinecraftForge/repos","events_url":"https://api.github.com/users/MinecraftForge/events{/privacy}","received_events_url":"https://api.github.com/users/MinecraftForge/received_events","type":"Organization","site_admin":false},"repo":{"id":3301400,"name":"MinecraftForge","full_name":"MinecraftForge/MinecraftForge","owner":{"login":"MinecraftForge","id":1390178,"avatar_url":"https://avatars2.githubusercontent.com/u/1390178?v=4","gravatar_id":"","url":"https://api.github.com/users/MinecraftForge","html_url":"https://github.com/MinecraftForge","followers_url":"https://api.github.com/users/MinecraftForge/followers","following_url":"https://api.github.com/users/MinecraftForge/following{/other_user}","gists_url":"https://api.github.com/users/MinecraftForge/gists{/gist_id}","starred_url":"https://api.github.com/users/MinecraftForge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MinecraftForge/subscriptions","organizations_url":"https://api.github.com/users/MinecraftForge/orgs","repos_url":"https://api.github.com/users/MinecraftForge/repos","events_url":"https://api.github.com/users/MinecraftForge/events{/privacy}","received_events_url":"https://api.github.com/users/MinecraftForge/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MinecraftForge/MinecraftForge","description":"Modifications to the Minecraft base files to assist in compatibility between mods.","fork":false,"url":"https://api.github.com/repos/MinecraftForge/MinecraftForge","forks_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/forks","keys_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/teams","hooks_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/hooks","issue_events_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/events{/number}","events_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/events","assignees_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/assignees{/user}","branches_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/branches{/branch}","tags_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/tags","blobs_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/git/refs{/sha}","trees_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/statuses/{sha}","languages_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/languages","stargazers_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/stargazers","contributors_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/contributors","subscribers_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/subscribers","subscription_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/subscription","commits_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/commits{/sha}","git_commits_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/git/commits{/sha}","comments_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/comments{/number}","issue_comment_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/comments{/number}","contents_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/contents/{+path}","compare_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/merges","archive_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/downloads","issues_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues{/number}","pulls_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls{/number}","milestones_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/milestones{/number}","notifications_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/labels{/name}","releases_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/releases{/id}","deployments_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/deployments","created_at":"2012-01-30T01:35:01Z","updated_at":"2018-03-18T17:18:54Z","pushed_at":"2018-03-18T18:42:01Z","git_url":"git://github.com/MinecraftForge/MinecraftForge.git","ssh_url":"git@github.com:MinecraftForge/MinecraftForge.git","clone_url":"https://github.com/MinecraftForge/MinecraftForge.git","svn_url":"https://github.com/MinecraftForge/MinecraftForge","homepage":"","size":91519,"stargazers_count":2203,"watchers_count":2203,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1080,"mirror_url":null,"archived":false,"open_issues_count":206,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1080,"open_issues":206,"watchers":2203,"default_branch":"1.12.x"}},"_links":{"self":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/4805"},"html":{"href":"https://github.com/MinecraftForge/MinecraftForge/pull/4805"},"issue":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/4805"},"comments":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/4805/comments"},"review_comments":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/4805/comments"},"review_comment":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/pulls/4805/commits"},"statuses":{"href":"https://api.github.com/repos/MinecraftForge/MinecraftForge/statuses/3cb072b379df89dda48a8cd315f1d51c2a1ad14c"}},"author_association":"NONE"}}
{"actor":{"display_login":"mezz"}}