{"action":"created","comment":{"url":"https://api.github.com/repos/OpenMW/openmw/pulls/comments/182352960","pull_request_review_id":113129007,"id":182352960,"diff_hunk":"@@ -0,0 +1,137 @@\n+#ifndef CSV_RENDER_TERRAINTEXTUREMODE_H\n+#define CSV_RENDER_TERRAINTEXTUREMODE_H\n+\n+#include \"editmode.hpp\"\n+\n+#include <string>\n+\n+#include <QWidget>\n+#include <QLabel>\n+#include <QSpinBox>\n+#include <QGroupBox>\n+#include <QSlider>\n+#include <QIcon>\n+#include <QFrame>\n+#include <QEvent>\n+#include <QHBoxLayout>\n+#include <QPushButton>\n+\n+#include \"../../model/world/data.hpp\"\n+#include \"../../model/world/land.hpp\"\n+\n+namespace CSVWidget\n+{\n+    class SceneToolMode;\n+}\n+\n+namespace CSVRender\n+{\n+    class BrushSizeControls : public QGroupBox\n+    {\n+        Q_OBJECT\n+\n+        public:\n+            BrushSizeControls(const QString &title, QWidget *parent);\n+            QSlider *brushSizeSlider;\n+\n+        private:\n+            QSpinBox *brushSizeSpinBox;\n+            QHBoxLayout *layoutSliderSize;\n+    };\n+\n+    class TextureBrushButton : public QPushButton\n+    {\n+        Q_OBJECT\n+\n+        public:\n+            TextureBrushButton (const QIcon& icon, const QString& tooltip = \"\",\n+                QWidget *parent = 0);\n+    };\n+\n+    class TextureBrushWindow : public QFrame\n+    {\n+        Q_OBJECT\n+\n+        public:\n+            TextureBrushWindow(WorldspaceWidget *worldspaceWidget, QWidget *parent = 0);\n+            void configureButtonInitialSettings(TextureBrushButton *button);\n+\n+            TextureBrushButton *buttonPoint = new TextureBrushButton(QIcon (QPixmap (\":scenetoolbar/brush-point\")), \"\", this);\n+            TextureBrushButton *buttonSquare = new TextureBrushButton(QIcon (QPixmap (\":scenetoolbar/brush-square\")), \"\", this);\n+            TextureBrushButton *buttonCircle = new TextureBrushButton(QIcon (QPixmap (\":scenetoolbar/brush-circle\")), \"\", this);\n+            TextureBrushButton *buttonCustom = new TextureBrushButton(QIcon (QPixmap (\":scenetoolbar/brush-custom\")), \"\", this);\n+\n+        private:\n+            QLabel *selectedBrush;\n+            QGroupBox *horizontalGroupBox;\n+            int mButtonSize;\n+            int mBrushSize = 0;","path":"apps/opencs/view/render/terraintexturemode.hpp","position":68,"original_position":68,"commit_id":"720a21cfc37f0c5f7e11c9f82acfa30d9aab38da","original_commit_id":"720a21cfc37f0c5f7e11c9f82acfa30d9aab38da","user":{"login":"zinnschlag","id":287696,"avatar_url":"https://avatars1.githubusercontent.com/u/287696?v=4","gravatar_id":"","url":"https://api.github.com/users/zinnschlag","html_url":"https://github.com/zinnschlag","followers_url":"https://api.github.com/users/zinnschlag/followers","following_url":"https://api.github.com/users/zinnschlag/following{/other_user}","gists_url":"https://api.github.com/users/zinnschlag/gists{/gist_id}","starred_url":"https://api.github.com/users/zinnschlag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zinnschlag/subscriptions","organizations_url":"https://api.github.com/users/zinnschlag/orgs","repos_url":"https://api.github.com/users/zinnschlag/repos","events_url":"https://api.github.com/users/zinnschlag/events{/privacy}","received_events_url":"https://api.github.com/users/zinnschlag/received_events","type":"User","site_admin":false},"body":"Its not a good idea to initialise variables here if you also have a constructor, because that separates the initialisation into two different parts of the code (two different files actually) which makes it harder to verify that everything got initialised correctly.","created_at":"2018-04-18T08:50:09Z","updated_at":"2018-04-18T08:50:10Z","html_url":"https://github.com/OpenMW/openmw/pull/1680#discussion_r182352960","pull_request_url":"https://api.github.com/repos/OpenMW/openmw/pulls/1680","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/OpenMW/openmw/pulls/comments/182352960"},"html":{"href":"https://github.com/OpenMW/openmw/pull/1680#discussion_r182352960"},"pull_request":{"href":"https://api.github.com/repos/OpenMW/openmw/pulls/1680"}}},"pull_request":{"url":"https://api.github.com/repos/OpenMW/openmw/pulls/1680","id":181705883,"html_url":"https://github.com/OpenMW/openmw/pull/1680","diff_url":"https://github.com/OpenMW/openmw/pull/1680.diff","patch_url":"https://github.com/OpenMW/openmw/pull/1680.patch","issue_url":"https://api.github.com/repos/OpenMW/openmw/issues/1680","number":1680,"state":"open","locked":false,"title":"[Feedback needed] Terraintexture primary edit","user":{"login":"unelsson","id":1066066,"avatar_url":"https://avatars3.githubusercontent.com/u/1066066?v=4","gravatar_id":"","url":"https://api.github.com/users/unelsson","html_url":"https://github.com/unelsson","followers_url":"https://api.github.com/users/unelsson/followers","following_url":"https://api.github.com/users/unelsson/following{/other_user}","gists_url":"https://api.github.com/users/unelsson/gists{/gist_id}","starred_url":"https://api.github.com/users/unelsson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unelsson/subscriptions","organizations_url":"https://api.github.com/users/unelsson/orgs","repos_url":"https://api.github.com/users/unelsson/repos","events_url":"https://api.github.com/users/unelsson/events{/privacy}","received_events_url":"https://api.github.com/users/unelsson/received_events","type":"User","site_admin":false},"body":"Roughly alter terrain data with mouse clicking. Early PR to get some feedback.\r\n\r\nBased on https://github.com/OpenMW/openmw/pull/1679\r\nhttps://youtu.be/caN1x3Mdy7Y?t=23s","created_at":"2018-04-15T15:52:55Z","updated_at":"2018-04-18T08:50:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6eb8b0f93173583579d65186ee27f46a05792b2c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/OpenMW/openmw/pulls/1680/commits","review_comments_url":"https://api.github.com/repos/OpenMW/openmw/pulls/1680/comments","review_comment_url":"https://api.github.com/repos/OpenMW/openmw/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenMW/openmw/issues/1680/comments","statuses_url":"https://api.github.com/repos/OpenMW/openmw/statuses/720a21cfc37f0c5f7e11c9f82acfa30d9aab38da","head":{"label":"unelsson:terraintexturemode_primaryedit","ref":"terraintexturemode_primaryedit","sha":"720a21cfc37f0c5f7e11c9f82acfa30d9aab38da","user":{"login":"unelsson","id":1066066,"avatar_url":"https://avatars3.githubusercontent.com/u/1066066?v=4","gravatar_id":"","url":"https://api.github.com/users/unelsson","html_url":"https://github.com/unelsson","followers_url":"https://api.github.com/users/unelsson/followers","following_url":"https://api.github.com/users/unelsson/following{/other_user}","gists_url":"https://api.github.com/users/unelsson/gists{/gist_id}","starred_url":"https://api.github.com/users/unelsson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unelsson/subscriptions","organizations_url":"https://api.github.com/users/unelsson/orgs","repos_url":"https://api.github.com/users/unelsson/repos","events_url":"https://api.github.com/users/unelsson/events{/privacy}","received_events_url":"https://api.github.com/users/unelsson/received_events","type":"User","site_admin":false},"repo":{"id":126310102,"name":"openmw","full_name":"unelsson/openmw","owner":{"login":"unelsson","id":1066066,"avatar_url":"https://avatars3.githubusercontent.com/u/1066066?v=4","gravatar_id":"","url":"https://api.github.com/users/unelsson","html_url":"https://github.com/unelsson","followers_url":"https://api.github.com/users/unelsson/followers","following_url":"https://api.github.com/users/unelsson/following{/other_user}","gists_url":"https://api.github.com/users/unelsson/gists{/gist_id}","starred_url":"https://api.github.com/users/unelsson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unelsson/subscriptions","organizations_url":"https://api.github.com/users/unelsson/orgs","repos_url":"https://api.github.com/users/unelsson/repos","events_url":"https://api.github.com/users/unelsson/events{/privacy}","received_events_url":"https://api.github.com/users/unelsson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/unelsson/openmw","description":"OpenMW is an unofficial open source engine reimplementation of the game Morrowind.","fork":true,"url":"https://api.github.com/repos/unelsson/openmw","forks_url":"https://api.github.com/repos/unelsson/openmw/forks","keys_url":"https://api.github.com/repos/unelsson/openmw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/unelsson/openmw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/unelsson/openmw/teams","hooks_url":"https://api.github.com/repos/unelsson/openmw/hooks","issue_events_url":"https://api.github.com/repos/unelsson/openmw/issues/events{/number}","events_url":"https://api.github.com/repos/unelsson/openmw/events","assignees_url":"https://api.github.com/repos/unelsson/openmw/assignees{/user}","branches_url":"https://api.github.com/repos/unelsson/openmw/branches{/branch}","tags_url":"https://api.github.com/repos/unelsson/openmw/tags","blobs_url":"https://api.github.com/repos/unelsson/openmw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/unelsson/openmw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/unelsson/openmw/git/refs{/sha}","trees_url":"https://api.github.com/repos/unelsson/openmw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/unelsson/openmw/statuses/{sha}","languages_url":"https://api.github.com/repos/unelsson/openmw/languages","stargazers_url":"https://api.github.com/repos/unelsson/openmw/stargazers","contributors_url":"https://api.github.com/repos/unelsson/openmw/contributors","subscribers_url":"https://api.github.com/repos/unelsson/openmw/subscribers","subscription_url":"https://api.github.com/repos/unelsson/openmw/subscription","commits_url":"https://api.github.com/repos/unelsson/openmw/commits{/sha}","git_commits_url":"https://api.github.com/repos/unelsson/openmw/git/commits{/sha}","comments_url":"https://api.github.com/repos/unelsson/openmw/comments{/number}","issue_comment_url":"https://api.github.com/repos/unelsson/openmw/issues/comments{/number}","contents_url":"https://api.github.com/repos/unelsson/openmw/contents/{+path}","compare_url":"https://api.github.com/repos/unelsson/openmw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/unelsson/openmw/merges","archive_url":"https://api.github.com/repos/unelsson/openmw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/unelsson/openmw/downloads","issues_url":"https://api.github.com/repos/unelsson/openmw/issues{/number}","pulls_url":"https://api.github.com/repos/unelsson/openmw/pulls{/number}","milestones_url":"https://api.github.com/repos/unelsson/openmw/milestones{/number}","notifications_url":"https://api.github.com/repos/unelsson/openmw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/unelsson/openmw/labels{/name}","releases_url":"https://api.github.com/repos/unelsson/openmw/releases{/id}","deployments_url":"https://api.github.com/repos/unelsson/openmw/deployments","created_at":"2018-03-22T09:20:08Z","updated_at":"2018-04-15T07:30:21Z","pushed_at":"2018-04-17T18:35:00Z","git_url":"git://github.com/unelsson/openmw.git","ssh_url":"git@github.com:unelsson/openmw.git","clone_url":"https://github.com/unelsson/openmw.git","svn_url":"https://github.com/unelsson/openmw","homepage":"http://www.openmw.org/","size":50805,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OpenMW:master","ref":"master","sha":"fc72483ddfe1872d4c9450950d03e99beee245e0","user":{"login":"OpenMW","id":6727417,"avatar_url":"https://avatars0.githubusercontent.com/u/6727417?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenMW","html_url":"https://github.com/OpenMW","followers_url":"https://api.github.com/users/OpenMW/followers","following_url":"https://api.github.com/users/OpenMW/following{/other_user}","gists_url":"https://api.github.com/users/OpenMW/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenMW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenMW/subscriptions","organizations_url":"https://api.github.com/users/OpenMW/orgs","repos_url":"https://api.github.com/users/OpenMW/repos","events_url":"https://api.github.com/users/OpenMW/events{/privacy}","received_events_url":"https://api.github.com/users/OpenMW/received_events","type":"Organization","site_admin":false},"repo":{"id":285722,"name":"openmw","full_name":"OpenMW/openmw","owner":{"login":"OpenMW","id":6727417,"avatar_url":"https://avatars0.githubusercontent.com/u/6727417?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenMW","html_url":"https://github.com/OpenMW","followers_url":"https://api.github.com/users/OpenMW/followers","following_url":"https://api.github.com/users/OpenMW/following{/other_user}","gists_url":"https://api.github.com/users/OpenMW/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenMW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenMW/subscriptions","organizations_url":"https://api.github.com/users/OpenMW/orgs","repos_url":"https://api.github.com/users/OpenMW/repos","events_url":"https://api.github.com/users/OpenMW/events{/privacy}","received_events_url":"https://api.github.com/users/OpenMW/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenMW/openmw","description":"OpenMW is an unofficial open source engine reimplementation of the game Morrowind.","fork":false,"url":"https://api.github.com/repos/OpenMW/openmw","forks_url":"https://api.github.com/repos/OpenMW/openmw/forks","keys_url":"https://api.github.com/repos/OpenMW/openmw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenMW/openmw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenMW/openmw/teams","hooks_url":"https://api.github.com/repos/OpenMW/openmw/hooks","issue_events_url":"https://api.github.com/repos/OpenMW/openmw/issues/events{/number}","events_url":"https://api.github.com/repos/OpenMW/openmw/events","assignees_url":"https://api.github.com/repos/OpenMW/openmw/assignees{/user}","branches_url":"https://api.github.com/repos/OpenMW/openmw/branches{/branch}","tags_url":"https://api.github.com/repos/OpenMW/openmw/tags","blobs_url":"https://api.github.com/repos/OpenMW/openmw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenMW/openmw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenMW/openmw/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenMW/openmw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenMW/openmw/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenMW/openmw/languages","stargazers_url":"https://api.github.com/repos/OpenMW/openmw/stargazers","contributors_url":"https://api.github.com/repos/OpenMW/openmw/contributors","subscribers_url":"https://api.github.com/repos/OpenMW/openmw/subscribers","subscription_url":"https://api.github.com/repos/OpenMW/openmw/subscription","commits_url":"https://api.github.com/repos/OpenMW/openmw/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenMW/openmw/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenMW/openmw/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenMW/openmw/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenMW/openmw/contents/{+path}","compare_url":"https://api.github.com/repos/OpenMW/openmw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenMW/openmw/merges","archive_url":"https://api.github.com/repos/OpenMW/openmw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenMW/openmw/downloads","issues_url":"https://api.github.com/repos/OpenMW/openmw/issues{/number}","pulls_url":"https://api.github.com/repos/OpenMW/openmw/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenMW/openmw/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenMW/openmw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenMW/openmw/labels{/name}","releases_url":"https://api.github.com/repos/OpenMW/openmw/releases{/id}","deployments_url":"https://api.github.com/repos/OpenMW/openmw/deployments","created_at":"2009-08-23T14:46:21Z","updated_at":"2018-04-18T02:49:49Z","pushed_at":"2018-04-17T21:13:14Z","git_url":"git://github.com/OpenMW/openmw.git","ssh_url":"git@github.com:OpenMW/openmw.git","clone_url":"https://github.com/OpenMW/openmw.git","svn_url":"https://github.com/OpenMW/openmw","homepage":"http://www.openmw.org/","size":50604,"stargazers_count":2109,"watchers_count":2109,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":639,"mirror_url":null,"archived":false,"open_issues_count":46,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":639,"open_issues":46,"watchers":2109,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenMW/openmw/pulls/1680"},"html":{"href":"https://github.com/OpenMW/openmw/pull/1680"},"issue":{"href":"https://api.github.com/repos/OpenMW/openmw/issues/1680"},"comments":{"href":"https://api.github.com/repos/OpenMW/openmw/issues/1680/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenMW/openmw/pulls/1680/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenMW/openmw/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenMW/openmw/pulls/1680/commits"},"statuses":{"href":"https://api.github.com/repos/OpenMW/openmw/statuses/720a21cfc37f0c5f7e11c9f82acfa30d9aab38da"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"zinnschlag"}}