{"action":"opened","number":1229,"pull_request":{"url":"https://api.github.com/repos/TextureGroup/Texture/pulls/1229","id":229904632,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5OTA0NjMy","html_url":"https://github.com/TextureGroup/Texture/pull/1229","diff_url":"https://github.com/TextureGroup/Texture/pull/1229.diff","patch_url":"https://github.com/TextureGroup/Texture/pull/1229.patch","issue_url":"https://api.github.com/repos/TextureGroup/Texture/issues/1229","number":1229,"state":"open","locked":false,"title":"Add extension points for global node behaviors, potentially replacing node controller","user":{"login":"Adlai-Holler","id":2466893,"node_id":"MDQ6VXNlcjI0NjY4OTM=","avatar_url":"https://avatars2.githubusercontent.com/u/2466893?v=4","gravatar_id":"","url":"https://api.github.com/users/Adlai-Holler","html_url":"https://github.com/Adlai-Holler","followers_url":"https://api.github.com/users/Adlai-Holler/followers","following_url":"https://api.github.com/users/Adlai-Holler/following{/other_user}","gists_url":"https://api.github.com/users/Adlai-Holler/gists{/gist_id}","starred_url":"https://api.github.com/users/Adlai-Holler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Adlai-Holler/subscriptions","organizations_url":"https://api.github.com/users/Adlai-Holler/orgs","repos_url":"https://api.github.com/users/Adlai-Holler/repos","events_url":"https://api.github.com/users/Adlai-Holler/events{/privacy}","received_events_url":"https://api.github.com/users/Adlai-Holler/received_events","type":"User","site_admin":false},"body":"Node controllers were added as a way for clients to customize node behavior globally. If you subclass ASTextNode and ASImageNode, you have to duplicate any common logic you want to add.\r\n\r\nNode controllers however introduce additional complexity and duplication – if ASNetworkImageNode can fire off network requests, why does it need a controller? Nodes are in fact a sort of tiny view controller and we should stick with the original abstraction instead of adding a different one in.\r\n\r\nThis diff does something pretty strange, but I think useful. It modifies the node API to (1) offer a public ivar to ASDisplayNode and (2) guarantee that certain `ASDisplayNode+Subclass` category methods e.g. interface state methods are not implemented by the base class, and thus can be overridden safely in categories. To make it safe, we put in empty stubs for methods that they don't choose to implement.\r\n\r\nI modified CatDealsCollectionView to demonstrate how this extension point could be used to add visibility logging events at the application level. \r\n\r\nI propose that this API *informally deprecates* the Beta `ASNodeController` and the `interfaceStateDelegates` APIs. Those systems will be removed.","created_at":"2018-11-10T18:12:58Z","updated_at":"2018-11-10T18:12:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/TextureGroup/Texture/pulls/1229/commits","review_comments_url":"https://api.github.com/repos/TextureGroup/Texture/pulls/1229/comments","review_comment_url":"https://api.github.com/repos/TextureGroup/Texture/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TextureGroup/Texture/issues/1229/comments","statuses_url":"https://api.github.com/repos/TextureGroup/Texture/statuses/6135e24e64d760c25085c2b149e63f0dccae36af","head":{"label":"TextureGroup:AHGlobalExtensions","ref":"AHGlobalExtensions","sha":"6135e24e64d760c25085c2b149e63f0dccae36af","user":{"login":"TextureGroup","id":25676156,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1Njc2MTU2","avatar_url":"https://avatars3.githubusercontent.com/u/25676156?v=4","gravatar_id":"","url":"https://api.github.com/users/TextureGroup","html_url":"https://github.com/TextureGroup","followers_url":"https://api.github.com/users/TextureGroup/followers","following_url":"https://api.github.com/users/TextureGroup/following{/other_user}","gists_url":"https://api.github.com/users/TextureGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/TextureGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TextureGroup/subscriptions","organizations_url":"https://api.github.com/users/TextureGroup/orgs","repos_url":"https://api.github.com/users/TextureGroup/repos","events_url":"https://api.github.com/users/TextureGroup/events{/privacy}","received_events_url":"https://api.github.com/users/TextureGroup/received_events","type":"Organization","site_admin":false},"repo":{"id":81514066,"node_id":"MDEwOlJlcG9zaXRvcnk4MTUxNDA2Ng==","name":"Texture","full_name":"TextureGroup/Texture","private":false,"owner":{"login":"TextureGroup","id":25676156,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1Njc2MTU2","avatar_url":"https://avatars3.githubusercontent.com/u/25676156?v=4","gravatar_id":"","url":"https://api.github.com/users/TextureGroup","html_url":"https://github.com/TextureGroup","followers_url":"https://api.github.com/users/TextureGroup/followers","following_url":"https://api.github.com/users/TextureGroup/following{/other_user}","gists_url":"https://api.github.com/users/TextureGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/TextureGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TextureGroup/subscriptions","organizations_url":"https://api.github.com/users/TextureGroup/orgs","repos_url":"https://api.github.com/users/TextureGroup/repos","events_url":"https://api.github.com/users/TextureGroup/events{/privacy}","received_events_url":"https://api.github.com/users/TextureGroup/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/TextureGroup/Texture","description":"Smooth asynchronous user interfaces for iOS apps.","fork":false,"url":"https://api.github.com/repos/TextureGroup/Texture","forks_url":"https://api.github.com/repos/TextureGroup/Texture/forks","keys_url":"https://api.github.com/repos/TextureGroup/Texture/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TextureGroup/Texture/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TextureGroup/Texture/teams","hooks_url":"https://api.github.com/repos/TextureGroup/Texture/hooks","issue_events_url":"https://api.github.com/repos/TextureGroup/Texture/issues/events{/number}","events_url":"https://api.github.com/repos/TextureGroup/Texture/events","assignees_url":"https://api.github.com/repos/TextureGroup/Texture/assignees{/user}","branches_url":"https://api.github.com/repos/TextureGroup/Texture/branches{/branch}","tags_url":"https://api.github.com/repos/TextureGroup/Texture/tags","blobs_url":"https://api.github.com/repos/TextureGroup/Texture/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TextureGroup/Texture/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TextureGroup/Texture/git/refs{/sha}","trees_url":"https://api.github.com/repos/TextureGroup/Texture/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TextureGroup/Texture/statuses/{sha}","languages_url":"https://api.github.com/repos/TextureGroup/Texture/languages","stargazers_url":"https://api.github.com/repos/TextureGroup/Texture/stargazers","contributors_url":"https://api.github.com/repos/TextureGroup/Texture/contributors","subscribers_url":"https://api.github.com/repos/TextureGroup/Texture/subscribers","subscription_url":"https://api.github.com/repos/TextureGroup/Texture/subscription","commits_url":"https://api.github.com/repos/TextureGroup/Texture/commits{/sha}","git_commits_url":"https://api.github.com/repos/TextureGroup/Texture/git/commits{/sha}","comments_url":"https://api.github.com/repos/TextureGroup/Texture/comments{/number}","issue_comment_url":"https://api.github.com/repos/TextureGroup/Texture/issues/comments{/number}","contents_url":"https://api.github.com/repos/TextureGroup/Texture/contents/{+path}","compare_url":"https://api.github.com/repos/TextureGroup/Texture/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TextureGroup/Texture/merges","archive_url":"https://api.github.com/repos/TextureGroup/Texture/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TextureGroup/Texture/downloads","issues_url":"https://api.github.com/repos/TextureGroup/Texture/issues{/number}","pulls_url":"https://api.github.com/repos/TextureGroup/Texture/pulls{/number}","milestones_url":"https://api.github.com/repos/TextureGroup/Texture/milestones{/number}","notifications_url":"https://api.github.com/repos/TextureGroup/Texture/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TextureGroup/Texture/labels{/name}","releases_url":"https://api.github.com/repos/TextureGroup/Texture/releases{/id}","deployments_url":"https://api.github.com/repos/TextureGroup/Texture/deployments","created_at":"2017-02-10T01:44:38Z","updated_at":"2018-11-10T16:42:05Z","pushed_at":"2018-11-10T18:05:55Z","git_url":"git://github.com/TextureGroup/Texture.git","ssh_url":"git@github.com:TextureGroup/Texture.git","clone_url":"https://github.com/TextureGroup/Texture.git","svn_url":"https://github.com/TextureGroup/Texture","homepage":"http://texturegroup.org","size":125453,"stargazers_count":4738,"watchers_count":4738,"language":"Objective-C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":609,"mirror_url":null,"archived":false,"open_issues_count":355,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":609,"open_issues":355,"watchers":4738,"default_branch":"master"}},"base":{"label":"TextureGroup:master","ref":"master","sha":"fd047d681eb4867081a61df9a444309ed91cf56d","user":{"login":"TextureGroup","id":25676156,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1Njc2MTU2","avatar_url":"https://avatars3.githubusercontent.com/u/25676156?v=4","gravatar_id":"","url":"https://api.github.com/users/TextureGroup","html_url":"https://github.com/TextureGroup","followers_url":"https://api.github.com/users/TextureGroup/followers","following_url":"https://api.github.com/users/TextureGroup/following{/other_user}","gists_url":"https://api.github.com/users/TextureGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/TextureGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TextureGroup/subscriptions","organizations_url":"https://api.github.com/users/TextureGroup/orgs","repos_url":"https://api.github.com/users/TextureGroup/repos","events_url":"https://api.github.com/users/TextureGroup/events{/privacy}","received_events_url":"https://api.github.com/users/TextureGroup/received_events","type":"Organization","site_admin":false},"repo":{"id":81514066,"node_id":"MDEwOlJlcG9zaXRvcnk4MTUxNDA2Ng==","name":"Texture","full_name":"TextureGroup/Texture","private":false,"owner":{"login":"TextureGroup","id":25676156,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1Njc2MTU2","avatar_url":"https://avatars3.githubusercontent.com/u/25676156?v=4","gravatar_id":"","url":"https://api.github.com/users/TextureGroup","html_url":"https://github.com/TextureGroup","followers_url":"https://api.github.com/users/TextureGroup/followers","following_url":"https://api.github.com/users/TextureGroup/following{/other_user}","gists_url":"https://api.github.com/users/TextureGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/TextureGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TextureGroup/subscriptions","organizations_url":"https://api.github.com/users/TextureGroup/orgs","repos_url":"https://api.github.com/users/TextureGroup/repos","events_url":"https://api.github.com/users/TextureGroup/events{/privacy}","received_events_url":"https://api.github.com/users/TextureGroup/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/TextureGroup/Texture","description":"Smooth asynchronous user interfaces for iOS apps.","fork":false,"url":"https://api.github.com/repos/TextureGroup/Texture","forks_url":"https://api.github.com/repos/TextureGroup/Texture/forks","keys_url":"https://api.github.com/repos/TextureGroup/Texture/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TextureGroup/Texture/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TextureGroup/Texture/teams","hooks_url":"https://api.github.com/repos/TextureGroup/Texture/hooks","issue_events_url":"https://api.github.com/repos/TextureGroup/Texture/issues/events{/number}","events_url":"https://api.github.com/repos/TextureGroup/Texture/events","assignees_url":"https://api.github.com/repos/TextureGroup/Texture/assignees{/user}","branches_url":"https://api.github.com/repos/TextureGroup/Texture/branches{/branch}","tags_url":"https://api.github.com/repos/TextureGroup/Texture/tags","blobs_url":"https://api.github.com/repos/TextureGroup/Texture/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TextureGroup/Texture/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TextureGroup/Texture/git/refs{/sha}","trees_url":"https://api.github.com/repos/TextureGroup/Texture/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TextureGroup/Texture/statuses/{sha}","languages_url":"https://api.github.com/repos/TextureGroup/Texture/languages","stargazers_url":"https://api.github.com/repos/TextureGroup/Texture/stargazers","contributors_url":"https://api.github.com/repos/TextureGroup/Texture/contributors","subscribers_url":"https://api.github.com/repos/TextureGroup/Texture/subscribers","subscription_url":"https://api.github.com/repos/TextureGroup/Texture/subscription","commits_url":"https://api.github.com/repos/TextureGroup/Texture/commits{/sha}","git_commits_url":"https://api.github.com/repos/TextureGroup/Texture/git/commits{/sha}","comments_url":"https://api.github.com/repos/TextureGroup/Texture/comments{/number}","issue_comment_url":"https://api.github.com/repos/TextureGroup/Texture/issues/comments{/number}","contents_url":"https://api.github.com/repos/TextureGroup/Texture/contents/{+path}","compare_url":"https://api.github.com/repos/TextureGroup/Texture/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TextureGroup/Texture/merges","archive_url":"https://api.github.com/repos/TextureGroup/Texture/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TextureGroup/Texture/downloads","issues_url":"https://api.github.com/repos/TextureGroup/Texture/issues{/number}","pulls_url":"https://api.github.com/repos/TextureGroup/Texture/pulls{/number}","milestones_url":"https://api.github.com/repos/TextureGroup/Texture/milestones{/number}","notifications_url":"https://api.github.com/repos/TextureGroup/Texture/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TextureGroup/Texture/labels{/name}","releases_url":"https://api.github.com/repos/TextureGroup/Texture/releases{/id}","deployments_url":"https://api.github.com/repos/TextureGroup/Texture/deployments","created_at":"2017-02-10T01:44:38Z","updated_at":"2018-11-10T16:42:05Z","pushed_at":"2018-11-10T18:05:55Z","git_url":"git://github.com/TextureGroup/Texture.git","ssh_url":"git@github.com:TextureGroup/Texture.git","clone_url":"https://github.com/TextureGroup/Texture.git","svn_url":"https://github.com/TextureGroup/Texture","homepage":"http://texturegroup.org","size":125453,"stargazers_count":4738,"watchers_count":4738,"language":"Objective-C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":609,"mirror_url":null,"archived":false,"open_issues_count":355,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":609,"open_issues":355,"watchers":4738,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TextureGroup/Texture/pulls/1229"},"html":{"href":"https://github.com/TextureGroup/Texture/pull/1229"},"issue":{"href":"https://api.github.com/repos/TextureGroup/Texture/issues/1229"},"comments":{"href":"https://api.github.com/repos/TextureGroup/Texture/issues/1229/comments"},"review_comments":{"href":"https://api.github.com/repos/TextureGroup/Texture/pulls/1229/comments"},"review_comment":{"href":"https://api.github.com/repos/TextureGroup/Texture/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TextureGroup/Texture/pulls/1229/commits"},"statuses":{"href":"https://api.github.com/repos/TextureGroup/Texture/statuses/6135e24e64d760c25085c2b149e63f0dccae36af"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":184,"deletions":25,"changed_files":9}}
{"actor":{"display_login":"Adlai-Holler"}}