{"action":"created","comment":{"url":"https://api.github.com/repos/Metaswitch/sprout/pulls/comments/173415776","pull_request_review_id":102604155,"id":173415776,"diff_hunk":"@@ -302,7 +302,8 @@ class SproutletProxy : public BasicProxy, SproutletHelper\n     virtual void on_tsx_state(pjsip_event* event);\n \n     // A count of the number of pending Callbacks that are queued for this\n-    // UASTsx. A non-zero count prevents the UASTsx from being destroyed\n+    // UASTsx plus the number of outstanding PJSIP timers.","path":"include/sproutletproxy.h","position":5,"original_position":5,"commit_id":"9bcc47a42cdba08768ef76224a0f69d178bd8bfb","original_commit_id":"9bcc47a42cdba08768ef76224a0f69d178bd8bfb","user":{"login":"steelyvoid","id":8615257,"avatar_url":"https://avatars0.githubusercontent.com/u/8615257?v=4","gravatar_id":"","url":"https://api.github.com/users/steelyvoid","html_url":"https://github.com/steelyvoid","followers_url":"https://api.github.com/users/steelyvoid/followers","following_url":"https://api.github.com/users/steelyvoid/following{/other_user}","gists_url":"https://api.github.com/users/steelyvoid/gists{/gist_id}","starred_url":"https://api.github.com/users/steelyvoid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steelyvoid/subscriptions","organizations_url":"https://api.github.com/users/steelyvoid/orgs","repos_url":"https://api.github.com/users/steelyvoid/repos","events_url":"https://api.github.com/users/steelyvoid/events{/privacy}","received_events_url":"https://api.github.com/users/steelyvoid/received_events","type":"User","site_admin":false},"body":"Agreed - thanks","created_at":"2018-03-09T10:33:20Z","updated_at":"2018-03-09T10:33:20Z","html_url":"https://github.com/Metaswitch/sprout/pull/2167#discussion_r173415776","pull_request_url":"https://api.github.com/repos/Metaswitch/sprout/pulls/2167","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Metaswitch/sprout/pulls/comments/173415776"},"html":{"href":"https://github.com/Metaswitch/sprout/pull/2167#discussion_r173415776"},"pull_request":{"href":"https://api.github.com/repos/Metaswitch/sprout/pulls/2167"}},"in_reply_to_id":173273934},"pull_request":{"url":"https://api.github.com/repos/Metaswitch/sprout/pulls/2167","id":171094323,"html_url":"https://github.com/Metaswitch/sprout/pull/2167","diff_url":"https://github.com/Metaswitch/sprout/pull/2167.diff","patch_url":"https://github.com/Metaswitch/sprout/pull/2167.patch","issue_url":"https://api.github.com/repos/Metaswitch/sprout/issues/2167","number":2167,"state":"open","locked":false,"title":"[Reviewer RJW2] Ensure PJSIP timers that are cancelled after they've popped do not make it into the sproutlets","user":{"login":"steelyvoid","id":8615257,"avatar_url":"https://avatars0.githubusercontent.com/u/8615257?v=4","gravatar_id":"","url":"https://api.github.com/users/steelyvoid","html_url":"https://github.com/steelyvoid","followers_url":"https://api.github.com/users/steelyvoid/followers","following_url":"https://api.github.com/users/steelyvoid/following{/other_user}","gists_url":"https://api.github.com/users/steelyvoid/gists{/gist_id}","starred_url":"https://api.github.com/users/steelyvoid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steelyvoid/subscriptions","organizations_url":"https://api.github.com/users/steelyvoid/orgs","repos_url":"https://api.github.com/users/steelyvoid/repos","events_url":"https://api.github.com/users/steelyvoid/events{/privacy}","received_events_url":"https://api.github.com/users/steelyvoid/received_events","type":"User","site_admin":false},"body":"Hi Richard\r\n\r\nAre you OK to review this two-pronged timer cancel fix?  \r\n\r\nNo UTs, but I managed to test first the timer handling code in scscfsproutlet with this \"slow DNS\" repro scenario (which stopped the crash, but a random leg got CANCELled and the call failed) and then the \"cancel timer even if popped\" code in sproutletproxy with the same slow repro (this time the call completed fine, with the slow timer being properly cancelled) altogether.\r\n\r\nI haven't been able to come up with a repro scenario for the \"extra response\" case in scscfsproutlet, but I'm going to claim that the backstop code is good by inspection (and \"make full_test\" passes).\r\n\r\nI'll reference the associated SAS resource bundle fix shortly","created_at":"2018-02-23T19:17:37Z","updated_at":"2018-03-09T10:33:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bdecb8fe16a4720abd3da7076acaec790a392074","assignee":{"login":"steelyvoid","id":8615257,"avatar_url":"https://avatars0.githubusercontent.com/u/8615257?v=4","gravatar_id":"","url":"https://api.github.com/users/steelyvoid","html_url":"https://github.com/steelyvoid","followers_url":"https://api.github.com/users/steelyvoid/followers","following_url":"https://api.github.com/users/steelyvoid/following{/other_user}","gists_url":"https://api.github.com/users/steelyvoid/gists{/gist_id}","starred_url":"https://api.github.com/users/steelyvoid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steelyvoid/subscriptions","organizations_url":"https://api.github.com/users/steelyvoid/orgs","repos_url":"https://api.github.com/users/steelyvoid/repos","events_url":"https://api.github.com/users/steelyvoid/events{/privacy}","received_events_url":"https://api.github.com/users/steelyvoid/received_events","type":"User","site_admin":false},"assignees":[{"login":"steelyvoid","id":8615257,"avatar_url":"https://avatars0.githubusercontent.com/u/8615257?v=4","gravatar_id":"","url":"https://api.github.com/users/steelyvoid","html_url":"https://github.com/steelyvoid","followers_url":"https://api.github.com/users/steelyvoid/followers","following_url":"https://api.github.com/users/steelyvoid/following{/other_user}","gists_url":"https://api.github.com/users/steelyvoid/gists{/gist_id}","starred_url":"https://api.github.com/users/steelyvoid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steelyvoid/subscriptions","organizations_url":"https://api.github.com/users/steelyvoid/orgs","repos_url":"https://api.github.com/users/steelyvoid/repos","events_url":"https://api.github.com/users/steelyvoid/events{/privacy}","received_events_url":"https://api.github.com/users/steelyvoid/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Metaswitch/sprout/pulls/2167/commits","review_comments_url":"https://api.github.com/repos/Metaswitch/sprout/pulls/2167/comments","review_comment_url":"https://api.github.com/repos/Metaswitch/sprout/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Metaswitch/sprout/issues/2167/comments","statuses_url":"https://api.github.com/repos/Metaswitch/sprout/statuses/9bcc47a42cdba08768ef76224a0f69d178bd8bfb","head":{"label":"Metaswitch:reliably_cancel_pjsip_timers","ref":"reliably_cancel_pjsip_timers","sha":"9bcc47a42cdba08768ef76224a0f69d178bd8bfb","user":{"login":"Metaswitch","id":453759,"avatar_url":"https://avatars1.githubusercontent.com/u/453759?v=4","gravatar_id":"","url":"https://api.github.com/users/Metaswitch","html_url":"https://github.com/Metaswitch","followers_url":"https://api.github.com/users/Metaswitch/followers","following_url":"https://api.github.com/users/Metaswitch/following{/other_user}","gists_url":"https://api.github.com/users/Metaswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Metaswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Metaswitch/subscriptions","organizations_url":"https://api.github.com/users/Metaswitch/orgs","repos_url":"https://api.github.com/users/Metaswitch/repos","events_url":"https://api.github.com/users/Metaswitch/events{/privacy}","received_events_url":"https://api.github.com/users/Metaswitch/received_events","type":"Organization","site_admin":false},"repo":{"id":9887542,"name":"sprout","full_name":"Metaswitch/sprout","owner":{"login":"Metaswitch","id":453759,"avatar_url":"https://avatars1.githubusercontent.com/u/453759?v=4","gravatar_id":"","url":"https://api.github.com/users/Metaswitch","html_url":"https://github.com/Metaswitch","followers_url":"https://api.github.com/users/Metaswitch/followers","following_url":"https://api.github.com/users/Metaswitch/following{/other_user}","gists_url":"https://api.github.com/users/Metaswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Metaswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Metaswitch/subscriptions","organizations_url":"https://api.github.com/users/Metaswitch/orgs","repos_url":"https://api.github.com/users/Metaswitch/repos","events_url":"https://api.github.com/users/Metaswitch/events{/privacy}","received_events_url":"https://api.github.com/users/Metaswitch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Metaswitch/sprout","description":"sprout and bono, the Clearwater SIP router and edge proxy","fork":false,"url":"https://api.github.com/repos/Metaswitch/sprout","forks_url":"https://api.github.com/repos/Metaswitch/sprout/forks","keys_url":"https://api.github.com/repos/Metaswitch/sprout/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Metaswitch/sprout/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Metaswitch/sprout/teams","hooks_url":"https://api.github.com/repos/Metaswitch/sprout/hooks","issue_events_url":"https://api.github.com/repos/Metaswitch/sprout/issues/events{/number}","events_url":"https://api.github.com/repos/Metaswitch/sprout/events","assignees_url":"https://api.github.com/repos/Metaswitch/sprout/assignees{/user}","branches_url":"https://api.github.com/repos/Metaswitch/sprout/branches{/branch}","tags_url":"https://api.github.com/repos/Metaswitch/sprout/tags","blobs_url":"https://api.github.com/repos/Metaswitch/sprout/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Metaswitch/sprout/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Metaswitch/sprout/git/refs{/sha}","trees_url":"https://api.github.com/repos/Metaswitch/sprout/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Metaswitch/sprout/statuses/{sha}","languages_url":"https://api.github.com/repos/Metaswitch/sprout/languages","stargazers_url":"https://api.github.com/repos/Metaswitch/sprout/stargazers","contributors_url":"https://api.github.com/repos/Metaswitch/sprout/contributors","subscribers_url":"https://api.github.com/repos/Metaswitch/sprout/subscribers","subscription_url":"https://api.github.com/repos/Metaswitch/sprout/subscription","commits_url":"https://api.github.com/repos/Metaswitch/sprout/commits{/sha}","git_commits_url":"https://api.github.com/repos/Metaswitch/sprout/git/commits{/sha}","comments_url":"https://api.github.com/repos/Metaswitch/sprout/comments{/number}","issue_comment_url":"https://api.github.com/repos/Metaswitch/sprout/issues/comments{/number}","contents_url":"https://api.github.com/repos/Metaswitch/sprout/contents/{+path}","compare_url":"https://api.github.com/repos/Metaswitch/sprout/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Metaswitch/sprout/merges","archive_url":"https://api.github.com/repos/Metaswitch/sprout/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Metaswitch/sprout/downloads","issues_url":"https://api.github.com/repos/Metaswitch/sprout/issues{/number}","pulls_url":"https://api.github.com/repos/Metaswitch/sprout/pulls{/number}","milestones_url":"https://api.github.com/repos/Metaswitch/sprout/milestones{/number}","notifications_url":"https://api.github.com/repos/Metaswitch/sprout/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Metaswitch/sprout/labels{/name}","releases_url":"https://api.github.com/repos/Metaswitch/sprout/releases{/id}","deployments_url":"https://api.github.com/repos/Metaswitch/sprout/deployments","created_at":"2013-05-06T13:37:07Z","updated_at":"2018-03-07T12:18:05Z","pushed_at":"2018-03-08T19:08:59Z","git_url":"git://github.com/Metaswitch/sprout.git","ssh_url":"git@github.com:Metaswitch/sprout.git","clone_url":"https://github.com/Metaswitch/sprout.git","svn_url":"https://github.com/Metaswitch/sprout","homepage":null,"size":34462,"stargazers_count":26,"watchers_count":26,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":31,"mirror_url":null,"archived":false,"open_issues_count":172,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":31,"open_issues":172,"watchers":26,"default_branch":"dev"}},"base":{"label":"Metaswitch:dev","ref":"dev","sha":"274e63e7573df552ebef8f60ab4aedd8760dbde4","user":{"login":"Metaswitch","id":453759,"avatar_url":"https://avatars1.githubusercontent.com/u/453759?v=4","gravatar_id":"","url":"https://api.github.com/users/Metaswitch","html_url":"https://github.com/Metaswitch","followers_url":"https://api.github.com/users/Metaswitch/followers","following_url":"https://api.github.com/users/Metaswitch/following{/other_user}","gists_url":"https://api.github.com/users/Metaswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Metaswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Metaswitch/subscriptions","organizations_url":"https://api.github.com/users/Metaswitch/orgs","repos_url":"https://api.github.com/users/Metaswitch/repos","events_url":"https://api.github.com/users/Metaswitch/events{/privacy}","received_events_url":"https://api.github.com/users/Metaswitch/received_events","type":"Organization","site_admin":false},"repo":{"id":9887542,"name":"sprout","full_name":"Metaswitch/sprout","owner":{"login":"Metaswitch","id":453759,"avatar_url":"https://avatars1.githubusercontent.com/u/453759?v=4","gravatar_id":"","url":"https://api.github.com/users/Metaswitch","html_url":"https://github.com/Metaswitch","followers_url":"https://api.github.com/users/Metaswitch/followers","following_url":"https://api.github.com/users/Metaswitch/following{/other_user}","gists_url":"https://api.github.com/users/Metaswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Metaswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Metaswitch/subscriptions","organizations_url":"https://api.github.com/users/Metaswitch/orgs","repos_url":"https://api.github.com/users/Metaswitch/repos","events_url":"https://api.github.com/users/Metaswitch/events{/privacy}","received_events_url":"https://api.github.com/users/Metaswitch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Metaswitch/sprout","description":"sprout and bono, the Clearwater SIP router and edge proxy","fork":false,"url":"https://api.github.com/repos/Metaswitch/sprout","forks_url":"https://api.github.com/repos/Metaswitch/sprout/forks","keys_url":"https://api.github.com/repos/Metaswitch/sprout/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Metaswitch/sprout/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Metaswitch/sprout/teams","hooks_url":"https://api.github.com/repos/Metaswitch/sprout/hooks","issue_events_url":"https://api.github.com/repos/Metaswitch/sprout/issues/events{/number}","events_url":"https://api.github.com/repos/Metaswitch/sprout/events","assignees_url":"https://api.github.com/repos/Metaswitch/sprout/assignees{/user}","branches_url":"https://api.github.com/repos/Metaswitch/sprout/branches{/branch}","tags_url":"https://api.github.com/repos/Metaswitch/sprout/tags","blobs_url":"https://api.github.com/repos/Metaswitch/sprout/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Metaswitch/sprout/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Metaswitch/sprout/git/refs{/sha}","trees_url":"https://api.github.com/repos/Metaswitch/sprout/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Metaswitch/sprout/statuses/{sha}","languages_url":"https://api.github.com/repos/Metaswitch/sprout/languages","stargazers_url":"https://api.github.com/repos/Metaswitch/sprout/stargazers","contributors_url":"https://api.github.com/repos/Metaswitch/sprout/contributors","subscribers_url":"https://api.github.com/repos/Metaswitch/sprout/subscribers","subscription_url":"https://api.github.com/repos/Metaswitch/sprout/subscription","commits_url":"https://api.github.com/repos/Metaswitch/sprout/commits{/sha}","git_commits_url":"https://api.github.com/repos/Metaswitch/sprout/git/commits{/sha}","comments_url":"https://api.github.com/repos/Metaswitch/sprout/comments{/number}","issue_comment_url":"https://api.github.com/repos/Metaswitch/sprout/issues/comments{/number}","contents_url":"https://api.github.com/repos/Metaswitch/sprout/contents/{+path}","compare_url":"https://api.github.com/repos/Metaswitch/sprout/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Metaswitch/sprout/merges","archive_url":"https://api.github.com/repos/Metaswitch/sprout/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Metaswitch/sprout/downloads","issues_url":"https://api.github.com/repos/Metaswitch/sprout/issues{/number}","pulls_url":"https://api.github.com/repos/Metaswitch/sprout/pulls{/number}","milestones_url":"https://api.github.com/repos/Metaswitch/sprout/milestones{/number}","notifications_url":"https://api.github.com/repos/Metaswitch/sprout/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Metaswitch/sprout/labels{/name}","releases_url":"https://api.github.com/repos/Metaswitch/sprout/releases{/id}","deployments_url":"https://api.github.com/repos/Metaswitch/sprout/deployments","created_at":"2013-05-06T13:37:07Z","updated_at":"2018-03-07T12:18:05Z","pushed_at":"2018-03-08T19:08:59Z","git_url":"git://github.com/Metaswitch/sprout.git","ssh_url":"git@github.com:Metaswitch/sprout.git","clone_url":"https://github.com/Metaswitch/sprout.git","svn_url":"https://github.com/Metaswitch/sprout","homepage":null,"size":34462,"stargazers_count":26,"watchers_count":26,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":31,"mirror_url":null,"archived":false,"open_issues_count":172,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":31,"open_issues":172,"watchers":26,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Metaswitch/sprout/pulls/2167"},"html":{"href":"https://github.com/Metaswitch/sprout/pull/2167"},"issue":{"href":"https://api.github.com/repos/Metaswitch/sprout/issues/2167"},"comments":{"href":"https://api.github.com/repos/Metaswitch/sprout/issues/2167/comments"},"review_comments":{"href":"https://api.github.com/repos/Metaswitch/sprout/pulls/2167/comments"},"review_comment":{"href":"https://api.github.com/repos/Metaswitch/sprout/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Metaswitch/sprout/pulls/2167/commits"},"statuses":{"href":"https://api.github.com/repos/Metaswitch/sprout/statuses/9bcc47a42cdba08768ef76224a0f69d178bd8bfb"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"steelyvoid"}}