{"action":"created","comment":{"url":"https://api.github.com/repos/paypal/squbs/pulls/comments/196442293","pull_request_review_id":129994253,"id":196442293,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NjQ0MjI5Mw==","diff_hunk":"@@ -201,14 +201,14 @@ class PersistentQueue[T](config: QueueConfig, onCommitCallback: Int => Unit = _\n \n     // deletes old files whose long value (based on epoch) is < released file's long value.\n     private def deleteOlderFiles(cycle: Int, releasedFile: File): Unit = {\n-      val files = Option(persistDir.listFiles).toArray.flatten.filterNot(_.getName == Tailer).toSeq\n-      if (files.nonEmpty) {\n-        val releasedFileLong = fileIdParser.toLong(releasedFile)\n-        files.filter { file =>\n-          file.getName.endsWith(SUFFIX) && (fileIdParser.toLong(file) < releasedFileLong)\n-        } foreach { file =>\n-          logger.info(\"File released {} - {}\", cycle.toString, file.getPath)\n-          file.delete()\n+      for {\n+        allFiles <- Option(persistDir.listFiles).toSeq\n+        file <- allFiles\n+        if (file.getName.endsWith(SUFFIX) &&  fileIdParser.toLong(releasedFile) > (fileIdParser.toLong(file)))\n+      } {","path":"squbs-pattern/src/main/scala/org/squbs/pattern/stream/PersistentQueue.scala","position":34,"original_position":34,"commit_id":"055731b75fac9ce1b90e806839b6395e89398219","original_commit_id":"055731b75fac9ce1b90e806839b6395e89398219","user":{"login":"anilgursel","id":3316621,"node_id":"MDQ6VXNlcjMzMTY2MjE=","avatar_url":"https://avatars0.githubusercontent.com/u/3316621?v=4","gravatar_id":"","url":"https://api.github.com/users/anilgursel","html_url":"https://github.com/anilgursel","followers_url":"https://api.github.com/users/anilgursel/followers","following_url":"https://api.github.com/users/anilgursel/following{/other_user}","gists_url":"https://api.github.com/users/anilgursel/gists{/gist_id}","starred_url":"https://api.github.com/users/anilgursel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anilgursel/subscriptions","organizations_url":"https://api.github.com/users/anilgursel/orgs","repos_url":"https://api.github.com/users/anilgursel/repos","events_url":"https://api.github.com/users/anilgursel/events{/privacy}","received_events_url":"https://api.github.com/users/anilgursel/received_events","type":"User","site_admin":false},"body":"I do not see filtering of Tailer and `directory-listing.cq4t` in this commit.  Earlier commits had a check like below:\r\n\r\n```scala\r\nif (file.getName != Tailer && file.getName != \"directory-listing.cq4t\")\r\n```\r\n\r\n","created_at":"2018-06-19T14:16:22Z","updated_at":"2018-06-19T14:16:22Z","html_url":"https://github.com/paypal/squbs/pull/667#discussion_r196442293","pull_request_url":"https://api.github.com/repos/paypal/squbs/pulls/667","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/paypal/squbs/pulls/comments/196442293"},"html":{"href":"https://github.com/paypal/squbs/pull/667#discussion_r196442293"},"pull_request":{"href":"https://api.github.com/repos/paypal/squbs/pulls/667"}}},"pull_request":{"url":"https://api.github.com/repos/paypal/squbs/pulls/667","id":193761772,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzNzYxNzcy","html_url":"https://github.com/paypal/squbs/pull/667","diff_url":"https://github.com/paypal/squbs/pull/667.diff","patch_url":"https://github.com/paypal/squbs/pull/667.patch","issue_url":"https://api.github.com/repos/paypal/squbs/issues/667","number":667,"state":"open","locked":false,"title":"[WIP] Bump chronicle queue","user":{"login":"jiminhsieh","id":5125598,"node_id":"MDQ6VXNlcjUxMjU1OTg=","avatar_url":"https://avatars3.githubusercontent.com/u/5125598?v=4","gravatar_id":"","url":"https://api.github.com/users/jiminhsieh","html_url":"https://github.com/jiminhsieh","followers_url":"https://api.github.com/users/jiminhsieh/followers","following_url":"https://api.github.com/users/jiminhsieh/following{/other_user}","gists_url":"https://api.github.com/users/jiminhsieh/gists{/gist_id}","starred_url":"https://api.github.com/users/jiminhsieh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jiminhsieh/subscriptions","organizations_url":"https://api.github.com/users/jiminhsieh/orgs","repos_url":"https://api.github.com/users/jiminhsieh/repos","events_url":"https://api.github.com/users/jiminhsieh/events{/privacy}","received_events_url":"https://api.github.com/users/jiminhsieh/received_events","type":"User","site_admin":false},"body":"\r\n- [ ] Title includes issue id.\r\n- [x] Description of the change added.\r\n- [ ] Commits are squashed.\r\n- [ ] Tests added.\r\n- [x] Documentation added/updated.\r\n- [x] Also please review [CONTRIBUTING.md](https://github.com/paypal/squbs/blob/master/CONTRIBUTING.md).\r\n","created_at":"2018-06-09T06:35:09Z","updated_at":"2018-06-19T14:16:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0bf7f4ff0efe8892827c76d9ad65803bd1dc05b9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/paypal/squbs/pulls/667/commits","review_comments_url":"https://api.github.com/repos/paypal/squbs/pulls/667/comments","review_comment_url":"https://api.github.com/repos/paypal/squbs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/paypal/squbs/issues/667/comments","statuses_url":"https://api.github.com/repos/paypal/squbs/statuses/055731b75fac9ce1b90e806839b6395e89398219","head":{"label":"jiminhsieh:bump-chronicle-queue","ref":"bump-chronicle-queue","sha":"055731b75fac9ce1b90e806839b6395e89398219","user":{"login":"jiminhsieh","id":5125598,"node_id":"MDQ6VXNlcjUxMjU1OTg=","avatar_url":"https://avatars3.githubusercontent.com/u/5125598?v=4","gravatar_id":"","url":"https://api.github.com/users/jiminhsieh","html_url":"https://github.com/jiminhsieh","followers_url":"https://api.github.com/users/jiminhsieh/followers","following_url":"https://api.github.com/users/jiminhsieh/following{/other_user}","gists_url":"https://api.github.com/users/jiminhsieh/gists{/gist_id}","starred_url":"https://api.github.com/users/jiminhsieh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jiminhsieh/subscriptions","organizations_url":"https://api.github.com/users/jiminhsieh/orgs","repos_url":"https://api.github.com/users/jiminhsieh/repos","events_url":"https://api.github.com/users/jiminhsieh/events{/privacy}","received_events_url":"https://api.github.com/users/jiminhsieh/received_events","type":"User","site_admin":false},"repo":{"id":114245760,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQyNDU3NjA=","name":"squbs","full_name":"jiminhsieh/squbs","owner":{"login":"jiminhsieh","id":5125598,"node_id":"MDQ6VXNlcjUxMjU1OTg=","avatar_url":"https://avatars3.githubusercontent.com/u/5125598?v=4","gravatar_id":"","url":"https://api.github.com/users/jiminhsieh","html_url":"https://github.com/jiminhsieh","followers_url":"https://api.github.com/users/jiminhsieh/followers","following_url":"https://api.github.com/users/jiminhsieh/following{/other_user}","gists_url":"https://api.github.com/users/jiminhsieh/gists{/gist_id}","starred_url":"https://api.github.com/users/jiminhsieh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jiminhsieh/subscriptions","organizations_url":"https://api.github.com/users/jiminhsieh/orgs","repos_url":"https://api.github.com/users/jiminhsieh/repos","events_url":"https://api.github.com/users/jiminhsieh/events{/privacy}","received_events_url":"https://api.github.com/users/jiminhsieh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jiminhsieh/squbs","description":"Akka/Akka HTTP for Large-Scale Production Deployments","fork":true,"url":"https://api.github.com/repos/jiminhsieh/squbs","forks_url":"https://api.github.com/repos/jiminhsieh/squbs/forks","keys_url":"https://api.github.com/repos/jiminhsieh/squbs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jiminhsieh/squbs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jiminhsieh/squbs/teams","hooks_url":"https://api.github.com/repos/jiminhsieh/squbs/hooks","issue_events_url":"https://api.github.com/repos/jiminhsieh/squbs/issues/events{/number}","events_url":"https://api.github.com/repos/jiminhsieh/squbs/events","assignees_url":"https://api.github.com/repos/jiminhsieh/squbs/assignees{/user}","branches_url":"https://api.github.com/repos/jiminhsieh/squbs/branches{/branch}","tags_url":"https://api.github.com/repos/jiminhsieh/squbs/tags","blobs_url":"https://api.github.com/repos/jiminhsieh/squbs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jiminhsieh/squbs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jiminhsieh/squbs/git/refs{/sha}","trees_url":"https://api.github.com/repos/jiminhsieh/squbs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jiminhsieh/squbs/statuses/{sha}","languages_url":"https://api.github.com/repos/jiminhsieh/squbs/languages","stargazers_url":"https://api.github.com/repos/jiminhsieh/squbs/stargazers","contributors_url":"https://api.github.com/repos/jiminhsieh/squbs/contributors","subscribers_url":"https://api.github.com/repos/jiminhsieh/squbs/subscribers","subscription_url":"https://api.github.com/repos/jiminhsieh/squbs/subscription","commits_url":"https://api.github.com/repos/jiminhsieh/squbs/commits{/sha}","git_commits_url":"https://api.github.com/repos/jiminhsieh/squbs/git/commits{/sha}","comments_url":"https://api.github.com/repos/jiminhsieh/squbs/comments{/number}","issue_comment_url":"https://api.github.com/repos/jiminhsieh/squbs/issues/comments{/number}","contents_url":"https://api.github.com/repos/jiminhsieh/squbs/contents/{+path}","compare_url":"https://api.github.com/repos/jiminhsieh/squbs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jiminhsieh/squbs/merges","archive_url":"https://api.github.com/repos/jiminhsieh/squbs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jiminhsieh/squbs/downloads","issues_url":"https://api.github.com/repos/jiminhsieh/squbs/issues{/number}","pulls_url":"https://api.github.com/repos/jiminhsieh/squbs/pulls{/number}","milestones_url":"https://api.github.com/repos/jiminhsieh/squbs/milestones{/number}","notifications_url":"https://api.github.com/repos/jiminhsieh/squbs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jiminhsieh/squbs/labels{/name}","releases_url":"https://api.github.com/repos/jiminhsieh/squbs/releases{/id}","deployments_url":"https://api.github.com/repos/jiminhsieh/squbs/deployments","created_at":"2017-12-14T12:05:27Z","updated_at":"2018-06-09T02:41:48Z","pushed_at":"2018-06-19T01:24:25Z","git_url":"git://github.com/jiminhsieh/squbs.git","ssh_url":"git@github.com:jiminhsieh/squbs.git","clone_url":"https://github.com/jiminhsieh/squbs.git","svn_url":"https://github.com/jiminhsieh/squbs","homepage":"http://paypal.github.io/squbs","size":7358,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"paypal:master","ref":"master","sha":"2662767dbc7103bf0e1451b4c6367f05969b3b9a","user":{"login":"paypal","id":476675,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3NjY3NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/476675?v=4","gravatar_id":"","url":"https://api.github.com/users/paypal","html_url":"https://github.com/paypal","followers_url":"https://api.github.com/users/paypal/followers","following_url":"https://api.github.com/users/paypal/following{/other_user}","gists_url":"https://api.github.com/users/paypal/gists{/gist_id}","starred_url":"https://api.github.com/users/paypal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paypal/subscriptions","organizations_url":"https://api.github.com/users/paypal/orgs","repos_url":"https://api.github.com/users/paypal/repos","events_url":"https://api.github.com/users/paypal/events{/privacy}","received_events_url":"https://api.github.com/users/paypal/received_events","type":"Organization","site_admin":false},"repo":{"id":38714007,"node_id":"MDEwOlJlcG9zaXRvcnkzODcxNDAwNw==","name":"squbs","full_name":"paypal/squbs","owner":{"login":"paypal","id":476675,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3NjY3NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/476675?v=4","gravatar_id":"","url":"https://api.github.com/users/paypal","html_url":"https://github.com/paypal","followers_url":"https://api.github.com/users/paypal/followers","following_url":"https://api.github.com/users/paypal/following{/other_user}","gists_url":"https://api.github.com/users/paypal/gists{/gist_id}","starred_url":"https://api.github.com/users/paypal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paypal/subscriptions","organizations_url":"https://api.github.com/users/paypal/orgs","repos_url":"https://api.github.com/users/paypal/repos","events_url":"https://api.github.com/users/paypal/events{/privacy}","received_events_url":"https://api.github.com/users/paypal/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/paypal/squbs","description":"Akka Streams & Akka HTTP for Large-Scale Production Deployments","fork":false,"url":"https://api.github.com/repos/paypal/squbs","forks_url":"https://api.github.com/repos/paypal/squbs/forks","keys_url":"https://api.github.com/repos/paypal/squbs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paypal/squbs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paypal/squbs/teams","hooks_url":"https://api.github.com/repos/paypal/squbs/hooks","issue_events_url":"https://api.github.com/repos/paypal/squbs/issues/events{/number}","events_url":"https://api.github.com/repos/paypal/squbs/events","assignees_url":"https://api.github.com/repos/paypal/squbs/assignees{/user}","branches_url":"https://api.github.com/repos/paypal/squbs/branches{/branch}","tags_url":"https://api.github.com/repos/paypal/squbs/tags","blobs_url":"https://api.github.com/repos/paypal/squbs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paypal/squbs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paypal/squbs/git/refs{/sha}","trees_url":"https://api.github.com/repos/paypal/squbs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paypal/squbs/statuses/{sha}","languages_url":"https://api.github.com/repos/paypal/squbs/languages","stargazers_url":"https://api.github.com/repos/paypal/squbs/stargazers","contributors_url":"https://api.github.com/repos/paypal/squbs/contributors","subscribers_url":"https://api.github.com/repos/paypal/squbs/subscribers","subscription_url":"https://api.github.com/repos/paypal/squbs/subscription","commits_url":"https://api.github.com/repos/paypal/squbs/commits{/sha}","git_commits_url":"https://api.github.com/repos/paypal/squbs/git/commits{/sha}","comments_url":"https://api.github.com/repos/paypal/squbs/comments{/number}","issue_comment_url":"https://api.github.com/repos/paypal/squbs/issues/comments{/number}","contents_url":"https://api.github.com/repos/paypal/squbs/contents/{+path}","compare_url":"https://api.github.com/repos/paypal/squbs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paypal/squbs/merges","archive_url":"https://api.github.com/repos/paypal/squbs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paypal/squbs/downloads","issues_url":"https://api.github.com/repos/paypal/squbs/issues{/number}","pulls_url":"https://api.github.com/repos/paypal/squbs/pulls{/number}","milestones_url":"https://api.github.com/repos/paypal/squbs/milestones{/number}","notifications_url":"https://api.github.com/repos/paypal/squbs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paypal/squbs/labels{/name}","releases_url":"https://api.github.com/repos/paypal/squbs/releases{/id}","deployments_url":"https://api.github.com/repos/paypal/squbs/deployments","created_at":"2015-07-07T20:48:12Z","updated_at":"2018-06-18T02:45:07Z","pushed_at":"2018-06-19T01:24:27Z","git_url":"git://github.com/paypal/squbs.git","ssh_url":"git@github.com:paypal/squbs.git","clone_url":"https://github.com/paypal/squbs.git","svn_url":"https://github.com/paypal/squbs","homepage":"http://paypal.github.io/squbs","size":7336,"stargazers_count":1133,"watchers_count":1133,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":195,"mirror_url":null,"archived":false,"open_issues_count":63,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":195,"open_issues":63,"watchers":1133,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/paypal/squbs/pulls/667"},"html":{"href":"https://github.com/paypal/squbs/pull/667"},"issue":{"href":"https://api.github.com/repos/paypal/squbs/issues/667"},"comments":{"href":"https://api.github.com/repos/paypal/squbs/issues/667/comments"},"review_comments":{"href":"https://api.github.com/repos/paypal/squbs/pulls/667/comments"},"review_comment":{"href":"https://api.github.com/repos/paypal/squbs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/paypal/squbs/pulls/667/commits"},"statuses":{"href":"https://api.github.com/repos/paypal/squbs/statuses/055731b75fac9ce1b90e806839b6395e89398219"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"anilgursel"}}