{"action":"created","issue":{"url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/issues/1383","repository_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push","labels_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/issues/1383/labels{/name}","comments_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/issues/1383/comments","events_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/issues/1383/events","html_url":"https://github.com/phonegap/phonegap-plugin-push/pull/1383","id":190069962,"node_id":"MDExOlB1bGxSZXF1ZXN0OTQxODMwMTE=","number":1383,"title":"[v2.0.x] Solved a couple Android build errors","user":{"login":"JaimeFerBec","id":3408943,"node_id":"MDQ6VXNlcjM0MDg5NDM=","avatar_url":"https://avatars0.githubusercontent.com/u/3408943?v=4","gravatar_id":"","url":"https://api.github.com/users/JaimeFerBec","html_url":"https://github.com/JaimeFerBec","followers_url":"https://api.github.com/users/JaimeFerBec/followers","following_url":"https://api.github.com/users/JaimeFerBec/following{/other_user}","gists_url":"https://api.github.com/users/JaimeFerBec/gists{/gist_id}","starred_url":"https://api.github.com/users/JaimeFerBec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JaimeFerBec/subscriptions","organizations_url":"https://api.github.com/users/JaimeFerBec/orgs","repos_url":"https://api.github.com/users/JaimeFerBec/repos","events_url":"https://api.github.com/users/JaimeFerBec/events{/privacy}","received_events_url":"https://api.github.com/users/JaimeFerBec/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-11-17T14:57:47Z","updated_at":"2018-06-03T03:34:32Z","closed_at":"2016-11-18T01:37:20Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/pulls/1383","html_url":"https://github.com/phonegap/phonegap-plugin-push/pull/1383","diff_url":"https://github.com/phonegap/phonegap-plugin-push/pull/1383.diff","patch_url":"https://github.com/phonegap/phonegap-plugin-push/pull/1383.patch"},"body":"<!--- Provide a general summary of your changes in the Title above -->\r\n\r\n## Description\r\nThis pull requests suggests changes to a couple of files that are used to configure and build this cordova plugin.\r\n\r\n## Related Issue\r\n[v2.0.x][Android] Multiple build errors #1381 \r\n\r\n## Motivation and Context\r\n<!--- Why is this change required? What problem does it solve? -->\r\nThis change solves the following two Android build errors, which came up running `cordova buid android` on a private cordova project of mine which uses this plugin.\r\n\r\n### First error\r\n\r\n> FAILURE: Build failed with an exception.\r\n> \r\n> What went wrong:\r\n> Execution failed for task ':transformClassesWithDexForArmv7Debug'.\r\n> com.android.build.api.transform.TransformException: com.android.ide.common.process.ProcessException: java.util.concurrent.ExecutionException: com.android.dex.DexException: Multiple dex files define Landroid/support/v4/accessibilityservice/AccessibilityServiceInfoCompat$AccessibilityServiceInfoVersionImpl;\r\n\r\n### Second error\r\n\r\n> FAILURE: Build failed with an exception.\r\n> \r\n> What went wrong:\r\n> Execution failed for task ':transformClassesWithDexForArmv7Debug'.\r\n> com.android.build.api.transform.TransformException: com.android.ide.common.process.ProcessException: java.util.concurrent.ExecutionException: com.android.dex.DexException: Multiple dex files define Lcom/google/firebase/FirebaseException;\r\n\r\n### In depth\r\nThe actual meaning of these errors, how I found them, and how I got to the solution I am proposing can all be found explained in depth in the related issue #1381.\r\n\r\n## How Has This Been Tested?\r\n<!--- Please describe in detail how you tested your changes. -->\r\n<!--- Include details of your testing environment, and the tests you ran to -->\r\n<!--- see how your change affects other areas of the code, etc. -->\r\nI ran the npm tests on this repository (as specified by the **CONTRIBUTING** document), and also tested the plugin with the proposed changes on a cordova project of mine.\r\n\r\n### Npm tests\r\nI ran npm test before and after making the changes in this repository, and the results were successful (I did not add any new tests, though).\r\n\r\n### Testing on my cordova project\r\nI added this plugin's v2.0.x branch with the proposed changes to my cordova project, and tried building (`cordova build android`) and running the app (`cordova run android`) on a physical Android device, making sure that the phonegap plugin was functioning correctly.\r\n\r\nThese tests were successful as well.\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [x] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] My code follows the code style of this project.\r\n- [ ] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\n- [x] I have read the **CONTRIBUTING** document.\r\n- [ ] I have added tests to cover my changes.\r\n- [x] All new and existing tests passed.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/issues/comments/394132488","html_url":"https://github.com/phonegap/phonegap-plugin-push/pull/1383#issuecomment-394132488","issue_url":"https://api.github.com/repos/phonegap/phonegap-plugin-push/issues/1383","id":394132488,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NDEzMjQ4OA==","user":{"login":"lock[bot]","id":33595554,"node_id":"MDM6Qm90MzM1OTU1NTQ=","avatar_url":"https://avatars1.githubusercontent.com/in/6672?v=4","gravatar_id":"","url":"https://api.github.com/users/lock%5Bbot%5D","html_url":"https://github.com/apps/lock","followers_url":"https://api.github.com/users/lock%5Bbot%5D/followers","following_url":"https://api.github.com/users/lock%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/lock%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/lock%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lock%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/lock%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/lock%5Bbot%5D/repos","events_url":"https://api.github.com/users/lock%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/lock%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-06-03T03:34:32Z","updated_at":"2018-06-03T03:34:32Z","author_association":"NONE","body":"This thread has been automatically locked."}}
{"actor":{"display_login":"lock"}}