{"action":"opened","number":12849,"pull_request":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/12849","id":240441139,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwNDQxMTM5","html_url":"https://github.com/scikit-learn/scikit-learn/pull/12849","diff_url":"https://github.com/scikit-learn/scikit-learn/pull/12849.diff","patch_url":"https://github.com/scikit-learn/scikit-learn/pull/12849.patch","issue_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/12849","number":12849,"state":"open","locked":false,"title":"[WIP] Improve SVC tests to make the","user":{"login":"ogrisel","id":89061,"node_id":"MDQ6VXNlcjg5MDYx","avatar_url":"https://avatars0.githubusercontent.com/u/89061?v=4","gravatar_id":"","url":"https://api.github.com/users/ogrisel","html_url":"https://github.com/ogrisel","followers_url":"https://api.github.com/users/ogrisel/followers","following_url":"https://api.github.com/users/ogrisel/following{/other_user}","gists_url":"https://api.github.com/users/ogrisel/gists{/gist_id}","starred_url":"https://api.github.com/users/ogrisel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ogrisel/subscriptions","organizations_url":"https://api.github.com/users/ogrisel/orgs","repos_url":"https://api.github.com/users/ogrisel/repos","events_url":"https://api.github.com/users/ogrisel/events{/privacy}","received_events_url":"https://api.github.com/users/ogrisel/received_events","type":"User","site_admin":false},"body":"This PR changes the assertions made on the parametrization of the dual coefficients of SVM to check the equality of two models because the ordering of the support vectors is non-deterministic in case of duplicated samples in the training set (as is the case in the iris dataset and the subset of 20 newsgroups\r\n we use in some of the tests).\r\n\r\nThe problem was identified in #12738 when trying to replace the libsvm-base solver by the one from DAAL using the daal4py monkeypatch from https://github.com/IntelPython/daal4py/pull/15.\r\n\r\nI have tried to run the tests with:\r\n\r\n```\r\npython -m daal4py -m pytest -vl  sklearn/svm/tests\r\n```\r\n\r\nand they pass on this branch (using the daal4py branch from  https://github.com/IntelPython/daal4py/pull/15).\r\n\r\nHowever, if I decrease the regularization (larger C value) in `test_svc_iris` or in `test_sparse_20newsgroups_subset` they will fail. I am not sure whether this highlight a true discrepancy between the 2 solvers or  whether this is just that the optimization problem becomes too under determined to guarantee such equality of the estimated parameters.\r\n\r\n","created_at":"2018-12-21T11:02:01Z","updated_at":"2018-12-21T11:02:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/12849/commits","review_comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/12849/comments","review_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/12849/comments","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/6b9da826308321e4df33ce70a11d5e124c8890b8","head":{"label":"ogrisel:svc-iris","ref":"svc-iris","sha":"6b9da826308321e4df33ce70a11d5e124c8890b8","user":{"login":"ogrisel","id":89061,"node_id":"MDQ6VXNlcjg5MDYx","avatar_url":"https://avatars0.githubusercontent.com/u/89061?v=4","gravatar_id":"","url":"https://api.github.com/users/ogrisel","html_url":"https://github.com/ogrisel","followers_url":"https://api.github.com/users/ogrisel/followers","following_url":"https://api.github.com/users/ogrisel/following{/other_user}","gists_url":"https://api.github.com/users/ogrisel/gists{/gist_id}","starred_url":"https://api.github.com/users/ogrisel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ogrisel/subscriptions","organizations_url":"https://api.github.com/users/ogrisel/orgs","repos_url":"https://api.github.com/users/ogrisel/repos","events_url":"https://api.github.com/users/ogrisel/events{/privacy}","received_events_url":"https://api.github.com/users/ogrisel/received_events","type":"User","site_admin":false},"repo":{"id":843501,"node_id":"MDEwOlJlcG9zaXRvcnk4NDM1MDE=","name":"scikit-learn","full_name":"ogrisel/scikit-learn","private":false,"owner":{"login":"ogrisel","id":89061,"node_id":"MDQ6VXNlcjg5MDYx","avatar_url":"https://avatars0.githubusercontent.com/u/89061?v=4","gravatar_id":"","url":"https://api.github.com/users/ogrisel","html_url":"https://github.com/ogrisel","followers_url":"https://api.github.com/users/ogrisel/followers","following_url":"https://api.github.com/users/ogrisel/following{/other_user}","gists_url":"https://api.github.com/users/ogrisel/gists{/gist_id}","starred_url":"https://api.github.com/users/ogrisel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ogrisel/subscriptions","organizations_url":"https://api.github.com/users/ogrisel/orgs","repos_url":"https://api.github.com/users/ogrisel/repos","events_url":"https://api.github.com/users/ogrisel/events{/privacy}","received_events_url":"https://api.github.com/users/ogrisel/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ogrisel/scikit-learn","description":"scikit-learn repo for ogrisel's work in progress contributions","fork":true,"url":"https://api.github.com/repos/ogrisel/scikit-learn","forks_url":"https://api.github.com/repos/ogrisel/scikit-learn/forks","keys_url":"https://api.github.com/repos/ogrisel/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ogrisel/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ogrisel/scikit-learn/teams","hooks_url":"https://api.github.com/repos/ogrisel/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/ogrisel/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/ogrisel/scikit-learn/events","assignees_url":"https://api.github.com/repos/ogrisel/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/ogrisel/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/ogrisel/scikit-learn/tags","blobs_url":"https://api.github.com/repos/ogrisel/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ogrisel/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ogrisel/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/ogrisel/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ogrisel/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/ogrisel/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/ogrisel/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/ogrisel/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/ogrisel/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/ogrisel/scikit-learn/subscription","commits_url":"https://api.github.com/repos/ogrisel/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/ogrisel/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/ogrisel/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/ogrisel/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/ogrisel/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/ogrisel/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ogrisel/scikit-learn/merges","archive_url":"https://api.github.com/repos/ogrisel/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ogrisel/scikit-learn/downloads","issues_url":"https://api.github.com/repos/ogrisel/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/ogrisel/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/ogrisel/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/ogrisel/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ogrisel/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/ogrisel/scikit-learn/releases{/id}","deployments_url":"https://api.github.com/repos/ogrisel/scikit-learn/deployments","created_at":"2010-08-17T12:40:43Z","updated_at":"2016-11-03T10:27:30Z","pushed_at":"2018-12-21T10:51:46Z","git_url":"git://github.com/ogrisel/scikit-learn.git","ssh_url":"git@github.com:ogrisel/scikit-learn.git","clone_url":"https://github.com/ogrisel/scikit-learn.git","svn_url":"https://github.com/ogrisel/scikit-learn","homepage":"http://scikit-learn.org","size":97232,"stargazers_count":18,"watchers_count":18,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":5,"open_issues":1,"watchers":18,"default_branch":"master"}},"base":{"label":"scikit-learn:master","ref":"master","sha":"951c4f1a51ff57968d9b13581c6dbfd0cc8fe150","user":{"login":"scikit-learn","id":365630,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTYzMA==","avatar_url":"https://avatars2.githubusercontent.com/u/365630?v=4","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"repo":{"id":843222,"node_id":"MDEwOlJlcG9zaXRvcnk4NDMyMjI=","name":"scikit-learn","full_name":"scikit-learn/scikit-learn","private":false,"owner":{"login":"scikit-learn","id":365630,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTYzMA==","avatar_url":"https://avatars2.githubusercontent.com/u/365630?v=4","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/scikit-learn/scikit-learn","description":"scikit-learn: machine learning in Python","fork":false,"url":"https://api.github.com/repos/scikit-learn/scikit-learn","forks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/forks","keys_url":"https://api.github.com/repos/scikit-learn/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scikit-learn/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scikit-learn/scikit-learn/teams","hooks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/events","assignees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/scikit-learn/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/tags","blobs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/scikit-learn/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscription","commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/scikit-learn/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scikit-learn/scikit-learn/merges","archive_url":"https://api.github.com/repos/scikit-learn/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scikit-learn/scikit-learn/downloads","issues_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/scikit-learn/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/scikit-learn/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/scikit-learn/scikit-learn/releases{/id}","deployments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/deployments","created_at":"2010-08-17T09:43:38Z","updated_at":"2018-12-21T08:15:37Z","pushed_at":"2018-12-21T10:09:49Z","git_url":"git://github.com/scikit-learn/scikit-learn.git","ssh_url":"git@github.com:scikit-learn/scikit-learn.git","clone_url":"https://github.com/scikit-learn/scikit-learn.git","svn_url":"https://github.com/scikit-learn/scikit-learn","homepage":"http://scikit-learn.org","size":97978,"stargazers_count":32415,"watchers_count":32415,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15964,"mirror_url":null,"archived":false,"open_issues_count":1857,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":15964,"open_issues":1857,"watchers":32415,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/12849"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/12849"},"issue":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/12849"},"comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/12849/comments"},"review_comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/12849/comments"},"review_comment":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/12849/commits"},"statuses":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/6b9da826308321e4df33ce70a11d5e124c8890b8"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":90,"deletions":31,"changed_files":2}}
{"actor":{"display_login":"ogrisel"}}