{"action":"created","comment":{"url":"https://api.github.com/repos/vert-x3/vertx-web/pulls/comments/189245304","pull_request_review_id":121389334,"id":189245304,"diff_hunk":"@@ -0,0 +1,38 @@\n+package io.vertx.ext.web.client.cache;\n+\n+import io.vertx.ext.web.client.HttpResponse;\n+import io.vertx.ext.web.client.impl.CacheInterceptor;\n+\n+import java.util.Optional;\n+\n+/**\n+ * Abstracts caching of HTTP requests and responses\n+ * @author Alexey Soshin\n+ */\n+public interface CacheManager {\n+\n+    /**\n+     * Clears the cache completely\n+     */\n+    void flush();\n+\n+    /**\n+     * Attempts to fetch value corresponding to request from cache\n+     * @param cacheKey key based on HTTP request\n+     * @return cached HTTP response or Optional.empty\n+     */\n+    Optional<HttpResponse<Object>> fetch(CacheInterceptor.CacheKey cacheKey);","path":"vertx-web-client/src/main/java/io/vertx/ext/web/client/cache/CacheManager.java","position":24,"original_position":24,"commit_id":"cbc642f1de0a56069c44349b19933914245e78e0","original_commit_id":"4dbdd6f147a6580b95080de38d81f7fc2e850d1a","user":{"login":"vietj","id":225674,"avatar_url":"https://avatars2.githubusercontent.com/u/225674?v=4","gravatar_id":"","url":"https://api.github.com/users/vietj","html_url":"https://github.com/vietj","followers_url":"https://api.github.com/users/vietj/followers","following_url":"https://api.github.com/users/vietj/following{/other_user}","gists_url":"https://api.github.com/users/vietj/gists{/gist_id}","starred_url":"https://api.github.com/users/vietj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vietj/subscriptions","organizations_url":"https://api.github.com/users/vietj/orgs","repos_url":"https://api.github.com/users/vietj/repos","events_url":"https://api.github.com/users/vietj/events{/privacy}","received_events_url":"https://api.github.com/users/vietj/received_events","type":"User","site_admin":false},"body":"then rather move the CacheKey to the cache package, CacheInterceptor is in `impl` package and `cache` package is SPI package","created_at":"2018-05-18T11:58:00Z","updated_at":"2018-05-18T11:58:00Z","html_url":"https://github.com/vert-x3/vertx-web/pull/892#discussion_r189245304","pull_request_url":"https://api.github.com/repos/vert-x3/vertx-web/pulls/892","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/vert-x3/vertx-web/pulls/comments/189245304"},"html":{"href":"https://github.com/vert-x3/vertx-web/pull/892#discussion_r189245304"},"pull_request":{"href":"https://api.github.com/repos/vert-x3/vertx-web/pulls/892"}},"in_reply_to_id":189109568},"pull_request":{"url":"https://api.github.com/repos/vert-x3/vertx-web/pulls/892","id":179169028,"html_url":"https://github.com/vert-x3/vertx-web/pull/892","diff_url":"https://github.com/vert-x3/vertx-web/pull/892.diff","patch_url":"https://github.com/vert-x3/vertx-web/pull/892.patch","issue_url":"https://api.github.com/repos/vert-x3/vertx-web/issues/892","number":892,"state":"open","locked":false,"title":"Fix #881 Vertx HTTP client/Web Client cache support","user":{"login":"AlexeySoshin","id":13611636,"avatar_url":"https://avatars0.githubusercontent.com/u/13611636?v=4","gravatar_id":"","url":"https://api.github.com/users/AlexeySoshin","html_url":"https://github.com/AlexeySoshin","followers_url":"https://api.github.com/users/AlexeySoshin/followers","following_url":"https://api.github.com/users/AlexeySoshin/following{/other_user}","gists_url":"https://api.github.com/users/AlexeySoshin/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexeySoshin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexeySoshin/subscriptions","organizations_url":"https://api.github.com/users/AlexeySoshin/orgs","repos_url":"https://api.github.com/users/AlexeySoshin/repos","events_url":"https://api.github.com/users/AlexeySoshin/events{/privacy}","received_events_url":"https://api.github.com/users/AlexeySoshin/received_events","type":"User","site_admin":false},"body":"Implement CachedWebClient that can cache HttpResponses","created_at":"2018-04-03T17:35:30Z","updated_at":"2018-05-18T11:58:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6101511963c53a471122b9ccfdcbea3ced332a8d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":234665676,"url":"https://api.github.com/repos/vert-x3/vertx-web/labels/to%20review","name":"to review","color":"ededed","default":false}],"milestone":{"url":"https://api.github.com/repos/vert-x3/vertx-web/milestones/9","html_url":"https://github.com/vert-x3/vertx-web/milestone/9","labels_url":"https://api.github.com/repos/vert-x3/vertx-web/milestones/9/labels","id":3106859,"number":9,"title":"3.6.0","description":null,"creator":{"login":"vietj","id":225674,"avatar_url":"https://avatars2.githubusercontent.com/u/225674?v=4","gravatar_id":"","url":"https://api.github.com/users/vietj","html_url":"https://github.com/vietj","followers_url":"https://api.github.com/users/vietj/followers","following_url":"https://api.github.com/users/vietj/following{/other_user}","gists_url":"https://api.github.com/users/vietj/gists{/gist_id}","starred_url":"https://api.github.com/users/vietj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vietj/subscriptions","organizations_url":"https://api.github.com/users/vietj/orgs","repos_url":"https://api.github.com/users/vietj/repos","events_url":"https://api.github.com/users/vietj/events{/privacy}","received_events_url":"https://api.github.com/users/vietj/received_events","type":"User","site_admin":false},"open_issues":8,"closed_issues":12,"state":"open","created_at":"2018-02-12T07:40:24Z","updated_at":"2018-05-18T09:42:34Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/vert-x3/vertx-web/pulls/892/commits","review_comments_url":"https://api.github.com/repos/vert-x3/vertx-web/pulls/892/comments","review_comment_url":"https://api.github.com/repos/vert-x3/vertx-web/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vert-x3/vertx-web/issues/892/comments","statuses_url":"https://api.github.com/repos/vert-x3/vertx-web/statuses/cbc642f1de0a56069c44349b19933914245e78e0","head":{"label":"AlexeySoshin:master","ref":"master","sha":"cbc642f1de0a56069c44349b19933914245e78e0","user":{"login":"AlexeySoshin","id":13611636,"avatar_url":"https://avatars0.githubusercontent.com/u/13611636?v=4","gravatar_id":"","url":"https://api.github.com/users/AlexeySoshin","html_url":"https://github.com/AlexeySoshin","followers_url":"https://api.github.com/users/AlexeySoshin/followers","following_url":"https://api.github.com/users/AlexeySoshin/following{/other_user}","gists_url":"https://api.github.com/users/AlexeySoshin/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexeySoshin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexeySoshin/subscriptions","organizations_url":"https://api.github.com/users/AlexeySoshin/orgs","repos_url":"https://api.github.com/users/AlexeySoshin/repos","events_url":"https://api.github.com/users/AlexeySoshin/events{/privacy}","received_events_url":"https://api.github.com/users/AlexeySoshin/received_events","type":"User","site_admin":false},"repo":{"id":125709934,"name":"vertx-web","full_name":"AlexeySoshin/vertx-web","owner":{"login":"AlexeySoshin","id":13611636,"avatar_url":"https://avatars0.githubusercontent.com/u/13611636?v=4","gravatar_id":"","url":"https://api.github.com/users/AlexeySoshin","html_url":"https://github.com/AlexeySoshin","followers_url":"https://api.github.com/users/AlexeySoshin/followers","following_url":"https://api.github.com/users/AlexeySoshin/following{/other_user}","gists_url":"https://api.github.com/users/AlexeySoshin/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexeySoshin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexeySoshin/subscriptions","organizations_url":"https://api.github.com/users/AlexeySoshin/orgs","repos_url":"https://api.github.com/users/AlexeySoshin/repos","events_url":"https://api.github.com/users/AlexeySoshin/events{/privacy}","received_events_url":"https://api.github.com/users/AlexeySoshin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AlexeySoshin/vertx-web","description":"HTTP web applications for Vert.x","fork":true,"url":"https://api.github.com/repos/AlexeySoshin/vertx-web","forks_url":"https://api.github.com/repos/AlexeySoshin/vertx-web/forks","keys_url":"https://api.github.com/repos/AlexeySoshin/vertx-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AlexeySoshin/vertx-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AlexeySoshin/vertx-web/teams","hooks_url":"https://api.github.com/repos/AlexeySoshin/vertx-web/hooks","issue_events_url":"https://api.github.com/repos/AlexeySoshin/vertx-web/issues/events{/number}","events_url":"https://api.github.com/repos/AlexeySoshin/vertx-web/events","assignees_url":"https://api.github.com/repos/AlexeySoshin/vertx-web/assignees{/user}","branches_url":"https://api.github.com/repos/AlexeySoshin/vertx-web/branches{/branch}","tags_url":"https://api.github.com/repos/AlexeySoshin/vertx-web/tags","blobs_url":"https://api.github.com/repos/AlexeySoshin/vertx-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AlexeySoshin/vertx-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AlexeySoshin/vertx-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/AlexeySoshin/vertx-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AlexeySoshin/vertx-web/statuses/{sha}","languages_url":"https://api.github.com/repos/AlexeySoshin/vertx-web/languages","stargazers_url":"https://api.github.com/repos/AlexeySoshin/vertx-web/stargazers","contributors_url":"https://api.github.com/repos/AlexeySoshin/vertx-web/contributors","subscribers_url":"https://api.github.com/repos/AlexeySoshin/vertx-web/subscribers","subscription_url":"https://api.github.com/repos/AlexeySoshin/vertx-web/subscription","commits_url":"https://api.github.com/repos/AlexeySoshin/vertx-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/AlexeySoshin/vertx-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/AlexeySoshin/vertx-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/AlexeySoshin/vertx-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/AlexeySoshin/vertx-web/contents/{+path}","compare_url":"https://api.github.com/repos/AlexeySoshin/vertx-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AlexeySoshin/vertx-web/merges","archive_url":"https://api.github.com/repos/AlexeySoshin/vertx-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AlexeySoshin/vertx-web/downloads","issues_url":"https://api.github.com/repos/AlexeySoshin/vertx-web/issues{/number}","pulls_url":"https://api.github.com/repos/AlexeySoshin/vertx-web/pulls{/number}","milestones_url":"https://api.github.com/repos/AlexeySoshin/vertx-web/milestones{/number}","notifications_url":"https://api.github.com/repos/AlexeySoshin/vertx-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AlexeySoshin/vertx-web/labels{/name}","releases_url":"https://api.github.com/repos/AlexeySoshin/vertx-web/releases{/id}","deployments_url":"https://api.github.com/repos/AlexeySoshin/vertx-web/deployments","created_at":"2018-03-18T09:31:45Z","updated_at":"2018-05-18T11:57:10Z","pushed_at":"2018-05-18T11:57:08Z","git_url":"git://github.com/AlexeySoshin/vertx-web.git","ssh_url":"git@github.com:AlexeySoshin/vertx-web.git","clone_url":"https://github.com/AlexeySoshin/vertx-web.git","svn_url":"https://github.com/AlexeySoshin/vertx-web","homepage":"","size":11484,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"vert-x3:master","ref":"master","sha":"0a196a7db43c492ba2082dd054218f8ec6899fbb","user":{"login":"vert-x3","id":8124623,"avatar_url":"https://avatars1.githubusercontent.com/u/8124623?v=4","gravatar_id":"","url":"https://api.github.com/users/vert-x3","html_url":"https://github.com/vert-x3","followers_url":"https://api.github.com/users/vert-x3/followers","following_url":"https://api.github.com/users/vert-x3/following{/other_user}","gists_url":"https://api.github.com/users/vert-x3/gists{/gist_id}","starred_url":"https://api.github.com/users/vert-x3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vert-x3/subscriptions","organizations_url":"https://api.github.com/users/vert-x3/orgs","repos_url":"https://api.github.com/users/vert-x3/repos","events_url":"https://api.github.com/users/vert-x3/events{/privacy}","received_events_url":"https://api.github.com/users/vert-x3/received_events","type":"Organization","site_admin":false},"repo":{"id":26628954,"name":"vertx-web","full_name":"vert-x3/vertx-web","owner":{"login":"vert-x3","id":8124623,"avatar_url":"https://avatars1.githubusercontent.com/u/8124623?v=4","gravatar_id":"","url":"https://api.github.com/users/vert-x3","html_url":"https://github.com/vert-x3","followers_url":"https://api.github.com/users/vert-x3/followers","following_url":"https://api.github.com/users/vert-x3/following{/other_user}","gists_url":"https://api.github.com/users/vert-x3/gists{/gist_id}","starred_url":"https://api.github.com/users/vert-x3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vert-x3/subscriptions","organizations_url":"https://api.github.com/users/vert-x3/orgs","repos_url":"https://api.github.com/users/vert-x3/repos","events_url":"https://api.github.com/users/vert-x3/events{/privacy}","received_events_url":"https://api.github.com/users/vert-x3/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vert-x3/vertx-web","description":"HTTP web applications for Vert.x","fork":false,"url":"https://api.github.com/repos/vert-x3/vertx-web","forks_url":"https://api.github.com/repos/vert-x3/vertx-web/forks","keys_url":"https://api.github.com/repos/vert-x3/vertx-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vert-x3/vertx-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vert-x3/vertx-web/teams","hooks_url":"https://api.github.com/repos/vert-x3/vertx-web/hooks","issue_events_url":"https://api.github.com/repos/vert-x3/vertx-web/issues/events{/number}","events_url":"https://api.github.com/repos/vert-x3/vertx-web/events","assignees_url":"https://api.github.com/repos/vert-x3/vertx-web/assignees{/user}","branches_url":"https://api.github.com/repos/vert-x3/vertx-web/branches{/branch}","tags_url":"https://api.github.com/repos/vert-x3/vertx-web/tags","blobs_url":"https://api.github.com/repos/vert-x3/vertx-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vert-x3/vertx-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vert-x3/vertx-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/vert-x3/vertx-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vert-x3/vertx-web/statuses/{sha}","languages_url":"https://api.github.com/repos/vert-x3/vertx-web/languages","stargazers_url":"https://api.github.com/repos/vert-x3/vertx-web/stargazers","contributors_url":"https://api.github.com/repos/vert-x3/vertx-web/contributors","subscribers_url":"https://api.github.com/repos/vert-x3/vertx-web/subscribers","subscription_url":"https://api.github.com/repos/vert-x3/vertx-web/subscription","commits_url":"https://api.github.com/repos/vert-x3/vertx-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/vert-x3/vertx-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/vert-x3/vertx-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/vert-x3/vertx-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/vert-x3/vertx-web/contents/{+path}","compare_url":"https://api.github.com/repos/vert-x3/vertx-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vert-x3/vertx-web/merges","archive_url":"https://api.github.com/repos/vert-x3/vertx-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vert-x3/vertx-web/downloads","issues_url":"https://api.github.com/repos/vert-x3/vertx-web/issues{/number}","pulls_url":"https://api.github.com/repos/vert-x3/vertx-web/pulls{/number}","milestones_url":"https://api.github.com/repos/vert-x3/vertx-web/milestones{/number}","notifications_url":"https://api.github.com/repos/vert-x3/vertx-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vert-x3/vertx-web/labels{/name}","releases_url":"https://api.github.com/repos/vert-x3/vertx-web/releases{/id}","deployments_url":"https://api.github.com/repos/vert-x3/vertx-web/deployments","created_at":"2014-11-14T08:15:20Z","updated_at":"2018-05-18T09:44:45Z","pushed_at":"2018-05-18T11:57:09Z","git_url":"git://github.com/vert-x3/vertx-web.git","ssh_url":"git@github.com:vert-x3/vertx-web.git","clone_url":"https://github.com/vert-x3/vertx-web.git","svn_url":"https://github.com/vert-x3/vertx-web","homepage":"","size":11646,"stargazers_count":428,"watchers_count":428,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":243,"mirror_url":null,"archived":false,"open_issues_count":133,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":243,"open_issues":133,"watchers":428,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vert-x3/vertx-web/pulls/892"},"html":{"href":"https://github.com/vert-x3/vertx-web/pull/892"},"issue":{"href":"https://api.github.com/repos/vert-x3/vertx-web/issues/892"},"comments":{"href":"https://api.github.com/repos/vert-x3/vertx-web/issues/892/comments"},"review_comments":{"href":"https://api.github.com/repos/vert-x3/vertx-web/pulls/892/comments"},"review_comment":{"href":"https://api.github.com/repos/vert-x3/vertx-web/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vert-x3/vertx-web/pulls/892/commits"},"statuses":{"href":"https://api.github.com/repos/vert-x3/vertx-web/statuses/cbc642f1de0a56069c44349b19933914245e78e0"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"vietj"}}