{"action":"created","issue":{"url":"https://api.github.com/repos/tensorflow/tensorboard/issues/1355","repository_url":"https://api.github.com/repos/tensorflow/tensorboard","labels_url":"https://api.github.com/repos/tensorflow/tensorboard/issues/1355/labels{/name}","comments_url":"https://api.github.com/repos/tensorflow/tensorboard/issues/1355/comments","events_url":"https://api.github.com/repos/tensorflow/tensorboard/issues/1355/events","html_url":"https://github.com/tensorflow/tensorboard/pull/1355","id":350531941,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4MzYwOTIy","number":1355,"title":"Perf: optimized tooltip redraw","user":{"login":"stephanwlee","id":2547313,"node_id":"MDQ6VXNlcjI1NDczMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/2547313?v=4","gravatar_id":"","url":"https://api.github.com/users/stephanwlee","html_url":"https://github.com/stephanwlee","followers_url":"https://api.github.com/users/stephanwlee/followers","following_url":"https://api.github.com/users/stephanwlee/following{/other_user}","gists_url":"https://api.github.com/users/stephanwlee/gists{/gist_id}","starred_url":"https://api.github.com/users/stephanwlee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephanwlee/subscriptions","organizations_url":"https://api.github.com/users/stephanwlee/orgs","repos_url":"https://api.github.com/users/stephanwlee/repos","events_url":"https://api.github.com/users/stephanwlee/events{/privacy}","received_events_url":"https://api.github.com/users/stephanwlee/received_events","type":"User","site_admin":false},"labels":[{"id":605776134,"node_id":"MDU6TGFiZWw2MDU3NzYxMzQ=","url":"https://api.github.com/repos/tensorflow/tensorboard/labels/type:bug/performance","name":"type:bug/performance","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-08-14T17:51:50Z","updated_at":"2018-08-15T23:10:23Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/tensorflow/tensorboard/pulls/1355","html_url":"https://github.com/tensorflow/tensorboard/pull/1355","diff_url":"https://github.com/tensorflow/tensorboard/pull/1355.diff","patch_url":"https://github.com/tensorflow/tensorboard/pull/1355.patch"},"body":"Note that this changes vz-line-chart.\r\n\r\nIn this change, it:\r\n- update tooltip instaed of complete redraw. Tooltip, previously, threw\r\n  away all items and created all rows anew on mouse move. It poorly\r\n  scaled with number of rows (runs). Instead, we now use d3 way of\r\n creating and updating each row on mouse move.\r\n- reorganizes how tooltip is draw\r\n- optimizes calculation of finding nearest data point from dataset.\r\n  Previously, it computed y-value for all data points (MxN) where\r\n  M ~ 1000 and 1 <= N <= ~20. It calculates nearest point only based on\r\n  x-value.\r\n- Wrap tooltip update around RAF. With large N and M, an update took\r\n  long enough to miss one animation frame. Instead of doing an update\r\n  right away, if we missed next animation frame, schedule an update\r\n  onto the next animation frame."},"comment":{"url":"https://api.github.com/repos/tensorflow/tensorboard/issues/comments/413368026","html_url":"https://github.com/tensorflow/tensorboard/pull/1355#issuecomment-413368026","issue_url":"https://api.github.com/repos/tensorflow/tensorboard/issues/1355","id":413368026,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMzM2ODAyNg==","user":{"login":"stephanwlee","id":2547313,"node_id":"MDQ6VXNlcjI1NDczMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/2547313?v=4","gravatar_id":"","url":"https://api.github.com/users/stephanwlee","html_url":"https://github.com/stephanwlee","followers_url":"https://api.github.com/users/stephanwlee/followers","following_url":"https://api.github.com/users/stephanwlee/following{/other_user}","gists_url":"https://api.github.com/users/stephanwlee/gists{/gist_id}","starred_url":"https://api.github.com/users/stephanwlee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephanwlee/subscriptions","organizations_url":"https://api.github.com/users/stephanwlee/orgs","repos_url":"https://api.github.com/users/stephanwlee/repos","events_url":"https://api.github.com/users/stephanwlee/events{/privacy}","received_events_url":"https://api.github.com/users/stephanwlee/received_events","type":"User","site_admin":false},"created_at":"2018-08-15T23:10:23Z","updated_at":"2018-08-15T23:10:23Z","author_association":"COLLABORATOR","body":"Got it. Just for my information, what specifically has happened in the past when changing vz-line-chart especially when it is a simple implementation change instead of API or behavioral change? Thanks!"}}
{"actor":{"display_login":"stephanwlee"}}