{"action":"created","issue":{"url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/issues/154","repository_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS","labels_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/issues/154/labels{/name}","comments_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/issues/154/comments","events_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/issues/154/events","html_url":"https://github.com/blockchain/My-Wallet-V3-iOS/pull/154","id":322136737,"number":154,"title":"refactor(reminder): move all reminder code to ReminderCoordinator.","user":{"login":"bchrisarriola","id":38220701,"avatar_url":"https://avatars0.githubusercontent.com/u/38220701?v=4","gravatar_id":"","url":"https://api.github.com/users/bchrisarriola","html_url":"https://github.com/bchrisarriola","followers_url":"https://api.github.com/users/bchrisarriola/followers","following_url":"https://api.github.com/users/bchrisarriola/following{/other_user}","gists_url":"https://api.github.com/users/bchrisarriola/gists{/gist_id}","starred_url":"https://api.github.com/users/bchrisarriola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bchrisarriola/subscriptions","organizations_url":"https://api.github.com/users/bchrisarriola/orgs","repos_url":"https://api.github.com/users/bchrisarriola/repos","events_url":"https://api.github.com/users/bchrisarriola/events{/privacy}","received_events_url":"https://api.github.com/users/bchrisarriola/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-05-11T01:20:19Z","updated_at":"2018-05-11T21:53:07Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/pulls/154","html_url":"https://github.com/blockchain/My-Wallet-V3-iOS/pull/154","diff_url":"https://github.com/blockchain/My-Wallet-V3-iOS/pull/154.diff","patch_url":"https://github.com/blockchain/My-Wallet-V3-iOS/pull/154.patch"},"body":"Note that I did not branch off of the `touch_id` branch (#153) so this can be reviewed/merged in parallel with it."},"comment":{"url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/issues/comments/388495197","html_url":"https://github.com/blockchain/My-Wallet-V3-iOS/pull/154#issuecomment-388495197","issue_url":"https://api.github.com/repos/blockchain/My-Wallet-V3-iOS/issues/154","id":388495197,"user":{"login":"bchrisarriola","id":38220701,"avatar_url":"https://avatars0.githubusercontent.com/u/38220701?v=4","gravatar_id":"","url":"https://api.github.com/users/bchrisarriola","html_url":"https://github.com/bchrisarriola","followers_url":"https://api.github.com/users/bchrisarriola/followers","following_url":"https://api.github.com/users/bchrisarriola/following{/other_user}","gists_url":"https://api.github.com/users/bchrisarriola/gists{/gist_id}","starred_url":"https://api.github.com/users/bchrisarriola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bchrisarriola/subscriptions","organizations_url":"https://api.github.com/users/bchrisarriola/orgs","repos_url":"https://api.github.com/users/bchrisarriola/repos","events_url":"https://api.github.com/users/bchrisarriola/events{/privacy}","received_events_url":"https://api.github.com/users/bchrisarriola/received_events","type":"User","site_admin":false},"created_at":"2018-05-11T21:53:07Z","updated_at":"2018-05-11T21:53:07Z","author_association":"CONTRIBUTOR","body":"Looks like there were some authentication flows (pin entry + touch ID) wherein `authHandler` within `WalletManager` was not set. Good catch, @woudini \r\n\r\nSome adjustments I made:\r\n* Created a method in `AuthenticationManager` to allow authenticating with a pin (check for maintenance is wrapped within here), this method accepts an `WalletAuthHandler`\r\n* Remove an extra call to `authenticateWithBiometrics` in AppDelegate's `applicationWillEnterForeground` method\r\n* `AuthenticationManager.Handler` typealias was previous conflated to mean two things: (1) handler for biometrics authentication, and (2) handler for password or pin authentication. To avoid the confusion, I created 2 type aliases (i.e. `WalletAuthHandler` and `BiometricsAuthHandler`) to capture these two different use cases"}}
{"actor":{"display_login":"bchrisarriola"}}