{"action":"created","issue":{"url":"https://api.github.com/repos/databricks/mlflow/issues/124","repository_url":"https://api.github.com/repos/databricks/mlflow","labels_url":"https://api.github.com/repos/databricks/mlflow/issues/124/labels{/name}","comments_url":"https://api.github.com/repos/databricks/mlflow/issues/124/comments","events_url":"https://api.github.com/repos/databricks/mlflow/issues/124/events","html_url":"https://github.com/databricks/mlflow/pull/124","id":338097622,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5MTE1ODQ4","number":124,"title":"Tag SageMaker docker image upload with current mlflow version","user":{"login":"sueann","id":4411489,"node_id":"MDQ6VXNlcjQ0MTE0ODk=","avatar_url":"https://avatars1.githubusercontent.com/u/4411489?v=4","gravatar_id":"","url":"https://api.github.com/users/sueann","html_url":"https://github.com/sueann","followers_url":"https://api.github.com/users/sueann/followers","following_url":"https://api.github.com/users/sueann/following{/other_user}","gists_url":"https://api.github.com/users/sueann/gists{/gist_id}","starred_url":"https://api.github.com/users/sueann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sueann/subscriptions","organizations_url":"https://api.github.com/users/sueann/orgs","repos_url":"https://api.github.com/users/sueann/repos","events_url":"https://api.github.com/users/sueann/events{/privacy}","received_events_url":"https://api.github.com/users/sueann/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-07-04T00:58:53Z","updated_at":"2018-07-05T21:24:00Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/databricks/mlflow/pulls/124","html_url":"https://github.com/databricks/mlflow/pull/124","diff_url":"https://github.com/databricks/mlflow/pull/124.diff","patch_url":"https://github.com/databricks/mlflow/pull/124.patch"},"body":"The SageMaker deployment docker image should be tagged with the mlflow version used so one can track the correct image to use in `deploy()`. This PR uses the current mlflow version to tag the ECR image instead of \"latest\" for SageMaker docker image upload.\r\n\r\nTo test (which should mirror the release process):\r\n1. Set `mlflow.version.VERSION` to the next version (e.g. 0.2.2 for the current state).\r\n2. Run `mlflow sagemaker build-and-push-container -c mlflow-pyfunc --mlflow_home <path_to_mlflow_git_checkout>`\r\n3. Check image was uploaded, tagged with the correct version, by running `aws ecr describe-images --repository-name mlflow-pyfunc` and examining the field `\"imageTags\"` (should be \"0.2.2\" given the command in 1)."},"comment":{"url":"https://api.github.com/repos/databricks/mlflow/issues/comments/402856865","html_url":"https://github.com/databricks/mlflow/pull/124#issuecomment-402856865","issue_url":"https://api.github.com/repos/databricks/mlflow/issues/124","id":402856865,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMjg1Njg2NQ==","user":{"login":"tomasatdatabricks","id":33237569,"node_id":"MDQ6VXNlcjMzMjM3NTY5","avatar_url":"https://avatars3.githubusercontent.com/u/33237569?v=4","gravatar_id":"","url":"https://api.github.com/users/tomasatdatabricks","html_url":"https://github.com/tomasatdatabricks","followers_url":"https://api.github.com/users/tomasatdatabricks/followers","following_url":"https://api.github.com/users/tomasatdatabricks/following{/other_user}","gists_url":"https://api.github.com/users/tomasatdatabricks/gists{/gist_id}","starred_url":"https://api.github.com/users/tomasatdatabricks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomasatdatabricks/subscriptions","organizations_url":"https://api.github.com/users/tomasatdatabricks/orgs","repos_url":"https://api.github.com/users/tomasatdatabricks/repos","events_url":"https://api.github.com/users/tomasatdatabricks/events{/privacy}","received_events_url":"https://api.github.com/users/tomasatdatabricks/received_events","type":"User","site_admin":false},"created_at":"2018-07-05T21:24:00Z","updated_at":"2018-07-05T21:24:00Z","author_association":"CONTRIBUTOR","body":"Looks the test might be flaky / there is a race somewhere. I reran the tests."}}
{"actor":{"display_login":"tomasatdatabricks"}}