{"action":"created","issue":{"url":"https://api.github.com/repos/ros-perception/laser_geometry/issues/28","repository_url":"https://api.github.com/repos/ros-perception/laser_geometry","labels_url":"https://api.github.com/repos/ros-perception/laser_geometry/issues/28/labels{/name}","comments_url":"https://api.github.com/repos/ros-perception/laser_geometry/issues/28/comments","events_url":"https://api.github.com/repos/ros-perception/laser_geometry/issues/28/events","html_url":"https://github.com/ros-perception/laser_geometry/pull/28","id":305584547,"number":28,"title":"Polish ros2 branch","user":{"login":"botteroa-si","id":34235401,"avatar_url":"https://avatars1.githubusercontent.com/u/34235401?v=4","gravatar_id":"","url":"https://api.github.com/users/botteroa-si","html_url":"https://github.com/botteroa-si","followers_url":"https://api.github.com/users/botteroa-si/followers","following_url":"https://api.github.com/users/botteroa-si/following{/other_user}","gists_url":"https://api.github.com/users/botteroa-si/gists{/gist_id}","starred_url":"https://api.github.com/users/botteroa-si/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/botteroa-si/subscriptions","organizations_url":"https://api.github.com/users/botteroa-si/orgs","repos_url":"https://api.github.com/users/botteroa-si/repos","events_url":"https://api.github.com/users/botteroa-si/events{/privacy}","received_events_url":"https://api.github.com/users/botteroa-si/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-03-15T14:50:09Z","updated_at":"2018-03-22T00:30:36Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/ros-perception/laser_geometry/pulls/28","html_url":"https://github.com/ros-perception/laser_geometry/pull/28","diff_url":"https://github.com/ros-perception/laser_geometry/pull/28.diff","patch_url":"https://github.com/ros-perception/laser_geometry/pull/28.patch"},"body":"Make the branch work on Windows (with VS '15 and '17), macOS and Linux.\r\n\r\n- Remove PoinCloud support: for now only supports PointCloud2. \r\n- Remove Boost dependencies\r\n- Make tests work (when possible: the other tests need tf2)\r\n- Introduce and fix ament linters present in most ROS2 packages (cpplint, uncrustify, cmake_lint, cppcheck)\r\n- Fix all Windows warnings on OSRF Jenkins warning level\r\n- Build as static library for now\r\n"},"comment":{"url":"https://api.github.com/repos/ros-perception/laser_geometry/issues/comments/375139700","html_url":"https://github.com/ros-perception/laser_geometry/pull/28#issuecomment-375139700","issue_url":"https://api.github.com/repos/ros-perception/laser_geometry/issues/28","id":375139700,"user":{"login":"wjwwood","id":100427,"avatar_url":"https://avatars1.githubusercontent.com/u/100427?v=4","gravatar_id":"","url":"https://api.github.com/users/wjwwood","html_url":"https://github.com/wjwwood","followers_url":"https://api.github.com/users/wjwwood/followers","following_url":"https://api.github.com/users/wjwwood/following{/other_user}","gists_url":"https://api.github.com/users/wjwwood/gists{/gist_id}","starred_url":"https://api.github.com/users/wjwwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wjwwood/subscriptions","organizations_url":"https://api.github.com/users/wjwwood/orgs","repos_url":"https://api.github.com/users/wjwwood/repos","events_url":"https://api.github.com/users/wjwwood/events{/privacy}","received_events_url":"https://api.github.com/users/wjwwood/received_events","type":"User","site_admin":false},"created_at":"2018-03-22T00:30:36Z","updated_at":"2018-03-22T00:30:36Z","author_association":"OWNER","body":"> Remove PoinCloud support: for now only supports PointCloud2.\r\n\r\nThis is a fine shortcut to take, but after merging please make an issue for this, and when I review the code I'll look for a TODO to match.\r\n\r\n> Make tests work (when possible: the other tests need tf2)\r\n\r\nWhy is needing `tf2` a problem?\r\n\r\n> Introduce and fix ament linters present in most ROS2 packages (cpplint, uncrustify, cmake_lint, cppcheck)\r\n\r\nThis, along with some other changes like the `.h` being changed to `.hpp` are not required to be in ROS 2, and though I chose to do this in rviz, I'd like to point out that they're not required.\r\n\r\n> Build as static library for now\r\n\r\nIf this is a shortcut to avoid visibility macros, I'd rather not delay this. It will need to be used as a shared library at some point in the future, I'd rather see that done now.\r\n\r\n----\r\n\r\nWhat about the python code? I think it depends on missing python code in `sensor_msgs`.\r\n\r\nI'd say it's fine not do everything in one pull requests, but we should do them soon or find someone willing to maintain this package in ROS 2 (I don't @vrabaud is going to have time) so that they can do these follow up items and/or accept contributions when someone does port those things for us in a pull request.\r\n\r\nI don't have time to take on that role."}}
{"actor":{"display_login":"wjwwood"}}