{"action":"created","issue":{"url":"https://api.github.com/repos/raiden-network/raiden/issues/3191","repository_url":"https://api.github.com/repos/raiden-network/raiden","labels_url":"https://api.github.com/repos/raiden-network/raiden/issues/3191/labels{/name}","comments_url":"https://api.github.com/repos/raiden-network/raiden/issues/3191/comments","events_url":"https://api.github.com/repos/raiden-network/raiden/issues/3191/events","html_url":"https://github.com/raiden-network/raiden/pull/3191","id":392701782,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5OTE0Njkz","number":3191,"title":" Protect targets_to_identifiers_to_statuses with a lock ","user":{"login":"LefterisJP","id":1658405,"node_id":"MDQ6VXNlcjE2NTg0MDU=","avatar_url":"https://avatars1.githubusercontent.com/u/1658405?v=4","gravatar_id":"","url":"https://api.github.com/users/LefterisJP","html_url":"https://github.com/LefterisJP","followers_url":"https://api.github.com/users/LefterisJP/followers","following_url":"https://api.github.com/users/LefterisJP/following{/other_user}","gists_url":"https://api.github.com/users/LefterisJP/gists{/gist_id}","starred_url":"https://api.github.com/users/LefterisJP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LefterisJP/subscriptions","organizations_url":"https://api.github.com/users/LefterisJP/orgs","repos_url":"https://api.github.com/users/LefterisJP/repos","events_url":"https://api.github.com/users/LefterisJP/events{/privacy}","received_events_url":"https://api.github.com/users/LefterisJP/received_events","type":"User","site_admin":false},"labels":[{"id":456350195,"node_id":"MDU6TGFiZWw0NTYzNTAxOTU=","url":"https://api.github.com/repos/raiden-network/raiden/labels/dev:%20Please%20Review","name":"dev: Please Review","color":"006b75","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-12-19T17:20:35Z","updated_at":"2019-01-04T16:44:03Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/raiden-network/raiden/pulls/3191","html_url":"https://github.com/raiden-network/raiden/pull/3191","diff_url":"https://github.com/raiden-network/raiden/pull/3191.diff","patch_url":"https://github.com/raiden-network/raiden/pull/3191.patch"},"body":"Also remove unnecessary assert.\r\n\r\nFixes a race condition of using the same payment identifier and the\r\nfirst transfer succeeding while the second one is just beginning.\r\nFor more details check: #3121 (comment)\r\n\r\nFix #3121"},"comment":{"url":"https://api.github.com/repos/raiden-network/raiden/issues/comments/451498294","html_url":"https://github.com/raiden-network/raiden/pull/3191#issuecomment-451498294","issue_url":"https://api.github.com/repos/raiden-network/raiden/issues/3191","id":451498294,"node_id":"MDEyOklzc3VlQ29tbWVudDQ1MTQ5ODI5NA==","user":{"login":"hackaugusto","id":310139,"node_id":"MDQ6VXNlcjMxMDEzOQ==","avatar_url":"https://avatars0.githubusercontent.com/u/310139?v=4","gravatar_id":"","url":"https://api.github.com/users/hackaugusto","html_url":"https://github.com/hackaugusto","followers_url":"https://api.github.com/users/hackaugusto/followers","following_url":"https://api.github.com/users/hackaugusto/following{/other_user}","gists_url":"https://api.github.com/users/hackaugusto/gists{/gist_id}","starred_url":"https://api.github.com/users/hackaugusto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hackaugusto/subscriptions","organizations_url":"https://api.github.com/users/hackaugusto/orgs","repos_url":"https://api.github.com/users/hackaugusto/repos","events_url":"https://api.github.com/users/hackaugusto/events{/privacy}","received_events_url":"https://api.github.com/users/hackaugusto/received_events","type":"User","site_admin":false},"created_at":"2019-01-04T16:44:03Z","updated_at":"2019-01-04T16:44:03Z","author_association":"COLLABORATOR","body":"> Put the assertion back on but keep the lock\r\n\r\nhttps://github.com/raiden-network/raiden/blob/8f1767797d63e894429bb6f398483c5925cccf7f/raiden/raiden_event_handler.py#L198-L202\r\n\r\nThat assert is really silly IMO, using a `pop` with a default to `assert` afterwards is just changing the location of the problem and the exception (a missing key) without any benefit. Could you please just not use the default in the `pop`?"}}
{"actor":{"display_login":"hackaugusto"}}