{"action":"created","comment":{"url":"https://api.github.com/repos/stevengj/meep/pulls/comments/204759144","pull_request_review_id":139894489,"id":204759144,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDc1OTE0NA==","diff_hunk":"@@ -180,9 +180,51 @@ integral = f_i [-w0^3/3 + (i+1) w0^2/2\n ****************************************************************************/\n \n using namespace std;\n+typedef complex<double> cdouble;\n \n namespace meep {\n \n+/***************************************************************/\n+/* utility routine designed to be called by chunkloop functions*/\n+/* for fetching values of field components at grid points,     */\n+/* taking into account the complications of symmetry and       */\n+/* yee-grid averaging.                                         */\n+/* The first 5 arguments are the arguments of the same name    */\n+/* passed to the chunkloop function.                           */\n+/* The 6th argument is the integer idx defined inside the body */\n+/* of a LOOP_OVER_IVECS.                                       */\n+/* components is a caller-created list of components; the      */\n+/* return value is an array of the same length storing the     */\n+/* values of those components at the grid point.               */\n+/***************************************************************/\n+vector<complex<double> > get_field_components(fields_chunk *fc, component cgrid,\n+                                              complex<double> shift_phase,\n+                                              const symmetry &S, int sn,\n+                                              int idx, vector<component> components)","path":"src/loop_in_chunks.cpp","position":24,"original_position":24,"commit_id":"f02ac28975817f58029515d9dcd797f958199364","original_commit_id":"f02ac28975817f58029515d9dcd797f958199364","user":{"login":"stevengj","id":2913679,"node_id":"MDQ6VXNlcjI5MTM2Nzk=","avatar_url":"https://avatars3.githubusercontent.com/u/2913679?v=4","gravatar_id":"","url":"https://api.github.com/users/stevengj","html_url":"https://github.com/stevengj","followers_url":"https://api.github.com/users/stevengj/followers","following_url":"https://api.github.com/users/stevengj/following{/other_user}","gists_url":"https://api.github.com/users/stevengj/gists{/gist_id}","starred_url":"https://api.github.com/users/stevengj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevengj/subscriptions","organizations_url":"https://api.github.com/users/stevengj/orgs","repos_url":"https://api.github.com/users/stevengj/repos","events_url":"https://api.github.com/users/stevengj/events{/privacy}","received_events_url":"https://api.github.com/users/stevengj/received_events","type":"User","site_admin":false},"body":"This really should be refactored into two routines, one since the call to `S.transform`, `S.phase_shift`, and `yee2cent_offsets` can happen once outside the ivec loop.   That is, there should be one routine that sets up a data structure or class for field computations (outside the loop) and one that applies it to `fc->f` (inside the loop).","created_at":"2018-07-24T13:41:15Z","updated_at":"2018-07-24T13:41:16Z","html_url":"https://github.com/stevengj/meep/pull/428#discussion_r204759144","pull_request_url":"https://api.github.com/repos/stevengj/meep/pulls/428","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/stevengj/meep/pulls/comments/204759144"},"html":{"href":"https://github.com/stevengj/meep/pull/428#discussion_r204759144"},"pull_request":{"href":"https://api.github.com/repos/stevengj/meep/pulls/428"}}},"pull_request":{"url":"https://api.github.com/repos/stevengj/meep/pulls/428","id":203084459,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzMDg0NDU5","html_url":"https://github.com/stevengj/meep/pull/428","diff_url":"https://github.com/stevengj/meep/pull/428.diff","patch_url":"https://github.com/stevengj/meep/pull/428.patch","issue_url":"https://api.github.com/repos/stevengj/meep/issues/428","number":428,"state":"open","locked":false,"title":"Docs on chunking and symmetries","user":{"login":"HomerReid","id":920123,"node_id":"MDQ6VXNlcjkyMDEyMw==","avatar_url":"https://avatars0.githubusercontent.com/u/920123?v=4","gravatar_id":"","url":"https://api.github.com/users/HomerReid","html_url":"https://github.com/HomerReid","followers_url":"https://api.github.com/users/HomerReid/followers","following_url":"https://api.github.com/users/HomerReid/following{/other_user}","gists_url":"https://api.github.com/users/HomerReid/gists{/gist_id}","starred_url":"https://api.github.com/users/HomerReid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HomerReid/subscriptions","organizations_url":"https://api.github.com/users/HomerReid/orgs","repos_url":"https://api.github.com/users/HomerReid/repos","events_url":"https://api.github.com/users/HomerReid/events{/privacy}","received_events_url":"https://api.github.com/users/HomerReid/received_events","type":"User","site_admin":false},"body":"Fixes #405. I decided to go ahead and write the documentation myself. Here is a PDF printout of what the online documentation will look like.\r\n[ChunksAndSymmetry.pdf](https://github.com/stevengj/meep/files/2217522/ChunksAndSymmetry.pdf)\r\n","created_at":"2018-07-23T00:02:36Z","updated_at":"2018-07-24T13:41:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cc6da68ccb732666802a6387cbfd95e23ee1263c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/stevengj/meep/pulls/428/commits","review_comments_url":"https://api.github.com/repos/stevengj/meep/pulls/428/comments","review_comment_url":"https://api.github.com/repos/stevengj/meep/pulls/comments{/number}","comments_url":"https://api.github.com/repos/stevengj/meep/issues/428/comments","statuses_url":"https://api.github.com/repos/stevengj/meep/statuses/f02ac28975817f58029515d9dcd797f958199364","head":{"label":"HomerReid:docs_on_chunking_and_symmetries","ref":"docs_on_chunking_and_symmetries","sha":"f02ac28975817f58029515d9dcd797f958199364","user":{"login":"HomerReid","id":920123,"node_id":"MDQ6VXNlcjkyMDEyMw==","avatar_url":"https://avatars0.githubusercontent.com/u/920123?v=4","gravatar_id":"","url":"https://api.github.com/users/HomerReid","html_url":"https://github.com/HomerReid","followers_url":"https://api.github.com/users/HomerReid/followers","following_url":"https://api.github.com/users/HomerReid/following{/other_user}","gists_url":"https://api.github.com/users/HomerReid/gists{/gist_id}","starred_url":"https://api.github.com/users/HomerReid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HomerReid/subscriptions","organizations_url":"https://api.github.com/users/HomerReid/orgs","repos_url":"https://api.github.com/users/HomerReid/repos","events_url":"https://api.github.com/users/HomerReid/events{/privacy}","received_events_url":"https://api.github.com/users/HomerReid/received_events","type":"User","site_admin":false},"repo":{"id":123765110,"node_id":"MDEwOlJlcG9zaXRvcnkxMjM3NjUxMTA=","name":"meep","full_name":"HomerReid/meep","owner":{"login":"HomerReid","id":920123,"node_id":"MDQ6VXNlcjkyMDEyMw==","avatar_url":"https://avatars0.githubusercontent.com/u/920123?v=4","gravatar_id":"","url":"https://api.github.com/users/HomerReid","html_url":"https://github.com/HomerReid","followers_url":"https://api.github.com/users/HomerReid/followers","following_url":"https://api.github.com/users/HomerReid/following{/other_user}","gists_url":"https://api.github.com/users/HomerReid/gists{/gist_id}","starred_url":"https://api.github.com/users/HomerReid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HomerReid/subscriptions","organizations_url":"https://api.github.com/users/HomerReid/orgs","repos_url":"https://api.github.com/users/HomerReid/repos","events_url":"https://api.github.com/users/HomerReid/events{/privacy}","received_events_url":"https://api.github.com/users/HomerReid/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/HomerReid/meep","description":"free finite-difference time-domain (FDTD) software for electromagnetic simulations","fork":true,"url":"https://api.github.com/repos/HomerReid/meep","forks_url":"https://api.github.com/repos/HomerReid/meep/forks","keys_url":"https://api.github.com/repos/HomerReid/meep/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HomerReid/meep/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HomerReid/meep/teams","hooks_url":"https://api.github.com/repos/HomerReid/meep/hooks","issue_events_url":"https://api.github.com/repos/HomerReid/meep/issues/events{/number}","events_url":"https://api.github.com/repos/HomerReid/meep/events","assignees_url":"https://api.github.com/repos/HomerReid/meep/assignees{/user}","branches_url":"https://api.github.com/repos/HomerReid/meep/branches{/branch}","tags_url":"https://api.github.com/repos/HomerReid/meep/tags","blobs_url":"https://api.github.com/repos/HomerReid/meep/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HomerReid/meep/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HomerReid/meep/git/refs{/sha}","trees_url":"https://api.github.com/repos/HomerReid/meep/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HomerReid/meep/statuses/{sha}","languages_url":"https://api.github.com/repos/HomerReid/meep/languages","stargazers_url":"https://api.github.com/repos/HomerReid/meep/stargazers","contributors_url":"https://api.github.com/repos/HomerReid/meep/contributors","subscribers_url":"https://api.github.com/repos/HomerReid/meep/subscribers","subscription_url":"https://api.github.com/repos/HomerReid/meep/subscription","commits_url":"https://api.github.com/repos/HomerReid/meep/commits{/sha}","git_commits_url":"https://api.github.com/repos/HomerReid/meep/git/commits{/sha}","comments_url":"https://api.github.com/repos/HomerReid/meep/comments{/number}","issue_comment_url":"https://api.github.com/repos/HomerReid/meep/issues/comments{/number}","contents_url":"https://api.github.com/repos/HomerReid/meep/contents/{+path}","compare_url":"https://api.github.com/repos/HomerReid/meep/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HomerReid/meep/merges","archive_url":"https://api.github.com/repos/HomerReid/meep/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HomerReid/meep/downloads","issues_url":"https://api.github.com/repos/HomerReid/meep/issues{/number}","pulls_url":"https://api.github.com/repos/HomerReid/meep/pulls{/number}","milestones_url":"https://api.github.com/repos/HomerReid/meep/milestones{/number}","notifications_url":"https://api.github.com/repos/HomerReid/meep/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HomerReid/meep/labels{/name}","releases_url":"https://api.github.com/repos/HomerReid/meep/releases{/id}","deployments_url":"https://api.github.com/repos/HomerReid/meep/deployments","created_at":"2018-03-04T07:01:27Z","updated_at":"2018-06-04T10:14:04Z","pushed_at":"2018-07-24T05:08:53Z","git_url":"git://github.com/HomerReid/meep.git","ssh_url":"git@github.com:HomerReid/meep.git","clone_url":"https://github.com/HomerReid/meep.git","svn_url":"https://github.com/HomerReid/meep","homepage":null,"size":17585,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"stevengj:master","ref":"master","sha":"222982424a2eb949dc4f3f8c4834aaa839570b0c","user":{"login":"stevengj","id":2913679,"node_id":"MDQ6VXNlcjI5MTM2Nzk=","avatar_url":"https://avatars3.githubusercontent.com/u/2913679?v=4","gravatar_id":"","url":"https://api.github.com/users/stevengj","html_url":"https://github.com/stevengj","followers_url":"https://api.github.com/users/stevengj/followers","following_url":"https://api.github.com/users/stevengj/following{/other_user}","gists_url":"https://api.github.com/users/stevengj/gists{/gist_id}","starred_url":"https://api.github.com/users/stevengj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevengj/subscriptions","organizations_url":"https://api.github.com/users/stevengj/orgs","repos_url":"https://api.github.com/users/stevengj/repos","events_url":"https://api.github.com/users/stevengj/events{/privacy}","received_events_url":"https://api.github.com/users/stevengj/received_events","type":"User","site_admin":false},"repo":{"id":18223131,"node_id":"MDEwOlJlcG9zaXRvcnkxODIyMzEzMQ==","name":"meep","full_name":"stevengj/meep","owner":{"login":"stevengj","id":2913679,"node_id":"MDQ6VXNlcjI5MTM2Nzk=","avatar_url":"https://avatars3.githubusercontent.com/u/2913679?v=4","gravatar_id":"","url":"https://api.github.com/users/stevengj","html_url":"https://github.com/stevengj","followers_url":"https://api.github.com/users/stevengj/followers","following_url":"https://api.github.com/users/stevengj/following{/other_user}","gists_url":"https://api.github.com/users/stevengj/gists{/gist_id}","starred_url":"https://api.github.com/users/stevengj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevengj/subscriptions","organizations_url":"https://api.github.com/users/stevengj/orgs","repos_url":"https://api.github.com/users/stevengj/repos","events_url":"https://api.github.com/users/stevengj/events{/privacy}","received_events_url":"https://api.github.com/users/stevengj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stevengj/meep","description":"free finite-difference time-domain (FDTD) software for electromagnetic simulations","fork":false,"url":"https://api.github.com/repos/stevengj/meep","forks_url":"https://api.github.com/repos/stevengj/meep/forks","keys_url":"https://api.github.com/repos/stevengj/meep/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stevengj/meep/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stevengj/meep/teams","hooks_url":"https://api.github.com/repos/stevengj/meep/hooks","issue_events_url":"https://api.github.com/repos/stevengj/meep/issues/events{/number}","events_url":"https://api.github.com/repos/stevengj/meep/events","assignees_url":"https://api.github.com/repos/stevengj/meep/assignees{/user}","branches_url":"https://api.github.com/repos/stevengj/meep/branches{/branch}","tags_url":"https://api.github.com/repos/stevengj/meep/tags","blobs_url":"https://api.github.com/repos/stevengj/meep/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stevengj/meep/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stevengj/meep/git/refs{/sha}","trees_url":"https://api.github.com/repos/stevengj/meep/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stevengj/meep/statuses/{sha}","languages_url":"https://api.github.com/repos/stevengj/meep/languages","stargazers_url":"https://api.github.com/repos/stevengj/meep/stargazers","contributors_url":"https://api.github.com/repos/stevengj/meep/contributors","subscribers_url":"https://api.github.com/repos/stevengj/meep/subscribers","subscription_url":"https://api.github.com/repos/stevengj/meep/subscription","commits_url":"https://api.github.com/repos/stevengj/meep/commits{/sha}","git_commits_url":"https://api.github.com/repos/stevengj/meep/git/commits{/sha}","comments_url":"https://api.github.com/repos/stevengj/meep/comments{/number}","issue_comment_url":"https://api.github.com/repos/stevengj/meep/issues/comments{/number}","contents_url":"https://api.github.com/repos/stevengj/meep/contents/{+path}","compare_url":"https://api.github.com/repos/stevengj/meep/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stevengj/meep/merges","archive_url":"https://api.github.com/repos/stevengj/meep/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stevengj/meep/downloads","issues_url":"https://api.github.com/repos/stevengj/meep/issues{/number}","pulls_url":"https://api.github.com/repos/stevengj/meep/pulls{/number}","milestones_url":"https://api.github.com/repos/stevengj/meep/milestones{/number}","notifications_url":"https://api.github.com/repos/stevengj/meep/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stevengj/meep/labels{/name}","releases_url":"https://api.github.com/repos/stevengj/meep/releases{/id}","deployments_url":"https://api.github.com/repos/stevengj/meep/deployments","created_at":"2014-03-28T18:59:52Z","updated_at":"2018-07-22T19:34:18Z","pushed_at":"2018-07-24T05:08:54Z","git_url":"git://github.com/stevengj/meep.git","ssh_url":"git@github.com:stevengj/meep.git","clone_url":"https://github.com/stevengj/meep.git","svn_url":"https://github.com/stevengj/meep","homepage":null,"size":15902,"stargazers_count":183,"watchers_count":183,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":91,"mirror_url":null,"archived":false,"open_issues_count":47,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":91,"open_issues":47,"watchers":183,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/stevengj/meep/pulls/428"},"html":{"href":"https://github.com/stevengj/meep/pull/428"},"issue":{"href":"https://api.github.com/repos/stevengj/meep/issues/428"},"comments":{"href":"https://api.github.com/repos/stevengj/meep/issues/428/comments"},"review_comments":{"href":"https://api.github.com/repos/stevengj/meep/pulls/428/comments"},"review_comment":{"href":"https://api.github.com/repos/stevengj/meep/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/stevengj/meep/pulls/428/commits"},"statuses":{"href":"https://api.github.com/repos/stevengj/meep/statuses/f02ac28975817f58029515d9dcd797f958199364"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"stevengj"}}