{"action":"created","comment":{"url":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls/comments/217004497","pull_request_review_id":154614740,"id":217004497,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzAwNDQ5Nw==","diff_hunk":"@@ -1591,10 +1596,12 @@ void TorrentHandle::handleTorrentFinishedAlert(const libtorrent::torrent_finishe\n         m_moveFinishedTriggers.append(boost::bind(&Session::handleTorrentFinished, m_session, this));\n     }\n     else {\n-        if (recheckTorrentsOnCompletion)\n+        if (recheckTorrentsOnCompletion && !m_didCheck)","path":"src/base/bittorrent/torrenthandle.cpp","position":17,"original_position":17,"commit_id":"0af8ebacc4d05f4cc32712c51a07d2853c8a1aaf","original_commit_id":"0af8ebacc4d05f4cc32712c51a07d2853c8a1aaf","user":{"login":"glassez","id":5063477,"node_id":"MDQ6VXNlcjUwNjM0Nzc=","avatar_url":"https://avatars3.githubusercontent.com/u/5063477?v=4","gravatar_id":"","url":"https://api.github.com/users/glassez","html_url":"https://github.com/glassez","followers_url":"https://api.github.com/users/glassez/followers","following_url":"https://api.github.com/users/glassez/following{/other_user}","gists_url":"https://api.github.com/users/glassez/gists{/gist_id}","starred_url":"https://api.github.com/users/glassez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glassez/subscriptions","organizations_url":"https://api.github.com/users/glassez/orgs","repos_url":"https://api.github.com/users/glassez/repos","events_url":"https://api.github.com/users/glassez/events{/privacy}","received_events_url":"https://api.github.com/users/glassez/received_events","type":"User","site_admin":false},"body":"You also need to add this condition above to prevent deferred call to \"forceRecheck()\".","created_at":"2018-09-12T12:12:11Z","updated_at":"2018-09-12T12:12:19Z","html_url":"https://github.com/qbittorrent/qBittorrent/pull/9481#discussion_r217004497","pull_request_url":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls/9481","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls/comments/217004497"},"html":{"href":"https://github.com/qbittorrent/qBittorrent/pull/9481#discussion_r217004497"},"pull_request":{"href":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls/9481"}}},"pull_request":{"url":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls/9481","id":214612766,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0NjEyNzY2","html_url":"https://github.com/qbittorrent/qBittorrent/pull/9481","diff_url":"https://github.com/qbittorrent/qBittorrent/pull/9481.diff","patch_url":"https://github.com/qbittorrent/qBittorrent/pull/9481.patch","issue_url":"https://api.github.com/repos/qbittorrent/qBittorrent/issues/9481","number":9481,"state":"open","locked":false,"title":"Recheck on completion loop workaround","user":{"login":"mj-p","id":38722481,"node_id":"MDQ6VXNlcjM4NzIyNDgx","avatar_url":"https://avatars1.githubusercontent.com/u/38722481?v=4","gravatar_id":"","url":"https://api.github.com/users/mj-p","html_url":"https://github.com/mj-p","followers_url":"https://api.github.com/users/mj-p/followers","following_url":"https://api.github.com/users/mj-p/following{/other_user}","gists_url":"https://api.github.com/users/mj-p/gists{/gist_id}","starred_url":"https://api.github.com/users/mj-p/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mj-p/subscriptions","organizations_url":"https://api.github.com/users/mj-p/orgs","repos_url":"https://api.github.com/users/mj-p/repos","events_url":"https://api.github.com/users/mj-p/events{/privacy}","received_events_url":"https://api.github.com/users/mj-p/received_events","type":"User","site_admin":false},"body":"Keep state of a recheck requirement for recheckOnCompletion.\r\n\r\nCurrent implementation didn't work for new seeding torrents with recheckOnCompletion on due to the order events are fired in libtorrent (torrent_finished first, then torrent_checked).\r\n\r\nIssues: #9370 and #8743","created_at":"2018-09-11T12:18:50Z","updated_at":"2018-09-12T12:12:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"020f757b5ae05b1d4a994e3495fc0b9fad7b181a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":662470851,"node_id":"MDU6TGFiZWw2NjI0NzA4NTE=","url":"https://api.github.com/repos/qbittorrent/qBittorrent/labels/Core","name":"Core","color":"111111","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls/9481/commits","review_comments_url":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls/9481/comments","review_comment_url":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/qbittorrent/qBittorrent/issues/9481/comments","statuses_url":"https://api.github.com/repos/qbittorrent/qBittorrent/statuses/0af8ebacc4d05f4cc32712c51a07d2853c8a1aaf","head":{"label":"mj-p:master","ref":"master","sha":"0af8ebacc4d05f4cc32712c51a07d2853c8a1aaf","user":{"login":"mj-p","id":38722481,"node_id":"MDQ6VXNlcjM4NzIyNDgx","avatar_url":"https://avatars1.githubusercontent.com/u/38722481?v=4","gravatar_id":"","url":"https://api.github.com/users/mj-p","html_url":"https://github.com/mj-p","followers_url":"https://api.github.com/users/mj-p/followers","following_url":"https://api.github.com/users/mj-p/following{/other_user}","gists_url":"https://api.github.com/users/mj-p/gists{/gist_id}","starred_url":"https://api.github.com/users/mj-p/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mj-p/subscriptions","organizations_url":"https://api.github.com/users/mj-p/orgs","repos_url":"https://api.github.com/users/mj-p/repos","events_url":"https://api.github.com/users/mj-p/events{/privacy}","received_events_url":"https://api.github.com/users/mj-p/received_events","type":"User","site_admin":false},"repo":{"id":148306875,"node_id":"MDEwOlJlcG9zaXRvcnkxNDgzMDY4NzU=","name":"qBittorrent","full_name":"mj-p/qBittorrent","owner":{"login":"mj-p","id":38722481,"node_id":"MDQ6VXNlcjM4NzIyNDgx","avatar_url":"https://avatars1.githubusercontent.com/u/38722481?v=4","gravatar_id":"","url":"https://api.github.com/users/mj-p","html_url":"https://github.com/mj-p","followers_url":"https://api.github.com/users/mj-p/followers","following_url":"https://api.github.com/users/mj-p/following{/other_user}","gists_url":"https://api.github.com/users/mj-p/gists{/gist_id}","starred_url":"https://api.github.com/users/mj-p/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mj-p/subscriptions","organizations_url":"https://api.github.com/users/mj-p/orgs","repos_url":"https://api.github.com/users/mj-p/repos","events_url":"https://api.github.com/users/mj-p/events{/privacy}","received_events_url":"https://api.github.com/users/mj-p/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mj-p/qBittorrent","description":"qBittorrent BitTorrent client","fork":true,"url":"https://api.github.com/repos/mj-p/qBittorrent","forks_url":"https://api.github.com/repos/mj-p/qBittorrent/forks","keys_url":"https://api.github.com/repos/mj-p/qBittorrent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mj-p/qBittorrent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mj-p/qBittorrent/teams","hooks_url":"https://api.github.com/repos/mj-p/qBittorrent/hooks","issue_events_url":"https://api.github.com/repos/mj-p/qBittorrent/issues/events{/number}","events_url":"https://api.github.com/repos/mj-p/qBittorrent/events","assignees_url":"https://api.github.com/repos/mj-p/qBittorrent/assignees{/user}","branches_url":"https://api.github.com/repos/mj-p/qBittorrent/branches{/branch}","tags_url":"https://api.github.com/repos/mj-p/qBittorrent/tags","blobs_url":"https://api.github.com/repos/mj-p/qBittorrent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mj-p/qBittorrent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mj-p/qBittorrent/git/refs{/sha}","trees_url":"https://api.github.com/repos/mj-p/qBittorrent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mj-p/qBittorrent/statuses/{sha}","languages_url":"https://api.github.com/repos/mj-p/qBittorrent/languages","stargazers_url":"https://api.github.com/repos/mj-p/qBittorrent/stargazers","contributors_url":"https://api.github.com/repos/mj-p/qBittorrent/contributors","subscribers_url":"https://api.github.com/repos/mj-p/qBittorrent/subscribers","subscription_url":"https://api.github.com/repos/mj-p/qBittorrent/subscription","commits_url":"https://api.github.com/repos/mj-p/qBittorrent/commits{/sha}","git_commits_url":"https://api.github.com/repos/mj-p/qBittorrent/git/commits{/sha}","comments_url":"https://api.github.com/repos/mj-p/qBittorrent/comments{/number}","issue_comment_url":"https://api.github.com/repos/mj-p/qBittorrent/issues/comments{/number}","contents_url":"https://api.github.com/repos/mj-p/qBittorrent/contents/{+path}","compare_url":"https://api.github.com/repos/mj-p/qBittorrent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mj-p/qBittorrent/merges","archive_url":"https://api.github.com/repos/mj-p/qBittorrent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mj-p/qBittorrent/downloads","issues_url":"https://api.github.com/repos/mj-p/qBittorrent/issues{/number}","pulls_url":"https://api.github.com/repos/mj-p/qBittorrent/pulls{/number}","milestones_url":"https://api.github.com/repos/mj-p/qBittorrent/milestones{/number}","notifications_url":"https://api.github.com/repos/mj-p/qBittorrent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mj-p/qBittorrent/labels{/name}","releases_url":"https://api.github.com/repos/mj-p/qBittorrent/releases{/id}","deployments_url":"https://api.github.com/repos/mj-p/qBittorrent/deployments","created_at":"2018-09-11T11:29:21Z","updated_at":"2018-09-11T11:47:36Z","pushed_at":"2018-09-11T11:47:35Z","git_url":"git://github.com/mj-p/qBittorrent.git","ssh_url":"git@github.com:mj-p/qBittorrent.git","clone_url":"https://github.com/mj-p/qBittorrent.git","svn_url":"https://github.com/mj-p/qBittorrent","homepage":"https://www.qbittorrent.org","size":166235,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"qbittorrent:master","ref":"master","sha":"bfb1210c43850db001e3e8a497d38929a1266186","user":{"login":"qbittorrent","id":2131270,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMzEyNzA=","avatar_url":"https://avatars2.githubusercontent.com/u/2131270?v=4","gravatar_id":"","url":"https://api.github.com/users/qbittorrent","html_url":"https://github.com/qbittorrent","followers_url":"https://api.github.com/users/qbittorrent/followers","following_url":"https://api.github.com/users/qbittorrent/following{/other_user}","gists_url":"https://api.github.com/users/qbittorrent/gists{/gist_id}","starred_url":"https://api.github.com/users/qbittorrent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qbittorrent/subscriptions","organizations_url":"https://api.github.com/users/qbittorrent/orgs","repos_url":"https://api.github.com/users/qbittorrent/repos","events_url":"https://api.github.com/users/qbittorrent/events{/privacy}","received_events_url":"https://api.github.com/users/qbittorrent/received_events","type":"Organization","site_admin":false},"repo":{"id":3351871,"node_id":"MDEwOlJlcG9zaXRvcnkzMzUxODcx","name":"qBittorrent","full_name":"qbittorrent/qBittorrent","owner":{"login":"qbittorrent","id":2131270,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMzEyNzA=","avatar_url":"https://avatars2.githubusercontent.com/u/2131270?v=4","gravatar_id":"","url":"https://api.github.com/users/qbittorrent","html_url":"https://github.com/qbittorrent","followers_url":"https://api.github.com/users/qbittorrent/followers","following_url":"https://api.github.com/users/qbittorrent/following{/other_user}","gists_url":"https://api.github.com/users/qbittorrent/gists{/gist_id}","starred_url":"https://api.github.com/users/qbittorrent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qbittorrent/subscriptions","organizations_url":"https://api.github.com/users/qbittorrent/orgs","repos_url":"https://api.github.com/users/qbittorrent/repos","events_url":"https://api.github.com/users/qbittorrent/events{/privacy}","received_events_url":"https://api.github.com/users/qbittorrent/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/qbittorrent/qBittorrent","description":"qBittorrent BitTorrent client","fork":false,"url":"https://api.github.com/repos/qbittorrent/qBittorrent","forks_url":"https://api.github.com/repos/qbittorrent/qBittorrent/forks","keys_url":"https://api.github.com/repos/qbittorrent/qBittorrent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qbittorrent/qBittorrent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qbittorrent/qBittorrent/teams","hooks_url":"https://api.github.com/repos/qbittorrent/qBittorrent/hooks","issue_events_url":"https://api.github.com/repos/qbittorrent/qBittorrent/issues/events{/number}","events_url":"https://api.github.com/repos/qbittorrent/qBittorrent/events","assignees_url":"https://api.github.com/repos/qbittorrent/qBittorrent/assignees{/user}","branches_url":"https://api.github.com/repos/qbittorrent/qBittorrent/branches{/branch}","tags_url":"https://api.github.com/repos/qbittorrent/qBittorrent/tags","blobs_url":"https://api.github.com/repos/qbittorrent/qBittorrent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qbittorrent/qBittorrent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qbittorrent/qBittorrent/git/refs{/sha}","trees_url":"https://api.github.com/repos/qbittorrent/qBittorrent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qbittorrent/qBittorrent/statuses/{sha}","languages_url":"https://api.github.com/repos/qbittorrent/qBittorrent/languages","stargazers_url":"https://api.github.com/repos/qbittorrent/qBittorrent/stargazers","contributors_url":"https://api.github.com/repos/qbittorrent/qBittorrent/contributors","subscribers_url":"https://api.github.com/repos/qbittorrent/qBittorrent/subscribers","subscription_url":"https://api.github.com/repos/qbittorrent/qBittorrent/subscription","commits_url":"https://api.github.com/repos/qbittorrent/qBittorrent/commits{/sha}","git_commits_url":"https://api.github.com/repos/qbittorrent/qBittorrent/git/commits{/sha}","comments_url":"https://api.github.com/repos/qbittorrent/qBittorrent/comments{/number}","issue_comment_url":"https://api.github.com/repos/qbittorrent/qBittorrent/issues/comments{/number}","contents_url":"https://api.github.com/repos/qbittorrent/qBittorrent/contents/{+path}","compare_url":"https://api.github.com/repos/qbittorrent/qBittorrent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qbittorrent/qBittorrent/merges","archive_url":"https://api.github.com/repos/qbittorrent/qBittorrent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qbittorrent/qBittorrent/downloads","issues_url":"https://api.github.com/repos/qbittorrent/qBittorrent/issues{/number}","pulls_url":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls{/number}","milestones_url":"https://api.github.com/repos/qbittorrent/qBittorrent/milestones{/number}","notifications_url":"https://api.github.com/repos/qbittorrent/qBittorrent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qbittorrent/qBittorrent/labels{/name}","releases_url":"https://api.github.com/repos/qbittorrent/qBittorrent/releases{/id}","deployments_url":"https://api.github.com/repos/qbittorrent/qBittorrent/deployments","created_at":"2012-02-04T09:37:46Z","updated_at":"2018-09-12T08:29:41Z","pushed_at":"2018-09-12T08:29:28Z","git_url":"git://github.com/qbittorrent/qBittorrent.git","ssh_url":"git@github.com:qbittorrent/qBittorrent.git","clone_url":"https://github.com/qbittorrent/qBittorrent.git","svn_url":"https://github.com/qbittorrent/qBittorrent","homepage":"https://www.qbittorrent.org","size":166247,"stargazers_count":4900,"watchers_count":4900,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":887,"mirror_url":null,"archived":false,"open_issues_count":2959,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":887,"open_issues":2959,"watchers":4900,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls/9481"},"html":{"href":"https://github.com/qbittorrent/qBittorrent/pull/9481"},"issue":{"href":"https://api.github.com/repos/qbittorrent/qBittorrent/issues/9481"},"comments":{"href":"https://api.github.com/repos/qbittorrent/qBittorrent/issues/9481/comments"},"review_comments":{"href":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls/9481/comments"},"review_comment":{"href":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls/9481/commits"},"statuses":{"href":"https://api.github.com/repos/qbittorrent/qBittorrent/statuses/0af8ebacc4d05f4cc32712c51a07d2853c8a1aaf"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"glassez"}}