{"action":"created","issue":{"url":"https://api.github.com/repos/reefangel/Libraries/issues/246","repository_url":"https://api.github.com/repos/reefangel/Libraries","labels_url":"https://api.github.com/repos/reefangel/Libraries/issues/246/labels{/name}","comments_url":"https://api.github.com/repos/reefangel/Libraries/issues/246/comments","events_url":"https://api.github.com/repos/reefangel/Libraries/issues/246/events","html_url":"https://github.com/reefangel/Libraries/issues/246","id":383918879,"node_id":"MDU6SXNzdWUzODM5MTg4Nzk=","number":246,"title":"SunLocation not setting memory correctly","user":{"login":"lnevo","id":2120894,"node_id":"MDQ6VXNlcjIxMjA4OTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/2120894?v=4","gravatar_id":"","url":"https://api.github.com/users/lnevo","html_url":"https://github.com/lnevo","followers_url":"https://api.github.com/users/lnevo/followers","following_url":"https://api.github.com/users/lnevo/following{/other_user}","gists_url":"https://api.github.com/users/lnevo/gists{/gist_id}","starred_url":"https://api.github.com/users/lnevo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lnevo/subscriptions","organizations_url":"https://api.github.com/users/lnevo/orgs","repos_url":"https://api.github.com/users/lnevo/repos","events_url":"https://api.github.com/users/lnevo/events{/privacy}","received_events_url":"https://api.github.com/users/lnevo/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-11-23T20:07:06Z","updated_at":"2018-11-25T06:38:21Z","closed_at":"2018-11-23T23:38:04Z","author_association":"CONTRIBUTOR","body":"There is an issue when adjusting the StdLightsOn and StdLightsOff memory locations to adjust for the actinic offset. \r\n\r\nIf we cross the midnight threshold and then subtract the ActinicOffset value, it may become a negative number and wrap around causing a bad time to be set in the memory location and messing up the lighting schedule. \r\n\r\nPull request https://github.com/reefangel/Libraries/pull/245 has been submitted to address this. "},"comment":{"url":"https://api.github.com/repos/reefangel/Libraries/issues/comments/441419080","html_url":"https://github.com/reefangel/Libraries/issues/246#issuecomment-441419080","issue_url":"https://api.github.com/repos/reefangel/Libraries/issues/246","id":441419080,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MTQxOTA4MA==","user":{"login":"lnevo","id":2120894,"node_id":"MDQ6VXNlcjIxMjA4OTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/2120894?v=4","gravatar_id":"","url":"https://api.github.com/users/lnevo","html_url":"https://github.com/lnevo","followers_url":"https://api.github.com/users/lnevo/followers","following_url":"https://api.github.com/users/lnevo/following{/other_user}","gists_url":"https://api.github.com/users/lnevo/gists{/gist_id}","starred_url":"https://api.github.com/users/lnevo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lnevo/subscriptions","organizations_url":"https://api.github.com/users/lnevo/orgs","repos_url":"https://api.github.com/users/lnevo/repos","events_url":"https://api.github.com/users/lnevo/events{/privacy}","received_events_url":"https://api.github.com/users/lnevo/received_events","type":"User","site_admin":false},"created_at":"2018-11-25T06:38:21Z","updated_at":"2018-11-25T06:38:21Z","author_association":"CONTRIBUTOR","body":"It looks like we are having the same issue in the RA_PWM library calls as well. \n\nIf End time crosses midnight and the offset subtracts more minutes than will have elapsed, we’ll go negative for the value and not get the right hour / minute. \n\nThere’s a LOT of the exact same code in a lot of functions calculating the onTime / offTime…\n\nI’ll open a new issue.\n\n> On Nov 23, 2018, at 6:38 PM, Roberto Imai <notifications@github.com> wrote:\n> \n> Closed #246 <https://github.com/reefangel/Libraries/issues/246>.\n> \n> —\n> You are receiving this because you authored the thread.\n> Reply to this email directly, view it on GitHub <https://github.com/reefangel/Libraries/issues/246#event-1984789488>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACBcvuLLtevT_XYnzUcgmhlTD1tSESpWks5uyIbdgaJpZM4YxFX4>.\n> \n\n"}}
{"actor":{"display_login":"lnevo"}}