{"action":"created","comment":{"url":"https://api.github.com/repos/zero-os/0-stor/pulls/comments/165984936","pull_request_review_id":94004767,"id":165984936,"diff_hunk":"@@ -0,0 +1,28 @@\n+benchmarks:","path":"benchmark/benchmarks_local/datashards_vs_metashards/read_bench.yaml","position":1,"original_position":1,"commit_id":"69079ad315cd0293bba7211aeb68b67dace23e2c","original_commit_id":"69079ad315cd0293bba7211aeb68b67dace23e2c","user":{"login":"GlenDC","id":3900482,"avatar_url":"https://avatars2.githubusercontent.com/u/3900482?v=4","gravatar_id":"","url":"https://api.github.com/users/GlenDC","html_url":"https://github.com/GlenDC","followers_url":"https://api.github.com/users/GlenDC/followers","following_url":"https://api.github.com/users/GlenDC/following{/other_user}","gists_url":"https://api.github.com/users/GlenDC/gists{/gist_id}","starred_url":"https://api.github.com/users/GlenDC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GlenDC/subscriptions","organizations_url":"https://api.github.com/users/GlenDC/orgs","repos_url":"https://api.github.com/users/GlenDC/repos","events_url":"https://api.github.com/users/GlenDC/events{/privacy}","received_events_url":"https://api.github.com/users/GlenDC/received_events","type":"User","site_admin":false},"body":"I guess that's a failure in the bench config to not be able to handle this in sync?","created_at":"2018-02-05T14:23:44Z","updated_at":"2018-02-05T14:23:44Z","html_url":"https://github.com/zero-os/0-stor/pull/497#discussion_r165984936","pull_request_url":"https://api.github.com/repos/zero-os/0-stor/pulls/497","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/zero-os/0-stor/pulls/comments/165984936"},"html":{"href":"https://github.com/zero-os/0-stor/pull/497#discussion_r165984936"},"pull_request":{"href":"https://api.github.com/repos/zero-os/0-stor/pulls/497"}},"in_reply_to_id":165982937},"pull_request":{"url":"https://api.github.com/repos/zero-os/0-stor/pulls/497","id":166258319,"html_url":"https://github.com/zero-os/0-stor/pull/497","diff_url":"https://github.com/zero-os/0-stor/pull/497.diff","patch_url":"https://github.com/zero-os/0-stor/pull/497.patch","issue_url":"https://api.github.com/repos/zero-os/0-stor/issues/497","number":497,"state":"open","locked":false,"title":"Adds proposal for benchmark configs","user":{"login":"chrisvdg","id":23582741,"avatar_url":"https://avatars3.githubusercontent.com/u/23582741?v=4","gravatar_id":"","url":"https://api.github.com/users/chrisvdg","html_url":"https://github.com/chrisvdg","followers_url":"https://api.github.com/users/chrisvdg/followers","following_url":"https://api.github.com/users/chrisvdg/following{/other_user}","gists_url":"https://api.github.com/users/chrisvdg/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisvdg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisvdg/subscriptions","organizations_url":"https://api.github.com/users/chrisvdg/orgs","repos_url":"https://api.github.com/users/chrisvdg/repos","events_url":"https://api.github.com/users/chrisvdg/events{/privacy}","received_events_url":"https://api.github.com/users/chrisvdg/received_events","type":"User","site_admin":false},"body":"Proposal of benchmark configs for beta2\r\nResults of the proposal ran locally can be found here:\r\nhttps://github.com/chrisvdg/0-stor/tree/1.1.0-beta-2-benchmarked/benchmark/benchmarks_local\r\nhttps://github.com/chrisvdg/0-stor/tree/1.1.0-beta-2-benchmarked/benchmark/profiling_local","created_at":"2018-01-31T13:23:49Z","updated_at":"2018-02-05T14:23:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b5e2ef81e7645ddb884d26c72ed3eeeb72021067","assignee":{"login":"chrisvdg","id":23582741,"avatar_url":"https://avatars3.githubusercontent.com/u/23582741?v=4","gravatar_id":"","url":"https://api.github.com/users/chrisvdg","html_url":"https://github.com/chrisvdg","followers_url":"https://api.github.com/users/chrisvdg/followers","following_url":"https://api.github.com/users/chrisvdg/following{/other_user}","gists_url":"https://api.github.com/users/chrisvdg/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisvdg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisvdg/subscriptions","organizations_url":"https://api.github.com/users/chrisvdg/orgs","repos_url":"https://api.github.com/users/chrisvdg/repos","events_url":"https://api.github.com/users/chrisvdg/events{/privacy}","received_events_url":"https://api.github.com/users/chrisvdg/received_events","type":"User","site_admin":false},"assignees":[{"login":"chrisvdg","id":23582741,"avatar_url":"https://avatars3.githubusercontent.com/u/23582741?v=4","gravatar_id":"","url":"https://api.github.com/users/chrisvdg","html_url":"https://github.com/chrisvdg","followers_url":"https://api.github.com/users/chrisvdg/followers","following_url":"https://api.github.com/users/chrisvdg/following{/other_user}","gists_url":"https://api.github.com/users/chrisvdg/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisvdg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisvdg/subscriptions","organizations_url":"https://api.github.com/users/chrisvdg/orgs","repos_url":"https://api.github.com/users/chrisvdg/repos","events_url":"https://api.github.com/users/chrisvdg/events{/privacy}","received_events_url":"https://api.github.com/users/chrisvdg/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/zero-os/0-stor/pulls/497/commits","review_comments_url":"https://api.github.com/repos/zero-os/0-stor/pulls/497/comments","review_comment_url":"https://api.github.com/repos/zero-os/0-stor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zero-os/0-stor/issues/497/comments","statuses_url":"https://api.github.com/repos/zero-os/0-stor/statuses/69079ad315cd0293bba7211aeb68b67dace23e2c","head":{"label":"zero-os:benchmark-configs-beta2","ref":"benchmark-configs-beta2","sha":"69079ad315cd0293bba7211aeb68b67dace23e2c","user":{"login":"zero-os","id":29012647,"avatar_url":"https://avatars0.githubusercontent.com/u/29012647?v=4","gravatar_id":"","url":"https://api.github.com/users/zero-os","html_url":"https://github.com/zero-os","followers_url":"https://api.github.com/users/zero-os/followers","following_url":"https://api.github.com/users/zero-os/following{/other_user}","gists_url":"https://api.github.com/users/zero-os/gists{/gist_id}","starred_url":"https://api.github.com/users/zero-os/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zero-os/subscriptions","organizations_url":"https://api.github.com/users/zero-os/orgs","repos_url":"https://api.github.com/users/zero-os/repos","events_url":"https://api.github.com/users/zero-os/events{/privacy}","received_events_url":"https://api.github.com/users/zero-os/received_events","type":"Organization","site_admin":false},"repo":{"id":91236213,"name":"0-stor","full_name":"zero-os/0-stor","owner":{"login":"zero-os","id":29012647,"avatar_url":"https://avatars0.githubusercontent.com/u/29012647?v=4","gravatar_id":"","url":"https://api.github.com/users/zero-os","html_url":"https://github.com/zero-os","followers_url":"https://api.github.com/users/zero-os/followers","following_url":"https://api.github.com/users/zero-os/following{/other_user}","gists_url":"https://api.github.com/users/zero-os/gists{/gist_id}","starred_url":"https://api.github.com/users/zero-os/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zero-os/subscriptions","organizations_url":"https://api.github.com/users/zero-os/orgs","repos_url":"https://api.github.com/users/zero-os/repos","events_url":"https://api.github.com/users/zero-os/events{/privacy}","received_events_url":"https://api.github.com/users/zero-os/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zero-os/0-stor","description":"Single device object store","fork":false,"url":"https://api.github.com/repos/zero-os/0-stor","forks_url":"https://api.github.com/repos/zero-os/0-stor/forks","keys_url":"https://api.github.com/repos/zero-os/0-stor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zero-os/0-stor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zero-os/0-stor/teams","hooks_url":"https://api.github.com/repos/zero-os/0-stor/hooks","issue_events_url":"https://api.github.com/repos/zero-os/0-stor/issues/events{/number}","events_url":"https://api.github.com/repos/zero-os/0-stor/events","assignees_url":"https://api.github.com/repos/zero-os/0-stor/assignees{/user}","branches_url":"https://api.github.com/repos/zero-os/0-stor/branches{/branch}","tags_url":"https://api.github.com/repos/zero-os/0-stor/tags","blobs_url":"https://api.github.com/repos/zero-os/0-stor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zero-os/0-stor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zero-os/0-stor/git/refs{/sha}","trees_url":"https://api.github.com/repos/zero-os/0-stor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zero-os/0-stor/statuses/{sha}","languages_url":"https://api.github.com/repos/zero-os/0-stor/languages","stargazers_url":"https://api.github.com/repos/zero-os/0-stor/stargazers","contributors_url":"https://api.github.com/repos/zero-os/0-stor/contributors","subscribers_url":"https://api.github.com/repos/zero-os/0-stor/subscribers","subscription_url":"https://api.github.com/repos/zero-os/0-stor/subscription","commits_url":"https://api.github.com/repos/zero-os/0-stor/commits{/sha}","git_commits_url":"https://api.github.com/repos/zero-os/0-stor/git/commits{/sha}","comments_url":"https://api.github.com/repos/zero-os/0-stor/comments{/number}","issue_comment_url":"https://api.github.com/repos/zero-os/0-stor/issues/comments{/number}","contents_url":"https://api.github.com/repos/zero-os/0-stor/contents/{+path}","compare_url":"https://api.github.com/repos/zero-os/0-stor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zero-os/0-stor/merges","archive_url":"https://api.github.com/repos/zero-os/0-stor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zero-os/0-stor/downloads","issues_url":"https://api.github.com/repos/zero-os/0-stor/issues{/number}","pulls_url":"https://api.github.com/repos/zero-os/0-stor/pulls{/number}","milestones_url":"https://api.github.com/repos/zero-os/0-stor/milestones{/number}","notifications_url":"https://api.github.com/repos/zero-os/0-stor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zero-os/0-stor/labels{/name}","releases_url":"https://api.github.com/repos/zero-os/0-stor/releases{/id}","deployments_url":"https://api.github.com/repos/zero-os/0-stor/deployments","created_at":"2017-05-14T10:33:38Z","updated_at":"2018-01-25T05:31:27Z","pushed_at":"2018-02-05T11:09:27Z","git_url":"git://github.com/zero-os/0-stor.git","ssh_url":"git@github.com:zero-os/0-stor.git","clone_url":"https://github.com/zero-os/0-stor.git","svn_url":"https://github.com/zero-os/0-stor","homepage":"","size":41846,"stargazers_count":13,"watchers_count":13,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":33,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":6,"open_issues":33,"watchers":13,"default_branch":"master"}},"base":{"label":"zero-os:1.1.0-beta-2","ref":"1.1.0-beta-2","sha":"378d72bc02171d4ffe6fe9bc711b6d072c1b00ba","user":{"login":"zero-os","id":29012647,"avatar_url":"https://avatars0.githubusercontent.com/u/29012647?v=4","gravatar_id":"","url":"https://api.github.com/users/zero-os","html_url":"https://github.com/zero-os","followers_url":"https://api.github.com/users/zero-os/followers","following_url":"https://api.github.com/users/zero-os/following{/other_user}","gists_url":"https://api.github.com/users/zero-os/gists{/gist_id}","starred_url":"https://api.github.com/users/zero-os/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zero-os/subscriptions","organizations_url":"https://api.github.com/users/zero-os/orgs","repos_url":"https://api.github.com/users/zero-os/repos","events_url":"https://api.github.com/users/zero-os/events{/privacy}","received_events_url":"https://api.github.com/users/zero-os/received_events","type":"Organization","site_admin":false},"repo":{"id":91236213,"name":"0-stor","full_name":"zero-os/0-stor","owner":{"login":"zero-os","id":29012647,"avatar_url":"https://avatars0.githubusercontent.com/u/29012647?v=4","gravatar_id":"","url":"https://api.github.com/users/zero-os","html_url":"https://github.com/zero-os","followers_url":"https://api.github.com/users/zero-os/followers","following_url":"https://api.github.com/users/zero-os/following{/other_user}","gists_url":"https://api.github.com/users/zero-os/gists{/gist_id}","starred_url":"https://api.github.com/users/zero-os/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zero-os/subscriptions","organizations_url":"https://api.github.com/users/zero-os/orgs","repos_url":"https://api.github.com/users/zero-os/repos","events_url":"https://api.github.com/users/zero-os/events{/privacy}","received_events_url":"https://api.github.com/users/zero-os/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zero-os/0-stor","description":"Single device object store","fork":false,"url":"https://api.github.com/repos/zero-os/0-stor","forks_url":"https://api.github.com/repos/zero-os/0-stor/forks","keys_url":"https://api.github.com/repos/zero-os/0-stor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zero-os/0-stor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zero-os/0-stor/teams","hooks_url":"https://api.github.com/repos/zero-os/0-stor/hooks","issue_events_url":"https://api.github.com/repos/zero-os/0-stor/issues/events{/number}","events_url":"https://api.github.com/repos/zero-os/0-stor/events","assignees_url":"https://api.github.com/repos/zero-os/0-stor/assignees{/user}","branches_url":"https://api.github.com/repos/zero-os/0-stor/branches{/branch}","tags_url":"https://api.github.com/repos/zero-os/0-stor/tags","blobs_url":"https://api.github.com/repos/zero-os/0-stor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zero-os/0-stor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zero-os/0-stor/git/refs{/sha}","trees_url":"https://api.github.com/repos/zero-os/0-stor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zero-os/0-stor/statuses/{sha}","languages_url":"https://api.github.com/repos/zero-os/0-stor/languages","stargazers_url":"https://api.github.com/repos/zero-os/0-stor/stargazers","contributors_url":"https://api.github.com/repos/zero-os/0-stor/contributors","subscribers_url":"https://api.github.com/repos/zero-os/0-stor/subscribers","subscription_url":"https://api.github.com/repos/zero-os/0-stor/subscription","commits_url":"https://api.github.com/repos/zero-os/0-stor/commits{/sha}","git_commits_url":"https://api.github.com/repos/zero-os/0-stor/git/commits{/sha}","comments_url":"https://api.github.com/repos/zero-os/0-stor/comments{/number}","issue_comment_url":"https://api.github.com/repos/zero-os/0-stor/issues/comments{/number}","contents_url":"https://api.github.com/repos/zero-os/0-stor/contents/{+path}","compare_url":"https://api.github.com/repos/zero-os/0-stor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zero-os/0-stor/merges","archive_url":"https://api.github.com/repos/zero-os/0-stor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zero-os/0-stor/downloads","issues_url":"https://api.github.com/repos/zero-os/0-stor/issues{/number}","pulls_url":"https://api.github.com/repos/zero-os/0-stor/pulls{/number}","milestones_url":"https://api.github.com/repos/zero-os/0-stor/milestones{/number}","notifications_url":"https://api.github.com/repos/zero-os/0-stor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zero-os/0-stor/labels{/name}","releases_url":"https://api.github.com/repos/zero-os/0-stor/releases{/id}","deployments_url":"https://api.github.com/repos/zero-os/0-stor/deployments","created_at":"2017-05-14T10:33:38Z","updated_at":"2018-01-25T05:31:27Z","pushed_at":"2018-02-05T11:09:27Z","git_url":"git://github.com/zero-os/0-stor.git","ssh_url":"git@github.com:zero-os/0-stor.git","clone_url":"https://github.com/zero-os/0-stor.git","svn_url":"https://github.com/zero-os/0-stor","homepage":"","size":41846,"stargazers_count":13,"watchers_count":13,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":33,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":6,"open_issues":33,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zero-os/0-stor/pulls/497"},"html":{"href":"https://github.com/zero-os/0-stor/pull/497"},"issue":{"href":"https://api.github.com/repos/zero-os/0-stor/issues/497"},"comments":{"href":"https://api.github.com/repos/zero-os/0-stor/issues/497/comments"},"review_comments":{"href":"https://api.github.com/repos/zero-os/0-stor/pulls/497/comments"},"review_comment":{"href":"https://api.github.com/repos/zero-os/0-stor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zero-os/0-stor/pulls/497/commits"},"statuses":{"href":"https://api.github.com/repos/zero-os/0-stor/statuses/69079ad315cd0293bba7211aeb68b67dace23e2c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"GlenDC"}}