{"action":"created","comment":{"url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/pulls/comments/240244951","pull_request_review_id":183228963,"id":240244951,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MDI0NDk1MQ==","diff_hunk":"@@ -248,6 +248,9 @@ The table below illustrates how the selection is made:\n | X | fr | jp | en | fr |\n | it | fr | jp | en | it |\n \n+The translation service probes the browser culture first, for example `en-GB`.\n+If the `en-GB.json` files does not exist, the service falls back to the language id: `en`.","path":"docs/user-guide/internationalization.md","position":5,"original_position":5,"commit_id":"01bd3d3297b79bcc3fa9c3b9968832c6bf1a1522","original_commit_id":"01bd3d3297b79bcc3fa9c3b9968832c6bf1a1522","user":{"login":"therealandeeee","id":30621568,"node_id":"MDQ6VXNlcjMwNjIxNTY4","avatar_url":"https://avatars0.githubusercontent.com/u/30621568?v=4","gravatar_id":"","url":"https://api.github.com/users/therealandeeee","html_url":"https://github.com/therealandeeee","followers_url":"https://api.github.com/users/therealandeeee/followers","following_url":"https://api.github.com/users/therealandeeee/following{/other_user}","gists_url":"https://api.github.com/users/therealandeeee/gists{/gist_id}","starred_url":"https://api.github.com/users/therealandeeee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/therealandeeee/subscriptions","organizations_url":"https://api.github.com/users/therealandeeee/orgs","repos_url":"https://api.github.com/users/therealandeeee/repos","events_url":"https://api.github.com/users/therealandeeee/events{/privacy}","received_events_url":"https://api.github.com/users/therealandeeee/received_events","type":"User","site_admin":false},"body":"Should be \"en-GB.json *file* does not exist\" or \"en-GB.json files do not exist\".","created_at":"2018-12-10T15:03:49Z","updated_at":"2018-12-10T15:03:50Z","html_url":"https://github.com/Alfresco/alfresco-ng2-components/pull/4066#discussion_r240244951","pull_request_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/pulls/4066","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/pulls/comments/240244951"},"html":{"href":"https://github.com/Alfresco/alfresco-ng2-components/pull/4066#discussion_r240244951"},"pull_request":{"href":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/pulls/4066"}}},"pull_request":{"url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/pulls/4066","id":237347969,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3MzQ3OTY5","html_url":"https://github.com/Alfresco/alfresco-ng2-components/pull/4066","diff_url":"https://github.com/Alfresco/alfresco-ng2-components/pull/4066.diff","patch_url":"https://github.com/Alfresco/alfresco-ng2-components/pull/4066.patch","issue_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/issues/4066","number":4066,"state":"open","locked":false,"title":"[ADF-3784] support for browser cultures (i18n)","user":{"login":"DenysVuika","id":503991,"node_id":"MDQ6VXNlcjUwMzk5MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/503991?v=4","gravatar_id":"","url":"https://api.github.com/users/DenysVuika","html_url":"https://github.com/DenysVuika","followers_url":"https://api.github.com/users/DenysVuika/followers","following_url":"https://api.github.com/users/DenysVuika/following{/other_user}","gists_url":"https://api.github.com/users/DenysVuika/gists{/gist_id}","starred_url":"https://api.github.com/users/DenysVuika/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DenysVuika/subscriptions","organizations_url":"https://api.github.com/users/DenysVuika/orgs","repos_url":"https://api.github.com/users/DenysVuika/repos","events_url":"https://api.github.com/users/DenysVuika/events{/privacy}","received_events_url":"https://api.github.com/users/DenysVuika/received_events","type":"User","site_admin":false},"body":"**Please check if the PR fulfills these requirements**\r\n\r\n> - [x] The commit message follows our [guidelines](https://github.com/Alfresco/alfresco-ng2-components/wiki/Commit-format)\r\n> - [ ] Tests for the changes have been added (for bug fixes / features)\r\n> - [x] Docs have been added / updated (for bug fixes / features)\r\n\r\n<!--\r\n Before submitting your PR, please check that your code follows our contribution guidelines:\r\n https://github.com/Alfresco/alfresco-ng2-components/wiki/Code-contribution-acceptance-criteria\r\n -->\r\n\r\n**What kind of change does this PR introduce?** (check one with \"x\")\r\n\r\n> - [x] Bugfix\r\n> - [x] Feature\r\n> - [ ] Code style update (formatting, local variables)\r\n> - [ ] Refactoring (no functional changes, no api changes)\r\n> - [ ] Build related changes\r\n> - [ ] Documentation\r\n> - [ ] Other... Please describe:\r\n\r\n\r\n**What is the current behaviour?** (You can also link to an open issue here)\r\n\r\nBrowser cultures are not supported (i.e. `pt-BR` or `zh-CN`)\r\n\r\n**What is the new behaviour?**\r\n\r\n- support browser cultures\r\n- fallback to the language ids when missing culture-based translations\r\n\r\n**Does this PR introduce a breaking change?** (check one with \"x\")\r\n\r\n> - [ ] Yes\r\n> - [x] No\r\n\r\n\r\nIf this PR contains a breaking change, please describe the impact and migration path for existing applications: ...\r\n\r\n**Other information**:\r\n","created_at":"2018-12-10T14:52:43Z","updated_at":"2018-12-10T15:03:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"de79881f11c093bdefb5c4e50b94a83b65f88523","assignee":null,"assignees":[],"requested_reviewers":[{"login":"eromano","id":1030050,"node_id":"MDQ6VXNlcjEwMzAwNTA=","avatar_url":"https://avatars1.githubusercontent.com/u/1030050?v=4","gravatar_id":"","url":"https://api.github.com/users/eromano","html_url":"https://github.com/eromano","followers_url":"https://api.github.com/users/eromano/followers","following_url":"https://api.github.com/users/eromano/following{/other_user}","gists_url":"https://api.github.com/users/eromano/gists{/gist_id}","starred_url":"https://api.github.com/users/eromano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eromano/subscriptions","organizations_url":"https://api.github.com/users/eromano/orgs","repos_url":"https://api.github.com/users/eromano/repos","events_url":"https://api.github.com/users/eromano/events{/privacy}","received_events_url":"https://api.github.com/users/eromano/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/pulls/4066/commits","review_comments_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/pulls/4066/comments","review_comment_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/issues/4066/comments","statuses_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/statuses/01bd3d3297b79bcc3fa9c3b9968832c6bf1a1522","head":{"label":"Alfresco:denys-i18n-cultures","ref":"denys-i18n-cultures","sha":"01bd3d3297b79bcc3fa9c3b9968832c6bf1a1522","user":{"login":"Alfresco","id":391127,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MTEyNw==","avatar_url":"https://avatars2.githubusercontent.com/u/391127?v=4","gravatar_id":"","url":"https://api.github.com/users/Alfresco","html_url":"https://github.com/Alfresco","followers_url":"https://api.github.com/users/Alfresco/followers","following_url":"https://api.github.com/users/Alfresco/following{/other_user}","gists_url":"https://api.github.com/users/Alfresco/gists{/gist_id}","starred_url":"https://api.github.com/users/Alfresco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alfresco/subscriptions","organizations_url":"https://api.github.com/users/Alfresco/orgs","repos_url":"https://api.github.com/users/Alfresco/repos","events_url":"https://api.github.com/users/Alfresco/events{/privacy}","received_events_url":"https://api.github.com/users/Alfresco/received_events","type":"Organization","site_admin":false},"repo":{"id":55400726,"node_id":"MDEwOlJlcG9zaXRvcnk1NTQwMDcyNg==","name":"alfresco-ng2-components","full_name":"Alfresco/alfresco-ng2-components","private":false,"owner":{"login":"Alfresco","id":391127,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MTEyNw==","avatar_url":"https://avatars2.githubusercontent.com/u/391127?v=4","gravatar_id":"","url":"https://api.github.com/users/Alfresco","html_url":"https://github.com/Alfresco","followers_url":"https://api.github.com/users/Alfresco/followers","following_url":"https://api.github.com/users/Alfresco/following{/other_user}","gists_url":"https://api.github.com/users/Alfresco/gists{/gist_id}","starred_url":"https://api.github.com/users/Alfresco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alfresco/subscriptions","organizations_url":"https://api.github.com/users/Alfresco/orgs","repos_url":"https://api.github.com/users/Alfresco/repos","events_url":"https://api.github.com/users/Alfresco/events{/privacy}","received_events_url":"https://api.github.com/users/Alfresco/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Alfresco/alfresco-ng2-components","description":"Alfresco Angular Components","fork":false,"url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components","forks_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/forks","keys_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/teams","hooks_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/hooks","issue_events_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/issues/events{/number}","events_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/events","assignees_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/assignees{/user}","branches_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/branches{/branch}","tags_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/tags","blobs_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/statuses/{sha}","languages_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/languages","stargazers_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/stargazers","contributors_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/contributors","subscribers_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/subscribers","subscription_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/subscription","commits_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/issues/comments{/number}","contents_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/contents/{+path}","compare_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/merges","archive_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/downloads","issues_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/issues{/number}","pulls_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/pulls{/number}","milestones_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/milestones{/number}","notifications_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/labels{/name}","releases_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/releases{/id}","deployments_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/deployments","created_at":"2016-04-04T09:54:25Z","updated_at":"2018-12-10T14:22:53Z","pushed_at":"2018-12-10T14:52:44Z","git_url":"git://github.com/Alfresco/alfresco-ng2-components.git","ssh_url":"git@github.com:Alfresco/alfresco-ng2-components.git","clone_url":"https://github.com/Alfresco/alfresco-ng2-components.git","svn_url":"https://github.com/Alfresco/alfresco-ng2-components","homepage":"https://alfresco.github.io/adf-component-catalog/","size":406592,"stargazers_count":189,"watchers_count":189,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":104,"mirror_url":null,"archived":false,"open_issues_count":66,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":104,"open_issues":66,"watchers":189,"default_branch":"development"}},"base":{"label":"Alfresco:development","ref":"development","sha":"4ad3e162a7a84589954010c61aa52ae49ec1b1f5","user":{"login":"Alfresco","id":391127,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MTEyNw==","avatar_url":"https://avatars2.githubusercontent.com/u/391127?v=4","gravatar_id":"","url":"https://api.github.com/users/Alfresco","html_url":"https://github.com/Alfresco","followers_url":"https://api.github.com/users/Alfresco/followers","following_url":"https://api.github.com/users/Alfresco/following{/other_user}","gists_url":"https://api.github.com/users/Alfresco/gists{/gist_id}","starred_url":"https://api.github.com/users/Alfresco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alfresco/subscriptions","organizations_url":"https://api.github.com/users/Alfresco/orgs","repos_url":"https://api.github.com/users/Alfresco/repos","events_url":"https://api.github.com/users/Alfresco/events{/privacy}","received_events_url":"https://api.github.com/users/Alfresco/received_events","type":"Organization","site_admin":false},"repo":{"id":55400726,"node_id":"MDEwOlJlcG9zaXRvcnk1NTQwMDcyNg==","name":"alfresco-ng2-components","full_name":"Alfresco/alfresco-ng2-components","private":false,"owner":{"login":"Alfresco","id":391127,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MTEyNw==","avatar_url":"https://avatars2.githubusercontent.com/u/391127?v=4","gravatar_id":"","url":"https://api.github.com/users/Alfresco","html_url":"https://github.com/Alfresco","followers_url":"https://api.github.com/users/Alfresco/followers","following_url":"https://api.github.com/users/Alfresco/following{/other_user}","gists_url":"https://api.github.com/users/Alfresco/gists{/gist_id}","starred_url":"https://api.github.com/users/Alfresco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alfresco/subscriptions","organizations_url":"https://api.github.com/users/Alfresco/orgs","repos_url":"https://api.github.com/users/Alfresco/repos","events_url":"https://api.github.com/users/Alfresco/events{/privacy}","received_events_url":"https://api.github.com/users/Alfresco/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Alfresco/alfresco-ng2-components","description":"Alfresco Angular Components","fork":false,"url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components","forks_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/forks","keys_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/teams","hooks_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/hooks","issue_events_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/issues/events{/number}","events_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/events","assignees_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/assignees{/user}","branches_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/branches{/branch}","tags_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/tags","blobs_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/statuses/{sha}","languages_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/languages","stargazers_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/stargazers","contributors_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/contributors","subscribers_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/subscribers","subscription_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/subscription","commits_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/issues/comments{/number}","contents_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/contents/{+path}","compare_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/merges","archive_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/downloads","issues_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/issues{/number}","pulls_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/pulls{/number}","milestones_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/milestones{/number}","notifications_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/labels{/name}","releases_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/releases{/id}","deployments_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/deployments","created_at":"2016-04-04T09:54:25Z","updated_at":"2018-12-10T14:22:53Z","pushed_at":"2018-12-10T14:52:44Z","git_url":"git://github.com/Alfresco/alfresco-ng2-components.git","ssh_url":"git@github.com:Alfresco/alfresco-ng2-components.git","clone_url":"https://github.com/Alfresco/alfresco-ng2-components.git","svn_url":"https://github.com/Alfresco/alfresco-ng2-components","homepage":"https://alfresco.github.io/adf-component-catalog/","size":406592,"stargazers_count":189,"watchers_count":189,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":104,"mirror_url":null,"archived":false,"open_issues_count":66,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":104,"open_issues":66,"watchers":189,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/pulls/4066"},"html":{"href":"https://github.com/Alfresco/alfresco-ng2-components/pull/4066"},"issue":{"href":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/issues/4066"},"comments":{"href":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/issues/4066/comments"},"review_comments":{"href":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/pulls/4066/comments"},"review_comment":{"href":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/pulls/4066/commits"},"statuses":{"href":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/statuses/01bd3d3297b79bcc3fa9c3b9968832c6bf1a1522"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"therealandeeee"}}