{"action":"created","issue":{"url":"https://api.github.com/repos/rtfd/readthedocs-docker-images/issues/62","repository_url":"https://api.github.com/repos/rtfd/readthedocs-docker-images","labels_url":"https://api.github.com/repos/rtfd/readthedocs-docker-images/issues/62/labels{/name}","comments_url":"https://api.github.com/repos/rtfd/readthedocs-docker-images/issues/62/comments","events_url":"https://api.github.com/repos/rtfd/readthedocs-docker-images/issues/62/events","html_url":"https://github.com/rtfd/readthedocs-docker-images/issues/62","id":303593724,"number":62,"title":"Image release pattern","user":{"login":"agjohnson","id":1140183,"avatar_url":"https://avatars0.githubusercontent.com/u/1140183?v=4","gravatar_id":"","url":"https://api.github.com/users/agjohnson","html_url":"https://github.com/agjohnson","followers_url":"https://api.github.com/users/agjohnson/followers","following_url":"https://api.github.com/users/agjohnson/following{/other_user}","gists_url":"https://api.github.com/users/agjohnson/gists{/gist_id}","starred_url":"https://api.github.com/users/agjohnson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agjohnson/subscriptions","organizations_url":"https://api.github.com/users/agjohnson/orgs","repos_url":"https://api.github.com/users/agjohnson/repos","events_url":"https://api.github.com/users/agjohnson/events{/privacy}","received_events_url":"https://api.github.com/users/agjohnson/received_events","type":"User","site_admin":false},"labels":[{"id":361435053,"url":"https://api.github.com/repos/rtfd/readthedocs-docker-images/labels/Needed:%20design%20decision","name":"Needed: design decision","color":"54473F","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-03-08T19:02:08Z","updated_at":"2018-03-26T03:16:36Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"We have a few things to decide on given our release pattern here and the fact that we now allow arbitrary image selection through readthedocs.yml.\r\n\r\n### What to do with latest now?\r\n\r\n`latest` should probably be version `3.0` by now. I'm 👍 on making `latest` version `3.0` and making this the default (on a feature flag to scale in perhaps). I think we should maybe move to a versioned approach to `latest` though, as our docs now point people to use `latest` and our new `latest`, based on Ubuntu 18.04, could introduce unwanted changes.\r\n\r\nThis leads to another question.\r\n\r\n### How many images do users need access to?\r\n\r\nIt's helpful for users and for user to have some control over specific build image, however allowing users to select the minor version means we need to keep all these versions around, supported. I don't think it's necessary for users to have granular access to the minor versions.\r\n\r\nThis isn't a problem now, but if we semver our `latest` release, these versions will accumulate faster. We could end up with a list like: `[(2,0), (3,0), (4,0), (4,1), (4,2)]`. This seems like a lot to support, without much gain.\r\n\r\nI think only supporting major versions in our config file makes sense, so `build.image` becomes an integer field.\r\n\r\nThis leads to another question\r\n\r\n### How do we handle image deprecation?\r\n\r\nArbitrary image selection leads to the problem that users might want to pin to version `2.0` now, or as it stands with our current config, `2.1`. At some point we don't want to support this image though, so we need a pattern now on warning users that their image will be deprecated soon.\r\n\r\n### Things we do know\r\n\r\n* We shouldn't point users to use `latest` tag, this puts them into a stream of build images that they need to get out of at some point. We should instruct `3.0` explicitly\r\n* We don't want to go back to boolean image selection for the same reason\r\n* If we want to support arbitrary images, we need UX around how to deprecate these images as well"},"comment":{"url":"https://api.github.com/repos/rtfd/readthedocs-docker-images/issues/comments/376035135","html_url":"https://github.com/rtfd/readthedocs-docker-images/issues/62#issuecomment-376035135","issue_url":"https://api.github.com/repos/rtfd/readthedocs-docker-images/issues/62","id":376035135,"user":{"login":"ericholscher","id":25510,"avatar_url":"https://avatars2.githubusercontent.com/u/25510?v=4","gravatar_id":"","url":"https://api.github.com/users/ericholscher","html_url":"https://github.com/ericholscher","followers_url":"https://api.github.com/users/ericholscher/followers","following_url":"https://api.github.com/users/ericholscher/following{/other_user}","gists_url":"https://api.github.com/users/ericholscher/gists{/gist_id}","starred_url":"https://api.github.com/users/ericholscher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericholscher/subscriptions","organizations_url":"https://api.github.com/users/ericholscher/orgs","repos_url":"https://api.github.com/users/ericholscher/repos","events_url":"https://api.github.com/users/ericholscher/events{/privacy}","received_events_url":"https://api.github.com/users/ericholscher/received_events","type":"User","site_admin":false},"created_at":"2018-03-26T03:16:36Z","updated_at":"2018-03-26T03:16:36Z","author_association":"OWNER","body":"I think that makes sense. \"Let users opt into dev features\" seems like a good idea, but we never actually execute it well, so I think it's an anti-feature. \r\n\r\nAgreed on \"letting users opt into the old way when we break something\" is the primary reason for this functionality. The other is \"let users use custom build images\", but I don't want to go down that road yet. "}}
{"actor":{"display_login":"ericholscher"}}