{"action":"created","issue":{"url":"https://api.github.com/repos/elemental-lf/benji/issues/2","repository_url":"https://api.github.com/repos/elemental-lf/benji","labels_url":"https://api.github.com/repos/elemental-lf/benji/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/elemental-lf/benji/issues/2/comments","events_url":"https://api.github.com/repos/elemental-lf/benji/issues/2/events","html_url":"https://github.com/elemental-lf/benji/issues/2","id":345355023,"node_id":"MDU6SXNzdWUzNDUzNTUwMjM=","number":2,"title":"extras_require keys should not contain spaces","user":{"login":"olifre","id":166759,"node_id":"MDQ6VXNlcjE2Njc1OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/166759?v=4","gravatar_id":"","url":"https://api.github.com/users/olifre","html_url":"https://github.com/olifre","followers_url":"https://api.github.com/users/olifre/followers","following_url":"https://api.github.com/users/olifre/following{/other_user}","gists_url":"https://api.github.com/users/olifre/gists{/gist_id}","starred_url":"https://api.github.com/users/olifre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olifre/subscriptions","organizations_url":"https://api.github.com/users/olifre/orgs","repos_url":"https://api.github.com/users/olifre/repos","events_url":"https://api.github.com/users/olifre/events{/privacy}","received_events_url":"https://api.github.com/users/olifre/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-07-27T20:21:41Z","updated_at":"2018-08-06T14:39:20Z","closed_at":"2018-08-06T14:39:20Z","author_association":"NONE","body":"It seems not to work as intended:\r\n```\r\npip install \"benji[disk based read cache]\"\r\npip install \"benji[disk\\ based\\ read\\ cache]\"\r\npip install \"benji[disk%20based%20read%20cache]\"\r\n```\r\nall fail with something along the lines of:\r\n```\r\nException:\r\nTraceback (most recent call last):\r\n  File \"/opt/benji/lib64/python3.6/site-packages/pip/_vendor/packaging/requirements.py\", line 93, in __init__\r\n    req = REQUIREMENT.parseString(requirement_string)\r\n  File \"/opt/benji/lib64/python3.6/site-packages/pip/_vendor/pyparsing.py\", line 1632, in parseString\r\n    raise exc\r\n  File \"/opt/benji/lib64/python3.6/site-packages/pip/_vendor/pyparsing.py\", line 1622, in parseString\r\n    loc, tokens = self._parse( instring, 0 )\r\n  File \"/opt/benji/lib64/python3.6/site-packages/pip/_vendor/pyparsing.py\", line 1379, in _parseNoCache\r\n    loc,tokens = self.parseImpl( instring, preloc, doActions )\r\n  File \"/opt/benji/lib64/python3.6/site-packages/pip/_vendor/pyparsing.py\", line 3395, in parseImpl\r\n    loc, exprtokens = e._parse( instring, loc, doActions )\r\n  File \"/opt/benji/lib64/python3.6/site-packages/pip/_vendor/pyparsing.py\", line 1383, in _parseNoCache\r\n    loc,tokens = self.parseImpl( instring, preloc, doActions )\r\n  File \"/opt/benji/lib64/python3.6/site-packages/pip/_vendor/pyparsing.py\", line 3183, in parseImpl\r\n    raise ParseException(instring, loc, self.errmsg, self)\r\npip._vendor.pyparsing.ParseException: Expected stringEnd (at char 11), (line:1, col:12)\r\n\r\nDuring handling of the above exception, another exception occurred:\r\n\r\nTraceback (most recent call last):\r\n  File \"/opt/benji/lib64/python3.6/site-packages/pip/_internal/basecommand.py\", line 141, in main\r\n    status = self.run(options, args)\r\n  File \"/opt/benji/lib64/python3.6/site-packages/pip/_internal/commands/install.py\", line 274, in run\r\n    self.name, wheel_cache\r\n  File \"/opt/benji/lib64/python3.6/site-packages/pip/_internal/basecommand.py\", line 213, in populate_requirement_set\r\n    wheel_cache=wheel_cache\r\n  File \"/opt/benji/lib64/python3.6/site-packages/pip/_internal/req/req_install.py\", line 248, in from_line\r\n    extras = Requirement(\"placeholder\" + extras.lower()).extras\r\n  File \"/opt/benji/lib64/python3.6/site-packages/pip/_vendor/packaging/requirements.py\", line 97, in __init__\r\n    requirement_string[e.loc:e.loc + 8]))\r\npip._vendor.packaging.requirements.InvalidRequirement: Invalid requirement, parse error at \"'[disk ba'\"\r\n```\r\nLooking at:\r\nhttps://github.com/loli/medpy/issues/49\r\nit seems spaces do not work in the keys of `extras_require` (i.e. tooling does not like it). \r\n"},"comment":{"url":"https://api.github.com/repos/elemental-lf/benji/issues/comments/410730984","html_url":"https://github.com/elemental-lf/benji/issues/2#issuecomment-410730984","issue_url":"https://api.github.com/repos/elemental-lf/benji/issues/2","id":410730984,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMDczMDk4NA==","user":{"login":"elemental-lf","id":24651317,"node_id":"MDQ6VXNlcjI0NjUxMzE3","avatar_url":"https://avatars3.githubusercontent.com/u/24651317?v=4","gravatar_id":"","url":"https://api.github.com/users/elemental-lf","html_url":"https://github.com/elemental-lf","followers_url":"https://api.github.com/users/elemental-lf/followers","following_url":"https://api.github.com/users/elemental-lf/following{/other_user}","gists_url":"https://api.github.com/users/elemental-lf/gists{/gist_id}","starred_url":"https://api.github.com/users/elemental-lf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elemental-lf/subscriptions","organizations_url":"https://api.github.com/users/elemental-lf/orgs","repos_url":"https://api.github.com/users/elemental-lf/repos","events_url":"https://api.github.com/users/elemental-lf/events{/privacy}","received_events_url":"https://api.github.com/users/elemental-lf/received_events","type":"User","site_admin":false},"created_at":"2018-08-06T14:39:20Z","updated_at":"2018-08-06T14:39:20Z","author_association":"OWNER","body":"Thanks for the report, Oliver! This problem has been addressed in the current master. "}}
{"actor":{"display_login":"elemental-lf"}}