{"action":"created","issue":{"url":"https://api.github.com/repos/mapbox/carmen/issues/702","repository_url":"https://api.github.com/repos/mapbox/carmen","labels_url":"https://api.github.com/repos/mapbox/carmen/issues/702/labels{/name}","comments_url":"https://api.github.com/repos/mapbox/carmen/issues/702/comments","events_url":"https://api.github.com/repos/mapbox/carmen/issues/702/events","html_url":"https://github.com/mapbox/carmen/pull/702","id":308958030,"number":702,"title":"Strip out acute accent character ( ́  ) from all the queries ","user":{"login":"bsrinivasa","id":17143802,"avatar_url":"https://avatars2.githubusercontent.com/u/17143802?v=4","gravatar_id":"","url":"https://api.github.com/users/bsrinivasa","html_url":"https://github.com/bsrinivasa","followers_url":"https://api.github.com/users/bsrinivasa/followers","following_url":"https://api.github.com/users/bsrinivasa/following{/other_user}","gists_url":"https://api.github.com/users/bsrinivasa/gists{/gist_id}","starred_url":"https://api.github.com/users/bsrinivasa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsrinivasa/subscriptions","organizations_url":"https://api.github.com/users/bsrinivasa/orgs","repos_url":"https://api.github.com/users/bsrinivasa/repos","events_url":"https://api.github.com/users/bsrinivasa/events{/privacy}","received_events_url":"https://api.github.com/users/bsrinivasa/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-03-27T12:58:49Z","updated_at":"2018-03-28T20:28:31Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/mapbox/carmen/pulls/702","html_url":"https://github.com/mapbox/carmen/pull/702","diff_url":"https://github.com/mapbox/carmen/pull/702.diff","patch_url":"https://github.com/mapbox/carmen/pull/702.patch"},"body":"### Context\r\n\r\nBased on user feedback, queries for Moscow in Russian labels doesn't work when `Москва́`(with the accent character) is used instead of `Москва`. Based on discussion,  removing the character from all the queries with this character is a good solution Adding a line to strip out the accent character from all the queries. \r\n\r\nUsed [this](https://www.fileformat.info/info/unicode/char/0301/index.htm) to refer for the unicode encoding to replace the accent character with null.\r\n\r\n\r\n### Summary of Changes\r\n- [ ] Added a `.replace` statement to strip out the character\r\n\r\n\r\n### Next Steps\r\n- Test\r\n- Review and merge \r\n- Bump version\r\n\r\n\r\ncc @mattficke  @mapbox/geocoding-gang\r\n"},"comment":{"url":"https://api.github.com/repos/mapbox/carmen/issues/comments/377025076","html_url":"https://github.com/mapbox/carmen/pull/702#issuecomment-377025076","issue_url":"https://api.github.com/repos/mapbox/carmen/issues/702","id":377025076,"user":{"login":"boblannon","id":1092694,"avatar_url":"https://avatars3.githubusercontent.com/u/1092694?v=4","gravatar_id":"","url":"https://api.github.com/users/boblannon","html_url":"https://github.com/boblannon","followers_url":"https://api.github.com/users/boblannon/followers","following_url":"https://api.github.com/users/boblannon/following{/other_user}","gists_url":"https://api.github.com/users/boblannon/gists{/gist_id}","starred_url":"https://api.github.com/users/boblannon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boblannon/subscriptions","organizations_url":"https://api.github.com/users/boblannon/orgs","repos_url":"https://api.github.com/users/boblannon/repos","events_url":"https://api.github.com/users/boblannon/events{/privacy}","received_events_url":"https://api.github.com/users/boblannon/received_events","type":"User","site_admin":false},"created_at":"2018-03-28T20:28:30Z","updated_at":"2018-03-28T20:28:30Z","author_association":"CONTRIBUTOR","body":"> We could also consider ditching our current diacritical mark removal code altogether, and replacing it with a unicode normalization step that decomposes all precomposed characters with diacritical marks into (unmarked character) + (combining diacritical mark) pairs, and then stripping them all in one go\r\n\r\nyou'd still have the problem of the \"pre-composed\" versions of accented characters, meaning we'd still have to map at least some of the accented characters."}}
{"actor":{"display_login":"boblannon"}}