{"action":"created","comment":{"url":"https://api.github.com/repos/NYPL-Simplified/library_registry/pulls/comments/199558402","pull_request_review_id":133701281,"id":199558402,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTU1ODQwMg==","diff_hunk":"@@ -4,7 +4,7 @@\n import urlparse\n \n from flask import Flask, url_for, redirect, Response, request\n-from flask.ext.babel import Babel\n+from flask_babel import Babel","path":"app.py","position":5,"original_position":5,"commit_id":"a37b30227deec8ba4375b9261235e4bb15166600","original_commit_id":"a37b30227deec8ba4375b9261235e4bb15166600","user":{"login":"leonardr","id":662474,"node_id":"MDQ6VXNlcjY2MjQ3NA==","avatar_url":"https://avatars0.githubusercontent.com/u/662474?v=4","gravatar_id":"","url":"https://api.github.com/users/leonardr","html_url":"https://github.com/leonardr","followers_url":"https://api.github.com/users/leonardr/followers","following_url":"https://api.github.com/users/leonardr/following{/other_user}","gists_url":"https://api.github.com/users/leonardr/gists{/gist_id}","starred_url":"https://api.github.com/users/leonardr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leonardr/subscriptions","organizations_url":"https://api.github.com/users/leonardr/orgs","repos_url":"https://api.github.com/users/leonardr/repos","events_url":"https://api.github.com/users/leonardr/events{/privacy}","received_events_url":"https://api.github.com/users/leonardr/received_events","type":"User","site_admin":false},"body":"We now import Babel through a different package.","created_at":"2018-07-02T16:49:08Z","updated_at":"2018-07-02T16:49:09Z","html_url":"https://github.com/NYPL-Simplified/library_registry/pull/56#discussion_r199558402","pull_request_url":"https://api.github.com/repos/NYPL-Simplified/library_registry/pulls/56","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/NYPL-Simplified/library_registry/pulls/comments/199558402"},"html":{"href":"https://github.com/NYPL-Simplified/library_registry/pull/56#discussion_r199558402"},"pull_request":{"href":"https://api.github.com/repos/NYPL-Simplified/library_registry/pulls/56"}}},"pull_request":{"url":"https://api.github.com/repos/NYPL-Simplified/library_registry/pulls/56","id":198720756,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4NzIwNzU2","html_url":"https://github.com/NYPL-Simplified/library_registry/pull/56","diff_url":"https://github.com/NYPL-Simplified/library_registry/pull/56.diff","patch_url":"https://github.com/NYPL-Simplified/library_registry/pull/56.patch","issue_url":"https://api.github.com/repos/NYPL-Simplified/library_registry/issues/56","number":56,"state":"open","locked":false,"title":"Serve terms of service as part of a document that describes the registration process","user":{"login":"leonardr","id":662474,"node_id":"MDQ6VXNlcjY2MjQ3NA==","avatar_url":"https://avatars0.githubusercontent.com/u/662474?v=4","gravatar_id":"","url":"https://api.github.com/users/leonardr","html_url":"https://github.com/leonardr","followers_url":"https://api.github.com/users/leonardr/followers","following_url":"https://api.github.com/users/leonardr/following{/other_user}","gists_url":"https://api.github.com/users/leonardr/gists{/gist_id}","starred_url":"https://api.github.com/users/leonardr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leonardr/subscriptions","organizations_url":"https://api.github.com/users/leonardr/orgs","repos_url":"https://api.github.com/users/leonardr/repos","events_url":"https://api.github.com/users/leonardr/events{/privacy}","received_events_url":"https://api.github.com/users/leonardr/received_events","type":"User","site_admin":false},"body":"This branch makes the registration endpoint for a library registry respond to GET as well as POST. A GET request will give an OPDS 2 catalog containing (at most) one link. This link is a `data:` link describing the terms of service for the registration endpoint. This is as opposed to the catalog endpoints, which  don't have any special terms of service, because their users are random library patrons who don't even know they're using a separate service.\r\n\r\nSince this is the first library registry branch in nearly a year, I had to make a number of changes to make sure the code worked and the Travis tests ran with recent dependencies.","created_at":"2018-07-02T15:50:36Z","updated_at":"2018-07-02T16:49:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"de443979a0a7a0cccbf5506ee61a169283e65b7f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/NYPL-Simplified/library_registry/pulls/56/commits","review_comments_url":"https://api.github.com/repos/NYPL-Simplified/library_registry/pulls/56/comments","review_comment_url":"https://api.github.com/repos/NYPL-Simplified/library_registry/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NYPL-Simplified/library_registry/issues/56/comments","statuses_url":"https://api.github.com/repos/NYPL-Simplified/library_registry/statuses/a37b30227deec8ba4375b9261235e4bb15166600","head":{"label":"NYPL-Simplified:terms-of-service","ref":"terms-of-service","sha":"a37b30227deec8ba4375b9261235e4bb15166600","user":{"login":"NYPL-Simplified","id":16416905,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDE2OTA1","avatar_url":"https://avatars1.githubusercontent.com/u/16416905?v=4","gravatar_id":"","url":"https://api.github.com/users/NYPL-Simplified","html_url":"https://github.com/NYPL-Simplified","followers_url":"https://api.github.com/users/NYPL-Simplified/followers","following_url":"https://api.github.com/users/NYPL-Simplified/following{/other_user}","gists_url":"https://api.github.com/users/NYPL-Simplified/gists{/gist_id}","starred_url":"https://api.github.com/users/NYPL-Simplified/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NYPL-Simplified/subscriptions","organizations_url":"https://api.github.com/users/NYPL-Simplified/orgs","repos_url":"https://api.github.com/users/NYPL-Simplified/repos","events_url":"https://api.github.com/users/NYPL-Simplified/events{/privacy}","received_events_url":"https://api.github.com/users/NYPL-Simplified/received_events","type":"Organization","site_admin":false},"repo":{"id":80215623,"node_id":"MDEwOlJlcG9zaXRvcnk4MDIxNTYyMw==","name":"library_registry","full_name":"NYPL-Simplified/library_registry","owner":{"login":"NYPL-Simplified","id":16416905,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDE2OTA1","avatar_url":"https://avatars1.githubusercontent.com/u/16416905?v=4","gravatar_id":"","url":"https://api.github.com/users/NYPL-Simplified","html_url":"https://github.com/NYPL-Simplified","followers_url":"https://api.github.com/users/NYPL-Simplified/followers","following_url":"https://api.github.com/users/NYPL-Simplified/following{/other_user}","gists_url":"https://api.github.com/users/NYPL-Simplified/gists{/gist_id}","starred_url":"https://api.github.com/users/NYPL-Simplified/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NYPL-Simplified/subscriptions","organizations_url":"https://api.github.com/users/NYPL-Simplified/orgs","repos_url":"https://api.github.com/users/NYPL-Simplified/repos","events_url":"https://api.github.com/users/NYPL-Simplified/events{/privacy}","received_events_url":"https://api.github.com/users/NYPL-Simplified/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NYPL-Simplified/library_registry","description":"A geographic search engine for matching people to the libraries that serve them.","fork":false,"url":"https://api.github.com/repos/NYPL-Simplified/library_registry","forks_url":"https://api.github.com/repos/NYPL-Simplified/library_registry/forks","keys_url":"https://api.github.com/repos/NYPL-Simplified/library_registry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NYPL-Simplified/library_registry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NYPL-Simplified/library_registry/teams","hooks_url":"https://api.github.com/repos/NYPL-Simplified/library_registry/hooks","issue_events_url":"https://api.github.com/repos/NYPL-Simplified/library_registry/issues/events{/number}","events_url":"https://api.github.com/repos/NYPL-Simplified/library_registry/events","assignees_url":"https://api.github.com/repos/NYPL-Simplified/library_registry/assignees{/user}","branches_url":"https://api.github.com/repos/NYPL-Simplified/library_registry/branches{/branch}","tags_url":"https://api.github.com/repos/NYPL-Simplified/library_registry/tags","blobs_url":"https://api.github.com/repos/NYPL-Simplified/library_registry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NYPL-Simplified/library_registry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NYPL-Simplified/library_registry/git/refs{/sha}","trees_url":"https://api.github.com/repos/NYPL-Simplified/library_registry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NYPL-Simplified/library_registry/statuses/{sha}","languages_url":"https://api.github.com/repos/NYPL-Simplified/library_registry/languages","stargazers_url":"https://api.github.com/repos/NYPL-Simplified/library_registry/stargazers","contributors_url":"https://api.github.com/repos/NYPL-Simplified/library_registry/contributors","subscribers_url":"https://api.github.com/repos/NYPL-Simplified/library_registry/subscribers","subscription_url":"https://api.github.com/repos/NYPL-Simplified/library_registry/subscription","commits_url":"https://api.github.com/repos/NYPL-Simplified/library_registry/commits{/sha}","git_commits_url":"https://api.github.com/repos/NYPL-Simplified/library_registry/git/commits{/sha}","comments_url":"https://api.github.com/repos/NYPL-Simplified/library_registry/comments{/number}","issue_comment_url":"https://api.github.com/repos/NYPL-Simplified/library_registry/issues/comments{/number}","contents_url":"https://api.github.com/repos/NYPL-Simplified/library_registry/contents/{+path}","compare_url":"https://api.github.com/repos/NYPL-Simplified/library_registry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NYPL-Simplified/library_registry/merges","archive_url":"https://api.github.com/repos/NYPL-Simplified/library_registry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NYPL-Simplified/library_registry/downloads","issues_url":"https://api.github.com/repos/NYPL-Simplified/library_registry/issues{/number}","pulls_url":"https://api.github.com/repos/NYPL-Simplified/library_registry/pulls{/number}","milestones_url":"https://api.github.com/repos/NYPL-Simplified/library_registry/milestones{/number}","notifications_url":"https://api.github.com/repos/NYPL-Simplified/library_registry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NYPL-Simplified/library_registry/labels{/name}","releases_url":"https://api.github.com/repos/NYPL-Simplified/library_registry/releases{/id}","deployments_url":"https://api.github.com/repos/NYPL-Simplified/library_registry/deployments","created_at":"2017-01-27T14:48:48Z","updated_at":"2018-06-18T21:40:20Z","pushed_at":"2018-07-02T16:37:41Z","git_url":"git://github.com/NYPL-Simplified/library_registry.git","ssh_url":"git@github.com:NYPL-Simplified/library_registry.git","clone_url":"https://github.com/NYPL-Simplified/library_registry.git","svn_url":"https://github.com/NYPL-Simplified/library_registry","homepage":"","size":376,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":2,"watchers":1,"default_branch":"master"}},"base":{"label":"NYPL-Simplified:master","ref":"master","sha":"f56b57450d91dd4dbe055027f775d3c5a284c7b1","user":{"login":"NYPL-Simplified","id":16416905,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDE2OTA1","avatar_url":"https://avatars1.githubusercontent.com/u/16416905?v=4","gravatar_id":"","url":"https://api.github.com/users/NYPL-Simplified","html_url":"https://github.com/NYPL-Simplified","followers_url":"https://api.github.com/users/NYPL-Simplified/followers","following_url":"https://api.github.com/users/NYPL-Simplified/following{/other_user}","gists_url":"https://api.github.com/users/NYPL-Simplified/gists{/gist_id}","starred_url":"https://api.github.com/users/NYPL-Simplified/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NYPL-Simplified/subscriptions","organizations_url":"https://api.github.com/users/NYPL-Simplified/orgs","repos_url":"https://api.github.com/users/NYPL-Simplified/repos","events_url":"https://api.github.com/users/NYPL-Simplified/events{/privacy}","received_events_url":"https://api.github.com/users/NYPL-Simplified/received_events","type":"Organization","site_admin":false},"repo":{"id":80215623,"node_id":"MDEwOlJlcG9zaXRvcnk4MDIxNTYyMw==","name":"library_registry","full_name":"NYPL-Simplified/library_registry","owner":{"login":"NYPL-Simplified","id":16416905,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDE2OTA1","avatar_url":"https://avatars1.githubusercontent.com/u/16416905?v=4","gravatar_id":"","url":"https://api.github.com/users/NYPL-Simplified","html_url":"https://github.com/NYPL-Simplified","followers_url":"https://api.github.com/users/NYPL-Simplified/followers","following_url":"https://api.github.com/users/NYPL-Simplified/following{/other_user}","gists_url":"https://api.github.com/users/NYPL-Simplified/gists{/gist_id}","starred_url":"https://api.github.com/users/NYPL-Simplified/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NYPL-Simplified/subscriptions","organizations_url":"https://api.github.com/users/NYPL-Simplified/orgs","repos_url":"https://api.github.com/users/NYPL-Simplified/repos","events_url":"https://api.github.com/users/NYPL-Simplified/events{/privacy}","received_events_url":"https://api.github.com/users/NYPL-Simplified/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NYPL-Simplified/library_registry","description":"A geographic search engine for matching people to the libraries that serve them.","fork":false,"url":"https://api.github.com/repos/NYPL-Simplified/library_registry","forks_url":"https://api.github.com/repos/NYPL-Simplified/library_registry/forks","keys_url":"https://api.github.com/repos/NYPL-Simplified/library_registry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NYPL-Simplified/library_registry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NYPL-Simplified/library_registry/teams","hooks_url":"https://api.github.com/repos/NYPL-Simplified/library_registry/hooks","issue_events_url":"https://api.github.com/repos/NYPL-Simplified/library_registry/issues/events{/number}","events_url":"https://api.github.com/repos/NYPL-Simplified/library_registry/events","assignees_url":"https://api.github.com/repos/NYPL-Simplified/library_registry/assignees{/user}","branches_url":"https://api.github.com/repos/NYPL-Simplified/library_registry/branches{/branch}","tags_url":"https://api.github.com/repos/NYPL-Simplified/library_registry/tags","blobs_url":"https://api.github.com/repos/NYPL-Simplified/library_registry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NYPL-Simplified/library_registry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NYPL-Simplified/library_registry/git/refs{/sha}","trees_url":"https://api.github.com/repos/NYPL-Simplified/library_registry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NYPL-Simplified/library_registry/statuses/{sha}","languages_url":"https://api.github.com/repos/NYPL-Simplified/library_registry/languages","stargazers_url":"https://api.github.com/repos/NYPL-Simplified/library_registry/stargazers","contributors_url":"https://api.github.com/repos/NYPL-Simplified/library_registry/contributors","subscribers_url":"https://api.github.com/repos/NYPL-Simplified/library_registry/subscribers","subscription_url":"https://api.github.com/repos/NYPL-Simplified/library_registry/subscription","commits_url":"https://api.github.com/repos/NYPL-Simplified/library_registry/commits{/sha}","git_commits_url":"https://api.github.com/repos/NYPL-Simplified/library_registry/git/commits{/sha}","comments_url":"https://api.github.com/repos/NYPL-Simplified/library_registry/comments{/number}","issue_comment_url":"https://api.github.com/repos/NYPL-Simplified/library_registry/issues/comments{/number}","contents_url":"https://api.github.com/repos/NYPL-Simplified/library_registry/contents/{+path}","compare_url":"https://api.github.com/repos/NYPL-Simplified/library_registry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NYPL-Simplified/library_registry/merges","archive_url":"https://api.github.com/repos/NYPL-Simplified/library_registry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NYPL-Simplified/library_registry/downloads","issues_url":"https://api.github.com/repos/NYPL-Simplified/library_registry/issues{/number}","pulls_url":"https://api.github.com/repos/NYPL-Simplified/library_registry/pulls{/number}","milestones_url":"https://api.github.com/repos/NYPL-Simplified/library_registry/milestones{/number}","notifications_url":"https://api.github.com/repos/NYPL-Simplified/library_registry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NYPL-Simplified/library_registry/labels{/name}","releases_url":"https://api.github.com/repos/NYPL-Simplified/library_registry/releases{/id}","deployments_url":"https://api.github.com/repos/NYPL-Simplified/library_registry/deployments","created_at":"2017-01-27T14:48:48Z","updated_at":"2018-06-18T21:40:20Z","pushed_at":"2018-07-02T16:37:41Z","git_url":"git://github.com/NYPL-Simplified/library_registry.git","ssh_url":"git@github.com:NYPL-Simplified/library_registry.git","clone_url":"https://github.com/NYPL-Simplified/library_registry.git","svn_url":"https://github.com/NYPL-Simplified/library_registry","homepage":"","size":376,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NYPL-Simplified/library_registry/pulls/56"},"html":{"href":"https://github.com/NYPL-Simplified/library_registry/pull/56"},"issue":{"href":"https://api.github.com/repos/NYPL-Simplified/library_registry/issues/56"},"comments":{"href":"https://api.github.com/repos/NYPL-Simplified/library_registry/issues/56/comments"},"review_comments":{"href":"https://api.github.com/repos/NYPL-Simplified/library_registry/pulls/56/comments"},"review_comment":{"href":"https://api.github.com/repos/NYPL-Simplified/library_registry/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NYPL-Simplified/library_registry/pulls/56/commits"},"statuses":{"href":"https://api.github.com/repos/NYPL-Simplified/library_registry/statuses/a37b30227deec8ba4375b9261235e4bb15166600"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"leonardr"}}