{"action":"created","comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments/174733267","pull_request_review_id":104136698,"id":174733267,"diff_hunk":"@@ -714,7 +714,7 @@ func (ru *RowUpdater) UpdateRow(\n \n \t\tru.Fks.addCheckForIndex(ru.Helper.TableDesc.PrimaryIndex.ID)\n \t\tfor i := range newSecondaryIndexEntries {\n-\t\t\tif !bytes.Equal(newSecondaryIndexEntries[i].Key, secondaryIndexEntries[i].Key) {\n+\t\t\tif !bytes.Equal(newSecondaryIndexEntries[i].Key, oldSecondaryIndexEntries[i].Key) {\n \t\t\t\tru.Fks.addCheckForIndex(ru.Helper.Indexes[i].ID)","path":"pkg/sql/sqlbase/rowwriter.go","position":26,"original_position":26,"commit_id":"df72e2d23c329cbdd5d351388b739de7e9d5f951","original_commit_id":"df72e2d23c329cbdd5d351388b739de7e9d5f951","user":{"login":"vivekmenezes","id":11774212,"avatar_url":"https://avatars1.githubusercontent.com/u/11774212?v=4","gravatar_id":"","url":"https://api.github.com/users/vivekmenezes","html_url":"https://github.com/vivekmenezes","followers_url":"https://api.github.com/users/vivekmenezes/followers","following_url":"https://api.github.com/users/vivekmenezes/following{/other_user}","gists_url":"https://api.github.com/users/vivekmenezes/gists{/gist_id}","starred_url":"https://api.github.com/users/vivekmenezes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vivekmenezes/subscriptions","organizations_url":"https://api.github.com/users/vivekmenezes/orgs","repos_url":"https://api.github.com/users/vivekmenezes/repos","events_url":"https://api.github.com/users/vivekmenezes/events{/privacy}","received_events_url":"https://api.github.com/users/vivekmenezes/received_events","type":"User","site_admin":false},"body":"I also checked you do not need to call ru.Fks.addCheckForIndex() for inverted indexes","created_at":"2018-03-15T10:16:31Z","updated_at":"2018-03-15T10:28:34Z","html_url":"https://github.com/cockroachdb/cockroach/pull/23318#discussion_r174733267","pull_request_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/23318","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments/174733267"},"html":{"href":"https://github.com/cockroachdb/cockroach/pull/23318#discussion_r174733267"},"pull_request":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/23318"}},"in_reply_to_id":174731153},"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/23318","id":172554895,"html_url":"https://github.com/cockroachdb/cockroach/pull/23318","diff_url":"https://github.com/cockroachdb/cockroach/pull/23318.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/23318.patch","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/23318","number":23318,"state":"open","locked":false,"title":"sql: fix panic for UPDATES on tables with an inverted index","user":{"login":"m-schneider","id":29267687,"avatar_url":"https://avatars3.githubusercontent.com/u/29267687?v=4","gravatar_id":"","url":"https://api.github.com/users/m-schneider","html_url":"https://github.com/m-schneider","followers_url":"https://api.github.com/users/m-schneider/followers","following_url":"https://api.github.com/users/m-schneider/following{/other_user}","gists_url":"https://api.github.com/users/m-schneider/gists{/gist_id}","starred_url":"https://api.github.com/users/m-schneider/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-schneider/subscriptions","organizations_url":"https://api.github.com/users/m-schneider/orgs","repos_url":"https://api.github.com/users/m-schneider/repos","events_url":"https://api.github.com/users/m-schneider/events{/privacy}","received_events_url":"https://api.github.com/users/m-schneider/received_events","type":"User","site_admin":false},"body":"Before this patch we would panic on updates to columns which had an\r\ninverted index on them and the new column value would generate more\r\nentries than the one being replaced.\r\n\r\nAfter this patch we handle updates to indexes which generate a different\r\nnumber of entries for the old and new values correctly.\r\n\r\nCloses: #23290\r\n\r\nRelease note: None","created_at":"2018-03-02T17:05:45Z","updated_at":"2018-03-15T10:28:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9c6b0de727e4f1cf0fef27d530b5cacf293bce54","assignee":null,"assignees":[],"requested_reviewers":[{"login":"justinj","id":409075,"avatar_url":"https://avatars2.githubusercontent.com/u/409075?v=4","gravatar_id":"","url":"https://api.github.com/users/justinj","html_url":"https://github.com/justinj","followers_url":"https://api.github.com/users/justinj/followers","following_url":"https://api.github.com/users/justinj/following{/other_user}","gists_url":"https://api.github.com/users/justinj/gists{/gist_id}","starred_url":"https://api.github.com/users/justinj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinj/subscriptions","organizations_url":"https://api.github.com/users/justinj/orgs","repos_url":"https://api.github.com/users/justinj/repos","events_url":"https://api.github.com/users/justinj/events{/privacy}","received_events_url":"https://api.github.com/users/justinj/received_events","type":"User","site_admin":false}],"requested_teams":[{"name":"sql-rest-prs","id":2437982,"slug":"sql-rest-prs","description":"Join this team for notifications about SQL PRs that do not fall in other buckets","privacy":"closed","url":"https://api.github.com/teams/2437982","members_url":"https://api.github.com/teams/2437982/members{/member}","repositories_url":"https://api.github.com/teams/2437982/repos","permission":"pull"},{"name":"sql-execution-prs","id":2437984,"slug":"sql-execution-prs","description":"Join this team for notifications about SQL execution PRs","privacy":"closed","url":"https://api.github.com/teams/2437984","members_url":"https://api.github.com/teams/2437984/members{/member}","repositories_url":"https://api.github.com/teams/2437984/repos","permission":"pull"},{"name":"sql-planning-prs","id":2437986,"slug":"sql-planning-prs","description":"Join this team for notifications about SQL planning PRs","privacy":"closed","url":"https://api.github.com/teams/2437986","members_url":"https://api.github.com/teams/2437986/members{/member}","repositories_url":"https://api.github.com/teams/2437986/repos","permission":"pull"},{"name":"sql-async-prs","id":2437987,"slug":"sql-async-prs","description":"Join this team for notifications about SQL async PRs","privacy":"closed","url":"https://api.github.com/teams/2437987","members_url":"https://api.github.com/teams/2437987/members{/member}","repositories_url":"https://api.github.com/teams/2437987/repos","permission":"pull"}],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/23318/commits","review_comments_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/23318/comments","review_comment_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/23318/comments","statuses_url":"https://api.github.com/repos/cockroachdb/cockroach/statuses/df72e2d23c329cbdd5d351388b739de7e9d5f951","head":{"label":"m-schneider:updateinvindexpanicfix","ref":"updateinvindexpanicfix","sha":"df72e2d23c329cbdd5d351388b739de7e9d5f951","user":{"login":"m-schneider","id":29267687,"avatar_url":"https://avatars3.githubusercontent.com/u/29267687?v=4","gravatar_id":"","url":"https://api.github.com/users/m-schneider","html_url":"https://github.com/m-schneider","followers_url":"https://api.github.com/users/m-schneider/followers","following_url":"https://api.github.com/users/m-schneider/following{/other_user}","gists_url":"https://api.github.com/users/m-schneider/gists{/gist_id}","starred_url":"https://api.github.com/users/m-schneider/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-schneider/subscriptions","organizations_url":"https://api.github.com/users/m-schneider/orgs","repos_url":"https://api.github.com/users/m-schneider/repos","events_url":"https://api.github.com/users/m-schneider/events{/privacy}","received_events_url":"https://api.github.com/users/m-schneider/received_events","type":"User","site_admin":false},"repo":{"id":94476336,"name":"cockroach","full_name":"m-schneider/cockroach","owner":{"login":"m-schneider","id":29267687,"avatar_url":"https://avatars3.githubusercontent.com/u/29267687?v=4","gravatar_id":"","url":"https://api.github.com/users/m-schneider","html_url":"https://github.com/m-schneider","followers_url":"https://api.github.com/users/m-schneider/followers","following_url":"https://api.github.com/users/m-schneider/following{/other_user}","gists_url":"https://api.github.com/users/m-schneider/gists{/gist_id}","starred_url":"https://api.github.com/users/m-schneider/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-schneider/subscriptions","organizations_url":"https://api.github.com/users/m-schneider/orgs","repos_url":"https://api.github.com/users/m-schneider/repos","events_url":"https://api.github.com/users/m-schneider/events{/privacy}","received_events_url":"https://api.github.com/users/m-schneider/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/m-schneider/cockroach","description":"CockroachDB - the open source, cloud-native SQL database.","fork":true,"url":"https://api.github.com/repos/m-schneider/cockroach","forks_url":"https://api.github.com/repos/m-schneider/cockroach/forks","keys_url":"https://api.github.com/repos/m-schneider/cockroach/keys{/key_id}","collaborators_url":"https://api.github.com/repos/m-schneider/cockroach/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/m-schneider/cockroach/teams","hooks_url":"https://api.github.com/repos/m-schneider/cockroach/hooks","issue_events_url":"https://api.github.com/repos/m-schneider/cockroach/issues/events{/number}","events_url":"https://api.github.com/repos/m-schneider/cockroach/events","assignees_url":"https://api.github.com/repos/m-schneider/cockroach/assignees{/user}","branches_url":"https://api.github.com/repos/m-schneider/cockroach/branches{/branch}","tags_url":"https://api.github.com/repos/m-schneider/cockroach/tags","blobs_url":"https://api.github.com/repos/m-schneider/cockroach/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/m-schneider/cockroach/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/m-schneider/cockroach/git/refs{/sha}","trees_url":"https://api.github.com/repos/m-schneider/cockroach/git/trees{/sha}","statuses_url":"https://api.github.com/repos/m-schneider/cockroach/statuses/{sha}","languages_url":"https://api.github.com/repos/m-schneider/cockroach/languages","stargazers_url":"https://api.github.com/repos/m-schneider/cockroach/stargazers","contributors_url":"https://api.github.com/repos/m-schneider/cockroach/contributors","subscribers_url":"https://api.github.com/repos/m-schneider/cockroach/subscribers","subscription_url":"https://api.github.com/repos/m-schneider/cockroach/subscription","commits_url":"https://api.github.com/repos/m-schneider/cockroach/commits{/sha}","git_commits_url":"https://api.github.com/repos/m-schneider/cockroach/git/commits{/sha}","comments_url":"https://api.github.com/repos/m-schneider/cockroach/comments{/number}","issue_comment_url":"https://api.github.com/repos/m-schneider/cockroach/issues/comments{/number}","contents_url":"https://api.github.com/repos/m-schneider/cockroach/contents/{+path}","compare_url":"https://api.github.com/repos/m-schneider/cockroach/compare/{base}...{head}","merges_url":"https://api.github.com/repos/m-schneider/cockroach/merges","archive_url":"https://api.github.com/repos/m-schneider/cockroach/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/m-schneider/cockroach/downloads","issues_url":"https://api.github.com/repos/m-schneider/cockroach/issues{/number}","pulls_url":"https://api.github.com/repos/m-schneider/cockroach/pulls{/number}","milestones_url":"https://api.github.com/repos/m-schneider/cockroach/milestones{/number}","notifications_url":"https://api.github.com/repos/m-schneider/cockroach/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/m-schneider/cockroach/labels{/name}","releases_url":"https://api.github.com/repos/m-schneider/cockroach/releases{/id}","deployments_url":"https://api.github.com/repos/m-schneider/cockroach/deployments","created_at":"2017-06-15T20:29:43Z","updated_at":"2017-06-15T20:29:52Z","pushed_at":"2018-03-14T21:32:45Z","git_url":"git://github.com/m-schneider/cockroach.git","ssh_url":"git@github.com:m-schneider/cockroach.git","clone_url":"https://github.com/m-schneider/cockroach.git","svn_url":"https://github.com/m-schneider/cockroach","homepage":"https://www.cockroachlabs.com","size":504965,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cockroachdb:master","ref":"master","sha":"ceb71c4df24c791e69255551f975edf9c3219b52","user":{"login":"cockroachdb","id":6748139,"avatar_url":"https://avatars3.githubusercontent.com/u/6748139?v=4","gravatar_id":"","url":"https://api.github.com/users/cockroachdb","html_url":"https://github.com/cockroachdb","followers_url":"https://api.github.com/users/cockroachdb/followers","following_url":"https://api.github.com/users/cockroachdb/following{/other_user}","gists_url":"https://api.github.com/users/cockroachdb/gists{/gist_id}","starred_url":"https://api.github.com/users/cockroachdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockroachdb/subscriptions","organizations_url":"https://api.github.com/users/cockroachdb/orgs","repos_url":"https://api.github.com/users/cockroachdb/repos","events_url":"https://api.github.com/users/cockroachdb/events{/privacy}","received_events_url":"https://api.github.com/users/cockroachdb/received_events","type":"Organization","site_admin":false},"repo":{"id":16563587,"name":"cockroach","full_name":"cockroachdb/cockroach","owner":{"login":"cockroachdb","id":6748139,"avatar_url":"https://avatars3.githubusercontent.com/u/6748139?v=4","gravatar_id":"","url":"https://api.github.com/users/cockroachdb","html_url":"https://github.com/cockroachdb","followers_url":"https://api.github.com/users/cockroachdb/followers","following_url":"https://api.github.com/users/cockroachdb/following{/other_user}","gists_url":"https://api.github.com/users/cockroachdb/gists{/gist_id}","starred_url":"https://api.github.com/users/cockroachdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockroachdb/subscriptions","organizations_url":"https://api.github.com/users/cockroachdb/orgs","repos_url":"https://api.github.com/users/cockroachdb/repos","events_url":"https://api.github.com/users/cockroachdb/events{/privacy}","received_events_url":"https://api.github.com/users/cockroachdb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cockroachdb/cockroach","description":"CockroachDB - the open source, cloud-native SQL database.","fork":false,"url":"https://api.github.com/repos/cockroachdb/cockroach","forks_url":"https://api.github.com/repos/cockroachdb/cockroach/forks","keys_url":"https://api.github.com/repos/cockroachdb/cockroach/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cockroachdb/cockroach/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cockroachdb/cockroach/teams","hooks_url":"https://api.github.com/repos/cockroachdb/cockroach/hooks","issue_events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/events{/number}","events_url":"https://api.github.com/repos/cockroachdb/cockroach/events","assignees_url":"https://api.github.com/repos/cockroachdb/cockroach/assignees{/user}","branches_url":"https://api.github.com/repos/cockroachdb/cockroach/branches{/branch}","tags_url":"https://api.github.com/repos/cockroachdb/cockroach/tags","blobs_url":"https://api.github.com/repos/cockroachdb/cockroach/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cockroachdb/cockroach/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cockroachdb/cockroach/git/refs{/sha}","trees_url":"https://api.github.com/repos/cockroachdb/cockroach/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cockroachdb/cockroach/statuses/{sha}","languages_url":"https://api.github.com/repos/cockroachdb/cockroach/languages","stargazers_url":"https://api.github.com/repos/cockroachdb/cockroach/stargazers","contributors_url":"https://api.github.com/repos/cockroachdb/cockroach/contributors","subscribers_url":"https://api.github.com/repos/cockroachdb/cockroach/subscribers","subscription_url":"https://api.github.com/repos/cockroachdb/cockroach/subscription","commits_url":"https://api.github.com/repos/cockroachdb/cockroach/commits{/sha}","git_commits_url":"https://api.github.com/repos/cockroachdb/cockroach/git/commits{/sha}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/comments{/number}","issue_comment_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments{/number}","contents_url":"https://api.github.com/repos/cockroachdb/cockroach/contents/{+path}","compare_url":"https://api.github.com/repos/cockroachdb/cockroach/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cockroachdb/cockroach/merges","archive_url":"https://api.github.com/repos/cockroachdb/cockroach/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cockroachdb/cockroach/downloads","issues_url":"https://api.github.com/repos/cockroachdb/cockroach/issues{/number}","pulls_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls{/number}","milestones_url":"https://api.github.com/repos/cockroachdb/cockroach/milestones{/number}","notifications_url":"https://api.github.com/repos/cockroachdb/cockroach/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/labels{/name}","releases_url":"https://api.github.com/repos/cockroachdb/cockroach/releases{/id}","deployments_url":"https://api.github.com/repos/cockroachdb/cockroach/deployments","created_at":"2014-02-06T00:18:47Z","updated_at":"2018-03-15T10:27:24Z","pushed_at":"2018-03-15T08:14:57Z","git_url":"git://github.com/cockroachdb/cockroach.git","ssh_url":"git@github.com:cockroachdb/cockroach.git","clone_url":"https://github.com/cockroachdb/cockroach.git","svn_url":"https://github.com/cockroachdb/cockroach","homepage":"https://www.cockroachlabs.com","size":972996,"stargazers_count":12787,"watchers_count":12787,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1302,"mirror_url":null,"archived":false,"open_issues_count":1568,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1302,"open_issues":1568,"watchers":12787,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/23318"},"html":{"href":"https://github.com/cockroachdb/cockroach/pull/23318"},"issue":{"href":"https://api.github.com/repos/cockroachdb/cockroach/issues/23318"},"comments":{"href":"https://api.github.com/repos/cockroachdb/cockroach/issues/23318/comments"},"review_comments":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/23318/comments"},"review_comment":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/23318/commits"},"statuses":{"href":"https://api.github.com/repos/cockroachdb/cockroach/statuses/df72e2d23c329cbdd5d351388b739de7e9d5f951"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"vivekmenezes"}}