{"action":"created","issue":{"url":"https://api.github.com/repos/DivanteLtd/vue-storefront/issues/664","repository_url":"https://api.github.com/repos/DivanteLtd/vue-storefront","labels_url":"https://api.github.com/repos/DivanteLtd/vue-storefront/issues/664/labels{/name}","comments_url":"https://api.github.com/repos/DivanteLtd/vue-storefront/issues/664/comments","events_url":"https://api.github.com/repos/DivanteLtd/vue-storefront/issues/664/events","html_url":"https://github.com/DivanteLtd/vue-storefront/pull/664","id":297119106,"number":664,"title":"Issue: 606. Make assets theme-independent.","user":{"login":"qiqqq","id":5213267,"avatar_url":"https://avatars0.githubusercontent.com/u/5213267?v=4","gravatar_id":"","url":"https://api.github.com/users/qiqqq","html_url":"https://github.com/qiqqq","followers_url":"https://api.github.com/users/qiqqq/followers","following_url":"https://api.github.com/users/qiqqq/following{/other_user}","gists_url":"https://api.github.com/users/qiqqq/gists{/gist_id}","starred_url":"https://api.github.com/users/qiqqq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qiqqq/subscriptions","organizations_url":"https://api.github.com/users/qiqqq/orgs","repos_url":"https://api.github.com/users/qiqqq/repos","events_url":"https://api.github.com/users/qiqqq/events{/privacy}","received_events_url":"https://api.github.com/users/qiqqq/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-02-14T14:39:27Z","updated_at":"2018-02-15T09:29:51Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/DivanteLtd/vue-storefront/pulls/664","html_url":"https://github.com/DivanteLtd/vue-storefront/pull/664","diff_url":"https://github.com/DivanteLtd/vue-storefront/pull/664.diff","patch_url":"https://github.com/DivanteLtd/vue-storefront/pull/664.patch"},"body":"Regarding to changes in PromotedOffers.vue I added background-color classes in order to tiles shows correctly without images. Images are now theme-specific and some components like MainSlider or PromotedOffers use global JSON resource to read URLs to images. Now if there are no images in theme, component looks quiet good with background-color only.\r\n\r\nI think we should create another task to make some resources theme-specific (this requires also rebuilding core components that use global resources)"},"comment":{"url":"https://api.github.com/repos/DivanteLtd/vue-storefront/issues/comments/365870953","html_url":"https://github.com/DivanteLtd/vue-storefront/pull/664#issuecomment-365870953","issue_url":"https://api.github.com/repos/DivanteLtd/vue-storefront/issues/664","id":365870953,"user":{"login":"qiqqq","id":5213267,"avatar_url":"https://avatars0.githubusercontent.com/u/5213267?v=4","gravatar_id":"","url":"https://api.github.com/users/qiqqq","html_url":"https://github.com/qiqqq","followers_url":"https://api.github.com/users/qiqqq/followers","following_url":"https://api.github.com/users/qiqqq/following{/other_user}","gists_url":"https://api.github.com/users/qiqqq/gists{/gist_id}","starred_url":"https://api.github.com/users/qiqqq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qiqqq/subscriptions","organizations_url":"https://api.github.com/users/qiqqq/orgs","repos_url":"https://api.github.com/users/qiqqq/repos","events_url":"https://api.github.com/users/qiqqq/events{/privacy}","received_events_url":"https://api.github.com/users/qiqqq/received_events","type":"User","site_admin":false},"created_at":"2018-02-15T09:29:51Z","updated_at":"2018-02-15T09:29:51Z","author_association":"CONTRIBUTOR","body":"@filrak There is no need to change URLs to images. I added middleware so each image is serve from path /assets/*.* . Images can be placed both in global /asstes/ directory as in theme /assets/ directory and path stays these same. I don't see also any broken images on my local instance so I don't understand your request."}}
{"actor":{"display_login":"qiqqq"}}