{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/61909","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/61909/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/61909/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/61909/events","html_url":"https://github.com/kubernetes/kubernetes/pull/61909","id":309875784,"number":61909,"title":"Updating multicluster e2e test to ensure that controller only creates instance groups","user":{"login":"nikhiljindal","id":10199099,"avatar_url":"https://avatars0.githubusercontent.com/u/10199099?v=4","gravatar_id":"","url":"https://api.github.com/users/nikhiljindal","html_url":"https://github.com/nikhiljindal","followers_url":"https://api.github.com/users/nikhiljindal/followers","following_url":"https://api.github.com/users/nikhiljindal/following{/other_user}","gists_url":"https://api.github.com/users/nikhiljindal/gists{/gist_id}","starred_url":"https://api.github.com/users/nikhiljindal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikhiljindal/subscriptions","organizations_url":"https://api.github.com/users/nikhiljindal/orgs","repos_url":"https://api.github.com/users/nikhiljindal/repos","events_url":"https://api.github.com/users/nikhiljindal/events{/privacy}","received_events_url":"https://api.github.com/users/nikhiljindal/received_events","type":"User","site_admin":false},"labels":[{"id":477397086,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":349530249,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":253450934,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/M","name":"size/M","color":"eebb00","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-03-29T19:28:36Z","updated_at":"2018-03-29T19:52:50Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/61909","html_url":"https://github.com/kubernetes/kubernetes/pull/61909","diff_url":"https://github.com/kubernetes/kubernetes/pull/61909.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/61909.patch"},"body":"Ref https://github.com/kubernetes/ingress-gce/issues/182\r\n\r\nUpdating the multicluster ingress e2e test to also verify that the controller does not create any other resource than instance group.\r\n\r\nI was planning to do that using annotations first, but turns out that we have the right check for annotations: https://github.com/kubernetes/ingress-gce/blob/61d574a2c74fbb6f47e1aec0fae385cf2ca97aaf/pkg/controller/controller.go#L317 :)\r\n\r\nAm using `length(ListResource) == 0` now but have still kept the annotation check.\r\n\r\ncc @nicksardo @MrHohn @G-Harmon\r\n\r\n**Release note**:\r\n```release-note\r\nNONE\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/377346444","html_url":"https://github.com/kubernetes/kubernetes/pull/61909#issuecomment-377346444","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/61909","id":377346444,"user":{"login":"k8s-ci-robot","id":20407524,"avatar_url":"https://avatars0.githubusercontent.com/u/20407524?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2018-03-29T19:29:41Z","updated_at":"2018-03-29T19:29:41Z","author_association":"COLLABORATOR","body":"[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/61909#\" title=\"Author self-approved\">nikhiljindal</a>*\nTo fully approve this pull request, please assign additional approvers.\nWe suggest the following additional approver: **dcbw**\n\nAssign the PR to them by writing `/assign @dcbw` in a comment when ready.\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[test/e2e/network/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/test/e2e/network/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"dcbw\"]} -->"}}
{"actor":{"display_login":"k8s-ci-robot"}}