{"action":"closed","issue":{"url":"https://api.github.com/repos/rhboot/fwupdate/issues/101","repository_url":"https://api.github.com/repos/rhboot/fwupdate","labels_url":"https://api.github.com/repos/rhboot/fwupdate/issues/101/labels{/name}","comments_url":"https://api.github.com/repos/rhboot/fwupdate/issues/101/comments","events_url":"https://api.github.com/repos/rhboot/fwupdate/issues/101/events","html_url":"https://github.com/rhboot/fwupdate/issues/101","id":299118317,"number":101,"title":"Hardening breaks build","user":{"login":"jtojnar","id":705123,"avatar_url":"https://avatars1.githubusercontent.com/u/705123?v=4","gravatar_id":"","url":"https://api.github.com/users/jtojnar","html_url":"https://github.com/jtojnar","followers_url":"https://api.github.com/users/jtojnar/followers","following_url":"https://api.github.com/users/jtojnar/following{/other_user}","gists_url":"https://api.github.com/users/jtojnar/gists{/gist_id}","starred_url":"https://api.github.com/users/jtojnar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtojnar/subscriptions","organizations_url":"https://api.github.com/users/jtojnar/orgs","repos_url":"https://api.github.com/users/jtojnar/repos","events_url":"https://api.github.com/users/jtojnar/events{/privacy}","received_events_url":"https://api.github.com/users/jtojnar/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-02-21T20:32:59Z","updated_at":"2018-02-22T00:01:09Z","closed_at":"2018-02-22T00:01:09Z","author_association":"CONTRIBUTOR","body":"On NixOS, we use hardening by default and unless we disable `-fstack-protector-strong --param ssp-buffer-size=4`, the build will fail with:\r\n\r\n```\r\nmake[1]: Entering directory '/build/fwupdate-10/efi'\r\ngcc -Og -g3 -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -fpic -Werror -Wall -Wextra -fshort-wchar -fno-merge-constants -ffreestanding -fno-stack-protector -fno-stack-check --std=gnu11 -DCONFIG_x86_64 -I/usr/include/efi/ -I/usr/include/efi/x86_64/ -iquote/build/fwupdate-10/include \"-DDEBUGDIR=L\\\"/\\\"\" -mno-mmx -mno-sse -mno-red-zone -nostdinc -maccumulate-outgoing-args -DEFI_FUNCTION_WRAPPER -DGNU_EFI_USE_MS_ABI -I/nix/store/0081d66ckxlrsyszlxhjbmcn3z11wxcd-gcc-6.4.0/lib/gcc/x86_64-unknown-linux-gnu/6.4.0/include -c -o fakeesrt2.o fakeesrt2.c\r\ngcc -nostdlib -Wl,--warn-common -Wl,--no-undefined -Wl,--fatal-warnings -Wl,-shared -Wl,-Bsymbolic -L/nix/store/0r8wbqnswd73zi404qribx56sl6y6vag-fwupdate-10/lib -L/nix/store/vs2691kx6grcn3qwv97xibdj1mlj1cbj-gnu-efi-3.0.6/lib -Wl,--build-id=sha1 -Wl,--hash-style=sysv /nix/store/vs2691kx6grcn3qwv97xibdj1mlj1cbj-gnu-efi-3.0.6/lib/crt0-efi-x86_64.o -o fakeesrt2.so fakeesrt2.o -lefi -lgnuefi \\\r\n        /nix/store/0081d66ckxlrsyszlxhjbmcn3z11wxcd-gcc-6.4.0/lib/gcc/x86_64-unknown-linux-gnu/6.4.0/libgcc.a \\\r\n        -T elf_x86_64_efi.lds\r\nfakeesrt2.o: In function `efi_main':\r\n/build/fwupdate-10/efi/fakeesrt2.c:56: undefined reference to `__stack_chk_fail'\r\ncollect2: error: ld returned 1 exit status\r\nmake[1]: *** [/build/fwupdate-10/efi/Makefile:107: fakeesrt2.so] Error 1\r\nrm fakeesrt2.o\r\nmake[1]: Leaving directory '/build/fwupdate-10/efi'\r\nmake: *** [Makefile:15: all] Error 2\r\n```"}}
{"actor":{"display_login":"jtojnar"}}