{"action":"created","comment":{"url":"https://api.github.com/repos/ARM-software/lisa/pulls/comments/218518777","pull_request_review_id":156468082,"id":218518777,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxODUxODc3Nw==","diff_hunk":"@@ -0,0 +1,85 @@\n+#!/bin/bash\n+set -eu\n+\n+BUILDROOT_URI=git://git.busybox.net/buildroot\n+BUILDROOT_VERSION=2018.08\n+BUILDROOT_DIR=$LISA_HOME/src/buildroot\n+BUILDROOT_PATCHES_DIR=$(dirname $0)/buildroot_patches\n+BUILDROOT_CONFIG=$(dirname $0)/buildroot_config\n+\n+function print_usage {\n+\techo \"Usage: $0 [options]\"\n+\techo \"\toptions:\"\n+\techo \"\t\t-p: purge buildroot to force a fresh build\"\n+\techo \"\t\t-h: print this help message\"\n+}\n+\n+while getopts \"hp\" opt\n+do\n+\tcase $opt in\n+\t\th)\n+\t\t\tprint_usage\n+\t\t\texit 0\n+\t\t\t;;\n+\t\tp)\n+\t\t\trm -rf $BUILDROOT_DIR\n+\t\t\texit 0\n+\t\t\t;;\n+\t\t?)\n+\t\t\tprint_usage\n+\t\t\texit -1\n+\t\t\t;;\n+\tesac\n+done\n+\n+# Executed command @$1 if file @$2 doesn't exist\n+function do_if {\n+\tif [ ! -e $2 ]; then\n+\t\t$1\n+\t\ttouch $2\n+\tfi\n+}\n+\n+function br_clone {\n+\tgit clone $BUILDROOT_URI $BUILDROOT_DIR\n+}\n+\n+function br_checkout_version {\n+\tpushd $BUILDROOT_DIR > /dev/null\n+\tgit checkout -b $BUILDROOT_VERSION $BUILDROOT_VERSION\n+\tpopd > /dev/null\n+}\n+\n+function br_patch {\n+\tpushd $BUILDROOT_DIR > /dev/null\n+\tfor patch in $(ls $BUILDROOT_PATCHES_DIR)\n+\tdo\n+\t\tgit am $patch\n+\tdone\n+\tpopd > /dev/null\n+}\n+\n+function br_apply_config {\n+\tcp $BUILDROOT_CONFIG $BUILDROOT_DIR/.config\n+\tmake -C $BUILDROOT_DIR olddefconfig\n+}\n+\n+\n+do_if br_clone $BUILDROOT_DIR/.lisa_cloned\n+\n+do_if br_checkout_version $BUILDROOT_DIR/.lisa_checked_out_$BUILDROOT_VERSION\n+\n+do_if br_patch $BUILDROOT_DIR/.lisa_patched\n+\n+do_if br_apply_config $BUILDROOT_DIR/.lisa_applied_config\n+\n+make -C $BUILDROOT_DIR\n+\n+# Generate ssh-keys so that they persist across multiple runs\n+ssh-keygen -A -f $BUILDROOT_DIR/output/target/\n+# Enable root login on sshd\n+sed -i 's/#PermitRootLogin.*/PermitRootLogin\tyes/' $BUILDROOT_DIR/output/target/etc/ssh/sshd_config\n+\n+make -C $BUILDROOT_DIR\n+\n+echo \"---===::: rootfs was created at $BUILDROOT_DIR/output/images/rootfs.cpio.xz :::===---\"","path":"src/shell/lisa_gen_buildroot_rootfs","position":85,"original_position":85,"commit_id":"d584891539ce29828b8011a5513d14ab45c51694","original_commit_id":"d584891539ce29828b8011a5513d14ab45c51694","user":{"login":"derkling","id":63746,"node_id":"MDQ6VXNlcjYzNzQ2","avatar_url":"https://avatars3.githubusercontent.com/u/63746?v=4","gravatar_id":"","url":"https://api.github.com/users/derkling","html_url":"https://github.com/derkling","followers_url":"https://api.github.com/users/derkling/followers","following_url":"https://api.github.com/users/derkling/following{/other_user}","gists_url":"https://api.github.com/users/derkling/gists{/gist_id}","starred_url":"https://api.github.com/users/derkling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derkling/subscriptions","organizations_url":"https://api.github.com/users/derkling/orgs","repos_url":"https://api.github.com/users/derkling/repos","events_url":"https://api.github.com/users/derkling/events{/privacy}","received_events_url":"https://api.github.com/users/derkling/received_events","type":"User","site_admin":false},"body":"I would split the status lien and the output product on different lines for better readability, i.e. something like:\r\n```bash\r\necho \"---===::: RootFS Created :::===---\"\r\necho \"Path: $BUILDROOT_DIR/output/images/rootfs.cpio.xz\"\r\n```","created_at":"2018-09-18T17:12:52Z","updated_at":"2018-09-18T17:17:23Z","html_url":"https://github.com/ARM-software/lisa/pull/628#discussion_r218518777","pull_request_url":"https://api.github.com/repos/ARM-software/lisa/pulls/628","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ARM-software/lisa/pulls/comments/218518777"},"html":{"href":"https://github.com/ARM-software/lisa/pull/628#discussion_r218518777"},"pull_request":{"href":"https://api.github.com/repos/ARM-software/lisa/pulls/628"}}},"pull_request":{"url":"https://api.github.com/repos/ARM-software/lisa/pulls/628","id":216291489,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2MjkxNDg5","html_url":"https://github.com/ARM-software/lisa/pull/628","diff_url":"https://github.com/ARM-software/lisa/pull/628.diff","patch_url":"https://github.com/ARM-software/lisa/pull/628.patch","issue_url":"https://api.github.com/repos/ARM-software/lisa/issues/628","number":628,"state":"open","locked":false,"title":"lisa_shell: add a new function to generate buildroot rootfs","user":{"login":"qais-yousef","id":16548712,"node_id":"MDQ6VXNlcjE2NTQ4NzEy","avatar_url":"https://avatars2.githubusercontent.com/u/16548712?v=4","gravatar_id":"","url":"https://api.github.com/users/qais-yousef","html_url":"https://github.com/qais-yousef","followers_url":"https://api.github.com/users/qais-yousef/followers","following_url":"https://api.github.com/users/qais-yousef/following{/other_user}","gists_url":"https://api.github.com/users/qais-yousef/gists{/gist_id}","starred_url":"https://api.github.com/users/qais-yousef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qais-yousef/subscriptions","organizations_url":"https://api.github.com/users/qais-yousef/orgs","repos_url":"https://api.github.com/users/qais-yousef/repos","events_url":"https://api.github.com/users/qais-yousef/events{/privacy}","received_events_url":"https://api.github.com/users/qais-yousef/received_events","type":"User","site_admin":false},"body":"buildroot rootfs are a better choice to run lisa tests on as they are\r\nquieter and provide a minimal userspace that allows testing kernel\r\nfunctionality with minimum interference from userland. Also it is less\r\nof a maintanence burden as it's unlikely to find unexpected things\r\nconfigured without our knowledge that might intefere with some of the\r\ntests or skew their results.\r\n\r\nA recent example was found in systemd indirectly causing higher number\r\nof kthreads to run on debian and arch-linux distro's which caused random\r\nnumber of failure rates in cpu migration load tracking tests.\r\n\r\nSigned-off-by: Qais Yousef <qais.yousef@arm.com>","created_at":"2018-09-18T12:35:22Z","updated_at":"2018-09-18T17:17:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f41dd7f3fd06889a093566ed68c1f5c6f42f1df6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ARM-software/lisa/pulls/628/commits","review_comments_url":"https://api.github.com/repos/ARM-software/lisa/pulls/628/comments","review_comment_url":"https://api.github.com/repos/ARM-software/lisa/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ARM-software/lisa/issues/628/comments","statuses_url":"https://api.github.com/repos/ARM-software/lisa/statuses/d584891539ce29828b8011a5513d14ab45c51694","head":{"label":"qais-yousef:buildroot-rootfs","ref":"buildroot-rootfs","sha":"d584891539ce29828b8011a5513d14ab45c51694","user":{"login":"qais-yousef","id":16548712,"node_id":"MDQ6VXNlcjE2NTQ4NzEy","avatar_url":"https://avatars2.githubusercontent.com/u/16548712?v=4","gravatar_id":"","url":"https://api.github.com/users/qais-yousef","html_url":"https://github.com/qais-yousef","followers_url":"https://api.github.com/users/qais-yousef/followers","following_url":"https://api.github.com/users/qais-yousef/following{/other_user}","gists_url":"https://api.github.com/users/qais-yousef/gists{/gist_id}","starred_url":"https://api.github.com/users/qais-yousef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qais-yousef/subscriptions","organizations_url":"https://api.github.com/users/qais-yousef/orgs","repos_url":"https://api.github.com/users/qais-yousef/repos","events_url":"https://api.github.com/users/qais-yousef/events{/privacy}","received_events_url":"https://api.github.com/users/qais-yousef/received_events","type":"User","site_admin":false},"repo":{"id":144586487,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ1ODY0ODc=","name":"lisa","full_name":"qais-yousef/lisa","private":false,"owner":{"login":"qais-yousef","id":16548712,"node_id":"MDQ6VXNlcjE2NTQ4NzEy","avatar_url":"https://avatars2.githubusercontent.com/u/16548712?v=4","gravatar_id":"","url":"https://api.github.com/users/qais-yousef","html_url":"https://github.com/qais-yousef","followers_url":"https://api.github.com/users/qais-yousef/followers","following_url":"https://api.github.com/users/qais-yousef/following{/other_user}","gists_url":"https://api.github.com/users/qais-yousef/gists{/gist_id}","starred_url":"https://api.github.com/users/qais-yousef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qais-yousef/subscriptions","organizations_url":"https://api.github.com/users/qais-yousef/orgs","repos_url":"https://api.github.com/users/qais-yousef/repos","events_url":"https://api.github.com/users/qais-yousef/events{/privacy}","received_events_url":"https://api.github.com/users/qais-yousef/received_events","type":"User","site_admin":false},"html_url":"https://github.com/qais-yousef/lisa","description":"Linux Integrated System Analysis","fork":true,"url":"https://api.github.com/repos/qais-yousef/lisa","forks_url":"https://api.github.com/repos/qais-yousef/lisa/forks","keys_url":"https://api.github.com/repos/qais-yousef/lisa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qais-yousef/lisa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qais-yousef/lisa/teams","hooks_url":"https://api.github.com/repos/qais-yousef/lisa/hooks","issue_events_url":"https://api.github.com/repos/qais-yousef/lisa/issues/events{/number}","events_url":"https://api.github.com/repos/qais-yousef/lisa/events","assignees_url":"https://api.github.com/repos/qais-yousef/lisa/assignees{/user}","branches_url":"https://api.github.com/repos/qais-yousef/lisa/branches{/branch}","tags_url":"https://api.github.com/repos/qais-yousef/lisa/tags","blobs_url":"https://api.github.com/repos/qais-yousef/lisa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qais-yousef/lisa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qais-yousef/lisa/git/refs{/sha}","trees_url":"https://api.github.com/repos/qais-yousef/lisa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qais-yousef/lisa/statuses/{sha}","languages_url":"https://api.github.com/repos/qais-yousef/lisa/languages","stargazers_url":"https://api.github.com/repos/qais-yousef/lisa/stargazers","contributors_url":"https://api.github.com/repos/qais-yousef/lisa/contributors","subscribers_url":"https://api.github.com/repos/qais-yousef/lisa/subscribers","subscription_url":"https://api.github.com/repos/qais-yousef/lisa/subscription","commits_url":"https://api.github.com/repos/qais-yousef/lisa/commits{/sha}","git_commits_url":"https://api.github.com/repos/qais-yousef/lisa/git/commits{/sha}","comments_url":"https://api.github.com/repos/qais-yousef/lisa/comments{/number}","issue_comment_url":"https://api.github.com/repos/qais-yousef/lisa/issues/comments{/number}","contents_url":"https://api.github.com/repos/qais-yousef/lisa/contents/{+path}","compare_url":"https://api.github.com/repos/qais-yousef/lisa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qais-yousef/lisa/merges","archive_url":"https://api.github.com/repos/qais-yousef/lisa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qais-yousef/lisa/downloads","issues_url":"https://api.github.com/repos/qais-yousef/lisa/issues{/number}","pulls_url":"https://api.github.com/repos/qais-yousef/lisa/pulls{/number}","milestones_url":"https://api.github.com/repos/qais-yousef/lisa/milestones{/number}","notifications_url":"https://api.github.com/repos/qais-yousef/lisa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qais-yousef/lisa/labels{/name}","releases_url":"https://api.github.com/repos/qais-yousef/lisa/releases{/id}","deployments_url":"https://api.github.com/repos/qais-yousef/lisa/deployments","created_at":"2018-08-13T13:52:20Z","updated_at":"2018-08-31T10:36:49Z","pushed_at":"2018-09-18T12:27:34Z","git_url":"git://github.com/qais-yousef/lisa.git","ssh_url":"git@github.com:qais-yousef/lisa.git","clone_url":"https://github.com/qais-yousef/lisa.git","svn_url":"https://github.com/qais-yousef/lisa","homepage":"","size":77203,"stargazers_count":0,"watchers_count":0,"language":"Jupyter Notebook","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ARM-software:master","ref":"master","sha":"49bd25ada9c7741d56bcd27996f5b2202750774a","user":{"login":"ARM-software","id":5690313,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTAzMTM=","avatar_url":"https://avatars1.githubusercontent.com/u/5690313?v=4","gravatar_id":"","url":"https://api.github.com/users/ARM-software","html_url":"https://github.com/ARM-software","followers_url":"https://api.github.com/users/ARM-software/followers","following_url":"https://api.github.com/users/ARM-software/following{/other_user}","gists_url":"https://api.github.com/users/ARM-software/gists{/gist_id}","starred_url":"https://api.github.com/users/ARM-software/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARM-software/subscriptions","organizations_url":"https://api.github.com/users/ARM-software/orgs","repos_url":"https://api.github.com/users/ARM-software/repos","events_url":"https://api.github.com/users/ARM-software/events{/privacy}","received_events_url":"https://api.github.com/users/ARM-software/received_events","type":"Organization","site_admin":false},"repo":{"id":47548304,"node_id":"MDEwOlJlcG9zaXRvcnk0NzU0ODMwNA==","name":"lisa","full_name":"ARM-software/lisa","private":false,"owner":{"login":"ARM-software","id":5690313,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTAzMTM=","avatar_url":"https://avatars1.githubusercontent.com/u/5690313?v=4","gravatar_id":"","url":"https://api.github.com/users/ARM-software","html_url":"https://github.com/ARM-software","followers_url":"https://api.github.com/users/ARM-software/followers","following_url":"https://api.github.com/users/ARM-software/following{/other_user}","gists_url":"https://api.github.com/users/ARM-software/gists{/gist_id}","starred_url":"https://api.github.com/users/ARM-software/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARM-software/subscriptions","organizations_url":"https://api.github.com/users/ARM-software/orgs","repos_url":"https://api.github.com/users/ARM-software/repos","events_url":"https://api.github.com/users/ARM-software/events{/privacy}","received_events_url":"https://api.github.com/users/ARM-software/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ARM-software/lisa","description":"Linux Integrated System Analysis","fork":false,"url":"https://api.github.com/repos/ARM-software/lisa","forks_url":"https://api.github.com/repos/ARM-software/lisa/forks","keys_url":"https://api.github.com/repos/ARM-software/lisa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ARM-software/lisa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ARM-software/lisa/teams","hooks_url":"https://api.github.com/repos/ARM-software/lisa/hooks","issue_events_url":"https://api.github.com/repos/ARM-software/lisa/issues/events{/number}","events_url":"https://api.github.com/repos/ARM-software/lisa/events","assignees_url":"https://api.github.com/repos/ARM-software/lisa/assignees{/user}","branches_url":"https://api.github.com/repos/ARM-software/lisa/branches{/branch}","tags_url":"https://api.github.com/repos/ARM-software/lisa/tags","blobs_url":"https://api.github.com/repos/ARM-software/lisa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ARM-software/lisa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ARM-software/lisa/git/refs{/sha}","trees_url":"https://api.github.com/repos/ARM-software/lisa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ARM-software/lisa/statuses/{sha}","languages_url":"https://api.github.com/repos/ARM-software/lisa/languages","stargazers_url":"https://api.github.com/repos/ARM-software/lisa/stargazers","contributors_url":"https://api.github.com/repos/ARM-software/lisa/contributors","subscribers_url":"https://api.github.com/repos/ARM-software/lisa/subscribers","subscription_url":"https://api.github.com/repos/ARM-software/lisa/subscription","commits_url":"https://api.github.com/repos/ARM-software/lisa/commits{/sha}","git_commits_url":"https://api.github.com/repos/ARM-software/lisa/git/commits{/sha}","comments_url":"https://api.github.com/repos/ARM-software/lisa/comments{/number}","issue_comment_url":"https://api.github.com/repos/ARM-software/lisa/issues/comments{/number}","contents_url":"https://api.github.com/repos/ARM-software/lisa/contents/{+path}","compare_url":"https://api.github.com/repos/ARM-software/lisa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ARM-software/lisa/merges","archive_url":"https://api.github.com/repos/ARM-software/lisa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ARM-software/lisa/downloads","issues_url":"https://api.github.com/repos/ARM-software/lisa/issues{/number}","pulls_url":"https://api.github.com/repos/ARM-software/lisa/pulls{/number}","milestones_url":"https://api.github.com/repos/ARM-software/lisa/milestones{/number}","notifications_url":"https://api.github.com/repos/ARM-software/lisa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ARM-software/lisa/labels{/name}","releases_url":"https://api.github.com/repos/ARM-software/lisa/releases{/id}","deployments_url":"https://api.github.com/repos/ARM-software/lisa/deployments","created_at":"2015-12-07T11:32:56Z","updated_at":"2018-09-16T05:22:35Z","pushed_at":"2018-09-18T12:35:22Z","git_url":"git://github.com/ARM-software/lisa.git","ssh_url":"git@github.com:ARM-software/lisa.git","clone_url":"https://github.com/ARM-software/lisa.git","svn_url":"https://github.com/ARM-software/lisa","homepage":"","size":77083,"stargazers_count":64,"watchers_count":64,"language":"Jupyter Notebook","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":55,"mirror_url":null,"archived":false,"open_issues_count":76,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":55,"open_issues":76,"watchers":64,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ARM-software/lisa/pulls/628"},"html":{"href":"https://github.com/ARM-software/lisa/pull/628"},"issue":{"href":"https://api.github.com/repos/ARM-software/lisa/issues/628"},"comments":{"href":"https://api.github.com/repos/ARM-software/lisa/issues/628/comments"},"review_comments":{"href":"https://api.github.com/repos/ARM-software/lisa/pulls/628/comments"},"review_comment":{"href":"https://api.github.com/repos/ARM-software/lisa/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ARM-software/lisa/pulls/628/commits"},"statuses":{"href":"https://api.github.com/repos/ARM-software/lisa/statuses/d584891539ce29828b8011a5513d14ab45c51694"}},"author_association":"NONE"}}
{"actor":{"display_login":"derkling"}}