{"action":"created","issue":{"url":"https://api.github.com/repos/home-assistant/home-assistant/issues/17681","repository_url":"https://api.github.com/repos/home-assistant/home-assistant","labels_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/17681/labels{/name}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/17681/comments","events_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/17681/events","html_url":"https://github.com/home-assistant/home-assistant/pull/17681","id":372365145,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0NTc0NTE0","number":17681,"title":"WIP: Koogeek sensor platform based on Homekit_controller","user":{"login":"drndos","id":5576134,"node_id":"MDQ6VXNlcjU1NzYxMzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/5576134?v=4","gravatar_id":"","url":"https://api.github.com/users/drndos","html_url":"https://github.com/drndos","followers_url":"https://api.github.com/users/drndos/followers","following_url":"https://api.github.com/users/drndos/following{/other_user}","gists_url":"https://api.github.com/users/drndos/gists{/gist_id}","starred_url":"https://api.github.com/users/drndos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drndos/subscriptions","organizations_url":"https://api.github.com/users/drndos/orgs","repos_url":"https://api.github.com/users/drndos/repos","events_url":"https://api.github.com/users/drndos/events{/privacy}","received_events_url":"https://api.github.com/users/drndos/received_events","type":"User","site_admin":false},"labels":[{"id":450787042,"node_id":"MDU6TGFiZWw0NTA3ODcwNDI=","url":"https://api.github.com/repos/home-assistant/home-assistant/labels/Hacktoberfest","name":"Hacktoberfest","color":"fbca04","default":false},{"id":527871105,"node_id":"MDU6TGFiZWw1Mjc4NzExMDU=","url":"https://api.github.com/repos/home-assistant/home-assistant/labels/cla-signed","name":"cla-signed","color":"008000","default":false},{"id":873190166,"node_id":"MDU6TGFiZWw4NzMxOTAxNjY=","url":"https://api.github.com/repos/home-assistant/home-assistant/labels/component:%20homekit_controller","name":"component: homekit_controller","color":"ededed","default":false},{"id":451931292,"node_id":"MDU6TGFiZWw0NTE5MzEyOTI=","url":"https://api.github.com/repos/home-assistant/home-assistant/labels/core","name":"core","color":"c5def5","default":false},{"id":955422305,"node_id":"MDU6TGFiZWw5NTU0MjIzMDU=","url":"https://api.github.com/repos/home-assistant/home-assistant/labels/in%20progress","name":"in progress","color":"ededed","default":false},{"id":526146744,"node_id":"MDU6TGFiZWw1MjYxNDY3NDQ=","url":"https://api.github.com/repos/home-assistant/home-assistant/labels/new-platform","name":"new-platform","color":"5319e7","default":false},{"id":1099304336,"node_id":"MDU6TGFiZWwxMDk5MzA0MzM2","url":"https://api.github.com/repos/home-assistant/home-assistant/labels/platform:%20sensor.koogeek","name":"platform: sensor.koogeek","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-21T22:43:32Z","updated_at":"2018-10-25T21:29:13Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/17681","html_url":"https://github.com/home-assistant/home-assistant/pull/17681","diff_url":"https://github.com/home-assistant/home-assistant/pull/17681.diff","patch_url":"https://github.com/home-assistant/home-assistant/pull/17681.patch"},"body":"Add Koogeek sensor platform\r\nAdd Dispatching mechanism for vendor specific homekit services to corresponding platforms\r\nAdd constant for watt-hours\r\n\r\n## Description:\r\nThis Pull request adds support for custom vendor specific homekit services and Koogeek sensor platform. It was tested on Koogeek P1EU homekit device.\r\n![image](https://user-images.githubusercontent.com/5576134/47273510-a92de200-d595-11e8-8764-95d3d135a6bd.png)\r\nTBD: Parse and format the Base64 data for statistics data or ignore it.\r\n\r\nThis pull request is work in progress. More testing is needed, especially we need to test more Koogeek devices. (Maybe it should be called KoogeekP1EUSensor or something like that, I don't know if it works for all koogeek outlets or just P1EU)\r\n\r\nAlso I would like to do better documentation about homekit_controller platform (missing!), how it works, example services and JSON structure and also the final mechanism of dispatching and platforms (this PR).\r\n\r\nMaybe there is better way to dispatch the service IDs to corresponding platform ?\r\n\r\n**Related issue (if applicable):** fixes #<home-assistant issue number goes here>\r\n\r\n**Pull request in [home-assistant.io](https://github.com/home-assistant/home-assistant.io) with documentation (if applicable):** home-assistant/home-assistant.io#<home-assistant.io PR number goes here>\r\nTBD\r\n\r\n## Example entry for `configuration.yaml` (if applicable):\r\nN/A\r\n\r\n## Checklist:\r\n  - [x] The code change is tested and works locally.\r\n  - [ ] Local tests pass with `tox`. **Your PR cannot be merged unless tests pass**\r\n\r\nIf user exposed functionality or configuration variables are added/changed:\r\n  - [ ] Documentation added/updated in [home-assistant.io](https://github.com/home-assistant/home-assistant.io)\r\n\r\nIf the code communicates with devices, web services, or third-party tools:\r\n  - N/A New dependencies have been added to the `REQUIREMENTS` variable ([example][ex-requir]).\r\n  - N/A New dependencies are only imported inside functions that use them ([example][ex-import]).\r\n  - N/A New or updated dependencies have been added to `requirements_all.txt` by running `script/gen_requirements_all.py`.\r\n  - [x] New files were added to `.coveragerc`.\r\n\r\nIf the code does not interact with devices:\r\n  - [ ] Tests have been added to verify that the new code works.\r\n\r\n[ex-requir]: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/keyboard.py#L14\r\n[ex-import]: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/keyboard.py#L54\r\n"},"comment":{"url":"https://api.github.com/repos/home-assistant/home-assistant/issues/comments/433212332","html_url":"https://github.com/home-assistant/home-assistant/pull/17681#issuecomment-433212332","issue_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/17681","id":433212332,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMzIxMjMzMg==","user":{"login":"frenck","id":195327,"node_id":"MDQ6VXNlcjE5NTMyNw==","avatar_url":"https://avatars0.githubusercontent.com/u/195327?v=4","gravatar_id":"","url":"https://api.github.com/users/frenck","html_url":"https://github.com/frenck","followers_url":"https://api.github.com/users/frenck/followers","following_url":"https://api.github.com/users/frenck/following{/other_user}","gists_url":"https://api.github.com/users/frenck/gists{/gist_id}","starred_url":"https://api.github.com/users/frenck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frenck/subscriptions","organizations_url":"https://api.github.com/users/frenck/orgs","repos_url":"https://api.github.com/users/frenck/repos","events_url":"https://api.github.com/users/frenck/events{/privacy}","received_events_url":"https://api.github.com/users/frenck/received_events","type":"User","site_admin":false},"created_at":"2018-10-25T21:29:13Z","updated_at":"2018-10-25T21:29:13Z","author_association":"MEMBER","body":"Could not find a matching PR on our documentation repository. Adding `docs-missing` label."}}
{"actor":{"display_login":"frenck"}}