{"action":"created","comment":{"url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments/173235283","pull_request_review_id":102391721,"id":173235283,"diff_hunk":"@@ -196,6 +196,9 @@ void fault_print_str(char *fmtstr, uint32_t *values)\n     while(fmtstr[i] != '\\0') {\n         if(fmtstr[i] == '\\n' || fmtstr[i] == '\\r') {\n             serial_putc(&stdio_uart, '\\r');\n+            if (fmtstr[i] == '\\n') {\n+        \t    serial_putc(&stdio_uart, '\\n');\n+            }","path":"rtos/TARGET_CORTEX/TARGET_CORTEX_M/mbed_rtx_fault_handler.c","position":6,"original_position":6,"commit_id":"01cdc8295b2371018302e5888554108f935f76c9","original_commit_id":"01cdc8295b2371018302e5888554108f935f76c9","user":{"login":"geky","id":1075160,"avatar_url":"https://avatars3.githubusercontent.com/u/1075160?v=4","gravatar_id":"","url":"https://api.github.com/users/geky","html_url":"https://github.com/geky","followers_url":"https://api.github.com/users/geky/followers","following_url":"https://api.github.com/users/geky/following{/other_user}","gists_url":"https://api.github.com/users/geky/gists{/gist_id}","starred_url":"https://api.github.com/users/geky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geky/subscriptions","organizations_url":"https://api.github.com/users/geky/orgs","repos_url":"https://api.github.com/users/geky/repos","events_url":"https://api.github.com/users/geky/events{/privacy}","received_events_url":"https://api.github.com/users/geky/received_events","type":"User","site_admin":false},"body":"Hmm, wouldn't the '\\r' still go through the else statement and get printed out?\r\n``` c\r\nif(fmtstr[i] == '\\n') {\r\n     serial_putc(&stdio_uart, '\\r');\r\n     serial_putc(&stdio_uart, '\\n');\r\n} else {\r\n     if(fmtstr[i]=='%') {\r\n         hex_to_str(values[vidx++],hex_str);\r\n         for(idx=7; idx>=0; idx--) {\r\n             serial_putc(&stdio_uart, hex_str[idx]);\r\n         }\r\n     } else {\r\n         serial_putc(&stdio_uart, fmtstr[i]);\r\n     }\r\n}\r\n```","created_at":"2018-03-08T17:43:24Z","updated_at":"2018-03-08T17:43:24Z","html_url":"https://github.com/ARMmbed/mbed-os/pull/6302#discussion_r173235283","pull_request_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/6302","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments/173235283"},"html":{"href":"https://github.com/ARMmbed/mbed-os/pull/6302#discussion_r173235283"},"pull_request":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/6302"}},"in_reply_to_id":173188866},"pull_request":{"url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/6302","id":173720715,"html_url":"https://github.com/ARMmbed/mbed-os/pull/6302","diff_url":"https://github.com/ARMmbed/mbed-os/pull/6302.diff","patch_url":"https://github.com/ARMmbed/mbed-os/pull/6302.patch","issue_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/6302","number":6302,"state":"open","locked":false,"title":"Fix issue in fault handler","user":{"login":"netanelgonen","id":17008964,"avatar_url":"https://avatars3.githubusercontent.com/u/17008964?v=4","gravatar_id":"","url":"https://api.github.com/users/netanelgonen","html_url":"https://github.com/netanelgonen","followers_url":"https://api.github.com/users/netanelgonen/followers","following_url":"https://api.github.com/users/netanelgonen/following{/other_user}","gists_url":"https://api.github.com/users/netanelgonen/gists{/gist_id}","starred_url":"https://api.github.com/users/netanelgonen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netanelgonen/subscriptions","organizations_url":"https://api.github.com/users/netanelgonen/orgs","repos_url":"https://api.github.com/users/netanelgonen/repos","events_url":"https://api.github.com/users/netanelgonen/events{/privacy}","received_events_url":"https://api.github.com/users/netanelgonen/received_events","type":"User","site_admin":false},"body":"### Description\r\n\r\nIncase used \\r or \\n inside the prints of the fault handler\r\nfault_print_str function would only \\r.\r\nThe fix is adding \\n if needed\r\n\r\n### Pull request type\r\n\r\n- [x] Fix\r\n","created_at":"2018-03-08T12:14:43Z","updated_at":"2018-03-08T17:43:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2ac28ae82ded5e3db902b16865d9ccd7afc9a360","assignee":null,"assignees":[],"requested_reviewers":[{"login":"SenRamakri","id":31017510,"avatar_url":"https://avatars0.githubusercontent.com/u/31017510?v=4","gravatar_id":"","url":"https://api.github.com/users/SenRamakri","html_url":"https://github.com/SenRamakri","followers_url":"https://api.github.com/users/SenRamakri/followers","following_url":"https://api.github.com/users/SenRamakri/following{/other_user}","gists_url":"https://api.github.com/users/SenRamakri/gists{/gist_id}","starred_url":"https://api.github.com/users/SenRamakri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SenRamakri/subscriptions","organizations_url":"https://api.github.com/users/SenRamakri/orgs","repos_url":"https://api.github.com/users/SenRamakri/repos","events_url":"https://api.github.com/users/SenRamakri/events{/privacy}","received_events_url":"https://api.github.com/users/SenRamakri/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":450730107,"url":"https://api.github.com/repos/ARMmbed/mbed-os/labels/Scope:%20bug-fix","name":"Scope: bug-fix","color":"c2e0c6","default":false},{"id":147112891,"url":"https://api.github.com/repos/ARMmbed/mbed-os/labels/needs:%20review","name":"needs: review","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/6302/commits","review_comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/6302/comments","review_comment_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/6302/comments","statuses_url":"https://api.github.com/repos/ARMmbed/mbed-os/statuses/01cdc8295b2371018302e5888554108f935f76c9","head":{"label":"netanelgonen:dev","ref":"dev","sha":"01cdc8295b2371018302e5888554108f935f76c9","user":{"login":"netanelgonen","id":17008964,"avatar_url":"https://avatars3.githubusercontent.com/u/17008964?v=4","gravatar_id":"","url":"https://api.github.com/users/netanelgonen","html_url":"https://github.com/netanelgonen","followers_url":"https://api.github.com/users/netanelgonen/followers","following_url":"https://api.github.com/users/netanelgonen/following{/other_user}","gists_url":"https://api.github.com/users/netanelgonen/gists{/gist_id}","starred_url":"https://api.github.com/users/netanelgonen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netanelgonen/subscriptions","organizations_url":"https://api.github.com/users/netanelgonen/orgs","repos_url":"https://api.github.com/users/netanelgonen/repos","events_url":"https://api.github.com/users/netanelgonen/events{/privacy}","received_events_url":"https://api.github.com/users/netanelgonen/received_events","type":"User","site_admin":false},"repo":{"id":74387189,"name":"mbed-os","full_name":"netanelgonen/mbed-os","owner":{"login":"netanelgonen","id":17008964,"avatar_url":"https://avatars3.githubusercontent.com/u/17008964?v=4","gravatar_id":"","url":"https://api.github.com/users/netanelgonen","html_url":"https://github.com/netanelgonen","followers_url":"https://api.github.com/users/netanelgonen/followers","following_url":"https://api.github.com/users/netanelgonen/following{/other_user}","gists_url":"https://api.github.com/users/netanelgonen/gists{/gist_id}","starred_url":"https://api.github.com/users/netanelgonen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netanelgonen/subscriptions","organizations_url":"https://api.github.com/users/netanelgonen/orgs","repos_url":"https://api.github.com/users/netanelgonen/repos","events_url":"https://api.github.com/users/netanelgonen/events{/privacy}","received_events_url":"https://api.github.com/users/netanelgonen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/netanelgonen/mbed-os","description":"ARM mbed OS is a platform operating system designed for the internet of things","fork":true,"url":"https://api.github.com/repos/netanelgonen/mbed-os","forks_url":"https://api.github.com/repos/netanelgonen/mbed-os/forks","keys_url":"https://api.github.com/repos/netanelgonen/mbed-os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/netanelgonen/mbed-os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/netanelgonen/mbed-os/teams","hooks_url":"https://api.github.com/repos/netanelgonen/mbed-os/hooks","issue_events_url":"https://api.github.com/repos/netanelgonen/mbed-os/issues/events{/number}","events_url":"https://api.github.com/repos/netanelgonen/mbed-os/events","assignees_url":"https://api.github.com/repos/netanelgonen/mbed-os/assignees{/user}","branches_url":"https://api.github.com/repos/netanelgonen/mbed-os/branches{/branch}","tags_url":"https://api.github.com/repos/netanelgonen/mbed-os/tags","blobs_url":"https://api.github.com/repos/netanelgonen/mbed-os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/netanelgonen/mbed-os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/netanelgonen/mbed-os/git/refs{/sha}","trees_url":"https://api.github.com/repos/netanelgonen/mbed-os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/netanelgonen/mbed-os/statuses/{sha}","languages_url":"https://api.github.com/repos/netanelgonen/mbed-os/languages","stargazers_url":"https://api.github.com/repos/netanelgonen/mbed-os/stargazers","contributors_url":"https://api.github.com/repos/netanelgonen/mbed-os/contributors","subscribers_url":"https://api.github.com/repos/netanelgonen/mbed-os/subscribers","subscription_url":"https://api.github.com/repos/netanelgonen/mbed-os/subscription","commits_url":"https://api.github.com/repos/netanelgonen/mbed-os/commits{/sha}","git_commits_url":"https://api.github.com/repos/netanelgonen/mbed-os/git/commits{/sha}","comments_url":"https://api.github.com/repos/netanelgonen/mbed-os/comments{/number}","issue_comment_url":"https://api.github.com/repos/netanelgonen/mbed-os/issues/comments{/number}","contents_url":"https://api.github.com/repos/netanelgonen/mbed-os/contents/{+path}","compare_url":"https://api.github.com/repos/netanelgonen/mbed-os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/netanelgonen/mbed-os/merges","archive_url":"https://api.github.com/repos/netanelgonen/mbed-os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/netanelgonen/mbed-os/downloads","issues_url":"https://api.github.com/repos/netanelgonen/mbed-os/issues{/number}","pulls_url":"https://api.github.com/repos/netanelgonen/mbed-os/pulls{/number}","milestones_url":"https://api.github.com/repos/netanelgonen/mbed-os/milestones{/number}","notifications_url":"https://api.github.com/repos/netanelgonen/mbed-os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/netanelgonen/mbed-os/labels{/name}","releases_url":"https://api.github.com/repos/netanelgonen/mbed-os/releases{/id}","deployments_url":"https://api.github.com/repos/netanelgonen/mbed-os/deployments","created_at":"2016-11-21T17:16:48Z","updated_at":"2016-11-21T17:18:21Z","pushed_at":"2018-03-08T12:01:55Z","git_url":"git://github.com/netanelgonen/mbed-os.git","ssh_url":"git@github.com:netanelgonen/mbed-os.git","clone_url":"https://github.com/netanelgonen/mbed-os.git","svn_url":"https://github.com/netanelgonen/mbed-os","homepage":"https://mbed.com","size":197235,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ARMmbed:master","ref":"master","sha":"79bd2638b8a2626905fdb1f542946b34cc9dce04","user":{"login":"ARMmbed","id":8916057,"avatar_url":"https://avatars3.githubusercontent.com/u/8916057?v=4","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"repo":{"id":8270972,"name":"mbed-os","full_name":"ARMmbed/mbed-os","owner":{"login":"ARMmbed","id":8916057,"avatar_url":"https://avatars3.githubusercontent.com/u/8916057?v=4","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ARMmbed/mbed-os","description":"ARM Mbed OS is a platform operating system designed for the internet of things","fork":false,"url":"https://api.github.com/repos/ARMmbed/mbed-os","forks_url":"https://api.github.com/repos/ARMmbed/mbed-os/forks","keys_url":"https://api.github.com/repos/ARMmbed/mbed-os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ARMmbed/mbed-os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ARMmbed/mbed-os/teams","hooks_url":"https://api.github.com/repos/ARMmbed/mbed-os/hooks","issue_events_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/events{/number}","events_url":"https://api.github.com/repos/ARMmbed/mbed-os/events","assignees_url":"https://api.github.com/repos/ARMmbed/mbed-os/assignees{/user}","branches_url":"https://api.github.com/repos/ARMmbed/mbed-os/branches{/branch}","tags_url":"https://api.github.com/repos/ARMmbed/mbed-os/tags","blobs_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/refs{/sha}","trees_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ARMmbed/mbed-os/statuses/{sha}","languages_url":"https://api.github.com/repos/ARMmbed/mbed-os/languages","stargazers_url":"https://api.github.com/repos/ARMmbed/mbed-os/stargazers","contributors_url":"https://api.github.com/repos/ARMmbed/mbed-os/contributors","subscribers_url":"https://api.github.com/repos/ARMmbed/mbed-os/subscribers","subscription_url":"https://api.github.com/repos/ARMmbed/mbed-os/subscription","commits_url":"https://api.github.com/repos/ARMmbed/mbed-os/commits{/sha}","git_commits_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/commits{/sha}","comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/comments{/number}","issue_comment_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/comments{/number}","contents_url":"https://api.github.com/repos/ARMmbed/mbed-os/contents/{+path}","compare_url":"https://api.github.com/repos/ARMmbed/mbed-os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ARMmbed/mbed-os/merges","archive_url":"https://api.github.com/repos/ARMmbed/mbed-os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ARMmbed/mbed-os/downloads","issues_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues{/number}","pulls_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls{/number}","milestones_url":"https://api.github.com/repos/ARMmbed/mbed-os/milestones{/number}","notifications_url":"https://api.github.com/repos/ARMmbed/mbed-os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ARMmbed/mbed-os/labels{/name}","releases_url":"https://api.github.com/repos/ARMmbed/mbed-os/releases{/id}","deployments_url":"https://api.github.com/repos/ARMmbed/mbed-os/deployments","created_at":"2013-02-18T15:23:11Z","updated_at":"2018-03-07T10:55:49Z","pushed_at":"2018-03-08T17:22:13Z","git_url":"git://github.com/ARMmbed/mbed-os.git","ssh_url":"git@github.com:ARMmbed/mbed-os.git","clone_url":"https://github.com/ARMmbed/mbed-os.git","svn_url":"https://github.com/ARMmbed/mbed-os","homepage":"https://mbed.com","size":201601,"stargazers_count":1525,"watchers_count":1525,"language":"C","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1352,"mirror_url":null,"archived":false,"open_issues_count":400,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1352,"open_issues":400,"watchers":1525,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/6302"},"html":{"href":"https://github.com/ARMmbed/mbed-os/pull/6302"},"issue":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/issues/6302"},"comments":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/issues/6302/comments"},"review_comments":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/6302/comments"},"review_comment":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/6302/commits"},"statuses":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/statuses/01cdc8295b2371018302e5888554108f935f76c9"}},"author_association":"NONE"}}
{"actor":{"display_login":"geky"}}