{"action":"created","comment":{"url":"https://api.github.com/repos/greena13/react-hotkeys/pulls/comments/178329029","pull_request_review_id":108378454,"id":178329029,"diff_hunk":"@@ -1,23 +1,24 @@\n import * as React from 'react';\n+import FocusTrap from './lib/FocusTrap';","path":"index.d.ts","position":2,"original_position":2,"commit_id":"e6c98d19d5de419ea23a11d002d0d261d4efa81e","original_commit_id":"e6c98d19d5de419ea23a11d002d0d261d4efa81e","user":{"login":"mykter","id":1424497,"avatar_url":"https://avatars2.githubusercontent.com/u/1424497?v=4","gravatar_id":"","url":"https://api.github.com/users/mykter","html_url":"https://github.com/mykter","followers_url":"https://api.github.com/users/mykter/followers","following_url":"https://api.github.com/users/mykter/following{/other_user}","gists_url":"https://api.github.com/users/mykter/gists{/gist_id}","starred_url":"https://api.github.com/users/mykter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mykter/subscriptions","organizations_url":"https://api.github.com/users/mykter/orgs","repos_url":"https://api.github.com/users/mykter/repos","events_url":"https://api.github.com/users/mykter/events{/privacy}","received_events_url":"https://api.github.com/users/mykter/received_events","type":"User","site_admin":false},"body":"FYI currently 1.0.5 is reporting:\r\n```\r\nreact-hotkeys/index.d.ts(2,23): error TS7016: Could not find a declaration file for module './cjs/FocusTrap'. './node_modules/react-hotkeys/cjs/FocusTrap.js' implicitly has an 'any' type.\r\n```","created_at":"2018-03-30T17:05:44Z","updated_at":"2018-03-30T17:05:44Z","html_url":"https://github.com/greena13/react-hotkeys/pull/87#discussion_r178329029","pull_request_url":"https://api.github.com/repos/greena13/react-hotkeys/pulls/87","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/greena13/react-hotkeys/pulls/comments/178329029"},"html":{"href":"https://github.com/greena13/react-hotkeys/pull/87#discussion_r178329029"},"pull_request":{"href":"https://api.github.com/repos/greena13/react-hotkeys/pulls/87"}},"in_reply_to_id":178245699},"pull_request":{"url":"https://api.github.com/repos/greena13/react-hotkeys/pulls/87","id":178165125,"html_url":"https://github.com/greena13/react-hotkeys/pull/87","diff_url":"https://github.com/greena13/react-hotkeys/pull/87.diff","patch_url":"https://github.com/greena13/react-hotkeys/pull/87.patch","issue_url":"https://api.github.com/repos/greena13/react-hotkeys/issues/87","number":87,"state":"closed","locked":false,"title":"Fix typings","user":{"login":"matthew-matvei","id":19278663,"avatar_url":"https://avatars0.githubusercontent.com/u/19278663?v=4","gravatar_id":"","url":"https://api.github.com/users/matthew-matvei","html_url":"https://github.com/matthew-matvei","followers_url":"https://api.github.com/users/matthew-matvei/followers","following_url":"https://api.github.com/users/matthew-matvei/following{/other_user}","gists_url":"https://api.github.com/users/matthew-matvei/gists{/gist_id}","starred_url":"https://api.github.com/users/matthew-matvei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthew-matvei/subscriptions","organizations_url":"https://api.github.com/users/matthew-matvei/orgs","repos_url":"https://api.github.com/users/matthew-matvei/repos","events_url":"https://api.github.com/users/matthew-matvei/events{/privacy}","received_events_url":"https://api.github.com/users/matthew-matvei/received_events","type":"User","site_admin":false},"body":"This pull request aims to resolve #84 \r\n\r\nI have tested this by developing and `npm pack`ing locally, then installing the package into my [FreeMAN](https://github.com/matthew-matvei/freeman) app which uses `react-hotkeys` fairly extensively.\r\n\r\n- Importing `FocusTrap` (resolved `ts` errors, though actual type definitions instead of 'importing' js file for this class might be best moving forward)\r\n- Removed initialisers in `interface` definitions\r\n- Made handler function `keyEvent` optional, since the API doesn't seem to require it\r\n- `HotKeysProps` extends React's `Props<HotKeys>` in order to get in-built props like `ref` and `children`\r\n\r\nI don't think this project is set up for any automated type tests or `tslint`ing, so I would suggest anyone interested to build this branch locally, `npm pack` and install it into where you are consuming it. I'm aware my own `tsconfig.json` could potentially make this solution not work for you.","created_at":"2018-03-28T21:10:11Z","updated_at":"2018-03-30T17:05:44Z","closed_at":"2018-03-30T07:15:36Z","merged_at":"2018-03-30T07:15:36Z","merge_commit_sha":"9a0a58c7a9ce6108bf9b6f25219c8ed964958a04","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/greena13/react-hotkeys/pulls/87/commits","review_comments_url":"https://api.github.com/repos/greena13/react-hotkeys/pulls/87/comments","review_comment_url":"https://api.github.com/repos/greena13/react-hotkeys/pulls/comments{/number}","comments_url":"https://api.github.com/repos/greena13/react-hotkeys/issues/87/comments","statuses_url":"https://api.github.com/repos/greena13/react-hotkeys/statuses/e6c98d19d5de419ea23a11d002d0d261d4efa81e","head":{"label":"matthew-matvei:fix-typings","ref":"fix-typings","sha":"e6c98d19d5de419ea23a11d002d0d261d4efa81e","user":{"login":"matthew-matvei","id":19278663,"avatar_url":"https://avatars0.githubusercontent.com/u/19278663?v=4","gravatar_id":"","url":"https://api.github.com/users/matthew-matvei","html_url":"https://github.com/matthew-matvei","followers_url":"https://api.github.com/users/matthew-matvei/followers","following_url":"https://api.github.com/users/matthew-matvei/following{/other_user}","gists_url":"https://api.github.com/users/matthew-matvei/gists{/gist_id}","starred_url":"https://api.github.com/users/matthew-matvei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthew-matvei/subscriptions","organizations_url":"https://api.github.com/users/matthew-matvei/orgs","repos_url":"https://api.github.com/users/matthew-matvei/repos","events_url":"https://api.github.com/users/matthew-matvei/events{/privacy}","received_events_url":"https://api.github.com/users/matthew-matvei/received_events","type":"User","site_admin":false},"repo":{"id":127189960,"name":"react-hotkeys","full_name":"matthew-matvei/react-hotkeys","owner":{"login":"matthew-matvei","id":19278663,"avatar_url":"https://avatars0.githubusercontent.com/u/19278663?v=4","gravatar_id":"","url":"https://api.github.com/users/matthew-matvei","html_url":"https://github.com/matthew-matvei","followers_url":"https://api.github.com/users/matthew-matvei/followers","following_url":"https://api.github.com/users/matthew-matvei/following{/other_user}","gists_url":"https://api.github.com/users/matthew-matvei/gists{/gist_id}","starred_url":"https://api.github.com/users/matthew-matvei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthew-matvei/subscriptions","organizations_url":"https://api.github.com/users/matthew-matvei/orgs","repos_url":"https://api.github.com/users/matthew-matvei/repos","events_url":"https://api.github.com/users/matthew-matvei/events{/privacy}","received_events_url":"https://api.github.com/users/matthew-matvei/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/matthew-matvei/react-hotkeys","description":"Declarative hotkey and focus area management for React","fork":true,"url":"https://api.github.com/repos/matthew-matvei/react-hotkeys","forks_url":"https://api.github.com/repos/matthew-matvei/react-hotkeys/forks","keys_url":"https://api.github.com/repos/matthew-matvei/react-hotkeys/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matthew-matvei/react-hotkeys/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matthew-matvei/react-hotkeys/teams","hooks_url":"https://api.github.com/repos/matthew-matvei/react-hotkeys/hooks","issue_events_url":"https://api.github.com/repos/matthew-matvei/react-hotkeys/issues/events{/number}","events_url":"https://api.github.com/repos/matthew-matvei/react-hotkeys/events","assignees_url":"https://api.github.com/repos/matthew-matvei/react-hotkeys/assignees{/user}","branches_url":"https://api.github.com/repos/matthew-matvei/react-hotkeys/branches{/branch}","tags_url":"https://api.github.com/repos/matthew-matvei/react-hotkeys/tags","blobs_url":"https://api.github.com/repos/matthew-matvei/react-hotkeys/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matthew-matvei/react-hotkeys/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matthew-matvei/react-hotkeys/git/refs{/sha}","trees_url":"https://api.github.com/repos/matthew-matvei/react-hotkeys/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matthew-matvei/react-hotkeys/statuses/{sha}","languages_url":"https://api.github.com/repos/matthew-matvei/react-hotkeys/languages","stargazers_url":"https://api.github.com/repos/matthew-matvei/react-hotkeys/stargazers","contributors_url":"https://api.github.com/repos/matthew-matvei/react-hotkeys/contributors","subscribers_url":"https://api.github.com/repos/matthew-matvei/react-hotkeys/subscribers","subscription_url":"https://api.github.com/repos/matthew-matvei/react-hotkeys/subscription","commits_url":"https://api.github.com/repos/matthew-matvei/react-hotkeys/commits{/sha}","git_commits_url":"https://api.github.com/repos/matthew-matvei/react-hotkeys/git/commits{/sha}","comments_url":"https://api.github.com/repos/matthew-matvei/react-hotkeys/comments{/number}","issue_comment_url":"https://api.github.com/repos/matthew-matvei/react-hotkeys/issues/comments{/number}","contents_url":"https://api.github.com/repos/matthew-matvei/react-hotkeys/contents/{+path}","compare_url":"https://api.github.com/repos/matthew-matvei/react-hotkeys/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matthew-matvei/react-hotkeys/merges","archive_url":"https://api.github.com/repos/matthew-matvei/react-hotkeys/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matthew-matvei/react-hotkeys/downloads","issues_url":"https://api.github.com/repos/matthew-matvei/react-hotkeys/issues{/number}","pulls_url":"https://api.github.com/repos/matthew-matvei/react-hotkeys/pulls{/number}","milestones_url":"https://api.github.com/repos/matthew-matvei/react-hotkeys/milestones{/number}","notifications_url":"https://api.github.com/repos/matthew-matvei/react-hotkeys/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matthew-matvei/react-hotkeys/labels{/name}","releases_url":"https://api.github.com/repos/matthew-matvei/react-hotkeys/releases{/id}","deployments_url":"https://api.github.com/repos/matthew-matvei/react-hotkeys/deployments","created_at":"2018-03-28T19:44:10Z","updated_at":"2018-03-28T19:44:12Z","pushed_at":"2018-03-29T18:29:55Z","git_url":"git://github.com/matthew-matvei/react-hotkeys.git","ssh_url":"git@github.com:matthew-matvei/react-hotkeys.git","clone_url":"https://github.com/matthew-matvei/react-hotkeys.git","svn_url":"https://github.com/matthew-matvei/react-hotkeys","homepage":"https://github.com/greena13/react-hotkeys","size":2114,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"isc","name":"ISC License","spdx_id":"ISC","url":"https://api.github.com/licenses/isc"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"greena13:master","ref":"master","sha":"b3cef1283d6a70a212a1e96ca692a223831296ac","user":{"login":"greena13","id":2115363,"avatar_url":"https://avatars3.githubusercontent.com/u/2115363?v=4","gravatar_id":"","url":"https://api.github.com/users/greena13","html_url":"https://github.com/greena13","followers_url":"https://api.github.com/users/greena13/followers","following_url":"https://api.github.com/users/greena13/following{/other_user}","gists_url":"https://api.github.com/users/greena13/gists{/gist_id}","starred_url":"https://api.github.com/users/greena13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greena13/subscriptions","organizations_url":"https://api.github.com/users/greena13/orgs","repos_url":"https://api.github.com/users/greena13/repos","events_url":"https://api.github.com/users/greena13/events{/privacy}","received_events_url":"https://api.github.com/users/greena13/received_events","type":"User","site_admin":false},"repo":{"id":33366494,"name":"react-hotkeys","full_name":"greena13/react-hotkeys","owner":{"login":"greena13","id":2115363,"avatar_url":"https://avatars3.githubusercontent.com/u/2115363?v=4","gravatar_id":"","url":"https://api.github.com/users/greena13","html_url":"https://github.com/greena13","followers_url":"https://api.github.com/users/greena13/followers","following_url":"https://api.github.com/users/greena13/following{/other_user}","gists_url":"https://api.github.com/users/greena13/gists{/gist_id}","starred_url":"https://api.github.com/users/greena13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greena13/subscriptions","organizations_url":"https://api.github.com/users/greena13/orgs","repos_url":"https://api.github.com/users/greena13/repos","events_url":"https://api.github.com/users/greena13/events{/privacy}","received_events_url":"https://api.github.com/users/greena13/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/greena13/react-hotkeys","description":"Declarative hotkey and focus area management for React","fork":false,"url":"https://api.github.com/repos/greena13/react-hotkeys","forks_url":"https://api.github.com/repos/greena13/react-hotkeys/forks","keys_url":"https://api.github.com/repos/greena13/react-hotkeys/keys{/key_id}","collaborators_url":"https://api.github.com/repos/greena13/react-hotkeys/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/greena13/react-hotkeys/teams","hooks_url":"https://api.github.com/repos/greena13/react-hotkeys/hooks","issue_events_url":"https://api.github.com/repos/greena13/react-hotkeys/issues/events{/number}","events_url":"https://api.github.com/repos/greena13/react-hotkeys/events","assignees_url":"https://api.github.com/repos/greena13/react-hotkeys/assignees{/user}","branches_url":"https://api.github.com/repos/greena13/react-hotkeys/branches{/branch}","tags_url":"https://api.github.com/repos/greena13/react-hotkeys/tags","blobs_url":"https://api.github.com/repos/greena13/react-hotkeys/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/greena13/react-hotkeys/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/greena13/react-hotkeys/git/refs{/sha}","trees_url":"https://api.github.com/repos/greena13/react-hotkeys/git/trees{/sha}","statuses_url":"https://api.github.com/repos/greena13/react-hotkeys/statuses/{sha}","languages_url":"https://api.github.com/repos/greena13/react-hotkeys/languages","stargazers_url":"https://api.github.com/repos/greena13/react-hotkeys/stargazers","contributors_url":"https://api.github.com/repos/greena13/react-hotkeys/contributors","subscribers_url":"https://api.github.com/repos/greena13/react-hotkeys/subscribers","subscription_url":"https://api.github.com/repos/greena13/react-hotkeys/subscription","commits_url":"https://api.github.com/repos/greena13/react-hotkeys/commits{/sha}","git_commits_url":"https://api.github.com/repos/greena13/react-hotkeys/git/commits{/sha}","comments_url":"https://api.github.com/repos/greena13/react-hotkeys/comments{/number}","issue_comment_url":"https://api.github.com/repos/greena13/react-hotkeys/issues/comments{/number}","contents_url":"https://api.github.com/repos/greena13/react-hotkeys/contents/{+path}","compare_url":"https://api.github.com/repos/greena13/react-hotkeys/compare/{base}...{head}","merges_url":"https://api.github.com/repos/greena13/react-hotkeys/merges","archive_url":"https://api.github.com/repos/greena13/react-hotkeys/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/greena13/react-hotkeys/downloads","issues_url":"https://api.github.com/repos/greena13/react-hotkeys/issues{/number}","pulls_url":"https://api.github.com/repos/greena13/react-hotkeys/pulls{/number}","milestones_url":"https://api.github.com/repos/greena13/react-hotkeys/milestones{/number}","notifications_url":"https://api.github.com/repos/greena13/react-hotkeys/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/greena13/react-hotkeys/labels{/name}","releases_url":"https://api.github.com/repos/greena13/react-hotkeys/releases{/id}","deployments_url":"https://api.github.com/repos/greena13/react-hotkeys/deployments","created_at":"2015-04-03T14:21:27Z","updated_at":"2018-03-30T09:53:54Z","pushed_at":"2018-03-30T09:07:00Z","git_url":"git://github.com/greena13/react-hotkeys.git","ssh_url":"git@github.com:greena13/react-hotkeys.git","clone_url":"https://github.com/greena13/react-hotkeys.git","svn_url":"https://github.com/greena13/react-hotkeys","homepage":"https://github.com/greena13/react-hotkeys","size":2114,"stargazers_count":942,"watchers_count":942,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":63,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"isc","name":"ISC License","spdx_id":"ISC","url":"https://api.github.com/licenses/isc"},"forks":63,"open_issues":11,"watchers":942,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/greena13/react-hotkeys/pulls/87"},"html":{"href":"https://github.com/greena13/react-hotkeys/pull/87"},"issue":{"href":"https://api.github.com/repos/greena13/react-hotkeys/issues/87"},"comments":{"href":"https://api.github.com/repos/greena13/react-hotkeys/issues/87/comments"},"review_comments":{"href":"https://api.github.com/repos/greena13/react-hotkeys/pulls/87/comments"},"review_comment":{"href":"https://api.github.com/repos/greena13/react-hotkeys/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/greena13/react-hotkeys/pulls/87/commits"},"statuses":{"href":"https://api.github.com/repos/greena13/react-hotkeys/statuses/e6c98d19d5de419ea23a11d002d0d261d4efa81e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mykter"}}