{"action":"opened","number":4873,"pull_request":{"url":"https://api.github.com/repos/zestedesavoir/zds-site/pulls/4873","id":168459019,"html_url":"https://github.com/zestedesavoir/zds-site/pull/4873","diff_url":"https://github.com/zestedesavoir/zds-site/pull/4873.diff","patch_url":"https://github.com/zestedesavoir/zds-site/pull/4873.patch","issue_url":"https://api.github.com/repos/zestedesavoir/zds-site/issues/4873","number":4873,"state":"open","locked":false,"title":"S'assures que les comptes du bot et des utilisateurs anonymes et externes existent au lancement","user":{"login":"rezemika","id":1690660,"avatar_url":"https://avatars0.githubusercontent.com/u/1690660?v=4","gravatar_id":"","url":"https://api.github.com/users/rezemika","html_url":"https://github.com/rezemika","followers_url":"https://api.github.com/users/rezemika/followers","following_url":"https://api.github.com/users/rezemika/following{/other_user}","gists_url":"https://api.github.com/users/rezemika/gists{/gist_id}","starred_url":"https://api.github.com/users/rezemika/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rezemika/subscriptions","organizations_url":"https://api.github.com/users/rezemika/orgs","repos_url":"https://api.github.com/users/rezemika/repos","events_url":"https://api.github.com/users/rezemika/events{/privacy}","received_events_url":"https://api.github.com/users/rezemika/received_events","type":"User","site_admin":false},"body":"Le compte du bot était récupéré par des `get_object_or_404(User, username=settings.ZDS_APP['member']['bot_account'])`.\r\nOr, si celui-ci n'existe pas sur l'instance, cela lève une erreur 404 alors qu'il s'agit d'un problème de configuration.\r\nDésormais, la présence de ces comptes est vérifiée au lancement, et une exception est levée si l'un d'eux est introuvable.\r\n\r\nPuisqu'ils sont présents avec certitude sur l'instance, les appels de `get_object_or_404()` sont remplacés par `User.objects.get()`.\r\n\r\nNuméro du ticket concerné : #4870 \r\n\r\n### Contrôle qualité\r\n\r\n  - Vérifiez que les compte du bot, de l'utilisateur externe et de l'utilisateur anonyme sont toujours fonctionnels, et qu'une exception est levée au lancement s'ils sont absents.\r\n","created_at":"2018-02-11T15:41:19Z","updated_at":"2018-02-11T15:41:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/zestedesavoir/zds-site/pulls/4873/commits","review_comments_url":"https://api.github.com/repos/zestedesavoir/zds-site/pulls/4873/comments","review_comment_url":"https://api.github.com/repos/zestedesavoir/zds-site/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zestedesavoir/zds-site/issues/4873/comments","statuses_url":"https://api.github.com/repos/zestedesavoir/zds-site/statuses/bf7c48406f841b8945229e61bbeb6e9d24604772","head":{"label":"rezemika:fix-4872","ref":"fix-4872","sha":"bf7c48406f841b8945229e61bbeb6e9d24604772","user":{"login":"rezemika","id":1690660,"avatar_url":"https://avatars0.githubusercontent.com/u/1690660?v=4","gravatar_id":"","url":"https://api.github.com/users/rezemika","html_url":"https://github.com/rezemika","followers_url":"https://api.github.com/users/rezemika/followers","following_url":"https://api.github.com/users/rezemika/following{/other_user}","gists_url":"https://api.github.com/users/rezemika/gists{/gist_id}","starred_url":"https://api.github.com/users/rezemika/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rezemika/subscriptions","organizations_url":"https://api.github.com/users/rezemika/orgs","repos_url":"https://api.github.com/users/rezemika/repos","events_url":"https://api.github.com/users/rezemika/events{/privacy}","received_events_url":"https://api.github.com/users/rezemika/received_events","type":"User","site_admin":false},"repo":{"id":90057073,"name":"zds-site","full_name":"rezemika/zds-site","owner":{"login":"rezemika","id":1690660,"avatar_url":"https://avatars0.githubusercontent.com/u/1690660?v=4","gravatar_id":"","url":"https://api.github.com/users/rezemika","html_url":"https://github.com/rezemika","followers_url":"https://api.github.com/users/rezemika/followers","following_url":"https://api.github.com/users/rezemika/following{/other_user}","gists_url":"https://api.github.com/users/rezemika/gists{/gist_id}","starred_url":"https://api.github.com/users/rezemika/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rezemika/subscriptions","organizations_url":"https://api.github.com/users/rezemika/orgs","repos_url":"https://api.github.com/users/rezemika/repos","events_url":"https://api.github.com/users/rezemika/events{/privacy}","received_events_url":"https://api.github.com/users/rezemika/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rezemika/zds-site","description":"Dépôt de ZdS, faisant notamment fonctionner https://zestedesavoir.com","fork":true,"url":"https://api.github.com/repos/rezemika/zds-site","forks_url":"https://api.github.com/repos/rezemika/zds-site/forks","keys_url":"https://api.github.com/repos/rezemika/zds-site/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rezemika/zds-site/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rezemika/zds-site/teams","hooks_url":"https://api.github.com/repos/rezemika/zds-site/hooks","issue_events_url":"https://api.github.com/repos/rezemika/zds-site/issues/events{/number}","events_url":"https://api.github.com/repos/rezemika/zds-site/events","assignees_url":"https://api.github.com/repos/rezemika/zds-site/assignees{/user}","branches_url":"https://api.github.com/repos/rezemika/zds-site/branches{/branch}","tags_url":"https://api.github.com/repos/rezemika/zds-site/tags","blobs_url":"https://api.github.com/repos/rezemika/zds-site/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rezemika/zds-site/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rezemika/zds-site/git/refs{/sha}","trees_url":"https://api.github.com/repos/rezemika/zds-site/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rezemika/zds-site/statuses/{sha}","languages_url":"https://api.github.com/repos/rezemika/zds-site/languages","stargazers_url":"https://api.github.com/repos/rezemika/zds-site/stargazers","contributors_url":"https://api.github.com/repos/rezemika/zds-site/contributors","subscribers_url":"https://api.github.com/repos/rezemika/zds-site/subscribers","subscription_url":"https://api.github.com/repos/rezemika/zds-site/subscription","commits_url":"https://api.github.com/repos/rezemika/zds-site/commits{/sha}","git_commits_url":"https://api.github.com/repos/rezemika/zds-site/git/commits{/sha}","comments_url":"https://api.github.com/repos/rezemika/zds-site/comments{/number}","issue_comment_url":"https://api.github.com/repos/rezemika/zds-site/issues/comments{/number}","contents_url":"https://api.github.com/repos/rezemika/zds-site/contents/{+path}","compare_url":"https://api.github.com/repos/rezemika/zds-site/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rezemika/zds-site/merges","archive_url":"https://api.github.com/repos/rezemika/zds-site/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rezemika/zds-site/downloads","issues_url":"https://api.github.com/repos/rezemika/zds-site/issues{/number}","pulls_url":"https://api.github.com/repos/rezemika/zds-site/pulls{/number}","milestones_url":"https://api.github.com/repos/rezemika/zds-site/milestones{/number}","notifications_url":"https://api.github.com/repos/rezemika/zds-site/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rezemika/zds-site/labels{/name}","releases_url":"https://api.github.com/repos/rezemika/zds-site/releases{/id}","deployments_url":"https://api.github.com/repos/rezemika/zds-site/deployments","created_at":"2017-05-02T16:57:20Z","updated_at":"2017-05-02T16:57:25Z","pushed_at":"2018-02-11T15:39:46Z","git_url":"git://github.com/rezemika/zds-site.git","ssh_url":"git@github.com:rezemika/zds-site.git","clone_url":"https://github.com/rezemika/zds-site.git","svn_url":"https://github.com/rezemika/zds-site","homepage":"","size":109536,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"zestedesavoir:dev","ref":"dev","sha":"cb209f027916ece6dff7544a3580648cd6d8bb30","user":{"login":"zestedesavoir","id":7406239,"avatar_url":"https://avatars3.githubusercontent.com/u/7406239?v=4","gravatar_id":"","url":"https://api.github.com/users/zestedesavoir","html_url":"https://github.com/zestedesavoir","followers_url":"https://api.github.com/users/zestedesavoir/followers","following_url":"https://api.github.com/users/zestedesavoir/following{/other_user}","gists_url":"https://api.github.com/users/zestedesavoir/gists{/gist_id}","starred_url":"https://api.github.com/users/zestedesavoir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zestedesavoir/subscriptions","organizations_url":"https://api.github.com/users/zestedesavoir/orgs","repos_url":"https://api.github.com/users/zestedesavoir/repos","events_url":"https://api.github.com/users/zestedesavoir/events{/privacy}","received_events_url":"https://api.github.com/users/zestedesavoir/received_events","type":"Organization","site_admin":false},"repo":{"id":14778920,"name":"zds-site","full_name":"zestedesavoir/zds-site","owner":{"login":"zestedesavoir","id":7406239,"avatar_url":"https://avatars3.githubusercontent.com/u/7406239?v=4","gravatar_id":"","url":"https://api.github.com/users/zestedesavoir","html_url":"https://github.com/zestedesavoir","followers_url":"https://api.github.com/users/zestedesavoir/followers","following_url":"https://api.github.com/users/zestedesavoir/following{/other_user}","gists_url":"https://api.github.com/users/zestedesavoir/gists{/gist_id}","starred_url":"https://api.github.com/users/zestedesavoir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zestedesavoir/subscriptions","organizations_url":"https://api.github.com/users/zestedesavoir/orgs","repos_url":"https://api.github.com/users/zestedesavoir/repos","events_url":"https://api.github.com/users/zestedesavoir/events{/privacy}","received_events_url":"https://api.github.com/users/zestedesavoir/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zestedesavoir/zds-site","description":"Dépôt de Zeste de Savoir","fork":false,"url":"https://api.github.com/repos/zestedesavoir/zds-site","forks_url":"https://api.github.com/repos/zestedesavoir/zds-site/forks","keys_url":"https://api.github.com/repos/zestedesavoir/zds-site/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zestedesavoir/zds-site/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zestedesavoir/zds-site/teams","hooks_url":"https://api.github.com/repos/zestedesavoir/zds-site/hooks","issue_events_url":"https://api.github.com/repos/zestedesavoir/zds-site/issues/events{/number}","events_url":"https://api.github.com/repos/zestedesavoir/zds-site/events","assignees_url":"https://api.github.com/repos/zestedesavoir/zds-site/assignees{/user}","branches_url":"https://api.github.com/repos/zestedesavoir/zds-site/branches{/branch}","tags_url":"https://api.github.com/repos/zestedesavoir/zds-site/tags","blobs_url":"https://api.github.com/repos/zestedesavoir/zds-site/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zestedesavoir/zds-site/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zestedesavoir/zds-site/git/refs{/sha}","trees_url":"https://api.github.com/repos/zestedesavoir/zds-site/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zestedesavoir/zds-site/statuses/{sha}","languages_url":"https://api.github.com/repos/zestedesavoir/zds-site/languages","stargazers_url":"https://api.github.com/repos/zestedesavoir/zds-site/stargazers","contributors_url":"https://api.github.com/repos/zestedesavoir/zds-site/contributors","subscribers_url":"https://api.github.com/repos/zestedesavoir/zds-site/subscribers","subscription_url":"https://api.github.com/repos/zestedesavoir/zds-site/subscription","commits_url":"https://api.github.com/repos/zestedesavoir/zds-site/commits{/sha}","git_commits_url":"https://api.github.com/repos/zestedesavoir/zds-site/git/commits{/sha}","comments_url":"https://api.github.com/repos/zestedesavoir/zds-site/comments{/number}","issue_comment_url":"https://api.github.com/repos/zestedesavoir/zds-site/issues/comments{/number}","contents_url":"https://api.github.com/repos/zestedesavoir/zds-site/contents/{+path}","compare_url":"https://api.github.com/repos/zestedesavoir/zds-site/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zestedesavoir/zds-site/merges","archive_url":"https://api.github.com/repos/zestedesavoir/zds-site/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zestedesavoir/zds-site/downloads","issues_url":"https://api.github.com/repos/zestedesavoir/zds-site/issues{/number}","pulls_url":"https://api.github.com/repos/zestedesavoir/zds-site/pulls{/number}","milestones_url":"https://api.github.com/repos/zestedesavoir/zds-site/milestones{/number}","notifications_url":"https://api.github.com/repos/zestedesavoir/zds-site/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zestedesavoir/zds-site/labels{/name}","releases_url":"https://api.github.com/repos/zestedesavoir/zds-site/releases{/id}","deployments_url":"https://api.github.com/repos/zestedesavoir/zds-site/deployments","created_at":"2013-11-28T14:23:48Z","updated_at":"2018-02-07T18:42:21Z","pushed_at":"2018-02-11T15:33:50Z","git_url":"git://github.com/zestedesavoir/zds-site.git","ssh_url":"git@github.com:zestedesavoir/zds-site.git","clone_url":"https://github.com/zestedesavoir/zds-site.git","svn_url":"https://github.com/zestedesavoir/zds-site","homepage":"https://zestedesavoir.com","size":112591,"stargazers_count":209,"watchers_count":209,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":146,"mirror_url":null,"archived":false,"open_issues_count":237,"license":null,"forks":146,"open_issues":237,"watchers":209,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/zestedesavoir/zds-site/pulls/4873"},"html":{"href":"https://github.com/zestedesavoir/zds-site/pull/4873"},"issue":{"href":"https://api.github.com/repos/zestedesavoir/zds-site/issues/4873"},"comments":{"href":"https://api.github.com/repos/zestedesavoir/zds-site/issues/4873/comments"},"review_comments":{"href":"https://api.github.com/repos/zestedesavoir/zds-site/pulls/4873/comments"},"review_comment":{"href":"https://api.github.com/repos/zestedesavoir/zds-site/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zestedesavoir/zds-site/pulls/4873/commits"},"statuses":{"href":"https://api.github.com/repos/zestedesavoir/zds-site/statuses/bf7c48406f841b8945229e61bbeb6e9d24604772"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":37,"deletions":29,"changed_files":8}}
{"actor":{"display_login":"rezemika"}}