{"action":"opened","number":23,"pull_request":{"url":"https://api.github.com/repos/immutability-io/vault-ethereum/pulls/23","id":213448602,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzNDQ4NjAy","html_url":"https://github.com/immutability-io/vault-ethereum/pull/23","diff_url":"https://github.com/immutability-io/vault-ethereum/pull/23.diff","patch_url":"https://github.com/immutability-io/vault-ethereum/pull/23.patch","issue_url":"https://api.github.com/repos/immutability-io/vault-ethereum/issues/23","number":23,"state":"open","locked":false,"title":"Endpoint for signing transactions in json format","user":{"login":"DeRain","id":3999180,"node_id":"MDQ6VXNlcjM5OTkxODA=","avatar_url":"https://avatars1.githubusercontent.com/u/3999180?v=4","gravatar_id":"","url":"https://api.github.com/users/DeRain","html_url":"https://github.com/DeRain","followers_url":"https://api.github.com/users/DeRain/followers","following_url":"https://api.github.com/users/DeRain/following{/other_user}","gists_url":"https://api.github.com/users/DeRain/gists{/gist_id}","starred_url":"https://api.github.com/users/DeRain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DeRain/subscriptions","organizations_url":"https://api.github.com/users/DeRain/orgs","repos_url":"https://api.github.com/users/DeRain/repos","events_url":"https://api.github.com/users/DeRain/events{/privacy}","received_events_url":"https://api.github.com/users/DeRain/received_events","type":"User","site_admin":false},"body":"## Description\r\nBrand new API endpoint for making signing transaction easy!\r\n\r\n## Motivation and Context\r\nI'm tried common sign method, but it seems it's working only for custom data signatures. Anyway - I think we need a more developer's friendly way to sign the transaction.\r\n\r\nThe developer only needs to provide all `json` properties of the transaction and then he gets signed transaction in HEX format that ready to be broadcasted to Ethereum network by any convenient way. For example:\r\n[Etherscan tool](https://etherscan.io/pushTx)\r\n[How to broadcast transaction via web3](https://github.com/ethereum/wiki/wiki/JavaScript-API#web3ethsendrawtransaction)\r\n\r\n## How Has This Been Tested?\r\nThis is a brand new API and does not impact any existing code. I've created signed transactions and broadcasted them on `Ropsten` network via [Etherscan publishing tool](https://ropsten.etherscan.io/pushTx)\r\n\r\n## Types of changes\r\n- [ ] Documentation enhancement\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [*] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n- [*] My code follows the code style of this project.\r\n- [*] My change requires a change to the documentation.\r\n- [*] I have updated the documentation accordingly.\r\n- [ ] I have read the **CONTRIBUTING** document.","created_at":"2018-09-05T22:44:06Z","updated_at":"2018-09-05T22:44:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/immutability-io/vault-ethereum/pulls/23/commits","review_comments_url":"https://api.github.com/repos/immutability-io/vault-ethereum/pulls/23/comments","review_comment_url":"https://api.github.com/repos/immutability-io/vault-ethereum/pulls/comments{/number}","comments_url":"https://api.github.com/repos/immutability-io/vault-ethereum/issues/23/comments","statuses_url":"https://api.github.com/repos/immutability-io/vault-ethereum/statuses/c099fd8d9e0db3e127c40967bf87c2c3ed5022c8","head":{"label":"dreamteam-gg:master","ref":"master","sha":"c099fd8d9e0db3e127c40967bf87c2c3ed5022c8","user":{"login":"dreamteam-gg","id":37930087,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3OTMwMDg3","avatar_url":"https://avatars1.githubusercontent.com/u/37930087?v=4","gravatar_id":"","url":"https://api.github.com/users/dreamteam-gg","html_url":"https://github.com/dreamteam-gg","followers_url":"https://api.github.com/users/dreamteam-gg/followers","following_url":"https://api.github.com/users/dreamteam-gg/following{/other_user}","gists_url":"https://api.github.com/users/dreamteam-gg/gists{/gist_id}","starred_url":"https://api.github.com/users/dreamteam-gg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dreamteam-gg/subscriptions","organizations_url":"https://api.github.com/users/dreamteam-gg/orgs","repos_url":"https://api.github.com/users/dreamteam-gg/repos","events_url":"https://api.github.com/users/dreamteam-gg/events{/privacy}","received_events_url":"https://api.github.com/users/dreamteam-gg/received_events","type":"Organization","site_admin":false},"repo":{"id":147532084,"node_id":"MDEwOlJlcG9zaXRvcnkxNDc1MzIwODQ=","name":"vault-ethereum","full_name":"dreamteam-gg/vault-ethereum","owner":{"login":"dreamteam-gg","id":37930087,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3OTMwMDg3","avatar_url":"https://avatars1.githubusercontent.com/u/37930087?v=4","gravatar_id":"","url":"https://api.github.com/users/dreamteam-gg","html_url":"https://github.com/dreamteam-gg","followers_url":"https://api.github.com/users/dreamteam-gg/followers","following_url":"https://api.github.com/users/dreamteam-gg/following{/other_user}","gists_url":"https://api.github.com/users/dreamteam-gg/gists{/gist_id}","starred_url":"https://api.github.com/users/dreamteam-gg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dreamteam-gg/subscriptions","organizations_url":"https://api.github.com/users/dreamteam-gg/orgs","repos_url":"https://api.github.com/users/dreamteam-gg/repos","events_url":"https://api.github.com/users/dreamteam-gg/events{/privacy}","received_events_url":"https://api.github.com/users/dreamteam-gg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dreamteam-gg/vault-ethereum","description":"A plugin that turns Vault into an Ethereum wallet.","fork":true,"url":"https://api.github.com/repos/dreamteam-gg/vault-ethereum","forks_url":"https://api.github.com/repos/dreamteam-gg/vault-ethereum/forks","keys_url":"https://api.github.com/repos/dreamteam-gg/vault-ethereum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dreamteam-gg/vault-ethereum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dreamteam-gg/vault-ethereum/teams","hooks_url":"https://api.github.com/repos/dreamteam-gg/vault-ethereum/hooks","issue_events_url":"https://api.github.com/repos/dreamteam-gg/vault-ethereum/issues/events{/number}","events_url":"https://api.github.com/repos/dreamteam-gg/vault-ethereum/events","assignees_url":"https://api.github.com/repos/dreamteam-gg/vault-ethereum/assignees{/user}","branches_url":"https://api.github.com/repos/dreamteam-gg/vault-ethereum/branches{/branch}","tags_url":"https://api.github.com/repos/dreamteam-gg/vault-ethereum/tags","blobs_url":"https://api.github.com/repos/dreamteam-gg/vault-ethereum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dreamteam-gg/vault-ethereum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dreamteam-gg/vault-ethereum/git/refs{/sha}","trees_url":"https://api.github.com/repos/dreamteam-gg/vault-ethereum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dreamteam-gg/vault-ethereum/statuses/{sha}","languages_url":"https://api.github.com/repos/dreamteam-gg/vault-ethereum/languages","stargazers_url":"https://api.github.com/repos/dreamteam-gg/vault-ethereum/stargazers","contributors_url":"https://api.github.com/repos/dreamteam-gg/vault-ethereum/contributors","subscribers_url":"https://api.github.com/repos/dreamteam-gg/vault-ethereum/subscribers","subscription_url":"https://api.github.com/repos/dreamteam-gg/vault-ethereum/subscription","commits_url":"https://api.github.com/repos/dreamteam-gg/vault-ethereum/commits{/sha}","git_commits_url":"https://api.github.com/repos/dreamteam-gg/vault-ethereum/git/commits{/sha}","comments_url":"https://api.github.com/repos/dreamteam-gg/vault-ethereum/comments{/number}","issue_comment_url":"https://api.github.com/repos/dreamteam-gg/vault-ethereum/issues/comments{/number}","contents_url":"https://api.github.com/repos/dreamteam-gg/vault-ethereum/contents/{+path}","compare_url":"https://api.github.com/repos/dreamteam-gg/vault-ethereum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dreamteam-gg/vault-ethereum/merges","archive_url":"https://api.github.com/repos/dreamteam-gg/vault-ethereum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dreamteam-gg/vault-ethereum/downloads","issues_url":"https://api.github.com/repos/dreamteam-gg/vault-ethereum/issues{/number}","pulls_url":"https://api.github.com/repos/dreamteam-gg/vault-ethereum/pulls{/number}","milestones_url":"https://api.github.com/repos/dreamteam-gg/vault-ethereum/milestones{/number}","notifications_url":"https://api.github.com/repos/dreamteam-gg/vault-ethereum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dreamteam-gg/vault-ethereum/labels{/name}","releases_url":"https://api.github.com/repos/dreamteam-gg/vault-ethereum/releases{/id}","deployments_url":"https://api.github.com/repos/dreamteam-gg/vault-ethereum/deployments","created_at":"2018-09-05T14:33:20Z","updated_at":"2018-09-05T22:28:57Z","pushed_at":"2018-09-05T22:28:56Z","git_url":"git://github.com/dreamteam-gg/vault-ethereum.git","ssh_url":"git@github.com:dreamteam-gg/vault-ethereum.git","clone_url":"https://github.com/dreamteam-gg/vault-ethereum.git","svn_url":"https://github.com/dreamteam-gg/vault-ethereum","homepage":"","size":17145,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"immutability-io:master","ref":"master","sha":"a447ba6547f2ee3295dad1e4f9ea8505d071f2ff","user":{"login":"immutability-io","id":20804935,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwODA0OTM1","avatar_url":"https://avatars0.githubusercontent.com/u/20804935?v=4","gravatar_id":"","url":"https://api.github.com/users/immutability-io","html_url":"https://github.com/immutability-io","followers_url":"https://api.github.com/users/immutability-io/followers","following_url":"https://api.github.com/users/immutability-io/following{/other_user}","gists_url":"https://api.github.com/users/immutability-io/gists{/gist_id}","starred_url":"https://api.github.com/users/immutability-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/immutability-io/subscriptions","organizations_url":"https://api.github.com/users/immutability-io/orgs","repos_url":"https://api.github.com/users/immutability-io/repos","events_url":"https://api.github.com/users/immutability-io/events{/privacy}","received_events_url":"https://api.github.com/users/immutability-io/received_events","type":"Organization","site_admin":false},"repo":{"id":112760484,"node_id":"MDEwOlJlcG9zaXRvcnkxMTI3NjA0ODQ=","name":"vault-ethereum","full_name":"immutability-io/vault-ethereum","owner":{"login":"immutability-io","id":20804935,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwODA0OTM1","avatar_url":"https://avatars0.githubusercontent.com/u/20804935?v=4","gravatar_id":"","url":"https://api.github.com/users/immutability-io","html_url":"https://github.com/immutability-io","followers_url":"https://api.github.com/users/immutability-io/followers","following_url":"https://api.github.com/users/immutability-io/following{/other_user}","gists_url":"https://api.github.com/users/immutability-io/gists{/gist_id}","starred_url":"https://api.github.com/users/immutability-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/immutability-io/subscriptions","organizations_url":"https://api.github.com/users/immutability-io/orgs","repos_url":"https://api.github.com/users/immutability-io/repos","events_url":"https://api.github.com/users/immutability-io/events{/privacy}","received_events_url":"https://api.github.com/users/immutability-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/immutability-io/vault-ethereum","description":"A plugin that turns Vault into an Ethereum wallet.","fork":false,"url":"https://api.github.com/repos/immutability-io/vault-ethereum","forks_url":"https://api.github.com/repos/immutability-io/vault-ethereum/forks","keys_url":"https://api.github.com/repos/immutability-io/vault-ethereum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/immutability-io/vault-ethereum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/immutability-io/vault-ethereum/teams","hooks_url":"https://api.github.com/repos/immutability-io/vault-ethereum/hooks","issue_events_url":"https://api.github.com/repos/immutability-io/vault-ethereum/issues/events{/number}","events_url":"https://api.github.com/repos/immutability-io/vault-ethereum/events","assignees_url":"https://api.github.com/repos/immutability-io/vault-ethereum/assignees{/user}","branches_url":"https://api.github.com/repos/immutability-io/vault-ethereum/branches{/branch}","tags_url":"https://api.github.com/repos/immutability-io/vault-ethereum/tags","blobs_url":"https://api.github.com/repos/immutability-io/vault-ethereum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/immutability-io/vault-ethereum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/immutability-io/vault-ethereum/git/refs{/sha}","trees_url":"https://api.github.com/repos/immutability-io/vault-ethereum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/immutability-io/vault-ethereum/statuses/{sha}","languages_url":"https://api.github.com/repos/immutability-io/vault-ethereum/languages","stargazers_url":"https://api.github.com/repos/immutability-io/vault-ethereum/stargazers","contributors_url":"https://api.github.com/repos/immutability-io/vault-ethereum/contributors","subscribers_url":"https://api.github.com/repos/immutability-io/vault-ethereum/subscribers","subscription_url":"https://api.github.com/repos/immutability-io/vault-ethereum/subscription","commits_url":"https://api.github.com/repos/immutability-io/vault-ethereum/commits{/sha}","git_commits_url":"https://api.github.com/repos/immutability-io/vault-ethereum/git/commits{/sha}","comments_url":"https://api.github.com/repos/immutability-io/vault-ethereum/comments{/number}","issue_comment_url":"https://api.github.com/repos/immutability-io/vault-ethereum/issues/comments{/number}","contents_url":"https://api.github.com/repos/immutability-io/vault-ethereum/contents/{+path}","compare_url":"https://api.github.com/repos/immutability-io/vault-ethereum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/immutability-io/vault-ethereum/merges","archive_url":"https://api.github.com/repos/immutability-io/vault-ethereum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/immutability-io/vault-ethereum/downloads","issues_url":"https://api.github.com/repos/immutability-io/vault-ethereum/issues{/number}","pulls_url":"https://api.github.com/repos/immutability-io/vault-ethereum/pulls{/number}","milestones_url":"https://api.github.com/repos/immutability-io/vault-ethereum/milestones{/number}","notifications_url":"https://api.github.com/repos/immutability-io/vault-ethereum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/immutability-io/vault-ethereum/labels{/name}","releases_url":"https://api.github.com/repos/immutability-io/vault-ethereum/releases{/id}","deployments_url":"https://api.github.com/repos/immutability-io/vault-ethereum/deployments","created_at":"2017-12-01T16:16:56Z","updated_at":"2018-09-04T21:58:43Z","pushed_at":"2018-09-04T21:58:41Z","git_url":"git://github.com/immutability-io/vault-ethereum.git","ssh_url":"git@github.com:immutability-io/vault-ethereum.git","clone_url":"https://github.com/immutability-io/vault-ethereum.git","svn_url":"https://github.com/immutability-io/vault-ethereum","homepage":"","size":17145,"stargazers_count":42,"watchers_count":42,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":12,"open_issues":1,"watchers":42,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/immutability-io/vault-ethereum/pulls/23"},"html":{"href":"https://github.com/immutability-io/vault-ethereum/pull/23"},"issue":{"href":"https://api.github.com/repos/immutability-io/vault-ethereum/issues/23"},"comments":{"href":"https://api.github.com/repos/immutability-io/vault-ethereum/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/immutability-io/vault-ethereum/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/immutability-io/vault-ethereum/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/immutability-io/vault-ethereum/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/immutability-io/vault-ethereum/statuses/c099fd8d9e0db3e127c40967bf87c2c3ed5022c8"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":321,"deletions":2,"changed_files":4}}
{"actor":{"display_login":"DeRain"}}