{"action":"closed","number":465,"pull_request":{"url":"https://api.github.com/repos/2ndQuadrant/repmgr/pulls/465","id":198958572,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4OTU4NTcy","html_url":"https://github.com/2ndQuadrant/repmgr/pull/465","diff_url":"https://github.com/2ndQuadrant/repmgr/pull/465.diff","patch_url":"https://github.com/2ndQuadrant/repmgr/pull/465.patch","issue_url":"https://api.github.com/repos/2ndQuadrant/repmgr/issues/465","number":465,"state":"closed","locked":false,"title":"Update repmgrd logrotate example","user":{"login":"AndrzejNowicki","id":9307561,"node_id":"MDQ6VXNlcjkzMDc1NjE=","avatar_url":"https://avatars2.githubusercontent.com/u/9307561?v=4","gravatar_id":"","url":"https://api.github.com/users/AndrzejNowicki","html_url":"https://github.com/AndrzejNowicki","followers_url":"https://api.github.com/users/AndrzejNowicki/followers","following_url":"https://api.github.com/users/AndrzejNowicki/following{/other_user}","gists_url":"https://api.github.com/users/AndrzejNowicki/gists{/gist_id}","starred_url":"https://api.github.com/users/AndrzejNowicki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndrzejNowicki/subscriptions","organizations_url":"https://api.github.com/users/AndrzejNowicki/orgs","repos_url":"https://api.github.com/users/AndrzejNowicki/repos","events_url":"https://api.github.com/users/AndrzejNowicki/events{/privacy}","received_events_url":"https://api.github.com/users/AndrzejNowicki/received_events","type":"User","site_admin":false},"body":"The old logrotate configuration example might cause a situation in which repmgrd still has an open file descriptor to the logfile, but the file has already been rotated&removed by logrotate:\r\n```\r\n$ sudo ls -l /proc/`pidof repmgrd`/fd\r\ntotal 0\r\nlr-x------ 1 postgres postgres 64 Jul  3 14:30 0 -> /dev/null\r\nl-wx------ 1 postgres postgres 64 Jul  3 14:30 1 -> /dev/null\r\nl-wx------ 1 postgres postgres 64 Jul  3 14:30 2 -> /var/log/repmgr/repmgr-9.4.log.1 (deleted)\r\nlrwx------ 1 postgres postgres 64 Jul  3 14:30 3 -> socket:[246459548]\r\n```\r\nYou can still access the logfile via `cat /proc/PID/fd/2`, but the /var/log/repmgr/repmgr-9.4.log is empty.\r\n\r\nSetting up logrotate with copytruncate option is a workaround for that issue.\r\n\r\nAnother proposal would be to send a SIGHUP to repmgrd on file rotation, but currently the logfile file descriptor gets reopened only if the configuration is changed. See:\r\nhttps://github.com/2ndQuadrant/repmgr/blob/b2081dca523ca9ad6e516ba55302260f22272a2a/repmgrd-physical.c#L549\r\nAlso configuration reload caused by logrotate seems like a bad idea.\r\n\r\nAnother signal could be used for reopening the logfile, but copytruncate works well enough so I don't think it's that necessary.","created_at":"2018-07-03T13:12:04Z","updated_at":"2018-08-02T04:06:16Z","closed_at":"2018-08-02T04:06:16Z","merged_at":null,"merge_commit_sha":"9ee4034f8558764330da1886a49c6beba59302ef","assignee":{"login":"ibarwick","id":4560438,"node_id":"MDQ6VXNlcjQ1NjA0Mzg=","avatar_url":"https://avatars3.githubusercontent.com/u/4560438?v=4","gravatar_id":"","url":"https://api.github.com/users/ibarwick","html_url":"https://github.com/ibarwick","followers_url":"https://api.github.com/users/ibarwick/followers","following_url":"https://api.github.com/users/ibarwick/following{/other_user}","gists_url":"https://api.github.com/users/ibarwick/gists{/gist_id}","starred_url":"https://api.github.com/users/ibarwick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibarwick/subscriptions","organizations_url":"https://api.github.com/users/ibarwick/orgs","repos_url":"https://api.github.com/users/ibarwick/repos","events_url":"https://api.github.com/users/ibarwick/events{/privacy}","received_events_url":"https://api.github.com/users/ibarwick/received_events","type":"User","site_admin":false},"assignees":[{"login":"ibarwick","id":4560438,"node_id":"MDQ6VXNlcjQ1NjA0Mzg=","avatar_url":"https://avatars3.githubusercontent.com/u/4560438?v=4","gravatar_id":"","url":"https://api.github.com/users/ibarwick","html_url":"https://github.com/ibarwick","followers_url":"https://api.github.com/users/ibarwick/followers","following_url":"https://api.github.com/users/ibarwick/following{/other_user}","gists_url":"https://api.github.com/users/ibarwick/gists{/gist_id}","starred_url":"https://api.github.com/users/ibarwick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibarwick/subscriptions","organizations_url":"https://api.github.com/users/ibarwick/orgs","repos_url":"https://api.github.com/users/ibarwick/repos","events_url":"https://api.github.com/users/ibarwick/events{/privacy}","received_events_url":"https://api.github.com/users/ibarwick/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/2ndQuadrant/repmgr/milestones/18","html_url":"https://github.com/2ndQuadrant/repmgr/milestone/18","labels_url":"https://api.github.com/repos/2ndQuadrant/repmgr/milestones/18/labels","id":3530792,"node_id":"MDk6TWlsZXN0b25lMzUzMDc5Mg==","number":18,"title":"4.1.1","description":null,"creator":{"login":"ibarwick","id":4560438,"node_id":"MDQ6VXNlcjQ1NjA0Mzg=","avatar_url":"https://avatars3.githubusercontent.com/u/4560438?v=4","gravatar_id":"","url":"https://api.github.com/users/ibarwick","html_url":"https://github.com/ibarwick","followers_url":"https://api.github.com/users/ibarwick/followers","following_url":"https://api.github.com/users/ibarwick/following{/other_user}","gists_url":"https://api.github.com/users/ibarwick/gists{/gist_id}","starred_url":"https://api.github.com/users/ibarwick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibarwick/subscriptions","organizations_url":"https://api.github.com/users/ibarwick/orgs","repos_url":"https://api.github.com/users/ibarwick/repos","events_url":"https://api.github.com/users/ibarwick/events{/privacy}","received_events_url":"https://api.github.com/users/ibarwick/received_events","type":"User","site_admin":false},"open_issues":0,"closed_issues":2,"state":"open","created_at":"2018-07-30T01:49:31Z","updated_at":"2018-08-02T04:06:16Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/2ndQuadrant/repmgr/pulls/465/commits","review_comments_url":"https://api.github.com/repos/2ndQuadrant/repmgr/pulls/465/comments","review_comment_url":"https://api.github.com/repos/2ndQuadrant/repmgr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/2ndQuadrant/repmgr/issues/465/comments","statuses_url":"https://api.github.com/repos/2ndQuadrant/repmgr/statuses/6fb7c66360fd891432f9501db37201bc5d66172e","head":{"label":"AndrzejNowicki:patch-1","ref":"patch-1","sha":"6fb7c66360fd891432f9501db37201bc5d66172e","user":{"login":"AndrzejNowicki","id":9307561,"node_id":"MDQ6VXNlcjkzMDc1NjE=","avatar_url":"https://avatars2.githubusercontent.com/u/9307561?v=4","gravatar_id":"","url":"https://api.github.com/users/AndrzejNowicki","html_url":"https://github.com/AndrzejNowicki","followers_url":"https://api.github.com/users/AndrzejNowicki/followers","following_url":"https://api.github.com/users/AndrzejNowicki/following{/other_user}","gists_url":"https://api.github.com/users/AndrzejNowicki/gists{/gist_id}","starred_url":"https://api.github.com/users/AndrzejNowicki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndrzejNowicki/subscriptions","organizations_url":"https://api.github.com/users/AndrzejNowicki/orgs","repos_url":"https://api.github.com/users/AndrzejNowicki/repos","events_url":"https://api.github.com/users/AndrzejNowicki/events{/privacy}","received_events_url":"https://api.github.com/users/AndrzejNowicki/received_events","type":"User","site_admin":false},"repo":{"id":125030601,"node_id":"MDEwOlJlcG9zaXRvcnkxMjUwMzA2MDE=","name":"repmgr","full_name":"AndrzejNowicki/repmgr","owner":{"login":"AndrzejNowicki","id":9307561,"node_id":"MDQ6VXNlcjkzMDc1NjE=","avatar_url":"https://avatars2.githubusercontent.com/u/9307561?v=4","gravatar_id":"","url":"https://api.github.com/users/AndrzejNowicki","html_url":"https://github.com/AndrzejNowicki","followers_url":"https://api.github.com/users/AndrzejNowicki/followers","following_url":"https://api.github.com/users/AndrzejNowicki/following{/other_user}","gists_url":"https://api.github.com/users/AndrzejNowicki/gists{/gist_id}","starred_url":"https://api.github.com/users/AndrzejNowicki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndrzejNowicki/subscriptions","organizations_url":"https://api.github.com/users/AndrzejNowicki/orgs","repos_url":"https://api.github.com/users/AndrzejNowicki/repos","events_url":"https://api.github.com/users/AndrzejNowicki/events{/privacy}","received_events_url":"https://api.github.com/users/AndrzejNowicki/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AndrzejNowicki/repmgr","description":"The Most Popular Replication Manager for PostgreSQL (Postgres)","fork":true,"url":"https://api.github.com/repos/AndrzejNowicki/repmgr","forks_url":"https://api.github.com/repos/AndrzejNowicki/repmgr/forks","keys_url":"https://api.github.com/repos/AndrzejNowicki/repmgr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AndrzejNowicki/repmgr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AndrzejNowicki/repmgr/teams","hooks_url":"https://api.github.com/repos/AndrzejNowicki/repmgr/hooks","issue_events_url":"https://api.github.com/repos/AndrzejNowicki/repmgr/issues/events{/number}","events_url":"https://api.github.com/repos/AndrzejNowicki/repmgr/events","assignees_url":"https://api.github.com/repos/AndrzejNowicki/repmgr/assignees{/user}","branches_url":"https://api.github.com/repos/AndrzejNowicki/repmgr/branches{/branch}","tags_url":"https://api.github.com/repos/AndrzejNowicki/repmgr/tags","blobs_url":"https://api.github.com/repos/AndrzejNowicki/repmgr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AndrzejNowicki/repmgr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AndrzejNowicki/repmgr/git/refs{/sha}","trees_url":"https://api.github.com/repos/AndrzejNowicki/repmgr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AndrzejNowicki/repmgr/statuses/{sha}","languages_url":"https://api.github.com/repos/AndrzejNowicki/repmgr/languages","stargazers_url":"https://api.github.com/repos/AndrzejNowicki/repmgr/stargazers","contributors_url":"https://api.github.com/repos/AndrzejNowicki/repmgr/contributors","subscribers_url":"https://api.github.com/repos/AndrzejNowicki/repmgr/subscribers","subscription_url":"https://api.github.com/repos/AndrzejNowicki/repmgr/subscription","commits_url":"https://api.github.com/repos/AndrzejNowicki/repmgr/commits{/sha}","git_commits_url":"https://api.github.com/repos/AndrzejNowicki/repmgr/git/commits{/sha}","comments_url":"https://api.github.com/repos/AndrzejNowicki/repmgr/comments{/number}","issue_comment_url":"https://api.github.com/repos/AndrzejNowicki/repmgr/issues/comments{/number}","contents_url":"https://api.github.com/repos/AndrzejNowicki/repmgr/contents/{+path}","compare_url":"https://api.github.com/repos/AndrzejNowicki/repmgr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AndrzejNowicki/repmgr/merges","archive_url":"https://api.github.com/repos/AndrzejNowicki/repmgr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AndrzejNowicki/repmgr/downloads","issues_url":"https://api.github.com/repos/AndrzejNowicki/repmgr/issues{/number}","pulls_url":"https://api.github.com/repos/AndrzejNowicki/repmgr/pulls{/number}","milestones_url":"https://api.github.com/repos/AndrzejNowicki/repmgr/milestones{/number}","notifications_url":"https://api.github.com/repos/AndrzejNowicki/repmgr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AndrzejNowicki/repmgr/labels{/name}","releases_url":"https://api.github.com/repos/AndrzejNowicki/repmgr/releases{/id}","deployments_url":"https://api.github.com/repos/AndrzejNowicki/repmgr/deployments","created_at":"2018-03-13T10:03:42Z","updated_at":"2018-03-13T10:03:44Z","pushed_at":"2018-07-03T13:11:19Z","git_url":"git://github.com/AndrzejNowicki/repmgr.git","ssh_url":"git@github.com:AndrzejNowicki/repmgr.git","clone_url":"https://github.com/AndrzejNowicki/repmgr.git","svn_url":"https://github.com/AndrzejNowicki/repmgr","homepage":"https://www.repmgr.org/","size":5363,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"2ndQuadrant:master","ref":"master","sha":"8b059bc9b0bddab167da02f7979025330912dbbe","user":{"login":"2ndQuadrant","id":898233,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg5ODIzMw==","avatar_url":"https://avatars2.githubusercontent.com/u/898233?v=4","gravatar_id":"","url":"https://api.github.com/users/2ndQuadrant","html_url":"https://github.com/2ndQuadrant","followers_url":"https://api.github.com/users/2ndQuadrant/followers","following_url":"https://api.github.com/users/2ndQuadrant/following{/other_user}","gists_url":"https://api.github.com/users/2ndQuadrant/gists{/gist_id}","starred_url":"https://api.github.com/users/2ndQuadrant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/2ndQuadrant/subscriptions","organizations_url":"https://api.github.com/users/2ndQuadrant/orgs","repos_url":"https://api.github.com/users/2ndQuadrant/repos","events_url":"https://api.github.com/users/2ndQuadrant/events{/privacy}","received_events_url":"https://api.github.com/users/2ndQuadrant/received_events","type":"Organization","site_admin":false},"repo":{"id":2180048,"node_id":"MDEwOlJlcG9zaXRvcnkyMTgwMDQ4","name":"repmgr","full_name":"2ndQuadrant/repmgr","owner":{"login":"2ndQuadrant","id":898233,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg5ODIzMw==","avatar_url":"https://avatars2.githubusercontent.com/u/898233?v=4","gravatar_id":"","url":"https://api.github.com/users/2ndQuadrant","html_url":"https://github.com/2ndQuadrant","followers_url":"https://api.github.com/users/2ndQuadrant/followers","following_url":"https://api.github.com/users/2ndQuadrant/following{/other_user}","gists_url":"https://api.github.com/users/2ndQuadrant/gists{/gist_id}","starred_url":"https://api.github.com/users/2ndQuadrant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/2ndQuadrant/subscriptions","organizations_url":"https://api.github.com/users/2ndQuadrant/orgs","repos_url":"https://api.github.com/users/2ndQuadrant/repos","events_url":"https://api.github.com/users/2ndQuadrant/events{/privacy}","received_events_url":"https://api.github.com/users/2ndQuadrant/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/2ndQuadrant/repmgr","description":"The Most Popular Replication Manager for PostgreSQL (Postgres) - latest version 4.1.0 (2018-07-31)","fork":false,"url":"https://api.github.com/repos/2ndQuadrant/repmgr","forks_url":"https://api.github.com/repos/2ndQuadrant/repmgr/forks","keys_url":"https://api.github.com/repos/2ndQuadrant/repmgr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/2ndQuadrant/repmgr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/2ndQuadrant/repmgr/teams","hooks_url":"https://api.github.com/repos/2ndQuadrant/repmgr/hooks","issue_events_url":"https://api.github.com/repos/2ndQuadrant/repmgr/issues/events{/number}","events_url":"https://api.github.com/repos/2ndQuadrant/repmgr/events","assignees_url":"https://api.github.com/repos/2ndQuadrant/repmgr/assignees{/user}","branches_url":"https://api.github.com/repos/2ndQuadrant/repmgr/branches{/branch}","tags_url":"https://api.github.com/repos/2ndQuadrant/repmgr/tags","blobs_url":"https://api.github.com/repos/2ndQuadrant/repmgr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/2ndQuadrant/repmgr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/2ndQuadrant/repmgr/git/refs{/sha}","trees_url":"https://api.github.com/repos/2ndQuadrant/repmgr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/2ndQuadrant/repmgr/statuses/{sha}","languages_url":"https://api.github.com/repos/2ndQuadrant/repmgr/languages","stargazers_url":"https://api.github.com/repos/2ndQuadrant/repmgr/stargazers","contributors_url":"https://api.github.com/repos/2ndQuadrant/repmgr/contributors","subscribers_url":"https://api.github.com/repos/2ndQuadrant/repmgr/subscribers","subscription_url":"https://api.github.com/repos/2ndQuadrant/repmgr/subscription","commits_url":"https://api.github.com/repos/2ndQuadrant/repmgr/commits{/sha}","git_commits_url":"https://api.github.com/repos/2ndQuadrant/repmgr/git/commits{/sha}","comments_url":"https://api.github.com/repos/2ndQuadrant/repmgr/comments{/number}","issue_comment_url":"https://api.github.com/repos/2ndQuadrant/repmgr/issues/comments{/number}","contents_url":"https://api.github.com/repos/2ndQuadrant/repmgr/contents/{+path}","compare_url":"https://api.github.com/repos/2ndQuadrant/repmgr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/2ndQuadrant/repmgr/merges","archive_url":"https://api.github.com/repos/2ndQuadrant/repmgr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/2ndQuadrant/repmgr/downloads","issues_url":"https://api.github.com/repos/2ndQuadrant/repmgr/issues{/number}","pulls_url":"https://api.github.com/repos/2ndQuadrant/repmgr/pulls{/number}","milestones_url":"https://api.github.com/repos/2ndQuadrant/repmgr/milestones{/number}","notifications_url":"https://api.github.com/repos/2ndQuadrant/repmgr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/2ndQuadrant/repmgr/labels{/name}","releases_url":"https://api.github.com/repos/2ndQuadrant/repmgr/releases{/id}","deployments_url":"https://api.github.com/repos/2ndQuadrant/repmgr/deployments","created_at":"2011-08-09T15:35:43Z","updated_at":"2018-08-02T01:54:52Z","pushed_at":"2018-08-02T01:54:50Z","git_url":"git://github.com/2ndQuadrant/repmgr.git","ssh_url":"git@github.com:2ndQuadrant/repmgr.git","clone_url":"https://github.com/2ndQuadrant/repmgr.git","svn_url":"https://github.com/2ndQuadrant/repmgr","homepage":"https://repmgr.org/","size":4974,"stargazers_count":943,"watchers_count":943,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":184,"mirror_url":null,"archived":false,"open_issues_count":30,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":184,"open_issues":30,"watchers":943,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/2ndQuadrant/repmgr/pulls/465"},"html":{"href":"https://github.com/2ndQuadrant/repmgr/pull/465"},"issue":{"href":"https://api.github.com/repos/2ndQuadrant/repmgr/issues/465"},"comments":{"href":"https://api.github.com/repos/2ndQuadrant/repmgr/issues/465/comments"},"review_comments":{"href":"https://api.github.com/repos/2ndQuadrant/repmgr/pulls/465/comments"},"review_comment":{"href":"https://api.github.com/repos/2ndQuadrant/repmgr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/2ndQuadrant/repmgr/pulls/465/commits"},"statuses":{"href":"https://api.github.com/repos/2ndQuadrant/repmgr/statuses/6fb7c66360fd891432f9501db37201bc5d66172e"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":false,"rebaseable":false,"mergeable_state":"dirty","merged_by":null,"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":3,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"ibarwick"}}