{"action":"created","comment":{"url":"https://api.github.com/repos/uber/cadence/pulls/comments/182173280","pull_request_review_id":112927466,"id":182173280,"diff_hunk":"@@ -169,12 +197,13 @@ func (t *timerQueueStandbyProcessorImpl) processExpiredUserTimer(timerTask *pers\n \t\t\t\t//\n \t\t\t\t// we do not need to notity new timer to base, since if there is no new event being replicated\n \t\t\t\t// checking again if the timer can be completed is meaningless\n-\t\t\t\tt.timerQueueAckMgr.retryTimerTask(timerTask)\n-\t\t\t\treturn nil\n+\t\t\t\treturn newTaskRetryError()","path":"service/history/timerQueueStandbyProcessor.go","position":132,"original_position":132,"commit_id":"a33303dd15d5bf6af37ed87b6bfb9bfbe1dfc384","original_commit_id":"a33303dd15d5bf6af37ed87b6bfb9bfbe1dfc384","user":{"login":"wxing1292","id":8762893,"avatar_url":"https://avatars3.githubusercontent.com/u/8762893?v=4","gravatar_id":"","url":"https://api.github.com/users/wxing1292","html_url":"https://github.com/wxing1292","followers_url":"https://api.github.com/users/wxing1292/followers","following_url":"https://api.github.com/users/wxing1292/following{/other_user}","gists_url":"https://api.github.com/users/wxing1292/gists{/gist_id}","starred_url":"https://api.github.com/users/wxing1292/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wxing1292/subscriptions","organizations_url":"https://api.github.com/users/wxing1292/orgs","repos_url":"https://api.github.com/users/wxing1292/repos","events_url":"https://api.github.com/users/wxing1292/events{/privacy}","received_events_url":"https://api.github.com/users/wxing1292/received_events","type":"User","site_admin":false},"body":"ok","created_at":"2018-04-17T17:59:10Z","updated_at":"2018-04-17T17:59:10Z","html_url":"https://github.com/uber/cadence/pull/648#discussion_r182173280","pull_request_url":"https://api.github.com/repos/uber/cadence/pulls/648","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/uber/cadence/pulls/comments/182173280"},"html":{"href":"https://github.com/uber/cadence/pull/648#discussion_r182173280"},"pull_request":{"href":"https://api.github.com/repos/uber/cadence/pulls/648"}},"in_reply_to_id":182157359},"pull_request":{"url":"https://api.github.com/repos/uber/cadence/pulls/648","id":178777176,"html_url":"https://github.com/uber/cadence/pull/648","diff_url":"https://github.com/uber/cadence/pull/648.diff","patch_url":"https://github.com/uber/cadence/pull/648.patch","issue_url":"https://api.github.com/repos/uber/cadence/issues/648","number":648,"state":"open","locked":false,"title":"implemented functionality in timer ack manager & timer processor base to allow failover","user":{"login":"wxing1292","id":8762893,"avatar_url":"https://avatars3.githubusercontent.com/u/8762893?v=4","gravatar_id":"","url":"https://api.github.com/users/wxing1292","html_url":"https://github.com/wxing1292","followers_url":"https://api.github.com/users/wxing1292/followers","following_url":"https://api.github.com/users/wxing1292/following{/other_user}","gists_url":"https://api.github.com/users/wxing1292/gists{/gist_id}","starred_url":"https://api.github.com/users/wxing1292/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wxing1292/subscriptions","organizations_url":"https://api.github.com/users/wxing1292/orgs","repos_url":"https://api.github.com/users/wxing1292/repos","events_url":"https://api.github.com/users/wxing1292/events{/privacy}","received_events_url":"https://api.github.com/users/wxing1292/received_events","type":"User","site_admin":false},"body":"Partially solve #565","created_at":"2018-04-02T05:41:04Z","updated_at":"2018-04-17T17:59:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2058a3bc25e389ad6178eb23101c004bc76d42f1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/uber/cadence/pulls/648/commits","review_comments_url":"https://api.github.com/repos/uber/cadence/pulls/648/comments","review_comment_url":"https://api.github.com/repos/uber/cadence/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uber/cadence/issues/648/comments","statuses_url":"https://api.github.com/repos/uber/cadence/statuses/a33303dd15d5bf6af37ed87b6bfb9bfbe1dfc384","head":{"label":"uber:timer-Q-failover","ref":"timer-Q-failover","sha":"a33303dd15d5bf6af37ed87b6bfb9bfbe1dfc384","user":{"login":"uber","id":538264,"avatar_url":"https://avatars3.githubusercontent.com/u/538264?v=4","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"repo":{"id":82700090,"name":"cadence","full_name":"uber/cadence","owner":{"login":"uber","id":538264,"avatar_url":"https://avatars3.githubusercontent.com/u/538264?v=4","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber/cadence","description":"Cadence is a distributed, scalable, durable, and highly available orchestration engine to execute asynchronous long-running business logic in a scalable and resilient way.","fork":false,"url":"https://api.github.com/repos/uber/cadence","forks_url":"https://api.github.com/repos/uber/cadence/forks","keys_url":"https://api.github.com/repos/uber/cadence/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber/cadence/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber/cadence/teams","hooks_url":"https://api.github.com/repos/uber/cadence/hooks","issue_events_url":"https://api.github.com/repos/uber/cadence/issues/events{/number}","events_url":"https://api.github.com/repos/uber/cadence/events","assignees_url":"https://api.github.com/repos/uber/cadence/assignees{/user}","branches_url":"https://api.github.com/repos/uber/cadence/branches{/branch}","tags_url":"https://api.github.com/repos/uber/cadence/tags","blobs_url":"https://api.github.com/repos/uber/cadence/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber/cadence/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber/cadence/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber/cadence/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber/cadence/statuses/{sha}","languages_url":"https://api.github.com/repos/uber/cadence/languages","stargazers_url":"https://api.github.com/repos/uber/cadence/stargazers","contributors_url":"https://api.github.com/repos/uber/cadence/contributors","subscribers_url":"https://api.github.com/repos/uber/cadence/subscribers","subscription_url":"https://api.github.com/repos/uber/cadence/subscription","commits_url":"https://api.github.com/repos/uber/cadence/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber/cadence/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber/cadence/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber/cadence/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber/cadence/contents/{+path}","compare_url":"https://api.github.com/repos/uber/cadence/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber/cadence/merges","archive_url":"https://api.github.com/repos/uber/cadence/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber/cadence/downloads","issues_url":"https://api.github.com/repos/uber/cadence/issues{/number}","pulls_url":"https://api.github.com/repos/uber/cadence/pulls{/number}","milestones_url":"https://api.github.com/repos/uber/cadence/milestones{/number}","notifications_url":"https://api.github.com/repos/uber/cadence/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber/cadence/labels{/name}","releases_url":"https://api.github.com/repos/uber/cadence/releases{/id}","deployments_url":"https://api.github.com/repos/uber/cadence/deployments","created_at":"2017-02-21T16:10:18Z","updated_at":"2018-04-17T17:09:21Z","pushed_at":"2018-04-16T22:46:19Z","git_url":"git://github.com/uber/cadence.git","ssh_url":"git@github.com:uber/cadence.git","clone_url":"https://github.com/uber/cadence.git","svn_url":"https://github.com/uber/cadence","homepage":"","size":12796,"stargazers_count":279,"watchers_count":279,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":31,"mirror_url":null,"archived":false,"open_issues_count":121,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":31,"open_issues":121,"watchers":279,"default_branch":"master"}},"base":{"label":"uber:master","ref":"master","sha":"902840be0be77c2bc3fa6563bc04bbd78df7dcfe","user":{"login":"uber","id":538264,"avatar_url":"https://avatars3.githubusercontent.com/u/538264?v=4","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"repo":{"id":82700090,"name":"cadence","full_name":"uber/cadence","owner":{"login":"uber","id":538264,"avatar_url":"https://avatars3.githubusercontent.com/u/538264?v=4","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber/cadence","description":"Cadence is a distributed, scalable, durable, and highly available orchestration engine to execute asynchronous long-running business logic in a scalable and resilient way.","fork":false,"url":"https://api.github.com/repos/uber/cadence","forks_url":"https://api.github.com/repos/uber/cadence/forks","keys_url":"https://api.github.com/repos/uber/cadence/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber/cadence/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber/cadence/teams","hooks_url":"https://api.github.com/repos/uber/cadence/hooks","issue_events_url":"https://api.github.com/repos/uber/cadence/issues/events{/number}","events_url":"https://api.github.com/repos/uber/cadence/events","assignees_url":"https://api.github.com/repos/uber/cadence/assignees{/user}","branches_url":"https://api.github.com/repos/uber/cadence/branches{/branch}","tags_url":"https://api.github.com/repos/uber/cadence/tags","blobs_url":"https://api.github.com/repos/uber/cadence/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber/cadence/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber/cadence/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber/cadence/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber/cadence/statuses/{sha}","languages_url":"https://api.github.com/repos/uber/cadence/languages","stargazers_url":"https://api.github.com/repos/uber/cadence/stargazers","contributors_url":"https://api.github.com/repos/uber/cadence/contributors","subscribers_url":"https://api.github.com/repos/uber/cadence/subscribers","subscription_url":"https://api.github.com/repos/uber/cadence/subscription","commits_url":"https://api.github.com/repos/uber/cadence/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber/cadence/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber/cadence/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber/cadence/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber/cadence/contents/{+path}","compare_url":"https://api.github.com/repos/uber/cadence/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber/cadence/merges","archive_url":"https://api.github.com/repos/uber/cadence/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber/cadence/downloads","issues_url":"https://api.github.com/repos/uber/cadence/issues{/number}","pulls_url":"https://api.github.com/repos/uber/cadence/pulls{/number}","milestones_url":"https://api.github.com/repos/uber/cadence/milestones{/number}","notifications_url":"https://api.github.com/repos/uber/cadence/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber/cadence/labels{/name}","releases_url":"https://api.github.com/repos/uber/cadence/releases{/id}","deployments_url":"https://api.github.com/repos/uber/cadence/deployments","created_at":"2017-02-21T16:10:18Z","updated_at":"2018-04-17T17:09:21Z","pushed_at":"2018-04-16T22:46:19Z","git_url":"git://github.com/uber/cadence.git","ssh_url":"git@github.com:uber/cadence.git","clone_url":"https://github.com/uber/cadence.git","svn_url":"https://github.com/uber/cadence","homepage":"","size":12796,"stargazers_count":279,"watchers_count":279,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":31,"mirror_url":null,"archived":false,"open_issues_count":121,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":31,"open_issues":121,"watchers":279,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uber/cadence/pulls/648"},"html":{"href":"https://github.com/uber/cadence/pull/648"},"issue":{"href":"https://api.github.com/repos/uber/cadence/issues/648"},"comments":{"href":"https://api.github.com/repos/uber/cadence/issues/648/comments"},"review_comments":{"href":"https://api.github.com/repos/uber/cadence/pulls/648/comments"},"review_comment":{"href":"https://api.github.com/repos/uber/cadence/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uber/cadence/pulls/648/commits"},"statuses":{"href":"https://api.github.com/repos/uber/cadence/statuses/a33303dd15d5bf6af37ed87b6bfb9bfbe1dfc384"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"wxing1292"}}