{"action":"created","comment":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments/245462713","pull_request_review_id":189580697,"id":245462713,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NTQ2MjcxMw==","diff_hunk":"@@ -2037,13 +2037,14 @@ int editmap::mapgen_retarget()\n         action = ctxt.handle_input( BLINK_SPEED );\n         blink = !blink;\n         if( const cata::optional<tripoint> vec = ctxt.get_direction( action ) ) {\n-            tripoint ptarget = tripoint( target.x + ( vec->x * 24 ), target.y + ( vec->y * 24 ), target.z );\n-            if( pinbounds( ptarget ) && inbounds( ptarget.x + 24, ptarget.y + 24, ptarget.z ) ) {\n+            tripoint ptarget = tripoint( target.x + ( vec->x * SEEX * 2 ), target.y + ( vec->y * SEEY * 2 ),\n+                                         target.z );\n+            if( pinbounds( ptarget ) && inbounds( ptarget.x + SEEX * 2, ptarget.y + SEEY * 2, ptarget.z ) ) {\n                 target = ptarget;\n \n                 target_list.clear();\n-                for( int x = target.x - 11; x < target.x + 13; x++ ) {\n-                    for( int y = target.y - 11; y < target.y + 13; y++ ) {\n+                for( int x = target.x - SEEX + 1; x < target.x + SEEX + 1; x++ ) {\n+                    for( int y = target.y - SEEY + 1; y < target.y + SEEY + 1; y++ ) {","path":"src/editmap.cpp","position":93,"original_position":93,"commit_id":"a39f95edb763059809011abcd45865e15219d36f","original_commit_id":"a39f95edb763059809011abcd45865e15219d36f","user":{"login":"kevingranade","id":860276,"node_id":"MDQ6VXNlcjg2MDI3Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/860276?v=4","gravatar_id":"","url":"https://api.github.com/users/kevingranade","html_url":"https://github.com/kevingranade","followers_url":"https://api.github.com/users/kevingranade/followers","following_url":"https://api.github.com/users/kevingranade/following{/other_user}","gists_url":"https://api.github.com/users/kevingranade/gists{/gist_id}","starred_url":"https://api.github.com/users/kevingranade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevingranade/subscriptions","organizations_url":"https://api.github.com/users/kevingranade/orgs","repos_url":"https://api.github.com/users/kevingranade/repos","events_url":"https://api.github.com/users/kevingranade/events{/privacy}","received_events_url":"https://api.github.com/users/kevingranade/received_events","type":"User","site_admin":false},"body":"```suggestion\r\n                    for( int y = target.y - SEEY - 1; y < target.y + SEEY + 1; y++ ) {\r\n```","created_at":"2019-01-05T02:12:02Z","updated_at":"2019-01-05T02:12:02Z","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/27298#discussion_r245462713","pull_request_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/27298","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments/245462713"},"html":{"href":"https://github.com/CleverRaven/Cataclysm-DDA/pull/27298#discussion_r245462713"},"pull_request":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/27298"}}},"pull_request":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/27298","id":240817861,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwODE3ODYx","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/27298","diff_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/27298.diff","patch_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/27298.patch","issue_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/27298","number":27298,"state":"open","locked":false,"title":"Replaced magic numbers and formulas with defines","user":{"login":"ZhilkinSerg","id":16213433,"node_id":"MDQ6VXNlcjE2MjEzNDMz","avatar_url":"https://avatars0.githubusercontent.com/u/16213433?v=4","gravatar_id":"","url":"https://api.github.com/users/ZhilkinSerg","html_url":"https://github.com/ZhilkinSerg","followers_url":"https://api.github.com/users/ZhilkinSerg/followers","following_url":"https://api.github.com/users/ZhilkinSerg/following{/other_user}","gists_url":"https://api.github.com/users/ZhilkinSerg/gists{/gist_id}","starred_url":"https://api.github.com/users/ZhilkinSerg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZhilkinSerg/subscriptions","organizations_url":"https://api.github.com/users/ZhilkinSerg/orgs","repos_url":"https://api.github.com/users/ZhilkinSerg/repos","events_url":"https://api.github.com/users/ZhilkinSerg/events{/privacy}","received_events_url":"https://api.github.com/users/ZhilkinSerg/received_events","type":"User","site_admin":false},"body":"#### Summary\r\n\r\n```SUMMARY: None```\r\n\r\n#### Purpose of change\r\n\r\nReduce number of magic numbers in the code and normalize defines in coordinate related formulas.","created_at":"2018-12-25T00:20:38Z","updated_at":"2019-01-05T02:12:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"79a203cfbfcaebb1ecfff45fcd9d792e14763721","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":887839346,"node_id":"MDU6TGFiZWw4ODc4MzkzNDY=","url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/labels/Code:%20Astyle%20/%20Optimization","name":"Code: Astyle / Optimization","color":"cc126f","default":false},{"id":659366627,"node_id":"MDU6TGFiZWw2NTkzNjY2Mjc=","url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/labels/[C++]","name":"[C++]","color":"f9d0c4","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/27298/commits","review_comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/27298/comments","review_comment_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/27298/comments","statuses_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/a39f95edb763059809011abcd45865e15219d36f","head":{"label":"ZhilkinSerg:coords-normalize-defines","ref":"coords-normalize-defines","sha":"a39f95edb763059809011abcd45865e15219d36f","user":{"login":"ZhilkinSerg","id":16213433,"node_id":"MDQ6VXNlcjE2MjEzNDMz","avatar_url":"https://avatars0.githubusercontent.com/u/16213433?v=4","gravatar_id":"","url":"https://api.github.com/users/ZhilkinSerg","html_url":"https://github.com/ZhilkinSerg","followers_url":"https://api.github.com/users/ZhilkinSerg/followers","following_url":"https://api.github.com/users/ZhilkinSerg/following{/other_user}","gists_url":"https://api.github.com/users/ZhilkinSerg/gists{/gist_id}","starred_url":"https://api.github.com/users/ZhilkinSerg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZhilkinSerg/subscriptions","organizations_url":"https://api.github.com/users/ZhilkinSerg/orgs","repos_url":"https://api.github.com/users/ZhilkinSerg/repos","events_url":"https://api.github.com/users/ZhilkinSerg/events{/privacy}","received_events_url":"https://api.github.com/users/ZhilkinSerg/received_events","type":"User","site_admin":false},"repo":{"id":81851736,"node_id":"MDEwOlJlcG9zaXRvcnk4MTg1MTczNg==","name":"Cataclysm-DDA","full_name":"ZhilkinSerg/Cataclysm-DDA","private":false,"owner":{"login":"ZhilkinSerg","id":16213433,"node_id":"MDQ6VXNlcjE2MjEzNDMz","avatar_url":"https://avatars0.githubusercontent.com/u/16213433?v=4","gravatar_id":"","url":"https://api.github.com/users/ZhilkinSerg","html_url":"https://github.com/ZhilkinSerg","followers_url":"https://api.github.com/users/ZhilkinSerg/followers","following_url":"https://api.github.com/users/ZhilkinSerg/following{/other_user}","gists_url":"https://api.github.com/users/ZhilkinSerg/gists{/gist_id}","starred_url":"https://api.github.com/users/ZhilkinSerg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZhilkinSerg/subscriptions","organizations_url":"https://api.github.com/users/ZhilkinSerg/orgs","repos_url":"https://api.github.com/users/ZhilkinSerg/repos","events_url":"https://api.github.com/users/ZhilkinSerg/events{/privacy}","received_events_url":"https://api.github.com/users/ZhilkinSerg/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ZhilkinSerg/Cataclysm-DDA","description":"Cataclysm - Dark Days Ahead. A fork/variant of Cataclysm Roguelike by Whales.","fork":true,"url":"https://api.github.com/repos/ZhilkinSerg/Cataclysm-DDA","forks_url":"https://api.github.com/repos/ZhilkinSerg/Cataclysm-DDA/forks","keys_url":"https://api.github.com/repos/ZhilkinSerg/Cataclysm-DDA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ZhilkinSerg/Cataclysm-DDA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ZhilkinSerg/Cataclysm-DDA/teams","hooks_url":"https://api.github.com/repos/ZhilkinSerg/Cataclysm-DDA/hooks","issue_events_url":"https://api.github.com/repos/ZhilkinSerg/Cataclysm-DDA/issues/events{/number}","events_url":"https://api.github.com/repos/ZhilkinSerg/Cataclysm-DDA/events","assignees_url":"https://api.github.com/repos/ZhilkinSerg/Cataclysm-DDA/assignees{/user}","branches_url":"https://api.github.com/repos/ZhilkinSerg/Cataclysm-DDA/branches{/branch}","tags_url":"https://api.github.com/repos/ZhilkinSerg/Cataclysm-DDA/tags","blobs_url":"https://api.github.com/repos/ZhilkinSerg/Cataclysm-DDA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ZhilkinSerg/Cataclysm-DDA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ZhilkinSerg/Cataclysm-DDA/git/refs{/sha}","trees_url":"https://api.github.com/repos/ZhilkinSerg/Cataclysm-DDA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ZhilkinSerg/Cataclysm-DDA/statuses/{sha}","languages_url":"https://api.github.com/repos/ZhilkinSerg/Cataclysm-DDA/languages","stargazers_url":"https://api.github.com/repos/ZhilkinSerg/Cataclysm-DDA/stargazers","contributors_url":"https://api.github.com/repos/ZhilkinSerg/Cataclysm-DDA/contributors","subscribers_url":"https://api.github.com/repos/ZhilkinSerg/Cataclysm-DDA/subscribers","subscription_url":"https://api.github.com/repos/ZhilkinSerg/Cataclysm-DDA/subscription","commits_url":"https://api.github.com/repos/ZhilkinSerg/Cataclysm-DDA/commits{/sha}","git_commits_url":"https://api.github.com/repos/ZhilkinSerg/Cataclysm-DDA/git/commits{/sha}","comments_url":"https://api.github.com/repos/ZhilkinSerg/Cataclysm-DDA/comments{/number}","issue_comment_url":"https://api.github.com/repos/ZhilkinSerg/Cataclysm-DDA/issues/comments{/number}","contents_url":"https://api.github.com/repos/ZhilkinSerg/Cataclysm-DDA/contents/{+path}","compare_url":"https://api.github.com/repos/ZhilkinSerg/Cataclysm-DDA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ZhilkinSerg/Cataclysm-DDA/merges","archive_url":"https://api.github.com/repos/ZhilkinSerg/Cataclysm-DDA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ZhilkinSerg/Cataclysm-DDA/downloads","issues_url":"https://api.github.com/repos/ZhilkinSerg/Cataclysm-DDA/issues{/number}","pulls_url":"https://api.github.com/repos/ZhilkinSerg/Cataclysm-DDA/pulls{/number}","milestones_url":"https://api.github.com/repos/ZhilkinSerg/Cataclysm-DDA/milestones{/number}","notifications_url":"https://api.github.com/repos/ZhilkinSerg/Cataclysm-DDA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ZhilkinSerg/Cataclysm-DDA/labels{/name}","releases_url":"https://api.github.com/repos/ZhilkinSerg/Cataclysm-DDA/releases{/id}","deployments_url":"https://api.github.com/repos/ZhilkinSerg/Cataclysm-DDA/deployments","created_at":"2017-02-13T17:27:56Z","updated_at":"2019-01-04T08:19:39Z","pushed_at":"2019-01-04T08:19:38Z","git_url":"git://github.com/ZhilkinSerg/Cataclysm-DDA.git","ssh_url":"git@github.com:ZhilkinSerg/Cataclysm-DDA.git","clone_url":"https://github.com/ZhilkinSerg/Cataclysm-DDA.git","svn_url":"https://github.com/ZhilkinSerg/Cataclysm-DDA","homepage":"http://en.cataclysmdda.com/","size":1478603,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"CleverRaven:master","ref":"master","sha":"1d28cb1e3048a7633f80fb5ac1713ad6b5ed02b3","user":{"login":"CleverRaven","id":4367009,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzNjcwMDk=","avatar_url":"https://avatars0.githubusercontent.com/u/4367009?v=4","gravatar_id":"","url":"https://api.github.com/users/CleverRaven","html_url":"https://github.com/CleverRaven","followers_url":"https://api.github.com/users/CleverRaven/followers","following_url":"https://api.github.com/users/CleverRaven/following{/other_user}","gists_url":"https://api.github.com/users/CleverRaven/gists{/gist_id}","starred_url":"https://api.github.com/users/CleverRaven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CleverRaven/subscriptions","organizations_url":"https://api.github.com/users/CleverRaven/orgs","repos_url":"https://api.github.com/users/CleverRaven/repos","events_url":"https://api.github.com/users/CleverRaven/events{/privacy}","received_events_url":"https://api.github.com/users/CleverRaven/received_events","type":"Organization","site_admin":false},"repo":{"id":5973855,"node_id":"MDEwOlJlcG9zaXRvcnk1OTczODU1","name":"Cataclysm-DDA","full_name":"CleverRaven/Cataclysm-DDA","private":false,"owner":{"login":"CleverRaven","id":4367009,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzNjcwMDk=","avatar_url":"https://avatars0.githubusercontent.com/u/4367009?v=4","gravatar_id":"","url":"https://api.github.com/users/CleverRaven","html_url":"https://github.com/CleverRaven","followers_url":"https://api.github.com/users/CleverRaven/followers","following_url":"https://api.github.com/users/CleverRaven/following{/other_user}","gists_url":"https://api.github.com/users/CleverRaven/gists{/gist_id}","starred_url":"https://api.github.com/users/CleverRaven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CleverRaven/subscriptions","organizations_url":"https://api.github.com/users/CleverRaven/orgs","repos_url":"https://api.github.com/users/CleverRaven/repos","events_url":"https://api.github.com/users/CleverRaven/events{/privacy}","received_events_url":"https://api.github.com/users/CleverRaven/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/CleverRaven/Cataclysm-DDA","description":"Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.","fork":false,"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA","forks_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/forks","keys_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/teams","hooks_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/hooks","issue_events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/events{/number}","events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/events","assignees_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/assignees{/user}","branches_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/branches{/branch}","tags_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/tags","blobs_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/refs{/sha}","trees_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/{sha}","languages_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/languages","stargazers_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/stargazers","contributors_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/contributors","subscribers_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/subscribers","subscription_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/subscription","commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/commits{/sha}","git_commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/commits{/sha}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/comments{/number}","issue_comment_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/comments{/number}","contents_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/contents/{+path}","compare_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/merges","archive_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/downloads","issues_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues{/number}","pulls_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls{/number}","milestones_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/milestones{/number}","notifications_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/labels{/name}","releases_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/releases{/id}","deployments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/deployments","created_at":"2012-09-26T22:57:43Z","updated_at":"2019-01-05T01:41:21Z","pushed_at":"2019-01-05T01:41:08Z","git_url":"git://github.com/CleverRaven/Cataclysm-DDA.git","ssh_url":"git@github.com:CleverRaven/Cataclysm-DDA.git","clone_url":"https://github.com/CleverRaven/Cataclysm-DDA.git","svn_url":"https://github.com/CleverRaven/Cataclysm-DDA","homepage":"http://cataclysmdda.org","size":1482058,"stargazers_count":2391,"watchers_count":2391,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1556,"mirror_url":null,"archived":false,"open_issues_count":1095,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1556,"open_issues":1095,"watchers":2391,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/27298"},"html":{"href":"https://github.com/CleverRaven/Cataclysm-DDA/pull/27298"},"issue":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/27298"},"comments":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/27298/comments"},"review_comments":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/27298/comments"},"review_comment":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/27298/commits"},"statuses":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/a39f95edb763059809011abcd45865e15219d36f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kevingranade"}}