{"action":"created","issue":{"url":"https://api.github.com/repos/mailcow/mailcow-dockerized/issues/709","repository_url":"https://api.github.com/repos/mailcow/mailcow-dockerized","labels_url":"https://api.github.com/repos/mailcow/mailcow-dockerized/issues/709/labels{/name}","comments_url":"https://api.github.com/repos/mailcow/mailcow-dockerized/issues/709/comments","events_url":"https://api.github.com/repos/mailcow/mailcow-dockerized/issues/709/events","html_url":"https://github.com/mailcow/mailcow-dockerized/pull/709","id":270469769,"node_id":"MDExOlB1bGxSZXF1ZXN0MTUwMTU5Mjk0","number":709,"title":"Verfify additional subdomains","user":{"login":"markusg","id":236166,"node_id":"MDQ6VXNlcjIzNjE2Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/236166?v=4","gravatar_id":"","url":"https://api.github.com/users/markusg","html_url":"https://github.com/markusg","followers_url":"https://api.github.com/users/markusg/followers","following_url":"https://api.github.com/users/markusg/following{/other_user}","gists_url":"https://api.github.com/users/markusg/gists{/gist_id}","starred_url":"https://api.github.com/users/markusg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markusg/subscriptions","organizations_url":"https://api.github.com/users/markusg/orgs","repos_url":"https://api.github.com/users/markusg/repos","events_url":"https://api.github.com/users/markusg/events{/privacy}","received_events_url":"https://api.github.com/users/markusg/received_events","type":"User","site_admin":false},"labels":[{"id":851914702,"node_id":"MDU6TGFiZWw4NTE5MTQ3MDI=","url":"https://api.github.com/repos/mailcow/mailcow-dockerized/labels/dunno","name":"dunno","color":"5171c1","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2017-11-01T22:10:36Z","updated_at":"2018-10-14T08:51:07Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/mailcow/mailcow-dockerized/pulls/709","html_url":"https://github.com/mailcow/mailcow-dockerized/pull/709","diff_url":"https://github.com/mailcow/mailcow-dockerized/pull/709.diff","patch_url":"https://github.com/mailcow/mailcow-dockerized/pull/709.patch"},"body":"Me and obviously some other users (https://github.com/mailcow/mailcow-dockerized/issues/528) don't use only one domain, but want to provide the service under additional subdomains for user convenience. (mail.* but also roundcube.*...  whatever)\r\n\r\nI want to give a starting porint, with the way i do it at the moment:\r\n\r\nThis introduces an ADDITIONAL_SUBDOMAINS env variable, where you can specify additional subdomains, which are then verfied with letsencrypt for all SQL_DOMAINS.\r\nThis saved me A LOT of typing for the ADDITIONAL_SAN 😄 \r\n\r\nHowever there are two limitations:\r\n1. You cannot go beyound 100 names per certificate, which makes it applicable to only a limited range of  usecases.\r\n2.  The autoconfig.* content is not yet remapped - i don't think this is necessary: I use  the feature to not have to explain to the user that they have to use the main mailcowdomain.\r\n\r\nWhat also could be done is the convenience redirect (https://github.com/mailcow/mailcow-dockerized/issues/625).\r\n\r\nAny thoughts on this?"},"comment":{"url":"https://api.github.com/repos/mailcow/mailcow-dockerized/issues/comments/429607754","html_url":"https://github.com/mailcow/mailcow-dockerized/pull/709#issuecomment-429607754","issue_url":"https://api.github.com/repos/mailcow/mailcow-dockerized/issues/709","id":429607754,"node_id":"MDEyOklzc3VlQ29tbWVudDQyOTYwNzc1NA==","user":{"login":"markusg","id":236166,"node_id":"MDQ6VXNlcjIzNjE2Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/236166?v=4","gravatar_id":"","url":"https://api.github.com/users/markusg","html_url":"https://github.com/markusg","followers_url":"https://api.github.com/users/markusg/followers","following_url":"https://api.github.com/users/markusg/following{/other_user}","gists_url":"https://api.github.com/users/markusg/gists{/gist_id}","starred_url":"https://api.github.com/users/markusg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markusg/subscriptions","organizations_url":"https://api.github.com/users/markusg/orgs","repos_url":"https://api.github.com/users/markusg/repos","events_url":"https://api.github.com/users/markusg/events{/privacy}","received_events_url":"https://api.github.com/users/markusg/received_events","type":"User","site_admin":false},"created_at":"2018-10-14T08:51:07Z","updated_at":"2018-10-14T08:51:07Z","author_association":"CONTRIBUTOR","body":"Before this goes stale and to avoid confusion: forget all the upper posts.\r\nThis PR does two things:\r\n1. cleanup the entrypoint.sh of ACME to not have the duplicate code for autoconfig.* and autodiscover.* \r\n2. recognizes subdomain.* from ADDITIONAL_SAN to allow the same mechanism for custom subdomains.\r\n"}}
{"actor":{"display_login":"markusg"}}