{"action":"created","comment":{"url":"https://api.github.com/repos/jenkinsci/docker/pulls/comments/234175444","pull_request_review_id":175763543,"id":234175444,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDE3NTQ0NA==","diff_hunk":"@@ -1,10 +1,47 @@\n ROOT_DIR=\"$(shell dirname $(realpath $(lastword $(MAKEFILE_LIST))))/\"\n \n+all: shellcheck build test\n+\n shellcheck:\n \t# TODO: remove SC1117 exclusion when on shellcheck > 0.5.0\n \t$(ROOT_DIR)/tools/shellcheck -e SC1091 \\\n \t                             -e SC1117 \\\n \t                             jenkins-support \\\n \t                             *.sh\n \n-.PHONY: shellcheck\n+build: build-debian build-alpine build-slim\n+\n+build-debian:\n+\tdocker build --file Dockerfile .\n+\n+build-alpine:\n+\tdocker build --file Dockerfile-alpine .\n+\n+build-slim:\n+\tdocker build --file Dockerfile-slim .\n+\n+bats:\n+\tgit clone https://github.com/sstephenson/bats.git\n+\n+prepare-test: bats\n+\tgit submodule update --init --recursive\n+\n+test-debian: prepare-test\n+\tDOCKERFILE=Dockerfile bats/bin/bats tests\n+\n+test-alpine: prepare-test\n+\tDOCKERFILE=Dockerfile-alpine bats/bin/bats tests\n+\n+test-slim: prepare-test\n+\tDOCKERFILE=Dockerfile-slim bats/bin/bats tests\n+\n+test: test-debian test-alpine test-slim\n+\n+clean:\n+\trm -rf tests/test_helper/bats-*; \\\n+\trm -rf bats\n+\n+publish:","path":"Makefile","position":45,"original_position":45,"commit_id":"9a1be7e3c6099ea350663dfec30e2c478152c9cd","original_commit_id":"9a1be7e3c6099ea350663dfec30e2c478152c9cd","user":{"login":"batmat","id":223853,"node_id":"MDQ6VXNlcjIyMzg1Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/223853?v=4","gravatar_id":"","url":"https://api.github.com/users/batmat","html_url":"https://github.com/batmat","followers_url":"https://api.github.com/users/batmat/followers","following_url":"https://api.github.com/users/batmat/following{/other_user}","gists_url":"https://api.github.com/users/batmat/gists{/gist_id}","starred_url":"https://api.github.com/users/batmat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/batmat/subscriptions","organizations_url":"https://api.github.com/users/batmat/orgs","repos_url":"https://api.github.com/users/batmat/repos","events_url":"https://api.github.com/users/batmat/events{/privacy}","received_events_url":"https://api.github.com/users/batmat/received_events","type":"User","site_admin":false},"body":"Planned more probably for a followup, as it's harder to test locally. I plan to see how I can make it possible to override the target repo to push to, so that a developer can test the image publication too, but pushing to some Docker repository location where one is allowed to.","created_at":"2018-11-16T11:34:57Z","updated_at":"2018-11-16T11:34:58Z","html_url":"https://github.com/jenkinsci/docker/pull/760#discussion_r234175444","pull_request_url":"https://api.github.com/repos/jenkinsci/docker/pulls/760","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/docker/pulls/comments/234175444"},"html":{"href":"https://github.com/jenkinsci/docker/pull/760#discussion_r234175444"},"pull_request":{"href":"https://api.github.com/repos/jenkinsci/docker/pulls/760"}}},"pull_request":{"url":"https://api.github.com/repos/jenkinsci/docker/pulls/760","id":231499843,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxNDk5ODQz","html_url":"https://github.com/jenkinsci/docker/pull/760","diff_url":"https://github.com/jenkinsci/docker/pull/760.diff","patch_url":"https://github.com/jenkinsci/docker/pull/760.patch","issue_url":"https://api.github.com/repos/jenkinsci/docker/issues/760","number":760,"state":"open","locked":false,"title":"Ease local development by adding make targets","user":{"login":"batmat","id":223853,"node_id":"MDQ6VXNlcjIyMzg1Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/223853?v=4","gravatar_id":"","url":"https://api.github.com/users/batmat","html_url":"https://github.com/batmat","followers_url":"https://api.github.com/users/batmat/followers","following_url":"https://api.github.com/users/batmat/following{/other_user}","gists_url":"https://api.github.com/users/batmat/gists{/gist_id}","starred_url":"https://api.github.com/users/batmat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/batmat/subscriptions","organizations_url":"https://api.github.com/users/batmat/orgs","repos_url":"https://api.github.com/users/batmat/repos","events_url":"https://api.github.com/users/batmat/events{/privacy}","received_events_url":"https://api.github.com/users/batmat/received_events","type":"User","site_admin":false},"body":"Also use them in Jenkinsfile for moar behavior consistency.\r\n\r\nOne can do for instance:\r\n\r\n* `make` # will build and test everything locally\r\n* `make test-debian`\r\netc.","created_at":"2018-11-16T11:29:32Z","updated_at":"2018-11-16T11:34:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"92356dc6dad172acafa78fe8d3c2e0d5ea11389c","assignee":null,"assignees":[],"requested_reviewers":[{"login":"carlossg","id":23651,"node_id":"MDQ6VXNlcjIzNjUx","avatar_url":"https://avatars2.githubusercontent.com/u/23651?v=4","gravatar_id":"","url":"https://api.github.com/users/carlossg","html_url":"https://github.com/carlossg","followers_url":"https://api.github.com/users/carlossg/followers","following_url":"https://api.github.com/users/carlossg/following{/other_user}","gists_url":"https://api.github.com/users/carlossg/gists{/gist_id}","starred_url":"https://api.github.com/users/carlossg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlossg/subscriptions","organizations_url":"https://api.github.com/users/carlossg/orgs","repos_url":"https://api.github.com/users/carlossg/repos","events_url":"https://api.github.com/users/carlossg/events{/privacy}","received_events_url":"https://api.github.com/users/carlossg/received_events","type":"User","site_admin":false},{"login":"ndeloof","id":132757,"node_id":"MDQ6VXNlcjEzMjc1Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/132757?v=4","gravatar_id":"","url":"https://api.github.com/users/ndeloof","html_url":"https://github.com/ndeloof","followers_url":"https://api.github.com/users/ndeloof/followers","following_url":"https://api.github.com/users/ndeloof/following{/other_user}","gists_url":"https://api.github.com/users/ndeloof/gists{/gist_id}","starred_url":"https://api.github.com/users/ndeloof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndeloof/subscriptions","organizations_url":"https://api.github.com/users/ndeloof/orgs","repos_url":"https://api.github.com/users/ndeloof/repos","events_url":"https://api.github.com/users/ndeloof/events{/privacy}","received_events_url":"https://api.github.com/users/ndeloof/received_events","type":"User","site_admin":false}],"requested_teams":[{"name":"Java11 support","id":2991889,"node_id":"MDQ6VGVhbTI5OTE4ODk=","slug":"java11-support","description":"Java 11 Support Team (JEP-211)","privacy":"closed","url":"https://api.github.com/teams/2991889","members_url":"https://api.github.com/teams/2991889/members{/member}","repositories_url":"https://api.github.com/teams/2991889/repos","permission":"pull"}],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jenkinsci/docker/pulls/760/commits","review_comments_url":"https://api.github.com/repos/jenkinsci/docker/pulls/760/comments","review_comment_url":"https://api.github.com/repos/jenkinsci/docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jenkinsci/docker/issues/760/comments","statuses_url":"https://api.github.com/repos/jenkinsci/docker/statuses/9a1be7e3c6099ea350663dfec30e2c478152c9cd","head":{"label":"batmat:JENKINS-51985-prequel-make-it-easier-to-local-dev","ref":"JENKINS-51985-prequel-make-it-easier-to-local-dev","sha":"9a1be7e3c6099ea350663dfec30e2c478152c9cd","user":{"login":"batmat","id":223853,"node_id":"MDQ6VXNlcjIyMzg1Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/223853?v=4","gravatar_id":"","url":"https://api.github.com/users/batmat","html_url":"https://github.com/batmat","followers_url":"https://api.github.com/users/batmat/followers","following_url":"https://api.github.com/users/batmat/following{/other_user}","gists_url":"https://api.github.com/users/batmat/gists{/gist_id}","starred_url":"https://api.github.com/users/batmat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/batmat/subscriptions","organizations_url":"https://api.github.com/users/batmat/orgs","repos_url":"https://api.github.com/users/batmat/repos","events_url":"https://api.github.com/users/batmat/events{/privacy}","received_events_url":"https://api.github.com/users/batmat/received_events","type":"User","site_admin":false},"repo":{"id":47499954,"node_id":"MDEwOlJlcG9zaXRvcnk0NzQ5OTk1NA==","name":"docker","full_name":"batmat/docker","private":false,"owner":{"login":"batmat","id":223853,"node_id":"MDQ6VXNlcjIyMzg1Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/223853?v=4","gravatar_id":"","url":"https://api.github.com/users/batmat","html_url":"https://github.com/batmat","followers_url":"https://api.github.com/users/batmat/followers","following_url":"https://api.github.com/users/batmat/following{/other_user}","gists_url":"https://api.github.com/users/batmat/gists{/gist_id}","starred_url":"https://api.github.com/users/batmat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/batmat/subscriptions","organizations_url":"https://api.github.com/users/batmat/orgs","repos_url":"https://api.github.com/users/batmat/repos","events_url":"https://api.github.com/users/batmat/events{/privacy}","received_events_url":"https://api.github.com/users/batmat/received_events","type":"User","site_admin":false},"html_url":"https://github.com/batmat/docker","description":"Docker official jenkins repo","fork":true,"url":"https://api.github.com/repos/batmat/docker","forks_url":"https://api.github.com/repos/batmat/docker/forks","keys_url":"https://api.github.com/repos/batmat/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/batmat/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/batmat/docker/teams","hooks_url":"https://api.github.com/repos/batmat/docker/hooks","issue_events_url":"https://api.github.com/repos/batmat/docker/issues/events{/number}","events_url":"https://api.github.com/repos/batmat/docker/events","assignees_url":"https://api.github.com/repos/batmat/docker/assignees{/user}","branches_url":"https://api.github.com/repos/batmat/docker/branches{/branch}","tags_url":"https://api.github.com/repos/batmat/docker/tags","blobs_url":"https://api.github.com/repos/batmat/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/batmat/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/batmat/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/batmat/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/batmat/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/batmat/docker/languages","stargazers_url":"https://api.github.com/repos/batmat/docker/stargazers","contributors_url":"https://api.github.com/repos/batmat/docker/contributors","subscribers_url":"https://api.github.com/repos/batmat/docker/subscribers","subscription_url":"https://api.github.com/repos/batmat/docker/subscription","commits_url":"https://api.github.com/repos/batmat/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/batmat/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/batmat/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/batmat/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/batmat/docker/contents/{+path}","compare_url":"https://api.github.com/repos/batmat/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/batmat/docker/merges","archive_url":"https://api.github.com/repos/batmat/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/batmat/docker/downloads","issues_url":"https://api.github.com/repos/batmat/docker/issues{/number}","pulls_url":"https://api.github.com/repos/batmat/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/batmat/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/batmat/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/batmat/docker/labels{/name}","releases_url":"https://api.github.com/repos/batmat/docker/releases{/id}","deployments_url":"https://api.github.com/repos/batmat/docker/deployments","created_at":"2015-12-06T14:29:06Z","updated_at":"2015-12-06T14:29:07Z","pushed_at":"2018-11-16T11:28:13Z","git_url":"git://github.com/batmat/docker.git","ssh_url":"git@github.com:batmat/docker.git","clone_url":"https://github.com/batmat/docker.git","svn_url":"https://github.com/batmat/docker","homepage":"https://hub.docker.com","size":172,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jenkinsci:master","ref":"master","sha":"b7b551075f3b2e7de8ea654023c77ab305f64446","user":{"login":"jenkinsci","id":107424,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNzQyNA==","avatar_url":"https://avatars0.githubusercontent.com/u/107424?v=4","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"repo":{"id":21969270,"node_id":"MDEwOlJlcG9zaXRvcnkyMTk2OTI3MA==","name":"docker","full_name":"jenkinsci/docker","private":false,"owner":{"login":"jenkinsci","id":107424,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNzQyNA==","avatar_url":"https://avatars0.githubusercontent.com/u/107424?v=4","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/jenkinsci/docker","description":"Docker official jenkins repo","fork":true,"url":"https://api.github.com/repos/jenkinsci/docker","forks_url":"https://api.github.com/repos/jenkinsci/docker/forks","keys_url":"https://api.github.com/repos/jenkinsci/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkinsci/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkinsci/docker/teams","hooks_url":"https://api.github.com/repos/jenkinsci/docker/hooks","issue_events_url":"https://api.github.com/repos/jenkinsci/docker/issues/events{/number}","events_url":"https://api.github.com/repos/jenkinsci/docker/events","assignees_url":"https://api.github.com/repos/jenkinsci/docker/assignees{/user}","branches_url":"https://api.github.com/repos/jenkinsci/docker/branches{/branch}","tags_url":"https://api.github.com/repos/jenkinsci/docker/tags","blobs_url":"https://api.github.com/repos/jenkinsci/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkinsci/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkinsci/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkinsci/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkinsci/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkinsci/docker/languages","stargazers_url":"https://api.github.com/repos/jenkinsci/docker/stargazers","contributors_url":"https://api.github.com/repos/jenkinsci/docker/contributors","subscribers_url":"https://api.github.com/repos/jenkinsci/docker/subscribers","subscription_url":"https://api.github.com/repos/jenkinsci/docker/subscription","commits_url":"https://api.github.com/repos/jenkinsci/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkinsci/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkinsci/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkinsci/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenkinsci/docker/contents/{+path}","compare_url":"https://api.github.com/repos/jenkinsci/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkinsci/docker/merges","archive_url":"https://api.github.com/repos/jenkinsci/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkinsci/docker/downloads","issues_url":"https://api.github.com/repos/jenkinsci/docker/issues{/number}","pulls_url":"https://api.github.com/repos/jenkinsci/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkinsci/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkinsci/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkinsci/docker/labels{/name}","releases_url":"https://api.github.com/repos/jenkinsci/docker/releases{/id}","deployments_url":"https://api.github.com/repos/jenkinsci/docker/deployments","created_at":"2014-07-18T05:51:05Z","updated_at":"2018-11-15T14:26:08Z","pushed_at":"2018-11-16T11:29:33Z","git_url":"git://github.com/jenkinsci/docker.git","ssh_url":"git@github.com:jenkinsci/docker.git","clone_url":"https://github.com/jenkinsci/docker.git","svn_url":"https://github.com/jenkinsci/docker","homepage":"https://hub.docker.com","size":461,"stargazers_count":2488,"watchers_count":2488,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1805,"mirror_url":null,"archived":false,"open_issues_count":55,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1805,"open_issues":55,"watchers":2488,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/docker/pulls/760"},"html":{"href":"https://github.com/jenkinsci/docker/pull/760"},"issue":{"href":"https://api.github.com/repos/jenkinsci/docker/issues/760"},"comments":{"href":"https://api.github.com/repos/jenkinsci/docker/issues/760/comments"},"review_comments":{"href":"https://api.github.com/repos/jenkinsci/docker/pulls/760/comments"},"review_comment":{"href":"https://api.github.com/repos/jenkinsci/docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jenkinsci/docker/pulls/760/commits"},"statuses":{"href":"https://api.github.com/repos/jenkinsci/docker/statuses/9a1be7e3c6099ea350663dfec30e2c478152c9cd"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"batmat"}}