{"action":"created","comment":{"url":"https://api.github.com/repos/hh-italian-group/HHStatAnalysis/pulls/comments/236537992","pull_request_review_id":178629690,"id":236537992,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjUzNzk5Mg==","diff_hunk":"@@ -107,24 +107,24 @@ void ttbb_base::AddSystematics(ch::CombineHarvester& cb)\n \n     CU::topPt().Apply(cb, bkg_TT);\n \n-    static const size_t DYUncDim = 4;\n+    static const size_t DYUncDim = 6;\n     TMatrixD dy_unc_cov(DYUncDim, DYUncDim);\n-    dy_unc_cov[0][0] = 2.727e-06;\n-    dy_unc_cov[1][1] = 0.0002202;\n-    dy_unc_cov[2][2] = 0.0007727;\n-    dy_unc_cov[3][3] = 0.0004435;\n-    dy_unc_cov[0][1] = dy_unc_cov[1][0] = -6.962e-06;\n-    dy_unc_cov[0][2] = dy_unc_cov[2][0] = 6.771e-06;\n-    dy_unc_cov[0][3] = dy_unc_cov[3][0] = -8.506e-06;\n-    dy_unc_cov[1][2] = dy_unc_cov[2][1] = -0.0001962;\n-    dy_unc_cov[1][3] = dy_unc_cov[3][1] = -3.962e-05;\n-    dy_unc_cov[2][3] = dy_unc_cov[3][2] = -0.0001762;\n+\n+    std::shared_ptr<TFile> file(TFile::Open(\"HHStatAnalysis/Run2_2017/data/DY_Scale_factor_nbjet_njetBins_other_bkg_fixed_27June.root\", \"READ\"));\n+    TH2D* dy_matrix = (TH2D*)file.get()->Get(\"NbjetBins_NjetBins/covariance_matrix\");\n+\n+    for(size_t i = 1; i <= DYUncDim; ++i) {\n+      for(size_t j = i; j <= DYUncDim; ++j) {\n+        dy_unc_cov[i-1][j-1] = dy_unc_cov[j-1][i-1] = dy_matrix->GetBinContent(i,j);\n+      }\n+    }\n \n     TVectorD dy_sf(DYUncDim);\n-    dy_sf[0] = 1.05357;\n-    dy_sf[1] = 1.09229;\n-    dy_sf[2] = 1.06439;\n-    dy_sf[3] = 0.933618;\n+    TH1D* sf_histo = (TH1D*)file.get()->Get(\"NbjetBins_NjetBins/scale_factors\");","path":"Run2_2017/src/ttbb.cc","position":32,"original_position":32,"commit_id":"7e08a90a848faf46e3ed707ce658d3d8da1560a3","original_commit_id":"7e08a90a848faf46e3ed707ce658d3d8da1560a3","user":{"login":"kandrosov","id":6347415,"node_id":"MDQ6VXNlcjYzNDc0MTU=","avatar_url":"https://avatars0.githubusercontent.com/u/6347415?v=4","gravatar_id":"","url":"https://api.github.com/users/kandrosov","html_url":"https://github.com/kandrosov","followers_url":"https://api.github.com/users/kandrosov/followers","following_url":"https://api.github.com/users/kandrosov/following{/other_user}","gists_url":"https://api.github.com/users/kandrosov/gists{/gist_id}","starred_url":"https://api.github.com/users/kandrosov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kandrosov/subscriptions","organizations_url":"https://api.github.com/users/kandrosov/orgs","repos_url":"https://api.github.com/users/kandrosov/repos","events_url":"https://api.github.com/users/kandrosov/events{/privacy}","received_events_url":"https://api.github.com/users/kandrosov/received_events","type":"User","site_admin":false},"body":"`auto sf_histo = root_ext:: ReadObject<TH1D>(*dy_file, \"NbjetBins_NjetBins/scale_factors\");`","created_at":"2018-11-27T06:54:45Z","updated_at":"2018-11-27T06:57:18Z","html_url":"https://github.com/hh-italian-group/HHStatAnalysis/pull/3#discussion_r236537992","pull_request_url":"https://api.github.com/repos/hh-italian-group/HHStatAnalysis/pulls/3","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/hh-italian-group/HHStatAnalysis/pulls/comments/236537992"},"html":{"href":"https://github.com/hh-italian-group/HHStatAnalysis/pull/3#discussion_r236537992"},"pull_request":{"href":"https://api.github.com/repos/hh-italian-group/HHStatAnalysis/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/hh-italian-group/HHStatAnalysis/pulls/3","id":233169088,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzMTY5MDg4","html_url":"https://github.com/hh-italian-group/HHStatAnalysis/pull/3","diff_url":"https://github.com/hh-italian-group/HHStatAnalysis/pull/3.diff","patch_url":"https://github.com/hh-italian-group/HHStatAnalysis/pull/3.patch","issue_url":"https://api.github.com/repos/hh-italian-group/HHStatAnalysis/issues/3","number":3,"state":"open","locked":false,"title":"Updates for 2017 data","user":{"login":"Angelagiraldi","id":25198387,"node_id":"MDQ6VXNlcjI1MTk4Mzg3","avatar_url":"https://avatars1.githubusercontent.com/u/25198387?v=4","gravatar_id":"","url":"https://api.github.com/users/Angelagiraldi","html_url":"https://github.com/Angelagiraldi","followers_url":"https://api.github.com/users/Angelagiraldi/followers","following_url":"https://api.github.com/users/Angelagiraldi/following{/other_user}","gists_url":"https://api.github.com/users/Angelagiraldi/gists{/gist_id}","starred_url":"https://api.github.com/users/Angelagiraldi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Angelagiraldi/subscriptions","organizations_url":"https://api.github.com/users/Angelagiraldi/orgs","repos_url":"https://api.github.com/users/Angelagiraldi/repos","events_url":"https://api.github.com/users/Angelagiraldi/events{/privacy}","received_events_url":"https://api.github.com/users/Angelagiraldi/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-11-23T11:10:51Z","updated_at":"2018-11-27T06:57:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"03d840f228fee6683697b0400ebcf693a365b957","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hh-italian-group/HHStatAnalysis/pulls/3/commits","review_comments_url":"https://api.github.com/repos/hh-italian-group/HHStatAnalysis/pulls/3/comments","review_comment_url":"https://api.github.com/repos/hh-italian-group/HHStatAnalysis/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hh-italian-group/HHStatAnalysis/issues/3/comments","statuses_url":"https://api.github.com/repos/hh-italian-group/HHStatAnalysis/statuses/7e08a90a848faf46e3ed707ce658d3d8da1560a3","head":{"label":"Angelagiraldi:lim_2017","ref":"lim_2017","sha":"7e08a90a848faf46e3ed707ce658d3d8da1560a3","user":{"login":"Angelagiraldi","id":25198387,"node_id":"MDQ6VXNlcjI1MTk4Mzg3","avatar_url":"https://avatars1.githubusercontent.com/u/25198387?v=4","gravatar_id":"","url":"https://api.github.com/users/Angelagiraldi","html_url":"https://github.com/Angelagiraldi","followers_url":"https://api.github.com/users/Angelagiraldi/followers","following_url":"https://api.github.com/users/Angelagiraldi/following{/other_user}","gists_url":"https://api.github.com/users/Angelagiraldi/gists{/gist_id}","starred_url":"https://api.github.com/users/Angelagiraldi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Angelagiraldi/subscriptions","organizations_url":"https://api.github.com/users/Angelagiraldi/orgs","repos_url":"https://api.github.com/users/Angelagiraldi/repos","events_url":"https://api.github.com/users/Angelagiraldi/events{/privacy}","received_events_url":"https://api.github.com/users/Angelagiraldi/received_events","type":"User","site_admin":false},"repo":{"id":151538298,"node_id":"MDEwOlJlcG9zaXRvcnkxNTE1MzgyOTg=","name":"HHStatAnalysis","full_name":"Angelagiraldi/HHStatAnalysis","private":false,"owner":{"login":"Angelagiraldi","id":25198387,"node_id":"MDQ6VXNlcjI1MTk4Mzg3","avatar_url":"https://avatars1.githubusercontent.com/u/25198387?v=4","gravatar_id":"","url":"https://api.github.com/users/Angelagiraldi","html_url":"https://github.com/Angelagiraldi","followers_url":"https://api.github.com/users/Angelagiraldi/followers","following_url":"https://api.github.com/users/Angelagiraldi/following{/other_user}","gists_url":"https://api.github.com/users/Angelagiraldi/gists{/gist_id}","starred_url":"https://api.github.com/users/Angelagiraldi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Angelagiraldi/subscriptions","organizations_url":"https://api.github.com/users/Angelagiraldi/orgs","repos_url":"https://api.github.com/users/Angelagiraldi/repos","events_url":"https://api.github.com/users/Angelagiraldi/events{/privacy}","received_events_url":"https://api.github.com/users/Angelagiraldi/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Angelagiraldi/HHStatAnalysis","description":null,"fork":true,"url":"https://api.github.com/repos/Angelagiraldi/HHStatAnalysis","forks_url":"https://api.github.com/repos/Angelagiraldi/HHStatAnalysis/forks","keys_url":"https://api.github.com/repos/Angelagiraldi/HHStatAnalysis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Angelagiraldi/HHStatAnalysis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Angelagiraldi/HHStatAnalysis/teams","hooks_url":"https://api.github.com/repos/Angelagiraldi/HHStatAnalysis/hooks","issue_events_url":"https://api.github.com/repos/Angelagiraldi/HHStatAnalysis/issues/events{/number}","events_url":"https://api.github.com/repos/Angelagiraldi/HHStatAnalysis/events","assignees_url":"https://api.github.com/repos/Angelagiraldi/HHStatAnalysis/assignees{/user}","branches_url":"https://api.github.com/repos/Angelagiraldi/HHStatAnalysis/branches{/branch}","tags_url":"https://api.github.com/repos/Angelagiraldi/HHStatAnalysis/tags","blobs_url":"https://api.github.com/repos/Angelagiraldi/HHStatAnalysis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Angelagiraldi/HHStatAnalysis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Angelagiraldi/HHStatAnalysis/git/refs{/sha}","trees_url":"https://api.github.com/repos/Angelagiraldi/HHStatAnalysis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Angelagiraldi/HHStatAnalysis/statuses/{sha}","languages_url":"https://api.github.com/repos/Angelagiraldi/HHStatAnalysis/languages","stargazers_url":"https://api.github.com/repos/Angelagiraldi/HHStatAnalysis/stargazers","contributors_url":"https://api.github.com/repos/Angelagiraldi/HHStatAnalysis/contributors","subscribers_url":"https://api.github.com/repos/Angelagiraldi/HHStatAnalysis/subscribers","subscription_url":"https://api.github.com/repos/Angelagiraldi/HHStatAnalysis/subscription","commits_url":"https://api.github.com/repos/Angelagiraldi/HHStatAnalysis/commits{/sha}","git_commits_url":"https://api.github.com/repos/Angelagiraldi/HHStatAnalysis/git/commits{/sha}","comments_url":"https://api.github.com/repos/Angelagiraldi/HHStatAnalysis/comments{/number}","issue_comment_url":"https://api.github.com/repos/Angelagiraldi/HHStatAnalysis/issues/comments{/number}","contents_url":"https://api.github.com/repos/Angelagiraldi/HHStatAnalysis/contents/{+path}","compare_url":"https://api.github.com/repos/Angelagiraldi/HHStatAnalysis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Angelagiraldi/HHStatAnalysis/merges","archive_url":"https://api.github.com/repos/Angelagiraldi/HHStatAnalysis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Angelagiraldi/HHStatAnalysis/downloads","issues_url":"https://api.github.com/repos/Angelagiraldi/HHStatAnalysis/issues{/number}","pulls_url":"https://api.github.com/repos/Angelagiraldi/HHStatAnalysis/pulls{/number}","milestones_url":"https://api.github.com/repos/Angelagiraldi/HHStatAnalysis/milestones{/number}","notifications_url":"https://api.github.com/repos/Angelagiraldi/HHStatAnalysis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Angelagiraldi/HHStatAnalysis/labels{/name}","releases_url":"https://api.github.com/repos/Angelagiraldi/HHStatAnalysis/releases{/id}","deployments_url":"https://api.github.com/repos/Angelagiraldi/HHStatAnalysis/deployments","created_at":"2018-10-04T08:03:52Z","updated_at":"2018-10-04T08:03:54Z","pushed_at":"2018-11-23T10:50:53Z","git_url":"git://github.com/Angelagiraldi/HHStatAnalysis.git","ssh_url":"git@github.com:Angelagiraldi/HHStatAnalysis.git","clone_url":"https://github.com/Angelagiraldi/HHStatAnalysis.git","svn_url":"https://github.com/Angelagiraldi/HHStatAnalysis","homepage":null,"size":277,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hh-italian-group:ttbb-it","ref":"ttbb-it","sha":"7e214559a37dc74f11acf1285c09c43ffb982596","user":{"login":"hh-italian-group","id":9250152,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkyNTAxNTI=","avatar_url":"https://avatars3.githubusercontent.com/u/9250152?v=4","gravatar_id":"","url":"https://api.github.com/users/hh-italian-group","html_url":"https://github.com/hh-italian-group","followers_url":"https://api.github.com/users/hh-italian-group/followers","following_url":"https://api.github.com/users/hh-italian-group/following{/other_user}","gists_url":"https://api.github.com/users/hh-italian-group/gists{/gist_id}","starred_url":"https://api.github.com/users/hh-italian-group/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hh-italian-group/subscriptions","organizations_url":"https://api.github.com/users/hh-italian-group/orgs","repos_url":"https://api.github.com/users/hh-italian-group/repos","events_url":"https://api.github.com/users/hh-italian-group/events{/privacy}","received_events_url":"https://api.github.com/users/hh-italian-group/received_events","type":"Organization","site_admin":false},"repo":{"id":69229797,"node_id":"MDEwOlJlcG9zaXRvcnk2OTIyOTc5Nw==","name":"HHStatAnalysis","full_name":"hh-italian-group/HHStatAnalysis","private":false,"owner":{"login":"hh-italian-group","id":9250152,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkyNTAxNTI=","avatar_url":"https://avatars3.githubusercontent.com/u/9250152?v=4","gravatar_id":"","url":"https://api.github.com/users/hh-italian-group","html_url":"https://github.com/hh-italian-group","followers_url":"https://api.github.com/users/hh-italian-group/followers","following_url":"https://api.github.com/users/hh-italian-group/following{/other_user}","gists_url":"https://api.github.com/users/hh-italian-group/gists{/gist_id}","starred_url":"https://api.github.com/users/hh-italian-group/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hh-italian-group/subscriptions","organizations_url":"https://api.github.com/users/hh-italian-group/orgs","repos_url":"https://api.github.com/users/hh-italian-group/repos","events_url":"https://api.github.com/users/hh-italian-group/events{/privacy}","received_events_url":"https://api.github.com/users/hh-italian-group/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/hh-italian-group/HHStatAnalysis","description":null,"fork":true,"url":"https://api.github.com/repos/hh-italian-group/HHStatAnalysis","forks_url":"https://api.github.com/repos/hh-italian-group/HHStatAnalysis/forks","keys_url":"https://api.github.com/repos/hh-italian-group/HHStatAnalysis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hh-italian-group/HHStatAnalysis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hh-italian-group/HHStatAnalysis/teams","hooks_url":"https://api.github.com/repos/hh-italian-group/HHStatAnalysis/hooks","issue_events_url":"https://api.github.com/repos/hh-italian-group/HHStatAnalysis/issues/events{/number}","events_url":"https://api.github.com/repos/hh-italian-group/HHStatAnalysis/events","assignees_url":"https://api.github.com/repos/hh-italian-group/HHStatAnalysis/assignees{/user}","branches_url":"https://api.github.com/repos/hh-italian-group/HHStatAnalysis/branches{/branch}","tags_url":"https://api.github.com/repos/hh-italian-group/HHStatAnalysis/tags","blobs_url":"https://api.github.com/repos/hh-italian-group/HHStatAnalysis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hh-italian-group/HHStatAnalysis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hh-italian-group/HHStatAnalysis/git/refs{/sha}","trees_url":"https://api.github.com/repos/hh-italian-group/HHStatAnalysis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hh-italian-group/HHStatAnalysis/statuses/{sha}","languages_url":"https://api.github.com/repos/hh-italian-group/HHStatAnalysis/languages","stargazers_url":"https://api.github.com/repos/hh-italian-group/HHStatAnalysis/stargazers","contributors_url":"https://api.github.com/repos/hh-italian-group/HHStatAnalysis/contributors","subscribers_url":"https://api.github.com/repos/hh-italian-group/HHStatAnalysis/subscribers","subscription_url":"https://api.github.com/repos/hh-italian-group/HHStatAnalysis/subscription","commits_url":"https://api.github.com/repos/hh-italian-group/HHStatAnalysis/commits{/sha}","git_commits_url":"https://api.github.com/repos/hh-italian-group/HHStatAnalysis/git/commits{/sha}","comments_url":"https://api.github.com/repos/hh-italian-group/HHStatAnalysis/comments{/number}","issue_comment_url":"https://api.github.com/repos/hh-italian-group/HHStatAnalysis/issues/comments{/number}","contents_url":"https://api.github.com/repos/hh-italian-group/HHStatAnalysis/contents/{+path}","compare_url":"https://api.github.com/repos/hh-italian-group/HHStatAnalysis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hh-italian-group/HHStatAnalysis/merges","archive_url":"https://api.github.com/repos/hh-italian-group/HHStatAnalysis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hh-italian-group/HHStatAnalysis/downloads","issues_url":"https://api.github.com/repos/hh-italian-group/HHStatAnalysis/issues{/number}","pulls_url":"https://api.github.com/repos/hh-italian-group/HHStatAnalysis/pulls{/number}","milestones_url":"https://api.github.com/repos/hh-italian-group/HHStatAnalysis/milestones{/number}","notifications_url":"https://api.github.com/repos/hh-italian-group/HHStatAnalysis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hh-italian-group/HHStatAnalysis/labels{/name}","releases_url":"https://api.github.com/repos/hh-italian-group/HHStatAnalysis/releases{/id}","deployments_url":"https://api.github.com/repos/hh-italian-group/HHStatAnalysis/deployments","created_at":"2016-09-26T08:34:42Z","updated_at":"2016-09-26T08:34:43Z","pushed_at":"2018-11-23T11:10:51Z","git_url":"git://github.com/hh-italian-group/HHStatAnalysis.git","ssh_url":"git@github.com:hh-italian-group/HHStatAnalysis.git","clone_url":"https://github.com/hh-italian-group/HHStatAnalysis.git","svn_url":"https://github.com/hh-italian-group/HHStatAnalysis","homepage":null,"size":210,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":3,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hh-italian-group/HHStatAnalysis/pulls/3"},"html":{"href":"https://github.com/hh-italian-group/HHStatAnalysis/pull/3"},"issue":{"href":"https://api.github.com/repos/hh-italian-group/HHStatAnalysis/issues/3"},"comments":{"href":"https://api.github.com/repos/hh-italian-group/HHStatAnalysis/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/hh-italian-group/HHStatAnalysis/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/hh-italian-group/HHStatAnalysis/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hh-italian-group/HHStatAnalysis/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/hh-italian-group/HHStatAnalysis/statuses/7e08a90a848faf46e3ed707ce658d3d8da1560a3"}},"author_association":"NONE"}}
{"actor":{"display_login":"kandrosov"}}