{"action":"created","comment":{"url":"https://api.github.com/repos/gruut/enterprise-merger/pulls/comments/243485982","pull_request_review_id":187269888,"id":243485982,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MzQ4NTk4Mg==","diff_hunk":"@@ -40,6 +40,8 @@ constexpr size_t MAX_WAIT_TIME = 5;\n \n constexpr int SYNC_CONTROL_INTERVAL = 500;\n \n+constexpr int AVAILABLE_INPUT_SIZE = 20;","path":"src/config/config.hpp","position":4,"original_position":4,"commit_id":"51d2ce805d13343ea384700c92412545518c6881","original_commit_id":"51d2ce805d13343ea384700c92412545518c6881","user":{"login":"park53kr","id":6479241,"node_id":"MDQ6VXNlcjY0NzkyNDE=","avatar_url":"https://avatars3.githubusercontent.com/u/6479241?v=4","gravatar_id":"","url":"https://api.github.com/users/park53kr","html_url":"https://github.com/park53kr","followers_url":"https://api.github.com/users/park53kr/followers","following_url":"https://api.github.com/users/park53kr/following{/other_user}","gists_url":"https://api.github.com/users/park53kr/gists{/gist_id}","starred_url":"https://api.github.com/users/park53kr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/park53kr/subscriptions","organizations_url":"https://api.github.com/users/park53kr/orgs","repos_url":"https://api.github.com/users/park53kr/repos","events_url":"https://api.github.com/users/park53kr/events{/privacy}","received_events_url":"https://api.github.com/users/park53kr/received_events","type":"User","site_admin":false},"body":"global하게 사용되는 config인데 변수명이 모호합니다. 나중에 추가되는 다른 변수명과 충돌가능성이 있습니다.\r\n","created_at":"2018-12-21T04:32:14Z","updated_at":"2018-12-21T04:34:34Z","html_url":"https://github.com/gruut/enterprise-merger/pull/169#discussion_r243485982","pull_request_url":"https://api.github.com/repos/gruut/enterprise-merger/pulls/169","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/gruut/enterprise-merger/pulls/comments/243485982"},"html":{"href":"https://github.com/gruut/enterprise-merger/pull/169#discussion_r243485982"},"pull_request":{"href":"https://api.github.com/repos/gruut/enterprise-merger/pulls/169"}}},"pull_request":{"url":"https://api.github.com/repos/gruut/enterprise-merger/pulls/169","id":240360552,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwMzYwNTUy","html_url":"https://github.com/gruut/enterprise-merger/pull/169","diff_url":"https://github.com/gruut/enterprise-merger/pull/169.diff","patch_url":"https://github.com/gruut/enterprise-merger/pull/169.patch","issue_url":"https://api.github.com/repos/gruut/enterprise-merger/issues/169","number":169,"state":"closed","locked":false,"title":" # REFACTOR - rpc server에서 다수 메시지 발생 시 처리속도 문제 해결","user":{"login":"blackironj","id":43738420,"node_id":"MDQ6VXNlcjQzNzM4NDIw","avatar_url":"https://avatars3.githubusercontent.com/u/43738420?v=4","gravatar_id":"","url":"https://api.github.com/users/blackironj","html_url":"https://github.com/blackironj","followers_url":"https://api.github.com/users/blackironj/followers","following_url":"https://api.github.com/users/blackironj/following{/other_user}","gists_url":"https://api.github.com/users/blackironj/gists{/gist_id}","starred_url":"https://api.github.com/users/blackironj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blackironj/subscriptions","organizations_url":"https://api.github.com/users/blackironj/orgs","repos_url":"https://api.github.com/users/blackironj/repos","events_url":"https://api.github.com/users/blackironj/events{/privacy}","received_events_url":"https://api.github.com/users/blackironj/received_events","type":"User","site_admin":false},"body":" #문제\r\n- rpc server에서 받은 메시지를 MessageHandler에게 넘겨 unpack하는 과정이\r\n순차 처리였음.\r\n\r\n #해결\r\n- 메시지를 받아 unpack하는 과정을 io_service에 post 하는 형태로 바꿈\r\n\r\n #기타\r\n- InputQueueAlt / OutputQueueAlt 클래스에 size() 함수 추가\r\n\r\n- MergerSrever의 recvMessage() 에서 InputQueue의 size가 특정 값보다\r\n커지면 completion_queue(rpc_queue)에서 InputQueue로 보내지 않게 함\r\n\r\n- MergerServer의 recvMessage() 에서 Sleep 이 더이상 필요없다고 생각하여\r\n삭제. 메시지가 없을 때는 Next() 부분에서 더이상 진행이 안되는 것을\r\n확인하였음.\r\n\r\n  * 현재 컴퓨터의 문제로 테스트는 해보지 못한 상태입니다.","created_at":"2018-12-21T03:09:38Z","updated_at":"2018-12-21T04:34:34Z","closed_at":"2018-12-21T04:31:06Z","merged_at":"2018-12-21T04:31:06Z","merge_commit_sha":"b55a8fdb705e9d9efce9d5711ce3aec9fd222699","assignee":{"login":"dreamx-gruut","id":45190245,"node_id":"MDQ6VXNlcjQ1MTkwMjQ1","avatar_url":"https://avatars3.githubusercontent.com/u/45190245?v=4","gravatar_id":"","url":"https://api.github.com/users/dreamx-gruut","html_url":"https://github.com/dreamx-gruut","followers_url":"https://api.github.com/users/dreamx-gruut/followers","following_url":"https://api.github.com/users/dreamx-gruut/following{/other_user}","gists_url":"https://api.github.com/users/dreamx-gruut/gists{/gist_id}","starred_url":"https://api.github.com/users/dreamx-gruut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dreamx-gruut/subscriptions","organizations_url":"https://api.github.com/users/dreamx-gruut/orgs","repos_url":"https://api.github.com/users/dreamx-gruut/repos","events_url":"https://api.github.com/users/dreamx-gruut/events{/privacy}","received_events_url":"https://api.github.com/users/dreamx-gruut/received_events","type":"User","site_admin":false},"assignees":[{"login":"dreamx-gruut","id":45190245,"node_id":"MDQ6VXNlcjQ1MTkwMjQ1","avatar_url":"https://avatars3.githubusercontent.com/u/45190245?v=4","gravatar_id":"","url":"https://api.github.com/users/dreamx-gruut","html_url":"https://github.com/dreamx-gruut","followers_url":"https://api.github.com/users/dreamx-gruut/followers","following_url":"https://api.github.com/users/dreamx-gruut/following{/other_user}","gists_url":"https://api.github.com/users/dreamx-gruut/gists{/gist_id}","starred_url":"https://api.github.com/users/dreamx-gruut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dreamx-gruut/subscriptions","organizations_url":"https://api.github.com/users/dreamx-gruut/orgs","repos_url":"https://api.github.com/users/dreamx-gruut/repos","events_url":"https://api.github.com/users/dreamx-gruut/events{/privacy}","received_events_url":"https://api.github.com/users/dreamx-gruut/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/gruut/enterprise-merger/pulls/169/commits","review_comments_url":"https://api.github.com/repos/gruut/enterprise-merger/pulls/169/comments","review_comment_url":"https://api.github.com/repos/gruut/enterprise-merger/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gruut/enterprise-merger/issues/169/comments","statuses_url":"https://api.github.com/repos/gruut/enterprise-merger/statuses/51d2ce805d13343ea384700c92412545518c6881","head":{"label":"gruut:refactor/grpc-server","ref":"refactor/grpc-server","sha":"51d2ce805d13343ea384700c92412545518c6881","user":{"login":"gruut","id":45159513,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1MTU5NTEz","avatar_url":"https://avatars1.githubusercontent.com/u/45159513?v=4","gravatar_id":"","url":"https://api.github.com/users/gruut","html_url":"https://github.com/gruut","followers_url":"https://api.github.com/users/gruut/followers","following_url":"https://api.github.com/users/gruut/following{/other_user}","gists_url":"https://api.github.com/users/gruut/gists{/gist_id}","starred_url":"https://api.github.com/users/gruut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gruut/subscriptions","organizations_url":"https://api.github.com/users/gruut/orgs","repos_url":"https://api.github.com/users/gruut/repos","events_url":"https://api.github.com/users/gruut/events{/privacy}","received_events_url":"https://api.github.com/users/gruut/received_events","type":"Organization","site_admin":false},"repo":{"id":158180298,"node_id":"MDEwOlJlcG9zaXRvcnkxNTgxODAyOTg=","name":"enterprise-merger","full_name":"gruut/enterprise-merger","private":false,"owner":{"login":"gruut","id":45159513,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1MTU5NTEz","avatar_url":"https://avatars1.githubusercontent.com/u/45159513?v=4","gravatar_id":"","url":"https://api.github.com/users/gruut","html_url":"https://github.com/gruut","followers_url":"https://api.github.com/users/gruut/followers","following_url":"https://api.github.com/users/gruut/following{/other_user}","gists_url":"https://api.github.com/users/gruut/gists{/gist_id}","starred_url":"https://api.github.com/users/gruut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gruut/subscriptions","organizations_url":"https://api.github.com/users/gruut/orgs","repos_url":"https://api.github.com/users/gruut/repos","events_url":"https://api.github.com/users/gruut/events{/privacy}","received_events_url":"https://api.github.com/users/gruut/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/gruut/enterprise-merger","description":"Gruut network","fork":false,"url":"https://api.github.com/repos/gruut/enterprise-merger","forks_url":"https://api.github.com/repos/gruut/enterprise-merger/forks","keys_url":"https://api.github.com/repos/gruut/enterprise-merger/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gruut/enterprise-merger/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gruut/enterprise-merger/teams","hooks_url":"https://api.github.com/repos/gruut/enterprise-merger/hooks","issue_events_url":"https://api.github.com/repos/gruut/enterprise-merger/issues/events{/number}","events_url":"https://api.github.com/repos/gruut/enterprise-merger/events","assignees_url":"https://api.github.com/repos/gruut/enterprise-merger/assignees{/user}","branches_url":"https://api.github.com/repos/gruut/enterprise-merger/branches{/branch}","tags_url":"https://api.github.com/repos/gruut/enterprise-merger/tags","blobs_url":"https://api.github.com/repos/gruut/enterprise-merger/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gruut/enterprise-merger/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gruut/enterprise-merger/git/refs{/sha}","trees_url":"https://api.github.com/repos/gruut/enterprise-merger/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gruut/enterprise-merger/statuses/{sha}","languages_url":"https://api.github.com/repos/gruut/enterprise-merger/languages","stargazers_url":"https://api.github.com/repos/gruut/enterprise-merger/stargazers","contributors_url":"https://api.github.com/repos/gruut/enterprise-merger/contributors","subscribers_url":"https://api.github.com/repos/gruut/enterprise-merger/subscribers","subscription_url":"https://api.github.com/repos/gruut/enterprise-merger/subscription","commits_url":"https://api.github.com/repos/gruut/enterprise-merger/commits{/sha}","git_commits_url":"https://api.github.com/repos/gruut/enterprise-merger/git/commits{/sha}","comments_url":"https://api.github.com/repos/gruut/enterprise-merger/comments{/number}","issue_comment_url":"https://api.github.com/repos/gruut/enterprise-merger/issues/comments{/number}","contents_url":"https://api.github.com/repos/gruut/enterprise-merger/contents/{+path}","compare_url":"https://api.github.com/repos/gruut/enterprise-merger/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gruut/enterprise-merger/merges","archive_url":"https://api.github.com/repos/gruut/enterprise-merger/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gruut/enterprise-merger/downloads","issues_url":"https://api.github.com/repos/gruut/enterprise-merger/issues{/number}","pulls_url":"https://api.github.com/repos/gruut/enterprise-merger/pulls{/number}","milestones_url":"https://api.github.com/repos/gruut/enterprise-merger/milestones{/number}","notifications_url":"https://api.github.com/repos/gruut/enterprise-merger/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gruut/enterprise-merger/labels{/name}","releases_url":"https://api.github.com/repos/gruut/enterprise-merger/releases{/id}","deployments_url":"https://api.github.com/repos/gruut/enterprise-merger/deployments","created_at":"2018-11-19T07:34:56Z","updated_at":"2018-12-21T04:31:08Z","pushed_at":"2018-12-21T04:31:09Z","git_url":"git://github.com/gruut/enterprise-merger.git","ssh_url":"git@github.com:gruut/enterprise-merger.git","clone_url":"https://github.com/gruut/enterprise-merger.git","svn_url":"https://github.com/gruut/enterprise-merger","homepage":"https://gruut.net","size":37169,"stargazers_count":5,"watchers_count":5,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":4,"license":null,"forks":2,"open_issues":4,"watchers":5,"default_branch":"develop"}},"base":{"label":"gruut:develop","ref":"develop","sha":"9e6ef5c9aeb03ea8903491e50aa8e925133697a4","user":{"login":"gruut","id":45159513,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1MTU5NTEz","avatar_url":"https://avatars1.githubusercontent.com/u/45159513?v=4","gravatar_id":"","url":"https://api.github.com/users/gruut","html_url":"https://github.com/gruut","followers_url":"https://api.github.com/users/gruut/followers","following_url":"https://api.github.com/users/gruut/following{/other_user}","gists_url":"https://api.github.com/users/gruut/gists{/gist_id}","starred_url":"https://api.github.com/users/gruut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gruut/subscriptions","organizations_url":"https://api.github.com/users/gruut/orgs","repos_url":"https://api.github.com/users/gruut/repos","events_url":"https://api.github.com/users/gruut/events{/privacy}","received_events_url":"https://api.github.com/users/gruut/received_events","type":"Organization","site_admin":false},"repo":{"id":158180298,"node_id":"MDEwOlJlcG9zaXRvcnkxNTgxODAyOTg=","name":"enterprise-merger","full_name":"gruut/enterprise-merger","private":false,"owner":{"login":"gruut","id":45159513,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1MTU5NTEz","avatar_url":"https://avatars1.githubusercontent.com/u/45159513?v=4","gravatar_id":"","url":"https://api.github.com/users/gruut","html_url":"https://github.com/gruut","followers_url":"https://api.github.com/users/gruut/followers","following_url":"https://api.github.com/users/gruut/following{/other_user}","gists_url":"https://api.github.com/users/gruut/gists{/gist_id}","starred_url":"https://api.github.com/users/gruut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gruut/subscriptions","organizations_url":"https://api.github.com/users/gruut/orgs","repos_url":"https://api.github.com/users/gruut/repos","events_url":"https://api.github.com/users/gruut/events{/privacy}","received_events_url":"https://api.github.com/users/gruut/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/gruut/enterprise-merger","description":"Gruut network","fork":false,"url":"https://api.github.com/repos/gruut/enterprise-merger","forks_url":"https://api.github.com/repos/gruut/enterprise-merger/forks","keys_url":"https://api.github.com/repos/gruut/enterprise-merger/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gruut/enterprise-merger/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gruut/enterprise-merger/teams","hooks_url":"https://api.github.com/repos/gruut/enterprise-merger/hooks","issue_events_url":"https://api.github.com/repos/gruut/enterprise-merger/issues/events{/number}","events_url":"https://api.github.com/repos/gruut/enterprise-merger/events","assignees_url":"https://api.github.com/repos/gruut/enterprise-merger/assignees{/user}","branches_url":"https://api.github.com/repos/gruut/enterprise-merger/branches{/branch}","tags_url":"https://api.github.com/repos/gruut/enterprise-merger/tags","blobs_url":"https://api.github.com/repos/gruut/enterprise-merger/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gruut/enterprise-merger/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gruut/enterprise-merger/git/refs{/sha}","trees_url":"https://api.github.com/repos/gruut/enterprise-merger/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gruut/enterprise-merger/statuses/{sha}","languages_url":"https://api.github.com/repos/gruut/enterprise-merger/languages","stargazers_url":"https://api.github.com/repos/gruut/enterprise-merger/stargazers","contributors_url":"https://api.github.com/repos/gruut/enterprise-merger/contributors","subscribers_url":"https://api.github.com/repos/gruut/enterprise-merger/subscribers","subscription_url":"https://api.github.com/repos/gruut/enterprise-merger/subscription","commits_url":"https://api.github.com/repos/gruut/enterprise-merger/commits{/sha}","git_commits_url":"https://api.github.com/repos/gruut/enterprise-merger/git/commits{/sha}","comments_url":"https://api.github.com/repos/gruut/enterprise-merger/comments{/number}","issue_comment_url":"https://api.github.com/repos/gruut/enterprise-merger/issues/comments{/number}","contents_url":"https://api.github.com/repos/gruut/enterprise-merger/contents/{+path}","compare_url":"https://api.github.com/repos/gruut/enterprise-merger/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gruut/enterprise-merger/merges","archive_url":"https://api.github.com/repos/gruut/enterprise-merger/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gruut/enterprise-merger/downloads","issues_url":"https://api.github.com/repos/gruut/enterprise-merger/issues{/number}","pulls_url":"https://api.github.com/repos/gruut/enterprise-merger/pulls{/number}","milestones_url":"https://api.github.com/repos/gruut/enterprise-merger/milestones{/number}","notifications_url":"https://api.github.com/repos/gruut/enterprise-merger/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gruut/enterprise-merger/labels{/name}","releases_url":"https://api.github.com/repos/gruut/enterprise-merger/releases{/id}","deployments_url":"https://api.github.com/repos/gruut/enterprise-merger/deployments","created_at":"2018-11-19T07:34:56Z","updated_at":"2018-12-21T04:31:08Z","pushed_at":"2018-12-21T04:31:09Z","git_url":"git://github.com/gruut/enterprise-merger.git","ssh_url":"git@github.com:gruut/enterprise-merger.git","clone_url":"https://github.com/gruut/enterprise-merger.git","svn_url":"https://github.com/gruut/enterprise-merger","homepage":"https://gruut.net","size":37169,"stargazers_count":5,"watchers_count":5,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":4,"license":null,"forks":2,"open_issues":4,"watchers":5,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/gruut/enterprise-merger/pulls/169"},"html":{"href":"https://github.com/gruut/enterprise-merger/pull/169"},"issue":{"href":"https://api.github.com/repos/gruut/enterprise-merger/issues/169"},"comments":{"href":"https://api.github.com/repos/gruut/enterprise-merger/issues/169/comments"},"review_comments":{"href":"https://api.github.com/repos/gruut/enterprise-merger/pulls/169/comments"},"review_comment":{"href":"https://api.github.com/repos/gruut/enterprise-merger/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gruut/enterprise-merger/pulls/169/commits"},"statuses":{"href":"https://api.github.com/repos/gruut/enterprise-merger/statuses/51d2ce805d13343ea384700c92412545518c6881"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"park53kr"}}