{"action":"opened","number":896,"pull_request":{"url":"https://api.github.com/repos/geli-lms/geli/pulls/896","id":224547558,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0NTQ3NTU4","html_url":"https://github.com/geli-lms/geli/pull/896","diff_url":"https://github.com/geli-lms/geli/pull/896.diff","patch_url":"https://github.com/geli-lms/geli/pull/896.patch","issue_url":"https://api.github.com/repos/geli-lms/geli/issues/896","number":896,"state":"open","locked":false,"title":"Bugfix/#895 add whitelisted user to courses","user":{"login":"torss","id":37229901,"node_id":"MDQ6VXNlcjM3MjI5OTAx","avatar_url":"https://avatars0.githubusercontent.com/u/37229901?v=4","gravatar_id":"","url":"https://api.github.com/users/torss","html_url":"https://github.com/torss","followers_url":"https://api.github.com/users/torss/followers","following_url":"https://api.github.com/users/torss/following{/other_user}","gists_url":"https://api.github.com/users/torss/gists{/gist_id}","starred_url":"https://api.github.com/users/torss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/torss/subscriptions","organizations_url":"https://api.github.com/users/torss/orgs","repos_url":"https://api.github.com/users/torss/repos","events_url":"https://api.github.com/users/torss/events{/privacy}","received_events_url":"https://api.github.com/users/torss/received_events","type":"User","site_admin":false},"body":"## Description:\r\n\r\nFixes some small issues regarding `addWhitelistedUserToCourses` in `AuthController`.\r\n\r\nCloses #895\r\n\r\n## Improvements:\r\nAll regarding  `addWhitelistedUserToCourses`:\r\n- Fixes 3 `whitelistet` typos (t instead of d at the end).\r\n- Fixes broken `course.students.findIndex` condition (`< 0` was inside of `findIndex` instead of outside, thus always evaluating to `false` inside of `findIndex`, and thus `true` in the outer `if`-condition).\r\n- Very minor self-documenting refactoring of the `if`-condition.\r\n\r\nOther (opportunistic fixes):\r\n- Some recent minor changelog issues.\r\n\r\n## Known Issues:\r\n_NONE_\r\n\r\n<!--\r\nATTENTION:\r\nRemember to prefix your PR-Title with `⚠ WIP: ` if you still work on it.\r\nIf you have reached a final state, remove the prefix.\r\n-->\r\n","created_at":"2018-10-21T15:04:58Z","updated_at":"2018-10-21T15:04:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/geli-lms/geli/pulls/896/commits","review_comments_url":"https://api.github.com/repos/geli-lms/geli/pulls/896/comments","review_comment_url":"https://api.github.com/repos/geli-lms/geli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/geli-lms/geli/issues/896/comments","statuses_url":"https://api.github.com/repos/geli-lms/geli/statuses/f5cbbe576e4e618181f7efea0b349c2a5a25b315","head":{"label":"geli-lms:bugfix/#895-addWhitelistedUserToCourses","ref":"bugfix/#895-addWhitelistedUserToCourses","sha":"f5cbbe576e4e618181f7efea0b349c2a5a25b315","user":{"login":"geli-lms","id":44055556,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ0MDU1NTU2","avatar_url":"https://avatars2.githubusercontent.com/u/44055556?v=4","gravatar_id":"","url":"https://api.github.com/users/geli-lms","html_url":"https://github.com/geli-lms","followers_url":"https://api.github.com/users/geli-lms/followers","following_url":"https://api.github.com/users/geli-lms/following{/other_user}","gists_url":"https://api.github.com/users/geli-lms/gists{/gist_id}","starred_url":"https://api.github.com/users/geli-lms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geli-lms/subscriptions","organizations_url":"https://api.github.com/users/geli-lms/orgs","repos_url":"https://api.github.com/users/geli-lms/repos","events_url":"https://api.github.com/users/geli-lms/events{/privacy}","received_events_url":"https://api.github.com/users/geli-lms/received_events","type":"Organization","site_admin":false},"repo":{"id":84955069,"node_id":"MDEwOlJlcG9zaXRvcnk4NDk1NTA2OQ==","name":"geli","full_name":"geli-lms/geli","private":false,"owner":{"login":"geli-lms","id":44055556,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ0MDU1NTU2","avatar_url":"https://avatars2.githubusercontent.com/u/44055556?v=4","gravatar_id":"","url":"https://api.github.com/users/geli-lms","html_url":"https://github.com/geli-lms","followers_url":"https://api.github.com/users/geli-lms/followers","following_url":"https://api.github.com/users/geli-lms/following{/other_user}","gists_url":"https://api.github.com/users/geli-lms/gists{/gist_id}","starred_url":"https://api.github.com/users/geli-lms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geli-lms/subscriptions","organizations_url":"https://api.github.com/users/geli-lms/orgs","repos_url":"https://api.github.com/users/geli-lms/repos","events_url":"https://api.github.com/users/geli-lms/events{/privacy}","received_events_url":"https://api.github.com/users/geli-lms/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/geli-lms/geli","description":"geli is an open source e-learning platform","fork":false,"url":"https://api.github.com/repos/geli-lms/geli","forks_url":"https://api.github.com/repos/geli-lms/geli/forks","keys_url":"https://api.github.com/repos/geli-lms/geli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/geli-lms/geli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/geli-lms/geli/teams","hooks_url":"https://api.github.com/repos/geli-lms/geli/hooks","issue_events_url":"https://api.github.com/repos/geli-lms/geli/issues/events{/number}","events_url":"https://api.github.com/repos/geli-lms/geli/events","assignees_url":"https://api.github.com/repos/geli-lms/geli/assignees{/user}","branches_url":"https://api.github.com/repos/geli-lms/geli/branches{/branch}","tags_url":"https://api.github.com/repos/geli-lms/geli/tags","blobs_url":"https://api.github.com/repos/geli-lms/geli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/geli-lms/geli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/geli-lms/geli/git/refs{/sha}","trees_url":"https://api.github.com/repos/geli-lms/geli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/geli-lms/geli/statuses/{sha}","languages_url":"https://api.github.com/repos/geli-lms/geli/languages","stargazers_url":"https://api.github.com/repos/geli-lms/geli/stargazers","contributors_url":"https://api.github.com/repos/geli-lms/geli/contributors","subscribers_url":"https://api.github.com/repos/geli-lms/geli/subscribers","subscription_url":"https://api.github.com/repos/geli-lms/geli/subscription","commits_url":"https://api.github.com/repos/geli-lms/geli/commits{/sha}","git_commits_url":"https://api.github.com/repos/geli-lms/geli/git/commits{/sha}","comments_url":"https://api.github.com/repos/geli-lms/geli/comments{/number}","issue_comment_url":"https://api.github.com/repos/geli-lms/geli/issues/comments{/number}","contents_url":"https://api.github.com/repos/geli-lms/geli/contents/{+path}","compare_url":"https://api.github.com/repos/geli-lms/geli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/geli-lms/geli/merges","archive_url":"https://api.github.com/repos/geli-lms/geli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/geli-lms/geli/downloads","issues_url":"https://api.github.com/repos/geli-lms/geli/issues{/number}","pulls_url":"https://api.github.com/repos/geli-lms/geli/pulls{/number}","milestones_url":"https://api.github.com/repos/geli-lms/geli/milestones{/number}","notifications_url":"https://api.github.com/repos/geli-lms/geli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/geli-lms/geli/labels{/name}","releases_url":"https://api.github.com/repos/geli-lms/geli/releases{/id}","deployments_url":"https://api.github.com/repos/geli-lms/geli/deployments","created_at":"2017-03-14T13:56:14Z","updated_at":"2018-10-20T21:39:20Z","pushed_at":"2018-10-21T15:03:48Z","git_url":"git://github.com/geli-lms/geli.git","ssh_url":"git@github.com:geli-lms/geli.git","clone_url":"https://github.com/geli-lms/geli.git","svn_url":"https://github.com/geli-lms/geli","homepage":"","size":49043,"stargazers_count":43,"watchers_count":43,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"archived":false,"open_issues_count":109,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":15,"open_issues":109,"watchers":43,"default_branch":"develop"}},"base":{"label":"geli-lms:develop","ref":"develop","sha":"c414b7e00df30075e819453bcc14f0c7ebf638b3","user":{"login":"geli-lms","id":44055556,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ0MDU1NTU2","avatar_url":"https://avatars2.githubusercontent.com/u/44055556?v=4","gravatar_id":"","url":"https://api.github.com/users/geli-lms","html_url":"https://github.com/geli-lms","followers_url":"https://api.github.com/users/geli-lms/followers","following_url":"https://api.github.com/users/geli-lms/following{/other_user}","gists_url":"https://api.github.com/users/geli-lms/gists{/gist_id}","starred_url":"https://api.github.com/users/geli-lms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geli-lms/subscriptions","organizations_url":"https://api.github.com/users/geli-lms/orgs","repos_url":"https://api.github.com/users/geli-lms/repos","events_url":"https://api.github.com/users/geli-lms/events{/privacy}","received_events_url":"https://api.github.com/users/geli-lms/received_events","type":"Organization","site_admin":false},"repo":{"id":84955069,"node_id":"MDEwOlJlcG9zaXRvcnk4NDk1NTA2OQ==","name":"geli","full_name":"geli-lms/geli","private":false,"owner":{"login":"geli-lms","id":44055556,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ0MDU1NTU2","avatar_url":"https://avatars2.githubusercontent.com/u/44055556?v=4","gravatar_id":"","url":"https://api.github.com/users/geli-lms","html_url":"https://github.com/geli-lms","followers_url":"https://api.github.com/users/geli-lms/followers","following_url":"https://api.github.com/users/geli-lms/following{/other_user}","gists_url":"https://api.github.com/users/geli-lms/gists{/gist_id}","starred_url":"https://api.github.com/users/geli-lms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geli-lms/subscriptions","organizations_url":"https://api.github.com/users/geli-lms/orgs","repos_url":"https://api.github.com/users/geli-lms/repos","events_url":"https://api.github.com/users/geli-lms/events{/privacy}","received_events_url":"https://api.github.com/users/geli-lms/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/geli-lms/geli","description":"geli is an open source e-learning platform","fork":false,"url":"https://api.github.com/repos/geli-lms/geli","forks_url":"https://api.github.com/repos/geli-lms/geli/forks","keys_url":"https://api.github.com/repos/geli-lms/geli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/geli-lms/geli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/geli-lms/geli/teams","hooks_url":"https://api.github.com/repos/geli-lms/geli/hooks","issue_events_url":"https://api.github.com/repos/geli-lms/geli/issues/events{/number}","events_url":"https://api.github.com/repos/geli-lms/geli/events","assignees_url":"https://api.github.com/repos/geli-lms/geli/assignees{/user}","branches_url":"https://api.github.com/repos/geli-lms/geli/branches{/branch}","tags_url":"https://api.github.com/repos/geli-lms/geli/tags","blobs_url":"https://api.github.com/repos/geli-lms/geli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/geli-lms/geli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/geli-lms/geli/git/refs{/sha}","trees_url":"https://api.github.com/repos/geli-lms/geli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/geli-lms/geli/statuses/{sha}","languages_url":"https://api.github.com/repos/geli-lms/geli/languages","stargazers_url":"https://api.github.com/repos/geli-lms/geli/stargazers","contributors_url":"https://api.github.com/repos/geli-lms/geli/contributors","subscribers_url":"https://api.github.com/repos/geli-lms/geli/subscribers","subscription_url":"https://api.github.com/repos/geli-lms/geli/subscription","commits_url":"https://api.github.com/repos/geli-lms/geli/commits{/sha}","git_commits_url":"https://api.github.com/repos/geli-lms/geli/git/commits{/sha}","comments_url":"https://api.github.com/repos/geli-lms/geli/comments{/number}","issue_comment_url":"https://api.github.com/repos/geli-lms/geli/issues/comments{/number}","contents_url":"https://api.github.com/repos/geli-lms/geli/contents/{+path}","compare_url":"https://api.github.com/repos/geli-lms/geli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/geli-lms/geli/merges","archive_url":"https://api.github.com/repos/geli-lms/geli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/geli-lms/geli/downloads","issues_url":"https://api.github.com/repos/geli-lms/geli/issues{/number}","pulls_url":"https://api.github.com/repos/geli-lms/geli/pulls{/number}","milestones_url":"https://api.github.com/repos/geli-lms/geli/milestones{/number}","notifications_url":"https://api.github.com/repos/geli-lms/geli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/geli-lms/geli/labels{/name}","releases_url":"https://api.github.com/repos/geli-lms/geli/releases{/id}","deployments_url":"https://api.github.com/repos/geli-lms/geli/deployments","created_at":"2017-03-14T13:56:14Z","updated_at":"2018-10-20T21:39:20Z","pushed_at":"2018-10-21T15:03:48Z","git_url":"git://github.com/geli-lms/geli.git","ssh_url":"git@github.com:geli-lms/geli.git","clone_url":"https://github.com/geli-lms/geli.git","svn_url":"https://github.com/geli-lms/geli","homepage":"","size":49043,"stargazers_count":43,"watchers_count":43,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"archived":false,"open_issues_count":109,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":15,"open_issues":109,"watchers":43,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/geli-lms/geli/pulls/896"},"html":{"href":"https://github.com/geli-lms/geli/pull/896"},"issue":{"href":"https://api.github.com/repos/geli-lms/geli/issues/896"},"comments":{"href":"https://api.github.com/repos/geli-lms/geli/issues/896/comments"},"review_comments":{"href":"https://api.github.com/repos/geli-lms/geli/pulls/896/comments"},"review_comment":{"href":"https://api.github.com/repos/geli-lms/geli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/geli-lms/geli/pulls/896/commits"},"statuses":{"href":"https://api.github.com/repos/geli-lms/geli/statuses/f5cbbe576e4e618181f7efea0b349c2a5a25b315"}},"author_association":"COLLABORATOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":6,"additions":9,"deletions":9,"changed_files":2}}
{"actor":{"display_login":"torss"}}