{"action":"created","comment":{"url":"https://api.github.com/repos/istanbuljs/istanbuljs/pulls/comments/241137046","pull_request_review_id":184333876,"id":241137046,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTEzNzA0Ng==","diff_hunk":"@@ -36,7 +36,7 @@ describe('map store', function () {\n         },\n         \"end\": {\n           \"line\": 4,\n-          \"column\": 5\n+          \"column\": Infinity","path":"packages/istanbul-lib-source-maps/test/map-store.test.js","position":16,"original_position":16,"commit_id":"fb733a38c3ca6a2eec7dde242b9c74bc628bff4b","original_commit_id":"fb733a38c3ca6a2eec7dde242b9c74bc628bff4b","user":{"login":"bcoe","id":194609,"node_id":"MDQ6VXNlcjE5NDYwOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/194609?v=4","gravatar_id":"","url":"https://api.github.com/users/bcoe","html_url":"https://github.com/bcoe","followers_url":"https://api.github.com/users/bcoe/followers","following_url":"https://api.github.com/users/bcoe/following{/other_user}","gists_url":"https://api.github.com/users/bcoe/gists{/gist_id}","starred_url":"https://api.github.com/users/bcoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcoe/subscriptions","organizations_url":"https://api.github.com/users/bcoe/orgs","repos_url":"https://api.github.com/users/bcoe/repos","events_url":"https://api.github.com/users/bcoe/events{/privacy}","received_events_url":"https://api.github.com/users/bcoe/received_events","type":"User","site_admin":false},"body":"the fact that `Infinity` behaves nicely with the String helpers is good to know. We're talking about making this a breaking change any ways, and I'm feeling more and more confident about swapping out what were already undefined ranges with `Infinity1.","created_at":"2018-12-12T18:41:10Z","updated_at":"2018-12-12T18:44:26Z","html_url":"https://github.com/istanbuljs/istanbuljs/pull/255#discussion_r241137046","pull_request_url":"https://api.github.com/repos/istanbuljs/istanbuljs/pulls/255","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/istanbuljs/istanbuljs/pulls/comments/241137046"},"html":{"href":"https://github.com/istanbuljs/istanbuljs/pull/255#discussion_r241137046"},"pull_request":{"href":"https://api.github.com/repos/istanbuljs/istanbuljs/pulls/255"}},"in_reply_to_id":240887479},"pull_request":{"url":"https://api.github.com/repos/istanbuljs/istanbuljs/pulls/255","id":237917929,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3OTE3OTI5","html_url":"https://github.com/istanbuljs/istanbuljs/pull/255","diff_url":"https://github.com/istanbuljs/istanbuljs/pull/255.diff","patch_url":"https://github.com/istanbuljs/istanbuljs/pull/255.patch","issue_url":"https://api.github.com/repos/istanbuljs/istanbuljs/issues/255","number":255,"state":"open","locked":false,"title":" fix: pull in @loganfsmyth's SourceMap fixes","user":{"login":"bcoe","id":194609,"node_id":"MDQ6VXNlcjE5NDYwOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/194609?v=4","gravatar_id":"","url":"https://api.github.com/users/bcoe","html_url":"https://github.com/bcoe","followers_url":"https://api.github.com/users/bcoe/followers","following_url":"https://api.github.com/users/bcoe/following{/other_user}","gists_url":"https://api.github.com/users/bcoe/gists{/gist_id}","starred_url":"https://api.github.com/users/bcoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcoe/subscriptions","organizations_url":"https://api.github.com/users/bcoe/orgs","repos_url":"https://api.github.com/users/bcoe/repos","events_url":"https://api.github.com/users/bcoe/events{/privacy}","received_events_url":"https://api.github.com/users/bcoe/received_events","type":"User","site_admin":false},"body":"This pulls in @loganfsmyth's modifications to the remapping algorithm for SourceMaps.\r\n\r\nI have a couple questions that I've left inline, please note that the tests that need to be modified reference the following:\r\n\r\n```js\r\n  // Original source\r\n  // export class SimpleClass {\r\n  //     hy() {\r\n  //         console.log(\"Hy\");\r\n  //     }\r\n  // }\r\n  // Transpiled Source\r\n  // \"use strict\";\r\n  // var SimpleClass = (function () {\r\n  //     function SimpleClass() {\r\n  //     }\r\n  //     SimpleClass.prototype.hy = function () {\r\n  //         console.log(\"Hy\");\r\n  //     };\r\n  //     return SimpleClass;\r\n  // }());\r\n  // exports.SimpleClass = SimpleClass;\r\n```\r\n\r\nCC: @loganfsmyth, @SimenB ","created_at":"2018-12-12T05:36:37Z","updated_at":"2018-12-12T18:44:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ea21c18ecbf830294dbc39bfce551ffb1e534840","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/istanbuljs/istanbuljs/pulls/255/commits","review_comments_url":"https://api.github.com/repos/istanbuljs/istanbuljs/pulls/255/comments","review_comment_url":"https://api.github.com/repos/istanbuljs/istanbuljs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/istanbuljs/istanbuljs/issues/255/comments","statuses_url":"https://api.github.com/repos/istanbuljs/istanbuljs/statuses/fb733a38c3ca6a2eec7dde242b9c74bc628bff4b","head":{"label":"istanbuljs:loganfsmyth-fix","ref":"loganfsmyth-fix","sha":"fb733a38c3ca6a2eec7dde242b9c74bc628bff4b","user":{"login":"istanbuljs","id":13523395,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNTIzMzk1","avatar_url":"https://avatars2.githubusercontent.com/u/13523395?v=4","gravatar_id":"","url":"https://api.github.com/users/istanbuljs","html_url":"https://github.com/istanbuljs","followers_url":"https://api.github.com/users/istanbuljs/followers","following_url":"https://api.github.com/users/istanbuljs/following{/other_user}","gists_url":"https://api.github.com/users/istanbuljs/gists{/gist_id}","starred_url":"https://api.github.com/users/istanbuljs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istanbuljs/subscriptions","organizations_url":"https://api.github.com/users/istanbuljs/orgs","repos_url":"https://api.github.com/users/istanbuljs/repos","events_url":"https://api.github.com/users/istanbuljs/events{/privacy}","received_events_url":"https://api.github.com/users/istanbuljs/received_events","type":"Organization","site_admin":false},"repo":{"id":81482340,"node_id":"MDEwOlJlcG9zaXRvcnk4MTQ4MjM0MA==","name":"istanbuljs","full_name":"istanbuljs/istanbuljs","private":false,"owner":{"login":"istanbuljs","id":13523395,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNTIzMzk1","avatar_url":"https://avatars2.githubusercontent.com/u/13523395?v=4","gravatar_id":"","url":"https://api.github.com/users/istanbuljs","html_url":"https://github.com/istanbuljs","followers_url":"https://api.github.com/users/istanbuljs/followers","following_url":"https://api.github.com/users/istanbuljs/following{/other_user}","gists_url":"https://api.github.com/users/istanbuljs/gists{/gist_id}","starred_url":"https://api.github.com/users/istanbuljs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istanbuljs/subscriptions","organizations_url":"https://api.github.com/users/istanbuljs/orgs","repos_url":"https://api.github.com/users/istanbuljs/repos","events_url":"https://api.github.com/users/istanbuljs/events{/privacy}","received_events_url":"https://api.github.com/users/istanbuljs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/istanbuljs/istanbuljs","description":"monorepo containing the various nuts and bolts that facilitate istanbul.js test instrumentation","fork":false,"url":"https://api.github.com/repos/istanbuljs/istanbuljs","forks_url":"https://api.github.com/repos/istanbuljs/istanbuljs/forks","keys_url":"https://api.github.com/repos/istanbuljs/istanbuljs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/istanbuljs/istanbuljs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/istanbuljs/istanbuljs/teams","hooks_url":"https://api.github.com/repos/istanbuljs/istanbuljs/hooks","issue_events_url":"https://api.github.com/repos/istanbuljs/istanbuljs/issues/events{/number}","events_url":"https://api.github.com/repos/istanbuljs/istanbuljs/events","assignees_url":"https://api.github.com/repos/istanbuljs/istanbuljs/assignees{/user}","branches_url":"https://api.github.com/repos/istanbuljs/istanbuljs/branches{/branch}","tags_url":"https://api.github.com/repos/istanbuljs/istanbuljs/tags","blobs_url":"https://api.github.com/repos/istanbuljs/istanbuljs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/istanbuljs/istanbuljs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/istanbuljs/istanbuljs/git/refs{/sha}","trees_url":"https://api.github.com/repos/istanbuljs/istanbuljs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/istanbuljs/istanbuljs/statuses/{sha}","languages_url":"https://api.github.com/repos/istanbuljs/istanbuljs/languages","stargazers_url":"https://api.github.com/repos/istanbuljs/istanbuljs/stargazers","contributors_url":"https://api.github.com/repos/istanbuljs/istanbuljs/contributors","subscribers_url":"https://api.github.com/repos/istanbuljs/istanbuljs/subscribers","subscription_url":"https://api.github.com/repos/istanbuljs/istanbuljs/subscription","commits_url":"https://api.github.com/repos/istanbuljs/istanbuljs/commits{/sha}","git_commits_url":"https://api.github.com/repos/istanbuljs/istanbuljs/git/commits{/sha}","comments_url":"https://api.github.com/repos/istanbuljs/istanbuljs/comments{/number}","issue_comment_url":"https://api.github.com/repos/istanbuljs/istanbuljs/issues/comments{/number}","contents_url":"https://api.github.com/repos/istanbuljs/istanbuljs/contents/{+path}","compare_url":"https://api.github.com/repos/istanbuljs/istanbuljs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/istanbuljs/istanbuljs/merges","archive_url":"https://api.github.com/repos/istanbuljs/istanbuljs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/istanbuljs/istanbuljs/downloads","issues_url":"https://api.github.com/repos/istanbuljs/istanbuljs/issues{/number}","pulls_url":"https://api.github.com/repos/istanbuljs/istanbuljs/pulls{/number}","milestones_url":"https://api.github.com/repos/istanbuljs/istanbuljs/milestones{/number}","notifications_url":"https://api.github.com/repos/istanbuljs/istanbuljs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/istanbuljs/istanbuljs/labels{/name}","releases_url":"https://api.github.com/repos/istanbuljs/istanbuljs/releases{/id}","deployments_url":"https://api.github.com/repos/istanbuljs/istanbuljs/deployments","created_at":"2017-02-09T18:39:33Z","updated_at":"2018-12-12T17:53:33Z","pushed_at":"2018-12-12T05:36:37Z","git_url":"git://github.com/istanbuljs/istanbuljs.git","ssh_url":"git@github.com:istanbuljs/istanbuljs.git","clone_url":"https://github.com/istanbuljs/istanbuljs.git","svn_url":"https://github.com/istanbuljs/istanbuljs","homepage":"https://istanbul.js.org/","size":1187,"stargazers_count":246,"watchers_count":246,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":92,"mirror_url":null,"archived":false,"open_issues_count":66,"license":null,"forks":92,"open_issues":66,"watchers":246,"default_branch":"master"}},"base":{"label":"istanbuljs:master","ref":"master","sha":"2857f990a85c9f276ec96f0e6969a33577be4ea7","user":{"login":"istanbuljs","id":13523395,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNTIzMzk1","avatar_url":"https://avatars2.githubusercontent.com/u/13523395?v=4","gravatar_id":"","url":"https://api.github.com/users/istanbuljs","html_url":"https://github.com/istanbuljs","followers_url":"https://api.github.com/users/istanbuljs/followers","following_url":"https://api.github.com/users/istanbuljs/following{/other_user}","gists_url":"https://api.github.com/users/istanbuljs/gists{/gist_id}","starred_url":"https://api.github.com/users/istanbuljs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istanbuljs/subscriptions","organizations_url":"https://api.github.com/users/istanbuljs/orgs","repos_url":"https://api.github.com/users/istanbuljs/repos","events_url":"https://api.github.com/users/istanbuljs/events{/privacy}","received_events_url":"https://api.github.com/users/istanbuljs/received_events","type":"Organization","site_admin":false},"repo":{"id":81482340,"node_id":"MDEwOlJlcG9zaXRvcnk4MTQ4MjM0MA==","name":"istanbuljs","full_name":"istanbuljs/istanbuljs","private":false,"owner":{"login":"istanbuljs","id":13523395,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNTIzMzk1","avatar_url":"https://avatars2.githubusercontent.com/u/13523395?v=4","gravatar_id":"","url":"https://api.github.com/users/istanbuljs","html_url":"https://github.com/istanbuljs","followers_url":"https://api.github.com/users/istanbuljs/followers","following_url":"https://api.github.com/users/istanbuljs/following{/other_user}","gists_url":"https://api.github.com/users/istanbuljs/gists{/gist_id}","starred_url":"https://api.github.com/users/istanbuljs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istanbuljs/subscriptions","organizations_url":"https://api.github.com/users/istanbuljs/orgs","repos_url":"https://api.github.com/users/istanbuljs/repos","events_url":"https://api.github.com/users/istanbuljs/events{/privacy}","received_events_url":"https://api.github.com/users/istanbuljs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/istanbuljs/istanbuljs","description":"monorepo containing the various nuts and bolts that facilitate istanbul.js test instrumentation","fork":false,"url":"https://api.github.com/repos/istanbuljs/istanbuljs","forks_url":"https://api.github.com/repos/istanbuljs/istanbuljs/forks","keys_url":"https://api.github.com/repos/istanbuljs/istanbuljs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/istanbuljs/istanbuljs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/istanbuljs/istanbuljs/teams","hooks_url":"https://api.github.com/repos/istanbuljs/istanbuljs/hooks","issue_events_url":"https://api.github.com/repos/istanbuljs/istanbuljs/issues/events{/number}","events_url":"https://api.github.com/repos/istanbuljs/istanbuljs/events","assignees_url":"https://api.github.com/repos/istanbuljs/istanbuljs/assignees{/user}","branches_url":"https://api.github.com/repos/istanbuljs/istanbuljs/branches{/branch}","tags_url":"https://api.github.com/repos/istanbuljs/istanbuljs/tags","blobs_url":"https://api.github.com/repos/istanbuljs/istanbuljs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/istanbuljs/istanbuljs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/istanbuljs/istanbuljs/git/refs{/sha}","trees_url":"https://api.github.com/repos/istanbuljs/istanbuljs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/istanbuljs/istanbuljs/statuses/{sha}","languages_url":"https://api.github.com/repos/istanbuljs/istanbuljs/languages","stargazers_url":"https://api.github.com/repos/istanbuljs/istanbuljs/stargazers","contributors_url":"https://api.github.com/repos/istanbuljs/istanbuljs/contributors","subscribers_url":"https://api.github.com/repos/istanbuljs/istanbuljs/subscribers","subscription_url":"https://api.github.com/repos/istanbuljs/istanbuljs/subscription","commits_url":"https://api.github.com/repos/istanbuljs/istanbuljs/commits{/sha}","git_commits_url":"https://api.github.com/repos/istanbuljs/istanbuljs/git/commits{/sha}","comments_url":"https://api.github.com/repos/istanbuljs/istanbuljs/comments{/number}","issue_comment_url":"https://api.github.com/repos/istanbuljs/istanbuljs/issues/comments{/number}","contents_url":"https://api.github.com/repos/istanbuljs/istanbuljs/contents/{+path}","compare_url":"https://api.github.com/repos/istanbuljs/istanbuljs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/istanbuljs/istanbuljs/merges","archive_url":"https://api.github.com/repos/istanbuljs/istanbuljs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/istanbuljs/istanbuljs/downloads","issues_url":"https://api.github.com/repos/istanbuljs/istanbuljs/issues{/number}","pulls_url":"https://api.github.com/repos/istanbuljs/istanbuljs/pulls{/number}","milestones_url":"https://api.github.com/repos/istanbuljs/istanbuljs/milestones{/number}","notifications_url":"https://api.github.com/repos/istanbuljs/istanbuljs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/istanbuljs/istanbuljs/labels{/name}","releases_url":"https://api.github.com/repos/istanbuljs/istanbuljs/releases{/id}","deployments_url":"https://api.github.com/repos/istanbuljs/istanbuljs/deployments","created_at":"2017-02-09T18:39:33Z","updated_at":"2018-12-12T17:53:33Z","pushed_at":"2018-12-12T05:36:37Z","git_url":"git://github.com/istanbuljs/istanbuljs.git","ssh_url":"git@github.com:istanbuljs/istanbuljs.git","clone_url":"https://github.com/istanbuljs/istanbuljs.git","svn_url":"https://github.com/istanbuljs/istanbuljs","homepage":"https://istanbul.js.org/","size":1187,"stargazers_count":246,"watchers_count":246,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":92,"mirror_url":null,"archived":false,"open_issues_count":66,"license":null,"forks":92,"open_issues":66,"watchers":246,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/istanbuljs/istanbuljs/pulls/255"},"html":{"href":"https://github.com/istanbuljs/istanbuljs/pull/255"},"issue":{"href":"https://api.github.com/repos/istanbuljs/istanbuljs/issues/255"},"comments":{"href":"https://api.github.com/repos/istanbuljs/istanbuljs/issues/255/comments"},"review_comments":{"href":"https://api.github.com/repos/istanbuljs/istanbuljs/pulls/255/comments"},"review_comment":{"href":"https://api.github.com/repos/istanbuljs/istanbuljs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/istanbuljs/istanbuljs/pulls/255/commits"},"statuses":{"href":"https://api.github.com/repos/istanbuljs/istanbuljs/statuses/fb733a38c3ca6a2eec7dde242b9c74bc628bff4b"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"bcoe"}}