{"action":"created","issue":{"url":"https://api.github.com/repos/OriginProtocol/origin-js/issues/208","repository_url":"https://api.github.com/repos/OriginProtocol/origin-js","labels_url":"https://api.github.com/repos/OriginProtocol/origin-js/issues/208/labels{/name}","comments_url":"https://api.github.com/repos/OriginProtocol/origin-js/issues/208/comments","events_url":"https://api.github.com/repos/OriginProtocol/origin-js/issues/208/events","html_url":"https://github.com/OriginProtocol/origin-js/issues/208","id":325751302,"number":208,"title":"copy zeppellin contracts over to contracts/ instead of importing node_modules/openzeppelin-solidity","user":{"login":"gaboesquivel","id":391270,"avatar_url":"https://avatars0.githubusercontent.com/u/391270?v=4","gravatar_id":"","url":"https://api.github.com/users/gaboesquivel","html_url":"https://github.com/gaboesquivel","followers_url":"https://api.github.com/users/gaboesquivel/followers","following_url":"https://api.github.com/users/gaboesquivel/following{/other_user}","gists_url":"https://api.github.com/users/gaboesquivel/gists{/gist_id}","starred_url":"https://api.github.com/users/gaboesquivel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaboesquivel/subscriptions","organizations_url":"https://api.github.com/users/gaboesquivel/orgs","repos_url":"https://api.github.com/users/gaboesquivel/repos","events_url":"https://api.github.com/users/gaboesquivel/events{/privacy}","received_events_url":"https://api.github.com/users/gaboesquivel/received_events","type":"User","site_admin":false},"labels":[{"id":901920961,"url":"https://api.github.com/repos/OriginProtocol/origin-js/labels/discussion","name":"discussion","color":"740de2","default":false},{"id":844743497,"url":"https://api.github.com/repos/OriginProtocol/origin-js/labels/smart%20contracts","name":"smart contracts","color":"6ebbc9","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-05-23T15:09:55Z","updated_at":"2018-05-28T16:13:11Z","closed_at":null,"author_association":"NONE","body":"I recommend stop using node_modules/openzeppelin-solidity and instead copy the necessary contract files over to contracts/openzeppelin for 2 reasons.\r\n\r\n- More control of the code the actually being imported, although in theory semver should guarantee we always the same version\r\n- Testing Coverage. In order to get the testing coverage report properly reporting the correct amount solidity code that is being tested I had to make this change in the past.  This is related to #197 "},"comment":{"url":"https://api.github.com/repos/OriginProtocol/origin-js/issues/comments/392563643","html_url":"https://github.com/OriginProtocol/origin-js/issues/208#issuecomment-392563643","issue_url":"https://api.github.com/repos/OriginProtocol/origin-js/issues/208","id":392563643,"user":{"login":"gaboesquivel","id":391270,"avatar_url":"https://avatars0.githubusercontent.com/u/391270?v=4","gravatar_id":"","url":"https://api.github.com/users/gaboesquivel","html_url":"https://github.com/gaboesquivel","followers_url":"https://api.github.com/users/gaboesquivel/followers","following_url":"https://api.github.com/users/gaboesquivel/following{/other_user}","gists_url":"https://api.github.com/users/gaboesquivel/gists{/gist_id}","starred_url":"https://api.github.com/users/gaboesquivel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaboesquivel/subscriptions","organizations_url":"https://api.github.com/users/gaboesquivel/orgs","repos_url":"https://api.github.com/users/gaboesquivel/repos","events_url":"https://api.github.com/users/gaboesquivel/events{/privacy}","received_events_url":"https://api.github.com/users/gaboesquivel/received_events","type":"User","site_admin":false},"created_at":"2018-05-28T16:13:11Z","updated_at":"2018-05-28T16:13:11Z","author_association":"NONE","body":"I actually agree with you. This was probably more a comment to #197, since it was mainly because of the code coverage reporter not playing well with imported open zeppelin contracts. We had to copy paste the zeppelin contracts along with the tests for those contract in order to reach full coverage in the report.  "}}
{"actor":{"display_login":"gaboesquivel"}}