{"action":"opened","number":6705,"pull_request":{"url":"https://api.github.com/repos/dotnet/corert/pulls/6705","id":240297498,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwMjk3NDk4","html_url":"https://github.com/dotnet/corert/pull/6705","diff_url":"https://github.com/dotnet/corert/pull/6705.diff","patch_url":"https://github.com/dotnet/corert/pull/6705.patch","issue_url":"https://api.github.com/repos/dotnet/corert/issues/6705","number":6705,"state":"open","locked":false,"title":"Trivial bug fix - use EmitByte for fixup type in signatures","user":{"login":"trylek","id":15313784,"node_id":"MDQ6VXNlcjE1MzEzNzg0","avatar_url":"https://avatars1.githubusercontent.com/u/15313784?v=4","gravatar_id":"","url":"https://api.github.com/users/trylek","html_url":"https://github.com/trylek","followers_url":"https://api.github.com/users/trylek/followers","following_url":"https://api.github.com/users/trylek/following{/other_user}","gists_url":"https://api.github.com/users/trylek/gists{/gist_id}","starred_url":"https://api.github.com/users/trylek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trylek/subscriptions","organizations_url":"https://api.github.com/users/trylek/orgs","repos_url":"https://api.github.com/users/trylek/repos","events_url":"https://api.github.com/users/trylek/events{/privacy}","received_events_url":"https://api.github.com/users/trylek/received_events","type":"User","site_admin":false},"body":"During code review of Andon's change to add initial support for\r\nmodule overrides to R2RDump signature parser I noticed that\r\nI had previously incorrectly used ReadUInt instead of ReadByte\r\nfor reading the fixup type from the signature.\r\n\r\nBased on this observation I audited all places in the CPAOT\r\ncompiler that emit signatures to double-check whether I might\r\nhave made the same mistake there. Indeed I found the same bug\r\nin two cases - in MethodFixupSignature and in encoding of\r\nREADYTORUN_FIXUP_Helper. Interestingly enough the same harmless\r\nbug is in CoreCLR, please see\r\n\r\nhttps://github.com/dotnet/coreclr/blob/04c4df8c9ecf53499838945197af70f11ddf840a/src/zap/zapimport.cpp#L2292\r\n\r\nThe AppendData performs the signature uint encoding which is\r\nharmless in this case because all READYTORUN_FIXUP_* have codes\r\nless than 128 however semantically it's still a bug, AppendByte\r\nshould be used instead as is clearly visible from the only place\r\nwhere the fixup is consumed,\r\n\r\nhttps://github.com/dotnet/coreclr/blob/04c4df8c9ecf53499838945197af70f11ddf840a/src/vm/jitinterface.cpp#L13715\r\n\r\nThanks\r\n\r\nTomas","created_at":"2018-12-20T20:49:17Z","updated_at":"2018-12-20T20:49:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corert/pulls/6705/commits","review_comments_url":"https://api.github.com/repos/dotnet/corert/pulls/6705/comments","review_comment_url":"https://api.github.com/repos/dotnet/corert/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corert/issues/6705/comments","statuses_url":"https://api.github.com/repos/dotnet/corert/statuses/cc7ad34faac0c0e15ef8f03762852ff408991298","head":{"label":"trylek:MethodFixupType","ref":"MethodFixupType","sha":"cc7ad34faac0c0e15ef8f03762852ff408991298","user":{"login":"trylek","id":15313784,"node_id":"MDQ6VXNlcjE1MzEzNzg0","avatar_url":"https://avatars1.githubusercontent.com/u/15313784?v=4","gravatar_id":"","url":"https://api.github.com/users/trylek","html_url":"https://github.com/trylek","followers_url":"https://api.github.com/users/trylek/followers","following_url":"https://api.github.com/users/trylek/following{/other_user}","gists_url":"https://api.github.com/users/trylek/gists{/gist_id}","starred_url":"https://api.github.com/users/trylek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trylek/subscriptions","organizations_url":"https://api.github.com/users/trylek/orgs","repos_url":"https://api.github.com/users/trylek/repos","events_url":"https://api.github.com/users/trylek/events{/privacy}","received_events_url":"https://api.github.com/users/trylek/received_events","type":"User","site_admin":false},"repo":{"id":87426770,"node_id":"MDEwOlJlcG9zaXRvcnk4NzQyNjc3MA==","name":"corert","full_name":"trylek/corert","private":false,"owner":{"login":"trylek","id":15313784,"node_id":"MDQ6VXNlcjE1MzEzNzg0","avatar_url":"https://avatars1.githubusercontent.com/u/15313784?v=4","gravatar_id":"","url":"https://api.github.com/users/trylek","html_url":"https://github.com/trylek","followers_url":"https://api.github.com/users/trylek/followers","following_url":"https://api.github.com/users/trylek/following{/other_user}","gists_url":"https://api.github.com/users/trylek/gists{/gist_id}","starred_url":"https://api.github.com/users/trylek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trylek/subscriptions","organizations_url":"https://api.github.com/users/trylek/orgs","repos_url":"https://api.github.com/users/trylek/repos","events_url":"https://api.github.com/users/trylek/events{/privacy}","received_events_url":"https://api.github.com/users/trylek/received_events","type":"User","site_admin":false},"html_url":"https://github.com/trylek/corert","description":"This repo contains CoreRT, a .NET Core runtime optimized for AOT (ahead of time compilation) scenarios, with the accompanying .NET Native compiler toolchain.","fork":true,"url":"https://api.github.com/repos/trylek/corert","forks_url":"https://api.github.com/repos/trylek/corert/forks","keys_url":"https://api.github.com/repos/trylek/corert/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trylek/corert/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trylek/corert/teams","hooks_url":"https://api.github.com/repos/trylek/corert/hooks","issue_events_url":"https://api.github.com/repos/trylek/corert/issues/events{/number}","events_url":"https://api.github.com/repos/trylek/corert/events","assignees_url":"https://api.github.com/repos/trylek/corert/assignees{/user}","branches_url":"https://api.github.com/repos/trylek/corert/branches{/branch}","tags_url":"https://api.github.com/repos/trylek/corert/tags","blobs_url":"https://api.github.com/repos/trylek/corert/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trylek/corert/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trylek/corert/git/refs{/sha}","trees_url":"https://api.github.com/repos/trylek/corert/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trylek/corert/statuses/{sha}","languages_url":"https://api.github.com/repos/trylek/corert/languages","stargazers_url":"https://api.github.com/repos/trylek/corert/stargazers","contributors_url":"https://api.github.com/repos/trylek/corert/contributors","subscribers_url":"https://api.github.com/repos/trylek/corert/subscribers","subscription_url":"https://api.github.com/repos/trylek/corert/subscription","commits_url":"https://api.github.com/repos/trylek/corert/commits{/sha}","git_commits_url":"https://api.github.com/repos/trylek/corert/git/commits{/sha}","comments_url":"https://api.github.com/repos/trylek/corert/comments{/number}","issue_comment_url":"https://api.github.com/repos/trylek/corert/issues/comments{/number}","contents_url":"https://api.github.com/repos/trylek/corert/contents/{+path}","compare_url":"https://api.github.com/repos/trylek/corert/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trylek/corert/merges","archive_url":"https://api.github.com/repos/trylek/corert/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trylek/corert/downloads","issues_url":"https://api.github.com/repos/trylek/corert/issues{/number}","pulls_url":"https://api.github.com/repos/trylek/corert/pulls{/number}","milestones_url":"https://api.github.com/repos/trylek/corert/milestones{/number}","notifications_url":"https://api.github.com/repos/trylek/corert/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trylek/corert/labels{/name}","releases_url":"https://api.github.com/repos/trylek/corert/releases{/id}","deployments_url":"https://api.github.com/repos/trylek/corert/deployments","created_at":"2017-04-06T12:27:11Z","updated_at":"2018-10-15T00:27:10Z","pushed_at":"2018-12-20T20:48:44Z","git_url":"git://github.com/trylek/corert.git","ssh_url":"git@github.com:trylek/corert.git","clone_url":"https://github.com/trylek/corert.git","svn_url":"https://github.com/trylek/corert","homepage":"http://dot.net","size":32485,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"a7de1267885d5531748fc1c214aed1badd9d52e4","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":42552143,"node_id":"MDEwOlJlcG9zaXRvcnk0MjU1MjE0Mw==","name":"corert","full_name":"dotnet/corert","private":false,"owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dotnet/corert","description":"This repo contains CoreRT, a .NET Core runtime optimized for AOT (ahead of time compilation) scenarios, with the accompanying compiler toolchain.","fork":false,"url":"https://api.github.com/repos/dotnet/corert","forks_url":"https://api.github.com/repos/dotnet/corert/forks","keys_url":"https://api.github.com/repos/dotnet/corert/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corert/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corert/teams","hooks_url":"https://api.github.com/repos/dotnet/corert/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corert/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corert/events","assignees_url":"https://api.github.com/repos/dotnet/corert/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corert/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corert/tags","blobs_url":"https://api.github.com/repos/dotnet/corert/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corert/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corert/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corert/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corert/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corert/languages","stargazers_url":"https://api.github.com/repos/dotnet/corert/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corert/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corert/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corert/subscription","commits_url":"https://api.github.com/repos/dotnet/corert/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corert/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corert/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corert/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corert/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corert/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corert/merges","archive_url":"https://api.github.com/repos/dotnet/corert/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corert/downloads","issues_url":"https://api.github.com/repos/dotnet/corert/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corert/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corert/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corert/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corert/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corert/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corert/deployments","created_at":"2015-09-15T23:10:53Z","updated_at":"2018-12-20T18:51:08Z","pushed_at":"2018-12-20T18:51:04Z","git_url":"git://github.com/dotnet/corert.git","ssh_url":"git@github.com:dotnet/corert.git","clone_url":"https://github.com/dotnet/corert.git","svn_url":"https://github.com/dotnet/corert","homepage":"http://dot.net","size":32438,"stargazers_count":1716,"watchers_count":1716,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":358,"mirror_url":null,"archived":false,"open_issues_count":286,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":358,"open_issues":286,"watchers":1716,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corert/pulls/6705"},"html":{"href":"https://github.com/dotnet/corert/pull/6705"},"issue":{"href":"https://api.github.com/repos/dotnet/corert/issues/6705"},"comments":{"href":"https://api.github.com/repos/dotnet/corert/issues/6705/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corert/pulls/6705/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corert/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corert/pulls/6705/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corert/statuses/cc7ad34faac0c0e15ef8f03762852ff408991298"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":2,"deletions":2,"changed_files":2}}
{"actor":{"display_login":"trylek"}}