{"action":"created","comment":{"url":"https://api.github.com/repos/istio/istio.github.io/pulls/comments/206702070","pull_request_review_id":142167108,"id":206702070,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNjcwMjA3MA==","diff_hunk":"@@ -137,6 +137,29 @@ public Response bookReviewsById(@PathParam(\"productId\") int productId,\n \n When you make downstream calls in your applications, make sure to include these headers.\n \n+## Trace Sampling\n+\n+Istio is configured by default to capture all traces. For every time\n+you access `/productpage` you should see a corresponding trace in the\n+Jaeger dashboard. This is suitable for a test or low traffic mesh. For\n+a high traffic mesh you may wish to lower the trace sampling\n+percentage. This can be set in two ways:\n+\n+* On mesh setup, you may use the Helm option `pilot.traceSampling` to\n+  set the percentage of trace sampling you want. See the","path":"content/docs/tasks/telemetry/distributed-tracing/index.md","position":13,"original_position":13,"commit_id":"e64868c1fd9198847608fec26d0a0262bdaf3ec5","original_commit_id":"e64868c1fd9198847608fec26d0a0262bdaf3ec5","user":{"login":"rcaballeromx","id":10066027,"node_id":"MDQ6VXNlcjEwMDY2MDI3","avatar_url":"https://avatars1.githubusercontent.com/u/10066027?v=4","gravatar_id":"","url":"https://api.github.com/users/rcaballeromx","html_url":"https://github.com/rcaballeromx","followers_url":"https://api.github.com/users/rcaballeromx/followers","following_url":"https://api.github.com/users/rcaballeromx/following{/other_user}","gists_url":"https://api.github.com/users/rcaballeromx/gists{/gist_id}","starred_url":"https://api.github.com/users/rcaballeromx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rcaballeromx/subscriptions","organizations_url":"https://api.github.com/users/rcaballeromx/orgs","repos_url":"https://api.github.com/users/rcaballeromx/repos","events_url":"https://api.github.com/users/rcaballeromx/events{/privacy}","received_events_url":"https://api.github.com/users/rcaballeromx/received_events","type":"User","site_admin":false},"body":"* During the mesh setup, use the `pilot.traceSampling` Helm option to\r\n  set the percentage of trace sampling.","created_at":"2018-07-31T22:21:14Z","updated_at":"2018-07-31T22:26:21Z","html_url":"https://github.com/istio/istio.github.io/pull/2097#discussion_r206702070","pull_request_url":"https://api.github.com/repos/istio/istio.github.io/pulls/2097","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/istio/istio.github.io/pulls/comments/206702070"},"html":{"href":"https://github.com/istio/istio.github.io/pull/2097#discussion_r206702070"},"pull_request":{"href":"https://api.github.com/repos/istio/istio.github.io/pulls/2097"}}},"pull_request":{"url":"https://api.github.com/repos/istio/istio.github.io/pulls/2097","id":205222012,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1MjIyMDEy","html_url":"https://github.com/istio/istio.github.io/pull/2097","diff_url":"https://github.com/istio/istio.github.io/pull/2097.diff","patch_url":"https://github.com/istio/istio.github.io/pull/2097.patch","issue_url":"https://api.github.com/repos/istio/istio.github.io/issues/2097","number":2097,"state":"open","locked":false,"title":"Add section to tracing task to cover sampling.","user":{"login":"jeffmendoza","id":771387,"node_id":"MDQ6VXNlcjc3MTM4Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/771387?v=4","gravatar_id":"","url":"https://api.github.com/users/jeffmendoza","html_url":"https://github.com/jeffmendoza","followers_url":"https://api.github.com/users/jeffmendoza/followers","following_url":"https://api.github.com/users/jeffmendoza/following{/other_user}","gists_url":"https://api.github.com/users/jeffmendoza/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffmendoza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffmendoza/subscriptions","organizations_url":"https://api.github.com/users/jeffmendoza/orgs","repos_url":"https://api.github.com/users/jeffmendoza/repos","events_url":"https://api.github.com/users/jeffmendoza/events{/privacy}","received_events_url":"https://api.github.com/users/jeffmendoza/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-07-31T19:46:28Z","updated_at":"2018-07-31T22:26:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"77c6ff2a91aaf327e9ff347fc9e8ecd68d53f26d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"frankbu","id":2752495,"node_id":"MDQ6VXNlcjI3NTI0OTU=","avatar_url":"https://avatars2.githubusercontent.com/u/2752495?v=4","gravatar_id":"","url":"https://api.github.com/users/frankbu","html_url":"https://github.com/frankbu","followers_url":"https://api.github.com/users/frankbu/followers","following_url":"https://api.github.com/users/frankbu/following{/other_user}","gists_url":"https://api.github.com/users/frankbu/gists{/gist_id}","starred_url":"https://api.github.com/users/frankbu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frankbu/subscriptions","organizations_url":"https://api.github.com/users/frankbu/orgs","repos_url":"https://api.github.com/users/frankbu/repos","events_url":"https://api.github.com/users/frankbu/events{/privacy}","received_events_url":"https://api.github.com/users/frankbu/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":884247475,"node_id":"MDU6TGFiZWw4ODQyNDc0NzU=","url":"https://api.github.com/repos/istio/istio.github.io/labels/cla:%20yes","name":"cla: yes","color":"bfdadc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/istio/istio.github.io/pulls/2097/commits","review_comments_url":"https://api.github.com/repos/istio/istio.github.io/pulls/2097/comments","review_comment_url":"https://api.github.com/repos/istio/istio.github.io/pulls/comments{/number}","comments_url":"https://api.github.com/repos/istio/istio.github.io/issues/2097/comments","statuses_url":"https://api.github.com/repos/istio/istio.github.io/statuses/e64868c1fd9198847608fec26d0a0262bdaf3ec5","head":{"label":"jeffmendoza:trace-sampling","ref":"trace-sampling","sha":"e64868c1fd9198847608fec26d0a0262bdaf3ec5","user":{"login":"jeffmendoza","id":771387,"node_id":"MDQ6VXNlcjc3MTM4Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/771387?v=4","gravatar_id":"","url":"https://api.github.com/users/jeffmendoza","html_url":"https://github.com/jeffmendoza","followers_url":"https://api.github.com/users/jeffmendoza/followers","following_url":"https://api.github.com/users/jeffmendoza/following{/other_user}","gists_url":"https://api.github.com/users/jeffmendoza/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffmendoza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffmendoza/subscriptions","organizations_url":"https://api.github.com/users/jeffmendoza/orgs","repos_url":"https://api.github.com/users/jeffmendoza/repos","events_url":"https://api.github.com/users/jeffmendoza/events{/privacy}","received_events_url":"https://api.github.com/users/jeffmendoza/received_events","type":"User","site_admin":false},"repo":{"id":114818983,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQ4MTg5ODM=","name":"istio.github.io","full_name":"jeffmendoza/istio.github.io","owner":{"login":"jeffmendoza","id":771387,"node_id":"MDQ6VXNlcjc3MTM4Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/771387?v=4","gravatar_id":"","url":"https://api.github.com/users/jeffmendoza","html_url":"https://github.com/jeffmendoza","followers_url":"https://api.github.com/users/jeffmendoza/followers","following_url":"https://api.github.com/users/jeffmendoza/following{/other_user}","gists_url":"https://api.github.com/users/jeffmendoza/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffmendoza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffmendoza/subscriptions","organizations_url":"https://api.github.com/users/jeffmendoza/orgs","repos_url":"https://api.github.com/users/jeffmendoza/repos","events_url":"https://api.github.com/users/jeffmendoza/events{/privacy}","received_events_url":"https://api.github.com/users/jeffmendoza/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jeffmendoza/istio.github.io","description":"Source for the istio.io site","fork":true,"url":"https://api.github.com/repos/jeffmendoza/istio.github.io","forks_url":"https://api.github.com/repos/jeffmendoza/istio.github.io/forks","keys_url":"https://api.github.com/repos/jeffmendoza/istio.github.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jeffmendoza/istio.github.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jeffmendoza/istio.github.io/teams","hooks_url":"https://api.github.com/repos/jeffmendoza/istio.github.io/hooks","issue_events_url":"https://api.github.com/repos/jeffmendoza/istio.github.io/issues/events{/number}","events_url":"https://api.github.com/repos/jeffmendoza/istio.github.io/events","assignees_url":"https://api.github.com/repos/jeffmendoza/istio.github.io/assignees{/user}","branches_url":"https://api.github.com/repos/jeffmendoza/istio.github.io/branches{/branch}","tags_url":"https://api.github.com/repos/jeffmendoza/istio.github.io/tags","blobs_url":"https://api.github.com/repos/jeffmendoza/istio.github.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jeffmendoza/istio.github.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jeffmendoza/istio.github.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/jeffmendoza/istio.github.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jeffmendoza/istio.github.io/statuses/{sha}","languages_url":"https://api.github.com/repos/jeffmendoza/istio.github.io/languages","stargazers_url":"https://api.github.com/repos/jeffmendoza/istio.github.io/stargazers","contributors_url":"https://api.github.com/repos/jeffmendoza/istio.github.io/contributors","subscribers_url":"https://api.github.com/repos/jeffmendoza/istio.github.io/subscribers","subscription_url":"https://api.github.com/repos/jeffmendoza/istio.github.io/subscription","commits_url":"https://api.github.com/repos/jeffmendoza/istio.github.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/jeffmendoza/istio.github.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/jeffmendoza/istio.github.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/jeffmendoza/istio.github.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/jeffmendoza/istio.github.io/contents/{+path}","compare_url":"https://api.github.com/repos/jeffmendoza/istio.github.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jeffmendoza/istio.github.io/merges","archive_url":"https://api.github.com/repos/jeffmendoza/istio.github.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jeffmendoza/istio.github.io/downloads","issues_url":"https://api.github.com/repos/jeffmendoza/istio.github.io/issues{/number}","pulls_url":"https://api.github.com/repos/jeffmendoza/istio.github.io/pulls{/number}","milestones_url":"https://api.github.com/repos/jeffmendoza/istio.github.io/milestones{/number}","notifications_url":"https://api.github.com/repos/jeffmendoza/istio.github.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jeffmendoza/istio.github.io/labels{/name}","releases_url":"https://api.github.com/repos/jeffmendoza/istio.github.io/releases{/id}","deployments_url":"https://api.github.com/repos/jeffmendoza/istio.github.io/deployments","created_at":"2017-12-19T22:52:16Z","updated_at":"2017-12-19T22:52:18Z","pushed_at":"2018-07-31T20:53:57Z","git_url":"git://github.com/jeffmendoza/istio.github.io.git","ssh_url":"git@github.com:jeffmendoza/istio.github.io.git","clone_url":"https://github.com/jeffmendoza/istio.github.io.git","svn_url":"https://github.com/jeffmendoza/istio.github.io","homepage":"https://istio.io/","size":27724,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"istio:release-1.0","ref":"release-1.0","sha":"d1a0d97c5c9a0975c4feadc0c55e98ba5f4d56f1","user":{"login":"istio","id":23534644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTM0NjQ0","avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"repo":{"id":82706976,"node_id":"MDEwOlJlcG9zaXRvcnk4MjcwNjk3Ng==","name":"istio.github.io","full_name":"istio/istio.github.io","owner":{"login":"istio","id":23534644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTM0NjQ0","avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/istio/istio.github.io","description":"Source for the istio.io site","fork":false,"url":"https://api.github.com/repos/istio/istio.github.io","forks_url":"https://api.github.com/repos/istio/istio.github.io/forks","keys_url":"https://api.github.com/repos/istio/istio.github.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/istio/istio.github.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/istio/istio.github.io/teams","hooks_url":"https://api.github.com/repos/istio/istio.github.io/hooks","issue_events_url":"https://api.github.com/repos/istio/istio.github.io/issues/events{/number}","events_url":"https://api.github.com/repos/istio/istio.github.io/events","assignees_url":"https://api.github.com/repos/istio/istio.github.io/assignees{/user}","branches_url":"https://api.github.com/repos/istio/istio.github.io/branches{/branch}","tags_url":"https://api.github.com/repos/istio/istio.github.io/tags","blobs_url":"https://api.github.com/repos/istio/istio.github.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/istio/istio.github.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/istio/istio.github.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/istio/istio.github.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/istio/istio.github.io/statuses/{sha}","languages_url":"https://api.github.com/repos/istio/istio.github.io/languages","stargazers_url":"https://api.github.com/repos/istio/istio.github.io/stargazers","contributors_url":"https://api.github.com/repos/istio/istio.github.io/contributors","subscribers_url":"https://api.github.com/repos/istio/istio.github.io/subscribers","subscription_url":"https://api.github.com/repos/istio/istio.github.io/subscription","commits_url":"https://api.github.com/repos/istio/istio.github.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/istio/istio.github.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/istio/istio.github.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/istio/istio.github.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/istio/istio.github.io/contents/{+path}","compare_url":"https://api.github.com/repos/istio/istio.github.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/istio/istio.github.io/merges","archive_url":"https://api.github.com/repos/istio/istio.github.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/istio/istio.github.io/downloads","issues_url":"https://api.github.com/repos/istio/istio.github.io/issues{/number}","pulls_url":"https://api.github.com/repos/istio/istio.github.io/pulls{/number}","milestones_url":"https://api.github.com/repos/istio/istio.github.io/milestones{/number}","notifications_url":"https://api.github.com/repos/istio/istio.github.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/istio/istio.github.io/labels{/name}","releases_url":"https://api.github.com/repos/istio/istio.github.io/releases{/id}","deployments_url":"https://api.github.com/repos/istio/istio.github.io/deployments","created_at":"2017-02-21T17:19:49Z","updated_at":"2018-07-31T19:09:49Z","pushed_at":"2018-07-31T22:09:50Z","git_url":"git://github.com/istio/istio.github.io.git","ssh_url":"git@github.com:istio/istio.github.io.git","clone_url":"https://github.com/istio/istio.github.io.git","svn_url":"https://github.com/istio/istio.github.io","homepage":"https://istio.io/","size":28016,"stargazers_count":85,"watchers_count":85,"language":"HTML","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":269,"mirror_url":null,"archived":false,"open_issues_count":61,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":269,"open_issues":61,"watchers":85,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/istio/istio.github.io/pulls/2097"},"html":{"href":"https://github.com/istio/istio.github.io/pull/2097"},"issue":{"href":"https://api.github.com/repos/istio/istio.github.io/issues/2097"},"comments":{"href":"https://api.github.com/repos/istio/istio.github.io/issues/2097/comments"},"review_comments":{"href":"https://api.github.com/repos/istio/istio.github.io/pulls/2097/comments"},"review_comment":{"href":"https://api.github.com/repos/istio/istio.github.io/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/istio/istio.github.io/pulls/2097/commits"},"statuses":{"href":"https://api.github.com/repos/istio/istio.github.io/statuses/e64868c1fd9198847608fec26d0a0262bdaf3ec5"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"rcaballeromx"}}