{"action":"created","comment":{"url":"https://api.github.com/repos/yast/yast-storage-ng/pulls/comments/168244319","pull_request_review_id":96570150,"id":168244319,"diff_hunk":"@@ -44,37 +44,51 @@ def initialize(setup_checker)\n     #\n     # @return [String]\n     def to_html\n-      errors = [boot_errors_html, product_errors_html].compact\n-      return \"\" if errors.empty?\n+      errors = errors_html\n+      return errors if errors\n \n-      errors.join(Yast::HTML.Newline)\n+      warnings = [boot_warnings_html, product_warnings_html].compact\n+      return \"\" if warnings.empty?\n+\n+      warnings.join(Yast::HTML.Newline)\n     end\n \n   private\n \n     # @return [SetupChecker] checker for the current setup\n     attr_reader :setup_checker\n \n-    # HTML representation for boot errors\n+    # HTML representation for boot warnings\n     #\n-    # @return [String, nil] nil if there is no boot error\n-    def boot_errors_html\n-      errors = setup_checker.boot_errors\n+    # @return [String, nil] nil if there is no boot warning\n+    def boot_warnings_html\n+      warnings = setup_checker.boot_warnings\n       # TRANSLATORS\n       header = _(\"The system might not be able to boot:\\n\")\n \n-      errors_html(header, errors)\n+      create_html(header, warnings)\n     end\n \n-    # HTML representation for mandatory product errors\n+    # HTML representation for mandatory product warnings\n     #\n-    # @return [String, nil] nil if there is no product error\n-    def product_errors_html\n-      errors = setup_checker.product_errors\n+    # @return [String, nil] nil if there is no product warning\n+    def product_warnings_html\n+      warnings = setup_checker.product_warnings\n+      # TRANSLATORS\n+      header = _(\"The system could not work properly because the following warnings were found:\\n\")","path":"src/lib/y2partitioner/setup_errors_presenter.rb","position":47,"original_position":47,"commit_id":"c100836151c883fcb1f63f5c836201bd0fa287b2","original_commit_id":"c100836151c883fcb1f63f5c836201bd0fa287b2","user":{"login":"joseivanlopez","id":1112304,"avatar_url":"https://avatars2.githubusercontent.com/u/1112304?v=4","gravatar_id":"","url":"https://api.github.com/users/joseivanlopez","html_url":"https://github.com/joseivanlopez","followers_url":"https://api.github.com/users/joseivanlopez/followers","following_url":"https://api.github.com/users/joseivanlopez/following{/other_user}","gists_url":"https://api.github.com/users/joseivanlopez/gists{/gist_id}","starred_url":"https://api.github.com/users/joseivanlopez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joseivanlopez/subscriptions","organizations_url":"https://api.github.com/users/joseivanlopez/orgs","repos_url":"https://api.github.com/users/joseivanlopez/repos","events_url":"https://api.github.com/users/joseivanlopez/events{/privacy}","received_events_url":"https://api.github.com/users/joseivanlopez/received_events","type":"User","site_admin":false},"body":"NP: I would avoid the word `warnings` there. An option could be: `The system could not work properly because the following issues were found:`","created_at":"2018-02-14T17:07:15Z","updated_at":"2018-02-14T17:26:38Z","html_url":"https://github.com/yast/yast-storage-ng/pull/521#discussion_r168244319","pull_request_url":"https://api.github.com/repos/yast/yast-storage-ng/pulls/521","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/yast/yast-storage-ng/pulls/comments/168244319"},"html":{"href":"https://github.com/yast/yast-storage-ng/pull/521#discussion_r168244319"},"pull_request":{"href":"https://api.github.com/repos/yast/yast-storage-ng/pulls/521"}}},"pull_request":{"url":"https://api.github.com/repos/yast/yast-storage-ng/pulls/521","id":169097363,"html_url":"https://github.com/yast/yast-storage-ng/pull/521","diff_url":"https://github.com/yast/yast-storage-ng/pull/521.diff","patch_url":"https://github.com/yast/yast-storage-ng/pull/521.patch","issue_url":"https://api.github.com/repos/yast/yast-storage-ng/issues/521","number":521,"state":"open","locked":false,"title":"[WIP] first version of fatal errors","user":{"login":"jreidinger","id":478871,"avatar_url":"https://avatars2.githubusercontent.com/u/478871?v=4","gravatar_id":"","url":"https://api.github.com/users/jreidinger","html_url":"https://github.com/jreidinger","followers_url":"https://api.github.com/users/jreidinger/followers","following_url":"https://api.github.com/users/jreidinger/following{/other_user}","gists_url":"https://api.github.com/users/jreidinger/gists{/gist_id}","starred_url":"https://api.github.com/users/jreidinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jreidinger/subscriptions","organizations_url":"https://api.github.com/users/jreidinger/orgs","repos_url":"https://api.github.com/users/jreidinger/repos","events_url":"https://api.github.com/users/jreidinger/events{/privacy}","received_events_url":"https://api.github.com/users/jreidinger/received_events","type":"User","site_admin":false},"body":"plan is to also add all current checks in bootloader itself.","created_at":"2018-02-14T12:30:26Z","updated_at":"2018-02-14T17:26:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ca5b161636d2053efd50a1a1ea7163cfd797ca12","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/yast/yast-storage-ng/pulls/521/commits","review_comments_url":"https://api.github.com/repos/yast/yast-storage-ng/pulls/521/comments","review_comment_url":"https://api.github.com/repos/yast/yast-storage-ng/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yast/yast-storage-ng/issues/521/comments","statuses_url":"https://api.github.com/repos/yast/yast-storage-ng/statuses/c100836151c883fcb1f63f5c836201bd0fa287b2","head":{"label":"yast:fatal_errors","ref":"fatal_errors","sha":"c100836151c883fcb1f63f5c836201bd0fa287b2","user":{"login":"yast","id":909990,"avatar_url":"https://avatars1.githubusercontent.com/u/909990?v=4","gravatar_id":"","url":"https://api.github.com/users/yast","html_url":"https://github.com/yast","followers_url":"https://api.github.com/users/yast/followers","following_url":"https://api.github.com/users/yast/following{/other_user}","gists_url":"https://api.github.com/users/yast/gists{/gist_id}","starred_url":"https://api.github.com/users/yast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yast/subscriptions","organizations_url":"https://api.github.com/users/yast/orgs","repos_url":"https://api.github.com/users/yast/repos","events_url":"https://api.github.com/users/yast/events{/privacy}","received_events_url":"https://api.github.com/users/yast/received_events","type":"Organization","site_admin":false},"repo":{"id":46064409,"name":"yast-storage-ng","full_name":"yast/yast-storage-ng","owner":{"login":"yast","id":909990,"avatar_url":"https://avatars1.githubusercontent.com/u/909990?v=4","gravatar_id":"","url":"https://api.github.com/users/yast","html_url":"https://github.com/yast","followers_url":"https://api.github.com/users/yast/followers","following_url":"https://api.github.com/users/yast/following{/other_user}","gists_url":"https://api.github.com/users/yast/gists{/gist_id}","starred_url":"https://api.github.com/users/yast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yast/subscriptions","organizations_url":"https://api.github.com/users/yast/orgs","repos_url":"https://api.github.com/users/yast/repos","events_url":"https://api.github.com/users/yast/events{/privacy}","received_events_url":"https://api.github.com/users/yast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yast/yast-storage-ng","description":"Rewrite of https://github.com/yast/yast-storage","fork":false,"url":"https://api.github.com/repos/yast/yast-storage-ng","forks_url":"https://api.github.com/repos/yast/yast-storage-ng/forks","keys_url":"https://api.github.com/repos/yast/yast-storage-ng/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yast/yast-storage-ng/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yast/yast-storage-ng/teams","hooks_url":"https://api.github.com/repos/yast/yast-storage-ng/hooks","issue_events_url":"https://api.github.com/repos/yast/yast-storage-ng/issues/events{/number}","events_url":"https://api.github.com/repos/yast/yast-storage-ng/events","assignees_url":"https://api.github.com/repos/yast/yast-storage-ng/assignees{/user}","branches_url":"https://api.github.com/repos/yast/yast-storage-ng/branches{/branch}","tags_url":"https://api.github.com/repos/yast/yast-storage-ng/tags","blobs_url":"https://api.github.com/repos/yast/yast-storage-ng/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yast/yast-storage-ng/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yast/yast-storage-ng/git/refs{/sha}","trees_url":"https://api.github.com/repos/yast/yast-storage-ng/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yast/yast-storage-ng/statuses/{sha}","languages_url":"https://api.github.com/repos/yast/yast-storage-ng/languages","stargazers_url":"https://api.github.com/repos/yast/yast-storage-ng/stargazers","contributors_url":"https://api.github.com/repos/yast/yast-storage-ng/contributors","subscribers_url":"https://api.github.com/repos/yast/yast-storage-ng/subscribers","subscription_url":"https://api.github.com/repos/yast/yast-storage-ng/subscription","commits_url":"https://api.github.com/repos/yast/yast-storage-ng/commits{/sha}","git_commits_url":"https://api.github.com/repos/yast/yast-storage-ng/git/commits{/sha}","comments_url":"https://api.github.com/repos/yast/yast-storage-ng/comments{/number}","issue_comment_url":"https://api.github.com/repos/yast/yast-storage-ng/issues/comments{/number}","contents_url":"https://api.github.com/repos/yast/yast-storage-ng/contents/{+path}","compare_url":"https://api.github.com/repos/yast/yast-storage-ng/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yast/yast-storage-ng/merges","archive_url":"https://api.github.com/repos/yast/yast-storage-ng/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yast/yast-storage-ng/downloads","issues_url":"https://api.github.com/repos/yast/yast-storage-ng/issues{/number}","pulls_url":"https://api.github.com/repos/yast/yast-storage-ng/pulls{/number}","milestones_url":"https://api.github.com/repos/yast/yast-storage-ng/milestones{/number}","notifications_url":"https://api.github.com/repos/yast/yast-storage-ng/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yast/yast-storage-ng/labels{/name}","releases_url":"https://api.github.com/repos/yast/yast-storage-ng/releases{/id}","deployments_url":"https://api.github.com/repos/yast/yast-storage-ng/deployments","created_at":"2015-11-12T16:09:03Z","updated_at":"2017-12-13T17:35:51Z","pushed_at":"2018-02-14T16:15:56Z","git_url":"git://github.com/yast/yast-storage-ng.git","ssh_url":"git@github.com:yast/yast-storage-ng.git","clone_url":"https://github.com/yast/yast-storage-ng.git","svn_url":"https://github.com/yast/yast-storage-ng","homepage":"http://yast.github.io/","size":4450,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":13,"open_issues":6,"watchers":3,"default_branch":"master"}},"base":{"label":"yast:master","ref":"master","sha":"6557fb397df3d32f11bb2d6a9d797bb4780bda85","user":{"login":"yast","id":909990,"avatar_url":"https://avatars1.githubusercontent.com/u/909990?v=4","gravatar_id":"","url":"https://api.github.com/users/yast","html_url":"https://github.com/yast","followers_url":"https://api.github.com/users/yast/followers","following_url":"https://api.github.com/users/yast/following{/other_user}","gists_url":"https://api.github.com/users/yast/gists{/gist_id}","starred_url":"https://api.github.com/users/yast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yast/subscriptions","organizations_url":"https://api.github.com/users/yast/orgs","repos_url":"https://api.github.com/users/yast/repos","events_url":"https://api.github.com/users/yast/events{/privacy}","received_events_url":"https://api.github.com/users/yast/received_events","type":"Organization","site_admin":false},"repo":{"id":46064409,"name":"yast-storage-ng","full_name":"yast/yast-storage-ng","owner":{"login":"yast","id":909990,"avatar_url":"https://avatars1.githubusercontent.com/u/909990?v=4","gravatar_id":"","url":"https://api.github.com/users/yast","html_url":"https://github.com/yast","followers_url":"https://api.github.com/users/yast/followers","following_url":"https://api.github.com/users/yast/following{/other_user}","gists_url":"https://api.github.com/users/yast/gists{/gist_id}","starred_url":"https://api.github.com/users/yast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yast/subscriptions","organizations_url":"https://api.github.com/users/yast/orgs","repos_url":"https://api.github.com/users/yast/repos","events_url":"https://api.github.com/users/yast/events{/privacy}","received_events_url":"https://api.github.com/users/yast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yast/yast-storage-ng","description":"Rewrite of https://github.com/yast/yast-storage","fork":false,"url":"https://api.github.com/repos/yast/yast-storage-ng","forks_url":"https://api.github.com/repos/yast/yast-storage-ng/forks","keys_url":"https://api.github.com/repos/yast/yast-storage-ng/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yast/yast-storage-ng/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yast/yast-storage-ng/teams","hooks_url":"https://api.github.com/repos/yast/yast-storage-ng/hooks","issue_events_url":"https://api.github.com/repos/yast/yast-storage-ng/issues/events{/number}","events_url":"https://api.github.com/repos/yast/yast-storage-ng/events","assignees_url":"https://api.github.com/repos/yast/yast-storage-ng/assignees{/user}","branches_url":"https://api.github.com/repos/yast/yast-storage-ng/branches{/branch}","tags_url":"https://api.github.com/repos/yast/yast-storage-ng/tags","blobs_url":"https://api.github.com/repos/yast/yast-storage-ng/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yast/yast-storage-ng/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yast/yast-storage-ng/git/refs{/sha}","trees_url":"https://api.github.com/repos/yast/yast-storage-ng/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yast/yast-storage-ng/statuses/{sha}","languages_url":"https://api.github.com/repos/yast/yast-storage-ng/languages","stargazers_url":"https://api.github.com/repos/yast/yast-storage-ng/stargazers","contributors_url":"https://api.github.com/repos/yast/yast-storage-ng/contributors","subscribers_url":"https://api.github.com/repos/yast/yast-storage-ng/subscribers","subscription_url":"https://api.github.com/repos/yast/yast-storage-ng/subscription","commits_url":"https://api.github.com/repos/yast/yast-storage-ng/commits{/sha}","git_commits_url":"https://api.github.com/repos/yast/yast-storage-ng/git/commits{/sha}","comments_url":"https://api.github.com/repos/yast/yast-storage-ng/comments{/number}","issue_comment_url":"https://api.github.com/repos/yast/yast-storage-ng/issues/comments{/number}","contents_url":"https://api.github.com/repos/yast/yast-storage-ng/contents/{+path}","compare_url":"https://api.github.com/repos/yast/yast-storage-ng/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yast/yast-storage-ng/merges","archive_url":"https://api.github.com/repos/yast/yast-storage-ng/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yast/yast-storage-ng/downloads","issues_url":"https://api.github.com/repos/yast/yast-storage-ng/issues{/number}","pulls_url":"https://api.github.com/repos/yast/yast-storage-ng/pulls{/number}","milestones_url":"https://api.github.com/repos/yast/yast-storage-ng/milestones{/number}","notifications_url":"https://api.github.com/repos/yast/yast-storage-ng/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yast/yast-storage-ng/labels{/name}","releases_url":"https://api.github.com/repos/yast/yast-storage-ng/releases{/id}","deployments_url":"https://api.github.com/repos/yast/yast-storage-ng/deployments","created_at":"2015-11-12T16:09:03Z","updated_at":"2017-12-13T17:35:51Z","pushed_at":"2018-02-14T16:15:56Z","git_url":"git://github.com/yast/yast-storage-ng.git","ssh_url":"git@github.com:yast/yast-storage-ng.git","clone_url":"https://github.com/yast/yast-storage-ng.git","svn_url":"https://github.com/yast/yast-storage-ng","homepage":"http://yast.github.io/","size":4450,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":13,"open_issues":6,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yast/yast-storage-ng/pulls/521"},"html":{"href":"https://github.com/yast/yast-storage-ng/pull/521"},"issue":{"href":"https://api.github.com/repos/yast/yast-storage-ng/issues/521"},"comments":{"href":"https://api.github.com/repos/yast/yast-storage-ng/issues/521/comments"},"review_comments":{"href":"https://api.github.com/repos/yast/yast-storage-ng/pulls/521/comments"},"review_comment":{"href":"https://api.github.com/repos/yast/yast-storage-ng/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yast/yast-storage-ng/pulls/521/commits"},"statuses":{"href":"https://api.github.com/repos/yast/yast-storage-ng/statuses/c100836151c883fcb1f63f5c836201bd0fa287b2"}},"author_association":"OWNER"}}
{"actor":{"display_login":"joseivanlopez"}}