{"action":"closed","number":6708,"pull_request":{"url":"https://api.github.com/repos/facebook/flow/pulls/6708","id":206911367,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2OTExMzY3","html_url":"https://github.com/facebook/flow/pull/6708","diff_url":"https://github.com/facebook/flow/pull/6708.diff","patch_url":"https://github.com/facebook/flow/pull/6708.patch","issue_url":"https://api.github.com/repos/facebook/flow/issues/6708","number":6708,"state":"closed","locked":false,"title":"Fix docs for `$Shape`","user":{"login":"wchargin","id":4317806,"node_id":"MDQ6VXNlcjQzMTc4MDY=","avatar_url":"https://avatars3.githubusercontent.com/u/4317806?v=4","gravatar_id":"","url":"https://api.github.com/users/wchargin","html_url":"https://github.com/wchargin","followers_url":"https://api.github.com/users/wchargin/followers","following_url":"https://api.github.com/users/wchargin/following{/other_user}","gists_url":"https://api.github.com/users/wchargin/gists{/gist_id}","starred_url":"https://api.github.com/users/wchargin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wchargin/subscriptions","organizations_url":"https://api.github.com/users/wchargin/orgs","repos_url":"https://api.github.com/users/wchargin/repos","events_url":"https://api.github.com/users/wchargin/events{/privacy}","received_events_url":"https://api.github.com/users/wchargin/received_events","type":"User","site_admin":false},"body":"Summary:\r\nDocs for `$Shape` were introduced in #6694, but that PR had four major\r\nerrors:\r\n\r\n  - the section was not linked from the table of contents;\r\n  - the type `$Shape<T>` was misspelled as `Shape<T>` in the header;\r\n  - the code block did not have `// @flow`, so lacked error annotations;\r\n  - the code block was not terminated, so the entirety of the rest of\r\n    the page was marked as code, [like this][1]—clearly no one previewed\r\n    the page before deploying!\r\n\r\n[1]: https://archive.fo/CqH7D#87%\r\n\r\nThis patch fixes those errors. While in the area, we clean up the\r\ncomments reading \"Error\" and \"OK\" to (a) eliminate the horizontal\r\nscrollbar and (b) match the style elsewhere on the page.\r\n\r\nCloses #6692.\r\n\r\nTest Plan:\r\nAfter much effort, managed to get the website to build locally. Visited\r\n<http://localhost:8080/en/docs/types/utilities/#toc-shape> and checked\r\nthat the four issues mentioned above are all fixed.\r\n\r\n(For posterity, steps taken to get the build working are listed here:\r\n<https://github.com/facebook/flow/pull/6708#issuecomment-411308129>.)\r\n\r\nwchargin-branch: fix-shape-docs\r\n\r\n","created_at":"2018-08-08T07:04:06Z","updated_at":"2018-08-10T21:01:01Z","closed_at":"2018-08-10T21:01:01Z","merged_at":null,"merge_commit_sha":"21cc67e05f7900548c377092fb4666d61123a4fe","assignee":{"login":"jbrown215","id":8551887,"node_id":"MDQ6VXNlcjg1NTE4ODc=","avatar_url":"https://avatars1.githubusercontent.com/u/8551887?v=4","gravatar_id":"","url":"https://api.github.com/users/jbrown215","html_url":"https://github.com/jbrown215","followers_url":"https://api.github.com/users/jbrown215/followers","following_url":"https://api.github.com/users/jbrown215/following{/other_user}","gists_url":"https://api.github.com/users/jbrown215/gists{/gist_id}","starred_url":"https://api.github.com/users/jbrown215/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbrown215/subscriptions","organizations_url":"https://api.github.com/users/jbrown215/orgs","repos_url":"https://api.github.com/users/jbrown215/repos","events_url":"https://api.github.com/users/jbrown215/events{/privacy}","received_events_url":"https://api.github.com/users/jbrown215/received_events","type":"User","site_admin":false},"assignees":[{"login":"jbrown215","id":8551887,"node_id":"MDQ6VXNlcjg1NTE4ODc=","avatar_url":"https://avatars1.githubusercontent.com/u/8551887?v=4","gravatar_id":"","url":"https://api.github.com/users/jbrown215","html_url":"https://github.com/jbrown215","followers_url":"https://api.github.com/users/jbrown215/followers","following_url":"https://api.github.com/users/jbrown215/following{/other_user}","gists_url":"https://api.github.com/users/jbrown215/gists{/gist_id}","starred_url":"https://api.github.com/users/jbrown215/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbrown215/subscriptions","organizations_url":"https://api.github.com/users/jbrown215/orgs","repos_url":"https://api.github.com/users/jbrown215/repos","events_url":"https://api.github.com/users/jbrown215/events{/privacy}","received_events_url":"https://api.github.com/users/jbrown215/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":196859323,"node_id":"MDU6TGFiZWwxOTY4NTkzMjM=","url":"https://api.github.com/repos/facebook/flow/labels/CLA%20Signed","name":"CLA Signed","color":"eeeeee","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/flow/pulls/6708/commits","review_comments_url":"https://api.github.com/repos/facebook/flow/pulls/6708/comments","review_comment_url":"https://api.github.com/repos/facebook/flow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/flow/issues/6708/comments","statuses_url":"https://api.github.com/repos/facebook/flow/statuses/5dd105edb093e705422e7124a6d2ce18b6bd7170","head":{"label":"wchargin:wchargin-fix-shape-docs","ref":"wchargin-fix-shape-docs","sha":"5dd105edb093e705422e7124a6d2ce18b6bd7170","user":{"login":"wchargin","id":4317806,"node_id":"MDQ6VXNlcjQzMTc4MDY=","avatar_url":"https://avatars3.githubusercontent.com/u/4317806?v=4","gravatar_id":"","url":"https://api.github.com/users/wchargin","html_url":"https://github.com/wchargin","followers_url":"https://api.github.com/users/wchargin/followers","following_url":"https://api.github.com/users/wchargin/following{/other_user}","gists_url":"https://api.github.com/users/wchargin/gists{/gist_id}","starred_url":"https://api.github.com/users/wchargin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wchargin/subscriptions","organizations_url":"https://api.github.com/users/wchargin/orgs","repos_url":"https://api.github.com/users/wchargin/repos","events_url":"https://api.github.com/users/wchargin/events{/privacy}","received_events_url":"https://api.github.com/users/wchargin/received_events","type":"User","site_admin":false},"repo":{"id":135395697,"node_id":"MDEwOlJlcG9zaXRvcnkxMzUzOTU2OTc=","name":"flow","full_name":"wchargin/flow","owner":{"login":"wchargin","id":4317806,"node_id":"MDQ6VXNlcjQzMTc4MDY=","avatar_url":"https://avatars3.githubusercontent.com/u/4317806?v=4","gravatar_id":"","url":"https://api.github.com/users/wchargin","html_url":"https://github.com/wchargin","followers_url":"https://api.github.com/users/wchargin/followers","following_url":"https://api.github.com/users/wchargin/following{/other_user}","gists_url":"https://api.github.com/users/wchargin/gists{/gist_id}","starred_url":"https://api.github.com/users/wchargin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wchargin/subscriptions","organizations_url":"https://api.github.com/users/wchargin/orgs","repos_url":"https://api.github.com/users/wchargin/repos","events_url":"https://api.github.com/users/wchargin/events{/privacy}","received_events_url":"https://api.github.com/users/wchargin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wchargin/flow","description":"Adds static typing to JavaScript to improve developer productivity and code quality.","fork":true,"url":"https://api.github.com/repos/wchargin/flow","forks_url":"https://api.github.com/repos/wchargin/flow/forks","keys_url":"https://api.github.com/repos/wchargin/flow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wchargin/flow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wchargin/flow/teams","hooks_url":"https://api.github.com/repos/wchargin/flow/hooks","issue_events_url":"https://api.github.com/repos/wchargin/flow/issues/events{/number}","events_url":"https://api.github.com/repos/wchargin/flow/events","assignees_url":"https://api.github.com/repos/wchargin/flow/assignees{/user}","branches_url":"https://api.github.com/repos/wchargin/flow/branches{/branch}","tags_url":"https://api.github.com/repos/wchargin/flow/tags","blobs_url":"https://api.github.com/repos/wchargin/flow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wchargin/flow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wchargin/flow/git/refs{/sha}","trees_url":"https://api.github.com/repos/wchargin/flow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wchargin/flow/statuses/{sha}","languages_url":"https://api.github.com/repos/wchargin/flow/languages","stargazers_url":"https://api.github.com/repos/wchargin/flow/stargazers","contributors_url":"https://api.github.com/repos/wchargin/flow/contributors","subscribers_url":"https://api.github.com/repos/wchargin/flow/subscribers","subscription_url":"https://api.github.com/repos/wchargin/flow/subscription","commits_url":"https://api.github.com/repos/wchargin/flow/commits{/sha}","git_commits_url":"https://api.github.com/repos/wchargin/flow/git/commits{/sha}","comments_url":"https://api.github.com/repos/wchargin/flow/comments{/number}","issue_comment_url":"https://api.github.com/repos/wchargin/flow/issues/comments{/number}","contents_url":"https://api.github.com/repos/wchargin/flow/contents/{+path}","compare_url":"https://api.github.com/repos/wchargin/flow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wchargin/flow/merges","archive_url":"https://api.github.com/repos/wchargin/flow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wchargin/flow/downloads","issues_url":"https://api.github.com/repos/wchargin/flow/issues{/number}","pulls_url":"https://api.github.com/repos/wchargin/flow/pulls{/number}","milestones_url":"https://api.github.com/repos/wchargin/flow/milestones{/number}","notifications_url":"https://api.github.com/repos/wchargin/flow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wchargin/flow/labels{/name}","releases_url":"https://api.github.com/repos/wchargin/flow/releases{/id}","deployments_url":"https://api.github.com/repos/wchargin/flow/deployments","created_at":"2018-05-30T06:07:20Z","updated_at":"2018-05-30T06:07:32Z","pushed_at":"2018-08-08T07:21:42Z","git_url":"git://github.com/wchargin/flow.git","ssh_url":"git@github.com:wchargin/flow.git","clone_url":"https://github.com/wchargin/flow.git","svn_url":"https://github.com/wchargin/flow","homepage":"https://flow.org/","size":40651,"stargazers_count":0,"watchers_count":0,"language":"OCaml","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"b1c804ee383207a9194d5e0d36b8a94eac3198da","user":{"login":"facebook","id":69631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NjMx","avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":25880891,"node_id":"MDEwOlJlcG9zaXRvcnkyNTg4MDg5MQ==","name":"flow","full_name":"facebook/flow","owner":{"login":"facebook","id":69631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NjMx","avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/flow","description":"Adds static typing to JavaScript to improve developer productivity and code quality.","fork":false,"url":"https://api.github.com/repos/facebook/flow","forks_url":"https://api.github.com/repos/facebook/flow/forks","keys_url":"https://api.github.com/repos/facebook/flow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/flow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/flow/teams","hooks_url":"https://api.github.com/repos/facebook/flow/hooks","issue_events_url":"https://api.github.com/repos/facebook/flow/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/flow/events","assignees_url":"https://api.github.com/repos/facebook/flow/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/flow/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/flow/tags","blobs_url":"https://api.github.com/repos/facebook/flow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/flow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/flow/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/flow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/flow/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/flow/languages","stargazers_url":"https://api.github.com/repos/facebook/flow/stargazers","contributors_url":"https://api.github.com/repos/facebook/flow/contributors","subscribers_url":"https://api.github.com/repos/facebook/flow/subscribers","subscription_url":"https://api.github.com/repos/facebook/flow/subscription","commits_url":"https://api.github.com/repos/facebook/flow/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/flow/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/flow/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/flow/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/flow/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/flow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/flow/merges","archive_url":"https://api.github.com/repos/facebook/flow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/flow/downloads","issues_url":"https://api.github.com/repos/facebook/flow/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/flow/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/flow/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/flow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/flow/labels{/name}","releases_url":"https://api.github.com/repos/facebook/flow/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/flow/deployments","created_at":"2014-10-28T17:17:45Z","updated_at":"2018-08-10T18:16:50Z","pushed_at":"2018-08-10T21:00:31Z","git_url":"git://github.com/facebook/flow.git","ssh_url":"git@github.com:facebook/flow.git","clone_url":"https://github.com/facebook/flow.git","svn_url":"https://github.com/facebook/flow","homepage":"https://flow.org/","size":40701,"stargazers_count":17381,"watchers_count":17381,"language":"OCaml","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1460,"mirror_url":null,"archived":false,"open_issues_count":2430,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1460,"open_issues":2430,"watchers":17381,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/flow/pulls/6708"},"html":{"href":"https://github.com/facebook/flow/pull/6708"},"issue":{"href":"https://api.github.com/repos/facebook/flow/issues/6708"},"comments":{"href":"https://api.github.com/repos/facebook/flow/issues/6708/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/flow/pulls/6708/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/flow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/flow/pulls/6708/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/flow/statuses/5dd105edb093e705422e7124a6d2ce18b6bd7170"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":9,"deletions":6,"changed_files":1}}
{"actor":{"display_login":"facebook-github-bot"}}