{"action":"created","comment":{"url":"https://api.github.com/repos/angularsen/UnitsNet/pulls/comments/196537475","pull_request_review_id":130109688,"id":196537475,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NjUzNzQ3NQ==","diff_hunk":"@@ -2,6 +2,9 @@\n   \"Name\": \"AmountOfSubstance\",\n   \"BaseUnit\": \"Mole\",\n   \"XmlDoc\": \"Mole is the amount of substance containing Avagadro's Number (6.02 x 10 ^ 23) of real particles such as molecules,atoms, ions or radicals.\",\n+  \"BaseDimensions\": {\n+    \"N\": 1","path":"UnitsNet/UnitDefinitions/AmountOfSubstance.json","position":5,"original_position":5,"commit_id":"66fa7ee8f175ee4a5011a7e362f73618d33ca813","original_commit_id":"3137cae68917c2ced98e83fca8e091efaabee743","user":{"login":"angularsen","id":787816,"node_id":"MDQ6VXNlcjc4NzgxNg==","avatar_url":"https://avatars1.githubusercontent.com/u/787816?v=4","gravatar_id":"","url":"https://api.github.com/users/angularsen","html_url":"https://github.com/angularsen","followers_url":"https://api.github.com/users/angularsen/followers","following_url":"https://api.github.com/users/angularsen/following{/other_user}","gists_url":"https://api.github.com/users/angularsen/gists{/gist_id}","starred_url":"https://api.github.com/users/angularsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angularsen/subscriptions","organizations_url":"https://api.github.com/users/angularsen/orgs","repos_url":"https://api.github.com/users/angularsen/repos","events_url":"https://api.github.com/users/angularsen/events{/privacy}","received_events_url":"https://api.github.com/users/angularsen/received_events","type":"User","site_admin":false},"body":"Thanks, I was indeed confused by this. As you say, I was of the understanding that the dimensions could be used to express *all units* - not just the base unit of each quantity. The confusion arise from that it is always the *base unit* of the quantity that expresses the dimensions, so for `Area` the base unit is `m²` and thus `L=2`.  In my mind, we could then somehow represent feet and inches the same way, since most units is a simple linear transformation of the base unit, but maybe that gets into the same territory why chose to have two conversion functions for `from` and `to`, since this function is not always trivial to invert.\r\n\r\nAnyway, I think I'm onboard with the correct thinking now :-)","created_at":"2018-06-19T18:44:48Z","updated_at":"2018-06-19T18:44:48Z","html_url":"https://github.com/angularsen/UnitsNet/pull/444#discussion_r196537475","pull_request_url":"https://api.github.com/repos/angularsen/UnitsNet/pulls/444","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/angularsen/UnitsNet/pulls/comments/196537475"},"html":{"href":"https://github.com/angularsen/UnitsNet/pull/444#discussion_r196537475"},"pull_request":{"href":"https://api.github.com/repos/angularsen/UnitsNet/pulls/444"}},"in_reply_to_id":195641032},"pull_request":{"url":"https://api.github.com/repos/angularsen/UnitsNet/pulls/444","id":194710944,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0NzEwOTQ0","html_url":"https://github.com/angularsen/UnitsNet/pull/444","diff_url":"https://github.com/angularsen/UnitsNet/pull/444.diff","patch_url":"https://github.com/angularsen/UnitsNet/pull/444.patch","issue_url":"https://api.github.com/repos/angularsen/UnitsNet/issues/444","number":444,"state":"open","locked":false,"title":"Base dimensions","user":{"login":"tmilnthorp","id":5693174,"node_id":"MDQ6VXNlcjU2OTMxNzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5693174?v=4","gravatar_id":"","url":"https://api.github.com/users/tmilnthorp","html_url":"https://github.com/tmilnthorp","followers_url":"https://api.github.com/users/tmilnthorp/followers","following_url":"https://api.github.com/users/tmilnthorp/following{/other_user}","gists_url":"https://api.github.com/users/tmilnthorp/gists{/gist_id}","starred_url":"https://api.github.com/users/tmilnthorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmilnthorp/subscriptions","organizations_url":"https://api.github.com/users/tmilnthorp/orgs","repos_url":"https://api.github.com/users/tmilnthorp/repos","events_url":"https://api.github.com/users/tmilnthorp/events{/privacy}","received_events_url":"https://api.github.com/users/tmilnthorp/received_events","type":"User","site_admin":false},"body":"Hello all! I wanted to add base dimensions for all quantity classes. We can later add the automatic operator overload generation based on these. However this is useful information on its own, and does not need to wait for that work.","created_at":"2018-06-13T20:49:27Z","updated_at":"2018-06-19T18:44:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bce505e7d40d3c64a573c96f29eb1aa53dcbc4a4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/angularsen/UnitsNet/pulls/444/commits","review_comments_url":"https://api.github.com/repos/angularsen/UnitsNet/pulls/444/comments","review_comment_url":"https://api.github.com/repos/angularsen/UnitsNet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angularsen/UnitsNet/issues/444/comments","statuses_url":"https://api.github.com/repos/angularsen/UnitsNet/statuses/66fa7ee8f175ee4a5011a7e362f73618d33ca813","head":{"label":"tmilnthorp:BaseDimensions","ref":"BaseDimensions","sha":"66fa7ee8f175ee4a5011a7e362f73618d33ca813","user":{"login":"tmilnthorp","id":5693174,"node_id":"MDQ6VXNlcjU2OTMxNzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5693174?v=4","gravatar_id":"","url":"https://api.github.com/users/tmilnthorp","html_url":"https://github.com/tmilnthorp","followers_url":"https://api.github.com/users/tmilnthorp/followers","following_url":"https://api.github.com/users/tmilnthorp/following{/other_user}","gists_url":"https://api.github.com/users/tmilnthorp/gists{/gist_id}","starred_url":"https://api.github.com/users/tmilnthorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmilnthorp/subscriptions","organizations_url":"https://api.github.com/users/tmilnthorp/orgs","repos_url":"https://api.github.com/users/tmilnthorp/repos","events_url":"https://api.github.com/users/tmilnthorp/events{/privacy}","received_events_url":"https://api.github.com/users/tmilnthorp/received_events","type":"User","site_admin":false},"repo":{"id":129925220,"node_id":"MDEwOlJlcG9zaXRvcnkxMjk5MjUyMjA=","name":"UnitsNet","full_name":"tmilnthorp/UnitsNet","owner":{"login":"tmilnthorp","id":5693174,"node_id":"MDQ6VXNlcjU2OTMxNzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5693174?v=4","gravatar_id":"","url":"https://api.github.com/users/tmilnthorp","html_url":"https://github.com/tmilnthorp","followers_url":"https://api.github.com/users/tmilnthorp/followers","following_url":"https://api.github.com/users/tmilnthorp/following{/other_user}","gists_url":"https://api.github.com/users/tmilnthorp/gists{/gist_id}","starred_url":"https://api.github.com/users/tmilnthorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmilnthorp/subscriptions","organizations_url":"https://api.github.com/users/tmilnthorp/orgs","repos_url":"https://api.github.com/users/tmilnthorp/repos","events_url":"https://api.github.com/users/tmilnthorp/events{/privacy}","received_events_url":"https://api.github.com/users/tmilnthorp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tmilnthorp/UnitsNet","description":"Makes life working with units of measurement just a little bit better.","fork":true,"url":"https://api.github.com/repos/tmilnthorp/UnitsNet","forks_url":"https://api.github.com/repos/tmilnthorp/UnitsNet/forks","keys_url":"https://api.github.com/repos/tmilnthorp/UnitsNet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tmilnthorp/UnitsNet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tmilnthorp/UnitsNet/teams","hooks_url":"https://api.github.com/repos/tmilnthorp/UnitsNet/hooks","issue_events_url":"https://api.github.com/repos/tmilnthorp/UnitsNet/issues/events{/number}","events_url":"https://api.github.com/repos/tmilnthorp/UnitsNet/events","assignees_url":"https://api.github.com/repos/tmilnthorp/UnitsNet/assignees{/user}","branches_url":"https://api.github.com/repos/tmilnthorp/UnitsNet/branches{/branch}","tags_url":"https://api.github.com/repos/tmilnthorp/UnitsNet/tags","blobs_url":"https://api.github.com/repos/tmilnthorp/UnitsNet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tmilnthorp/UnitsNet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tmilnthorp/UnitsNet/git/refs{/sha}","trees_url":"https://api.github.com/repos/tmilnthorp/UnitsNet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tmilnthorp/UnitsNet/statuses/{sha}","languages_url":"https://api.github.com/repos/tmilnthorp/UnitsNet/languages","stargazers_url":"https://api.github.com/repos/tmilnthorp/UnitsNet/stargazers","contributors_url":"https://api.github.com/repos/tmilnthorp/UnitsNet/contributors","subscribers_url":"https://api.github.com/repos/tmilnthorp/UnitsNet/subscribers","subscription_url":"https://api.github.com/repos/tmilnthorp/UnitsNet/subscription","commits_url":"https://api.github.com/repos/tmilnthorp/UnitsNet/commits{/sha}","git_commits_url":"https://api.github.com/repos/tmilnthorp/UnitsNet/git/commits{/sha}","comments_url":"https://api.github.com/repos/tmilnthorp/UnitsNet/comments{/number}","issue_comment_url":"https://api.github.com/repos/tmilnthorp/UnitsNet/issues/comments{/number}","contents_url":"https://api.github.com/repos/tmilnthorp/UnitsNet/contents/{+path}","compare_url":"https://api.github.com/repos/tmilnthorp/UnitsNet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tmilnthorp/UnitsNet/merges","archive_url":"https://api.github.com/repos/tmilnthorp/UnitsNet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tmilnthorp/UnitsNet/downloads","issues_url":"https://api.github.com/repos/tmilnthorp/UnitsNet/issues{/number}","pulls_url":"https://api.github.com/repos/tmilnthorp/UnitsNet/pulls{/number}","milestones_url":"https://api.github.com/repos/tmilnthorp/UnitsNet/milestones{/number}","notifications_url":"https://api.github.com/repos/tmilnthorp/UnitsNet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tmilnthorp/UnitsNet/labels{/name}","releases_url":"https://api.github.com/repos/tmilnthorp/UnitsNet/releases{/id}","deployments_url":"https://api.github.com/repos/tmilnthorp/UnitsNet/deployments","created_at":"2018-04-17T15:24:34Z","updated_at":"2018-06-06T14:02:22Z","pushed_at":"2018-06-19T18:30:36Z","git_url":"git://github.com/tmilnthorp/UnitsNet.git","ssh_url":"git@github.com:tmilnthorp/UnitsNet.git","clone_url":"https://github.com/tmilnthorp/UnitsNet.git","svn_url":"https://github.com/tmilnthorp/UnitsNet","homepage":"https://www.nuget.org/packages/UnitsNet/","size":17510,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angularsen:master","ref":"master","sha":"3c6e4ed9af9026cc12344ec0a773d6edb7bf9674","user":{"login":"angularsen","id":787816,"node_id":"MDQ6VXNlcjc4NzgxNg==","avatar_url":"https://avatars1.githubusercontent.com/u/787816?v=4","gravatar_id":"","url":"https://api.github.com/users/angularsen","html_url":"https://github.com/angularsen","followers_url":"https://api.github.com/users/angularsen/followers","following_url":"https://api.github.com/users/angularsen/following{/other_user}","gists_url":"https://api.github.com/users/angularsen/gists{/gist_id}","starred_url":"https://api.github.com/users/angularsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angularsen/subscriptions","organizations_url":"https://api.github.com/users/angularsen/orgs","repos_url":"https://api.github.com/users/angularsen/repos","events_url":"https://api.github.com/users/angularsen/events{/privacy}","received_events_url":"https://api.github.com/users/angularsen/received_events","type":"User","site_admin":false},"repo":{"id":11521218,"node_id":"MDEwOlJlcG9zaXRvcnkxMTUyMTIxOA==","name":"UnitsNet","full_name":"angularsen/UnitsNet","owner":{"login":"angularsen","id":787816,"node_id":"MDQ6VXNlcjc4NzgxNg==","avatar_url":"https://avatars1.githubusercontent.com/u/787816?v=4","gravatar_id":"","url":"https://api.github.com/users/angularsen","html_url":"https://github.com/angularsen","followers_url":"https://api.github.com/users/angularsen/followers","following_url":"https://api.github.com/users/angularsen/following{/other_user}","gists_url":"https://api.github.com/users/angularsen/gists{/gist_id}","starred_url":"https://api.github.com/users/angularsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angularsen/subscriptions","organizations_url":"https://api.github.com/users/angularsen/orgs","repos_url":"https://api.github.com/users/angularsen/repos","events_url":"https://api.github.com/users/angularsen/events{/privacy}","received_events_url":"https://api.github.com/users/angularsen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/angularsen/UnitsNet","description":"Makes life working with units of measurement just a little bit better.","fork":false,"url":"https://api.github.com/repos/angularsen/UnitsNet","forks_url":"https://api.github.com/repos/angularsen/UnitsNet/forks","keys_url":"https://api.github.com/repos/angularsen/UnitsNet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angularsen/UnitsNet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angularsen/UnitsNet/teams","hooks_url":"https://api.github.com/repos/angularsen/UnitsNet/hooks","issue_events_url":"https://api.github.com/repos/angularsen/UnitsNet/issues/events{/number}","events_url":"https://api.github.com/repos/angularsen/UnitsNet/events","assignees_url":"https://api.github.com/repos/angularsen/UnitsNet/assignees{/user}","branches_url":"https://api.github.com/repos/angularsen/UnitsNet/branches{/branch}","tags_url":"https://api.github.com/repos/angularsen/UnitsNet/tags","blobs_url":"https://api.github.com/repos/angularsen/UnitsNet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angularsen/UnitsNet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angularsen/UnitsNet/git/refs{/sha}","trees_url":"https://api.github.com/repos/angularsen/UnitsNet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angularsen/UnitsNet/statuses/{sha}","languages_url":"https://api.github.com/repos/angularsen/UnitsNet/languages","stargazers_url":"https://api.github.com/repos/angularsen/UnitsNet/stargazers","contributors_url":"https://api.github.com/repos/angularsen/UnitsNet/contributors","subscribers_url":"https://api.github.com/repos/angularsen/UnitsNet/subscribers","subscription_url":"https://api.github.com/repos/angularsen/UnitsNet/subscription","commits_url":"https://api.github.com/repos/angularsen/UnitsNet/commits{/sha}","git_commits_url":"https://api.github.com/repos/angularsen/UnitsNet/git/commits{/sha}","comments_url":"https://api.github.com/repos/angularsen/UnitsNet/comments{/number}","issue_comment_url":"https://api.github.com/repos/angularsen/UnitsNet/issues/comments{/number}","contents_url":"https://api.github.com/repos/angularsen/UnitsNet/contents/{+path}","compare_url":"https://api.github.com/repos/angularsen/UnitsNet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angularsen/UnitsNet/merges","archive_url":"https://api.github.com/repos/angularsen/UnitsNet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angularsen/UnitsNet/downloads","issues_url":"https://api.github.com/repos/angularsen/UnitsNet/issues{/number}","pulls_url":"https://api.github.com/repos/angularsen/UnitsNet/pulls{/number}","milestones_url":"https://api.github.com/repos/angularsen/UnitsNet/milestones{/number}","notifications_url":"https://api.github.com/repos/angularsen/UnitsNet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angularsen/UnitsNet/labels{/name}","releases_url":"https://api.github.com/repos/angularsen/UnitsNet/releases{/id}","deployments_url":"https://api.github.com/repos/angularsen/UnitsNet/deployments","created_at":"2013-07-19T06:00:54Z","updated_at":"2018-06-17T20:20:30Z","pushed_at":"2018-06-19T18:30:37Z","git_url":"git://github.com/angularsen/UnitsNet.git","ssh_url":"git@github.com:angularsen/UnitsNet.git","clone_url":"https://github.com/angularsen/UnitsNet.git","svn_url":"https://github.com/angularsen/UnitsNet","homepage":"https://www.nuget.org/packages/UnitsNet/","size":16713,"stargazers_count":275,"watchers_count":275,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":125,"mirror_url":null,"archived":false,"open_issues_count":25,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":125,"open_issues":25,"watchers":275,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angularsen/UnitsNet/pulls/444"},"html":{"href":"https://github.com/angularsen/UnitsNet/pull/444"},"issue":{"href":"https://api.github.com/repos/angularsen/UnitsNet/issues/444"},"comments":{"href":"https://api.github.com/repos/angularsen/UnitsNet/issues/444/comments"},"review_comments":{"href":"https://api.github.com/repos/angularsen/UnitsNet/pulls/444/comments"},"review_comment":{"href":"https://api.github.com/repos/angularsen/UnitsNet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angularsen/UnitsNet/pulls/444/commits"},"statuses":{"href":"https://api.github.com/repos/angularsen/UnitsNet/statuses/66fa7ee8f175ee4a5011a7e362f73618d33ca813"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"angularsen"}}