{"action":"created","issue":{"url":"https://api.github.com/repos/wirecard/prestashop-ee/issues/35","repository_url":"https://api.github.com/repos/wirecard/prestashop-ee","labels_url":"https://api.github.com/repos/wirecard/prestashop-ee/issues/35/labels{/name}","comments_url":"https://api.github.com/repos/wirecard/prestashop-ee/issues/35/comments","events_url":"https://api.github.com/repos/wirecard/prestashop-ee/issues/35/events","html_url":"https://github.com/wirecard/prestashop-ee/pull/35","id":300067685,"number":35,"title":"#34 Refactored Code to move out of controller","user":{"login":"just-in-m","id":35484291,"avatar_url":"https://avatars3.githubusercontent.com/u/35484291?v=4","gravatar_id":"","url":"https://api.github.com/users/just-in-m","html_url":"https://github.com/just-in-m","followers_url":"https://api.github.com/users/just-in-m/followers","following_url":"https://api.github.com/users/just-in-m/following{/other_user}","gists_url":"https://api.github.com/users/just-in-m/gists{/gist_id}","starred_url":"https://api.github.com/users/just-in-m/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/just-in-m/subscriptions","organizations_url":"https://api.github.com/users/just-in-m/orgs","repos_url":"https://api.github.com/users/just-in-m/repos","events_url":"https://api.github.com/users/just-in-m/events{/privacy}","received_events_url":"https://api.github.com/users/just-in-m/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-02-25T22:25:33Z","updated_at":"2018-03-15T17:27:42Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/wirecard/prestashop-ee/pulls/35","html_url":"https://github.com/wirecard/prestashop-ee/pull/35","diff_url":"https://github.com/wirecard/prestashop-ee/pull/35.diff","patch_url":"https://github.com/wirecard/prestashop-ee/pull/35.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/wirecard/prestashop-ee/issues/comments/373458626","html_url":"https://github.com/wirecard/prestashop-ee/pull/35#issuecomment-373458626","issue_url":"https://api.github.com/repos/wirecard/prestashop-ee/issues/35","id":373458626,"user":{"login":"wirecard-bot","id":19989513,"avatar_url":"https://avatars1.githubusercontent.com/u/19989513?v=4","gravatar_id":"","url":"https://api.github.com/users/wirecard-bot","html_url":"https://github.com/wirecard-bot","followers_url":"https://api.github.com/users/wirecard-bot/followers","following_url":"https://api.github.com/users/wirecard-bot/following{/other_user}","gists_url":"https://api.github.com/users/wirecard-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/wirecard-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wirecard-bot/subscriptions","organizations_url":"https://api.github.com/users/wirecard-bot/orgs","repos_url":"https://api.github.com/users/wirecard-bot/repos","events_url":"https://api.github.com/users/wirecard-bot/events{/privacy}","received_events_url":"https://api.github.com/users/wirecard-bot/received_events","type":"User","site_admin":false},"created_at":"2018-03-15T17:27:41Z","updated_at":"2018-03-15T17:27:41Z","author_association":"COLLABORATOR","body":"SonarQube analysis reported 78 issues\n* ![CRITICAL][CRITICAL] 48 critical\n* ![MAJOR][MAJOR] 13 major\n* ![MINOR][MINOR] 10 minor\n* ![INFO][INFO] 7 info\n\nWatch the comments in this conversation to review them.\n\n#### 6 extra issues\n\nNote: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:\n\n1. ![CRITICAL][CRITICAL] [ajax.php#L47](https://github.com/wirecard/prestashop-ee/blob/86197bd1860445c2359364dc278ae0991b1d9b8c/wirecardpaymentgateway/Controllers/Front/ajax.php#L47): Add a \"case default\" clause to this \"switch\" statement. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonarcloud.io/coding_rules#rule_key=php%3AS131)\n1. ![CRITICAL][CRITICAL] [wirecardpaymentgateway.php#L301](https://github.com/wirecard/prestashop-ee/blob/86197bd1860445c2359364dc278ae0991b1d9b8c/wirecardpaymentgateway/wirecardpaymentgateway.php#L301): Define a constant instead of duplicating this literal \"linkbutton\" 7 times. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonarcloud.io/coding_rules#rule_key=php%3AS1192)\n1. ![MAJOR][MAJOR] [ajax.php#L39](https://github.com/wirecard/prestashop-ee/blob/86197bd1860445c2359364dc278ae0991b1d9b8c/wirecardpaymentgateway/Controllers/Front/ajax.php#L39): Remove this unused \"$config\" private field. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonarcloud.io/coding_rules#rule_key=php%3AS1068)\n1. ![MAJOR][MAJOR] [ajax.php#L56](https://github.com/wirecard/prestashop-ee/blob/86197bd1860445c2359364dc278ae0991b1d9b8c/wirecardpaymentgateway/Controllers/Front/ajax.php#L56): Rename \"$config\" which has the same name as the field declared at line 39. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonarcloud.io/coding_rules#rule_key=php%3AS1117)\n1. ![MAJOR][MAJOR] [wirecardpaymentgateway.php#L225](https://github.com/wirecard/prestashop-ee/blob/86197bd1860445c2359364dc278ae0991b1d9b8c/wirecardpaymentgateway/wirecardpaymentgateway.php#L225): This function \"config\" has 561 lines, which is greater than the 150 lines authorized. Split it into smaller functions. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonarcloud.io/coding_rules#rule_key=php%3AS138)\n1. ![MINOR][MINOR] [ajax.php#L47](https://github.com/wirecard/prestashop-ee/blob/86197bd1860445c2359364dc278ae0991b1d9b8c/wirecardpaymentgateway/Controllers/Front/ajax.php#L47): Replace this \"switch\" statement with \"if\" statements to increase readability. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonarcloud.io/coding_rules#rule_key=php%3AS1301)\n\n[CRITICAL]: https://sonarsource.github.io/sonar-github/severity-critical.png 'Severity: CRITICAL'\n[INFO]: https://sonarsource.github.io/sonar-github/severity-info.png 'Severity: INFO'\n[MAJOR]: https://sonarsource.github.io/sonar-github/severity-major.png 'Severity: MAJOR'\n[MINOR]: https://sonarsource.github.io/sonar-github/severity-minor.png 'Severity: MINOR'"}}
{"actor":{"display_login":"wirecard-bot"}}