{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-mxnet/pulls/comments/179672250","pull_request_review_id":109960406,"id":179672250,"diff_hunk":"@@ -102,6 +103,11 @@\n _NDARRAY_BASIC_INDEXING = 0\n _NDARRAY_ADVANCED_INDEXING = 1\n \n+if sys.version_info[0] == 3:\n+    _index_types = (int, np.int32, np.int64)","path":"python/mxnet/ndarray/ndarray.py","position":null,"original_position":20,"commit_id":"14535ccbe639354f6258b4b7198c2f34fd64c33a","original_commit_id":"fdae6b4c69d2a70190a2829619936e7d1cd7450e","user":{"login":"reminisce","id":4978794,"avatar_url":"https://avatars1.githubusercontent.com/u/4978794?v=4","gravatar_id":"","url":"https://api.github.com/users/reminisce","html_url":"https://github.com/reminisce","followers_url":"https://api.github.com/users/reminisce/followers","following_url":"https://api.github.com/users/reminisce/following{/other_user}","gists_url":"https://api.github.com/users/reminisce/gists{/gist_id}","starred_url":"https://api.github.com/users/reminisce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reminisce/subscriptions","organizations_url":"https://api.github.com/users/reminisce/orgs","repos_url":"https://api.github.com/users/reminisce/repos","events_url":"https://api.github.com/users/reminisce/events{/privacy}","received_events_url":"https://api.github.com/users/reminisce/received_events","type":"User","site_admin":false},"body":"sparse is using integer_types and I was afraid this change would break the use case there. Anyway, I finally removed this `_index_types` and added `np.int32` and `np.int64` directly to `integer_types`. Unit test for sparse use case is also added.","created_at":"2018-04-06T06:45:30Z","updated_at":"2018-04-06T06:45:30Z","html_url":"https://github.com/apache/incubator-mxnet/pull/10434#discussion_r179672250","pull_request_url":"https://api.github.com/repos/apache/incubator-mxnet/pulls/10434","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-mxnet/pulls/comments/179672250"},"html":{"href":"https://github.com/apache/incubator-mxnet/pull/10434#discussion_r179672250"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-mxnet/pulls/10434"}},"in_reply_to_id":179665498},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-mxnet/pulls/10434","id":179858637,"html_url":"https://github.com/apache/incubator-mxnet/pull/10434","diff_url":"https://github.com/apache/incubator-mxnet/pull/10434.diff","patch_url":"https://github.com/apache/incubator-mxnet/pull/10434.patch","issue_url":"https://api.github.com/repos/apache/incubator-mxnet/issues/10434","number":10434,"state":"open","locked":false,"title":"[MXNET-155] Add support for np.int32 and np.int64 as basic index types","user":{"login":"reminisce","id":4978794,"avatar_url":"https://avatars1.githubusercontent.com/u/4978794?v=4","gravatar_id":"","url":"https://api.github.com/users/reminisce","html_url":"https://github.com/reminisce","followers_url":"https://api.github.com/users/reminisce/followers","following_url":"https://api.github.com/users/reminisce/following{/other_user}","gists_url":"https://api.github.com/users/reminisce/gists{/gist_id}","starred_url":"https://api.github.com/users/reminisce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reminisce/subscriptions","organizations_url":"https://api.github.com/users/reminisce/orgs","repos_url":"https://api.github.com/users/reminisce/repos","events_url":"https://api.github.com/users/reminisce/events{/privacy}","received_events_url":"https://api.github.com/users/reminisce/received_events","type":"User","site_admin":false},"body":"## Description ##\r\nSupport np.int32 and np.int64 as basic index types. Those types were not defined as index types previously.\r\n\r\nIssue#: https://github.com/apache/incubator-mxnet/issues/9772\r\n\r\n## Checklist ##\r\n### Essentials ###\r\nPlease feel free to remove inapplicable items for your PR.\r\n- [x] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) created (except PRs with tiny changes)\r\n- [x] Changes are complete (i.e. I finished coding on this PR)\r\n- [x] All changes have test coverage:\r\n- Unit tests are added for small changes to verify correctness (e.g. adding a new operator)\r\n- Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)\r\n- Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)\r\n- [ ] Code is well-documented: \r\n- For user-facing API changes, API doc string has been updated. \r\n- For new C++ functions in header files, their functionalities and arguments are documented. \r\n- For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable\r\n- Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html\r\n- [x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change\r\n\r\n### Changes ###\r\n- [ ] Feature1, tests, (and when applicable, API doc)\r\n- [ ] Feature2, tests, (and when applicable, API doc)\r\n\r\n## Comments ##\r\n- If this change is a backward incompatible change, why must this change be made.\r\n- Interesting edge cases to note here\r\n","created_at":"2018-04-06T05:38:41Z","updated_at":"2018-04-06T06:45:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eb03df6950e8e296622590f25028783e2d750156","assignee":null,"assignees":[],"requested_reviewers":[{"login":"szha","id":2626883,"avatar_url":"https://avatars2.githubusercontent.com/u/2626883?v=4","gravatar_id":"","url":"https://api.github.com/users/szha","html_url":"https://github.com/szha","followers_url":"https://api.github.com/users/szha/followers","following_url":"https://api.github.com/users/szha/following{/other_user}","gists_url":"https://api.github.com/users/szha/gists{/gist_id}","starred_url":"https://api.github.com/users/szha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szha/subscriptions","organizations_url":"https://api.github.com/users/szha/orgs","repos_url":"https://api.github.com/users/szha/repos","events_url":"https://api.github.com/users/szha/events{/privacy}","received_events_url":"https://api.github.com/users/szha/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-mxnet/pulls/10434/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-mxnet/pulls/10434/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-mxnet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-mxnet/issues/10434/comments","statuses_url":"https://api.github.com/repos/apache/incubator-mxnet/statuses/14535ccbe639354f6258b4b7198c2f34fd64c33a","head":{"label":"reminisce:support_np_int_basic_index","ref":"support_np_int_basic_index","sha":"14535ccbe639354f6258b4b7198c2f34fd64c33a","user":{"login":"reminisce","id":4978794,"avatar_url":"https://avatars1.githubusercontent.com/u/4978794?v=4","gravatar_id":"","url":"https://api.github.com/users/reminisce","html_url":"https://github.com/reminisce","followers_url":"https://api.github.com/users/reminisce/followers","following_url":"https://api.github.com/users/reminisce/following{/other_user}","gists_url":"https://api.github.com/users/reminisce/gists{/gist_id}","starred_url":"https://api.github.com/users/reminisce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reminisce/subscriptions","organizations_url":"https://api.github.com/users/reminisce/orgs","repos_url":"https://api.github.com/users/reminisce/repos","events_url":"https://api.github.com/users/reminisce/events{/privacy}","received_events_url":"https://api.github.com/users/reminisce/received_events","type":"User","site_admin":false},"repo":{"id":79397572,"name":"mxnet","full_name":"reminisce/mxnet","owner":{"login":"reminisce","id":4978794,"avatar_url":"https://avatars1.githubusercontent.com/u/4978794?v=4","gravatar_id":"","url":"https://api.github.com/users/reminisce","html_url":"https://github.com/reminisce","followers_url":"https://api.github.com/users/reminisce/followers","following_url":"https://api.github.com/users/reminisce/following{/other_user}","gists_url":"https://api.github.com/users/reminisce/gists{/gist_id}","starred_url":"https://api.github.com/users/reminisce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reminisce/subscriptions","organizations_url":"https://api.github.com/users/reminisce/orgs","repos_url":"https://api.github.com/users/reminisce/repos","events_url":"https://api.github.com/users/reminisce/events{/privacy}","received_events_url":"https://api.github.com/users/reminisce/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/reminisce/mxnet","description":"Lightweight, Portable, Flexible Distributed/Mobile Deep Learning with Dynamic, Mutation-aware Dataflow Dep Scheduler; for Python, R, Julia, Scala, Go, Javascript and more","fork":true,"url":"https://api.github.com/repos/reminisce/mxnet","forks_url":"https://api.github.com/repos/reminisce/mxnet/forks","keys_url":"https://api.github.com/repos/reminisce/mxnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reminisce/mxnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reminisce/mxnet/teams","hooks_url":"https://api.github.com/repos/reminisce/mxnet/hooks","issue_events_url":"https://api.github.com/repos/reminisce/mxnet/issues/events{/number}","events_url":"https://api.github.com/repos/reminisce/mxnet/events","assignees_url":"https://api.github.com/repos/reminisce/mxnet/assignees{/user}","branches_url":"https://api.github.com/repos/reminisce/mxnet/branches{/branch}","tags_url":"https://api.github.com/repos/reminisce/mxnet/tags","blobs_url":"https://api.github.com/repos/reminisce/mxnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reminisce/mxnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reminisce/mxnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/reminisce/mxnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reminisce/mxnet/statuses/{sha}","languages_url":"https://api.github.com/repos/reminisce/mxnet/languages","stargazers_url":"https://api.github.com/repos/reminisce/mxnet/stargazers","contributors_url":"https://api.github.com/repos/reminisce/mxnet/contributors","subscribers_url":"https://api.github.com/repos/reminisce/mxnet/subscribers","subscription_url":"https://api.github.com/repos/reminisce/mxnet/subscription","commits_url":"https://api.github.com/repos/reminisce/mxnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/reminisce/mxnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/reminisce/mxnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/reminisce/mxnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/reminisce/mxnet/contents/{+path}","compare_url":"https://api.github.com/repos/reminisce/mxnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reminisce/mxnet/merges","archive_url":"https://api.github.com/repos/reminisce/mxnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reminisce/mxnet/downloads","issues_url":"https://api.github.com/repos/reminisce/mxnet/issues{/number}","pulls_url":"https://api.github.com/repos/reminisce/mxnet/pulls{/number}","milestones_url":"https://api.github.com/repos/reminisce/mxnet/milestones{/number}","notifications_url":"https://api.github.com/repos/reminisce/mxnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reminisce/mxnet/labels{/name}","releases_url":"https://api.github.com/repos/reminisce/mxnet/releases{/id}","deployments_url":"https://api.github.com/repos/reminisce/mxnet/deployments","created_at":"2017-01-19T00:07:24Z","updated_at":"2018-03-12T21:10:06Z","pushed_at":"2018-04-06T06:42:10Z","git_url":"git://github.com/reminisce/mxnet.git","ssh_url":"git@github.com:reminisce/mxnet.git","clone_url":"https://github.com/reminisce/mxnet.git","svn_url":"https://github.com/reminisce/mxnet","homepage":"http://mxnet.io","size":37373,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":3,"open_issues":2,"watchers":1,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"c3a6f19b55b2048e4326645979655597b6c39dbe","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":34864402,"name":"incubator-mxnet","full_name":"apache/incubator-mxnet","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-mxnet","description":"Lightweight, Portable, Flexible Distributed/Mobile Deep Learning with Dynamic, Mutation-aware Dataflow Dep Scheduler; for Python, R, Julia, Scala, Go, Javascript and more","fork":false,"url":"https://api.github.com/repos/apache/incubator-mxnet","forks_url":"https://api.github.com/repos/apache/incubator-mxnet/forks","keys_url":"https://api.github.com/repos/apache/incubator-mxnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-mxnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-mxnet/teams","hooks_url":"https://api.github.com/repos/apache/incubator-mxnet/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-mxnet/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-mxnet/events","assignees_url":"https://api.github.com/repos/apache/incubator-mxnet/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-mxnet/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-mxnet/tags","blobs_url":"https://api.github.com/repos/apache/incubator-mxnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-mxnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-mxnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-mxnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-mxnet/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-mxnet/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-mxnet/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-mxnet/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-mxnet/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-mxnet/subscription","commits_url":"https://api.github.com/repos/apache/incubator-mxnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-mxnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-mxnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-mxnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-mxnet/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-mxnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-mxnet/merges","archive_url":"https://api.github.com/repos/apache/incubator-mxnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-mxnet/downloads","issues_url":"https://api.github.com/repos/apache/incubator-mxnet/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-mxnet/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-mxnet/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-mxnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-mxnet/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-mxnet/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-mxnet/deployments","created_at":"2015-04-30T16:21:15Z","updated_at":"2018-04-06T05:52:09Z","pushed_at":"2018-04-06T06:42:12Z","git_url":"git://github.com/apache/incubator-mxnet.git","ssh_url":"git@github.com:apache/incubator-mxnet.git","clone_url":"https://github.com/apache/incubator-mxnet.git","svn_url":"https://github.com/apache/incubator-mxnet","homepage":"http://mxnet.io","size":34773,"stargazers_count":13588,"watchers_count":13588,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5021,"mirror_url":null,"archived":false,"open_issues_count":869,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":5021,"open_issues":869,"watchers":13588,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-mxnet/pulls/10434"},"html":{"href":"https://github.com/apache/incubator-mxnet/pull/10434"},"issue":{"href":"https://api.github.com/repos/apache/incubator-mxnet/issues/10434"},"comments":{"href":"https://api.github.com/repos/apache/incubator-mxnet/issues/10434/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-mxnet/pulls/10434/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-mxnet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-mxnet/pulls/10434/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-mxnet/statuses/14535ccbe639354f6258b4b7198c2f34fd64c33a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"reminisce"}}