{"action":"created","comment":{"url":"https://api.github.com/repos/pytorch/glow/pulls/comments/201185837","pull_request_review_id":135637596,"id":201185837,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTE4NTgzNw==","diff_hunk":"@@ -2190,13 +2195,24 @@ TEST_P(InterpAndCPU, NonSquarePaddingConvolution) {\n       IH1.at({0, i, j, 0}) = i * 4 + j - 2 + 1;\n     }\n \n-  CN = F_->createConv(\"Conv1\", input1, filter, zeroBias, outTy, 2, 1,\n-                      {0, 0, 0, 0}, 1);\n-  S = F_->createSave(\"save1\", CN);\n-  EE_.compile(CompilationMode::Infer, F_);\n+  auto filter1 =","path":"tests/unittests/OperatorTest.cpp","position":29,"original_position":29,"commit_id":"d2a15016587c4e11f0694ced32622b46c5b607b8","original_commit_id":"d2a15016587c4e11f0694ced32622b46c5b607b8","user":{"login":"opti-mix","id":33707249,"node_id":"MDQ6VXNlcjMzNzA3MjQ5","avatar_url":"https://avatars3.githubusercontent.com/u/33707249?v=4","gravatar_id":"","url":"https://api.github.com/users/opti-mix","html_url":"https://github.com/opti-mix","followers_url":"https://api.github.com/users/opti-mix/followers","following_url":"https://api.github.com/users/opti-mix/following{/other_user}","gists_url":"https://api.github.com/users/opti-mix/gists{/gist_id}","starred_url":"https://api.github.com/users/opti-mix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opti-mix/subscriptions","organizations_url":"https://api.github.com/users/opti-mix/orgs","repos_url":"https://api.github.com/users/opti-mix/repos","events_url":"https://api.github.com/users/opti-mix/events{/privacy}","received_events_url":"https://api.github.com/users/opti-mix/received_events","type":"User","site_admin":false},"body":"> For OpenCL, there is an optimization (forget which one, need to re-check it :P) makes the var \"filter\" to be an unused var and deleted.\r\n\r\nI'd be interested to hear what optimization does this. AFAIK, there are no OpenCL-specific optimizations except for Transforms.cpp, which changes the layout from NHWC to NCWH for convolutions and pooling operators.","created_at":"2018-07-10T00:17:16Z","updated_at":"2018-07-10T00:17:16Z","html_url":"https://github.com/pytorch/glow/pull/1221#discussion_r201185837","pull_request_url":"https://api.github.com/repos/pytorch/glow/pulls/1221","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pytorch/glow/pulls/comments/201185837"},"html":{"href":"https://github.com/pytorch/glow/pull/1221#discussion_r201185837"},"pull_request":{"href":"https://api.github.com/repos/pytorch/glow/pulls/1221"}},"in_reply_to_id":201158017},"pull_request":{"url":"https://api.github.com/repos/pytorch/glow/pulls/1221","id":199610575,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5NjEwNTc1","html_url":"https://github.com/pytorch/glow/pull/1221","diff_url":"https://github.com/pytorch/glow/pull/1221.diff","patch_url":"https://github.com/pytorch/glow/pull/1221.patch","issue_url":"https://api.github.com/repos/pytorch/glow/issues/1221","number":1221,"state":"open","locked":false,"title":"Non-Square padding for OpenCL backend","user":{"login":"beicy","id":37386895,"node_id":"MDQ6VXNlcjM3Mzg2ODk1","avatar_url":"https://avatars0.githubusercontent.com/u/37386895?v=4","gravatar_id":"","url":"https://api.github.com/users/beicy","html_url":"https://github.com/beicy","followers_url":"https://api.github.com/users/beicy/followers","following_url":"https://api.github.com/users/beicy/following{/other_user}","gists_url":"https://api.github.com/users/beicy/gists{/gist_id}","starred_url":"https://api.github.com/users/beicy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beicy/subscriptions","organizations_url":"https://api.github.com/users/beicy/orgs","repos_url":"https://api.github.com/users/beicy/repos","events_url":"https://api.github.com/users/beicy/events{/privacy}","received_events_url":"https://api.github.com/users/beicy/received_events","type":"User","site_admin":false},"body":"So far, the first half of the output values are correct, but the rest are all zero. The test is NonSquarePaddingConvolution in OperatorTest.cpp","created_at":"2018-07-05T23:24:27Z","updated_at":"2018-07-10T00:17:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"01e4a6244cc80d3ae7955f6d1d3c14be8d2eabf2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":706497924,"node_id":"MDU6TGFiZWw3MDY0OTc5MjQ=","url":"https://api.github.com/repos/pytorch/glow/labels/CLA%20Signed","name":"CLA Signed","color":"009900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/pytorch/glow/pulls/1221/commits","review_comments_url":"https://api.github.com/repos/pytorch/glow/pulls/1221/comments","review_comment_url":"https://api.github.com/repos/pytorch/glow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pytorch/glow/issues/1221/comments","statuses_url":"https://api.github.com/repos/pytorch/glow/statuses/d2a15016587c4e11f0694ced32622b46c5b607b8","head":{"label":"beicy:PaddingOpenCL","ref":"PaddingOpenCL","sha":"d2a15016587c4e11f0694ced32622b46c5b607b8","user":{"login":"beicy","id":37386895,"node_id":"MDQ6VXNlcjM3Mzg2ODk1","avatar_url":"https://avatars0.githubusercontent.com/u/37386895?v=4","gravatar_id":"","url":"https://api.github.com/users/beicy","html_url":"https://github.com/beicy","followers_url":"https://api.github.com/users/beicy/followers","following_url":"https://api.github.com/users/beicy/following{/other_user}","gists_url":"https://api.github.com/users/beicy/gists{/gist_id}","starred_url":"https://api.github.com/users/beicy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beicy/subscriptions","organizations_url":"https://api.github.com/users/beicy/orgs","repos_url":"https://api.github.com/users/beicy/repos","events_url":"https://api.github.com/users/beicy/events{/privacy}","received_events_url":"https://api.github.com/users/beicy/received_events","type":"User","site_admin":false},"repo":{"id":132027958,"node_id":"MDEwOlJlcG9zaXRvcnkxMzIwMjc5NTg=","name":"glow","full_name":"beicy/glow","owner":{"login":"beicy","id":37386895,"node_id":"MDQ6VXNlcjM3Mzg2ODk1","avatar_url":"https://avatars0.githubusercontent.com/u/37386895?v=4","gravatar_id":"","url":"https://api.github.com/users/beicy","html_url":"https://github.com/beicy","followers_url":"https://api.github.com/users/beicy/followers","following_url":"https://api.github.com/users/beicy/following{/other_user}","gists_url":"https://api.github.com/users/beicy/gists{/gist_id}","starred_url":"https://api.github.com/users/beicy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beicy/subscriptions","organizations_url":"https://api.github.com/users/beicy/orgs","repos_url":"https://api.github.com/users/beicy/repos","events_url":"https://api.github.com/users/beicy/events{/privacy}","received_events_url":"https://api.github.com/users/beicy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/beicy/glow","description":"Compiler for Neural Network hardware accelerators","fork":true,"url":"https://api.github.com/repos/beicy/glow","forks_url":"https://api.github.com/repos/beicy/glow/forks","keys_url":"https://api.github.com/repos/beicy/glow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/beicy/glow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/beicy/glow/teams","hooks_url":"https://api.github.com/repos/beicy/glow/hooks","issue_events_url":"https://api.github.com/repos/beicy/glow/issues/events{/number}","events_url":"https://api.github.com/repos/beicy/glow/events","assignees_url":"https://api.github.com/repos/beicy/glow/assignees{/user}","branches_url":"https://api.github.com/repos/beicy/glow/branches{/branch}","tags_url":"https://api.github.com/repos/beicy/glow/tags","blobs_url":"https://api.github.com/repos/beicy/glow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/beicy/glow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/beicy/glow/git/refs{/sha}","trees_url":"https://api.github.com/repos/beicy/glow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/beicy/glow/statuses/{sha}","languages_url":"https://api.github.com/repos/beicy/glow/languages","stargazers_url":"https://api.github.com/repos/beicy/glow/stargazers","contributors_url":"https://api.github.com/repos/beicy/glow/contributors","subscribers_url":"https://api.github.com/repos/beicy/glow/subscribers","subscription_url":"https://api.github.com/repos/beicy/glow/subscription","commits_url":"https://api.github.com/repos/beicy/glow/commits{/sha}","git_commits_url":"https://api.github.com/repos/beicy/glow/git/commits{/sha}","comments_url":"https://api.github.com/repos/beicy/glow/comments{/number}","issue_comment_url":"https://api.github.com/repos/beicy/glow/issues/comments{/number}","contents_url":"https://api.github.com/repos/beicy/glow/contents/{+path}","compare_url":"https://api.github.com/repos/beicy/glow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/beicy/glow/merges","archive_url":"https://api.github.com/repos/beicy/glow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/beicy/glow/downloads","issues_url":"https://api.github.com/repos/beicy/glow/issues{/number}","pulls_url":"https://api.github.com/repos/beicy/glow/pulls{/number}","milestones_url":"https://api.github.com/repos/beicy/glow/milestones{/number}","notifications_url":"https://api.github.com/repos/beicy/glow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/beicy/glow/labels{/name}","releases_url":"https://api.github.com/repos/beicy/glow/releases{/id}","deployments_url":"https://api.github.com/repos/beicy/glow/deployments","created_at":"2018-05-03T17:23:58Z","updated_at":"2018-05-07T22:51:35Z","pushed_at":"2018-07-09T20:31:05Z","git_url":"git://github.com/beicy/glow.git","ssh_url":"git@github.com:beicy/glow.git","clone_url":"https://github.com/beicy/glow.git","svn_url":"https://github.com/beicy/glow","homepage":null,"size":6647,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pytorch:master","ref":"master","sha":"45abbe88906be3eeaf9ace788fa479110d7724f0","user":{"login":"pytorch","id":21003710,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDAzNzEw","avatar_url":"https://avatars3.githubusercontent.com/u/21003710?v=4","gravatar_id":"","url":"https://api.github.com/users/pytorch","html_url":"https://github.com/pytorch","followers_url":"https://api.github.com/users/pytorch/followers","following_url":"https://api.github.com/users/pytorch/following{/other_user}","gists_url":"https://api.github.com/users/pytorch/gists{/gist_id}","starred_url":"https://api.github.com/users/pytorch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytorch/subscriptions","organizations_url":"https://api.github.com/users/pytorch/orgs","repos_url":"https://api.github.com/users/pytorch/repos","events_url":"https://api.github.com/users/pytorch/events{/privacy}","received_events_url":"https://api.github.com/users/pytorch/received_events","type":"Organization","site_admin":false},"repo":{"id":105281531,"node_id":"MDEwOlJlcG9zaXRvcnkxMDUyODE1MzE=","name":"glow","full_name":"pytorch/glow","owner":{"login":"pytorch","id":21003710,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDAzNzEw","avatar_url":"https://avatars3.githubusercontent.com/u/21003710?v=4","gravatar_id":"","url":"https://api.github.com/users/pytorch","html_url":"https://github.com/pytorch","followers_url":"https://api.github.com/users/pytorch/followers","following_url":"https://api.github.com/users/pytorch/following{/other_user}","gists_url":"https://api.github.com/users/pytorch/gists{/gist_id}","starred_url":"https://api.github.com/users/pytorch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytorch/subscriptions","organizations_url":"https://api.github.com/users/pytorch/orgs","repos_url":"https://api.github.com/users/pytorch/repos","events_url":"https://api.github.com/users/pytorch/events{/privacy}","received_events_url":"https://api.github.com/users/pytorch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pytorch/glow","description":"Compiler for Neural Network hardware accelerators","fork":false,"url":"https://api.github.com/repos/pytorch/glow","forks_url":"https://api.github.com/repos/pytorch/glow/forks","keys_url":"https://api.github.com/repos/pytorch/glow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pytorch/glow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pytorch/glow/teams","hooks_url":"https://api.github.com/repos/pytorch/glow/hooks","issue_events_url":"https://api.github.com/repos/pytorch/glow/issues/events{/number}","events_url":"https://api.github.com/repos/pytorch/glow/events","assignees_url":"https://api.github.com/repos/pytorch/glow/assignees{/user}","branches_url":"https://api.github.com/repos/pytorch/glow/branches{/branch}","tags_url":"https://api.github.com/repos/pytorch/glow/tags","blobs_url":"https://api.github.com/repos/pytorch/glow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pytorch/glow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pytorch/glow/git/refs{/sha}","trees_url":"https://api.github.com/repos/pytorch/glow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pytorch/glow/statuses/{sha}","languages_url":"https://api.github.com/repos/pytorch/glow/languages","stargazers_url":"https://api.github.com/repos/pytorch/glow/stargazers","contributors_url":"https://api.github.com/repos/pytorch/glow/contributors","subscribers_url":"https://api.github.com/repos/pytorch/glow/subscribers","subscription_url":"https://api.github.com/repos/pytorch/glow/subscription","commits_url":"https://api.github.com/repos/pytorch/glow/commits{/sha}","git_commits_url":"https://api.github.com/repos/pytorch/glow/git/commits{/sha}","comments_url":"https://api.github.com/repos/pytorch/glow/comments{/number}","issue_comment_url":"https://api.github.com/repos/pytorch/glow/issues/comments{/number}","contents_url":"https://api.github.com/repos/pytorch/glow/contents/{+path}","compare_url":"https://api.github.com/repos/pytorch/glow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pytorch/glow/merges","archive_url":"https://api.github.com/repos/pytorch/glow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pytorch/glow/downloads","issues_url":"https://api.github.com/repos/pytorch/glow/issues{/number}","pulls_url":"https://api.github.com/repos/pytorch/glow/pulls{/number}","milestones_url":"https://api.github.com/repos/pytorch/glow/milestones{/number}","notifications_url":"https://api.github.com/repos/pytorch/glow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pytorch/glow/labels{/name}","releases_url":"https://api.github.com/repos/pytorch/glow/releases{/id}","deployments_url":"https://api.github.com/repos/pytorch/glow/deployments","created_at":"2017-09-29T14:28:18Z","updated_at":"2018-07-10T00:14:38Z","pushed_at":"2018-07-10T00:14:35Z","git_url":"git://github.com/pytorch/glow.git","ssh_url":"git@github.com:pytorch/glow.git","clone_url":"https://github.com/pytorch/glow.git","svn_url":"https://github.com/pytorch/glow","homepage":null,"size":6646,"stargazers_count":641,"watchers_count":641,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":65,"mirror_url":null,"archived":false,"open_issues_count":35,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":65,"open_issues":35,"watchers":641,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pytorch/glow/pulls/1221"},"html":{"href":"https://github.com/pytorch/glow/pull/1221"},"issue":{"href":"https://api.github.com/repos/pytorch/glow/issues/1221"},"comments":{"href":"https://api.github.com/repos/pytorch/glow/issues/1221/comments"},"review_comments":{"href":"https://api.github.com/repos/pytorch/glow/pulls/1221/comments"},"review_comment":{"href":"https://api.github.com/repos/pytorch/glow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pytorch/glow/pulls/1221/commits"},"statuses":{"href":"https://api.github.com/repos/pytorch/glow/statuses/d2a15016587c4e11f0694ced32622b46c5b607b8"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"opti-mix"}}