{"action":"created","issue":{"url":"https://api.github.com/repos/zeppelinos/zos-cli/issues/68","repository_url":"https://api.github.com/repos/zeppelinos/zos-cli","labels_url":"https://api.github.com/repos/zeppelinos/zos-cli/issues/68/labels{/name}","comments_url":"https://api.github.com/repos/zeppelinos/zos-cli/issues/68/comments","events_url":"https://api.github.com/repos/zeppelinos/zos-cli/issues/68/events","html_url":"https://github.com/zeppelinos/zos-cli/pull/68","id":319909511,"number":68,"title":"Remove testing circumvents from models","user":{"login":"facuspagnuolo","id":6967192,"avatar_url":"https://avatars1.githubusercontent.com/u/6967192?v=4","gravatar_id":"","url":"https://api.github.com/users/facuspagnuolo","html_url":"https://github.com/facuspagnuolo","followers_url":"https://api.github.com/users/facuspagnuolo/followers","following_url":"https://api.github.com/users/facuspagnuolo/following{/other_user}","gists_url":"https://api.github.com/users/facuspagnuolo/gists{/gist_id}","starred_url":"https://api.github.com/users/facuspagnuolo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facuspagnuolo/subscriptions","organizations_url":"https://api.github.com/users/facuspagnuolo/orgs","repos_url":"https://api.github.com/users/facuspagnuolo/repos","events_url":"https://api.github.com/users/facuspagnuolo/events{/privacy}","received_events_url":"https://api.github.com/users/facuspagnuolo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-05-03T12:57:57Z","updated_at":"2018-05-03T15:19:56Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/zeppelinos/zos-cli/pulls/68","html_url":"https://github.com/zeppelinos/zos-cli/pull/68","diff_url":"https://github.com/zeppelinos/zos-cli/pull/68.diff","patch_url":"https://github.com/zeppelinos/zos-cli/pull/68.patch"},"body":"**MERGE AFTER #67** (change base branch to the [refactor branch](https://github.com/zeppelinos/zos-cli/tree/refactor_branch) before merging)\r\n\r\nThis PR removes all the testing circumvents from models.\r\nThe way I did this is to provide a general testing setup function. Said function is in charge of stubbing, handling logs, etc."},"comment":{"url":"https://api.github.com/repos/zeppelinos/zos-cli/issues/comments/386332591","html_url":"https://github.com/zeppelinos/zos-cli/pull/68#issuecomment-386332591","issue_url":"https://api.github.com/repos/zeppelinos/zos-cli/issues/68","id":386332591,"user":{"login":"spalladino","id":429604,"avatar_url":"https://avatars2.githubusercontent.com/u/429604?v=4","gravatar_id":"","url":"https://api.github.com/users/spalladino","html_url":"https://github.com/spalladino","followers_url":"https://api.github.com/users/spalladino/followers","following_url":"https://api.github.com/users/spalladino/following{/other_user}","gists_url":"https://api.github.com/users/spalladino/gists{/gist_id}","starred_url":"https://api.github.com/users/spalladino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spalladino/subscriptions","organizations_url":"https://api.github.com/users/spalladino/orgs","repos_url":"https://api.github.com/users/spalladino/repos","events_url":"https://api.github.com/users/spalladino/events{/privacy}","received_events_url":"https://api.github.com/users/spalladino/received_events","type":"User","site_admin":false},"created_at":"2018-05-03T15:19:56Z","updated_at":"2018-05-03T15:19:56Z","author_association":"OWNER","body":"Nice! I really like moving test-logic outside of the models themselves. However, I'm not sure I like overwriting the `contract` main function for testing. \r\n\r\nHow about moving the stubbing logic to a file required as a [--file](https://mochajs.org/#--file-file) in [mocha.opts](https://mochajs.org/#mochaopts)? I believe it should work regardless of truffle."}}
{"actor":{"display_login":"spalladino"}}