{"action":"created","issue":{"url":"https://api.github.com/repos/OSGP/Protocol-Adapter-OSLP/issues/108","repository_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-OSLP","labels_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-OSLP/issues/108/labels{/name}","comments_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-OSLP/issues/108/comments","events_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-OSLP/issues/108/events","html_url":"https://github.com/OSGP/Protocol-Adapter-OSLP/pull/108","id":308948940,"number":108,"title":"FLEX-4205 ~ Implements basic behavior for SetTransitionRequest for web-device-simulator.","user":{"login":"kevinsmeets","id":11557950,"avatar_url":"https://avatars1.githubusercontent.com/u/11557950?v=4","gravatar_id":"","url":"https://api.github.com/users/kevinsmeets","html_url":"https://github.com/kevinsmeets","followers_url":"https://api.github.com/users/kevinsmeets/followers","following_url":"https://api.github.com/users/kevinsmeets/following{/other_user}","gists_url":"https://api.github.com/users/kevinsmeets/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinsmeets/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinsmeets/subscriptions","organizations_url":"https://api.github.com/users/kevinsmeets/orgs","repos_url":"https://api.github.com/users/kevinsmeets/repos","events_url":"https://api.github.com/users/kevinsmeets/events{/privacy}","received_events_url":"https://api.github.com/users/kevinsmeets/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-03-27T12:32:41Z","updated_at":"2018-03-27T12:38:27Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/OSGP/Protocol-Adapter-OSLP/pulls/108","html_url":"https://github.com/OSGP/Protocol-Adapter-OSLP/pull/108","diff_url":"https://github.com/OSGP/Protocol-Adapter-OSLP/pull/108.diff","patch_url":"https://github.com/OSGP/Protocol-Adapter-OSLP/pull/108.patch"},"body":"Use the transition type to determine if the relay should be switched on or off. Assume that the simulated device is running a 'normal' light schedule, meaning that the light is on during the night and off during the day."},"comment":{"url":"https://api.github.com/repos/OSGP/Protocol-Adapter-OSLP/issues/comments/376509307","html_url":"https://github.com/OSGP/Protocol-Adapter-OSLP/pull/108#issuecomment-376509307","issue_url":"https://api.github.com/repos/OSGP/Protocol-Adapter-OSLP/issues/108","id":376509307,"user":{"login":"jenkins-ip-10-4-24-184","id":12208121,"avatar_url":"https://avatars1.githubusercontent.com/u/12208121?v=4","gravatar_id":"","url":"https://api.github.com/users/jenkins-ip-10-4-24-184","html_url":"https://github.com/jenkins-ip-10-4-24-184","followers_url":"https://api.github.com/users/jenkins-ip-10-4-24-184/followers","following_url":"https://api.github.com/users/jenkins-ip-10-4-24-184/following{/other_user}","gists_url":"https://api.github.com/users/jenkins-ip-10-4-24-184/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkins-ip-10-4-24-184/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkins-ip-10-4-24-184/subscriptions","organizations_url":"https://api.github.com/users/jenkins-ip-10-4-24-184/orgs","repos_url":"https://api.github.com/users/jenkins-ip-10-4-24-184/repos","events_url":"https://api.github.com/users/jenkins-ip-10-4-24-184/events{/privacy}","received_events_url":"https://api.github.com/users/jenkins-ip-10-4-24-184/received_events","type":"User","site_admin":false},"created_at":"2018-03-27T12:38:27Z","updated_at":"2018-03-27T12:38:27Z","author_association":"CONTRIBUTOR","body":"SonarQube analysis reported 9 issues\n\nNote: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:\n\n1. ![MAJOR][MAJOR] [OslpChannelHandler.java#L309](https://github.com/OSGP/Protocol-Adapter-OSLP/blob/117df448bbe0237ee051a0b35f76adb1272d6ae6/web-device-simulator/src/main/java/com/alliander/osgp/webdevicesimulator/service/OslpChannelHandler.java#L309): Refactor this code to not nest more than 3 if/for/while/switch/try statements. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](http://ci.opensmartgridplatform.org/sonarqube/coding_rules#rule_key=squid%3AS134)\n1. ![MAJOR][MAJOR] [OslpChannelHandler.java#L391](https://github.com/OSGP/Protocol-Adapter-OSLP/blob/117df448bbe0237ee051a0b35f76adb1272d6ae6/web-device-simulator/src/main/java/com/alliander/osgp/webdevicesimulator/service/OslpChannelHandler.java#L391): Refactor this method to throw at most one checked exception instead of: java.io.IOException, com.alliander.osgp.webdevicesimulator.exceptions.DeviceSimulatorException [![rule](https://sonarsource.github.io/sonar-github/rule.png)](http://ci.opensmartgridplatform.org/sonarqube/coding_rules#rule_key=squid%3AS1160)\n1. ![MAJOR][MAJOR] [OslpChannelHandler.java#L424](https://github.com/OSGP/Protocol-Adapter-OSLP/blob/117df448bbe0237ee051a0b35f76adb1272d6ae6/web-device-simulator/src/main/java/com/alliander/osgp/webdevicesimulator/service/OslpChannelHandler.java#L424): This block of commented-out lines of code should be removed. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](http://ci.opensmartgridplatform.org/sonarqube/coding_rules#rule_key=squid%3ACommentedOutCodeLine)\n1. ![MAJOR][MAJOR] [OslpChannelHandler.java#L457](https://github.com/OSGP/Protocol-Adapter-OSLP/blob/117df448bbe0237ee051a0b35f76adb1272d6ae6/web-device-simulator/src/main/java/com/alliander/osgp/webdevicesimulator/service/OslpChannelHandler.java#L457): The Cyclomatic Complexity of this method \"handleRequest\" is 29 which is greater than 10 authorized. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](http://ci.opensmartgridplatform.org/sonarqube/coding_rules#rule_key=squid%3AMethodCyclomaticComplexity)\n1. ![MAJOR][MAJOR] [OslpChannelHandler.java#L1057](https://github.com/OSGP/Protocol-Adapter-OSLP/blob/117df448bbe0237ee051a0b35f76adb1272d6ae6/web-device-simulator/src/main/java/com/alliander/osgp/webdevicesimulator/service/OslpChannelHandler.java#L1057): This block of commented-out lines of code should be removed. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](http://ci.opensmartgridplatform.org/sonarqube/coding_rules#rule_key=squid%3ACommentedOutCodeLine)\n1. ![MAJOR][MAJOR] [OslpChannelHandler.java#L1130](https://github.com/OSGP/Protocol-Adapter-OSLP/blob/117df448bbe0237ee051a0b35f76adb1272d6ae6/web-device-simulator/src/main/java/com/alliander/osgp/webdevicesimulator/service/OslpChannelHandler.java#L1130): Remove these unused method parameters. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](http://ci.opensmartgridplatform.org/sonarqube/coding_rules#rule_key=squid%3AS1172)\n1. ![MAJOR][MAJOR] [OslpChannelHandler.java#L1157](https://github.com/OSGP/Protocol-Adapter-OSLP/blob/117df448bbe0237ee051a0b35f76adb1272d6ae6/web-device-simulator/src/main/java/com/alliander/osgp/webdevicesimulator/service/OslpChannelHandler.java#L1157): Remove these unused method parameters. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](http://ci.opensmartgridplatform.org/sonarqube/coding_rules#rule_key=squid%3AS1172)\n1. ![MAJOR][MAJOR] [OslpChannelHandler.java#L1162](https://github.com/OSGP/Protocol-Adapter-OSLP/blob/117df448bbe0237ee051a0b35f76adb1272d6ae6/web-device-simulator/src/main/java/com/alliander/osgp/webdevicesimulator/service/OslpChannelHandler.java#L1162): Remove these unused method parameters. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](http://ci.opensmartgridplatform.org/sonarqube/coding_rules#rule_key=squid%3AS1172)\n1. ![MAJOR][MAJOR] [OslpChannelHandler.java#L1166](https://github.com/OSGP/Protocol-Adapter-OSLP/blob/117df448bbe0237ee051a0b35f76adb1272d6ae6/web-device-simulator/src/main/java/com/alliander/osgp/webdevicesimulator/service/OslpChannelHandler.java#L1166): Remove these unused method parameters. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](http://ci.opensmartgridplatform.org/sonarqube/coding_rules#rule_key=squid%3AS1172)\n\n[MAJOR]: https://sonarsource.github.io/sonar-github/severity-major.png 'Severity: MAJOR'"}}
{"actor":{"display_login":"jenkins-ip-10-4-24-184"}}