{"action":"created","comment":{"url":"https://api.github.com/repos/apache/geode-native/pulls/comments/233590888","pull_request_review_id":175042408,"id":233590888,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzU5MDg4OA==","diff_hunk":"@@ -26,6 +26,10 @@ if(CMAKE_CXX_COMPILER_ID STREQUAL \"SunPro\")\n   set(CMAKE_CXX_FLAGS \"${CMAKE_CXX_FLAGS} -m64\")\n endif()\n \n+if(WIN32)\n+  set(CMAKE_CXX_FLAGS \"${CMAKE_CXX_FLAGS} -m64 /D_SILENCE_TR1_NAMESPACE_DEPRECATION_WARNING\")","path":"dependencies/gtest/CMakeLists.txt","position":5,"original_position":5,"commit_id":"6a107be977ef02adc35f57a444a55a0cb4bfc8b2","original_commit_id":"6a107be977ef02adc35f57a444a55a0cb4bfc8b2","user":{"login":"pdxcodemonkey","id":3029555,"node_id":"MDQ6VXNlcjMwMjk1NTU=","avatar_url":"https://avatars3.githubusercontent.com/u/3029555?v=4","gravatar_id":"","url":"https://api.github.com/users/pdxcodemonkey","html_url":"https://github.com/pdxcodemonkey","followers_url":"https://api.github.com/users/pdxcodemonkey/followers","following_url":"https://api.github.com/users/pdxcodemonkey/following{/other_user}","gists_url":"https://api.github.com/users/pdxcodemonkey/gists{/gist_id}","starred_url":"https://api.github.com/users/pdxcodemonkey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdxcodemonkey/subscriptions","organizations_url":"https://api.github.com/users/pdxcodemonkey/orgs","repos_url":"https://api.github.com/users/pdxcodemonkey/repos","events_url":"https://api.github.com/users/pdxcodemonkey/events{/privacy}","received_events_url":"https://api.github.com/users/pdxcodemonkey/received_events","type":"User","site_admin":false},"body":"It's in gtest: gtest-port.h","created_at":"2018-11-14T19:37:38Z","updated_at":"2018-11-14T19:37:38Z","html_url":"https://github.com/apache/geode-native/pull/404#discussion_r233590888","pull_request_url":"https://api.github.com/repos/apache/geode-native/pulls/404","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/geode-native/pulls/comments/233590888"},"html":{"href":"https://github.com/apache/geode-native/pull/404#discussion_r233590888"},"pull_request":{"href":"https://api.github.com/repos/apache/geode-native/pulls/404"}},"in_reply_to_id":233590251},"pull_request":{"url":"https://api.github.com/repos/apache/geode-native/pulls/404","id":230955637,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwOTU1NjM3","html_url":"https://github.com/apache/geode-native/pull/404","diff_url":"https://github.com/apache/geode-native/pull/404.diff","patch_url":"https://github.com/apache/geode-native/pull/404.patch","issue_url":"https://api.github.com/repos/apache/geode-native/issues/404","number":404,"state":"open","locked":false,"title":"GEODE-6054: Build with Visual Studio 2017 runtime.","user":{"login":"pdxcodemonkey","id":3029555,"node_id":"MDQ6VXNlcjMwMjk1NTU=","avatar_url":"https://avatars3.githubusercontent.com/u/3029555?v=4","gravatar_id":"","url":"https://api.github.com/users/pdxcodemonkey","html_url":"https://github.com/pdxcodemonkey","followers_url":"https://api.github.com/users/pdxcodemonkey/followers","following_url":"https://api.github.com/users/pdxcodemonkey/following{/other_user}","gists_url":"https://api.github.com/users/pdxcodemonkey/gists{/gist_id}","starred_url":"https://api.github.com/users/pdxcodemonkey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdxcodemonkey/subscriptions","organizations_url":"https://api.github.com/users/pdxcodemonkey/orgs","repos_url":"https://api.github.com/users/pdxcodemonkey/repos","events_url":"https://api.github.com/users/pdxcodemonkey/events{/privacy}","received_events_url":"https://api.github.com/users/pdxcodemonkey/received_events","type":"User","site_admin":false},"body":"- The only build error was a warning-as-error failure due to a gtest header.  Well-known problem, fixed with a cmake variable in the gtest CMakeLists.txt\r\n\r\nFWIW, This is fixed in a gtest version newer than 1.8, but 1.8 is what we're currently on:  https://github.com/google/googletest/issues/1111\r\n\r\nCo-authored-by: Ernest Burghardt <eburghardt@pivotal.io>","created_at":"2018-11-14T19:34:46Z","updated_at":"2018-11-14T19:37:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4f975a1e7e89194f604861ed8f8bcea6976cc4a4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/geode-native/pulls/404/commits","review_comments_url":"https://api.github.com/repos/apache/geode-native/pulls/404/comments","review_comment_url":"https://api.github.com/repos/apache/geode-native/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/geode-native/issues/404/comments","statuses_url":"https://api.github.com/repos/apache/geode-native/statuses/6a107be977ef02adc35f57a444a55a0cb4bfc8b2","head":{"label":"pdxcodemonkey:GEODE-6054-build-with-VS-2017","ref":"GEODE-6054-build-with-VS-2017","sha":"6a107be977ef02adc35f57a444a55a0cb4bfc8b2","user":{"login":"pdxcodemonkey","id":3029555,"node_id":"MDQ6VXNlcjMwMjk1NTU=","avatar_url":"https://avatars3.githubusercontent.com/u/3029555?v=4","gravatar_id":"","url":"https://api.github.com/users/pdxcodemonkey","html_url":"https://github.com/pdxcodemonkey","followers_url":"https://api.github.com/users/pdxcodemonkey/followers","following_url":"https://api.github.com/users/pdxcodemonkey/following{/other_user}","gists_url":"https://api.github.com/users/pdxcodemonkey/gists{/gist_id}","starred_url":"https://api.github.com/users/pdxcodemonkey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdxcodemonkey/subscriptions","organizations_url":"https://api.github.com/users/pdxcodemonkey/orgs","repos_url":"https://api.github.com/users/pdxcodemonkey/repos","events_url":"https://api.github.com/users/pdxcodemonkey/events{/privacy}","received_events_url":"https://api.github.com/users/pdxcodemonkey/received_events","type":"User","site_admin":false},"repo":{"id":122256536,"node_id":"MDEwOlJlcG9zaXRvcnkxMjIyNTY1MzY=","name":"geode-native","full_name":"pdxcodemonkey/geode-native","private":false,"owner":{"login":"pdxcodemonkey","id":3029555,"node_id":"MDQ6VXNlcjMwMjk1NTU=","avatar_url":"https://avatars3.githubusercontent.com/u/3029555?v=4","gravatar_id":"","url":"https://api.github.com/users/pdxcodemonkey","html_url":"https://github.com/pdxcodemonkey","followers_url":"https://api.github.com/users/pdxcodemonkey/followers","following_url":"https://api.github.com/users/pdxcodemonkey/following{/other_user}","gists_url":"https://api.github.com/users/pdxcodemonkey/gists{/gist_id}","starred_url":"https://api.github.com/users/pdxcodemonkey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdxcodemonkey/subscriptions","organizations_url":"https://api.github.com/users/pdxcodemonkey/orgs","repos_url":"https://api.github.com/users/pdxcodemonkey/repos","events_url":"https://api.github.com/users/pdxcodemonkey/events{/privacy}","received_events_url":"https://api.github.com/users/pdxcodemonkey/received_events","type":"User","site_admin":false},"html_url":"https://github.com/pdxcodemonkey/geode-native","description":"Apache Geode native components","fork":true,"url":"https://api.github.com/repos/pdxcodemonkey/geode-native","forks_url":"https://api.github.com/repos/pdxcodemonkey/geode-native/forks","keys_url":"https://api.github.com/repos/pdxcodemonkey/geode-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pdxcodemonkey/geode-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pdxcodemonkey/geode-native/teams","hooks_url":"https://api.github.com/repos/pdxcodemonkey/geode-native/hooks","issue_events_url":"https://api.github.com/repos/pdxcodemonkey/geode-native/issues/events{/number}","events_url":"https://api.github.com/repos/pdxcodemonkey/geode-native/events","assignees_url":"https://api.github.com/repos/pdxcodemonkey/geode-native/assignees{/user}","branches_url":"https://api.github.com/repos/pdxcodemonkey/geode-native/branches{/branch}","tags_url":"https://api.github.com/repos/pdxcodemonkey/geode-native/tags","blobs_url":"https://api.github.com/repos/pdxcodemonkey/geode-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pdxcodemonkey/geode-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pdxcodemonkey/geode-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/pdxcodemonkey/geode-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pdxcodemonkey/geode-native/statuses/{sha}","languages_url":"https://api.github.com/repos/pdxcodemonkey/geode-native/languages","stargazers_url":"https://api.github.com/repos/pdxcodemonkey/geode-native/stargazers","contributors_url":"https://api.github.com/repos/pdxcodemonkey/geode-native/contributors","subscribers_url":"https://api.github.com/repos/pdxcodemonkey/geode-native/subscribers","subscription_url":"https://api.github.com/repos/pdxcodemonkey/geode-native/subscription","commits_url":"https://api.github.com/repos/pdxcodemonkey/geode-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/pdxcodemonkey/geode-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/pdxcodemonkey/geode-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/pdxcodemonkey/geode-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/pdxcodemonkey/geode-native/contents/{+path}","compare_url":"https://api.github.com/repos/pdxcodemonkey/geode-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pdxcodemonkey/geode-native/merges","archive_url":"https://api.github.com/repos/pdxcodemonkey/geode-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pdxcodemonkey/geode-native/downloads","issues_url":"https://api.github.com/repos/pdxcodemonkey/geode-native/issues{/number}","pulls_url":"https://api.github.com/repos/pdxcodemonkey/geode-native/pulls{/number}","milestones_url":"https://api.github.com/repos/pdxcodemonkey/geode-native/milestones{/number}","notifications_url":"https://api.github.com/repos/pdxcodemonkey/geode-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pdxcodemonkey/geode-native/labels{/name}","releases_url":"https://api.github.com/repos/pdxcodemonkey/geode-native/releases{/id}","deployments_url":"https://api.github.com/repos/pdxcodemonkey/geode-native/deployments","created_at":"2018-02-20T21:08:20Z","updated_at":"2018-08-07T22:42:33Z","pushed_at":"2018-11-14T19:30:37Z","git_url":"git://github.com/pdxcodemonkey/geode-native.git","ssh_url":"git@github.com:pdxcodemonkey/geode-native.git","clone_url":"https://github.com/pdxcodemonkey/geode-native.git","svn_url":"https://github.com/pdxcodemonkey/geode-native","homepage":"","size":20265,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"apache:develop","ref":"develop","sha":"98d1fb419071a37a9745cd0879e6b498f8843a14","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":80904111,"node_id":"MDEwOlJlcG9zaXRvcnk4MDkwNDExMQ==","name":"geode-native","full_name":"apache/geode-native","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/geode-native","description":"Apache Geode native components","fork":false,"url":"https://api.github.com/repos/apache/geode-native","forks_url":"https://api.github.com/repos/apache/geode-native/forks","keys_url":"https://api.github.com/repos/apache/geode-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/geode-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/geode-native/teams","hooks_url":"https://api.github.com/repos/apache/geode-native/hooks","issue_events_url":"https://api.github.com/repos/apache/geode-native/issues/events{/number}","events_url":"https://api.github.com/repos/apache/geode-native/events","assignees_url":"https://api.github.com/repos/apache/geode-native/assignees{/user}","branches_url":"https://api.github.com/repos/apache/geode-native/branches{/branch}","tags_url":"https://api.github.com/repos/apache/geode-native/tags","blobs_url":"https://api.github.com/repos/apache/geode-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/geode-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/geode-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/geode-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/geode-native/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/geode-native/languages","stargazers_url":"https://api.github.com/repos/apache/geode-native/stargazers","contributors_url":"https://api.github.com/repos/apache/geode-native/contributors","subscribers_url":"https://api.github.com/repos/apache/geode-native/subscribers","subscription_url":"https://api.github.com/repos/apache/geode-native/subscription","commits_url":"https://api.github.com/repos/apache/geode-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/geode-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/geode-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/geode-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/geode-native/contents/{+path}","compare_url":"https://api.github.com/repos/apache/geode-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/geode-native/merges","archive_url":"https://api.github.com/repos/apache/geode-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/geode-native/downloads","issues_url":"https://api.github.com/repos/apache/geode-native/issues{/number}","pulls_url":"https://api.github.com/repos/apache/geode-native/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/geode-native/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/geode-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/geode-native/labels{/name}","releases_url":"https://api.github.com/repos/apache/geode-native/releases{/id}","deployments_url":"https://api.github.com/repos/apache/geode-native/deployments","created_at":"2017-02-04T08:00:06Z","updated_at":"2018-11-13T16:45:45Z","pushed_at":"2018-11-14T19:34:47Z","git_url":"git://github.com/apache/geode-native.git","ssh_url":"git@github.com:apache/geode-native.git","clone_url":"https://github.com/apache/geode-native.git","svn_url":"https://github.com/apache/geode-native","homepage":"","size":20063,"stargazers_count":20,"watchers_count":20,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":36,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":36,"open_issues":4,"watchers":20,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/geode-native/pulls/404"},"html":{"href":"https://github.com/apache/geode-native/pull/404"},"issue":{"href":"https://api.github.com/repos/apache/geode-native/issues/404"},"comments":{"href":"https://api.github.com/repos/apache/geode-native/issues/404/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/geode-native/pulls/404/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/geode-native/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/geode-native/pulls/404/commits"},"statuses":{"href":"https://api.github.com/repos/apache/geode-native/statuses/6a107be977ef02adc35f57a444a55a0cb4bfc8b2"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"pdxcodemonkey"}}