{"action":"closed","issue":{"url":"https://api.github.com/repos/aowen87/TicketTester/issues/1533","repository_url":"https://api.github.com/repos/aowen87/TicketTester","labels_url":"https://api.github.com/repos/aowen87/TicketTester/issues/1533/labels{/name}","comments_url":"https://api.github.com/repos/aowen87/TicketTester/issues/1533/comments","events_url":"https://api.github.com/repos/aowen87/TicketTester/issues/1533/events","html_url":"https://github.com/aowen87/TicketTester/issues/1533","id":388537953,"node_id":"MDU6SXNzdWUzODg1Mzc5NTM=","number":1533,"title":"Reopen with different nodelist set creates SIL woes","user":{"login":"aowen87","id":11658578,"node_id":"MDQ6VXNlcjExNjU4NTc4","avatar_url":"https://avatars0.githubusercontent.com/u/11658578?v=4","gravatar_id":"","url":"https://api.github.com/users/aowen87","html_url":"https://github.com/aowen87","followers_url":"https://api.github.com/users/aowen87/followers","following_url":"https://api.github.com/users/aowen87/following{/other_user}","gists_url":"https://api.github.com/users/aowen87/gists{/gist_id}","starred_url":"https://api.github.com/users/aowen87/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aowen87/subscriptions","organizations_url":"https://api.github.com/users/aowen87/orgs","repos_url":"https://api.github.com/users/aowen87/repos","events_url":"https://api.github.com/users/aowen87/events{/privacy}","received_events_url":"https://api.github.com/users/aowen87/received_events","type":"User","site_admin":false},"labels":[{"id":1153147965,"node_id":"MDU6TGFiZWwxMTUzMTQ3OTY1","url":"https://api.github.com/repos/aowen87/TicketTester/labels/asc","name":"asc","color":"00ACC1","default":false},{"id":1153146737,"node_id":"MDU6TGFiZWwxMTUzMTQ2NzM3","url":"https://api.github.com/repos/aowen87/TicketTester/labels/bug","name":"bug","color":"d73a4a","default":true},{"id":1153147660,"node_id":"MDU6TGFiZWwxMTUzMTQ3NjYw","url":"https://api.github.com/repos/aowen87/TicketTester/labels/likelihood%20medium","name":"likelihood medium","color":"003152","default":false},{"id":1153147506,"node_id":"MDU6TGFiZWwxMTUzMTQ3NTA2","url":"https://api.github.com/repos/aowen87/TicketTester/labels/reviewed","name":"reviewed","color":"008ECC","default":false},{"id":1153147611,"node_id":"MDU6TGFiZWwxMTUzMTQ3NjEx","url":"https://api.github.com/repos/aowen87/TicketTester/labels/severity%20low","name":"severity low","color":"0F52BA","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/aowen87/TicketTester/milestones/33","html_url":"https://github.com/aowen87/TicketTester/milestone/33","labels_url":"https://api.github.com/repos/aowen87/TicketTester/milestones/33/labels","id":3878243,"node_id":"MDk6TWlsZXN0b25lMzg3ODI0Mw==","number":33,"title":"2.2.1","description":null,"creator":{"login":"aowen87","id":11658578,"node_id":"MDQ6VXNlcjExNjU4NTc4","avatar_url":"https://avatars0.githubusercontent.com/u/11658578?v=4","gravatar_id":"","url":"https://api.github.com/users/aowen87","html_url":"https://github.com/aowen87","followers_url":"https://api.github.com/users/aowen87/followers","following_url":"https://api.github.com/users/aowen87/following{/other_user}","gists_url":"https://api.github.com/users/aowen87/gists{/gist_id}","starred_url":"https://api.github.com/users/aowen87/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aowen87/subscriptions","organizations_url":"https://api.github.com/users/aowen87/orgs","repos_url":"https://api.github.com/users/aowen87/repos","events_url":"https://api.github.com/users/aowen87/events{/privacy}","received_events_url":"https://api.github.com/users/aowen87/received_events","type":"User","site_admin":false},"open_issues":0,"closed_issues":18,"state":"open","created_at":"2018-12-06T23:50:20Z","updated_at":"2018-12-07T07:33:47Z","due_on":null,"closed_at":null},"comments":0,"created_at":"2018-12-07T07:33:43Z","updated_at":"2018-12-07T07:33:47Z","closed_at":"2018-12-07T07:33:47Z","author_association":"OWNER","body":"Mike Wickett has a dataset where the available nodelists change as the simulation progresses.  (The dataset is @ /g/g24/cyrush/visit/issue00427 on LLNL OCF)\r\n\r\nIf you create a mesh plot of \"slide_mesh\" & then reopen on any timestep with a different set of nodelists - the reopen will turn off all sets in the SIL & produce a plot with no data.  \r\n\r\nIt appears some how topset is incorrect for this mesh (the second in the file) due to the change of sets representing the nodelists (which are only defined on the first mesh).\r\n\r\nI tested VisIt 1.x and this didn't happen, it started in version 2.0.0.\r\n\r\n\n\n\n\n\n\n-----------------------REDMINE MIGRATION-----------------------\nThis ticket was migrated from Redmine. As such, not all \ninformation was able to be captured in the transition. Below is\na complete record of the original redmine ticket.\n\nTicket number: 427\nStatus: Resolved\nProject: VisIt\nTracker: Bug\nPriority: Normal\nSubject: Reopen with different nodelist set creates SIL woes\nAssigned to: Cyrus Harrison\nCategory: \nTarget version: 2.2.1\nAuthor: Cyrus Harrison\nStart: 10/14/2010\nDue date: \n% Done: 0\nEstimated time: \nCreated: 10/14/2010 12:19 pm\nUpdated: 02/23/2011 05:24 pm\nLikelihood: 3 - Occasional\nSeverity: 2 - Minor Irritation\nFound in version: 2.1.0\nImpact: \nExpected Use: \nOS: All\nSupport Group: DOE/ASC\nDescription:\n Mike Wickett has a dataset where the available nodelists change as the simulation progresses.  (The dataset is @ /g/g24/cyrush/visit/issue00427 on LLNL OCF)\r\n\r\nIf you create a mesh plot of \"slide_mesh\" & then reopen on any timestep with a different set of nodelists - the reopen will turn off all sets in the SIL & produce a plot with no data.  \r\n\r\nIt appears some how topset is incorrect for this mesh (the second in the file) due to the change of sets representing the nodelists (which are only defined on the first mesh).\r\n\r\nI tested VisIt 1.x and this didn't happen, it started in version 2.0.0.\r\n\r\n\n\nComments:\nAdded loc of data.\nUpdate from LLNL meeting.\nBoth the \"slide_mesh\" and the main mesh use the name \"block0\" for the top block.B/c the nodelists differ the SILs are not 100% compatible.The problem occurs in avtSILRestriction::SetFromCompatibleRestriction.We lookup and check if \"block0\" is on & we get the result for \"main_mesh/block0\" instead of \"slide_mesh/block0\"At this level, the SIL entires aren't qualified by the mesh name - the SIL object just returns the first instance of \"block0\"\nHi Everyone,This update resolves issues w/ avtSILRestriction::SetFromCompatibleRestriction() outlined @https://visitbugs.ornl.gov/issues/427I ended up doing a lockstep DFS traversal of the SIL Restrictions, each starting at the topset.Performance Notes:1) Previously we looped over all sets in the SIL Restriction. In the new case we visit less sets b/c we only traverse sets in the tree rooted at the current topset.2) The new implementation avoids using exceptions as a mechanism to trap names that do match between sils.3) Like the previous implementation domains aren't traversed, however there is a double loop used to identify matching subset names. If this becomes a performance problem presorting sorting these lists may improve things.Overall, these changes introduce two things that should improve the performance & one that may be slower.RC:Sending        avt/DBAtts/SIL/avtSILRestriction.CTransmitting file data .Committed revision r14124.Trunk:Sending        avt/DBAtts/SIL/avtSILRestriction.CTransmitting file data .Committed revision r14126.Side note - I found it strange that we don't try to traverse & match domains. For my test dataset - this creates another annoyance. I filed another ticket to look into this (https://visitbugs.ornl.gov/issues/626)-Cyrus\n\n"}}
{"actor":{"display_login":"aowen87"}}