{"action":"created","issue":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/37385","repository_url":"https://api.github.com/repos/NixOS/nixpkgs","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/37385/labels{/name}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/37385/comments","events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/37385/events","html_url":"https://github.com/NixOS/nixpkgs/pull/37385","id":306588443,"number":37385,"title":"google-drive-ocamlfuse and gapi-ocaml update","user":{"login":"coreyoconnor","id":34317,"avatar_url":"https://avatars1.githubusercontent.com/u/34317?v=4","gravatar_id":"","url":"https://api.github.com/users/coreyoconnor","html_url":"https://github.com/coreyoconnor","followers_url":"https://api.github.com/users/coreyoconnor/followers","following_url":"https://api.github.com/users/coreyoconnor/following{/other_user}","gists_url":"https://api.github.com/users/coreyoconnor/gists{/gist_id}","starred_url":"https://api.github.com/users/coreyoconnor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreyoconnor/subscriptions","organizations_url":"https://api.github.com/users/coreyoconnor/orgs","repos_url":"https://api.github.com/users/coreyoconnor/repos","events_url":"https://api.github.com/users/coreyoconnor/events{/privacy}","received_events_url":"https://api.github.com/users/coreyoconnor/received_events","type":"User","site_admin":false},"labels":[{"id":737642262,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-darwin:%200","name":"10.rebuild-darwin: 0","color":"eeffee","default":false},{"id":731733923,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-linux:%201-10","name":"10.rebuild-linux: 1-10","color":"eeffee","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-03-19T18:52:05Z","updated_at":"2018-03-19T23:30:27Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/37385","html_url":"https://github.com/NixOS/nixpkgs/pull/37385","diff_url":"https://github.com/NixOS/nixpkgs/pull/37385.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/37385.patch"},"body":"This required changing the build process for both packages. I noticed two things I'd like feedback on:\r\n\r\n1. While both libraries claimed to have migrated to \"jbuilder\" I still needed different commands for each.\r\n2. There are other ocaml packages using \"opam\" to build as well. I grabbed the \"opam-install\" command from one of these. Is there a standard script that should be referenced instead?\r\n\r\n###### Motivation for this change\r\n\r\n1. update google-drive-ocamlfuse to 0.3.6\r\n\r\n###### Things done\r\n\r\n<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->\r\n\r\n- [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)\r\n- Built on platform(s)\r\n   - [ ] NixOS\r\n   - [ ] macOS\r\n   - [ ] other Linux distributions\r\n- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))\r\n- [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [x] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments/374420816","html_url":"https://github.com/NixOS/nixpkgs/pull/37385#issuecomment-374420816","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/37385","id":374420816,"user":{"login":"Mic92","id":96200,"avatar_url":"https://avatars3.githubusercontent.com/u/96200?v=4","gravatar_id":"","url":"https://api.github.com/users/Mic92","html_url":"https://github.com/Mic92","followers_url":"https://api.github.com/users/Mic92/followers","following_url":"https://api.github.com/users/Mic92/following{/other_user}","gists_url":"https://api.github.com/users/Mic92/gists{/gist_id}","starred_url":"https://api.github.com/users/Mic92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mic92/subscriptions","organizations_url":"https://api.github.com/users/Mic92/orgs","repos_url":"https://api.github.com/users/Mic92/repos","events_url":"https://api.github.com/users/Mic92/events{/privacy}","received_events_url":"https://api.github.com/users/Mic92/received_events","type":"User","site_admin":false},"created_at":"2018-03-19T23:30:27Z","updated_at":"2018-03-19T23:30:27Z","author_association":"CONTRIBUTOR","body":"@GrahamcOfBorg build  google-drive-ocamlfuse"}}
{"actor":{"display_login":"Mic92"}}