{"action":"created","issue":{"url":"https://api.github.com/repos/syl20bnr/spacemacs/issues/10675","repository_url":"https://api.github.com/repos/syl20bnr/spacemacs","labels_url":"https://api.github.com/repos/syl20bnr/spacemacs/issues/10675/labels{/name}","comments_url":"https://api.github.com/repos/syl20bnr/spacemacs/issues/10675/comments","events_url":"https://api.github.com/repos/syl20bnr/spacemacs/issues/10675/events","html_url":"https://github.com/syl20bnr/spacemacs/pull/10675","id":322845493,"number":10675,"title":"Use native line numbers in Emacs 26","user":{"login":"bmag","id":4334375,"avatar_url":"https://avatars0.githubusercontent.com/u/4334375?v=4","gravatar_id":"","url":"https://api.github.com/users/bmag","html_url":"https://github.com/bmag","followers_url":"https://api.github.com/users/bmag/followers","following_url":"https://api.github.com/users/bmag/following{/other_user}","gists_url":"https://api.github.com/users/bmag/gists{/gist_id}","starred_url":"https://api.github.com/users/bmag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmag/subscriptions","organizations_url":"https://api.github.com/users/bmag/orgs","repos_url":"https://api.github.com/users/bmag/repos","events_url":"https://api.github.com/users/bmag/events{/privacy}","received_events_url":"https://api.github.com/users/bmag/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":17,"created_at":"2018-05-14T14:37:39Z","updated_at":"2018-05-29T02:31:22Z","closed_at":"2018-05-28T16:48:26Z","author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/syl20bnr/spacemacs/pulls/10675","html_url":"https://github.com/syl20bnr/spacemacs/pull/10675","diff_url":"https://github.com/syl20bnr/spacemacs/pull/10675.diff","patch_url":"https://github.com/syl20bnr/spacemacs/pull/10675.patch"},"body":"Note to other maintainers: don't merge this yet, I might need to make a few more changes\r\n\r\nEmacs 26.1 will introduce a new minor mode for native line numbers: `display-line-numbers-mode`. It is meant to replace linum and friends (including linum-relative). This PR causes Spacemacs to use `display-line-numbers-mode` in Emacs 26, and `linum-mode` in Emacs 25. If `nlinum` layer is enabled by the user, then `nlinum-mode` will be used instead of `display-line-numbers-mode`. Users of `nlinum` layer are recommended to use `display-line-numbers-mode` in Emacs 26.\r\n\r\nThere's a small issue that `display-line-numbers-type` is a \"global\" variable (not buffer-local), so toggling between absolute and relative line numbers in one buffer may affect other buffers. If you test this PR and want to comment about how it behaves, please do.\r\n\r\nCurrently, the `SPC t n` and `SPC t r` toggles for the three different line numbers solutions behave differently. I'm not sure which behavior is the best, so I'd like to hear what other people prefer. The different behaviors are as follows:\r\n\r\n(this summary shows state transitions for line numbers status. \"off\" means no line numbers are shown, \"absolute\" means absolute line numbers are shown, \"relative\" means relative line numbers are shown)\r\nlinum:\r\n- `SPC t n`: (state before key press --> state after key press)\r\n  - off (variant 1) --> absolute\r\n  - off (variant 2) --> relative\r\n  - absolute --> off (variant 1)\r\n  - relative --> off (variant 2)\r\n- `SPC t r`:\r\n  - off (variant 1) --> relative\r\n  - off (variant 2) --> off (variant 1)\r\n  - absolute --> relative\r\n  - relative --> off (variant 1)\r\n\r\nnlinum:\r\n- `SPC t n`:\r\n  - off (variant 1) --> absolute\r\n  - off (variant 2) --> relative\r\n  - absolute --> off (variant 1)\r\n  - relative --> off (variant 2)\r\n- `SPC t r`:\r\n  - off (variant 1) --> off (variant 2)\r\n  - off (variant 2) --> off (variant 1)\r\n  - absolute --> relative\r\n  - relative --> absolute\r\n\r\ndisplay-line-numbers:\r\n- `SPC t n`:\r\n  - off --> absolute\r\n  - absolute --> off\r\n  - relative --> absolute\r\n- SPC t r:\r\n  - off --> relative\r\n  - absolute --> relative\r\n  - relative --> off"},"comment":{"url":"https://api.github.com/repos/syl20bnr/spacemacs/issues/comments/392635956","html_url":"https://github.com/syl20bnr/spacemacs/pull/10675#issuecomment-392635956","issue_url":"https://api.github.com/repos/syl20bnr/spacemacs/issues/10675","id":392635956,"user":{"login":"rekols","id":9636382,"avatar_url":"https://avatars3.githubusercontent.com/u/9636382?v=4","gravatar_id":"","url":"https://api.github.com/users/rekols","html_url":"https://github.com/rekols","followers_url":"https://api.github.com/users/rekols/followers","following_url":"https://api.github.com/users/rekols/following{/other_user}","gists_url":"https://api.github.com/users/rekols/gists{/gist_id}","starred_url":"https://api.github.com/users/rekols/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rekols/subscriptions","organizations_url":"https://api.github.com/users/rekols/orgs","repos_url":"https://api.github.com/users/rekols/repos","events_url":"https://api.github.com/users/rekols/events{/privacy}","received_events_url":"https://api.github.com/users/rekols/received_events","type":"User","site_admin":false},"created_at":"2018-05-29T02:31:21Z","updated_at":"2018-05-29T02:31:21Z","author_association":"NONE","body":"wow, this is fast !!!"}}
{"actor":{"display_login":"rekols"}}