{"action":"opened","issue":{"url":"https://api.github.com/repos/RocketChat/Rocket.Chat.js.SDK/issues/7","repository_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.js.SDK","labels_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.js.SDK/issues/7/labels{/name}","comments_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.js.SDK/issues/7/comments","events_url":"https://api.github.com/repos/RocketChat/Rocket.Chat.js.SDK/issues/7/events","html_url":"https://github.com/RocketChat/Rocket.Chat.js.SDK/issues/7","id":319172684,"number":7,"title":"Add missing env variables from adapter","user":{"login":"timkinnane","id":1774379,"avatar_url":"https://avatars1.githubusercontent.com/u/1774379?v=4","gravatar_id":"","url":"https://api.github.com/users/timkinnane","html_url":"https://github.com/timkinnane","followers_url":"https://api.github.com/users/timkinnane/followers","following_url":"https://api.github.com/users/timkinnane/following{/other_user}","gists_url":"https://api.github.com/users/timkinnane/gists{/gist_id}","starred_url":"https://api.github.com/users/timkinnane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timkinnane/subscriptions","organizations_url":"https://api.github.com/users/timkinnane/orgs","repos_url":"https://api.github.com/users/timkinnane/repos","events_url":"https://api.github.com/users/timkinnane/events{/privacy}","received_events_url":"https://api.github.com/users/timkinnane/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-05-01T11:08:09Z","updated_at":"2018-05-01T11:08:09Z","closed_at":null,"author_association":"COLLABORATOR","body":"While writing developer docs I noticed that the Hubot Adapter implements a few environment variables that aren't used in the SDK. Namely:\r\n- `ROCKETCHAT_USER`\r\n- `ROCKETCHAT_PASSWORD`\r\n- `ROCKETCHAT_ROOM`\r\n- `ROCKETCHAT_USESSL`\r\n\r\nThese should all be carried over to the SDK so bots in other frameworks can set them in a consistent way. Ideally, the only additional environment variables required in the adapter should be for behaviour specific to that framework."}}
{"actor":{"display_login":"timkinnane"}}