{"action":"created","issue":{"url":"https://api.github.com/repos/PsychoinformaticsLab/neuroscout/issues/245","repository_url":"https://api.github.com/repos/PsychoinformaticsLab/neuroscout","labels_url":"https://api.github.com/repos/PsychoinformaticsLab/neuroscout/issues/245/labels{/name}","comments_url":"https://api.github.com/repos/PsychoinformaticsLab/neuroscout/issues/245/comments","events_url":"https://api.github.com/repos/PsychoinformaticsLab/neuroscout/issues/245/events","html_url":"https://github.com/PsychoinformaticsLab/neuroscout/pull/245","id":325912569,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkwMTMzMjUw","number":245,"title":"frontend transformations","user":{"login":"rwblair","id":14927911,"node_id":"MDQ6VXNlcjE0OTI3OTEx","avatar_url":"https://avatars2.githubusercontent.com/u/14927911?v=4","gravatar_id":"","url":"https://api.github.com/users/rwblair","html_url":"https://github.com/rwblair","followers_url":"https://api.github.com/users/rwblair/followers","following_url":"https://api.github.com/users/rwblair/following{/other_user}","gists_url":"https://api.github.com/users/rwblair/gists{/gist_id}","starred_url":"https://api.github.com/users/rwblair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwblair/subscriptions","organizations_url":"https://api.github.com/users/rwblair/orgs","repos_url":"https://api.github.com/users/rwblair/repos","events_url":"https://api.github.com/users/rwblair/events{/privacy}","received_events_url":"https://api.github.com/users/rwblair/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":13,"created_at":"2018-05-23T23:36:29Z","updated_at":"2018-06-08T23:00:39Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/PsychoinformaticsLab/neuroscout/pulls/245","html_url":"https://github.com/PsychoinformaticsLab/neuroscout/pull/245","diff_url":"https://github.com/PsychoinformaticsLab/neuroscout/pull/245.diff","patch_url":"https://github.com/PsychoinformaticsLab/neuroscout/pull/245.patch"},"body":"This addresses the three points in #225.\r\n\r\nOne outstanding issue is that the predictors are being stored in the model  using their unique IDs from the database and not their full names as shown in the spec. The work I did on contrasts and hrf_variables in this PR save them using their full name instead of ID. Predictors selected in transformations are still using their database IDs instead of name, will fix that next. Here is a sample of what the current model json being saved in the database looks like:\r\n\r\n```\r\n{\r\n  \"name\": \"test name\",\r\n  \"input\": {\r\n    \"exclude\": {\r\n      \"subject\": [\r\n        \"01\"\r\n      ]\r\n    },\r\n    \"include\": {\r\n      \"run\": [\r\n        \"2\"\r\n      ],\r\n      \"task\": \"emotionalregulation\"\r\n    }\r\n  },\r\n  \"blocks\": [\r\n    {\r\n      \"level\": \"run\",\r\n      \"model\": {\r\n        \"variables\": [\r\n          1,\r\n          2\r\n        ],\r\n        \"hrf_variables\": [\r\n          \"trial_num\"\r\n        ]\r\n      },\r\n      \"contrasts\": [\r\n        {\r\n          \"name\": \"test cont\",\r\n          \"weights\": [\r\n            1\r\n          ],\r\n          \"predictors\": [\r\n            \"trial_num\"\r\n          ],\r\n          \"contrastType\": \"T\"\r\n        }\r\n      ],\r\n      \"transformations\": [\r\n        {\r\n          \"wrt\": [\r\n            2\r\n          ],\r\n          \"name\": \"orthogonalize\",\r\n          \"input\": [\r\n            1\r\n          ]\r\n        }\r\n      ]\r\n    }\r\n  ],\r\n  \"description\": \"test desc\"\r\n}\r\n```"},"comment":{"url":"https://api.github.com/repos/PsychoinformaticsLab/neuroscout/issues/comments/395914883","html_url":"https://github.com/PsychoinformaticsLab/neuroscout/pull/245#issuecomment-395914883","issue_url":"https://api.github.com/repos/PsychoinformaticsLab/neuroscout/issues/245","id":395914883,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NTkxNDg4Mw==","user":{"login":"tyarkoni","id":303932,"node_id":"MDQ6VXNlcjMwMzkzMg==","avatar_url":"https://avatars2.githubusercontent.com/u/303932?v=4","gravatar_id":"","url":"https://api.github.com/users/tyarkoni","html_url":"https://github.com/tyarkoni","followers_url":"https://api.github.com/users/tyarkoni/followers","following_url":"https://api.github.com/users/tyarkoni/following{/other_user}","gists_url":"https://api.github.com/users/tyarkoni/gists{/gist_id}","starred_url":"https://api.github.com/users/tyarkoni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tyarkoni/subscriptions","organizations_url":"https://api.github.com/users/tyarkoni/orgs","repos_url":"https://api.github.com/users/tyarkoni/repos","events_url":"https://api.github.com/users/tyarkoni/events{/privacy}","received_events_url":"https://api.github.com/users/tyarkoni/received_events","type":"User","site_admin":false},"created_at":"2018-06-08T23:00:39Z","updated_at":"2018-06-08T23:00:39Z","author_association":"NONE","body":"Yep, I believe that should be sufficient. Not sure if fitlins can handle that yet, and pybids also needs to be updated to handle auto_contrasts, but I think that's what's in the spec"}}
{"actor":{"display_login":"tyarkoni"}}