{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes-incubator/kubespray/pulls/comments/214654252","pull_request_review_id":151755520,"id":214654252,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNDY1NDI1Mg==","diff_hunk":"@@ -97,20 +97,23 @@ controllerManagerExtraArgs:\n   node-monitor-grace-period: {{ kube_controller_node_monitor_grace_period }}\n   node-monitor-period: {{ kube_controller_node_monitor_period }}\n   pod-eviction-timeout: {{ kube_controller_pod_eviction_timeout }}\n+{% if kube_feature_gates %}\n+  feature-gates: {{ kube_feature_gates|join(',') }}\n+{% endif %}\n {% if cloud_provider is defined and cloud_provider in [\"openstack\"] and openstack_cacert is defined %}\n controllerManagerExtraVolumes:\n - name: openstackcacert\n   hostPath: \"{{ kube_config_dir }}/openstack-cacert.pem\"\n   mountPath: \"{{ kube_config_dir }}/openstack-cacert.pem\"\n {% endif %}\n-{% if kube_feature_gates %}\n-  feature-gates: {{ kube_feature_gates|join(',') }}\n-{% endif %}\n {% for key in kube_kubeadm_controller_extra_args %}\n   {{ key }}: \"{{ kube_kubeadm_controller_extra_args[key] }}\"\n {% endfor %}\n {% if kube_kubeadm_scheduler_extra_args|length > 0 %}\n schedulerExtraArgs:\n+{% if kube_feature_gates %}","path":"roles/kubernetes/master/templates/kubeadm-config.v1alpha1.yaml.j2","position":21,"original_position":21,"commit_id":"da3c60b30f3c57e16c504129a8ecbf5419a80fac","original_commit_id":"da3c60b30f3c57e16c504129a8ecbf5419a80fac","user":{"login":"mattymo","id":1229061,"node_id":"MDQ6VXNlcjEyMjkwNjE=","avatar_url":"https://avatars2.githubusercontent.com/u/1229061?v=4","gravatar_id":"","url":"https://api.github.com/users/mattymo","html_url":"https://github.com/mattymo","followers_url":"https://api.github.com/users/mattymo/followers","following_url":"https://api.github.com/users/mattymo/following{/other_user}","gists_url":"https://api.github.com/users/mattymo/gists{/gist_id}","starred_url":"https://api.github.com/users/mattymo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattymo/subscriptions","organizations_url":"https://api.github.com/users/mattymo/orgs","repos_url":"https://api.github.com/users/mattymo/repos","events_url":"https://api.github.com/users/mattymo/events{/privacy}","received_events_url":"https://api.github.com/users/mattymo/received_events","type":"User","site_admin":false},"body":"You moved this inside of kube_kubeadm_scheduler_extra_args if statement. If it's empty, this won't get inserted.","created_at":"2018-09-03T11:15:36Z","updated_at":"2018-09-03T11:15:36Z","html_url":"https://github.com/kubernetes-incubator/kubespray/pull/3224#discussion_r214654252","pull_request_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/pulls/3224","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/kubernetes-incubator/kubespray/pulls/comments/214654252"},"html":{"href":"https://github.com/kubernetes-incubator/kubespray/pull/3224#discussion_r214654252"},"pull_request":{"href":"https://api.github.com/repos/kubernetes-incubator/kubespray/pulls/3224"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes-incubator/kubespray/pulls/3224","id":212605402,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyNjA1NDAy","html_url":"https://github.com/kubernetes-incubator/kubespray/pull/3224","diff_url":"https://github.com/kubernetes-incubator/kubespray/pull/3224.diff","patch_url":"https://github.com/kubernetes-incubator/kubespray/pull/3224.patch","issue_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/issues/3224","number":3224,"state":"open","locked":false,"title":"Fix feature-gates","user":{"login":"riverzhang","id":24387537,"node_id":"MDQ6VXNlcjI0Mzg3NTM3","avatar_url":"https://avatars2.githubusercontent.com/u/24387537?v=4","gravatar_id":"","url":"https://api.github.com/users/riverzhang","html_url":"https://github.com/riverzhang","followers_url":"https://api.github.com/users/riverzhang/followers","following_url":"https://api.github.com/users/riverzhang/following{/other_user}","gists_url":"https://api.github.com/users/riverzhang/gists{/gist_id}","starred_url":"https://api.github.com/users/riverzhang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riverzhang/subscriptions","organizations_url":"https://api.github.com/users/riverzhang/orgs","repos_url":"https://api.github.com/users/riverzhang/repos","events_url":"https://api.github.com/users/riverzhang/events{/privacy}","received_events_url":"https://api.github.com/users/riverzhang/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-09-02T18:28:39Z","updated_at":"2018-09-03T11:15:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8309464380eb81c28376ce3a906d8430002da345","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jjungnickel","id":160383,"node_id":"MDQ6VXNlcjE2MDM4Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/160383?v=4","gravatar_id":"","url":"https://api.github.com/users/jjungnickel","html_url":"https://github.com/jjungnickel","followers_url":"https://api.github.com/users/jjungnickel/followers","following_url":"https://api.github.com/users/jjungnickel/following{/other_user}","gists_url":"https://api.github.com/users/jjungnickel/gists{/gist_id}","starred_url":"https://api.github.com/users/jjungnickel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjungnickel/subscriptions","organizations_url":"https://api.github.com/users/jjungnickel/orgs","repos_url":"https://api.github.com/users/jjungnickel/repos","events_url":"https://api.github.com/users/jjungnickel/events{/privacy}","received_events_url":"https://api.github.com/users/jjungnickel/received_events","type":"User","site_admin":false},{"login":"ArchiFleKs","id":1276073,"node_id":"MDQ6VXNlcjEyNzYwNzM=","avatar_url":"https://avatars0.githubusercontent.com/u/1276073?v=4","gravatar_id":"","url":"https://api.github.com/users/ArchiFleKs","html_url":"https://github.com/ArchiFleKs","followers_url":"https://api.github.com/users/ArchiFleKs/followers","following_url":"https://api.github.com/users/ArchiFleKs/following{/other_user}","gists_url":"https://api.github.com/users/ArchiFleKs/gists{/gist_id}","starred_url":"https://api.github.com/users/ArchiFleKs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArchiFleKs/subscriptions","organizations_url":"https://api.github.com/users/ArchiFleKs/orgs","repos_url":"https://api.github.com/users/ArchiFleKs/repos","events_url":"https://api.github.com/users/ArchiFleKs/events{/privacy}","received_events_url":"https://api.github.com/users/ArchiFleKs/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1031817353,"node_id":"MDU6TGFiZWwxMDMxODE3MzUz","url":"https://api.github.com/repos/kubernetes-incubator/kubespray/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":485769464,"node_id":"MDU6TGFiZWw0ODU3Njk0NjQ=","url":"https://api.github.com/repos/kubernetes-incubator/kubespray/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":676230123,"node_id":"MDU6TGFiZWw2NzYyMzAxMjM=","url":"https://api.github.com/repos/kubernetes-incubator/kubespray/labels/size/S","name":"size/S","color":"77bb00","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/pulls/3224/commits","review_comments_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/pulls/3224/comments","review_comment_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/issues/3224/comments","statuses_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/statuses/da3c60b30f3c57e16c504129a8ecbf5419a80fac","head":{"label":"riverzhang:fix-feature-gates","ref":"fix-feature-gates","sha":"da3c60b30f3c57e16c504129a8ecbf5419a80fac","user":{"login":"riverzhang","id":24387537,"node_id":"MDQ6VXNlcjI0Mzg3NTM3","avatar_url":"https://avatars2.githubusercontent.com/u/24387537?v=4","gravatar_id":"","url":"https://api.github.com/users/riverzhang","html_url":"https://github.com/riverzhang","followers_url":"https://api.github.com/users/riverzhang/followers","following_url":"https://api.github.com/users/riverzhang/following{/other_user}","gists_url":"https://api.github.com/users/riverzhang/gists{/gist_id}","starred_url":"https://api.github.com/users/riverzhang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riverzhang/subscriptions","organizations_url":"https://api.github.com/users/riverzhang/orgs","repos_url":"https://api.github.com/users/riverzhang/repos","events_url":"https://api.github.com/users/riverzhang/events{/privacy}","received_events_url":"https://api.github.com/users/riverzhang/received_events","type":"User","site_admin":false},"repo":{"id":144722671,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ3MjI2NzE=","name":"kubespray","full_name":"riverzhang/kubespray","owner":{"login":"riverzhang","id":24387537,"node_id":"MDQ6VXNlcjI0Mzg3NTM3","avatar_url":"https://avatars2.githubusercontent.com/u/24387537?v=4","gravatar_id":"","url":"https://api.github.com/users/riverzhang","html_url":"https://github.com/riverzhang","followers_url":"https://api.github.com/users/riverzhang/followers","following_url":"https://api.github.com/users/riverzhang/following{/other_user}","gists_url":"https://api.github.com/users/riverzhang/gists{/gist_id}","starred_url":"https://api.github.com/users/riverzhang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riverzhang/subscriptions","organizations_url":"https://api.github.com/users/riverzhang/orgs","repos_url":"https://api.github.com/users/riverzhang/repos","events_url":"https://api.github.com/users/riverzhang/events{/privacy}","received_events_url":"https://api.github.com/users/riverzhang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/riverzhang/kubespray","description":"Setup a kubernetes cluster","fork":true,"url":"https://api.github.com/repos/riverzhang/kubespray","forks_url":"https://api.github.com/repos/riverzhang/kubespray/forks","keys_url":"https://api.github.com/repos/riverzhang/kubespray/keys{/key_id}","collaborators_url":"https://api.github.com/repos/riverzhang/kubespray/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/riverzhang/kubespray/teams","hooks_url":"https://api.github.com/repos/riverzhang/kubespray/hooks","issue_events_url":"https://api.github.com/repos/riverzhang/kubespray/issues/events{/number}","events_url":"https://api.github.com/repos/riverzhang/kubespray/events","assignees_url":"https://api.github.com/repos/riverzhang/kubespray/assignees{/user}","branches_url":"https://api.github.com/repos/riverzhang/kubespray/branches{/branch}","tags_url":"https://api.github.com/repos/riverzhang/kubespray/tags","blobs_url":"https://api.github.com/repos/riverzhang/kubespray/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/riverzhang/kubespray/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/riverzhang/kubespray/git/refs{/sha}","trees_url":"https://api.github.com/repos/riverzhang/kubespray/git/trees{/sha}","statuses_url":"https://api.github.com/repos/riverzhang/kubespray/statuses/{sha}","languages_url":"https://api.github.com/repos/riverzhang/kubespray/languages","stargazers_url":"https://api.github.com/repos/riverzhang/kubespray/stargazers","contributors_url":"https://api.github.com/repos/riverzhang/kubespray/contributors","subscribers_url":"https://api.github.com/repos/riverzhang/kubespray/subscribers","subscription_url":"https://api.github.com/repos/riverzhang/kubespray/subscription","commits_url":"https://api.github.com/repos/riverzhang/kubespray/commits{/sha}","git_commits_url":"https://api.github.com/repos/riverzhang/kubespray/git/commits{/sha}","comments_url":"https://api.github.com/repos/riverzhang/kubespray/comments{/number}","issue_comment_url":"https://api.github.com/repos/riverzhang/kubespray/issues/comments{/number}","contents_url":"https://api.github.com/repos/riverzhang/kubespray/contents/{+path}","compare_url":"https://api.github.com/repos/riverzhang/kubespray/compare/{base}...{head}","merges_url":"https://api.github.com/repos/riverzhang/kubespray/merges","archive_url":"https://api.github.com/repos/riverzhang/kubespray/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/riverzhang/kubespray/downloads","issues_url":"https://api.github.com/repos/riverzhang/kubespray/issues{/number}","pulls_url":"https://api.github.com/repos/riverzhang/kubespray/pulls{/number}","milestones_url":"https://api.github.com/repos/riverzhang/kubespray/milestones{/number}","notifications_url":"https://api.github.com/repos/riverzhang/kubespray/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/riverzhang/kubespray/labels{/name}","releases_url":"https://api.github.com/repos/riverzhang/kubespray/releases{/id}","deployments_url":"https://api.github.com/repos/riverzhang/kubespray/deployments","created_at":"2018-08-14T13:17:32Z","updated_at":"2018-09-02T17:52:21Z","pushed_at":"2018-09-03T10:43:43Z","git_url":"git://github.com/riverzhang/kubespray.git","ssh_url":"git@github.com:riverzhang/kubespray.git","clone_url":"https://github.com/riverzhang/kubespray.git","svn_url":"https://github.com/riverzhang/kubespray","homepage":"","size":8369,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes-incubator:master","ref":"master","sha":"a47c9239e829ab91e66c358e80ec2372c8a4e976","user":{"login":"kubernetes-incubator","id":20862812,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwODYyODEy","avatar_url":"https://avatars2.githubusercontent.com/u/20862812?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes-incubator","html_url":"https://github.com/kubernetes-incubator","followers_url":"https://api.github.com/users/kubernetes-incubator/followers","following_url":"https://api.github.com/users/kubernetes-incubator/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-incubator/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-incubator/orgs","repos_url":"https://api.github.com/users/kubernetes-incubator/repos","events_url":"https://api.github.com/users/kubernetes-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-incubator/received_events","type":"Organization","site_admin":false},"repo":{"id":43613404,"node_id":"MDEwOlJlcG9zaXRvcnk0MzYxMzQwNA==","name":"kubespray","full_name":"kubernetes-incubator/kubespray","owner":{"login":"kubernetes-incubator","id":20862812,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwODYyODEy","avatar_url":"https://avatars2.githubusercontent.com/u/20862812?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes-incubator","html_url":"https://github.com/kubernetes-incubator","followers_url":"https://api.github.com/users/kubernetes-incubator/followers","following_url":"https://api.github.com/users/kubernetes-incubator/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-incubator/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-incubator/orgs","repos_url":"https://api.github.com/users/kubernetes-incubator/repos","events_url":"https://api.github.com/users/kubernetes-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-incubator/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes-incubator/kubespray","description":"Setup a kubernetes cluster","fork":false,"url":"https://api.github.com/repos/kubernetes-incubator/kubespray","forks_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/forks","keys_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/teams","hooks_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/hooks","issue_events_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/events","assignees_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/tags","blobs_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/languages","stargazers_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/stargazers","contributors_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/contributors","subscribers_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/subscribers","subscription_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/subscription","commits_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/merges","archive_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/downloads","issues_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes-incubator/kubespray/deployments","created_at":"2015-10-03T20:18:11Z","updated_at":"2018-09-03T10:49:21Z","pushed_at":"2018-09-03T10:49:06Z","git_url":"git://github.com/kubernetes-incubator/kubespray.git","ssh_url":"git@github.com:kubernetes-incubator/kubespray.git","clone_url":"https://github.com/kubernetes-incubator/kubespray.git","svn_url":"https://github.com/kubernetes-incubator/kubespray","homepage":"","size":8377,"stargazers_count":3790,"watchers_count":3790,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1500,"mirror_url":null,"archived":false,"open_issues_count":414,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1500,"open_issues":414,"watchers":3790,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes-incubator/kubespray/pulls/3224"},"html":{"href":"https://github.com/kubernetes-incubator/kubespray/pull/3224"},"issue":{"href":"https://api.github.com/repos/kubernetes-incubator/kubespray/issues/3224"},"comments":{"href":"https://api.github.com/repos/kubernetes-incubator/kubespray/issues/3224/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes-incubator/kubespray/pulls/3224/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes-incubator/kubespray/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes-incubator/kubespray/pulls/3224/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes-incubator/kubespray/statuses/da3c60b30f3c57e16c504129a8ecbf5419a80fac"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"mattymo"}}