{"action":"created","issue":{"url":"https://api.github.com/repos/envoyproxy/envoy/issues/5358","repository_url":"https://api.github.com/repos/envoyproxy/envoy","labels_url":"https://api.github.com/repos/envoyproxy/envoy/issues/5358/labels{/name}","comments_url":"https://api.github.com/repos/envoyproxy/envoy/issues/5358/comments","events_url":"https://api.github.com/repos/envoyproxy/envoy/issues/5358/events","html_url":"https://github.com/envoyproxy/envoy/pull/5358","id":392843370,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwMDIxOTIw","number":5358,"title":"tracers: bugfix for datadog tracer","user":{"login":"cgilmour","id":892558,"node_id":"MDQ6VXNlcjg5MjU1OA==","avatar_url":"https://avatars0.githubusercontent.com/u/892558?v=4","gravatar_id":"","url":"https://api.github.com/users/cgilmour","html_url":"https://github.com/cgilmour","followers_url":"https://api.github.com/users/cgilmour/followers","following_url":"https://api.github.com/users/cgilmour/following{/other_user}","gists_url":"https://api.github.com/users/cgilmour/gists{/gist_id}","starred_url":"https://api.github.com/users/cgilmour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgilmour/subscriptions","organizations_url":"https://api.github.com/users/cgilmour/orgs","repos_url":"https://api.github.com/users/cgilmour/repos","events_url":"https://api.github.com/users/cgilmour/events{/privacy}","received_events_url":"https://api.github.com/users/cgilmour/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"mattklein123","id":6305260,"node_id":"MDQ6VXNlcjYzMDUyNjA=","avatar_url":"https://avatars3.githubusercontent.com/u/6305260?v=4","gravatar_id":"","url":"https://api.github.com/users/mattklein123","html_url":"https://github.com/mattklein123","followers_url":"https://api.github.com/users/mattklein123/followers","following_url":"https://api.github.com/users/mattklein123/following{/other_user}","gists_url":"https://api.github.com/users/mattklein123/gists{/gist_id}","starred_url":"https://api.github.com/users/mattklein123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattklein123/subscriptions","organizations_url":"https://api.github.com/users/mattklein123/orgs","repos_url":"https://api.github.com/users/mattklein123/repos","events_url":"https://api.github.com/users/mattklein123/events{/privacy}","received_events_url":"https://api.github.com/users/mattklein123/received_events","type":"User","site_admin":false},"assignees":[{"login":"mattklein123","id":6305260,"node_id":"MDQ6VXNlcjYzMDUyNjA=","avatar_url":"https://avatars3.githubusercontent.com/u/6305260?v=4","gravatar_id":"","url":"https://api.github.com/users/mattklein123","html_url":"https://github.com/mattklein123","followers_url":"https://api.github.com/users/mattklein123/followers","following_url":"https://api.github.com/users/mattklein123/following{/other_user}","gists_url":"https://api.github.com/users/mattklein123/gists{/gist_id}","starred_url":"https://api.github.com/users/mattklein123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattklein123/subscriptions","organizations_url":"https://api.github.com/users/mattklein123/orgs","repos_url":"https://api.github.com/users/mattklein123/repos","events_url":"https://api.github.com/users/mattklein123/events{/privacy}","received_events_url":"https://api.github.com/users/mattklein123/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2018-12-20T01:05:35Z","updated_at":"2018-12-21T17:57:38Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/envoyproxy/envoy/pulls/5358","html_url":"https://github.com/envoyproxy/envoy/pull/5358","diff_url":"https://github.com/envoyproxy/envoy/pull/5358.diff","patch_url":"https://github.com/envoyproxy/envoy/pull/5358.patch"},"body":"*Description*:\r\nA user reported directly that their metrics had regular `response_code_class:5` coming from the tracer sending data to an agent that collects them.\r\nThese were found to be 503s from sending on a half-closed connection.\r\n\r\nNormally that would be incredibly rare and unlikely. But with the upstream having a 5000ms timer and the tracer flushing on an exact multiple of it, it essentially forces that race condition to get hit.\r\n\r\nThis PR makes sure the timers don't align.\r\n\r\n*Risk Level*: Low\r\n*Testing*: Unit tests, E2E\r\n*Docs Changes*: N/A\r\n*Release Notes*: N/A\r\n"},"comment":{"url":"https://api.github.com/repos/envoyproxy/envoy/issues/comments/449456159","html_url":"https://github.com/envoyproxy/envoy/pull/5358#issuecomment-449456159","issue_url":"https://api.github.com/repos/envoyproxy/envoy/issues/5358","id":449456159,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0OTQ1NjE1OQ==","user":{"login":"mattklein123","id":6305260,"node_id":"MDQ6VXNlcjYzMDUyNjA=","avatar_url":"https://avatars3.githubusercontent.com/u/6305260?v=4","gravatar_id":"","url":"https://api.github.com/users/mattklein123","html_url":"https://github.com/mattklein123","followers_url":"https://api.github.com/users/mattklein123/followers","following_url":"https://api.github.com/users/mattklein123/following{/other_user}","gists_url":"https://api.github.com/users/mattklein123/gists{/gist_id}","starred_url":"https://api.github.com/users/mattklein123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattklein123/subscriptions","organizations_url":"https://api.github.com/users/mattklein123/orgs","repos_url":"https://api.github.com/users/mattklein123/repos","events_url":"https://api.github.com/users/mattklein123/events{/privacy}","received_events_url":"https://api.github.com/users/mattklein123/received_events","type":"User","site_admin":false},"created_at":"2018-12-21T17:57:38Z","updated_at":"2018-12-21T17:57:38Z","author_association":"MEMBER","body":"@cgilmour OK, though in general this kind of timing fix is still very fragile. It seems like a better solution would be to support retries if we want to gurantee trace delivery? That is obviously a larger and much more complicated fix though. If you don't want to do that, can you put a bunch more comments in around the timing issue and add a TODO to think about adding retries? Thank you.\r\n\r\n/wait"}}
{"actor":{"display_login":"mattklein123"}}