{"action":"closed","number":57,"pull_request":{"url":"https://api.github.com/repos/ARMmbed/littlefs/pulls/57","id":193487708,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzNDg3NzA4","html_url":"https://github.com/ARMmbed/littlefs/pull/57","diff_url":"https://github.com/ARMmbed/littlefs/pull/57.diff","patch_url":"https://github.com/ARMmbed/littlefs/pull/57.patch","issue_url":"https://api.github.com/repos/ARMmbed/littlefs/issues/57","number":57,"state":"closed","locked":false,"title":"Fix some compiler warnings: shadowed variable and unused parameters","user":{"login":"dpgeorge","id":6187689,"node_id":"MDQ6VXNlcjYxODc2ODk=","avatar_url":"https://avatars1.githubusercontent.com/u/6187689?v=4","gravatar_id":"","url":"https://api.github.com/users/dpgeorge","html_url":"https://github.com/dpgeorge","followers_url":"https://api.github.com/users/dpgeorge/followers","following_url":"https://api.github.com/users/dpgeorge/following{/other_user}","gists_url":"https://api.github.com/users/dpgeorge/gists{/gist_id}","starred_url":"https://api.github.com/users/dpgeorge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpgeorge/subscriptions","organizations_url":"https://api.github.com/users/dpgeorge/orgs","repos_url":"https://api.github.com/users/dpgeorge/repos","events_url":"https://api.github.com/users/dpgeorge/events{/privacy}","received_events_url":"https://api.github.com/users/dpgeorge/received_events","type":"User","site_admin":false},"body":"First off, thanks for this project!  It's nice and clean and integrates well into other embedded systems.\r\n\r\nIn this PR I've fixed a few compiler warnings, when `-Wshadow` and `-Wunused-parameter` are enabled.  Fixing these help to integrate littlefs in bigger projects that have these warnings enabled, without applying additional workarounds.\r\n\r\nI also added a commit to enable these warnings in the Makefile here, so the problems don't crop up again.\r\n\r\nAny feedback is most welcome.","created_at":"2018-06-08T01:31:58Z","updated_at":"2018-07-02T17:01:35Z","closed_at":"2018-07-02T17:01:35Z","merged_at":"2018-07-02T17:01:35Z","merge_commit_sha":"ba4f17173f94644da2f684c9b81b4f916f0156be","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ARMmbed/littlefs/pulls/57/commits","review_comments_url":"https://api.github.com/repos/ARMmbed/littlefs/pulls/57/comments","review_comment_url":"https://api.github.com/repos/ARMmbed/littlefs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ARMmbed/littlefs/issues/57/comments","statuses_url":"https://api.github.com/repos/ARMmbed/littlefs/statuses/51346b8bf4146cc145c2cefce9928b03fa9f4c8c","head":{"label":"dpgeorge:fix-warnings","ref":"fix-warnings","sha":"51346b8bf4146cc145c2cefce9928b03fa9f4c8c","user":{"login":"dpgeorge","id":6187689,"node_id":"MDQ6VXNlcjYxODc2ODk=","avatar_url":"https://avatars1.githubusercontent.com/u/6187689?v=4","gravatar_id":"","url":"https://api.github.com/users/dpgeorge","html_url":"https://github.com/dpgeorge","followers_url":"https://api.github.com/users/dpgeorge/followers","following_url":"https://api.github.com/users/dpgeorge/following{/other_user}","gists_url":"https://api.github.com/users/dpgeorge/gists{/gist_id}","starred_url":"https://api.github.com/users/dpgeorge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpgeorge/subscriptions","organizations_url":"https://api.github.com/users/dpgeorge/orgs","repos_url":"https://api.github.com/users/dpgeorge/repos","events_url":"https://api.github.com/users/dpgeorge/events{/privacy}","received_events_url":"https://api.github.com/users/dpgeorge/received_events","type":"User","site_admin":false},"repo":{"id":136549014,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY1NDkwMTQ=","name":"littlefs","full_name":"dpgeorge/littlefs","owner":{"login":"dpgeorge","id":6187689,"node_id":"MDQ6VXNlcjYxODc2ODk=","avatar_url":"https://avatars1.githubusercontent.com/u/6187689?v=4","gravatar_id":"","url":"https://api.github.com/users/dpgeorge","html_url":"https://github.com/dpgeorge","followers_url":"https://api.github.com/users/dpgeorge/followers","following_url":"https://api.github.com/users/dpgeorge/following{/other_user}","gists_url":"https://api.github.com/users/dpgeorge/gists{/gist_id}","starred_url":"https://api.github.com/users/dpgeorge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpgeorge/subscriptions","organizations_url":"https://api.github.com/users/dpgeorge/orgs","repos_url":"https://api.github.com/users/dpgeorge/repos","events_url":"https://api.github.com/users/dpgeorge/events{/privacy}","received_events_url":"https://api.github.com/users/dpgeorge/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dpgeorge/littlefs","description":"A little fail-safe filesystem designed for microcontrollers","fork":true,"url":"https://api.github.com/repos/dpgeorge/littlefs","forks_url":"https://api.github.com/repos/dpgeorge/littlefs/forks","keys_url":"https://api.github.com/repos/dpgeorge/littlefs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dpgeorge/littlefs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dpgeorge/littlefs/teams","hooks_url":"https://api.github.com/repos/dpgeorge/littlefs/hooks","issue_events_url":"https://api.github.com/repos/dpgeorge/littlefs/issues/events{/number}","events_url":"https://api.github.com/repos/dpgeorge/littlefs/events","assignees_url":"https://api.github.com/repos/dpgeorge/littlefs/assignees{/user}","branches_url":"https://api.github.com/repos/dpgeorge/littlefs/branches{/branch}","tags_url":"https://api.github.com/repos/dpgeorge/littlefs/tags","blobs_url":"https://api.github.com/repos/dpgeorge/littlefs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dpgeorge/littlefs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dpgeorge/littlefs/git/refs{/sha}","trees_url":"https://api.github.com/repos/dpgeorge/littlefs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dpgeorge/littlefs/statuses/{sha}","languages_url":"https://api.github.com/repos/dpgeorge/littlefs/languages","stargazers_url":"https://api.github.com/repos/dpgeorge/littlefs/stargazers","contributors_url":"https://api.github.com/repos/dpgeorge/littlefs/contributors","subscribers_url":"https://api.github.com/repos/dpgeorge/littlefs/subscribers","subscription_url":"https://api.github.com/repos/dpgeorge/littlefs/subscription","commits_url":"https://api.github.com/repos/dpgeorge/littlefs/commits{/sha}","git_commits_url":"https://api.github.com/repos/dpgeorge/littlefs/git/commits{/sha}","comments_url":"https://api.github.com/repos/dpgeorge/littlefs/comments{/number}","issue_comment_url":"https://api.github.com/repos/dpgeorge/littlefs/issues/comments{/number}","contents_url":"https://api.github.com/repos/dpgeorge/littlefs/contents/{+path}","compare_url":"https://api.github.com/repos/dpgeorge/littlefs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dpgeorge/littlefs/merges","archive_url":"https://api.github.com/repos/dpgeorge/littlefs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dpgeorge/littlefs/downloads","issues_url":"https://api.github.com/repos/dpgeorge/littlefs/issues{/number}","pulls_url":"https://api.github.com/repos/dpgeorge/littlefs/pulls{/number}","milestones_url":"https://api.github.com/repos/dpgeorge/littlefs/milestones{/number}","notifications_url":"https://api.github.com/repos/dpgeorge/littlefs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dpgeorge/littlefs/labels{/name}","releases_url":"https://api.github.com/repos/dpgeorge/littlefs/releases{/id}","deployments_url":"https://api.github.com/repos/dpgeorge/littlefs/deployments","created_at":"2018-06-08T01:16:38Z","updated_at":"2018-06-26T01:37:33Z","pushed_at":"2018-07-02T15:29:47Z","git_url":"git://github.com/dpgeorge/littlefs.git","ssh_url":"git@github.com:dpgeorge/littlefs.git","clone_url":"https://github.com/dpgeorge/littlefs.git","svn_url":"https://github.com/dpgeorge/littlefs","homepage":"","size":348,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ARMmbed:master","ref":"master","sha":"93a2e0bbe53e741f468bd84e75a2f894aa6158e3","user":{"login":"ARMmbed","id":8916057,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg5MTYwNTc=","avatar_url":"https://avatars3.githubusercontent.com/u/8916057?v=4","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"repo":{"id":83160811,"node_id":"MDEwOlJlcG9zaXRvcnk4MzE2MDgxMQ==","name":"littlefs","full_name":"ARMmbed/littlefs","owner":{"login":"ARMmbed","id":8916057,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg5MTYwNTc=","avatar_url":"https://avatars3.githubusercontent.com/u/8916057?v=4","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ARMmbed/littlefs","description":"A little fail-safe filesystem designed for microcontrollers","fork":false,"url":"https://api.github.com/repos/ARMmbed/littlefs","forks_url":"https://api.github.com/repos/ARMmbed/littlefs/forks","keys_url":"https://api.github.com/repos/ARMmbed/littlefs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ARMmbed/littlefs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ARMmbed/littlefs/teams","hooks_url":"https://api.github.com/repos/ARMmbed/littlefs/hooks","issue_events_url":"https://api.github.com/repos/ARMmbed/littlefs/issues/events{/number}","events_url":"https://api.github.com/repos/ARMmbed/littlefs/events","assignees_url":"https://api.github.com/repos/ARMmbed/littlefs/assignees{/user}","branches_url":"https://api.github.com/repos/ARMmbed/littlefs/branches{/branch}","tags_url":"https://api.github.com/repos/ARMmbed/littlefs/tags","blobs_url":"https://api.github.com/repos/ARMmbed/littlefs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ARMmbed/littlefs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ARMmbed/littlefs/git/refs{/sha}","trees_url":"https://api.github.com/repos/ARMmbed/littlefs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ARMmbed/littlefs/statuses/{sha}","languages_url":"https://api.github.com/repos/ARMmbed/littlefs/languages","stargazers_url":"https://api.github.com/repos/ARMmbed/littlefs/stargazers","contributors_url":"https://api.github.com/repos/ARMmbed/littlefs/contributors","subscribers_url":"https://api.github.com/repos/ARMmbed/littlefs/subscribers","subscription_url":"https://api.github.com/repos/ARMmbed/littlefs/subscription","commits_url":"https://api.github.com/repos/ARMmbed/littlefs/commits{/sha}","git_commits_url":"https://api.github.com/repos/ARMmbed/littlefs/git/commits{/sha}","comments_url":"https://api.github.com/repos/ARMmbed/littlefs/comments{/number}","issue_comment_url":"https://api.github.com/repos/ARMmbed/littlefs/issues/comments{/number}","contents_url":"https://api.github.com/repos/ARMmbed/littlefs/contents/{+path}","compare_url":"https://api.github.com/repos/ARMmbed/littlefs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ARMmbed/littlefs/merges","archive_url":"https://api.github.com/repos/ARMmbed/littlefs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ARMmbed/littlefs/downloads","issues_url":"https://api.github.com/repos/ARMmbed/littlefs/issues{/number}","pulls_url":"https://api.github.com/repos/ARMmbed/littlefs/pulls{/number}","milestones_url":"https://api.github.com/repos/ARMmbed/littlefs/milestones{/number}","notifications_url":"https://api.github.com/repos/ARMmbed/littlefs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ARMmbed/littlefs/labels{/name}","releases_url":"https://api.github.com/repos/ARMmbed/littlefs/releases{/id}","deployments_url":"https://api.github.com/repos/ARMmbed/littlefs/deployments","created_at":"2017-02-25T20:33:13Z","updated_at":"2018-06-26T20:00:52Z","pushed_at":"2018-07-02T17:01:35Z","git_url":"git://github.com/ARMmbed/littlefs.git","ssh_url":"git@github.com:ARMmbed/littlefs.git","clone_url":"https://github.com/ARMmbed/littlefs.git","svn_url":"https://github.com/ARMmbed/littlefs","homepage":"","size":437,"stargazers_count":293,"watchers_count":293,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":65,"mirror_url":null,"archived":false,"open_issues_count":28,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":65,"open_issues":28,"watchers":293,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/littlefs/pulls/57"},"html":{"href":"https://github.com/ARMmbed/littlefs/pull/57"},"issue":{"href":"https://api.github.com/repos/ARMmbed/littlefs/issues/57"},"comments":{"href":"https://api.github.com/repos/ARMmbed/littlefs/issues/57/comments"},"review_comments":{"href":"https://api.github.com/repos/ARMmbed/littlefs/pulls/57/comments"},"review_comment":{"href":"https://api.github.com/repos/ARMmbed/littlefs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ARMmbed/littlefs/pulls/57/commits"},"statuses":{"href":"https://api.github.com/repos/ARMmbed/littlefs/statuses/51346b8bf4146cc145c2cefce9928b03fa9f4c8c"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"geky","id":1075160,"node_id":"MDQ6VXNlcjEwNzUxNjA=","avatar_url":"https://avatars3.githubusercontent.com/u/1075160?v=4","gravatar_id":"","url":"https://api.github.com/users/geky","html_url":"https://github.com/geky","followers_url":"https://api.github.com/users/geky/followers","following_url":"https://api.github.com/users/geky/following{/other_user}","gists_url":"https://api.github.com/users/geky/gists{/gist_id}","starred_url":"https://api.github.com/users/geky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geky/subscriptions","organizations_url":"https://api.github.com/users/geky/orgs","repos_url":"https://api.github.com/users/geky/repos","events_url":"https://api.github.com/users/geky/events{/privacy}","received_events_url":"https://api.github.com/users/geky/received_events","type":"User","site_admin":false},"comments":8,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":11,"deletions":8,"changed_files":5}}
{"actor":{"display_login":"geky"}}