{"action":"opened","number":5663,"pull_request":{"url":"https://api.github.com/repos/discourse/discourse/pulls/5663","id":173978904,"html_url":"https://github.com/discourse/discourse/pull/5663","diff_url":"https://github.com/discourse/discourse/pull/5663.diff","patch_url":"https://github.com/discourse/discourse/pull/5663.patch","issue_url":"https://api.github.com/repos/discourse/discourse/issues/5663","number":5663,"state":"open","locked":false,"title":"FIX: Excerpts could be too long for column","user":{"login":"gschlager","id":473736,"avatar_url":"https://avatars3.githubusercontent.com/u/473736?v=4","gravatar_id":"","url":"https://api.github.com/users/gschlager","html_url":"https://github.com/gschlager","followers_url":"https://api.github.com/users/gschlager/followers","following_url":"https://api.github.com/users/gschlager/following{/other_user}","gists_url":"https://api.github.com/users/gschlager/gists{/gist_id}","starred_url":"https://api.github.com/users/gschlager/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gschlager/subscriptions","organizations_url":"https://api.github.com/users/gschlager/orgs","repos_url":"https://api.github.com/users/gschlager/repos","events_url":"https://api.github.com/users/gschlager/events{/privacy}","received_events_url":"https://api.github.com/users/gschlager/received_events","type":"User","site_admin":false},"body":"This changes the data type of `topics.excerpt` from `VARCHAR(1000)` to `TEXT`. If I'm [reading this correctly](https://wiki.postgresql.org/wiki/What%27s_new_in_PostgreSQL_9.2#Reduce_ALTER_TABLE_rewrites) that's not a costly operation in Postgres.\r\n\r\nWhy? Because excerpts can contain an unknown number of HTML (e.g. from the `<details>`).\r\nhttps://meta.discourse.org/t/excerpt-gets-too-long-under-certain-circumstances-activerecord-valuetoolong/77579\r\n\r\nAlso, I made improvements to the text length calculation when the excerpt contains `<details>`.","created_at":"2018-03-09T11:11:18Z","updated_at":"2018-03-09T11:11:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/discourse/discourse/pulls/5663/commits","review_comments_url":"https://api.github.com/repos/discourse/discourse/pulls/5663/comments","review_comment_url":"https://api.github.com/repos/discourse/discourse/pulls/comments{/number}","comments_url":"https://api.github.com/repos/discourse/discourse/issues/5663/comments","statuses_url":"https://api.github.com/repos/discourse/discourse/statuses/235de028c6e74f06fee54e5549403694b3b08960","head":{"label":"gschlager:excerpt","ref":"excerpt","sha":"235de028c6e74f06fee54e5549403694b3b08960","user":{"login":"gschlager","id":473736,"avatar_url":"https://avatars3.githubusercontent.com/u/473736?v=4","gravatar_id":"","url":"https://api.github.com/users/gschlager","html_url":"https://github.com/gschlager","followers_url":"https://api.github.com/users/gschlager/followers","following_url":"https://api.github.com/users/gschlager/following{/other_user}","gists_url":"https://api.github.com/users/gschlager/gists{/gist_id}","starred_url":"https://api.github.com/users/gschlager/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gschlager/subscriptions","organizations_url":"https://api.github.com/users/gschlager/orgs","repos_url":"https://api.github.com/users/gschlager/repos","events_url":"https://api.github.com/users/gschlager/events{/privacy}","received_events_url":"https://api.github.com/users/gschlager/received_events","type":"User","site_admin":false},"repo":{"id":22441495,"name":"discourse","full_name":"gschlager/discourse","owner":{"login":"gschlager","id":473736,"avatar_url":"https://avatars3.githubusercontent.com/u/473736?v=4","gravatar_id":"","url":"https://api.github.com/users/gschlager","html_url":"https://github.com/gschlager","followers_url":"https://api.github.com/users/gschlager/followers","following_url":"https://api.github.com/users/gschlager/following{/other_user}","gists_url":"https://api.github.com/users/gschlager/gists{/gist_id}","starred_url":"https://api.github.com/users/gschlager/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gschlager/subscriptions","organizations_url":"https://api.github.com/users/gschlager/orgs","repos_url":"https://api.github.com/users/gschlager/repos","events_url":"https://api.github.com/users/gschlager/events{/privacy}","received_events_url":"https://api.github.com/users/gschlager/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gschlager/discourse","description":"A platform for community discussion. Free, open, simple.","fork":true,"url":"https://api.github.com/repos/gschlager/discourse","forks_url":"https://api.github.com/repos/gschlager/discourse/forks","keys_url":"https://api.github.com/repos/gschlager/discourse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gschlager/discourse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gschlager/discourse/teams","hooks_url":"https://api.github.com/repos/gschlager/discourse/hooks","issue_events_url":"https://api.github.com/repos/gschlager/discourse/issues/events{/number}","events_url":"https://api.github.com/repos/gschlager/discourse/events","assignees_url":"https://api.github.com/repos/gschlager/discourse/assignees{/user}","branches_url":"https://api.github.com/repos/gschlager/discourse/branches{/branch}","tags_url":"https://api.github.com/repos/gschlager/discourse/tags","blobs_url":"https://api.github.com/repos/gschlager/discourse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gschlager/discourse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gschlager/discourse/git/refs{/sha}","trees_url":"https://api.github.com/repos/gschlager/discourse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gschlager/discourse/statuses/{sha}","languages_url":"https://api.github.com/repos/gschlager/discourse/languages","stargazers_url":"https://api.github.com/repos/gschlager/discourse/stargazers","contributors_url":"https://api.github.com/repos/gschlager/discourse/contributors","subscribers_url":"https://api.github.com/repos/gschlager/discourse/subscribers","subscription_url":"https://api.github.com/repos/gschlager/discourse/subscription","commits_url":"https://api.github.com/repos/gschlager/discourse/commits{/sha}","git_commits_url":"https://api.github.com/repos/gschlager/discourse/git/commits{/sha}","comments_url":"https://api.github.com/repos/gschlager/discourse/comments{/number}","issue_comment_url":"https://api.github.com/repos/gschlager/discourse/issues/comments{/number}","contents_url":"https://api.github.com/repos/gschlager/discourse/contents/{+path}","compare_url":"https://api.github.com/repos/gschlager/discourse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gschlager/discourse/merges","archive_url":"https://api.github.com/repos/gschlager/discourse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gschlager/discourse/downloads","issues_url":"https://api.github.com/repos/gschlager/discourse/issues{/number}","pulls_url":"https://api.github.com/repos/gschlager/discourse/pulls{/number}","milestones_url":"https://api.github.com/repos/gschlager/discourse/milestones{/number}","notifications_url":"https://api.github.com/repos/gschlager/discourse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gschlager/discourse/labels{/name}","releases_url":"https://api.github.com/repos/gschlager/discourse/releases{/id}","deployments_url":"https://api.github.com/repos/gschlager/discourse/deployments","created_at":"2014-07-30T19:20:49Z","updated_at":"2016-10-26T20:48:32Z","pushed_at":"2018-03-09T11:05:17Z","git_url":"git://github.com/gschlager/discourse.git","ssh_url":"git@github.com:gschlager/discourse.git","clone_url":"https://github.com/gschlager/discourse.git","svn_url":"https://github.com/gschlager/discourse","homepage":"http://www.discourse.org","size":211169,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":7,"watchers":0,"default_branch":"master"}},"base":{"label":"discourse:master","ref":"master","sha":"dc77cce8d97594caa845a2970ce1bf545b7fc0fe","user":{"login":"discourse","id":3220138,"avatar_url":"https://avatars2.githubusercontent.com/u/3220138?v=4","gravatar_id":"","url":"https://api.github.com/users/discourse","html_url":"https://github.com/discourse","followers_url":"https://api.github.com/users/discourse/followers","following_url":"https://api.github.com/users/discourse/following{/other_user}","gists_url":"https://api.github.com/users/discourse/gists{/gist_id}","starred_url":"https://api.github.com/users/discourse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/discourse/subscriptions","organizations_url":"https://api.github.com/users/discourse/orgs","repos_url":"https://api.github.com/users/discourse/repos","events_url":"https://api.github.com/users/discourse/events{/privacy}","received_events_url":"https://api.github.com/users/discourse/received_events","type":"Organization","site_admin":false},"repo":{"id":7569578,"name":"discourse","full_name":"discourse/discourse","owner":{"login":"discourse","id":3220138,"avatar_url":"https://avatars2.githubusercontent.com/u/3220138?v=4","gravatar_id":"","url":"https://api.github.com/users/discourse","html_url":"https://github.com/discourse","followers_url":"https://api.github.com/users/discourse/followers","following_url":"https://api.github.com/users/discourse/following{/other_user}","gists_url":"https://api.github.com/users/discourse/gists{/gist_id}","starred_url":"https://api.github.com/users/discourse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/discourse/subscriptions","organizations_url":"https://api.github.com/users/discourse/orgs","repos_url":"https://api.github.com/users/discourse/repos","events_url":"https://api.github.com/users/discourse/events{/privacy}","received_events_url":"https://api.github.com/users/discourse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/discourse/discourse","description":"A platform for community discussion. Free, open, simple.","fork":false,"url":"https://api.github.com/repos/discourse/discourse","forks_url":"https://api.github.com/repos/discourse/discourse/forks","keys_url":"https://api.github.com/repos/discourse/discourse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/discourse/discourse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/discourse/discourse/teams","hooks_url":"https://api.github.com/repos/discourse/discourse/hooks","issue_events_url":"https://api.github.com/repos/discourse/discourse/issues/events{/number}","events_url":"https://api.github.com/repos/discourse/discourse/events","assignees_url":"https://api.github.com/repos/discourse/discourse/assignees{/user}","branches_url":"https://api.github.com/repos/discourse/discourse/branches{/branch}","tags_url":"https://api.github.com/repos/discourse/discourse/tags","blobs_url":"https://api.github.com/repos/discourse/discourse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/discourse/discourse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/discourse/discourse/git/refs{/sha}","trees_url":"https://api.github.com/repos/discourse/discourse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/discourse/discourse/statuses/{sha}","languages_url":"https://api.github.com/repos/discourse/discourse/languages","stargazers_url":"https://api.github.com/repos/discourse/discourse/stargazers","contributors_url":"https://api.github.com/repos/discourse/discourse/contributors","subscribers_url":"https://api.github.com/repos/discourse/discourse/subscribers","subscription_url":"https://api.github.com/repos/discourse/discourse/subscription","commits_url":"https://api.github.com/repos/discourse/discourse/commits{/sha}","git_commits_url":"https://api.github.com/repos/discourse/discourse/git/commits{/sha}","comments_url":"https://api.github.com/repos/discourse/discourse/comments{/number}","issue_comment_url":"https://api.github.com/repos/discourse/discourse/issues/comments{/number}","contents_url":"https://api.github.com/repos/discourse/discourse/contents/{+path}","compare_url":"https://api.github.com/repos/discourse/discourse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/discourse/discourse/merges","archive_url":"https://api.github.com/repos/discourse/discourse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/discourse/discourse/downloads","issues_url":"https://api.github.com/repos/discourse/discourse/issues{/number}","pulls_url":"https://api.github.com/repos/discourse/discourse/pulls{/number}","milestones_url":"https://api.github.com/repos/discourse/discourse/milestones{/number}","notifications_url":"https://api.github.com/repos/discourse/discourse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/discourse/discourse/labels{/name}","releases_url":"https://api.github.com/repos/discourse/discourse/releases{/id}","deployments_url":"https://api.github.com/repos/discourse/discourse/deployments","created_at":"2013-01-12T00:25:55Z","updated_at":"2018-03-09T09:23:55Z","pushed_at":"2018-03-09T10:17:49Z","git_url":"git://github.com/discourse/discourse.git","ssh_url":"git@github.com:discourse/discourse.git","clone_url":"https://github.com/discourse/discourse.git","svn_url":"https://github.com/discourse/discourse","homepage":"https://www.discourse.org","size":211585,"stargazers_count":24315,"watchers_count":24315,"language":"Ruby","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5968,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":5968,"open_issues":10,"watchers":24315,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/discourse/discourse/pulls/5663"},"html":{"href":"https://github.com/discourse/discourse/pull/5663"},"issue":{"href":"https://api.github.com/repos/discourse/discourse/issues/5663"},"comments":{"href":"https://api.github.com/repos/discourse/discourse/issues/5663/comments"},"review_comments":{"href":"https://api.github.com/repos/discourse/discourse/pulls/5663/comments"},"review_comment":{"href":"https://api.github.com/repos/discourse/discourse/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/discourse/discourse/pulls/5663/commits"},"statuses":{"href":"https://api.github.com/repos/discourse/discourse/statuses/235de028c6e74f06fee54e5549403694b3b08960"}},"author_association":"OWNER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":2,"additions":49,"deletions":12,"changed_files":3}}
{"actor":{"display_login":"gschlager"}}