{"action":"closed","number":169,"pull_request":{"url":"https://api.github.com/repos/private-octopus/picoquic/pulls/169","id":182615830,"html_url":"https://github.com/private-octopus/picoquic/pull/169","diff_url":"https://github.com/private-octopus/picoquic/pull/169.diff","patch_url":"https://github.com/private-octopus/picoquic/pull/169.patch","issue_url":"https://api.github.com/repos/private-octopus/picoquic/issues/169","number":169,"state":"closed","locked":false,"title":"Fix off-by-one error in encoding of ack ranges and gaps","user":{"login":"huitema","id":7464128,"avatar_url":"https://avatars0.githubusercontent.com/u/7464128?v=4","gravatar_id":"","url":"https://api.github.com/users/huitema","html_url":"https://github.com/huitema","followers_url":"https://api.github.com/users/huitema/followers","following_url":"https://api.github.com/users/huitema/following{/other_user}","gists_url":"https://api.github.com/users/huitema/gists{/gist_id}","starred_url":"https://api.github.com/users/huitema/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huitema/subscriptions","organizations_url":"https://api.github.com/users/huitema/orgs","repos_url":"https://api.github.com/users/huitema/repos","events_url":"https://api.github.com/users/huitema/events{/privacy}","received_events_url":"https://api.github.com/users/huitema/received_events","type":"User","site_admin":false},"body":"Embarrassing bug. The coding changed way back, with draft-08, but we missed it, and the interop tests did not surface the issue.","created_at":"2018-04-18T22:05:42Z","updated_at":"2018-04-18T22:10:19Z","closed_at":"2018-04-18T22:10:19Z","merged_at":"2018-04-18T22:10:19Z","merge_commit_sha":"f3e2a637c9eafddbeb2571545e59cf4e268716c8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/private-octopus/picoquic/pulls/169/commits","review_comments_url":"https://api.github.com/repos/private-octopus/picoquic/pulls/169/comments","review_comment_url":"https://api.github.com/repos/private-octopus/picoquic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/private-octopus/picoquic/issues/169/comments","statuses_url":"https://api.github.com/repos/private-octopus/picoquic/statuses/2581b3c61efdd7ca853d84a2997b283507e9d566","head":{"label":"private-octopus:fix-ack-gap","ref":"fix-ack-gap","sha":"2581b3c61efdd7ca853d84a2997b283507e9d566","user":{"login":"private-octopus","id":27636089,"avatar_url":"https://avatars1.githubusercontent.com/u/27636089?v=4","gravatar_id":"","url":"https://api.github.com/users/private-octopus","html_url":"https://github.com/private-octopus","followers_url":"https://api.github.com/users/private-octopus/followers","following_url":"https://api.github.com/users/private-octopus/following{/other_user}","gists_url":"https://api.github.com/users/private-octopus/gists{/gist_id}","starred_url":"https://api.github.com/users/private-octopus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/private-octopus/subscriptions","organizations_url":"https://api.github.com/users/private-octopus/orgs","repos_url":"https://api.github.com/users/private-octopus/repos","events_url":"https://api.github.com/users/private-octopus/events{/privacy}","received_events_url":"https://api.github.com/users/private-octopus/received_events","type":"User","site_admin":false},"repo":{"id":95480304,"name":"picoquic","full_name":"private-octopus/picoquic","owner":{"login":"private-octopus","id":27636089,"avatar_url":"https://avatars1.githubusercontent.com/u/27636089?v=4","gravatar_id":"","url":"https://api.github.com/users/private-octopus","html_url":"https://github.com/private-octopus","followers_url":"https://api.github.com/users/private-octopus/followers","following_url":"https://api.github.com/users/private-octopus/following{/other_user}","gists_url":"https://api.github.com/users/private-octopus/gists{/gist_id}","starred_url":"https://api.github.com/users/private-octopus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/private-octopus/subscriptions","organizations_url":"https://api.github.com/users/private-octopus/orgs","repos_url":"https://api.github.com/users/private-octopus/repos","events_url":"https://api.github.com/users/private-octopus/events{/privacy}","received_events_url":"https://api.github.com/users/private-octopus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/private-octopus/picoquic","description":"Minimal implementation of the QUIC protocol","fork":false,"url":"https://api.github.com/repos/private-octopus/picoquic","forks_url":"https://api.github.com/repos/private-octopus/picoquic/forks","keys_url":"https://api.github.com/repos/private-octopus/picoquic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/private-octopus/picoquic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/private-octopus/picoquic/teams","hooks_url":"https://api.github.com/repos/private-octopus/picoquic/hooks","issue_events_url":"https://api.github.com/repos/private-octopus/picoquic/issues/events{/number}","events_url":"https://api.github.com/repos/private-octopus/picoquic/events","assignees_url":"https://api.github.com/repos/private-octopus/picoquic/assignees{/user}","branches_url":"https://api.github.com/repos/private-octopus/picoquic/branches{/branch}","tags_url":"https://api.github.com/repos/private-octopus/picoquic/tags","blobs_url":"https://api.github.com/repos/private-octopus/picoquic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/private-octopus/picoquic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/private-octopus/picoquic/git/refs{/sha}","trees_url":"https://api.github.com/repos/private-octopus/picoquic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/private-octopus/picoquic/statuses/{sha}","languages_url":"https://api.github.com/repos/private-octopus/picoquic/languages","stargazers_url":"https://api.github.com/repos/private-octopus/picoquic/stargazers","contributors_url":"https://api.github.com/repos/private-octopus/picoquic/contributors","subscribers_url":"https://api.github.com/repos/private-octopus/picoquic/subscribers","subscription_url":"https://api.github.com/repos/private-octopus/picoquic/subscription","commits_url":"https://api.github.com/repos/private-octopus/picoquic/commits{/sha}","git_commits_url":"https://api.github.com/repos/private-octopus/picoquic/git/commits{/sha}","comments_url":"https://api.github.com/repos/private-octopus/picoquic/comments{/number}","issue_comment_url":"https://api.github.com/repos/private-octopus/picoquic/issues/comments{/number}","contents_url":"https://api.github.com/repos/private-octopus/picoquic/contents/{+path}","compare_url":"https://api.github.com/repos/private-octopus/picoquic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/private-octopus/picoquic/merges","archive_url":"https://api.github.com/repos/private-octopus/picoquic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/private-octopus/picoquic/downloads","issues_url":"https://api.github.com/repos/private-octopus/picoquic/issues{/number}","pulls_url":"https://api.github.com/repos/private-octopus/picoquic/pulls{/number}","milestones_url":"https://api.github.com/repos/private-octopus/picoquic/milestones{/number}","notifications_url":"https://api.github.com/repos/private-octopus/picoquic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/private-octopus/picoquic/labels{/name}","releases_url":"https://api.github.com/repos/private-octopus/picoquic/releases{/id}","deployments_url":"https://api.github.com/repos/private-octopus/picoquic/deployments","created_at":"2017-06-26T19:08:37Z","updated_at":"2018-04-18T18:23:02Z","pushed_at":"2018-04-18T22:10:18Z","git_url":"git://github.com/private-octopus/picoquic.git","ssh_url":"git@github.com:private-octopus/picoquic.git","clone_url":"https://github.com/private-octopus/picoquic.git","svn_url":"https://github.com/private-octopus/picoquic","homepage":null,"size":10687,"stargazers_count":36,"watchers_count":36,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":10,"open_issues":18,"watchers":36,"default_branch":"master"}},"base":{"label":"private-octopus:master","ref":"master","sha":"715b6f12c309ad3f0d91aaa3ef5adc737e0f23ab","user":{"login":"private-octopus","id":27636089,"avatar_url":"https://avatars1.githubusercontent.com/u/27636089?v=4","gravatar_id":"","url":"https://api.github.com/users/private-octopus","html_url":"https://github.com/private-octopus","followers_url":"https://api.github.com/users/private-octopus/followers","following_url":"https://api.github.com/users/private-octopus/following{/other_user}","gists_url":"https://api.github.com/users/private-octopus/gists{/gist_id}","starred_url":"https://api.github.com/users/private-octopus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/private-octopus/subscriptions","organizations_url":"https://api.github.com/users/private-octopus/orgs","repos_url":"https://api.github.com/users/private-octopus/repos","events_url":"https://api.github.com/users/private-octopus/events{/privacy}","received_events_url":"https://api.github.com/users/private-octopus/received_events","type":"User","site_admin":false},"repo":{"id":95480304,"name":"picoquic","full_name":"private-octopus/picoquic","owner":{"login":"private-octopus","id":27636089,"avatar_url":"https://avatars1.githubusercontent.com/u/27636089?v=4","gravatar_id":"","url":"https://api.github.com/users/private-octopus","html_url":"https://github.com/private-octopus","followers_url":"https://api.github.com/users/private-octopus/followers","following_url":"https://api.github.com/users/private-octopus/following{/other_user}","gists_url":"https://api.github.com/users/private-octopus/gists{/gist_id}","starred_url":"https://api.github.com/users/private-octopus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/private-octopus/subscriptions","organizations_url":"https://api.github.com/users/private-octopus/orgs","repos_url":"https://api.github.com/users/private-octopus/repos","events_url":"https://api.github.com/users/private-octopus/events{/privacy}","received_events_url":"https://api.github.com/users/private-octopus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/private-octopus/picoquic","description":"Minimal implementation of the QUIC protocol","fork":false,"url":"https://api.github.com/repos/private-octopus/picoquic","forks_url":"https://api.github.com/repos/private-octopus/picoquic/forks","keys_url":"https://api.github.com/repos/private-octopus/picoquic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/private-octopus/picoquic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/private-octopus/picoquic/teams","hooks_url":"https://api.github.com/repos/private-octopus/picoquic/hooks","issue_events_url":"https://api.github.com/repos/private-octopus/picoquic/issues/events{/number}","events_url":"https://api.github.com/repos/private-octopus/picoquic/events","assignees_url":"https://api.github.com/repos/private-octopus/picoquic/assignees{/user}","branches_url":"https://api.github.com/repos/private-octopus/picoquic/branches{/branch}","tags_url":"https://api.github.com/repos/private-octopus/picoquic/tags","blobs_url":"https://api.github.com/repos/private-octopus/picoquic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/private-octopus/picoquic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/private-octopus/picoquic/git/refs{/sha}","trees_url":"https://api.github.com/repos/private-octopus/picoquic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/private-octopus/picoquic/statuses/{sha}","languages_url":"https://api.github.com/repos/private-octopus/picoquic/languages","stargazers_url":"https://api.github.com/repos/private-octopus/picoquic/stargazers","contributors_url":"https://api.github.com/repos/private-octopus/picoquic/contributors","subscribers_url":"https://api.github.com/repos/private-octopus/picoquic/subscribers","subscription_url":"https://api.github.com/repos/private-octopus/picoquic/subscription","commits_url":"https://api.github.com/repos/private-octopus/picoquic/commits{/sha}","git_commits_url":"https://api.github.com/repos/private-octopus/picoquic/git/commits{/sha}","comments_url":"https://api.github.com/repos/private-octopus/picoquic/comments{/number}","issue_comment_url":"https://api.github.com/repos/private-octopus/picoquic/issues/comments{/number}","contents_url":"https://api.github.com/repos/private-octopus/picoquic/contents/{+path}","compare_url":"https://api.github.com/repos/private-octopus/picoquic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/private-octopus/picoquic/merges","archive_url":"https://api.github.com/repos/private-octopus/picoquic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/private-octopus/picoquic/downloads","issues_url":"https://api.github.com/repos/private-octopus/picoquic/issues{/number}","pulls_url":"https://api.github.com/repos/private-octopus/picoquic/pulls{/number}","milestones_url":"https://api.github.com/repos/private-octopus/picoquic/milestones{/number}","notifications_url":"https://api.github.com/repos/private-octopus/picoquic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/private-octopus/picoquic/labels{/name}","releases_url":"https://api.github.com/repos/private-octopus/picoquic/releases{/id}","deployments_url":"https://api.github.com/repos/private-octopus/picoquic/deployments","created_at":"2017-06-26T19:08:37Z","updated_at":"2018-04-18T18:23:02Z","pushed_at":"2018-04-18T22:10:18Z","git_url":"git://github.com/private-octopus/picoquic.git","ssh_url":"git@github.com:private-octopus/picoquic.git","clone_url":"https://github.com/private-octopus/picoquic.git","svn_url":"https://github.com/private-octopus/picoquic","homepage":null,"size":10687,"stargazers_count":36,"watchers_count":36,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":10,"open_issues":18,"watchers":36,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/private-octopus/picoquic/pulls/169"},"html":{"href":"https://github.com/private-octopus/picoquic/pull/169"},"issue":{"href":"https://api.github.com/repos/private-octopus/picoquic/issues/169"},"comments":{"href":"https://api.github.com/repos/private-octopus/picoquic/issues/169/comments"},"review_comments":{"href":"https://api.github.com/repos/private-octopus/picoquic/pulls/169/comments"},"review_comment":{"href":"https://api.github.com/repos/private-octopus/picoquic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/private-octopus/picoquic/pulls/169/commits"},"statuses":{"href":"https://api.github.com/repos/private-octopus/picoquic/statuses/2581b3c61efdd7ca853d84a2997b283507e9d566"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"huitema","id":7464128,"avatar_url":"https://avatars0.githubusercontent.com/u/7464128?v=4","gravatar_id":"","url":"https://api.github.com/users/huitema","html_url":"https://github.com/huitema","followers_url":"https://api.github.com/users/huitema/followers","following_url":"https://api.github.com/users/huitema/following{/other_user}","gists_url":"https://api.github.com/users/huitema/gists{/gist_id}","starred_url":"https://api.github.com/users/huitema/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huitema/subscriptions","organizations_url":"https://api.github.com/users/huitema/orgs","repos_url":"https://api.github.com/users/huitema/repos","events_url":"https://api.github.com/users/huitema/events{/privacy}","received_events_url":"https://api.github.com/users/huitema/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":24,"deletions":20,"changed_files":6}}
{"actor":{"display_login":"huitema"}}