{"action":"created","issue":{"url":"https://api.github.com/repos/txzhao/rl-zoo/issues/1","repository_url":"https://api.github.com/repos/txzhao/rl-zoo","labels_url":"https://api.github.com/repos/txzhao/rl-zoo/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/txzhao/rl-zoo/issues/1/comments","events_url":"https://api.github.com/repos/txzhao/rl-zoo/issues/1/events","html_url":"https://github.com/txzhao/rl-zoo/issues/1","id":323527634,"number":1,"title":"Environment Configuration ","user":{"login":"engahmed1190","id":25582838,"avatar_url":"https://avatars0.githubusercontent.com/u/25582838?v=4","gravatar_id":"","url":"https://api.github.com/users/engahmed1190","html_url":"https://github.com/engahmed1190","followers_url":"https://api.github.com/users/engahmed1190/followers","following_url":"https://api.github.com/users/engahmed1190/following{/other_user}","gists_url":"https://api.github.com/users/engahmed1190/gists{/gist_id}","starred_url":"https://api.github.com/users/engahmed1190/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/engahmed1190/subscriptions","organizations_url":"https://api.github.com/users/engahmed1190/orgs","repos_url":"https://api.github.com/users/engahmed1190/repos","events_url":"https://api.github.com/users/engahmed1190/events{/privacy}","received_events_url":"https://api.github.com/users/engahmed1190/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-05-16T08:56:46Z","updated_at":"2018-05-17T10:35:58Z","closed_at":"2018-05-17T07:41:26Z","author_association":"NONE","body":"Hello @txzhao \r\n\r\nI would like to thank you for this code it is very good!\r\n\r\nI am confused in the part related to the size of `N_ACTIONS` , `N_STATES` , `ENV_A_SHAPE`\r\n\r\n```\r\nN_ACTIONS = env.action_space.n\r\nN_STATES = env.observation_space.shape[0]\r\nENV_A_SHAPE = 0 if isinstance(env.action_space.sample(), int) else env.action_space.sample().shape     # to confirm the shape\r\nenv_config = {'n_actions': N_ACTIONS, 'n_states': N_STATES, 'env_a_shape': ENV_A_SHAPE}\r\n```\r\n\r\nin my case, I have used a custom environment where action in 3 numbers array size 3*1 . can you please clarify what is the difference  between N_ACTIONS and ENV_A_SHAPE\r\n\r\nThanks\r\n"},"comment":{"url":"https://api.github.com/repos/txzhao/rl-zoo/issues/comments/389822711","html_url":"https://github.com/txzhao/rl-zoo/issues/1#issuecomment-389822711","issue_url":"https://api.github.com/repos/txzhao/rl-zoo/issues/1","id":389822711,"user":{"login":"engahmed1190","id":25582838,"avatar_url":"https://avatars0.githubusercontent.com/u/25582838?v=4","gravatar_id":"","url":"https://api.github.com/users/engahmed1190","html_url":"https://github.com/engahmed1190","followers_url":"https://api.github.com/users/engahmed1190/followers","following_url":"https://api.github.com/users/engahmed1190/following{/other_user}","gists_url":"https://api.github.com/users/engahmed1190/gists{/gist_id}","starred_url":"https://api.github.com/users/engahmed1190/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/engahmed1190/subscriptions","organizations_url":"https://api.github.com/users/engahmed1190/orgs","repos_url":"https://api.github.com/users/engahmed1190/repos","events_url":"https://api.github.com/users/engahmed1190/events{/privacy}","received_events_url":"https://api.github.com/users/engahmed1190/received_events","type":"User","site_admin":false},"created_at":"2018-05-17T10:35:58Z","updated_at":"2018-05-17T10:35:58Z","author_association":"NONE","body":"Hi @txzhao \r\n\r\nThanks for your respond .\r\n\r\nin my case, I have action space of 3 values so ENV_A_SHAPE is 3 but the N_ACTION is very big where I have 3 values each of them can take value from 0 to 1000.\r\n\r\nwhat do suggest in this case .\r\n"}}
{"actor":{"display_login":"engahmed1190"}}