{"action":"created","issue":{"url":"https://api.github.com/repos/sqlcollaborative/dbatools/issues/4175","repository_url":"https://api.github.com/repos/sqlcollaborative/dbatools","labels_url":"https://api.github.com/repos/sqlcollaborative/dbatools/issues/4175/labels{/name}","comments_url":"https://api.github.com/repos/sqlcollaborative/dbatools/issues/4175/comments","events_url":"https://api.github.com/repos/sqlcollaborative/dbatools/issues/4175/events","html_url":"https://github.com/sqlcollaborative/dbatools/pull/4175","id":368604029,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxNzQwNTU5","number":4175,"title":"Modify Get-DbaService to allow collecting Clustered state and Version information","user":{"login":"sqllensman","id":8676242,"node_id":"MDQ6VXNlcjg2NzYyNDI=","avatar_url":"https://avatars0.githubusercontent.com/u/8676242?v=4","gravatar_id":"","url":"https://api.github.com/users/sqllensman","html_url":"https://github.com/sqllensman","followers_url":"https://api.github.com/users/sqllensman/followers","following_url":"https://api.github.com/users/sqllensman/following{/other_user}","gists_url":"https://api.github.com/users/sqllensman/gists{/gist_id}","starred_url":"https://api.github.com/users/sqllensman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sqllensman/subscriptions","organizations_url":"https://api.github.com/users/sqllensman/orgs","repos_url":"https://api.github.com/users/sqllensman/repos","events_url":"https://api.github.com/users/sqllensman/events{/privacy}","received_events_url":"https://api.github.com/users/sqllensman/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-10T10:41:59Z","updated_at":"2018-10-10T10:43:33Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/sqlcollaborative/dbatools/pulls/4175","html_url":"https://github.com/sqlcollaborative/dbatools/pull/4175","diff_url":"https://github.com/sqlcollaborative/dbatools/pull/4175.diff","patch_url":"https://github.com/sqlcollaborative/dbatools/pull/4175.patch"},"body":"<!-- Below information IS REQUIRED with every PR -->\r\n## Type of Change\r\n<!-- What type of change does your code introduce -->\r\n - [ ] Bug fix (non-breaking change, fixes #<enter issue number>)\r\n - [X] New feature (non-breaking change, adds functionality)\r\n - [ ] Breaking change (effects multiple commands or functionality)\r\n - [ ] Ran manual Pester test and has passed (`.\\tests\\manual.pester.ps1)\r\n - [ ] Adding code coverage to existing functionality\r\n - [X] Pester test is included\r\n - [ ] Nunit test is included\r\n - [X] Documentation\r\n - [ ] Build system\r\n \r\n<!-- Below this line you can erase anything that is not applicable -->\r\n### Purpose\r\nAdds an option to request additional information about SQL Server related services.\r\nBy default the command only gets data from the SqlService namespace. Additional information is available from the SqlServiceAdvancedProperty namespace. In particular information can be collected about Clustered status of Services, the software version and Sku.\r\n\r\n### Approach\r\nAdds a new switch to allow collecting data from SqlServiceAdvancedProperty namespace\r\n\r\n### Commands to test\r\nGet-DbaService\r\n\r\n### Learning\r\nBased on ideas in\r\nhttps://www.mssqltips.com/sqlservertip/2358/using-powershell-to-pull-sql-server-services-configuration-information/\r\n\r\nand \r\n\r\nhttps://github.com/proxb/PowerShell_Scripts/blob/master/Get-PSSQLInstance.ps1\r\n"},"comment":{"url":"https://api.github.com/repos/sqlcollaborative/dbatools/issues/comments/428525943","html_url":"https://github.com/sqlcollaborative/dbatools/pull/4175#issuecomment-428525943","issue_url":"https://api.github.com/repos/sqlcollaborative/dbatools/issues/4175","id":428525943,"node_id":"MDEyOklzc3VlQ29tbWVudDQyODUyNTk0Mw==","user":{"login":"potatoqualitee","id":8278033,"node_id":"MDQ6VXNlcjgyNzgwMzM=","avatar_url":"https://avatars1.githubusercontent.com/u/8278033?v=4","gravatar_id":"","url":"https://api.github.com/users/potatoqualitee","html_url":"https://github.com/potatoqualitee","followers_url":"https://api.github.com/users/potatoqualitee/followers","following_url":"https://api.github.com/users/potatoqualitee/following{/other_user}","gists_url":"https://api.github.com/users/potatoqualitee/gists{/gist_id}","starred_url":"https://api.github.com/users/potatoqualitee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/potatoqualitee/subscriptions","organizations_url":"https://api.github.com/users/potatoqualitee/orgs","repos_url":"https://api.github.com/users/potatoqualitee/repos","events_url":"https://api.github.com/users/potatoqualitee/events{/privacy}","received_events_url":"https://api.github.com/users/potatoqualitee/received_events","type":"User","site_admin":false},"created_at":"2018-10-10T10:43:33Z","updated_at":"2018-10-10T10:43:33Z","author_association":"MEMBER","body":"fabulous! thanks. I'll ask @nvarscar to take a look and approve for merging."}}
{"actor":{"display_login":"potatoqualitee"}}