{"action":"opened","number":261,"pull_request":{"url":"https://api.github.com/repos/rednex/rgbds/pulls/261","id":178941581,"html_url":"https://github.com/rednex/rgbds/pull/261","diff_url":"https://github.com/rednex/rgbds/pull/261.diff","patch_url":"https://github.com/rednex/rgbds/pull/261.patch","issue_url":"https://api.github.com/repos/rednex/rgbds/issues/261","number":261,"state":"open","locked":false,"title":"Enable a lot of GCC warnings and cleanup Makefile and compiler macros","user":{"login":"AntonioND","id":6632664,"avatar_url":"https://avatars0.githubusercontent.com/u/6632664?v=4","gravatar_id":"","url":"https://api.github.com/users/AntonioND","html_url":"https://github.com/AntonioND","followers_url":"https://api.github.com/users/AntonioND/followers","following_url":"https://api.github.com/users/AntonioND/following{/other_user}","gists_url":"https://api.github.com/users/AntonioND/gists{/gist_id}","starred_url":"https://api.github.com/users/AntonioND/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AntonioND/subscriptions","organizations_url":"https://api.github.com/users/AntonioND/orgs","repos_url":"https://api.github.com/users/AntonioND/repos","events_url":"https://api.github.com/users/AntonioND/events{/privacy}","received_events_url":"https://api.github.com/users/AntonioND/received_events","type":"User","site_admin":false},"body":"I've checked the GCC documentation and enabled most of the warnings that I saw that made sense to enable. As we are using `-Werror`, this can be a huge problem. Any change in the compiler may introduce a new warning that causes the build to stop.\r\n\r\nTo fix that, I've desabled `-Werror` from the default make target, now it is only enabled (along with all of the warnings) when doing `make develop`. The default target now only enables `-Wall`, which is far from enabling all compiler warnings.\r\n\r\nAlso, the file `stdnoreturn.h` has been modified to remove support for compilers that aren't actually tested. It now has defines for `__attribute__((unused))` and it has been renamed to `helpers.h`.","created_at":"2018-04-02T21:46:58Z","updated_at":"2018-04-02T21:46:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rednex/rgbds/pulls/261/commits","review_comments_url":"https://api.github.com/repos/rednex/rgbds/pulls/261/comments","review_comment_url":"https://api.github.com/repos/rednex/rgbds/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rednex/rgbds/issues/261/comments","statuses_url":"https://api.github.com/repos/rednex/rgbds/statuses/eb29c04d047a5d88d37517e9eb1f31cbb21ad280","head":{"label":"rednex:warnings","ref":"warnings","sha":"eb29c04d047a5d88d37517e9eb1f31cbb21ad280","user":{"login":"rednex","id":25339833,"avatar_url":"https://avatars1.githubusercontent.com/u/25339833?v=4","gravatar_id":"","url":"https://api.github.com/users/rednex","html_url":"https://github.com/rednex","followers_url":"https://api.github.com/users/rednex/followers","following_url":"https://api.github.com/users/rednex/following{/other_user}","gists_url":"https://api.github.com/users/rednex/gists{/gist_id}","starred_url":"https://api.github.com/users/rednex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rednex/subscriptions","organizations_url":"https://api.github.com/users/rednex/orgs","repos_url":"https://api.github.com/users/rednex/repos","events_url":"https://api.github.com/users/rednex/events{/privacy}","received_events_url":"https://api.github.com/users/rednex/received_events","type":"Organization","site_admin":false},"repo":{"id":304743,"name":"rgbds","full_name":"rednex/rgbds","owner":{"login":"rednex","id":25339833,"avatar_url":"https://avatars1.githubusercontent.com/u/25339833?v=4","gravatar_id":"","url":"https://api.github.com/users/rednex","html_url":"https://github.com/rednex","followers_url":"https://api.github.com/users/rednex/followers","following_url":"https://api.github.com/users/rednex/following{/other_user}","gists_url":"https://api.github.com/users/rednex/gists{/gist_id}","starred_url":"https://api.github.com/users/rednex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rednex/subscriptions","organizations_url":"https://api.github.com/users/rednex/orgs","repos_url":"https://api.github.com/users/rednex/repos","events_url":"https://api.github.com/users/rednex/events{/privacy}","received_events_url":"https://api.github.com/users/rednex/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rednex/rgbds","description":"Rednex Game Boy Development System","fork":false,"url":"https://api.github.com/repos/rednex/rgbds","forks_url":"https://api.github.com/repos/rednex/rgbds/forks","keys_url":"https://api.github.com/repos/rednex/rgbds/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rednex/rgbds/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rednex/rgbds/teams","hooks_url":"https://api.github.com/repos/rednex/rgbds/hooks","issue_events_url":"https://api.github.com/repos/rednex/rgbds/issues/events{/number}","events_url":"https://api.github.com/repos/rednex/rgbds/events","assignees_url":"https://api.github.com/repos/rednex/rgbds/assignees{/user}","branches_url":"https://api.github.com/repos/rednex/rgbds/branches{/branch}","tags_url":"https://api.github.com/repos/rednex/rgbds/tags","blobs_url":"https://api.github.com/repos/rednex/rgbds/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rednex/rgbds/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rednex/rgbds/git/refs{/sha}","trees_url":"https://api.github.com/repos/rednex/rgbds/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rednex/rgbds/statuses/{sha}","languages_url":"https://api.github.com/repos/rednex/rgbds/languages","stargazers_url":"https://api.github.com/repos/rednex/rgbds/stargazers","contributors_url":"https://api.github.com/repos/rednex/rgbds/contributors","subscribers_url":"https://api.github.com/repos/rednex/rgbds/subscribers","subscription_url":"https://api.github.com/repos/rednex/rgbds/subscription","commits_url":"https://api.github.com/repos/rednex/rgbds/commits{/sha}","git_commits_url":"https://api.github.com/repos/rednex/rgbds/git/commits{/sha}","comments_url":"https://api.github.com/repos/rednex/rgbds/comments{/number}","issue_comment_url":"https://api.github.com/repos/rednex/rgbds/issues/comments{/number}","contents_url":"https://api.github.com/repos/rednex/rgbds/contents/{+path}","compare_url":"https://api.github.com/repos/rednex/rgbds/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rednex/rgbds/merges","archive_url":"https://api.github.com/repos/rednex/rgbds/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rednex/rgbds/downloads","issues_url":"https://api.github.com/repos/rednex/rgbds/issues{/number}","pulls_url":"https://api.github.com/repos/rednex/rgbds/pulls{/number}","milestones_url":"https://api.github.com/repos/rednex/rgbds/milestones{/number}","notifications_url":"https://api.github.com/repos/rednex/rgbds/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rednex/rgbds/labels{/name}","releases_url":"https://api.github.com/repos/rednex/rgbds/releases{/id}","deployments_url":"https://api.github.com/repos/rednex/rgbds/deployments","created_at":"2009-09-12T03:33:35Z","updated_at":"2018-04-02T17:28:45Z","pushed_at":"2018-04-02T21:46:53Z","git_url":"git://github.com/rednex/rgbds.git","ssh_url":"git@github.com:rednex/rgbds.git","clone_url":"https://github.com/rednex/rgbds.git","svn_url":"https://github.com/rednex/rgbds","homepage":"https://rednex.github.io/rgbds/","size":1287,"stargazers_count":336,"watchers_count":336,"language":"C","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":49,"mirror_url":null,"archived":false,"open_issues_count":23,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":49,"open_issues":23,"watchers":336,"default_branch":"master"}},"base":{"label":"rednex:develop","ref":"develop","sha":"4d13d57491ab39034af7af05d4e42ea5a14793f2","user":{"login":"rednex","id":25339833,"avatar_url":"https://avatars1.githubusercontent.com/u/25339833?v=4","gravatar_id":"","url":"https://api.github.com/users/rednex","html_url":"https://github.com/rednex","followers_url":"https://api.github.com/users/rednex/followers","following_url":"https://api.github.com/users/rednex/following{/other_user}","gists_url":"https://api.github.com/users/rednex/gists{/gist_id}","starred_url":"https://api.github.com/users/rednex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rednex/subscriptions","organizations_url":"https://api.github.com/users/rednex/orgs","repos_url":"https://api.github.com/users/rednex/repos","events_url":"https://api.github.com/users/rednex/events{/privacy}","received_events_url":"https://api.github.com/users/rednex/received_events","type":"Organization","site_admin":false},"repo":{"id":304743,"name":"rgbds","full_name":"rednex/rgbds","owner":{"login":"rednex","id":25339833,"avatar_url":"https://avatars1.githubusercontent.com/u/25339833?v=4","gravatar_id":"","url":"https://api.github.com/users/rednex","html_url":"https://github.com/rednex","followers_url":"https://api.github.com/users/rednex/followers","following_url":"https://api.github.com/users/rednex/following{/other_user}","gists_url":"https://api.github.com/users/rednex/gists{/gist_id}","starred_url":"https://api.github.com/users/rednex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rednex/subscriptions","organizations_url":"https://api.github.com/users/rednex/orgs","repos_url":"https://api.github.com/users/rednex/repos","events_url":"https://api.github.com/users/rednex/events{/privacy}","received_events_url":"https://api.github.com/users/rednex/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rednex/rgbds","description":"Rednex Game Boy Development System","fork":false,"url":"https://api.github.com/repos/rednex/rgbds","forks_url":"https://api.github.com/repos/rednex/rgbds/forks","keys_url":"https://api.github.com/repos/rednex/rgbds/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rednex/rgbds/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rednex/rgbds/teams","hooks_url":"https://api.github.com/repos/rednex/rgbds/hooks","issue_events_url":"https://api.github.com/repos/rednex/rgbds/issues/events{/number}","events_url":"https://api.github.com/repos/rednex/rgbds/events","assignees_url":"https://api.github.com/repos/rednex/rgbds/assignees{/user}","branches_url":"https://api.github.com/repos/rednex/rgbds/branches{/branch}","tags_url":"https://api.github.com/repos/rednex/rgbds/tags","blobs_url":"https://api.github.com/repos/rednex/rgbds/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rednex/rgbds/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rednex/rgbds/git/refs{/sha}","trees_url":"https://api.github.com/repos/rednex/rgbds/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rednex/rgbds/statuses/{sha}","languages_url":"https://api.github.com/repos/rednex/rgbds/languages","stargazers_url":"https://api.github.com/repos/rednex/rgbds/stargazers","contributors_url":"https://api.github.com/repos/rednex/rgbds/contributors","subscribers_url":"https://api.github.com/repos/rednex/rgbds/subscribers","subscription_url":"https://api.github.com/repos/rednex/rgbds/subscription","commits_url":"https://api.github.com/repos/rednex/rgbds/commits{/sha}","git_commits_url":"https://api.github.com/repos/rednex/rgbds/git/commits{/sha}","comments_url":"https://api.github.com/repos/rednex/rgbds/comments{/number}","issue_comment_url":"https://api.github.com/repos/rednex/rgbds/issues/comments{/number}","contents_url":"https://api.github.com/repos/rednex/rgbds/contents/{+path}","compare_url":"https://api.github.com/repos/rednex/rgbds/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rednex/rgbds/merges","archive_url":"https://api.github.com/repos/rednex/rgbds/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rednex/rgbds/downloads","issues_url":"https://api.github.com/repos/rednex/rgbds/issues{/number}","pulls_url":"https://api.github.com/repos/rednex/rgbds/pulls{/number}","milestones_url":"https://api.github.com/repos/rednex/rgbds/milestones{/number}","notifications_url":"https://api.github.com/repos/rednex/rgbds/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rednex/rgbds/labels{/name}","releases_url":"https://api.github.com/repos/rednex/rgbds/releases{/id}","deployments_url":"https://api.github.com/repos/rednex/rgbds/deployments","created_at":"2009-09-12T03:33:35Z","updated_at":"2018-04-02T17:28:45Z","pushed_at":"2018-04-02T21:46:53Z","git_url":"git://github.com/rednex/rgbds.git","ssh_url":"git@github.com:rednex/rgbds.git","clone_url":"https://github.com/rednex/rgbds.git","svn_url":"https://github.com/rednex/rgbds","homepage":"https://rednex.github.io/rgbds/","size":1287,"stargazers_count":336,"watchers_count":336,"language":"C","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":49,"mirror_url":null,"archived":false,"open_issues_count":23,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":49,"open_issues":23,"watchers":336,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rednex/rgbds/pulls/261"},"html":{"href":"https://github.com/rednex/rgbds/pull/261"},"issue":{"href":"https://api.github.com/repos/rednex/rgbds/issues/261"},"comments":{"href":"https://api.github.com/repos/rednex/rgbds/issues/261/comments"},"review_comments":{"href":"https://api.github.com/repos/rednex/rgbds/pulls/261/comments"},"review_comment":{"href":"https://api.github.com/repos/rednex/rgbds/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rednex/rgbds/pulls/261/commits"},"statuses":{"href":"https://api.github.com/repos/rednex/rgbds/statuses/eb29c04d047a5d88d37517e9eb1f31cbb21ad280"}},"author_association":"OWNER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":12,"additions":149,"deletions":100,"changed_files":22}}
{"actor":{"display_login":"AntonioND"}}