{"action":"created","comment":{"url":"https://api.github.com/repos/Bahmni/bahmni-core/pulls/comments/189371666","pull_request_review_id":121545532,"id":189371666,"diff_hunk":"@@ -19,6 +20,12 @@\n                                                        String programAttributeFieldName, String[] addressSearchResultFields,\n                                                        String[] patientSearchResultFields, String loginLocationUuid, Boolean filterPatientsByLocation, Boolean filterOnAllIdentifiers);\n \n+    List<PatientResponse> getSimilarPatientsUsingLuceneSearch(String identifer, String name, String gender, String customAttribute,","path":"bahmnicore-api/src/main/java/org/bahmni/module/bahmnicore/dao/PatientDao.java","position":12,"original_position":12,"commit_id":"114c540a0ddb851b5213af64c4ba0595637b8fda","original_commit_id":"114c540a0ddb851b5213af64c4ba0595637b8fda","user":{"login":"djazayeri","id":1165236,"avatar_url":"https://avatars0.githubusercontent.com/u/1165236?v=4","gravatar_id":"","url":"https://api.github.com/users/djazayeri","html_url":"https://github.com/djazayeri","followers_url":"https://api.github.com/users/djazayeri/followers","following_url":"https://api.github.com/users/djazayeri/following{/other_user}","gists_url":"https://api.github.com/users/djazayeri/gists{/gist_id}","starred_url":"https://api.github.com/users/djazayeri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djazayeri/subscriptions","organizations_url":"https://api.github.com/users/djazayeri/orgs","repos_url":"https://api.github.com/users/djazayeri/repos","events_url":"https://api.github.com/users/djazayeri/events{/privacy}","received_events_url":"https://api.github.com/users/djazayeri/received_events","type":"User","site_admin":false},"body":"Do we really have to add another method here? The DAO isn't an external-facing interface so we should just be able to add a parameter to the above, right?","created_at":"2018-05-18T19:29:07Z","updated_at":"2018-05-18T19:45:23Z","html_url":"https://github.com/Bahmni/bahmni-core/pull/33#discussion_r189371666","pull_request_url":"https://api.github.com/repos/Bahmni/bahmni-core/pulls/33","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Bahmni/bahmni-core/pulls/comments/189371666"},"html":{"href":"https://github.com/Bahmni/bahmni-core/pull/33#discussion_r189371666"},"pull_request":{"href":"https://api.github.com/repos/Bahmni/bahmni-core/pulls/33"}}},"pull_request":{"url":"https://api.github.com/repos/Bahmni/bahmni-core/pulls/33","id":188328472,"html_url":"https://github.com/Bahmni/bahmni-core/pull/33","diff_url":"https://github.com/Bahmni/bahmni-core/pull/33.diff","patch_url":"https://github.com/Bahmni/bahmni-core/pull/33.patch","issue_url":"https://api.github.com/repos/Bahmni/bahmni-core/issues/33","number":33,"state":"open","locked":false,"title":"BAH-460 Add search similar patients API","user":{"login":"eyalgo","id":1395180,"avatar_url":"https://avatars2.githubusercontent.com/u/1395180?v=4","gravatar_id":"","url":"https://api.github.com/users/eyalgo","html_url":"https://github.com/eyalgo","followers_url":"https://api.github.com/users/eyalgo/followers","following_url":"https://api.github.com/users/eyalgo/following{/other_user}","gists_url":"https://api.github.com/users/eyalgo/gists{/gist_id}","starred_url":"https://api.github.com/users/eyalgo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eyalgo/subscriptions","organizations_url":"https://api.github.com/users/eyalgo/orgs","repos_url":"https://api.github.com/users/eyalgo/repos","events_url":"https://api.github.com/users/eyalgo/events{/privacy}","received_events_url":"https://api.github.com/users/eyalgo/received_events","type":"User","site_admin":false},"body":"- Add API for search similar patients in BahmniPatientService\r\n- Add API for similar patients in PatientDao\r\n- The search is done using Lucene","created_at":"2018-05-16T06:16:30Z","updated_at":"2018-05-18T19:45:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d0a12593cb91316657c5c7c5034180832366d1ae","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Bahmni/bahmni-core/pulls/33/commits","review_comments_url":"https://api.github.com/repos/Bahmni/bahmni-core/pulls/33/comments","review_comment_url":"https://api.github.com/repos/Bahmni/bahmni-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Bahmni/bahmni-core/issues/33/comments","statuses_url":"https://api.github.com/repos/Bahmni/bahmni-core/statuses/114c540a0ddb851b5213af64c4ba0595637b8fda","head":{"label":"eyalgo:master","ref":"master","sha":"114c540a0ddb851b5213af64c4ba0595637b8fda","user":{"login":"eyalgo","id":1395180,"avatar_url":"https://avatars2.githubusercontent.com/u/1395180?v=4","gravatar_id":"","url":"https://api.github.com/users/eyalgo","html_url":"https://github.com/eyalgo","followers_url":"https://api.github.com/users/eyalgo/followers","following_url":"https://api.github.com/users/eyalgo/following{/other_user}","gists_url":"https://api.github.com/users/eyalgo/gists{/gist_id}","starred_url":"https://api.github.com/users/eyalgo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eyalgo/subscriptions","organizations_url":"https://api.github.com/users/eyalgo/orgs","repos_url":"https://api.github.com/users/eyalgo/repos","events_url":"https://api.github.com/users/eyalgo/events{/privacy}","received_events_url":"https://api.github.com/users/eyalgo/received_events","type":"User","site_admin":false},"repo":{"id":133032357,"name":"bahmni-core","full_name":"eyalgo/bahmni-core","owner":{"login":"eyalgo","id":1395180,"avatar_url":"https://avatars2.githubusercontent.com/u/1395180?v=4","gravatar_id":"","url":"https://api.github.com/users/eyalgo","html_url":"https://github.com/eyalgo","followers_url":"https://api.github.com/users/eyalgo/followers","following_url":"https://api.github.com/users/eyalgo/following{/other_user}","gists_url":"https://api.github.com/users/eyalgo/gists{/gist_id}","starred_url":"https://api.github.com/users/eyalgo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eyalgo/subscriptions","organizations_url":"https://api.github.com/users/eyalgo/orgs","repos_url":"https://api.github.com/users/eyalgo/repos","events_url":"https://api.github.com/users/eyalgo/events{/privacy}","received_events_url":"https://api.github.com/users/eyalgo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eyalgo/bahmni-core","description":"Core OpenMRS modules for Bahmni (including ERP & ELIS Atom Feed Clients)","fork":true,"url":"https://api.github.com/repos/eyalgo/bahmni-core","forks_url":"https://api.github.com/repos/eyalgo/bahmni-core/forks","keys_url":"https://api.github.com/repos/eyalgo/bahmni-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eyalgo/bahmni-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eyalgo/bahmni-core/teams","hooks_url":"https://api.github.com/repos/eyalgo/bahmni-core/hooks","issue_events_url":"https://api.github.com/repos/eyalgo/bahmni-core/issues/events{/number}","events_url":"https://api.github.com/repos/eyalgo/bahmni-core/events","assignees_url":"https://api.github.com/repos/eyalgo/bahmni-core/assignees{/user}","branches_url":"https://api.github.com/repos/eyalgo/bahmni-core/branches{/branch}","tags_url":"https://api.github.com/repos/eyalgo/bahmni-core/tags","blobs_url":"https://api.github.com/repos/eyalgo/bahmni-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eyalgo/bahmni-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eyalgo/bahmni-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/eyalgo/bahmni-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eyalgo/bahmni-core/statuses/{sha}","languages_url":"https://api.github.com/repos/eyalgo/bahmni-core/languages","stargazers_url":"https://api.github.com/repos/eyalgo/bahmni-core/stargazers","contributors_url":"https://api.github.com/repos/eyalgo/bahmni-core/contributors","subscribers_url":"https://api.github.com/repos/eyalgo/bahmni-core/subscribers","subscription_url":"https://api.github.com/repos/eyalgo/bahmni-core/subscription","commits_url":"https://api.github.com/repos/eyalgo/bahmni-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/eyalgo/bahmni-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/eyalgo/bahmni-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/eyalgo/bahmni-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/eyalgo/bahmni-core/contents/{+path}","compare_url":"https://api.github.com/repos/eyalgo/bahmni-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eyalgo/bahmni-core/merges","archive_url":"https://api.github.com/repos/eyalgo/bahmni-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eyalgo/bahmni-core/downloads","issues_url":"https://api.github.com/repos/eyalgo/bahmni-core/issues{/number}","pulls_url":"https://api.github.com/repos/eyalgo/bahmni-core/pulls{/number}","milestones_url":"https://api.github.com/repos/eyalgo/bahmni-core/milestones{/number}","notifications_url":"https://api.github.com/repos/eyalgo/bahmni-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eyalgo/bahmni-core/labels{/name}","releases_url":"https://api.github.com/repos/eyalgo/bahmni-core/releases{/id}","deployments_url":"https://api.github.com/repos/eyalgo/bahmni-core/deployments","created_at":"2018-05-11T11:38:41Z","updated_at":"2018-05-17T16:03:12Z","pushed_at":"2018-05-17T16:03:10Z","git_url":"git://github.com/eyalgo/bahmni-core.git","ssh_url":"git@github.com:eyalgo/bahmni-core.git","clone_url":"https://github.com/eyalgo/bahmni-core.git","svn_url":"https://github.com/eyalgo/bahmni-core","homepage":"","size":7846,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Bahmni:master","ref":"master","sha":"4b82757328b83add989a1d0d914c0830e67cc401","user":{"login":"Bahmni","id":3725098,"avatar_url":"https://avatars0.githubusercontent.com/u/3725098?v=4","gravatar_id":"","url":"https://api.github.com/users/Bahmni","html_url":"https://github.com/Bahmni","followers_url":"https://api.github.com/users/Bahmni/followers","following_url":"https://api.github.com/users/Bahmni/following{/other_user}","gists_url":"https://api.github.com/users/Bahmni/gists{/gist_id}","starred_url":"https://api.github.com/users/Bahmni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bahmni/subscriptions","organizations_url":"https://api.github.com/users/Bahmni/orgs","repos_url":"https://api.github.com/users/Bahmni/repos","events_url":"https://api.github.com/users/Bahmni/events{/privacy}","received_events_url":"https://api.github.com/users/Bahmni/received_events","type":"Organization","site_admin":false},"repo":{"id":8854393,"name":"bahmni-core","full_name":"Bahmni/bahmni-core","owner":{"login":"Bahmni","id":3725098,"avatar_url":"https://avatars0.githubusercontent.com/u/3725098?v=4","gravatar_id":"","url":"https://api.github.com/users/Bahmni","html_url":"https://github.com/Bahmni","followers_url":"https://api.github.com/users/Bahmni/followers","following_url":"https://api.github.com/users/Bahmni/following{/other_user}","gists_url":"https://api.github.com/users/Bahmni/gists{/gist_id}","starred_url":"https://api.github.com/users/Bahmni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bahmni/subscriptions","organizations_url":"https://api.github.com/users/Bahmni/orgs","repos_url":"https://api.github.com/users/Bahmni/repos","events_url":"https://api.github.com/users/Bahmni/events{/privacy}","received_events_url":"https://api.github.com/users/Bahmni/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Bahmni/bahmni-core","description":"Core OpenMRS modules for Bahmni (including ERP & ELIS Atom Feed Clients)","fork":true,"url":"https://api.github.com/repos/Bahmni/bahmni-core","forks_url":"https://api.github.com/repos/Bahmni/bahmni-core/forks","keys_url":"https://api.github.com/repos/Bahmni/bahmni-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Bahmni/bahmni-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Bahmni/bahmni-core/teams","hooks_url":"https://api.github.com/repos/Bahmni/bahmni-core/hooks","issue_events_url":"https://api.github.com/repos/Bahmni/bahmni-core/issues/events{/number}","events_url":"https://api.github.com/repos/Bahmni/bahmni-core/events","assignees_url":"https://api.github.com/repos/Bahmni/bahmni-core/assignees{/user}","branches_url":"https://api.github.com/repos/Bahmni/bahmni-core/branches{/branch}","tags_url":"https://api.github.com/repos/Bahmni/bahmni-core/tags","blobs_url":"https://api.github.com/repos/Bahmni/bahmni-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Bahmni/bahmni-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Bahmni/bahmni-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/Bahmni/bahmni-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Bahmni/bahmni-core/statuses/{sha}","languages_url":"https://api.github.com/repos/Bahmni/bahmni-core/languages","stargazers_url":"https://api.github.com/repos/Bahmni/bahmni-core/stargazers","contributors_url":"https://api.github.com/repos/Bahmni/bahmni-core/contributors","subscribers_url":"https://api.github.com/repos/Bahmni/bahmni-core/subscribers","subscription_url":"https://api.github.com/repos/Bahmni/bahmni-core/subscription","commits_url":"https://api.github.com/repos/Bahmni/bahmni-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/Bahmni/bahmni-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/Bahmni/bahmni-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/Bahmni/bahmni-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/Bahmni/bahmni-core/contents/{+path}","compare_url":"https://api.github.com/repos/Bahmni/bahmni-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Bahmni/bahmni-core/merges","archive_url":"https://api.github.com/repos/Bahmni/bahmni-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Bahmni/bahmni-core/downloads","issues_url":"https://api.github.com/repos/Bahmni/bahmni-core/issues{/number}","pulls_url":"https://api.github.com/repos/Bahmni/bahmni-core/pulls{/number}","milestones_url":"https://api.github.com/repos/Bahmni/bahmni-core/milestones{/number}","notifications_url":"https://api.github.com/repos/Bahmni/bahmni-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Bahmni/bahmni-core/labels{/name}","releases_url":"https://api.github.com/repos/Bahmni/bahmni-core/releases{/id}","deployments_url":"https://api.github.com/repos/Bahmni/bahmni-core/deployments","created_at":"2013-03-18T13:11:01Z","updated_at":"2018-05-15T18:19:05Z","pushed_at":"2018-05-18T09:51:41Z","git_url":"git://github.com/Bahmni/bahmni-core.git","ssh_url":"git@github.com:Bahmni/bahmni-core.git","clone_url":"https://github.com/Bahmni/bahmni-core.git","svn_url":"https://github.com/Bahmni/bahmni-core","homepage":"","size":8172,"stargazers_count":48,"watchers_count":48,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":77,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":77,"open_issues":5,"watchers":48,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Bahmni/bahmni-core/pulls/33"},"html":{"href":"https://github.com/Bahmni/bahmni-core/pull/33"},"issue":{"href":"https://api.github.com/repos/Bahmni/bahmni-core/issues/33"},"comments":{"href":"https://api.github.com/repos/Bahmni/bahmni-core/issues/33/comments"},"review_comments":{"href":"https://api.github.com/repos/Bahmni/bahmni-core/pulls/33/comments"},"review_comment":{"href":"https://api.github.com/repos/Bahmni/bahmni-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Bahmni/bahmni-core/pulls/33/commits"},"statuses":{"href":"https://api.github.com/repos/Bahmni/bahmni-core/statuses/114c540a0ddb851b5213af64c4ba0595637b8fda"}},"author_association":"NONE"}}
{"actor":{"display_login":"djazayeri"}}