{"push_id":3130697595,"size":2,"distinct_size":1,"ref":"refs/heads/master","head":"2089f9737c7538dd5cc717d6748b3c419495656b","before":"3d5c620d3e2cbd7e848be76cd71466356a42c5ca","commits":[{"sha":"0a0af7c1a40a8e457db72ba5d702d7e8e4f5c630","author":{"name":"Dries Vints","email":"9818b0f8e34f57ac0059d0bc440479771e319166@gmail.com"},"message":"Do not update card in createAsStripeCustomer method\n\nAt the moment when using the createAsStripeCustomer method on a Billable entity, it could be that the creation of the customer succeeds but the updating of the card fails. When this happens it's impossible to know which customer was created in Stripe and therefor also impossible to remove this record again when the card update fails.\n\nIt seems that the updateCard method shouldn't be in the createAsStripeCustomer method as this couples these two API calls too much. If we remove the call from the createAsStripeCustomer method it can be used just for the purpose that it's states. This will always return a Customer object and allow the developer to remove it again if the updateCard method after that fails.\n\nThis is a breaking change which will require developers to call the updateCard method manually after call the createAsStripeCustomer. I've already adjusted the behavior of the getStripeCustomer call in the SubscriptionBuilder so there's no breaking changes there.\n\nYou might notice that at the moment the same problem exists for the getStripeCustomer call but at least with these changes the developers have full control to first create the customer and then do a try/catch check around the updateCard method and revert the customer creation if they want.\n\nThis will require changes to the docs as well which I'll send in as soon as this PR is merged.\n\nFixes https://github.com/laravel/cashier/issues/575","distinct":false,"url":"https://api.github.com/repos/laravel/cashier/commits/0a0af7c1a40a8e457db72ba5d702d7e8e4f5c630"},{"sha":"2089f9737c7538dd5cc717d6748b3c419495656b","author":{"name":"Taylor Otwell","email":"5d74ae093a16a00e5af127763f2dc7e13988f162@laravel.com"},"message":"Merge pull request #588 from laravel/update-customer-methods\n\n[9.0] Do not update card in createAsStripeCustomer method","distinct":true,"url":"https://api.github.com/repos/laravel/cashier/commits/2089f9737c7538dd5cc717d6748b3c419495656b"}]}
{"actor":{"display_login":"taylorotwell"}}