{"action":"created","issue":{"url":"https://api.github.com/repos/triplea-game/triplea/issues/4332","repository_url":"https://api.github.com/repos/triplea-game/triplea","labels_url":"https://api.github.com/repos/triplea-game/triplea/issues/4332/labels{/name}","comments_url":"https://api.github.com/repos/triplea-game/triplea/issues/4332/comments","events_url":"https://api.github.com/repos/triplea-game/triplea/issues/4332/events","html_url":"https://github.com/triplea-game/triplea/pull/4332","id":378825944,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5NDM4NDM3","number":4332,"title":"Checkstyle: Fix naming violations in Version","user":{"login":"ssoloff","id":4826349,"node_id":"MDQ6VXNlcjQ4MjYzNDk=","avatar_url":"https://avatars2.githubusercontent.com/u/4826349?v=4","gravatar_id":"","url":"https://api.github.com/users/ssoloff","html_url":"https://github.com/ssoloff","followers_url":"https://api.github.com/users/ssoloff/followers","following_url":"https://api.github.com/users/ssoloff/following{/other_user}","gists_url":"https://api.github.com/users/ssoloff/gists{/gist_id}","starred_url":"https://api.github.com/users/ssoloff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssoloff/subscriptions","organizations_url":"https://api.github.com/users/ssoloff/orgs","repos_url":"https://api.github.com/users/ssoloff/repos","events_url":"https://api.github.com/users/ssoloff/events{/privacy}","received_events_url":"https://api.github.com/users/ssoloff/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-11-08T16:55:52Z","updated_at":"2018-11-08T17:56:48Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/triplea-game/triplea/pulls/4332","html_url":"https://github.com/triplea-game/triplea/pull/4332","diff_url":"https://github.com/triplea-game/triplea/pull/4332.diff","patch_url":"https://github.com/triplea-game/triplea/pull/4332.patch"},"body":"## Overview\r\n\r\nFixes violations of the Checkstyle MemberName rule in the `Version` class.\r\n\r\n## Functional Changes\r\n\r\nNone.\r\n\r\n## Manual Testing Performed\r\n\r\nI couldn't find any usages where instances of `Version` are serialized between a lobby client and lobby server (the string representations are serialized but not the `Version`s themselves), but, just to be safe, I verified a lobby client from this branch could connect to an 11996 lobby server.\r\n\r\n## Additional Review Notes\r\n\r\n@simon33-2 This is going to conflict with #4234.  I will submit a PR to your fork that resolves the conflicts there."},"comment":{"url":"https://api.github.com/repos/triplea-game/triplea/issues/comments/437095971","html_url":"https://github.com/triplea-game/triplea/pull/4332#issuecomment-437095971","issue_url":"https://api.github.com/repos/triplea-game/triplea/issues/4332","id":437095971,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNzA5NTk3MQ==","user":{"login":"ssoloff","id":4826349,"node_id":"MDQ6VXNlcjQ4MjYzNDk=","avatar_url":"https://avatars2.githubusercontent.com/u/4826349?v=4","gravatar_id":"","url":"https://api.github.com/users/ssoloff","html_url":"https://github.com/ssoloff","followers_url":"https://api.github.com/users/ssoloff/followers","following_url":"https://api.github.com/users/ssoloff/following{/other_user}","gists_url":"https://api.github.com/users/ssoloff/gists{/gist_id}","starred_url":"https://api.github.com/users/ssoloff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssoloff/subscriptions","organizations_url":"https://api.github.com/users/ssoloff/orgs","repos_url":"https://api.github.com/users/ssoloff/repos","events_url":"https://api.github.com/users/ssoloff/events{/privacy}","received_events_url":"https://api.github.com/users/ssoloff/received_events","type":"User","site_admin":false},"created_at":"2018-11-08T17:56:48Z","updated_at":"2018-11-08T17:56:48Z","author_association":"MEMBER","body":"> The version object is currently used to verify that a given savegame is compatible and works perfectly without any problems.\r\n\r\n@RoiEXLab That's a good point and something we should be concerned about.  However, it still seems to works as before, just with a slightly misleading error message.  Instead of saying the user is trying to load a 1.10 save game into a 1.9 engine, it says the user is trying to load a 0.0 save game into a 1.9 engine.  But it otherwise prevents the user from loading the game.\r\n\r\nSo other than mislabeling the save game version, the behavior to gracefully not load the game appears to still work."}}
{"actor":{"display_login":"ssoloff"}}