{"action":"created","comment":{"url":"https://api.github.com/repos/josegonzalez/sm/pulls/comments/233527737","pull_request_review_id":174962962,"id":233527737,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzUyNzczNw==","diff_hunk":"@@ -4,12 +4,17 @@ import (\n \t\"fmt\"\n \t\"io/ioutil\"\n \t\"log\"\n+\t\"os\"\n+\t\"strconv\"\n \t\"sync\"\n+\t\"time\"\n \n-\t\"github.com/agilebits/sm/secrets\"\n+\t\"github.com/josegonzalez/sm/secrets\"","path":"cmd/decrypt-all.go","position":10,"original_position":10,"commit_id":"0b57c402d5453841ef284600d3c24a78496d82a4","original_commit_id":"0b57c402d5453841ef284600d3c24a78496d82a4","user":{"login":"jippi","id":22841,"node_id":"MDQ6VXNlcjIyODQx","avatar_url":"https://avatars0.githubusercontent.com/u/22841?v=4","gravatar_id":"","url":"https://api.github.com/users/jippi","html_url":"https://github.com/jippi","followers_url":"https://api.github.com/users/jippi/followers","following_url":"https://api.github.com/users/jippi/following{/other_user}","gists_url":"https://api.github.com/users/jippi/gists{/gist_id}","starred_url":"https://api.github.com/users/jippi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jippi/subscriptions","organizations_url":"https://api.github.com/users/jippi/orgs","repos_url":"https://api.github.com/users/jippi/repos","events_url":"https://api.github.com/users/jippi/events{/privacy}","received_events_url":"https://api.github.com/users/jippi/received_events","type":"User","site_admin":false},"body":"also been open for 1y now, so chances are likely 0 :) ","created_at":"2018-11-14T16:44:52Z","updated_at":"2018-11-14T16:44:53Z","html_url":"https://github.com/josegonzalez/sm/pull/1#discussion_r233527737","pull_request_url":"https://api.github.com/repos/josegonzalez/sm/pulls/1","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/josegonzalez/sm/pulls/comments/233527737"},"html":{"href":"https://github.com/josegonzalez/sm/pull/1#discussion_r233527737"},"pull_request":{"href":"https://api.github.com/repos/josegonzalez/sm/pulls/1"}},"in_reply_to_id":233524727},"pull_request":{"url":"https://api.github.com/repos/josegonzalez/sm/pulls/1","id":230795595,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwNzk1NTk1","html_url":"https://github.com/josegonzalez/sm/pull/1","diff_url":"https://github.com/josegonzalez/sm/pull/1.diff","patch_url":"https://github.com/josegonzalez/sm/pull/1.patch","issue_url":"https://api.github.com/repos/josegonzalez/sm/issues/1","number":1,"state":"open","locked":false,"title":"efficient bulk-decrypt with concurrency control","user":{"login":"jippi","id":22841,"node_id":"MDQ6VXNlcjIyODQx","avatar_url":"https://avatars0.githubusercontent.com/u/22841?v=4","gravatar_id":"","url":"https://api.github.com/users/jippi","html_url":"https://github.com/jippi","followers_url":"https://api.github.com/users/jippi/followers","following_url":"https://api.github.com/users/jippi/following{/other_user}","gists_url":"https://api.github.com/users/jippi/gists{/gist_id}","starred_url":"https://api.github.com/users/jippi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jippi/subscriptions","organizations_url":"https://api.github.com/users/jippi/orgs","repos_url":"https://api.github.com/users/jippi/repos","events_url":"https://api.github.com/users/jippi/events{/privacy}","received_events_url":"https://api.github.com/users/jippi/received_events","type":"User","site_admin":false},"body":"Also fixed bad references to `agilebits`\r\n\r\nTests with different worker count against an internal repo\r\n\r\nHigh concurrencies often get \"stuck\" temp waiting for AWS, so likely some throttle on their side. \r\n`WORKER_COUNT =25` was found to be a sweet spot between fast and consistent performance without throttling \r\n\r\n```\r\nWORKER_COUNT=50 sm decrypt-all  0.93s user 0.41s system 20% cpu 6.678 total\r\nWORKER_COUNT=50 sm decrypt-all  0.84s user 0.38s system 79% cpu 1.538 total\r\nWORKER_COUNT=50 sm decrypt-all  0.94s user 0.44s system 19% cpu 7.186 total\r\n\r\nWORKER_COUNT=40 sm decrypt-all  0.79s user 0.37s system 66% cpu 1.735 total\r\nWORKER_COUNT=40 sm decrypt-all  0.79s user 0.38s system 61% cpu 1.920 total\r\nWORKER_COUNT=40 sm decrypt-all  0.75s user 0.35s system 57% cpu 1.917 total\r\n\r\nWORKER_COUNT=30 sm decrypt-all  0.72s user 0.35s system 51% cpu 2.067 total\r\nWORKER_COUNT=30 sm decrypt-all  0.73s user 0.37s system 47% cpu 2.349 total\r\nWORKER_COUNT=30 sm decrypt-all  0.75s user 0.37s system 47% cpu 2.360 total\r\n\r\nWORKER_COUNT=25 sm decrypt-all  0.67s user 0.36s system 43% cpu 2.343 total\r\nWORKER_COUNT=25 sm decrypt-all  0.64s user 0.36s system 37% cpu 2.671 total\r\nWORKER_COUNT=25 sm decrypt-all  0.75s user 0.38s system 43% cpu 2.614 total\r\n\r\nWORKER_COUNT=20 sm decrypt-all  0.74s user 0.38s system 39% cpu 2.825 total\r\nWORKER_COUNT=20 sm decrypt-all  0.67s user 0.35s system 35% cpu 2.895 total\r\nWORKER_COUNT=20 sm decrypt-all  0.61s user 0.35s system 34% cpu 2.744 total\r\n\r\nWORKER_COUNT=10 sm decrypt-all  0.43s user 0.32s system 15% cpu 4.831 total \r\nWORKER_COUNT=10 sm decrypt-all  0.59s user 0.36s system 19% cpu 4.893 total\r\nWORKER_COUNT=10 sm decrypt-all  0.50s user 0.35s system 17% cpu 4.868 total\r\n```\r\n\r\nSigned-off-by: Christian Winther <jippignu@gmail.com>","created_at":"2018-11-14T11:08:50Z","updated_at":"2018-11-14T16:44:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9c388e008a58162227222c131ef13087da600ee6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/josegonzalez/sm/pulls/1/commits","review_comments_url":"https://api.github.com/repos/josegonzalez/sm/pulls/1/comments","review_comment_url":"https://api.github.com/repos/josegonzalez/sm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/josegonzalez/sm/issues/1/comments","statuses_url":"https://api.github.com/repos/josegonzalez/sm/statuses/0b57c402d5453841ef284600d3c24a78496d82a4","head":{"label":"jippi:more-efficient-decrypt","ref":"more-efficient-decrypt","sha":"0b57c402d5453841ef284600d3c24a78496d82a4","user":{"login":"jippi","id":22841,"node_id":"MDQ6VXNlcjIyODQx","avatar_url":"https://avatars0.githubusercontent.com/u/22841?v=4","gravatar_id":"","url":"https://api.github.com/users/jippi","html_url":"https://github.com/jippi","followers_url":"https://api.github.com/users/jippi/followers","following_url":"https://api.github.com/users/jippi/following{/other_user}","gists_url":"https://api.github.com/users/jippi/gists{/gist_id}","starred_url":"https://api.github.com/users/jippi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jippi/subscriptions","organizations_url":"https://api.github.com/users/jippi/orgs","repos_url":"https://api.github.com/users/jippi/repos","events_url":"https://api.github.com/users/jippi/events{/privacy}","received_events_url":"https://api.github.com/users/jippi/received_events","type":"User","site_admin":false},"repo":{"id":157536456,"node_id":"MDEwOlJlcG9zaXRvcnkxNTc1MzY0NTY=","name":"sm","full_name":"jippi/sm","private":false,"owner":{"login":"jippi","id":22841,"node_id":"MDQ6VXNlcjIyODQx","avatar_url":"https://avatars0.githubusercontent.com/u/22841?v=4","gravatar_id":"","url":"https://api.github.com/users/jippi","html_url":"https://github.com/jippi","followers_url":"https://api.github.com/users/jippi/followers","following_url":"https://api.github.com/users/jippi/following{/other_user}","gists_url":"https://api.github.com/users/jippi/gists{/gist_id}","starred_url":"https://api.github.com/users/jippi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jippi/subscriptions","organizations_url":"https://api.github.com/users/jippi/orgs","repos_url":"https://api.github.com/users/jippi/repos","events_url":"https://api.github.com/users/jippi/events{/privacy}","received_events_url":"https://api.github.com/users/jippi/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jippi/sm","description":"Simple secret management tool for server configuration","fork":true,"url":"https://api.github.com/repos/jippi/sm","forks_url":"https://api.github.com/repos/jippi/sm/forks","keys_url":"https://api.github.com/repos/jippi/sm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jippi/sm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jippi/sm/teams","hooks_url":"https://api.github.com/repos/jippi/sm/hooks","issue_events_url":"https://api.github.com/repos/jippi/sm/issues/events{/number}","events_url":"https://api.github.com/repos/jippi/sm/events","assignees_url":"https://api.github.com/repos/jippi/sm/assignees{/user}","branches_url":"https://api.github.com/repos/jippi/sm/branches{/branch}","tags_url":"https://api.github.com/repos/jippi/sm/tags","blobs_url":"https://api.github.com/repos/jippi/sm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jippi/sm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jippi/sm/git/refs{/sha}","trees_url":"https://api.github.com/repos/jippi/sm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jippi/sm/statuses/{sha}","languages_url":"https://api.github.com/repos/jippi/sm/languages","stargazers_url":"https://api.github.com/repos/jippi/sm/stargazers","contributors_url":"https://api.github.com/repos/jippi/sm/contributors","subscribers_url":"https://api.github.com/repos/jippi/sm/subscribers","subscription_url":"https://api.github.com/repos/jippi/sm/subscription","commits_url":"https://api.github.com/repos/jippi/sm/commits{/sha}","git_commits_url":"https://api.github.com/repos/jippi/sm/git/commits{/sha}","comments_url":"https://api.github.com/repos/jippi/sm/comments{/number}","issue_comment_url":"https://api.github.com/repos/jippi/sm/issues/comments{/number}","contents_url":"https://api.github.com/repos/jippi/sm/contents/{+path}","compare_url":"https://api.github.com/repos/jippi/sm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jippi/sm/merges","archive_url":"https://api.github.com/repos/jippi/sm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jippi/sm/downloads","issues_url":"https://api.github.com/repos/jippi/sm/issues{/number}","pulls_url":"https://api.github.com/repos/jippi/sm/pulls{/number}","milestones_url":"https://api.github.com/repos/jippi/sm/milestones{/number}","notifications_url":"https://api.github.com/repos/jippi/sm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jippi/sm/labels{/name}","releases_url":"https://api.github.com/repos/jippi/sm/releases{/id}","deployments_url":"https://api.github.com/repos/jippi/sm/deployments","created_at":"2018-11-14T11:07:57Z","updated_at":"2018-11-14T11:07:59Z","pushed_at":"2018-11-14T11:38:51Z","git_url":"git://github.com/jippi/sm.git","ssh_url":"git@github.com:jippi/sm.git","clone_url":"https://github.com/jippi/sm.git","svn_url":"https://github.com/jippi/sm","homepage":null,"size":48,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"josegonzalez:master","ref":"master","sha":"0eced3ad55645a0362ff6ad684e518ea1fd5a229","user":{"login":"josegonzalez","id":65675,"node_id":"MDQ6VXNlcjY1Njc1","avatar_url":"https://avatars2.githubusercontent.com/u/65675?v=4","gravatar_id":"","url":"https://api.github.com/users/josegonzalez","html_url":"https://github.com/josegonzalez","followers_url":"https://api.github.com/users/josegonzalez/followers","following_url":"https://api.github.com/users/josegonzalez/following{/other_user}","gists_url":"https://api.github.com/users/josegonzalez/gists{/gist_id}","starred_url":"https://api.github.com/users/josegonzalez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josegonzalez/subscriptions","organizations_url":"https://api.github.com/users/josegonzalez/orgs","repos_url":"https://api.github.com/users/josegonzalez/repos","events_url":"https://api.github.com/users/josegonzalez/events{/privacy}","received_events_url":"https://api.github.com/users/josegonzalez/received_events","type":"User","site_admin":false},"repo":{"id":105820314,"node_id":"MDEwOlJlcG9zaXRvcnkxMDU4MjAzMTQ=","name":"sm","full_name":"josegonzalez/sm","private":false,"owner":{"login":"josegonzalez","id":65675,"node_id":"MDQ6VXNlcjY1Njc1","avatar_url":"https://avatars2.githubusercontent.com/u/65675?v=4","gravatar_id":"","url":"https://api.github.com/users/josegonzalez","html_url":"https://github.com/josegonzalez","followers_url":"https://api.github.com/users/josegonzalez/followers","following_url":"https://api.github.com/users/josegonzalez/following{/other_user}","gists_url":"https://api.github.com/users/josegonzalez/gists{/gist_id}","starred_url":"https://api.github.com/users/josegonzalez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josegonzalez/subscriptions","organizations_url":"https://api.github.com/users/josegonzalez/orgs","repos_url":"https://api.github.com/users/josegonzalez/repos","events_url":"https://api.github.com/users/josegonzalez/events{/privacy}","received_events_url":"https://api.github.com/users/josegonzalez/received_events","type":"User","site_admin":false},"html_url":"https://github.com/josegonzalez/sm","description":"Simple secret management tool for server configuration","fork":true,"url":"https://api.github.com/repos/josegonzalez/sm","forks_url":"https://api.github.com/repos/josegonzalez/sm/forks","keys_url":"https://api.github.com/repos/josegonzalez/sm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/josegonzalez/sm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/josegonzalez/sm/teams","hooks_url":"https://api.github.com/repos/josegonzalez/sm/hooks","issue_events_url":"https://api.github.com/repos/josegonzalez/sm/issues/events{/number}","events_url":"https://api.github.com/repos/josegonzalez/sm/events","assignees_url":"https://api.github.com/repos/josegonzalez/sm/assignees{/user}","branches_url":"https://api.github.com/repos/josegonzalez/sm/branches{/branch}","tags_url":"https://api.github.com/repos/josegonzalez/sm/tags","blobs_url":"https://api.github.com/repos/josegonzalez/sm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/josegonzalez/sm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/josegonzalez/sm/git/refs{/sha}","trees_url":"https://api.github.com/repos/josegonzalez/sm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/josegonzalez/sm/statuses/{sha}","languages_url":"https://api.github.com/repos/josegonzalez/sm/languages","stargazers_url":"https://api.github.com/repos/josegonzalez/sm/stargazers","contributors_url":"https://api.github.com/repos/josegonzalez/sm/contributors","subscribers_url":"https://api.github.com/repos/josegonzalez/sm/subscribers","subscription_url":"https://api.github.com/repos/josegonzalez/sm/subscription","commits_url":"https://api.github.com/repos/josegonzalez/sm/commits{/sha}","git_commits_url":"https://api.github.com/repos/josegonzalez/sm/git/commits{/sha}","comments_url":"https://api.github.com/repos/josegonzalez/sm/comments{/number}","issue_comment_url":"https://api.github.com/repos/josegonzalez/sm/issues/comments{/number}","contents_url":"https://api.github.com/repos/josegonzalez/sm/contents/{+path}","compare_url":"https://api.github.com/repos/josegonzalez/sm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/josegonzalez/sm/merges","archive_url":"https://api.github.com/repos/josegonzalez/sm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/josegonzalez/sm/downloads","issues_url":"https://api.github.com/repos/josegonzalez/sm/issues{/number}","pulls_url":"https://api.github.com/repos/josegonzalez/sm/pulls{/number}","milestones_url":"https://api.github.com/repos/josegonzalez/sm/milestones{/number}","notifications_url":"https://api.github.com/repos/josegonzalez/sm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/josegonzalez/sm/labels{/name}","releases_url":"https://api.github.com/repos/josegonzalez/sm/releases{/id}","deployments_url":"https://api.github.com/repos/josegonzalez/sm/deployments","created_at":"2017-10-04T21:28:23Z","updated_at":"2018-11-09T23:41:29Z","pushed_at":"2018-11-14T11:38:53Z","git_url":"git://github.com/josegonzalez/sm.git","ssh_url":"git@github.com:josegonzalez/sm.git","clone_url":"https://github.com/josegonzalez/sm.git","svn_url":"https://github.com/josegonzalez/sm","homepage":null,"size":37,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/josegonzalez/sm/pulls/1"},"html":{"href":"https://github.com/josegonzalez/sm/pull/1"},"issue":{"href":"https://api.github.com/repos/josegonzalez/sm/issues/1"},"comments":{"href":"https://api.github.com/repos/josegonzalez/sm/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/josegonzalez/sm/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/josegonzalez/sm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/josegonzalez/sm/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/josegonzalez/sm/statuses/0b57c402d5453841ef284600d3c24a78496d82a4"}},"author_association":"NONE"}}
{"actor":{"display_login":"jippi"}}