{"action":"created","comment":{"url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/pulls/comments/176095177","pull_request_review_id":105737227,"id":176095177,"diff_hunk":"@@ -135,6 +137,20 @@ private void UpdateInspectionSeverity(Configuration config)\n                 return results;\n             }\n \n+            private static bool RequiredLibrariesArePresent(IInspection inspection, RubberduckParserState state)\n+            {\n+                var requiredLibraries = inspection.GetType().GetCustomAttributes<RequiredLibraryAttribute>().ToArray();\n+\n+                if (!requiredLibraries.Any())\n+                {\n+                    return true;\n+                }\n+\n+                var projectNames = state.DeclarationFinder.Projects.Where(project => project.IsUserDefined == false).Select(project => project.ProjectName).ToArray();","path":"Rubberduck.Inspections/Inspector.cs","position":35,"original_position":35,"commit_id":"0db91ddb817464514bed016641afbbf0c680ae48","original_commit_id":"0db91ddb817464514bed016641afbbf0c680ae48","user":{"login":"retailcoder","id":5751684,"avatar_url":"https://avatars2.githubusercontent.com/u/5751684?v=4","gravatar_id":"","url":"https://api.github.com/users/retailcoder","html_url":"https://github.com/retailcoder","followers_url":"https://api.github.com/users/retailcoder/followers","following_url":"https://api.github.com/users/retailcoder/following{/other_user}","gists_url":"https://api.github.com/users/retailcoder/gists{/gist_id}","starred_url":"https://api.github.com/users/retailcoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/retailcoder/subscriptions","organizations_url":"https://api.github.com/users/retailcoder/orgs","repos_url":"https://api.github.com/users/retailcoder/repos","events_url":"https://api.github.com/users/retailcoder/events{/privacy}","received_events_url":"https://api.github.com/users/retailcoder/received_events","type":"User","site_admin":false},"body":"why not `!project.IsUserDefined` instead of `project.IsUserDefined == false`?","created_at":"2018-03-21T14:13:25Z","updated_at":"2018-03-21T14:13:25Z","html_url":"https://github.com/rubberduck-vba/Rubberduck/pull/3834#discussion_r176095177","pull_request_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/pulls/3834","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/rubberduck-vba/Rubberduck/pulls/comments/176095177"},"html":{"href":"https://github.com/rubberduck-vba/Rubberduck/pull/3834#discussion_r176095177"},"pull_request":{"href":"https://api.github.com/repos/rubberduck-vba/Rubberduck/pulls/3834"}}},"pull_request":{"url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/pulls/3834","id":174250057,"html_url":"https://github.com/rubberduck-vba/Rubberduck/pull/3834","diff_url":"https://github.com/rubberduck-vba/Rubberduck/pull/3834.diff","patch_url":"https://github.com/rubberduck-vba/Rubberduck/pull/3834.patch","issue_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/issues/3834","number":3834,"state":"open","locked":false,"title":"SheetAccessedUsingString inspection","user":{"login":"rkapka","id":28876818,"avatar_url":"https://avatars3.githubusercontent.com/u/28876818?v=4","gravatar_id":"","url":"https://api.github.com/users/rkapka","html_url":"https://github.com/rkapka","followers_url":"https://api.github.com/users/rkapka/followers","following_url":"https://api.github.com/users/rkapka/following{/other_user}","gists_url":"https://api.github.com/users/rkapka/gists{/gist_id}","starred_url":"https://api.github.com/users/rkapka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rkapka/subscriptions","organizations_url":"https://api.github.com/users/rkapka/orgs","repos_url":"https://api.github.com/users/rkapka/repos","events_url":"https://api.github.com/users/rkapka/events{/privacy}","received_events_url":"https://api.github.com/users/rkapka/received_events","type":"User","site_admin":false},"body":"Closes #1926 \r\n\r\nOne thing that bothers me is that the rewriter leaves empty lines and spaces after removing declarations. In the tests I expect the whitespace in the output, which is pretty ridiculous. I checked how `RemoveUnusedDeclarationQuickFix` works (it doesn't leave the whitespace, at least not for variable declarations), but it just calls `Remove` on the declaration. Could it be because of the inspection's result type, which is `DeclarationInspectionResult`? I doubt this, because the same class is used in `LineLabelNotUsedInspection` and the quick fix leaves an empty line where the label was... I'm confused 😕 ","created_at":"2018-03-11T23:48:54Z","updated_at":"2018-03-21T14:13:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"03fd91bc1e8e83b2713a2bb91674ca678da18ea1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/pulls/3834/commits","review_comments_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/pulls/3834/comments","review_comment_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/issues/3834/comments","statuses_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/statuses/0db91ddb817464514bed016641afbbf0c680ae48","head":{"label":"rkapka:rkapka-master","ref":"rkapka-master","sha":"0db91ddb817464514bed016641afbbf0c680ae48","user":{"login":"rkapka","id":28876818,"avatar_url":"https://avatars3.githubusercontent.com/u/28876818?v=4","gravatar_id":"","url":"https://api.github.com/users/rkapka","html_url":"https://github.com/rkapka","followers_url":"https://api.github.com/users/rkapka/followers","following_url":"https://api.github.com/users/rkapka/following{/other_user}","gists_url":"https://api.github.com/users/rkapka/gists{/gist_id}","starred_url":"https://api.github.com/users/rkapka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rkapka/subscriptions","organizations_url":"https://api.github.com/users/rkapka/orgs","repos_url":"https://api.github.com/users/rkapka/repos","events_url":"https://api.github.com/users/rkapka/events{/privacy}","received_events_url":"https://api.github.com/users/rkapka/received_events","type":"User","site_admin":false},"repo":{"id":92099900,"name":"Rubberduck","full_name":"rkapka/Rubberduck","owner":{"login":"rkapka","id":28876818,"avatar_url":"https://avatars3.githubusercontent.com/u/28876818?v=4","gravatar_id":"","url":"https://api.github.com/users/rkapka","html_url":"https://github.com/rkapka","followers_url":"https://api.github.com/users/rkapka/followers","following_url":"https://api.github.com/users/rkapka/following{/other_user}","gists_url":"https://api.github.com/users/rkapka/gists{/gist_id}","starred_url":"https://api.github.com/users/rkapka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rkapka/subscriptions","organizations_url":"https://api.github.com/users/rkapka/orgs","repos_url":"https://api.github.com/users/rkapka/repos","events_url":"https://api.github.com/users/rkapka/events{/privacy}","received_events_url":"https://api.github.com/users/rkapka/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rkapka/Rubberduck","description":"Every programmer needs a rubberduck. COM add-in for the VBA IDE (VBE).","fork":true,"url":"https://api.github.com/repos/rkapka/Rubberduck","forks_url":"https://api.github.com/repos/rkapka/Rubberduck/forks","keys_url":"https://api.github.com/repos/rkapka/Rubberduck/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rkapka/Rubberduck/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rkapka/Rubberduck/teams","hooks_url":"https://api.github.com/repos/rkapka/Rubberduck/hooks","issue_events_url":"https://api.github.com/repos/rkapka/Rubberduck/issues/events{/number}","events_url":"https://api.github.com/repos/rkapka/Rubberduck/events","assignees_url":"https://api.github.com/repos/rkapka/Rubberduck/assignees{/user}","branches_url":"https://api.github.com/repos/rkapka/Rubberduck/branches{/branch}","tags_url":"https://api.github.com/repos/rkapka/Rubberduck/tags","blobs_url":"https://api.github.com/repos/rkapka/Rubberduck/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rkapka/Rubberduck/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rkapka/Rubberduck/git/refs{/sha}","trees_url":"https://api.github.com/repos/rkapka/Rubberduck/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rkapka/Rubberduck/statuses/{sha}","languages_url":"https://api.github.com/repos/rkapka/Rubberduck/languages","stargazers_url":"https://api.github.com/repos/rkapka/Rubberduck/stargazers","contributors_url":"https://api.github.com/repos/rkapka/Rubberduck/contributors","subscribers_url":"https://api.github.com/repos/rkapka/Rubberduck/subscribers","subscription_url":"https://api.github.com/repos/rkapka/Rubberduck/subscription","commits_url":"https://api.github.com/repos/rkapka/Rubberduck/commits{/sha}","git_commits_url":"https://api.github.com/repos/rkapka/Rubberduck/git/commits{/sha}","comments_url":"https://api.github.com/repos/rkapka/Rubberduck/comments{/number}","issue_comment_url":"https://api.github.com/repos/rkapka/Rubberduck/issues/comments{/number}","contents_url":"https://api.github.com/repos/rkapka/Rubberduck/contents/{+path}","compare_url":"https://api.github.com/repos/rkapka/Rubberduck/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rkapka/Rubberduck/merges","archive_url":"https://api.github.com/repos/rkapka/Rubberduck/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rkapka/Rubberduck/downloads","issues_url":"https://api.github.com/repos/rkapka/Rubberduck/issues{/number}","pulls_url":"https://api.github.com/repos/rkapka/Rubberduck/pulls{/number}","milestones_url":"https://api.github.com/repos/rkapka/Rubberduck/milestones{/number}","notifications_url":"https://api.github.com/repos/rkapka/Rubberduck/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rkapka/Rubberduck/labels{/name}","releases_url":"https://api.github.com/repos/rkapka/Rubberduck/releases{/id}","deployments_url":"https://api.github.com/repos/rkapka/Rubberduck/deployments","created_at":"2017-05-22T21:12:45Z","updated_at":"2017-05-22T21:12:51Z","pushed_at":"2018-03-20T22:44:46Z","git_url":"git://github.com/rkapka/Rubberduck.git","ssh_url":"git@github.com:rkapka/Rubberduck.git","clone_url":"https://github.com/rkapka/Rubberduck.git","svn_url":"https://github.com/rkapka/Rubberduck","homepage":"","size":43945,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"next"}},"base":{"label":"rubberduck-vba:next","ref":"next","sha":"7a599fe61eefd866fa702a71662d86fba6f946e6","user":{"login":"rubberduck-vba","id":12832254,"avatar_url":"https://avatars0.githubusercontent.com/u/12832254?v=4","gravatar_id":"","url":"https://api.github.com/users/rubberduck-vba","html_url":"https://github.com/rubberduck-vba","followers_url":"https://api.github.com/users/rubberduck-vba/followers","following_url":"https://api.github.com/users/rubberduck-vba/following{/other_user}","gists_url":"https://api.github.com/users/rubberduck-vba/gists{/gist_id}","starred_url":"https://api.github.com/users/rubberduck-vba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubberduck-vba/subscriptions","organizations_url":"https://api.github.com/users/rubberduck-vba/orgs","repos_url":"https://api.github.com/users/rubberduck-vba/repos","events_url":"https://api.github.com/users/rubberduck-vba/events{/privacy}","received_events_url":"https://api.github.com/users/rubberduck-vba/received_events","type":"Organization","site_admin":false},"repo":{"id":25800128,"name":"Rubberduck","full_name":"rubberduck-vba/Rubberduck","owner":{"login":"rubberduck-vba","id":12832254,"avatar_url":"https://avatars0.githubusercontent.com/u/12832254?v=4","gravatar_id":"","url":"https://api.github.com/users/rubberduck-vba","html_url":"https://github.com/rubberduck-vba","followers_url":"https://api.github.com/users/rubberduck-vba/followers","following_url":"https://api.github.com/users/rubberduck-vba/following{/other_user}","gists_url":"https://api.github.com/users/rubberduck-vba/gists{/gist_id}","starred_url":"https://api.github.com/users/rubberduck-vba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubberduck-vba/subscriptions","organizations_url":"https://api.github.com/users/rubberduck-vba/orgs","repos_url":"https://api.github.com/users/rubberduck-vba/repos","events_url":"https://api.github.com/users/rubberduck-vba/events{/privacy}","received_events_url":"https://api.github.com/users/rubberduck-vba/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rubberduck-vba/Rubberduck","description":"Every programmer needs a rubberduck. COM add-in for the VBA IDE (VBE).","fork":false,"url":"https://api.github.com/repos/rubberduck-vba/Rubberduck","forks_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/forks","keys_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/teams","hooks_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/hooks","issue_events_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/issues/events{/number}","events_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/events","assignees_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/assignees{/user}","branches_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/branches{/branch}","tags_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/tags","blobs_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/git/refs{/sha}","trees_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/statuses/{sha}","languages_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/languages","stargazers_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/stargazers","contributors_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/contributors","subscribers_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/subscribers","subscription_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/subscription","commits_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/commits{/sha}","git_commits_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/git/commits{/sha}","comments_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/comments{/number}","issue_comment_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/issues/comments{/number}","contents_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/contents/{+path}","compare_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/merges","archive_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/downloads","issues_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/issues{/number}","pulls_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/pulls{/number}","milestones_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/milestones{/number}","notifications_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/labels{/name}","releases_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/releases{/id}","deployments_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/deployments","created_at":"2014-10-27T02:35:11Z","updated_at":"2018-03-21T13:42:52Z","pushed_at":"2018-03-21T05:29:54Z","git_url":"git://github.com/rubberduck-vba/Rubberduck.git","ssh_url":"git@github.com:rubberduck-vba/Rubberduck.git","clone_url":"https://github.com/rubberduck-vba/Rubberduck.git","svn_url":"https://github.com/rubberduck-vba/Rubberduck","homepage":"","size":44316,"stargazers_count":566,"watchers_count":566,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":152,"mirror_url":null,"archived":false,"open_issues_count":634,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":152,"open_issues":634,"watchers":566,"default_branch":"next"}},"_links":{"self":{"href":"https://api.github.com/repos/rubberduck-vba/Rubberduck/pulls/3834"},"html":{"href":"https://github.com/rubberduck-vba/Rubberduck/pull/3834"},"issue":{"href":"https://api.github.com/repos/rubberduck-vba/Rubberduck/issues/3834"},"comments":{"href":"https://api.github.com/repos/rubberduck-vba/Rubberduck/issues/3834/comments"},"review_comments":{"href":"https://api.github.com/repos/rubberduck-vba/Rubberduck/pulls/3834/comments"},"review_comment":{"href":"https://api.github.com/repos/rubberduck-vba/Rubberduck/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rubberduck-vba/Rubberduck/pulls/3834/commits"},"statuses":{"href":"https://api.github.com/repos/rubberduck-vba/Rubberduck/statuses/0db91ddb817464514bed016641afbbf0c680ae48"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"retailcoder"}}