{"action":"created","issue":{"url":"https://api.github.com/repos/google/gopacket/issues/487","repository_url":"https://api.github.com/repos/google/gopacket","labels_url":"https://api.github.com/repos/google/gopacket/issues/487/labels{/name}","comments_url":"https://api.github.com/repos/google/gopacket/issues/487/comments","events_url":"https://api.github.com/repos/google/gopacket/issues/487/events","html_url":"https://github.com/google/gopacket/issues/487","id":342294709,"node_id":"MDU6SXNzdWUzNDIyOTQ3MDk=","number":487,"title":"reassembly: Flush might close half connection and cause data loss.","user":{"login":"noibar","id":14787829,"node_id":"MDQ6VXNlcjE0Nzg3ODI5","avatar_url":"https://avatars0.githubusercontent.com/u/14787829?v=4","gravatar_id":"","url":"https://api.github.com/users/noibar","html_url":"https://github.com/noibar","followers_url":"https://api.github.com/users/noibar/followers","following_url":"https://api.github.com/users/noibar/following{/other_user}","gists_url":"https://api.github.com/users/noibar/gists{/gist_id}","starred_url":"https://api.github.com/users/noibar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noibar/subscriptions","organizations_url":"https://api.github.com/users/noibar/orgs","repos_url":"https://api.github.com/users/noibar/repos","events_url":"https://api.github.com/users/noibar/events{/privacy}","received_events_url":"https://api.github.com/users/noibar/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-07-18T11:49:45Z","updated_at":"2018-07-18T20:03:47Z","closed_at":"2018-07-18T20:03:47Z","author_association":"CONTRIBUTOR","body":"If assembler.FlushWithOptions is called, and one of the halfConnection is seen only before the specified time, half of the connection is closed. If another packet that belongs to this halfConnection is received, the stream pool returns the main connection, with half connection closed, and the data is discarded without and error or log message. \r\n\r\n```go:\r\n func (a *Assembler) AssembleWithContext(netFlow gopacket.Flow, t *layers.TCP, ac AssemblerContext) {\r\n    // ...\r\n\r\n    if half.closed {\r\n        return\r\n    }\r\n\r\n    // ...\r\n}\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/google/gopacket/issues/comments/406056798","html_url":"https://github.com/google/gopacket/issues/487#issuecomment-406056798","issue_url":"https://api.github.com/repos/google/gopacket/issues/487","id":406056798,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNjA1Njc5OA==","user":{"login":"lhausermann","id":7381663,"node_id":"MDQ6VXNlcjczODE2NjM=","avatar_url":"https://avatars2.githubusercontent.com/u/7381663?v=4","gravatar_id":"","url":"https://api.github.com/users/lhausermann","html_url":"https://github.com/lhausermann","followers_url":"https://api.github.com/users/lhausermann/followers","following_url":"https://api.github.com/users/lhausermann/following{/other_user}","gists_url":"https://api.github.com/users/lhausermann/gists{/gist_id}","starred_url":"https://api.github.com/users/lhausermann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lhausermann/subscriptions","organizations_url":"https://api.github.com/users/lhausermann/orgs","repos_url":"https://api.github.com/users/lhausermann/repos","events_url":"https://api.github.com/users/lhausermann/events{/privacy}","received_events_url":"https://api.github.com/users/lhausermann/received_events","type":"User","site_admin":false},"created_at":"2018-07-18T20:03:46Z","updated_at":"2018-07-18T20:03:46Z","author_association":"COLLABORATOR","body":"Great @noibar , second bug fixed into @sentryo contribution (defrag and reassembly)\r\nHey, we are hiring by the way ;-)"}}
{"actor":{"display_login":"lhausermann"}}