{"action":"closed","number":134,"pull_request":{"url":"https://api.github.com/repos/cyverse/atmosphere-ansible/pulls/134","id":162731021,"html_url":"https://github.com/cyverse/atmosphere-ansible/pull/134","diff_url":"https://github.com/cyverse/atmosphere-ansible/pull/134.diff","patch_url":"https://github.com/cyverse/atmosphere-ansible/pull/134.patch","issue_url":"https://api.github.com/repos/cyverse/atmosphere-ansible/issues/134","number":134,"state":"closed","locked":false,"title":"Problem: instances fail to boot if a volume is removed outside of Atmosphere","user":{"login":"calvinmclean","id":19335917,"avatar_url":"https://avatars2.githubusercontent.com/u/19335917?v=4","gravatar_id":"","url":"https://api.github.com/users/calvinmclean","html_url":"https://github.com/calvinmclean","followers_url":"https://api.github.com/users/calvinmclean/followers","following_url":"https://api.github.com/users/calvinmclean/following{/other_user}","gists_url":"https://api.github.com/users/calvinmclean/gists{/gist_id}","starred_url":"https://api.github.com/users/calvinmclean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calvinmclean/subscriptions","organizations_url":"https://api.github.com/users/calvinmclean/orgs","repos_url":"https://api.github.com/users/calvinmclean/repos","events_url":"https://api.github.com/users/calvinmclean/events{/privacy}","received_events_url":"https://api.github.com/users/calvinmclean/received_events","type":"User","site_admin":false},"body":"If a volume is removed without using the [atmosphere-ansible unmount_volume playbook](https://github.com/cyverse/atmosphere-ansible/blob/master/ansible/playbooks/instance_actions/unmount_volume.yml), the instance will fail to boot after being rebooted/redeployed/resumed because a disk in `/etc/fstab` is missing. It appears to be stuck in \"Networking\" which is confusing since it is not a networking problem.\r\n\r\nOnce a failure like this is diagnosed, it is still not straightforward or easy to fix.\r\n\r\nThis PR adds the 'nobootwait' or 'nofail' option to the `/etc/fstab` line of the mounted disk. This allows instances to boot even if the volume is missing. 'nofail' is used on all instances except Ubuntu 14 instances which use 'nobootwait'. These fstab changes are made for ephemeral disks and mounted volumes.","created_at":"2018-01-12T21:39:10Z","updated_at":"2018-03-05T19:24:52Z","closed_at":"2018-03-05T19:24:52Z","merged_at":null,"merge_commit_sha":"7b0c7d33e5a2d9e8d5928e487eceeec1fd963cc3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cyverse/atmosphere-ansible/pulls/134/commits","review_comments_url":"https://api.github.com/repos/cyverse/atmosphere-ansible/pulls/134/comments","review_comment_url":"https://api.github.com/repos/cyverse/atmosphere-ansible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cyverse/atmosphere-ansible/issues/134/comments","statuses_url":"https://api.github.com/repos/cyverse/atmosphere-ansible/statuses/eab99315d6f21a6298fbd267272711dca3f6e879","head":{"label":"calvinmclean:fstab-mount-opts","ref":"fstab-mount-opts","sha":"eab99315d6f21a6298fbd267272711dca3f6e879","user":{"login":"calvinmclean","id":19335917,"avatar_url":"https://avatars2.githubusercontent.com/u/19335917?v=4","gravatar_id":"","url":"https://api.github.com/users/calvinmclean","html_url":"https://github.com/calvinmclean","followers_url":"https://api.github.com/users/calvinmclean/followers","following_url":"https://api.github.com/users/calvinmclean/following{/other_user}","gists_url":"https://api.github.com/users/calvinmclean/gists{/gist_id}","starred_url":"https://api.github.com/users/calvinmclean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calvinmclean/subscriptions","organizations_url":"https://api.github.com/users/calvinmclean/orgs","repos_url":"https://api.github.com/users/calvinmclean/repos","events_url":"https://api.github.com/users/calvinmclean/events{/privacy}","received_events_url":"https://api.github.com/users/calvinmclean/received_events","type":"User","site_admin":false},"repo":{"id":61568201,"name":"atmosphere-ansible","full_name":"calvinmclean/atmosphere-ansible","owner":{"login":"calvinmclean","id":19335917,"avatar_url":"https://avatars2.githubusercontent.com/u/19335917?v=4","gravatar_id":"","url":"https://api.github.com/users/calvinmclean","html_url":"https://github.com/calvinmclean","followers_url":"https://api.github.com/users/calvinmclean/followers","following_url":"https://api.github.com/users/calvinmclean/following{/other_user}","gists_url":"https://api.github.com/users/calvinmclean/gists{/gist_id}","starred_url":"https://api.github.com/users/calvinmclean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calvinmclean/subscriptions","organizations_url":"https://api.github.com/users/calvinmclean/orgs","repos_url":"https://api.github.com/users/calvinmclean/repos","events_url":"https://api.github.com/users/calvinmclean/events{/privacy}","received_events_url":"https://api.github.com/users/calvinmclean/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/calvinmclean/atmosphere-ansible","description":"Ansible instance deployment code for Atmosphere","fork":true,"url":"https://api.github.com/repos/calvinmclean/atmosphere-ansible","forks_url":"https://api.github.com/repos/calvinmclean/atmosphere-ansible/forks","keys_url":"https://api.github.com/repos/calvinmclean/atmosphere-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/calvinmclean/atmosphere-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/calvinmclean/atmosphere-ansible/teams","hooks_url":"https://api.github.com/repos/calvinmclean/atmosphere-ansible/hooks","issue_events_url":"https://api.github.com/repos/calvinmclean/atmosphere-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/calvinmclean/atmosphere-ansible/events","assignees_url":"https://api.github.com/repos/calvinmclean/atmosphere-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/calvinmclean/atmosphere-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/calvinmclean/atmosphere-ansible/tags","blobs_url":"https://api.github.com/repos/calvinmclean/atmosphere-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/calvinmclean/atmosphere-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/calvinmclean/atmosphere-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/calvinmclean/atmosphere-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/calvinmclean/atmosphere-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/calvinmclean/atmosphere-ansible/languages","stargazers_url":"https://api.github.com/repos/calvinmclean/atmosphere-ansible/stargazers","contributors_url":"https://api.github.com/repos/calvinmclean/atmosphere-ansible/contributors","subscribers_url":"https://api.github.com/repos/calvinmclean/atmosphere-ansible/subscribers","subscription_url":"https://api.github.com/repos/calvinmclean/atmosphere-ansible/subscription","commits_url":"https://api.github.com/repos/calvinmclean/atmosphere-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/calvinmclean/atmosphere-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/calvinmclean/atmosphere-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/calvinmclean/atmosphere-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/calvinmclean/atmosphere-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/calvinmclean/atmosphere-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/calvinmclean/atmosphere-ansible/merges","archive_url":"https://api.github.com/repos/calvinmclean/atmosphere-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/calvinmclean/atmosphere-ansible/downloads","issues_url":"https://api.github.com/repos/calvinmclean/atmosphere-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/calvinmclean/atmosphere-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/calvinmclean/atmosphere-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/calvinmclean/atmosphere-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/calvinmclean/atmosphere-ansible/labels{/name}","releases_url":"https://api.github.com/repos/calvinmclean/atmosphere-ansible/releases{/id}","deployments_url":"https://api.github.com/repos/calvinmclean/atmosphere-ansible/deployments","created_at":"2016-06-20T17:48:51Z","updated_at":"2017-06-29T16:12:44Z","pushed_at":"2018-03-02T22:36:36Z","git_url":"git://github.com/calvinmclean/atmosphere-ansible.git","ssh_url":"git@github.com:calvinmclean/atmosphere-ansible.git","clone_url":"https://github.com/calvinmclean/atmosphere-ansible.git","svn_url":"https://github.com/calvinmclean/atmosphere-ansible","homepage":"","size":200729,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cyverse:master","ref":"master","sha":"7095707e5286b820133bd4db937f64f35da00397","user":{"login":"cyverse","id":15638129,"avatar_url":"https://avatars0.githubusercontent.com/u/15638129?v=4","gravatar_id":"","url":"https://api.github.com/users/cyverse","html_url":"https://github.com/cyverse","followers_url":"https://api.github.com/users/cyverse/followers","following_url":"https://api.github.com/users/cyverse/following{/other_user}","gists_url":"https://api.github.com/users/cyverse/gists{/gist_id}","starred_url":"https://api.github.com/users/cyverse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyverse/subscriptions","organizations_url":"https://api.github.com/users/cyverse/orgs","repos_url":"https://api.github.com/users/cyverse/repos","events_url":"https://api.github.com/users/cyverse/events{/privacy}","received_events_url":"https://api.github.com/users/cyverse/received_events","type":"Organization","site_admin":false},"repo":{"id":45134022,"name":"atmosphere-ansible","full_name":"cyverse/atmosphere-ansible","owner":{"login":"cyverse","id":15638129,"avatar_url":"https://avatars0.githubusercontent.com/u/15638129?v=4","gravatar_id":"","url":"https://api.github.com/users/cyverse","html_url":"https://github.com/cyverse","followers_url":"https://api.github.com/users/cyverse/followers","following_url":"https://api.github.com/users/cyverse/following{/other_user}","gists_url":"https://api.github.com/users/cyverse/gists{/gist_id}","starred_url":"https://api.github.com/users/cyverse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyverse/subscriptions","organizations_url":"https://api.github.com/users/cyverse/orgs","repos_url":"https://api.github.com/users/cyverse/repos","events_url":"https://api.github.com/users/cyverse/events{/privacy}","received_events_url":"https://api.github.com/users/cyverse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cyverse/atmosphere-ansible","description":"Ansible instance deployment code for Atmosphere","fork":false,"url":"https://api.github.com/repos/cyverse/atmosphere-ansible","forks_url":"https://api.github.com/repos/cyverse/atmosphere-ansible/forks","keys_url":"https://api.github.com/repos/cyverse/atmosphere-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cyverse/atmosphere-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cyverse/atmosphere-ansible/teams","hooks_url":"https://api.github.com/repos/cyverse/atmosphere-ansible/hooks","issue_events_url":"https://api.github.com/repos/cyverse/atmosphere-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/cyverse/atmosphere-ansible/events","assignees_url":"https://api.github.com/repos/cyverse/atmosphere-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/cyverse/atmosphere-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/cyverse/atmosphere-ansible/tags","blobs_url":"https://api.github.com/repos/cyverse/atmosphere-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cyverse/atmosphere-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cyverse/atmosphere-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/cyverse/atmosphere-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cyverse/atmosphere-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/cyverse/atmosphere-ansible/languages","stargazers_url":"https://api.github.com/repos/cyverse/atmosphere-ansible/stargazers","contributors_url":"https://api.github.com/repos/cyverse/atmosphere-ansible/contributors","subscribers_url":"https://api.github.com/repos/cyverse/atmosphere-ansible/subscribers","subscription_url":"https://api.github.com/repos/cyverse/atmosphere-ansible/subscription","commits_url":"https://api.github.com/repos/cyverse/atmosphere-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/cyverse/atmosphere-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/cyverse/atmosphere-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/cyverse/atmosphere-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/cyverse/atmosphere-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/cyverse/atmosphere-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cyverse/atmosphere-ansible/merges","archive_url":"https://api.github.com/repos/cyverse/atmosphere-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cyverse/atmosphere-ansible/downloads","issues_url":"https://api.github.com/repos/cyverse/atmosphere-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/cyverse/atmosphere-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/cyverse/atmosphere-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/cyverse/atmosphere-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cyverse/atmosphere-ansible/labels{/name}","releases_url":"https://api.github.com/repos/cyverse/atmosphere-ansible/releases{/id}","deployments_url":"https://api.github.com/repos/cyverse/atmosphere-ansible/deployments","created_at":"2015-10-28T18:37:27Z","updated_at":"2017-06-19T18:36:38Z","pushed_at":"2018-03-05T19:24:25Z","git_url":"git://github.com/cyverse/atmosphere-ansible.git","ssh_url":"git@github.com:cyverse/atmosphere-ansible.git","clone_url":"https://github.com/cyverse/atmosphere-ansible.git","svn_url":"https://github.com/cyverse/atmosphere-ansible","homepage":"","size":200715,"stargazers_count":3,"watchers_count":3,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":15,"open_issues":11,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cyverse/atmosphere-ansible/pulls/134"},"html":{"href":"https://github.com/cyverse/atmosphere-ansible/pull/134"},"issue":{"href":"https://api.github.com/repos/cyverse/atmosphere-ansible/issues/134"},"comments":{"href":"https://api.github.com/repos/cyverse/atmosphere-ansible/issues/134/comments"},"review_comments":{"href":"https://api.github.com/repos/cyverse/atmosphere-ansible/pulls/134/comments"},"review_comment":{"href":"https://api.github.com/repos/cyverse/atmosphere-ansible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cyverse/atmosphere-ansible/pulls/134/commits"},"statuses":{"href":"https://api.github.com/repos/cyverse/atmosphere-ansible/statuses/eab99315d6f21a6298fbd267272711dca3f6e879"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":true,"rebaseable":false,"mergeable_state":"clean","merged_by":null,"comments":5,"review_comments":13,"maintainer_can_modify":false,"commits":11,"additions":40,"deletions":6,"changed_files":7}}
{"actor":{"display_login":"cdosborn"}}