{"action":"created","comment":{"url":"https://api.github.com/repos/MycroftAI/mycroft-core/pulls/comments/167804281","pull_request_review_id":96069985,"id":167804281,"diff_hunk":"@@ -22,6 +22,23 @@\n from mycroft.util.log import LOG\n \n \n+# The DisplayManager provides \"state\" for the visual representation associated\n+# with this Mycroft instance.  The current states are:\n+#   ActiveSkill - The skill that last interacted with the display via the\n+#                  Enclosure API.\n+#\n+# Currently, a wakeword sets the ActiveSkill to \"wakeword\", which will auto\n+# clear after 10 seconds.\n+#\n+# A skill is set to Active when it matches an intent, outputs audio, or\n+# changes the display via the EnclosureAPI()\n+#\n+# A skill is automatically cleared from Active two seconds after audio\n+# output is spoken, or 2 seconds after resetting the disply.\n+#\n+# So it is common to have \"\" as the active skill.","path":"mycroft/client/enclosure/display_manager.py","position":18,"original_position":18,"commit_id":"fa589fead4438a0b2167ba59dbb0abf369939cf7","original_commit_id":"fa589fead4438a0b2167ba59dbb0abf369939cf7","user":{"login":"forslund","id":804543,"avatar_url":"https://avatars0.githubusercontent.com/u/804543?v=4","gravatar_id":"","url":"https://api.github.com/users/forslund","html_url":"https://github.com/forslund","followers_url":"https://api.github.com/users/forslund/followers","following_url":"https://api.github.com/users/forslund/following{/other_user}","gists_url":"https://api.github.com/users/forslund/gists{/gist_id}","starred_url":"https://api.github.com/users/forslund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forslund/subscriptions","organizations_url":"https://api.github.com/users/forslund/orgs","repos_url":"https://api.github.com/users/forslund/repos","events_url":"https://api.github.com/users/forslund/events{/privacy}","received_events_url":"https://api.github.com/users/forslund/received_events","type":"User","site_admin":false},"body":"Feels like this should be a docstring instead of a comment block.","created_at":"2018-02-13T09:32:21Z","updated_at":"2018-02-13T09:46:46Z","html_url":"https://github.com/MycroftAI/mycroft-core/pull/1421#discussion_r167804281","pull_request_url":"https://api.github.com/repos/MycroftAI/mycroft-core/pulls/1421","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/MycroftAI/mycroft-core/pulls/comments/167804281"},"html":{"href":"https://github.com/MycroftAI/mycroft-core/pull/1421#discussion_r167804281"},"pull_request":{"href":"https://api.github.com/repos/MycroftAI/mycroft-core/pulls/1421"}}},"pull_request":{"url":"https://api.github.com/repos/MycroftAI/mycroft-core/pulls/1421","id":168785636,"html_url":"https://github.com/MycroftAI/mycroft-core/pull/1421","diff_url":"https://github.com/MycroftAI/mycroft-core/pull/1421.diff","patch_url":"https://github.com/MycroftAI/mycroft-core/pull/1421.patch","issue_url":"https://api.github.com/repos/MycroftAI/mycroft-core/issues/1421","number":1421,"state":"open","locked":false,"title":"Internal documentation, typos, remove misleading message","user":{"login":"penrods","id":16079445,"avatar_url":"https://avatars3.githubusercontent.com/u/16079445?v=4","gravatar_id":"","url":"https://api.github.com/users/penrods","html_url":"https://github.com/penrods","followers_url":"https://api.github.com/users/penrods/followers","following_url":"https://api.github.com/users/penrods/following{/other_user}","gists_url":"https://api.github.com/users/penrods/gists{/gist_id}","starred_url":"https://api.github.com/users/penrods/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/penrods/subscriptions","organizations_url":"https://api.github.com/users/penrods/orgs","repos_url":"https://api.github.com/users/penrods/repos","events_url":"https://api.github.com/users/penrods/events{/privacy}","received_events_url":"https://api.github.com/users/penrods/received_events","type":"User","site_admin":false},"body":"* Made MycroftSkill.remove_event() return a bool, preventing unnecessary/misleading message from being posted by MycroftSkill.cancel_scheduled_event()\r\n* More doc and several minor renames around intent processing\r\n* Several minor typo and doc corrections\r\n","created_at":"2018-02-13T08:54:56Z","updated_at":"2018-02-13T09:46:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"868258cb166fbf725f7859896194b1bd94669aec","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":664720248,"url":"https://api.github.com/repos/MycroftAI/mycroft-core/labels/CLA:%20Yes","name":"CLA: Yes","color":"0e8a16","default":false},{"id":572162072,"url":"https://api.github.com/repos/MycroftAI/mycroft-core/labels/tagged%20for%20review%20and%20potential%20merge","name":"tagged for review and potential merge","color":"d4c5f9","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/MycroftAI/mycroft-core/pulls/1421/commits","review_comments_url":"https://api.github.com/repos/MycroftAI/mycroft-core/pulls/1421/comments","review_comment_url":"https://api.github.com/repos/MycroftAI/mycroft-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MycroftAI/mycroft-core/issues/1421/comments","statuses_url":"https://api.github.com/repos/MycroftAI/mycroft-core/statuses/fa589fead4438a0b2167ba59dbb0abf369939cf7","head":{"label":"MycroftAI:feature/doc_cleanup","ref":"feature/doc_cleanup","sha":"fa589fead4438a0b2167ba59dbb0abf369939cf7","user":{"login":"MycroftAI","id":14171097,"avatar_url":"https://avatars0.githubusercontent.com/u/14171097?v=4","gravatar_id":"","url":"https://api.github.com/users/MycroftAI","html_url":"https://github.com/MycroftAI","followers_url":"https://api.github.com/users/MycroftAI/followers","following_url":"https://api.github.com/users/MycroftAI/following{/other_user}","gists_url":"https://api.github.com/users/MycroftAI/gists{/gist_id}","starred_url":"https://api.github.com/users/MycroftAI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MycroftAI/subscriptions","organizations_url":"https://api.github.com/users/MycroftAI/orgs","repos_url":"https://api.github.com/users/MycroftAI/repos","events_url":"https://api.github.com/users/MycroftAI/events{/privacy}","received_events_url":"https://api.github.com/users/MycroftAI/received_events","type":"Organization","site_admin":false},"repo":{"id":59299524,"name":"mycroft-core","full_name":"MycroftAI/mycroft-core","owner":{"login":"MycroftAI","id":14171097,"avatar_url":"https://avatars0.githubusercontent.com/u/14171097?v=4","gravatar_id":"","url":"https://api.github.com/users/MycroftAI","html_url":"https://github.com/MycroftAI","followers_url":"https://api.github.com/users/MycroftAI/followers","following_url":"https://api.github.com/users/MycroftAI/following{/other_user}","gists_url":"https://api.github.com/users/MycroftAI/gists{/gist_id}","starred_url":"https://api.github.com/users/MycroftAI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MycroftAI/subscriptions","organizations_url":"https://api.github.com/users/MycroftAI/orgs","repos_url":"https://api.github.com/users/MycroftAI/repos","events_url":"https://api.github.com/users/MycroftAI/events{/privacy}","received_events_url":"https://api.github.com/users/MycroftAI/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MycroftAI/mycroft-core","description":"Mycroft Core, the Mycroft Artificial Intelligence platform.","fork":false,"url":"https://api.github.com/repos/MycroftAI/mycroft-core","forks_url":"https://api.github.com/repos/MycroftAI/mycroft-core/forks","keys_url":"https://api.github.com/repos/MycroftAI/mycroft-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MycroftAI/mycroft-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MycroftAI/mycroft-core/teams","hooks_url":"https://api.github.com/repos/MycroftAI/mycroft-core/hooks","issue_events_url":"https://api.github.com/repos/MycroftAI/mycroft-core/issues/events{/number}","events_url":"https://api.github.com/repos/MycroftAI/mycroft-core/events","assignees_url":"https://api.github.com/repos/MycroftAI/mycroft-core/assignees{/user}","branches_url":"https://api.github.com/repos/MycroftAI/mycroft-core/branches{/branch}","tags_url":"https://api.github.com/repos/MycroftAI/mycroft-core/tags","blobs_url":"https://api.github.com/repos/MycroftAI/mycroft-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MycroftAI/mycroft-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MycroftAI/mycroft-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/MycroftAI/mycroft-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MycroftAI/mycroft-core/statuses/{sha}","languages_url":"https://api.github.com/repos/MycroftAI/mycroft-core/languages","stargazers_url":"https://api.github.com/repos/MycroftAI/mycroft-core/stargazers","contributors_url":"https://api.github.com/repos/MycroftAI/mycroft-core/contributors","subscribers_url":"https://api.github.com/repos/MycroftAI/mycroft-core/subscribers","subscription_url":"https://api.github.com/repos/MycroftAI/mycroft-core/subscription","commits_url":"https://api.github.com/repos/MycroftAI/mycroft-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/MycroftAI/mycroft-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/MycroftAI/mycroft-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/MycroftAI/mycroft-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/MycroftAI/mycroft-core/contents/{+path}","compare_url":"https://api.github.com/repos/MycroftAI/mycroft-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MycroftAI/mycroft-core/merges","archive_url":"https://api.github.com/repos/MycroftAI/mycroft-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MycroftAI/mycroft-core/downloads","issues_url":"https://api.github.com/repos/MycroftAI/mycroft-core/issues{/number}","pulls_url":"https://api.github.com/repos/MycroftAI/mycroft-core/pulls{/number}","milestones_url":"https://api.github.com/repos/MycroftAI/mycroft-core/milestones{/number}","notifications_url":"https://api.github.com/repos/MycroftAI/mycroft-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MycroftAI/mycroft-core/labels{/name}","releases_url":"https://api.github.com/repos/MycroftAI/mycroft-core/releases{/id}","deployments_url":"https://api.github.com/repos/MycroftAI/mycroft-core/deployments","created_at":"2016-05-20T14:11:07Z","updated_at":"2018-02-13T05:33:32Z","pushed_at":"2018-02-13T09:05:54Z","git_url":"git://github.com/MycroftAI/mycroft-core.git","ssh_url":"git@github.com:MycroftAI/mycroft-core.git","clone_url":"https://github.com/MycroftAI/mycroft-core.git","svn_url":"https://github.com/MycroftAI/mycroft-core","homepage":"https://mycroft.ai","size":94226,"stargazers_count":2005,"watchers_count":2005,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":493,"mirror_url":null,"archived":false,"open_issues_count":178,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":493,"open_issues":178,"watchers":2005,"default_branch":"dev"}},"base":{"label":"MycroftAI:dev","ref":"dev","sha":"acbebac87f09ea8d8a900b8b677de1de473e08ce","user":{"login":"MycroftAI","id":14171097,"avatar_url":"https://avatars0.githubusercontent.com/u/14171097?v=4","gravatar_id":"","url":"https://api.github.com/users/MycroftAI","html_url":"https://github.com/MycroftAI","followers_url":"https://api.github.com/users/MycroftAI/followers","following_url":"https://api.github.com/users/MycroftAI/following{/other_user}","gists_url":"https://api.github.com/users/MycroftAI/gists{/gist_id}","starred_url":"https://api.github.com/users/MycroftAI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MycroftAI/subscriptions","organizations_url":"https://api.github.com/users/MycroftAI/orgs","repos_url":"https://api.github.com/users/MycroftAI/repos","events_url":"https://api.github.com/users/MycroftAI/events{/privacy}","received_events_url":"https://api.github.com/users/MycroftAI/received_events","type":"Organization","site_admin":false},"repo":{"id":59299524,"name":"mycroft-core","full_name":"MycroftAI/mycroft-core","owner":{"login":"MycroftAI","id":14171097,"avatar_url":"https://avatars0.githubusercontent.com/u/14171097?v=4","gravatar_id":"","url":"https://api.github.com/users/MycroftAI","html_url":"https://github.com/MycroftAI","followers_url":"https://api.github.com/users/MycroftAI/followers","following_url":"https://api.github.com/users/MycroftAI/following{/other_user}","gists_url":"https://api.github.com/users/MycroftAI/gists{/gist_id}","starred_url":"https://api.github.com/users/MycroftAI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MycroftAI/subscriptions","organizations_url":"https://api.github.com/users/MycroftAI/orgs","repos_url":"https://api.github.com/users/MycroftAI/repos","events_url":"https://api.github.com/users/MycroftAI/events{/privacy}","received_events_url":"https://api.github.com/users/MycroftAI/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MycroftAI/mycroft-core","description":"Mycroft Core, the Mycroft Artificial Intelligence platform.","fork":false,"url":"https://api.github.com/repos/MycroftAI/mycroft-core","forks_url":"https://api.github.com/repos/MycroftAI/mycroft-core/forks","keys_url":"https://api.github.com/repos/MycroftAI/mycroft-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MycroftAI/mycroft-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MycroftAI/mycroft-core/teams","hooks_url":"https://api.github.com/repos/MycroftAI/mycroft-core/hooks","issue_events_url":"https://api.github.com/repos/MycroftAI/mycroft-core/issues/events{/number}","events_url":"https://api.github.com/repos/MycroftAI/mycroft-core/events","assignees_url":"https://api.github.com/repos/MycroftAI/mycroft-core/assignees{/user}","branches_url":"https://api.github.com/repos/MycroftAI/mycroft-core/branches{/branch}","tags_url":"https://api.github.com/repos/MycroftAI/mycroft-core/tags","blobs_url":"https://api.github.com/repos/MycroftAI/mycroft-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MycroftAI/mycroft-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MycroftAI/mycroft-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/MycroftAI/mycroft-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MycroftAI/mycroft-core/statuses/{sha}","languages_url":"https://api.github.com/repos/MycroftAI/mycroft-core/languages","stargazers_url":"https://api.github.com/repos/MycroftAI/mycroft-core/stargazers","contributors_url":"https://api.github.com/repos/MycroftAI/mycroft-core/contributors","subscribers_url":"https://api.github.com/repos/MycroftAI/mycroft-core/subscribers","subscription_url":"https://api.github.com/repos/MycroftAI/mycroft-core/subscription","commits_url":"https://api.github.com/repos/MycroftAI/mycroft-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/MycroftAI/mycroft-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/MycroftAI/mycroft-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/MycroftAI/mycroft-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/MycroftAI/mycroft-core/contents/{+path}","compare_url":"https://api.github.com/repos/MycroftAI/mycroft-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MycroftAI/mycroft-core/merges","archive_url":"https://api.github.com/repos/MycroftAI/mycroft-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MycroftAI/mycroft-core/downloads","issues_url":"https://api.github.com/repos/MycroftAI/mycroft-core/issues{/number}","pulls_url":"https://api.github.com/repos/MycroftAI/mycroft-core/pulls{/number}","milestones_url":"https://api.github.com/repos/MycroftAI/mycroft-core/milestones{/number}","notifications_url":"https://api.github.com/repos/MycroftAI/mycroft-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MycroftAI/mycroft-core/labels{/name}","releases_url":"https://api.github.com/repos/MycroftAI/mycroft-core/releases{/id}","deployments_url":"https://api.github.com/repos/MycroftAI/mycroft-core/deployments","created_at":"2016-05-20T14:11:07Z","updated_at":"2018-02-13T05:33:32Z","pushed_at":"2018-02-13T09:05:54Z","git_url":"git://github.com/MycroftAI/mycroft-core.git","ssh_url":"git@github.com:MycroftAI/mycroft-core.git","clone_url":"https://github.com/MycroftAI/mycroft-core.git","svn_url":"https://github.com/MycroftAI/mycroft-core","homepage":"https://mycroft.ai","size":94226,"stargazers_count":2005,"watchers_count":2005,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":493,"mirror_url":null,"archived":false,"open_issues_count":178,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":493,"open_issues":178,"watchers":2005,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/MycroftAI/mycroft-core/pulls/1421"},"html":{"href":"https://github.com/MycroftAI/mycroft-core/pull/1421"},"issue":{"href":"https://api.github.com/repos/MycroftAI/mycroft-core/issues/1421"},"comments":{"href":"https://api.github.com/repos/MycroftAI/mycroft-core/issues/1421/comments"},"review_comments":{"href":"https://api.github.com/repos/MycroftAI/mycroft-core/pulls/1421/comments"},"review_comment":{"href":"https://api.github.com/repos/MycroftAI/mycroft-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MycroftAI/mycroft-core/pulls/1421/commits"},"statuses":{"href":"https://api.github.com/repos/MycroftAI/mycroft-core/statuses/fa589fead4438a0b2167ba59dbb0abf369939cf7"}},"author_association":"OWNER"}}
{"actor":{"display_login":"forslund"}}