{"action":"created","issue":{"url":"https://api.github.com/repos/fancyapps/fancybox/issues/1827","repository_url":"https://api.github.com/repos/fancyapps/fancybox","labels_url":"https://api.github.com/repos/fancyapps/fancybox/issues/1827/labels{/name}","comments_url":"https://api.github.com/repos/fancyapps/fancybox/issues/1827/comments","events_url":"https://api.github.com/repos/fancyapps/fancybox/issues/1827/events","html_url":"https://github.com/fancyapps/fancybox/issues/1827","id":294977102,"number":1827,"title":"html dir=\"rtl\" Support - Use Absolute ltr direction","user":{"login":"Ezra-Siton-UIX","id":16711871,"avatar_url":"https://avatars3.githubusercontent.com/u/16711871?v=4","gravatar_id":"","url":"https://api.github.com/users/Ezra-Siton-UIX","html_url":"https://github.com/Ezra-Siton-UIX","followers_url":"https://api.github.com/users/Ezra-Siton-UIX/followers","following_url":"https://api.github.com/users/Ezra-Siton-UIX/following{/other_user}","gists_url":"https://api.github.com/users/Ezra-Siton-UIX/gists{/gist_id}","starred_url":"https://api.github.com/users/Ezra-Siton-UIX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ezra-Siton-UIX/subscriptions","organizations_url":"https://api.github.com/users/Ezra-Siton-UIX/orgs","repos_url":"https://api.github.com/users/Ezra-Siton-UIX/repos","events_url":"https://api.github.com/users/Ezra-Siton-UIX/events{/privacy}","received_events_url":"https://api.github.com/users/Ezra-Siton-UIX/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-02-07T01:43:34Z","updated_at":"2018-02-13T09:28:22Z","closed_at":"2018-02-13T09:28:22Z","author_association":"NONE","body":"I Don't know why in the code i find \"`direction: rtl;`\" (So I don't create pull Req). \r\n\r\n## Where?\r\nhttps://github.com/fancyapps/fancybox/blob/master/src/css/core.css\r\n\r\n## What?\r\non RTL sites \"dir=RTL\" added to html tag (By `W3C `[recommendation](https://www.w3.org/International/questions/qa-html-dir))\r\nThe styles inside `core.css` override my RTL direction\r\n\r\n## Before\r\n![image](https://user-images.githubusercontent.com/16711871/35894744-e7ac600e-0bbc-11e8-8a6e-98b847d11e0a.png)\r\n\r\n\r\nAll styles are flip (LTR) + caption: \"text-align: left\" (But in RTL the text-align is right) + The close btn should be on left-side in RTL\r\n\r\n## Solution \"After\"\r\nHer 3-4 lines of code i added to solve this issue (or remove the direction from the core code):\r\nhttps://codepen.io/ezra_siton/pen/oEzMBo\r\n\r\n```\r\n\r\n/* 1-2 -- FIX THE RTL PROBLEM */\r\nhtml[dir=\"rtl\"] .fancybox-stage {\r\n  direction: inherit;\r\n}\r\nhtml[dir=\"rtl\"] .fancybox-slide > * {\r\n  text-align: initial;\r\n}\r\n/* 2-2 -- FIX Caption Decleration */\r\nhtml[dir=\"rtl\"] .fancybox-caption-wrap{\r\n  direction: inherit;\r\n}\r\n/* 3-3 - FIX close button position */\r\nhtml[dir=\"rtl\"] .fancybox-close-small{\r\n\tleft: 0;\r\n\tright: initial;\r\n}\r\n\r\n\r\n\r\n\r\n```"},"comment":{"url":"https://api.github.com/repos/fancyapps/fancybox/issues/comments/365203749","html_url":"https://github.com/fancyapps/fancybox/issues/1827#issuecomment-365203749","issue_url":"https://api.github.com/repos/fancyapps/fancybox/issues/1827","id":365203749,"user":{"login":"fancyapps","id":1055589,"avatar_url":"https://avatars3.githubusercontent.com/u/1055589?v=4","gravatar_id":"","url":"https://api.github.com/users/fancyapps","html_url":"https://github.com/fancyapps","followers_url":"https://api.github.com/users/fancyapps/followers","following_url":"https://api.github.com/users/fancyapps/following{/other_user}","gists_url":"https://api.github.com/users/fancyapps/gists{/gist_id}","starred_url":"https://api.github.com/users/fancyapps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fancyapps/subscriptions","organizations_url":"https://api.github.com/users/fancyapps/orgs","repos_url":"https://api.github.com/users/fancyapps/repos","events_url":"https://api.github.com/users/fancyapps/events{/privacy}","received_events_url":"https://api.github.com/users/fancyapps/received_events","type":"User","site_admin":false},"created_at":"2018-02-13T09:28:22Z","updated_at":"2018-02-13T09:28:22Z","author_association":"OWNER","body":"Thanks! \r\n\r\nThis is also (partly) duplicate of #1210"}}
{"actor":{"display_login":"fancyapps"}}