{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/23425","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/23425/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/23425/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/23425/events","html_url":"https://github.com/nodejs/node/pull/23425","id":369235310,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyMjI1NDEx","number":23425,"title":"Back-port v8 changes for ppc64, Aix platform","user":{"login":"V-for-Vasili","id":22247310,"node_id":"MDQ6VXNlcjIyMjQ3MzEw","avatar_url":"https://avatars2.githubusercontent.com/u/22247310?v=4","gravatar_id":"","url":"https://api.github.com/users/V-for-Vasili","html_url":"https://github.com/V-for-Vasili","followers_url":"https://api.github.com/users/V-for-Vasili/followers","following_url":"https://api.github.com/users/V-for-Vasili/following{/other_user}","gists_url":"https://api.github.com/users/V-for-Vasili/gists{/gist_id}","starred_url":"https://api.github.com/users/V-for-Vasili/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/V-for-Vasili/subscriptions","organizations_url":"https://api.github.com/users/V-for-Vasili/orgs","repos_url":"https://api.github.com/users/V-for-Vasili/repos","events_url":"https://api.github.com/users/V-for-Vasili/events{/privacy}","received_events_url":"https://api.github.com/users/V-for-Vasili/received_events","type":"User","site_admin":false},"labels":[{"id":176191361,"node_id":"MDU6TGFiZWwxNzYxOTEzNjE=","url":"https://api.github.com/repos/nodejs/node/labels/V8%20Engine","name":"V8 Engine","color":"0052cc","default":false},{"id":904071494,"node_id":"MDU6TGFiZWw5MDQwNzE0OTQ=","url":"https://api.github.com/repos/nodejs/node/labels/v10.x","name":"v10.x","color":"4213c4","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-10-11T17:52:13Z","updated_at":"2018-10-12T01:35:21Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/23425","html_url":"https://github.com/nodejs/node/pull/23425","diff_url":"https://github.com/nodejs/node/pull/23425.diff","patch_url":"https://github.com/nodejs/node/pull/23425.patch"},"body":"<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n\r\n\r\nBack-port v8 changes for ppc64, Aix platform \r\nChanges included:\r\n\r\n\r\ns390, ppc64: Enable v8gen.py on Linux s390, ppc64\r\nV8 Revision: abab9fbb643e97d1fa7ddee9bfc609e0e4a4f184\r\n\r\n\r\nfix gn builds on aix.\r\nV8 Revision: d9e78322d0370543342d52d58e4d81db67bb7203\r\n\r\n\r\nUse gn from PATH on aix in v8gen.py\r\nV8 Revision: e7fad930a83b5b4f1bfee6bee620f35b988d28c3\r\n\r\n\r\nppc64, aix: Pass CallFrequency object by const reference to avoid value copy error.\r\nBug: v8:8193\r\nGCC bug: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61976\r\nV8 Revision: d2e0166ded485df126c765b9196f7edd1ce50f82\r\n\r\n\r\ndisable failing cctest on AIX temporarily\r\nV8 Revision: 67b549938d9060dde5cb557865f7451392a0f004\r\n\r\n\r\ndeps/v8/src/torque/file-visitor.h:\r\nAdd virtual dtor to avoid gcc error on Aix. (Not currently present in v8/master)\r\n\r\nThe following patch to v8/build solves this issue for v8/master:\r\na1a12ef3b343f9e75c630ed6dc8f1ea44a8a747b\r\n\r\nHowever, the version of '/chromium/src/build.git' cannot be updated to include this\r\npatch in v8/DEPS file. (could potentially cause issues for other platforms)\r\n\r\nThe change to deps/v8/src/torque/file-visitor.h is a workaround for origin/v10.x-staging\r\nbranch.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/429174885","html_url":"https://github.com/nodejs/node/pull/23425#issuecomment-429174885","issue_url":"https://api.github.com/repos/nodejs/node/issues/23425","id":429174885,"node_id":"MDEyOklzc3VlQ29tbWVudDQyOTE3NDg4NQ==","user":{"login":"mhdawson","id":9373002,"node_id":"MDQ6VXNlcjkzNzMwMDI=","avatar_url":"https://avatars3.githubusercontent.com/u/9373002?v=4","gravatar_id":"","url":"https://api.github.com/users/mhdawson","html_url":"https://github.com/mhdawson","followers_url":"https://api.github.com/users/mhdawson/followers","following_url":"https://api.github.com/users/mhdawson/following{/other_user}","gists_url":"https://api.github.com/users/mhdawson/gists{/gist_id}","starred_url":"https://api.github.com/users/mhdawson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhdawson/subscriptions","organizations_url":"https://api.github.com/users/mhdawson/orgs","repos_url":"https://api.github.com/users/mhdawson/repos","events_url":"https://api.github.com/users/mhdawson/events{/privacy}","received_events_url":"https://api.github.com/users/mhdawson/received_events","type":"User","site_admin":false},"created_at":"2018-10-12T01:35:21Z","updated_at":"2018-10-12T01:35:21Z","author_association":"MEMBER","body":"As some additional context, these fixes are needed to address some edge cases which are exposed by the v8 tests even though we don't see any failures in the Node.js tests. \r\n\r\nUnfortunately, we had a gap in our internal v8 testing on AIX (We don't run the v8 tests on AIX right now in the Node.js project CI although we are working on contributing a new machine to OSU that might make that possible).  We are now back to having regular runs in our internal IBM CI.\r\n\r\nOnce we closed the gap in our internal testing it uncovered a few issues that this PR resolves based changes which have already landed in the v8 repos."}}
{"actor":{"display_login":"mhdawson"}}