{"action":"created","issue":{"url":"https://api.github.com/repos/tgstation/tgstation/issues/34086","repository_url":"https://api.github.com/repos/tgstation/tgstation","labels_url":"https://api.github.com/repos/tgstation/tgstation/issues/34086/labels{/name}","comments_url":"https://api.github.com/repos/tgstation/tgstation/issues/34086/comments","events_url":"https://api.github.com/repos/tgstation/tgstation/issues/34086/events","html_url":"https://github.com/tgstation/tgstation/pull/34086","id":285899540,"number":34086,"title":"goonchat linkify has been vastly improved","user":{"login":"optimumtact","id":2544323,"avatar_url":"https://avatars2.githubusercontent.com/u/2544323?v=4","gravatar_id":"","url":"https://api.github.com/users/optimumtact","html_url":"https://github.com/optimumtact","followers_url":"https://api.github.com/users/optimumtact/followers","following_url":"https://api.github.com/users/optimumtact/following{/other_user}","gists_url":"https://api.github.com/users/optimumtact/gists{/gist_id}","starred_url":"https://api.github.com/users/optimumtact/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/optimumtact/subscriptions","organizations_url":"https://api.github.com/users/optimumtact/orgs","repos_url":"https://api.github.com/users/optimumtact/repos","events_url":"https://api.github.com/users/optimumtact/events{/privacy}","received_events_url":"https://api.github.com/users/optimumtact/received_events","type":"User","site_admin":false},"labels":[{"id":627951053,"url":"https://api.github.com/repos/tgstation/tgstation/labels/Code%20Improvement","name":"Code Improvement","color":"551A8B","default":false},{"id":760204058,"url":"https://api.github.com/repos/tgstation/tgstation/labels/Test%20Merge%20Candidate","name":"Test Merge Candidate","color":"010577","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":16,"created_at":"2018-01-04T07:13:57Z","updated_at":"2018-04-25T07:40:44Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/tgstation/tgstation/pulls/34086","html_url":"https://github.com/tgstation/tgstation/pull/34086","diff_url":"https://github.com/tgstation/tgstation/pull/34086.diff","patch_url":"https://github.com/tgstation/tgstation/pull/34086.patch"},"body":"    You must now explicitly specify if you want linkification by setting\r\n    linkify=TRUE in the to_chat call, right now this is only enabled by\r\n    default for OOC\r\n\r\n    The linkification process is now also restricted to only the content\r\n    inside spans that contain the class .linkify. This is because if we ran\r\n    the linkify unrestricted on the entire message we would break things that\r\n    are using URL's for specific purposes.\r\n\r\n    For example, goonchat images are served as an <img src=\"url\"> link, and if\r\n    we were to replace the url in that with a clickable a href we would break\r\n    the images being sent to chat\r\n\r\n    The combination of flag and span class is entirely for performance, if there's no\r\n    reason to run the linkify process over the message text, we can simply\r\n    avoid doing so and not waste time doing work we don't need to do\r\n\r\nWhy:\r\npreviously in the image below, my name would have appeared as a clickable link in ic messages as well\r\n![](https://file.house/_use.png)\r\n\r\n\r\nThe regex will match links of the form\r\nwww.tgstation13.org\r\nhttps://tgstation13.org\r\nhttps://tgstation13.org/some/url/shit\r\nhttp://tgstation13.org\r\nhttp://www.tgstation13.org\r\nbyond://sybil.tgstation13.org \r\n\r\netc etc\r\n\r\nFixes #33996\r\nFixes #36924\r\n\r\n\r\nI added a basic debug console that calls eval, which helps when doing on sight debugging of issues. It also gives you somewhere to send debug output that isn't just the main game screen. So you can leave it in as reuseable for future devs.\r\n![](https://file.house/Aepq.png)\r\n  "},"comment":{"url":"https://api.github.com/repos/tgstation/tgstation/issues/comments/384190285","html_url":"https://github.com/tgstation/tgstation/pull/34086#issuecomment-384190285","issue_url":"https://api.github.com/repos/tgstation/tgstation/issues/34086","id":384190285,"user":{"login":"PKPenguin321","id":8345184,"avatar_url":"https://avatars0.githubusercontent.com/u/8345184?v=4","gravatar_id":"","url":"https://api.github.com/users/PKPenguin321","html_url":"https://github.com/PKPenguin321","followers_url":"https://api.github.com/users/PKPenguin321/followers","following_url":"https://api.github.com/users/PKPenguin321/following{/other_user}","gists_url":"https://api.github.com/users/PKPenguin321/gists{/gist_id}","starred_url":"https://api.github.com/users/PKPenguin321/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PKPenguin321/subscriptions","organizations_url":"https://api.github.com/users/PKPenguin321/orgs","repos_url":"https://api.github.com/users/PKPenguin321/repos","events_url":"https://api.github.com/users/PKPenguin321/events{/privacy}","received_events_url":"https://api.github.com/users/PKPenguin321/received_events","type":"User","site_admin":false},"created_at":"2018-04-25T07:40:44Z","updated_at":"2018-04-25T07:40:44Z","author_association":"CONTRIBUTOR","body":"Hard work and perseverance\r\nGood job oranges"}}
{"actor":{"display_login":"PKPenguin321"}}