{"action":"closed","number":16089,"pull_request":{"url":"https://api.github.com/repos/grpc/grpc/pulls/16089","id":203018674,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzMDE4Njc0","html_url":"https://github.com/grpc/grpc/pull/16089","diff_url":"https://github.com/grpc/grpc/pull/16089.diff","patch_url":"https://github.com/grpc/grpc/pull/16089.patch","issue_url":"https://api.github.com/repos/grpc/grpc/issues/16089","number":16089,"state":"closed","locked":false,"title":"Added the checks to detect for Xamarin iOS and Android","user":{"login":"mattleibow","id":1096616,"node_id":"MDQ6VXNlcjEwOTY2MTY=","avatar_url":"https://avatars0.githubusercontent.com/u/1096616?v=4","gravatar_id":"","url":"https://api.github.com/users/mattleibow","html_url":"https://github.com/mattleibow","followers_url":"https://api.github.com/users/mattleibow/followers","following_url":"https://api.github.com/users/mattleibow/following{/other_user}","gists_url":"https://api.github.com/users/mattleibow/gists{/gist_id}","starred_url":"https://api.github.com/users/mattleibow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattleibow/subscriptions","organizations_url":"https://api.github.com/users/mattleibow/orgs","repos_url":"https://api.github.com/users/mattleibow/repos","events_url":"https://api.github.com/users/mattleibow/events{/privacy}","received_events_url":"https://api.github.com/users/mattleibow/received_events","type":"User","site_admin":false},"body":"This PR makes a few tweaks to the managed code to load the correct native files.\r\n\r\n_To build the native libraries for iOS, I am using this: https://gist.github.com/mattleibow/f480c8bb4720b0fdb7d99bd087954263_\r\n\r\nIf the native files are build and added to the NuGet package, then they can be added to iOS apps with something like this: \r\n\r\n```xml\r\n<?xml version=\"1.0\" encoding=\"UTF-8\"?>\r\n<Project xmlns=\"http://schemas.microsoft.com/developer/msbuild/2003\">\r\n    <ItemGroup>\r\n        <NativeReference Include=\"$(MSBuildThisFileDirectory)..\\..\\runtimes\\ios\\native\\libgrpc_csharp_ext.a\">\r\n            <Kind>Static</Kind>\r\n            <ForceLoad>True</ForceLoad>\r\n        </NativeReference>\r\n        <NativeReference Include=\"$(MSBuildThisFileDirectory)..\\..\\runtimes\\ios\\native\\libgrpc.a\">\r\n            <Kind>Static</Kind>\r\n            <ForceLoad>True</ForceLoad>\r\n        </NativeReference>\r\n    </ItemGroup>\r\n</Project>\r\n```\r\n\r\nI did notice that I had to add a reference to both `libgrpc_csharp_ext.a` and `libgrpc.a`.","created_at":"2018-07-21T17:16:18Z","updated_at":"2018-07-23T16:17:44Z","closed_at":"2018-07-23T16:17:44Z","merged_at":null,"merge_commit_sha":"18284bb699390ec1f5c70b94908f164484c00b0b","assignee":{"login":"jtattermusch","id":9939684,"node_id":"MDQ6VXNlcjk5Mzk2ODQ=","avatar_url":"https://avatars1.githubusercontent.com/u/9939684?v=4","gravatar_id":"","url":"https://api.github.com/users/jtattermusch","html_url":"https://github.com/jtattermusch","followers_url":"https://api.github.com/users/jtattermusch/followers","following_url":"https://api.github.com/users/jtattermusch/following{/other_user}","gists_url":"https://api.github.com/users/jtattermusch/gists{/gist_id}","starred_url":"https://api.github.com/users/jtattermusch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtattermusch/subscriptions","organizations_url":"https://api.github.com/users/jtattermusch/orgs","repos_url":"https://api.github.com/users/jtattermusch/repos","events_url":"https://api.github.com/users/jtattermusch/events{/privacy}","received_events_url":"https://api.github.com/users/jtattermusch/received_events","type":"User","site_admin":false},"assignees":[{"login":"jtattermusch","id":9939684,"node_id":"MDQ6VXNlcjk5Mzk2ODQ=","avatar_url":"https://avatars1.githubusercontent.com/u/9939684?v=4","gravatar_id":"","url":"https://api.github.com/users/jtattermusch","html_url":"https://github.com/jtattermusch","followers_url":"https://api.github.com/users/jtattermusch/followers","following_url":"https://api.github.com/users/jtattermusch/following{/other_user}","gists_url":"https://api.github.com/users/jtattermusch/gists{/gist_id}","starred_url":"https://api.github.com/users/jtattermusch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtattermusch/subscriptions","organizations_url":"https://api.github.com/users/jtattermusch/orgs","repos_url":"https://api.github.com/users/jtattermusch/repos","events_url":"https://api.github.com/users/jtattermusch/events{/privacy}","received_events_url":"https://api.github.com/users/jtattermusch/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":168238370,"node_id":"MDU6TGFiZWwxNjgyMzgzNzA=","url":"https://api.github.com/repos/grpc/grpc/labels/lang/C%23","name":"lang/C#","color":"fad8c7","default":false},{"id":961831639,"node_id":"MDU6TGFiZWw5NjE4MzE2Mzk=","url":"https://api.github.com/repos/grpc/grpc/labels/release%20notes:%20yes","name":"release notes: yes","color":"5319e7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/grpc/grpc/pulls/16089/commits","review_comments_url":"https://api.github.com/repos/grpc/grpc/pulls/16089/comments","review_comment_url":"https://api.github.com/repos/grpc/grpc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grpc/grpc/issues/16089/comments","statuses_url":"https://api.github.com/repos/grpc/grpc/statuses/b8cb6c1ae96d7291b5ee05f3b6f7f3a1e6d3190e","head":{"label":"mattleibow:dev/xamarin-support","ref":"dev/xamarin-support","sha":"b8cb6c1ae96d7291b5ee05f3b6f7f3a1e6d3190e","user":{"login":"mattleibow","id":1096616,"node_id":"MDQ6VXNlcjEwOTY2MTY=","avatar_url":"https://avatars0.githubusercontent.com/u/1096616?v=4","gravatar_id":"","url":"https://api.github.com/users/mattleibow","html_url":"https://github.com/mattleibow","followers_url":"https://api.github.com/users/mattleibow/followers","following_url":"https://api.github.com/users/mattleibow/following{/other_user}","gists_url":"https://api.github.com/users/mattleibow/gists{/gist_id}","starred_url":"https://api.github.com/users/mattleibow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattleibow/subscriptions","organizations_url":"https://api.github.com/users/mattleibow/orgs","repos_url":"https://api.github.com/users/mattleibow/repos","events_url":"https://api.github.com/users/mattleibow/events{/privacy}","received_events_url":"https://api.github.com/users/mattleibow/received_events","type":"User","site_admin":false},"repo":{"id":141832033,"node_id":"MDEwOlJlcG9zaXRvcnkxNDE4MzIwMzM=","name":"grpc","full_name":"mattleibow/grpc","owner":{"login":"mattleibow","id":1096616,"node_id":"MDQ6VXNlcjEwOTY2MTY=","avatar_url":"https://avatars0.githubusercontent.com/u/1096616?v=4","gravatar_id":"","url":"https://api.github.com/users/mattleibow","html_url":"https://github.com/mattleibow","followers_url":"https://api.github.com/users/mattleibow/followers","following_url":"https://api.github.com/users/mattleibow/following{/other_user}","gists_url":"https://api.github.com/users/mattleibow/gists{/gist_id}","starred_url":"https://api.github.com/users/mattleibow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattleibow/subscriptions","organizations_url":"https://api.github.com/users/mattleibow/orgs","repos_url":"https://api.github.com/users/mattleibow/repos","events_url":"https://api.github.com/users/mattleibow/events{/privacy}","received_events_url":"https://api.github.com/users/mattleibow/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mattleibow/grpc","description":"The C based gRPC (C++, Python, Ruby, Objective-C, PHP, C#)","fork":true,"url":"https://api.github.com/repos/mattleibow/grpc","forks_url":"https://api.github.com/repos/mattleibow/grpc/forks","keys_url":"https://api.github.com/repos/mattleibow/grpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mattleibow/grpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mattleibow/grpc/teams","hooks_url":"https://api.github.com/repos/mattleibow/grpc/hooks","issue_events_url":"https://api.github.com/repos/mattleibow/grpc/issues/events{/number}","events_url":"https://api.github.com/repos/mattleibow/grpc/events","assignees_url":"https://api.github.com/repos/mattleibow/grpc/assignees{/user}","branches_url":"https://api.github.com/repos/mattleibow/grpc/branches{/branch}","tags_url":"https://api.github.com/repos/mattleibow/grpc/tags","blobs_url":"https://api.github.com/repos/mattleibow/grpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mattleibow/grpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mattleibow/grpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/mattleibow/grpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mattleibow/grpc/statuses/{sha}","languages_url":"https://api.github.com/repos/mattleibow/grpc/languages","stargazers_url":"https://api.github.com/repos/mattleibow/grpc/stargazers","contributors_url":"https://api.github.com/repos/mattleibow/grpc/contributors","subscribers_url":"https://api.github.com/repos/mattleibow/grpc/subscribers","subscription_url":"https://api.github.com/repos/mattleibow/grpc/subscription","commits_url":"https://api.github.com/repos/mattleibow/grpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/mattleibow/grpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/mattleibow/grpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/mattleibow/grpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/mattleibow/grpc/contents/{+path}","compare_url":"https://api.github.com/repos/mattleibow/grpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mattleibow/grpc/merges","archive_url":"https://api.github.com/repos/mattleibow/grpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mattleibow/grpc/downloads","issues_url":"https://api.github.com/repos/mattleibow/grpc/issues{/number}","pulls_url":"https://api.github.com/repos/mattleibow/grpc/pulls{/number}","milestones_url":"https://api.github.com/repos/mattleibow/grpc/milestones{/number}","notifications_url":"https://api.github.com/repos/mattleibow/grpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mattleibow/grpc/labels{/name}","releases_url":"https://api.github.com/repos/mattleibow/grpc/releases{/id}","deployments_url":"https://api.github.com/repos/mattleibow/grpc/deployments","created_at":"2018-07-21T17:14:38Z","updated_at":"2018-07-21T17:14:54Z","pushed_at":"2018-07-21T17:40:25Z","git_url":"git://github.com/mattleibow/grpc.git","ssh_url":"git@github.com:mattleibow/grpc.git","clone_url":"https://github.com/mattleibow/grpc.git","svn_url":"https://github.com/mattleibow/grpc","homepage":"https://grpc.io","size":179537,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"grpc:master","ref":"master","sha":"2cfc216cfd58dc247249da87dbefa8bb949c8b9c","user":{"login":"grpc","id":7802525,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4MDI1MjU=","avatar_url":"https://avatars1.githubusercontent.com/u/7802525?v=4","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"repo":{"id":27729880,"node_id":"MDEwOlJlcG9zaXRvcnkyNzcyOTg4MA==","name":"grpc","full_name":"grpc/grpc","owner":{"login":"grpc","id":7802525,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4MDI1MjU=","avatar_url":"https://avatars1.githubusercontent.com/u/7802525?v=4","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/grpc/grpc","description":"The C based gRPC (C++, Python, Ruby, Objective-C, PHP, C#)","fork":false,"url":"https://api.github.com/repos/grpc/grpc","forks_url":"https://api.github.com/repos/grpc/grpc/forks","keys_url":"https://api.github.com/repos/grpc/grpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grpc/grpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grpc/grpc/teams","hooks_url":"https://api.github.com/repos/grpc/grpc/hooks","issue_events_url":"https://api.github.com/repos/grpc/grpc/issues/events{/number}","events_url":"https://api.github.com/repos/grpc/grpc/events","assignees_url":"https://api.github.com/repos/grpc/grpc/assignees{/user}","branches_url":"https://api.github.com/repos/grpc/grpc/branches{/branch}","tags_url":"https://api.github.com/repos/grpc/grpc/tags","blobs_url":"https://api.github.com/repos/grpc/grpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grpc/grpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grpc/grpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/grpc/grpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grpc/grpc/statuses/{sha}","languages_url":"https://api.github.com/repos/grpc/grpc/languages","stargazers_url":"https://api.github.com/repos/grpc/grpc/stargazers","contributors_url":"https://api.github.com/repos/grpc/grpc/contributors","subscribers_url":"https://api.github.com/repos/grpc/grpc/subscribers","subscription_url":"https://api.github.com/repos/grpc/grpc/subscription","commits_url":"https://api.github.com/repos/grpc/grpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/grpc/grpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/grpc/grpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/grpc/grpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/grpc/grpc/contents/{+path}","compare_url":"https://api.github.com/repos/grpc/grpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grpc/grpc/merges","archive_url":"https://api.github.com/repos/grpc/grpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grpc/grpc/downloads","issues_url":"https://api.github.com/repos/grpc/grpc/issues{/number}","pulls_url":"https://api.github.com/repos/grpc/grpc/pulls{/number}","milestones_url":"https://api.github.com/repos/grpc/grpc/milestones{/number}","notifications_url":"https://api.github.com/repos/grpc/grpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grpc/grpc/labels{/name}","releases_url":"https://api.github.com/repos/grpc/grpc/releases{/id}","deployments_url":"https://api.github.com/repos/grpc/grpc/deployments","created_at":"2014-12-08T18:58:53Z","updated_at":"2018-07-23T15:48:33Z","pushed_at":"2018-07-23T16:11:46Z","git_url":"git://github.com/grpc/grpc.git","ssh_url":"git@github.com:grpc/grpc.git","clone_url":"https://github.com/grpc/grpc.git","svn_url":"https://github.com/grpc/grpc","homepage":"https://grpc.io","size":188380,"stargazers_count":16320,"watchers_count":16320,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":3681,"mirror_url":null,"archived":false,"open_issues_count":1019,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3681,"open_issues":1019,"watchers":16320,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc/pulls/16089"},"html":{"href":"https://github.com/grpc/grpc/pull/16089"},"issue":{"href":"https://api.github.com/repos/grpc/grpc/issues/16089"},"comments":{"href":"https://api.github.com/repos/grpc/grpc/issues/16089/comments"},"review_comments":{"href":"https://api.github.com/repos/grpc/grpc/pulls/16089/comments"},"review_comment":{"href":"https://api.github.com/repos/grpc/grpc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grpc/grpc/pulls/16089/commits"},"statuses":{"href":"https://api.github.com/repos/grpc/grpc/statuses/b8cb6c1ae96d7291b5ee05f3b6f7f3a1e6d3190e"}},"author_association":"NONE","merged":false,"mergeable":false,"rebaseable":false,"mergeable_state":"dirty","merged_by":null,"comments":3,"review_comments":8,"maintainer_can_modify":false,"commits":2,"additions":68,"deletions":1,"changed_files":3}}
{"actor":{"display_login":"jtattermusch"}}