{"action":"created","comment":{"url":"https://api.github.com/repos/wolfgang42/rockstar-js/pulls/comments/227146378","pull_request_review_id":167119542,"id":227146378,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNzE0NjM3OA==","diff_hunk":"@@ -0,0 +1,38 @@\n+const rockstar = require('../src/rockstar');\n+const expect = require('chai').expect;\n+\n+describe('Compiling', () => {\n+  it('should declare variables properly', () => {\n+    expect(rockstar.compile('Joe is 1')).to.be.equal('Joe=1;');\n+    expect(rockstar.compile('Joe was 1')).to.be.equal('Joe=1;');\n+    expect(rockstar.compile('Beatles were 4')).to.be.equal('Beatles=4;');\n+  });\n+\n+  it('should handle keywords', () => {\n+    //TODO: Should we check types too?","path":"test/unit_tests.js","position":12,"original_position":12,"commit_id":"42516d741e626fb411af73766f2752b74de9bf6d","original_commit_id":"42516d741e626fb411af73766f2752b74de9bf6d","user":{"login":"wolfgang42","id":2261204,"node_id":"MDQ6VXNlcjIyNjEyMDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/2261204?v=4","gravatar_id":"","url":"https://api.github.com/users/wolfgang42","html_url":"https://github.com/wolfgang42","followers_url":"https://api.github.com/users/wolfgang42/followers","following_url":"https://api.github.com/users/wolfgang42/following{/other_user}","gists_url":"https://api.github.com/users/wolfgang42/gists{/gist_id}","starred_url":"https://api.github.com/users/wolfgang42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wolfgang42/subscriptions","organizations_url":"https://api.github.com/users/wolfgang42/orgs","repos_url":"https://api.github.com/users/wolfgang42/repos","events_url":"https://api.github.com/users/wolfgang42/events{/privacy}","received_events_url":"https://api.github.com/users/wolfgang42/received_events","type":"User","site_admin":false},"body":"I'm not sure what you mean by \"check types\" here.","created_at":"2018-10-22T21:33:26Z","updated_at":"2018-10-22T21:36:49Z","html_url":"https://github.com/wolfgang42/rockstar-js/pull/40#discussion_r227146378","pull_request_url":"https://api.github.com/repos/wolfgang42/rockstar-js/pulls/40","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/wolfgang42/rockstar-js/pulls/comments/227146378"},"html":{"href":"https://github.com/wolfgang42/rockstar-js/pull/40#discussion_r227146378"},"pull_request":{"href":"https://api.github.com/repos/wolfgang42/rockstar-js/pulls/40"}}},"pull_request":{"url":"https://api.github.com/repos/wolfgang42/rockstar-js/pulls/40","id":222930235,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyOTMwMjM1","html_url":"https://github.com/wolfgang42/rockstar-js/pull/40","diff_url":"https://github.com/wolfgang42/rockstar-js/pull/40.diff","patch_url":"https://github.com/wolfgang42/rockstar-js/pull/40.patch","issue_url":"https://api.github.com/repos/wolfgang42/rockstar-js/issues/40","number":40,"state":"open","locked":false,"title":"Unit tests","user":{"login":"ldevernay","id":23695083,"node_id":"MDQ6VXNlcjIzNjk1MDgz","avatar_url":"https://avatars3.githubusercontent.com/u/23695083?v=4","gravatar_id":"","url":"https://api.github.com/users/ldevernay","html_url":"https://github.com/ldevernay","followers_url":"https://api.github.com/users/ldevernay/followers","following_url":"https://api.github.com/users/ldevernay/following{/other_user}","gists_url":"https://api.github.com/users/ldevernay/gists{/gist_id}","starred_url":"https://api.github.com/users/ldevernay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldevernay/subscriptions","organizations_url":"https://api.github.com/users/ldevernay/orgs","repos_url":"https://api.github.com/users/ldevernay/repos","events_url":"https://api.github.com/users/ldevernay/events{/privacy}","received_events_url":"https://api.github.com/users/ldevernay/received_events","type":"User","site_admin":false},"body":"This is a first draft for unit tests & test coverage.\r\nWe should first check together if this is a good way to go before going any further.\r\nDoes the chosen terminology suit you?\r\nShould we also implement failing tests regarding ongoing issues?","created_at":"2018-10-15T14:38:01Z","updated_at":"2018-10-22T21:36:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aa37b3960e45f1c1db517538f13d8e6b6f7e282d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/wolfgang42/rockstar-js/pulls/40/commits","review_comments_url":"https://api.github.com/repos/wolfgang42/rockstar-js/pulls/40/comments","review_comment_url":"https://api.github.com/repos/wolfgang42/rockstar-js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wolfgang42/rockstar-js/issues/40/comments","statuses_url":"https://api.github.com/repos/wolfgang42/rockstar-js/statuses/42516d741e626fb411af73766f2752b74de9bf6d","head":{"label":"ldevernay:unit_tests","ref":"unit_tests","sha":"42516d741e626fb411af73766f2752b74de9bf6d","user":{"login":"ldevernay","id":23695083,"node_id":"MDQ6VXNlcjIzNjk1MDgz","avatar_url":"https://avatars3.githubusercontent.com/u/23695083?v=4","gravatar_id":"","url":"https://api.github.com/users/ldevernay","html_url":"https://github.com/ldevernay","followers_url":"https://api.github.com/users/ldevernay/followers","following_url":"https://api.github.com/users/ldevernay/following{/other_user}","gists_url":"https://api.github.com/users/ldevernay/gists{/gist_id}","starred_url":"https://api.github.com/users/ldevernay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldevernay/subscriptions","organizations_url":"https://api.github.com/users/ldevernay/orgs","repos_url":"https://api.github.com/users/ldevernay/repos","events_url":"https://api.github.com/users/ldevernay/events{/privacy}","received_events_url":"https://api.github.com/users/ldevernay/received_events","type":"User","site_admin":false},"repo":{"id":152556575,"node_id":"MDEwOlJlcG9zaXRvcnkxNTI1NTY1NzU=","name":"rockstar-js","full_name":"ldevernay/rockstar-js","private":false,"owner":{"login":"ldevernay","id":23695083,"node_id":"MDQ6VXNlcjIzNjk1MDgz","avatar_url":"https://avatars3.githubusercontent.com/u/23695083?v=4","gravatar_id":"","url":"https://api.github.com/users/ldevernay","html_url":"https://github.com/ldevernay","followers_url":"https://api.github.com/users/ldevernay/followers","following_url":"https://api.github.com/users/ldevernay/following{/other_user}","gists_url":"https://api.github.com/users/ldevernay/gists{/gist_id}","starred_url":"https://api.github.com/users/ldevernay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldevernay/subscriptions","organizations_url":"https://api.github.com/users/ldevernay/orgs","repos_url":"https://api.github.com/users/ldevernay/repos","events_url":"https://api.github.com/users/ldevernay/events{/privacy}","received_events_url":"https://api.github.com/users/ldevernay/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ldevernay/rockstar-js","description":"JavaScript transpiler for the esoteric language 'Rockstar'","fork":true,"url":"https://api.github.com/repos/ldevernay/rockstar-js","forks_url":"https://api.github.com/repos/ldevernay/rockstar-js/forks","keys_url":"https://api.github.com/repos/ldevernay/rockstar-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ldevernay/rockstar-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ldevernay/rockstar-js/teams","hooks_url":"https://api.github.com/repos/ldevernay/rockstar-js/hooks","issue_events_url":"https://api.github.com/repos/ldevernay/rockstar-js/issues/events{/number}","events_url":"https://api.github.com/repos/ldevernay/rockstar-js/events","assignees_url":"https://api.github.com/repos/ldevernay/rockstar-js/assignees{/user}","branches_url":"https://api.github.com/repos/ldevernay/rockstar-js/branches{/branch}","tags_url":"https://api.github.com/repos/ldevernay/rockstar-js/tags","blobs_url":"https://api.github.com/repos/ldevernay/rockstar-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ldevernay/rockstar-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ldevernay/rockstar-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/ldevernay/rockstar-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ldevernay/rockstar-js/statuses/{sha}","languages_url":"https://api.github.com/repos/ldevernay/rockstar-js/languages","stargazers_url":"https://api.github.com/repos/ldevernay/rockstar-js/stargazers","contributors_url":"https://api.github.com/repos/ldevernay/rockstar-js/contributors","subscribers_url":"https://api.github.com/repos/ldevernay/rockstar-js/subscribers","subscription_url":"https://api.github.com/repos/ldevernay/rockstar-js/subscription","commits_url":"https://api.github.com/repos/ldevernay/rockstar-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/ldevernay/rockstar-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/ldevernay/rockstar-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/ldevernay/rockstar-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/ldevernay/rockstar-js/contents/{+path}","compare_url":"https://api.github.com/repos/ldevernay/rockstar-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ldevernay/rockstar-js/merges","archive_url":"https://api.github.com/repos/ldevernay/rockstar-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ldevernay/rockstar-js/downloads","issues_url":"https://api.github.com/repos/ldevernay/rockstar-js/issues{/number}","pulls_url":"https://api.github.com/repos/ldevernay/rockstar-js/pulls{/number}","milestones_url":"https://api.github.com/repos/ldevernay/rockstar-js/milestones{/number}","notifications_url":"https://api.github.com/repos/ldevernay/rockstar-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ldevernay/rockstar-js/labels{/name}","releases_url":"https://api.github.com/repos/ldevernay/rockstar-js/releases{/id}","deployments_url":"https://api.github.com/repos/ldevernay/rockstar-js/deployments","created_at":"2018-10-11T08:22:06Z","updated_at":"2018-10-11T08:22:08Z","pushed_at":"2018-10-15T14:34:19Z","git_url":"git://github.com/ldevernay/rockstar-js.git","ssh_url":"git@github.com:ldevernay/rockstar-js.git","clone_url":"https://github.com/ldevernay/rockstar-js.git","svn_url":"https://github.com/ldevernay/rockstar-js","homepage":"","size":52,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wolfgang42:master","ref":"master","sha":"62f263bf4719e311f2ff393b1727c6012feeb65d","user":{"login":"wolfgang42","id":2261204,"node_id":"MDQ6VXNlcjIyNjEyMDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/2261204?v=4","gravatar_id":"","url":"https://api.github.com/users/wolfgang42","html_url":"https://github.com/wolfgang42","followers_url":"https://api.github.com/users/wolfgang42/followers","following_url":"https://api.github.com/users/wolfgang42/following{/other_user}","gists_url":"https://api.github.com/users/wolfgang42/gists{/gist_id}","starred_url":"https://api.github.com/users/wolfgang42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wolfgang42/subscriptions","organizations_url":"https://api.github.com/users/wolfgang42/orgs","repos_url":"https://api.github.com/users/wolfgang42/repos","events_url":"https://api.github.com/users/wolfgang42/events{/privacy}","received_events_url":"https://api.github.com/users/wolfgang42/received_events","type":"User","site_admin":false},"repo":{"id":141935592,"node_id":"MDEwOlJlcG9zaXRvcnkxNDE5MzU1OTI=","name":"rockstar-js","full_name":"wolfgang42/rockstar-js","private":false,"owner":{"login":"wolfgang42","id":2261204,"node_id":"MDQ6VXNlcjIyNjEyMDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/2261204?v=4","gravatar_id":"","url":"https://api.github.com/users/wolfgang42","html_url":"https://github.com/wolfgang42","followers_url":"https://api.github.com/users/wolfgang42/followers","following_url":"https://api.github.com/users/wolfgang42/following{/other_user}","gists_url":"https://api.github.com/users/wolfgang42/gists{/gist_id}","starred_url":"https://api.github.com/users/wolfgang42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wolfgang42/subscriptions","organizations_url":"https://api.github.com/users/wolfgang42/orgs","repos_url":"https://api.github.com/users/wolfgang42/repos","events_url":"https://api.github.com/users/wolfgang42/events{/privacy}","received_events_url":"https://api.github.com/users/wolfgang42/received_events","type":"User","site_admin":false},"html_url":"https://github.com/wolfgang42/rockstar-js","description":"JavaScript transpiler for the esoteric language 'Rockstar'","fork":false,"url":"https://api.github.com/repos/wolfgang42/rockstar-js","forks_url":"https://api.github.com/repos/wolfgang42/rockstar-js/forks","keys_url":"https://api.github.com/repos/wolfgang42/rockstar-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wolfgang42/rockstar-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wolfgang42/rockstar-js/teams","hooks_url":"https://api.github.com/repos/wolfgang42/rockstar-js/hooks","issue_events_url":"https://api.github.com/repos/wolfgang42/rockstar-js/issues/events{/number}","events_url":"https://api.github.com/repos/wolfgang42/rockstar-js/events","assignees_url":"https://api.github.com/repos/wolfgang42/rockstar-js/assignees{/user}","branches_url":"https://api.github.com/repos/wolfgang42/rockstar-js/branches{/branch}","tags_url":"https://api.github.com/repos/wolfgang42/rockstar-js/tags","blobs_url":"https://api.github.com/repos/wolfgang42/rockstar-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wolfgang42/rockstar-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wolfgang42/rockstar-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/wolfgang42/rockstar-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wolfgang42/rockstar-js/statuses/{sha}","languages_url":"https://api.github.com/repos/wolfgang42/rockstar-js/languages","stargazers_url":"https://api.github.com/repos/wolfgang42/rockstar-js/stargazers","contributors_url":"https://api.github.com/repos/wolfgang42/rockstar-js/contributors","subscribers_url":"https://api.github.com/repos/wolfgang42/rockstar-js/subscribers","subscription_url":"https://api.github.com/repos/wolfgang42/rockstar-js/subscription","commits_url":"https://api.github.com/repos/wolfgang42/rockstar-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/wolfgang42/rockstar-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/wolfgang42/rockstar-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/wolfgang42/rockstar-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/wolfgang42/rockstar-js/contents/{+path}","compare_url":"https://api.github.com/repos/wolfgang42/rockstar-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wolfgang42/rockstar-js/merges","archive_url":"https://api.github.com/repos/wolfgang42/rockstar-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wolfgang42/rockstar-js/downloads","issues_url":"https://api.github.com/repos/wolfgang42/rockstar-js/issues{/number}","pulls_url":"https://api.github.com/repos/wolfgang42/rockstar-js/pulls{/number}","milestones_url":"https://api.github.com/repos/wolfgang42/rockstar-js/milestones{/number}","notifications_url":"https://api.github.com/repos/wolfgang42/rockstar-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wolfgang42/rockstar-js/labels{/name}","releases_url":"https://api.github.com/repos/wolfgang42/rockstar-js/releases{/id}","deployments_url":"https://api.github.com/repos/wolfgang42/rockstar-js/deployments","created_at":"2018-07-22T22:32:38Z","updated_at":"2018-10-22T21:33:38Z","pushed_at":"2018-10-22T20:58:30Z","git_url":"git://github.com/wolfgang42/rockstar-js.git","ssh_url":"git@github.com:wolfgang42/rockstar-js.git","clone_url":"https://github.com/wolfgang42/rockstar-js.git","svn_url":"https://github.com/wolfgang42/rockstar-js","homepage":"","size":57,"stargazers_count":166,"watchers_count":166,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"archived":false,"open_issues_count":23,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":15,"open_issues":23,"watchers":166,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wolfgang42/rockstar-js/pulls/40"},"html":{"href":"https://github.com/wolfgang42/rockstar-js/pull/40"},"issue":{"href":"https://api.github.com/repos/wolfgang42/rockstar-js/issues/40"},"comments":{"href":"https://api.github.com/repos/wolfgang42/rockstar-js/issues/40/comments"},"review_comments":{"href":"https://api.github.com/repos/wolfgang42/rockstar-js/pulls/40/comments"},"review_comment":{"href":"https://api.github.com/repos/wolfgang42/rockstar-js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wolfgang42/rockstar-js/pulls/40/commits"},"statuses":{"href":"https://api.github.com/repos/wolfgang42/rockstar-js/statuses/42516d741e626fb411af73766f2752b74de9bf6d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"wolfgang42"}}