{"action":"created","issue":{"url":"https://api.github.com/repos/DivanteLtd/vue-storefront/issues/2042","repository_url":"https://api.github.com/repos/DivanteLtd/vue-storefront","labels_url":"https://api.github.com/repos/DivanteLtd/vue-storefront/issues/2042/labels{/name}","comments_url":"https://api.github.com/repos/DivanteLtd/vue-storefront/issues/2042/comments","events_url":"https://api.github.com/repos/DivanteLtd/vue-storefront/issues/2042/events","html_url":"https://github.com/DivanteLtd/vue-storefront/pull/2042","id":385947969,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0ODAzNDc2","number":2042,"title":"[DO NOT MERGE] i18n improvements","user":{"login":"DavidRouyer","id":1556750,"node_id":"MDQ6VXNlcjE1NTY3NTA=","avatar_url":"https://avatars2.githubusercontent.com/u/1556750?v=4","gravatar_id":"","url":"https://api.github.com/users/DavidRouyer","html_url":"https://github.com/DavidRouyer","followers_url":"https://api.github.com/users/DavidRouyer/followers","following_url":"https://api.github.com/users/DavidRouyer/following{/other_user}","gists_url":"https://api.github.com/users/DavidRouyer/gists{/gist_id}","starred_url":"https://api.github.com/users/DavidRouyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DavidRouyer/subscriptions","organizations_url":"https://api.github.com/users/DavidRouyer/orgs","repos_url":"https://api.github.com/users/DavidRouyer/repos","events_url":"https://api.github.com/users/DavidRouyer/events{/privacy}","received_events_url":"https://api.github.com/users/DavidRouyer/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-11-29T22:09:52Z","updated_at":"2018-11-30T12:45:40Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/DivanteLtd/vue-storefront/pulls/2042","html_url":"https://github.com/DivanteLtd/vue-storefront/pull/2042","diff_url":"https://github.com/DivanteLtd/vue-storefront/pull/2042.diff","patch_url":"https://github.com/DivanteLtd/vue-storefront/pull/2042.patch"},"body":"### Related issues\r\n\r\n#1749 \r\n\r\n### Short description and why it's useful\r\n\r\nThis is the current goal I want to achieve\r\n\r\n- Put all translations in the theme folder\r\n- Translations files are now JSON files (translation.preprocessor is not needed anymore)\r\n- Use `i18n.setLocaleMessage('en-US', require('theme/resource/i18n/en-US.json'))` in the theme to bundle the default language and lazy load the others\r\n- Remove unneeded config entries\r\n- **TODO**: make the JSON file look more like the RFC one (I will simply create a `core` section to avoid breaking user's current translations, future work will be done in the v2 of the theme)\r\n\r\n### Screenshots of visual changes before/after (if there are any)\r\n\r\n### Screenshot of passed e2e tests (if you are using our standard setup as a backend)\r\n\r\n### Upgrade Notes and Changelog\r\n\r\n- [ ] No upgrade steps required (100% backward compatibility)\r\n- [ ] I've updated the [Upgrade notes](https://github.com/DivanteLtd/vue-storefront/blob/develop/doc/Upgrade%20notes.md) and [Changelog](https://github.com/DivanteLtd/vue-storefront/blob/develop/CHANGELOG.md) on how to port existing VS sites with this new feature **TODO**\r\n\r\n### Contribution and currently important rules acceptance\r\n\r\n- [x] I read and followed [contribution rules](https://github.com/DivanteLtd/vue-storefront/blob/master/CONTRIBUTING.md)\r\n- [x] I read the [TypeScript Action Plan](https://github.com/DivanteLtd/vue-storefront/blob/master/doc/TypeScript%20Action%20Plan.md) and adjusted my PR according to it\r\n- [x] I read about [Vue Storefront Modules](https://github.com/DivanteLtd/vue-storefront/blob/master/doc/api-modules/about-modules.md) and I am aware that every new feature should be a module\r\n"},"comment":{"url":"https://api.github.com/repos/DivanteLtd/vue-storefront/issues/comments/443193196","html_url":"https://github.com/DivanteLtd/vue-storefront/pull/2042#issuecomment-443193196","issue_url":"https://api.github.com/repos/DivanteLtd/vue-storefront/issues/2042","id":443193196,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MzE5MzE5Ng==","user":{"login":"filrak","id":15185752,"node_id":"MDQ6VXNlcjE1MTg1NzUy","avatar_url":"https://avatars2.githubusercontent.com/u/15185752?v=4","gravatar_id":"","url":"https://api.github.com/users/filrak","html_url":"https://github.com/filrak","followers_url":"https://api.github.com/users/filrak/followers","following_url":"https://api.github.com/users/filrak/following{/other_user}","gists_url":"https://api.github.com/users/filrak/gists{/gist_id}","starred_url":"https://api.github.com/users/filrak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/filrak/subscriptions","organizations_url":"https://api.github.com/users/filrak/orgs","repos_url":"https://api.github.com/users/filrak/repos","events_url":"https://api.github.com/users/filrak/events{/privacy}","received_events_url":"https://api.github.com/users/filrak/received_events","type":"User","site_admin":false},"created_at":"2018-11-30T12:45:40Z","updated_at":"2018-11-30T12:45:40Z","author_association":"COLLABORATOR","body":"@DavidRouyer do we really need to lazy load all languages? I mean we can even load them on demand (or on hover of language switcher, this is a nice way to do preloads 1-2 sec before click)"}}
{"actor":{"display_login":"filrak"}}