{"action":"created","comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/166915450","pull_request_review_id":95048692,"id":166915450,"diff_hunk":"@@ -1351,7 +1356,9 @@ def fit(self, X, y=None):\n         Parameters\n         ----------\n         X : array-like or sparse matrix, shape=(n_samples, n_features)\n-            Training instances to cluster.\n+            Training instances to cluster. It must be noted that the data\n+            will be converted to C ordering, which will cause a memory copy\n+            if the given data is in not C-contiguous.","path":"sklearn/cluster/k_means_.py","position":129,"original_position":129,"commit_id":"f7950034bb586d08970dc27dda9e699b6cf3922e","original_commit_id":"f7950034bb586d08970dc27dda9e699b6cf3922e","user":{"login":"glemaitre","id":7454015,"avatar_url":"https://avatars2.githubusercontent.com/u/7454015?v=4","gravatar_id":"","url":"https://api.github.com/users/glemaitre","html_url":"https://github.com/glemaitre","followers_url":"https://api.github.com/users/glemaitre/followers","following_url":"https://api.github.com/users/glemaitre/following{/other_user}","gists_url":"https://api.github.com/users/glemaitre/gists{/gist_id}","starred_url":"https://api.github.com/users/glemaitre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glemaitre/subscriptions","organizations_url":"https://api.github.com/users/glemaitre/orgs","repos_url":"https://api.github.com/users/glemaitre/repos","events_url":"https://api.github.com/users/glemaitre/events{/privacy}","received_events_url":"https://api.github.com/users/glemaitre/received_events","type":"User","site_admin":false},"body":"given data are not C-contiguous","created_at":"2018-02-08T12:12:14Z","updated_at":"2018-02-08T12:12:21Z","html_url":"https://github.com/scikit-learn/scikit-learn/pull/10471#discussion_r166915450","pull_request_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/10471","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/166915450"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/10471#discussion_r166915450"},"pull_request":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/10471"}}},"pull_request":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/10471","id":162820558,"html_url":"https://github.com/scikit-learn/scikit-learn/pull/10471","diff_url":"https://github.com/scikit-learn/scikit-learn/pull/10471.diff","patch_url":"https://github.com/scikit-learn/scikit-learn/pull/10471.patch","issue_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/10471","number":10471,"state":"open","locked":false,"title":"[MRG + 1] KMeans optimisation for array C/F contiguity","user":{"login":"gxyd","id":7712241,"avatar_url":"https://avatars0.githubusercontent.com/u/7712241?v=4","gravatar_id":"","url":"https://api.github.com/users/gxyd","html_url":"https://github.com/gxyd","followers_url":"https://api.github.com/users/gxyd/followers","following_url":"https://api.github.com/users/gxyd/following{/other_user}","gists_url":"https://api.github.com/users/gxyd/gists{/gist_id}","starred_url":"https://api.github.com/users/gxyd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gxyd/subscriptions","organizations_url":"https://api.github.com/users/gxyd/orgs","repos_url":"https://api.github.com/users/gxyd/repos","events_url":"https://api.github.com/users/gxyd/events{/privacy}","received_events_url":"https://api.github.com/users/gxyd/received_events","type":"User","site_admin":false},"body":"\r\n\r\n<!--\r\nThanks for contributing a pull request! Please ensure you have taken a look at\r\nthe contribution guidelines: https://github.com/scikit-learn/scikit-learn/blob/master/CONTRIBUTING.md#pull-request-checklist\r\n-->\r\n\r\n#### Reference Issues/PRs\r\n<!--\r\nExample: Fixes #1234. See also #3456.\r\nPlease use keywords (e.g., Fixes) to create link to the issues or pull requests\r\nyou resolved, so that they will automatically be closed when your pull request\r\nis merged. See https://github.com/blog/1506-closing-issues-via-pull-requests\r\n-->\r\n\r\nFixes #4582\r\n\r\n#### What does this implement/fix? Explain your changes.\r\n\r\nUse `order='C'` internally in `check_array` for KMeans optimization.\r\n\r\n#### Any other comments?\r\n\r\nI don't think this will require any tests. Requires benchmarking? apart from what was described on the issue itself?\r\n\r\n<!--\r\nPlease be aware that we are a loose team of volunteers so patience is\r\nnecessary; assistance handling other issues is very welcome. We value\r\nall user contributions, no matter how minor they are. If we are slow to\r\nreview, either the pull request needs some benchmarking, tinkering,\r\nconvincing, etc. or more likely the reviewers are simply busy. In either\r\ncase, we ask for your understanding during the review process.\r\nFor more information, see our FAQ on this topic:\r\nhttp://scikit-learn.org/dev/faq.html#why-is-my-pull-request-not-getting-any-attention.\r\n\r\nThanks for contributing!\r\n-->\r\n","created_at":"2018-01-14T11:20:46Z","updated_at":"2018-02-08T12:12:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9e70f0b7c6817eb90ae9b3adb19245f0c81594eb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/10471/commits","review_comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/10471/comments","review_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/10471/comments","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/f7950034bb586d08970dc27dda9e699b6cf3922e","head":{"label":"gxyd:k-means","ref":"k-means","sha":"f7950034bb586d08970dc27dda9e699b6cf3922e","user":{"login":"gxyd","id":7712241,"avatar_url":"https://avatars0.githubusercontent.com/u/7712241?v=4","gravatar_id":"","url":"https://api.github.com/users/gxyd","html_url":"https://github.com/gxyd","followers_url":"https://api.github.com/users/gxyd/followers","following_url":"https://api.github.com/users/gxyd/following{/other_user}","gists_url":"https://api.github.com/users/gxyd/gists{/gist_id}","starred_url":"https://api.github.com/users/gxyd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gxyd/subscriptions","organizations_url":"https://api.github.com/users/gxyd/orgs","repos_url":"https://api.github.com/users/gxyd/repos","events_url":"https://api.github.com/users/gxyd/events{/privacy}","received_events_url":"https://api.github.com/users/gxyd/received_events","type":"User","site_admin":false},"repo":{"id":50286950,"name":"scikit-learn","full_name":"gxyd/scikit-learn","owner":{"login":"gxyd","id":7712241,"avatar_url":"https://avatars0.githubusercontent.com/u/7712241?v=4","gravatar_id":"","url":"https://api.github.com/users/gxyd","html_url":"https://github.com/gxyd","followers_url":"https://api.github.com/users/gxyd/followers","following_url":"https://api.github.com/users/gxyd/following{/other_user}","gists_url":"https://api.github.com/users/gxyd/gists{/gist_id}","starred_url":"https://api.github.com/users/gxyd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gxyd/subscriptions","organizations_url":"https://api.github.com/users/gxyd/orgs","repos_url":"https://api.github.com/users/gxyd/repos","events_url":"https://api.github.com/users/gxyd/events{/privacy}","received_events_url":"https://api.github.com/users/gxyd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gxyd/scikit-learn","description":"scikit-learn: machine learning in Python","fork":true,"url":"https://api.github.com/repos/gxyd/scikit-learn","forks_url":"https://api.github.com/repos/gxyd/scikit-learn/forks","keys_url":"https://api.github.com/repos/gxyd/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gxyd/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gxyd/scikit-learn/teams","hooks_url":"https://api.github.com/repos/gxyd/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/gxyd/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/gxyd/scikit-learn/events","assignees_url":"https://api.github.com/repos/gxyd/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/gxyd/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/gxyd/scikit-learn/tags","blobs_url":"https://api.github.com/repos/gxyd/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gxyd/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gxyd/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/gxyd/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gxyd/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/gxyd/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/gxyd/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/gxyd/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/gxyd/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/gxyd/scikit-learn/subscription","commits_url":"https://api.github.com/repos/gxyd/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/gxyd/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/gxyd/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/gxyd/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/gxyd/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/gxyd/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gxyd/scikit-learn/merges","archive_url":"https://api.github.com/repos/gxyd/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gxyd/scikit-learn/downloads","issues_url":"https://api.github.com/repos/gxyd/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/gxyd/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/gxyd/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/gxyd/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gxyd/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/gxyd/scikit-learn/releases{/id}","deployments_url":"https://api.github.com/repos/gxyd/scikit-learn/deployments","created_at":"2016-01-24T12:37:02Z","updated_at":"2016-01-24T12:37:10Z","pushed_at":"2018-02-08T12:01:32Z","git_url":"git://github.com/gxyd/scikit-learn.git","ssh_url":"git@github.com:gxyd/scikit-learn.git","clone_url":"https://github.com/gxyd/scikit-learn.git","svn_url":"https://github.com/gxyd/scikit-learn","homepage":"http://scikit-learn.org","size":86806,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scikit-learn:master","ref":"master","sha":"ac11e4bc1a28272585bd8f8366f2f56509c24bb8","user":{"login":"scikit-learn","id":365630,"avatar_url":"https://avatars2.githubusercontent.com/u/365630?v=4","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"repo":{"id":843222,"name":"scikit-learn","full_name":"scikit-learn/scikit-learn","owner":{"login":"scikit-learn","id":365630,"avatar_url":"https://avatars2.githubusercontent.com/u/365630?v=4","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scikit-learn/scikit-learn","description":"scikit-learn: machine learning in Python","fork":false,"url":"https://api.github.com/repos/scikit-learn/scikit-learn","forks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/forks","keys_url":"https://api.github.com/repos/scikit-learn/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scikit-learn/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scikit-learn/scikit-learn/teams","hooks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/events","assignees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/scikit-learn/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/tags","blobs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/scikit-learn/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscription","commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/scikit-learn/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scikit-learn/scikit-learn/merges","archive_url":"https://api.github.com/repos/scikit-learn/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scikit-learn/scikit-learn/downloads","issues_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/scikit-learn/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/scikit-learn/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/scikit-learn/scikit-learn/releases{/id}","deployments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/deployments","created_at":"2010-08-17T09:43:38Z","updated_at":"2018-02-08T11:20:23Z","pushed_at":"2018-02-08T12:09:01Z","git_url":"git://github.com/scikit-learn/scikit-learn.git","ssh_url":"git@github.com:scikit-learn/scikit-learn.git","clone_url":"https://github.com/scikit-learn/scikit-learn.git","svn_url":"https://github.com/scikit-learn/scikit-learn","homepage":"http://scikit-learn.org","size":88727,"stargazers_count":25512,"watchers_count":25512,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13024,"mirror_url":null,"archived":false,"open_issues_count":1568,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":13024,"open_issues":1568,"watchers":25512,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/10471"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/10471"},"issue":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/10471"},"comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/10471/comments"},"review_comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/10471/comments"},"review_comment":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/10471/commits"},"statuses":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/f7950034bb586d08970dc27dda9e699b6cf3922e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"glemaitre"}}