{"action":"created","comment":{"url":"https://api.github.com/repos/pytorch/pytorch/pulls/comments/208261191","pull_request_review_id":144032834,"id":208261191,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODI2MTE5MQ==","diff_hunk":"@@ -1,5 +1,9 @@\n #include \"ATen/core/TensorTypeId.h\"\n \n+namespace at {","path":"aten/src/ATen/core/TensorTypeId.cpp","position":null,"original_position":3,"commit_id":"6096162026f6def6e02b18ae15b453df5686c904","original_commit_id":"5ac5fd5bb8e3858f19af3f891134775fd422091c","user":{"login":"ezyang","id":13564,"node_id":"MDQ6VXNlcjEzNTY0","avatar_url":"https://avatars0.githubusercontent.com/u/13564?v=4","gravatar_id":"","url":"https://api.github.com/users/ezyang","html_url":"https://github.com/ezyang","followers_url":"https://api.github.com/users/ezyang/followers","following_url":"https://api.github.com/users/ezyang/following{/other_user}","gists_url":"https://api.github.com/users/ezyang/gists{/gist_id}","starred_url":"https://api.github.com/users/ezyang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezyang/subscriptions","organizations_url":"https://api.github.com/users/ezyang/orgs","repos_url":"https://api.github.com/users/ezyang/repos","events_url":"https://api.github.com/users/ezyang/events{/privacy}","received_events_url":"https://api.github.com/users/ezyang/received_events","type":"User","site_admin":false},"body":"I think it's silly to have to include `Formatting.h` if you want to `<<` types; the implementations are really simple, put them with the actual headers.","created_at":"2018-08-07T14:47:33Z","updated_at":"2018-08-07T14:47:34Z","html_url":"https://github.com/pytorch/pytorch/pull/10278#discussion_r208261191","pull_request_url":"https://api.github.com/repos/pytorch/pytorch/pulls/10278","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/comments/208261191"},"html":{"href":"https://github.com/pytorch/pytorch/pull/10278#discussion_r208261191"},"pull_request":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/10278"}},"in_reply_to_id":208048250},"pull_request":{"url":"https://api.github.com/repos/pytorch/pytorch/pulls/10278","id":206525630,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2NTI1NjMw","html_url":"https://github.com/pytorch/pytorch/pull/10278","diff_url":"https://github.com/pytorch/pytorch/pull/10278.diff","patch_url":"https://github.com/pytorch/pytorch/pull/10278.patch","issue_url":"https://api.github.com/repos/pytorch/pytorch/issues/10278","number":10278,"state":"open","locked":false,"title":"Rewrite TensorImpl to use TensorTypeId.","user":{"login":"ezyang","id":13564,"node_id":"MDQ6VXNlcjEzNTY0","avatar_url":"https://avatars0.githubusercontent.com/u/13564?v=4","gravatar_id":"","url":"https://api.github.com/users/ezyang","html_url":"https://github.com/ezyang","followers_url":"https://api.github.com/users/ezyang/followers","following_url":"https://api.github.com/users/ezyang/following{/other_user}","gists_url":"https://api.github.com/users/ezyang/gists{/gist_id}","starred_url":"https://api.github.com/users/ezyang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezyang/subscriptions","organizations_url":"https://api.github.com/users/ezyang/orgs","repos_url":"https://api.github.com/users/ezyang/repos","events_url":"https://api.github.com/users/ezyang/events{/privacy}","received_events_url":"https://api.github.com/users/ezyang/received_events","type":"User","site_admin":false},"body":"Summary:\nTranslation to Backend happens immediately before we go into the\nType universe; otherwise we use TensorTypeId.\n\nI allocated TensorTypeId corresponding exactly to existing ATen\nBackend.  Only CPUTensorId and CUDATensorId are relevant in the\nCaffe2 universe.\n\nDifferential Revision: D9184060\n","created_at":"2018-08-06T21:47:27Z","updated_at":"2018-08-07T14:47:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"796dc3adf6ea2b16857a89f79c2675ecb1d241e4","assignee":null,"assignees":[],"requested_reviewers":[{"login":"zdevito","id":370202,"node_id":"MDQ6VXNlcjM3MDIwMg==","avatar_url":"https://avatars0.githubusercontent.com/u/370202?v=4","gravatar_id":"","url":"https://api.github.com/users/zdevito","html_url":"https://github.com/zdevito","followers_url":"https://api.github.com/users/zdevito/followers","following_url":"https://api.github.com/users/zdevito/following{/other_user}","gists_url":"https://api.github.com/users/zdevito/gists{/gist_id}","starred_url":"https://api.github.com/users/zdevito/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zdevito/subscriptions","organizations_url":"https://api.github.com/users/zdevito/orgs","repos_url":"https://api.github.com/users/zdevito/repos","events_url":"https://api.github.com/users/zdevito/events{/privacy}","received_events_url":"https://api.github.com/users/zdevito/received_events","type":"User","site_admin":false},{"login":"colesbury","id":655866,"node_id":"MDQ6VXNlcjY1NTg2Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/655866?v=4","gravatar_id":"","url":"https://api.github.com/users/colesbury","html_url":"https://github.com/colesbury","followers_url":"https://api.github.com/users/colesbury/followers","following_url":"https://api.github.com/users/colesbury/following{/other_user}","gists_url":"https://api.github.com/users/colesbury/gists{/gist_id}","starred_url":"https://api.github.com/users/colesbury/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colesbury/subscriptions","organizations_url":"https://api.github.com/users/colesbury/orgs","repos_url":"https://api.github.com/users/colesbury/repos","events_url":"https://api.github.com/users/colesbury/events{/privacy}","received_events_url":"https://api.github.com/users/colesbury/received_events","type":"User","site_admin":false},{"login":"soumith","id":1310570,"node_id":"MDQ6VXNlcjEzMTA1NzA=","avatar_url":"https://avatars0.githubusercontent.com/u/1310570?v=4","gravatar_id":"","url":"https://api.github.com/users/soumith","html_url":"https://github.com/soumith","followers_url":"https://api.github.com/users/soumith/followers","following_url":"https://api.github.com/users/soumith/following{/other_user}","gists_url":"https://api.github.com/users/soumith/gists{/gist_id}","starred_url":"https://api.github.com/users/soumith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soumith/subscriptions","organizations_url":"https://api.github.com/users/soumith/orgs","repos_url":"https://api.github.com/users/soumith/repos","events_url":"https://api.github.com/users/soumith/events{/privacy}","received_events_url":"https://api.github.com/users/soumith/received_events","type":"User","site_admin":false},{"login":"apaszke","id":4583066,"node_id":"MDQ6VXNlcjQ1ODMwNjY=","avatar_url":"https://avatars3.githubusercontent.com/u/4583066?v=4","gravatar_id":"","url":"https://api.github.com/users/apaszke","html_url":"https://github.com/apaszke","followers_url":"https://api.github.com/users/apaszke/followers","following_url":"https://api.github.com/users/apaszke/following{/other_user}","gists_url":"https://api.github.com/users/apaszke/gists{/gist_id}","starred_url":"https://api.github.com/users/apaszke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apaszke/subscriptions","organizations_url":"https://api.github.com/users/apaszke/orgs","repos_url":"https://api.github.com/users/apaszke/repos","events_url":"https://api.github.com/users/apaszke/events{/privacy}","received_events_url":"https://api.github.com/users/apaszke/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pytorch/pytorch/pulls/10278/commits","review_comments_url":"https://api.github.com/repos/pytorch/pytorch/pulls/10278/comments","review_comment_url":"https://api.github.com/repos/pytorch/pytorch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pytorch/pytorch/issues/10278/comments","statuses_url":"https://api.github.com/repos/pytorch/pytorch/statuses/6096162026f6def6e02b18ae15b453df5686c904","head":{"label":"ezyang:export-D9184060","ref":"export-D9184060","sha":"6096162026f6def6e02b18ae15b453df5686c904","user":{"login":"ezyang","id":13564,"node_id":"MDQ6VXNlcjEzNTY0","avatar_url":"https://avatars0.githubusercontent.com/u/13564?v=4","gravatar_id":"","url":"https://api.github.com/users/ezyang","html_url":"https://github.com/ezyang","followers_url":"https://api.github.com/users/ezyang/followers","following_url":"https://api.github.com/users/ezyang/following{/other_user}","gists_url":"https://api.github.com/users/ezyang/gists{/gist_id}","starred_url":"https://api.github.com/users/ezyang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezyang/subscriptions","organizations_url":"https://api.github.com/users/ezyang/orgs","repos_url":"https://api.github.com/users/ezyang/repos","events_url":"https://api.github.com/users/ezyang/events{/privacy}","received_events_url":"https://api.github.com/users/ezyang/received_events","type":"User","site_admin":false},"repo":{"id":101798885,"node_id":"MDEwOlJlcG9zaXRvcnkxMDE3OTg4ODU=","name":"pytorch","full_name":"ezyang/pytorch","owner":{"login":"ezyang","id":13564,"node_id":"MDQ6VXNlcjEzNTY0","avatar_url":"https://avatars0.githubusercontent.com/u/13564?v=4","gravatar_id":"","url":"https://api.github.com/users/ezyang","html_url":"https://github.com/ezyang","followers_url":"https://api.github.com/users/ezyang/followers","following_url":"https://api.github.com/users/ezyang/following{/other_user}","gists_url":"https://api.github.com/users/ezyang/gists{/gist_id}","starred_url":"https://api.github.com/users/ezyang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezyang/subscriptions","organizations_url":"https://api.github.com/users/ezyang/orgs","repos_url":"https://api.github.com/users/ezyang/repos","events_url":"https://api.github.com/users/ezyang/events{/privacy}","received_events_url":"https://api.github.com/users/ezyang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ezyang/pytorch","description":"Tensors and Dynamic neural networks in Python  with strong GPU acceleration","fork":true,"url":"https://api.github.com/repos/ezyang/pytorch","forks_url":"https://api.github.com/repos/ezyang/pytorch/forks","keys_url":"https://api.github.com/repos/ezyang/pytorch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ezyang/pytorch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ezyang/pytorch/teams","hooks_url":"https://api.github.com/repos/ezyang/pytorch/hooks","issue_events_url":"https://api.github.com/repos/ezyang/pytorch/issues/events{/number}","events_url":"https://api.github.com/repos/ezyang/pytorch/events","assignees_url":"https://api.github.com/repos/ezyang/pytorch/assignees{/user}","branches_url":"https://api.github.com/repos/ezyang/pytorch/branches{/branch}","tags_url":"https://api.github.com/repos/ezyang/pytorch/tags","blobs_url":"https://api.github.com/repos/ezyang/pytorch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ezyang/pytorch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ezyang/pytorch/git/refs{/sha}","trees_url":"https://api.github.com/repos/ezyang/pytorch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ezyang/pytorch/statuses/{sha}","languages_url":"https://api.github.com/repos/ezyang/pytorch/languages","stargazers_url":"https://api.github.com/repos/ezyang/pytorch/stargazers","contributors_url":"https://api.github.com/repos/ezyang/pytorch/contributors","subscribers_url":"https://api.github.com/repos/ezyang/pytorch/subscribers","subscription_url":"https://api.github.com/repos/ezyang/pytorch/subscription","commits_url":"https://api.github.com/repos/ezyang/pytorch/commits{/sha}","git_commits_url":"https://api.github.com/repos/ezyang/pytorch/git/commits{/sha}","comments_url":"https://api.github.com/repos/ezyang/pytorch/comments{/number}","issue_comment_url":"https://api.github.com/repos/ezyang/pytorch/issues/comments{/number}","contents_url":"https://api.github.com/repos/ezyang/pytorch/contents/{+path}","compare_url":"https://api.github.com/repos/ezyang/pytorch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ezyang/pytorch/merges","archive_url":"https://api.github.com/repos/ezyang/pytorch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ezyang/pytorch/downloads","issues_url":"https://api.github.com/repos/ezyang/pytorch/issues{/number}","pulls_url":"https://api.github.com/repos/ezyang/pytorch/pulls{/number}","milestones_url":"https://api.github.com/repos/ezyang/pytorch/milestones{/number}","notifications_url":"https://api.github.com/repos/ezyang/pytorch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ezyang/pytorch/labels{/name}","releases_url":"https://api.github.com/repos/ezyang/pytorch/releases{/id}","deployments_url":"https://api.github.com/repos/ezyang/pytorch/deployments","created_at":"2017-08-29T19:28:39Z","updated_at":"2018-07-02T18:14:07Z","pushed_at":"2018-08-07T00:12:09Z","git_url":"git://github.com/ezyang/pytorch.git","ssh_url":"git@github.com:ezyang/pytorch.git","clone_url":"https://github.com/ezyang/pytorch.git","svn_url":"https://github.com/ezyang/pytorch","homepage":"http://pytorch.org","size":68097,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"pytorch:master","ref":"master","sha":"25b2e88750e81111d609c04911e631ee21998c19","user":{"login":"pytorch","id":21003710,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDAzNzEw","avatar_url":"https://avatars3.githubusercontent.com/u/21003710?v=4","gravatar_id":"","url":"https://api.github.com/users/pytorch","html_url":"https://github.com/pytorch","followers_url":"https://api.github.com/users/pytorch/followers","following_url":"https://api.github.com/users/pytorch/following{/other_user}","gists_url":"https://api.github.com/users/pytorch/gists{/gist_id}","starred_url":"https://api.github.com/users/pytorch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytorch/subscriptions","organizations_url":"https://api.github.com/users/pytorch/orgs","repos_url":"https://api.github.com/users/pytorch/repos","events_url":"https://api.github.com/users/pytorch/events{/privacy}","received_events_url":"https://api.github.com/users/pytorch/received_events","type":"Organization","site_admin":false},"repo":{"id":65600975,"node_id":"MDEwOlJlcG9zaXRvcnk2NTYwMDk3NQ==","name":"pytorch","full_name":"pytorch/pytorch","owner":{"login":"pytorch","id":21003710,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDAzNzEw","avatar_url":"https://avatars3.githubusercontent.com/u/21003710?v=4","gravatar_id":"","url":"https://api.github.com/users/pytorch","html_url":"https://github.com/pytorch","followers_url":"https://api.github.com/users/pytorch/followers","following_url":"https://api.github.com/users/pytorch/following{/other_user}","gists_url":"https://api.github.com/users/pytorch/gists{/gist_id}","starred_url":"https://api.github.com/users/pytorch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytorch/subscriptions","organizations_url":"https://api.github.com/users/pytorch/orgs","repos_url":"https://api.github.com/users/pytorch/repos","events_url":"https://api.github.com/users/pytorch/events{/privacy}","received_events_url":"https://api.github.com/users/pytorch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pytorch/pytorch","description":"Tensors and Dynamic neural networks in Python  with strong GPU acceleration","fork":false,"url":"https://api.github.com/repos/pytorch/pytorch","forks_url":"https://api.github.com/repos/pytorch/pytorch/forks","keys_url":"https://api.github.com/repos/pytorch/pytorch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pytorch/pytorch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pytorch/pytorch/teams","hooks_url":"https://api.github.com/repos/pytorch/pytorch/hooks","issue_events_url":"https://api.github.com/repos/pytorch/pytorch/issues/events{/number}","events_url":"https://api.github.com/repos/pytorch/pytorch/events","assignees_url":"https://api.github.com/repos/pytorch/pytorch/assignees{/user}","branches_url":"https://api.github.com/repos/pytorch/pytorch/branches{/branch}","tags_url":"https://api.github.com/repos/pytorch/pytorch/tags","blobs_url":"https://api.github.com/repos/pytorch/pytorch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pytorch/pytorch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pytorch/pytorch/git/refs{/sha}","trees_url":"https://api.github.com/repos/pytorch/pytorch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pytorch/pytorch/statuses/{sha}","languages_url":"https://api.github.com/repos/pytorch/pytorch/languages","stargazers_url":"https://api.github.com/repos/pytorch/pytorch/stargazers","contributors_url":"https://api.github.com/repos/pytorch/pytorch/contributors","subscribers_url":"https://api.github.com/repos/pytorch/pytorch/subscribers","subscription_url":"https://api.github.com/repos/pytorch/pytorch/subscription","commits_url":"https://api.github.com/repos/pytorch/pytorch/commits{/sha}","git_commits_url":"https://api.github.com/repos/pytorch/pytorch/git/commits{/sha}","comments_url":"https://api.github.com/repos/pytorch/pytorch/comments{/number}","issue_comment_url":"https://api.github.com/repos/pytorch/pytorch/issues/comments{/number}","contents_url":"https://api.github.com/repos/pytorch/pytorch/contents/{+path}","compare_url":"https://api.github.com/repos/pytorch/pytorch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pytorch/pytorch/merges","archive_url":"https://api.github.com/repos/pytorch/pytorch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pytorch/pytorch/downloads","issues_url":"https://api.github.com/repos/pytorch/pytorch/issues{/number}","pulls_url":"https://api.github.com/repos/pytorch/pytorch/pulls{/number}","milestones_url":"https://api.github.com/repos/pytorch/pytorch/milestones{/number}","notifications_url":"https://api.github.com/repos/pytorch/pytorch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pytorch/pytorch/labels{/name}","releases_url":"https://api.github.com/repos/pytorch/pytorch/releases{/id}","deployments_url":"https://api.github.com/repos/pytorch/pytorch/deployments","created_at":"2016-08-13T05:26:41Z","updated_at":"2018-08-07T14:41:30Z","pushed_at":"2018-08-07T14:43:22Z","git_url":"git://github.com/pytorch/pytorch.git","ssh_url":"git@github.com:pytorch/pytorch.git","clone_url":"https://github.com/pytorch/pytorch.git","svn_url":"https://github.com/pytorch/pytorch","homepage":"http://pytorch.org","size":67020,"stargazers_count":17665,"watchers_count":17665,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4152,"mirror_url":null,"archived":false,"open_issues_count":1574,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4152,"open_issues":1574,"watchers":17665,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/10278"},"html":{"href":"https://github.com/pytorch/pytorch/pull/10278"},"issue":{"href":"https://api.github.com/repos/pytorch/pytorch/issues/10278"},"comments":{"href":"https://api.github.com/repos/pytorch/pytorch/issues/10278/comments"},"review_comments":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/10278/comments"},"review_comment":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/10278/commits"},"statuses":{"href":"https://api.github.com/repos/pytorch/pytorch/statuses/6096162026f6def6e02b18ae15b453df5686c904"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ezyang"}}