{"action":"created","comment":{"url":"https://api.github.com/repos/grpc/grpc/pulls/comments/233941609","pull_request_review_id":175472585,"id":233941609,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzk0MTYwOQ==","diff_hunk":"@@ -728,6 +733,26 @@ TEST_F(ClientLbEnd2endTest, PickFirstCheckStateBeforeStartWatch) {\n   EXPECT_EQ(\"pick_first\", channel_2->GetLoadBalancingPolicyName());\n }\n \n+TEST_F(ClientLbEnd2endTest, PickFirstIdleOnDisconnect) {\n+  // Start server, send RPC, and make sure channel is READY.\n+  const int kNumServers = 1;\n+  StartServers(kNumServers);\n+  auto channel = BuildChannel(\"\");  // pick_first is the default.\n+  auto stub = BuildStub(channel);\n+  SetNextResolution(GetServersPorts());\n+  for (size_t i = 0; i < servers_.size(); ++i) {\n+    CheckRpcSendOk(stub, DEBUG_LOCATION);\n+  }\n+  CheckRpcSendOk(stub, DEBUG_LOCATION);\n+  EXPECT_EQ(channel->GetState(false), GRPC_CHANNEL_READY);\n+  // Stop server.  Channel should go into state IDLE.\n+  SetFailureOnReresolution();\n+  servers_[0]->Shutdown();\n+  EXPECT_TRUE(WaitForChannelNotReady(channel.get()));\n+  EXPECT_EQ(channel->GetState(false), GRPC_CHANNEL_IDLE);\n+  servers_.clear();","path":"test/cpp/end2end/client_lb_end2end_test.cc","position":33,"original_position":33,"commit_id":"e205367303444f5c16b83f50b7df11163d249a51","original_commit_id":"e205367303444f5c16b83f50b7df11163d249a51","user":{"login":"AspirinSJL","id":3314176,"node_id":"MDQ6VXNlcjMzMTQxNzY=","avatar_url":"https://avatars0.githubusercontent.com/u/3314176?v=4","gravatar_id":"","url":"https://api.github.com/users/AspirinSJL","html_url":"https://github.com/AspirinSJL","followers_url":"https://api.github.com/users/AspirinSJL/followers","following_url":"https://api.github.com/users/AspirinSJL/following{/other_user}","gists_url":"https://api.github.com/users/AspirinSJL/gists{/gist_id}","starred_url":"https://api.github.com/users/AspirinSJL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AspirinSJL/subscriptions","organizations_url":"https://api.github.com/users/AspirinSJL/orgs","repos_url":"https://api.github.com/users/AspirinSJL/repos","events_url":"https://api.github.com/users/AspirinSJL/events{/privacy}","received_events_url":"https://api.github.com/users/AspirinSJL/received_events","type":"User","site_admin":false},"body":"This should be done automatically by the test's dtor.","created_at":"2018-11-15T17:37:09Z","updated_at":"2018-11-15T17:37:09Z","html_url":"https://github.com/grpc/grpc/pull/17226#discussion_r233941609","pull_request_url":"https://api.github.com/repos/grpc/grpc/pulls/17226","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc/pulls/comments/233941609"},"html":{"href":"https://github.com/grpc/grpc/pull/17226#discussion_r233941609"},"pull_request":{"href":"https://api.github.com/repos/grpc/grpc/pulls/17226"}}},"pull_request":{"url":"https://api.github.com/repos/grpc/grpc/pulls/17226","id":231256800,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxMjU2ODAw","html_url":"https://github.com/grpc/grpc/pull/17226","diff_url":"https://github.com/grpc/grpc/pull/17226.diff","patch_url":"https://github.com/grpc/grpc/pull/17226.patch","issue_url":"https://api.github.com/repos/grpc/grpc/issues/17226","number":17226,"state":"open","locked":false,"title":"Don't reset channel state on resolver failure when LB policy exists.","user":{"login":"markdroth","id":18664614,"node_id":"MDQ6VXNlcjE4NjY0NjE0","avatar_url":"https://avatars2.githubusercontent.com/u/18664614?v=4","gravatar_id":"","url":"https://api.github.com/users/markdroth","html_url":"https://github.com/markdroth","followers_url":"https://api.github.com/users/markdroth/followers","following_url":"https://api.github.com/users/markdroth/following{/other_user}","gists_url":"https://api.github.com/users/markdroth/gists{/gist_id}","starred_url":"https://api.github.com/users/markdroth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markdroth/subscriptions","organizations_url":"https://api.github.com/users/markdroth/orgs","repos_url":"https://api.github.com/users/markdroth/repos","events_url":"https://api.github.com/users/markdroth/events{/privacy}","received_events_url":"https://api.github.com/users/markdroth/received_events","type":"User","site_admin":false},"body":"cc @muxi @srini100 ","created_at":"2018-11-15T16:29:41Z","updated_at":"2018-11-15T17:37:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"245f0fac6fd8dfa67d7d8ea3124008ba26b80d28","assignee":null,"assignees":[],"requested_reviewers":[{"login":"apolcyn","id":9566254,"node_id":"MDQ6VXNlcjk1NjYyNTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/9566254?v=4","gravatar_id":"","url":"https://api.github.com/users/apolcyn","html_url":"https://github.com/apolcyn","followers_url":"https://api.github.com/users/apolcyn/followers","following_url":"https://api.github.com/users/apolcyn/following{/other_user}","gists_url":"https://api.github.com/users/apolcyn/gists{/gist_id}","starred_url":"https://api.github.com/users/apolcyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apolcyn/subscriptions","organizations_url":"https://api.github.com/users/apolcyn/orgs","repos_url":"https://api.github.com/users/apolcyn/repos","events_url":"https://api.github.com/users/apolcyn/events{/privacy}","received_events_url":"https://api.github.com/users/apolcyn/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":218696181,"node_id":"MDU6TGFiZWwyMTg2OTYxODE=","url":"https://api.github.com/repos/grpc/grpc/labels/lang/core","name":"lang/core","color":"fad8c7","default":false},{"id":961831639,"node_id":"MDU6TGFiZWw5NjE4MzE2Mzk=","url":"https://api.github.com/repos/grpc/grpc/labels/release%20notes:%20yes","name":"release notes: yes","color":"5319e7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/grpc/grpc/pulls/17226/commits","review_comments_url":"https://api.github.com/repos/grpc/grpc/pulls/17226/comments","review_comment_url":"https://api.github.com/repos/grpc/grpc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grpc/grpc/issues/17226/comments","statuses_url":"https://api.github.com/repos/grpc/grpc/statuses/e205367303444f5c16b83f50b7df11163d249a51","head":{"label":"markdroth:channel_state_fix","ref":"channel_state_fix","sha":"e205367303444f5c16b83f50b7df11163d249a51","user":{"login":"markdroth","id":18664614,"node_id":"MDQ6VXNlcjE4NjY0NjE0","avatar_url":"https://avatars2.githubusercontent.com/u/18664614?v=4","gravatar_id":"","url":"https://api.github.com/users/markdroth","html_url":"https://github.com/markdroth","followers_url":"https://api.github.com/users/markdroth/followers","following_url":"https://api.github.com/users/markdroth/following{/other_user}","gists_url":"https://api.github.com/users/markdroth/gists{/gist_id}","starred_url":"https://api.github.com/users/markdroth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markdroth/subscriptions","organizations_url":"https://api.github.com/users/markdroth/orgs","repos_url":"https://api.github.com/users/markdroth/repos","events_url":"https://api.github.com/users/markdroth/events{/privacy}","received_events_url":"https://api.github.com/users/markdroth/received_events","type":"User","site_admin":false},"repo":{"id":57141284,"node_id":"MDEwOlJlcG9zaXRvcnk1NzE0MTI4NA==","name":"grpc","full_name":"markdroth/grpc","private":false,"owner":{"login":"markdroth","id":18664614,"node_id":"MDQ6VXNlcjE4NjY0NjE0","avatar_url":"https://avatars2.githubusercontent.com/u/18664614?v=4","gravatar_id":"","url":"https://api.github.com/users/markdroth","html_url":"https://github.com/markdroth","followers_url":"https://api.github.com/users/markdroth/followers","following_url":"https://api.github.com/users/markdroth/following{/other_user}","gists_url":"https://api.github.com/users/markdroth/gists{/gist_id}","starred_url":"https://api.github.com/users/markdroth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markdroth/subscriptions","organizations_url":"https://api.github.com/users/markdroth/orgs","repos_url":"https://api.github.com/users/markdroth/repos","events_url":"https://api.github.com/users/markdroth/events{/privacy}","received_events_url":"https://api.github.com/users/markdroth/received_events","type":"User","site_admin":false},"html_url":"https://github.com/markdroth/grpc","description":"The C based gRPC (C++, Node.js, Python, Ruby, Objective-C, PHP, C#)","fork":true,"url":"https://api.github.com/repos/markdroth/grpc","forks_url":"https://api.github.com/repos/markdroth/grpc/forks","keys_url":"https://api.github.com/repos/markdroth/grpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/markdroth/grpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/markdroth/grpc/teams","hooks_url":"https://api.github.com/repos/markdroth/grpc/hooks","issue_events_url":"https://api.github.com/repos/markdroth/grpc/issues/events{/number}","events_url":"https://api.github.com/repos/markdroth/grpc/events","assignees_url":"https://api.github.com/repos/markdroth/grpc/assignees{/user}","branches_url":"https://api.github.com/repos/markdroth/grpc/branches{/branch}","tags_url":"https://api.github.com/repos/markdroth/grpc/tags","blobs_url":"https://api.github.com/repos/markdroth/grpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/markdroth/grpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/markdroth/grpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/markdroth/grpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/markdroth/grpc/statuses/{sha}","languages_url":"https://api.github.com/repos/markdroth/grpc/languages","stargazers_url":"https://api.github.com/repos/markdroth/grpc/stargazers","contributors_url":"https://api.github.com/repos/markdroth/grpc/contributors","subscribers_url":"https://api.github.com/repos/markdroth/grpc/subscribers","subscription_url":"https://api.github.com/repos/markdroth/grpc/subscription","commits_url":"https://api.github.com/repos/markdroth/grpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/markdroth/grpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/markdroth/grpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/markdroth/grpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/markdroth/grpc/contents/{+path}","compare_url":"https://api.github.com/repos/markdroth/grpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/markdroth/grpc/merges","archive_url":"https://api.github.com/repos/markdroth/grpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/markdroth/grpc/downloads","issues_url":"https://api.github.com/repos/markdroth/grpc/issues{/number}","pulls_url":"https://api.github.com/repos/markdroth/grpc/pulls{/number}","milestones_url":"https://api.github.com/repos/markdroth/grpc/milestones{/number}","notifications_url":"https://api.github.com/repos/markdroth/grpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/markdroth/grpc/labels{/name}","releases_url":"https://api.github.com/repos/markdroth/grpc/releases{/id}","deployments_url":"https://api.github.com/repos/markdroth/grpc/deployments","created_at":"2016-04-26T15:47:18Z","updated_at":"2016-04-26T15:47:26Z","pushed_at":"2018-11-15T16:28:19Z","git_url":"git://github.com/markdroth/grpc.git","ssh_url":"git@github.com:markdroth/grpc.git","clone_url":"https://github.com/markdroth/grpc.git","svn_url":"https://github.com/markdroth/grpc","homepage":"","size":169633,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"grpc:master","ref":"master","sha":"dc1bbf9932b8de85e96c92db9c7f43219498b58c","user":{"login":"grpc","id":7802525,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4MDI1MjU=","avatar_url":"https://avatars1.githubusercontent.com/u/7802525?v=4","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"repo":{"id":27729880,"node_id":"MDEwOlJlcG9zaXRvcnkyNzcyOTg4MA==","name":"grpc","full_name":"grpc/grpc","private":false,"owner":{"login":"grpc","id":7802525,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4MDI1MjU=","avatar_url":"https://avatars1.githubusercontent.com/u/7802525?v=4","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/grpc/grpc","description":"The C based gRPC (C++, Python, Ruby, Objective-C, PHP, C#)","fork":false,"url":"https://api.github.com/repos/grpc/grpc","forks_url":"https://api.github.com/repos/grpc/grpc/forks","keys_url":"https://api.github.com/repos/grpc/grpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grpc/grpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grpc/grpc/teams","hooks_url":"https://api.github.com/repos/grpc/grpc/hooks","issue_events_url":"https://api.github.com/repos/grpc/grpc/issues/events{/number}","events_url":"https://api.github.com/repos/grpc/grpc/events","assignees_url":"https://api.github.com/repos/grpc/grpc/assignees{/user}","branches_url":"https://api.github.com/repos/grpc/grpc/branches{/branch}","tags_url":"https://api.github.com/repos/grpc/grpc/tags","blobs_url":"https://api.github.com/repos/grpc/grpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grpc/grpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grpc/grpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/grpc/grpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grpc/grpc/statuses/{sha}","languages_url":"https://api.github.com/repos/grpc/grpc/languages","stargazers_url":"https://api.github.com/repos/grpc/grpc/stargazers","contributors_url":"https://api.github.com/repos/grpc/grpc/contributors","subscribers_url":"https://api.github.com/repos/grpc/grpc/subscribers","subscription_url":"https://api.github.com/repos/grpc/grpc/subscription","commits_url":"https://api.github.com/repos/grpc/grpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/grpc/grpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/grpc/grpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/grpc/grpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/grpc/grpc/contents/{+path}","compare_url":"https://api.github.com/repos/grpc/grpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grpc/grpc/merges","archive_url":"https://api.github.com/repos/grpc/grpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grpc/grpc/downloads","issues_url":"https://api.github.com/repos/grpc/grpc/issues{/number}","pulls_url":"https://api.github.com/repos/grpc/grpc/pulls{/number}","milestones_url":"https://api.github.com/repos/grpc/grpc/milestones{/number}","notifications_url":"https://api.github.com/repos/grpc/grpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grpc/grpc/labels{/name}","releases_url":"https://api.github.com/repos/grpc/grpc/releases{/id}","deployments_url":"https://api.github.com/repos/grpc/grpc/deployments","created_at":"2014-12-08T18:58:53Z","updated_at":"2018-11-15T16:17:05Z","pushed_at":"2018-11-15T16:29:42Z","git_url":"git://github.com/grpc/grpc.git","ssh_url":"git@github.com:grpc/grpc.git","clone_url":"https://github.com/grpc/grpc.git","svn_url":"https://github.com/grpc/grpc","homepage":"https://grpc.io","size":198706,"stargazers_count":18035,"watchers_count":18035,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":4167,"mirror_url":null,"archived":false,"open_issues_count":1096,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":4167,"open_issues":1096,"watchers":18035,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc/pulls/17226"},"html":{"href":"https://github.com/grpc/grpc/pull/17226"},"issue":{"href":"https://api.github.com/repos/grpc/grpc/issues/17226"},"comments":{"href":"https://api.github.com/repos/grpc/grpc/issues/17226/comments"},"review_comments":{"href":"https://api.github.com/repos/grpc/grpc/pulls/17226/comments"},"review_comment":{"href":"https://api.github.com/repos/grpc/grpc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grpc/grpc/pulls/17226/commits"},"statuses":{"href":"https://api.github.com/repos/grpc/grpc/statuses/e205367303444f5c16b83f50b7df11163d249a51"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"AspirinSJL"}}