{"action":"created","comment":{"url":"https://api.github.com/repos/besser82/libxcrypt/pulls/comments/233446704","pull_request_review_id":174856106,"id":233446704,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzQ0NjcwNA==","diff_hunk":"@@ -0,0 +1,37 @@\n+/* libxcrypt interfaces for code compatibility.\n+\n+   Copyright (C) 2018 Björn Esser <besser82@fedoraproject.org>\n+\n+   Redistribution and use in source and binary forms, with or without\n+   modification, are permitted.\n+\n+   THIS SOFTWARE IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS ``AS IS'' AND\n+   ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE\n+   IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE\n+   ARE DISCLAIMED.  IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE\n+   FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL\n+   DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS\n+   OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)\n+   HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT\n+   LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY\n+   OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF\n+   SUCH DAMAGE.  */\n+\n+#ifndef _XCRYPT_H\n+#define _XCRYPT_H 1\n+\n+#include <crypt.h>\n+\n+/* Those are kept for code compatibility with older versions\n+   (v3.1.1 and earlier) of libxcrypt.\n+   We intentionally define these functions as macros here,\n+   since we actually want to link compiled applications against\n+   the unprefixed indentical functions defined in <crypt.h>.  */\n+#ifndef IN_LIBCRYPT  /* Defined when building libxcrypt. */\n+# define xcrypt           crypt\n+# define xcrypt_r         crypt_r\n+# define xcrypt_gensalt   crypt_gensalt\n+# define xcrypt_gensalt_r crypt_gensalt_rn\n+#endif","path":"xcrypt.h","position":35,"original_position":35,"commit_id":"427577f5bd2339f5ce07bbaee43071e23a1987a0","original_commit_id":"427577f5bd2339f5ce07bbaee43071e23a1987a0","user":{"login":"zackw","id":325899,"node_id":"MDQ6VXNlcjMyNTg5OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/325899?v=4","gravatar_id":"","url":"https://api.github.com/users/zackw","html_url":"https://github.com/zackw","followers_url":"https://api.github.com/users/zackw/followers","following_url":"https://api.github.com/users/zackw/following{/other_user}","gists_url":"https://api.github.com/users/zackw/gists{/gist_id}","starred_url":"https://api.github.com/users/zackw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zackw/subscriptions","organizations_url":"https://api.github.com/users/zackw/orgs","repos_url":"https://api.github.com/users/zackw/repos","events_url":"https://api.github.com/users/zackw/events{/privacy}","received_events_url":"https://api.github.com/users/zackw/received_events","type":"User","site_admin":false},"body":"I presume there exist applications that were including this header?  Also see what I said about using `__REDIRECT` instead of macros, when possible.","created_at":"2018-11-14T13:30:46Z","updated_at":"2018-11-14T13:31:34Z","html_url":"https://github.com/besser82/libxcrypt/pull/63#discussion_r233446704","pull_request_url":"https://api.github.com/repos/besser82/libxcrypt/pulls/63","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/besser82/libxcrypt/pulls/comments/233446704"},"html":{"href":"https://github.com/besser82/libxcrypt/pull/63#discussion_r233446704"},"pull_request":{"href":"https://api.github.com/repos/besser82/libxcrypt/pulls/63"}}},"pull_request":{"url":"https://api.github.com/repos/besser82/libxcrypt/pulls/63","id":230484155,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwNDg0MTU1","html_url":"https://github.com/besser82/libxcrypt/pull/63","diff_url":"https://github.com/besser82/libxcrypt/pull/63.diff","patch_url":"https://github.com/besser82/libxcrypt/pull/63.patch","issue_url":"https://api.github.com/repos/besser82/libxcrypt/issues/63","number":63,"state":"open","locked":false,"title":"Add aliases for xcrypt{,_r} and xcrypt_gensalt{,_r}.","user":{"login":"besser82","id":1271348,"node_id":"MDQ6VXNlcjEyNzEzNDg=","avatar_url":"https://avatars3.githubusercontent.com/u/1271348?v=4","gravatar_id":"","url":"https://api.github.com/users/besser82","html_url":"https://github.com/besser82","followers_url":"https://api.github.com/users/besser82/followers","following_url":"https://api.github.com/users/besser82/following{/other_user}","gists_url":"https://api.github.com/users/besser82/gists{/gist_id}","starred_url":"https://api.github.com/users/besser82/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/besser82/subscriptions","organizations_url":"https://api.github.com/users/besser82/orgs","repos_url":"https://api.github.com/users/besser82/repos","events_url":"https://api.github.com/users/besser82/events{/privacy}","received_events_url":"https://api.github.com/users/besser82/received_events","type":"User","site_admin":false},"body":"Those aliases were added for code compatibility with libxcrypt v3.1.1 and earlier.\r\n\r\nAlso replace the prototype for the crypt_gensalt_r function with a macro, so new compiled applications link against the identical crypt_gensalt_rn function directly.","created_at":"2018-11-13T13:57:13Z","updated_at":"2018-11-14T13:31:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"956e1dc9691e11d36689c6a42eb7fe0f37ca9146","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/besser82/libxcrypt/pulls/63/commits","review_comments_url":"https://api.github.com/repos/besser82/libxcrypt/pulls/63/comments","review_comment_url":"https://api.github.com/repos/besser82/libxcrypt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/besser82/libxcrypt/issues/63/comments","statuses_url":"https://api.github.com/repos/besser82/libxcrypt/statuses/427577f5bd2339f5ce07bbaee43071e23a1987a0","head":{"label":"besser82:besser82/old_xcrypt_compat","ref":"besser82/old_xcrypt_compat","sha":"427577f5bd2339f5ce07bbaee43071e23a1987a0","user":{"login":"besser82","id":1271348,"node_id":"MDQ6VXNlcjEyNzEzNDg=","avatar_url":"https://avatars3.githubusercontent.com/u/1271348?v=4","gravatar_id":"","url":"https://api.github.com/users/besser82","html_url":"https://github.com/besser82","followers_url":"https://api.github.com/users/besser82/followers","following_url":"https://api.github.com/users/besser82/following{/other_user}","gists_url":"https://api.github.com/users/besser82/gists{/gist_id}","starred_url":"https://api.github.com/users/besser82/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/besser82/subscriptions","organizations_url":"https://api.github.com/users/besser82/orgs","repos_url":"https://api.github.com/users/besser82/repos","events_url":"https://api.github.com/users/besser82/events{/privacy}","received_events_url":"https://api.github.com/users/besser82/received_events","type":"User","site_admin":false},"repo":{"id":35503965,"node_id":"MDEwOlJlcG9zaXRvcnkzNTUwMzk2NQ==","name":"libxcrypt","full_name":"besser82/libxcrypt","private":false,"owner":{"login":"besser82","id":1271348,"node_id":"MDQ6VXNlcjEyNzEzNDg=","avatar_url":"https://avatars3.githubusercontent.com/u/1271348?v=4","gravatar_id":"","url":"https://api.github.com/users/besser82","html_url":"https://github.com/besser82","followers_url":"https://api.github.com/users/besser82/followers","following_url":"https://api.github.com/users/besser82/following{/other_user}","gists_url":"https://api.github.com/users/besser82/gists{/gist_id}","starred_url":"https://api.github.com/users/besser82/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/besser82/subscriptions","organizations_url":"https://api.github.com/users/besser82/orgs","repos_url":"https://api.github.com/users/besser82/repos","events_url":"https://api.github.com/users/besser82/events{/privacy}","received_events_url":"https://api.github.com/users/besser82/received_events","type":"User","site_admin":false},"html_url":"https://github.com/besser82/libxcrypt","description":"Extended crypt library for DES, MD5, Blowfish and others","fork":false,"url":"https://api.github.com/repos/besser82/libxcrypt","forks_url":"https://api.github.com/repos/besser82/libxcrypt/forks","keys_url":"https://api.github.com/repos/besser82/libxcrypt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/besser82/libxcrypt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/besser82/libxcrypt/teams","hooks_url":"https://api.github.com/repos/besser82/libxcrypt/hooks","issue_events_url":"https://api.github.com/repos/besser82/libxcrypt/issues/events{/number}","events_url":"https://api.github.com/repos/besser82/libxcrypt/events","assignees_url":"https://api.github.com/repos/besser82/libxcrypt/assignees{/user}","branches_url":"https://api.github.com/repos/besser82/libxcrypt/branches{/branch}","tags_url":"https://api.github.com/repos/besser82/libxcrypt/tags","blobs_url":"https://api.github.com/repos/besser82/libxcrypt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/besser82/libxcrypt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/besser82/libxcrypt/git/refs{/sha}","trees_url":"https://api.github.com/repos/besser82/libxcrypt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/besser82/libxcrypt/statuses/{sha}","languages_url":"https://api.github.com/repos/besser82/libxcrypt/languages","stargazers_url":"https://api.github.com/repos/besser82/libxcrypt/stargazers","contributors_url":"https://api.github.com/repos/besser82/libxcrypt/contributors","subscribers_url":"https://api.github.com/repos/besser82/libxcrypt/subscribers","subscription_url":"https://api.github.com/repos/besser82/libxcrypt/subscription","commits_url":"https://api.github.com/repos/besser82/libxcrypt/commits{/sha}","git_commits_url":"https://api.github.com/repos/besser82/libxcrypt/git/commits{/sha}","comments_url":"https://api.github.com/repos/besser82/libxcrypt/comments{/number}","issue_comment_url":"https://api.github.com/repos/besser82/libxcrypt/issues/comments{/number}","contents_url":"https://api.github.com/repos/besser82/libxcrypt/contents/{+path}","compare_url":"https://api.github.com/repos/besser82/libxcrypt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/besser82/libxcrypt/merges","archive_url":"https://api.github.com/repos/besser82/libxcrypt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/besser82/libxcrypt/downloads","issues_url":"https://api.github.com/repos/besser82/libxcrypt/issues{/number}","pulls_url":"https://api.github.com/repos/besser82/libxcrypt/pulls{/number}","milestones_url":"https://api.github.com/repos/besser82/libxcrypt/milestones{/number}","notifications_url":"https://api.github.com/repos/besser82/libxcrypt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/besser82/libxcrypt/labels{/name}","releases_url":"https://api.github.com/repos/besser82/libxcrypt/releases{/id}","deployments_url":"https://api.github.com/repos/besser82/libxcrypt/deployments","created_at":"2015-05-12T17:57:11Z","updated_at":"2018-11-14T10:49:23Z","pushed_at":"2018-11-14T10:51:05Z","git_url":"git://github.com/besser82/libxcrypt.git","ssh_url":"git@github.com:besser82/libxcrypt.git","clone_url":"https://github.com/besser82/libxcrypt.git","svn_url":"https://github.com/besser82/libxcrypt","homepage":"","size":1284,"stargazers_count":14,"watchers_count":14,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":3,"open_issues":11,"watchers":14,"default_branch":"develop"}},"base":{"label":"besser82:develop","ref":"develop","sha":"65485d7891cfe50db941ab14e864bb485a54d71c","user":{"login":"besser82","id":1271348,"node_id":"MDQ6VXNlcjEyNzEzNDg=","avatar_url":"https://avatars3.githubusercontent.com/u/1271348?v=4","gravatar_id":"","url":"https://api.github.com/users/besser82","html_url":"https://github.com/besser82","followers_url":"https://api.github.com/users/besser82/followers","following_url":"https://api.github.com/users/besser82/following{/other_user}","gists_url":"https://api.github.com/users/besser82/gists{/gist_id}","starred_url":"https://api.github.com/users/besser82/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/besser82/subscriptions","organizations_url":"https://api.github.com/users/besser82/orgs","repos_url":"https://api.github.com/users/besser82/repos","events_url":"https://api.github.com/users/besser82/events{/privacy}","received_events_url":"https://api.github.com/users/besser82/received_events","type":"User","site_admin":false},"repo":{"id":35503965,"node_id":"MDEwOlJlcG9zaXRvcnkzNTUwMzk2NQ==","name":"libxcrypt","full_name":"besser82/libxcrypt","private":false,"owner":{"login":"besser82","id":1271348,"node_id":"MDQ6VXNlcjEyNzEzNDg=","avatar_url":"https://avatars3.githubusercontent.com/u/1271348?v=4","gravatar_id":"","url":"https://api.github.com/users/besser82","html_url":"https://github.com/besser82","followers_url":"https://api.github.com/users/besser82/followers","following_url":"https://api.github.com/users/besser82/following{/other_user}","gists_url":"https://api.github.com/users/besser82/gists{/gist_id}","starred_url":"https://api.github.com/users/besser82/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/besser82/subscriptions","organizations_url":"https://api.github.com/users/besser82/orgs","repos_url":"https://api.github.com/users/besser82/repos","events_url":"https://api.github.com/users/besser82/events{/privacy}","received_events_url":"https://api.github.com/users/besser82/received_events","type":"User","site_admin":false},"html_url":"https://github.com/besser82/libxcrypt","description":"Extended crypt library for DES, MD5, Blowfish and others","fork":false,"url":"https://api.github.com/repos/besser82/libxcrypt","forks_url":"https://api.github.com/repos/besser82/libxcrypt/forks","keys_url":"https://api.github.com/repos/besser82/libxcrypt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/besser82/libxcrypt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/besser82/libxcrypt/teams","hooks_url":"https://api.github.com/repos/besser82/libxcrypt/hooks","issue_events_url":"https://api.github.com/repos/besser82/libxcrypt/issues/events{/number}","events_url":"https://api.github.com/repos/besser82/libxcrypt/events","assignees_url":"https://api.github.com/repos/besser82/libxcrypt/assignees{/user}","branches_url":"https://api.github.com/repos/besser82/libxcrypt/branches{/branch}","tags_url":"https://api.github.com/repos/besser82/libxcrypt/tags","blobs_url":"https://api.github.com/repos/besser82/libxcrypt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/besser82/libxcrypt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/besser82/libxcrypt/git/refs{/sha}","trees_url":"https://api.github.com/repos/besser82/libxcrypt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/besser82/libxcrypt/statuses/{sha}","languages_url":"https://api.github.com/repos/besser82/libxcrypt/languages","stargazers_url":"https://api.github.com/repos/besser82/libxcrypt/stargazers","contributors_url":"https://api.github.com/repos/besser82/libxcrypt/contributors","subscribers_url":"https://api.github.com/repos/besser82/libxcrypt/subscribers","subscription_url":"https://api.github.com/repos/besser82/libxcrypt/subscription","commits_url":"https://api.github.com/repos/besser82/libxcrypt/commits{/sha}","git_commits_url":"https://api.github.com/repos/besser82/libxcrypt/git/commits{/sha}","comments_url":"https://api.github.com/repos/besser82/libxcrypt/comments{/number}","issue_comment_url":"https://api.github.com/repos/besser82/libxcrypt/issues/comments{/number}","contents_url":"https://api.github.com/repos/besser82/libxcrypt/contents/{+path}","compare_url":"https://api.github.com/repos/besser82/libxcrypt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/besser82/libxcrypt/merges","archive_url":"https://api.github.com/repos/besser82/libxcrypt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/besser82/libxcrypt/downloads","issues_url":"https://api.github.com/repos/besser82/libxcrypt/issues{/number}","pulls_url":"https://api.github.com/repos/besser82/libxcrypt/pulls{/number}","milestones_url":"https://api.github.com/repos/besser82/libxcrypt/milestones{/number}","notifications_url":"https://api.github.com/repos/besser82/libxcrypt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/besser82/libxcrypt/labels{/name}","releases_url":"https://api.github.com/repos/besser82/libxcrypt/releases{/id}","deployments_url":"https://api.github.com/repos/besser82/libxcrypt/deployments","created_at":"2015-05-12T17:57:11Z","updated_at":"2018-11-14T10:49:23Z","pushed_at":"2018-11-14T10:51:05Z","git_url":"git://github.com/besser82/libxcrypt.git","ssh_url":"git@github.com:besser82/libxcrypt.git","clone_url":"https://github.com/besser82/libxcrypt.git","svn_url":"https://github.com/besser82/libxcrypt","homepage":"","size":1284,"stargazers_count":14,"watchers_count":14,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":3,"open_issues":11,"watchers":14,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/besser82/libxcrypt/pulls/63"},"html":{"href":"https://github.com/besser82/libxcrypt/pull/63"},"issue":{"href":"https://api.github.com/repos/besser82/libxcrypt/issues/63"},"comments":{"href":"https://api.github.com/repos/besser82/libxcrypt/issues/63/comments"},"review_comments":{"href":"https://api.github.com/repos/besser82/libxcrypt/pulls/63/comments"},"review_comment":{"href":"https://api.github.com/repos/besser82/libxcrypt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/besser82/libxcrypt/pulls/63/commits"},"statuses":{"href":"https://api.github.com/repos/besser82/libxcrypt/statuses/427577f5bd2339f5ce07bbaee43071e23a1987a0"}},"author_association":"OWNER"}}
{"actor":{"display_login":"zackw"}}