{"action":"created","comment":{"url":"https://api.github.com/repos/openregister/registers-frontend/pulls/comments/240627207","pull_request_review_id":183698254,"id":240627207,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MDYyNzIwNw==","diff_hunk":"@@ -0,0 +1,23 @@\n+\n+%table.registers-secondary-table\n+  %caption.registers-secondary-table__caption\n+    The\n+    <!-- -->\n+    %b #{@register.register_fields.count} fields\n+    <!-- -->","path":"app/views/registers/_fields.html.haml","position":7,"original_position":7,"commit_id":"037899393f73010be43c1b6338105cc271cc4996","original_commit_id":"037899393f73010be43c1b6338105cc271cc4996","user":{"login":"injms","id":1732331,"node_id":"MDQ6VXNlcjE3MzIzMzE=","avatar_url":"https://avatars1.githubusercontent.com/u/1732331?v=4","gravatar_id":"","url":"https://api.github.com/users/injms","html_url":"https://github.com/injms","followers_url":"https://api.github.com/users/injms/followers","following_url":"https://api.github.com/users/injms/following{/other_user}","gists_url":"https://api.github.com/users/injms/gists{/gist_id}","starred_url":"https://api.github.com/users/injms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/injms/subscriptions","organizations_url":"https://api.github.com/users/injms/orgs","repos_url":"https://api.github.com/users/injms/repos","events_url":"https://api.github.com/users/injms/events{/privacy}","received_events_url":"https://api.github.com/users/injms/received_events","type":"User","site_admin":false},"body":"Unfortunately not if we want spaces between the words - Haml is set up to strip out whitespace, even here when you've got nested elements.\r\n","created_at":"2018-12-11T14:18:46Z","updated_at":"2018-12-11T14:18:46Z","html_url":"https://github.com/openregister/registers-frontend/pull/522#discussion_r240627207","pull_request_url":"https://api.github.com/repos/openregister/registers-frontend/pulls/522","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/openregister/registers-frontend/pulls/comments/240627207"},"html":{"href":"https://github.com/openregister/registers-frontend/pull/522#discussion_r240627207"},"pull_request":{"href":"https://api.github.com/repos/openregister/registers-frontend/pulls/522"}},"in_reply_to_id":240562646},"pull_request":{"url":"https://api.github.com/repos/openregister/registers-frontend/pulls/522","id":236891834,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2ODkxODM0","html_url":"https://github.com/openregister/registers-frontend/pull/522","diff_url":"https://github.com/openregister/registers-frontend/pull/522.diff","patch_url":"https://github.com/openregister/registers-frontend/pull/522.patch","issue_url":"https://api.github.com/repos/openregister/registers-frontend/issues/522","number":522,"state":"open","locked":false,"title":"New tables for registers page","user":{"login":"injms","id":1732331,"node_id":"MDQ6VXNlcjE3MzIzMzE=","avatar_url":"https://avatars1.githubusercontent.com/u/1732331?v=4","gravatar_id":"","url":"https://api.github.com/users/injms","html_url":"https://github.com/injms","followers_url":"https://api.github.com/users/injms/followers","following_url":"https://api.github.com/users/injms/following{/other_user}","gists_url":"https://api.github.com/users/injms/gists{/gist_id}","starred_url":"https://api.github.com/users/injms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/injms/subscriptions","organizations_url":"https://api.github.com/users/injms/orgs","repos_url":"https://api.github.com/users/injms/repos","events_url":"https://api.github.com/users/injms/events{/privacy}","received_events_url":"https://api.github.com/users/injms/received_events","type":"User","site_admin":false},"body":"### Context\r\nThe page for each register contains a table showing the data contained in that register. This is being updated to only show a set number of records. A further table is added to show the register's fields, plus an example of each field from that register.\r\n\r\nThis should follow the layout in the prototype, as linked to from the [card](https://trello.com/c/p0jeQjUc/3133-implement-new-field-descriptions-and-preview-on-individual-register-pages).\r\n\r\n### Changes proposed in this pull request\r\n* table of records limited to 5 on all registers, except those published by DCMS which is limited to 10\r\n* 'load more' or pagination only present on DCMS published registers\r\n* Question mark (What is...?) removed from table header\r\n* Table showing fields and examples for each field added\r\n* Removes search; removes search tests\r\n\r\n### Guidance to review\r\n* No DCMS registers are on the staging site or on the local seeds; give me a shout and we can copy the live database to your local install\r\n* Please take a look at the `fields_with_examples` method in the register model - insight into the psql query for the json blob welcome\r\n* The examples sometimes, depending on the register, run into the problem that they all look as if they're linked when they're not. For example, on the countries register all the examples except for start date and end date are from the same record - giving the impression that all examples are linked. This is something I'm going to ask Stephen and Mark about.","created_at":"2018-12-07T14:50:37Z","updated_at":"2018-12-11T14:18:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cd8a92c11e6b09ea7594e068e720680c9d2fdc69","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/openregister/registers-frontend/pulls/522/commits","review_comments_url":"https://api.github.com/repos/openregister/registers-frontend/pulls/522/comments","review_comment_url":"https://api.github.com/repos/openregister/registers-frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openregister/registers-frontend/issues/522/comments","statuses_url":"https://api.github.com/repos/openregister/registers-frontend/statuses/037899393f73010be43c1b6338105cc271cc4996","head":{"label":"openregister:new-tables-for-registers","ref":"new-tables-for-registers","sha":"037899393f73010be43c1b6338105cc271cc4996","user":{"login":"openregister","id":10206003,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMjA2MDAz","avatar_url":"https://avatars1.githubusercontent.com/u/10206003?v=4","gravatar_id":"","url":"https://api.github.com/users/openregister","html_url":"https://github.com/openregister","followers_url":"https://api.github.com/users/openregister/followers","following_url":"https://api.github.com/users/openregister/following{/other_user}","gists_url":"https://api.github.com/users/openregister/gists{/gist_id}","starred_url":"https://api.github.com/users/openregister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openregister/subscriptions","organizations_url":"https://api.github.com/users/openregister/orgs","repos_url":"https://api.github.com/users/openregister/repos","events_url":"https://api.github.com/users/openregister/events{/privacy}","received_events_url":"https://api.github.com/users/openregister/received_events","type":"Organization","site_admin":false},"repo":{"id":79900152,"node_id":"MDEwOlJlcG9zaXRvcnk3OTkwMDE1Mg==","name":"registers-frontend","full_name":"openregister/registers-frontend","private":false,"owner":{"login":"openregister","id":10206003,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMjA2MDAz","avatar_url":"https://avatars1.githubusercontent.com/u/10206003?v=4","gravatar_id":"","url":"https://api.github.com/users/openregister","html_url":"https://github.com/openregister","followers_url":"https://api.github.com/users/openregister/followers","following_url":"https://api.github.com/users/openregister/following{/other_user}","gists_url":"https://api.github.com/users/openregister/gists{/gist_id}","starred_url":"https://api.github.com/users/openregister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openregister/subscriptions","organizations_url":"https://api.github.com/users/openregister/orgs","repos_url":"https://api.github.com/users/openregister/repos","events_url":"https://api.github.com/users/openregister/events{/privacy}","received_events_url":"https://api.github.com/users/openregister/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/openregister/registers-frontend","description":"GOV.UK Registers Frontend","fork":false,"url":"https://api.github.com/repos/openregister/registers-frontend","forks_url":"https://api.github.com/repos/openregister/registers-frontend/forks","keys_url":"https://api.github.com/repos/openregister/registers-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openregister/registers-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openregister/registers-frontend/teams","hooks_url":"https://api.github.com/repos/openregister/registers-frontend/hooks","issue_events_url":"https://api.github.com/repos/openregister/registers-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/openregister/registers-frontend/events","assignees_url":"https://api.github.com/repos/openregister/registers-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/openregister/registers-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/openregister/registers-frontend/tags","blobs_url":"https://api.github.com/repos/openregister/registers-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openregister/registers-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openregister/registers-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/openregister/registers-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openregister/registers-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/openregister/registers-frontend/languages","stargazers_url":"https://api.github.com/repos/openregister/registers-frontend/stargazers","contributors_url":"https://api.github.com/repos/openregister/registers-frontend/contributors","subscribers_url":"https://api.github.com/repos/openregister/registers-frontend/subscribers","subscription_url":"https://api.github.com/repos/openregister/registers-frontend/subscription","commits_url":"https://api.github.com/repos/openregister/registers-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/openregister/registers-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/openregister/registers-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/openregister/registers-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/openregister/registers-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/openregister/registers-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openregister/registers-frontend/merges","archive_url":"https://api.github.com/repos/openregister/registers-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openregister/registers-frontend/downloads","issues_url":"https://api.github.com/repos/openregister/registers-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/openregister/registers-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/openregister/registers-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/openregister/registers-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openregister/registers-frontend/labels{/name}","releases_url":"https://api.github.com/repos/openregister/registers-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/openregister/registers-frontend/deployments","created_at":"2017-01-24T10:11:12Z","updated_at":"2018-12-10T08:20:42Z","pushed_at":"2018-12-11T10:45:35Z","git_url":"git://github.com/openregister/registers-frontend.git","ssh_url":"git@github.com:openregister/registers-frontend.git","clone_url":"https://github.com/openregister/registers-frontend.git","svn_url":"https://github.com/openregister/registers-frontend","homepage":"https://www.registers.service.gov.uk/","size":3613,"stargazers_count":4,"watchers_count":4,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":8,"watchers":4,"default_branch":"master"}},"base":{"label":"openregister:master","ref":"master","sha":"f5ddf9c3009a70dc0a1aa73799769b8cbbb32570","user":{"login":"openregister","id":10206003,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMjA2MDAz","avatar_url":"https://avatars1.githubusercontent.com/u/10206003?v=4","gravatar_id":"","url":"https://api.github.com/users/openregister","html_url":"https://github.com/openregister","followers_url":"https://api.github.com/users/openregister/followers","following_url":"https://api.github.com/users/openregister/following{/other_user}","gists_url":"https://api.github.com/users/openregister/gists{/gist_id}","starred_url":"https://api.github.com/users/openregister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openregister/subscriptions","organizations_url":"https://api.github.com/users/openregister/orgs","repos_url":"https://api.github.com/users/openregister/repos","events_url":"https://api.github.com/users/openregister/events{/privacy}","received_events_url":"https://api.github.com/users/openregister/received_events","type":"Organization","site_admin":false},"repo":{"id":79900152,"node_id":"MDEwOlJlcG9zaXRvcnk3OTkwMDE1Mg==","name":"registers-frontend","full_name":"openregister/registers-frontend","private":false,"owner":{"login":"openregister","id":10206003,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMjA2MDAz","avatar_url":"https://avatars1.githubusercontent.com/u/10206003?v=4","gravatar_id":"","url":"https://api.github.com/users/openregister","html_url":"https://github.com/openregister","followers_url":"https://api.github.com/users/openregister/followers","following_url":"https://api.github.com/users/openregister/following{/other_user}","gists_url":"https://api.github.com/users/openregister/gists{/gist_id}","starred_url":"https://api.github.com/users/openregister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openregister/subscriptions","organizations_url":"https://api.github.com/users/openregister/orgs","repos_url":"https://api.github.com/users/openregister/repos","events_url":"https://api.github.com/users/openregister/events{/privacy}","received_events_url":"https://api.github.com/users/openregister/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/openregister/registers-frontend","description":"GOV.UK Registers Frontend","fork":false,"url":"https://api.github.com/repos/openregister/registers-frontend","forks_url":"https://api.github.com/repos/openregister/registers-frontend/forks","keys_url":"https://api.github.com/repos/openregister/registers-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openregister/registers-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openregister/registers-frontend/teams","hooks_url":"https://api.github.com/repos/openregister/registers-frontend/hooks","issue_events_url":"https://api.github.com/repos/openregister/registers-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/openregister/registers-frontend/events","assignees_url":"https://api.github.com/repos/openregister/registers-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/openregister/registers-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/openregister/registers-frontend/tags","blobs_url":"https://api.github.com/repos/openregister/registers-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openregister/registers-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openregister/registers-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/openregister/registers-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openregister/registers-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/openregister/registers-frontend/languages","stargazers_url":"https://api.github.com/repos/openregister/registers-frontend/stargazers","contributors_url":"https://api.github.com/repos/openregister/registers-frontend/contributors","subscribers_url":"https://api.github.com/repos/openregister/registers-frontend/subscribers","subscription_url":"https://api.github.com/repos/openregister/registers-frontend/subscription","commits_url":"https://api.github.com/repos/openregister/registers-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/openregister/registers-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/openregister/registers-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/openregister/registers-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/openregister/registers-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/openregister/registers-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openregister/registers-frontend/merges","archive_url":"https://api.github.com/repos/openregister/registers-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openregister/registers-frontend/downloads","issues_url":"https://api.github.com/repos/openregister/registers-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/openregister/registers-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/openregister/registers-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/openregister/registers-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openregister/registers-frontend/labels{/name}","releases_url":"https://api.github.com/repos/openregister/registers-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/openregister/registers-frontend/deployments","created_at":"2017-01-24T10:11:12Z","updated_at":"2018-12-10T08:20:42Z","pushed_at":"2018-12-11T10:45:35Z","git_url":"git://github.com/openregister/registers-frontend.git","ssh_url":"git@github.com:openregister/registers-frontend.git","clone_url":"https://github.com/openregister/registers-frontend.git","svn_url":"https://github.com/openregister/registers-frontend","homepage":"https://www.registers.service.gov.uk/","size":3613,"stargazers_count":4,"watchers_count":4,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":8,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openregister/registers-frontend/pulls/522"},"html":{"href":"https://github.com/openregister/registers-frontend/pull/522"},"issue":{"href":"https://api.github.com/repos/openregister/registers-frontend/issues/522"},"comments":{"href":"https://api.github.com/repos/openregister/registers-frontend/issues/522/comments"},"review_comments":{"href":"https://api.github.com/repos/openregister/registers-frontend/pulls/522/comments"},"review_comment":{"href":"https://api.github.com/repos/openregister/registers-frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openregister/registers-frontend/pulls/522/commits"},"statuses":{"href":"https://api.github.com/repos/openregister/registers-frontend/statuses/037899393f73010be43c1b6338105cc271cc4996"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"injms"}}