{"action":"created","issue":{"url":"https://api.github.com/repos/valhalla/valhalla/issues/1537","repository_url":"https://api.github.com/repos/valhalla/valhalla","labels_url":"https://api.github.com/repos/valhalla/valhalla/issues/1537/labels{/name}","comments_url":"https://api.github.com/repos/valhalla/valhalla/issues/1537/comments","events_url":"https://api.github.com/repos/valhalla/valhalla/issues/1537/events","html_url":"https://github.com/valhalla/valhalla/pull/1537","id":360995448,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2MDc4MTYx","number":1537,"title":"Finish separating valhalla_build_transit into fetch and convert steps","user":{"login":"irees","id":720087,"node_id":"MDQ6VXNlcjcyMDA4Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/720087?v=4","gravatar_id":"","url":"https://api.github.com/users/irees","html_url":"https://github.com/irees","followers_url":"https://api.github.com/users/irees/followers","following_url":"https://api.github.com/users/irees/following{/other_user}","gists_url":"https://api.github.com/users/irees/gists{/gist_id}","starred_url":"https://api.github.com/users/irees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/irees/subscriptions","organizations_url":"https://api.github.com/users/irees/orgs","repos_url":"https://api.github.com/users/irees/repos","events_url":"https://api.github.com/users/irees/events{/privacy}","received_events_url":"https://api.github.com/users/irees/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-09-17T18:47:14Z","updated_at":"2018-09-18T13:50:49Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/valhalla/valhalla/pulls/1537","html_url":"https://github.com/valhalla/valhalla/pull/1537","diff_url":"https://github.com/valhalla/valhalla/pull/1537.diff","patch_url":"https://github.com/valhalla/valhalla/pull/1537.patch"},"body":"# Issue\r\n\r\nHi all. I am doing some maintenance on Transitland, and hope to improve our exported tiles. This PR removes some duplicated transit fetch code and should simplify future maintenance.\r\n\r\nCompletes the separation of the `valhalla_build_transit` program into two separate programs:\r\n- the existing `valhalla_fetch_transit` (updated to use the `stop_stations` endpoints from `valhalla_build_transit`) \r\n- a new program, `valhalla_convert_transit` which converts PBF to GPH tiles (essentially `valhalla_build_transit` with fetch-related code removed)\r\n\r\nAdditionally, a shell script for `valhalla_build_transit` provides backwards compatibility. It runs `valhalla_fetch_transit` immediately followed by `valhalla_convert_transit`. \r\n\r\nA `transitpbf.h` header file contains the transit PBF reading/writing code in common between these programs.\r\n\r\nI welcome any suggestions and feedback.\r\n\r\n## Tasklist\r\n\r\n - [ ] Add tests\r\n - [ ] Review - you must request approval to merge any PR to master\r\n - [ ] Add #fixes with the issue number that this PR addresses\r\n - [ ] Generally use squash merge to rebase and clean comments before merging\r\n - [ ] Update the [changelog](CHANGELOG.md)\r\n - [ ] Update relevant [documentation](docs/README.md)\r\n\r\n## Requirements / Relations\r\n\r\n Link any requirements here. Other pull requests this PR is based on?\r\n"},"comment":{"url":"https://api.github.com/repos/valhalla/valhalla/issues/comments/422401157","html_url":"https://github.com/valhalla/valhalla/pull/1537#issuecomment-422401157","issue_url":"https://api.github.com/repos/valhalla/valhalla/issues/1537","id":422401157,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMjQwMTE1Nw==","user":{"login":"gknisely","id":2676277,"node_id":"MDQ6VXNlcjI2NzYyNzc=","avatar_url":"https://avatars2.githubusercontent.com/u/2676277?v=4","gravatar_id":"","url":"https://api.github.com/users/gknisely","html_url":"https://github.com/gknisely","followers_url":"https://api.github.com/users/gknisely/followers","following_url":"https://api.github.com/users/gknisely/following{/other_user}","gists_url":"https://api.github.com/users/gknisely/gists{/gist_id}","starred_url":"https://api.github.com/users/gknisely/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gknisely/subscriptions","organizations_url":"https://api.github.com/users/gknisely/orgs","repos_url":"https://api.github.com/users/gknisely/repos","events_url":"https://api.github.com/users/gknisely/events{/privacy}","received_events_url":"https://api.github.com/users/gknisely/received_events","type":"User","site_admin":false},"created_at":"2018-09-18T13:50:49Z","updated_at":"2018-09-18T13:50:49Z","author_association":"MEMBER","body":"@irees I actually have a PR that I am going to submit soon.  It removes the boost date_time dependency from the transit logic.  Any chance you can grab those updates after I merge?  "}}
{"actor":{"display_login":"gknisely"}}