{"action":"closed","number":5830,"pull_request":{"url":"https://api.github.com/repos/keycloak/keycloak/pulls/5830","id":241339307,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxMzM5MzA3","html_url":"https://github.com/keycloak/keycloak/pull/5830","diff_url":"https://github.com/keycloak/keycloak/pull/5830.diff","patch_url":"https://github.com/keycloak/keycloak/pull/5830.patch","issue_url":"https://api.github.com/repos/keycloak/keycloak/issues/5830","number":5830,"state":"closed","locked":false,"title":"[KEYCLOAK-9179] Fix/google id provider profile url","user":{"login":"jcampbell","id":332575,"node_id":"MDQ6VXNlcjMzMjU3NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/332575?v=4","gravatar_id":"","url":"https://api.github.com/users/jcampbell","html_url":"https://github.com/jcampbell","followers_url":"https://api.github.com/users/jcampbell/followers","following_url":"https://api.github.com/users/jcampbell/following{/other_user}","gists_url":"https://api.github.com/users/jcampbell/gists{/gist_id}","starred_url":"https://api.github.com/users/jcampbell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcampbell/subscriptions","organizations_url":"https://api.github.com/users/jcampbell/orgs","repos_url":"https://api.github.com/users/jcampbell/repos","events_url":"https://api.github.com/users/jcampbell/events{/privacy}","received_events_url":"https://api.github.com/users/jcampbell/received_events","type":"User","site_admin":false},"body":"The GoogleIdentityProvider (keycloak\\services\\src\\main\\java\\org\\keycloak\\social\\google\\GoogleIdentityProvider.java) uses the Google+ API for profile information, via the hard-coded profile URL hard-coded into it (\"https://www.googleapis.com/plus/v1/people/me/openIdConnect\").\r\n\r\nGoogle has deprecated this API, and apparently plans to shut it down completely by 7 March 2019, with intermittent failures starting 28 January 2019. See: https://developers.google.com/+/web/api/rest/latest/people/get\r\nhttps://developers.google.com/+/api-shutdown\r\n\r\nSince the GoogleIdentityProvider is already using the oauth2/v2 endpoints, it seems like a very simple change to the following endpoint for (basic) profile information would address the issue: https://www.googleapis.com/oauth2/v2/userinfo\r\n\r\nHowever, I don't see fixed mappings in the provider now, which I suppose means anyone using them is building them on a per-installation basis (is that right?), and so we'd need to address that migration path. Additionally, it is possible that it would make sense to convert to the people API, which provides much fuller profile information. However, unlike with oauth2/v2 endpoints, that would require developers specifically enable it (as they currently have to for Google+, but do not have to for basic profile and signin).","created_at":"2018-12-28T14:07:28Z","updated_at":"2019-01-03T13:37:48Z","closed_at":"2019-01-03T13:37:48Z","merged_at":null,"merge_commit_sha":"042ae7f560cf8a61c715d3b63425e33912fc64a5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":892326668,"node_id":"MDU6TGFiZWw4OTIzMjY2Njg=","url":"https://api.github.com/repos/keycloak/keycloak/labels/Hold","name":"Hold","color":"b60205","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/keycloak/keycloak/pulls/5830/commits","review_comments_url":"https://api.github.com/repos/keycloak/keycloak/pulls/5830/comments","review_comment_url":"https://api.github.com/repos/keycloak/keycloak/pulls/comments{/number}","comments_url":"https://api.github.com/repos/keycloak/keycloak/issues/5830/comments","statuses_url":"https://api.github.com/repos/keycloak/keycloak/statuses/40fa9780d257eddad664c4733445c4d721eaca86","head":{"label":"jcampbell:fix/google_id_provider_profile_url","ref":"fix/google_id_provider_profile_url","sha":"40fa9780d257eddad664c4733445c4d721eaca86","user":{"login":"jcampbell","id":332575,"node_id":"MDQ6VXNlcjMzMjU3NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/332575?v=4","gravatar_id":"","url":"https://api.github.com/users/jcampbell","html_url":"https://github.com/jcampbell","followers_url":"https://api.github.com/users/jcampbell/followers","following_url":"https://api.github.com/users/jcampbell/following{/other_user}","gists_url":"https://api.github.com/users/jcampbell/gists{/gist_id}","starred_url":"https://api.github.com/users/jcampbell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcampbell/subscriptions","organizations_url":"https://api.github.com/users/jcampbell/orgs","repos_url":"https://api.github.com/users/jcampbell/repos","events_url":"https://api.github.com/users/jcampbell/events{/privacy}","received_events_url":"https://api.github.com/users/jcampbell/received_events","type":"User","site_admin":false},"repo":{"id":162772186,"node_id":"MDEwOlJlcG9zaXRvcnkxNjI3NzIxODY=","name":"keycloak","full_name":"jcampbell/keycloak","private":false,"owner":{"login":"jcampbell","id":332575,"node_id":"MDQ6VXNlcjMzMjU3NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/332575?v=4","gravatar_id":"","url":"https://api.github.com/users/jcampbell","html_url":"https://github.com/jcampbell","followers_url":"https://api.github.com/users/jcampbell/followers","following_url":"https://api.github.com/users/jcampbell/following{/other_user}","gists_url":"https://api.github.com/users/jcampbell/gists{/gist_id}","starred_url":"https://api.github.com/users/jcampbell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcampbell/subscriptions","organizations_url":"https://api.github.com/users/jcampbell/orgs","repos_url":"https://api.github.com/users/jcampbell/repos","events_url":"https://api.github.com/users/jcampbell/events{/privacy}","received_events_url":"https://api.github.com/users/jcampbell/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jcampbell/keycloak","description":"Open Source Identity and Access Management For Modern Applications and Services","fork":true,"url":"https://api.github.com/repos/jcampbell/keycloak","forks_url":"https://api.github.com/repos/jcampbell/keycloak/forks","keys_url":"https://api.github.com/repos/jcampbell/keycloak/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jcampbell/keycloak/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jcampbell/keycloak/teams","hooks_url":"https://api.github.com/repos/jcampbell/keycloak/hooks","issue_events_url":"https://api.github.com/repos/jcampbell/keycloak/issues/events{/number}","events_url":"https://api.github.com/repos/jcampbell/keycloak/events","assignees_url":"https://api.github.com/repos/jcampbell/keycloak/assignees{/user}","branches_url":"https://api.github.com/repos/jcampbell/keycloak/branches{/branch}","tags_url":"https://api.github.com/repos/jcampbell/keycloak/tags","blobs_url":"https://api.github.com/repos/jcampbell/keycloak/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jcampbell/keycloak/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jcampbell/keycloak/git/refs{/sha}","trees_url":"https://api.github.com/repos/jcampbell/keycloak/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jcampbell/keycloak/statuses/{sha}","languages_url":"https://api.github.com/repos/jcampbell/keycloak/languages","stargazers_url":"https://api.github.com/repos/jcampbell/keycloak/stargazers","contributors_url":"https://api.github.com/repos/jcampbell/keycloak/contributors","subscribers_url":"https://api.github.com/repos/jcampbell/keycloak/subscribers","subscription_url":"https://api.github.com/repos/jcampbell/keycloak/subscription","commits_url":"https://api.github.com/repos/jcampbell/keycloak/commits{/sha}","git_commits_url":"https://api.github.com/repos/jcampbell/keycloak/git/commits{/sha}","comments_url":"https://api.github.com/repos/jcampbell/keycloak/comments{/number}","issue_comment_url":"https://api.github.com/repos/jcampbell/keycloak/issues/comments{/number}","contents_url":"https://api.github.com/repos/jcampbell/keycloak/contents/{+path}","compare_url":"https://api.github.com/repos/jcampbell/keycloak/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jcampbell/keycloak/merges","archive_url":"https://api.github.com/repos/jcampbell/keycloak/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jcampbell/keycloak/downloads","issues_url":"https://api.github.com/repos/jcampbell/keycloak/issues{/number}","pulls_url":"https://api.github.com/repos/jcampbell/keycloak/pulls{/number}","milestones_url":"https://api.github.com/repos/jcampbell/keycloak/milestones{/number}","notifications_url":"https://api.github.com/repos/jcampbell/keycloak/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jcampbell/keycloak/labels{/name}","releases_url":"https://api.github.com/repos/jcampbell/keycloak/releases{/id}","deployments_url":"https://api.github.com/repos/jcampbell/keycloak/deployments","created_at":"2018-12-22T01:30:24Z","updated_at":"2019-01-03T01:51:32Z","pushed_at":"2019-01-03T01:51:30Z","git_url":"git://github.com/jcampbell/keycloak.git","ssh_url":"git@github.com:jcampbell/keycloak.git","clone_url":"https://github.com/jcampbell/keycloak.git","svn_url":"https://github.com/jcampbell/keycloak","homepage":"http://www.keycloak.org","size":130011,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"keycloak:master","ref":"master","sha":"83b2642c4e875345d288546e9bc9efaae0d27680","user":{"login":"keycloak","id":4921466,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5MjE0NjY=","avatar_url":"https://avatars1.githubusercontent.com/u/4921466?v=4","gravatar_id":"","url":"https://api.github.com/users/keycloak","html_url":"https://github.com/keycloak","followers_url":"https://api.github.com/users/keycloak/followers","following_url":"https://api.github.com/users/keycloak/following{/other_user}","gists_url":"https://api.github.com/users/keycloak/gists{/gist_id}","starred_url":"https://api.github.com/users/keycloak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keycloak/subscriptions","organizations_url":"https://api.github.com/users/keycloak/orgs","repos_url":"https://api.github.com/users/keycloak/repos","events_url":"https://api.github.com/users/keycloak/events{/privacy}","received_events_url":"https://api.github.com/users/keycloak/received_events","type":"Organization","site_admin":false},"repo":{"id":11125589,"node_id":"MDEwOlJlcG9zaXRvcnkxMTEyNTU4OQ==","name":"keycloak","full_name":"keycloak/keycloak","private":false,"owner":{"login":"keycloak","id":4921466,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5MjE0NjY=","avatar_url":"https://avatars1.githubusercontent.com/u/4921466?v=4","gravatar_id":"","url":"https://api.github.com/users/keycloak","html_url":"https://github.com/keycloak","followers_url":"https://api.github.com/users/keycloak/followers","following_url":"https://api.github.com/users/keycloak/following{/other_user}","gists_url":"https://api.github.com/users/keycloak/gists{/gist_id}","starred_url":"https://api.github.com/users/keycloak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keycloak/subscriptions","organizations_url":"https://api.github.com/users/keycloak/orgs","repos_url":"https://api.github.com/users/keycloak/repos","events_url":"https://api.github.com/users/keycloak/events{/privacy}","received_events_url":"https://api.github.com/users/keycloak/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/keycloak/keycloak","description":"Open Source Identity and Access Management For Modern Applications and Services","fork":false,"url":"https://api.github.com/repos/keycloak/keycloak","forks_url":"https://api.github.com/repos/keycloak/keycloak/forks","keys_url":"https://api.github.com/repos/keycloak/keycloak/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keycloak/keycloak/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keycloak/keycloak/teams","hooks_url":"https://api.github.com/repos/keycloak/keycloak/hooks","issue_events_url":"https://api.github.com/repos/keycloak/keycloak/issues/events{/number}","events_url":"https://api.github.com/repos/keycloak/keycloak/events","assignees_url":"https://api.github.com/repos/keycloak/keycloak/assignees{/user}","branches_url":"https://api.github.com/repos/keycloak/keycloak/branches{/branch}","tags_url":"https://api.github.com/repos/keycloak/keycloak/tags","blobs_url":"https://api.github.com/repos/keycloak/keycloak/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keycloak/keycloak/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keycloak/keycloak/git/refs{/sha}","trees_url":"https://api.github.com/repos/keycloak/keycloak/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keycloak/keycloak/statuses/{sha}","languages_url":"https://api.github.com/repos/keycloak/keycloak/languages","stargazers_url":"https://api.github.com/repos/keycloak/keycloak/stargazers","contributors_url":"https://api.github.com/repos/keycloak/keycloak/contributors","subscribers_url":"https://api.github.com/repos/keycloak/keycloak/subscribers","subscription_url":"https://api.github.com/repos/keycloak/keycloak/subscription","commits_url":"https://api.github.com/repos/keycloak/keycloak/commits{/sha}","git_commits_url":"https://api.github.com/repos/keycloak/keycloak/git/commits{/sha}","comments_url":"https://api.github.com/repos/keycloak/keycloak/comments{/number}","issue_comment_url":"https://api.github.com/repos/keycloak/keycloak/issues/comments{/number}","contents_url":"https://api.github.com/repos/keycloak/keycloak/contents/{+path}","compare_url":"https://api.github.com/repos/keycloak/keycloak/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keycloak/keycloak/merges","archive_url":"https://api.github.com/repos/keycloak/keycloak/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keycloak/keycloak/downloads","issues_url":"https://api.github.com/repos/keycloak/keycloak/issues{/number}","pulls_url":"https://api.github.com/repos/keycloak/keycloak/pulls{/number}","milestones_url":"https://api.github.com/repos/keycloak/keycloak/milestones{/number}","notifications_url":"https://api.github.com/repos/keycloak/keycloak/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keycloak/keycloak/labels{/name}","releases_url":"https://api.github.com/repos/keycloak/keycloak/releases{/id}","deployments_url":"https://api.github.com/repos/keycloak/keycloak/deployments","created_at":"2013-07-02T13:38:51Z","updated_at":"2019-01-03T13:33:07Z","pushed_at":"2019-01-03T13:32:58Z","git_url":"git://github.com/keycloak/keycloak.git","ssh_url":"git@github.com:keycloak/keycloak.git","clone_url":"https://github.com/keycloak/keycloak.git","svn_url":"https://github.com/keycloak/keycloak","homepage":"http://www.keycloak.org","size":130010,"stargazers_count":3156,"watchers_count":3156,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1677,"mirror_url":null,"archived":false,"open_issues_count":51,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1677,"open_issues":51,"watchers":3156,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/keycloak/keycloak/pulls/5830"},"html":{"href":"https://github.com/keycloak/keycloak/pull/5830"},"issue":{"href":"https://api.github.com/repos/keycloak/keycloak/issues/5830"},"comments":{"href":"https://api.github.com/repos/keycloak/keycloak/issues/5830/comments"},"review_comments":{"href":"https://api.github.com/repos/keycloak/keycloak/pulls/5830/comments"},"review_comment":{"href":"https://api.github.com/repos/keycloak/keycloak/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/keycloak/keycloak/pulls/5830/commits"},"statuses":{"href":"https://api.github.com/repos/keycloak/keycloak/statuses/40fa9780d257eddad664c4733445c4d721eaca86"}},"author_association":"NONE","merged":false,"mergeable":false,"rebaseable":false,"mergeable_state":"dirty","merged_by":null,"comments":11,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":41,"deletions":6,"changed_files":1}}
{"actor":{"display_login":"stianst"}}