{"action":"created","comment":{"url":"https://api.github.com/repos/google/macops-MOLXPCConnection/pulls/comments/199538694","pull_request_review_id":133675864,"id":199538694,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTUzODY5NA==","diff_hunk":"@@ -113,9 +120,14 @@\n @property(readonly, nonatomic, nullable) id remoteObjectProxy;\n \n /**\n- The interface this object exports. (server)\n+ The privileged interface this object exports. (server)\n+ */\n+@property(retain, nullable) NSXPCInterface *privilegedExportedInterface;\n+\n+/**\n+ The unprivileged interface this object exports. (server)\n  */\n-@property(retain, nullable) NSXPCInterface *exportedInterface;\n+@property(retain, nullable) NSXPCInterface *unprivilegedExportedInterface;","path":"Source/MOLXPCConnection/MOLXPCConnection.h","position":36,"original_position":36,"commit_id":"8df21f42c5ebe37854c8f40688cd565b4021497a","original_commit_id":"8df21f42c5ebe37854c8f40688cd565b4021497a","user":{"login":"russellhancox","id":69123,"node_id":"MDQ6VXNlcjY5MTIz","avatar_url":"https://avatars0.githubusercontent.com/u/69123?v=4","gravatar_id":"","url":"https://api.github.com/users/russellhancox","html_url":"https://github.com/russellhancox","followers_url":"https://api.github.com/users/russellhancox/followers","following_url":"https://api.github.com/users/russellhancox/following{/other_user}","gists_url":"https://api.github.com/users/russellhancox/gists{/gist_id}","starred_url":"https://api.github.com/users/russellhancox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/russellhancox/subscriptions","organizations_url":"https://api.github.com/users/russellhancox/orgs","repos_url":"https://api.github.com/users/russellhancox/repos","events_url":"https://api.github.com/users/russellhancox/events{/privacy}","received_events_url":"https://api.github.com/users/russellhancox/received_events","type":"User","site_admin":false},"body":"This interface is nice and clean but to avoid breaking upgrading clients, I'd like to leave the exportedInterface property around for a release or two. Could you add it back and mark it as deprecated, like so:\r\n\r\n```objc\r\n/**\r\n  Old interface property, please update to use privilegedExportedInterface and/or unprivilegedExportedInterface instead.\r\n*/\r\n@property(retain, nullable) NSXPCInterface *exportedInterface __attribute__((\r\n   deprecated(Use privilegedExportedInterface and / or unprivilegedExportedInterface instead.)));\r\n```","created_at":"2018-07-02T15:38:28Z","updated_at":"2018-07-02T15:45:27Z","html_url":"https://github.com/google/macops-MOLXPCConnection/pull/4#discussion_r199538694","pull_request_url":"https://api.github.com/repos/google/macops-MOLXPCConnection/pulls/4","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/google/macops-MOLXPCConnection/pulls/comments/199538694"},"html":{"href":"https://github.com/google/macops-MOLXPCConnection/pull/4#discussion_r199538694"},"pull_request":{"href":"https://api.github.com/repos/google/macops-MOLXPCConnection/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/google/macops-MOLXPCConnection/pulls/4","id":198685777,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4Njg1Nzc3","html_url":"https://github.com/google/macops-MOLXPCConnection/pull/4","diff_url":"https://github.com/google/macops-MOLXPCConnection/pull/4.diff","patch_url":"https://github.com/google/macops-MOLXPCConnection/pull/4.patch","issue_url":"https://api.github.com/repos/google/macops-MOLXPCConnection/issues/4","number":4,"state":"open","locked":false,"title":"Add support for privileged and unprivileged connections","user":{"login":"alessandrogario","id":5714290,"node_id":"MDQ6VXNlcjU3MTQyOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/5714290?v=4","gravatar_id":"","url":"https://api.github.com/users/alessandrogario","html_url":"https://github.com/alessandrogario","followers_url":"https://api.github.com/users/alessandrogario/followers","following_url":"https://api.github.com/users/alessandrogario/following{/other_user}","gists_url":"https://api.github.com/users/alessandrogario/gists{/gist_id}","starred_url":"https://api.github.com/users/alessandrogario/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alessandrogario/subscriptions","organizations_url":"https://api.github.com/users/alessandrogario/orgs","repos_url":"https://api.github.com/users/alessandrogario/repos","events_url":"https://api.github.com/users/alessandrogario/events{/privacy}","received_events_url":"https://api.github.com/users/alessandrogario/received_events","type":"User","site_admin":false},"body":"This PR adds support for separating the interface into privileged and unprivileged, depending on the permissions of the connecting client","created_at":"2018-07-02T13:49:11Z","updated_at":"2018-07-02T15:45:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4eb995cfd4fbed4fe638e2faf29b9eed0c97fa70","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/google/macops-MOLXPCConnection/pulls/4/commits","review_comments_url":"https://api.github.com/repos/google/macops-MOLXPCConnection/pulls/4/comments","review_comment_url":"https://api.github.com/repos/google/macops-MOLXPCConnection/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/macops-MOLXPCConnection/issues/4/comments","statuses_url":"https://api.github.com/repos/google/macops-MOLXPCConnection/statuses/8df21f42c5ebe37854c8f40688cd565b4021497a","head":{"label":"trailofbits:alessandro/feature/unprivileged-connections","ref":"alessandro/feature/unprivileged-connections","sha":"8df21f42c5ebe37854c8f40688cd565b4021497a","user":{"login":"trailofbits","id":2314423,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMTQ0MjM=","avatar_url":"https://avatars0.githubusercontent.com/u/2314423?v=4","gravatar_id":"","url":"https://api.github.com/users/trailofbits","html_url":"https://github.com/trailofbits","followers_url":"https://api.github.com/users/trailofbits/followers","following_url":"https://api.github.com/users/trailofbits/following{/other_user}","gists_url":"https://api.github.com/users/trailofbits/gists{/gist_id}","starred_url":"https://api.github.com/users/trailofbits/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trailofbits/subscriptions","organizations_url":"https://api.github.com/users/trailofbits/orgs","repos_url":"https://api.github.com/users/trailofbits/repos","events_url":"https://api.github.com/users/trailofbits/events{/privacy}","received_events_url":"https://api.github.com/users/trailofbits/received_events","type":"Organization","site_admin":false},"repo":{"id":139449411,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk0NDk0MTE=","name":"macops-MOLXPCConnection","full_name":"trailofbits/macops-MOLXPCConnection","owner":{"login":"trailofbits","id":2314423,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMTQ0MjM=","avatar_url":"https://avatars0.githubusercontent.com/u/2314423?v=4","gravatar_id":"","url":"https://api.github.com/users/trailofbits","html_url":"https://github.com/trailofbits","followers_url":"https://api.github.com/users/trailofbits/followers","following_url":"https://api.github.com/users/trailofbits/following{/other_user}","gists_url":"https://api.github.com/users/trailofbits/gists{/gist_id}","starred_url":"https://api.github.com/users/trailofbits/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trailofbits/subscriptions","organizations_url":"https://api.github.com/users/trailofbits/orgs","repos_url":"https://api.github.com/users/trailofbits/repos","events_url":"https://api.github.com/users/trailofbits/events{/privacy}","received_events_url":"https://api.github.com/users/trailofbits/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/trailofbits/macops-MOLXPCConnection","description":"An NSXPCConnection wrapper that does signature validation","fork":true,"url":"https://api.github.com/repos/trailofbits/macops-MOLXPCConnection","forks_url":"https://api.github.com/repos/trailofbits/macops-MOLXPCConnection/forks","keys_url":"https://api.github.com/repos/trailofbits/macops-MOLXPCConnection/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trailofbits/macops-MOLXPCConnection/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trailofbits/macops-MOLXPCConnection/teams","hooks_url":"https://api.github.com/repos/trailofbits/macops-MOLXPCConnection/hooks","issue_events_url":"https://api.github.com/repos/trailofbits/macops-MOLXPCConnection/issues/events{/number}","events_url":"https://api.github.com/repos/trailofbits/macops-MOLXPCConnection/events","assignees_url":"https://api.github.com/repos/trailofbits/macops-MOLXPCConnection/assignees{/user}","branches_url":"https://api.github.com/repos/trailofbits/macops-MOLXPCConnection/branches{/branch}","tags_url":"https://api.github.com/repos/trailofbits/macops-MOLXPCConnection/tags","blobs_url":"https://api.github.com/repos/trailofbits/macops-MOLXPCConnection/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trailofbits/macops-MOLXPCConnection/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trailofbits/macops-MOLXPCConnection/git/refs{/sha}","trees_url":"https://api.github.com/repos/trailofbits/macops-MOLXPCConnection/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trailofbits/macops-MOLXPCConnection/statuses/{sha}","languages_url":"https://api.github.com/repos/trailofbits/macops-MOLXPCConnection/languages","stargazers_url":"https://api.github.com/repos/trailofbits/macops-MOLXPCConnection/stargazers","contributors_url":"https://api.github.com/repos/trailofbits/macops-MOLXPCConnection/contributors","subscribers_url":"https://api.github.com/repos/trailofbits/macops-MOLXPCConnection/subscribers","subscription_url":"https://api.github.com/repos/trailofbits/macops-MOLXPCConnection/subscription","commits_url":"https://api.github.com/repos/trailofbits/macops-MOLXPCConnection/commits{/sha}","git_commits_url":"https://api.github.com/repos/trailofbits/macops-MOLXPCConnection/git/commits{/sha}","comments_url":"https://api.github.com/repos/trailofbits/macops-MOLXPCConnection/comments{/number}","issue_comment_url":"https://api.github.com/repos/trailofbits/macops-MOLXPCConnection/issues/comments{/number}","contents_url":"https://api.github.com/repos/trailofbits/macops-MOLXPCConnection/contents/{+path}","compare_url":"https://api.github.com/repos/trailofbits/macops-MOLXPCConnection/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trailofbits/macops-MOLXPCConnection/merges","archive_url":"https://api.github.com/repos/trailofbits/macops-MOLXPCConnection/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trailofbits/macops-MOLXPCConnection/downloads","issues_url":"https://api.github.com/repos/trailofbits/macops-MOLXPCConnection/issues{/number}","pulls_url":"https://api.github.com/repos/trailofbits/macops-MOLXPCConnection/pulls{/number}","milestones_url":"https://api.github.com/repos/trailofbits/macops-MOLXPCConnection/milestones{/number}","notifications_url":"https://api.github.com/repos/trailofbits/macops-MOLXPCConnection/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trailofbits/macops-MOLXPCConnection/labels{/name}","releases_url":"https://api.github.com/repos/trailofbits/macops-MOLXPCConnection/releases{/id}","deployments_url":"https://api.github.com/repos/trailofbits/macops-MOLXPCConnection/deployments","created_at":"2018-07-02T13:44:32Z","updated_at":"2018-07-02T13:44:34Z","pushed_at":"2018-07-02T13:47:17Z","git_url":"git://github.com/trailofbits/macops-MOLXPCConnection.git","ssh_url":"git@github.com:trailofbits/macops-MOLXPCConnection.git","clone_url":"https://github.com/trailofbits/macops-MOLXPCConnection.git","svn_url":"https://github.com/trailofbits/macops-MOLXPCConnection","homepage":"","size":21,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"d6e43bd9a81d5e3b64da7992581fe26eaca0bcd2","user":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":105059052,"node_id":"MDEwOlJlcG9zaXRvcnkxMDUwNTkwNTI=","name":"macops-MOLXPCConnection","full_name":"google/macops-MOLXPCConnection","owner":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/macops-MOLXPCConnection","description":"An NSXPCConnection wrapper that does signature validation","fork":false,"url":"https://api.github.com/repos/google/macops-MOLXPCConnection","forks_url":"https://api.github.com/repos/google/macops-MOLXPCConnection/forks","keys_url":"https://api.github.com/repos/google/macops-MOLXPCConnection/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/macops-MOLXPCConnection/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/macops-MOLXPCConnection/teams","hooks_url":"https://api.github.com/repos/google/macops-MOLXPCConnection/hooks","issue_events_url":"https://api.github.com/repos/google/macops-MOLXPCConnection/issues/events{/number}","events_url":"https://api.github.com/repos/google/macops-MOLXPCConnection/events","assignees_url":"https://api.github.com/repos/google/macops-MOLXPCConnection/assignees{/user}","branches_url":"https://api.github.com/repos/google/macops-MOLXPCConnection/branches{/branch}","tags_url":"https://api.github.com/repos/google/macops-MOLXPCConnection/tags","blobs_url":"https://api.github.com/repos/google/macops-MOLXPCConnection/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/macops-MOLXPCConnection/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/macops-MOLXPCConnection/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/macops-MOLXPCConnection/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/macops-MOLXPCConnection/statuses/{sha}","languages_url":"https://api.github.com/repos/google/macops-MOLXPCConnection/languages","stargazers_url":"https://api.github.com/repos/google/macops-MOLXPCConnection/stargazers","contributors_url":"https://api.github.com/repos/google/macops-MOLXPCConnection/contributors","subscribers_url":"https://api.github.com/repos/google/macops-MOLXPCConnection/subscribers","subscription_url":"https://api.github.com/repos/google/macops-MOLXPCConnection/subscription","commits_url":"https://api.github.com/repos/google/macops-MOLXPCConnection/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/macops-MOLXPCConnection/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/macops-MOLXPCConnection/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/macops-MOLXPCConnection/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/macops-MOLXPCConnection/contents/{+path}","compare_url":"https://api.github.com/repos/google/macops-MOLXPCConnection/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/macops-MOLXPCConnection/merges","archive_url":"https://api.github.com/repos/google/macops-MOLXPCConnection/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/macops-MOLXPCConnection/downloads","issues_url":"https://api.github.com/repos/google/macops-MOLXPCConnection/issues{/number}","pulls_url":"https://api.github.com/repos/google/macops-MOLXPCConnection/pulls{/number}","milestones_url":"https://api.github.com/repos/google/macops-MOLXPCConnection/milestones{/number}","notifications_url":"https://api.github.com/repos/google/macops-MOLXPCConnection/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/macops-MOLXPCConnection/labels{/name}","releases_url":"https://api.github.com/repos/google/macops-MOLXPCConnection/releases{/id}","deployments_url":"https://api.github.com/repos/google/macops-MOLXPCConnection/deployments","created_at":"2017-09-27T19:13:43Z","updated_at":"2018-05-17T20:26:06Z","pushed_at":"2018-07-02T13:49:12Z","git_url":"git://github.com/google/macops-MOLXPCConnection.git","ssh_url":"git@github.com:google/macops-MOLXPCConnection.git","clone_url":"https://github.com/google/macops-MOLXPCConnection.git","svn_url":"https://github.com/google/macops-MOLXPCConnection","homepage":"","size":20,"stargazers_count":2,"watchers_count":2,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":4,"open_issues":2,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/macops-MOLXPCConnection/pulls/4"},"html":{"href":"https://github.com/google/macops-MOLXPCConnection/pull/4"},"issue":{"href":"https://api.github.com/repos/google/macops-MOLXPCConnection/issues/4"},"comments":{"href":"https://api.github.com/repos/google/macops-MOLXPCConnection/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/google/macops-MOLXPCConnection/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/google/macops-MOLXPCConnection/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/macops-MOLXPCConnection/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/google/macops-MOLXPCConnection/statuses/8df21f42c5ebe37854c8f40688cd565b4021497a"}},"author_association":"NONE"}}
{"actor":{"display_login":"russellhancox"}}