{"action":"created","issue":{"url":"https://api.github.com/repos/jcabi/jcabi-ssh/issues/73","repository_url":"https://api.github.com/repos/jcabi/jcabi-ssh","labels_url":"https://api.github.com/repos/jcabi/jcabi-ssh/issues/73/labels{/name}","comments_url":"https://api.github.com/repos/jcabi/jcabi-ssh/issues/73/comments","events_url":"https://api.github.com/repos/jcabi/jcabi-ssh/issues/73/events","html_url":"https://github.com/jcabi/jcabi-ssh/issues/73","id":332607334,"node_id":"MDU6SXNzdWUzMzI2MDczMzQ=","number":73,"title":"security is broken when temporary private key file won't get deleted if exception thrown","user":{"login":"jimengliu","id":17127678,"node_id":"MDQ6VXNlcjE3MTI3Njc4","avatar_url":"https://avatars2.githubusercontent.com/u/17127678?v=4","gravatar_id":"","url":"https://api.github.com/users/jimengliu","html_url":"https://github.com/jimengliu","followers_url":"https://api.github.com/users/jimengliu/followers","following_url":"https://api.github.com/users/jimengliu/following{/other_user}","gists_url":"https://api.github.com/users/jimengliu/gists{/gist_id}","starred_url":"https://api.github.com/users/jimengliu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimengliu/subscriptions","organizations_url":"https://api.github.com/users/jimengliu/orgs","repos_url":"https://api.github.com/users/jimengliu/repos","events_url":"https://api.github.com/users/jimengliu/events{/privacy}","received_events_url":"https://api.github.com/users/jimengliu/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-06-15T00:24:36Z","updated_at":"2018-06-15T04:31:07Z","closed_at":null,"author_association":"NONE","body":"After using jcabi-ssh for a while, I noticed a lot of private key files inside /tmp folder. This poses significant security issues.\r\n\r\nThe problem is in session() function (in file src/main/java/com/jcabi/ssh/Ssh.java). The temporary private key file was constructed first, but it won't get deleted when there is exception thrown. Because the line to delete the file \r\n\r\nFiles.deleteIfExists(file.toPath());\r\n\r\nis within try{} block, not in finally{} block.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/jcabi/jcabi-ssh/issues/comments/397510339","html_url":"https://github.com/jcabi/jcabi-ssh/issues/73#issuecomment-397510339","issue_url":"https://api.github.com/repos/jcabi/jcabi-ssh/issues/73","id":397510339,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NzUxMDMzOQ==","user":{"login":"rultor","id":8086956,"node_id":"MDQ6VXNlcjgwODY5NTY=","avatar_url":"https://avatars1.githubusercontent.com/u/8086956?v=4","gravatar_id":"","url":"https://api.github.com/users/rultor","html_url":"https://github.com/rultor","followers_url":"https://api.github.com/users/rultor/followers","following_url":"https://api.github.com/users/rultor/following{/other_user}","gists_url":"https://api.github.com/users/rultor/gists{/gist_id}","starred_url":"https://api.github.com/users/rultor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rultor/subscriptions","organizations_url":"https://api.github.com/users/rultor/orgs","repos_url":"https://api.github.com/users/rultor/repos","events_url":"https://api.github.com/users/rultor/events{/privacy}","received_events_url":"https://api.github.com/users/rultor/received_events","type":"User","site_admin":false},"created_at":"2018-06-15T04:31:06Z","updated_at":"2018-06-15T04:31:06Z","author_association":"CONTRIBUTOR","body":"> @rultor release, tag is `1.6.1`\n\n@yegor256 OK, I will release it now. Please check the progress [here](http://www.rultor.com/t/14931-397510076)"}}
{"actor":{"display_login":"rultor"}}