{"action":"created","comment":{"url":"https://api.github.com/repos/symfony/maker-bundle/pulls/comments/227581533","pull_request_review_id":167657090,"id":227581533,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNzU4MTUzMw==","diff_hunk":"@@ -0,0 +1,73 @@\n+<?php\n+\n+/*\n+ * This file is part of the Symfony MakerBundle package.\n+ *\n+ * (c) Fabien Potencier <fabien@symfony.com>\n+ *\n+ * For the full copyright and license information, please view the LICENSE\n+ * file that was distributed with this source code.\n+ */\n+\n+namespace Symfony\\Bundle\\MakerBundle\\Maker;\n+\n+use Symfony\\Bundle\\MakerBundle\\ConsoleStyle;\n+use Symfony\\Bundle\\MakerBundle\\DependencyBuilder;\n+use Symfony\\Bundle\\MakerBundle\\Generator;\n+use Symfony\\Bundle\\MakerBundle\\InputConfiguration;\n+use Symfony\\Component\\Console\\Command\\Command;\n+use Symfony\\Component\\Console\\Input\\InputArgument;\n+use Symfony\\Component\\Console\\Input\\InputInterface;\n+use Symfony\\Component\\Serializer\\Serializer;\n+\n+/**\n+ * @author Grégoire Pineau <lyrixx@lyrixx.info>\n+ */\n+final class MakeSerializerNormalizer extends AbstractMaker\n+{\n+    public static function getCommandName(): string\n+    {\n+        return 'make:serializer:normalizer';\n+    }\n+\n+    public function configureCommand(Command $command, InputConfiguration $inputConf)\n+    {\n+        $command\n+            ->setDescription('Creates a new serializer normalizer class')\n+            ->addArgument('name', InputArgument::OPTIONAL, 'Choose a class name for your normalizer (e.g. <fg=yellow>UserNormalizer</>)')\n+            ->setHelp(file_get_contents(__DIR__.'/../Resources/help/MakeSerializerNormalizer.txt'))\n+        ;\n+    }\n+\n+    public function generate(InputInterface $input, ConsoleStyle $io, Generator $generator)\n+    {\n+        $normalizerClassNameDetails = $generator->createClassNameDetails(\n+            $input->getArgument('name'),\n+            'Serializer\\\\Normalizer\\\\',\n+            'Normalizer'\n+        );","path":"src/Maker/MakeSerializerNormalizer.php","position":48,"original_position":48,"commit_id":"193c9b3a47c892f511fc7a1b238d91e98049ae87","original_commit_id":"193c9b3a47c892f511fc7a1b238d91e98049ae87","user":{"login":"lyrixx","id":408368,"node_id":"MDQ6VXNlcjQwODM2OA==","avatar_url":"https://avatars1.githubusercontent.com/u/408368?v=4","gravatar_id":"","url":"https://api.github.com/users/lyrixx","html_url":"https://github.com/lyrixx","followers_url":"https://api.github.com/users/lyrixx/followers","following_url":"https://api.github.com/users/lyrixx/following{/other_user}","gists_url":"https://api.github.com/users/lyrixx/gists{/gist_id}","starred_url":"https://api.github.com/users/lyrixx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyrixx/subscriptions","organizations_url":"https://api.github.com/users/lyrixx/orgs","repos_url":"https://api.github.com/users/lyrixx/repos","events_url":"https://api.github.com/users/lyrixx/events{/privacy}","received_events_url":"https://api.github.com/users/lyrixx/received_events","type":"User","site_admin":false},"body":"I know and I don't like it.\r\nI have the same opinion about form type.\r\n\r\nIt really prefer to use a sub namespace to keep things clean. \r\n\r\nI usually have between 0 to 10 normalizers and sometimes 1 encoder. \r\n\r\nBtw voters are put in a sub namespace too. \r\n\r\nIt's just an extra directory...","created_at":"2018-10-23T22:02:37Z","updated_at":"2018-10-23T22:02:37Z","html_url":"https://github.com/symfony/maker-bundle/pull/298#discussion_r227581533","pull_request_url":"https://api.github.com/repos/symfony/maker-bundle/pulls/298","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/symfony/maker-bundle/pulls/comments/227581533"},"html":{"href":"https://github.com/symfony/maker-bundle/pull/298#discussion_r227581533"},"pull_request":{"href":"https://api.github.com/repos/symfony/maker-bundle/pulls/298"}},"in_reply_to_id":227515041},"pull_request":{"url":"https://api.github.com/repos/symfony/maker-bundle/pulls/298","id":224343829,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0MzQzODI5","html_url":"https://github.com/symfony/maker-bundle/pull/298","diff_url":"https://github.com/symfony/maker-bundle/pull/298.diff","patch_url":"https://github.com/symfony/maker-bundle/pull/298.patch","issue_url":"https://api.github.com/repos/symfony/maker-bundle/issues/298","number":298,"state":"open","locked":false,"title":"[Serializer] Add a 'make:serializer:normalizer' command","user":{"login":"lyrixx","id":408368,"node_id":"MDQ6VXNlcjQwODM2OA==","avatar_url":"https://avatars1.githubusercontent.com/u/408368?v=4","gravatar_id":"","url":"https://api.github.com/users/lyrixx","html_url":"https://github.com/lyrixx","followers_url":"https://api.github.com/users/lyrixx/followers","following_url":"https://api.github.com/users/lyrixx/following{/other_user}","gists_url":"https://api.github.com/users/lyrixx/gists{/gist_id}","starred_url":"https://api.github.com/users/lyrixx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyrixx/subscriptions","organizations_url":"https://api.github.com/users/lyrixx/orgs","repos_url":"https://api.github.com/users/lyrixx/repos","events_url":"https://api.github.com/users/lyrixx/events{/privacy}","received_events_url":"https://api.github.com/users/lyrixx/received_events","type":"User","site_admin":false},"body":"fixes #287","created_at":"2018-10-19T16:30:20Z","updated_at":"2018-10-23T22:02:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"57185daee0b2c16487b136c5ef2405afab628d07","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/symfony/maker-bundle/pulls/298/commits","review_comments_url":"https://api.github.com/repos/symfony/maker-bundle/pulls/298/comments","review_comment_url":"https://api.github.com/repos/symfony/maker-bundle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/maker-bundle/issues/298/comments","statuses_url":"https://api.github.com/repos/symfony/maker-bundle/statuses/193c9b3a47c892f511fc7a1b238d91e98049ae87","head":{"label":"lyrixx:serializer-normalizer","ref":"serializer-normalizer","sha":"193c9b3a47c892f511fc7a1b238d91e98049ae87","user":{"login":"lyrixx","id":408368,"node_id":"MDQ6VXNlcjQwODM2OA==","avatar_url":"https://avatars1.githubusercontent.com/u/408368?v=4","gravatar_id":"","url":"https://api.github.com/users/lyrixx","html_url":"https://github.com/lyrixx","followers_url":"https://api.github.com/users/lyrixx/followers","following_url":"https://api.github.com/users/lyrixx/following{/other_user}","gists_url":"https://api.github.com/users/lyrixx/gists{/gist_id}","starred_url":"https://api.github.com/users/lyrixx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyrixx/subscriptions","organizations_url":"https://api.github.com/users/lyrixx/orgs","repos_url":"https://api.github.com/users/lyrixx/repos","events_url":"https://api.github.com/users/lyrixx/events{/privacy}","received_events_url":"https://api.github.com/users/lyrixx/received_events","type":"User","site_admin":false},"repo":{"id":111548709,"node_id":"MDEwOlJlcG9zaXRvcnkxMTE1NDg3MDk=","name":"maker-bundle","full_name":"lyrixx/maker-bundle","private":false,"owner":{"login":"lyrixx","id":408368,"node_id":"MDQ6VXNlcjQwODM2OA==","avatar_url":"https://avatars1.githubusercontent.com/u/408368?v=4","gravatar_id":"","url":"https://api.github.com/users/lyrixx","html_url":"https://github.com/lyrixx","followers_url":"https://api.github.com/users/lyrixx/followers","following_url":"https://api.github.com/users/lyrixx/following{/other_user}","gists_url":"https://api.github.com/users/lyrixx/gists{/gist_id}","starred_url":"https://api.github.com/users/lyrixx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyrixx/subscriptions","organizations_url":"https://api.github.com/users/lyrixx/orgs","repos_url":"https://api.github.com/users/lyrixx/repos","events_url":"https://api.github.com/users/lyrixx/events{/privacy}","received_events_url":"https://api.github.com/users/lyrixx/received_events","type":"User","site_admin":false},"html_url":"https://github.com/lyrixx/maker-bundle","description":"Symfony Maker Bundle","fork":true,"url":"https://api.github.com/repos/lyrixx/maker-bundle","forks_url":"https://api.github.com/repos/lyrixx/maker-bundle/forks","keys_url":"https://api.github.com/repos/lyrixx/maker-bundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lyrixx/maker-bundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lyrixx/maker-bundle/teams","hooks_url":"https://api.github.com/repos/lyrixx/maker-bundle/hooks","issue_events_url":"https://api.github.com/repos/lyrixx/maker-bundle/issues/events{/number}","events_url":"https://api.github.com/repos/lyrixx/maker-bundle/events","assignees_url":"https://api.github.com/repos/lyrixx/maker-bundle/assignees{/user}","branches_url":"https://api.github.com/repos/lyrixx/maker-bundle/branches{/branch}","tags_url":"https://api.github.com/repos/lyrixx/maker-bundle/tags","blobs_url":"https://api.github.com/repos/lyrixx/maker-bundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lyrixx/maker-bundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lyrixx/maker-bundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/lyrixx/maker-bundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lyrixx/maker-bundle/statuses/{sha}","languages_url":"https://api.github.com/repos/lyrixx/maker-bundle/languages","stargazers_url":"https://api.github.com/repos/lyrixx/maker-bundle/stargazers","contributors_url":"https://api.github.com/repos/lyrixx/maker-bundle/contributors","subscribers_url":"https://api.github.com/repos/lyrixx/maker-bundle/subscribers","subscription_url":"https://api.github.com/repos/lyrixx/maker-bundle/subscription","commits_url":"https://api.github.com/repos/lyrixx/maker-bundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/lyrixx/maker-bundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/lyrixx/maker-bundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/lyrixx/maker-bundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/lyrixx/maker-bundle/contents/{+path}","compare_url":"https://api.github.com/repos/lyrixx/maker-bundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lyrixx/maker-bundle/merges","archive_url":"https://api.github.com/repos/lyrixx/maker-bundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lyrixx/maker-bundle/downloads","issues_url":"https://api.github.com/repos/lyrixx/maker-bundle/issues{/number}","pulls_url":"https://api.github.com/repos/lyrixx/maker-bundle/pulls{/number}","milestones_url":"https://api.github.com/repos/lyrixx/maker-bundle/milestones{/number}","notifications_url":"https://api.github.com/repos/lyrixx/maker-bundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lyrixx/maker-bundle/labels{/name}","releases_url":"https://api.github.com/repos/lyrixx/maker-bundle/releases{/id}","deployments_url":"https://api.github.com/repos/lyrixx/maker-bundle/deployments","created_at":"2017-11-21T12:53:40Z","updated_at":"2017-11-21T12:53:42Z","pushed_at":"2018-10-19T16:29:40Z","git_url":"git://github.com/lyrixx/maker-bundle.git","ssh_url":"git@github.com:lyrixx/maker-bundle.git","clone_url":"https://github.com/lyrixx/maker-bundle.git","svn_url":"https://github.com/lyrixx/maker-bundle","homepage":"https://symfony.com/","size":756,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"symfony:master","ref":"master","sha":"26643943fe19b5b47d620744907f09d1d6b3f06f","user":{"login":"symfony","id":143937,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MzkzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/143937?v=4","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":109984157,"node_id":"MDEwOlJlcG9zaXRvcnkxMDk5ODQxNTc=","name":"maker-bundle","full_name":"symfony/maker-bundle","private":false,"owner":{"login":"symfony","id":143937,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MzkzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/143937?v=4","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/symfony/maker-bundle","description":"Symfony Maker Bundle","fork":false,"url":"https://api.github.com/repos/symfony/maker-bundle","forks_url":"https://api.github.com/repos/symfony/maker-bundle/forks","keys_url":"https://api.github.com/repos/symfony/maker-bundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/maker-bundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/maker-bundle/teams","hooks_url":"https://api.github.com/repos/symfony/maker-bundle/hooks","issue_events_url":"https://api.github.com/repos/symfony/maker-bundle/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/maker-bundle/events","assignees_url":"https://api.github.com/repos/symfony/maker-bundle/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/maker-bundle/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/maker-bundle/tags","blobs_url":"https://api.github.com/repos/symfony/maker-bundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/maker-bundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/maker-bundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/maker-bundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/maker-bundle/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/maker-bundle/languages","stargazers_url":"https://api.github.com/repos/symfony/maker-bundle/stargazers","contributors_url":"https://api.github.com/repos/symfony/maker-bundle/contributors","subscribers_url":"https://api.github.com/repos/symfony/maker-bundle/subscribers","subscription_url":"https://api.github.com/repos/symfony/maker-bundle/subscription","commits_url":"https://api.github.com/repos/symfony/maker-bundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/maker-bundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/maker-bundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/maker-bundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/maker-bundle/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/maker-bundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/maker-bundle/merges","archive_url":"https://api.github.com/repos/symfony/maker-bundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/maker-bundle/downloads","issues_url":"https://api.github.com/repos/symfony/maker-bundle/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/maker-bundle/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/maker-bundle/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/maker-bundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/maker-bundle/labels{/name}","releases_url":"https://api.github.com/repos/symfony/maker-bundle/releases{/id}","deployments_url":"https://api.github.com/repos/symfony/maker-bundle/deployments","created_at":"2017-11-08T14:10:03Z","updated_at":"2018-10-23T20:19:28Z","pushed_at":"2018-10-23T21:55:59Z","git_url":"git://github.com/symfony/maker-bundle.git","ssh_url":"git@github.com:symfony/maker-bundle.git","clone_url":"https://github.com/symfony/maker-bundle.git","svn_url":"https://github.com/symfony/maker-bundle","homepage":"https://symfony.com/","size":805,"stargazers_count":1238,"watchers_count":1238,"language":"PHP","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":91,"mirror_url":null,"archived":false,"open_issues_count":67,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":91,"open_issues":67,"watchers":1238,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/maker-bundle/pulls/298"},"html":{"href":"https://github.com/symfony/maker-bundle/pull/298"},"issue":{"href":"https://api.github.com/repos/symfony/maker-bundle/issues/298"},"comments":{"href":"https://api.github.com/repos/symfony/maker-bundle/issues/298/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/maker-bundle/pulls/298/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/maker-bundle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/maker-bundle/pulls/298/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/maker-bundle/statuses/193c9b3a47c892f511fc7a1b238d91e98049ae87"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"lyrixx"}}