{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/23692","repository_url":"https://api.github.com/repos/cockroachdb/cockroach","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/23692/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/23692/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/23692/events","html_url":"https://github.com/cockroachdb/cockroach/pull/23692","id":304005095,"number":23692,"title":"sql: don't reuse planner in QueryRow","user":{"login":"jordanlewis","id":43821,"avatar_url":"https://avatars1.githubusercontent.com/u/43821?v=4","gravatar_id":"","url":"https://api.github.com/users/jordanlewis","html_url":"https://github.com/jordanlewis","followers_url":"https://api.github.com/users/jordanlewis/followers","following_url":"https://api.github.com/users/jordanlewis/following{/other_user}","gists_url":"https://api.github.com/users/jordanlewis/gists{/gist_id}","starred_url":"https://api.github.com/users/jordanlewis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jordanlewis/subscriptions","organizations_url":"https://api.github.com/users/jordanlewis/orgs","repos_url":"https://api.github.com/users/jordanlewis/repos","events_url":"https://api.github.com/users/jordanlewis/events{/privacy}","received_events_url":"https://api.github.com/users/jordanlewis/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2018-03-09T22:48:29Z","updated_at":"2018-03-19T16:39:31Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/23692","html_url":"https://github.com/cockroachdb/cockroach/pull/23692","diff_url":"https://github.com/cockroachdb/cockroach/pull/23692.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/23692.patch"},"body":"Previously, EvalPlanner.QueryRow would try to reuse its input planner.\r\nThis is a horrible idea, as planners are single-use and reusing one will\r\nbreak it.\r\n\r\nFixes #23652.\r\n\r\nRelease note: None"},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/374279095","html_url":"https://github.com/cockroachdb/cockroach/pull/23692#issuecomment-374279095","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/23692","id":374279095,"user":{"login":"jordanlewis","id":43821,"avatar_url":"https://avatars1.githubusercontent.com/u/43821?v=4","gravatar_id":"","url":"https://api.github.com/users/jordanlewis","html_url":"https://github.com/jordanlewis","followers_url":"https://api.github.com/users/jordanlewis/followers","following_url":"https://api.github.com/users/jordanlewis/following{/other_user}","gists_url":"https://api.github.com/users/jordanlewis/gists{/gist_id}","starred_url":"https://api.github.com/users/jordanlewis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jordanlewis/subscriptions","organizations_url":"https://api.github.com/users/jordanlewis/orgs","repos_url":"https://api.github.com/users/jordanlewis/repos","events_url":"https://api.github.com/users/jordanlewis/events{/privacy}","received_events_url":"https://api.github.com/users/jordanlewis/received_events","type":"User","site_admin":false},"created_at":"2018-03-19T16:39:31Z","updated_at":"2018-03-19T16:39:31Z","author_association":"OWNER","body":"\n\n\n\nReview status: 5 of 7 files reviewed at latest revision, 1 unresolved discussion, some commit checks pending.\n\n---\n\n*[pkg/sql/planner.go, line 406 at r1](https://beta.reviewable.io/reviews/cockroachdb/cockroach/23692#-L7eVqwPeyfLuYrYjfQu:-L7yyZmw0B62C5dxqd5D:buc0p2h) ([raw file](https://github.com/cockroachdb/cockroach/blob/e6b6327773358e49ad90830ed0606a98f62087e8/pkg/sql/planner.go#L406)):*\n<details><summary><i>Previously, andreimatei (Andrei Matei) wrote…</i></summary><blockquote>\n\nwell, so then this anti-clobbering code doesn't matter and can go away, right?\n</blockquote></details>\n\nIt does matter. I'm going to investigate this after this PR is merged.\n\n---\n\n\n*Comments from [Reviewable](https://beta.reviewable.io/reviews/cockroachdb/cockroach/23692)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"jordanlewis"}}