{"action":"created","comment":{"url":"https://api.github.com/repos/radare/radare2/pulls/comments/201903303","pull_request_review_id":136495634,"id":201903303,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTkwMzMwMw==","diff_hunk":"@@ -413,21 +419,39 @@ R_API void r_core_anal_type_match(RCore *core, RAnalFunction *fcn) {\n \t\t\t\t\tvar_retype (anal, var, NULL, \"signed\", addr, false, true);\n \t\t\t\t}\n \t\t\t\t// lea rax , str.hello ; mov [local_ch], rax;\n-\t\t\t\tif (str_flag && (type == R_ANAL_OP_TYPE_MOV)) {\n-\t\t\t\t\tconst char *q = sdb_fmt (\"%d.reg.read\", cur_idx);\n-\t\t\t\t\tif (sdb_array_contains (trace, q, prev_dest, 0)) {\n-\t\t\t\t\t\tvar_retype (anal, var, NULL, \"const char *\", addr, false, true);\n+\t\t\t\tif (prop && (type == R_ANAL_OP_TYPE_MOV)) {\n+\t\t\t\t\tchar *vtype = str_flag ? \"const char *\": prev_type;\n+\t\t\t\t\tchar reg[10] = {0};","path":"libr/core/anal_tp.c","position":172,"original_position":172,"commit_id":"59403461f567ba66bdf2e7513b8cb1153ff68410","original_commit_id":"59403461f567ba66bdf2e7513b8cb1153ff68410","user":{"login":"XVilka","id":203261,"node_id":"MDQ6VXNlcjIwMzI2MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/203261?v=4","gravatar_id":"","url":"https://api.github.com/users/XVilka","html_url":"https://github.com/XVilka","followers_url":"https://api.github.com/users/XVilka/followers","following_url":"https://api.github.com/users/XVilka/following{/other_user}","gists_url":"https://api.github.com/users/XVilka/gists{/gist_id}","starred_url":"https://api.github.com/users/XVilka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/XVilka/subscriptions","organizations_url":"https://api.github.com/users/XVilka/orgs","repos_url":"https://api.github.com/users/XVilka/repos","events_url":"https://api.github.com/users/XVilka/events{/privacy}","received_events_url":"https://api.github.com/users/XVilka/received_events","type":"User","site_admin":false},"body":"and here","created_at":"2018-07-12T03:58:57Z","updated_at":"2018-07-12T03:58:57Z","html_url":"https://github.com/radare/radare2/pull/10705#discussion_r201903303","pull_request_url":"https://api.github.com/repos/radare/radare2/pulls/10705","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/radare/radare2/pulls/comments/201903303"},"html":{"href":"https://github.com/radare/radare2/pull/10705#discussion_r201903303"},"pull_request":{"href":"https://api.github.com/repos/radare/radare2/pulls/10705"}}},"pull_request":{"url":"https://api.github.com/repos/radare/radare2/pulls/10705","id":200732831,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwNzMyODMx","html_url":"https://github.com/radare/radare2/pull/10705","diff_url":"https://github.com/radare/radare2/pull/10705.diff","patch_url":"https://github.com/radare/radare2/pull/10705.patch","issue_url":"https://api.github.com/repos/radare/radare2/issues/10705","number":10705,"state":"open","locked":false,"title":"Intial work on type propgation on variable equality","user":{"login":"sivaramaaa","id":18589720,"node_id":"MDQ6VXNlcjE4NTg5NzIw","avatar_url":"https://avatars0.githubusercontent.com/u/18589720?v=4","gravatar_id":"","url":"https://api.github.com/users/sivaramaaa","html_url":"https://github.com/sivaramaaa","followers_url":"https://api.github.com/users/sivaramaaa/followers","following_url":"https://api.github.com/users/sivaramaaa/following{/other_user}","gists_url":"https://api.github.com/users/sivaramaaa/gists{/gist_id}","starred_url":"https://api.github.com/users/sivaramaaa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sivaramaaa/subscriptions","organizations_url":"https://api.github.com/users/sivaramaaa/orgs","repos_url":"https://api.github.com/users/sivaramaaa/repos","events_url":"https://api.github.com/users/sivaramaaa/events{/privacy}","received_events_url":"https://api.github.com/users/sivaramaaa/received_events","type":"User","site_admin":false},"body":"* `var1 = var2`\r\n\r\nPropagate var2 type to var1 , for now covered only basic case , Will soon cover indirect  variable assignment etc ...\r\n\r\n* Also a small fix in afta","created_at":"2018-07-11T15:05:48Z","updated_at":"2018-07-12T03:58:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"410b6891140eab5b9382e6301043397eb4db3123","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/radare/radare2/pulls/10705/commits","review_comments_url":"https://api.github.com/repos/radare/radare2/pulls/10705/comments","review_comment_url":"https://api.github.com/repos/radare/radare2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/radare/radare2/issues/10705/comments","statuses_url":"https://api.github.com/repos/radare/radare2/statuses/59403461f567ba66bdf2e7513b8cb1153ff68410","head":{"label":"sivaramaaa:patch-1","ref":"patch-1","sha":"59403461f567ba66bdf2e7513b8cb1153ff68410","user":{"login":"sivaramaaa","id":18589720,"node_id":"MDQ6VXNlcjE4NTg5NzIw","avatar_url":"https://avatars0.githubusercontent.com/u/18589720?v=4","gravatar_id":"","url":"https://api.github.com/users/sivaramaaa","html_url":"https://github.com/sivaramaaa","followers_url":"https://api.github.com/users/sivaramaaa/followers","following_url":"https://api.github.com/users/sivaramaaa/following{/other_user}","gists_url":"https://api.github.com/users/sivaramaaa/gists{/gist_id}","starred_url":"https://api.github.com/users/sivaramaaa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sivaramaaa/subscriptions","organizations_url":"https://api.github.com/users/sivaramaaa/orgs","repos_url":"https://api.github.com/users/sivaramaaa/repos","events_url":"https://api.github.com/users/sivaramaaa/events{/privacy}","received_events_url":"https://api.github.com/users/sivaramaaa/received_events","type":"User","site_admin":false},"repo":{"id":110410013,"node_id":"MDEwOlJlcG9zaXRvcnkxMTA0MTAwMTM=","name":"radare2","full_name":"sivaramaaa/radare2","owner":{"login":"sivaramaaa","id":18589720,"node_id":"MDQ6VXNlcjE4NTg5NzIw","avatar_url":"https://avatars0.githubusercontent.com/u/18589720?v=4","gravatar_id":"","url":"https://api.github.com/users/sivaramaaa","html_url":"https://github.com/sivaramaaa","followers_url":"https://api.github.com/users/sivaramaaa/followers","following_url":"https://api.github.com/users/sivaramaaa/following{/other_user}","gists_url":"https://api.github.com/users/sivaramaaa/gists{/gist_id}","starred_url":"https://api.github.com/users/sivaramaaa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sivaramaaa/subscriptions","organizations_url":"https://api.github.com/users/sivaramaaa/orgs","repos_url":"https://api.github.com/users/sivaramaaa/repos","events_url":"https://api.github.com/users/sivaramaaa/events{/privacy}","received_events_url":"https://api.github.com/users/sivaramaaa/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sivaramaaa/radare2","description":"unix-like reverse engineering framework and commandline tools","fork":true,"url":"https://api.github.com/repos/sivaramaaa/radare2","forks_url":"https://api.github.com/repos/sivaramaaa/radare2/forks","keys_url":"https://api.github.com/repos/sivaramaaa/radare2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sivaramaaa/radare2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sivaramaaa/radare2/teams","hooks_url":"https://api.github.com/repos/sivaramaaa/radare2/hooks","issue_events_url":"https://api.github.com/repos/sivaramaaa/radare2/issues/events{/number}","events_url":"https://api.github.com/repos/sivaramaaa/radare2/events","assignees_url":"https://api.github.com/repos/sivaramaaa/radare2/assignees{/user}","branches_url":"https://api.github.com/repos/sivaramaaa/radare2/branches{/branch}","tags_url":"https://api.github.com/repos/sivaramaaa/radare2/tags","blobs_url":"https://api.github.com/repos/sivaramaaa/radare2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sivaramaaa/radare2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sivaramaaa/radare2/git/refs{/sha}","trees_url":"https://api.github.com/repos/sivaramaaa/radare2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sivaramaaa/radare2/statuses/{sha}","languages_url":"https://api.github.com/repos/sivaramaaa/radare2/languages","stargazers_url":"https://api.github.com/repos/sivaramaaa/radare2/stargazers","contributors_url":"https://api.github.com/repos/sivaramaaa/radare2/contributors","subscribers_url":"https://api.github.com/repos/sivaramaaa/radare2/subscribers","subscription_url":"https://api.github.com/repos/sivaramaaa/radare2/subscription","commits_url":"https://api.github.com/repos/sivaramaaa/radare2/commits{/sha}","git_commits_url":"https://api.github.com/repos/sivaramaaa/radare2/git/commits{/sha}","comments_url":"https://api.github.com/repos/sivaramaaa/radare2/comments{/number}","issue_comment_url":"https://api.github.com/repos/sivaramaaa/radare2/issues/comments{/number}","contents_url":"https://api.github.com/repos/sivaramaaa/radare2/contents/{+path}","compare_url":"https://api.github.com/repos/sivaramaaa/radare2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sivaramaaa/radare2/merges","archive_url":"https://api.github.com/repos/sivaramaaa/radare2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sivaramaaa/radare2/downloads","issues_url":"https://api.github.com/repos/sivaramaaa/radare2/issues{/number}","pulls_url":"https://api.github.com/repos/sivaramaaa/radare2/pulls{/number}","milestones_url":"https://api.github.com/repos/sivaramaaa/radare2/milestones{/number}","notifications_url":"https://api.github.com/repos/sivaramaaa/radare2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sivaramaaa/radare2/labels{/name}","releases_url":"https://api.github.com/repos/sivaramaaa/radare2/releases{/id}","deployments_url":"https://api.github.com/repos/sivaramaaa/radare2/deployments","created_at":"2017-11-12T06:16:30Z","updated_at":"2018-07-11T10:08:53Z","pushed_at":"2018-07-11T22:52:27Z","git_url":"git://github.com/sivaramaaa/radare2.git","ssh_url":"git@github.com:sivaramaaa/radare2.git","clone_url":"https://github.com/sivaramaaa/radare2.git","svn_url":"https://github.com/sivaramaaa/radare2","homepage":"http://www.radare.org/","size":87022,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"radare:master","ref":"master","sha":"4e3cbbfa3eb3e81713e78f2f2106c636054122ed","user":{"login":"radare","id":917142,"node_id":"MDQ6VXNlcjkxNzE0Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/917142?v=4","gravatar_id":"","url":"https://api.github.com/users/radare","html_url":"https://github.com/radare","followers_url":"https://api.github.com/users/radare/followers","following_url":"https://api.github.com/users/radare/following{/other_user}","gists_url":"https://api.github.com/users/radare/gists{/gist_id}","starred_url":"https://api.github.com/users/radare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radare/subscriptions","organizations_url":"https://api.github.com/users/radare/orgs","repos_url":"https://api.github.com/users/radare/repos","events_url":"https://api.github.com/users/radare/events{/privacy}","received_events_url":"https://api.github.com/users/radare/received_events","type":"User","site_admin":false},"repo":{"id":4869294,"node_id":"MDEwOlJlcG9zaXRvcnk0ODY5Mjk0","name":"radare2","full_name":"radare/radare2","owner":{"login":"radare","id":917142,"node_id":"MDQ6VXNlcjkxNzE0Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/917142?v=4","gravatar_id":"","url":"https://api.github.com/users/radare","html_url":"https://github.com/radare","followers_url":"https://api.github.com/users/radare/followers","following_url":"https://api.github.com/users/radare/following{/other_user}","gists_url":"https://api.github.com/users/radare/gists{/gist_id}","starred_url":"https://api.github.com/users/radare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radare/subscriptions","organizations_url":"https://api.github.com/users/radare/orgs","repos_url":"https://api.github.com/users/radare/repos","events_url":"https://api.github.com/users/radare/events{/privacy}","received_events_url":"https://api.github.com/users/radare/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/radare/radare2","description":"unix-like reverse engineering framework and commandline tools security","fork":false,"url":"https://api.github.com/repos/radare/radare2","forks_url":"https://api.github.com/repos/radare/radare2/forks","keys_url":"https://api.github.com/repos/radare/radare2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/radare/radare2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/radare/radare2/teams","hooks_url":"https://api.github.com/repos/radare/radare2/hooks","issue_events_url":"https://api.github.com/repos/radare/radare2/issues/events{/number}","events_url":"https://api.github.com/repos/radare/radare2/events","assignees_url":"https://api.github.com/repos/radare/radare2/assignees{/user}","branches_url":"https://api.github.com/repos/radare/radare2/branches{/branch}","tags_url":"https://api.github.com/repos/radare/radare2/tags","blobs_url":"https://api.github.com/repos/radare/radare2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/radare/radare2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/radare/radare2/git/refs{/sha}","trees_url":"https://api.github.com/repos/radare/radare2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/radare/radare2/statuses/{sha}","languages_url":"https://api.github.com/repos/radare/radare2/languages","stargazers_url":"https://api.github.com/repos/radare/radare2/stargazers","contributors_url":"https://api.github.com/repos/radare/radare2/contributors","subscribers_url":"https://api.github.com/repos/radare/radare2/subscribers","subscription_url":"https://api.github.com/repos/radare/radare2/subscription","commits_url":"https://api.github.com/repos/radare/radare2/commits{/sha}","git_commits_url":"https://api.github.com/repos/radare/radare2/git/commits{/sha}","comments_url":"https://api.github.com/repos/radare/radare2/comments{/number}","issue_comment_url":"https://api.github.com/repos/radare/radare2/issues/comments{/number}","contents_url":"https://api.github.com/repos/radare/radare2/contents/{+path}","compare_url":"https://api.github.com/repos/radare/radare2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/radare/radare2/merges","archive_url":"https://api.github.com/repos/radare/radare2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/radare/radare2/downloads","issues_url":"https://api.github.com/repos/radare/radare2/issues{/number}","pulls_url":"https://api.github.com/repos/radare/radare2/pulls{/number}","milestones_url":"https://api.github.com/repos/radare/radare2/milestones{/number}","notifications_url":"https://api.github.com/repos/radare/radare2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/radare/radare2/labels{/name}","releases_url":"https://api.github.com/repos/radare/radare2/releases{/id}","deployments_url":"https://api.github.com/repos/radare/radare2/deployments","created_at":"2012-07-03T07:42:26Z","updated_at":"2018-07-11T22:31:38Z","pushed_at":"2018-07-12T01:00:20Z","git_url":"git://github.com/radare/radare2.git","ssh_url":"git@github.com:radare/radare2.git","clone_url":"https://github.com/radare/radare2.git","svn_url":"https://github.com/radare/radare2","homepage":"http://www.radare.org/","size":86907,"stargazers_count":7760,"watchers_count":7760,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1526,"mirror_url":null,"archived":false,"open_issues_count":925,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":1526,"open_issues":925,"watchers":7760,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/radare/radare2/pulls/10705"},"html":{"href":"https://github.com/radare/radare2/pull/10705"},"issue":{"href":"https://api.github.com/repos/radare/radare2/issues/10705"},"comments":{"href":"https://api.github.com/repos/radare/radare2/issues/10705/comments"},"review_comments":{"href":"https://api.github.com/repos/radare/radare2/pulls/10705/comments"},"review_comment":{"href":"https://api.github.com/repos/radare/radare2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/radare/radare2/pulls/10705/commits"},"statuses":{"href":"https://api.github.com/repos/radare/radare2/statuses/59403461f567ba66bdf2e7513b8cb1153ff68410"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"XVilka"}}