{"action":"created","comment":{"url":"https://api.github.com/repos/syndtr/goleveldb/pulls/comments/171327225","pull_request_review_id":100160386,"id":171327225,"diff_hunk":"@@ -177,3 +178,121 @@ type Storage interface {\n \t// called after the storage has been closed.\n \tClose() error\n }\n+\n+// MeteredStorage collects read and write statistics.\n+type MeteredStorage interface {\n+\t// Reads returns the cumulative number of read bytes of the underlying storage.\n+\tReads() uint64\n+\t// Writes returns the cumulative number of written bytes of the underlying storage.\n+\tWrites() uint64\n+}","path":"leveldb/storage/storage.go","position":19,"original_position":19,"commit_id":"5367fac9c9a09fb20075ca536a36359c6290fb45","original_commit_id":"774fa5856ba034a27ba009c82996d1c38ec6c912","user":{"login":"kurkomisi","id":20811485,"avatar_url":"https://avatars0.githubusercontent.com/u/20811485?v=4","gravatar_id":"","url":"https://api.github.com/users/kurkomisi","html_url":"https://github.com/kurkomisi","followers_url":"https://api.github.com/users/kurkomisi/followers","following_url":"https://api.github.com/users/kurkomisi/following{/other_user}","gists_url":"https://api.github.com/users/kurkomisi/gists{/gist_id}","starred_url":"https://api.github.com/users/kurkomisi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kurkomisi/subscriptions","organizations_url":"https://api.github.com/users/kurkomisi/orgs","repos_url":"https://api.github.com/users/kurkomisi/repos","events_url":"https://api.github.com/users/kurkomisi/events{/privacy}","received_events_url":"https://api.github.com/users/kurkomisi/received_events","type":"User","site_admin":false},"body":"I think the interface is needed at the type conversion, `db.go:966` in order to keep the custom type private.","created_at":"2018-02-28T17:44:37Z","updated_at":"2018-02-28T17:44:37Z","html_url":"https://github.com/syndtr/goleveldb/pull/207#discussion_r171327225","pull_request_url":"https://api.github.com/repos/syndtr/goleveldb/pulls/207","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/syndtr/goleveldb/pulls/comments/171327225"},"html":{"href":"https://github.com/syndtr/goleveldb/pull/207#discussion_r171327225"},"pull_request":{"href":"https://api.github.com/repos/syndtr/goleveldb/pulls/207"}},"in_reply_to_id":171281090},"pull_request":{"url":"https://api.github.com/repos/syndtr/goleveldb/pulls/207","id":171984180,"html_url":"https://github.com/syndtr/goleveldb/pull/207","diff_url":"https://github.com/syndtr/goleveldb/pull/207.diff","patch_url":"https://github.com/syndtr/goleveldb/pull/207.patch","issue_url":"https://api.github.com/repos/syndtr/goleveldb/issues/207","number":207,"state":"open","locked":false,"title":"leveldb: wrap storage, collect diskIO","user":{"login":"kurkomisi","id":20811485,"avatar_url":"https://avatars0.githubusercontent.com/u/20811485?v=4","gravatar_id":"","url":"https://api.github.com/users/kurkomisi","html_url":"https://github.com/kurkomisi","followers_url":"https://api.github.com/users/kurkomisi/followers","following_url":"https://api.github.com/users/kurkomisi/following{/other_user}","gists_url":"https://api.github.com/users/kurkomisi/gists{/gist_id}","starred_url":"https://api.github.com/users/kurkomisi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kurkomisi/subscriptions","organizations_url":"https://api.github.com/users/kurkomisi/orgs","repos_url":"https://api.github.com/users/kurkomisi/repos","events_url":"https://api.github.com/users/kurkomisi/events{/privacy}","received_events_url":"https://api.github.com/users/kurkomisi/received_events","type":"User","site_admin":false},"body":"Different approach of https://github.com/syndtr/goleveldb/pull/206","created_at":"2018-02-28T15:21:40Z","updated_at":"2018-02-28T17:44:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cd84c577b4983e0d3df37c40ffce43726dcaf83f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/syndtr/goleveldb/pulls/207/commits","review_comments_url":"https://api.github.com/repos/syndtr/goleveldb/pulls/207/comments","review_comment_url":"https://api.github.com/repos/syndtr/goleveldb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/syndtr/goleveldb/issues/207/comments","statuses_url":"https://api.github.com/repos/syndtr/goleveldb/statuses/5367fac9c9a09fb20075ca536a36359c6290fb45","head":{"label":"kurkomisi:wrap_storage","ref":"wrap_storage","sha":"5367fac9c9a09fb20075ca536a36359c6290fb45","user":{"login":"kurkomisi","id":20811485,"avatar_url":"https://avatars0.githubusercontent.com/u/20811485?v=4","gravatar_id":"","url":"https://api.github.com/users/kurkomisi","html_url":"https://github.com/kurkomisi","followers_url":"https://api.github.com/users/kurkomisi/followers","following_url":"https://api.github.com/users/kurkomisi/following{/other_user}","gists_url":"https://api.github.com/users/kurkomisi/gists{/gist_id}","starred_url":"https://api.github.com/users/kurkomisi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kurkomisi/subscriptions","organizations_url":"https://api.github.com/users/kurkomisi/orgs","repos_url":"https://api.github.com/users/kurkomisi/repos","events_url":"https://api.github.com/users/kurkomisi/events{/privacy}","received_events_url":"https://api.github.com/users/kurkomisi/received_events","type":"User","site_admin":false},"repo":{"id":122453994,"name":"goleveldb","full_name":"kurkomisi/goleveldb","owner":{"login":"kurkomisi","id":20811485,"avatar_url":"https://avatars0.githubusercontent.com/u/20811485?v=4","gravatar_id":"","url":"https://api.github.com/users/kurkomisi","html_url":"https://github.com/kurkomisi","followers_url":"https://api.github.com/users/kurkomisi/followers","following_url":"https://api.github.com/users/kurkomisi/following{/other_user}","gists_url":"https://api.github.com/users/kurkomisi/gists{/gist_id}","starred_url":"https://api.github.com/users/kurkomisi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kurkomisi/subscriptions","organizations_url":"https://api.github.com/users/kurkomisi/orgs","repos_url":"https://api.github.com/users/kurkomisi/repos","events_url":"https://api.github.com/users/kurkomisi/events{/privacy}","received_events_url":"https://api.github.com/users/kurkomisi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kurkomisi/goleveldb","description":"LevelDB key/value database in Go.","fork":true,"url":"https://api.github.com/repos/kurkomisi/goleveldb","forks_url":"https://api.github.com/repos/kurkomisi/goleveldb/forks","keys_url":"https://api.github.com/repos/kurkomisi/goleveldb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kurkomisi/goleveldb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kurkomisi/goleveldb/teams","hooks_url":"https://api.github.com/repos/kurkomisi/goleveldb/hooks","issue_events_url":"https://api.github.com/repos/kurkomisi/goleveldb/issues/events{/number}","events_url":"https://api.github.com/repos/kurkomisi/goleveldb/events","assignees_url":"https://api.github.com/repos/kurkomisi/goleveldb/assignees{/user}","branches_url":"https://api.github.com/repos/kurkomisi/goleveldb/branches{/branch}","tags_url":"https://api.github.com/repos/kurkomisi/goleveldb/tags","blobs_url":"https://api.github.com/repos/kurkomisi/goleveldb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kurkomisi/goleveldb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kurkomisi/goleveldb/git/refs{/sha}","trees_url":"https://api.github.com/repos/kurkomisi/goleveldb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kurkomisi/goleveldb/statuses/{sha}","languages_url":"https://api.github.com/repos/kurkomisi/goleveldb/languages","stargazers_url":"https://api.github.com/repos/kurkomisi/goleveldb/stargazers","contributors_url":"https://api.github.com/repos/kurkomisi/goleveldb/contributors","subscribers_url":"https://api.github.com/repos/kurkomisi/goleveldb/subscribers","subscription_url":"https://api.github.com/repos/kurkomisi/goleveldb/subscription","commits_url":"https://api.github.com/repos/kurkomisi/goleveldb/commits{/sha}","git_commits_url":"https://api.github.com/repos/kurkomisi/goleveldb/git/commits{/sha}","comments_url":"https://api.github.com/repos/kurkomisi/goleveldb/comments{/number}","issue_comment_url":"https://api.github.com/repos/kurkomisi/goleveldb/issues/comments{/number}","contents_url":"https://api.github.com/repos/kurkomisi/goleveldb/contents/{+path}","compare_url":"https://api.github.com/repos/kurkomisi/goleveldb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kurkomisi/goleveldb/merges","archive_url":"https://api.github.com/repos/kurkomisi/goleveldb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kurkomisi/goleveldb/downloads","issues_url":"https://api.github.com/repos/kurkomisi/goleveldb/issues{/number}","pulls_url":"https://api.github.com/repos/kurkomisi/goleveldb/pulls{/number}","milestones_url":"https://api.github.com/repos/kurkomisi/goleveldb/milestones{/number}","notifications_url":"https://api.github.com/repos/kurkomisi/goleveldb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kurkomisi/goleveldb/labels{/name}","releases_url":"https://api.github.com/repos/kurkomisi/goleveldb/releases{/id}","deployments_url":"https://api.github.com/repos/kurkomisi/goleveldb/deployments","created_at":"2018-02-22T09:01:15Z","updated_at":"2018-02-22T09:01:16Z","pushed_at":"2018-02-28T17:32:55Z","git_url":"git://github.com/kurkomisi/goleveldb.git","ssh_url":"git@github.com:kurkomisi/goleveldb.git","clone_url":"https://github.com/kurkomisi/goleveldb.git","svn_url":"https://github.com/kurkomisi/goleveldb","homepage":null,"size":1725,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"syndtr:master","ref":"master","sha":"c7a14d4b00e222eab6111b4cd1af829c13f53ec2","user":{"login":"syndtr","id":728237,"avatar_url":"https://avatars2.githubusercontent.com/u/728237?v=4","gravatar_id":"","url":"https://api.github.com/users/syndtr","html_url":"https://github.com/syndtr","followers_url":"https://api.github.com/users/syndtr/followers","following_url":"https://api.github.com/users/syndtr/following{/other_user}","gists_url":"https://api.github.com/users/syndtr/gists{/gist_id}","starred_url":"https://api.github.com/users/syndtr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syndtr/subscriptions","organizations_url":"https://api.github.com/users/syndtr/orgs","repos_url":"https://api.github.com/users/syndtr/repos","events_url":"https://api.github.com/users/syndtr/events{/privacy}","received_events_url":"https://api.github.com/users/syndtr/received_events","type":"User","site_admin":false},"repo":{"id":7767488,"name":"goleveldb","full_name":"syndtr/goleveldb","owner":{"login":"syndtr","id":728237,"avatar_url":"https://avatars2.githubusercontent.com/u/728237?v=4","gravatar_id":"","url":"https://api.github.com/users/syndtr","html_url":"https://github.com/syndtr","followers_url":"https://api.github.com/users/syndtr/followers","following_url":"https://api.github.com/users/syndtr/following{/other_user}","gists_url":"https://api.github.com/users/syndtr/gists{/gist_id}","starred_url":"https://api.github.com/users/syndtr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syndtr/subscriptions","organizations_url":"https://api.github.com/users/syndtr/orgs","repos_url":"https://api.github.com/users/syndtr/repos","events_url":"https://api.github.com/users/syndtr/events{/privacy}","received_events_url":"https://api.github.com/users/syndtr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/syndtr/goleveldb","description":"LevelDB key/value database in Go.","fork":false,"url":"https://api.github.com/repos/syndtr/goleveldb","forks_url":"https://api.github.com/repos/syndtr/goleveldb/forks","keys_url":"https://api.github.com/repos/syndtr/goleveldb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/syndtr/goleveldb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/syndtr/goleveldb/teams","hooks_url":"https://api.github.com/repos/syndtr/goleveldb/hooks","issue_events_url":"https://api.github.com/repos/syndtr/goleveldb/issues/events{/number}","events_url":"https://api.github.com/repos/syndtr/goleveldb/events","assignees_url":"https://api.github.com/repos/syndtr/goleveldb/assignees{/user}","branches_url":"https://api.github.com/repos/syndtr/goleveldb/branches{/branch}","tags_url":"https://api.github.com/repos/syndtr/goleveldb/tags","blobs_url":"https://api.github.com/repos/syndtr/goleveldb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/syndtr/goleveldb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/syndtr/goleveldb/git/refs{/sha}","trees_url":"https://api.github.com/repos/syndtr/goleveldb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/syndtr/goleveldb/statuses/{sha}","languages_url":"https://api.github.com/repos/syndtr/goleveldb/languages","stargazers_url":"https://api.github.com/repos/syndtr/goleveldb/stargazers","contributors_url":"https://api.github.com/repos/syndtr/goleveldb/contributors","subscribers_url":"https://api.github.com/repos/syndtr/goleveldb/subscribers","subscription_url":"https://api.github.com/repos/syndtr/goleveldb/subscription","commits_url":"https://api.github.com/repos/syndtr/goleveldb/commits{/sha}","git_commits_url":"https://api.github.com/repos/syndtr/goleveldb/git/commits{/sha}","comments_url":"https://api.github.com/repos/syndtr/goleveldb/comments{/number}","issue_comment_url":"https://api.github.com/repos/syndtr/goleveldb/issues/comments{/number}","contents_url":"https://api.github.com/repos/syndtr/goleveldb/contents/{+path}","compare_url":"https://api.github.com/repos/syndtr/goleveldb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/syndtr/goleveldb/merges","archive_url":"https://api.github.com/repos/syndtr/goleveldb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/syndtr/goleveldb/downloads","issues_url":"https://api.github.com/repos/syndtr/goleveldb/issues{/number}","pulls_url":"https://api.github.com/repos/syndtr/goleveldb/pulls{/number}","milestones_url":"https://api.github.com/repos/syndtr/goleveldb/milestones{/number}","notifications_url":"https://api.github.com/repos/syndtr/goleveldb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/syndtr/goleveldb/labels{/name}","releases_url":"https://api.github.com/repos/syndtr/goleveldb/releases{/id}","deployments_url":"https://api.github.com/repos/syndtr/goleveldb/deployments","created_at":"2013-01-23T04:08:58Z","updated_at":"2018-02-28T16:23:50Z","pushed_at":"2018-02-28T17:32:57Z","git_url":"git://github.com/syndtr/goleveldb.git","ssh_url":"git@github.com:syndtr/goleveldb.git","clone_url":"https://github.com/syndtr/goleveldb.git","svn_url":"https://github.com/syndtr/goleveldb","homepage":null,"size":1721,"stargazers_count":2019,"watchers_count":2019,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":256,"mirror_url":null,"archived":false,"open_issues_count":28,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause"},"forks":256,"open_issues":28,"watchers":2019,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/syndtr/goleveldb/pulls/207"},"html":{"href":"https://github.com/syndtr/goleveldb/pull/207"},"issue":{"href":"https://api.github.com/repos/syndtr/goleveldb/issues/207"},"comments":{"href":"https://api.github.com/repos/syndtr/goleveldb/issues/207/comments"},"review_comments":{"href":"https://api.github.com/repos/syndtr/goleveldb/pulls/207/comments"},"review_comment":{"href":"https://api.github.com/repos/syndtr/goleveldb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/syndtr/goleveldb/pulls/207/commits"},"statuses":{"href":"https://api.github.com/repos/syndtr/goleveldb/statuses/5367fac9c9a09fb20075ca536a36359c6290fb45"}},"author_association":"NONE"}}
{"actor":{"display_login":"kurkomisi"}}