{"action":"opened","number":50,"pull_request":{"url":"https://api.github.com/repos/webpack-contrib/webpack-serve/pulls/50","id":173442171,"html_url":"https://github.com/webpack-contrib/webpack-serve/pull/50","diff_url":"https://github.com/webpack-contrib/webpack-serve/pull/50.diff","patch_url":"https://github.com/webpack-contrib/webpack-serve/pull/50.patch","issue_url":"https://api.github.com/repos/webpack-contrib/webpack-serve/issues/50","number":50,"state":"open","locked":false,"title":"Allow Users to Completely Disable webpack-hot-client","user":{"login":"shellscape","id":76371,"avatar_url":"https://avatars1.githubusercontent.com/u/76371?v=4","gravatar_id":"","url":"https://api.github.com/users/shellscape","html_url":"https://github.com/shellscape","followers_url":"https://api.github.com/users/shellscape/followers","following_url":"https://api.github.com/users/shellscape/following{/other_user}","gists_url":"https://api.github.com/users/shellscape/gists{/gist_id}","starred_url":"https://api.github.com/users/shellscape/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shellscape/subscriptions","organizations_url":"https://api.github.com/users/shellscape/orgs","repos_url":"https://api.github.com/users/shellscape/repos","events_url":"https://api.github.com/users/shellscape/events{/privacy}","received_events_url":"https://api.github.com/users/shellscape/received_events","type":"User","site_admin":false},"body":"<!--\r\n  ZOMG a Pull Request. We ❤️ those!\r\n\r\n  If you remove or skip this template, you'll make the 🐼 sad and @ken_wheeler\r\n  will appear and pile-drive the close button from a great height while making\r\n  animal noises.\r\n\r\n  Please place an x (no spaces!) in all [ ] that apply\r\n-->\r\n\r\nThis PR contains a:\r\n\r\n- [ ] **bugfix**\r\n- [x] new **feature**\r\n- [ ] **code refactor**\r\n- [ ] **test update** <!-- if bug or feature is checked, this should be too -->\r\n- [ ] **typo fix**\r\n- [ ] **metadata update**\r\n\r\n### Motivation / Use-Case\r\n\r\nThere have been repeated requests to completely disable all HMR functionality for `webpack-serve`. While that kind of defeats the purpose of the top-to-bottom setup, it's obvious folks are using this for it's bindings to `webpack-dev-middleware` in lieu of HMR.\r\n\r\nThis PR introduces support for setting `hot: false` instead of an `Object`, and the `--no-hot-client` CLI flag. The result is that `webpack-hot-client` will never be instantiated through `koa-webpack`, no `WebSocket` serve will be started, and the user will be responsible for loading changes tracked by webpack. \r\n\r\n### Breaking Changes\r\n\r\nNone\r\n\r\n### Additional Info\r\n\r\nTODO: Add test coverage for this change\r\n","created_at":"2018-03-07T12:49:19Z","updated_at":"2018-03-07T12:49:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/webpack-contrib/webpack-serve/pulls/50/commits","review_comments_url":"https://api.github.com/repos/webpack-contrib/webpack-serve/pulls/50/comments","review_comment_url":"https://api.github.com/repos/webpack-contrib/webpack-serve/pulls/comments{/number}","comments_url":"https://api.github.com/repos/webpack-contrib/webpack-serve/issues/50/comments","statuses_url":"https://api.github.com/repos/webpack-contrib/webpack-serve/statuses/bdc0a9220c39cd84c936cb737f0911caa73d60d9","head":{"label":"webpack-contrib:disable-hot-client","ref":"disable-hot-client","sha":"bdc0a9220c39cd84c936cb737f0911caa73d60d9","user":{"login":"webpack-contrib","id":25012217,"avatar_url":"https://avatars3.githubusercontent.com/u/25012217?v=4","gravatar_id":"","url":"https://api.github.com/users/webpack-contrib","html_url":"https://github.com/webpack-contrib","followers_url":"https://api.github.com/users/webpack-contrib/followers","following_url":"https://api.github.com/users/webpack-contrib/following{/other_user}","gists_url":"https://api.github.com/users/webpack-contrib/gists{/gist_id}","starred_url":"https://api.github.com/users/webpack-contrib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webpack-contrib/subscriptions","organizations_url":"https://api.github.com/users/webpack-contrib/orgs","repos_url":"https://api.github.com/users/webpack-contrib/repos","events_url":"https://api.github.com/users/webpack-contrib/events{/privacy}","received_events_url":"https://api.github.com/users/webpack-contrib/received_events","type":"Organization","site_admin":false},"repo":{"id":115440393,"name":"webpack-serve","full_name":"webpack-contrib/webpack-serve","owner":{"login":"webpack-contrib","id":25012217,"avatar_url":"https://avatars3.githubusercontent.com/u/25012217?v=4","gravatar_id":"","url":"https://api.github.com/users/webpack-contrib","html_url":"https://github.com/webpack-contrib","followers_url":"https://api.github.com/users/webpack-contrib/followers","following_url":"https://api.github.com/users/webpack-contrib/following{/other_user}","gists_url":"https://api.github.com/users/webpack-contrib/gists{/gist_id}","starred_url":"https://api.github.com/users/webpack-contrib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webpack-contrib/subscriptions","organizations_url":"https://api.github.com/users/webpack-contrib/orgs","repos_url":"https://api.github.com/users/webpack-contrib/repos","events_url":"https://api.github.com/users/webpack-contrib/events{/privacy}","received_events_url":"https://api.github.com/users/webpack-contrib/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/webpack-contrib/webpack-serve","description":"A lean, modern, and flexible webpack development server","fork":false,"url":"https://api.github.com/repos/webpack-contrib/webpack-serve","forks_url":"https://api.github.com/repos/webpack-contrib/webpack-serve/forks","keys_url":"https://api.github.com/repos/webpack-contrib/webpack-serve/keys{/key_id}","collaborators_url":"https://api.github.com/repos/webpack-contrib/webpack-serve/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/webpack-contrib/webpack-serve/teams","hooks_url":"https://api.github.com/repos/webpack-contrib/webpack-serve/hooks","issue_events_url":"https://api.github.com/repos/webpack-contrib/webpack-serve/issues/events{/number}","events_url":"https://api.github.com/repos/webpack-contrib/webpack-serve/events","assignees_url":"https://api.github.com/repos/webpack-contrib/webpack-serve/assignees{/user}","branches_url":"https://api.github.com/repos/webpack-contrib/webpack-serve/branches{/branch}","tags_url":"https://api.github.com/repos/webpack-contrib/webpack-serve/tags","blobs_url":"https://api.github.com/repos/webpack-contrib/webpack-serve/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/webpack-contrib/webpack-serve/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/webpack-contrib/webpack-serve/git/refs{/sha}","trees_url":"https://api.github.com/repos/webpack-contrib/webpack-serve/git/trees{/sha}","statuses_url":"https://api.github.com/repos/webpack-contrib/webpack-serve/statuses/{sha}","languages_url":"https://api.github.com/repos/webpack-contrib/webpack-serve/languages","stargazers_url":"https://api.github.com/repos/webpack-contrib/webpack-serve/stargazers","contributors_url":"https://api.github.com/repos/webpack-contrib/webpack-serve/contributors","subscribers_url":"https://api.github.com/repos/webpack-contrib/webpack-serve/subscribers","subscription_url":"https://api.github.com/repos/webpack-contrib/webpack-serve/subscription","commits_url":"https://api.github.com/repos/webpack-contrib/webpack-serve/commits{/sha}","git_commits_url":"https://api.github.com/repos/webpack-contrib/webpack-serve/git/commits{/sha}","comments_url":"https://api.github.com/repos/webpack-contrib/webpack-serve/comments{/number}","issue_comment_url":"https://api.github.com/repos/webpack-contrib/webpack-serve/issues/comments{/number}","contents_url":"https://api.github.com/repos/webpack-contrib/webpack-serve/contents/{+path}","compare_url":"https://api.github.com/repos/webpack-contrib/webpack-serve/compare/{base}...{head}","merges_url":"https://api.github.com/repos/webpack-contrib/webpack-serve/merges","archive_url":"https://api.github.com/repos/webpack-contrib/webpack-serve/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/webpack-contrib/webpack-serve/downloads","issues_url":"https://api.github.com/repos/webpack-contrib/webpack-serve/issues{/number}","pulls_url":"https://api.github.com/repos/webpack-contrib/webpack-serve/pulls{/number}","milestones_url":"https://api.github.com/repos/webpack-contrib/webpack-serve/milestones{/number}","notifications_url":"https://api.github.com/repos/webpack-contrib/webpack-serve/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/webpack-contrib/webpack-serve/labels{/name}","releases_url":"https://api.github.com/repos/webpack-contrib/webpack-serve/releases{/id}","deployments_url":"https://api.github.com/repos/webpack-contrib/webpack-serve/deployments","created_at":"2017-12-26T17:06:30Z","updated_at":"2018-03-07T12:14:33Z","pushed_at":"2018-03-07T12:43:14Z","git_url":"git://github.com/webpack-contrib/webpack-serve.git","ssh_url":"git@github.com:webpack-contrib/webpack-serve.git","clone_url":"https://github.com/webpack-contrib/webpack-serve.git","svn_url":"https://github.com/webpack-contrib/webpack-serve","homepage":"","size":370,"stargazers_count":108,"watchers_count":108,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":8,"open_issues":8,"watchers":108,"default_branch":"master"}},"base":{"label":"webpack-contrib:master","ref":"master","sha":"16f4806821fb0994126f920ff9238bba6ea12824","user":{"login":"webpack-contrib","id":25012217,"avatar_url":"https://avatars3.githubusercontent.com/u/25012217?v=4","gravatar_id":"","url":"https://api.github.com/users/webpack-contrib","html_url":"https://github.com/webpack-contrib","followers_url":"https://api.github.com/users/webpack-contrib/followers","following_url":"https://api.github.com/users/webpack-contrib/following{/other_user}","gists_url":"https://api.github.com/users/webpack-contrib/gists{/gist_id}","starred_url":"https://api.github.com/users/webpack-contrib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webpack-contrib/subscriptions","organizations_url":"https://api.github.com/users/webpack-contrib/orgs","repos_url":"https://api.github.com/users/webpack-contrib/repos","events_url":"https://api.github.com/users/webpack-contrib/events{/privacy}","received_events_url":"https://api.github.com/users/webpack-contrib/received_events","type":"Organization","site_admin":false},"repo":{"id":115440393,"name":"webpack-serve","full_name":"webpack-contrib/webpack-serve","owner":{"login":"webpack-contrib","id":25012217,"avatar_url":"https://avatars3.githubusercontent.com/u/25012217?v=4","gravatar_id":"","url":"https://api.github.com/users/webpack-contrib","html_url":"https://github.com/webpack-contrib","followers_url":"https://api.github.com/users/webpack-contrib/followers","following_url":"https://api.github.com/users/webpack-contrib/following{/other_user}","gists_url":"https://api.github.com/users/webpack-contrib/gists{/gist_id}","starred_url":"https://api.github.com/users/webpack-contrib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webpack-contrib/subscriptions","organizations_url":"https://api.github.com/users/webpack-contrib/orgs","repos_url":"https://api.github.com/users/webpack-contrib/repos","events_url":"https://api.github.com/users/webpack-contrib/events{/privacy}","received_events_url":"https://api.github.com/users/webpack-contrib/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/webpack-contrib/webpack-serve","description":"A lean, modern, and flexible webpack development server","fork":false,"url":"https://api.github.com/repos/webpack-contrib/webpack-serve","forks_url":"https://api.github.com/repos/webpack-contrib/webpack-serve/forks","keys_url":"https://api.github.com/repos/webpack-contrib/webpack-serve/keys{/key_id}","collaborators_url":"https://api.github.com/repos/webpack-contrib/webpack-serve/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/webpack-contrib/webpack-serve/teams","hooks_url":"https://api.github.com/repos/webpack-contrib/webpack-serve/hooks","issue_events_url":"https://api.github.com/repos/webpack-contrib/webpack-serve/issues/events{/number}","events_url":"https://api.github.com/repos/webpack-contrib/webpack-serve/events","assignees_url":"https://api.github.com/repos/webpack-contrib/webpack-serve/assignees{/user}","branches_url":"https://api.github.com/repos/webpack-contrib/webpack-serve/branches{/branch}","tags_url":"https://api.github.com/repos/webpack-contrib/webpack-serve/tags","blobs_url":"https://api.github.com/repos/webpack-contrib/webpack-serve/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/webpack-contrib/webpack-serve/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/webpack-contrib/webpack-serve/git/refs{/sha}","trees_url":"https://api.github.com/repos/webpack-contrib/webpack-serve/git/trees{/sha}","statuses_url":"https://api.github.com/repos/webpack-contrib/webpack-serve/statuses/{sha}","languages_url":"https://api.github.com/repos/webpack-contrib/webpack-serve/languages","stargazers_url":"https://api.github.com/repos/webpack-contrib/webpack-serve/stargazers","contributors_url":"https://api.github.com/repos/webpack-contrib/webpack-serve/contributors","subscribers_url":"https://api.github.com/repos/webpack-contrib/webpack-serve/subscribers","subscription_url":"https://api.github.com/repos/webpack-contrib/webpack-serve/subscription","commits_url":"https://api.github.com/repos/webpack-contrib/webpack-serve/commits{/sha}","git_commits_url":"https://api.github.com/repos/webpack-contrib/webpack-serve/git/commits{/sha}","comments_url":"https://api.github.com/repos/webpack-contrib/webpack-serve/comments{/number}","issue_comment_url":"https://api.github.com/repos/webpack-contrib/webpack-serve/issues/comments{/number}","contents_url":"https://api.github.com/repos/webpack-contrib/webpack-serve/contents/{+path}","compare_url":"https://api.github.com/repos/webpack-contrib/webpack-serve/compare/{base}...{head}","merges_url":"https://api.github.com/repos/webpack-contrib/webpack-serve/merges","archive_url":"https://api.github.com/repos/webpack-contrib/webpack-serve/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/webpack-contrib/webpack-serve/downloads","issues_url":"https://api.github.com/repos/webpack-contrib/webpack-serve/issues{/number}","pulls_url":"https://api.github.com/repos/webpack-contrib/webpack-serve/pulls{/number}","milestones_url":"https://api.github.com/repos/webpack-contrib/webpack-serve/milestones{/number}","notifications_url":"https://api.github.com/repos/webpack-contrib/webpack-serve/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/webpack-contrib/webpack-serve/labels{/name}","releases_url":"https://api.github.com/repos/webpack-contrib/webpack-serve/releases{/id}","deployments_url":"https://api.github.com/repos/webpack-contrib/webpack-serve/deployments","created_at":"2017-12-26T17:06:30Z","updated_at":"2018-03-07T12:14:33Z","pushed_at":"2018-03-07T12:43:14Z","git_url":"git://github.com/webpack-contrib/webpack-serve.git","ssh_url":"git@github.com:webpack-contrib/webpack-serve.git","clone_url":"https://github.com/webpack-contrib/webpack-serve.git","svn_url":"https://github.com/webpack-contrib/webpack-serve","homepage":"","size":370,"stargazers_count":108,"watchers_count":108,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":8,"open_issues":8,"watchers":108,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/webpack-contrib/webpack-serve/pulls/50"},"html":{"href":"https://github.com/webpack-contrib/webpack-serve/pull/50"},"issue":{"href":"https://api.github.com/repos/webpack-contrib/webpack-serve/issues/50"},"comments":{"href":"https://api.github.com/repos/webpack-contrib/webpack-serve/issues/50/comments"},"review_comments":{"href":"https://api.github.com/repos/webpack-contrib/webpack-serve/pulls/50/comments"},"review_comment":{"href":"https://api.github.com/repos/webpack-contrib/webpack-serve/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/webpack-contrib/webpack-serve/pulls/50/commits"},"statuses":{"href":"https://api.github.com/repos/webpack-contrib/webpack-serve/statuses/bdc0a9220c39cd84c936cb737f0911caa73d60d9"}},"author_association":"COLLABORATOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":29,"deletions":13,"changed_files":3}}
{"actor":{"display_login":"shellscape"}}