{"action":"opened","number":309,"pull_request":{"url":"https://api.github.com/repos/lupoDharkael/flameshot/pulls/309","id":207800021,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3ODAwMDIx","html_url":"https://github.com/lupoDharkael/flameshot/pull/309","diff_url":"https://github.com/lupoDharkael/flameshot/pull/309.diff","patch_url":"https://github.com/lupoDharkael/flameshot/pull/309.patch","issue_url":"https://api.github.com/repos/lupoDharkael/flameshot/issues/309","number":309,"state":"open","locked":false,"title":"flameshot.pro: Install SVG icon into $prefix/share/icons/hicolor/scalable/apps instead of $prefix/share/pixmaps","user":{"login":"hosiet","id":8443926,"node_id":"MDQ6VXNlcjg0NDM5MjY=","avatar_url":"https://avatars3.githubusercontent.com/u/8443926?v=4","gravatar_id":"","url":"https://api.github.com/users/hosiet","html_url":"https://github.com/hosiet","followers_url":"https://api.github.com/users/hosiet/followers","following_url":"https://api.github.com/users/hosiet/following{/other_user}","gists_url":"https://api.github.com/users/hosiet/gists{/gist_id}","starred_url":"https://api.github.com/users/hosiet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hosiet/subscriptions","organizations_url":"https://api.github.com/users/hosiet/orgs","repos_url":"https://api.github.com/users/hosiet/repos","events_url":"https://api.github.com/users/hosiet/events{/privacy}","received_events_url":"https://api.github.com/users/hosiet/received_events","type":"User","site_admin":false},"body":"While #293 somehow solves the icon problem, it is not the best solution. According to Freedesktop.org Icon Theme Specification\r\n(https://specifications.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html):\r\n\r\n    Directory Layout\r\n\r\n    [...]\r\n    By default, apps should look in $HOME/.icons (for backwards compatibility),\r\n    in $XDG_DATA_DIRS/icons and in /usr/share/pixmaps (in that order).\r\n    [...]\r\n    In order to have a place for third party applications to install their icons\r\n    there should always exist a theme called \"hicolor\".\r\n\r\nWhile using /pixmaps/ directory ensures the least priority in search icons, the directory name itself \"pixmaps\" does not suite our actual situation (provided that \"flameshot.svg\" is a scalable icon, not a **pixmap**).\r\n\r\nI suggest that we place this icon into the \"hicolor\" theme (aka fallback theme) in /icons/ directory under \"scalable/apps/\" subdirectory.\r\n\r\nProposed changes:\r\n\r\n  1. Install flameshot.svg under `$prefix/share/icons/hicolor/scalable/apps/` instad of `$prefix/share/pixmaps/`.\r\n\r\n  2. Rename qmake \"icon\" target into \"appsvgicon\" target so that the name \"icon\" may still be used in the future for other tasks.\r\n\r\n  3. The embedded rpm spec file is updated accordingly.\r\n\r\n* * *\r\n\r\ncc @AlfredoRamos","created_at":"2018-08-12T01:31:14Z","updated_at":"2018-08-12T01:31:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/lupoDharkael/flameshot/pulls/309/commits","review_comments_url":"https://api.github.com/repos/lupoDharkael/flameshot/pulls/309/comments","review_comment_url":"https://api.github.com/repos/lupoDharkael/flameshot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lupoDharkael/flameshot/issues/309/comments","statuses_url":"https://api.github.com/repos/lupoDharkael/flameshot/statuses/9adc9b83ad566add37c2b101e52a685c97bcc5f9","head":{"label":"hosiet:pr-change-svg-icon-installation-dir","ref":"pr-change-svg-icon-installation-dir","sha":"9adc9b83ad566add37c2b101e52a685c97bcc5f9","user":{"login":"hosiet","id":8443926,"node_id":"MDQ6VXNlcjg0NDM5MjY=","avatar_url":"https://avatars3.githubusercontent.com/u/8443926?v=4","gravatar_id":"","url":"https://api.github.com/users/hosiet","html_url":"https://github.com/hosiet","followers_url":"https://api.github.com/users/hosiet/followers","following_url":"https://api.github.com/users/hosiet/following{/other_user}","gists_url":"https://api.github.com/users/hosiet/gists{/gist_id}","starred_url":"https://api.github.com/users/hosiet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hosiet/subscriptions","organizations_url":"https://api.github.com/users/hosiet/orgs","repos_url":"https://api.github.com/users/hosiet/repos","events_url":"https://api.github.com/users/hosiet/events{/privacy}","received_events_url":"https://api.github.com/users/hosiet/received_events","type":"User","site_admin":false},"repo":{"id":116392295,"node_id":"MDEwOlJlcG9zaXRvcnkxMTYzOTIyOTU=","name":"flameshot","full_name":"hosiet/flameshot","owner":{"login":"hosiet","id":8443926,"node_id":"MDQ6VXNlcjg0NDM5MjY=","avatar_url":"https://avatars3.githubusercontent.com/u/8443926?v=4","gravatar_id":"","url":"https://api.github.com/users/hosiet","html_url":"https://github.com/hosiet","followers_url":"https://api.github.com/users/hosiet/followers","following_url":"https://api.github.com/users/hosiet/following{/other_user}","gists_url":"https://api.github.com/users/hosiet/gists{/gist_id}","starred_url":"https://api.github.com/users/hosiet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hosiet/subscriptions","organizations_url":"https://api.github.com/users/hosiet/orgs","repos_url":"https://api.github.com/users/hosiet/repos","events_url":"https://api.github.com/users/hosiet/events{/privacy}","received_events_url":"https://api.github.com/users/hosiet/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hosiet/flameshot","description":"Powerful yet simple to use screenshot software","fork":true,"url":"https://api.github.com/repos/hosiet/flameshot","forks_url":"https://api.github.com/repos/hosiet/flameshot/forks","keys_url":"https://api.github.com/repos/hosiet/flameshot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hosiet/flameshot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hosiet/flameshot/teams","hooks_url":"https://api.github.com/repos/hosiet/flameshot/hooks","issue_events_url":"https://api.github.com/repos/hosiet/flameshot/issues/events{/number}","events_url":"https://api.github.com/repos/hosiet/flameshot/events","assignees_url":"https://api.github.com/repos/hosiet/flameshot/assignees{/user}","branches_url":"https://api.github.com/repos/hosiet/flameshot/branches{/branch}","tags_url":"https://api.github.com/repos/hosiet/flameshot/tags","blobs_url":"https://api.github.com/repos/hosiet/flameshot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hosiet/flameshot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hosiet/flameshot/git/refs{/sha}","trees_url":"https://api.github.com/repos/hosiet/flameshot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hosiet/flameshot/statuses/{sha}","languages_url":"https://api.github.com/repos/hosiet/flameshot/languages","stargazers_url":"https://api.github.com/repos/hosiet/flameshot/stargazers","contributors_url":"https://api.github.com/repos/hosiet/flameshot/contributors","subscribers_url":"https://api.github.com/repos/hosiet/flameshot/subscribers","subscription_url":"https://api.github.com/repos/hosiet/flameshot/subscription","commits_url":"https://api.github.com/repos/hosiet/flameshot/commits{/sha}","git_commits_url":"https://api.github.com/repos/hosiet/flameshot/git/commits{/sha}","comments_url":"https://api.github.com/repos/hosiet/flameshot/comments{/number}","issue_comment_url":"https://api.github.com/repos/hosiet/flameshot/issues/comments{/number}","contents_url":"https://api.github.com/repos/hosiet/flameshot/contents/{+path}","compare_url":"https://api.github.com/repos/hosiet/flameshot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hosiet/flameshot/merges","archive_url":"https://api.github.com/repos/hosiet/flameshot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hosiet/flameshot/downloads","issues_url":"https://api.github.com/repos/hosiet/flameshot/issues{/number}","pulls_url":"https://api.github.com/repos/hosiet/flameshot/pulls{/number}","milestones_url":"https://api.github.com/repos/hosiet/flameshot/milestones{/number}","notifications_url":"https://api.github.com/repos/hosiet/flameshot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hosiet/flameshot/labels{/name}","releases_url":"https://api.github.com/repos/hosiet/flameshot/releases{/id}","deployments_url":"https://api.github.com/repos/hosiet/flameshot/deployments","created_at":"2018-01-05T14:16:48Z","updated_at":"2018-01-05T14:16:50Z","pushed_at":"2018-08-12T01:27:01Z","git_url":"git://github.com/hosiet/flameshot.git","ssh_url":"git@github.com:hosiet/flameshot.git","clone_url":"https://github.com/hosiet/flameshot.git","svn_url":"https://github.com/hosiet/flameshot","homepage":"","size":1733,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lupoDharkael:master","ref":"master","sha":"b0000f8dcd8c6c8ecccde77255fb6cb2f74b908f","user":{"login":"lupoDharkael","id":14951430,"node_id":"MDQ6VXNlcjE0OTUxNDMw","avatar_url":"https://avatars3.githubusercontent.com/u/14951430?v=4","gravatar_id":"","url":"https://api.github.com/users/lupoDharkael","html_url":"https://github.com/lupoDharkael","followers_url":"https://api.github.com/users/lupoDharkael/followers","following_url":"https://api.github.com/users/lupoDharkael/following{/other_user}","gists_url":"https://api.github.com/users/lupoDharkael/gists{/gist_id}","starred_url":"https://api.github.com/users/lupoDharkael/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lupoDharkael/subscriptions","organizations_url":"https://api.github.com/users/lupoDharkael/orgs","repos_url":"https://api.github.com/users/lupoDharkael/repos","events_url":"https://api.github.com/users/lupoDharkael/events{/privacy}","received_events_url":"https://api.github.com/users/lupoDharkael/received_events","type":"User","site_admin":false},"repo":{"id":90902132,"node_id":"MDEwOlJlcG9zaXRvcnk5MDkwMjEzMg==","name":"flameshot","full_name":"lupoDharkael/flameshot","owner":{"login":"lupoDharkael","id":14951430,"node_id":"MDQ6VXNlcjE0OTUxNDMw","avatar_url":"https://avatars3.githubusercontent.com/u/14951430?v=4","gravatar_id":"","url":"https://api.github.com/users/lupoDharkael","html_url":"https://github.com/lupoDharkael","followers_url":"https://api.github.com/users/lupoDharkael/followers","following_url":"https://api.github.com/users/lupoDharkael/following{/other_user}","gists_url":"https://api.github.com/users/lupoDharkael/gists{/gist_id}","starred_url":"https://api.github.com/users/lupoDharkael/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lupoDharkael/subscriptions","organizations_url":"https://api.github.com/users/lupoDharkael/orgs","repos_url":"https://api.github.com/users/lupoDharkael/repos","events_url":"https://api.github.com/users/lupoDharkael/events{/privacy}","received_events_url":"https://api.github.com/users/lupoDharkael/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lupoDharkael/flameshot","description":"Powerful yet simple to use screenshot software","fork":false,"url":"https://api.github.com/repos/lupoDharkael/flameshot","forks_url":"https://api.github.com/repos/lupoDharkael/flameshot/forks","keys_url":"https://api.github.com/repos/lupoDharkael/flameshot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lupoDharkael/flameshot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lupoDharkael/flameshot/teams","hooks_url":"https://api.github.com/repos/lupoDharkael/flameshot/hooks","issue_events_url":"https://api.github.com/repos/lupoDharkael/flameshot/issues/events{/number}","events_url":"https://api.github.com/repos/lupoDharkael/flameshot/events","assignees_url":"https://api.github.com/repos/lupoDharkael/flameshot/assignees{/user}","branches_url":"https://api.github.com/repos/lupoDharkael/flameshot/branches{/branch}","tags_url":"https://api.github.com/repos/lupoDharkael/flameshot/tags","blobs_url":"https://api.github.com/repos/lupoDharkael/flameshot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lupoDharkael/flameshot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lupoDharkael/flameshot/git/refs{/sha}","trees_url":"https://api.github.com/repos/lupoDharkael/flameshot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lupoDharkael/flameshot/statuses/{sha}","languages_url":"https://api.github.com/repos/lupoDharkael/flameshot/languages","stargazers_url":"https://api.github.com/repos/lupoDharkael/flameshot/stargazers","contributors_url":"https://api.github.com/repos/lupoDharkael/flameshot/contributors","subscribers_url":"https://api.github.com/repos/lupoDharkael/flameshot/subscribers","subscription_url":"https://api.github.com/repos/lupoDharkael/flameshot/subscription","commits_url":"https://api.github.com/repos/lupoDharkael/flameshot/commits{/sha}","git_commits_url":"https://api.github.com/repos/lupoDharkael/flameshot/git/commits{/sha}","comments_url":"https://api.github.com/repos/lupoDharkael/flameshot/comments{/number}","issue_comment_url":"https://api.github.com/repos/lupoDharkael/flameshot/issues/comments{/number}","contents_url":"https://api.github.com/repos/lupoDharkael/flameshot/contents/{+path}","compare_url":"https://api.github.com/repos/lupoDharkael/flameshot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lupoDharkael/flameshot/merges","archive_url":"https://api.github.com/repos/lupoDharkael/flameshot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lupoDharkael/flameshot/downloads","issues_url":"https://api.github.com/repos/lupoDharkael/flameshot/issues{/number}","pulls_url":"https://api.github.com/repos/lupoDharkael/flameshot/pulls{/number}","milestones_url":"https://api.github.com/repos/lupoDharkael/flameshot/milestones{/number}","notifications_url":"https://api.github.com/repos/lupoDharkael/flameshot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lupoDharkael/flameshot/labels{/name}","releases_url":"https://api.github.com/repos/lupoDharkael/flameshot/releases{/id}","deployments_url":"https://api.github.com/repos/lupoDharkael/flameshot/deployments","created_at":"2017-05-10T19:44:51Z","updated_at":"2018-08-11T22:28:26Z","pushed_at":"2018-08-12T00:52:47Z","git_url":"git://github.com/lupoDharkael/flameshot.git","ssh_url":"git@github.com:lupoDharkael/flameshot.git","clone_url":"https://github.com/lupoDharkael/flameshot.git","svn_url":"https://github.com/lupoDharkael/flameshot","homepage":"","size":1810,"stargazers_count":1247,"watchers_count":1247,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":90,"mirror_url":null,"archived":false,"open_issues_count":93,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":90,"open_issues":93,"watchers":1247,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lupoDharkael/flameshot/pulls/309"},"html":{"href":"https://github.com/lupoDharkael/flameshot/pull/309"},"issue":{"href":"https://api.github.com/repos/lupoDharkael/flameshot/issues/309"},"comments":{"href":"https://api.github.com/repos/lupoDharkael/flameshot/issues/309/comments"},"review_comments":{"href":"https://api.github.com/repos/lupoDharkael/flameshot/pulls/309/comments"},"review_comment":{"href":"https://api.github.com/repos/lupoDharkael/flameshot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lupoDharkael/flameshot/pulls/309/commits"},"statuses":{"href":"https://api.github.com/repos/lupoDharkael/flameshot/statuses/9adc9b83ad566add37c2b101e52a685c97bcc5f9"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":4,"deletions":4,"changed_files":2}}
{"actor":{"display_login":"hosiet"}}