{"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/23160","repository_url":"https://api.github.com/repos/cms-sw/cmssw","labels_url":"https://api.github.com/repos/cms-sw/cmssw/issues/23160/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/23160/comments","events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/23160/events","html_url":"https://github.com/cms-sw/cmssw/pull/23160","id":320913947,"number":23160,"title":"Updated pixel track efficiency codes for phase 1 detector","user":{"login":"chenxvan","id":7559253,"avatar_url":"https://avatars2.githubusercontent.com/u/7559253?v=4","gravatar_id":"","url":"https://api.github.com/users/chenxvan","html_url":"https://github.com/chenxvan","followers_url":"https://api.github.com/users/chenxvan/followers","following_url":"https://api.github.com/users/chenxvan/following{/other_user}","gists_url":"https://api.github.com/users/chenxvan/gists{/gist_id}","starred_url":"https://api.github.com/users/chenxvan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chenxvan/subscriptions","organizations_url":"https://api.github.com/users/chenxvan/orgs","repos_url":"https://api.github.com/users/chenxvan/repos","events_url":"https://api.github.com/users/chenxvan/events{/privacy}","received_events_url":"https://api.github.com/users/chenxvan/received_events","type":"User","site_admin":false},"labels":[{"id":673935047,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/code-checks-approved","name":"code-checks-approved","color":"2cbe4e","default":false},{"id":88645479,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-available","name":"comparison-available","color":"2cbe4e","default":false},{"id":52820549,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/dqm-pending","name":"dqm-pending","color":"fbca04","default":false},{"id":56953091,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04","default":false},{"id":53167770,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"ff8000","default":false},{"id":56131195,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-approved","name":"tests-approved","color":"2cbe4e","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/76","html_url":"https://github.com/cms-sw/cmssw/milestone/76","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/76/labels","id":3227631,"number":76,"title":"CMSSW_10_2_X","description":null,"creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars3.githubusercontent.com/u/4115138?v=4","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":41,"closed_issues":319,"state":"open","created_at":"2018-03-29T07:57:10Z","updated_at":"2018-05-17T10:40:04Z","due_on":null,"closed_at":null},"comments":31,"created_at":"2018-05-07T18:49:45Z","updated_at":"2018-05-17T12:02:56Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/23160","html_url":"https://github.com/cms-sw/cmssw/pull/23160","diff_url":"https://github.com/cms-sw/cmssw/pull/23160.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/23160.patch"},"body":"Added offline cuts for all the pixel detector. Added fiducial cuts and backpropagation for Layer 1 detector."},"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/389842755","html_url":"https://github.com/cms-sw/cmssw/pull/23160#issuecomment-389842755","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/23160","id":389842755,"user":{"login":"fioriNTU","id":10884186,"avatar_url":"https://avatars0.githubusercontent.com/u/10884186?v=4","gravatar_id":"","url":"https://api.github.com/users/fioriNTU","html_url":"https://github.com/fioriNTU","followers_url":"https://api.github.com/users/fioriNTU/followers","following_url":"https://api.github.com/users/fioriNTU/following{/other_user}","gists_url":"https://api.github.com/users/fioriNTU/gists{/gist_id}","starred_url":"https://api.github.com/users/fioriNTU/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fioriNTU/subscriptions","organizations_url":"https://api.github.com/users/fioriNTU/orgs","repos_url":"https://api.github.com/users/fioriNTU/repos","events_url":"https://api.github.com/users/fioriNTU/events{/privacy}","received_events_url":"https://api.github.com/users/fioriNTU/received_events","type":"User","site_admin":false},"created_at":"2018-05-17T12:02:56Z","updated_at":"2018-05-17T12:02:56Z","author_association":"CONTRIBUTOR","body":"@fabiocos checking the diff link you sent it looks like the PV plots perfectly match on top of each other, but they are flagged as \"failing comparison\" please check here:\r\n\r\nhttps://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_10_2_X_2018-05-16-2300+23160/26539/140.53_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI/OfflinePV_Alignment.html\r\n\r\nFor what concern this PR, it doesn't touch any reconstruction module, it only change the way the Layer 1 efficiency for Pixels is computed in DQM, it neither changes the total number of bins in DQM histograms. I would expect only a slight increase in processing time, but nothing can happen outside the Phase1 DQM."}}
{"actor":{"display_login":"fioriNTU"}}