{"action":"opened","number":31,"pull_request":{"url":"https://api.github.com/repos/AutosoftDMS/SignalR-Swift/pulls/31","id":170133860,"html_url":"https://github.com/AutosoftDMS/SignalR-Swift/pull/31","diff_url":"https://github.com/AutosoftDMS/SignalR-Swift/pull/31.diff","patch_url":"https://github.com/AutosoftDMS/SignalR-Swift/pull/31.patch","issue_url":"https://api.github.com/repos/AutosoftDMS/SignalR-Swift/issues/31","number":31,"state":"open","locked":false,"title":"Heartbeat monitor & crash & refactoring ","user":{"login":"vldalx","id":13873200,"avatar_url":"https://avatars1.githubusercontent.com/u/13873200?v=4","gravatar_id":"","url":"https://api.github.com/users/vldalx","html_url":"https://github.com/vldalx","followers_url":"https://api.github.com/users/vldalx/followers","following_url":"https://api.github.com/users/vldalx/following{/other_user}","gists_url":"https://api.github.com/users/vldalx/gists{/gist_id}","starred_url":"https://api.github.com/users/vldalx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vldalx/subscriptions","organizations_url":"https://api.github.com/users/vldalx/orgs","repos_url":"https://api.github.com/users/vldalx/repos","events_url":"https://api.github.com/users/vldalx/events{/privacy}","received_events_url":"https://api.github.com/users/vldalx/received_events","type":"User","site_admin":false},"body":"## A wrong logic in `HeartbeatMonitor`.\r\nCompare the next 2 snippets:\r\nhttps://github.com/AutosoftDMS/SignalR-Swift/blob/a8ded012ff2991004375e14c2de054999a1c8e51/SignalR-Swift/Client/HeartbeatMonitor.swift#L49-L50\r\nand\r\nhttps://github.com/DyKnow/SignalR-ObjC/blob/c412cc38618b27c83fe170eaa9da95aa0c7eb42a/SignalR.Client/SRHeartbeatMonitor.m#L65-L68\r\nThis is the only place that the field is set to `true`.\r\nThe same error is here\r\nhttps://github.com/AutosoftDMS/SignalR-Swift/blob/a8ded012ff2991004375e14c2de054999a1c8e51/SignalR-Swift/Client/HeartbeatMonitor.swift#L54-L55\r\n\r\n## A crash.\r\nhttps://github.com/AutosoftDMS/SignalR-Swift/blob/a8ded012ff2991004375e14c2de054999a1c8e51/SignalR-Swift/Client/Connection.swift#L260-L262\r\nThe problem is the `unowned` reference ","created_at":"2018-02-20T09:06:19Z","updated_at":"2018-02-20T09:06:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/AutosoftDMS/SignalR-Swift/pulls/31/commits","review_comments_url":"https://api.github.com/repos/AutosoftDMS/SignalR-Swift/pulls/31/comments","review_comment_url":"https://api.github.com/repos/AutosoftDMS/SignalR-Swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AutosoftDMS/SignalR-Swift/issues/31/comments","statuses_url":"https://api.github.com/repos/AutosoftDMS/SignalR-Swift/statuses/7582baf4af2eaf7cc73cc6c791e0c6fadfa747e4","head":{"label":"vldalx:heartbeat_monitor","ref":"heartbeat_monitor","sha":"7582baf4af2eaf7cc73cc6c791e0c6fadfa747e4","user":{"login":"vldalx","id":13873200,"avatar_url":"https://avatars1.githubusercontent.com/u/13873200?v=4","gravatar_id":"","url":"https://api.github.com/users/vldalx","html_url":"https://github.com/vldalx","followers_url":"https://api.github.com/users/vldalx/followers","following_url":"https://api.github.com/users/vldalx/following{/other_user}","gists_url":"https://api.github.com/users/vldalx/gists{/gist_id}","starred_url":"https://api.github.com/users/vldalx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vldalx/subscriptions","organizations_url":"https://api.github.com/users/vldalx/orgs","repos_url":"https://api.github.com/users/vldalx/repos","events_url":"https://api.github.com/users/vldalx/events{/privacy}","received_events_url":"https://api.github.com/users/vldalx/received_events","type":"User","site_admin":false},"repo":{"id":95765122,"name":"SignalR-Swift","full_name":"vldalx/SignalR-Swift","owner":{"login":"vldalx","id":13873200,"avatar_url":"https://avatars1.githubusercontent.com/u/13873200?v=4","gravatar_id":"","url":"https://api.github.com/users/vldalx","html_url":"https://github.com/vldalx","followers_url":"https://api.github.com/users/vldalx/followers","following_url":"https://api.github.com/users/vldalx/following{/other_user}","gists_url":"https://api.github.com/users/vldalx/gists{/gist_id}","starred_url":"https://api.github.com/users/vldalx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vldalx/subscriptions","organizations_url":"https://api.github.com/users/vldalx/orgs","repos_url":"https://api.github.com/users/vldalx/repos","events_url":"https://api.github.com/users/vldalx/events{/privacy}","received_events_url":"https://api.github.com/users/vldalx/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vldalx/SignalR-Swift","description":"SignalR client library written in pure Swift","fork":true,"url":"https://api.github.com/repos/vldalx/SignalR-Swift","forks_url":"https://api.github.com/repos/vldalx/SignalR-Swift/forks","keys_url":"https://api.github.com/repos/vldalx/SignalR-Swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vldalx/SignalR-Swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vldalx/SignalR-Swift/teams","hooks_url":"https://api.github.com/repos/vldalx/SignalR-Swift/hooks","issue_events_url":"https://api.github.com/repos/vldalx/SignalR-Swift/issues/events{/number}","events_url":"https://api.github.com/repos/vldalx/SignalR-Swift/events","assignees_url":"https://api.github.com/repos/vldalx/SignalR-Swift/assignees{/user}","branches_url":"https://api.github.com/repos/vldalx/SignalR-Swift/branches{/branch}","tags_url":"https://api.github.com/repos/vldalx/SignalR-Swift/tags","blobs_url":"https://api.github.com/repos/vldalx/SignalR-Swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vldalx/SignalR-Swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vldalx/SignalR-Swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/vldalx/SignalR-Swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vldalx/SignalR-Swift/statuses/{sha}","languages_url":"https://api.github.com/repos/vldalx/SignalR-Swift/languages","stargazers_url":"https://api.github.com/repos/vldalx/SignalR-Swift/stargazers","contributors_url":"https://api.github.com/repos/vldalx/SignalR-Swift/contributors","subscribers_url":"https://api.github.com/repos/vldalx/SignalR-Swift/subscribers","subscription_url":"https://api.github.com/repos/vldalx/SignalR-Swift/subscription","commits_url":"https://api.github.com/repos/vldalx/SignalR-Swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/vldalx/SignalR-Swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/vldalx/SignalR-Swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/vldalx/SignalR-Swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/vldalx/SignalR-Swift/contents/{+path}","compare_url":"https://api.github.com/repos/vldalx/SignalR-Swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vldalx/SignalR-Swift/merges","archive_url":"https://api.github.com/repos/vldalx/SignalR-Swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vldalx/SignalR-Swift/downloads","issues_url":"https://api.github.com/repos/vldalx/SignalR-Swift/issues{/number}","pulls_url":"https://api.github.com/repos/vldalx/SignalR-Swift/pulls{/number}","milestones_url":"https://api.github.com/repos/vldalx/SignalR-Swift/milestones{/number}","notifications_url":"https://api.github.com/repos/vldalx/SignalR-Swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vldalx/SignalR-Swift/labels{/name}","releases_url":"https://api.github.com/repos/vldalx/SignalR-Swift/releases{/id}","deployments_url":"https://api.github.com/repos/vldalx/SignalR-Swift/deployments","created_at":"2017-06-29T10:08:49Z","updated_at":"2017-06-29T10:08:51Z","pushed_at":"2018-02-20T08:03:51Z","git_url":"git://github.com/vldalx/SignalR-Swift.git","ssh_url":"git@github.com:vldalx/SignalR-Swift.git","clone_url":"https://github.com/vldalx/SignalR-Swift.git","svn_url":"https://github.com/vldalx/SignalR-Swift","homepage":null,"size":1147,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"AutosoftDMS:master","ref":"master","sha":"a8ded012ff2991004375e14c2de054999a1c8e51","user":{"login":"AutosoftDMS","id":15056243,"avatar_url":"https://avatars2.githubusercontent.com/u/15056243?v=4","gravatar_id":"","url":"https://api.github.com/users/AutosoftDMS","html_url":"https://github.com/AutosoftDMS","followers_url":"https://api.github.com/users/AutosoftDMS/followers","following_url":"https://api.github.com/users/AutosoftDMS/following{/other_user}","gists_url":"https://api.github.com/users/AutosoftDMS/gists{/gist_id}","starred_url":"https://api.github.com/users/AutosoftDMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AutosoftDMS/subscriptions","organizations_url":"https://api.github.com/users/AutosoftDMS/orgs","repos_url":"https://api.github.com/users/AutosoftDMS/repos","events_url":"https://api.github.com/users/AutosoftDMS/events{/privacy}","received_events_url":"https://api.github.com/users/AutosoftDMS/received_events","type":"Organization","site_admin":false},"repo":{"id":85649979,"name":"SignalR-Swift","full_name":"AutosoftDMS/SignalR-Swift","owner":{"login":"AutosoftDMS","id":15056243,"avatar_url":"https://avatars2.githubusercontent.com/u/15056243?v=4","gravatar_id":"","url":"https://api.github.com/users/AutosoftDMS","html_url":"https://github.com/AutosoftDMS","followers_url":"https://api.github.com/users/AutosoftDMS/followers","following_url":"https://api.github.com/users/AutosoftDMS/following{/other_user}","gists_url":"https://api.github.com/users/AutosoftDMS/gists{/gist_id}","starred_url":"https://api.github.com/users/AutosoftDMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AutosoftDMS/subscriptions","organizations_url":"https://api.github.com/users/AutosoftDMS/orgs","repos_url":"https://api.github.com/users/AutosoftDMS/repos","events_url":"https://api.github.com/users/AutosoftDMS/events{/privacy}","received_events_url":"https://api.github.com/users/AutosoftDMS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AutosoftDMS/SignalR-Swift","description":"SignalR client library written in pure Swift","fork":false,"url":"https://api.github.com/repos/AutosoftDMS/SignalR-Swift","forks_url":"https://api.github.com/repos/AutosoftDMS/SignalR-Swift/forks","keys_url":"https://api.github.com/repos/AutosoftDMS/SignalR-Swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AutosoftDMS/SignalR-Swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AutosoftDMS/SignalR-Swift/teams","hooks_url":"https://api.github.com/repos/AutosoftDMS/SignalR-Swift/hooks","issue_events_url":"https://api.github.com/repos/AutosoftDMS/SignalR-Swift/issues/events{/number}","events_url":"https://api.github.com/repos/AutosoftDMS/SignalR-Swift/events","assignees_url":"https://api.github.com/repos/AutosoftDMS/SignalR-Swift/assignees{/user}","branches_url":"https://api.github.com/repos/AutosoftDMS/SignalR-Swift/branches{/branch}","tags_url":"https://api.github.com/repos/AutosoftDMS/SignalR-Swift/tags","blobs_url":"https://api.github.com/repos/AutosoftDMS/SignalR-Swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AutosoftDMS/SignalR-Swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AutosoftDMS/SignalR-Swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/AutosoftDMS/SignalR-Swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AutosoftDMS/SignalR-Swift/statuses/{sha}","languages_url":"https://api.github.com/repos/AutosoftDMS/SignalR-Swift/languages","stargazers_url":"https://api.github.com/repos/AutosoftDMS/SignalR-Swift/stargazers","contributors_url":"https://api.github.com/repos/AutosoftDMS/SignalR-Swift/contributors","subscribers_url":"https://api.github.com/repos/AutosoftDMS/SignalR-Swift/subscribers","subscription_url":"https://api.github.com/repos/AutosoftDMS/SignalR-Swift/subscription","commits_url":"https://api.github.com/repos/AutosoftDMS/SignalR-Swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/AutosoftDMS/SignalR-Swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/AutosoftDMS/SignalR-Swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/AutosoftDMS/SignalR-Swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/AutosoftDMS/SignalR-Swift/contents/{+path}","compare_url":"https://api.github.com/repos/AutosoftDMS/SignalR-Swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AutosoftDMS/SignalR-Swift/merges","archive_url":"https://api.github.com/repos/AutosoftDMS/SignalR-Swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AutosoftDMS/SignalR-Swift/downloads","issues_url":"https://api.github.com/repos/AutosoftDMS/SignalR-Swift/issues{/number}","pulls_url":"https://api.github.com/repos/AutosoftDMS/SignalR-Swift/pulls{/number}","milestones_url":"https://api.github.com/repos/AutosoftDMS/SignalR-Swift/milestones{/number}","notifications_url":"https://api.github.com/repos/AutosoftDMS/SignalR-Swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AutosoftDMS/SignalR-Swift/labels{/name}","releases_url":"https://api.github.com/repos/AutosoftDMS/SignalR-Swift/releases{/id}","deployments_url":"https://api.github.com/repos/AutosoftDMS/SignalR-Swift/deployments","created_at":"2017-03-21T02:29:33Z","updated_at":"2018-02-15T09:54:41Z","pushed_at":"2018-02-08T14:39:53Z","git_url":"git://github.com/AutosoftDMS/SignalR-Swift.git","ssh_url":"git@github.com:AutosoftDMS/SignalR-Swift.git","clone_url":"https://github.com/AutosoftDMS/SignalR-Swift.git","svn_url":"https://github.com/AutosoftDMS/SignalR-Swift","homepage":null,"size":1146,"stargazers_count":21,"watchers_count":21,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":11,"open_issues":7,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AutosoftDMS/SignalR-Swift/pulls/31"},"html":{"href":"https://github.com/AutosoftDMS/SignalR-Swift/pull/31"},"issue":{"href":"https://api.github.com/repos/AutosoftDMS/SignalR-Swift/issues/31"},"comments":{"href":"https://api.github.com/repos/AutosoftDMS/SignalR-Swift/issues/31/comments"},"review_comments":{"href":"https://api.github.com/repos/AutosoftDMS/SignalR-Swift/pulls/31/comments"},"review_comment":{"href":"https://api.github.com/repos/AutosoftDMS/SignalR-Swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AutosoftDMS/SignalR-Swift/pulls/31/commits"},"statuses":{"href":"https://api.github.com/repos/AutosoftDMS/SignalR-Swift/statuses/7582baf4af2eaf7cc73cc6c791e0c6fadfa747e4"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":4,"additions":38,"deletions":73,"changed_files":5}}
{"actor":{"display_login":"vldalx"}}