{"action":"created","comment":{"url":"https://api.github.com/repos/PatB93/Smalltown/pulls/comments/214043741","pull_request_review_id":151010425,"id":214043741,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNDA0Mzc0MQ==","diff_hunk":"@@ -40,32 +44,34 @@ class MainActivity : AppCompatActivity() {\n         addFragment(landingMenuFragment, R.id.fragment_content)\n         replaceFragmentSubject.subscribe { replaceFragment(it, R.id.fragment_content) }\n \n-        dbWorkerThread = DbWorkerThread(\"dbWorkerThread\")\n-        dbWorkerThread.start()\n+        //TODO: This is an example of how to save data into the inventory db, I should actually implement this at some point\n+        //insertInventoryObject(InventoryDataRecord(null, \"rock\", 100, null, 1, null)).subscribe()\n     }\n \n-    private fun insertInventoryDataIntoDb(inventoryData: InventoryDataTable) {\n-        val task = Runnable { inventoryDatabase?.inventoryDataDao()?.insert(inventoryData) }\n-        dbWorkerThread.postTask(task)\n+    //TODO: This is an example of how to fetch data from the inventory db, I should actually implement this at some point\n+    //override fun onResume() {\n+    //  super.onResume()\n+    //  fetchInventory().flatMapIterable { it }\n+    //      .subscribe(this::success, this::fail)\n+    //}\n+\n+\n+    //TODO: This class may not be the best place for these DB functions, but they will live here for the time being.","path":"app/src/main/java/com/example/pbode/smalltown/MainActivity.kt","position":59,"original_position":59,"commit_id":"6e54b79058af3e383aa44f9d1709ad88e9c454a8","original_commit_id":"6e54b79058af3e383aa44f9d1709ad88e9c454a8","user":{"login":"lucas-brandt","id":10900261,"node_id":"MDQ6VXNlcjEwOTAwMjYx","avatar_url":"https://avatars1.githubusercontent.com/u/10900261?v=4","gravatar_id":"","url":"https://api.github.com/users/lucas-brandt","html_url":"https://github.com/lucas-brandt","followers_url":"https://api.github.com/users/lucas-brandt/followers","following_url":"https://api.github.com/users/lucas-brandt/following{/other_user}","gists_url":"https://api.github.com/users/lucas-brandt/gists{/gist_id}","starred_url":"https://api.github.com/users/lucas-brandt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucas-brandt/subscriptions","organizations_url":"https://api.github.com/users/lucas-brandt/orgs","repos_url":"https://api.github.com/users/lucas-brandt/repos","events_url":"https://api.github.com/users/lucas-brandt/events{/privacy}","received_events_url":"https://api.github.com/users/lucas-brandt/received_events","type":"User","site_admin":false},"body":"no u\r\n","created_at":"2018-08-30T14:03:50Z","updated_at":"2018-08-30T14:03:50Z","html_url":"https://github.com/PatB93/Smalltown/pull/7#discussion_r214043741","pull_request_url":"https://api.github.com/repos/PatB93/Smalltown/pulls/7","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/PatB93/Smalltown/pulls/comments/214043741"},"html":{"href":"https://github.com/PatB93/Smalltown/pull/7#discussion_r214043741"},"pull_request":{"href":"https://api.github.com/repos/PatB93/Smalltown/pulls/7"}},"in_reply_to_id":213830258},"pull_request":{"url":"https://api.github.com/repos/PatB93/Smalltown/pulls/7","id":211873379,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExODczMzc5","html_url":"https://github.com/PatB93/Smalltown/pull/7","diff_url":"https://github.com/PatB93/Smalltown/pull/7.diff","patch_url":"https://github.com/PatB93/Smalltown/pull/7.patch","issue_url":"https://api.github.com/repos/PatB93/Smalltown/issues/7","number":7,"state":"open","locked":false,"title":"ROOM DB and Inventory Integration Pt 2: Electric Boogaloo","user":{"login":"lucas-brandt","id":10900261,"node_id":"MDQ6VXNlcjEwOTAwMjYx","avatar_url":"https://avatars1.githubusercontent.com/u/10900261?v=4","gravatar_id":"","url":"https://api.github.com/users/lucas-brandt","html_url":"https://github.com/lucas-brandt","followers_url":"https://api.github.com/users/lucas-brandt/followers","following_url":"https://api.github.com/users/lucas-brandt/following{/other_user}","gists_url":"https://api.github.com/users/lucas-brandt/gists{/gist_id}","starred_url":"https://api.github.com/users/lucas-brandt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucas-brandt/subscriptions","organizations_url":"https://api.github.com/users/lucas-brandt/orgs","repos_url":"https://api.github.com/users/lucas-brandt/repos","events_url":"https://api.github.com/users/lucas-brandt/events{/privacy}","received_events_url":"https://api.github.com/users/lucas-brandt/received_events","type":"User","site_admin":false},"body":"Pat merged the first one without my final commit. 👏 for Pat.\r\n\r\nIn other news:\r\nI added RxRoom architecture and implemented said architecture on the inventory database. Basically, I rewrote how our databases work. Yay.","created_at":"2018-08-29T20:13:32Z","updated_at":"2018-08-30T14:03:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3dcaf6026e4d2e8caaf24bddf56f5ffb5bb8ed13","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1039658219,"node_id":"MDU6TGFiZWwxMDM5NjU4MjE5","url":"https://api.github.com/repos/PatB93/Smalltown/labels/Needs%20More%20Work","name":"Needs More Work","color":"af2c2a","default":false},{"id":1033253837,"node_id":"MDU6TGFiZWwxMDMzMjUzODM3","url":"https://api.github.com/repos/PatB93/Smalltown/labels/enhancement","name":"enhancement","color":"a2eeef","default":true},{"id":1033253841,"node_id":"MDU6TGFiZWwxMDMzMjUzODQx","url":"https://api.github.com/repos/PatB93/Smalltown/labels/question","name":"question","color":"d876e3","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/PatB93/Smalltown/pulls/7/commits","review_comments_url":"https://api.github.com/repos/PatB93/Smalltown/pulls/7/comments","review_comment_url":"https://api.github.com/repos/PatB93/Smalltown/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PatB93/Smalltown/issues/7/comments","statuses_url":"https://api.github.com/repos/PatB93/Smalltown/statuses/6e54b79058af3e383aa44f9d1709ad88e9c454a8","head":{"label":"PatB93:inventory-database-setup","ref":"inventory-database-setup","sha":"6e54b79058af3e383aa44f9d1709ad88e9c454a8","user":{"login":"PatB93","id":12751226,"node_id":"MDQ6VXNlcjEyNzUxMjI2","avatar_url":"https://avatars0.githubusercontent.com/u/12751226?v=4","gravatar_id":"","url":"https://api.github.com/users/PatB93","html_url":"https://github.com/PatB93","followers_url":"https://api.github.com/users/PatB93/followers","following_url":"https://api.github.com/users/PatB93/following{/other_user}","gists_url":"https://api.github.com/users/PatB93/gists{/gist_id}","starred_url":"https://api.github.com/users/PatB93/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PatB93/subscriptions","organizations_url":"https://api.github.com/users/PatB93/orgs","repos_url":"https://api.github.com/users/PatB93/repos","events_url":"https://api.github.com/users/PatB93/events{/privacy}","received_events_url":"https://api.github.com/users/PatB93/received_events","type":"User","site_admin":false},"repo":{"id":145862624,"node_id":"MDEwOlJlcG9zaXRvcnkxNDU4NjI2MjQ=","name":"Smalltown","full_name":"PatB93/Smalltown","owner":{"login":"PatB93","id":12751226,"node_id":"MDQ6VXNlcjEyNzUxMjI2","avatar_url":"https://avatars0.githubusercontent.com/u/12751226?v=4","gravatar_id":"","url":"https://api.github.com/users/PatB93","html_url":"https://github.com/PatB93","followers_url":"https://api.github.com/users/PatB93/followers","following_url":"https://api.github.com/users/PatB93/following{/other_user}","gists_url":"https://api.github.com/users/PatB93/gists{/gist_id}","starred_url":"https://api.github.com/users/PatB93/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PatB93/subscriptions","organizations_url":"https://api.github.com/users/PatB93/orgs","repos_url":"https://api.github.com/users/PatB93/repos","events_url":"https://api.github.com/users/PatB93/events{/privacy}","received_events_url":"https://api.github.com/users/PatB93/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/PatB93/Smalltown","description":null,"fork":false,"url":"https://api.github.com/repos/PatB93/Smalltown","forks_url":"https://api.github.com/repos/PatB93/Smalltown/forks","keys_url":"https://api.github.com/repos/PatB93/Smalltown/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PatB93/Smalltown/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PatB93/Smalltown/teams","hooks_url":"https://api.github.com/repos/PatB93/Smalltown/hooks","issue_events_url":"https://api.github.com/repos/PatB93/Smalltown/issues/events{/number}","events_url":"https://api.github.com/repos/PatB93/Smalltown/events","assignees_url":"https://api.github.com/repos/PatB93/Smalltown/assignees{/user}","branches_url":"https://api.github.com/repos/PatB93/Smalltown/branches{/branch}","tags_url":"https://api.github.com/repos/PatB93/Smalltown/tags","blobs_url":"https://api.github.com/repos/PatB93/Smalltown/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PatB93/Smalltown/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PatB93/Smalltown/git/refs{/sha}","trees_url":"https://api.github.com/repos/PatB93/Smalltown/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PatB93/Smalltown/statuses/{sha}","languages_url":"https://api.github.com/repos/PatB93/Smalltown/languages","stargazers_url":"https://api.github.com/repos/PatB93/Smalltown/stargazers","contributors_url":"https://api.github.com/repos/PatB93/Smalltown/contributors","subscribers_url":"https://api.github.com/repos/PatB93/Smalltown/subscribers","subscription_url":"https://api.github.com/repos/PatB93/Smalltown/subscription","commits_url":"https://api.github.com/repos/PatB93/Smalltown/commits{/sha}","git_commits_url":"https://api.github.com/repos/PatB93/Smalltown/git/commits{/sha}","comments_url":"https://api.github.com/repos/PatB93/Smalltown/comments{/number}","issue_comment_url":"https://api.github.com/repos/PatB93/Smalltown/issues/comments{/number}","contents_url":"https://api.github.com/repos/PatB93/Smalltown/contents/{+path}","compare_url":"https://api.github.com/repos/PatB93/Smalltown/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PatB93/Smalltown/merges","archive_url":"https://api.github.com/repos/PatB93/Smalltown/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PatB93/Smalltown/downloads","issues_url":"https://api.github.com/repos/PatB93/Smalltown/issues{/number}","pulls_url":"https://api.github.com/repos/PatB93/Smalltown/pulls{/number}","milestones_url":"https://api.github.com/repos/PatB93/Smalltown/milestones{/number}","notifications_url":"https://api.github.com/repos/PatB93/Smalltown/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PatB93/Smalltown/labels{/name}","releases_url":"https://api.github.com/repos/PatB93/Smalltown/releases{/id}","deployments_url":"https://api.github.com/repos/PatB93/Smalltown/deployments","created_at":"2018-08-23T14:09:27Z","updated_at":"2018-08-29T19:04:46Z","pushed_at":"2018-08-30T01:46:47Z","git_url":"git://github.com/PatB93/Smalltown.git","ssh_url":"git@github.com:PatB93/Smalltown.git","clone_url":"https://github.com/PatB93/Smalltown.git","svn_url":"https://github.com/PatB93/Smalltown","homepage":null,"size":274,"stargazers_count":0,"watchers_count":0,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"PatB93:master","ref":"master","sha":"d4bc6fb33694ac67be96daed8101edda6276f1f5","user":{"login":"PatB93","id":12751226,"node_id":"MDQ6VXNlcjEyNzUxMjI2","avatar_url":"https://avatars0.githubusercontent.com/u/12751226?v=4","gravatar_id":"","url":"https://api.github.com/users/PatB93","html_url":"https://github.com/PatB93","followers_url":"https://api.github.com/users/PatB93/followers","following_url":"https://api.github.com/users/PatB93/following{/other_user}","gists_url":"https://api.github.com/users/PatB93/gists{/gist_id}","starred_url":"https://api.github.com/users/PatB93/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PatB93/subscriptions","organizations_url":"https://api.github.com/users/PatB93/orgs","repos_url":"https://api.github.com/users/PatB93/repos","events_url":"https://api.github.com/users/PatB93/events{/privacy}","received_events_url":"https://api.github.com/users/PatB93/received_events","type":"User","site_admin":false},"repo":{"id":145862624,"node_id":"MDEwOlJlcG9zaXRvcnkxNDU4NjI2MjQ=","name":"Smalltown","full_name":"PatB93/Smalltown","owner":{"login":"PatB93","id":12751226,"node_id":"MDQ6VXNlcjEyNzUxMjI2","avatar_url":"https://avatars0.githubusercontent.com/u/12751226?v=4","gravatar_id":"","url":"https://api.github.com/users/PatB93","html_url":"https://github.com/PatB93","followers_url":"https://api.github.com/users/PatB93/followers","following_url":"https://api.github.com/users/PatB93/following{/other_user}","gists_url":"https://api.github.com/users/PatB93/gists{/gist_id}","starred_url":"https://api.github.com/users/PatB93/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PatB93/subscriptions","organizations_url":"https://api.github.com/users/PatB93/orgs","repos_url":"https://api.github.com/users/PatB93/repos","events_url":"https://api.github.com/users/PatB93/events{/privacy}","received_events_url":"https://api.github.com/users/PatB93/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/PatB93/Smalltown","description":null,"fork":false,"url":"https://api.github.com/repos/PatB93/Smalltown","forks_url":"https://api.github.com/repos/PatB93/Smalltown/forks","keys_url":"https://api.github.com/repos/PatB93/Smalltown/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PatB93/Smalltown/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PatB93/Smalltown/teams","hooks_url":"https://api.github.com/repos/PatB93/Smalltown/hooks","issue_events_url":"https://api.github.com/repos/PatB93/Smalltown/issues/events{/number}","events_url":"https://api.github.com/repos/PatB93/Smalltown/events","assignees_url":"https://api.github.com/repos/PatB93/Smalltown/assignees{/user}","branches_url":"https://api.github.com/repos/PatB93/Smalltown/branches{/branch}","tags_url":"https://api.github.com/repos/PatB93/Smalltown/tags","blobs_url":"https://api.github.com/repos/PatB93/Smalltown/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PatB93/Smalltown/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PatB93/Smalltown/git/refs{/sha}","trees_url":"https://api.github.com/repos/PatB93/Smalltown/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PatB93/Smalltown/statuses/{sha}","languages_url":"https://api.github.com/repos/PatB93/Smalltown/languages","stargazers_url":"https://api.github.com/repos/PatB93/Smalltown/stargazers","contributors_url":"https://api.github.com/repos/PatB93/Smalltown/contributors","subscribers_url":"https://api.github.com/repos/PatB93/Smalltown/subscribers","subscription_url":"https://api.github.com/repos/PatB93/Smalltown/subscription","commits_url":"https://api.github.com/repos/PatB93/Smalltown/commits{/sha}","git_commits_url":"https://api.github.com/repos/PatB93/Smalltown/git/commits{/sha}","comments_url":"https://api.github.com/repos/PatB93/Smalltown/comments{/number}","issue_comment_url":"https://api.github.com/repos/PatB93/Smalltown/issues/comments{/number}","contents_url":"https://api.github.com/repos/PatB93/Smalltown/contents/{+path}","compare_url":"https://api.github.com/repos/PatB93/Smalltown/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PatB93/Smalltown/merges","archive_url":"https://api.github.com/repos/PatB93/Smalltown/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PatB93/Smalltown/downloads","issues_url":"https://api.github.com/repos/PatB93/Smalltown/issues{/number}","pulls_url":"https://api.github.com/repos/PatB93/Smalltown/pulls{/number}","milestones_url":"https://api.github.com/repos/PatB93/Smalltown/milestones{/number}","notifications_url":"https://api.github.com/repos/PatB93/Smalltown/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PatB93/Smalltown/labels{/name}","releases_url":"https://api.github.com/repos/PatB93/Smalltown/releases{/id}","deployments_url":"https://api.github.com/repos/PatB93/Smalltown/deployments","created_at":"2018-08-23T14:09:27Z","updated_at":"2018-08-29T19:04:46Z","pushed_at":"2018-08-30T01:46:47Z","git_url":"git://github.com/PatB93/Smalltown.git","ssh_url":"git@github.com:PatB93/Smalltown.git","clone_url":"https://github.com/PatB93/Smalltown.git","svn_url":"https://github.com/PatB93/Smalltown","homepage":null,"size":274,"stargazers_count":0,"watchers_count":0,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PatB93/Smalltown/pulls/7"},"html":{"href":"https://github.com/PatB93/Smalltown/pull/7"},"issue":{"href":"https://api.github.com/repos/PatB93/Smalltown/issues/7"},"comments":{"href":"https://api.github.com/repos/PatB93/Smalltown/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/PatB93/Smalltown/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/PatB93/Smalltown/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PatB93/Smalltown/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/PatB93/Smalltown/statuses/6e54b79058af3e383aa44f9d1709ad88e9c454a8"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"lucas-brandt"}}