{"action":"created","comment":{"url":"https://api.github.com/repos/UWPCE-PythonCert-ClassRepos/Self_Paced-Online/pulls/comments/188999191","pull_request_review_id":121092124,"id":188999191,"diff_hunk":"@@ -0,0 +1,152 @@\n+#!/usr/bin/env python3\n+import sys\n+from collections import defaultdict\n+\n+\n+class Donor:\n+    def __init__(self, names, amount):\n+        self.names = names\n+        self.amount = amount\n+\n+    @property\n+    def names(self):\n+        return \"{}\".format(self._names)\n+\n+    @names.setter\n+    def names(self, names):\n+        self._names = names\n+\n+    @property\n+    def amount(self):\n+        return self._amount\n+\n+    @amount.setter\n+    def amount(self, amount):\n+        self._amount = amount","path":"students/shibin_mathew/lesson9/mailroom.py","position":25,"original_position":25,"commit_id":"1074a56e14e68a7f8dbc865d247da8efdd9d0c89","original_commit_id":"1074a56e14e68a7f8dbc865d247da8efdd9d0c89","user":{"login":"natasha-aleksandrova","id":1928658,"avatar_url":"https://avatars2.githubusercontent.com/u/1928658?v=4","gravatar_id":"","url":"https://api.github.com/users/natasha-aleksandrova","html_url":"https://github.com/natasha-aleksandrova","followers_url":"https://api.github.com/users/natasha-aleksandrova/followers","following_url":"https://api.github.com/users/natasha-aleksandrova/following{/other_user}","gists_url":"https://api.github.com/users/natasha-aleksandrova/gists{/gist_id}","starred_url":"https://api.github.com/users/natasha-aleksandrova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natasha-aleksandrova/subscriptions","organizations_url":"https://api.github.com/users/natasha-aleksandrova/orgs","repos_url":"https://api.github.com/users/natasha-aleksandrova/repos","events_url":"https://api.github.com/users/natasha-aleksandrova/events{/privacy}","received_events_url":"https://api.github.com/users/natasha-aleksandrova/received_events","type":"User","site_admin":false},"body":"if you are not doing anything special you don't really need to use properties, just regular class attributes should work.","created_at":"2018-05-17T15:22:47Z","updated_at":"2018-05-17T15:33:39Z","html_url":"https://github.com/UWPCE-PythonCert-ClassRepos/Self_Paced-Online/pull/579#discussion_r188999191","pull_request_url":"https://api.github.com/repos/UWPCE-PythonCert-ClassRepos/Self_Paced-Online/pulls/579","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/UWPCE-PythonCert-ClassRepos/Self_Paced-Online/pulls/comments/188999191"},"html":{"href":"https://github.com/UWPCE-PythonCert-ClassRepos/Self_Paced-Online/pull/579#discussion_r188999191"},"pull_request":{"href":"https://api.github.com/repos/UWPCE-PythonCert-ClassRepos/Self_Paced-Online/pulls/579"}}},"pull_request":{"url":"https://api.github.com/repos/UWPCE-PythonCert-ClassRepos/Self_Paced-Online/pulls/579","id":188608927,"html_url":"https://github.com/UWPCE-PythonCert-ClassRepos/Self_Paced-Online/pull/579","diff_url":"https://github.com/UWPCE-PythonCert-ClassRepos/Self_Paced-Online/pull/579.diff","patch_url":"https://github.com/UWPCE-PythonCert-ClassRepos/Self_Paced-Online/pull/579.patch","issue_url":"https://api.github.com/repos/UWPCE-PythonCert-ClassRepos/Self_Paced-Online/issues/579","number":579,"state":"open","locked":false,"title":"Updated mailroom.py with OO principles and generated tests","user":{"login":"shibinmathew","id":15223433,"avatar_url":"https://avatars0.githubusercontent.com/u/15223433?v=4","gravatar_id":"","url":"https://api.github.com/users/shibinmathew","html_url":"https://github.com/shibinmathew","followers_url":"https://api.github.com/users/shibinmathew/followers","following_url":"https://api.github.com/users/shibinmathew/following{/other_user}","gists_url":"https://api.github.com/users/shibinmathew/gists{/gist_id}","starred_url":"https://api.github.com/users/shibinmathew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shibinmathew/subscriptions","organizations_url":"https://api.github.com/users/shibinmathew/orgs","repos_url":"https://api.github.com/users/shibinmathew/repos","events_url":"https://api.github.com/users/shibinmathew/events{/privacy}","received_events_url":"https://api.github.com/users/shibinmathew/received_events","type":"User","site_admin":false},"body":"mailroom.py and test_mailroom.py for lesson 9.","created_at":"2018-05-17T02:36:27Z","updated_at":"2018-05-17T15:33:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1c3aeb81f5dd4946b0806bef31307cf45717b826","assignee":{"login":"natasha-aleksandrova","id":1928658,"avatar_url":"https://avatars2.githubusercontent.com/u/1928658?v=4","gravatar_id":"","url":"https://api.github.com/users/natasha-aleksandrova","html_url":"https://github.com/natasha-aleksandrova","followers_url":"https://api.github.com/users/natasha-aleksandrova/followers","following_url":"https://api.github.com/users/natasha-aleksandrova/following{/other_user}","gists_url":"https://api.github.com/users/natasha-aleksandrova/gists{/gist_id}","starred_url":"https://api.github.com/users/natasha-aleksandrova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natasha-aleksandrova/subscriptions","organizations_url":"https://api.github.com/users/natasha-aleksandrova/orgs","repos_url":"https://api.github.com/users/natasha-aleksandrova/repos","events_url":"https://api.github.com/users/natasha-aleksandrova/events{/privacy}","received_events_url":"https://api.github.com/users/natasha-aleksandrova/received_events","type":"User","site_admin":false},"assignees":[{"login":"natasha-aleksandrova","id":1928658,"avatar_url":"https://avatars2.githubusercontent.com/u/1928658?v=4","gravatar_id":"","url":"https://api.github.com/users/natasha-aleksandrova","html_url":"https://github.com/natasha-aleksandrova","followers_url":"https://api.github.com/users/natasha-aleksandrova/followers","following_url":"https://api.github.com/users/natasha-aleksandrova/following{/other_user}","gists_url":"https://api.github.com/users/natasha-aleksandrova/gists{/gist_id}","starred_url":"https://api.github.com/users/natasha-aleksandrova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natasha-aleksandrova/subscriptions","organizations_url":"https://api.github.com/users/natasha-aleksandrova/orgs","repos_url":"https://api.github.com/users/natasha-aleksandrova/repos","events_url":"https://api.github.com/users/natasha-aleksandrova/events{/privacy}","received_events_url":"https://api.github.com/users/natasha-aleksandrova/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/UWPCE-PythonCert-ClassRepos/Self_Paced-Online/pulls/579/commits","review_comments_url":"https://api.github.com/repos/UWPCE-PythonCert-ClassRepos/Self_Paced-Online/pulls/579/comments","review_comment_url":"https://api.github.com/repos/UWPCE-PythonCert-ClassRepos/Self_Paced-Online/pulls/comments{/number}","comments_url":"https://api.github.com/repos/UWPCE-PythonCert-ClassRepos/Self_Paced-Online/issues/579/comments","statuses_url":"https://api.github.com/repos/UWPCE-PythonCert-ClassRepos/Self_Paced-Online/statuses/1074a56e14e68a7f8dbc865d247da8efdd9d0c89","head":{"label":"shibinmathew:master","ref":"master","sha":"1074a56e14e68a7f8dbc865d247da8efdd9d0c89","user":{"login":"shibinmathew","id":15223433,"avatar_url":"https://avatars0.githubusercontent.com/u/15223433?v=4","gravatar_id":"","url":"https://api.github.com/users/shibinmathew","html_url":"https://github.com/shibinmathew","followers_url":"https://api.github.com/users/shibinmathew/followers","following_url":"https://api.github.com/users/shibinmathew/following{/other_user}","gists_url":"https://api.github.com/users/shibinmathew/gists{/gist_id}","starred_url":"https://api.github.com/users/shibinmathew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shibinmathew/subscriptions","organizations_url":"https://api.github.com/users/shibinmathew/orgs","repos_url":"https://api.github.com/users/shibinmathew/repos","events_url":"https://api.github.com/users/shibinmathew/events{/privacy}","received_events_url":"https://api.github.com/users/shibinmathew/received_events","type":"User","site_admin":false},"repo":{"id":119766378,"name":"Self_Paced-Online","full_name":"shibinmathew/Self_Paced-Online","owner":{"login":"shibinmathew","id":15223433,"avatar_url":"https://avatars0.githubusercontent.com/u/15223433?v=4","gravatar_id":"","url":"https://api.github.com/users/shibinmathew","html_url":"https://github.com/shibinmathew","followers_url":"https://api.github.com/users/shibinmathew/followers","following_url":"https://api.github.com/users/shibinmathew/following{/other_user}","gists_url":"https://api.github.com/users/shibinmathew/gists{/gist_id}","starred_url":"https://api.github.com/users/shibinmathew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shibinmathew/subscriptions","organizations_url":"https://api.github.com/users/shibinmathew/orgs","repos_url":"https://api.github.com/users/shibinmathew/repos","events_url":"https://api.github.com/users/shibinmathew/events{/privacy}","received_events_url":"https://api.github.com/users/shibinmathew/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shibinmathew/Self_Paced-Online","description":"Class repository for the self paced online class","fork":true,"url":"https://api.github.com/repos/shibinmathew/Self_Paced-Online","forks_url":"https://api.github.com/repos/shibinmathew/Self_Paced-Online/forks","keys_url":"https://api.github.com/repos/shibinmathew/Self_Paced-Online/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shibinmathew/Self_Paced-Online/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shibinmathew/Self_Paced-Online/teams","hooks_url":"https://api.github.com/repos/shibinmathew/Self_Paced-Online/hooks","issue_events_url":"https://api.github.com/repos/shibinmathew/Self_Paced-Online/issues/events{/number}","events_url":"https://api.github.com/repos/shibinmathew/Self_Paced-Online/events","assignees_url":"https://api.github.com/repos/shibinmathew/Self_Paced-Online/assignees{/user}","branches_url":"https://api.github.com/repos/shibinmathew/Self_Paced-Online/branches{/branch}","tags_url":"https://api.github.com/repos/shibinmathew/Self_Paced-Online/tags","blobs_url":"https://api.github.com/repos/shibinmathew/Self_Paced-Online/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shibinmathew/Self_Paced-Online/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shibinmathew/Self_Paced-Online/git/refs{/sha}","trees_url":"https://api.github.com/repos/shibinmathew/Self_Paced-Online/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shibinmathew/Self_Paced-Online/statuses/{sha}","languages_url":"https://api.github.com/repos/shibinmathew/Self_Paced-Online/languages","stargazers_url":"https://api.github.com/repos/shibinmathew/Self_Paced-Online/stargazers","contributors_url":"https://api.github.com/repos/shibinmathew/Self_Paced-Online/contributors","subscribers_url":"https://api.github.com/repos/shibinmathew/Self_Paced-Online/subscribers","subscription_url":"https://api.github.com/repos/shibinmathew/Self_Paced-Online/subscription","commits_url":"https://api.github.com/repos/shibinmathew/Self_Paced-Online/commits{/sha}","git_commits_url":"https://api.github.com/repos/shibinmathew/Self_Paced-Online/git/commits{/sha}","comments_url":"https://api.github.com/repos/shibinmathew/Self_Paced-Online/comments{/number}","issue_comment_url":"https://api.github.com/repos/shibinmathew/Self_Paced-Online/issues/comments{/number}","contents_url":"https://api.github.com/repos/shibinmathew/Self_Paced-Online/contents/{+path}","compare_url":"https://api.github.com/repos/shibinmathew/Self_Paced-Online/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shibinmathew/Self_Paced-Online/merges","archive_url":"https://api.github.com/repos/shibinmathew/Self_Paced-Online/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shibinmathew/Self_Paced-Online/downloads","issues_url":"https://api.github.com/repos/shibinmathew/Self_Paced-Online/issues{/number}","pulls_url":"https://api.github.com/repos/shibinmathew/Self_Paced-Online/pulls{/number}","milestones_url":"https://api.github.com/repos/shibinmathew/Self_Paced-Online/milestones{/number}","notifications_url":"https://api.github.com/repos/shibinmathew/Self_Paced-Online/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shibinmathew/Self_Paced-Online/labels{/name}","releases_url":"https://api.github.com/repos/shibinmathew/Self_Paced-Online/releases{/id}","deployments_url":"https://api.github.com/repos/shibinmathew/Self_Paced-Online/deployments","created_at":"2018-02-01T01:34:00Z","updated_at":"2018-05-17T02:34:45Z","pushed_at":"2018-05-17T02:34:44Z","git_url":"git://github.com/shibinmathew/Self_Paced-Online.git","ssh_url":"git@github.com:shibinmathew/Self_Paced-Online.git","clone_url":"https://github.com/shibinmathew/Self_Paced-Online.git","svn_url":"https://github.com/shibinmathew/Self_Paced-Online","homepage":null,"size":573,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"UWPCE-PythonCert-ClassRepos:master","ref":"master","sha":"47db5ac7d43c5fbf0a09ccb9456e6b10cad81e44","user":{"login":"UWPCE-PythonCert-ClassRepos","id":34701012,"avatar_url":"https://avatars0.githubusercontent.com/u/34701012?v=4","gravatar_id":"","url":"https://api.github.com/users/UWPCE-PythonCert-ClassRepos","html_url":"https://github.com/UWPCE-PythonCert-ClassRepos","followers_url":"https://api.github.com/users/UWPCE-PythonCert-ClassRepos/followers","following_url":"https://api.github.com/users/UWPCE-PythonCert-ClassRepos/following{/other_user}","gists_url":"https://api.github.com/users/UWPCE-PythonCert-ClassRepos/gists{/gist_id}","starred_url":"https://api.github.com/users/UWPCE-PythonCert-ClassRepos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UWPCE-PythonCert-ClassRepos/subscriptions","organizations_url":"https://api.github.com/users/UWPCE-PythonCert-ClassRepos/orgs","repos_url":"https://api.github.com/users/UWPCE-PythonCert-ClassRepos/repos","events_url":"https://api.github.com/users/UWPCE-PythonCert-ClassRepos/events{/privacy}","received_events_url":"https://api.github.com/users/UWPCE-PythonCert-ClassRepos/received_events","type":"Organization","site_admin":false},"repo":{"id":115212391,"name":"Self_Paced-Online","full_name":"UWPCE-PythonCert-ClassRepos/Self_Paced-Online","owner":{"login":"UWPCE-PythonCert-ClassRepos","id":34701012,"avatar_url":"https://avatars0.githubusercontent.com/u/34701012?v=4","gravatar_id":"","url":"https://api.github.com/users/UWPCE-PythonCert-ClassRepos","html_url":"https://github.com/UWPCE-PythonCert-ClassRepos","followers_url":"https://api.github.com/users/UWPCE-PythonCert-ClassRepos/followers","following_url":"https://api.github.com/users/UWPCE-PythonCert-ClassRepos/following{/other_user}","gists_url":"https://api.github.com/users/UWPCE-PythonCert-ClassRepos/gists{/gist_id}","starred_url":"https://api.github.com/users/UWPCE-PythonCert-ClassRepos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UWPCE-PythonCert-ClassRepos/subscriptions","organizations_url":"https://api.github.com/users/UWPCE-PythonCert-ClassRepos/orgs","repos_url":"https://api.github.com/users/UWPCE-PythonCert-ClassRepos/repos","events_url":"https://api.github.com/users/UWPCE-PythonCert-ClassRepos/events{/privacy}","received_events_url":"https://api.github.com/users/UWPCE-PythonCert-ClassRepos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/UWPCE-PythonCert-ClassRepos/Self_Paced-Online","description":"Course 1 - Class repository for the self paced online class ","fork":false,"url":"https://api.github.com/repos/UWPCE-PythonCert-ClassRepos/Self_Paced-Online","forks_url":"https://api.github.com/repos/UWPCE-PythonCert-ClassRepos/Self_Paced-Online/forks","keys_url":"https://api.github.com/repos/UWPCE-PythonCert-ClassRepos/Self_Paced-Online/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UWPCE-PythonCert-ClassRepos/Self_Paced-Online/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UWPCE-PythonCert-ClassRepos/Self_Paced-Online/teams","hooks_url":"https://api.github.com/repos/UWPCE-PythonCert-ClassRepos/Self_Paced-Online/hooks","issue_events_url":"https://api.github.com/repos/UWPCE-PythonCert-ClassRepos/Self_Paced-Online/issues/events{/number}","events_url":"https://api.github.com/repos/UWPCE-PythonCert-ClassRepos/Self_Paced-Online/events","assignees_url":"https://api.github.com/repos/UWPCE-PythonCert-ClassRepos/Self_Paced-Online/assignees{/user}","branches_url":"https://api.github.com/repos/UWPCE-PythonCert-ClassRepos/Self_Paced-Online/branches{/branch}","tags_url":"https://api.github.com/repos/UWPCE-PythonCert-ClassRepos/Self_Paced-Online/tags","blobs_url":"https://api.github.com/repos/UWPCE-PythonCert-ClassRepos/Self_Paced-Online/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UWPCE-PythonCert-ClassRepos/Self_Paced-Online/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UWPCE-PythonCert-ClassRepos/Self_Paced-Online/git/refs{/sha}","trees_url":"https://api.github.com/repos/UWPCE-PythonCert-ClassRepos/Self_Paced-Online/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UWPCE-PythonCert-ClassRepos/Self_Paced-Online/statuses/{sha}","languages_url":"https://api.github.com/repos/UWPCE-PythonCert-ClassRepos/Self_Paced-Online/languages","stargazers_url":"https://api.github.com/repos/UWPCE-PythonCert-ClassRepos/Self_Paced-Online/stargazers","contributors_url":"https://api.github.com/repos/UWPCE-PythonCert-ClassRepos/Self_Paced-Online/contributors","subscribers_url":"https://api.github.com/repos/UWPCE-PythonCert-ClassRepos/Self_Paced-Online/subscribers","subscription_url":"https://api.github.com/repos/UWPCE-PythonCert-ClassRepos/Self_Paced-Online/subscription","commits_url":"https://api.github.com/repos/UWPCE-PythonCert-ClassRepos/Self_Paced-Online/commits{/sha}","git_commits_url":"https://api.github.com/repos/UWPCE-PythonCert-ClassRepos/Self_Paced-Online/git/commits{/sha}","comments_url":"https://api.github.com/repos/UWPCE-PythonCert-ClassRepos/Self_Paced-Online/comments{/number}","issue_comment_url":"https://api.github.com/repos/UWPCE-PythonCert-ClassRepos/Self_Paced-Online/issues/comments{/number}","contents_url":"https://api.github.com/repos/UWPCE-PythonCert-ClassRepos/Self_Paced-Online/contents/{+path}","compare_url":"https://api.github.com/repos/UWPCE-PythonCert-ClassRepos/Self_Paced-Online/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UWPCE-PythonCert-ClassRepos/Self_Paced-Online/merges","archive_url":"https://api.github.com/repos/UWPCE-PythonCert-ClassRepos/Self_Paced-Online/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UWPCE-PythonCert-ClassRepos/Self_Paced-Online/downloads","issues_url":"https://api.github.com/repos/UWPCE-PythonCert-ClassRepos/Self_Paced-Online/issues{/number}","pulls_url":"https://api.github.com/repos/UWPCE-PythonCert-ClassRepos/Self_Paced-Online/pulls{/number}","milestones_url":"https://api.github.com/repos/UWPCE-PythonCert-ClassRepos/Self_Paced-Online/milestones{/number}","notifications_url":"https://api.github.com/repos/UWPCE-PythonCert-ClassRepos/Self_Paced-Online/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UWPCE-PythonCert-ClassRepos/Self_Paced-Online/labels{/name}","releases_url":"https://api.github.com/repos/UWPCE-PythonCert-ClassRepos/Self_Paced-Online/releases{/id}","deployments_url":"https://api.github.com/repos/UWPCE-PythonCert-ClassRepos/Self_Paced-Online/deployments","created_at":"2017-12-23T17:52:41Z","updated_at":"2018-05-17T00:10:08Z","pushed_at":"2018-05-17T15:12:29Z","git_url":"git://github.com/UWPCE-PythonCert-ClassRepos/Self_Paced-Online.git","ssh_url":"git@github.com:UWPCE-PythonCert-ClassRepos/Self_Paced-Online.git","clone_url":"https://github.com/UWPCE-PythonCert-ClassRepos/Self_Paced-Online.git","svn_url":"https://github.com/UWPCE-PythonCert-ClassRepos/Self_Paced-Online","homepage":"","size":8678,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":66,"mirror_url":null,"archived":false,"open_issues_count":8,"license":null,"forks":66,"open_issues":8,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/UWPCE-PythonCert-ClassRepos/Self_Paced-Online/pulls/579"},"html":{"href":"https://github.com/UWPCE-PythonCert-ClassRepos/Self_Paced-Online/pull/579"},"issue":{"href":"https://api.github.com/repos/UWPCE-PythonCert-ClassRepos/Self_Paced-Online/issues/579"},"comments":{"href":"https://api.github.com/repos/UWPCE-PythonCert-ClassRepos/Self_Paced-Online/issues/579/comments"},"review_comments":{"href":"https://api.github.com/repos/UWPCE-PythonCert-ClassRepos/Self_Paced-Online/pulls/579/comments"},"review_comment":{"href":"https://api.github.com/repos/UWPCE-PythonCert-ClassRepos/Self_Paced-Online/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/UWPCE-PythonCert-ClassRepos/Self_Paced-Online/pulls/579/commits"},"statuses":{"href":"https://api.github.com/repos/UWPCE-PythonCert-ClassRepos/Self_Paced-Online/statuses/1074a56e14e68a7f8dbc865d247da8efdd9d0c89"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"natasha-aleksandrova"}}