{"action":"created","comment":{"url":"https://api.github.com/repos/istio/istio/pulls/comments/179658365","pull_request_review_id":109944600,"id":179658365,"diff_hunk":"@@ -82,9 +84,14 @@ func (configgen *ConfigGeneratorImpl) buildGatewayListeners(env model.Environmen\n \t\t\tlog.Warnf(\"Multiple servers on same port is not supported yet, port %d\", server.Port.Number)\n \t\t\tcontinue\n \t\t}\n+\t\tvar opts buildListenerOpts\n+\t\tvar listenerType plugin.ListenerType\n+\t\tvar networkFilters []listener.Filter\n+\t\tvar hTTPFilters []*http_conn.HttpFilter","path":"pilot/pkg/networking/core/v1alpha3/gateway.go","position":21,"original_position":21,"commit_id":"0140ce0705889cd1dccafb08f65001e8fc5cf072","original_commit_id":"d46b9dddc23988a6e46e6634a08a2455ef8cbb8a","user":{"login":"ostromart","id":30089849,"avatar_url":"https://avatars3.githubusercontent.com/u/30089849?v=4","gravatar_id":"","url":"https://api.github.com/users/ostromart","html_url":"https://github.com/ostromart","followers_url":"https://api.github.com/users/ostromart/followers","following_url":"https://api.github.com/users/ostromart/following{/other_user}","gists_url":"https://api.github.com/users/ostromart/gists{/gist_id}","starred_url":"https://api.github.com/users/ostromart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ostromart/subscriptions","organizations_url":"https://api.github.com/users/ostromart/orgs","repos_url":"https://api.github.com/users/ostromart/repos","events_url":"https://api.github.com/users/ostromart/events{/privacy}","received_events_url":"https://api.github.com/users/ostromart/received_events","type":"User","site_admin":false},"body":"hmm, i wonder if this changed at some point. i could swear i've had to do these silly caps to make some lint check pass. anyway, done.","created_at":"2018-04-06T04:32:47Z","updated_at":"2018-04-06T04:32:47Z","html_url":"https://github.com/istio/istio/pull/4718#discussion_r179658365","pull_request_url":"https://api.github.com/repos/istio/istio/pulls/4718","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/istio/istio/pulls/comments/179658365"},"html":{"href":"https://github.com/istio/istio/pull/4718#discussion_r179658365"},"pull_request":{"href":"https://api.github.com/repos/istio/istio/pulls/4718"}},"in_reply_to_id":179564512},"pull_request":{"url":"https://api.github.com/repos/istio/istio/pulls/4718","id":179240625,"html_url":"https://github.com/istio/istio/pull/4718","diff_url":"https://github.com/istio/istio/pull/4718.diff","patch_url":"https://github.com/istio/istio/pull/4718.patch","issue_url":"https://api.github.com/repos/istio/istio/issues/4718","number":4718,"state":"open","locked":false,"title":"Mixer filter fixes","user":{"login":"ostromart","id":30089849,"avatar_url":"https://avatars3.githubusercontent.com/u/30089849?v=4","gravatar_id":"","url":"https://api.github.com/users/ostromart","html_url":"https://github.com/ostromart","followers_url":"https://api.github.com/users/ostromart/followers","following_url":"https://api.github.com/users/ostromart/following{/other_user}","gists_url":"https://api.github.com/users/ostromart/gists{/gist_id}","starred_url":"https://api.github.com/users/ostromart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ostromart/subscriptions","organizations_url":"https://api.github.com/users/ostromart/orgs","repos_url":"https://api.github.com/users/ostromart/repos","events_url":"https://api.github.com/users/ostromart/events{/privacy}","received_events_url":"https://api.github.com/users/ostromart/received_events","type":"User","site_admin":false},"body":"1. Import some v1 mixer filter code and rewrite in terms of expected v2 envoy format (proto rather than JSON).\r\n2. API change to OnOutboundListener and OnInboundListener. Rather than bundling the filters in a struct, return the filters as a plugin slice. This is more convenient for appending.\r\n3. Various fixes.","created_at":"2018-04-03T22:51:56Z","updated_at":"2018-04-06T04:32:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f600ab4bac5a6b57bce674c5f1e604d5cb8e8454","assignee":null,"assignees":[],"requested_reviewers":[{"login":"costinm","id":84202,"avatar_url":"https://avatars1.githubusercontent.com/u/84202?v=4","gravatar_id":"","url":"https://api.github.com/users/costinm","html_url":"https://github.com/costinm","followers_url":"https://api.github.com/users/costinm/followers","following_url":"https://api.github.com/users/costinm/following{/other_user}","gists_url":"https://api.github.com/users/costinm/gists{/gist_id}","starred_url":"https://api.github.com/users/costinm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/costinm/subscriptions","organizations_url":"https://api.github.com/users/costinm/orgs","repos_url":"https://api.github.com/users/costinm/repos","events_url":"https://api.github.com/users/costinm/events{/privacy}","received_events_url":"https://api.github.com/users/costinm/received_events","type":"User","site_admin":false},{"login":"bianpengyuan","id":34738376,"avatar_url":"https://avatars2.githubusercontent.com/u/34738376?v=4","gravatar_id":"","url":"https://api.github.com/users/bianpengyuan","html_url":"https://github.com/bianpengyuan","followers_url":"https://api.github.com/users/bianpengyuan/followers","following_url":"https://api.github.com/users/bianpengyuan/following{/other_user}","gists_url":"https://api.github.com/users/bianpengyuan/gists{/gist_id}","starred_url":"https://api.github.com/users/bianpengyuan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bianpengyuan/subscriptions","organizations_url":"https://api.github.com/users/bianpengyuan/orgs","repos_url":"https://api.github.com/users/bianpengyuan/repos","events_url":"https://api.github.com/users/bianpengyuan/events{/privacy}","received_events_url":"https://api.github.com/users/bianpengyuan/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":491318011,"url":"https://api.github.com/repos/istio/istio/labels/cla:%20yes","name":"cla: yes","color":"bfdadc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/istio/istio/pulls/4718/commits","review_comments_url":"https://api.github.com/repos/istio/istio/pulls/4718/comments","review_comment_url":"https://api.github.com/repos/istio/istio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/istio/istio/issues/4718/comments","statuses_url":"https://api.github.com/repos/istio/istio/statuses/0140ce0705889cd1dccafb08f65001e8fc5cf072","head":{"label":"ostromart:dev","ref":"dev","sha":"0140ce0705889cd1dccafb08f65001e8fc5cf072","user":{"login":"ostromart","id":30089849,"avatar_url":"https://avatars3.githubusercontent.com/u/30089849?v=4","gravatar_id":"","url":"https://api.github.com/users/ostromart","html_url":"https://github.com/ostromart","followers_url":"https://api.github.com/users/ostromart/followers","following_url":"https://api.github.com/users/ostromart/following{/other_user}","gists_url":"https://api.github.com/users/ostromart/gists{/gist_id}","starred_url":"https://api.github.com/users/ostromart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ostromart/subscriptions","organizations_url":"https://api.github.com/users/ostromart/orgs","repos_url":"https://api.github.com/users/ostromart/repos","events_url":"https://api.github.com/users/ostromart/events{/privacy}","received_events_url":"https://api.github.com/users/ostromart/received_events","type":"User","site_admin":false},"repo":{"id":119454979,"name":"istio","full_name":"ostromart/istio","owner":{"login":"ostromart","id":30089849,"avatar_url":"https://avatars3.githubusercontent.com/u/30089849?v=4","gravatar_id":"","url":"https://api.github.com/users/ostromart","html_url":"https://github.com/ostromart","followers_url":"https://api.github.com/users/ostromart/followers","following_url":"https://api.github.com/users/ostromart/following{/other_user}","gists_url":"https://api.github.com/users/ostromart/gists{/gist_id}","starred_url":"https://api.github.com/users/ostromart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ostromart/subscriptions","organizations_url":"https://api.github.com/users/ostromart/orgs","repos_url":"https://api.github.com/users/ostromart/repos","events_url":"https://api.github.com/users/ostromart/events{/privacy}","received_events_url":"https://api.github.com/users/ostromart/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ostromart/istio","description":"An open platform to connect, manage, and secure microservices.","fork":true,"url":"https://api.github.com/repos/ostromart/istio","forks_url":"https://api.github.com/repos/ostromart/istio/forks","keys_url":"https://api.github.com/repos/ostromart/istio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ostromart/istio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ostromart/istio/teams","hooks_url":"https://api.github.com/repos/ostromart/istio/hooks","issue_events_url":"https://api.github.com/repos/ostromart/istio/issues/events{/number}","events_url":"https://api.github.com/repos/ostromart/istio/events","assignees_url":"https://api.github.com/repos/ostromart/istio/assignees{/user}","branches_url":"https://api.github.com/repos/ostromart/istio/branches{/branch}","tags_url":"https://api.github.com/repos/ostromart/istio/tags","blobs_url":"https://api.github.com/repos/ostromart/istio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ostromart/istio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ostromart/istio/git/refs{/sha}","trees_url":"https://api.github.com/repos/ostromart/istio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ostromart/istio/statuses/{sha}","languages_url":"https://api.github.com/repos/ostromart/istio/languages","stargazers_url":"https://api.github.com/repos/ostromart/istio/stargazers","contributors_url":"https://api.github.com/repos/ostromart/istio/contributors","subscribers_url":"https://api.github.com/repos/ostromart/istio/subscribers","subscription_url":"https://api.github.com/repos/ostromart/istio/subscription","commits_url":"https://api.github.com/repos/ostromart/istio/commits{/sha}","git_commits_url":"https://api.github.com/repos/ostromart/istio/git/commits{/sha}","comments_url":"https://api.github.com/repos/ostromart/istio/comments{/number}","issue_comment_url":"https://api.github.com/repos/ostromart/istio/issues/comments{/number}","contents_url":"https://api.github.com/repos/ostromart/istio/contents/{+path}","compare_url":"https://api.github.com/repos/ostromart/istio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ostromart/istio/merges","archive_url":"https://api.github.com/repos/ostromart/istio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ostromart/istio/downloads","issues_url":"https://api.github.com/repos/ostromart/istio/issues{/number}","pulls_url":"https://api.github.com/repos/ostromart/istio/pulls{/number}","milestones_url":"https://api.github.com/repos/ostromart/istio/milestones{/number}","notifications_url":"https://api.github.com/repos/ostromart/istio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ostromart/istio/labels{/name}","releases_url":"https://api.github.com/repos/ostromart/istio/releases{/id}","deployments_url":"https://api.github.com/repos/ostromart/istio/deployments","created_at":"2018-01-29T23:24:42Z","updated_at":"2018-04-04T20:23:37Z","pushed_at":"2018-04-06T04:30:26Z","git_url":"git://github.com/ostromart/istio.git","ssh_url":"git@github.com:ostromart/istio.git","clone_url":"https://github.com/ostromart/istio.git","svn_url":"https://github.com/ostromart/istio","homepage":"https://istio.io","size":19212,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":5,"license":null,"forks":0,"open_issues":5,"watchers":0,"default_branch":"master"}},"base":{"label":"istio:master","ref":"master","sha":"9cf6e72bc5ce74caddde1f1a95e9dd333733467e","user":{"login":"istio","id":23534644,"avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"repo":{"id":74175805,"name":"istio","full_name":"istio/istio","owner":{"login":"istio","id":23534644,"avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/istio/istio","description":"An open platform to connect, manage, and secure microservices.","fork":false,"url":"https://api.github.com/repos/istio/istio","forks_url":"https://api.github.com/repos/istio/istio/forks","keys_url":"https://api.github.com/repos/istio/istio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/istio/istio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/istio/istio/teams","hooks_url":"https://api.github.com/repos/istio/istio/hooks","issue_events_url":"https://api.github.com/repos/istio/istio/issues/events{/number}","events_url":"https://api.github.com/repos/istio/istio/events","assignees_url":"https://api.github.com/repos/istio/istio/assignees{/user}","branches_url":"https://api.github.com/repos/istio/istio/branches{/branch}","tags_url":"https://api.github.com/repos/istio/istio/tags","blobs_url":"https://api.github.com/repos/istio/istio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/istio/istio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/istio/istio/git/refs{/sha}","trees_url":"https://api.github.com/repos/istio/istio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/istio/istio/statuses/{sha}","languages_url":"https://api.github.com/repos/istio/istio/languages","stargazers_url":"https://api.github.com/repos/istio/istio/stargazers","contributors_url":"https://api.github.com/repos/istio/istio/contributors","subscribers_url":"https://api.github.com/repos/istio/istio/subscribers","subscription_url":"https://api.github.com/repos/istio/istio/subscription","commits_url":"https://api.github.com/repos/istio/istio/commits{/sha}","git_commits_url":"https://api.github.com/repos/istio/istio/git/commits{/sha}","comments_url":"https://api.github.com/repos/istio/istio/comments{/number}","issue_comment_url":"https://api.github.com/repos/istio/istio/issues/comments{/number}","contents_url":"https://api.github.com/repos/istio/istio/contents/{+path}","compare_url":"https://api.github.com/repos/istio/istio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/istio/istio/merges","archive_url":"https://api.github.com/repos/istio/istio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/istio/istio/downloads","issues_url":"https://api.github.com/repos/istio/istio/issues{/number}","pulls_url":"https://api.github.com/repos/istio/istio/pulls{/number}","milestones_url":"https://api.github.com/repos/istio/istio/milestones{/number}","notifications_url":"https://api.github.com/repos/istio/istio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/istio/istio/labels{/name}","releases_url":"https://api.github.com/repos/istio/istio/releases{/id}","deployments_url":"https://api.github.com/repos/istio/istio/deployments","created_at":"2016-11-18T23:57:21Z","updated_at":"2018-04-06T03:03:46Z","pushed_at":"2018-04-06T04:30:28Z","git_url":"git://github.com/istio/istio.git","ssh_url":"git@github.com:istio/istio.git","clone_url":"https://github.com/istio/istio.git","svn_url":"https://github.com/istio/istio","homepage":"https://istio.io","size":19342,"stargazers_count":7041,"watchers_count":7041,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":915,"mirror_url":null,"archived":false,"open_issues_count":821,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":915,"open_issues":821,"watchers":7041,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/istio/istio/pulls/4718"},"html":{"href":"https://github.com/istio/istio/pull/4718"},"issue":{"href":"https://api.github.com/repos/istio/istio/issues/4718"},"comments":{"href":"https://api.github.com/repos/istio/istio/issues/4718/comments"},"review_comments":{"href":"https://api.github.com/repos/istio/istio/pulls/4718/comments"},"review_comment":{"href":"https://api.github.com/repos/istio/istio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/istio/istio/pulls/4718/commits"},"statuses":{"href":"https://api.github.com/repos/istio/istio/statuses/0140ce0705889cd1dccafb08f65001e8fc5cf072"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ostromart"}}