{"action":"created","issue":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/20746","repository_url":"https://api.github.com/repos/joomla/joomla-cms","labels_url":"https://api.github.com/repos/joomla/joomla-cms/issues/20746/labels{/name}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/20746/comments","events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/20746/events","html_url":"https://github.com/joomla/joomla-cms/pull/20746","id":332247388,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0Nzc1NDgy","number":20746,"title":"Better mode autoloading.","user":{"login":"okonomiyaki3000","id":79470,"node_id":"MDQ6VXNlcjc5NDcw","avatar_url":"https://avatars3.githubusercontent.com/u/79470?v=4","gravatar_id":"","url":"https://api.github.com/users/okonomiyaki3000","html_url":"https://github.com/okonomiyaki3000","followers_url":"https://api.github.com/users/okonomiyaki3000/followers","following_url":"https://api.github.com/users/okonomiyaki3000/following{/other_user}","gists_url":"https://api.github.com/users/okonomiyaki3000/gists{/gist_id}","starred_url":"https://api.github.com/users/okonomiyaki3000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/okonomiyaki3000/subscriptions","organizations_url":"https://api.github.com/users/okonomiyaki3000/orgs","repos_url":"https://api.github.com/users/okonomiyaki3000/repos","events_url":"https://api.github.com/users/okonomiyaki3000/events{/privacy}","received_events_url":"https://api.github.com/users/okonomiyaki3000/received_events","type":"User","site_admin":false},"labels":[{"id":60721348,"node_id":"MDU6TGFiZWw2MDcyMTM0OA==","url":"https://api.github.com/repos/joomla/joomla-cms/labels/PR-staging","name":"PR-staging","color":"c7def8","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-06-14T04:25:08Z","updated_at":"2018-06-16T09:17:22Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/20746","html_url":"https://github.com/joomla/joomla-cms/pull/20746","diff_url":"https://github.com/joomla/joomla-cms/pull/20746.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/20746.patch"},"body":"### Summary of Changes\r\n\r\nImprovement to editor mode autoselection.\r\nShould now find the correct mode whether the option is set to a mode's name, mime-type, or extension.\r\nSetting the mode is also improved, especially for php mode. \r\n\r\n### Testing Instructions\r\n\r\nUse codemirror. Open as many document types as possible.\r\nEspecially try testing PHP documents before and after applying the patch.\r\n\r\n### Expected result\r\n\r\nMode should be selected correctly so that syntax highlighting and other mode-specific features should work normally.\r\n\r\n### Actual result\r\n\r\nBefore this change there is a problem with PHP documents. If they contain HTML sections, it will not be highlighted properly and features such as tag autoclosing will not work.\r\n\r\nAfter this change, all is well.\r\n\r\n### Documentation Changes Required\r\n\r\nNope."},"comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments/397799863","html_url":"https://github.com/joomla/joomla-cms/pull/20746#issuecomment-397799863","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/20746","id":397799863,"node_id":"MDEyOklzc3VlQ29tbWVudDM5Nzc5OTg2Mw==","user":{"login":"franz-wohlkoenig","id":8235763,"node_id":"MDQ6VXNlcjgyMzU3NjM=","avatar_url":"https://avatars1.githubusercontent.com/u/8235763?v=4","gravatar_id":"","url":"https://api.github.com/users/franz-wohlkoenig","html_url":"https://github.com/franz-wohlkoenig","followers_url":"https://api.github.com/users/franz-wohlkoenig/followers","following_url":"https://api.github.com/users/franz-wohlkoenig/following{/other_user}","gists_url":"https://api.github.com/users/franz-wohlkoenig/gists{/gist_id}","starred_url":"https://api.github.com/users/franz-wohlkoenig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/franz-wohlkoenig/subscriptions","organizations_url":"https://api.github.com/users/franz-wohlkoenig/orgs","repos_url":"https://api.github.com/users/franz-wohlkoenig/repos","events_url":"https://api.github.com/users/franz-wohlkoenig/events{/privacy}","received_events_url":"https://api.github.com/users/franz-wohlkoenig/received_events","type":"User","site_admin":false},"created_at":"2018-06-16T09:17:22Z","updated_at":"2018-06-16T09:17:22Z","author_association":"NONE","body":"can this PR be tested as Appveyor failes?<hr /><sub>This comment was created with the <a href=\"https://github.com/joomla/jissues\">J!Tracker Application</a> at <a href=\"https://issues.joomla.org/tracker/joomla-cms/20746\">issues.joomla.org/tracker/joomla-cms/20746</a>.</sub>"}}
{"actor":{"display_login":"franz-wohlkoenig"}}