{"action":"created","comment":{"url":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/comments/191503641","pull_request_review_id":124088291,"id":191503641,"diff_hunk":"@@ -76,12 +81,26 @@ spec:\n               key: registry-admin-password\n         - name: EUREKA_CLIENT_SERVICE_URL_DEFAULTZONE\n           value: http://admin:${jhipster.registry.password}@jhipster-registry.<%= kubernetesNamespace %>.svc.cluster.local:8761/eureka/\n+          <%_ if (app.istioSupportOpt !== 'no') { _%>\n+        - name: EUREKA_INSTANCE_PREFER_IP_ADDRESS\n+          value: \"false\"\n+        - name: EUREKA_INSTANCE_HOSTNAME\n+          value: <%= app.baseName.toLowerCase() %>\n+          <%_ } _%>\n         <%_ } _%>\n         <%_ if (app.serviceDiscoveryType === 'consul') { _%>\n         - name: SPRING_CLOUD_CONSUL_HOST\n           value: consul.<%= kubernetesNamespace %>.svc.cluster.local\n         - name: SPRING_CLOUD_CONSUL_PORT\n           value: \"8500\"\n+          <%_ if (app.istioSupportOpt !== 'no') { _%>\n+        - name: SPRING_CLOUD_CONSUL_DISCOVERY_PREFER_IP_ADDRESS\n+          value: \"false\"\n+        - name: SPRING_CLOUD_CONSUL_DISCOVERY_HOSTNAME\n+          value: <%= app.baseName.toLowerCase() %>\n+        - name: SPRING_CLOUD_CONSUL_DISCOVERY_SERVICE_NAME\n+          value: <%= app.baseName.toLowerCase() %>\n+          <%_ } _%>","path":"generators/kubernetes/templates/deployment.yml.ejs","position":47,"original_position":47,"commit_id":"c7e87df759585e4540d6039eb0b7c359529befdf","original_commit_id":"118773fecb5c4344cab207376657f0b185e1d658","user":{"login":"srinivasa-vasu","id":20539215,"avatar_url":"https://avatars1.githubusercontent.com/u/20539215?v=4","gravatar_id":"","url":"https://api.github.com/users/srinivasa-vasu","html_url":"https://github.com/srinivasa-vasu","followers_url":"https://api.github.com/users/srinivasa-vasu/followers","following_url":"https://api.github.com/users/srinivasa-vasu/following{/other_user}","gists_url":"https://api.github.com/users/srinivasa-vasu/gists{/gist_id}","starred_url":"https://api.github.com/users/srinivasa-vasu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srinivasa-vasu/subscriptions","organizations_url":"https://api.github.com/users/srinivasa-vasu/orgs","repos_url":"https://api.github.com/users/srinivasa-vasu/repos","events_url":"https://api.github.com/users/srinivasa-vasu/events{/privacy}","received_events_url":"https://api.github.com/users/srinivasa-vasu/received_events","type":"User","site_admin":false},"body":"@saturnism done!","created_at":"2018-05-29T17:13:01Z","updated_at":"2018-05-29T17:13:01Z","html_url":"https://github.com/jhipster/generator-jhipster/pull/7697#discussion_r191503641","pull_request_url":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/7697","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/comments/191503641"},"html":{"href":"https://github.com/jhipster/generator-jhipster/pull/7697#discussion_r191503641"},"pull_request":{"href":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/7697"}},"in_reply_to_id":191289275},"pull_request":{"url":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/7697","id":190966230,"html_url":"https://github.com/jhipster/generator-jhipster/pull/7697","diff_url":"https://github.com/jhipster/generator-jhipster/pull/7697.diff","patch_url":"https://github.com/jhipster/generator-jhipster/pull/7697.patch","issue_url":"https://api.github.com/repos/jhipster/generator-jhipster/issues/7697","number":7697,"state":"open","locked":false,"title":"Istio - intial commit","user":{"login":"srinivasa-vasu","id":20539215,"avatar_url":"https://avatars1.githubusercontent.com/u/20539215?v=4","gravatar_id":"","url":"https://api.github.com/users/srinivasa-vasu","html_url":"https://github.com/srinivasa-vasu","followers_url":"https://api.github.com/users/srinivasa-vasu/followers","following_url":"https://api.github.com/users/srinivasa-vasu/following{/other_user}","gists_url":"https://api.github.com/users/srinivasa-vasu/gists{/gist_id}","starred_url":"https://api.github.com/users/srinivasa-vasu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srinivasa-vasu/subscriptions","organizations_url":"https://api.github.com/users/srinivasa-vasu/orgs","repos_url":"https://api.github.com/users/srinivasa-vasu/repos","events_url":"https://api.github.com/users/srinivasa-vasu/events{/privacy}","received_events_url":"https://api.github.com/users/srinivasa-vasu/received_events","type":"User","site_admin":false},"body":"#7337 \r\n- tested with both eureka and consul\r\n- included routerule and destinationpolicy rules\r\nThis is with minimal change to the existing code base. We can slowly introduce more features to it and over the period of time redundant components can be decoupled.\r\n","created_at":"2018-05-28T16:28:56Z","updated_at":"2018-05-29T17:13:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"128cbe8c08942ef3db9f438ca1a5dba46875addf","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/7697/commits","review_comments_url":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/7697/comments","review_comment_url":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jhipster/generator-jhipster/issues/7697/comments","statuses_url":"https://api.github.com/repos/jhipster/generator-jhipster/statuses/c7e87df759585e4540d6039eb0b7c359529befdf","head":{"label":"srinivasa-vasu:k8s_istio_v0.1","ref":"k8s_istio_v0.1","sha":"c7e87df759585e4540d6039eb0b7c359529befdf","user":{"login":"srinivasa-vasu","id":20539215,"avatar_url":"https://avatars1.githubusercontent.com/u/20539215?v=4","gravatar_id":"","url":"https://api.github.com/users/srinivasa-vasu","html_url":"https://github.com/srinivasa-vasu","followers_url":"https://api.github.com/users/srinivasa-vasu/followers","following_url":"https://api.github.com/users/srinivasa-vasu/following{/other_user}","gists_url":"https://api.github.com/users/srinivasa-vasu/gists{/gist_id}","starred_url":"https://api.github.com/users/srinivasa-vasu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srinivasa-vasu/subscriptions","organizations_url":"https://api.github.com/users/srinivasa-vasu/orgs","repos_url":"https://api.github.com/users/srinivasa-vasu/repos","events_url":"https://api.github.com/users/srinivasa-vasu/events{/privacy}","received_events_url":"https://api.github.com/users/srinivasa-vasu/received_events","type":"User","site_admin":false},"repo":{"id":89149304,"name":"generator-jhipster","full_name":"srinivasa-vasu/generator-jhipster","owner":{"login":"srinivasa-vasu","id":20539215,"avatar_url":"https://avatars1.githubusercontent.com/u/20539215?v=4","gravatar_id":"","url":"https://api.github.com/users/srinivasa-vasu","html_url":"https://github.com/srinivasa-vasu","followers_url":"https://api.github.com/users/srinivasa-vasu/followers","following_url":"https://api.github.com/users/srinivasa-vasu/following{/other_user}","gists_url":"https://api.github.com/users/srinivasa-vasu/gists{/gist_id}","starred_url":"https://api.github.com/users/srinivasa-vasu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srinivasa-vasu/subscriptions","organizations_url":"https://api.github.com/users/srinivasa-vasu/orgs","repos_url":"https://api.github.com/users/srinivasa-vasu/repos","events_url":"https://api.github.com/users/srinivasa-vasu/events{/privacy}","received_events_url":"https://api.github.com/users/srinivasa-vasu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/srinivasa-vasu/generator-jhipster","description":"Open Source application generator for creating Spring Boot + Angular projects in seconds!","fork":true,"url":"https://api.github.com/repos/srinivasa-vasu/generator-jhipster","forks_url":"https://api.github.com/repos/srinivasa-vasu/generator-jhipster/forks","keys_url":"https://api.github.com/repos/srinivasa-vasu/generator-jhipster/keys{/key_id}","collaborators_url":"https://api.github.com/repos/srinivasa-vasu/generator-jhipster/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/srinivasa-vasu/generator-jhipster/teams","hooks_url":"https://api.github.com/repos/srinivasa-vasu/generator-jhipster/hooks","issue_events_url":"https://api.github.com/repos/srinivasa-vasu/generator-jhipster/issues/events{/number}","events_url":"https://api.github.com/repos/srinivasa-vasu/generator-jhipster/events","assignees_url":"https://api.github.com/repos/srinivasa-vasu/generator-jhipster/assignees{/user}","branches_url":"https://api.github.com/repos/srinivasa-vasu/generator-jhipster/branches{/branch}","tags_url":"https://api.github.com/repos/srinivasa-vasu/generator-jhipster/tags","blobs_url":"https://api.github.com/repos/srinivasa-vasu/generator-jhipster/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/srinivasa-vasu/generator-jhipster/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/srinivasa-vasu/generator-jhipster/git/refs{/sha}","trees_url":"https://api.github.com/repos/srinivasa-vasu/generator-jhipster/git/trees{/sha}","statuses_url":"https://api.github.com/repos/srinivasa-vasu/generator-jhipster/statuses/{sha}","languages_url":"https://api.github.com/repos/srinivasa-vasu/generator-jhipster/languages","stargazers_url":"https://api.github.com/repos/srinivasa-vasu/generator-jhipster/stargazers","contributors_url":"https://api.github.com/repos/srinivasa-vasu/generator-jhipster/contributors","subscribers_url":"https://api.github.com/repos/srinivasa-vasu/generator-jhipster/subscribers","subscription_url":"https://api.github.com/repos/srinivasa-vasu/generator-jhipster/subscription","commits_url":"https://api.github.com/repos/srinivasa-vasu/generator-jhipster/commits{/sha}","git_commits_url":"https://api.github.com/repos/srinivasa-vasu/generator-jhipster/git/commits{/sha}","comments_url":"https://api.github.com/repos/srinivasa-vasu/generator-jhipster/comments{/number}","issue_comment_url":"https://api.github.com/repos/srinivasa-vasu/generator-jhipster/issues/comments{/number}","contents_url":"https://api.github.com/repos/srinivasa-vasu/generator-jhipster/contents/{+path}","compare_url":"https://api.github.com/repos/srinivasa-vasu/generator-jhipster/compare/{base}...{head}","merges_url":"https://api.github.com/repos/srinivasa-vasu/generator-jhipster/merges","archive_url":"https://api.github.com/repos/srinivasa-vasu/generator-jhipster/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/srinivasa-vasu/generator-jhipster/downloads","issues_url":"https://api.github.com/repos/srinivasa-vasu/generator-jhipster/issues{/number}","pulls_url":"https://api.github.com/repos/srinivasa-vasu/generator-jhipster/pulls{/number}","milestones_url":"https://api.github.com/repos/srinivasa-vasu/generator-jhipster/milestones{/number}","notifications_url":"https://api.github.com/repos/srinivasa-vasu/generator-jhipster/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/srinivasa-vasu/generator-jhipster/labels{/name}","releases_url":"https://api.github.com/repos/srinivasa-vasu/generator-jhipster/releases{/id}","deployments_url":"https://api.github.com/repos/srinivasa-vasu/generator-jhipster/deployments","created_at":"2017-04-23T14:49:04Z","updated_at":"2017-04-23T14:49:10Z","pushed_at":"2018-05-29T17:12:28Z","git_url":"git://github.com/srinivasa-vasu/generator-jhipster.git","ssh_url":"git@github.com:srinivasa-vasu/generator-jhipster.git","clone_url":"https://github.com/srinivasa-vasu/generator-jhipster.git","svn_url":"https://github.com/srinivasa-vasu/generator-jhipster","homepage":"http://jhipster.github.io","size":30956,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jhipster:master","ref":"master","sha":"68244ea6faa8dba9dcf06d1c65ea67445769e7b3","user":{"login":"jhipster","id":6059488,"avatar_url":"https://avatars3.githubusercontent.com/u/6059488?v=4","gravatar_id":"","url":"https://api.github.com/users/jhipster","html_url":"https://github.com/jhipster","followers_url":"https://api.github.com/users/jhipster/followers","following_url":"https://api.github.com/users/jhipster/following{/other_user}","gists_url":"https://api.github.com/users/jhipster/gists{/gist_id}","starred_url":"https://api.github.com/users/jhipster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhipster/subscriptions","organizations_url":"https://api.github.com/users/jhipster/orgs","repos_url":"https://api.github.com/users/jhipster/repos","events_url":"https://api.github.com/users/jhipster/events{/privacy}","received_events_url":"https://api.github.com/users/jhipster/received_events","type":"Organization","site_admin":false},"repo":{"id":13753636,"name":"generator-jhipster","full_name":"jhipster/generator-jhipster","owner":{"login":"jhipster","id":6059488,"avatar_url":"https://avatars3.githubusercontent.com/u/6059488?v=4","gravatar_id":"","url":"https://api.github.com/users/jhipster","html_url":"https://github.com/jhipster","followers_url":"https://api.github.com/users/jhipster/followers","following_url":"https://api.github.com/users/jhipster/following{/other_user}","gists_url":"https://api.github.com/users/jhipster/gists{/gist_id}","starred_url":"https://api.github.com/users/jhipster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhipster/subscriptions","organizations_url":"https://api.github.com/users/jhipster/orgs","repos_url":"https://api.github.com/users/jhipster/repos","events_url":"https://api.github.com/users/jhipster/events{/privacy}","received_events_url":"https://api.github.com/users/jhipster/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jhipster/generator-jhipster","description":"Open Source application generator for creating Spring Boot + Angular/React projects in seconds!","fork":false,"url":"https://api.github.com/repos/jhipster/generator-jhipster","forks_url":"https://api.github.com/repos/jhipster/generator-jhipster/forks","keys_url":"https://api.github.com/repos/jhipster/generator-jhipster/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jhipster/generator-jhipster/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jhipster/generator-jhipster/teams","hooks_url":"https://api.github.com/repos/jhipster/generator-jhipster/hooks","issue_events_url":"https://api.github.com/repos/jhipster/generator-jhipster/issues/events{/number}","events_url":"https://api.github.com/repos/jhipster/generator-jhipster/events","assignees_url":"https://api.github.com/repos/jhipster/generator-jhipster/assignees{/user}","branches_url":"https://api.github.com/repos/jhipster/generator-jhipster/branches{/branch}","tags_url":"https://api.github.com/repos/jhipster/generator-jhipster/tags","blobs_url":"https://api.github.com/repos/jhipster/generator-jhipster/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jhipster/generator-jhipster/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jhipster/generator-jhipster/git/refs{/sha}","trees_url":"https://api.github.com/repos/jhipster/generator-jhipster/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jhipster/generator-jhipster/statuses/{sha}","languages_url":"https://api.github.com/repos/jhipster/generator-jhipster/languages","stargazers_url":"https://api.github.com/repos/jhipster/generator-jhipster/stargazers","contributors_url":"https://api.github.com/repos/jhipster/generator-jhipster/contributors","subscribers_url":"https://api.github.com/repos/jhipster/generator-jhipster/subscribers","subscription_url":"https://api.github.com/repos/jhipster/generator-jhipster/subscription","commits_url":"https://api.github.com/repos/jhipster/generator-jhipster/commits{/sha}","git_commits_url":"https://api.github.com/repos/jhipster/generator-jhipster/git/commits{/sha}","comments_url":"https://api.github.com/repos/jhipster/generator-jhipster/comments{/number}","issue_comment_url":"https://api.github.com/repos/jhipster/generator-jhipster/issues/comments{/number}","contents_url":"https://api.github.com/repos/jhipster/generator-jhipster/contents/{+path}","compare_url":"https://api.github.com/repos/jhipster/generator-jhipster/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jhipster/generator-jhipster/merges","archive_url":"https://api.github.com/repos/jhipster/generator-jhipster/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jhipster/generator-jhipster/downloads","issues_url":"https://api.github.com/repos/jhipster/generator-jhipster/issues{/number}","pulls_url":"https://api.github.com/repos/jhipster/generator-jhipster/pulls{/number}","milestones_url":"https://api.github.com/repos/jhipster/generator-jhipster/milestones{/number}","notifications_url":"https://api.github.com/repos/jhipster/generator-jhipster/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jhipster/generator-jhipster/labels{/name}","releases_url":"https://api.github.com/repos/jhipster/generator-jhipster/releases{/id}","deployments_url":"https://api.github.com/repos/jhipster/generator-jhipster/deployments","created_at":"2013-10-21T20:07:22Z","updated_at":"2018-05-29T14:16:33Z","pushed_at":"2018-05-29T17:12:30Z","git_url":"git://github.com/jhipster/generator-jhipster.git","ssh_url":"git@github.com:jhipster/generator-jhipster.git","clone_url":"https://github.com/jhipster/generator-jhipster.git","svn_url":"https://github.com/jhipster/generator-jhipster","homepage":"https://www.jhipster.tech","size":31200,"stargazers_count":10546,"watchers_count":10546,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2265,"mirror_url":null,"archived":false,"open_issues_count":47,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":2265,"open_issues":47,"watchers":10546,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/7697"},"html":{"href":"https://github.com/jhipster/generator-jhipster/pull/7697"},"issue":{"href":"https://api.github.com/repos/jhipster/generator-jhipster/issues/7697"},"comments":{"href":"https://api.github.com/repos/jhipster/generator-jhipster/issues/7697/comments"},"review_comments":{"href":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/7697/comments"},"review_comment":{"href":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jhipster/generator-jhipster/pulls/7697/commits"},"statuses":{"href":"https://api.github.com/repos/jhipster/generator-jhipster/statuses/c7e87df759585e4540d6039eb0b7c359529befdf"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"srinivasa-vasu"}}