{"action":"created","issue":{"url":"https://api.github.com/repos/Azure/kubernetes-keyvault-flexvol/issues/49","repository_url":"https://api.github.com/repos/Azure/kubernetes-keyvault-flexvol","labels_url":"https://api.github.com/repos/Azure/kubernetes-keyvault-flexvol/issues/49/labels{/name}","comments_url":"https://api.github.com/repos/Azure/kubernetes-keyvault-flexvol/issues/49/comments","events_url":"https://api.github.com/repos/Azure/kubernetes-keyvault-flexvol/issues/49/events","html_url":"https://github.com/Azure/kubernetes-keyvault-flexvol/pull/49","id":384114172,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzMzk3NjU4","number":49,"title":"Feature/support multiple secrets","user":{"login":"idanlevin","id":5193170,"node_id":"MDQ6VXNlcjUxOTMxNzA=","avatar_url":"https://avatars3.githubusercontent.com/u/5193170?v=4","gravatar_id":"","url":"https://api.github.com/users/idanlevin","html_url":"https://github.com/idanlevin","followers_url":"https://api.github.com/users/idanlevin/followers","following_url":"https://api.github.com/users/idanlevin/following{/other_user}","gists_url":"https://api.github.com/users/idanlevin/gists{/gist_id}","starred_url":"https://api.github.com/users/idanlevin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/idanlevin/subscriptions","organizations_url":"https://api.github.com/users/idanlevin/orgs","repos_url":"https://api.github.com/users/idanlevin/repos","events_url":"https://api.github.com/users/idanlevin/events{/privacy}","received_events_url":"https://api.github.com/users/idanlevin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-11-25T20:17:32Z","updated_at":"2018-11-26T02:29:38Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/Azure/kubernetes-keyvault-flexvol/pulls/49","html_url":"https://github.com/Azure/kubernetes-keyvault-flexvol/pull/49","diff_url":"https://github.com/Azure/kubernetes-keyvault-flexvol/pull/49.diff","patch_url":"https://github.com/Azure/kubernetes-keyvault-flexvol/pull/49.patch"},"body":"this is a best-effort implementation of multiple secrets, I wanted to do it nicer by allowing the user to create an array of objects but it turns out the `flexVolume` `options` only support strings, so I ended up going with a semi-colon separated list of objects\r\n\r\nI don't have access to `mcr.microsoft.com/k8s/flexvolume` so I replaced it with my personal Dockerhub until fixed\r\n\r\n\r\nfixes this: https://github.com/Azure/kubernetes-keyvault-flexvol/issues/37"},"comment":{"url":"https://api.github.com/repos/Azure/kubernetes-keyvault-flexvol/issues/comments/441501021","html_url":"https://github.com/Azure/kubernetes-keyvault-flexvol/pull/49#issuecomment-441501021","issue_url":"https://api.github.com/repos/Azure/kubernetes-keyvault-flexvol/issues/49","id":441501021,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MTUwMTAyMQ==","user":{"login":"ritazh","id":1856066,"node_id":"MDQ6VXNlcjE4NTYwNjY=","avatar_url":"https://avatars2.githubusercontent.com/u/1856066?v=4","gravatar_id":"","url":"https://api.github.com/users/ritazh","html_url":"https://github.com/ritazh","followers_url":"https://api.github.com/users/ritazh/followers","following_url":"https://api.github.com/users/ritazh/following{/other_user}","gists_url":"https://api.github.com/users/ritazh/gists{/gist_id}","starred_url":"https://api.github.com/users/ritazh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ritazh/subscriptions","organizations_url":"https://api.github.com/users/ritazh/orgs","repos_url":"https://api.github.com/users/ritazh/repos","events_url":"https://api.github.com/users/ritazh/events{/privacy}","received_events_url":"https://api.github.com/users/ritazh/received_events","type":"User","site_admin":false},"created_at":"2018-11-26T02:29:38Z","updated_at":"2018-11-26T02:29:38Z","author_association":"MEMBER","body":"@idanlevin Thank you for your contribution! 👏 Just reviewed and tested the code. Overall, this looks great. One concern is going from`keyvaultobjectname` to `keyvaultobjectnames` is a breaking change for existing users. We need to support but deprecate`keyvaultobjectname`, `keyvaultobjecttype`, and `keyvaultobjectversion` for at least few more releases before removing them altogether.  "}}
{"actor":{"display_login":"ritazh"}}