{"action":"created","issue":{"url":"https://api.github.com/repos/drugdata/D3R/issues/189","repository_url":"https://api.github.com/repos/drugdata/D3R","labels_url":"https://api.github.com/repos/drugdata/D3R/issues/189/labels{/name}","comments_url":"https://api.github.com/repos/drugdata/D3R/issues/189/comments","events_url":"https://api.github.com/repos/drugdata/D3R/issues/189/events","html_url":"https://github.com/drugdata/D3R/issues/189","id":350957797,"node_id":"MDU6SXNzdWUzNTA5NTc3OTc=","number":189,"title":"Bug in evaluate.wait_and_check() causes evaluation to prematurely give up on alignment","user":{"login":"coleslaw481","id":655940,"node_id":"MDQ6VXNlcjY1NTk0MA==","avatar_url":"https://avatars2.githubusercontent.com/u/655940?v=4","gravatar_id":"","url":"https://api.github.com/users/coleslaw481","html_url":"https://github.com/coleslaw481","followers_url":"https://api.github.com/users/coleslaw481/followers","following_url":"https://api.github.com/users/coleslaw481/following{/other_user}","gists_url":"https://api.github.com/users/coleslaw481/gists{/gist_id}","starred_url":"https://api.github.com/users/coleslaw481/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coleslaw481/subscriptions","organizations_url":"https://api.github.com/users/coleslaw481/orgs","repos_url":"https://api.github.com/users/coleslaw481/repos","events_url":"https://api.github.com/users/coleslaw481/events{/privacy}","received_events_url":"https://api.github.com/users/coleslaw481/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"coleslaw481","id":655940,"node_id":"MDQ6VXNlcjY1NTk0MA==","avatar_url":"https://avatars2.githubusercontent.com/u/655940?v=4","gravatar_id":"","url":"https://api.github.com/users/coleslaw481","html_url":"https://github.com/coleslaw481","followers_url":"https://api.github.com/users/coleslaw481/followers","following_url":"https://api.github.com/users/coleslaw481/following{/other_user}","gists_url":"https://api.github.com/users/coleslaw481/gists{/gist_id}","starred_url":"https://api.github.com/users/coleslaw481/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coleslaw481/subscriptions","organizations_url":"https://api.github.com/users/coleslaw481/orgs","repos_url":"https://api.github.com/users/coleslaw481/repos","events_url":"https://api.github.com/users/coleslaw481/events{/privacy}","received_events_url":"https://api.github.com/users/coleslaw481/received_events","type":"User","site_admin":false},"assignees":[{"login":"coleslaw481","id":655940,"node_id":"MDQ6VXNlcjY1NTk0MA==","avatar_url":"https://avatars2.githubusercontent.com/u/655940?v=4","gravatar_id":"","url":"https://api.github.com/users/coleslaw481","html_url":"https://github.com/coleslaw481","followers_url":"https://api.github.com/users/coleslaw481/followers","following_url":"https://api.github.com/users/coleslaw481/following{/other_user}","gists_url":"https://api.github.com/users/coleslaw481/gists{/gist_id}","starred_url":"https://api.github.com/users/coleslaw481/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coleslaw481/subscriptions","organizations_url":"https://api.github.com/users/coleslaw481/orgs","repos_url":"https://api.github.com/users/coleslaw481/repos","events_url":"https://api.github.com/users/coleslaw481/events{/privacy}","received_events_url":"https://api.github.com/users/coleslaw481/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/drugdata/D3R/milestones/22","html_url":"https://github.com/drugdata/D3R/milestone/22","labels_url":"https://api.github.com/repos/drugdata/D3R/milestones/22/labels","id":3040699,"node_id":"MDk6TWlsZXN0b25lMzA0MDY5OQ==","number":22,"title":"1.11.0","description":"","creator":{"login":"coleslaw481","id":655940,"node_id":"MDQ6VXNlcjY1NTk0MA==","avatar_url":"https://avatars2.githubusercontent.com/u/655940?v=4","gravatar_id":"","url":"https://api.github.com/users/coleslaw481","html_url":"https://github.com/coleslaw481","followers_url":"https://api.github.com/users/coleslaw481/followers","following_url":"https://api.github.com/users/coleslaw481/following{/other_user}","gists_url":"https://api.github.com/users/coleslaw481/gists{/gist_id}","starred_url":"https://api.github.com/users/coleslaw481/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coleslaw481/subscriptions","organizations_url":"https://api.github.com/users/coleslaw481/orgs","repos_url":"https://api.github.com/users/coleslaw481/repos","events_url":"https://api.github.com/users/coleslaw481/events{/privacy}","received_events_url":"https://api.github.com/users/coleslaw481/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":9,"state":"open","created_at":"2018-01-16T23:19:40Z","updated_at":"2018-08-20T20:28:05Z","due_on":null,"closed_at":null},"comments":0,"created_at":"2018-08-15T20:37:16Z","updated_at":"2018-08-20T20:28:05Z","closed_at":"2018-08-20T20:28:05Z","author_association":"CONTRIBUTOR","body":"In evaluate.py wait_and_check function the last `return False` is indented such that its part of the while loop. This causes the code to return False after sleeping once if the file doesn't appear with first check.\r\n\r\nIt appears this outcome is NOT the intended implementation. \r\n\r\n\r\nThis code is used to wait for the schrodinger call to the command `align_binding_sites` to generate output. If `align_binding_sites` fails to generate output a different command `structalign` is made.\r\n\r\nThe return False should be pulled out of the loop and some checks should be added for valid inputs."},"comment":{"url":"https://api.github.com/repos/drugdata/D3R/issues/comments/414451920","html_url":"https://github.com/drugdata/D3R/issues/189#issuecomment-414451920","issue_url":"https://api.github.com/repos/drugdata/D3R/issues/189","id":414451920,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNDQ1MTkyMA==","user":{"login":"coleslaw481","id":655940,"node_id":"MDQ6VXNlcjY1NTk0MA==","avatar_url":"https://avatars2.githubusercontent.com/u/655940?v=4","gravatar_id":"","url":"https://api.github.com/users/coleslaw481","html_url":"https://github.com/coleslaw481","followers_url":"https://api.github.com/users/coleslaw481/followers","following_url":"https://api.github.com/users/coleslaw481/following{/other_user}","gists_url":"https://api.github.com/users/coleslaw481/gists{/gist_id}","starred_url":"https://api.github.com/users/coleslaw481/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coleslaw481/subscriptions","organizations_url":"https://api.github.com/users/coleslaw481/orgs","repos_url":"https://api.github.com/users/coleslaw481/repos","events_url":"https://api.github.com/users/coleslaw481/events{/privacy}","received_events_url":"https://api.github.com/users/coleslaw481/received_events","type":"User","site_admin":false},"created_at":"2018-08-20T20:28:05Z","updated_at":"2018-08-20T20:28:05Z","author_association":"CONTRIBUTOR","body":"Added tests and properly indented `return False` line. "}}
{"actor":{"display_login":"coleslaw481"}}