{"action":"created","comment":{"url":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/pulls/comments/203684708","pull_request_review_id":138620810,"id":203684708,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMzY4NDcwOA==","diff_hunk":"@@ -151,6 +148,34 @@\n \n       _navigateToView: function() {\n         this.navigateTo('browse', this.document.path);\n+      },\n+\n+      _updateUrl: function() {\n+        var currentUrl = window.location.href;\n+        var newUrl;\n+        var queryParamsIdx = currentUrl.lastIndexOf('?');\n+        var queryParams;\n+        if (queryParamsIdx > -1) {\n+          newUrl = currentUrl.slice(0, queryParamsIdx);\n+          queryParams = new URLSearchParams(currentUrl.substring(queryParamsIdx));\n+        } else {\n+          newUrl = currentUrl;\n+          queryParams = new URLSearchParams();\n+        }\n+        // remove 'p' queryParam if current tab is the default one\n+        if (this.selectedTab === this.properties.selectedTab.value) {","path":"elements/nuxeo-browser.html","position":45,"original_position":45,"commit_id":"a321ce007a04e3c8a8cd56e7a0eacceb084d447a","original_commit_id":"a321ce007a04e3c8a8cd56e7a0eacceb084d447a","user":{"login":"afjusto","id":4780036,"node_id":"MDQ6VXNlcjQ3ODAwMzY=","avatar_url":"https://avatars2.githubusercontent.com/u/4780036?v=4","gravatar_id":"","url":"https://api.github.com/users/afjusto","html_url":"https://github.com/afjusto","followers_url":"https://api.github.com/users/afjusto/followers","following_url":"https://api.github.com/users/afjusto/following{/other_user}","gists_url":"https://api.github.com/users/afjusto/gists{/gist_id}","starred_url":"https://api.github.com/users/afjusto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afjusto/subscriptions","organizations_url":"https://api.github.com/users/afjusto/orgs","repos_url":"https://api.github.com/users/afjusto/repos","events_url":"https://api.github.com/users/afjusto/events{/privacy}","received_events_url":"https://api.github.com/users/afjusto/received_events","type":"User","site_admin":false},"body":"`this.selectedTab` -> current value\r\n`this.properties.selectedTab.value` -> default value (https://github.com/nuxeo/nuxeo-web-ui/blob/master/elements/nuxeo-browser.html#L95)\r\n\r\nThe spec says we don't want the parameter to be added when switching to the default view (aka `view` tab)","created_at":"2018-07-19T10:58:59Z","updated_at":"2018-07-19T10:58:59Z","html_url":"https://github.com/nuxeo/nuxeo-web-ui/pull/287#discussion_r203684708","pull_request_url":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/pulls/287","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/pulls/comments/203684708"},"html":{"href":"https://github.com/nuxeo/nuxeo-web-ui/pull/287#discussion_r203684708"},"pull_request":{"href":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/pulls/287"}},"in_reply_to_id":203683397},"pull_request":{"url":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/pulls/287","id":202234362,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyMjM0MzYy","html_url":"https://github.com/nuxeo/nuxeo-web-ui/pull/287","diff_url":"https://github.com/nuxeo/nuxeo-web-ui/pull/287.diff","patch_url":"https://github.com/nuxeo/nuxeo-web-ui/pull/287.patch","issue_url":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/issues/287","number":287,"state":"open","locked":false,"title":"NXP-22453: add routing support to subpage navigation in nuxeo browser","user":{"login":"afjusto","id":4780036,"node_id":"MDQ6VXNlcjQ3ODAwMzY=","avatar_url":"https://avatars2.githubusercontent.com/u/4780036?v=4","gravatar_id":"","url":"https://api.github.com/users/afjusto","html_url":"https://github.com/afjusto","followers_url":"https://api.github.com/users/afjusto/followers","following_url":"https://api.github.com/users/afjusto/following{/other_user}","gists_url":"https://api.github.com/users/afjusto/gists{/gist_id}","starred_url":"https://api.github.com/users/afjusto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afjusto/subscriptions","organizations_url":"https://api.github.com/users/afjusto/orgs","repos_url":"https://api.github.com/users/afjusto/repos","events_url":"https://api.github.com/users/afjusto/events{/privacy}","received_events_url":"https://api.github.com/users/afjusto/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-07-18T12:20:47Z","updated_at":"2018-07-19T10:58:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fb66a34453714fe004212c7964c6ddccd511ea8e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/pulls/287/commits","review_comments_url":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/pulls/287/comments","review_comment_url":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/issues/287/comments","statuses_url":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/statuses/a321ce007a04e3c8a8cd56e7a0eacceb084d447a","head":{"label":"nuxeo:feature-NXP-22453-routing-subpage-navigation","ref":"feature-NXP-22453-routing-subpage-navigation","sha":"a321ce007a04e3c8a8cd56e7a0eacceb084d447a","user":{"login":"nuxeo","id":460607,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2MDYwNw==","avatar_url":"https://avatars1.githubusercontent.com/u/460607?v=4","gravatar_id":"","url":"https://api.github.com/users/nuxeo","html_url":"https://github.com/nuxeo","followers_url":"https://api.github.com/users/nuxeo/followers","following_url":"https://api.github.com/users/nuxeo/following{/other_user}","gists_url":"https://api.github.com/users/nuxeo/gists{/gist_id}","starred_url":"https://api.github.com/users/nuxeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nuxeo/subscriptions","organizations_url":"https://api.github.com/users/nuxeo/orgs","repos_url":"https://api.github.com/users/nuxeo/repos","events_url":"https://api.github.com/users/nuxeo/events{/privacy}","received_events_url":"https://api.github.com/users/nuxeo/received_events","type":"Organization","site_admin":false},"repo":{"id":46934532,"node_id":"MDEwOlJlcG9zaXRvcnk0NjkzNDUzMg==","name":"nuxeo-web-ui","full_name":"nuxeo/nuxeo-web-ui","owner":{"login":"nuxeo","id":460607,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2MDYwNw==","avatar_url":"https://avatars1.githubusercontent.com/u/460607?v=4","gravatar_id":"","url":"https://api.github.com/users/nuxeo","html_url":"https://github.com/nuxeo","followers_url":"https://api.github.com/users/nuxeo/followers","following_url":"https://api.github.com/users/nuxeo/following{/other_user}","gists_url":"https://api.github.com/users/nuxeo/gists{/gist_id}","starred_url":"https://api.github.com/users/nuxeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nuxeo/subscriptions","organizations_url":"https://api.github.com/users/nuxeo/orgs","repos_url":"https://api.github.com/users/nuxeo/repos","events_url":"https://api.github.com/users/nuxeo/events{/privacy}","received_events_url":"https://api.github.com/users/nuxeo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nuxeo/nuxeo-web-ui","description":"New Nuxeo Web UI","fork":false,"url":"https://api.github.com/repos/nuxeo/nuxeo-web-ui","forks_url":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/forks","keys_url":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/teams","hooks_url":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/hooks","issue_events_url":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/issues/events{/number}","events_url":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/events","assignees_url":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/assignees{/user}","branches_url":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/branches{/branch}","tags_url":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/tags","blobs_url":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/languages","stargazers_url":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/stargazers","contributors_url":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/contributors","subscribers_url":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/subscribers","subscription_url":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/subscription","commits_url":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/contents/{+path}","compare_url":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/merges","archive_url":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/downloads","issues_url":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/issues{/number}","pulls_url":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/labels{/name}","releases_url":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/releases{/id}","deployments_url":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/deployments","created_at":"2015-11-26T15:33:53Z","updated_at":"2018-07-17T17:39:17Z","pushed_at":"2018-07-19T10:44:51Z","git_url":"git://github.com/nuxeo/nuxeo-web-ui.git","ssh_url":"git@github.com:nuxeo/nuxeo-web-ui.git","clone_url":"https://github.com/nuxeo/nuxeo-web-ui.git","svn_url":"https://github.com/nuxeo/nuxeo-web-ui","homepage":"","size":42415,"stargazers_count":22,"watchers_count":22,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":5,"license":null,"forks":17,"open_issues":5,"watchers":22,"default_branch":"master"}},"base":{"label":"nuxeo:master","ref":"master","sha":"39cafa74a6bab4b179dd73a316b6dc95c27b3e2a","user":{"login":"nuxeo","id":460607,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2MDYwNw==","avatar_url":"https://avatars1.githubusercontent.com/u/460607?v=4","gravatar_id":"","url":"https://api.github.com/users/nuxeo","html_url":"https://github.com/nuxeo","followers_url":"https://api.github.com/users/nuxeo/followers","following_url":"https://api.github.com/users/nuxeo/following{/other_user}","gists_url":"https://api.github.com/users/nuxeo/gists{/gist_id}","starred_url":"https://api.github.com/users/nuxeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nuxeo/subscriptions","organizations_url":"https://api.github.com/users/nuxeo/orgs","repos_url":"https://api.github.com/users/nuxeo/repos","events_url":"https://api.github.com/users/nuxeo/events{/privacy}","received_events_url":"https://api.github.com/users/nuxeo/received_events","type":"Organization","site_admin":false},"repo":{"id":46934532,"node_id":"MDEwOlJlcG9zaXRvcnk0NjkzNDUzMg==","name":"nuxeo-web-ui","full_name":"nuxeo/nuxeo-web-ui","owner":{"login":"nuxeo","id":460607,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2MDYwNw==","avatar_url":"https://avatars1.githubusercontent.com/u/460607?v=4","gravatar_id":"","url":"https://api.github.com/users/nuxeo","html_url":"https://github.com/nuxeo","followers_url":"https://api.github.com/users/nuxeo/followers","following_url":"https://api.github.com/users/nuxeo/following{/other_user}","gists_url":"https://api.github.com/users/nuxeo/gists{/gist_id}","starred_url":"https://api.github.com/users/nuxeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nuxeo/subscriptions","organizations_url":"https://api.github.com/users/nuxeo/orgs","repos_url":"https://api.github.com/users/nuxeo/repos","events_url":"https://api.github.com/users/nuxeo/events{/privacy}","received_events_url":"https://api.github.com/users/nuxeo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nuxeo/nuxeo-web-ui","description":"New Nuxeo Web UI","fork":false,"url":"https://api.github.com/repos/nuxeo/nuxeo-web-ui","forks_url":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/forks","keys_url":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/teams","hooks_url":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/hooks","issue_events_url":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/issues/events{/number}","events_url":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/events","assignees_url":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/assignees{/user}","branches_url":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/branches{/branch}","tags_url":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/tags","blobs_url":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/languages","stargazers_url":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/stargazers","contributors_url":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/contributors","subscribers_url":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/subscribers","subscription_url":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/subscription","commits_url":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/contents/{+path}","compare_url":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/merges","archive_url":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/downloads","issues_url":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/issues{/number}","pulls_url":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/labels{/name}","releases_url":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/releases{/id}","deployments_url":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/deployments","created_at":"2015-11-26T15:33:53Z","updated_at":"2018-07-17T17:39:17Z","pushed_at":"2018-07-19T10:44:51Z","git_url":"git://github.com/nuxeo/nuxeo-web-ui.git","ssh_url":"git@github.com:nuxeo/nuxeo-web-ui.git","clone_url":"https://github.com/nuxeo/nuxeo-web-ui.git","svn_url":"https://github.com/nuxeo/nuxeo-web-ui","homepage":"","size":42415,"stargazers_count":22,"watchers_count":22,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":5,"license":null,"forks":17,"open_issues":5,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/pulls/287"},"html":{"href":"https://github.com/nuxeo/nuxeo-web-ui/pull/287"},"issue":{"href":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/issues/287"},"comments":{"href":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/issues/287/comments"},"review_comments":{"href":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/pulls/287/comments"},"review_comment":{"href":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/pulls/287/commits"},"statuses":{"href":"https://api.github.com/repos/nuxeo/nuxeo-web-ui/statuses/a321ce007a04e3c8a8cd56e7a0eacceb084d447a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"afjusto"}}