{"action":"created","comment":{"url":"https://api.github.com/repos/openucx/ucx/pulls/comments/166791806","pull_request_review_id":94911597,"id":166791806,"diff_hunk":"@@ -19,17 +19,29 @@ void uct_ib_log_dump_opcode(uint32_t qp_num, unsigned idx, uct_ib_opcode_t *op,\n void uct_ib_log_dump_sg_list(uct_ib_iface_t *iface, uct_am_trace_type_t type,\n                              struct ibv_sge *sg_list, int num_sge,\n                              uint64_t inline_bitmap,\n-                             uct_log_data_dump_func_t data_dump,\n+                             uct_log_data_dump_func_t data_dump_cb,\n                              char *buf, size_t max)\n {\n     char data[256];\n+    int data_dump = (data_dump_cb != NULL);\n     size_t total_len       = 0;\n     size_t total_valid_len = 0;;\n     char *s    = buf;\n     char *ends = buf + max;\n     void *md   = data;\n     size_t len;\n     int i;\n+    uct_md_attr_t md_attr;\n+    ucs_status_t status;\n+\n+    if (data_dump) {\n+        /* disable data dump if ib hca can direct access mem type */\n+        status = uct_md_query(iface->super.md, &md_attr);\n+        if (status != UCS_OK ||\n+            (md_attr.cap.reg_mem_types & ~UCS_BIT(UCT_MD_MEM_TYPE_HOST))) {","path":"src/uct/ib/base/ib_log.c","position":24,"original_position":24,"commit_id":"46cb7819b3e0cd0958c5029be27f35a7b88a19b8","original_commit_id":"46cb7819b3e0cd0958c5029be27f35a7b88a19b8","user":{"login":"yosefe","id":2255631,"avatar_url":"https://avatars0.githubusercontent.com/u/2255631?v=4","gravatar_id":"","url":"https://api.github.com/users/yosefe","html_url":"https://github.com/yosefe","followers_url":"https://api.github.com/users/yosefe/followers","following_url":"https://api.github.com/users/yosefe/following{/other_user}","gists_url":"https://api.github.com/users/yosefe/gists{/gist_id}","starred_url":"https://api.github.com/users/yosefe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yosefe/subscriptions","organizations_url":"https://api.github.com/users/yosefe/orgs","repos_url":"https://api.github.com/users/yosefe/repos","events_url":"https://api.github.com/users/yosefe/events{/privacy}","received_events_url":"https://api.github.com/users/yosefe/received_events","type":"User","site_admin":false},"body":"since this is IB, can we cache this flag on the ib_device structure?","created_at":"2018-02-07T23:35:53Z","updated_at":"2018-02-07T23:35:57Z","html_url":"https://github.com/openucx/ucx/pull/2273#discussion_r166791806","pull_request_url":"https://api.github.com/repos/openucx/ucx/pulls/2273","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/openucx/ucx/pulls/comments/166791806"},"html":{"href":"https://github.com/openucx/ucx/pull/2273#discussion_r166791806"},"pull_request":{"href":"https://api.github.com/repos/openucx/ucx/pulls/2273"}}},"pull_request":{"url":"https://api.github.com/repos/openucx/ucx/pulls/2273","id":167819845,"html_url":"https://github.com/openucx/ucx/pull/2273","diff_url":"https://github.com/openucx/ucx/pull/2273.diff","patch_url":"https://github.com/openucx/ucx/pull/2273.patch","issue_url":"https://api.github.com/repos/openucx/ucx/issues/2273","number":2273,"state":"open","locked":false,"title":"UCT/IB: disable ib data dump log when mem type direct access is enabled.","user":{"login":"bureddy","id":4983664,"avatar_url":"https://avatars3.githubusercontent.com/u/4983664?v=4","gravatar_id":"","url":"https://api.github.com/users/bureddy","html_url":"https://github.com/bureddy","followers_url":"https://api.github.com/users/bureddy/followers","following_url":"https://api.github.com/users/bureddy/following{/other_user}","gists_url":"https://api.github.com/users/bureddy/gists{/gist_id}","starred_url":"https://api.github.com/users/bureddy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bureddy/subscriptions","organizations_url":"https://api.github.com/users/bureddy/orgs","repos_url":"https://api.github.com/users/bureddy/repos","events_url":"https://api.github.com/users/bureddy/events{/privacy}","received_events_url":"https://api.github.com/users/bureddy/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-02-07T21:55:10Z","updated_at":"2018-02-07T23:35:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b4d61197c4bda66e419d51a5cb78e7696858c1ac","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/openucx/ucx/pulls/2273/commits","review_comments_url":"https://api.github.com/repos/openucx/ucx/pulls/2273/comments","review_comment_url":"https://api.github.com/repos/openucx/ucx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openucx/ucx/issues/2273/comments","statuses_url":"https://api.github.com/repos/openucx/ucx/statuses/46cb7819b3e0cd0958c5029be27f35a7b88a19b8","head":{"label":"bureddy:log-fix","ref":"log-fix","sha":"46cb7819b3e0cd0958c5029be27f35a7b88a19b8","user":{"login":"bureddy","id":4983664,"avatar_url":"https://avatars3.githubusercontent.com/u/4983664?v=4","gravatar_id":"","url":"https://api.github.com/users/bureddy","html_url":"https://github.com/bureddy","followers_url":"https://api.github.com/users/bureddy/followers","following_url":"https://api.github.com/users/bureddy/following{/other_user}","gists_url":"https://api.github.com/users/bureddy/gists{/gist_id}","starred_url":"https://api.github.com/users/bureddy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bureddy/subscriptions","organizations_url":"https://api.github.com/users/bureddy/orgs","repos_url":"https://api.github.com/users/bureddy/repos","events_url":"https://api.github.com/users/bureddy/events{/privacy}","received_events_url":"https://api.github.com/users/bureddy/received_events","type":"User","site_admin":false},"repo":{"id":79393098,"name":"ucx","full_name":"bureddy/ucx","owner":{"login":"bureddy","id":4983664,"avatar_url":"https://avatars3.githubusercontent.com/u/4983664?v=4","gravatar_id":"","url":"https://api.github.com/users/bureddy","html_url":"https://github.com/bureddy","followers_url":"https://api.github.com/users/bureddy/followers","following_url":"https://api.github.com/users/bureddy/following{/other_user}","gists_url":"https://api.github.com/users/bureddy/gists{/gist_id}","starred_url":"https://api.github.com/users/bureddy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bureddy/subscriptions","organizations_url":"https://api.github.com/users/bureddy/orgs","repos_url":"https://api.github.com/users/bureddy/repos","events_url":"https://api.github.com/users/bureddy/events{/privacy}","received_events_url":"https://api.github.com/users/bureddy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bureddy/ucx","description":"Unified Communication X  (mailing list - https://elist.ornl.gov/mailman/listinfo/ucx-group): ","fork":true,"url":"https://api.github.com/repos/bureddy/ucx","forks_url":"https://api.github.com/repos/bureddy/ucx/forks","keys_url":"https://api.github.com/repos/bureddy/ucx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bureddy/ucx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bureddy/ucx/teams","hooks_url":"https://api.github.com/repos/bureddy/ucx/hooks","issue_events_url":"https://api.github.com/repos/bureddy/ucx/issues/events{/number}","events_url":"https://api.github.com/repos/bureddy/ucx/events","assignees_url":"https://api.github.com/repos/bureddy/ucx/assignees{/user}","branches_url":"https://api.github.com/repos/bureddy/ucx/branches{/branch}","tags_url":"https://api.github.com/repos/bureddy/ucx/tags","blobs_url":"https://api.github.com/repos/bureddy/ucx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bureddy/ucx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bureddy/ucx/git/refs{/sha}","trees_url":"https://api.github.com/repos/bureddy/ucx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bureddy/ucx/statuses/{sha}","languages_url":"https://api.github.com/repos/bureddy/ucx/languages","stargazers_url":"https://api.github.com/repos/bureddy/ucx/stargazers","contributors_url":"https://api.github.com/repos/bureddy/ucx/contributors","subscribers_url":"https://api.github.com/repos/bureddy/ucx/subscribers","subscription_url":"https://api.github.com/repos/bureddy/ucx/subscription","commits_url":"https://api.github.com/repos/bureddy/ucx/commits{/sha}","git_commits_url":"https://api.github.com/repos/bureddy/ucx/git/commits{/sha}","comments_url":"https://api.github.com/repos/bureddy/ucx/comments{/number}","issue_comment_url":"https://api.github.com/repos/bureddy/ucx/issues/comments{/number}","contents_url":"https://api.github.com/repos/bureddy/ucx/contents/{+path}","compare_url":"https://api.github.com/repos/bureddy/ucx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bureddy/ucx/merges","archive_url":"https://api.github.com/repos/bureddy/ucx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bureddy/ucx/downloads","issues_url":"https://api.github.com/repos/bureddy/ucx/issues{/number}","pulls_url":"https://api.github.com/repos/bureddy/ucx/pulls{/number}","milestones_url":"https://api.github.com/repos/bureddy/ucx/milestones{/number}","notifications_url":"https://api.github.com/repos/bureddy/ucx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bureddy/ucx/labels{/name}","releases_url":"https://api.github.com/repos/bureddy/ucx/releases{/id}","deployments_url":"https://api.github.com/repos/bureddy/ucx/deployments","created_at":"2017-01-18T22:54:26Z","updated_at":"2017-01-18T22:54:30Z","pushed_at":"2018-02-07T21:54:09Z","git_url":"git://github.com/bureddy/ucx.git","ssh_url":"git@github.com:bureddy/ucx.git","clone_url":"https://github.com/bureddy/ucx.git","svn_url":"https://github.com/bureddy/ucx","homepage":"http://www.openucx.org","size":11588,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"base":{"label":"openucx:master","ref":"master","sha":"6fd628a842ff37d64c910d209d67b680bbb49b76","user":{"login":"openucx","id":13118737,"avatar_url":"https://avatars2.githubusercontent.com/u/13118737?v=4","gravatar_id":"","url":"https://api.github.com/users/openucx","html_url":"https://github.com/openucx","followers_url":"https://api.github.com/users/openucx/followers","following_url":"https://api.github.com/users/openucx/following{/other_user}","gists_url":"https://api.github.com/users/openucx/gists{/gist_id}","starred_url":"https://api.github.com/users/openucx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openucx/subscriptions","organizations_url":"https://api.github.com/users/openucx/orgs","repos_url":"https://api.github.com/users/openucx/repos","events_url":"https://api.github.com/users/openucx/events{/privacy}","received_events_url":"https://api.github.com/users/openucx/received_events","type":"Organization","site_admin":false},"repo":{"id":25379390,"name":"ucx","full_name":"openucx/ucx","owner":{"login":"openucx","id":13118737,"avatar_url":"https://avatars2.githubusercontent.com/u/13118737?v=4","gravatar_id":"","url":"https://api.github.com/users/openucx","html_url":"https://github.com/openucx","followers_url":"https://api.github.com/users/openucx/followers","following_url":"https://api.github.com/users/openucx/following{/other_user}","gists_url":"https://api.github.com/users/openucx/gists{/gist_id}","starred_url":"https://api.github.com/users/openucx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openucx/subscriptions","organizations_url":"https://api.github.com/users/openucx/orgs","repos_url":"https://api.github.com/users/openucx/repos","events_url":"https://api.github.com/users/openucx/events{/privacy}","received_events_url":"https://api.github.com/users/openucx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openucx/ucx","description":"Unified Communication X  (mailing list - https://elist.ornl.gov/mailman/listinfo/ucx-group): ","fork":false,"url":"https://api.github.com/repos/openucx/ucx","forks_url":"https://api.github.com/repos/openucx/ucx/forks","keys_url":"https://api.github.com/repos/openucx/ucx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openucx/ucx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openucx/ucx/teams","hooks_url":"https://api.github.com/repos/openucx/ucx/hooks","issue_events_url":"https://api.github.com/repos/openucx/ucx/issues/events{/number}","events_url":"https://api.github.com/repos/openucx/ucx/events","assignees_url":"https://api.github.com/repos/openucx/ucx/assignees{/user}","branches_url":"https://api.github.com/repos/openucx/ucx/branches{/branch}","tags_url":"https://api.github.com/repos/openucx/ucx/tags","blobs_url":"https://api.github.com/repos/openucx/ucx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openucx/ucx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openucx/ucx/git/refs{/sha}","trees_url":"https://api.github.com/repos/openucx/ucx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openucx/ucx/statuses/{sha}","languages_url":"https://api.github.com/repos/openucx/ucx/languages","stargazers_url":"https://api.github.com/repos/openucx/ucx/stargazers","contributors_url":"https://api.github.com/repos/openucx/ucx/contributors","subscribers_url":"https://api.github.com/repos/openucx/ucx/subscribers","subscription_url":"https://api.github.com/repos/openucx/ucx/subscription","commits_url":"https://api.github.com/repos/openucx/ucx/commits{/sha}","git_commits_url":"https://api.github.com/repos/openucx/ucx/git/commits{/sha}","comments_url":"https://api.github.com/repos/openucx/ucx/comments{/number}","issue_comment_url":"https://api.github.com/repos/openucx/ucx/issues/comments{/number}","contents_url":"https://api.github.com/repos/openucx/ucx/contents/{+path}","compare_url":"https://api.github.com/repos/openucx/ucx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openucx/ucx/merges","archive_url":"https://api.github.com/repos/openucx/ucx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openucx/ucx/downloads","issues_url":"https://api.github.com/repos/openucx/ucx/issues{/number}","pulls_url":"https://api.github.com/repos/openucx/ucx/pulls{/number}","milestones_url":"https://api.github.com/repos/openucx/ucx/milestones{/number}","notifications_url":"https://api.github.com/repos/openucx/ucx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openucx/ucx/labels{/name}","releases_url":"https://api.github.com/repos/openucx/ucx/releases{/id}","deployments_url":"https://api.github.com/repos/openucx/ucx/deployments","created_at":"2014-10-17T22:17:24Z","updated_at":"2018-01-20T18:26:38Z","pushed_at":"2018-02-07T23:25:31Z","git_url":"git://github.com/openucx/ucx.git","ssh_url":"git@github.com:openucx/ucx.git","clone_url":"https://github.com/openucx/ucx.git","svn_url":"https://github.com/openucx/ucx","homepage":"http://www.openucx.org","size":11503,"stargazers_count":96,"watchers_count":96,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":64,"mirror_url":null,"archived":false,"open_issues_count":129,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":64,"open_issues":129,"watchers":96,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openucx/ucx/pulls/2273"},"html":{"href":"https://github.com/openucx/ucx/pull/2273"},"issue":{"href":"https://api.github.com/repos/openucx/ucx/issues/2273"},"comments":{"href":"https://api.github.com/repos/openucx/ucx/issues/2273/comments"},"review_comments":{"href":"https://api.github.com/repos/openucx/ucx/pulls/2273/comments"},"review_comment":{"href":"https://api.github.com/repos/openucx/ucx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openucx/ucx/pulls/2273/commits"},"statuses":{"href":"https://api.github.com/repos/openucx/ucx/statuses/46cb7819b3e0cd0958c5029be27f35a7b88a19b8"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"yosefe"}}