{"action":"created","comment":{"url":"https://api.github.com/repos/spatialos/UnityGDK/pulls/comments/213389906","pull_request_review_id":150216457,"id":213389906,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMzM4OTkwNg==","diff_hunk":"@@ -70,34 +72,37 @@ public class BuildSystem : ComponentSystem\n     {\n         for(var i = 0; i < data.Length; i++)\n         {\n-            var requestSender = data.BuilderRequestSender[i];\n+            var requestSender = data.BuildWallSender[i];\n             var entityId = data.EntityIds[i];\n             \n-            BuildRequest buildRequest = new BuildRequest\n+            Builder.BuildWall.Request request = new Builder.BuildWall.Request\n             {\n-                Location = new Location(...),\n-                Rotation = new Rotation(...)\n-            }\n+                TargetEntityId = entityId,\n+                Payload = new BuildRequest\n+                {\n+                    Location = new Location(...),\n+                    Rotation = new Rotation(...)\n+                }\n+            };\n+\n             \n-            requestSender.SendBuildWallRequest(entityId, buildRequest);\n+            requestSender.RequestsToSend.Add(request);\n         }\n     }\n }\n ```\n \n This system runs on a client. It injects all SpatialOS entities in the client's view that have the `Builder` SpatialOS component, and sends a `build_wall` command to each SpatialOS entity (which will be received by the managed worker).","path":"docs/content/commands.md","position":69,"original_position":69,"commit_id":"4ff6f56bef4418510034b5d63b337f20b8369213","original_commit_id":"4ff6f56bef4418510034b5d63b337f20b8369213","user":{"login":"ElleEss","id":36853437,"node_id":"MDQ6VXNlcjM2ODUzNDM3","avatar_url":"https://avatars2.githubusercontent.com/u/36853437?v=4","gravatar_id":"","url":"https://api.github.com/users/ElleEss","html_url":"https://github.com/ElleEss","followers_url":"https://api.github.com/users/ElleEss/followers","following_url":"https://api.github.com/users/ElleEss/following{/other_user}","gists_url":"https://api.github.com/users/ElleEss/gists{/gist_id}","starred_url":"https://api.github.com/users/ElleEss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ElleEss/subscriptions","organizations_url":"https://api.github.com/users/ElleEss/orgs","repos_url":"https://api.github.com/users/ElleEss/repos","events_url":"https://api.github.com/users/ElleEss/events{/privacy}","received_events_url":"https://api.github.com/users/ElleEss/received_events","type":"User","site_admin":false},"body":"\r\nI know you didn't edit this but...\r\n(1) It injects what in the SpatialOS entities? \r\nOr does it inject the SpatialOS entites *into* the client' view?\r\nI can't follow the sentence.\r\n(2) Does it send the `build_wall` command to each SpatialOS entity which has the `Builder` component or all of them. Currently it says \"each\" which suggests all of them. I suspect it's the one with the components only?\r\n(3) Which managed worker (server-worker) receives the commands?  Or is it just general \"all server workers\"?\r\n(4) We need to use the current terminology:\r\n\"client-worker\", \"managed-worker\".\r\n\r\nSo something like the following (but my interpretation may be out).\r\n\r\n\"This system runs on a client-worker. It injects <something into??> all SpatialOS entities currently in the client-worker's view that have the `Builder` SpatialOS component. It then sends a `build_wall` command to each SpatialOS entity with that component. All server-workers receive this command.\"","created_at":"2018-08-28T16:46:42Z","updated_at":"2018-08-28T16:46:42Z","html_url":"https://github.com/spatialos/UnityGDK/pull/243#discussion_r213389906","pull_request_url":"https://api.github.com/repos/spatialos/UnityGDK/pulls/243","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/spatialos/UnityGDK/pulls/comments/213389906"},"html":{"href":"https://github.com/spatialos/UnityGDK/pull/243#discussion_r213389906"},"pull_request":{"href":"https://api.github.com/repos/spatialos/UnityGDK/pulls/243"}}},"pull_request":{"url":"https://api.github.com/repos/spatialos/UnityGDK/pulls/243","id":210130002,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwMTMwMDAy","html_url":"https://github.com/spatialos/UnityGDK/pull/243","diff_url":"https://github.com/spatialos/UnityGDK/pull/243.diff","patch_url":"https://github.com/spatialos/UnityGDK/pull/243.patch","issue_url":"https://api.github.com/repos/spatialos/UnityGDK/issues/243","number":243,"state":"open","locked":false,"title":"UTY-963: Core C# SDK Docs Changes","user":{"login":"jamiebrynes7","id":13353733,"node_id":"MDQ6VXNlcjEzMzUzNzMz","avatar_url":"https://avatars1.githubusercontent.com/u/13353733?v=4","gravatar_id":"","url":"https://api.github.com/users/jamiebrynes7","html_url":"https://github.com/jamiebrynes7","followers_url":"https://api.github.com/users/jamiebrynes7/followers","following_url":"https://api.github.com/users/jamiebrynes7/following{/other_user}","gists_url":"https://api.github.com/users/jamiebrynes7/gists{/gist_id}","starred_url":"https://api.github.com/users/jamiebrynes7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamiebrynes7/subscriptions","organizations_url":"https://api.github.com/users/jamiebrynes7/orgs","repos_url":"https://api.github.com/users/jamiebrynes7/repos","events_url":"https://api.github.com/users/jamiebrynes7/events{/privacy}","received_events_url":"https://api.github.com/users/jamiebrynes7/received_events","type":"User","site_admin":false},"body":"#### Description\r\nUpdates all the docs to reflect the changes to the core. Some things have been omitted for now (reference type providers).\r\n#### Tests\r\nN/A\r\n#### Documentation\r\nyes\r\n#### Primary reviewers\r\n@ElleEss ","created_at":"2018-08-22T13:16:04Z","updated_at":"2018-08-28T16:46:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4db19cc8bb86a09a50a87b40da5001bc70f21337","assignee":null,"assignees":[],"requested_reviewers":[{"login":"zeroZshadow","id":3106728,"node_id":"MDQ6VXNlcjMxMDY3Mjg=","avatar_url":"https://avatars3.githubusercontent.com/u/3106728?v=4","gravatar_id":"","url":"https://api.github.com/users/zeroZshadow","html_url":"https://github.com/zeroZshadow","followers_url":"https://api.github.com/users/zeroZshadow/followers","following_url":"https://api.github.com/users/zeroZshadow/following{/other_user}","gists_url":"https://api.github.com/users/zeroZshadow/gists{/gist_id}","starred_url":"https://api.github.com/users/zeroZshadow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeroZshadow/subscriptions","organizations_url":"https://api.github.com/users/zeroZshadow/orgs","repos_url":"https://api.github.com/users/zeroZshadow/repos","events_url":"https://api.github.com/users/zeroZshadow/events{/privacy}","received_events_url":"https://api.github.com/users/zeroZshadow/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":999948057,"node_id":"MDU6TGFiZWw5OTk5NDgwNTc=","url":"https://api.github.com/repos/spatialos/UnityGDK/labels/size/XL","name":"size/XL","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/spatialos/UnityGDK/pulls/243/commits","review_comments_url":"https://api.github.com/repos/spatialos/UnityGDK/pulls/243/comments","review_comment_url":"https://api.github.com/repos/spatialos/UnityGDK/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spatialos/UnityGDK/issues/243/comments","statuses_url":"https://api.github.com/repos/spatialos/UnityGDK/statuses/4ff6f56bef4418510034b5d63b337f20b8369213","head":{"label":"spatialos:docs/UTY-963-core-csharp-doc-changes","ref":"docs/UTY-963-core-csharp-doc-changes","sha":"4ff6f56bef4418510034b5d63b337f20b8369213","user":{"login":"spatialos","id":23554165,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTU0MTY1","avatar_url":"https://avatars2.githubusercontent.com/u/23554165?v=4","gravatar_id":"","url":"https://api.github.com/users/spatialos","html_url":"https://github.com/spatialos","followers_url":"https://api.github.com/users/spatialos/followers","following_url":"https://api.github.com/users/spatialos/following{/other_user}","gists_url":"https://api.github.com/users/spatialos/gists{/gist_id}","starred_url":"https://api.github.com/users/spatialos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spatialos/subscriptions","organizations_url":"https://api.github.com/users/spatialos/orgs","repos_url":"https://api.github.com/users/spatialos/repos","events_url":"https://api.github.com/users/spatialos/events{/privacy}","received_events_url":"https://api.github.com/users/spatialos/received_events","type":"Organization","site_admin":false},"repo":{"id":137235993,"node_id":"MDEwOlJlcG9zaXRvcnkxMzcyMzU5OTM=","name":"UnityGDK","full_name":"spatialos/UnityGDK","owner":{"login":"spatialos","id":23554165,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTU0MTY1","avatar_url":"https://avatars2.githubusercontent.com/u/23554165?v=4","gravatar_id":"","url":"https://api.github.com/users/spatialos","html_url":"https://github.com/spatialos","followers_url":"https://api.github.com/users/spatialos/followers","following_url":"https://api.github.com/users/spatialos/following{/other_user}","gists_url":"https://api.github.com/users/spatialos/gists{/gist_id}","starred_url":"https://api.github.com/users/spatialos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spatialos/subscriptions","organizations_url":"https://api.github.com/users/spatialos/orgs","repos_url":"https://api.github.com/users/spatialos/repos","events_url":"https://api.github.com/users/spatialos/events{/privacy}","received_events_url":"https://api.github.com/users/spatialos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spatialos/UnityGDK","description":"Unity GDK","fork":false,"url":"https://api.github.com/repos/spatialos/UnityGDK","forks_url":"https://api.github.com/repos/spatialos/UnityGDK/forks","keys_url":"https://api.github.com/repos/spatialos/UnityGDK/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spatialos/UnityGDK/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spatialos/UnityGDK/teams","hooks_url":"https://api.github.com/repos/spatialos/UnityGDK/hooks","issue_events_url":"https://api.github.com/repos/spatialos/UnityGDK/issues/events{/number}","events_url":"https://api.github.com/repos/spatialos/UnityGDK/events","assignees_url":"https://api.github.com/repos/spatialos/UnityGDK/assignees{/user}","branches_url":"https://api.github.com/repos/spatialos/UnityGDK/branches{/branch}","tags_url":"https://api.github.com/repos/spatialos/UnityGDK/tags","blobs_url":"https://api.github.com/repos/spatialos/UnityGDK/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spatialos/UnityGDK/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spatialos/UnityGDK/git/refs{/sha}","trees_url":"https://api.github.com/repos/spatialos/UnityGDK/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spatialos/UnityGDK/statuses/{sha}","languages_url":"https://api.github.com/repos/spatialos/UnityGDK/languages","stargazers_url":"https://api.github.com/repos/spatialos/UnityGDK/stargazers","contributors_url":"https://api.github.com/repos/spatialos/UnityGDK/contributors","subscribers_url":"https://api.github.com/repos/spatialos/UnityGDK/subscribers","subscription_url":"https://api.github.com/repos/spatialos/UnityGDK/subscription","commits_url":"https://api.github.com/repos/spatialos/UnityGDK/commits{/sha}","git_commits_url":"https://api.github.com/repos/spatialos/UnityGDK/git/commits{/sha}","comments_url":"https://api.github.com/repos/spatialos/UnityGDK/comments{/number}","issue_comment_url":"https://api.github.com/repos/spatialos/UnityGDK/issues/comments{/number}","contents_url":"https://api.github.com/repos/spatialos/UnityGDK/contents/{+path}","compare_url":"https://api.github.com/repos/spatialos/UnityGDK/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spatialos/UnityGDK/merges","archive_url":"https://api.github.com/repos/spatialos/UnityGDK/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spatialos/UnityGDK/downloads","issues_url":"https://api.github.com/repos/spatialos/UnityGDK/issues{/number}","pulls_url":"https://api.github.com/repos/spatialos/UnityGDK/pulls{/number}","milestones_url":"https://api.github.com/repos/spatialos/UnityGDK/milestones{/number}","notifications_url":"https://api.github.com/repos/spatialos/UnityGDK/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spatialos/UnityGDK/labels{/name}","releases_url":"https://api.github.com/repos/spatialos/UnityGDK/releases{/id}","deployments_url":"https://api.github.com/repos/spatialos/UnityGDK/deployments","created_at":"2018-06-13T15:37:54Z","updated_at":"2018-08-28T14:34:40Z","pushed_at":"2018-08-28T16:23:45Z","git_url":"git://github.com/spatialos/UnityGDK.git","ssh_url":"git@github.com:spatialos/UnityGDK.git","clone_url":"https://github.com/spatialos/UnityGDK.git","svn_url":"https://github.com/spatialos/UnityGDK","homepage":null,"size":187826,"stargazers_count":82,"watchers_count":82,"language":"C#","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":5,"open_issues":14,"watchers":82,"default_branch":"master"}},"base":{"label":"spatialos:master","ref":"master","sha":"a847aaa1cadc85e3f195940aa9ee78036897cc78","user":{"login":"spatialos","id":23554165,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTU0MTY1","avatar_url":"https://avatars2.githubusercontent.com/u/23554165?v=4","gravatar_id":"","url":"https://api.github.com/users/spatialos","html_url":"https://github.com/spatialos","followers_url":"https://api.github.com/users/spatialos/followers","following_url":"https://api.github.com/users/spatialos/following{/other_user}","gists_url":"https://api.github.com/users/spatialos/gists{/gist_id}","starred_url":"https://api.github.com/users/spatialos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spatialos/subscriptions","organizations_url":"https://api.github.com/users/spatialos/orgs","repos_url":"https://api.github.com/users/spatialos/repos","events_url":"https://api.github.com/users/spatialos/events{/privacy}","received_events_url":"https://api.github.com/users/spatialos/received_events","type":"Organization","site_admin":false},"repo":{"id":137235993,"node_id":"MDEwOlJlcG9zaXRvcnkxMzcyMzU5OTM=","name":"UnityGDK","full_name":"spatialos/UnityGDK","owner":{"login":"spatialos","id":23554165,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTU0MTY1","avatar_url":"https://avatars2.githubusercontent.com/u/23554165?v=4","gravatar_id":"","url":"https://api.github.com/users/spatialos","html_url":"https://github.com/spatialos","followers_url":"https://api.github.com/users/spatialos/followers","following_url":"https://api.github.com/users/spatialos/following{/other_user}","gists_url":"https://api.github.com/users/spatialos/gists{/gist_id}","starred_url":"https://api.github.com/users/spatialos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spatialos/subscriptions","organizations_url":"https://api.github.com/users/spatialos/orgs","repos_url":"https://api.github.com/users/spatialos/repos","events_url":"https://api.github.com/users/spatialos/events{/privacy}","received_events_url":"https://api.github.com/users/spatialos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spatialos/UnityGDK","description":"Unity GDK","fork":false,"url":"https://api.github.com/repos/spatialos/UnityGDK","forks_url":"https://api.github.com/repos/spatialos/UnityGDK/forks","keys_url":"https://api.github.com/repos/spatialos/UnityGDK/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spatialos/UnityGDK/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spatialos/UnityGDK/teams","hooks_url":"https://api.github.com/repos/spatialos/UnityGDK/hooks","issue_events_url":"https://api.github.com/repos/spatialos/UnityGDK/issues/events{/number}","events_url":"https://api.github.com/repos/spatialos/UnityGDK/events","assignees_url":"https://api.github.com/repos/spatialos/UnityGDK/assignees{/user}","branches_url":"https://api.github.com/repos/spatialos/UnityGDK/branches{/branch}","tags_url":"https://api.github.com/repos/spatialos/UnityGDK/tags","blobs_url":"https://api.github.com/repos/spatialos/UnityGDK/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spatialos/UnityGDK/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spatialos/UnityGDK/git/refs{/sha}","trees_url":"https://api.github.com/repos/spatialos/UnityGDK/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spatialos/UnityGDK/statuses/{sha}","languages_url":"https://api.github.com/repos/spatialos/UnityGDK/languages","stargazers_url":"https://api.github.com/repos/spatialos/UnityGDK/stargazers","contributors_url":"https://api.github.com/repos/spatialos/UnityGDK/contributors","subscribers_url":"https://api.github.com/repos/spatialos/UnityGDK/subscribers","subscription_url":"https://api.github.com/repos/spatialos/UnityGDK/subscription","commits_url":"https://api.github.com/repos/spatialos/UnityGDK/commits{/sha}","git_commits_url":"https://api.github.com/repos/spatialos/UnityGDK/git/commits{/sha}","comments_url":"https://api.github.com/repos/spatialos/UnityGDK/comments{/number}","issue_comment_url":"https://api.github.com/repos/spatialos/UnityGDK/issues/comments{/number}","contents_url":"https://api.github.com/repos/spatialos/UnityGDK/contents/{+path}","compare_url":"https://api.github.com/repos/spatialos/UnityGDK/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spatialos/UnityGDK/merges","archive_url":"https://api.github.com/repos/spatialos/UnityGDK/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spatialos/UnityGDK/downloads","issues_url":"https://api.github.com/repos/spatialos/UnityGDK/issues{/number}","pulls_url":"https://api.github.com/repos/spatialos/UnityGDK/pulls{/number}","milestones_url":"https://api.github.com/repos/spatialos/UnityGDK/milestones{/number}","notifications_url":"https://api.github.com/repos/spatialos/UnityGDK/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spatialos/UnityGDK/labels{/name}","releases_url":"https://api.github.com/repos/spatialos/UnityGDK/releases{/id}","deployments_url":"https://api.github.com/repos/spatialos/UnityGDK/deployments","created_at":"2018-06-13T15:37:54Z","updated_at":"2018-08-28T14:34:40Z","pushed_at":"2018-08-28T16:23:45Z","git_url":"git://github.com/spatialos/UnityGDK.git","ssh_url":"git@github.com:spatialos/UnityGDK.git","clone_url":"https://github.com/spatialos/UnityGDK.git","svn_url":"https://github.com/spatialos/UnityGDK","homepage":null,"size":187826,"stargazers_count":82,"watchers_count":82,"language":"C#","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":5,"open_issues":14,"watchers":82,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spatialos/UnityGDK/pulls/243"},"html":{"href":"https://github.com/spatialos/UnityGDK/pull/243"},"issue":{"href":"https://api.github.com/repos/spatialos/UnityGDK/issues/243"},"comments":{"href":"https://api.github.com/repos/spatialos/UnityGDK/issues/243/comments"},"review_comments":{"href":"https://api.github.com/repos/spatialos/UnityGDK/pulls/243/comments"},"review_comment":{"href":"https://api.github.com/repos/spatialos/UnityGDK/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spatialos/UnityGDK/pulls/243/commits"},"statuses":{"href":"https://api.github.com/repos/spatialos/UnityGDK/statuses/4ff6f56bef4418510034b5d63b337f20b8369213"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ElleEss"}}