{"action":"created","comment":{"url":"https://api.github.com/repos/vinyldns/vinyldns/pulls/comments/219989100","pull_request_review_id":158295364,"id":219989100,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxOTk4OTEwMA==","diff_hunk":"@@ -307,6 +307,7 @@ lazy val portal = (project in file(\"modules/portal\")).enablePlugins(PlayScala, A\n     libraryDependencies ++= portalDependencies,\n     routesGenerator := InjectedRoutesGenerator,\n     coverageMinimum := 75,\n+    coverageFailOnMinimum := false,","path":"build.sbt","position":4,"original_position":4,"commit_id":"dc4e0b90cb7b3cfba0cddb5bf6c27b917ea3933e","original_commit_id":"dc4e0b90cb7b3cfba0cddb5bf6c27b917ea3933e","user":{"login":"rebstar6","id":4467125,"node_id":"MDQ6VXNlcjQ0NjcxMjU=","avatar_url":"https://avatars3.githubusercontent.com/u/4467125?v=4","gravatar_id":"","url":"https://api.github.com/users/rebstar6","html_url":"https://github.com/rebstar6","followers_url":"https://api.github.com/users/rebstar6/followers","following_url":"https://api.github.com/users/rebstar6/following{/other_user}","gists_url":"https://api.github.com/users/rebstar6/gists{/gist_id}","starred_url":"https://api.github.com/users/rebstar6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rebstar6/subscriptions","organizations_url":"https://api.github.com/users/rebstar6/orgs","repos_url":"https://api.github.com/users/rebstar6/repos","events_url":"https://api.github.com/users/rebstar6/events{/privacy}","received_events_url":"https://api.github.com/users/rebstar6/received_events","type":"User","site_admin":false},"body":"why have a minimum if we dont fail on it?\r\n\r\nwhere are we on coverage now in the portal? id rather lower the minimum if we have to now then just not fail when we hit it","created_at":"2018-09-24T21:05:34Z","updated_at":"2018-09-24T21:05:34Z","html_url":"https://github.com/vinyldns/vinyldns/pull/186#discussion_r219989100","pull_request_url":"https://api.github.com/repos/vinyldns/vinyldns/pulls/186","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/vinyldns/vinyldns/pulls/comments/219989100"},"html":{"href":"https://github.com/vinyldns/vinyldns/pull/186#discussion_r219989100"},"pull_request":{"href":"https://api.github.com/repos/vinyldns/vinyldns/pulls/186"}}},"pull_request":{"url":"https://api.github.com/repos/vinyldns/vinyldns/pulls/186","id":214044627,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0MDQ0NjI3","html_url":"https://github.com/vinyldns/vinyldns/pull/186","diff_url":"https://github.com/vinyldns/vinyldns/pull/186.diff","patch_url":"https://github.com/vinyldns/vinyldns/pull/186.patch","issue_url":"https://api.github.com/repos/vinyldns/vinyldns/issues/186","number":186,"state":"open","locked":false,"title":"Portal lock users take 2","user":{"login":"britneywright","id":4439228,"node_id":"MDQ6VXNlcjQ0MzkyMjg=","avatar_url":"https://avatars2.githubusercontent.com/u/4439228?v=4","gravatar_id":"","url":"https://api.github.com/users/britneywright","html_url":"https://github.com/britneywright","followers_url":"https://api.github.com/users/britneywright/followers","following_url":"https://api.github.com/users/britneywright/following{/other_user}","gists_url":"https://api.github.com/users/britneywright/gists{/gist_id}","starred_url":"https://api.github.com/users/britneywright/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/britneywright/subscriptions","organizations_url":"https://api.github.com/users/britneywright/orgs","repos_url":"https://api.github.com/users/britneywright/repos","events_url":"https://api.github.com/users/britneywright/events{/privacy}","received_events_url":"https://api.github.com/users/britneywright/received_events","type":"User","site_admin":false},"body":"Based on @pauljamescleary PR I added the check of the user's \"isLocked\" attribute in the custom action builders. There's two action builders now, one for the API and one for the Frontend. It might be overkill to have the custom action on the api calls in VinylDNS.scala with it handled in the views and the API itself will check the user account when that PR is merged. I didn't update the tests yet with that in mind.\r\n\r\nOverall I like the custom action builder approach. reduced a lot of redundancy in the code. ","created_at":"2018-09-07T21:31:57Z","updated_at":"2018-09-24T21:05:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ce3b32ba9e81b7bbc153e3436f7433a8c820c255","assignee":{"login":"britneywright","id":4439228,"node_id":"MDQ6VXNlcjQ0MzkyMjg=","avatar_url":"https://avatars2.githubusercontent.com/u/4439228?v=4","gravatar_id":"","url":"https://api.github.com/users/britneywright","html_url":"https://github.com/britneywright","followers_url":"https://api.github.com/users/britneywright/followers","following_url":"https://api.github.com/users/britneywright/following{/other_user}","gists_url":"https://api.github.com/users/britneywright/gists{/gist_id}","starred_url":"https://api.github.com/users/britneywright/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/britneywright/subscriptions","organizations_url":"https://api.github.com/users/britneywright/orgs","repos_url":"https://api.github.com/users/britneywright/repos","events_url":"https://api.github.com/users/britneywright/events{/privacy}","received_events_url":"https://api.github.com/users/britneywright/received_events","type":"User","site_admin":false},"assignees":[{"login":"britneywright","id":4439228,"node_id":"MDQ6VXNlcjQ0MzkyMjg=","avatar_url":"https://avatars2.githubusercontent.com/u/4439228?v=4","gravatar_id":"","url":"https://api.github.com/users/britneywright","html_url":"https://github.com/britneywright","followers_url":"https://api.github.com/users/britneywright/followers","following_url":"https://api.github.com/users/britneywright/following{/other_user}","gists_url":"https://api.github.com/users/britneywright/gists{/gist_id}","starred_url":"https://api.github.com/users/britneywright/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/britneywright/subscriptions","organizations_url":"https://api.github.com/users/britneywright/orgs","repos_url":"https://api.github.com/users/britneywright/repos","events_url":"https://api.github.com/users/britneywright/events{/privacy}","received_events_url":"https://api.github.com/users/britneywright/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/vinyldns/vinyldns/pulls/186/commits","review_comments_url":"https://api.github.com/repos/vinyldns/vinyldns/pulls/186/comments","review_comment_url":"https://api.github.com/repos/vinyldns/vinyldns/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vinyldns/vinyldns/issues/186/comments","statuses_url":"https://api.github.com/repos/vinyldns/vinyldns/statuses/dc4e0b90cb7b3cfba0cddb5bf6c27b917ea3933e","head":{"label":"britneywright:portal-lock-uers-take-2","ref":"portal-lock-uers-take-2","sha":"dc4e0b90cb7b3cfba0cddb5bf6c27b917ea3933e","user":{"login":"britneywright","id":4439228,"node_id":"MDQ6VXNlcjQ0MzkyMjg=","avatar_url":"https://avatars2.githubusercontent.com/u/4439228?v=4","gravatar_id":"","url":"https://api.github.com/users/britneywright","html_url":"https://github.com/britneywright","followers_url":"https://api.github.com/users/britneywright/followers","following_url":"https://api.github.com/users/britneywright/following{/other_user}","gists_url":"https://api.github.com/users/britneywright/gists{/gist_id}","starred_url":"https://api.github.com/users/britneywright/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/britneywright/subscriptions","organizations_url":"https://api.github.com/users/britneywright/orgs","repos_url":"https://api.github.com/users/britneywright/repos","events_url":"https://api.github.com/users/britneywright/events{/privacy}","received_events_url":"https://api.github.com/users/britneywright/received_events","type":"User","site_admin":false},"repo":{"id":142593271,"node_id":"MDEwOlJlcG9zaXRvcnkxNDI1OTMyNzE=","name":"vinyldns","full_name":"britneywright/vinyldns","private":false,"owner":{"login":"britneywright","id":4439228,"node_id":"MDQ6VXNlcjQ0MzkyMjg=","avatar_url":"https://avatars2.githubusercontent.com/u/4439228?v=4","gravatar_id":"","url":"https://api.github.com/users/britneywright","html_url":"https://github.com/britneywright","followers_url":"https://api.github.com/users/britneywright/followers","following_url":"https://api.github.com/users/britneywright/following{/other_user}","gists_url":"https://api.github.com/users/britneywright/gists{/gist_id}","starred_url":"https://api.github.com/users/britneywright/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/britneywright/subscriptions","organizations_url":"https://api.github.com/users/britneywright/orgs","repos_url":"https://api.github.com/users/britneywright/repos","events_url":"https://api.github.com/users/britneywright/events{/privacy}","received_events_url":"https://api.github.com/users/britneywright/received_events","type":"User","site_admin":false},"html_url":"https://github.com/britneywright/vinyldns","description":"Vendor agnostic DNS front-end for managing DNS self-service across your systems.","fork":true,"url":"https://api.github.com/repos/britneywright/vinyldns","forks_url":"https://api.github.com/repos/britneywright/vinyldns/forks","keys_url":"https://api.github.com/repos/britneywright/vinyldns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/britneywright/vinyldns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/britneywright/vinyldns/teams","hooks_url":"https://api.github.com/repos/britneywright/vinyldns/hooks","issue_events_url":"https://api.github.com/repos/britneywright/vinyldns/issues/events{/number}","events_url":"https://api.github.com/repos/britneywright/vinyldns/events","assignees_url":"https://api.github.com/repos/britneywright/vinyldns/assignees{/user}","branches_url":"https://api.github.com/repos/britneywright/vinyldns/branches{/branch}","tags_url":"https://api.github.com/repos/britneywright/vinyldns/tags","blobs_url":"https://api.github.com/repos/britneywright/vinyldns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/britneywright/vinyldns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/britneywright/vinyldns/git/refs{/sha}","trees_url":"https://api.github.com/repos/britneywright/vinyldns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/britneywright/vinyldns/statuses/{sha}","languages_url":"https://api.github.com/repos/britneywright/vinyldns/languages","stargazers_url":"https://api.github.com/repos/britneywright/vinyldns/stargazers","contributors_url":"https://api.github.com/repos/britneywright/vinyldns/contributors","subscribers_url":"https://api.github.com/repos/britneywright/vinyldns/subscribers","subscription_url":"https://api.github.com/repos/britneywright/vinyldns/subscription","commits_url":"https://api.github.com/repos/britneywright/vinyldns/commits{/sha}","git_commits_url":"https://api.github.com/repos/britneywright/vinyldns/git/commits{/sha}","comments_url":"https://api.github.com/repos/britneywright/vinyldns/comments{/number}","issue_comment_url":"https://api.github.com/repos/britneywright/vinyldns/issues/comments{/number}","contents_url":"https://api.github.com/repos/britneywright/vinyldns/contents/{+path}","compare_url":"https://api.github.com/repos/britneywright/vinyldns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/britneywright/vinyldns/merges","archive_url":"https://api.github.com/repos/britneywright/vinyldns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/britneywright/vinyldns/downloads","issues_url":"https://api.github.com/repos/britneywright/vinyldns/issues{/number}","pulls_url":"https://api.github.com/repos/britneywright/vinyldns/pulls{/number}","milestones_url":"https://api.github.com/repos/britneywright/vinyldns/milestones{/number}","notifications_url":"https://api.github.com/repos/britneywright/vinyldns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/britneywright/vinyldns/labels{/name}","releases_url":"https://api.github.com/repos/britneywright/vinyldns/releases{/id}","deployments_url":"https://api.github.com/repos/britneywright/vinyldns/deployments","created_at":"2018-07-27T15:18:39Z","updated_at":"2018-09-24T19:48:31Z","pushed_at":"2018-09-24T20:49:19Z","git_url":"git://github.com/britneywright/vinyldns.git","ssh_url":"git@github.com:britneywright/vinyldns.git","clone_url":"https://github.com/britneywright/vinyldns.git","svn_url":"https://github.com/britneywright/vinyldns","homepage":"","size":8581,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"vinyldns:master","ref":"master","sha":"bc63c79e092bc0ab5c72016c0fcca00862429f7e","user":{"login":"vinyldns","id":40363296,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwMzYzMjk2","avatar_url":"https://avatars0.githubusercontent.com/u/40363296?v=4","gravatar_id":"","url":"https://api.github.com/users/vinyldns","html_url":"https://github.com/vinyldns","followers_url":"https://api.github.com/users/vinyldns/followers","following_url":"https://api.github.com/users/vinyldns/following{/other_user}","gists_url":"https://api.github.com/users/vinyldns/gists{/gist_id}","starred_url":"https://api.github.com/users/vinyldns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vinyldns/subscriptions","organizations_url":"https://api.github.com/users/vinyldns/orgs","repos_url":"https://api.github.com/users/vinyldns/repos","events_url":"https://api.github.com/users/vinyldns/events{/privacy}","received_events_url":"https://api.github.com/users/vinyldns/received_events","type":"Organization","site_admin":false},"repo":{"id":142474323,"node_id":"MDEwOlJlcG9zaXRvcnkxNDI0NzQzMjM=","name":"vinyldns","full_name":"vinyldns/vinyldns","private":false,"owner":{"login":"vinyldns","id":40363296,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwMzYzMjk2","avatar_url":"https://avatars0.githubusercontent.com/u/40363296?v=4","gravatar_id":"","url":"https://api.github.com/users/vinyldns","html_url":"https://github.com/vinyldns","followers_url":"https://api.github.com/users/vinyldns/followers","following_url":"https://api.github.com/users/vinyldns/following{/other_user}","gists_url":"https://api.github.com/users/vinyldns/gists{/gist_id}","starred_url":"https://api.github.com/users/vinyldns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vinyldns/subscriptions","organizations_url":"https://api.github.com/users/vinyldns/orgs","repos_url":"https://api.github.com/users/vinyldns/repos","events_url":"https://api.github.com/users/vinyldns/events{/privacy}","received_events_url":"https://api.github.com/users/vinyldns/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/vinyldns/vinyldns","description":"Vendor agnostic DNS front-end for streamlining DNS operations and enabling self-service for your DNS infrastructure","fork":false,"url":"https://api.github.com/repos/vinyldns/vinyldns","forks_url":"https://api.github.com/repos/vinyldns/vinyldns/forks","keys_url":"https://api.github.com/repos/vinyldns/vinyldns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vinyldns/vinyldns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vinyldns/vinyldns/teams","hooks_url":"https://api.github.com/repos/vinyldns/vinyldns/hooks","issue_events_url":"https://api.github.com/repos/vinyldns/vinyldns/issues/events{/number}","events_url":"https://api.github.com/repos/vinyldns/vinyldns/events","assignees_url":"https://api.github.com/repos/vinyldns/vinyldns/assignees{/user}","branches_url":"https://api.github.com/repos/vinyldns/vinyldns/branches{/branch}","tags_url":"https://api.github.com/repos/vinyldns/vinyldns/tags","blobs_url":"https://api.github.com/repos/vinyldns/vinyldns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vinyldns/vinyldns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vinyldns/vinyldns/git/refs{/sha}","trees_url":"https://api.github.com/repos/vinyldns/vinyldns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vinyldns/vinyldns/statuses/{sha}","languages_url":"https://api.github.com/repos/vinyldns/vinyldns/languages","stargazers_url":"https://api.github.com/repos/vinyldns/vinyldns/stargazers","contributors_url":"https://api.github.com/repos/vinyldns/vinyldns/contributors","subscribers_url":"https://api.github.com/repos/vinyldns/vinyldns/subscribers","subscription_url":"https://api.github.com/repos/vinyldns/vinyldns/subscription","commits_url":"https://api.github.com/repos/vinyldns/vinyldns/commits{/sha}","git_commits_url":"https://api.github.com/repos/vinyldns/vinyldns/git/commits{/sha}","comments_url":"https://api.github.com/repos/vinyldns/vinyldns/comments{/number}","issue_comment_url":"https://api.github.com/repos/vinyldns/vinyldns/issues/comments{/number}","contents_url":"https://api.github.com/repos/vinyldns/vinyldns/contents/{+path}","compare_url":"https://api.github.com/repos/vinyldns/vinyldns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vinyldns/vinyldns/merges","archive_url":"https://api.github.com/repos/vinyldns/vinyldns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vinyldns/vinyldns/downloads","issues_url":"https://api.github.com/repos/vinyldns/vinyldns/issues{/number}","pulls_url":"https://api.github.com/repos/vinyldns/vinyldns/pulls{/number}","milestones_url":"https://api.github.com/repos/vinyldns/vinyldns/milestones{/number}","notifications_url":"https://api.github.com/repos/vinyldns/vinyldns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vinyldns/vinyldns/labels{/name}","releases_url":"https://api.github.com/repos/vinyldns/vinyldns/releases{/id}","deployments_url":"https://api.github.com/repos/vinyldns/vinyldns/deployments","created_at":"2018-07-26T17:43:18Z","updated_at":"2018-09-24T20:55:17Z","pushed_at":"2018-09-24T20:55:16Z","git_url":"git://github.com/vinyldns/vinyldns.git","ssh_url":"git@github.com:vinyldns/vinyldns.git","clone_url":"https://github.com/vinyldns/vinyldns.git","svn_url":"https://github.com/vinyldns/vinyldns","homepage":"http://vinyldns.io/","size":9585,"stargazers_count":111,"watchers_count":111,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":57,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":18,"open_issues":57,"watchers":111,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vinyldns/vinyldns/pulls/186"},"html":{"href":"https://github.com/vinyldns/vinyldns/pull/186"},"issue":{"href":"https://api.github.com/repos/vinyldns/vinyldns/issues/186"},"comments":{"href":"https://api.github.com/repos/vinyldns/vinyldns/issues/186/comments"},"review_comments":{"href":"https://api.github.com/repos/vinyldns/vinyldns/pulls/186/comments"},"review_comment":{"href":"https://api.github.com/repos/vinyldns/vinyldns/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vinyldns/vinyldns/pulls/186/commits"},"statuses":{"href":"https://api.github.com/repos/vinyldns/vinyldns/statuses/dc4e0b90cb7b3cfba0cddb5bf6c27b917ea3933e"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"rebstar6"}}