{"action":"created","issue":{"url":"https://api.github.com/repos/flathub/flathub/issues/717","repository_url":"https://api.github.com/repos/flathub/flathub","labels_url":"https://api.github.com/repos/flathub/flathub/issues/717/labels{/name}","comments_url":"https://api.github.com/repos/flathub/flathub/issues/717/comments","events_url":"https://api.github.com/repos/flathub/flathub/issues/717/events","html_url":"https://github.com/flathub/flathub/pull/717","id":379941346,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwMjU5ODk2","number":717,"title":"add io.github.rinigus.PureMaps","user":{"login":"rinigus","id":15706605,"node_id":"MDQ6VXNlcjE1NzA2NjA1","avatar_url":"https://avatars1.githubusercontent.com/u/15706605?v=4","gravatar_id":"","url":"https://api.github.com/users/rinigus","html_url":"https://github.com/rinigus","followers_url":"https://api.github.com/users/rinigus/followers","following_url":"https://api.github.com/users/rinigus/following{/other_user}","gists_url":"https://api.github.com/users/rinigus/gists{/gist_id}","starred_url":"https://api.github.com/users/rinigus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rinigus/subscriptions","organizations_url":"https://api.github.com/users/rinigus/orgs","repos_url":"https://api.github.com/users/rinigus/repos","events_url":"https://api.github.com/users/rinigus/events{/privacy}","received_events_url":"https://api.github.com/users/rinigus/received_events","type":"User","site_admin":false},"labels":[{"id":696244970,"node_id":"MDU6TGFiZWw2OTYyNDQ5NzA=","url":"https://api.github.com/repos/flathub/flathub/labels/work-in-progress","name":"work-in-progress","color":"0052cc","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":28,"created_at":"2018-11-12T20:32:26Z","updated_at":"2018-11-19T19:42:49Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/flathub/flathub/pulls/717","html_url":"https://github.com/flathub/flathub/pull/717","diff_url":"https://github.com/flathub/flathub/pull/717.diff","patch_url":"https://github.com/flathub/flathub/pull/717.patch"},"body":"This is to add [Pure Maps](https://github.com/rinigus/pure-maps) to Flathub.\r\n\r\nPure Maps is a map application used on Sailfish OS for viewing & searching maps, finding routes, and navigation along them. When compared to Sailfish version, this version is stripped of online provider's API keys. This is to avoid running out of free quotas and effectively deny SFOS users access to maps. However, each user can specify personal API keys via Preferences.\r\n\r\nWhile on normal desktop usage is limited to checking out maps, on Linux setups with GPS this can be used as a full blown navigation program.\r\n\r\nThe current version has 2 problems that I hope someone can help to resolve.\r\n\r\n1. I don't know how to specify location permissions for flatpak. Since its a mapping application, this permission is needed. I couldn't test whether GPS location can be obtained on PC using Kde/5.11 platform either - don't have GPS hooked to PC.\r\n\r\n2. For some reason, local builds fail if I enable `install -D packaging/pure-maps.appdata.xml /app/share/appdata/io.github.rinigus.PureMaps.appdata.xml` at the end of JSON with \r\n```\r\nRenaming icon hicolor/256x256/apps/pure-maps.png to hicolor/256x256/apps/io.github.rinigus.PureMaps.png\r\nRenaming icon hicolor/86x86/apps/pure-maps.png to hicolor/86x86/apps/io.github.rinigus.PureMaps.png\r\nRenaming icon hicolor/128x128/apps/pure-maps.png to hicolor/128x128/apps/io.github.rinigus.PureMaps.png\r\nRenaming icon hicolor/108x108/apps/pure-maps.png to hicolor/108x108/apps/io.github.rinigus.PureMaps.png\r\nRewriting contents of io.github.rinigus.PureMaps.desktop\r\nRunning appstream-compose\r\nProcessing application io.github.rinigus.PureMaps\r\nError loading desktop file: Failed to find icon: Failed to find icon io.github.rinigus.PureMaps\r\nError: ERROR: appstream-compose failed: Child process exited with code 1\r\n```\r\nThe icons seem to be all there and I couldn't spot something strange in JSON or appdata XML. \r\n\r\nInstead of trying to resolve these issues, I am asking for review and help with this submission. Note that I'll be out of office for 2 days and my replies maybe delayed till that time.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/flathub/flathub/issues/comments/440017642","html_url":"https://github.com/flathub/flathub/pull/717#issuecomment-440017642","issue_url":"https://api.github.com/repos/flathub/flathub/issues/717","id":440017642,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MDAxNzY0Mg==","user":{"login":"barthalion","id":380403,"node_id":"MDQ6VXNlcjM4MDQwMw==","avatar_url":"https://avatars3.githubusercontent.com/u/380403?v=4","gravatar_id":"","url":"https://api.github.com/users/barthalion","html_url":"https://github.com/barthalion","followers_url":"https://api.github.com/users/barthalion/followers","following_url":"https://api.github.com/users/barthalion/following{/other_user}","gists_url":"https://api.github.com/users/barthalion/gists{/gist_id}","starred_url":"https://api.github.com/users/barthalion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/barthalion/subscriptions","organizations_url":"https://api.github.com/users/barthalion/orgs","repos_url":"https://api.github.com/users/barthalion/repos","events_url":"https://api.github.com/users/barthalion/events{/privacy}","received_events_url":"https://api.github.com/users/barthalion/received_events","type":"User","site_admin":false},"created_at":"2018-11-19T19:42:49Z","updated_at":"2018-11-19T19:42:49Z","author_association":"MEMBER","body":"Yeah, I agree there's no point in waiting. I'll merge it tomorrow morning if nobody beats me to it."}}
{"actor":{"display_login":"barthalion"}}