{"push_id":2804143344,"size":2,"distinct_size":2,"ref":"refs/heads/master","head":"018c91200c2ffad26f3fdee0cb9a90d0b0671c88","before":"6685acb9a4e71e42296c018d688450e4f11dba54","commits":[{"sha":"6a5939f62f1dea811fd2812b5a5e6d0ea2928ad2","author":{"name":"Tobi Akomolede","email":"5247504e21a74d3a5b83080bb8a05f1613b47c72@fb.com"},"message":"fb-intl-fbt-str Rx1: Using Rx Observable on client cache to auto update FbtPanelWorkspaceView\n\nSummary: This diff ties the `FbtStringBundleRoot`'s props to an observable, such that they update whenever a new bundle has been cached. This fixes a bug that required you to close the FBT pane in order to see new FBT strings after extraction.\n\nReviewed By: kayhadrin\n\nDifferential Revision: D9272296\n\nfbshipit-source-id: fccea85d58959ca5236be0dcc2dc1afa69806a26","distinct":true,"url":"https://api.github.com/repos/atxwebs/nuclide/commits/6a5939f62f1dea811fd2812b5a5e6d0ea2928ad2"},{"sha":"018c91200c2ffad26f3fdee0cb9a90d0b0671c88","author":{"name":"Tobi Akomolede","email":"5247504e21a74d3a5b83080bb8a05f1613b47c72@fb.com"},"message":"fb-intl-fbt-str Rx 2: get translation info using Rx Observable rather than having asnyc code in UI\n\nSummary:\nBefore we were using an async function call in the `FbtStringBundleRoot` UI component. This is a bit of an anti-pattern. Thus we fix this by moving the `translationInfo` into a part of the `FbtStringBundleRoot`'s properties, and then we bind this component using an `Observable`. This `Observable` emits events in the following cases:\n1) When we query the FbtBundle cache\n2) When we query the translation info cache\n\nWe also modify `getOrCreateFbtBundleTranslationInfo` such that it gets translation information for the full FbtBundle (rather than the bundle passed as a parameter), so that when we update the observables for a given file path (we'll have an observable for each selection-extraction for the file), it updates for the full mapping of hashes to translation info.\n\nReviewed By: kayhadrin\n\nDifferential Revision: D9308005\n\nfbshipit-source-id: 459fb6218f35bb3093ebea1d3762d564c42a8e9c","distinct":true,"url":"https://api.github.com/repos/atxwebs/nuclide/commits/018c91200c2ffad26f3fdee0cb9a90d0b0671c88"}]}
{"actor":{"display_login":"pull"}}