{"action":"opened","issue":{"url":"https://api.github.com/repos/vitotai/BrewManiacEsp8266/issues/34","repository_url":"https://api.github.com/repos/vitotai/BrewManiacEsp8266","labels_url":"https://api.github.com/repos/vitotai/BrewManiacEsp8266/issues/34/labels{/name}","comments_url":"https://api.github.com/repos/vitotai/BrewManiacEsp8266/issues/34/comments","events_url":"https://api.github.com/repos/vitotai/BrewManiacEsp8266/issues/34/events","html_url":"https://github.com/vitotai/BrewManiacEsp8266/issues/34","id":377132643,"node_id":"MDU6SXNzdWUzNzcxMzI2NDM=","number":34,"title":"issue with PID parameter scaling","user":{"login":"lekrom","id":20283041,"node_id":"MDQ6VXNlcjIwMjgzMDQx","avatar_url":"https://avatars3.githubusercontent.com/u/20283041?v=4","gravatar_id":"","url":"https://api.github.com/users/lekrom","html_url":"https://github.com/lekrom","followers_url":"https://api.github.com/users/lekrom/followers","following_url":"https://api.github.com/users/lekrom/following{/other_user}","gists_url":"https://api.github.com/users/lekrom/gists{/gist_id}","starred_url":"https://api.github.com/users/lekrom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lekrom/subscriptions","organizations_url":"https://api.github.com/users/lekrom/orgs","repos_url":"https://api.github.com/users/lekrom/repos","events_url":"https://api.github.com/users/lekrom/events{/privacy}","received_events_url":"https://api.github.com/users/lekrom/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-11-04T09:34:33Z","updated_at":"2018-11-04T09:34:33Z","closed_at":null,"author_association":"NONE","body":"Hi Vito. Great work on the latest BM. I have upgraded my system from the old arduino BM to the latest BMex. There is however something i would like to recommend. I realise the temp control stuff came from open ardbir,  but there is an issue in their original PID parameters. Firstly, negative PID coefficients are not allowed and makes no sense in my opinion. I realise that the actual paramers are scaled and shifted to account for this. The issue is that the way the parameters are displayd makes it not very intuitive to tune. Also, at least in my system, the kD parameter can not be set correctly. Analysing the amplitude an period when performing the autotune implies I need a kD of 5000-ish. Not possible with the current scaling, it overflows and the stored kD is incorrect. I have hacked the code on my arduino version to fix this. Without this hack my system tends to overshoot a bit. The kP and kI values are correctly obtained from the autune. Regard, Lekrom."}}
{"actor":{"display_login":"lekrom"}}