{"action":"created","comment":{"url":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/comments/181138801","pull_request_review_id":111689077,"id":181138801,"diff_hunk":"@@ -144,25 +144,3 @@ bool Sub::far_from_EKF_origin(const Location& loc)\n     // close enough to origin\n     return false;\n }\n-\n-// checks if we should update ahrs/RTL home position from GPS\n-void Sub::set_system_time_from_GPS()\n-{\n-    // exit immediately if system time already set\n-    if (hal.util->system_time_was_set()) {\n-        return;\n-    }\n-\n-    // if we have a 3d lock and valid location\n-    if (gps.status() >= AP_GPS::GPS_OK_FIX_3D) {\n-        uint64_t gps_timestamp = gps.time_epoch_usec();\n-\n-        // set system clock for log timestamps\n-        hal.util->set_system_clock(gps_timestamp);\n-\n-        // update signing timestamp\n-        GCS_MAVLINK::update_signing_timestamp(gps_timestamp);\n-\n-        Log_Write_Event(DATA_SYSTEM_TIME_SET);","path":"ArduSub/commands.cpp","position":null,"original_position":23,"commit_id":"000df4263413de49a94871c650b7bb4d781d1317","original_commit_id":"0acb4505ceb5b058a6ce1c22edce2b5763c85220","user":{"login":"OXINARF","id":1778527,"avatar_url":"https://avatars2.githubusercontent.com/u/1778527?v=4","gravatar_id":"","url":"https://api.github.com/users/OXINARF","html_url":"https://github.com/OXINARF","followers_url":"https://api.github.com/users/OXINARF/followers","following_url":"https://api.github.com/users/OXINARF/following{/other_user}","gists_url":"https://api.github.com/users/OXINARF/gists{/gist_id}","starred_url":"https://api.github.com/users/OXINARF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OXINARF/subscriptions","organizations_url":"https://api.github.com/users/OXINARF/orgs","repos_url":"https://api.github.com/users/OXINARF/repos","events_url":"https://api.github.com/users/OXINARF/events{/privacy}","received_events_url":"https://api.github.com/users/OXINARF/received_events","type":"User","site_admin":false},"body":"Same.","created_at":"2018-04-12T16:11:39Z","updated_at":"2018-04-12T16:17:25Z","html_url":"https://github.com/ArduPilot/ardupilot/pull/8121#discussion_r181138801","pull_request_url":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/8121","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/comments/181138801"},"html":{"href":"https://github.com/ArduPilot/ardupilot/pull/8121#discussion_r181138801"},"pull_request":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/8121"}}},"pull_request":{"url":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/8121","id":180486326,"html_url":"https://github.com/ArduPilot/ardupilot/pull/8121","diff_url":"https://github.com/ArduPilot/ardupilot/pull/8121.diff","patch_url":"https://github.com/ArduPilot/ardupilot/pull/8121.patch","issue_url":"https://api.github.com/repos/ArduPilot/ardupilot/issues/8121","number":8121,"state":"open","locked":false,"title":"Set time","user":{"login":"peterbarker","id":7077857,"avatar_url":"https://avatars0.githubusercontent.com/u/7077857?v=4","gravatar_id":"","url":"https://api.github.com/users/peterbarker","html_url":"https://github.com/peterbarker","followers_url":"https://api.github.com/users/peterbarker/followers","following_url":"https://api.github.com/users/peterbarker/following{/other_user}","gists_url":"https://api.github.com/users/peterbarker/gists{/gist_id}","starred_url":"https://api.github.com/users/peterbarker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterbarker/subscriptions","organizations_url":"https://api.github.com/users/peterbarker/orgs","repos_url":"https://api.github.com/users/peterbarker/repos","events_url":"https://api.github.com/users/peterbarker/events{/privacy}","received_events_url":"https://api.github.com/users/peterbarker/received_events","type":"User","site_admin":false},"body":"This is based on @patrickelectric 's work #7716\r\n\r\nThis is attempting to address two points:\r\n - tridge didn't like the #ifdefs for the different platforms we support.  Sadly, most pretend to do the `clock_gettime()` thing, so pushing this to the seperate HALs  has multiplied the code a bit.\r\n - Using ChibiOS time functions isn't a great move.  I grabbed @night-ghost's code from F4Light which just keeps a delta between the epoch and boot times.\r\n","created_at":"2018-04-10T04:22:50Z","updated_at":"2018-04-12T16:17:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bdd3ed0107fe3684bfffd9c02305b6cafc7664cb","assignee":null,"assignees":[],"requested_reviewers":[{"login":"tridge","id":831867,"avatar_url":"https://avatars2.githubusercontent.com/u/831867?v=4","gravatar_id":"","url":"https://api.github.com/users/tridge","html_url":"https://github.com/tridge","followers_url":"https://api.github.com/users/tridge/followers","following_url":"https://api.github.com/users/tridge/following{/other_user}","gists_url":"https://api.github.com/users/tridge/gists{/gist_id}","starred_url":"https://api.github.com/users/tridge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tridge/subscriptions","organizations_url":"https://api.github.com/users/tridge/orgs","repos_url":"https://api.github.com/users/tridge/repos","events_url":"https://api.github.com/users/tridge/events{/privacy}","received_events_url":"https://api.github.com/users/tridge/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":24269224,"url":"https://api.github.com/repos/ArduPilot/ardupilot/labels/Copter","name":"Copter","color":"02e10c","default":false},{"id":136051782,"url":"https://api.github.com/repos/ArduPilot/ardupilot/labels/Library","name":"Library","color":"f7c6c7","default":false},{"id":24269282,"url":"https://api.github.com/repos/ArduPilot/ardupilot/labels/Rover","name":"Rover","color":"B36F30","default":false},{"id":530490772,"url":"https://api.github.com/repos/ArduPilot/ardupilot/labels/Sub","name":"Sub","color":"36C9E4","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/8121/commits","review_comments_url":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/8121/comments","review_comment_url":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ArduPilot/ardupilot/issues/8121/comments","statuses_url":"https://api.github.com/repos/ArduPilot/ardupilot/statuses/000df4263413de49a94871c650b7bb4d781d1317","head":{"label":"peterbarker:set-time","ref":"set-time","sha":"000df4263413de49a94871c650b7bb4d781d1317","user":{"login":"peterbarker","id":7077857,"avatar_url":"https://avatars0.githubusercontent.com/u/7077857?v=4","gravatar_id":"","url":"https://api.github.com/users/peterbarker","html_url":"https://github.com/peterbarker","followers_url":"https://api.github.com/users/peterbarker/followers","following_url":"https://api.github.com/users/peterbarker/following{/other_user}","gists_url":"https://api.github.com/users/peterbarker/gists{/gist_id}","starred_url":"https://api.github.com/users/peterbarker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterbarker/subscriptions","organizations_url":"https://api.github.com/users/peterbarker/orgs","repos_url":"https://api.github.com/users/peterbarker/repos","events_url":"https://api.github.com/users/peterbarker/events{/privacy}","received_events_url":"https://api.github.com/users/peterbarker/received_events","type":"User","site_admin":false},"repo":{"id":34165570,"name":"ardupilot","full_name":"peterbarker/ardupilot","owner":{"login":"peterbarker","id":7077857,"avatar_url":"https://avatars0.githubusercontent.com/u/7077857?v=4","gravatar_id":"","url":"https://api.github.com/users/peterbarker","html_url":"https://github.com/peterbarker","followers_url":"https://api.github.com/users/peterbarker/followers","following_url":"https://api.github.com/users/peterbarker/following{/other_user}","gists_url":"https://api.github.com/users/peterbarker/gists{/gist_id}","starred_url":"https://api.github.com/users/peterbarker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterbarker/subscriptions","organizations_url":"https://api.github.com/users/peterbarker/orgs","repos_url":"https://api.github.com/users/peterbarker/repos","events_url":"https://api.github.com/users/peterbarker/events{/privacy}","received_events_url":"https://api.github.com/users/peterbarker/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/peterbarker/ardupilot","description":"APM Plane, APM Copter, APM Rover source","fork":true,"url":"https://api.github.com/repos/peterbarker/ardupilot","forks_url":"https://api.github.com/repos/peterbarker/ardupilot/forks","keys_url":"https://api.github.com/repos/peterbarker/ardupilot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/peterbarker/ardupilot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/peterbarker/ardupilot/teams","hooks_url":"https://api.github.com/repos/peterbarker/ardupilot/hooks","issue_events_url":"https://api.github.com/repos/peterbarker/ardupilot/issues/events{/number}","events_url":"https://api.github.com/repos/peterbarker/ardupilot/events","assignees_url":"https://api.github.com/repos/peterbarker/ardupilot/assignees{/user}","branches_url":"https://api.github.com/repos/peterbarker/ardupilot/branches{/branch}","tags_url":"https://api.github.com/repos/peterbarker/ardupilot/tags","blobs_url":"https://api.github.com/repos/peterbarker/ardupilot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/peterbarker/ardupilot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/peterbarker/ardupilot/git/refs{/sha}","trees_url":"https://api.github.com/repos/peterbarker/ardupilot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/peterbarker/ardupilot/statuses/{sha}","languages_url":"https://api.github.com/repos/peterbarker/ardupilot/languages","stargazers_url":"https://api.github.com/repos/peterbarker/ardupilot/stargazers","contributors_url":"https://api.github.com/repos/peterbarker/ardupilot/contributors","subscribers_url":"https://api.github.com/repos/peterbarker/ardupilot/subscribers","subscription_url":"https://api.github.com/repos/peterbarker/ardupilot/subscription","commits_url":"https://api.github.com/repos/peterbarker/ardupilot/commits{/sha}","git_commits_url":"https://api.github.com/repos/peterbarker/ardupilot/git/commits{/sha}","comments_url":"https://api.github.com/repos/peterbarker/ardupilot/comments{/number}","issue_comment_url":"https://api.github.com/repos/peterbarker/ardupilot/issues/comments{/number}","contents_url":"https://api.github.com/repos/peterbarker/ardupilot/contents/{+path}","compare_url":"https://api.github.com/repos/peterbarker/ardupilot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/peterbarker/ardupilot/merges","archive_url":"https://api.github.com/repos/peterbarker/ardupilot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/peterbarker/ardupilot/downloads","issues_url":"https://api.github.com/repos/peterbarker/ardupilot/issues{/number}","pulls_url":"https://api.github.com/repos/peterbarker/ardupilot/pulls{/number}","milestones_url":"https://api.github.com/repos/peterbarker/ardupilot/milestones{/number}","notifications_url":"https://api.github.com/repos/peterbarker/ardupilot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/peterbarker/ardupilot/labels{/name}","releases_url":"https://api.github.com/repos/peterbarker/ardupilot/releases{/id}","deployments_url":"https://api.github.com/repos/peterbarker/ardupilot/deployments","created_at":"2015-04-18T12:46:36Z","updated_at":"2016-11-30T01:59:51Z","pushed_at":"2018-04-12T05:29:13Z","git_url":"git://github.com/peterbarker/ardupilot.git","ssh_url":"git@github.com:peterbarker/ardupilot.git","clone_url":"https://github.com/peterbarker/ardupilot.git","svn_url":"https://github.com/peterbarker/ardupilot","homepage":"http://ardupilot.com/","size":100591,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ArduPilot:master","ref":"master","sha":"751024f48393955d4266581a4b3c147113fbc6e1","user":{"login":"ArduPilot","id":17919847,"avatar_url":"https://avatars3.githubusercontent.com/u/17919847?v=4","gravatar_id":"","url":"https://api.github.com/users/ArduPilot","html_url":"https://github.com/ArduPilot","followers_url":"https://api.github.com/users/ArduPilot/followers","following_url":"https://api.github.com/users/ArduPilot/following{/other_user}","gists_url":"https://api.github.com/users/ArduPilot/gists{/gist_id}","starred_url":"https://api.github.com/users/ArduPilot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArduPilot/subscriptions","organizations_url":"https://api.github.com/users/ArduPilot/orgs","repos_url":"https://api.github.com/users/ArduPilot/repos","events_url":"https://api.github.com/users/ArduPilot/events{/privacy}","received_events_url":"https://api.github.com/users/ArduPilot/received_events","type":"Organization","site_admin":false},"repo":{"id":7512484,"name":"ardupilot","full_name":"ArduPilot/ardupilot","owner":{"login":"ArduPilot","id":17919847,"avatar_url":"https://avatars3.githubusercontent.com/u/17919847?v=4","gravatar_id":"","url":"https://api.github.com/users/ArduPilot","html_url":"https://github.com/ArduPilot","followers_url":"https://api.github.com/users/ArduPilot/followers","following_url":"https://api.github.com/users/ArduPilot/following{/other_user}","gists_url":"https://api.github.com/users/ArduPilot/gists{/gist_id}","starred_url":"https://api.github.com/users/ArduPilot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArduPilot/subscriptions","organizations_url":"https://api.github.com/users/ArduPilot/orgs","repos_url":"https://api.github.com/users/ArduPilot/repos","events_url":"https://api.github.com/users/ArduPilot/events{/privacy}","received_events_url":"https://api.github.com/users/ArduPilot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ArduPilot/ardupilot","description":"ArduPlane, ArduCopter, ArduRover source","fork":false,"url":"https://api.github.com/repos/ArduPilot/ardupilot","forks_url":"https://api.github.com/repos/ArduPilot/ardupilot/forks","keys_url":"https://api.github.com/repos/ArduPilot/ardupilot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ArduPilot/ardupilot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ArduPilot/ardupilot/teams","hooks_url":"https://api.github.com/repos/ArduPilot/ardupilot/hooks","issue_events_url":"https://api.github.com/repos/ArduPilot/ardupilot/issues/events{/number}","events_url":"https://api.github.com/repos/ArduPilot/ardupilot/events","assignees_url":"https://api.github.com/repos/ArduPilot/ardupilot/assignees{/user}","branches_url":"https://api.github.com/repos/ArduPilot/ardupilot/branches{/branch}","tags_url":"https://api.github.com/repos/ArduPilot/ardupilot/tags","blobs_url":"https://api.github.com/repos/ArduPilot/ardupilot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ArduPilot/ardupilot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ArduPilot/ardupilot/git/refs{/sha}","trees_url":"https://api.github.com/repos/ArduPilot/ardupilot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ArduPilot/ardupilot/statuses/{sha}","languages_url":"https://api.github.com/repos/ArduPilot/ardupilot/languages","stargazers_url":"https://api.github.com/repos/ArduPilot/ardupilot/stargazers","contributors_url":"https://api.github.com/repos/ArduPilot/ardupilot/contributors","subscribers_url":"https://api.github.com/repos/ArduPilot/ardupilot/subscribers","subscription_url":"https://api.github.com/repos/ArduPilot/ardupilot/subscription","commits_url":"https://api.github.com/repos/ArduPilot/ardupilot/commits{/sha}","git_commits_url":"https://api.github.com/repos/ArduPilot/ardupilot/git/commits{/sha}","comments_url":"https://api.github.com/repos/ArduPilot/ardupilot/comments{/number}","issue_comment_url":"https://api.github.com/repos/ArduPilot/ardupilot/issues/comments{/number}","contents_url":"https://api.github.com/repos/ArduPilot/ardupilot/contents/{+path}","compare_url":"https://api.github.com/repos/ArduPilot/ardupilot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ArduPilot/ardupilot/merges","archive_url":"https://api.github.com/repos/ArduPilot/ardupilot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ArduPilot/ardupilot/downloads","issues_url":"https://api.github.com/repos/ArduPilot/ardupilot/issues{/number}","pulls_url":"https://api.github.com/repos/ArduPilot/ardupilot/pulls{/number}","milestones_url":"https://api.github.com/repos/ArduPilot/ardupilot/milestones{/number}","notifications_url":"https://api.github.com/repos/ArduPilot/ardupilot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ArduPilot/ardupilot/labels{/name}","releases_url":"https://api.github.com/repos/ArduPilot/ardupilot/releases{/id}","deployments_url":"https://api.github.com/repos/ArduPilot/ardupilot/deployments","created_at":"2013-01-09T00:58:52Z","updated_at":"2018-04-12T15:35:50Z","pushed_at":"2018-04-12T15:35:01Z","git_url":"git://github.com/ArduPilot/ardupilot.git","ssh_url":"git@github.com:ArduPilot/ardupilot.git","clone_url":"https://github.com/ArduPilot/ardupilot.git","svn_url":"https://github.com/ArduPilot/ardupilot","homepage":"http://ardupilot.org/","size":100134,"stargazers_count":3129,"watchers_count":3129,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6196,"mirror_url":null,"archived":false,"open_issues_count":1108,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":6196,"open_issues":1108,"watchers":3129,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/8121"},"html":{"href":"https://github.com/ArduPilot/ardupilot/pull/8121"},"issue":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/issues/8121"},"comments":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/issues/8121/comments"},"review_comments":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/8121/comments"},"review_comment":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/8121/commits"},"statuses":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/statuses/000df4263413de49a94871c650b7bb4d781d1317"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"OXINARF"}}