{"action":"created","comment":{"url":"https://api.github.com/repos/minio/minio/pulls/comments/244559650","pull_request_review_id":188467132,"id":244559650,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDU1OTY1MA==","diff_hunk":"@@ -53,6 +53,9 @@ func registerAdminRouter(router *mux.Router, enableIAM bool) {\n \t// Info operations\n \tadminV1Router.Methods(http.MethodGet).Path(\"/info\").HandlerFunc(httpTraceAll(adminAPI.ServerInfoHandler))\n \n+\t// Performance command - retrun performance details based on input type\n+\tadminV1Router.Methods(http.MethodGet).Path(\"/performance\").HandlerFunc(httpTraceAll(adminAPI.PerfInfoHandler)).Queries(\"perfType\", \"{perfType:.*}\")","path":"cmd/admin-router.go","position":null,"original_position":5,"commit_id":"d86c0116cca4a29ddca082c2a33bb2ea03110821","original_commit_id":"92010994cf9f25f987aab69b2ebdf7c936ccb978","user":{"login":"nitisht","id":5156139,"node_id":"MDQ6VXNlcjUxNTYxMzk=","avatar_url":"https://avatars0.githubusercontent.com/u/5156139?v=4","gravatar_id":"","url":"https://api.github.com/users/nitisht","html_url":"https://github.com/nitisht","followers_url":"https://api.github.com/users/nitisht/followers","following_url":"https://api.github.com/users/nitisht/following{/other_user}","gists_url":"https://api.github.com/users/nitisht/gists{/gist_id}","starred_url":"https://api.github.com/users/nitisht/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nitisht/subscriptions","organizations_url":"https://api.github.com/users/nitisht/orgs","repos_url":"https://api.github.com/users/nitisht/repos","events_url":"https://api.github.com/users/nitisht/events{/privacy}","received_events_url":"https://api.github.com/users/nitisht/received_events","type":"User","site_admin":false},"body":"okay, updated. @harshavardhana @kannappanr PTAL","created_at":"2018-12-31T07:31:55Z","updated_at":"2018-12-31T07:31:56Z","html_url":"https://github.com/minio/minio/pull/6969#discussion_r244559650","pull_request_url":"https://api.github.com/repos/minio/minio/pulls/6969","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/minio/minio/pulls/comments/244559650"},"html":{"href":"https://github.com/minio/minio/pull/6969#discussion_r244559650"},"pull_request":{"href":"https://api.github.com/repos/minio/minio/pulls/6969"}},"in_reply_to_id":244558156},"pull_request":{"url":"https://api.github.com/repos/minio/minio/pulls/6969","id":238458947,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4NDU4OTQ3","html_url":"https://github.com/minio/minio/pull/6969","diff_url":"https://github.com/minio/minio/pull/6969.diff","patch_url":"https://github.com/minio/minio/pull/6969.patch","issue_url":"https://api.github.com/repos/minio/minio/issues/6969","number":6969,"state":"open","locked":false,"title":"Add ServerDrivesInfo() admin API","user":{"login":"nitisht","id":5156139,"node_id":"MDQ6VXNlcjUxNTYxMzk=","avatar_url":"https://avatars0.githubusercontent.com/u/5156139?v=4","gravatar_id":"","url":"https://api.github.com/users/nitisht","html_url":"https://github.com/nitisht","followers_url":"https://api.github.com/users/nitisht/followers","following_url":"https://api.github.com/users/nitisht/following{/other_user}","gists_url":"https://api.github.com/users/nitisht/gists{/gist_id}","starred_url":"https://api.github.com/users/nitisht/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nitisht/subscriptions","organizations_url":"https://api.github.com/users/nitisht/orgs","repos_url":"https://api.github.com/users/nitisht/repos","events_url":"https://api.github.com/users/nitisht/events{/privacy}","received_events_url":"https://api.github.com/users/nitisht/received_events","type":"User","site_admin":false},"body":"## Description\r\nThis is a part of implementation of mc admin health command.\r\nServerDrivePerfInfo() exposes local and remote server drive mount path\r\nand write speed information.\r\n\r\n## Motivation and Context\r\nPart of https://github.com/minio/mc/issues/2606\r\n\r\n## Regression\r\nNo\r\n\r\n## How Has This Been Tested?\r\nUsing the madmin package\r\n\r\n```go\r\n\t// Initialize minio client object.\r\n\tmdmClnt, err := madmin.New(\"127.0.0.1:9000\", \"minio\", \"minio123\", ssl)\r\n\tif err != nil {\r\n\t\tfmt.Println(err)\r\n\t\treturn\r\n\t}\r\n\tsi, err := mdmClnt.ServerDrivesPerfInfo()\r\n\tif err != nil {\r\n\t\tlog.Fatalln(err)\r\n\t}\r\n\tb, err := json.Marshal(si)\r\n\tfmt.Printf(\"%s\\n\", string(b))\r\n```\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [x] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] My code follows the code style of this project.\r\n- [ ] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\n- [ ] I have added unit tests to cover my changes.\r\n- [ ] I have added/updated functional tests in [mint](https://github.com/minio/mint). (If yes, add `mint` PR # here: )\r\n- [ ] All new and existing tests passed.","created_at":"2018-12-13T16:48:11Z","updated_at":"2018-12-31T07:31:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"837f9fe8116d07b9b3a2a9ec49c4d4c407c708d1","assignee":null,"assignees":[],"requested_reviewers":[{"login":"kannappanr","id":30541348,"node_id":"MDQ6VXNlcjMwNTQxMzQ4","avatar_url":"https://avatars0.githubusercontent.com/u/30541348?v=4","gravatar_id":"","url":"https://api.github.com/users/kannappanr","html_url":"https://github.com/kannappanr","followers_url":"https://api.github.com/users/kannappanr/followers","following_url":"https://api.github.com/users/kannappanr/following{/other_user}","gists_url":"https://api.github.com/users/kannappanr/gists{/gist_id}","starred_url":"https://api.github.com/users/kannappanr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kannappanr/subscriptions","organizations_url":"https://api.github.com/users/kannappanr/orgs","repos_url":"https://api.github.com/users/kannappanr/repos","events_url":"https://api.github.com/users/kannappanr/events{/privacy}","received_events_url":"https://api.github.com/users/kannappanr/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/minio/minio/pulls/6969/commits","review_comments_url":"https://api.github.com/repos/minio/minio/pulls/6969/comments","review_comment_url":"https://api.github.com/repos/minio/minio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/minio/minio/issues/6969/comments","statuses_url":"https://api.github.com/repos/minio/minio/statuses/d86c0116cca4a29ddca082c2a33bb2ea03110821","head":{"label":"nitisht:mc-health","ref":"mc-health","sha":"d86c0116cca4a29ddca082c2a33bb2ea03110821","user":{"login":"nitisht","id":5156139,"node_id":"MDQ6VXNlcjUxNTYxMzk=","avatar_url":"https://avatars0.githubusercontent.com/u/5156139?v=4","gravatar_id":"","url":"https://api.github.com/users/nitisht","html_url":"https://github.com/nitisht","followers_url":"https://api.github.com/users/nitisht/followers","following_url":"https://api.github.com/users/nitisht/following{/other_user}","gists_url":"https://api.github.com/users/nitisht/gists{/gist_id}","starred_url":"https://api.github.com/users/nitisht/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nitisht/subscriptions","organizations_url":"https://api.github.com/users/nitisht/orgs","repos_url":"https://api.github.com/users/nitisht/repos","events_url":"https://api.github.com/users/nitisht/events{/privacy}","received_events_url":"https://api.github.com/users/nitisht/received_events","type":"User","site_admin":false},"repo":{"id":100204191,"node_id":"MDEwOlJlcG9zaXRvcnkxMDAyMDQxOTE=","name":"minio","full_name":"nitisht/minio","private":false,"owner":{"login":"nitisht","id":5156139,"node_id":"MDQ6VXNlcjUxNTYxMzk=","avatar_url":"https://avatars0.githubusercontent.com/u/5156139?v=4","gravatar_id":"","url":"https://api.github.com/users/nitisht","html_url":"https://github.com/nitisht","followers_url":"https://api.github.com/users/nitisht/followers","following_url":"https://api.github.com/users/nitisht/following{/other_user}","gists_url":"https://api.github.com/users/nitisht/gists{/gist_id}","starred_url":"https://api.github.com/users/nitisht/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nitisht/subscriptions","organizations_url":"https://api.github.com/users/nitisht/orgs","repos_url":"https://api.github.com/users/nitisht/repos","events_url":"https://api.github.com/users/nitisht/events{/privacy}","received_events_url":"https://api.github.com/users/nitisht/received_events","type":"User","site_admin":false},"html_url":"https://github.com/nitisht/minio","description":"Minio is an open source object storage server compatible with Amazon S3 APIs","fork":true,"url":"https://api.github.com/repos/nitisht/minio","forks_url":"https://api.github.com/repos/nitisht/minio/forks","keys_url":"https://api.github.com/repos/nitisht/minio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nitisht/minio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nitisht/minio/teams","hooks_url":"https://api.github.com/repos/nitisht/minio/hooks","issue_events_url":"https://api.github.com/repos/nitisht/minio/issues/events{/number}","events_url":"https://api.github.com/repos/nitisht/minio/events","assignees_url":"https://api.github.com/repos/nitisht/minio/assignees{/user}","branches_url":"https://api.github.com/repos/nitisht/minio/branches{/branch}","tags_url":"https://api.github.com/repos/nitisht/minio/tags","blobs_url":"https://api.github.com/repos/nitisht/minio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nitisht/minio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nitisht/minio/git/refs{/sha}","trees_url":"https://api.github.com/repos/nitisht/minio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nitisht/minio/statuses/{sha}","languages_url":"https://api.github.com/repos/nitisht/minio/languages","stargazers_url":"https://api.github.com/repos/nitisht/minio/stargazers","contributors_url":"https://api.github.com/repos/nitisht/minio/contributors","subscribers_url":"https://api.github.com/repos/nitisht/minio/subscribers","subscription_url":"https://api.github.com/repos/nitisht/minio/subscription","commits_url":"https://api.github.com/repos/nitisht/minio/commits{/sha}","git_commits_url":"https://api.github.com/repos/nitisht/minio/git/commits{/sha}","comments_url":"https://api.github.com/repos/nitisht/minio/comments{/number}","issue_comment_url":"https://api.github.com/repos/nitisht/minio/issues/comments{/number}","contents_url":"https://api.github.com/repos/nitisht/minio/contents/{+path}","compare_url":"https://api.github.com/repos/nitisht/minio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nitisht/minio/merges","archive_url":"https://api.github.com/repos/nitisht/minio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nitisht/minio/downloads","issues_url":"https://api.github.com/repos/nitisht/minio/issues{/number}","pulls_url":"https://api.github.com/repos/nitisht/minio/pulls{/number}","milestones_url":"https://api.github.com/repos/nitisht/minio/milestones{/number}","notifications_url":"https://api.github.com/repos/nitisht/minio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nitisht/minio/labels{/name}","releases_url":"https://api.github.com/repos/nitisht/minio/releases{/id}","deployments_url":"https://api.github.com/repos/nitisht/minio/deployments","created_at":"2017-08-13T20:56:45Z","updated_at":"2018-12-31T03:10:16Z","pushed_at":"2018-12-31T07:31:25Z","git_url":"git://github.com/nitisht/minio.git","ssh_url":"git@github.com:nitisht/minio.git","clone_url":"https://github.com/nitisht/minio.git","svn_url":"https://github.com/nitisht/minio","homepage":"https://minio.io","size":44693,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"minio:master","ref":"master","sha":"75cd4201b06b485a72dbad8ec8688123b0cc8075","user":{"login":"minio","id":695951,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NTk1MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/695951?v=4","gravatar_id":"","url":"https://api.github.com/users/minio","html_url":"https://github.com/minio","followers_url":"https://api.github.com/users/minio/followers","following_url":"https://api.github.com/users/minio/following{/other_user}","gists_url":"https://api.github.com/users/minio/gists{/gist_id}","starred_url":"https://api.github.com/users/minio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minio/subscriptions","organizations_url":"https://api.github.com/users/minio/orgs","repos_url":"https://api.github.com/users/minio/repos","events_url":"https://api.github.com/users/minio/events{/privacy}","received_events_url":"https://api.github.com/users/minio/received_events","type":"Organization","site_admin":false},"repo":{"id":29261473,"node_id":"MDEwOlJlcG9zaXRvcnkyOTI2MTQ3Mw==","name":"minio","full_name":"minio/minio","private":false,"owner":{"login":"minio","id":695951,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NTk1MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/695951?v=4","gravatar_id":"","url":"https://api.github.com/users/minio","html_url":"https://github.com/minio","followers_url":"https://api.github.com/users/minio/followers","following_url":"https://api.github.com/users/minio/following{/other_user}","gists_url":"https://api.github.com/users/minio/gists{/gist_id}","starred_url":"https://api.github.com/users/minio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minio/subscriptions","organizations_url":"https://api.github.com/users/minio/orgs","repos_url":"https://api.github.com/users/minio/repos","events_url":"https://api.github.com/users/minio/events{/privacy}","received_events_url":"https://api.github.com/users/minio/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/minio/minio","description":"Minio is an open source object storage server compatible with Amazon S3 APIs","fork":false,"url":"https://api.github.com/repos/minio/minio","forks_url":"https://api.github.com/repos/minio/minio/forks","keys_url":"https://api.github.com/repos/minio/minio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minio/minio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minio/minio/teams","hooks_url":"https://api.github.com/repos/minio/minio/hooks","issue_events_url":"https://api.github.com/repos/minio/minio/issues/events{/number}","events_url":"https://api.github.com/repos/minio/minio/events","assignees_url":"https://api.github.com/repos/minio/minio/assignees{/user}","branches_url":"https://api.github.com/repos/minio/minio/branches{/branch}","tags_url":"https://api.github.com/repos/minio/minio/tags","blobs_url":"https://api.github.com/repos/minio/minio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minio/minio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minio/minio/git/refs{/sha}","trees_url":"https://api.github.com/repos/minio/minio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minio/minio/statuses/{sha}","languages_url":"https://api.github.com/repos/minio/minio/languages","stargazers_url":"https://api.github.com/repos/minio/minio/stargazers","contributors_url":"https://api.github.com/repos/minio/minio/contributors","subscribers_url":"https://api.github.com/repos/minio/minio/subscribers","subscription_url":"https://api.github.com/repos/minio/minio/subscription","commits_url":"https://api.github.com/repos/minio/minio/commits{/sha}","git_commits_url":"https://api.github.com/repos/minio/minio/git/commits{/sha}","comments_url":"https://api.github.com/repos/minio/minio/comments{/number}","issue_comment_url":"https://api.github.com/repos/minio/minio/issues/comments{/number}","contents_url":"https://api.github.com/repos/minio/minio/contents/{+path}","compare_url":"https://api.github.com/repos/minio/minio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minio/minio/merges","archive_url":"https://api.github.com/repos/minio/minio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minio/minio/downloads","issues_url":"https://api.github.com/repos/minio/minio/issues{/number}","pulls_url":"https://api.github.com/repos/minio/minio/pulls{/number}","milestones_url":"https://api.github.com/repos/minio/minio/milestones{/number}","notifications_url":"https://api.github.com/repos/minio/minio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minio/minio/labels{/name}","releases_url":"https://api.github.com/repos/minio/minio/releases{/id}","deployments_url":"https://api.github.com/repos/minio/minio/deployments","created_at":"2015-01-14T19:23:58Z","updated_at":"2018-12-31T05:17:30Z","pushed_at":"2018-12-31T07:31:28Z","git_url":"git://github.com/minio/minio.git","ssh_url":"git@github.com:minio/minio.git","clone_url":"https://github.com/minio/minio.git","svn_url":"https://github.com/minio/minio","homepage":"https://minio.io/downloads.html#download-server","size":44808,"stargazers_count":14108,"watchers_count":14108,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1285,"mirror_url":null,"archived":false,"open_issues_count":136,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1285,"open_issues":136,"watchers":14108,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/minio/minio/pulls/6969"},"html":{"href":"https://github.com/minio/minio/pull/6969"},"issue":{"href":"https://api.github.com/repos/minio/minio/issues/6969"},"comments":{"href":"https://api.github.com/repos/minio/minio/issues/6969/comments"},"review_comments":{"href":"https://api.github.com/repos/minio/minio/pulls/6969/comments"},"review_comment":{"href":"https://api.github.com/repos/minio/minio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/minio/minio/pulls/6969/commits"},"statuses":{"href":"https://api.github.com/repos/minio/minio/statuses/d86c0116cca4a29ddca082c2a33bb2ea03110821"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"nitisht"}}