{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/cluster-ingress-operator/issues/56","repository_url":"https://api.github.com/repos/openshift/cluster-ingress-operator","labels_url":"https://api.github.com/repos/openshift/cluster-ingress-operator/issues/56/labels{/name}","comments_url":"https://api.github.com/repos/openshift/cluster-ingress-operator/issues/56/comments","events_url":"https://api.github.com/repos/openshift/cluster-ingress-operator/issues/56/events","html_url":"https://github.com/openshift/cluster-ingress-operator/pull/56","id":374469461,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2MTY1MzQz","number":56,"title":"release-local.sh: Fix cp command for manifests","user":{"login":"Miciah","id":2042465,"node_id":"MDQ6VXNlcjIwNDI0NjU=","avatar_url":"https://avatars1.githubusercontent.com/u/2042465?v=4","gravatar_id":"","url":"https://api.github.com/users/Miciah","html_url":"https://github.com/Miciah","followers_url":"https://api.github.com/users/Miciah/followers","following_url":"https://api.github.com/users/Miciah/following{/other_user}","gists_url":"https://api.github.com/users/Miciah/gists{/gist_id}","starred_url":"https://api.github.com/users/Miciah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Miciah/subscriptions","organizations_url":"https://api.github.com/users/Miciah/orgs","repos_url":"https://api.github.com/users/Miciah/repos","events_url":"https://api.github.com/users/Miciah/events{/privacy}","received_events_url":"https://api.github.com/users/Miciah/received_events","type":"User","site_admin":false},"labels":[{"id":1026574273,"node_id":"MDU6TGFiZWwxMDI2NTc0Mjcz","url":"https://api.github.com/repos/openshift/cluster-ingress-operator/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":1026556751,"node_id":"MDU6TGFiZWwxMDI2NTU2NzUx","url":"https://api.github.com/repos/openshift/cluster-ingress-operator/labels/lgtm","name":"lgtm","color":"15dd18","default":false},{"id":1027061067,"node_id":"MDU6TGFiZWwxMDI3MDYxMDY3","url":"https://api.github.com/repos/openshift/cluster-ingress-operator/labels/size/XS","name":"size/XS","color":"009900","default":false}],"state":"open","locked":false,"assignee":{"login":"ironcladlou","id":298299,"node_id":"MDQ6VXNlcjI5ODI5OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/298299?v=4","gravatar_id":"","url":"https://api.github.com/users/ironcladlou","html_url":"https://github.com/ironcladlou","followers_url":"https://api.github.com/users/ironcladlou/followers","following_url":"https://api.github.com/users/ironcladlou/following{/other_user}","gists_url":"https://api.github.com/users/ironcladlou/gists{/gist_id}","starred_url":"https://api.github.com/users/ironcladlou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ironcladlou/subscriptions","organizations_url":"https://api.github.com/users/ironcladlou/orgs","repos_url":"https://api.github.com/users/ironcladlou/repos","events_url":"https://api.github.com/users/ironcladlou/events{/privacy}","received_events_url":"https://api.github.com/users/ironcladlou/received_events","type":"User","site_admin":false},"assignees":[{"login":"ironcladlou","id":298299,"node_id":"MDQ6VXNlcjI5ODI5OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/298299?v=4","gravatar_id":"","url":"https://api.github.com/users/ironcladlou","html_url":"https://github.com/ironcladlou","followers_url":"https://api.github.com/users/ironcladlou/followers","following_url":"https://api.github.com/users/ironcladlou/following{/other_user}","gists_url":"https://api.github.com/users/ironcladlou/gists{/gist_id}","starred_url":"https://api.github.com/users/ironcladlou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ironcladlou/subscriptions","organizations_url":"https://api.github.com/users/ironcladlou/orgs","repos_url":"https://api.github.com/users/ironcladlou/repos","events_url":"https://api.github.com/users/ironcladlou/events{/privacy}","received_events_url":"https://api.github.com/users/ironcladlou/received_events","type":"User","site_admin":false}],"milestone":null,"comments":8,"created_at":"2018-10-26T17:03:27Z","updated_at":"2018-10-27T11:11:35Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/openshift/cluster-ingress-operator/pulls/56","html_url":"https://github.com/openshift/cluster-ingress-operator/pull/56","diff_url":"https://github.com/openshift/cluster-ingress-operator/pull/56.diff","patch_url":"https://github.com/openshift/cluster-ingress-operator/pull/56.patch"},"body":"Fix the `cp` command in `release-local.sh` to copy the manifest files directly into the temporary directory rather than copying the `manifests/` directory as a subdirectory of the temporary directory.  This change causes the subsequent `sed` command to overwrite the `02-deployment.yaml` file.\r\n\r\nBefore this commit, the `cp` command in `release-local.sh` was copying the `manifests/` directory under the temporary directory, and the subsequent `sed` command was creating a second `02-deployment.yaml` file in the temporary directory, as shown below:\r\n\r\n    /tmp/tmp.8gU85s0EC2\r\n    ├── 02-deployment.yaml\r\n    └── manifests\r\n        ├── 00-cluster-role.yaml\r\n        ├── 00-custom-resource-definition.yaml\r\n        ├── 00-namespace.yaml\r\n        ├── 01-cluster-role-binding.yaml\r\n        ├── 01-role-binding.yaml\r\n        ├── 01-role.yaml\r\n        ├── 01-service-account.yaml\r\n        ├── 02-deployment.yaml\r\n        └── image-references\r\n\r\nHaving this file hierarchy was causing the following error:\r\n\r\n    $ oc apply -f /tmp/tmp.8gU85s0EC2\r\n    Error from server (NotFound): error when creating \"/tmp/tmp.8gU85s0EC2/02-deployment.yaml\": namespaces \"openshift-ingress-operator\" not found\r\n\r\nAfter this change, the file hierarchy looks as follows:\r\n\r\n    /tmp/tmp.zkXMmjzrHV\r\n    ├── 00-cluster-role.yaml\r\n    ├── 00-custom-resource-definition.yaml\r\n    ├── 00-namespace.yaml\r\n    ├── 01-cluster-role-binding.yaml\r\n    ├── 01-role-binding.yaml\r\n    ├── 01-role.yaml\r\n    ├── 01-service-account.yaml\r\n    ├── 02-deployment.yaml\r\n    └── image-references\r\n\r\n...and the `oc apply` command succeeds."},"comment":{"url":"https://api.github.com/repos/openshift/cluster-ingress-operator/issues/comments/433611537","html_url":"https://github.com/openshift/cluster-ingress-operator/pull/56#issuecomment-433611537","issue_url":"https://api.github.com/repos/openshift/cluster-ingress-operator/issues/56","id":433611537,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMzYxMTUzNw==","user":{"login":"openshift-merge-robot","id":30189218,"node_id":"MDQ6VXNlcjMwMTg5MjE4","avatar_url":"https://avatars0.githubusercontent.com/u/30189218?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift-merge-robot","html_url":"https://github.com/openshift-merge-robot","followers_url":"https://api.github.com/users/openshift-merge-robot/followers","following_url":"https://api.github.com/users/openshift-merge-robot/following{/other_user}","gists_url":"https://api.github.com/users/openshift-merge-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift-merge-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift-merge-robot/subscriptions","organizations_url":"https://api.github.com/users/openshift-merge-robot/orgs","repos_url":"https://api.github.com/users/openshift-merge-robot/repos","events_url":"https://api.github.com/users/openshift-merge-robot/events{/privacy}","received_events_url":"https://api.github.com/users/openshift-merge-robot/received_events","type":"User","site_admin":false},"created_at":"2018-10-27T11:11:35Z","updated_at":"2018-10-27T11:11:35Z","author_association":"CONTRIBUTOR","body":"/retest\n\nPlease review the [full test history](https://openshift-gce-devel.appspot.com/pr/openshift_cluster-ingress-operator/56) for this PR and help us cut down flakes."}}
{"actor":{"display_login":"openshift-merge-robot"}}