{"action":"created","comment":{"url":"https://api.github.com/repos/dlang/druntime/pulls/comments/233305355","pull_request_review_id":174686988,"id":233305355,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzMwNTM1NQ==","diff_hunk":"@@ -0,0 +1,2299 @@\n+///\n+module core.experimental.array;\n+\n+import core.internal.traits : Unqual;\n+\n+// { \"Imports\" from Phobos\n+\n+// { Allocators\n+\n+/**\n+Returns the size in bytes of the state that needs to be allocated to hold an\n+object of type `T`. `stateSize!T` is zero for `struct`s that are not\n+nested and have no nonstatic member variables.\n+ */\n+template stateSize(T)\n+{\n+    static if (is(T == class) || is(T == interface))\n+        enum stateSize = __traits(classInstanceSize, T);\n+    else static if (is(T == void))\n+        enum size_t stateSize = 0;\n+    else\n+        enum stateSize = T.sizeof;\n+}\n+\n+template isAbstractClass(T...)\n+if (T.length == 1)\n+{\n+    enum bool isAbstractClass = __traits(isAbstractClass, T[0]);\n+}\n+\n+template isInnerClass(T)","path":"src/core/experimental/array.d","position":31,"original_position":31,"commit_id":"5518f64e6d4fb95f7b313212be768a1d094eb82a","original_commit_id":"5518f64e6d4fb95f7b313212be768a1d094eb82a","user":{"login":"wilzbach","id":4370550,"node_id":"MDQ6VXNlcjQzNzA1NTA=","avatar_url":"https://avatars3.githubusercontent.com/u/4370550?v=4","gravatar_id":"","url":"https://api.github.com/users/wilzbach","html_url":"https://github.com/wilzbach","followers_url":"https://api.github.com/users/wilzbach/followers","following_url":"https://api.github.com/users/wilzbach/following{/other_user}","gists_url":"https://api.github.com/users/wilzbach/gists{/gist_id}","starred_url":"https://api.github.com/users/wilzbach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilzbach/subscriptions","organizations_url":"https://api.github.com/users/wilzbach/orgs","repos_url":"https://api.github.com/users/wilzbach/repos","events_url":"https://api.github.com/users/wilzbach/events{/privacy}","received_events_url":"https://api.github.com/users/wilzbach/received_events","type":"User","site_admin":false},"body":"private","created_at":"2018-11-14T03:40:06Z","updated_at":"2018-11-14T03:59:30Z","html_url":"https://github.com/dlang/druntime/pull/2348#discussion_r233305355","pull_request_url":"https://api.github.com/repos/dlang/druntime/pulls/2348","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dlang/druntime/pulls/comments/233305355"},"html":{"href":"https://github.com/dlang/druntime/pull/2348#discussion_r233305355"},"pull_request":{"href":"https://api.github.com/repos/dlang/druntime/pulls/2348"}}},"pull_request":{"url":"https://api.github.com/repos/dlang/druntime/pulls/2348","id":229980970,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5OTgwOTcw","html_url":"https://github.com/dlang/druntime/pull/2348","diff_url":"https://github.com/dlang/druntime/pull/2348.diff","patch_url":"https://github.com/dlang/druntime/pull/2348.patch","issue_url":"https://api.github.com/repos/dlang/druntime/issues/2348","number":2348,"state":"open","locked":false,"title":"[WIP] Add @nogc array","user":{"login":"edi33416","id":3812633,"node_id":"MDQ6VXNlcjM4MTI2MzM=","avatar_url":"https://avatars0.githubusercontent.com/u/3812633?v=4","gravatar_id":"","url":"https://api.github.com/users/edi33416","html_url":"https://github.com/edi33416","followers_url":"https://api.github.com/users/edi33416/followers","following_url":"https://api.github.com/users/edi33416/following{/other_user}","gists_url":"https://api.github.com/users/edi33416/gists{/gist_id}","starred_url":"https://api.github.com/users/edi33416/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edi33416/subscriptions","organizations_url":"https://api.github.com/users/edi33416/orgs","repos_url":"https://api.github.com/users/edi33416/repos","events_url":"https://api.github.com/users/edi33416/events{/privacy}","received_events_url":"https://api.github.com/users/edi33416/received_events","type":"User","site_admin":false},"body":"This PR adds a `@nogc nothrow pure @safe` implementation of a generic array that mimics the behaviour of the built-in array (`T[]`).\r\n\r\nThis array implementation makes use of the Copy Constructor [PR](https://github.com/dlang/dmd/pull/8688). By doing so, it both tests the implementation and proves it's usefulness.\r\n\r\nI know this is a lengthy PR, but please bear with me, as there are a lot of unittests.\r\nAnd now, as Andrei says \"destroy()\"","created_at":"2018-11-11T21:55:31Z","updated_at":"2018-11-14T03:59:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e08ec7db30c2f8f5baccfff63061a84c0e82f185","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":660234731,"node_id":"MDU6TGFiZWw2NjAyMzQ3MzE=","url":"https://api.github.com/repos/dlang/druntime/labels/WIP","name":"WIP","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dlang/druntime/pulls/2348/commits","review_comments_url":"https://api.github.com/repos/dlang/druntime/pulls/2348/comments","review_comment_url":"https://api.github.com/repos/dlang/druntime/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dlang/druntime/issues/2348/comments","statuses_url":"https://api.github.com/repos/dlang/druntime/statuses/5518f64e6d4fb95f7b313212be768a1d094eb82a","head":{"label":"edi33416:add_nogc_array","ref":"add_nogc_array","sha":"5518f64e6d4fb95f7b313212be768a1d094eb82a","user":{"login":"edi33416","id":3812633,"node_id":"MDQ6VXNlcjM4MTI2MzM=","avatar_url":"https://avatars0.githubusercontent.com/u/3812633?v=4","gravatar_id":"","url":"https://api.github.com/users/edi33416","html_url":"https://github.com/edi33416","followers_url":"https://api.github.com/users/edi33416/followers","following_url":"https://api.github.com/users/edi33416/following{/other_user}","gists_url":"https://api.github.com/users/edi33416/gists{/gist_id}","starred_url":"https://api.github.com/users/edi33416/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edi33416/subscriptions","organizations_url":"https://api.github.com/users/edi33416/orgs","repos_url":"https://api.github.com/users/edi33416/repos","events_url":"https://api.github.com/users/edi33416/events{/privacy}","received_events_url":"https://api.github.com/users/edi33416/received_events","type":"User","site_admin":false},"repo":{"id":106275480,"node_id":"MDEwOlJlcG9zaXRvcnkxMDYyNzU0ODA=","name":"druntime","full_name":"edi33416/druntime","private":false,"owner":{"login":"edi33416","id":3812633,"node_id":"MDQ6VXNlcjM4MTI2MzM=","avatar_url":"https://avatars0.githubusercontent.com/u/3812633?v=4","gravatar_id":"","url":"https://api.github.com/users/edi33416","html_url":"https://github.com/edi33416","followers_url":"https://api.github.com/users/edi33416/followers","following_url":"https://api.github.com/users/edi33416/following{/other_user}","gists_url":"https://api.github.com/users/edi33416/gists{/gist_id}","starred_url":"https://api.github.com/users/edi33416/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edi33416/subscriptions","organizations_url":"https://api.github.com/users/edi33416/orgs","repos_url":"https://api.github.com/users/edi33416/repos","events_url":"https://api.github.com/users/edi33416/events{/privacy}","received_events_url":"https://api.github.com/users/edi33416/received_events","type":"User","site_admin":false},"html_url":"https://github.com/edi33416/druntime","description":"Low level runtime library for the D programming language","fork":true,"url":"https://api.github.com/repos/edi33416/druntime","forks_url":"https://api.github.com/repos/edi33416/druntime/forks","keys_url":"https://api.github.com/repos/edi33416/druntime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edi33416/druntime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edi33416/druntime/teams","hooks_url":"https://api.github.com/repos/edi33416/druntime/hooks","issue_events_url":"https://api.github.com/repos/edi33416/druntime/issues/events{/number}","events_url":"https://api.github.com/repos/edi33416/druntime/events","assignees_url":"https://api.github.com/repos/edi33416/druntime/assignees{/user}","branches_url":"https://api.github.com/repos/edi33416/druntime/branches{/branch}","tags_url":"https://api.github.com/repos/edi33416/druntime/tags","blobs_url":"https://api.github.com/repos/edi33416/druntime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edi33416/druntime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edi33416/druntime/git/refs{/sha}","trees_url":"https://api.github.com/repos/edi33416/druntime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edi33416/druntime/statuses/{sha}","languages_url":"https://api.github.com/repos/edi33416/druntime/languages","stargazers_url":"https://api.github.com/repos/edi33416/druntime/stargazers","contributors_url":"https://api.github.com/repos/edi33416/druntime/contributors","subscribers_url":"https://api.github.com/repos/edi33416/druntime/subscribers","subscription_url":"https://api.github.com/repos/edi33416/druntime/subscription","commits_url":"https://api.github.com/repos/edi33416/druntime/commits{/sha}","git_commits_url":"https://api.github.com/repos/edi33416/druntime/git/commits{/sha}","comments_url":"https://api.github.com/repos/edi33416/druntime/comments{/number}","issue_comment_url":"https://api.github.com/repos/edi33416/druntime/issues/comments{/number}","contents_url":"https://api.github.com/repos/edi33416/druntime/contents/{+path}","compare_url":"https://api.github.com/repos/edi33416/druntime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edi33416/druntime/merges","archive_url":"https://api.github.com/repos/edi33416/druntime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edi33416/druntime/downloads","issues_url":"https://api.github.com/repos/edi33416/druntime/issues{/number}","pulls_url":"https://api.github.com/repos/edi33416/druntime/pulls{/number}","milestones_url":"https://api.github.com/repos/edi33416/druntime/milestones{/number}","notifications_url":"https://api.github.com/repos/edi33416/druntime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edi33416/druntime/labels{/name}","releases_url":"https://api.github.com/repos/edi33416/druntime/releases{/id}","deployments_url":"https://api.github.com/repos/edi33416/druntime/deployments","created_at":"2017-10-09T11:34:25Z","updated_at":"2017-10-09T11:34:29Z","pushed_at":"2018-11-12T22:02:21Z","git_url":"git://github.com/edi33416/druntime.git","ssh_url":"git@github.com:edi33416/druntime.git","clone_url":"https://github.com/edi33416/druntime.git","svn_url":"https://github.com/edi33416/druntime","homepage":"dlang.org","size":15706,"stargazers_count":0,"watchers_count":0,"language":"D","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dlang:master","ref":"master","sha":"a104ca68bd64617bda5dd6792cb4a14977808273","user":{"login":"dlang","id":565913,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2NTkxMw==","avatar_url":"https://avatars3.githubusercontent.com/u/565913?v=4","gravatar_id":"","url":"https://api.github.com/users/dlang","html_url":"https://github.com/dlang","followers_url":"https://api.github.com/users/dlang/followers","following_url":"https://api.github.com/users/dlang/following{/other_user}","gists_url":"https://api.github.com/users/dlang/gists{/gist_id}","starred_url":"https://api.github.com/users/dlang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlang/subscriptions","organizations_url":"https://api.github.com/users/dlang/orgs","repos_url":"https://api.github.com/users/dlang/repos","events_url":"https://api.github.com/users/dlang/events{/privacy}","received_events_url":"https://api.github.com/users/dlang/received_events","type":"Organization","site_admin":false},"repo":{"id":1257087,"node_id":"MDEwOlJlcG9zaXRvcnkxMjU3MDg3","name":"druntime","full_name":"dlang/druntime","private":false,"owner":{"login":"dlang","id":565913,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2NTkxMw==","avatar_url":"https://avatars3.githubusercontent.com/u/565913?v=4","gravatar_id":"","url":"https://api.github.com/users/dlang","html_url":"https://github.com/dlang","followers_url":"https://api.github.com/users/dlang/followers","following_url":"https://api.github.com/users/dlang/following{/other_user}","gists_url":"https://api.github.com/users/dlang/gists{/gist_id}","starred_url":"https://api.github.com/users/dlang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlang/subscriptions","organizations_url":"https://api.github.com/users/dlang/orgs","repos_url":"https://api.github.com/users/dlang/repos","events_url":"https://api.github.com/users/dlang/events{/privacy}","received_events_url":"https://api.github.com/users/dlang/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dlang/druntime","description":"Low level runtime library for the D programming language","fork":false,"url":"https://api.github.com/repos/dlang/druntime","forks_url":"https://api.github.com/repos/dlang/druntime/forks","keys_url":"https://api.github.com/repos/dlang/druntime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dlang/druntime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dlang/druntime/teams","hooks_url":"https://api.github.com/repos/dlang/druntime/hooks","issue_events_url":"https://api.github.com/repos/dlang/druntime/issues/events{/number}","events_url":"https://api.github.com/repos/dlang/druntime/events","assignees_url":"https://api.github.com/repos/dlang/druntime/assignees{/user}","branches_url":"https://api.github.com/repos/dlang/druntime/branches{/branch}","tags_url":"https://api.github.com/repos/dlang/druntime/tags","blobs_url":"https://api.github.com/repos/dlang/druntime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dlang/druntime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dlang/druntime/git/refs{/sha}","trees_url":"https://api.github.com/repos/dlang/druntime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dlang/druntime/statuses/{sha}","languages_url":"https://api.github.com/repos/dlang/druntime/languages","stargazers_url":"https://api.github.com/repos/dlang/druntime/stargazers","contributors_url":"https://api.github.com/repos/dlang/druntime/contributors","subscribers_url":"https://api.github.com/repos/dlang/druntime/subscribers","subscription_url":"https://api.github.com/repos/dlang/druntime/subscription","commits_url":"https://api.github.com/repos/dlang/druntime/commits{/sha}","git_commits_url":"https://api.github.com/repos/dlang/druntime/git/commits{/sha}","comments_url":"https://api.github.com/repos/dlang/druntime/comments{/number}","issue_comment_url":"https://api.github.com/repos/dlang/druntime/issues/comments{/number}","contents_url":"https://api.github.com/repos/dlang/druntime/contents/{+path}","compare_url":"https://api.github.com/repos/dlang/druntime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dlang/druntime/merges","archive_url":"https://api.github.com/repos/dlang/druntime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dlang/druntime/downloads","issues_url":"https://api.github.com/repos/dlang/druntime/issues{/number}","pulls_url":"https://api.github.com/repos/dlang/druntime/pulls{/number}","milestones_url":"https://api.github.com/repos/dlang/druntime/milestones{/number}","notifications_url":"https://api.github.com/repos/dlang/druntime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dlang/druntime/labels{/name}","releases_url":"https://api.github.com/repos/dlang/druntime/releases{/id}","deployments_url":"https://api.github.com/repos/dlang/druntime/deployments","created_at":"2011-01-15T07:01:38Z","updated_at":"2018-11-14T01:30:21Z","pushed_at":"2018-11-14T01:30:04Z","git_url":"git://github.com/dlang/druntime.git","ssh_url":"git@github.com:dlang/druntime.git","clone_url":"https://github.com/dlang/druntime.git","svn_url":"https://github.com/dlang/druntime","homepage":"dlang.org","size":15732,"stargazers_count":501,"watchers_count":501,"language":"D","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":347,"mirror_url":null,"archived":false,"open_issues_count":72,"license":{"key":"bsl-1.0","name":"Boost Software License 1.0","spdx_id":"BSL-1.0","url":"https://api.github.com/licenses/bsl-1.0","node_id":"MDc6TGljZW5zZTI4"},"forks":347,"open_issues":72,"watchers":501,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dlang/druntime/pulls/2348"},"html":{"href":"https://github.com/dlang/druntime/pull/2348"},"issue":{"href":"https://api.github.com/repos/dlang/druntime/issues/2348"},"comments":{"href":"https://api.github.com/repos/dlang/druntime/issues/2348/comments"},"review_comments":{"href":"https://api.github.com/repos/dlang/druntime/pulls/2348/comments"},"review_comment":{"href":"https://api.github.com/repos/dlang/druntime/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dlang/druntime/pulls/2348/commits"},"statuses":{"href":"https://api.github.com/repos/dlang/druntime/statuses/5518f64e6d4fb95f7b313212be768a1d094eb82a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"wilzbach"}}