{"action":"created","comment":{"url":"https://api.github.com/repos/liquality/chainabstractionlayer/pulls/comments/239750839","pull_request_review_id":182620455,"id":239750839,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzOTc1MDgzOQ==","diff_hunk":"@@ -105,12 +105,12 @@ <h3>Refund swap:</h3>\n     /* global $, ChainAbstractionLayer, web3 */\n     const { Client, providers, networks, crypto } = ChainAbstractionLayer\n     const bitcoin = new Client()\n-    bitcoin.addProvider(new providers.bitcoin.BitcoreRPCProvider('https://localhost:18332', 'bitcoin', 'local321'))\n+    bitcoin.addProvider(new providers.bitcoin.BitcoreRPCProvider('http://localhost:18332', 'bitcoin', 'local321'))","path":"examples/swap/swap-e2e.html","position":5,"original_position":5,"commit_id":"2d443f2f09ae84e0cf05cc01abab9ed7c64c6a7a","original_commit_id":"2d443f2f09ae84e0cf05cc01abab9ed7c64c6a7a","user":{"login":"monokh","id":11529637,"node_id":"MDQ6VXNlcjExNTI5NjM3","avatar_url":"https://avatars2.githubusercontent.com/u/11529637?v=4","gravatar_id":"","url":"https://api.github.com/users/monokh","html_url":"https://github.com/monokh","followers_url":"https://api.github.com/users/monokh/followers","following_url":"https://api.github.com/users/monokh/following{/other_user}","gists_url":"https://api.github.com/users/monokh/gists{/gist_id}","starred_url":"https://api.github.com/users/monokh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monokh/subscriptions","organizations_url":"https://api.github.com/users/monokh/orgs","repos_url":"https://api.github.com/users/monokh/repos","events_url":"https://api.github.com/users/monokh/events{/privacy}","received_events_url":"https://api.github.com/users/monokh/received_events","type":"User","site_admin":false},"body":"I actually recall discussing whether https was required and i was under the impression that it was for some reason. I then tried to change to http and it still worked. So due to the default host port of starting a local rpc is http, i thought i could change it to that. ","created_at":"2018-12-07T09:56:32Z","updated_at":"2018-12-07T09:56:32Z","html_url":"https://github.com/liquality/chainabstractionlayer/pull/100#discussion_r239750839","pull_request_url":"https://api.github.com/repos/liquality/chainabstractionlayer/pulls/100","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/liquality/chainabstractionlayer/pulls/comments/239750839"},"html":{"href":"https://github.com/liquality/chainabstractionlayer/pull/100#discussion_r239750839"},"pull_request":{"href":"https://api.github.com/repos/liquality/chainabstractionlayer/pulls/100"}},"in_reply_to_id":239704824},"pull_request":{"url":"https://api.github.com/repos/liquality/chainabstractionlayer/pulls/100","id":236592486,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2NTkyNDg2","html_url":"https://github.com/liquality/chainabstractionlayer/pull/100","diff_url":"https://github.com/liquality/chainabstractionlayer/pull/100.diff","patch_url":"https://github.com/liquality/chainabstractionlayer/pull/100.patch","issue_url":"https://api.github.com/repos/liquality/chainabstractionlayer/issues/100","number":100,"state":"open","locked":false,"title":"Improve finding swap transactions","user":{"login":"monokh","id":11529637,"node_id":"MDQ6VXNlcjExNTI5NjM3","avatar_url":"https://avatars2.githubusercontent.com/u/11529637?v=4","gravatar_id":"","url":"https://api.github.com/users/monokh","html_url":"https://github.com/monokh","followers_url":"https://api.github.com/users/monokh/followers","following_url":"https://api.github.com/users/monokh/following{/other_user}","gists_url":"https://api.github.com/users/monokh/gists{/gist_id}","starred_url":"https://api.github.com/users/monokh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monokh/subscriptions","organizations_url":"https://api.github.com/users/monokh/orgs","repos_url":"https://api.github.com/users/monokh/repos","events_url":"https://api.github.com/users/monokh/events{/privacy}","received_events_url":"https://api.github.com/users/monokh/received_events","type":"User","site_admin":false},"body":"### Description\r\n\r\nThe method for finding the swap transactions would parse blocks and every transaction in that to find it. This was innefficient and on mainnet could make thousands of network calls (per tx) and take minutes\r\n\r\nWe need a more efficient way\r\n\r\n### Submission Checklist :pencil:\r\n\r\n- [x] Add `getAddressTransactions` to BitcoreRPCProvider - One call to get matching transactions in a block","created_at":"2018-12-06T16:30:47Z","updated_at":"2018-12-07T09:56:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a0256318a0194c5461a88c6e180bc505d59802c3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/liquality/chainabstractionlayer/pulls/100/commits","review_comments_url":"https://api.github.com/repos/liquality/chainabstractionlayer/pulls/100/comments","review_comment_url":"https://api.github.com/repos/liquality/chainabstractionlayer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/liquality/chainabstractionlayer/issues/100/comments","statuses_url":"https://api.github.com/repos/liquality/chainabstractionlayer/statuses/2d443f2f09ae84e0cf05cc01abab9ed7c64c6a7a","head":{"label":"liquality:improve-finding-transactions","ref":"improve-finding-transactions","sha":"2d443f2f09ae84e0cf05cc01abab9ed7c64c6a7a","user":{"login":"liquality","id":42639968,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyNjM5OTY4","avatar_url":"https://avatars0.githubusercontent.com/u/42639968?v=4","gravatar_id":"","url":"https://api.github.com/users/liquality","html_url":"https://github.com/liquality","followers_url":"https://api.github.com/users/liquality/followers","following_url":"https://api.github.com/users/liquality/following{/other_user}","gists_url":"https://api.github.com/users/liquality/gists{/gist_id}","starred_url":"https://api.github.com/users/liquality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liquality/subscriptions","organizations_url":"https://api.github.com/users/liquality/orgs","repos_url":"https://api.github.com/users/liquality/repos","events_url":"https://api.github.com/users/liquality/events{/privacy}","received_events_url":"https://api.github.com/users/liquality/received_events","type":"Organization","site_admin":false},"repo":{"id":130330053,"node_id":"MDEwOlJlcG9zaXRvcnkxMzAzMzAwNTM=","name":"chainabstractionlayer","full_name":"liquality/chainabstractionlayer","private":false,"owner":{"login":"liquality","id":42639968,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyNjM5OTY4","avatar_url":"https://avatars0.githubusercontent.com/u/42639968?v=4","gravatar_id":"","url":"https://api.github.com/users/liquality","html_url":"https://github.com/liquality","followers_url":"https://api.github.com/users/liquality/followers","following_url":"https://api.github.com/users/liquality/following{/other_user}","gists_url":"https://api.github.com/users/liquality/gists{/gist_id}","starred_url":"https://api.github.com/users/liquality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liquality/subscriptions","organizations_url":"https://api.github.com/users/liquality/orgs","repos_url":"https://api.github.com/users/liquality/repos","events_url":"https://api.github.com/users/liquality/events{/privacy}","received_events_url":"https://api.github.com/users/liquality/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/liquality/chainabstractionlayer","description":"Blockchain abstraction layer","fork":false,"url":"https://api.github.com/repos/liquality/chainabstractionlayer","forks_url":"https://api.github.com/repos/liquality/chainabstractionlayer/forks","keys_url":"https://api.github.com/repos/liquality/chainabstractionlayer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/liquality/chainabstractionlayer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/liquality/chainabstractionlayer/teams","hooks_url":"https://api.github.com/repos/liquality/chainabstractionlayer/hooks","issue_events_url":"https://api.github.com/repos/liquality/chainabstractionlayer/issues/events{/number}","events_url":"https://api.github.com/repos/liquality/chainabstractionlayer/events","assignees_url":"https://api.github.com/repos/liquality/chainabstractionlayer/assignees{/user}","branches_url":"https://api.github.com/repos/liquality/chainabstractionlayer/branches{/branch}","tags_url":"https://api.github.com/repos/liquality/chainabstractionlayer/tags","blobs_url":"https://api.github.com/repos/liquality/chainabstractionlayer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/liquality/chainabstractionlayer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/liquality/chainabstractionlayer/git/refs{/sha}","trees_url":"https://api.github.com/repos/liquality/chainabstractionlayer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/liquality/chainabstractionlayer/statuses/{sha}","languages_url":"https://api.github.com/repos/liquality/chainabstractionlayer/languages","stargazers_url":"https://api.github.com/repos/liquality/chainabstractionlayer/stargazers","contributors_url":"https://api.github.com/repos/liquality/chainabstractionlayer/contributors","subscribers_url":"https://api.github.com/repos/liquality/chainabstractionlayer/subscribers","subscription_url":"https://api.github.com/repos/liquality/chainabstractionlayer/subscription","commits_url":"https://api.github.com/repos/liquality/chainabstractionlayer/commits{/sha}","git_commits_url":"https://api.github.com/repos/liquality/chainabstractionlayer/git/commits{/sha}","comments_url":"https://api.github.com/repos/liquality/chainabstractionlayer/comments{/number}","issue_comment_url":"https://api.github.com/repos/liquality/chainabstractionlayer/issues/comments{/number}","contents_url":"https://api.github.com/repos/liquality/chainabstractionlayer/contents/{+path}","compare_url":"https://api.github.com/repos/liquality/chainabstractionlayer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/liquality/chainabstractionlayer/merges","archive_url":"https://api.github.com/repos/liquality/chainabstractionlayer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/liquality/chainabstractionlayer/downloads","issues_url":"https://api.github.com/repos/liquality/chainabstractionlayer/issues{/number}","pulls_url":"https://api.github.com/repos/liquality/chainabstractionlayer/pulls{/number}","milestones_url":"https://api.github.com/repos/liquality/chainabstractionlayer/milestones{/number}","notifications_url":"https://api.github.com/repos/liquality/chainabstractionlayer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/liquality/chainabstractionlayer/labels{/name}","releases_url":"https://api.github.com/repos/liquality/chainabstractionlayer/releases{/id}","deployments_url":"https://api.github.com/repos/liquality/chainabstractionlayer/deployments","created_at":"2018-04-20T08:03:01Z","updated_at":"2018-12-07T04:57:04Z","pushed_at":"2018-12-07T09:18:29Z","git_url":"git://github.com/liquality/chainabstractionlayer.git","ssh_url":"git@github.com:liquality/chainabstractionlayer.git","clone_url":"https://github.com/liquality/chainabstractionlayer.git","svn_url":"https://github.com/liquality/chainabstractionlayer","homepage":"https://liquality.io","size":7321,"stargazers_count":36,"watchers_count":36,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2,"open_issues":5,"watchers":36,"default_branch":"master"}},"base":{"label":"liquality:master","ref":"master","sha":"6acf38f648c84353de9c41e7575cad9d255661df","user":{"login":"liquality","id":42639968,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyNjM5OTY4","avatar_url":"https://avatars0.githubusercontent.com/u/42639968?v=4","gravatar_id":"","url":"https://api.github.com/users/liquality","html_url":"https://github.com/liquality","followers_url":"https://api.github.com/users/liquality/followers","following_url":"https://api.github.com/users/liquality/following{/other_user}","gists_url":"https://api.github.com/users/liquality/gists{/gist_id}","starred_url":"https://api.github.com/users/liquality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liquality/subscriptions","organizations_url":"https://api.github.com/users/liquality/orgs","repos_url":"https://api.github.com/users/liquality/repos","events_url":"https://api.github.com/users/liquality/events{/privacy}","received_events_url":"https://api.github.com/users/liquality/received_events","type":"Organization","site_admin":false},"repo":{"id":130330053,"node_id":"MDEwOlJlcG9zaXRvcnkxMzAzMzAwNTM=","name":"chainabstractionlayer","full_name":"liquality/chainabstractionlayer","private":false,"owner":{"login":"liquality","id":42639968,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyNjM5OTY4","avatar_url":"https://avatars0.githubusercontent.com/u/42639968?v=4","gravatar_id":"","url":"https://api.github.com/users/liquality","html_url":"https://github.com/liquality","followers_url":"https://api.github.com/users/liquality/followers","following_url":"https://api.github.com/users/liquality/following{/other_user}","gists_url":"https://api.github.com/users/liquality/gists{/gist_id}","starred_url":"https://api.github.com/users/liquality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liquality/subscriptions","organizations_url":"https://api.github.com/users/liquality/orgs","repos_url":"https://api.github.com/users/liquality/repos","events_url":"https://api.github.com/users/liquality/events{/privacy}","received_events_url":"https://api.github.com/users/liquality/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/liquality/chainabstractionlayer","description":"Blockchain abstraction layer","fork":false,"url":"https://api.github.com/repos/liquality/chainabstractionlayer","forks_url":"https://api.github.com/repos/liquality/chainabstractionlayer/forks","keys_url":"https://api.github.com/repos/liquality/chainabstractionlayer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/liquality/chainabstractionlayer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/liquality/chainabstractionlayer/teams","hooks_url":"https://api.github.com/repos/liquality/chainabstractionlayer/hooks","issue_events_url":"https://api.github.com/repos/liquality/chainabstractionlayer/issues/events{/number}","events_url":"https://api.github.com/repos/liquality/chainabstractionlayer/events","assignees_url":"https://api.github.com/repos/liquality/chainabstractionlayer/assignees{/user}","branches_url":"https://api.github.com/repos/liquality/chainabstractionlayer/branches{/branch}","tags_url":"https://api.github.com/repos/liquality/chainabstractionlayer/tags","blobs_url":"https://api.github.com/repos/liquality/chainabstractionlayer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/liquality/chainabstractionlayer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/liquality/chainabstractionlayer/git/refs{/sha}","trees_url":"https://api.github.com/repos/liquality/chainabstractionlayer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/liquality/chainabstractionlayer/statuses/{sha}","languages_url":"https://api.github.com/repos/liquality/chainabstractionlayer/languages","stargazers_url":"https://api.github.com/repos/liquality/chainabstractionlayer/stargazers","contributors_url":"https://api.github.com/repos/liquality/chainabstractionlayer/contributors","subscribers_url":"https://api.github.com/repos/liquality/chainabstractionlayer/subscribers","subscription_url":"https://api.github.com/repos/liquality/chainabstractionlayer/subscription","commits_url":"https://api.github.com/repos/liquality/chainabstractionlayer/commits{/sha}","git_commits_url":"https://api.github.com/repos/liquality/chainabstractionlayer/git/commits{/sha}","comments_url":"https://api.github.com/repos/liquality/chainabstractionlayer/comments{/number}","issue_comment_url":"https://api.github.com/repos/liquality/chainabstractionlayer/issues/comments{/number}","contents_url":"https://api.github.com/repos/liquality/chainabstractionlayer/contents/{+path}","compare_url":"https://api.github.com/repos/liquality/chainabstractionlayer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/liquality/chainabstractionlayer/merges","archive_url":"https://api.github.com/repos/liquality/chainabstractionlayer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/liquality/chainabstractionlayer/downloads","issues_url":"https://api.github.com/repos/liquality/chainabstractionlayer/issues{/number}","pulls_url":"https://api.github.com/repos/liquality/chainabstractionlayer/pulls{/number}","milestones_url":"https://api.github.com/repos/liquality/chainabstractionlayer/milestones{/number}","notifications_url":"https://api.github.com/repos/liquality/chainabstractionlayer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/liquality/chainabstractionlayer/labels{/name}","releases_url":"https://api.github.com/repos/liquality/chainabstractionlayer/releases{/id}","deployments_url":"https://api.github.com/repos/liquality/chainabstractionlayer/deployments","created_at":"2018-04-20T08:03:01Z","updated_at":"2018-12-07T04:57:04Z","pushed_at":"2018-12-07T09:18:29Z","git_url":"git://github.com/liquality/chainabstractionlayer.git","ssh_url":"git@github.com:liquality/chainabstractionlayer.git","clone_url":"https://github.com/liquality/chainabstractionlayer.git","svn_url":"https://github.com/liquality/chainabstractionlayer","homepage":"https://liquality.io","size":7321,"stargazers_count":36,"watchers_count":36,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2,"open_issues":5,"watchers":36,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/liquality/chainabstractionlayer/pulls/100"},"html":{"href":"https://github.com/liquality/chainabstractionlayer/pull/100"},"issue":{"href":"https://api.github.com/repos/liquality/chainabstractionlayer/issues/100"},"comments":{"href":"https://api.github.com/repos/liquality/chainabstractionlayer/issues/100/comments"},"review_comments":{"href":"https://api.github.com/repos/liquality/chainabstractionlayer/pulls/100/comments"},"review_comment":{"href":"https://api.github.com/repos/liquality/chainabstractionlayer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/liquality/chainabstractionlayer/pulls/100/commits"},"statuses":{"href":"https://api.github.com/repos/liquality/chainabstractionlayer/statuses/2d443f2f09ae84e0cf05cc01abab9ed7c64c6a7a"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"monokh"}}