{"action":"created","issue":{"url":"https://api.github.com/repos/nus-cs2103-AY1819S1/addressbook-level4/issues/115","repository_url":"https://api.github.com/repos/nus-cs2103-AY1819S1/addressbook-level4","labels_url":"https://api.github.com/repos/nus-cs2103-AY1819S1/addressbook-level4/issues/115/labels{/name}","comments_url":"https://api.github.com/repos/nus-cs2103-AY1819S1/addressbook-level4/issues/115/comments","events_url":"https://api.github.com/repos/nus-cs2103-AY1819S1/addressbook-level4/issues/115/events","html_url":"https://github.com/nus-cs2103-AY1819S1/addressbook-level4/pull/115","id":366860704,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwNDMyMjMw","number":115,"title":"[F11-4] NUS Hangs","user":{"login":"Happytreat","id":16359471,"node_id":"MDQ6VXNlcjE2MzU5NDcx","avatar_url":"https://avatars0.githubusercontent.com/u/16359471?v=4","gravatar_id":"","url":"https://api.github.com/users/Happytreat","html_url":"https://github.com/Happytreat","followers_url":"https://api.github.com/users/Happytreat/followers","following_url":"https://api.github.com/users/Happytreat/following{/other_user}","gists_url":"https://api.github.com/users/Happytreat/gists{/gist_id}","starred_url":"https://api.github.com/users/Happytreat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Happytreat/subscriptions","organizations_url":"https://api.github.com/users/Happytreat/orgs","repos_url":"https://api.github.com/users/Happytreat/repos","events_url":"https://api.github.com/users/Happytreat/events{/privacy}","received_events_url":"https://api.github.com/users/Happytreat/received_events","type":"User","site_admin":false},"labels":[{"id":1059083787,"node_id":"MDU6TGFiZWwxMDU5MDgzNzg3","url":"https://api.github.com/repos/nus-cs2103-AY1819S1/addressbook-level4/labels/team.4","name":"team.4","color":"ededed","default":false},{"id":1059593911,"node_id":"MDU6TGFiZWwxMDU5NTkzOTEx","url":"https://api.github.com/repos/nus-cs2103-AY1819S1/addressbook-level4/labels/tutorial.F11","name":"tutorial.F11","color":"ededed","default":false},{"id":1074988931,"node_id":"MDU6TGFiZWwxMDc0OTg4OTMx","url":"https://api.github.com/repos/nus-cs2103-AY1819S1/addressbook-level4/labels/v1.1-Reviewed","name":"v1.1-Reviewed","color":"4faf26","default":false},{"id":1090562772,"node_id":"MDU6TGFiZWwxMDkwNTYyNzcy","url":"https://api.github.com/repos/nus-cs2103-AY1819S1/addressbook-level4/labels/v1.2-Reviewed","name":"v1.2-Reviewed","color":"0c9b62","default":false}],"state":"open","locked":false,"assignee":{"login":"jelneo","id":28497440,"node_id":"MDQ6VXNlcjI4NDk3NDQw","avatar_url":"https://avatars3.githubusercontent.com/u/28497440?v=4","gravatar_id":"","url":"https://api.github.com/users/jelneo","html_url":"https://github.com/jelneo","followers_url":"https://api.github.com/users/jelneo/followers","following_url":"https://api.github.com/users/jelneo/following{/other_user}","gists_url":"https://api.github.com/users/jelneo/gists{/gist_id}","starred_url":"https://api.github.com/users/jelneo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jelneo/subscriptions","organizations_url":"https://api.github.com/users/jelneo/orgs","repos_url":"https://api.github.com/users/jelneo/repos","events_url":"https://api.github.com/users/jelneo/events{/privacy}","received_events_url":"https://api.github.com/users/jelneo/received_events","type":"User","site_admin":false},"assignees":[{"login":"jelneo","id":28497440,"node_id":"MDQ6VXNlcjI4NDk3NDQw","avatar_url":"https://avatars3.githubusercontent.com/u/28497440?v=4","gravatar_id":"","url":"https://api.github.com/users/jelneo","html_url":"https://github.com/jelneo","followers_url":"https://api.github.com/users/jelneo/followers","following_url":"https://api.github.com/users/jelneo/following{/other_user}","gists_url":"https://api.github.com/users/jelneo/gists{/gist_id}","starred_url":"https://api.github.com/users/jelneo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jelneo/subscriptions","organizations_url":"https://api.github.com/users/jelneo/orgs","repos_url":"https://api.github.com/users/jelneo/repos","events_url":"https://api.github.com/users/jelneo/events{/privacy}","received_events_url":"https://api.github.com/users/jelneo/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2018-10-04T16:00:31Z","updated_at":"2018-11-06T06:34:50Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/nus-cs2103-AY1819S1/addressbook-level4/pulls/115","html_url":"https://github.com/nus-cs2103-AY1819S1/addressbook-level4/pull/115","diff_url":"https://github.com/nus-cs2103-AY1819S1/addressbook-level4/pull/115.diff","patch_url":"https://github.com/nus-cs2103-AY1819S1/addressbook-level4/pull/115.patch"},"body":"@souless94 @nigelngyy @zhiwei94 @aspiringdevslog @Happytreat "},"comment":{"url":"https://api.github.com/repos/nus-cs2103-AY1819S1/addressbook-level4/issues/comments/436146084","html_url":"https://github.com/nus-cs2103-AY1819S1/addressbook-level4/pull/115#issuecomment-436146084","issue_url":"https://api.github.com/repos/nus-cs2103-AY1819S1/addressbook-level4/issues/115","id":436146084,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNjE0NjA4NA==","user":{"login":"jelneo","id":28497440,"node_id":"MDQ6VXNlcjI4NDk3NDQw","avatar_url":"https://avatars3.githubusercontent.com/u/28497440?v=4","gravatar_id":"","url":"https://api.github.com/users/jelneo","html_url":"https://github.com/jelneo","followers_url":"https://api.github.com/users/jelneo/followers","following_url":"https://api.github.com/users/jelneo/following{/other_user}","gists_url":"https://api.github.com/users/jelneo/gists{/gist_id}","starred_url":"https://api.github.com/users/jelneo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jelneo/subscriptions","organizations_url":"https://api.github.com/users/jelneo/orgs","repos_url":"https://api.github.com/users/jelneo/repos","events_url":"https://api.github.com/users/jelneo/events{/privacy}","received_events_url":"https://api.github.com/users/jelneo/received_events","type":"User","site_admin":false},"created_at":"2018-11-06T06:34:50Z","updated_at":"2018-11-06T06:34:50Z","author_association":"NONE","body":"Apologies, I just saw your comment @Happytreat @ZhiWei94 @souless94 @aspiringdevslog @nigelngyy\r\nSome things to note:\r\nThis should be changed to your project name:\r\n![image](https://user-images.githubusercontent.com/28497440/48044371-938bff80-e1c6-11e8-8abb-44157d67bcce.png)\r\nIn general, diagrams need to be big enough for the text inside it to be read easily.\r\n**3.1 Timetable feature**\r\nRemove 'Condition' inside the triangle. The conditions should be in square braces: `[]`. Be specific about which command is entered (see blue annotations):\r\n![image](https://user-images.githubusercontent.com/28497440/48044486-29c02580-e1c7-11e8-8a61-50b06ca0b559.png)\r\n\r\nFor the image below:\r\n1. what is the instance `u`? If it is the `AddTimetableCommand` that is created, then it should be at.\r\n2. there should only be 1 method per arrow. Do not lump them together.\r\nalso, it is advisable to make the image bigger such that the text can be easily read.\r\n![image](https://user-images.githubusercontent.com/28497440/48044806-c33c0700-e1c8-11e8-875f-366b1583631c.png)\r\n\r\n**3.2. Security Mechanism**\r\nThe portion in red should be broken up into alternate paths. In this case, we should prompt for login before we allow the user to execute any commands.\r\n![image](https://user-images.githubusercontent.com/28497440/48045098-de5b4680-e1c9-11e8-9cf3-c87bd470884b.png)\r\n\r\nThe problem with the below image is that the control is returned back to `CreateCommandParser` when `CreateCommand` is not done with objection construction (there's still `addNewAccount(...)` which is called after the return arrow). Hence you should fill up the activation bar as shown in blue and shift the return arrow down as shown in red.\r\n![image](https://user-images.githubusercontent.com/28497440/48045624-06e44000-e1cc-11e8-9bb9-e65df4cdf4a0.png)\r\n\r\nFor the image bloew:\r\n1. the return arrow should be at the end of the activation bar\r\n2. same comment as the sequence diagram for Create Command\r\n![image](https://user-images.githubusercontent.com/28497440/48046026-abb34d00-e1cd-11e8-84df-9ce42c54fd0d.png)\r\n\r\n**3.3. Group Feature**\r\nFor the image below:\r\n1. remove the yellow box\r\n2. Where is the start of the flow? Is it starting from Text UI or from other components?\r\n3. the start and end of an arrow should be touching an activation bar. Also, the end of the arrow should be below the start of the activation bar (see e.g. in blue)\r\n4.  Arrow should be pointing to `RegisterCommandParser`. Arrowhead missing as well.\r\n5. Activation bar and return arrow are placed wrongly for object creation.\r\n6. Format the arrowhead properly.\r\n7. arrow should touch the activation bar.\r\n8. floating return arrow. the end of the arrow needs to be coming from some process\r\n9. missing lifelines after the activation bars for all the classes.\r\n![image](https://user-images.githubusercontent.com/28497440/48046497-99d2a980-e1cf-11e8-9d18-7d1983613303.png)\r\n\r\nCorrect Sequence Diagram of RegisterCommand (Model component) according to the comments above too.\r\n\r\nFor the image below:\r\n1. wrong notation for denoting the end of an activity diagram\r\n2. should there be a loop? Must the user enter the find command again if the result of the find command is returned or the user entered an invalid find command?\r\n3. Why do we need to find exit command?\r\n4. It would be good to be specific about what results are returned. for e.g. System returns list of users or System returns result of find command if it returns a list of objects from multiple categories.\r\n![image](https://user-images.githubusercontent.com/28497440/48046839-e1a60080-e1d0-11e8-96cc-b981b0fa77ff.png)\r\n\r\n"}}
{"actor":{"display_login":"jelneo"}}