{"action":"created","comment":{"url":"https://api.github.com/repos/CPLUOS/nano/pulls/comments/181114506","pull_request_review_id":111662038,"id":181114506,"diff_hunk":"@@ -21,19 +21,19 @@\n   \n   # -- cuts on the vertex --\n   # Vertex chi2 <\n-  vtxChi2Cut = cms.double(10),\n+  vtxChi2Cut = cms.double(5),\n   # XY decay distance significance >\n-  vtxDecaySigXYCut = cms.double(-1),\n+  vtxDecaySigXYCut = cms.double(1),\n   # XYZ decay distance significance >\n-  vtxDecaySigXYZCut = cms.double(-1.),\n+  vtxDecaySigXYZCut = cms.double(1.),\n   \n   # -- miscellaneous cuts --\n   # POCA distance between tracks <\n-  tkDCACut = cms.double(100),\n+  tkDCACut = cms.double(2),\n   # cos(angleXY) between x and p of V0 candidate >\n-  cosThetaXYCut = cms.double(100),\n+  cosThetaXYCut = cms.double(0.9),\n   # cos(angleXYZ) between x and p of V0 candidate >\n-  cosThetaXYZCut = cms.double(100),\n+  cosThetaXYZCut = cms.double(0.9),","path":"nanoAOD/python/hadrons_cff.py","position":22,"original_position":22,"commit_id":"d8189f7f73238bc8b43f28e52369da1cd4bf6771","original_commit_id":"77262c37acb84ad55015f7d821e3254497202166","user":{"login":"tt8888tt","id":8747087,"avatar_url":"https://avatars3.githubusercontent.com/u/8747087?v=4","gravatar_id":"","url":"https://api.github.com/users/tt8888tt","html_url":"https://github.com/tt8888tt","followers_url":"https://api.github.com/users/tt8888tt/followers","following_url":"https://api.github.com/users/tt8888tt/following{/other_user}","gists_url":"https://api.github.com/users/tt8888tt/gists{/gist_id}","starred_url":"https://api.github.com/users/tt8888tt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tt8888tt/subscriptions","organizations_url":"https://api.github.com/users/tt8888tt/orgs","repos_url":"https://api.github.com/users/tt8888tt/repos","events_url":"https://api.github.com/users/tt8888tt/events{/privacy}","received_events_url":"https://api.github.com/users/tt8888tt/received_events","type":"User","site_admin":false},"body":"sorry I think it was rushed pr. now I have fixed them.\r\nIt may not pretty... but I tested and checked that cuts are working well.","created_at":"2018-04-12T15:02:02Z","updated_at":"2018-04-12T15:02:02Z","html_url":"https://github.com/CPLUOS/nano/pull/15#discussion_r181114506","pull_request_url":"https://api.github.com/repos/CPLUOS/nano/pulls/15","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/CPLUOS/nano/pulls/comments/181114506"},"html":{"href":"https://github.com/CPLUOS/nano/pull/15#discussion_r181114506"},"pull_request":{"href":"https://api.github.com/repos/CPLUOS/nano/pulls/15"}},"in_reply_to_id":180955118},"pull_request":{"url":"https://api.github.com/repos/CPLUOS/nano/pulls/15","id":180898412,"html_url":"https://github.com/CPLUOS/nano/pull/15","diff_url":"https://github.com/CPLUOS/nano/pull/15.diff","patch_url":"https://github.com/CPLUOS/nano/pull/15.patch","issue_url":"https://api.github.com/repos/CPLUOS/nano/issues/15","number":15,"state":"open","locked":false,"title":"update vtsAnalyser and cut values for prod","user":{"login":"tt8888tt","id":8747087,"avatar_url":"https://avatars3.githubusercontent.com/u/8747087?v=4","gravatar_id":"","url":"https://api.github.com/users/tt8888tt","html_url":"https://github.com/tt8888tt","followers_url":"https://api.github.com/users/tt8888tt/followers","following_url":"https://api.github.com/users/tt8888tt/following{/other_user}","gists_url":"https://api.github.com/users/tt8888tt/gists{/gist_id}","starred_url":"https://api.github.com/users/tt8888tt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tt8888tt/subscriptions","organizations_url":"https://api.github.com/users/tt8888tt/orgs","repos_url":"https://api.github.com/users/tt8888tt/repos","events_url":"https://api.github.com/users/tt8888tt/events{/privacy}","received_events_url":"https://api.github.com/users/tt8888tt/received_events","type":"User","site_admin":false},"body":"mainly cut values for hadronProducer are updated\r\ncut values are selected based on follow plots\r\n(https://docs.google.com/presentation/d/1YV_KFWB9zS4rxwKFMqNAQkkO7VCsejwGj8EMySdQOE8/edit#slide=id.p)\r\n\r\nfor vtsAnalyser, added in events selections.\r\nsyncronization test with c meson study group has been done.","created_at":"2018-04-11T13:11:24Z","updated_at":"2018-04-12T15:02:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2903238874849b49a77fbf5caff34b9cfb41201d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/CPLUOS/nano/pulls/15/commits","review_comments_url":"https://api.github.com/repos/CPLUOS/nano/pulls/15/comments","review_comment_url":"https://api.github.com/repos/CPLUOS/nano/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CPLUOS/nano/issues/15/comments","statuses_url":"https://api.github.com/repos/CPLUOS/nano/statuses/d8189f7f73238bc8b43f28e52369da1cd4bf6771","head":{"label":"tt8888tt:master","ref":"master","sha":"d8189f7f73238bc8b43f28e52369da1cd4bf6771","user":{"login":"tt8888tt","id":8747087,"avatar_url":"https://avatars3.githubusercontent.com/u/8747087?v=4","gravatar_id":"","url":"https://api.github.com/users/tt8888tt","html_url":"https://github.com/tt8888tt","followers_url":"https://api.github.com/users/tt8888tt/followers","following_url":"https://api.github.com/users/tt8888tt/following{/other_user}","gists_url":"https://api.github.com/users/tt8888tt/gists{/gist_id}","starred_url":"https://api.github.com/users/tt8888tt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tt8888tt/subscriptions","organizations_url":"https://api.github.com/users/tt8888tt/orgs","repos_url":"https://api.github.com/users/tt8888tt/repos","events_url":"https://api.github.com/users/tt8888tt/events{/privacy}","received_events_url":"https://api.github.com/users/tt8888tt/received_events","type":"User","site_admin":false},"repo":{"id":127642120,"name":"nano","full_name":"tt8888tt/nano","owner":{"login":"tt8888tt","id":8747087,"avatar_url":"https://avatars3.githubusercontent.com/u/8747087?v=4","gravatar_id":"","url":"https://api.github.com/users/tt8888tt","html_url":"https://github.com/tt8888tt","followers_url":"https://api.github.com/users/tt8888tt/followers","following_url":"https://api.github.com/users/tt8888tt/following{/other_user}","gists_url":"https://api.github.com/users/tt8888tt/gists{/gist_id}","starred_url":"https://api.github.com/users/tt8888tt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tt8888tt/subscriptions","organizations_url":"https://api.github.com/users/tt8888tt/orgs","repos_url":"https://api.github.com/users/tt8888tt/repos","events_url":"https://api.github.com/users/tt8888tt/events{/privacy}","received_events_url":"https://api.github.com/users/tt8888tt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tt8888tt/nano","description":null,"fork":true,"url":"https://api.github.com/repos/tt8888tt/nano","forks_url":"https://api.github.com/repos/tt8888tt/nano/forks","keys_url":"https://api.github.com/repos/tt8888tt/nano/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tt8888tt/nano/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tt8888tt/nano/teams","hooks_url":"https://api.github.com/repos/tt8888tt/nano/hooks","issue_events_url":"https://api.github.com/repos/tt8888tt/nano/issues/events{/number}","events_url":"https://api.github.com/repos/tt8888tt/nano/events","assignees_url":"https://api.github.com/repos/tt8888tt/nano/assignees{/user}","branches_url":"https://api.github.com/repos/tt8888tt/nano/branches{/branch}","tags_url":"https://api.github.com/repos/tt8888tt/nano/tags","blobs_url":"https://api.github.com/repos/tt8888tt/nano/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tt8888tt/nano/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tt8888tt/nano/git/refs{/sha}","trees_url":"https://api.github.com/repos/tt8888tt/nano/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tt8888tt/nano/statuses/{sha}","languages_url":"https://api.github.com/repos/tt8888tt/nano/languages","stargazers_url":"https://api.github.com/repos/tt8888tt/nano/stargazers","contributors_url":"https://api.github.com/repos/tt8888tt/nano/contributors","subscribers_url":"https://api.github.com/repos/tt8888tt/nano/subscribers","subscription_url":"https://api.github.com/repos/tt8888tt/nano/subscription","commits_url":"https://api.github.com/repos/tt8888tt/nano/commits{/sha}","git_commits_url":"https://api.github.com/repos/tt8888tt/nano/git/commits{/sha}","comments_url":"https://api.github.com/repos/tt8888tt/nano/comments{/number}","issue_comment_url":"https://api.github.com/repos/tt8888tt/nano/issues/comments{/number}","contents_url":"https://api.github.com/repos/tt8888tt/nano/contents/{+path}","compare_url":"https://api.github.com/repos/tt8888tt/nano/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tt8888tt/nano/merges","archive_url":"https://api.github.com/repos/tt8888tt/nano/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tt8888tt/nano/downloads","issues_url":"https://api.github.com/repos/tt8888tt/nano/issues{/number}","pulls_url":"https://api.github.com/repos/tt8888tt/nano/pulls{/number}","milestones_url":"https://api.github.com/repos/tt8888tt/nano/milestones{/number}","notifications_url":"https://api.github.com/repos/tt8888tt/nano/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tt8888tt/nano/labels{/name}","releases_url":"https://api.github.com/repos/tt8888tt/nano/releases{/id}","deployments_url":"https://api.github.com/repos/tt8888tt/nano/deployments","created_at":"2018-04-01T15:29:34Z","updated_at":"2018-04-12T14:55:09Z","pushed_at":"2018-04-12T14:55:07Z","git_url":"git://github.com/tt8888tt/nano.git","ssh_url":"git@github.com:tt8888tt/nano.git","clone_url":"https://github.com/tt8888tt/nano.git","svn_url":"https://github.com/tt8888tt/nano","homepage":null,"size":415,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CPLUOS:master","ref":"master","sha":"a969dda12ab67f43bfd1269ac3a9e347499f5bf5","user":{"login":"CPLUOS","id":33823127,"avatar_url":"https://avatars3.githubusercontent.com/u/33823127?v=4","gravatar_id":"","url":"https://api.github.com/users/CPLUOS","html_url":"https://github.com/CPLUOS","followers_url":"https://api.github.com/users/CPLUOS/followers","following_url":"https://api.github.com/users/CPLUOS/following{/other_user}","gists_url":"https://api.github.com/users/CPLUOS/gists{/gist_id}","starred_url":"https://api.github.com/users/CPLUOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CPLUOS/subscriptions","organizations_url":"https://api.github.com/users/CPLUOS/orgs","repos_url":"https://api.github.com/users/CPLUOS/repos","events_url":"https://api.github.com/users/CPLUOS/events{/privacy}","received_events_url":"https://api.github.com/users/CPLUOS/received_events","type":"Organization","site_admin":false},"repo":{"id":127641232,"name":"nano","full_name":"CPLUOS/nano","owner":{"login":"CPLUOS","id":33823127,"avatar_url":"https://avatars3.githubusercontent.com/u/33823127?v=4","gravatar_id":"","url":"https://api.github.com/users/CPLUOS","html_url":"https://github.com/CPLUOS","followers_url":"https://api.github.com/users/CPLUOS/followers","following_url":"https://api.github.com/users/CPLUOS/following{/other_user}","gists_url":"https://api.github.com/users/CPLUOS/gists{/gist_id}","starred_url":"https://api.github.com/users/CPLUOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CPLUOS/subscriptions","organizations_url":"https://api.github.com/users/CPLUOS/orgs","repos_url":"https://api.github.com/users/CPLUOS/repos","events_url":"https://api.github.com/users/CPLUOS/events{/privacy}","received_events_url":"https://api.github.com/users/CPLUOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CPLUOS/nano","description":null,"fork":false,"url":"https://api.github.com/repos/CPLUOS/nano","forks_url":"https://api.github.com/repos/CPLUOS/nano/forks","keys_url":"https://api.github.com/repos/CPLUOS/nano/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CPLUOS/nano/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CPLUOS/nano/teams","hooks_url":"https://api.github.com/repos/CPLUOS/nano/hooks","issue_events_url":"https://api.github.com/repos/CPLUOS/nano/issues/events{/number}","events_url":"https://api.github.com/repos/CPLUOS/nano/events","assignees_url":"https://api.github.com/repos/CPLUOS/nano/assignees{/user}","branches_url":"https://api.github.com/repos/CPLUOS/nano/branches{/branch}","tags_url":"https://api.github.com/repos/CPLUOS/nano/tags","blobs_url":"https://api.github.com/repos/CPLUOS/nano/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CPLUOS/nano/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CPLUOS/nano/git/refs{/sha}","trees_url":"https://api.github.com/repos/CPLUOS/nano/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CPLUOS/nano/statuses/{sha}","languages_url":"https://api.github.com/repos/CPLUOS/nano/languages","stargazers_url":"https://api.github.com/repos/CPLUOS/nano/stargazers","contributors_url":"https://api.github.com/repos/CPLUOS/nano/contributors","subscribers_url":"https://api.github.com/repos/CPLUOS/nano/subscribers","subscription_url":"https://api.github.com/repos/CPLUOS/nano/subscription","commits_url":"https://api.github.com/repos/CPLUOS/nano/commits{/sha}","git_commits_url":"https://api.github.com/repos/CPLUOS/nano/git/commits{/sha}","comments_url":"https://api.github.com/repos/CPLUOS/nano/comments{/number}","issue_comment_url":"https://api.github.com/repos/CPLUOS/nano/issues/comments{/number}","contents_url":"https://api.github.com/repos/CPLUOS/nano/contents/{+path}","compare_url":"https://api.github.com/repos/CPLUOS/nano/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CPLUOS/nano/merges","archive_url":"https://api.github.com/repos/CPLUOS/nano/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CPLUOS/nano/downloads","issues_url":"https://api.github.com/repos/CPLUOS/nano/issues{/number}","pulls_url":"https://api.github.com/repos/CPLUOS/nano/pulls{/number}","milestones_url":"https://api.github.com/repos/CPLUOS/nano/milestones{/number}","notifications_url":"https://api.github.com/repos/CPLUOS/nano/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CPLUOS/nano/labels{/name}","releases_url":"https://api.github.com/repos/CPLUOS/nano/releases{/id}","deployments_url":"https://api.github.com/repos/CPLUOS/nano/deployments","created_at":"2018-04-01T15:21:21Z","updated_at":"2018-04-12T09:56:21Z","pushed_at":"2018-04-12T14:55:09Z","git_url":"git://github.com/CPLUOS/nano.git","ssh_url":"git@github.com:CPLUOS/nano.git","clone_url":"https://github.com/CPLUOS/nano.git","svn_url":"https://github.com/CPLUOS/nano","homepage":null,"size":405,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":10,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CPLUOS/nano/pulls/15"},"html":{"href":"https://github.com/CPLUOS/nano/pull/15"},"issue":{"href":"https://api.github.com/repos/CPLUOS/nano/issues/15"},"comments":{"href":"https://api.github.com/repos/CPLUOS/nano/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/CPLUOS/nano/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/CPLUOS/nano/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CPLUOS/nano/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/CPLUOS/nano/statuses/d8189f7f73238bc8b43f28e52369da1cd4bf6771"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"tt8888tt"}}