{"action":"created","comment":{"url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/pulls/comments/230031549","pull_request_review_id":170671075,"id":230031549,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDAzMTU0OQ==","diff_hunk":"@@ -1378,7 +1398,12 @@ public ProcessWrapper launchTranscode(\n \n \t\t\t\tencodeSettings = \"-lavcopts \" + aspectRatioLavcopts + vcodecString + acodec + abitrate +\n \t\t\t\t\t\":threads=\" + configuration.getMencoderMaxThreads() +\n-\t\t\t\t\t\":o=preset=superfast,crf=\" + x264CRF + \",g=250,i_qfactor=0.71,qcomp=0.6,level=3.1,weightp=0,8x8dct=0,aq-strength=0,me_range=16\";\n+\t\t\t\t\t\":o=preset=superfast,crf=\" + x264CRF + \",g=250,i_qfactor=0.71,qcomp=0.6,\";\n+\t\t\t\tVideoLevel level = params.mediaRenderer.getVideoLevelLimit(VideoCodec.H264);\n+\t\t\t\tif (level != null) {\n+\t\t\t\t\tencodeSettings += \"level=\" + level.toString(false) + \",\";","path":"src/main/java/net/pms/encoders/MEncoderVideo.java","position":63,"original_position":63,"commit_id":"a08fd33f3feec1e58df38273d39e3e5177378b54","original_commit_id":"a08fd33f3feec1e58df38273d39e3e5177378b54","user":{"login":"Sami32","id":18471069,"node_id":"MDQ6VXNlcjE4NDcxMDY5","avatar_url":"https://avatars3.githubusercontent.com/u/18471069?v=4","gravatar_id":"","url":"https://api.github.com/users/Sami32","html_url":"https://github.com/Sami32","followers_url":"https://api.github.com/users/Sami32/followers","following_url":"https://api.github.com/users/Sami32/following{/other_user}","gists_url":"https://api.github.com/users/Sami32/gists{/gist_id}","starred_url":"https://api.github.com/users/Sami32/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sami32/subscriptions","organizations_url":"https://api.github.com/users/Sami32/orgs","repos_url":"https://api.github.com/users/Sami32/repos","events_url":"https://api.github.com/users/Sami32/events{/privacy}","received_events_url":"https://api.github.com/users/Sami32/received_events","type":"User","site_admin":false},"body":"The level should be added this way:\r\n... `:level=41:o=preset=superfast`","created_at":"2018-11-01T12:52:34Z","updated_at":"2018-11-01T12:52:34Z","html_url":"https://github.com/DigitalMediaServer/DigitalMediaServer/pull/115#discussion_r230031549","pull_request_url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/pulls/115","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/pulls/comments/230031549"},"html":{"href":"https://github.com/DigitalMediaServer/DigitalMediaServer/pull/115#discussion_r230031549"},"pull_request":{"href":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/pulls/115"}},"in_reply_to_id":230030096},"pull_request":{"url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/pulls/115","id":226070284,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2MDcwMjg0","html_url":"https://github.com/DigitalMediaServer/DigitalMediaServer/pull/115","diff_url":"https://github.com/DigitalMediaServer/DigitalMediaServer/pull/115.diff","patch_url":"https://github.com/DigitalMediaServer/DigitalMediaServer/pull/115.patch","issue_url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/issues/115","number":115,"state":"open","locked":false,"title":"Video level limits","user":{"login":"Nadahar","id":12900583,"node_id":"MDQ6VXNlcjEyOTAwNTgz","avatar_url":"https://avatars2.githubusercontent.com/u/12900583?v=4","gravatar_id":"","url":"https://api.github.com/users/Nadahar","html_url":"https://github.com/Nadahar","followers_url":"https://api.github.com/users/Nadahar/followers","following_url":"https://api.github.com/users/Nadahar/following{/other_user}","gists_url":"https://api.github.com/users/Nadahar/gists{/gist_id}","starred_url":"https://api.github.com/users/Nadahar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nadahar/subscriptions","organizations_url":"https://api.github.com/users/Nadahar/orgs","repos_url":"https://api.github.com/users/Nadahar/repos","events_url":"https://api.github.com/users/Nadahar/events{/privacy}","received_events_url":"https://api.github.com/users/Nadahar/received_events","type":"User","site_admin":false},"body":"I'm trying to salvage our previous work on H.264 and H.265 level. However, there are some stuff here that really doesn't make sense to me, so I need to ask some questions before I continue.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/digitalmediaserver/digitalmediaserver/115)\n<!-- Reviewable:end -->\n","created_at":"2018-10-26T11:48:17Z","updated_at":"2018-11-01T12:52:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f725b5af8313e7a628b0003824f1792bb3e6598d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":658667249,"node_id":"MDU6TGFiZWw2NTg2NjcyNDk=","url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/labels/awaiting%20review","name":"awaiting review","color":"d93f0b","default":false},{"id":658668190,"node_id":"MDU6TGFiZWw2NTg2NjgxOTA=","url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/labels/testing%20needed","name":"testing needed","color":"d93f1b","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/pulls/115/commits","review_comments_url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/pulls/115/comments","review_comment_url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/issues/115/comments","statuses_url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/statuses/a08fd33f3feec1e58df38273d39e3e5177378b54","head":{"label":"DigitalMediaServer:h265","ref":"h265","sha":"a08fd33f3feec1e58df38273d39e3e5177378b54","user":{"login":"DigitalMediaServer","id":17323476,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MzIzNDc2","avatar_url":"https://avatars1.githubusercontent.com/u/17323476?v=4","gravatar_id":"","url":"https://api.github.com/users/DigitalMediaServer","html_url":"https://github.com/DigitalMediaServer","followers_url":"https://api.github.com/users/DigitalMediaServer/followers","following_url":"https://api.github.com/users/DigitalMediaServer/following{/other_user}","gists_url":"https://api.github.com/users/DigitalMediaServer/gists{/gist_id}","starred_url":"https://api.github.com/users/DigitalMediaServer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DigitalMediaServer/subscriptions","organizations_url":"https://api.github.com/users/DigitalMediaServer/orgs","repos_url":"https://api.github.com/users/DigitalMediaServer/repos","events_url":"https://api.github.com/users/DigitalMediaServer/events{/privacy}","received_events_url":"https://api.github.com/users/DigitalMediaServer/received_events","type":"Organization","site_admin":false},"repo":{"id":52096694,"node_id":"MDEwOlJlcG9zaXRvcnk1MjA5NjY5NA==","name":"DigitalMediaServer","full_name":"DigitalMediaServer/DigitalMediaServer","private":false,"owner":{"login":"DigitalMediaServer","id":17323476,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MzIzNDc2","avatar_url":"https://avatars1.githubusercontent.com/u/17323476?v=4","gravatar_id":"","url":"https://api.github.com/users/DigitalMediaServer","html_url":"https://github.com/DigitalMediaServer","followers_url":"https://api.github.com/users/DigitalMediaServer/followers","following_url":"https://api.github.com/users/DigitalMediaServer/following{/other_user}","gists_url":"https://api.github.com/users/DigitalMediaServer/gists{/gist_id}","starred_url":"https://api.github.com/users/DigitalMediaServer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DigitalMediaServer/subscriptions","organizations_url":"https://api.github.com/users/DigitalMediaServer/orgs","repos_url":"https://api.github.com/users/DigitalMediaServer/repos","events_url":"https://api.github.com/users/DigitalMediaServer/events{/privacy}","received_events_url":"https://api.github.com/users/DigitalMediaServer/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/DigitalMediaServer/DigitalMediaServer","description":"A DLNA-compliant UPnP Media Server with focus on quality.","fork":false,"url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer","forks_url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/forks","keys_url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/teams","hooks_url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/hooks","issue_events_url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/issues/events{/number}","events_url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/events","assignees_url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/assignees{/user}","branches_url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/branches{/branch}","tags_url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/tags","blobs_url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/git/refs{/sha}","trees_url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/statuses/{sha}","languages_url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/languages","stargazers_url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/stargazers","contributors_url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/contributors","subscribers_url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/subscribers","subscription_url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/subscription","commits_url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/commits{/sha}","git_commits_url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/git/commits{/sha}","comments_url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/comments{/number}","issue_comment_url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/issues/comments{/number}","contents_url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/contents/{+path}","compare_url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/merges","archive_url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/downloads","issues_url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/issues{/number}","pulls_url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/pulls{/number}","milestones_url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/milestones{/number}","notifications_url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/labels{/name}","releases_url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/releases{/id}","deployments_url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/deployments","created_at":"2016-02-19T15:26:46Z","updated_at":"2018-10-25T12:33:34Z","pushed_at":"2018-11-01T02:12:59Z","git_url":"git://github.com/DigitalMediaServer/DigitalMediaServer.git","ssh_url":"git@github.com:DigitalMediaServer/DigitalMediaServer.git","clone_url":"https://github.com/DigitalMediaServer/DigitalMediaServer.git","svn_url":"https://github.com/DigitalMediaServer/DigitalMediaServer","homepage":"","size":80954,"stargazers_count":11,"watchers_count":11,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":41,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":5,"open_issues":41,"watchers":11,"default_branch":"master"}},"base":{"label":"DigitalMediaServer:master","ref":"master","sha":"663ab74fd0da91d2fb7d635ab940c9490a4347fd","user":{"login":"DigitalMediaServer","id":17323476,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MzIzNDc2","avatar_url":"https://avatars1.githubusercontent.com/u/17323476?v=4","gravatar_id":"","url":"https://api.github.com/users/DigitalMediaServer","html_url":"https://github.com/DigitalMediaServer","followers_url":"https://api.github.com/users/DigitalMediaServer/followers","following_url":"https://api.github.com/users/DigitalMediaServer/following{/other_user}","gists_url":"https://api.github.com/users/DigitalMediaServer/gists{/gist_id}","starred_url":"https://api.github.com/users/DigitalMediaServer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DigitalMediaServer/subscriptions","organizations_url":"https://api.github.com/users/DigitalMediaServer/orgs","repos_url":"https://api.github.com/users/DigitalMediaServer/repos","events_url":"https://api.github.com/users/DigitalMediaServer/events{/privacy}","received_events_url":"https://api.github.com/users/DigitalMediaServer/received_events","type":"Organization","site_admin":false},"repo":{"id":52096694,"node_id":"MDEwOlJlcG9zaXRvcnk1MjA5NjY5NA==","name":"DigitalMediaServer","full_name":"DigitalMediaServer/DigitalMediaServer","private":false,"owner":{"login":"DigitalMediaServer","id":17323476,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MzIzNDc2","avatar_url":"https://avatars1.githubusercontent.com/u/17323476?v=4","gravatar_id":"","url":"https://api.github.com/users/DigitalMediaServer","html_url":"https://github.com/DigitalMediaServer","followers_url":"https://api.github.com/users/DigitalMediaServer/followers","following_url":"https://api.github.com/users/DigitalMediaServer/following{/other_user}","gists_url":"https://api.github.com/users/DigitalMediaServer/gists{/gist_id}","starred_url":"https://api.github.com/users/DigitalMediaServer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DigitalMediaServer/subscriptions","organizations_url":"https://api.github.com/users/DigitalMediaServer/orgs","repos_url":"https://api.github.com/users/DigitalMediaServer/repos","events_url":"https://api.github.com/users/DigitalMediaServer/events{/privacy}","received_events_url":"https://api.github.com/users/DigitalMediaServer/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/DigitalMediaServer/DigitalMediaServer","description":"A DLNA-compliant UPnP Media Server with focus on quality.","fork":false,"url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer","forks_url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/forks","keys_url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/teams","hooks_url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/hooks","issue_events_url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/issues/events{/number}","events_url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/events","assignees_url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/assignees{/user}","branches_url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/branches{/branch}","tags_url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/tags","blobs_url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/git/refs{/sha}","trees_url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/statuses/{sha}","languages_url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/languages","stargazers_url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/stargazers","contributors_url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/contributors","subscribers_url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/subscribers","subscription_url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/subscription","commits_url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/commits{/sha}","git_commits_url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/git/commits{/sha}","comments_url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/comments{/number}","issue_comment_url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/issues/comments{/number}","contents_url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/contents/{+path}","compare_url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/merges","archive_url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/downloads","issues_url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/issues{/number}","pulls_url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/pulls{/number}","milestones_url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/milestones{/number}","notifications_url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/labels{/name}","releases_url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/releases{/id}","deployments_url":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/deployments","created_at":"2016-02-19T15:26:46Z","updated_at":"2018-10-25T12:33:34Z","pushed_at":"2018-11-01T02:12:59Z","git_url":"git://github.com/DigitalMediaServer/DigitalMediaServer.git","ssh_url":"git@github.com:DigitalMediaServer/DigitalMediaServer.git","clone_url":"https://github.com/DigitalMediaServer/DigitalMediaServer.git","svn_url":"https://github.com/DigitalMediaServer/DigitalMediaServer","homepage":"","size":80954,"stargazers_count":11,"watchers_count":11,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":41,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":5,"open_issues":41,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/pulls/115"},"html":{"href":"https://github.com/DigitalMediaServer/DigitalMediaServer/pull/115"},"issue":{"href":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/issues/115"},"comments":{"href":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/issues/115/comments"},"review_comments":{"href":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/pulls/115/comments"},"review_comment":{"href":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/pulls/115/commits"},"statuses":{"href":"https://api.github.com/repos/DigitalMediaServer/DigitalMediaServer/statuses/a08fd33f3feec1e58df38273d39e3e5177378b54"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Sami32"}}