{"action":"created","comment":{"url":"https://api.github.com/repos/apple/swift/pulls/comments/217474433","pull_request_review_id":155195269,"id":217474433,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzQ3NDQzMw==","diff_hunk":"@@ -83,7 +83,7 @@ UnicodeScalarPropertiesTests.test(\"properties.booleanProperties\") {\n   expectBooleanProperty(\\.changesWhenNFKCCaseFolded, trueFor: \"A\", falseFor: \"!\")\n \n #if os(macOS) || os(iOS) || os(watchOS) || os(tvOS)\n-  if #available(iOS 10.2, *) {\n+  if #available(macOS 10.12, iOS 10, tvOS 10, watchOS 3, *) {","path":"test/stdlib/UnicodeScalarPropertiesTests.swift","position":null,"original_position":5,"commit_id":"cec9faf1c0ad6a2768be47da9501ecd928cdaa4e","original_commit_id":"ef1a6a4b7f4ddaba72b18b978266fce32b6277ed","user":{"login":"jrose-apple","id":15097531,"node_id":"MDQ6VXNlcjE1MDk3NTMx","avatar_url":"https://avatars2.githubusercontent.com/u/15097531?v=4","gravatar_id":"","url":"https://api.github.com/users/jrose-apple","html_url":"https://github.com/jrose-apple","followers_url":"https://api.github.com/users/jrose-apple/followers","following_url":"https://api.github.com/users/jrose-apple/following{/other_user}","gists_url":"https://api.github.com/users/jrose-apple/gists{/gist_id}","starred_url":"https://api.github.com/users/jrose-apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrose-apple/subscriptions","organizations_url":"https://api.github.com/users/jrose-apple/orgs","repos_url":"https://api.github.com/users/jrose-apple/repos","events_url":"https://api.github.com/users/jrose-apple/events{/privacy}","received_events_url":"https://api.github.com/users/jrose-apple/received_events","type":"User","site_admin":false},"body":"I think the point was that the *properties* were available but the *test* behavior changed.","created_at":"2018-09-13T17:43:25Z","updated_at":"2018-09-13T17:43:25Z","html_url":"https://github.com/apple/swift/pull/19209#discussion_r217474433","pull_request_url":"https://api.github.com/repos/apple/swift/pulls/19209","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/comments/217474433"},"html":{"href":"https://github.com/apple/swift/pull/19209#discussion_r217474433"},"pull_request":{"href":"https://api.github.com/repos/apple/swift/pulls/19209"}},"in_reply_to_id":216408332},"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/19209","id":214144525,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0MTQ0NTI1","html_url":"https://github.com/apple/swift/pull/19209","diff_url":"https://github.com/apple/swift/pull/19209.diff","patch_url":"https://github.com/apple/swift/pull/19209.patch","issue_url":"https://api.github.com/repos/apple/swift/issues/19209","number":19209,"state":"open","locked":false,"title":"[SE-0211] Emoji properties require ICU 57 or later","user":{"login":"benrimmington","id":889638,"node_id":"MDQ6VXNlcjg4OTYzOA==","avatar_url":"https://avatars1.githubusercontent.com/u/889638?v=4","gravatar_id":"","url":"https://api.github.com/users/benrimmington","html_url":"https://github.com/benrimmington","followers_url":"https://api.github.com/users/benrimmington/followers","following_url":"https://api.github.com/users/benrimmington/following{/other_user}","gists_url":"https://api.github.com/users/benrimmington/gists{/gist_id}","starred_url":"https://api.github.com/users/benrimmington/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benrimmington/subscriptions","organizations_url":"https://api.github.com/users/benrimmington/orgs","repos_url":"https://api.github.com/users/benrimmington/repos","events_url":"https://api.github.com/users/benrimmington/events{/privacy}","received_events_url":"https://api.github.com/users/benrimmington/received_events","type":"User","site_admin":false},"body":"Availability of emoji properties should be platform versions which have a `/usr/lib/libicucore.dylib` derived from ICU 57 or later.\r\n\r\n|  ICU |   macOS |  iOS | tvOS | watchOS |\r\n| ---: | ------: | ---: | ---: | ------: |\r\n|  55  |  10.11  |   9  |   9  |      2  |\r\n| *57* | *10.12* | *10* | *10* |     *3* |\r\n|  59  |  10.13  |  11  |  11  |      4  |\r\n\r\nThese platform versions are based on the `unicode/uchar.h` and `unicode/uvernum.h` headers of:\r\n\r\n- the macOS ICU projects at <https://opensource.apple.com/>;\r\n- the iOS, tvOS, and watchOS SDKs.\r\n\r\n(I didn't check as far back as macOS 10.9 or iOS 7).\r\n\r\nThis pull request is a follow-up to:\r\n\r\n- <https://github.com/apple/swift/pull/15593/commits/b454e8d0f4df76ac3564af97c9f7f431f36a33c6>\r\n- <https://github.com/apple/swift/pull/17992>","created_at":"2018-09-09T13:07:30Z","updated_at":"2018-09-13T17:43:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"44f7fa44a2d9d2678a9fe5658c73677f3310a82a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift/pulls/19209/commits","review_comments_url":"https://api.github.com/repos/apple/swift/pulls/19209/comments","review_comment_url":"https://api.github.com/repos/apple/swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift/issues/19209/comments","statuses_url":"https://api.github.com/repos/apple/swift/statuses/cec9faf1c0ad6a2768be47da9501ecd928cdaa4e","head":{"label":"benrimmington:emoji_gate_2","ref":"emoji_gate_2","sha":"cec9faf1c0ad6a2768be47da9501ecd928cdaa4e","user":{"login":"benrimmington","id":889638,"node_id":"MDQ6VXNlcjg4OTYzOA==","avatar_url":"https://avatars1.githubusercontent.com/u/889638?v=4","gravatar_id":"","url":"https://api.github.com/users/benrimmington","html_url":"https://github.com/benrimmington","followers_url":"https://api.github.com/users/benrimmington/followers","following_url":"https://api.github.com/users/benrimmington/following{/other_user}","gists_url":"https://api.github.com/users/benrimmington/gists{/gist_id}","starred_url":"https://api.github.com/users/benrimmington/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benrimmington/subscriptions","organizations_url":"https://api.github.com/users/benrimmington/orgs","repos_url":"https://api.github.com/users/benrimmington/repos","events_url":"https://api.github.com/users/benrimmington/events{/privacy}","received_events_url":"https://api.github.com/users/benrimmington/received_events","type":"User","site_admin":false},"repo":{"id":113745445,"node_id":"MDEwOlJlcG9zaXRvcnkxMTM3NDU0NDU=","name":"swift","full_name":"benrimmington/swift","owner":{"login":"benrimmington","id":889638,"node_id":"MDQ6VXNlcjg4OTYzOA==","avatar_url":"https://avatars1.githubusercontent.com/u/889638?v=4","gravatar_id":"","url":"https://api.github.com/users/benrimmington","html_url":"https://github.com/benrimmington","followers_url":"https://api.github.com/users/benrimmington/followers","following_url":"https://api.github.com/users/benrimmington/following{/other_user}","gists_url":"https://api.github.com/users/benrimmington/gists{/gist_id}","starred_url":"https://api.github.com/users/benrimmington/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benrimmington/subscriptions","organizations_url":"https://api.github.com/users/benrimmington/orgs","repos_url":"https://api.github.com/users/benrimmington/repos","events_url":"https://api.github.com/users/benrimmington/events{/privacy}","received_events_url":"https://api.github.com/users/benrimmington/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/benrimmington/swift","description":"The Swift Programming Language","fork":true,"url":"https://api.github.com/repos/benrimmington/swift","forks_url":"https://api.github.com/repos/benrimmington/swift/forks","keys_url":"https://api.github.com/repos/benrimmington/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/benrimmington/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/benrimmington/swift/teams","hooks_url":"https://api.github.com/repos/benrimmington/swift/hooks","issue_events_url":"https://api.github.com/repos/benrimmington/swift/issues/events{/number}","events_url":"https://api.github.com/repos/benrimmington/swift/events","assignees_url":"https://api.github.com/repos/benrimmington/swift/assignees{/user}","branches_url":"https://api.github.com/repos/benrimmington/swift/branches{/branch}","tags_url":"https://api.github.com/repos/benrimmington/swift/tags","blobs_url":"https://api.github.com/repos/benrimmington/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/benrimmington/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/benrimmington/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/benrimmington/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/benrimmington/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/benrimmington/swift/languages","stargazers_url":"https://api.github.com/repos/benrimmington/swift/stargazers","contributors_url":"https://api.github.com/repos/benrimmington/swift/contributors","subscribers_url":"https://api.github.com/repos/benrimmington/swift/subscribers","subscription_url":"https://api.github.com/repos/benrimmington/swift/subscription","commits_url":"https://api.github.com/repos/benrimmington/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/benrimmington/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/benrimmington/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/benrimmington/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/benrimmington/swift/contents/{+path}","compare_url":"https://api.github.com/repos/benrimmington/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/benrimmington/swift/merges","archive_url":"https://api.github.com/repos/benrimmington/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/benrimmington/swift/downloads","issues_url":"https://api.github.com/repos/benrimmington/swift/issues{/number}","pulls_url":"https://api.github.com/repos/benrimmington/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/benrimmington/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/benrimmington/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/benrimmington/swift/labels{/name}","releases_url":"https://api.github.com/repos/benrimmington/swift/releases{/id}","deployments_url":"https://api.github.com/repos/benrimmington/swift/deployments","created_at":"2017-12-10T11:47:19Z","updated_at":"2018-09-13T16:59:44Z","pushed_at":"2018-09-13T17:28:28Z","git_url":"git://github.com/benrimmington/swift.git","ssh_url":"git@github.com:benrimmington/swift.git","clone_url":"https://github.com/benrimmington/swift.git","svn_url":"https://github.com/benrimmington/swift","homepage":"https://swift.org/","size":321563,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"c94bc1d7dbde329242cf68f856284095e07d9f1f","user":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44838949,"node_id":"MDEwOlJlcG9zaXRvcnk0NDgzODk0OQ==","name":"swift","full_name":"apple/swift","owner":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/swift","description":"The Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift","forks_url":"https://api.github.com/repos/apple/swift/forks","keys_url":"https://api.github.com/repos/apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift/teams","hooks_url":"https://api.github.com/repos/apple/swift/hooks","issue_events_url":"https://api.github.com/repos/apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift/events","assignees_url":"https://api.github.com/repos/apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift/tags","blobs_url":"https://api.github.com/repos/apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift/languages","stargazers_url":"https://api.github.com/repos/apple/swift/stargazers","contributors_url":"https://api.github.com/repos/apple/swift/contributors","subscribers_url":"https://api.github.com/repos/apple/swift/subscribers","subscription_url":"https://api.github.com/repos/apple/swift/subscription","commits_url":"https://api.github.com/repos/apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift/merges","archive_url":"https://api.github.com/repos/apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift/downloads","issues_url":"https://api.github.com/repos/apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift/deployments","created_at":"2015-10-23T21:15:07Z","updated_at":"2018-09-13T17:39:12Z","pushed_at":"2018-09-13T17:37:07Z","git_url":"git://github.com/apple/swift.git","ssh_url":"git@github.com:apple/swift.git","clone_url":"https://github.com/apple/swift.git","svn_url":"https://github.com/apple/swift","homepage":"https://swift.org","size":337689,"stargazers_count":45174,"watchers_count":45174,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7124,"mirror_url":null,"archived":false,"open_issues_count":383,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":7124,"open_issues":383,"watchers":45174,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/19209"},"html":{"href":"https://github.com/apple/swift/pull/19209"},"issue":{"href":"https://api.github.com/repos/apple/swift/issues/19209"},"comments":{"href":"https://api.github.com/repos/apple/swift/issues/19209/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift/pulls/19209/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift/pulls/19209/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift/statuses/cec9faf1c0ad6a2768be47da9501ecd928cdaa4e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jrose-apple"}}