{"action":"created","comment":{"url":"https://api.github.com/repos/infinispan/infinispan/pulls/comments/232285299","pull_request_review_id":173382074,"id":232285299,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjI4NTI5OQ==","diff_hunk":"@@ -0,0 +1,24 @@\n+package org.infinispan.rest.framework.impl;\n+\n+import java.util.Map;\n+\n+import org.infinispan.rest.framework.ContentSource;\n+import org.infinispan.rest.framework.Method;\n+import org.infinispan.rest.framework.RestRequest;\n+\n+/**\n+ * @since 10.0\n+ */\n+public interface RestRequestBuilder<B extends RestRequestBuilder<B>> {","path":"server/rest/src/main/java/org/infinispan/rest/framework/impl/RestRequestBuilder.java","position":12,"original_position":12,"commit_id":"0d344311b572cde316a7c42a7b03c7ff88e03366","original_commit_id":"0d344311b572cde316a7c42a7b03c7ff88e03366","user":{"login":"ryanemerson","id":765332,"node_id":"MDQ6VXNlcjc2NTMzMg==","avatar_url":"https://avatars3.githubusercontent.com/u/765332?v=4","gravatar_id":"","url":"https://api.github.com/users/ryanemerson","html_url":"https://github.com/ryanemerson","followers_url":"https://api.github.com/users/ryanemerson/followers","following_url":"https://api.github.com/users/ryanemerson/following{/other_user}","gists_url":"https://api.github.com/users/ryanemerson/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanemerson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanemerson/subscriptions","organizations_url":"https://api.github.com/users/ryanemerson/orgs","repos_url":"https://api.github.com/users/ryanemerson/repos","events_url":"https://api.github.com/users/ryanemerson/events{/privacy}","received_events_url":"https://api.github.com/users/ryanemerson/received_events","type":"User","site_admin":false},"body":"package-private?","created_at":"2018-11-09T15:10:29Z","updated_at":"2018-11-09T15:14:04Z","html_url":"https://github.com/infinispan/infinispan/pull/6380#discussion_r232285299","pull_request_url":"https://api.github.com/repos/infinispan/infinispan/pulls/6380","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/comments/232285299"},"html":{"href":"https://github.com/infinispan/infinispan/pull/6380#discussion_r232285299"},"pull_request":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/6380"}}},"pull_request":{"url":"https://api.github.com/repos/infinispan/infinispan/pulls/6380","id":229324916,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5MzI0OTE2","html_url":"https://github.com/infinispan/infinispan/pull/6380","diff_url":"https://github.com/infinispan/infinispan/pull/6380.diff","patch_url":"https://github.com/infinispan/infinispan/pull/6380.patch","issue_url":"https://api.github.com/repos/infinispan/infinispan/issues/6380","number":6380,"state":"open","locked":false,"title":"ISPN-9688 Internal REST server modularization","user":{"login":"gustavonalle","id":440989,"node_id":"MDQ6VXNlcjQ0MDk4OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/440989?v=4","gravatar_id":"","url":"https://api.github.com/users/gustavonalle","html_url":"https://github.com/gustavonalle","followers_url":"https://api.github.com/users/gustavonalle/followers","following_url":"https://api.github.com/users/gustavonalle/following{/other_user}","gists_url":"https://api.github.com/users/gustavonalle/gists{/gist_id}","starred_url":"https://api.github.com/users/gustavonalle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gustavonalle/subscriptions","organizations_url":"https://api.github.com/users/gustavonalle/orgs","repos_url":"https://api.github.com/users/gustavonalle/repos","events_url":"https://api.github.com/users/gustavonalle/events{/privacy}","received_events_url":"https://api.github.com/users/gustavonalle/received_events","type":"User","site_admin":false},"body":"https://issues.jboss.org/browse/ISPN-9688\r\n\r\n* This should keep the REST server behavior intact;\r\n* Perf wise, it should be roughly the same. I measured a ~5% increase in throughput and ~5-10% decrease in object allocation, but those are likely noise, let's see what RadarGun says.\r\n","created_at":"2018-11-08T10:57:44Z","updated_at":"2018-11-09T15:14:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8097b07da7c973a53c1d7b9a4c6e17a19fffb3df","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/infinispan/infinispan/pulls/6380/commits","review_comments_url":"https://api.github.com/repos/infinispan/infinispan/pulls/6380/comments","review_comment_url":"https://api.github.com/repos/infinispan/infinispan/pulls/comments{/number}","comments_url":"https://api.github.com/repos/infinispan/infinispan/issues/6380/comments","statuses_url":"https://api.github.com/repos/infinispan/infinispan/statuses/0d344311b572cde316a7c42a7b03c7ff88e03366","head":{"label":"gustavonalle:ISPN-9688/rest-modular","ref":"ISPN-9688/rest-modular","sha":"0d344311b572cde316a7c42a7b03c7ff88e03366","user":{"login":"gustavonalle","id":440989,"node_id":"MDQ6VXNlcjQ0MDk4OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/440989?v=4","gravatar_id":"","url":"https://api.github.com/users/gustavonalle","html_url":"https://github.com/gustavonalle","followers_url":"https://api.github.com/users/gustavonalle/followers","following_url":"https://api.github.com/users/gustavonalle/following{/other_user}","gists_url":"https://api.github.com/users/gustavonalle/gists{/gist_id}","starred_url":"https://api.github.com/users/gustavonalle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gustavonalle/subscriptions","organizations_url":"https://api.github.com/users/gustavonalle/orgs","repos_url":"https://api.github.com/users/gustavonalle/repos","events_url":"https://api.github.com/users/gustavonalle/events{/privacy}","received_events_url":"https://api.github.com/users/gustavonalle/received_events","type":"User","site_admin":false},"repo":{"id":20231400,"node_id":"MDEwOlJlcG9zaXRvcnkyMDIzMTQwMA==","name":"infinispan","full_name":"gustavonalle/infinispan","private":false,"owner":{"login":"gustavonalle","id":440989,"node_id":"MDQ6VXNlcjQ0MDk4OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/440989?v=4","gravatar_id":"","url":"https://api.github.com/users/gustavonalle","html_url":"https://github.com/gustavonalle","followers_url":"https://api.github.com/users/gustavonalle/followers","following_url":"https://api.github.com/users/gustavonalle/following{/other_user}","gists_url":"https://api.github.com/users/gustavonalle/gists{/gist_id}","starred_url":"https://api.github.com/users/gustavonalle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gustavonalle/subscriptions","organizations_url":"https://api.github.com/users/gustavonalle/orgs","repos_url":"https://api.github.com/users/gustavonalle/repos","events_url":"https://api.github.com/users/gustavonalle/events{/privacy}","received_events_url":"https://api.github.com/users/gustavonalle/received_events","type":"User","site_admin":false},"html_url":"https://github.com/gustavonalle/infinispan","description":"Infinispan is an open source data grid platform and highly scalable NoSQL cloud data store.","fork":true,"url":"https://api.github.com/repos/gustavonalle/infinispan","forks_url":"https://api.github.com/repos/gustavonalle/infinispan/forks","keys_url":"https://api.github.com/repos/gustavonalle/infinispan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gustavonalle/infinispan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gustavonalle/infinispan/teams","hooks_url":"https://api.github.com/repos/gustavonalle/infinispan/hooks","issue_events_url":"https://api.github.com/repos/gustavonalle/infinispan/issues/events{/number}","events_url":"https://api.github.com/repos/gustavonalle/infinispan/events","assignees_url":"https://api.github.com/repos/gustavonalle/infinispan/assignees{/user}","branches_url":"https://api.github.com/repos/gustavonalle/infinispan/branches{/branch}","tags_url":"https://api.github.com/repos/gustavonalle/infinispan/tags","blobs_url":"https://api.github.com/repos/gustavonalle/infinispan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gustavonalle/infinispan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gustavonalle/infinispan/git/refs{/sha}","trees_url":"https://api.github.com/repos/gustavonalle/infinispan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gustavonalle/infinispan/statuses/{sha}","languages_url":"https://api.github.com/repos/gustavonalle/infinispan/languages","stargazers_url":"https://api.github.com/repos/gustavonalle/infinispan/stargazers","contributors_url":"https://api.github.com/repos/gustavonalle/infinispan/contributors","subscribers_url":"https://api.github.com/repos/gustavonalle/infinispan/subscribers","subscription_url":"https://api.github.com/repos/gustavonalle/infinispan/subscription","commits_url":"https://api.github.com/repos/gustavonalle/infinispan/commits{/sha}","git_commits_url":"https://api.github.com/repos/gustavonalle/infinispan/git/commits{/sha}","comments_url":"https://api.github.com/repos/gustavonalle/infinispan/comments{/number}","issue_comment_url":"https://api.github.com/repos/gustavonalle/infinispan/issues/comments{/number}","contents_url":"https://api.github.com/repos/gustavonalle/infinispan/contents/{+path}","compare_url":"https://api.github.com/repos/gustavonalle/infinispan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gustavonalle/infinispan/merges","archive_url":"https://api.github.com/repos/gustavonalle/infinispan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gustavonalle/infinispan/downloads","issues_url":"https://api.github.com/repos/gustavonalle/infinispan/issues{/number}","pulls_url":"https://api.github.com/repos/gustavonalle/infinispan/pulls{/number}","milestones_url":"https://api.github.com/repos/gustavonalle/infinispan/milestones{/number}","notifications_url":"https://api.github.com/repos/gustavonalle/infinispan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gustavonalle/infinispan/labels{/name}","releases_url":"https://api.github.com/repos/gustavonalle/infinispan/releases{/id}","deployments_url":"https://api.github.com/repos/gustavonalle/infinispan/deployments","created_at":"2014-05-27T18:52:33Z","updated_at":"2018-07-31T08:53:31Z","pushed_at":"2018-11-09T11:09:21Z","git_url":"git://github.com/gustavonalle/infinispan.git","ssh_url":"git@github.com:gustavonalle/infinispan.git","clone_url":"https://github.com/gustavonalle/infinispan.git","svn_url":"https://github.com/gustavonalle/infinispan","homepage":"http://www.infinispan.org","size":105578,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"infinispan:master","ref":"master","sha":"38f24bfe07f6db428cfca3399595fb3873d047aa","user":{"login":"infinispan","id":458093,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1ODA5Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/458093?v=4","gravatar_id":"","url":"https://api.github.com/users/infinispan","html_url":"https://github.com/infinispan","followers_url":"https://api.github.com/users/infinispan/followers","following_url":"https://api.github.com/users/infinispan/following{/other_user}","gists_url":"https://api.github.com/users/infinispan/gists{/gist_id}","starred_url":"https://api.github.com/users/infinispan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infinispan/subscriptions","organizations_url":"https://api.github.com/users/infinispan/orgs","repos_url":"https://api.github.com/users/infinispan/repos","events_url":"https://api.github.com/users/infinispan/events{/privacy}","received_events_url":"https://api.github.com/users/infinispan/received_events","type":"Organization","site_admin":false},"repo":{"id":1050944,"node_id":"MDEwOlJlcG9zaXRvcnkxMDUwOTQ0","name":"infinispan","full_name":"infinispan/infinispan","private":false,"owner":{"login":"infinispan","id":458093,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1ODA5Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/458093?v=4","gravatar_id":"","url":"https://api.github.com/users/infinispan","html_url":"https://github.com/infinispan","followers_url":"https://api.github.com/users/infinispan/followers","following_url":"https://api.github.com/users/infinispan/following{/other_user}","gists_url":"https://api.github.com/users/infinispan/gists{/gist_id}","starred_url":"https://api.github.com/users/infinispan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infinispan/subscriptions","organizations_url":"https://api.github.com/users/infinispan/orgs","repos_url":"https://api.github.com/users/infinispan/repos","events_url":"https://api.github.com/users/infinispan/events{/privacy}","received_events_url":"https://api.github.com/users/infinispan/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/infinispan/infinispan","description":"Infinispan is an open source data grid platform and highly scalable NoSQL cloud data store.","fork":false,"url":"https://api.github.com/repos/infinispan/infinispan","forks_url":"https://api.github.com/repos/infinispan/infinispan/forks","keys_url":"https://api.github.com/repos/infinispan/infinispan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/infinispan/infinispan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/infinispan/infinispan/teams","hooks_url":"https://api.github.com/repos/infinispan/infinispan/hooks","issue_events_url":"https://api.github.com/repos/infinispan/infinispan/issues/events{/number}","events_url":"https://api.github.com/repos/infinispan/infinispan/events","assignees_url":"https://api.github.com/repos/infinispan/infinispan/assignees{/user}","branches_url":"https://api.github.com/repos/infinispan/infinispan/branches{/branch}","tags_url":"https://api.github.com/repos/infinispan/infinispan/tags","blobs_url":"https://api.github.com/repos/infinispan/infinispan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/infinispan/infinispan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/infinispan/infinispan/git/refs{/sha}","trees_url":"https://api.github.com/repos/infinispan/infinispan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/infinispan/infinispan/statuses/{sha}","languages_url":"https://api.github.com/repos/infinispan/infinispan/languages","stargazers_url":"https://api.github.com/repos/infinispan/infinispan/stargazers","contributors_url":"https://api.github.com/repos/infinispan/infinispan/contributors","subscribers_url":"https://api.github.com/repos/infinispan/infinispan/subscribers","subscription_url":"https://api.github.com/repos/infinispan/infinispan/subscription","commits_url":"https://api.github.com/repos/infinispan/infinispan/commits{/sha}","git_commits_url":"https://api.github.com/repos/infinispan/infinispan/git/commits{/sha}","comments_url":"https://api.github.com/repos/infinispan/infinispan/comments{/number}","issue_comment_url":"https://api.github.com/repos/infinispan/infinispan/issues/comments{/number}","contents_url":"https://api.github.com/repos/infinispan/infinispan/contents/{+path}","compare_url":"https://api.github.com/repos/infinispan/infinispan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/infinispan/infinispan/merges","archive_url":"https://api.github.com/repos/infinispan/infinispan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/infinispan/infinispan/downloads","issues_url":"https://api.github.com/repos/infinispan/infinispan/issues{/number}","pulls_url":"https://api.github.com/repos/infinispan/infinispan/pulls{/number}","milestones_url":"https://api.github.com/repos/infinispan/infinispan/milestones{/number}","notifications_url":"https://api.github.com/repos/infinispan/infinispan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/infinispan/infinispan/labels{/name}","releases_url":"https://api.github.com/repos/infinispan/infinispan/releases{/id}","deployments_url":"https://api.github.com/repos/infinispan/infinispan/deployments","created_at":"2010-11-04T12:33:19Z","updated_at":"2018-11-09T10:52:11Z","pushed_at":"2018-11-09T14:32:43Z","git_url":"git://github.com/infinispan/infinispan.git","ssh_url":"git@github.com:infinispan/infinispan.git","clone_url":"https://github.com/infinispan/infinispan.git","svn_url":"https://github.com/infinispan/infinispan","homepage":"http://www.infinispan.org","size":114024,"stargazers_count":689,"watchers_count":689,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":452,"mirror_url":null,"archived":false,"open_issues_count":21,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":452,"open_issues":21,"watchers":689,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/6380"},"html":{"href":"https://github.com/infinispan/infinispan/pull/6380"},"issue":{"href":"https://api.github.com/repos/infinispan/infinispan/issues/6380"},"comments":{"href":"https://api.github.com/repos/infinispan/infinispan/issues/6380/comments"},"review_comments":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/6380/comments"},"review_comment":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/6380/commits"},"statuses":{"href":"https://api.github.com/repos/infinispan/infinispan/statuses/0d344311b572cde316a7c42a7b03c7ff88e03366"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ryanemerson"}}