{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/bond/pulls/comments/165795969","pull_request_review_id":93797724,"id":165795969,"diff_hunk":"@@ -4,3 +4,13 @@ if (BOND_ENABLE_GRPC)\n     cxx_add_compile_options (Clang -Wno-unused-value)\n     add_subdirectory(grpc)\n endif()\n+\n+if (NOT BOND_SKIP_CORE_TESTS)","path":"thirdparty/CMakeLists.txt","position":5,"original_position":5,"commit_id":"2104745428867e7525793e7d2a11351101dceb0a","original_commit_id":"2104745428867e7525793e7d2a11351101dceb0a","user":{"login":"tstein","id":221157,"avatar_url":"https://avatars1.githubusercontent.com/u/221157?v=4","gravatar_id":"","url":"https://api.github.com/users/tstein","html_url":"https://github.com/tstein","followers_url":"https://api.github.com/users/tstein/followers","following_url":"https://api.github.com/users/tstein/following{/other_user}","gists_url":"https://api.github.com/users/tstein/gists{/gist_id}","starred_url":"https://api.github.com/users/tstein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tstein/subscriptions","organizations_url":"https://api.github.com/users/tstein/orgs","repos_url":"https://api.github.com/users/tstein/repos","events_url":"https://api.github.com/users/tstein/events{/privacy}","received_events_url":"https://api.github.com/users/tstein/received_events","type":"User","site_admin":false},"body":"Actually, I think it does. Nothing needed here.","created_at":"2018-02-03T00:53:38Z","updated_at":"2018-02-03T00:53:39Z","html_url":"https://github.com/Microsoft/bond/pull/788#discussion_r165795969","pull_request_url":"https://api.github.com/repos/Microsoft/bond/pulls/788","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/bond/pulls/comments/165795969"},"html":{"href":"https://github.com/Microsoft/bond/pull/788#discussion_r165795969"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/bond/pulls/788"}},"in_reply_to_id":165792158},"pull_request":{"url":"https://api.github.com/repos/Microsoft/bond/pulls/788","id":166874500,"html_url":"https://github.com/Microsoft/bond/pull/788","diff_url":"https://github.com/Microsoft/bond/pull/788.diff","patch_url":"https://github.com/Microsoft/bond/pull/788.patch","issue_url":"https://api.github.com/repos/Microsoft/bond/issues/788","number":788,"state":"open","locked":false,"title":"[c++] Protocol Buffers writer","user":{"login":"ara-ayvazyan","id":25734498,"avatar_url":"https://avatars1.githubusercontent.com/u/25734498?v=4","gravatar_id":"","url":"https://api.github.com/users/ara-ayvazyan","html_url":"https://github.com/ara-ayvazyan","followers_url":"https://api.github.com/users/ara-ayvazyan/followers","following_url":"https://api.github.com/users/ara-ayvazyan/following{/other_user}","gists_url":"https://api.github.com/users/ara-ayvazyan/gists{/gist_id}","starred_url":"https://api.github.com/users/ara-ayvazyan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ara-ayvazyan/subscriptions","organizations_url":"https://api.github.com/users/ara-ayvazyan/orgs","repos_url":"https://api.github.com/users/ara-ayvazyan/repos","events_url":"https://api.github.com/users/ara-ayvazyan/events{/privacy}","received_events_url":"https://api.github.com/users/ara-ayvazyan/received_events","type":"User","site_admin":false},"body":"TODO:\r\n* [ ] Update documentation","created_at":"2018-02-02T18:40:57Z","updated_at":"2018-02-03T00:53:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6f7f6db2de0e84757d1f6ea8f2adfb3b65eb6fe8","assignee":null,"assignees":[],"requested_reviewers":[{"login":"lalo","id":575454,"avatar_url":"https://avatars2.githubusercontent.com/u/575454?v=4","gravatar_id":"","url":"https://api.github.com/users/lalo","html_url":"https://github.com/lalo","followers_url":"https://api.github.com/users/lalo/followers","following_url":"https://api.github.com/users/lalo/following{/other_user}","gists_url":"https://api.github.com/users/lalo/gists{/gist_id}","starred_url":"https://api.github.com/users/lalo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lalo/subscriptions","organizations_url":"https://api.github.com/users/lalo/orgs","repos_url":"https://api.github.com/users/lalo/repos","events_url":"https://api.github.com/users/lalo/events{/privacy}","received_events_url":"https://api.github.com/users/lalo/received_events","type":"User","site_admin":false},{"login":"chwarr","id":10605667,"avatar_url":"https://avatars3.githubusercontent.com/u/10605667?v=4","gravatar_id":"","url":"https://api.github.com/users/chwarr","html_url":"https://github.com/chwarr","followers_url":"https://api.github.com/users/chwarr/followers","following_url":"https://api.github.com/users/chwarr/following{/other_user}","gists_url":"https://api.github.com/users/chwarr/gists{/gist_id}","starred_url":"https://api.github.com/users/chwarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chwarr/subscriptions","organizations_url":"https://api.github.com/users/chwarr/orgs","repos_url":"https://api.github.com/users/chwarr/repos","events_url":"https://api.github.com/users/chwarr/events{/privacy}","received_events_url":"https://api.github.com/users/chwarr/received_events","type":"User","site_admin":false}],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/bond/pulls/788/commits","review_comments_url":"https://api.github.com/repos/Microsoft/bond/pulls/788/comments","review_comment_url":"https://api.github.com/repos/Microsoft/bond/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/bond/issues/788/comments","statuses_url":"https://api.github.com/repos/Microsoft/bond/statuses/2104745428867e7525793e7d2a11351101dceb0a","head":{"label":"ara-ayvazyan:protobuf/proto-writer","ref":"protobuf/proto-writer","sha":"2104745428867e7525793e7d2a11351101dceb0a","user":{"login":"ara-ayvazyan","id":25734498,"avatar_url":"https://avatars1.githubusercontent.com/u/25734498?v=4","gravatar_id":"","url":"https://api.github.com/users/ara-ayvazyan","html_url":"https://github.com/ara-ayvazyan","followers_url":"https://api.github.com/users/ara-ayvazyan/followers","following_url":"https://api.github.com/users/ara-ayvazyan/following{/other_user}","gists_url":"https://api.github.com/users/ara-ayvazyan/gists{/gist_id}","starred_url":"https://api.github.com/users/ara-ayvazyan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ara-ayvazyan/subscriptions","organizations_url":"https://api.github.com/users/ara-ayvazyan/orgs","repos_url":"https://api.github.com/users/ara-ayvazyan/repos","events_url":"https://api.github.com/users/ara-ayvazyan/events{/privacy}","received_events_url":"https://api.github.com/users/ara-ayvazyan/received_events","type":"User","site_admin":false},"repo":{"id":87358176,"name":"bond","full_name":"ara-ayvazyan/bond","owner":{"login":"ara-ayvazyan","id":25734498,"avatar_url":"https://avatars1.githubusercontent.com/u/25734498?v=4","gravatar_id":"","url":"https://api.github.com/users/ara-ayvazyan","html_url":"https://github.com/ara-ayvazyan","followers_url":"https://api.github.com/users/ara-ayvazyan/followers","following_url":"https://api.github.com/users/ara-ayvazyan/following{/other_user}","gists_url":"https://api.github.com/users/ara-ayvazyan/gists{/gist_id}","starred_url":"https://api.github.com/users/ara-ayvazyan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ara-ayvazyan/subscriptions","organizations_url":"https://api.github.com/users/ara-ayvazyan/orgs","repos_url":"https://api.github.com/users/ara-ayvazyan/repos","events_url":"https://api.github.com/users/ara-ayvazyan/events{/privacy}","received_events_url":"https://api.github.com/users/ara-ayvazyan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ara-ayvazyan/bond","description":"Bond is a cross-platform framework for working with schematized data. It supports cross-language de/serialization and powerful generic mechanisms for efficiently manipulating data. Bond is broadly used at Microsoft in high scale services. ","fork":true,"url":"https://api.github.com/repos/ara-ayvazyan/bond","forks_url":"https://api.github.com/repos/ara-ayvazyan/bond/forks","keys_url":"https://api.github.com/repos/ara-ayvazyan/bond/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ara-ayvazyan/bond/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ara-ayvazyan/bond/teams","hooks_url":"https://api.github.com/repos/ara-ayvazyan/bond/hooks","issue_events_url":"https://api.github.com/repos/ara-ayvazyan/bond/issues/events{/number}","events_url":"https://api.github.com/repos/ara-ayvazyan/bond/events","assignees_url":"https://api.github.com/repos/ara-ayvazyan/bond/assignees{/user}","branches_url":"https://api.github.com/repos/ara-ayvazyan/bond/branches{/branch}","tags_url":"https://api.github.com/repos/ara-ayvazyan/bond/tags","blobs_url":"https://api.github.com/repos/ara-ayvazyan/bond/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ara-ayvazyan/bond/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ara-ayvazyan/bond/git/refs{/sha}","trees_url":"https://api.github.com/repos/ara-ayvazyan/bond/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ara-ayvazyan/bond/statuses/{sha}","languages_url":"https://api.github.com/repos/ara-ayvazyan/bond/languages","stargazers_url":"https://api.github.com/repos/ara-ayvazyan/bond/stargazers","contributors_url":"https://api.github.com/repos/ara-ayvazyan/bond/contributors","subscribers_url":"https://api.github.com/repos/ara-ayvazyan/bond/subscribers","subscription_url":"https://api.github.com/repos/ara-ayvazyan/bond/subscription","commits_url":"https://api.github.com/repos/ara-ayvazyan/bond/commits{/sha}","git_commits_url":"https://api.github.com/repos/ara-ayvazyan/bond/git/commits{/sha}","comments_url":"https://api.github.com/repos/ara-ayvazyan/bond/comments{/number}","issue_comment_url":"https://api.github.com/repos/ara-ayvazyan/bond/issues/comments{/number}","contents_url":"https://api.github.com/repos/ara-ayvazyan/bond/contents/{+path}","compare_url":"https://api.github.com/repos/ara-ayvazyan/bond/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ara-ayvazyan/bond/merges","archive_url":"https://api.github.com/repos/ara-ayvazyan/bond/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ara-ayvazyan/bond/downloads","issues_url":"https://api.github.com/repos/ara-ayvazyan/bond/issues{/number}","pulls_url":"https://api.github.com/repos/ara-ayvazyan/bond/pulls{/number}","milestones_url":"https://api.github.com/repos/ara-ayvazyan/bond/milestones{/number}","notifications_url":"https://api.github.com/repos/ara-ayvazyan/bond/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ara-ayvazyan/bond/labels{/name}","releases_url":"https://api.github.com/repos/ara-ayvazyan/bond/releases{/id}","deployments_url":"https://api.github.com/repos/ara-ayvazyan/bond/deployments","created_at":"2017-04-05T21:28:06Z","updated_at":"2017-04-05T21:28:10Z","pushed_at":"2018-02-02T23:21:53Z","git_url":"git://github.com/ara-ayvazyan/bond.git","ssh_url":"git@github.com:ara-ayvazyan/bond.git","clone_url":"https://github.com/ara-ayvazyan/bond.git","svn_url":"https://github.com/ara-ayvazyan/bond","homepage":null,"size":9496,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"95747ded0b4422a611070c7ff322909921bc25de","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":28014525,"name":"bond","full_name":"Microsoft/bond","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/bond","description":"Bond is a cross-platform framework for working with schematized data. It supports cross-language de/serialization and powerful generic mechanisms for efficiently manipulating data. Bond is broadly used at Microsoft in high scale services. ","fork":false,"url":"https://api.github.com/repos/Microsoft/bond","forks_url":"https://api.github.com/repos/Microsoft/bond/forks","keys_url":"https://api.github.com/repos/Microsoft/bond/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/bond/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/bond/teams","hooks_url":"https://api.github.com/repos/Microsoft/bond/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/bond/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/bond/events","assignees_url":"https://api.github.com/repos/Microsoft/bond/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/bond/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/bond/tags","blobs_url":"https://api.github.com/repos/Microsoft/bond/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/bond/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/bond/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/bond/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/bond/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/bond/languages","stargazers_url":"https://api.github.com/repos/Microsoft/bond/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/bond/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/bond/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/bond/subscription","commits_url":"https://api.github.com/repos/Microsoft/bond/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/bond/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/bond/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/bond/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/bond/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/bond/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/bond/merges","archive_url":"https://api.github.com/repos/Microsoft/bond/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/bond/downloads","issues_url":"https://api.github.com/repos/Microsoft/bond/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/bond/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/bond/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/bond/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/bond/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/bond/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/bond/deployments","created_at":"2014-12-15T01:05:31Z","updated_at":"2018-02-03T00:16:32Z","pushed_at":"2018-02-02T23:21:54Z","git_url":"git://github.com/Microsoft/bond.git","ssh_url":"git@github.com:Microsoft/bond.git","clone_url":"https://github.com/Microsoft/bond.git","svn_url":"https://github.com/Microsoft/bond","homepage":null,"size":12344,"stargazers_count":1686,"watchers_count":1686,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":233,"mirror_url":null,"archived":false,"open_issues_count":122,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":233,"open_issues":122,"watchers":1686,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/bond/pulls/788"},"html":{"href":"https://github.com/Microsoft/bond/pull/788"},"issue":{"href":"https://api.github.com/repos/Microsoft/bond/issues/788"},"comments":{"href":"https://api.github.com/repos/Microsoft/bond/issues/788/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/bond/pulls/788/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/bond/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/bond/pulls/788/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/bond/statuses/2104745428867e7525793e7d2a11351101dceb0a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"tstein"}}