{"action":"created","comment":{"url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/pulls/comments/170969959","pull_request_review_id":99740080,"id":170969959,"diff_hunk":"@@ -284,6 +284,27 @@ private static bool IsAscii(char c)\n             return c <= sbyte.MaxValue;\n         }\n \n+        internal /* for testing purposes */ string JoinAsSonarQubeMultiValueProperty(IEnumerable<string> paths)\n+        {\n+            if (Version.TryParse(this.config.SonarQubeVersion, out var sonarqubeVersion) &&\n+                sonarqubeVersion.CompareTo(new Version(6, 5)) >= 0)\n+            {\n+                return string.Join(MultiValuesPropertySeparator, paths.Select(path => $\"\\\"{path.Replace(\"\\\"\", \"\\\"\\\"\")}\\\"\"));\n+            }\n+            else\n+            {\n+                Func<string, bool> invalidPathPredicate = path => path.Contains(\",\");\n+                var invalidPaths = paths.Where(invalidPathPredicate);\n+                if (invalidPaths.Any())\n+                {\n+                    this.logger.LogWarning(Resources.WARN_InvalidCharacterInPaths, string.Join(\", \", invalidPaths));\n+                    return string.Join(MultiValuesPropertySeparator, paths.Where(path => !invalidPathPredicate(path)));","path":"src/SonarScanner.Shim/PropertiesWriter.cs","position":103,"original_position":103,"commit_id":"f03f392991ed4a7417980fb4e7499a8ec17d191b","original_commit_id":"f03f392991ed4a7417980fb4e7499a8ec17d191b","user":{"login":"Evangelink","id":11340282,"avatar_url":"https://avatars0.githubusercontent.com/u/11340282?v=4","gravatar_id":"","url":"https://api.github.com/users/Evangelink","html_url":"https://github.com/Evangelink","followers_url":"https://api.github.com/users/Evangelink/followers","following_url":"https://api.github.com/users/Evangelink/following{/other_user}","gists_url":"https://api.github.com/users/Evangelink/gists{/gist_id}","starred_url":"https://api.github.com/users/Evangelink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Evangelink/subscriptions","organizations_url":"https://api.github.com/users/Evangelink/orgs","repos_url":"https://api.github.com/users/Evangelink/repos","events_url":"https://api.github.com/users/Evangelink/events{/privacy}","received_events_url":"https://api.github.com/users/Evangelink/received_events","type":"User","site_admin":false},"body":"I wanted to avoid the `Where()` clause but I guess it doesn't cost much.","created_at":"2018-02-27T15:55:16Z","updated_at":"2018-02-27T15:55:17Z","html_url":"https://github.com/SonarSource/sonar-scanner-msbuild/pull/398#discussion_r170969959","pull_request_url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/pulls/398","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/pulls/comments/170969959"},"html":{"href":"https://github.com/SonarSource/sonar-scanner-msbuild/pull/398#discussion_r170969959"},"pull_request":{"href":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/pulls/398"}},"in_reply_to_id":170965101},"pull_request":{"url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/pulls/398","id":171670948,"html_url":"https://github.com/SonarSource/sonar-scanner-msbuild/pull/398","diff_url":"https://github.com/SonarSource/sonar-scanner-msbuild/pull/398.diff","patch_url":"https://github.com/SonarSource/sonar-scanner-msbuild/pull/398.patch","issue_url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/issues/398","number":398,"state":"open","locked":false,"title":"SONARMSBRU-199: Analysis should not fail for valid Windows file/folde…","user":{"login":"Evangelink","id":11340282,"avatar_url":"https://avatars0.githubusercontent.com/u/11340282?v=4","gravatar_id":"","url":"https://api.github.com/users/Evangelink","html_url":"https://github.com/Evangelink","followers_url":"https://api.github.com/users/Evangelink/followers","following_url":"https://api.github.com/users/Evangelink/following{/other_user}","gists_url":"https://api.github.com/users/Evangelink/gists{/gist_id}","starred_url":"https://api.github.com/users/Evangelink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Evangelink/subscriptions","organizations_url":"https://api.github.com/users/Evangelink/orgs","repos_url":"https://api.github.com/users/Evangelink/repos","events_url":"https://api.github.com/users/Evangelink/events{/privacy}","received_events_url":"https://api.github.com/users/Evangelink/received_events","type":"User","site_admin":false},"body":"…r names, e.g. containing commas\r\n\r\nFix [SONARMSBRU-199](https://jira.sonarsource.com/browse/SONARMSBRU-199)","created_at":"2018-02-27T14:02:57Z","updated_at":"2018-02-27T15:55:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a56f5f0c8a7505342f04dbd135475f9d906b2c80","assignee":{"login":"Evangelink","id":11340282,"avatar_url":"https://avatars0.githubusercontent.com/u/11340282?v=4","gravatar_id":"","url":"https://api.github.com/users/Evangelink","html_url":"https://github.com/Evangelink","followers_url":"https://api.github.com/users/Evangelink/followers","following_url":"https://api.github.com/users/Evangelink/following{/other_user}","gists_url":"https://api.github.com/users/Evangelink/gists{/gist_id}","starred_url":"https://api.github.com/users/Evangelink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Evangelink/subscriptions","organizations_url":"https://api.github.com/users/Evangelink/orgs","repos_url":"https://api.github.com/users/Evangelink/repos","events_url":"https://api.github.com/users/Evangelink/events{/privacy}","received_events_url":"https://api.github.com/users/Evangelink/received_events","type":"User","site_admin":false},"assignees":[{"login":"Evangelink","id":11340282,"avatar_url":"https://avatars0.githubusercontent.com/u/11340282?v=4","gravatar_id":"","url":"https://api.github.com/users/Evangelink","html_url":"https://github.com/Evangelink","followers_url":"https://api.github.com/users/Evangelink/followers","following_url":"https://api.github.com/users/Evangelink/following{/other_user}","gists_url":"https://api.github.com/users/Evangelink/gists{/gist_id}","starred_url":"https://api.github.com/users/Evangelink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Evangelink/subscriptions","organizations_url":"https://api.github.com/users/Evangelink/orgs","repos_url":"https://api.github.com/users/Evangelink/repos","events_url":"https://api.github.com/users/Evangelink/events{/privacy}","received_events_url":"https://api.github.com/users/Evangelink/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"michalb-sonar","id":28255392,"avatar_url":"https://avatars1.githubusercontent.com/u/28255392?v=4","gravatar_id":"","url":"https://api.github.com/users/michalb-sonar","html_url":"https://github.com/michalb-sonar","followers_url":"https://api.github.com/users/michalb-sonar/followers","following_url":"https://api.github.com/users/michalb-sonar/following{/other_user}","gists_url":"https://api.github.com/users/michalb-sonar/gists{/gist_id}","starred_url":"https://api.github.com/users/michalb-sonar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michalb-sonar/subscriptions","organizations_url":"https://api.github.com/users/michalb-sonar/orgs","repos_url":"https://api.github.com/users/michalb-sonar/repos","events_url":"https://api.github.com/users/michalb-sonar/events{/privacy}","received_events_url":"https://api.github.com/users/michalb-sonar/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":844836656,"url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/labels/Status:%20Needs%20Review","name":"Status: Needs Review","color":"b60205","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/pulls/398/commits","review_comments_url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/pulls/398/comments","review_comment_url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/issues/398/comments","statuses_url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/statuses/f03f392991ed4a7417980fb4e7499a8ec17d191b","head":{"label":"SonarSource:ammo/comma","ref":"ammo/comma","sha":"f03f392991ed4a7417980fb4e7499a8ec17d191b","user":{"login":"SonarSource","id":545988,"avatar_url":"https://avatars0.githubusercontent.com/u/545988?v=4","gravatar_id":"","url":"https://api.github.com/users/SonarSource","html_url":"https://github.com/SonarSource","followers_url":"https://api.github.com/users/SonarSource/followers","following_url":"https://api.github.com/users/SonarSource/following{/other_user}","gists_url":"https://api.github.com/users/SonarSource/gists{/gist_id}","starred_url":"https://api.github.com/users/SonarSource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SonarSource/subscriptions","organizations_url":"https://api.github.com/users/SonarSource/orgs","repos_url":"https://api.github.com/users/SonarSource/repos","events_url":"https://api.github.com/users/SonarSource/events{/privacy}","received_events_url":"https://api.github.com/users/SonarSource/received_events","type":"Organization","site_admin":false},"repo":{"id":34444711,"name":"sonar-scanner-msbuild","full_name":"SonarSource/sonar-scanner-msbuild","owner":{"login":"SonarSource","id":545988,"avatar_url":"https://avatars0.githubusercontent.com/u/545988?v=4","gravatar_id":"","url":"https://api.github.com/users/SonarSource","html_url":"https://github.com/SonarSource","followers_url":"https://api.github.com/users/SonarSource/followers","following_url":"https://api.github.com/users/SonarSource/following{/other_user}","gists_url":"https://api.github.com/users/SonarSource/gists{/gist_id}","starred_url":"https://api.github.com/users/SonarSource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SonarSource/subscriptions","organizations_url":"https://api.github.com/users/SonarSource/orgs","repos_url":"https://api.github.com/users/SonarSource/repos","events_url":"https://api.github.com/users/SonarSource/events{/privacy}","received_events_url":"https://api.github.com/users/SonarSource/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SonarSource/sonar-scanner-msbuild","description":"SonarQube Scanner for MSBuild","fork":false,"url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild","forks_url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/forks","keys_url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/teams","hooks_url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/hooks","issue_events_url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/issues/events{/number}","events_url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/events","assignees_url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/assignees{/user}","branches_url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/branches{/branch}","tags_url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/tags","blobs_url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/git/refs{/sha}","trees_url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/statuses/{sha}","languages_url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/languages","stargazers_url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/stargazers","contributors_url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/contributors","subscribers_url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/subscribers","subscription_url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/subscription","commits_url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/commits{/sha}","git_commits_url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/git/commits{/sha}","comments_url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/comments{/number}","issue_comment_url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/issues/comments{/number}","contents_url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/contents/{+path}","compare_url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/merges","archive_url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/downloads","issues_url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/issues{/number}","pulls_url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/pulls{/number}","milestones_url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/milestones{/number}","notifications_url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/labels{/name}","releases_url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/releases{/id}","deployments_url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/deployments","created_at":"2015-04-23T08:45:40Z","updated_at":"2018-02-27T03:14:48Z","pushed_at":"2018-02-27T15:49:30Z","git_url":"git://github.com/SonarSource/sonar-scanner-msbuild.git","ssh_url":"git@github.com:SonarSource/sonar-scanner-msbuild.git","clone_url":"https://github.com/SonarSource/sonar-scanner-msbuild.git","svn_url":"https://github.com/SonarSource/sonar-scanner-msbuild","homepage":"http://redirect.sonarsource.com/doc/msbuild-sq-runner.html","size":8094,"stargazers_count":91,"watchers_count":91,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":67,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0"},"forks":67,"open_issues":4,"watchers":91,"default_branch":"master"}},"base":{"label":"SonarSource:master","ref":"master","sha":"2ecbb6ff46583bb996c8c6f6343814faabbb92e6","user":{"login":"SonarSource","id":545988,"avatar_url":"https://avatars0.githubusercontent.com/u/545988?v=4","gravatar_id":"","url":"https://api.github.com/users/SonarSource","html_url":"https://github.com/SonarSource","followers_url":"https://api.github.com/users/SonarSource/followers","following_url":"https://api.github.com/users/SonarSource/following{/other_user}","gists_url":"https://api.github.com/users/SonarSource/gists{/gist_id}","starred_url":"https://api.github.com/users/SonarSource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SonarSource/subscriptions","organizations_url":"https://api.github.com/users/SonarSource/orgs","repos_url":"https://api.github.com/users/SonarSource/repos","events_url":"https://api.github.com/users/SonarSource/events{/privacy}","received_events_url":"https://api.github.com/users/SonarSource/received_events","type":"Organization","site_admin":false},"repo":{"id":34444711,"name":"sonar-scanner-msbuild","full_name":"SonarSource/sonar-scanner-msbuild","owner":{"login":"SonarSource","id":545988,"avatar_url":"https://avatars0.githubusercontent.com/u/545988?v=4","gravatar_id":"","url":"https://api.github.com/users/SonarSource","html_url":"https://github.com/SonarSource","followers_url":"https://api.github.com/users/SonarSource/followers","following_url":"https://api.github.com/users/SonarSource/following{/other_user}","gists_url":"https://api.github.com/users/SonarSource/gists{/gist_id}","starred_url":"https://api.github.com/users/SonarSource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SonarSource/subscriptions","organizations_url":"https://api.github.com/users/SonarSource/orgs","repos_url":"https://api.github.com/users/SonarSource/repos","events_url":"https://api.github.com/users/SonarSource/events{/privacy}","received_events_url":"https://api.github.com/users/SonarSource/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SonarSource/sonar-scanner-msbuild","description":"SonarQube Scanner for MSBuild","fork":false,"url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild","forks_url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/forks","keys_url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/teams","hooks_url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/hooks","issue_events_url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/issues/events{/number}","events_url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/events","assignees_url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/assignees{/user}","branches_url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/branches{/branch}","tags_url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/tags","blobs_url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/git/refs{/sha}","trees_url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/statuses/{sha}","languages_url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/languages","stargazers_url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/stargazers","contributors_url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/contributors","subscribers_url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/subscribers","subscription_url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/subscription","commits_url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/commits{/sha}","git_commits_url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/git/commits{/sha}","comments_url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/comments{/number}","issue_comment_url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/issues/comments{/number}","contents_url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/contents/{+path}","compare_url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/merges","archive_url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/downloads","issues_url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/issues{/number}","pulls_url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/pulls{/number}","milestones_url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/milestones{/number}","notifications_url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/labels{/name}","releases_url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/releases{/id}","deployments_url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/deployments","created_at":"2015-04-23T08:45:40Z","updated_at":"2018-02-27T03:14:48Z","pushed_at":"2018-02-27T15:49:30Z","git_url":"git://github.com/SonarSource/sonar-scanner-msbuild.git","ssh_url":"git@github.com:SonarSource/sonar-scanner-msbuild.git","clone_url":"https://github.com/SonarSource/sonar-scanner-msbuild.git","svn_url":"https://github.com/SonarSource/sonar-scanner-msbuild","homepage":"http://redirect.sonarsource.com/doc/msbuild-sq-runner.html","size":8094,"stargazers_count":91,"watchers_count":91,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":67,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0"},"forks":67,"open_issues":4,"watchers":91,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/pulls/398"},"html":{"href":"https://github.com/SonarSource/sonar-scanner-msbuild/pull/398"},"issue":{"href":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/issues/398"},"comments":{"href":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/issues/398/comments"},"review_comments":{"href":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/pulls/398/comments"},"review_comment":{"href":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/pulls/398/commits"},"statuses":{"href":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/statuses/f03f392991ed4a7417980fb4e7499a8ec17d191b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Evangelink"}}