{"action":"created","issue":{"url":"https://api.github.com/repos/rabbitmq/rabbitmq-dotnet-client/issues/393","repository_url":"https://api.github.com/repos/rabbitmq/rabbitmq-dotnet-client","labels_url":"https://api.github.com/repos/rabbitmq/rabbitmq-dotnet-client/issues/393/labels{/name}","comments_url":"https://api.github.com/repos/rabbitmq/rabbitmq-dotnet-client/issues/393/comments","events_url":"https://api.github.com/repos/rabbitmq/rabbitmq-dotnet-client/issues/393/events","html_url":"https://github.com/rabbitmq/rabbitmq-dotnet-client/pull/393","id":296932007,"number":393,"title":"avoid string concatenation","user":{"login":"paulomorgado","id":470455,"avatar_url":"https://avatars0.githubusercontent.com/u/470455?v=4","gravatar_id":"","url":"https://api.github.com/users/paulomorgado","html_url":"https://github.com/paulomorgado","followers_url":"https://api.github.com/users/paulomorgado/followers","following_url":"https://api.github.com/users/paulomorgado/following{/other_user}","gists_url":"https://api.github.com/users/paulomorgado/gists{/gist_id}","starred_url":"https://api.github.com/users/paulomorgado/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulomorgado/subscriptions","organizations_url":"https://api.github.com/users/paulomorgado/orgs","repos_url":"https://api.github.com/users/paulomorgado/repos","events_url":"https://api.github.com/users/paulomorgado/events{/privacy}","received_events_url":"https://api.github.com/users/paulomorgado/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-02-14T00:10:01Z","updated_at":"2018-02-14T00:12:31Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/rabbitmq/rabbitmq-dotnet-client/pulls/393","html_url":"https://github.com/rabbitmq/rabbitmq-dotnet-client/pull/393","diff_url":"https://github.com/rabbitmq/rabbitmq-dotnet-client/pull/393.diff","patch_url":"https://github.com/rabbitmq/rabbitmq-dotnet-client/pull/393.patch"},"body":"## Proposed Changes\r\n\r\nString concatenations are bad because they incur in memory allocations.\r\n\r\nUsing `string.Format` (directly or through string interpolation) uses cached `StringBuilder`s thus avoiding allocations. \r\n\r\n## Types of Changes\r\n\r\n- [ ] Bugfix (non-breaking change which fixes issue #NNNN)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)\r\n- [ ] Documentation (correction or otherwise)\r\n- [ ] Cosmetics (whitespace, appearance)\r\n\r\n## Checklist\r\n\r\n- [x] I have read the `CONTRIBUTING.md` document\r\n- [x] I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)\r\n- [ ] All tests pass locally with my changes\r\n- [ ] I have added tests that prove my fix is effective or that my feature works\r\n- [ ] I have added necessary documentation (if appropriate)\r\n- [ ] Any dependent changes have been merged and published in related repositories\r\n\r\n## Further Comments\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/rabbitmq/rabbitmq-dotnet-client/issues/comments/365450267","html_url":"https://github.com/rabbitmq/rabbitmq-dotnet-client/pull/393#issuecomment-365450267","issue_url":"https://api.github.com/repos/rabbitmq/rabbitmq-dotnet-client/issues/393","id":365450267,"user":{"login":"michaelklishin","id":1090,"avatar_url":"https://avatars3.githubusercontent.com/u/1090?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelklishin","html_url":"https://github.com/michaelklishin","followers_url":"https://api.github.com/users/michaelklishin/followers","following_url":"https://api.github.com/users/michaelklishin/following{/other_user}","gists_url":"https://api.github.com/users/michaelklishin/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelklishin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelklishin/subscriptions","organizations_url":"https://api.github.com/users/michaelklishin/orgs","repos_url":"https://api.github.com/users/michaelklishin/repos","events_url":"https://api.github.com/users/michaelklishin/events{/privacy}","received_events_url":"https://api.github.com/users/michaelklishin/received_events","type":"User","site_admin":false},"created_at":"2018-02-14T00:12:31Z","updated_at":"2018-02-14T00:12:31Z","author_association":"OWNER","body":"Thank you. All the changes seem to be off the hot code path, however, so I'd not expect any significant gains from this."}}
{"actor":{"display_login":"michaelklishin"}}