{"action":"created","issue":{"url":"https://api.github.com/repos/Opentrons/opentrons/issues/947","repository_url":"https://api.github.com/repos/Opentrons/opentrons","labels_url":"https://api.github.com/repos/Opentrons/opentrons/issues/947/labels{/name}","comments_url":"https://api.github.com/repos/Opentrons/opentrons/issues/947/comments","events_url":"https://api.github.com/repos/Opentrons/opentrons/issues/947/events","html_url":"https://github.com/Opentrons/opentrons/pull/947","id":301863077,"number":947,"title":"Add Run NavButton in NavBar","user":{"login":"Kadee80","id":3430313,"avatar_url":"https://avatars1.githubusercontent.com/u/3430313?v=4","gravatar_id":"","url":"https://api.github.com/users/Kadee80","html_url":"https://github.com/Kadee80","followers_url":"https://api.github.com/users/Kadee80/followers","following_url":"https://api.github.com/users/Kadee80/following{/other_user}","gists_url":"https://api.github.com/users/Kadee80/gists{/gist_id}","starred_url":"https://api.github.com/users/Kadee80/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kadee80/subscriptions","organizations_url":"https://api.github.com/users/Kadee80/orgs","repos_url":"https://api.github.com/users/Kadee80/repos","events_url":"https://api.github.com/users/Kadee80/events{/privacy}","received_events_url":"https://api.github.com/users/Kadee80/received_events","type":"User","site_admin":false},"labels":[{"id":749345056,"url":"https://api.github.com/repos/Opentrons/opentrons/labels/WIP","name":"WIP","color":"bc0903","default":false},{"id":712462287,"url":"https://api.github.com/repos/Opentrons/opentrons/labels/app","name":"app","color":"c5def5","default":false},{"id":772967030,"url":"https://api.github.com/repos/Opentrons/opentrons/labels/components","name":"components","color":"0052cc","default":false},{"id":233075101,"url":"https://api.github.com/repos/Opentrons/opentrons/labels/feature","name":"feature","color":"84b6eb","default":false},{"id":799628494,"url":"https://api.github.com/repos/Opentrons/opentrons/labels/medium","name":"medium","color":"d8d215","default":false}],"state":"open","locked":false,"assignee":{"login":"Kadee80","id":3430313,"avatar_url":"https://avatars1.githubusercontent.com/u/3430313?v=4","gravatar_id":"","url":"https://api.github.com/users/Kadee80","html_url":"https://github.com/Kadee80","followers_url":"https://api.github.com/users/Kadee80/followers","following_url":"https://api.github.com/users/Kadee80/following{/other_user}","gists_url":"https://api.github.com/users/Kadee80/gists{/gist_id}","starred_url":"https://api.github.com/users/Kadee80/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kadee80/subscriptions","organizations_url":"https://api.github.com/users/Kadee80/orgs","repos_url":"https://api.github.com/users/Kadee80/repos","events_url":"https://api.github.com/users/Kadee80/events{/privacy}","received_events_url":"https://api.github.com/users/Kadee80/received_events","type":"User","site_admin":false},"assignees":[{"login":"Kadee80","id":3430313,"avatar_url":"https://avatars1.githubusercontent.com/u/3430313?v=4","gravatar_id":"","url":"https://api.github.com/users/Kadee80","html_url":"https://github.com/Kadee80","followers_url":"https://api.github.com/users/Kadee80/followers","following_url":"https://api.github.com/users/Kadee80/following{/other_user}","gists_url":"https://api.github.com/users/Kadee80/gists{/gist_id}","starred_url":"https://api.github.com/users/Kadee80/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kadee80/subscriptions","organizations_url":"https://api.github.com/users/Kadee80/orgs","repos_url":"https://api.github.com/users/Kadee80/repos","events_url":"https://api.github.com/users/Kadee80/events{/privacy}","received_events_url":"https://api.github.com/users/Kadee80/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-03-02T18:34:57Z","updated_at":"2018-03-02T19:27:42Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/Opentrons/opentrons/pulls/947","html_url":"https://github.com/Opentrons/opentrons/pull/947","diff_url":"https://github.com/Opentrons/opentrons/pull/947.diff","patch_url":"https://github.com/Opentrons/opentrons/pull/947.patch"},"body":"## overview\r\n\r\nThis PR adds a RUN NavButton to the `NavBar` which is disabled until tips are probed. Clicking the run `NavButton` renders a new `RunPanel` and a Run Page that has the protocol name in the title bar along with the command list. I ported over the run|pause|resume|cancel button logic along with the timer from the old `RunControls` component to the RunPanel.\r\n\r\nRemoved the run button and message from the `SetupPanel`, I believe an 'all labware calibrated, continue to run screen prompt' screens are coming soon.\r\n\r\n## changelog\r\n\r\n- Update NavButton to take optional url prop (renders as navlink if present)\r\n- Update SidePanelGroup (make Title optional)\r\n- Add Run Panel, remove runControls from Run Page\r\n- Clicking Calibration NavButton defaults to either next pipette or next labware\r\n- Known bugs to be fixed in router PR\r\n  - currentlabware/instrument item aka active link is not highlighted\r\n  - removing run button and message in calibration panel makes it slightly less clear that you are now able to run your protocol. I believe an all labware calibrated screen with prompt to go to run screen is in the works.\r\n\r\n## review requests\r\ncalling this a WIP for now. \r\nI wound up touching more files than anticipated and would like y'alls input on the temp screens to render when navbar buttons are clicked.\r\nAlso, try and break it. There are a lot of conditions to consider and i want to make sure i got them all."},"comment":{"url":"https://api.github.com/repos/Opentrons/opentrons/issues/comments/370026966","html_url":"https://github.com/Opentrons/opentrons/pull/947#issuecomment-370026966","issue_url":"https://api.github.com/repos/Opentrons/opentrons/issues/947","id":370026966,"user":{"login":"codecov[bot]","id":22429695,"avatar_url":"https://avatars2.githubusercontent.com/in/254?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov%5Bbot%5D","html_url":"https://github.com/apps/codecov","followers_url":"https://api.github.com/users/codecov%5Bbot%5D/followers","following_url":"https://api.github.com/users/codecov%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/codecov%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/codecov%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/codecov%5Bbot%5D/repos","events_url":"https://api.github.com/users/codecov%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/codecov%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-03-02T19:27:42Z","updated_at":"2018-03-02T19:27:42Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/Opentrons/opentrons/pull/947?src=pr&el=h1) Report\n> Merging [#947](https://codecov.io/gh/Opentrons/opentrons/pull/947?src=pr&el=desc) into [edge](https://codecov.io/gh/Opentrons/opentrons/commit/7c386d5a36f47332d51a03911bfbb6a128ce6812?src=pr&el=desc) will **increase** coverage by `0.1%`.\n> The diff coverage is `14.54%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/Opentrons/opentrons/pull/947/graphs/tree.svg?width=650&height=150&token=DIJPWI1JiU&src=pr)](https://codecov.io/gh/Opentrons/opentrons/pull/947?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff            @@\n##             edge     #947     +/-   ##\n=========================================\n+ Coverage   69.58%   69.68%   +0.1%     \n=========================================\n  Files         232      231      -1     \n  Lines        7170     7165      -5     \n  Branches      287      291      +4     \n=========================================\n+ Hits         4989     4993      +4     \n+ Misses       2098     2089      -9     \n  Partials       83       83\n```\n\n\n| [Impacted Files](https://codecov.io/gh/Opentrons/opentrons/pull/947?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [app/src/components/setup-panel/index.js](https://codecov.io/gh/Opentrons/opentrons/pull/947/diff?src=pr&el=tree#diff-YXBwL3NyYy9jb21wb25lbnRzL3NldHVwLXBhbmVsL2luZGV4Lmpz) | `0% <ø> (ø)` | :arrow_up: |\n| [app/src/pages/Run.js](https://codecov.io/gh/Opentrons/opentrons/pull/947/diff?src=pr&el=tree#diff-YXBwL3NyYy9wYWdlcy9SdW4uanM=) | `0% <ø> (ø)` | :arrow_up: |\n| [app/src/components/run-panel/index.js](https://codecov.io/gh/Opentrons/opentrons/pull/947/diff?src=pr&el=tree#diff-YXBwL3NyYy9jb21wb25lbnRzL3J1bi1wYW5lbC9pbmRleC5qcw==) | `0% <0%> (ø)` | |\n| [app/src/components/run-panel/RunControls.js](https://codecov.io/gh/Opentrons/opentrons/pull/947/diff?src=pr&el=tree#diff-YXBwL3NyYy9jb21wb25lbnRzL3J1bi1wYW5lbC9SdW5Db250cm9scy5qcw==) | `0% <0%> (ø)` | |\n| [app/src/components/side-panel/index.js](https://codecov.io/gh/Opentrons/opentrons/pull/947/diff?src=pr&el=tree#diff-YXBwL3NyYy9jb21wb25lbnRzL3NpZGUtcGFuZWwvaW5kZXguanM=) | `0% <0%> (ø)` | :arrow_up: |\n| [app/src/components/nav-bar/NavButton.js](https://codecov.io/gh/Opentrons/opentrons/pull/947/diff?src=pr&el=tree#diff-YXBwL3NyYy9jb21wb25lbnRzL25hdi1iYXIvTmF2QnV0dG9uLmpz) | `0% <0%> (ø)` | :arrow_up: |\n| [app/src/components/run-panel/RunTimer.js](https://codecov.io/gh/Opentrons/opentrons/pull/947/diff?src=pr&el=tree#diff-YXBwL3NyYy9jb21wb25lbnRzL3J1bi1wYW5lbC9SdW5UaW1lci5qcw==) | `0% <0%> (ø)` | |\n| [components/src/lists/SidePanelGroup.js](https://codecov.io/gh/Opentrons/opentrons/pull/947/diff?src=pr&el=tree#diff-Y29tcG9uZW50cy9zcmMvbGlzdHMvU2lkZVBhbmVsR3JvdXAuanM=) | `100% <100%> (ø)` | :arrow_up: |\n| [app/src/interface/index.js](https://codecov.io/gh/Opentrons/opentrons/pull/947/diff?src=pr&el=tree#diff-YXBwL3NyYy9pbnRlcmZhY2UvaW5kZXguanM=) | `100% <100%> (ø)` | :arrow_up: |\n| [app/src/robot/selectors.js](https://codecov.io/gh/Opentrons/opentrons/pull/947/diff?src=pr&el=tree#diff-YXBwL3NyYy9yb2JvdC9zZWxlY3RvcnMuanM=) | `82.85% <33.33%> (-1.09%)` | :arrow_down: |\n| ... and [4 more](https://codecov.io/gh/Opentrons/opentrons/pull/947/diff?src=pr&el=tree-more) | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/Opentrons/opentrons/pull/947?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/Opentrons/opentrons/pull/947?src=pr&el=footer). Last update [7c386d5...02e43bf](https://codecov.io/gh/Opentrons/opentrons/pull/947?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov"}}