{"action":"created","comment":{"url":"https://api.github.com/repos/oshi/oshi/pulls/comments/222411467","pull_request_review_id":161292187,"id":222411467,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMjQxMTQ2Nw==","diff_hunk":"@@ -66,6 +66,7 @@ public static boolean updateDiskStats(HWDiskStore diskStore) {\n             // In KB\n             diskStore.setReadBytes((long) (ParseUtil.parseDoubleOrDefault(split[3], 0d) * 1024));\n             diskStore.setWriteBytes((long) (ParseUtil.parseDoubleOrDefault(split[4], 0d) * 1024));\n+            diskStore.setQueueLength((long) (ParseUtil.parseDoubleOrDefault(split[5], 0d)));","path":"oshi-core/src/main/java/oshi/hardware/platform/unix/freebsd/FreeBsdDisks.java","position":4,"original_position":4,"commit_id":"f85725493b2cd07ff9aab481a349850a54968e30","original_commit_id":"f85725493b2cd07ff9aab481a349850a54968e30","user":{"login":"Space2Man","id":10084695,"node_id":"MDQ6VXNlcjEwMDg0Njk1","avatar_url":"https://avatars3.githubusercontent.com/u/10084695?v=4","gravatar_id":"","url":"https://api.github.com/users/Space2Man","html_url":"https://github.com/Space2Man","followers_url":"https://api.github.com/users/Space2Man/followers","following_url":"https://api.github.com/users/Space2Man/following{/other_user}","gists_url":"https://api.github.com/users/Space2Man/gists{/gist_id}","starred_url":"https://api.github.com/users/Space2Man/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Space2Man/subscriptions","organizations_url":"https://api.github.com/users/Space2Man/orgs","repos_url":"https://api.github.com/users/Space2Man/repos","events_url":"https://api.github.com/users/Space2Man/events{/privacy}","received_events_url":"https://api.github.com/users/Space2Man/received_events","type":"User","site_admin":false},"body":"Not sure how to validate if we can parse to long directly ...","created_at":"2018-10-03T18:07:48Z","updated_at":"2018-10-03T18:07:49Z","html_url":"https://github.com/oshi/oshi/pull/639#discussion_r222411467","pull_request_url":"https://api.github.com/repos/oshi/oshi/pulls/639","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/oshi/oshi/pulls/comments/222411467"},"html":{"href":"https://github.com/oshi/oshi/pull/639#discussion_r222411467"},"pull_request":{"href":"https://api.github.com/repos/oshi/oshi/pulls/639"}},"in_reply_to_id":222372727},"pull_request":{"url":"https://api.github.com/repos/oshi/oshi/pulls/639","id":219997884,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5OTk3ODg0","html_url":"https://github.com/oshi/oshi/pull/639","diff_url":"https://github.com/oshi/oshi/pull/639.diff","patch_url":"https://github.com/oshi/oshi/pull/639.patch","issue_url":"https://api.github.com/repos/oshi/oshi/issues/639","number":639,"state":"open","locked":false,"title":"Implement QueueLength metric in HWDiskStore (macOS does not provide t…","user":{"login":"Space2Man","id":10084695,"node_id":"MDQ6VXNlcjEwMDg0Njk1","avatar_url":"https://avatars3.githubusercontent.com/u/10084695?v=4","gravatar_id":"","url":"https://api.github.com/users/Space2Man","html_url":"https://github.com/Space2Man","followers_url":"https://api.github.com/users/Space2Man/followers","following_url":"https://api.github.com/users/Space2Man/following{/other_user}","gists_url":"https://api.github.com/users/Space2Man/gists{/gist_id}","starred_url":"https://api.github.com/users/Space2Man/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Space2Man/subscriptions","organizations_url":"https://api.github.com/users/Space2Man/orgs","repos_url":"https://api.github.com/users/Space2Man/repos","events_url":"https://api.github.com/users/Space2Man/events{/privacy}","received_events_url":"https://api.github.com/users/Space2Man/received_events","type":"User","site_admin":false},"body":"…hat value -> always 0)\r\n\r\nThe following values are returned. They only show the current/instantaneous queue length:\r\n\r\n- Linux (see linux/Documentation/iostat.txt):\r\n\r\n> Field  9 -- # of I/Os currently in progress\r\n>     The only field that should go to zero. Incremented as requests are\r\n>     given to appropriate struct request_queue and decremented as they finish.\r\n\r\n- Solaris (see kstat in JNA or man(3) kstat) - sum of wcnt + rcnt\r\n\r\n> uint_t\t  wcnt;\t\t    /* count of\telements in wait state */\r\n> uint_t\t  rcnt;\t\t    /* count of\telements in run\tstate */\r\n \r\n- FreeBSD (see man iostat -Ix):\r\n\r\n> qlen\t   transactions\tqueue length\r\n\r\n- Windows (see [https://blogs.technet.microsoft.com/askcore/2012/03/16/windows-performance-monitor-disk-counters-explained/](https://blogs.technet.microsoft.com/askcore/2012/03/16/windows-performance-monitor-disk-counters-explained/):\r\n\r\n> Current Disk Queue Length\r\n> Current Disk Queue Length is a direct measurement of the disk queue present at the time of the sampling. \r\n\r\n- on MacOS this metric is not defined or at least I could not find it","created_at":"2018-10-03T11:10:18Z","updated_at":"2018-10-03T18:07:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"520452b7c93137e2af2c8d0f9eedefd8e49746ef","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/oshi/oshi/pulls/639/commits","review_comments_url":"https://api.github.com/repos/oshi/oshi/pulls/639/comments","review_comment_url":"https://api.github.com/repos/oshi/oshi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/oshi/oshi/issues/639/comments","statuses_url":"https://api.github.com/repos/oshi/oshi/statuses/f85725493b2cd07ff9aab481a349850a54968e30","head":{"label":"Space2Man:feature/QueueLengthV2","ref":"feature/QueueLengthV2","sha":"f85725493b2cd07ff9aab481a349850a54968e30","user":{"login":"Space2Man","id":10084695,"node_id":"MDQ6VXNlcjEwMDg0Njk1","avatar_url":"https://avatars3.githubusercontent.com/u/10084695?v=4","gravatar_id":"","url":"https://api.github.com/users/Space2Man","html_url":"https://github.com/Space2Man","followers_url":"https://api.github.com/users/Space2Man/followers","following_url":"https://api.github.com/users/Space2Man/following{/other_user}","gists_url":"https://api.github.com/users/Space2Man/gists{/gist_id}","starred_url":"https://api.github.com/users/Space2Man/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Space2Man/subscriptions","organizations_url":"https://api.github.com/users/Space2Man/orgs","repos_url":"https://api.github.com/users/Space2Man/repos","events_url":"https://api.github.com/users/Space2Man/events{/privacy}","received_events_url":"https://api.github.com/users/Space2Man/received_events","type":"User","site_admin":false},"repo":{"id":150329126,"node_id":"MDEwOlJlcG9zaXRvcnkxNTAzMjkxMjY=","name":"oshi","full_name":"Space2Man/oshi","private":false,"owner":{"login":"Space2Man","id":10084695,"node_id":"MDQ6VXNlcjEwMDg0Njk1","avatar_url":"https://avatars3.githubusercontent.com/u/10084695?v=4","gravatar_id":"","url":"https://api.github.com/users/Space2Man","html_url":"https://github.com/Space2Man","followers_url":"https://api.github.com/users/Space2Man/followers","following_url":"https://api.github.com/users/Space2Man/following{/other_user}","gists_url":"https://api.github.com/users/Space2Man/gists{/gist_id}","starred_url":"https://api.github.com/users/Space2Man/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Space2Man/subscriptions","organizations_url":"https://api.github.com/users/Space2Man/orgs","repos_url":"https://api.github.com/users/Space2Man/repos","events_url":"https://api.github.com/users/Space2Man/events{/privacy}","received_events_url":"https://api.github.com/users/Space2Man/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Space2Man/oshi","description":"Native Operating System and Hardware Information","fork":true,"url":"https://api.github.com/repos/Space2Man/oshi","forks_url":"https://api.github.com/repos/Space2Man/oshi/forks","keys_url":"https://api.github.com/repos/Space2Man/oshi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Space2Man/oshi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Space2Man/oshi/teams","hooks_url":"https://api.github.com/repos/Space2Man/oshi/hooks","issue_events_url":"https://api.github.com/repos/Space2Man/oshi/issues/events{/number}","events_url":"https://api.github.com/repos/Space2Man/oshi/events","assignees_url":"https://api.github.com/repos/Space2Man/oshi/assignees{/user}","branches_url":"https://api.github.com/repos/Space2Man/oshi/branches{/branch}","tags_url":"https://api.github.com/repos/Space2Man/oshi/tags","blobs_url":"https://api.github.com/repos/Space2Man/oshi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Space2Man/oshi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Space2Man/oshi/git/refs{/sha}","trees_url":"https://api.github.com/repos/Space2Man/oshi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Space2Man/oshi/statuses/{sha}","languages_url":"https://api.github.com/repos/Space2Man/oshi/languages","stargazers_url":"https://api.github.com/repos/Space2Man/oshi/stargazers","contributors_url":"https://api.github.com/repos/Space2Man/oshi/contributors","subscribers_url":"https://api.github.com/repos/Space2Man/oshi/subscribers","subscription_url":"https://api.github.com/repos/Space2Man/oshi/subscription","commits_url":"https://api.github.com/repos/Space2Man/oshi/commits{/sha}","git_commits_url":"https://api.github.com/repos/Space2Man/oshi/git/commits{/sha}","comments_url":"https://api.github.com/repos/Space2Man/oshi/comments{/number}","issue_comment_url":"https://api.github.com/repos/Space2Man/oshi/issues/comments{/number}","contents_url":"https://api.github.com/repos/Space2Man/oshi/contents/{+path}","compare_url":"https://api.github.com/repos/Space2Man/oshi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Space2Man/oshi/merges","archive_url":"https://api.github.com/repos/Space2Man/oshi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Space2Man/oshi/downloads","issues_url":"https://api.github.com/repos/Space2Man/oshi/issues{/number}","pulls_url":"https://api.github.com/repos/Space2Man/oshi/pulls{/number}","milestones_url":"https://api.github.com/repos/Space2Man/oshi/milestones{/number}","notifications_url":"https://api.github.com/repos/Space2Man/oshi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Space2Man/oshi/labels{/name}","releases_url":"https://api.github.com/repos/Space2Man/oshi/releases{/id}","deployments_url":"https://api.github.com/repos/Space2Man/oshi/deployments","created_at":"2018-09-25T21:03:56Z","updated_at":"2018-09-25T21:04:00Z","pushed_at":"2018-10-03T11:00:42Z","git_url":"git://github.com/Space2Man/oshi.git","ssh_url":"git@github.com:Space2Man/oshi.git","clone_url":"https://github.com/Space2Man/oshi.git","svn_url":"https://github.com/Space2Man/oshi","homepage":"","size":65105,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"oshi:master","ref":"master","sha":"6738257da57b61feb4e0ffee07cb082de168fed1","user":{"login":"oshi","id":21304425,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMzA0NDI1","avatar_url":"https://avatars2.githubusercontent.com/u/21304425?v=4","gravatar_id":"","url":"https://api.github.com/users/oshi","html_url":"https://github.com/oshi","followers_url":"https://api.github.com/users/oshi/followers","following_url":"https://api.github.com/users/oshi/following{/other_user}","gists_url":"https://api.github.com/users/oshi/gists{/gist_id}","starred_url":"https://api.github.com/users/oshi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oshi/subscriptions","organizations_url":"https://api.github.com/users/oshi/orgs","repos_url":"https://api.github.com/users/oshi/repos","events_url":"https://api.github.com/users/oshi/events{/privacy}","received_events_url":"https://api.github.com/users/oshi/received_events","type":"Organization","site_admin":false},"repo":{"id":3407114,"node_id":"MDEwOlJlcG9zaXRvcnkzNDA3MTE0","name":"oshi","full_name":"oshi/oshi","private":false,"owner":{"login":"oshi","id":21304425,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMzA0NDI1","avatar_url":"https://avatars2.githubusercontent.com/u/21304425?v=4","gravatar_id":"","url":"https://api.github.com/users/oshi","html_url":"https://github.com/oshi","followers_url":"https://api.github.com/users/oshi/followers","following_url":"https://api.github.com/users/oshi/following{/other_user}","gists_url":"https://api.github.com/users/oshi/gists{/gist_id}","starred_url":"https://api.github.com/users/oshi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oshi/subscriptions","organizations_url":"https://api.github.com/users/oshi/orgs","repos_url":"https://api.github.com/users/oshi/repos","events_url":"https://api.github.com/users/oshi/events{/privacy}","received_events_url":"https://api.github.com/users/oshi/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/oshi/oshi","description":"Native Operating System and Hardware Information","fork":false,"url":"https://api.github.com/repos/oshi/oshi","forks_url":"https://api.github.com/repos/oshi/oshi/forks","keys_url":"https://api.github.com/repos/oshi/oshi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oshi/oshi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oshi/oshi/teams","hooks_url":"https://api.github.com/repos/oshi/oshi/hooks","issue_events_url":"https://api.github.com/repos/oshi/oshi/issues/events{/number}","events_url":"https://api.github.com/repos/oshi/oshi/events","assignees_url":"https://api.github.com/repos/oshi/oshi/assignees{/user}","branches_url":"https://api.github.com/repos/oshi/oshi/branches{/branch}","tags_url":"https://api.github.com/repos/oshi/oshi/tags","blobs_url":"https://api.github.com/repos/oshi/oshi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oshi/oshi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oshi/oshi/git/refs{/sha}","trees_url":"https://api.github.com/repos/oshi/oshi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oshi/oshi/statuses/{sha}","languages_url":"https://api.github.com/repos/oshi/oshi/languages","stargazers_url":"https://api.github.com/repos/oshi/oshi/stargazers","contributors_url":"https://api.github.com/repos/oshi/oshi/contributors","subscribers_url":"https://api.github.com/repos/oshi/oshi/subscribers","subscription_url":"https://api.github.com/repos/oshi/oshi/subscription","commits_url":"https://api.github.com/repos/oshi/oshi/commits{/sha}","git_commits_url":"https://api.github.com/repos/oshi/oshi/git/commits{/sha}","comments_url":"https://api.github.com/repos/oshi/oshi/comments{/number}","issue_comment_url":"https://api.github.com/repos/oshi/oshi/issues/comments{/number}","contents_url":"https://api.github.com/repos/oshi/oshi/contents/{+path}","compare_url":"https://api.github.com/repos/oshi/oshi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oshi/oshi/merges","archive_url":"https://api.github.com/repos/oshi/oshi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oshi/oshi/downloads","issues_url":"https://api.github.com/repos/oshi/oshi/issues{/number}","pulls_url":"https://api.github.com/repos/oshi/oshi/pulls{/number}","milestones_url":"https://api.github.com/repos/oshi/oshi/milestones{/number}","notifications_url":"https://api.github.com/repos/oshi/oshi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oshi/oshi/labels{/name}","releases_url":"https://api.github.com/repos/oshi/oshi/releases{/id}","deployments_url":"https://api.github.com/repos/oshi/oshi/deployments","created_at":"2012-02-10T12:46:48Z","updated_at":"2018-10-02T09:09:16Z","pushed_at":"2018-10-03T11:10:19Z","git_url":"git://github.com/oshi/oshi.git","ssh_url":"git@github.com:oshi/oshi.git","clone_url":"https://github.com/oshi/oshi.git","svn_url":"https://github.com/oshi/oshi","homepage":"","size":65122,"stargazers_count":636,"watchers_count":636,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":183,"mirror_url":null,"archived":false,"open_issues_count":30,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":183,"open_issues":30,"watchers":636,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/oshi/oshi/pulls/639"},"html":{"href":"https://github.com/oshi/oshi/pull/639"},"issue":{"href":"https://api.github.com/repos/oshi/oshi/issues/639"},"comments":{"href":"https://api.github.com/repos/oshi/oshi/issues/639/comments"},"review_comments":{"href":"https://api.github.com/repos/oshi/oshi/pulls/639/comments"},"review_comment":{"href":"https://api.github.com/repos/oshi/oshi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/oshi/oshi/pulls/639/commits"},"statuses":{"href":"https://api.github.com/repos/oshi/oshi/statuses/f85725493b2cd07ff9aab481a349850a54968e30"}},"author_association":"NONE"}}
{"actor":{"display_login":"Space2Man"}}