{"action":"created","comment":{"url":"https://api.github.com/repos/MycroftAI/mycroft-core/pulls/comments/195906286","pull_request_review_id":129366781,"id":195906286,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTkwNjI4Ng==","diff_hunk":"@@ -17,6 +17,105 @@\n \n from mycroft.util.lang.format_common import convert_to_mixed_fraction\n \n+LONG_SCALE_EN = {\n+    10e12: \"billion\",\n+    10e18: 'trillion',\n+    10e24: \"quadrillion\",\n+    10e30: \"quintillion\",\n+    10e36: \"sextillion\",\n+    10e42: \"septillion\",\n+    10e48: \"octillion\",\n+    10e54: \"nonillion\",\n+    10e60: \"decillion\",\n+    10e66: \"undecillion\",\n+    10e72: \"duodecillion\",\n+    10e78: \"tredecillion\",\n+    10e84: \"quattuordecillion\",\n+    10e90: \"quinquadecillion\",\n+    10e96: \"sedecillion\",\n+    10e102: \"septendecillion\",\n+    10e108: \"octodecillion\",\n+    10e114: \"novendecillion\",\n+    10e120: \"vigintillion\",\n+    10e306: \"unquinquagintillion\",\n+    10e312: \"duoquinquagintillion\",\n+    10e336: \"sesquinquagintillion\",\n+    10e366: \"unsexagintillion\",\n+    10e100: \"googol\"\n+}\n+\n+SHORT_SCALE_EN = {","path":"mycroft/util/lang/format_en.py","position":31,"original_position":31,"commit_id":"7e93c1f74db68c36ec631d07197c1e17f3554fd5","original_commit_id":"7e93c1f74db68c36ec631d07197c1e17f3554fd5","user":{"login":"codacy-bot","id":19940114,"node_id":"MDQ6VXNlcjE5OTQwMTE0","avatar_url":"https://avatars1.githubusercontent.com/u/19940114?v=4","gravatar_id":"","url":"https://api.github.com/users/codacy-bot","html_url":"https://github.com/codacy-bot","followers_url":"https://api.github.com/users/codacy-bot/followers","following_url":"https://api.github.com/users/codacy-bot/following{/other_user}","gists_url":"https://api.github.com/users/codacy-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/codacy-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codacy-bot/subscriptions","organizations_url":"https://api.github.com/users/codacy-bot/orgs","repos_url":"https://api.github.com/users/codacy-bot/repos","events_url":"https://api.github.com/users/codacy-bot/events{/privacy}","received_events_url":"https://api.github.com/users/codacy-bot/received_events","type":"User","site_admin":false},"body":"![Codacy](https://app.codacy.com/assets/images/favicon.png) Issue found: [Duplicate key inf in dictionary](https://app.codacy.com/app/MatthewScholefield/mycroft-core/pullRequest?prid=1787653)","created_at":"2018-06-16T16:07:44Z","updated_at":"2018-06-16T16:07:44Z","html_url":"https://github.com/MycroftAI/mycroft-core/pull/1642#discussion_r195906286","pull_request_url":"https://api.github.com/repos/MycroftAI/mycroft-core/pulls/1642","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/MycroftAI/mycroft-core/pulls/comments/195906286"},"html":{"href":"https://github.com/MycroftAI/mycroft-core/pull/1642#discussion_r195906286"},"pull_request":{"href":"https://api.github.com/repos/MycroftAI/mycroft-core/pulls/1642"}}},"pull_request":{"url":"https://api.github.com/repos/MycroftAI/mycroft-core/pulls/1642","id":195316464,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1MzE2NDY0","html_url":"https://github.com/MycroftAI/mycroft-core/pull/1642","diff_url":"https://github.com/MycroftAI/mycroft-core/pull/1642.diff","patch_url":"https://github.com/MycroftAI/mycroft-core/pull/1642.patch","issue_url":"https://api.github.com/repos/MycroftAI/mycroft-core/issues/1642","number":1642,"state":"open","locked":false,"title":"improve extract_number_en","user":{"login":"JarbasAl","id":33701864,"node_id":"MDQ6VXNlcjMzNzAxODY0","avatar_url":"https://avatars0.githubusercontent.com/u/33701864?v=4","gravatar_id":"","url":"https://api.github.com/users/JarbasAl","html_url":"https://github.com/JarbasAl","followers_url":"https://api.github.com/users/JarbasAl/followers","following_url":"https://api.github.com/users/JarbasAl/following{/other_user}","gists_url":"https://api.github.com/users/JarbasAl/gists{/gist_id}","starred_url":"https://api.github.com/users/JarbasAl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JarbasAl/subscriptions","organizations_url":"https://api.github.com/users/JarbasAl/orgs","repos_url":"https://api.github.com/users/JarbasAl/repos","events_url":"https://api.github.com/users/JarbasAl/events{/privacy}","received_events_url":"https://api.github.com/users/JarbasAl/received_events","type":"User","site_admin":false},"body":"## Description\r\nwhen using extractnumber i noticed \"twenty two\" would not work... it is great with fractions, but fails on big numbers, i assume because it was meant to handle time\r\n\r\nthis PR adds support for negative numbers, numbers with decimal points and big numbers in general\r\n\r\nhttps://en.wikipedia.org/wiki/Names_of_large_numbers\r\n\r\n## How to test\r\n\r\ncheck the unittests\r\n\r\n## Contributor license agreement signed?\r\nCLA [ yes] (Whether you have signed a [CLA - Contributor Licensing Agreement](https://mycroft.ai/cla/)\r\n","created_at":"2018-06-16T04:19:07Z","updated_at":"2018-06-16T16:07:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8babe1a9ae528da3b0479bc62f0d34ea8dc8f96e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/MycroftAI/mycroft-core/pulls/1642/commits","review_comments_url":"https://api.github.com/repos/MycroftAI/mycroft-core/pulls/1642/comments","review_comment_url":"https://api.github.com/repos/MycroftAI/mycroft-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MycroftAI/mycroft-core/issues/1642/comments","statuses_url":"https://api.github.com/repos/MycroftAI/mycroft-core/statuses/7e93c1f74db68c36ec631d07197c1e17f3554fd5","head":{"label":"JarbasAl:improve_extract_number_en","ref":"improve_extract_number_en","sha":"7e93c1f74db68c36ec631d07197c1e17f3554fd5","user":{"login":"JarbasAl","id":33701864,"node_id":"MDQ6VXNlcjMzNzAxODY0","avatar_url":"https://avatars0.githubusercontent.com/u/33701864?v=4","gravatar_id":"","url":"https://api.github.com/users/JarbasAl","html_url":"https://github.com/JarbasAl","followers_url":"https://api.github.com/users/JarbasAl/followers","following_url":"https://api.github.com/users/JarbasAl/following{/other_user}","gists_url":"https://api.github.com/users/JarbasAl/gists{/gist_id}","starred_url":"https://api.github.com/users/JarbasAl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JarbasAl/subscriptions","organizations_url":"https://api.github.com/users/JarbasAl/orgs","repos_url":"https://api.github.com/users/JarbasAl/repos","events_url":"https://api.github.com/users/JarbasAl/events{/privacy}","received_events_url":"https://api.github.com/users/JarbasAl/received_events","type":"User","site_admin":false},"repo":{"id":110881871,"node_id":"MDEwOlJlcG9zaXRvcnkxMTA4ODE4NzE=","name":"jarbas-core","full_name":"JarbasAl/jarbas-core","owner":{"login":"JarbasAl","id":33701864,"node_id":"MDQ6VXNlcjMzNzAxODY0","avatar_url":"https://avatars0.githubusercontent.com/u/33701864?v=4","gravatar_id":"","url":"https://api.github.com/users/JarbasAl","html_url":"https://github.com/JarbasAl","followers_url":"https://api.github.com/users/JarbasAl/followers","following_url":"https://api.github.com/users/JarbasAl/following{/other_user}","gists_url":"https://api.github.com/users/JarbasAl/gists{/gist_id}","starred_url":"https://api.github.com/users/JarbasAl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JarbasAl/subscriptions","organizations_url":"https://api.github.com/users/JarbasAl/orgs","repos_url":"https://api.github.com/users/JarbasAl/repos","events_url":"https://api.github.com/users/JarbasAl/events{/privacy}","received_events_url":"https://api.github.com/users/JarbasAl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JarbasAl/jarbas-core","description":"Mycroft Core, the Mycroft Artificial Intelligence platform.","fork":true,"url":"https://api.github.com/repos/JarbasAl/jarbas-core","forks_url":"https://api.github.com/repos/JarbasAl/jarbas-core/forks","keys_url":"https://api.github.com/repos/JarbasAl/jarbas-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JarbasAl/jarbas-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JarbasAl/jarbas-core/teams","hooks_url":"https://api.github.com/repos/JarbasAl/jarbas-core/hooks","issue_events_url":"https://api.github.com/repos/JarbasAl/jarbas-core/issues/events{/number}","events_url":"https://api.github.com/repos/JarbasAl/jarbas-core/events","assignees_url":"https://api.github.com/repos/JarbasAl/jarbas-core/assignees{/user}","branches_url":"https://api.github.com/repos/JarbasAl/jarbas-core/branches{/branch}","tags_url":"https://api.github.com/repos/JarbasAl/jarbas-core/tags","blobs_url":"https://api.github.com/repos/JarbasAl/jarbas-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JarbasAl/jarbas-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JarbasAl/jarbas-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/JarbasAl/jarbas-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JarbasAl/jarbas-core/statuses/{sha}","languages_url":"https://api.github.com/repos/JarbasAl/jarbas-core/languages","stargazers_url":"https://api.github.com/repos/JarbasAl/jarbas-core/stargazers","contributors_url":"https://api.github.com/repos/JarbasAl/jarbas-core/contributors","subscribers_url":"https://api.github.com/repos/JarbasAl/jarbas-core/subscribers","subscription_url":"https://api.github.com/repos/JarbasAl/jarbas-core/subscription","commits_url":"https://api.github.com/repos/JarbasAl/jarbas-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/JarbasAl/jarbas-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/JarbasAl/jarbas-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/JarbasAl/jarbas-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/JarbasAl/jarbas-core/contents/{+path}","compare_url":"https://api.github.com/repos/JarbasAl/jarbas-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JarbasAl/jarbas-core/merges","archive_url":"https://api.github.com/repos/JarbasAl/jarbas-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JarbasAl/jarbas-core/downloads","issues_url":"https://api.github.com/repos/JarbasAl/jarbas-core/issues{/number}","pulls_url":"https://api.github.com/repos/JarbasAl/jarbas-core/pulls{/number}","milestones_url":"https://api.github.com/repos/JarbasAl/jarbas-core/milestones{/number}","notifications_url":"https://api.github.com/repos/JarbasAl/jarbas-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JarbasAl/jarbas-core/labels{/name}","releases_url":"https://api.github.com/repos/JarbasAl/jarbas-core/releases{/id}","deployments_url":"https://api.github.com/repos/JarbasAl/jarbas-core/deployments","created_at":"2017-11-15T20:17:26Z","updated_at":"2018-06-05T12:52:26Z","pushed_at":"2018-06-16T16:04:07Z","git_url":"git://github.com/JarbasAl/jarbas-core.git","ssh_url":"git@github.com:JarbasAl/jarbas-core.git","clone_url":"https://github.com/JarbasAl/jarbas-core.git","svn_url":"https://github.com/JarbasAl/jarbas-core","homepage":"https://mycroft.ai","size":220225,"stargazers_count":11,"watchers_count":11,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2,"open_issues":0,"watchers":11,"default_branch":"jarbas-dev"}},"base":{"label":"MycroftAI:dev","ref":"dev","sha":"abd1fe75711ad0eefd22706c6b8c7f2960ef388f","user":{"login":"MycroftAI","id":14171097,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTcxMDk3","avatar_url":"https://avatars0.githubusercontent.com/u/14171097?v=4","gravatar_id":"","url":"https://api.github.com/users/MycroftAI","html_url":"https://github.com/MycroftAI","followers_url":"https://api.github.com/users/MycroftAI/followers","following_url":"https://api.github.com/users/MycroftAI/following{/other_user}","gists_url":"https://api.github.com/users/MycroftAI/gists{/gist_id}","starred_url":"https://api.github.com/users/MycroftAI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MycroftAI/subscriptions","organizations_url":"https://api.github.com/users/MycroftAI/orgs","repos_url":"https://api.github.com/users/MycroftAI/repos","events_url":"https://api.github.com/users/MycroftAI/events{/privacy}","received_events_url":"https://api.github.com/users/MycroftAI/received_events","type":"Organization","site_admin":false},"repo":{"id":59299524,"node_id":"MDEwOlJlcG9zaXRvcnk1OTI5OTUyNA==","name":"mycroft-core","full_name":"MycroftAI/mycroft-core","owner":{"login":"MycroftAI","id":14171097,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTcxMDk3","avatar_url":"https://avatars0.githubusercontent.com/u/14171097?v=4","gravatar_id":"","url":"https://api.github.com/users/MycroftAI","html_url":"https://github.com/MycroftAI","followers_url":"https://api.github.com/users/MycroftAI/followers","following_url":"https://api.github.com/users/MycroftAI/following{/other_user}","gists_url":"https://api.github.com/users/MycroftAI/gists{/gist_id}","starred_url":"https://api.github.com/users/MycroftAI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MycroftAI/subscriptions","organizations_url":"https://api.github.com/users/MycroftAI/orgs","repos_url":"https://api.github.com/users/MycroftAI/repos","events_url":"https://api.github.com/users/MycroftAI/events{/privacy}","received_events_url":"https://api.github.com/users/MycroftAI/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MycroftAI/mycroft-core","description":"Mycroft Core, the Mycroft Artificial Intelligence platform.","fork":false,"url":"https://api.github.com/repos/MycroftAI/mycroft-core","forks_url":"https://api.github.com/repos/MycroftAI/mycroft-core/forks","keys_url":"https://api.github.com/repos/MycroftAI/mycroft-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MycroftAI/mycroft-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MycroftAI/mycroft-core/teams","hooks_url":"https://api.github.com/repos/MycroftAI/mycroft-core/hooks","issue_events_url":"https://api.github.com/repos/MycroftAI/mycroft-core/issues/events{/number}","events_url":"https://api.github.com/repos/MycroftAI/mycroft-core/events","assignees_url":"https://api.github.com/repos/MycroftAI/mycroft-core/assignees{/user}","branches_url":"https://api.github.com/repos/MycroftAI/mycroft-core/branches{/branch}","tags_url":"https://api.github.com/repos/MycroftAI/mycroft-core/tags","blobs_url":"https://api.github.com/repos/MycroftAI/mycroft-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MycroftAI/mycroft-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MycroftAI/mycroft-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/MycroftAI/mycroft-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MycroftAI/mycroft-core/statuses/{sha}","languages_url":"https://api.github.com/repos/MycroftAI/mycroft-core/languages","stargazers_url":"https://api.github.com/repos/MycroftAI/mycroft-core/stargazers","contributors_url":"https://api.github.com/repos/MycroftAI/mycroft-core/contributors","subscribers_url":"https://api.github.com/repos/MycroftAI/mycroft-core/subscribers","subscription_url":"https://api.github.com/repos/MycroftAI/mycroft-core/subscription","commits_url":"https://api.github.com/repos/MycroftAI/mycroft-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/MycroftAI/mycroft-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/MycroftAI/mycroft-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/MycroftAI/mycroft-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/MycroftAI/mycroft-core/contents/{+path}","compare_url":"https://api.github.com/repos/MycroftAI/mycroft-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MycroftAI/mycroft-core/merges","archive_url":"https://api.github.com/repos/MycroftAI/mycroft-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MycroftAI/mycroft-core/downloads","issues_url":"https://api.github.com/repos/MycroftAI/mycroft-core/issues{/number}","pulls_url":"https://api.github.com/repos/MycroftAI/mycroft-core/pulls{/number}","milestones_url":"https://api.github.com/repos/MycroftAI/mycroft-core/milestones{/number}","notifications_url":"https://api.github.com/repos/MycroftAI/mycroft-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MycroftAI/mycroft-core/labels{/name}","releases_url":"https://api.github.com/repos/MycroftAI/mycroft-core/releases{/id}","deployments_url":"https://api.github.com/repos/MycroftAI/mycroft-core/deployments","created_at":"2016-05-20T14:11:07Z","updated_at":"2018-06-16T09:07:01Z","pushed_at":"2018-06-16T16:04:09Z","git_url":"git://github.com/MycroftAI/mycroft-core.git","ssh_url":"git@github.com:MycroftAI/mycroft-core.git","clone_url":"https://github.com/MycroftAI/mycroft-core.git","svn_url":"https://github.com/MycroftAI/mycroft-core","homepage":"https://mycroft.ai","size":114554,"stargazers_count":2451,"watchers_count":2451,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":596,"mirror_url":null,"archived":false,"open_issues_count":186,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":596,"open_issues":186,"watchers":2451,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/MycroftAI/mycroft-core/pulls/1642"},"html":{"href":"https://github.com/MycroftAI/mycroft-core/pull/1642"},"issue":{"href":"https://api.github.com/repos/MycroftAI/mycroft-core/issues/1642"},"comments":{"href":"https://api.github.com/repos/MycroftAI/mycroft-core/issues/1642/comments"},"review_comments":{"href":"https://api.github.com/repos/MycroftAI/mycroft-core/pulls/1642/comments"},"review_comment":{"href":"https://api.github.com/repos/MycroftAI/mycroft-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MycroftAI/mycroft-core/pulls/1642/commits"},"statuses":{"href":"https://api.github.com/repos/MycroftAI/mycroft-core/statuses/7e93c1f74db68c36ec631d07197c1e17f3554fd5"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"codacy-bot"}}