{"action":"created","issue":{"url":"https://api.github.com/repos/opesci/devito/issues/622","repository_url":"https://api.github.com/repos/opesci/devito","labels_url":"https://api.github.com/repos/opesci/devito/issues/622/labels{/name}","comments_url":"https://api.github.com/repos/opesci/devito/issues/622/comments","events_url":"https://api.github.com/repos/opesci/devito/issues/622/events","html_url":"https://github.com/opesci/devito/pull/622","id":345632948,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0NzA5OTU0","number":622,"title":"minor pickling updates","user":{"login":"tjb900","id":1707852,"node_id":"MDQ6VXNlcjE3MDc4NTI=","avatar_url":"https://avatars3.githubusercontent.com/u/1707852?v=4","gravatar_id":"","url":"https://api.github.com/users/tjb900","html_url":"https://github.com/tjb900","followers_url":"https://api.github.com/users/tjb900/followers","following_url":"https://api.github.com/users/tjb900/following{/other_user}","gists_url":"https://api.github.com/users/tjb900/gists{/gist_id}","starred_url":"https://api.github.com/users/tjb900/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tjb900/subscriptions","organizations_url":"https://api.github.com/users/tjb900/orgs","repos_url":"https://api.github.com/users/tjb900/repos","events_url":"https://api.github.com/users/tjb900/events{/privacy}","received_events_url":"https://api.github.com/users/tjb900/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-07-30T06:54:28Z","updated_at":"2018-07-31T01:10:03Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/opesci/devito/pulls/622","html_url":"https://github.com/opesci/devito/pull/622","diff_url":"https://github.com/opesci/devito/pull/622.diff","patch_url":"https://github.com/opesci/devito/pull/622.patch"},"body":"0. I've changed one of the pickling tests to use a non-default value for `save`, to illustrate the failure I am fixing.\r\n1. To fix that now-broken test, `TimeFunction.save` is now pickled.  To facilitate that pickling, it is now saved in the instance as the original parameter, not the type.\r\n2. The Pickable superclass is modified to be pickle instance attributes which have leading underscores, but pass them back to the constructor during unpickling _without_ the underscore.  This is to handle the case of e.g. Constant._value.\r\n3. Constant now pickles its dtype and _value attributes."},"comment":{"url":"https://api.github.com/repos/opesci/devito/issues/comments/409060985","html_url":"https://github.com/opesci/devito/pull/622#issuecomment-409060985","issue_url":"https://api.github.com/repos/opesci/devito/issues/622","id":409060985,"node_id":"MDEyOklzc3VlQ29tbWVudDQwOTA2MDk4NQ==","user":{"login":"tjb900","id":1707852,"node_id":"MDQ6VXNlcjE3MDc4NTI=","avatar_url":"https://avatars3.githubusercontent.com/u/1707852?v=4","gravatar_id":"","url":"https://api.github.com/users/tjb900","html_url":"https://github.com/tjb900","followers_url":"https://api.github.com/users/tjb900/followers","following_url":"https://api.github.com/users/tjb900/following{/other_user}","gists_url":"https://api.github.com/users/tjb900/gists{/gist_id}","starred_url":"https://api.github.com/users/tjb900/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tjb900/subscriptions","organizations_url":"https://api.github.com/users/tjb900/orgs","repos_url":"https://api.github.com/users/tjb900/repos","events_url":"https://api.github.com/users/tjb900/events{/privacy}","received_events_url":"https://api.github.com/users/tjb900/received_events","type":"User","site_admin":false},"created_at":"2018-07-31T01:10:03Z","updated_at":"2018-07-31T01:10:03Z","author_association":"COLLABORATOR","body":"> I would rather keep it the way it was, the type only says whether or not the wavefield is time or t but saving the number of time_steps will force the creation of a new operator for every new number of time steps.\r\n\r\nOh, right!  So what determines which attributes of a Function are included in that hash?  It looks like this is what `Signer.__signature_items__` is designed to be for, but it isn't really used anywhere, yet...?\r\n"}}
{"actor":{"display_login":"tjb900"}}