{"action":"created","issue":{"url":"https://api.github.com/repos/NREL/EnergyPlus/issues/6728","repository_url":"https://api.github.com/repos/NREL/EnergyPlus","labels_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/6728/labels{/name}","comments_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/6728/comments","events_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/6728/events","html_url":"https://github.com/NREL/EnergyPlus/pull/6728","id":317344468,"node_id":"MDExOlB1bGxSZXF1ZXN0MTgzODI1NDgy","number":6728,"title":"Refactor of Boiler:HotWater Code","user":{"login":"drewyh","id":20280470,"node_id":"MDQ6VXNlcjIwMjgwNDcw","avatar_url":"https://avatars1.githubusercontent.com/u/20280470?v=4","gravatar_id":"","url":"https://api.github.com/users/drewyh","html_url":"https://github.com/drewyh","followers_url":"https://api.github.com/users/drewyh/followers","following_url":"https://api.github.com/users/drewyh/following{/other_user}","gists_url":"https://api.github.com/users/drewyh/gists{/gist_id}","starred_url":"https://api.github.com/users/drewyh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drewyh/subscriptions","organizations_url":"https://api.github.com/users/drewyh/orgs","repos_url":"https://api.github.com/users/drewyh/repos","events_url":"https://api.github.com/users/drewyh/events{/privacy}","received_events_url":"https://api.github.com/users/drewyh/received_events","type":"User","site_admin":false},"labels":[{"id":244051192,"node_id":"MDU6TGFiZWwyNDQwNTExOTI=","url":"https://api.github.com/repos/NREL/EnergyPlus/labels/Refactoring","name":"Refactoring","color":"0000FF","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/NREL/EnergyPlus/milestones/8","html_url":"https://github.com/NREL/EnergyPlus/milestone/8","labels_url":"https://api.github.com/repos/NREL/EnergyPlus/milestones/8/labels","id":3115951,"node_id":"MDk6TWlsZXN0b25lMzExNTk1MQ==","number":8,"title":"EnergyPlus 9.0","description":"","creator":{"login":"Myoldmopar","id":849824,"node_id":"MDQ6VXNlcjg0OTgyNA==","avatar_url":"https://avatars0.githubusercontent.com/u/849824?v=4","gravatar_id":"","url":"https://api.github.com/users/Myoldmopar","html_url":"https://github.com/Myoldmopar","followers_url":"https://api.github.com/users/Myoldmopar/followers","following_url":"https://api.github.com/users/Myoldmopar/following{/other_user}","gists_url":"https://api.github.com/users/Myoldmopar/gists{/gist_id}","starred_url":"https://api.github.com/users/Myoldmopar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Myoldmopar/subscriptions","organizations_url":"https://api.github.com/users/Myoldmopar/orgs","repos_url":"https://api.github.com/users/Myoldmopar/repos","events_url":"https://api.github.com/users/Myoldmopar/events{/privacy}","received_events_url":"https://api.github.com/users/Myoldmopar/received_events","type":"User","site_admin":false},"open_issues":70,"closed_issues":24,"state":"open","created_at":"2018-02-14T10:31:29Z","updated_at":"2018-07-10T17:49:54Z","due_on":"2018-09-30T07:00:00Z","closed_at":null},"comments":6,"created_at":"2018-04-24T18:30:53Z","updated_at":"2018-07-11T01:58:20Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/NREL/EnergyPlus/pulls/6728","html_url":"https://github.com/NREL/EnergyPlus/pull/6728","diff_url":"https://github.com/NREL/EnergyPlus/pull/6728.diff","patch_url":"https://github.com/NREL/EnergyPlus/pull/6728.patch"},"body":"Pull request overview\r\n---------------------\r\nThis pull request refactors the Boiler:HotWater code to use a more object oriented approach as well as a substantial cleanup including variable renaming, code restructuring etc. This should result in no diffs.\r\n\r\nThere are some changes beyond the scope of the boiler file:\r\n- DataGlobalConstants - Added PROPANEGAS to types of fuel so they don't need to be hard coded into the boiler file. The original boiler code included several more fuel subtypes (e.g. \"ELEC\" for electricity), since these were not documented in the InputOutputRef, assume it's OK to remove support for them.\r\n- Multiple files - Added additional parameter for EquipFlowCtrl as it is required by many PlantComponents\r\n- InputOutput Ref - Updated docs to simplify/clarify some items\r\nThere are some items which have not been refactored, these include:\r\n- Some variable/function names have not been updated as they are accessed elsewhere or are named consistently across multiple plant components\r\n- Reporting variables are private but are accessed externally, could consider making them public\r\n\r\n### Work Checklist\r\nAdd to this list or remove from it as applicable.  This is a simple templated set of guidelines.\r\n - [x] Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)\r\n - [ ] At least one of the following appropriate labels must be added to this PR to be consumed into the changelog:\r\n   - Defect: This pull request repairs a github defect issue.  The github issue should be referenced in the PR description\r\n   - Refactoring: This pull request includes code changes that don't change the functionality of the program, just perform refactoring\r\n   - NewFeature: This pull request includes code to add a new feature to EnergyPlus\r\n   - Performance: This pull request includes code changes that are directed at improving the runtime performance of EnergyPlus\r\n   - DoNoPublish: This pull request includes changes that shouldn't be included in the changelog\r\n\r\n### Review Checklist\r\nThis will not be exhaustively relevant to every PR.\r\n - [ ] Code style (parentheses padding, variable names)\r\n - [ ] Functional code review (it has to work!)\r\n - [ ] If defect, results of running current develop vs this branch should exhibit the fix\r\n - [ ] CI status: all green or justified\r\n - [ ] Performance: CI Linux results include performance check -- verify this\r\n - [ ] Unit Test(s)\r\n - C++ checks:\r\n   - [ ] Argument types\r\n   - [ ] If any virtual classes, ensure virtual destructor included, other things\r\n - ~~IDD changes:~~\r\n   - [ ] ~~Verify naming conventions and styles, memos and notes and defaults~~\r\n   - [ ] ~~Open windows IDF Editor with modified IDD to check for errors~~\r\n   - [ ] ~~If transition, add rules to spreadsheet~~\r\n   - [ ] ~~If transition, add transition source~~\r\n   - [ ] ~~If transition, update idfs~~\r\n - [ ] ~~If new idf included, locally check the err file and other outputs~~\r\n - [ ] Documentation changes in place\r\n - [ ] Changed docs build successfully\r\n - [ ] ~~ExpandObjects changes?~~\r\n - [ ] If output changes, including tabular output structure, add to output rules file for interfaces\r\n"},"comment":{"url":"https://api.github.com/repos/NREL/EnergyPlus/issues/comments/404020236","html_url":"https://github.com/NREL/EnergyPlus/pull/6728#issuecomment-404020236","issue_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/6728","id":404020236,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNDAyMDIzNg==","user":{"login":"Myoldmopar","id":849824,"node_id":"MDQ6VXNlcjg0OTgyNA==","avatar_url":"https://avatars0.githubusercontent.com/u/849824?v=4","gravatar_id":"","url":"https://api.github.com/users/Myoldmopar","html_url":"https://github.com/Myoldmopar","followers_url":"https://api.github.com/users/Myoldmopar/followers","following_url":"https://api.github.com/users/Myoldmopar/following{/other_user}","gists_url":"https://api.github.com/users/Myoldmopar/gists{/gist_id}","starred_url":"https://api.github.com/users/Myoldmopar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Myoldmopar/subscriptions","organizations_url":"https://api.github.com/users/Myoldmopar/orgs","repos_url":"https://api.github.com/users/Myoldmopar/repos","events_url":"https://api.github.com/users/Myoldmopar/events{/privacy}","received_events_url":"https://api.github.com/users/Myoldmopar/received_events","type":"User","site_admin":false},"created_at":"2018-07-11T01:58:20Z","updated_at":"2018-07-11T01:58:20Z","author_association":"MEMBER","body":"@drewyh we don't post them (though we could potentially in the future...), but you should be able to access them locally if you build both the develop branch and the current branch."}}
{"actor":{"display_login":"Myoldmopar"}}