{"push_id":2514891106,"size":5,"distinct_size":5,"ref":"refs/heads/xdmod8.0","head":"15fb30c3ffe25b44cd16046f50947ff1507f143d","before":"351c83c9cc20c13bb8c0c78c8c54aae56d70898c","commits":[{"sha":"ee899db53801a3543a43e250a77dff356cea13a2","author":{"name":"ryanrath","email":"933c8fe05f99895c0c5a8404b8621c162bcae002@buffalo.edu"},"message":"Update Center Promotion (#509)\n\n* Spacing Updates\r\n\r\n* Spacing Updates\r\n\r\n* Adding integration tests for role delegation behavior\r\n\r\n* Updating role_manager operations and supporting classes\r\n\r\nPreviously User Role Delegation worked as follows:\r\n- A Center Director could delegate the Center Director Role to Center Staff\r\n- A Center Director could demote Center Directors that they had promoted back to\r\n  Center Staff.\r\n\r\nCurrently User Role Delegation works as follows:\r\n- A Center Director can delegate Center Staff to any user \"associated\" with\r\n  their center.\r\n  - \"associated\" means that the user either has a direct relation with the\r\n    center ( via Users.organization_id ) or is mapped to a person that has a\r\n    direct relation with the center ( via Users.person_id -> Persons.id ->\r\n    Persons.organization_id )\r\n- A Center Director can demote a Center Staff \"associated\" with their center by\r\n  revoking the previously granted access to their center. If the user has no\r\n  other centers they are Center Staff of, then the Center Staff acl is removed.\r\n\r\n**NOTE: There are accompanying changes to how Federated Users are created\r\n        that will need to be added to ensure that they are associated with a\r\n        center / organization.**\r\n\r\n* Updating the sql for users eligible for promotion\r\n\r\n- Updated to take into account the correct organization fallback steps i.e.\r\n  - If the user has a user_acl_group_bys record that has a value that is also\r\n    a valid center.\r\n  - If the user is directly related to a valid center ( Users.organization_id )\r\n  - If the user is related to a valid center via their assigned Person.\r\n- Updated the function parameter accordingly ( we now require the user id of the\r\n  person running the query.\r\n\r\n* Updated additional sql queries to take into account center fallback\r\n\r\n- Just needed to add the center fallback queries to these two sql queries.\r\n\r\n* Pre-Change Cleanup\r\n\r\nCleaning up the file stylistically before making any functional changes.\r\n\r\n* Updating ProfileRoleDelegation to handle demotion correctly\r\n\r\nPrior to this commit if a center director demoted a user who was only associated\r\nwith their center via a Center Staff Acl the UI would incorrectly keep the user\r\nin the list of eligible users & if selected would report a center_mismatch.\r\n\r\nThis arose due to the UI not accurately interpreting the back end state.\r\nSpecifically, it is expected that if a user, as described previously, is demoted\r\nthat they would no longer be included in the list of users eligible for\r\npromotion to Center Staff as they are not currently associated with the center.\r\nSo it should not be possible to see them listed let alone select them.\r\n\r\nThese changes now ensure that each time a user is demoted that the list of\r\neligible users is refreshed and if the demoted user is found in the newly\r\nrefreshed list, that user is selected. Else the user selection is cleared and\r\nstatus message reset to it's value upon initial viewing of the promotion ui.\r\n\r\n* Forgot to actually kick off the reload\r\n\r\n* Changes per code review comments by @smgallo\r\n\r\n* Missed a db declaration\r\n\r\n* Additional Changes per convo w/ @smgallo\r\n\r\n* re-adding schema to from clauses\r\n\r\nJust replacing the schemas for a few from clauses so that they're all explicitly\r\ndeclared.","distinct":true,"url":"https://api.github.com/repos/jtpalmer/xdmod/commits/ee899db53801a3543a43e250a77dff356cea13a2"},{"sha":"a4a499cd3af26de48abfcb5aea3f44247b45692a","author":{"name":"Steve Gallo","email":"cce4d2f35a4f840df7c75b36e082c53b4101f159@buffalo.edu"},"message":"Load ETL resource codes as needed to allow for bootstrapping actions","distinct":true,"url":"https://api.github.com/repos/jtpalmer/xdmod/commits/a4a499cd3af26de48abfcb5aea3f44247b45692a"},{"sha":"072bd39145309c2daa314b1493fa4e992446af3a","author":{"name":"Steve Gallo","email":"cce4d2f35a4f840df7c75b36e082c53b4101f159@ccr.buffalo.edu"},"message":"More flexible aggregation period deletes (#525)","distinct":true,"url":"https://api.github.com/repos/jtpalmer/xdmod/commits/072bd39145309c2daa314b1493fa4e992446af3a"},{"sha":"1d043243ff3c83f0c797ac590d00638f9e7f9cc9","author":{"name":"Steve Gallo","email":"cce4d2f35a4f840df7c75b36e082c53b4101f159@ccr.buffalo.edu"},"message":"Merge pull request #526 from smgallo/etl/load-resource-codes-on-demand\n\nLoad ETL resource codes as needed to allow for bootstrapping actions","distinct":true,"url":"https://api.github.com/repos/jtpalmer/xdmod/commits/1d043243ff3c83f0c797ac590d00638f9e7f9cc9"},{"sha":"15fb30c3ffe25b44cd16046f50947ff1507f143d","author":{"name":"ryanrath","email":"933c8fe05f99895c0c5a8404b8621c162bcae002@buffalo.edu"},"message":"Updates to Config for Cloud Metrics (#510)\n\n* Defaulting module value for local configs\r\n\r\nThere are cases when we want to break out configuration data but  not associated\r\nit with a module. Previously this data would not have been included / processed,\r\nbut now if the module of a local config file is not known then `xdmod` is used.\r\n\r\nIn particular this resolves a problem that arose due to the way the Cloud\r\nconfiguration files are organized ( at the time of this commit ). This was\r\npreventing them from being properly interpreted by XDMoD. These changes allows\r\nthese files to be interpreted correctly.\r\n\r\n* Updating expected roles file for ConfigTest\r\n\r\nWhen requesting sections for 'xdmod' we now get all changes that are associated\r\nwith modules that do not have a module.d file. In this case we now retrieve the\r\nstorage realm changes.","distinct":true,"url":"https://api.github.com/repos/jtpalmer/xdmod/commits/15fb30c3ffe25b44cd16046f50947ff1507f143d"}]}
{"actor":{"display_login":"jtpalmer"}}