{"action":"created","comment":{"url":"https://api.github.com/repos/luna/basegl-ui/pulls/comments/196088332","pull_request_review_id":129574655,"id":196088332,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NjA4ODMzMg==","diff_hunk":"@@ -0,0 +1,55 @@\n+import {HasModel}  from \"view/HasModel\"\n+import * as _      from 'underscore'\n+import * as basegl from 'basegl/display/Symbol'\n+\n+\n+export class BasicComponent extends HasModel\n+    __draw: (def) => @withScene (scene) =>\n+        @__element = scene.add def\n+        @__view = basegl.group [@__element]\n+\n+    __undraw: (def) => @withScene (scene) =>\n+        if def?\n+            scene.delete def\n+            @__element = null\n+\n+    redefineRequred: => false\n+\n+    onModelUpdate: =>\n+        if @redefineRequred(@changed) or (not @__def?)","path":"src/view/BasicComponent.coffee","position":19,"original_position":19,"commit_id":"71064d3861c5facbe126e9c4389790a8a556aa6e","original_commit_id":"71064d3861c5facbe126e9c4389790a8a556aa6e","user":{"login":"ljkania","id":7061422,"node_id":"MDQ6VXNlcjcwNjE0MjI=","avatar_url":"https://avatars0.githubusercontent.com/u/7061422?v=4","gravatar_id":"","url":"https://api.github.com/users/ljkania","html_url":"https://github.com/ljkania","followers_url":"https://api.github.com/users/ljkania/followers","following_url":"https://api.github.com/users/ljkania/following{/other_user}","gists_url":"https://api.github.com/users/ljkania/gists{/gist_id}","starred_url":"https://api.github.com/users/ljkania/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ljkania/subscriptions","organizations_url":"https://api.github.com/users/ljkania/orgs","repos_url":"https://api.github.com/users/ljkania/repos","events_url":"https://api.github.com/users/ljkania/events{/privacy}","received_events_url":"https://api.github.com/users/ljkania/received_events","type":"User","site_admin":false},"body":"Change elements order - the second one happens much quicker.","created_at":"2018-06-18T14:01:05Z","updated_at":"2018-06-18T14:13:02Z","html_url":"https://github.com/luna/basegl-ui/pull/9#discussion_r196088332","pull_request_url":"https://api.github.com/repos/luna/basegl-ui/pulls/9","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/luna/basegl-ui/pulls/comments/196088332"},"html":{"href":"https://github.com/luna/basegl-ui/pull/9#discussion_r196088332"},"pull_request":{"href":"https://api.github.com/repos/luna/basegl-ui/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/luna/basegl-ui/pulls/9","id":195502834,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1NTAyODM0","html_url":"https://github.com/luna/basegl-ui/pull/9","diff_url":"https://github.com/luna/basegl-ui/pull/9.diff","patch_url":"https://github.com/luna/basegl-ui/pull/9.patch","issue_url":"https://api.github.com/repos/luna/basegl-ui/issues/9","number":9,"state":"open","locked":false,"title":"Hierarchical components","user":{"login":"pmlodawski","id":5347572,"node_id":"MDQ6VXNlcjUzNDc1NzI=","avatar_url":"https://avatars0.githubusercontent.com/u/5347572?v=4","gravatar_id":"","url":"https://api.github.com/users/pmlodawski","html_url":"https://github.com/pmlodawski","followers_url":"https://api.github.com/users/pmlodawski/followers","following_url":"https://api.github.com/users/pmlodawski/following{/other_user}","gists_url":"https://api.github.com/users/pmlodawski/gists{/gist_id}","starred_url":"https://api.github.com/users/pmlodawski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmlodawski/subscriptions","organizations_url":"https://api.github.com/users/pmlodawski/orgs","repos_url":"https://api.github.com/users/pmlodawski/repos","events_url":"https://api.github.com/users/pmlodawski/events{/privacy}","received_events_url":"https://api.github.com/users/pmlodawski/received_events","type":"User","site_admin":false},"body":"This pull request introduces new approach to create gui components. For now it is implemented only for connections, but it is backward compatible, co we can move more components into that. This also fixes problems solving in #5 ","created_at":"2018-06-18T12:02:39Z","updated_at":"2018-06-18T14:13:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a1707a7afc6221e47901f6ac794c3d49ff528700","assignee":{"login":"pmlodawski","id":5347572,"node_id":"MDQ6VXNlcjUzNDc1NzI=","avatar_url":"https://avatars0.githubusercontent.com/u/5347572?v=4","gravatar_id":"","url":"https://api.github.com/users/pmlodawski","html_url":"https://github.com/pmlodawski","followers_url":"https://api.github.com/users/pmlodawski/followers","following_url":"https://api.github.com/users/pmlodawski/following{/other_user}","gists_url":"https://api.github.com/users/pmlodawski/gists{/gist_id}","starred_url":"https://api.github.com/users/pmlodawski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmlodawski/subscriptions","organizations_url":"https://api.github.com/users/pmlodawski/orgs","repos_url":"https://api.github.com/users/pmlodawski/repos","events_url":"https://api.github.com/users/pmlodawski/events{/privacy}","received_events_url":"https://api.github.com/users/pmlodawski/received_events","type":"User","site_admin":false},"assignees":[{"login":"pmlodawski","id":5347572,"node_id":"MDQ6VXNlcjUzNDc1NzI=","avatar_url":"https://avatars0.githubusercontent.com/u/5347572?v=4","gravatar_id":"","url":"https://api.github.com/users/pmlodawski","html_url":"https://github.com/pmlodawski","followers_url":"https://api.github.com/users/pmlodawski/followers","following_url":"https://api.github.com/users/pmlodawski/following{/other_user}","gists_url":"https://api.github.com/users/pmlodawski/gists{/gist_id}","starred_url":"https://api.github.com/users/pmlodawski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmlodawski/subscriptions","organizations_url":"https://api.github.com/users/pmlodawski/orgs","repos_url":"https://api.github.com/users/pmlodawski/repos","events_url":"https://api.github.com/users/pmlodawski/events{/privacy}","received_events_url":"https://api.github.com/users/pmlodawski/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"kustosz","id":1214109,"node_id":"MDQ6VXNlcjEyMTQxMDk=","avatar_url":"https://avatars2.githubusercontent.com/u/1214109?v=4","gravatar_id":"","url":"https://api.github.com/users/kustosz","html_url":"https://github.com/kustosz","followers_url":"https://api.github.com/users/kustosz/followers","following_url":"https://api.github.com/users/kustosz/following{/other_user}","gists_url":"https://api.github.com/users/kustosz/gists{/gist_id}","starred_url":"https://api.github.com/users/kustosz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kustosz/subscriptions","organizations_url":"https://api.github.com/users/kustosz/orgs","repos_url":"https://api.github.com/users/kustosz/repos","events_url":"https://api.github.com/users/kustosz/events{/privacy}","received_events_url":"https://api.github.com/users/kustosz/received_events","type":"User","site_admin":false},{"login":"wdanilo","id":1623053,"node_id":"MDQ6VXNlcjE2MjMwNTM=","avatar_url":"https://avatars2.githubusercontent.com/u/1623053?v=4","gravatar_id":"","url":"https://api.github.com/users/wdanilo","html_url":"https://github.com/wdanilo","followers_url":"https://api.github.com/users/wdanilo/followers","following_url":"https://api.github.com/users/wdanilo/following{/other_user}","gists_url":"https://api.github.com/users/wdanilo/gists{/gist_id}","starred_url":"https://api.github.com/users/wdanilo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wdanilo/subscriptions","organizations_url":"https://api.github.com/users/wdanilo/orgs","repos_url":"https://api.github.com/users/wdanilo/repos","events_url":"https://api.github.com/users/wdanilo/events{/privacy}","received_events_url":"https://api.github.com/users/wdanilo/received_events","type":"User","site_admin":false},{"login":"piotrMocz","id":3109645,"node_id":"MDQ6VXNlcjMxMDk2NDU=","avatar_url":"https://avatars3.githubusercontent.com/u/3109645?v=4","gravatar_id":"","url":"https://api.github.com/users/piotrMocz","html_url":"https://github.com/piotrMocz","followers_url":"https://api.github.com/users/piotrMocz/followers","following_url":"https://api.github.com/users/piotrMocz/following{/other_user}","gists_url":"https://api.github.com/users/piotrMocz/gists{/gist_id}","starred_url":"https://api.github.com/users/piotrMocz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piotrMocz/subscriptions","organizations_url":"https://api.github.com/users/piotrMocz/orgs","repos_url":"https://api.github.com/users/piotrMocz/repos","events_url":"https://api.github.com/users/piotrMocz/events{/privacy}","received_events_url":"https://api.github.com/users/piotrMocz/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/luna/basegl-ui/pulls/9/commits","review_comments_url":"https://api.github.com/repos/luna/basegl-ui/pulls/9/comments","review_comment_url":"https://api.github.com/repos/luna/basegl-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/luna/basegl-ui/issues/9/comments","statuses_url":"https://api.github.com/repos/luna/basegl-ui/statuses/71064d3861c5facbe126e9c4389790a8a556aa6e","head":{"label":"luna:components","ref":"components","sha":"71064d3861c5facbe126e9c4389790a8a556aa6e","user":{"login":"luna","id":17415943,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NDE1OTQz","avatar_url":"https://avatars0.githubusercontent.com/u/17415943?v=4","gravatar_id":"","url":"https://api.github.com/users/luna","html_url":"https://github.com/luna","followers_url":"https://api.github.com/users/luna/followers","following_url":"https://api.github.com/users/luna/following{/other_user}","gists_url":"https://api.github.com/users/luna/gists{/gist_id}","starred_url":"https://api.github.com/users/luna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luna/subscriptions","organizations_url":"https://api.github.com/users/luna/orgs","repos_url":"https://api.github.com/users/luna/repos","events_url":"https://api.github.com/users/luna/events{/privacy}","received_events_url":"https://api.github.com/users/luna/received_events","type":"Organization","site_admin":false},"repo":{"id":124790721,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQ3OTA3MjE=","name":"basegl-ui","full_name":"luna/basegl-ui","owner":{"login":"luna","id":17415943,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NDE1OTQz","avatar_url":"https://avatars0.githubusercontent.com/u/17415943?v=4","gravatar_id":"","url":"https://api.github.com/users/luna","html_url":"https://github.com/luna","followers_url":"https://api.github.com/users/luna/followers","following_url":"https://api.github.com/users/luna/following{/other_user}","gists_url":"https://api.github.com/users/luna/gists{/gist_id}","starred_url":"https://api.github.com/users/luna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luna/subscriptions","organizations_url":"https://api.github.com/users/luna/orgs","repos_url":"https://api.github.com/users/luna/repos","events_url":"https://api.github.com/users/luna/events{/privacy}","received_events_url":"https://api.github.com/users/luna/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/luna/basegl-ui","description":null,"fork":false,"url":"https://api.github.com/repos/luna/basegl-ui","forks_url":"https://api.github.com/repos/luna/basegl-ui/forks","keys_url":"https://api.github.com/repos/luna/basegl-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/luna/basegl-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/luna/basegl-ui/teams","hooks_url":"https://api.github.com/repos/luna/basegl-ui/hooks","issue_events_url":"https://api.github.com/repos/luna/basegl-ui/issues/events{/number}","events_url":"https://api.github.com/repos/luna/basegl-ui/events","assignees_url":"https://api.github.com/repos/luna/basegl-ui/assignees{/user}","branches_url":"https://api.github.com/repos/luna/basegl-ui/branches{/branch}","tags_url":"https://api.github.com/repos/luna/basegl-ui/tags","blobs_url":"https://api.github.com/repos/luna/basegl-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/luna/basegl-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/luna/basegl-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/luna/basegl-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/luna/basegl-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/luna/basegl-ui/languages","stargazers_url":"https://api.github.com/repos/luna/basegl-ui/stargazers","contributors_url":"https://api.github.com/repos/luna/basegl-ui/contributors","subscribers_url":"https://api.github.com/repos/luna/basegl-ui/subscribers","subscription_url":"https://api.github.com/repos/luna/basegl-ui/subscription","commits_url":"https://api.github.com/repos/luna/basegl-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/luna/basegl-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/luna/basegl-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/luna/basegl-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/luna/basegl-ui/contents/{+path}","compare_url":"https://api.github.com/repos/luna/basegl-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/luna/basegl-ui/merges","archive_url":"https://api.github.com/repos/luna/basegl-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/luna/basegl-ui/downloads","issues_url":"https://api.github.com/repos/luna/basegl-ui/issues{/number}","pulls_url":"https://api.github.com/repos/luna/basegl-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/luna/basegl-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/luna/basegl-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/luna/basegl-ui/labels{/name}","releases_url":"https://api.github.com/repos/luna/basegl-ui/releases{/id}","deployments_url":"https://api.github.com/repos/luna/basegl-ui/deployments","created_at":"2018-03-11T19:26:40Z","updated_at":"2018-06-18T12:12:55Z","pushed_at":"2018-06-18T12:13:41Z","git_url":"git://github.com/luna/basegl-ui.git","ssh_url":"git@github.com:luna/basegl-ui.git","clone_url":"https://github.com/luna/basegl-ui.git","svn_url":"https://github.com/luna/basegl-ui","homepage":null,"size":321,"stargazers_count":1,"watchers_count":1,"language":"CoffeeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":0,"open_issues":2,"watchers":1,"default_branch":"master"}},"base":{"label":"luna:master","ref":"master","sha":"d8dc281013edf7e72cb2aea58b7a1a9eabe6877c","user":{"login":"luna","id":17415943,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NDE1OTQz","avatar_url":"https://avatars0.githubusercontent.com/u/17415943?v=4","gravatar_id":"","url":"https://api.github.com/users/luna","html_url":"https://github.com/luna","followers_url":"https://api.github.com/users/luna/followers","following_url":"https://api.github.com/users/luna/following{/other_user}","gists_url":"https://api.github.com/users/luna/gists{/gist_id}","starred_url":"https://api.github.com/users/luna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luna/subscriptions","organizations_url":"https://api.github.com/users/luna/orgs","repos_url":"https://api.github.com/users/luna/repos","events_url":"https://api.github.com/users/luna/events{/privacy}","received_events_url":"https://api.github.com/users/luna/received_events","type":"Organization","site_admin":false},"repo":{"id":124790721,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQ3OTA3MjE=","name":"basegl-ui","full_name":"luna/basegl-ui","owner":{"login":"luna","id":17415943,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NDE1OTQz","avatar_url":"https://avatars0.githubusercontent.com/u/17415943?v=4","gravatar_id":"","url":"https://api.github.com/users/luna","html_url":"https://github.com/luna","followers_url":"https://api.github.com/users/luna/followers","following_url":"https://api.github.com/users/luna/following{/other_user}","gists_url":"https://api.github.com/users/luna/gists{/gist_id}","starred_url":"https://api.github.com/users/luna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luna/subscriptions","organizations_url":"https://api.github.com/users/luna/orgs","repos_url":"https://api.github.com/users/luna/repos","events_url":"https://api.github.com/users/luna/events{/privacy}","received_events_url":"https://api.github.com/users/luna/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/luna/basegl-ui","description":null,"fork":false,"url":"https://api.github.com/repos/luna/basegl-ui","forks_url":"https://api.github.com/repos/luna/basegl-ui/forks","keys_url":"https://api.github.com/repos/luna/basegl-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/luna/basegl-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/luna/basegl-ui/teams","hooks_url":"https://api.github.com/repos/luna/basegl-ui/hooks","issue_events_url":"https://api.github.com/repos/luna/basegl-ui/issues/events{/number}","events_url":"https://api.github.com/repos/luna/basegl-ui/events","assignees_url":"https://api.github.com/repos/luna/basegl-ui/assignees{/user}","branches_url":"https://api.github.com/repos/luna/basegl-ui/branches{/branch}","tags_url":"https://api.github.com/repos/luna/basegl-ui/tags","blobs_url":"https://api.github.com/repos/luna/basegl-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/luna/basegl-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/luna/basegl-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/luna/basegl-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/luna/basegl-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/luna/basegl-ui/languages","stargazers_url":"https://api.github.com/repos/luna/basegl-ui/stargazers","contributors_url":"https://api.github.com/repos/luna/basegl-ui/contributors","subscribers_url":"https://api.github.com/repos/luna/basegl-ui/subscribers","subscription_url":"https://api.github.com/repos/luna/basegl-ui/subscription","commits_url":"https://api.github.com/repos/luna/basegl-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/luna/basegl-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/luna/basegl-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/luna/basegl-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/luna/basegl-ui/contents/{+path}","compare_url":"https://api.github.com/repos/luna/basegl-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/luna/basegl-ui/merges","archive_url":"https://api.github.com/repos/luna/basegl-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/luna/basegl-ui/downloads","issues_url":"https://api.github.com/repos/luna/basegl-ui/issues{/number}","pulls_url":"https://api.github.com/repos/luna/basegl-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/luna/basegl-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/luna/basegl-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/luna/basegl-ui/labels{/name}","releases_url":"https://api.github.com/repos/luna/basegl-ui/releases{/id}","deployments_url":"https://api.github.com/repos/luna/basegl-ui/deployments","created_at":"2018-03-11T19:26:40Z","updated_at":"2018-06-18T12:12:55Z","pushed_at":"2018-06-18T12:13:41Z","git_url":"git://github.com/luna/basegl-ui.git","ssh_url":"git@github.com:luna/basegl-ui.git","clone_url":"https://github.com/luna/basegl-ui.git","svn_url":"https://github.com/luna/basegl-ui","homepage":null,"size":321,"stargazers_count":1,"watchers_count":1,"language":"CoffeeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":0,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/luna/basegl-ui/pulls/9"},"html":{"href":"https://github.com/luna/basegl-ui/pull/9"},"issue":{"href":"https://api.github.com/repos/luna/basegl-ui/issues/9"},"comments":{"href":"https://api.github.com/repos/luna/basegl-ui/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/luna/basegl-ui/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/luna/basegl-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/luna/basegl-ui/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/luna/basegl-ui/statuses/71064d3861c5facbe126e9c4389790a8a556aa6e"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"ljkania"}}