{"action":"created","comment":{"url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/pulls/comments/214538124","pull_request_review_id":151618354,"id":214538124,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNDUzODEyNA==","diff_hunk":"@@ -61,7 +61,7 @@ TESTSRCS := $(shell find $(TESTDIR) -name '*.cpp')\n TESTOBJS := $(patsubst $(TESTDIR)/%.cpp,$(TESTOBJDIR)/%.o,$(TESTSRCS))\n TESTFOLDERS := $(sort $(dir $(TESTSRCS)))\n TESTLDFLAGS := -L./\n-TESTLIBS := -lgtest -lgtest_main -lpthread -lOP2Utility\n+TESTLIBS := -lgtest -lgtest_main -lpthread -lOP2Utility -lstdc++fs","path":"makefile","position":null,"original_position":5,"commit_id":"64c160b4bc720aaad62a273caa6d45e612bc43cd","original_commit_id":"9582058cd61010c437cb64aea7f2bab0c1917391","user":{"login":"Brett208","id":15183337,"node_id":"MDQ6VXNlcjE1MTgzMzM3","avatar_url":"https://avatars3.githubusercontent.com/u/15183337?v=4","gravatar_id":"","url":"https://api.github.com/users/Brett208","html_url":"https://github.com/Brett208","followers_url":"https://api.github.com/users/Brett208/followers","following_url":"https://api.github.com/users/Brett208/following{/other_user}","gists_url":"https://api.github.com/users/Brett208/gists{/gist_id}","starred_url":"https://api.github.com/users/Brett208/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Brett208/subscriptions","organizations_url":"https://api.github.com/users/Brett208/orgs","repos_url":"https://api.github.com/users/Brett208/repos","events_url":"https://api.github.com/users/Brett208/events{/privacy}","received_events_url":"https://api.github.com/users/Brett208/received_events","type":"User","site_admin":false},"body":"I had not thought about this being a problem. Thank you for catching and fixing.","created_at":"2018-09-02T11:53:39Z","updated_at":"2018-09-02T11:53:39Z","html_url":"https://github.com/OutpostUniverse/OP2Utility/pull/169#discussion_r214538124","pull_request_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/pulls/169","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/OutpostUniverse/OP2Utility/pulls/comments/214538124"},"html":{"href":"https://github.com/OutpostUniverse/OP2Utility/pull/169#discussion_r214538124"},"pull_request":{"href":"https://api.github.com/repos/OutpostUniverse/OP2Utility/pulls/169"}}},"pull_request":{"url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/pulls/169","id":212570343,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyNTcwMzQz","html_url":"https://github.com/OutpostUniverse/OP2Utility/pull/169","diff_url":"https://github.com/OutpostUniverse/OP2Utility/pull/169.diff","patch_url":"https://github.com/OutpostUniverse/OP2Utility/pull/169.patch","issue_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/issues/169","number":169,"state":"open","locked":false,"title":"Add basic map writer tests","user":{"login":"Brett208","id":15183337,"node_id":"MDQ6VXNlcjE1MTgzMzM3","avatar_url":"https://avatars3.githubusercontent.com/u/15183337?v=4","gravatar_id":"","url":"https://api.github.com/users/Brett208","html_url":"https://github.com/Brett208","followers_url":"https://api.github.com/users/Brett208/followers","following_url":"https://api.github.com/users/Brett208/following{/other_user}","gists_url":"https://api.github.com/users/Brett208/gists{/gist_id}","starred_url":"https://api.github.com/users/Brett208/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Brett208/subscriptions","organizations_url":"https://api.github.com/users/Brett208/orgs","repos_url":"https://api.github.com/users/Brett208/repos","events_url":"https://api.github.com/users/Brett208/events{/privacy}","received_events_url":"https://api.github.com/users/Brett208/received_events","type":"User","site_admin":false},"body":"This is my first time using the syntax:\r\n\r\n```sizeof(decltype(buffer)::value_type));```\r\n\r\nWhich is a feature of C++11 as pointed out in the issue #158. I had to append decltype to make it work.\r\n\r\nTo test the memory writer overload, I created a buffer of 1000 char. This was a bit arbitrary. It just needs to big enough that it fails before running out of space in the buffer. It is failing after reading the header and checking the version tag. \r\n\r\nGive me a minute to refactor here.","created_at":"2018-09-02T00:38:32Z","updated_at":"2018-09-02T11:53:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a8ce0eea2b41d0cc71400c27239551a4bc42a82c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/pulls/169/commits","review_comments_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/pulls/169/comments","review_comment_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/issues/169/comments","statuses_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/statuses/64c160b4bc720aaad62a273caa6d45e612bc43cd","head":{"label":"OutpostUniverse:Basic-Map-Writer-Tests","ref":"Basic-Map-Writer-Tests","sha":"64c160b4bc720aaad62a273caa6d45e612bc43cd","user":{"login":"OutpostUniverse","id":22143588,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMTQzNTg4","avatar_url":"https://avatars0.githubusercontent.com/u/22143588?v=4","gravatar_id":"","url":"https://api.github.com/users/OutpostUniverse","html_url":"https://github.com/OutpostUniverse","followers_url":"https://api.github.com/users/OutpostUniverse/followers","following_url":"https://api.github.com/users/OutpostUniverse/following{/other_user}","gists_url":"https://api.github.com/users/OutpostUniverse/gists{/gist_id}","starred_url":"https://api.github.com/users/OutpostUniverse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OutpostUniverse/subscriptions","organizations_url":"https://api.github.com/users/OutpostUniverse/orgs","repos_url":"https://api.github.com/users/OutpostUniverse/repos","events_url":"https://api.github.com/users/OutpostUniverse/events{/privacy}","received_events_url":"https://api.github.com/users/OutpostUniverse/received_events","type":"Organization","site_admin":false},"repo":{"id":102311838,"node_id":"MDEwOlJlcG9zaXRvcnkxMDIzMTE4Mzg=","name":"OP2Utility","full_name":"OutpostUniverse/OP2Utility","owner":{"login":"OutpostUniverse","id":22143588,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMTQzNTg4","avatar_url":"https://avatars0.githubusercontent.com/u/22143588?v=4","gravatar_id":"","url":"https://api.github.com/users/OutpostUniverse","html_url":"https://github.com/OutpostUniverse","followers_url":"https://api.github.com/users/OutpostUniverse/followers","following_url":"https://api.github.com/users/OutpostUniverse/following{/other_user}","gists_url":"https://api.github.com/users/OutpostUniverse/gists{/gist_id}","starred_url":"https://api.github.com/users/OutpostUniverse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OutpostUniverse/subscriptions","organizations_url":"https://api.github.com/users/OutpostUniverse/orgs","repos_url":"https://api.github.com/users/OutpostUniverse/repos","events_url":"https://api.github.com/users/OutpostUniverse/events{/privacy}","received_events_url":"https://api.github.com/users/OutpostUniverse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OutpostUniverse/OP2Utility","description":"C++ library for working with Outpost 2 related files and tasks.","fork":false,"url":"https://api.github.com/repos/OutpostUniverse/OP2Utility","forks_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/forks","keys_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/teams","hooks_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/hooks","issue_events_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/issues/events{/number}","events_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/events","assignees_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/assignees{/user}","branches_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/branches{/branch}","tags_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/tags","blobs_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/git/refs{/sha}","trees_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/statuses/{sha}","languages_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/languages","stargazers_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/stargazers","contributors_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/contributors","subscribers_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/subscribers","subscription_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/subscription","commits_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/commits{/sha}","git_commits_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/git/commits{/sha}","comments_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/comments{/number}","issue_comment_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/issues/comments{/number}","contents_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/contents/{+path}","compare_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/merges","archive_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/downloads","issues_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/issues{/number}","pulls_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/pulls{/number}","milestones_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/milestones{/number}","notifications_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/labels{/name}","releases_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/releases{/id}","deployments_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/deployments","created_at":"2017-09-04T02:46:27Z","updated_at":"2018-09-02T05:50:19Z","pushed_at":"2018-09-02T09:40:56Z","git_url":"git://github.com/OutpostUniverse/OP2Utility.git","ssh_url":"git@github.com:OutpostUniverse/OP2Utility.git","clone_url":"https://github.com/OutpostUniverse/OP2Utility.git","svn_url":"https://github.com/OutpostUniverse/OP2Utility","homepage":"","size":628,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":18,"watchers":1,"default_branch":"master"}},"base":{"label":"OutpostUniverse:master","ref":"master","sha":"53f544432e91c9bdac5ef21925b836d2a9f7aa36","user":{"login":"OutpostUniverse","id":22143588,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMTQzNTg4","avatar_url":"https://avatars0.githubusercontent.com/u/22143588?v=4","gravatar_id":"","url":"https://api.github.com/users/OutpostUniverse","html_url":"https://github.com/OutpostUniverse","followers_url":"https://api.github.com/users/OutpostUniverse/followers","following_url":"https://api.github.com/users/OutpostUniverse/following{/other_user}","gists_url":"https://api.github.com/users/OutpostUniverse/gists{/gist_id}","starred_url":"https://api.github.com/users/OutpostUniverse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OutpostUniverse/subscriptions","organizations_url":"https://api.github.com/users/OutpostUniverse/orgs","repos_url":"https://api.github.com/users/OutpostUniverse/repos","events_url":"https://api.github.com/users/OutpostUniverse/events{/privacy}","received_events_url":"https://api.github.com/users/OutpostUniverse/received_events","type":"Organization","site_admin":false},"repo":{"id":102311838,"node_id":"MDEwOlJlcG9zaXRvcnkxMDIzMTE4Mzg=","name":"OP2Utility","full_name":"OutpostUniverse/OP2Utility","owner":{"login":"OutpostUniverse","id":22143588,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMTQzNTg4","avatar_url":"https://avatars0.githubusercontent.com/u/22143588?v=4","gravatar_id":"","url":"https://api.github.com/users/OutpostUniverse","html_url":"https://github.com/OutpostUniverse","followers_url":"https://api.github.com/users/OutpostUniverse/followers","following_url":"https://api.github.com/users/OutpostUniverse/following{/other_user}","gists_url":"https://api.github.com/users/OutpostUniverse/gists{/gist_id}","starred_url":"https://api.github.com/users/OutpostUniverse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OutpostUniverse/subscriptions","organizations_url":"https://api.github.com/users/OutpostUniverse/orgs","repos_url":"https://api.github.com/users/OutpostUniverse/repos","events_url":"https://api.github.com/users/OutpostUniverse/events{/privacy}","received_events_url":"https://api.github.com/users/OutpostUniverse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OutpostUniverse/OP2Utility","description":"C++ library for working with Outpost 2 related files and tasks.","fork":false,"url":"https://api.github.com/repos/OutpostUniverse/OP2Utility","forks_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/forks","keys_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/teams","hooks_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/hooks","issue_events_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/issues/events{/number}","events_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/events","assignees_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/assignees{/user}","branches_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/branches{/branch}","tags_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/tags","blobs_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/git/refs{/sha}","trees_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/statuses/{sha}","languages_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/languages","stargazers_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/stargazers","contributors_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/contributors","subscribers_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/subscribers","subscription_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/subscription","commits_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/commits{/sha}","git_commits_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/git/commits{/sha}","comments_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/comments{/number}","issue_comment_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/issues/comments{/number}","contents_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/contents/{+path}","compare_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/merges","archive_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/downloads","issues_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/issues{/number}","pulls_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/pulls{/number}","milestones_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/milestones{/number}","notifications_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/labels{/name}","releases_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/releases{/id}","deployments_url":"https://api.github.com/repos/OutpostUniverse/OP2Utility/deployments","created_at":"2017-09-04T02:46:27Z","updated_at":"2018-09-02T05:50:19Z","pushed_at":"2018-09-02T09:40:56Z","git_url":"git://github.com/OutpostUniverse/OP2Utility.git","ssh_url":"git@github.com:OutpostUniverse/OP2Utility.git","clone_url":"https://github.com/OutpostUniverse/OP2Utility.git","svn_url":"https://github.com/OutpostUniverse/OP2Utility","homepage":"","size":628,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":18,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OutpostUniverse/OP2Utility/pulls/169"},"html":{"href":"https://github.com/OutpostUniverse/OP2Utility/pull/169"},"issue":{"href":"https://api.github.com/repos/OutpostUniverse/OP2Utility/issues/169"},"comments":{"href":"https://api.github.com/repos/OutpostUniverse/OP2Utility/issues/169/comments"},"review_comments":{"href":"https://api.github.com/repos/OutpostUniverse/OP2Utility/pulls/169/comments"},"review_comment":{"href":"https://api.github.com/repos/OutpostUniverse/OP2Utility/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OutpostUniverse/OP2Utility/pulls/169/commits"},"statuses":{"href":"https://api.github.com/repos/OutpostUniverse/OP2Utility/statuses/64c160b4bc720aaad62a273caa6d45e612bc43cd"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"Brett208"}}