{"action":"created","comment":{"url":"https://api.github.com/repos/brave/brave-core/pulls/comments/235076142","pull_request_review_id":176859103,"id":235076142,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTA3NjE0Mg==","diff_hunk":"@@ -39,7 +39,9 @@ void RegisterProfilePrefs(user_prefs::PrefRegistrySyncable* registry) {\n   // Default Brave shields\n   registry->RegisterBooleanPref(kHTTPSEVerywhereControlType, true);\n   registry->RegisterBooleanPref(kNoScriptControlType, false);\n+}\n \n+void OverrideDefaultProfilePrefs(user_prefs::PrefRegistrySyncable* registry) {","path":"browser/brave_profile_prefs.cc","position":6,"original_position":6,"commit_id":"c71d8ce274c42f1827b3a60762c73206cc142f44","original_commit_id":"c71d8ce274c42f1827b3a60762c73206cc142f44","user":{"login":"iefremov","id":3109556,"node_id":"MDQ6VXNlcjMxMDk1NTY=","avatar_url":"https://avatars3.githubusercontent.com/u/3109556?v=4","gravatar_id":"","url":"https://api.github.com/users/iefremov","html_url":"https://github.com/iefremov","followers_url":"https://api.github.com/users/iefremov/followers","following_url":"https://api.github.com/users/iefremov/following{/other_user}","gists_url":"https://api.github.com/users/iefremov/gists{/gist_id}","starred_url":"https://api.github.com/users/iefremov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iefremov/subscriptions","organizations_url":"https://api.github.com/users/iefremov/orgs","repos_url":"https://api.github.com/users/iefremov/repos","events_url":"https://api.github.com/users/iefremov/events{/privacy}","received_events_url":"https://api.github.com/users/iefremov/received_events","type":"User","site_admin":false},"body":"We can't set default values for unregistered preferences. The correct way to fix this is to ensure that all preferences we want to override are registered beforehand, but this causes much bigger diff. I think we can return to this issue when the process of enabling chromium tests for Brave starts.","created_at":"2018-11-20T16:31:33Z","updated_at":"2018-11-20T16:31:34Z","html_url":"https://github.com/brave/brave-core/pull/904#discussion_r235076142","pull_request_url":"https://api.github.com/repos/brave/brave-core/pulls/904","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/brave/brave-core/pulls/comments/235076142"},"html":{"href":"https://github.com/brave/brave-core/pull/904#discussion_r235076142"},"pull_request":{"href":"https://api.github.com/repos/brave/brave-core/pulls/904"}},"in_reply_to_id":235022183},"pull_request":{"url":"https://api.github.com/repos/brave/brave-core/pulls/904","id":230679138,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwNjc5MTM4","html_url":"https://github.com/brave/brave-core/pull/904","diff_url":"https://github.com/brave/brave-core/pull/904.diff","patch_url":"https://github.com/brave/brave-core/pull/904.patch","issue_url":"https://api.github.com/repos/brave/brave-core/issues/904","number":904,"state":"open","locked":false,"title":"Make BrowserWithTestWindowTest works in brave_unit_tests","user":{"login":"simonhong","id":6786187,"node_id":"MDQ6VXNlcjY3ODYxODc=","avatar_url":"https://avatars3.githubusercontent.com/u/6786187?v=4","gravatar_id":"","url":"https://api.github.com/users/simonhong","html_url":"https://github.com/simonhong","followers_url":"https://api.github.com/users/simonhong/followers","following_url":"https://api.github.com/users/simonhong/following{/other_user}","gists_url":"https://api.github.com/users/simonhong/gists{/gist_id}","starred_url":"https://api.github.com/users/simonhong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonhong/subscriptions","organizations_url":"https://api.github.com/users/simonhong/orgs","repos_url":"https://api.github.com/users/simonhong/repos","events_url":"https://api.github.com/users/simonhong/events{/privacy}","received_events_url":"https://api.github.com/users/simonhong/received_events","type":"User","site_admin":false},"body":"Fix https://github.com/brave/brave-browser/issues/2125\r\n\r\n* register our prefs to testing pref service\r\n* add missing dependency to RewardsServiceFactory\r\n\r\n## Submitter Checklist:\r\n\r\n- [x] Submitted a [ticket](https://github.com/brave/brave-browser/issues) for my issue if one did not already exist.\r\n- [x] Used Github [auto-closing keywords](https://help.github.com/articles/closing-issues-via-commit-messages/) in the commit message.\r\n- [x] Added/updated tests for this change (for new code or code which already has tests).\r\n- Verified that these changes build without errors on\r\n  - [ ] Windows\r\n  - [x] macOS\r\n  - [ ] Linux\r\n- Verified that these changes pass automated tests (`npm test brave_unit_tests && npm test brave_browser_tests`) on\r\n  - [ ] Windows\r\n  - [x] macOS\r\n  - [ ] Linux\r\n- [ ] Ran `git rebase master` (if needed).\r\n- [ ] Ran `git rebase -i` to squash commits (if needed).\r\n- [x] Tagged reviewers and labelled the pull request as needed.\r\n- [ ] Request a security/privacy review as needed.\r\n- [x] Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone\r\n\r\n## Test Plan:\r\n`yarn test brave_unit_tests --filter=BrowserWithTestWindowTest.BasicTest`\r\n\r\n## Reviewer Checklist:\r\n\r\n- [ ] New files have MPL-2.0 license header.\r\n- [ ] Request a security/privacy review as needed.\r\n- [ ] Adequate test coverage exists to prevent regressions \r\n- [ ] Verify test plan is specified in PR before merging to source","created_at":"2018-11-14T01:15:01Z","updated_at":"2018-11-20T16:31:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6b3c1917d7d96b940d6df93dbe02674437824802","assignee":{"login":"simonhong","id":6786187,"node_id":"MDQ6VXNlcjY3ODYxODc=","avatar_url":"https://avatars3.githubusercontent.com/u/6786187?v=4","gravatar_id":"","url":"https://api.github.com/users/simonhong","html_url":"https://github.com/simonhong","followers_url":"https://api.github.com/users/simonhong/followers","following_url":"https://api.github.com/users/simonhong/following{/other_user}","gists_url":"https://api.github.com/users/simonhong/gists{/gist_id}","starred_url":"https://api.github.com/users/simonhong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonhong/subscriptions","organizations_url":"https://api.github.com/users/simonhong/orgs","repos_url":"https://api.github.com/users/simonhong/repos","events_url":"https://api.github.com/users/simonhong/events{/privacy}","received_events_url":"https://api.github.com/users/simonhong/received_events","type":"User","site_admin":false},"assignees":[{"login":"simonhong","id":6786187,"node_id":"MDQ6VXNlcjY3ODYxODc=","avatar_url":"https://avatars3.githubusercontent.com/u/6786187?v=4","gravatar_id":"","url":"https://api.github.com/users/simonhong","html_url":"https://github.com/simonhong","followers_url":"https://api.github.com/users/simonhong/followers","following_url":"https://api.github.com/users/simonhong/following{/other_user}","gists_url":"https://api.github.com/users/simonhong/gists{/gist_id}","starred_url":"https://api.github.com/users/simonhong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonhong/subscriptions","organizations_url":"https://api.github.com/users/simonhong/orgs","repos_url":"https://api.github.com/users/simonhong/repos","events_url":"https://api.github.com/users/simonhong/events{/privacy}","received_events_url":"https://api.github.com/users/simonhong/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"bbondy","id":831718,"node_id":"MDQ6VXNlcjgzMTcxOA==","avatar_url":"https://avatars2.githubusercontent.com/u/831718?v=4","gravatar_id":"","url":"https://api.github.com/users/bbondy","html_url":"https://github.com/bbondy","followers_url":"https://api.github.com/users/bbondy/followers","following_url":"https://api.github.com/users/bbondy/following{/other_user}","gists_url":"https://api.github.com/users/bbondy/gists{/gist_id}","starred_url":"https://api.github.com/users/bbondy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbondy/subscriptions","organizations_url":"https://api.github.com/users/bbondy/orgs","repos_url":"https://api.github.com/users/bbondy/repos","events_url":"https://api.github.com/users/bbondy/events{/privacy}","received_events_url":"https://api.github.com/users/bbondy/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/brave/brave-core/pulls/904/commits","review_comments_url":"https://api.github.com/repos/brave/brave-core/pulls/904/comments","review_comment_url":"https://api.github.com/repos/brave/brave-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/brave/brave-core/issues/904/comments","statuses_url":"https://api.github.com/repos/brave/brave-core/statuses/c71d8ce274c42f1827b3a60762c73206cc142f44","head":{"label":"brave:enable_BrowserWithTestWindowTest","ref":"enable_BrowserWithTestWindowTest","sha":"c71d8ce274c42f1827b3a60762c73206cc142f44","user":{"login":"brave","id":12301619,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMzAxNjE5","avatar_url":"https://avatars1.githubusercontent.com/u/12301619?v=4","gravatar_id":"","url":"https://api.github.com/users/brave","html_url":"https://github.com/brave","followers_url":"https://api.github.com/users/brave/followers","following_url":"https://api.github.com/users/brave/following{/other_user}","gists_url":"https://api.github.com/users/brave/gists{/gist_id}","starred_url":"https://api.github.com/users/brave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brave/subscriptions","organizations_url":"https://api.github.com/users/brave/orgs","repos_url":"https://api.github.com/users/brave/repos","events_url":"https://api.github.com/users/brave/events{/privacy}","received_events_url":"https://api.github.com/users/brave/received_events","type":"Organization","site_admin":false},"repo":{"id":110198384,"node_id":"MDEwOlJlcG9zaXRvcnkxMTAxOTgzODQ=","name":"brave-core","full_name":"brave/brave-core","private":false,"owner":{"login":"brave","id":12301619,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMzAxNjE5","avatar_url":"https://avatars1.githubusercontent.com/u/12301619?v=4","gravatar_id":"","url":"https://api.github.com/users/brave","html_url":"https://github.com/brave","followers_url":"https://api.github.com/users/brave/followers","following_url":"https://api.github.com/users/brave/following{/other_user}","gists_url":"https://api.github.com/users/brave/gists{/gist_id}","starred_url":"https://api.github.com/users/brave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brave/subscriptions","organizations_url":"https://api.github.com/users/brave/orgs","repos_url":"https://api.github.com/users/brave/repos","events_url":"https://api.github.com/users/brave/events{/privacy}","received_events_url":"https://api.github.com/users/brave/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/brave/brave-core","description":"Core engine for the Brave browser for macOS, Windows, Linux, and eventually Android. For the issue log, please see https://github.com/brave/brave-browser","fork":false,"url":"https://api.github.com/repos/brave/brave-core","forks_url":"https://api.github.com/repos/brave/brave-core/forks","keys_url":"https://api.github.com/repos/brave/brave-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brave/brave-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brave/brave-core/teams","hooks_url":"https://api.github.com/repos/brave/brave-core/hooks","issue_events_url":"https://api.github.com/repos/brave/brave-core/issues/events{/number}","events_url":"https://api.github.com/repos/brave/brave-core/events","assignees_url":"https://api.github.com/repos/brave/brave-core/assignees{/user}","branches_url":"https://api.github.com/repos/brave/brave-core/branches{/branch}","tags_url":"https://api.github.com/repos/brave/brave-core/tags","blobs_url":"https://api.github.com/repos/brave/brave-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brave/brave-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brave/brave-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/brave/brave-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brave/brave-core/statuses/{sha}","languages_url":"https://api.github.com/repos/brave/brave-core/languages","stargazers_url":"https://api.github.com/repos/brave/brave-core/stargazers","contributors_url":"https://api.github.com/repos/brave/brave-core/contributors","subscribers_url":"https://api.github.com/repos/brave/brave-core/subscribers","subscription_url":"https://api.github.com/repos/brave/brave-core/subscription","commits_url":"https://api.github.com/repos/brave/brave-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/brave/brave-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/brave/brave-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/brave/brave-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/brave/brave-core/contents/{+path}","compare_url":"https://api.github.com/repos/brave/brave-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brave/brave-core/merges","archive_url":"https://api.github.com/repos/brave/brave-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brave/brave-core/downloads","issues_url":"https://api.github.com/repos/brave/brave-core/issues{/number}","pulls_url":"https://api.github.com/repos/brave/brave-core/pulls{/number}","milestones_url":"https://api.github.com/repos/brave/brave-core/milestones{/number}","notifications_url":"https://api.github.com/repos/brave/brave-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brave/brave-core/labels{/name}","releases_url":"https://api.github.com/repos/brave/brave-core/releases{/id}","deployments_url":"https://api.github.com/repos/brave/brave-core/deployments","created_at":"2017-11-10T03:33:30Z","updated_at":"2018-11-20T16:01:48Z","pushed_at":"2018-11-20T16:05:43Z","git_url":"git://github.com/brave/brave-core.git","ssh_url":"git@github.com:brave/brave-core.git","clone_url":"https://github.com/brave/brave-core.git","svn_url":"https://github.com/brave/brave-core","homepage":"","size":60682,"stargazers_count":207,"watchers_count":207,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":51,"mirror_url":null,"archived":false,"open_issues_count":28,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":51,"open_issues":28,"watchers":207,"default_branch":"master"}},"base":{"label":"brave:master","ref":"master","sha":"92e94245e60b12bb19db27bd863c37fa409392a6","user":{"login":"brave","id":12301619,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMzAxNjE5","avatar_url":"https://avatars1.githubusercontent.com/u/12301619?v=4","gravatar_id":"","url":"https://api.github.com/users/brave","html_url":"https://github.com/brave","followers_url":"https://api.github.com/users/brave/followers","following_url":"https://api.github.com/users/brave/following{/other_user}","gists_url":"https://api.github.com/users/brave/gists{/gist_id}","starred_url":"https://api.github.com/users/brave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brave/subscriptions","organizations_url":"https://api.github.com/users/brave/orgs","repos_url":"https://api.github.com/users/brave/repos","events_url":"https://api.github.com/users/brave/events{/privacy}","received_events_url":"https://api.github.com/users/brave/received_events","type":"Organization","site_admin":false},"repo":{"id":110198384,"node_id":"MDEwOlJlcG9zaXRvcnkxMTAxOTgzODQ=","name":"brave-core","full_name":"brave/brave-core","private":false,"owner":{"login":"brave","id":12301619,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMzAxNjE5","avatar_url":"https://avatars1.githubusercontent.com/u/12301619?v=4","gravatar_id":"","url":"https://api.github.com/users/brave","html_url":"https://github.com/brave","followers_url":"https://api.github.com/users/brave/followers","following_url":"https://api.github.com/users/brave/following{/other_user}","gists_url":"https://api.github.com/users/brave/gists{/gist_id}","starred_url":"https://api.github.com/users/brave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brave/subscriptions","organizations_url":"https://api.github.com/users/brave/orgs","repos_url":"https://api.github.com/users/brave/repos","events_url":"https://api.github.com/users/brave/events{/privacy}","received_events_url":"https://api.github.com/users/brave/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/brave/brave-core","description":"Core engine for the Brave browser for macOS, Windows, Linux, and eventually Android. For the issue log, please see https://github.com/brave/brave-browser","fork":false,"url":"https://api.github.com/repos/brave/brave-core","forks_url":"https://api.github.com/repos/brave/brave-core/forks","keys_url":"https://api.github.com/repos/brave/brave-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brave/brave-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brave/brave-core/teams","hooks_url":"https://api.github.com/repos/brave/brave-core/hooks","issue_events_url":"https://api.github.com/repos/brave/brave-core/issues/events{/number}","events_url":"https://api.github.com/repos/brave/brave-core/events","assignees_url":"https://api.github.com/repos/brave/brave-core/assignees{/user}","branches_url":"https://api.github.com/repos/brave/brave-core/branches{/branch}","tags_url":"https://api.github.com/repos/brave/brave-core/tags","blobs_url":"https://api.github.com/repos/brave/brave-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brave/brave-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brave/brave-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/brave/brave-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brave/brave-core/statuses/{sha}","languages_url":"https://api.github.com/repos/brave/brave-core/languages","stargazers_url":"https://api.github.com/repos/brave/brave-core/stargazers","contributors_url":"https://api.github.com/repos/brave/brave-core/contributors","subscribers_url":"https://api.github.com/repos/brave/brave-core/subscribers","subscription_url":"https://api.github.com/repos/brave/brave-core/subscription","commits_url":"https://api.github.com/repos/brave/brave-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/brave/brave-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/brave/brave-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/brave/brave-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/brave/brave-core/contents/{+path}","compare_url":"https://api.github.com/repos/brave/brave-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brave/brave-core/merges","archive_url":"https://api.github.com/repos/brave/brave-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brave/brave-core/downloads","issues_url":"https://api.github.com/repos/brave/brave-core/issues{/number}","pulls_url":"https://api.github.com/repos/brave/brave-core/pulls{/number}","milestones_url":"https://api.github.com/repos/brave/brave-core/milestones{/number}","notifications_url":"https://api.github.com/repos/brave/brave-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brave/brave-core/labels{/name}","releases_url":"https://api.github.com/repos/brave/brave-core/releases{/id}","deployments_url":"https://api.github.com/repos/brave/brave-core/deployments","created_at":"2017-11-10T03:33:30Z","updated_at":"2018-11-20T16:01:48Z","pushed_at":"2018-11-20T16:05:43Z","git_url":"git://github.com/brave/brave-core.git","ssh_url":"git@github.com:brave/brave-core.git","clone_url":"https://github.com/brave/brave-core.git","svn_url":"https://github.com/brave/brave-core","homepage":"","size":60682,"stargazers_count":207,"watchers_count":207,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":51,"mirror_url":null,"archived":false,"open_issues_count":28,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":51,"open_issues":28,"watchers":207,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/brave/brave-core/pulls/904"},"html":{"href":"https://github.com/brave/brave-core/pull/904"},"issue":{"href":"https://api.github.com/repos/brave/brave-core/issues/904"},"comments":{"href":"https://api.github.com/repos/brave/brave-core/issues/904/comments"},"review_comments":{"href":"https://api.github.com/repos/brave/brave-core/pulls/904/comments"},"review_comment":{"href":"https://api.github.com/repos/brave/brave-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/brave/brave-core/pulls/904/commits"},"statuses":{"href":"https://api.github.com/repos/brave/brave-core/statuses/c71d8ce274c42f1827b3a60762c73206cc142f44"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"iefremov"}}