{"action":"created","comment":{"url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments/230334755","pull_request_review_id":171051107,"id":230334755,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDMzNDc1NQ==","diff_hunk":"@@ -2343,7 +2343,8 @@ bool thread_nd_service_anycast_address_mapping_from_network_data(thread_network_\n         }\n         ns_list_foreach(thread_network_data_service_server_entry_t, curServiceServer, &curService->server_list) {\n             *rlocAddress = curServiceServer->router_id;\n-            return true;\n+            if(NULL != rlocAddress)","path":"features/nanostack/sal-stack-nanostack/source/6LoWPAN/Thread/thread_network_data_storage.c","position":5,"original_position":5,"commit_id":"e29b9baa7005c0f3e7c21f7b296fadd456cefef8","original_commit_id":"e29b9baa7005c0f3e7c21f7b296fadd456cefef8","user":{"login":"SeppoTakalo","id":3104794,"node_id":"MDQ6VXNlcjMxMDQ3OTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/3104794?v=4","gravatar_id":"","url":"https://api.github.com/users/SeppoTakalo","html_url":"https://github.com/SeppoTakalo","followers_url":"https://api.github.com/users/SeppoTakalo/followers","following_url":"https://api.github.com/users/SeppoTakalo/following{/other_user}","gists_url":"https://api.github.com/users/SeppoTakalo/gists{/gist_id}","starred_url":"https://api.github.com/users/SeppoTakalo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SeppoTakalo/subscriptions","organizations_url":"https://api.github.com/users/SeppoTakalo/orgs","repos_url":"https://api.github.com/users/SeppoTakalo/repos","events_url":"https://api.github.com/users/SeppoTakalo/events{/privacy}","received_events_url":"https://api.github.com/users/SeppoTakalo/received_events","type":"User","site_admin":false},"body":"This change should be removed, Mbed OS contains only copy of Nanostack, the development is happening in the master repository.","created_at":"2018-11-02T10:50:37Z","updated_at":"2018-11-02T10:51:34Z","html_url":"https://github.com/ARMmbed/mbed-os/pull/8625#discussion_r230334755","pull_request_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/8625","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments/230334755"},"html":{"href":"https://github.com/ARMmbed/mbed-os/pull/8625#discussion_r230334755"},"pull_request":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/8625"}},"in_reply_to_id":230292764},"pull_request":{"url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/8625","id":227778568,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3Nzc4NTY4","html_url":"https://github.com/ARMmbed/mbed-os/pull/8625","diff_url":"https://github.com/ARMmbed/mbed-os/pull/8625.diff","patch_url":"https://github.com/ARMmbed/mbed-os/pull/8625.patch","issue_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/8625","number":8625,"state":"open","locked":false,"title":"Fixes for code analysis warnings","user":{"login":"SenRamakri","id":31017510,"node_id":"MDQ6VXNlcjMxMDE3NTEw","avatar_url":"https://avatars0.githubusercontent.com/u/31017510?v=4","gravatar_id":"","url":"https://api.github.com/users/SenRamakri","html_url":"https://github.com/SenRamakri","followers_url":"https://api.github.com/users/SenRamakri/followers","following_url":"https://api.github.com/users/SenRamakri/following{/other_user}","gists_url":"https://api.github.com/users/SenRamakri/gists{/gist_id}","starred_url":"https://api.github.com/users/SenRamakri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SenRamakri/subscriptions","organizations_url":"https://api.github.com/users/SenRamakri/orgs","repos_url":"https://api.github.com/users/SenRamakri/repos","events_url":"https://api.github.com/users/SenRamakri/events{/privacy}","received_events_url":"https://api.github.com/users/SenRamakri/received_events","type":"User","site_admin":false},"body":"### Description\r\nFixes for code analysis warnings raised from PVS studio - See ARMmbed#8517\r\n\r\n### Pull request type\r\n    [x] Fix\r\n    [ ] Refactor\r\n    [ ] Target update\r\n    [ ] Functionality change\r\n    [ ] Docs update\r\n    [ ] Test update\r\n    [ ] Breaking change\r\n\r\n","created_at":"2018-11-01T22:25:57Z","updated_at":"2018-11-02T10:51:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"adcdb57ad8a027f928c57d03fa904dbe077c7a0c","assignee":null,"assignees":[],"requested_reviewers":[{"login":"dannybenor","id":8297560,"node_id":"MDQ6VXNlcjgyOTc1NjA=","avatar_url":"https://avatars3.githubusercontent.com/u/8297560?v=4","gravatar_id":"","url":"https://api.github.com/users/dannybenor","html_url":"https://github.com/dannybenor","followers_url":"https://api.github.com/users/dannybenor/followers","following_url":"https://api.github.com/users/dannybenor/following{/other_user}","gists_url":"https://api.github.com/users/dannybenor/gists{/gist_id}","starred_url":"https://api.github.com/users/dannybenor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dannybenor/subscriptions","organizations_url":"https://api.github.com/users/dannybenor/orgs","repos_url":"https://api.github.com/users/dannybenor/repos","events_url":"https://api.github.com/users/dannybenor/events{/privacy}","received_events_url":"https://api.github.com/users/dannybenor/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":147112891,"node_id":"MDU6TGFiZWwxNDcxMTI4OTE=","url":"https://api.github.com/repos/ARMmbed/mbed-os/labels/needs:%20review","name":"needs: review","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/8625/commits","review_comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/8625/comments","review_comment_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/8625/comments","statuses_url":"https://api.github.com/repos/ARMmbed/mbed-os/statuses/e29b9baa7005c0f3e7c21f7b296fadd456cefef8","head":{"label":"SenRamakri:sen_CodeAnalysisFixes","ref":"sen_CodeAnalysisFixes","sha":"e29b9baa7005c0f3e7c21f7b296fadd456cefef8","user":{"login":"SenRamakri","id":31017510,"node_id":"MDQ6VXNlcjMxMDE3NTEw","avatar_url":"https://avatars0.githubusercontent.com/u/31017510?v=4","gravatar_id":"","url":"https://api.github.com/users/SenRamakri","html_url":"https://github.com/SenRamakri","followers_url":"https://api.github.com/users/SenRamakri/followers","following_url":"https://api.github.com/users/SenRamakri/following{/other_user}","gists_url":"https://api.github.com/users/SenRamakri/gists{/gist_id}","starred_url":"https://api.github.com/users/SenRamakri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SenRamakri/subscriptions","organizations_url":"https://api.github.com/users/SenRamakri/orgs","repos_url":"https://api.github.com/users/SenRamakri/repos","events_url":"https://api.github.com/users/SenRamakri/events{/privacy}","received_events_url":"https://api.github.com/users/SenRamakri/received_events","type":"User","site_admin":false},"repo":{"id":100415897,"node_id":"MDEwOlJlcG9zaXRvcnkxMDA0MTU4OTc=","name":"mbed-os","full_name":"SenRamakri/mbed-os","private":false,"owner":{"login":"SenRamakri","id":31017510,"node_id":"MDQ6VXNlcjMxMDE3NTEw","avatar_url":"https://avatars0.githubusercontent.com/u/31017510?v=4","gravatar_id":"","url":"https://api.github.com/users/SenRamakri","html_url":"https://github.com/SenRamakri","followers_url":"https://api.github.com/users/SenRamakri/followers","following_url":"https://api.github.com/users/SenRamakri/following{/other_user}","gists_url":"https://api.github.com/users/SenRamakri/gists{/gist_id}","starred_url":"https://api.github.com/users/SenRamakri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SenRamakri/subscriptions","organizations_url":"https://api.github.com/users/SenRamakri/orgs","repos_url":"https://api.github.com/users/SenRamakri/repos","events_url":"https://api.github.com/users/SenRamakri/events{/privacy}","received_events_url":"https://api.github.com/users/SenRamakri/received_events","type":"User","site_admin":false},"html_url":"https://github.com/SenRamakri/mbed-os","description":"ARM mbed OS is a platform operating system designed for the internet of things","fork":true,"url":"https://api.github.com/repos/SenRamakri/mbed-os","forks_url":"https://api.github.com/repos/SenRamakri/mbed-os/forks","keys_url":"https://api.github.com/repos/SenRamakri/mbed-os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SenRamakri/mbed-os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SenRamakri/mbed-os/teams","hooks_url":"https://api.github.com/repos/SenRamakri/mbed-os/hooks","issue_events_url":"https://api.github.com/repos/SenRamakri/mbed-os/issues/events{/number}","events_url":"https://api.github.com/repos/SenRamakri/mbed-os/events","assignees_url":"https://api.github.com/repos/SenRamakri/mbed-os/assignees{/user}","branches_url":"https://api.github.com/repos/SenRamakri/mbed-os/branches{/branch}","tags_url":"https://api.github.com/repos/SenRamakri/mbed-os/tags","blobs_url":"https://api.github.com/repos/SenRamakri/mbed-os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SenRamakri/mbed-os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SenRamakri/mbed-os/git/refs{/sha}","trees_url":"https://api.github.com/repos/SenRamakri/mbed-os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SenRamakri/mbed-os/statuses/{sha}","languages_url":"https://api.github.com/repos/SenRamakri/mbed-os/languages","stargazers_url":"https://api.github.com/repos/SenRamakri/mbed-os/stargazers","contributors_url":"https://api.github.com/repos/SenRamakri/mbed-os/contributors","subscribers_url":"https://api.github.com/repos/SenRamakri/mbed-os/subscribers","subscription_url":"https://api.github.com/repos/SenRamakri/mbed-os/subscription","commits_url":"https://api.github.com/repos/SenRamakri/mbed-os/commits{/sha}","git_commits_url":"https://api.github.com/repos/SenRamakri/mbed-os/git/commits{/sha}","comments_url":"https://api.github.com/repos/SenRamakri/mbed-os/comments{/number}","issue_comment_url":"https://api.github.com/repos/SenRamakri/mbed-os/issues/comments{/number}","contents_url":"https://api.github.com/repos/SenRamakri/mbed-os/contents/{+path}","compare_url":"https://api.github.com/repos/SenRamakri/mbed-os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SenRamakri/mbed-os/merges","archive_url":"https://api.github.com/repos/SenRamakri/mbed-os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SenRamakri/mbed-os/downloads","issues_url":"https://api.github.com/repos/SenRamakri/mbed-os/issues{/number}","pulls_url":"https://api.github.com/repos/SenRamakri/mbed-os/pulls{/number}","milestones_url":"https://api.github.com/repos/SenRamakri/mbed-os/milestones{/number}","notifications_url":"https://api.github.com/repos/SenRamakri/mbed-os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SenRamakri/mbed-os/labels{/name}","releases_url":"https://api.github.com/repos/SenRamakri/mbed-os/releases{/id}","deployments_url":"https://api.github.com/repos/SenRamakri/mbed-os/deployments","created_at":"2017-08-15T20:16:33Z","updated_at":"2017-08-15T20:18:43Z","pushed_at":"2018-11-01T22:22:43Z","git_url":"git://github.com/SenRamakri/mbed-os.git","ssh_url":"git@github.com:SenRamakri/mbed-os.git","clone_url":"https://github.com/SenRamakri/mbed-os.git","svn_url":"https://github.com/SenRamakri/mbed-os","homepage":"https://mbed.com","size":232371,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ARMmbed:master","ref":"master","sha":"430fb3e7ba267c61852fd88e431d8249fc7984cd","user":{"login":"ARMmbed","id":8916057,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg5MTYwNTc=","avatar_url":"https://avatars3.githubusercontent.com/u/8916057?v=4","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"repo":{"id":8270972,"node_id":"MDEwOlJlcG9zaXRvcnk4MjcwOTcy","name":"mbed-os","full_name":"ARMmbed/mbed-os","private":false,"owner":{"login":"ARMmbed","id":8916057,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg5MTYwNTc=","avatar_url":"https://avatars3.githubusercontent.com/u/8916057?v=4","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ARMmbed/mbed-os","description":"Arm Mbed OS is a platform operating system designed for the internet of things","fork":false,"url":"https://api.github.com/repos/ARMmbed/mbed-os","forks_url":"https://api.github.com/repos/ARMmbed/mbed-os/forks","keys_url":"https://api.github.com/repos/ARMmbed/mbed-os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ARMmbed/mbed-os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ARMmbed/mbed-os/teams","hooks_url":"https://api.github.com/repos/ARMmbed/mbed-os/hooks","issue_events_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/events{/number}","events_url":"https://api.github.com/repos/ARMmbed/mbed-os/events","assignees_url":"https://api.github.com/repos/ARMmbed/mbed-os/assignees{/user}","branches_url":"https://api.github.com/repos/ARMmbed/mbed-os/branches{/branch}","tags_url":"https://api.github.com/repos/ARMmbed/mbed-os/tags","blobs_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/refs{/sha}","trees_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ARMmbed/mbed-os/statuses/{sha}","languages_url":"https://api.github.com/repos/ARMmbed/mbed-os/languages","stargazers_url":"https://api.github.com/repos/ARMmbed/mbed-os/stargazers","contributors_url":"https://api.github.com/repos/ARMmbed/mbed-os/contributors","subscribers_url":"https://api.github.com/repos/ARMmbed/mbed-os/subscribers","subscription_url":"https://api.github.com/repos/ARMmbed/mbed-os/subscription","commits_url":"https://api.github.com/repos/ARMmbed/mbed-os/commits{/sha}","git_commits_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/commits{/sha}","comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/comments{/number}","issue_comment_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/comments{/number}","contents_url":"https://api.github.com/repos/ARMmbed/mbed-os/contents/{+path}","compare_url":"https://api.github.com/repos/ARMmbed/mbed-os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ARMmbed/mbed-os/merges","archive_url":"https://api.github.com/repos/ARMmbed/mbed-os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ARMmbed/mbed-os/downloads","issues_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues{/number}","pulls_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls{/number}","milestones_url":"https://api.github.com/repos/ARMmbed/mbed-os/milestones{/number}","notifications_url":"https://api.github.com/repos/ARMmbed/mbed-os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ARMmbed/mbed-os/labels{/name}","releases_url":"https://api.github.com/repos/ARMmbed/mbed-os/releases{/id}","deployments_url":"https://api.github.com/repos/ARMmbed/mbed-os/deployments","created_at":"2013-02-18T15:23:11Z","updated_at":"2018-11-02T05:14:29Z","pushed_at":"2018-11-02T06:38:33Z","git_url":"git://github.com/ARMmbed/mbed-os.git","ssh_url":"git@github.com:ARMmbed/mbed-os.git","clone_url":"https://github.com/ARMmbed/mbed-os.git","svn_url":"https://github.com/ARMmbed/mbed-os","homepage":"https://mbed.com","size":234077,"stargazers_count":2023,"watchers_count":2023,"language":"C","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1655,"mirror_url":null,"archived":false,"open_issues_count":399,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1655,"open_issues":399,"watchers":2023,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/8625"},"html":{"href":"https://github.com/ARMmbed/mbed-os/pull/8625"},"issue":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/issues/8625"},"comments":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/issues/8625/comments"},"review_comments":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/8625/comments"},"review_comment":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/8625/commits"},"statuses":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/statuses/e29b9baa7005c0f3e7c21f7b296fadd456cefef8"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"SeppoTakalo"}}