{"action":"created","issue":{"url":"https://api.github.com/repos/everypolitician/commons-builder/issues/13","repository_url":"https://api.github.com/repos/everypolitician/commons-builder","labels_url":"https://api.github.com/repos/everypolitician/commons-builder/issues/13/labels{/name}","comments_url":"https://api.github.com/repos/everypolitician/commons-builder/issues/13/comments","events_url":"https://api.github.com/repos/everypolitician/commons-builder/issues/13/events","html_url":"https://github.com/everypolitician/commons-builder/pull/13","id":301590377,"number":13,"title":"Generate legislative/index.json [WiP]","user":{"login":"alexsdutton","id":238690,"avatar_url":"https://avatars0.githubusercontent.com/u/238690?v=4","gravatar_id":"","url":"https://api.github.com/users/alexsdutton","html_url":"https://github.com/alexsdutton","followers_url":"https://api.github.com/users/alexsdutton/followers","following_url":"https://api.github.com/users/alexsdutton/following{/other_user}","gists_url":"https://api.github.com/users/alexsdutton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexsdutton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexsdutton/subscriptions","organizations_url":"https://api.github.com/users/alexsdutton/orgs","repos_url":"https://api.github.com/users/alexsdutton/repos","events_url":"https://api.github.com/users/alexsdutton/events{/privacy}","received_events_url":"https://api.github.com/users/alexsdutton/received_events","type":"User","site_admin":false},"labels":[{"id":827630829,"url":"https://api.github.com/repos/everypolitician/commons-builder/labels/enhancement","name":"enhancement","color":"a2eeef","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-03-01T22:52:43Z","updated_at":"2018-03-02T09:10:15Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/everypolitician/commons-builder/pulls/13","html_url":"https://github.com/everypolitician/commons-builder/pull/13","diff_url":"https://github.com/everypolitician/commons-builder/pull/13.diff","patch_url":"https://github.com/everypolitician/commons-builder/pull/13.patch"},"body":"An attempt at addressing #10.\r\n\r\nMostly looks to be doing the right thing on Canada, except:\r\n\r\n* doesn't find the existing term for the House of Commons (Q21157957), but I think that's because it's attached to the Parliament, not the house.\r\n* two houses (Q1517320, Q2994129) don't make it in because it doesn't find their position item\r\n* Montreal's Borough Mayor (Q47450833) is excluded for not being a councillor or legislator. Is this a wrong interpretation?\r\n* The Legislative Assembly of British Columbia (Q1323479) is missing. It looks to be modelled as a part of the Parliament of British Columbia (Q6564780), which could explain it.\r\n\r\nThis also adds a wikidata query function, which could be reused elsewhere to remove duplication."},"comment":{"url":"https://api.github.com/repos/everypolitician/commons-builder/issues/comments/369863960","html_url":"https://github.com/everypolitician/commons-builder/pull/13#issuecomment-369863960","issue_url":"https://api.github.com/repos/everypolitician/commons-builder/issues/13","id":369863960,"user":{"login":"crowbot","id":2912,"avatar_url":"https://avatars2.githubusercontent.com/u/2912?v=4","gravatar_id":"","url":"https://api.github.com/users/crowbot","html_url":"https://github.com/crowbot","followers_url":"https://api.github.com/users/crowbot/followers","following_url":"https://api.github.com/users/crowbot/following{/other_user}","gists_url":"https://api.github.com/users/crowbot/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbot/subscriptions","organizations_url":"https://api.github.com/users/crowbot/orgs","repos_url":"https://api.github.com/users/crowbot/repos","events_url":"https://api.github.com/users/crowbot/events{/privacy}","received_events_url":"https://api.github.com/users/crowbot/received_events","type":"User","site_admin":false},"created_at":"2018-03-02T09:10:15Z","updated_at":"2018-03-02T09:10:15Z","author_association":"CONTRIBUTOR","body":"This looks really great. Definitely going in the right direction. I like the warnings for the missing positions - that's super useful. I'm probably not the best person to comment on the Wikidata modelling questions but I think the approach of getting everything that's modelled as we expect, and warning on things (that we can find) that look like they're not quite modelled as we expect is a good one. We could start using this now and giving some more detailed feedback on what it includes or excludes based on that, so I think good next steps (I'm sure you've already thought of these) to get it out into the wild would be:\r\n\r\n- Exporting the executable via `commons-builder.Gemspec`\r\n- Pulling the meatier bits of code out of the executable script and adding some basic tests for them (I wonder if the a good quick approach here would be to generate some example query output in the fixtures directory and make sure the code does the right thing with respect to that)\r\n\r\n I'm just about to merge the other pending pull request against this repo, so you might want to rebase against master once I've done that before you do the second thing."}}
{"actor":{"display_login":"crowbot"}}