{"action":"created","issue":{"url":"https://api.github.com/repos/dask/dask-jobqueue/issues/171","repository_url":"https://api.github.com/repos/dask/dask-jobqueue","labels_url":"https://api.github.com/repos/dask/dask-jobqueue/issues/171/labels{/name}","comments_url":"https://api.github.com/repos/dask/dask-jobqueue/issues/171/comments","events_url":"https://api.github.com/repos/dask/dask-jobqueue/issues/171/events","html_url":"https://github.com/dask/dask-jobqueue/pull/171","id":367495372,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwOTExMzAw","number":171,"title":"Fix scale edge cases","user":{"login":"guillaumeeb","id":17138587,"node_id":"MDQ6VXNlcjE3MTM4NTg3","avatar_url":"https://avatars0.githubusercontent.com/u/17138587?v=4","gravatar_id":"","url":"https://api.github.com/users/guillaumeeb","html_url":"https://github.com/guillaumeeb","followers_url":"https://api.github.com/users/guillaumeeb/followers","following_url":"https://api.github.com/users/guillaumeeb/following{/other_user}","gists_url":"https://api.github.com/users/guillaumeeb/gists{/gist_id}","starred_url":"https://api.github.com/users/guillaumeeb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guillaumeeb/subscriptions","organizations_url":"https://api.github.com/users/guillaumeeb/orgs","repos_url":"https://api.github.com/users/guillaumeeb/repos","events_url":"https://api.github.com/users/guillaumeeb/events{/privacy}","received_events_url":"https://api.github.com/users/guillaumeeb/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2018-10-06T20:58:41Z","updated_at":"2018-10-20T21:03:29Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/dask/dask-jobqueue/pulls/171","html_url":"https://github.com/dask/dask-jobqueue/pull/171","diff_url":"https://github.com/dask/dask-jobqueue/pull/171.diff","patch_url":"https://github.com/dask/dask-jobqueue/pull/171.patch"},"body":"Fixes #112.\r\n\r\nImplementation of https://github.com/dask/distributed/issues/2257.\r\n\r\nFirst step towards #170.\r\n\r\nMust wait for #97 to be merged and activate test `test_basic_scale_edge_cases`."},"comment":{"url":"https://api.github.com/repos/dask/dask-jobqueue/issues/comments/431617862","html_url":"https://github.com/dask/dask-jobqueue/pull/171#issuecomment-431617862","issue_url":"https://api.github.com/repos/dask/dask-jobqueue/issues/171","id":431617862,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMTYxNzg2Mg==","user":{"login":"guillaumeeb","id":17138587,"node_id":"MDQ6VXNlcjE3MTM4NTg3","avatar_url":"https://avatars0.githubusercontent.com/u/17138587?v=4","gravatar_id":"","url":"https://api.github.com/users/guillaumeeb","html_url":"https://github.com/guillaumeeb","followers_url":"https://api.github.com/users/guillaumeeb/followers","following_url":"https://api.github.com/users/guillaumeeb/following{/other_user}","gists_url":"https://api.github.com/users/guillaumeeb/gists{/gist_id}","starred_url":"https://api.github.com/users/guillaumeeb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guillaumeeb/subscriptions","organizations_url":"https://api.github.com/users/guillaumeeb/orgs","repos_url":"https://api.github.com/users/guillaumeeb/repos","events_url":"https://api.github.com/users/guillaumeeb/events{/privacy}","received_events_url":"https://api.github.com/users/guillaumeeb/received_events","type":"User","site_admin":false},"created_at":"2018-10-20T21:03:29Z","updated_at":"2018-10-20T21:03:29Z","author_association":"MEMBER","body":"I discovered when merging master and performing some tests that adaptive was directly calling `scale_up` and `scale_down`.\r\n\r\nI'm not sure if this is correct, I currently have the feeling that adaptive should only rely on `scale()`. ClusterManager should then know if it needs to gracefully retire worker or anything else. This maybe something to keep aside for later. cc @mrocklin.\r\n\r\nOtherwise I think this is ready to go in if Travis build succeed. This already fixes some bug I observed on scaling with or without adaptive (adaptive endless loop or with multiple scale calls)."}}
{"actor":{"display_login":"guillaumeeb"}}