{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/azure-cli/pulls/comments/212080960","pull_request_review_id":148632700,"id":212080960,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjA4MDk2MA==","diff_hunk":"@@ -0,0 +1,132 @@\n+# --------------------------------------------------------------------------------------------\n+# Copyright (c) Microsoft Corporation. All rights reserved.\n+# Licensed under the MIT License. See License.txt in the project root for license information.\n+# --------------------------------------------------------------------------------------------\n+\n+from knack.arguments import CLIArgumentType\n+\n+from azure.cli.core.commands.parameters import (\n+    resource_group_name_type,\n+    get_enum_type,\n+    get_three_state_flag,\n+    tags_type)\n+\n+name_arg_type = CLIArgumentType(metavar='NAME', configured_default='botname', id_part='Name')\n+\n+\n+# pylint: disable=line-too-long,too-many-statements\n+def load_arguments(self, _):\n+    with self.argument_context('bot') as c:\n+        c.argument('resource_group_name', arg_type=resource_group_name_type)\n+        c.argument('resource_name', options_list=['--name', '-n'], help='The resource name of the bot.', arg_type=name_arg_type)\n+\n+    with self.argument_context('bot create') as c:\n+        c.argument('sku_name', options_list=['--sku'], arg_type=get_enum_type(['F0', 'S1']), help='The Sku of the bot', arg_group='Registration bot Specific')\n+        c.argument('kind', options_list=['--kind', '-k'], arg_type=get_enum_type(['registration', 'function', 'webapp']), help='The kind of the bot.')\n+        c.argument('display_name', help='the Display Name of the bot.If not specified, defaults to the name of the bot.', arg_group='Registration bot Specific')\n+        c.argument('description', options_list=['--description', '-d'], help='The Description of the bot.', arg_group='Registration bot Specific')\n+        c.argument('endpoint', options_list=['-e', '--endpoint'], help='The Messaging Endpoint of the bot.', arg_group='Registration bot Specific')\n+        c.argument('msa_app_id', options_list=['--appid'], help='The Microsoft account id (MSA ID) to be used with the bot.')\n+        c.argument('password', options_list=['-p', '--password'], help='the Microsoft account (MSA) password for the bot.')\n+        c.argument('storageAccountName', options_list=['-s', '--storage'], help='Storage account name to be used with the bot.If not provided, a new account will be created.', arg_group='Web/Function bot Specific')","path":"src/command_modules/azure-cli-botservice/azure/cli/command_modules/botservice/_params.py","position":31,"original_position":31,"commit_id":"ce09c7f229f4d3c9475597726db74f23e5ae9a3e","original_commit_id":"ce09c7f229f4d3c9475597726db74f23e5ae9a3e","user":{"login":"sptramer","id":169061,"node_id":"MDQ6VXNlcjE2OTA2MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/169061?v=4","gravatar_id":"","url":"https://api.github.com/users/sptramer","html_url":"https://github.com/sptramer","followers_url":"https://api.github.com/users/sptramer/followers","following_url":"https://api.github.com/users/sptramer/following{/other_user}","gists_url":"https://api.github.com/users/sptramer/gists{/gist_id}","starred_url":"https://api.github.com/users/sptramer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sptramer/subscriptions","organizations_url":"https://api.github.com/users/sptramer/orgs","repos_url":"https://api.github.com/users/sptramer/repos","events_url":"https://api.github.com/users/sptramer/events{/privacy}","received_events_url":"https://api.github.com/users/sptramer/received_events","type":"User","site_admin":false},"body":"Missing space: `bot. If`","created_at":"2018-08-22T19:34:04Z","updated_at":"2018-08-22T19:42:22Z","html_url":"https://github.com/Azure/azure-cli/pull/7046#discussion_r212080960","pull_request_url":"https://api.github.com/repos/Azure/azure-cli/pulls/7046","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-cli/pulls/comments/212080960"},"html":{"href":"https://github.com/Azure/azure-cli/pull/7046#discussion_r212080960"},"pull_request":{"href":"https://api.github.com/repos/Azure/azure-cli/pulls/7046"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/azure-cli/pulls/7046","id":208431009,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4NDMxMDA5","html_url":"https://github.com/Azure/azure-cli/pull/7046","diff_url":"https://github.com/Azure/azure-cli/pull/7046.diff","patch_url":"https://github.com/Azure/azure-cli/pull/7046.patch","issue_url":"https://api.github.com/repos/Azure/azure-cli/issues/7046","number":7046,"state":"open","locked":false,"title":"Initial release of botservice cli module","user":{"login":"swagatmishra2007","id":19970037,"node_id":"MDQ6VXNlcjE5OTcwMDM3","avatar_url":"https://avatars3.githubusercontent.com/u/19970037?v=4","gravatar_id":"","url":"https://api.github.com/users/swagatmishra2007","html_url":"https://github.com/swagatmishra2007","followers_url":"https://api.github.com/users/swagatmishra2007/followers","following_url":"https://api.github.com/users/swagatmishra2007/following{/other_user}","gists_url":"https://api.github.com/users/swagatmishra2007/gists{/gist_id}","starred_url":"https://api.github.com/users/swagatmishra2007/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swagatmishra2007/subscriptions","organizations_url":"https://api.github.com/users/swagatmishra2007/orgs","repos_url":"https://api.github.com/users/swagatmishra2007/repos","events_url":"https://api.github.com/users/swagatmishra2007/events{/privacy}","received_events_url":"https://api.github.com/users/swagatmishra2007/received_events","type":"User","site_admin":false},"body":"Roughly this CR contains command groups for managing bots, channels and authsettings. A lot of this work was already released as a cli extension.\r\nThe delta from the extension is -\r\n1) Added tests for most commands\r\n2)  improved logic in some of the commands\r\n3) i am using the latest azure-mgmt-botservice python library\r\n4) added support for id's parameter, corrected various help files etc\r\n\r\n\r\n---\r\n\r\nThis checklist is used to make sure that common guidelines for a pull request are followed.\r\n\r\n- [ ] The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see [Modifying change log](https://github.com/Azure/azure-cli/tree/master/doc/authoring_command_modules#modify-change-log)).\r\n\r\n- [ ] I adhere to the [Command Guidelines](https://github.com/Azure/azure-cli/blob/dev/doc/command_guidelines.md).\r\n","created_at":"2018-08-14T22:45:44Z","updated_at":"2018-08-22T19:42:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fbf0763776d95627d81128b31c971a661baad692","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1032197164,"node_id":"MDU6TGFiZWwxMDMyMTk3MTY0","url":"https://api.github.com/repos/Azure/azure-cli/labels/BotService","name":"BotService","color":"d4c5f9","default":false},{"id":832584782,"node_id":"MDU6TGFiZWw4MzI1ODQ3ODI=","url":"https://api.github.com/repos/Azure/azure-cli/labels/New%20Service","name":"New Service","color":"89ceff","default":false}],"milestone":{"url":"https://api.github.com/repos/Azure/azure-cli/milestones/46","html_url":"https://github.com/Azure/azure-cli/milestone/46","labels_url":"https://api.github.com/repos/Azure/azure-cli/milestones/46/labels","id":3537585,"node_id":"MDk6TWlsZXN0b25lMzUzNzU4NQ==","number":46,"title":"Sprint 44","description":"Code Complete: 2018-08-22\r\nBuild: 2018-08-23\r\nRelease: 2018-08-28\r\n","creator":{"login":"mayurid","id":5912228,"node_id":"MDQ6VXNlcjU5MTIyMjg=","avatar_url":"https://avatars2.githubusercontent.com/u/5912228?v=4","gravatar_id":"","url":"https://api.github.com/users/mayurid","html_url":"https://github.com/mayurid","followers_url":"https://api.github.com/users/mayurid/followers","following_url":"https://api.github.com/users/mayurid/following{/other_user}","gists_url":"https://api.github.com/users/mayurid/gists{/gist_id}","starred_url":"https://api.github.com/users/mayurid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mayurid/subscriptions","organizations_url":"https://api.github.com/users/mayurid/orgs","repos_url":"https://api.github.com/users/mayurid/repos","events_url":"https://api.github.com/users/mayurid/events{/privacy}","received_events_url":"https://api.github.com/users/mayurid/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":19,"state":"open","created_at":"2018-07-31T21:47:16Z","updated_at":"2018-08-22T17:51:21Z","due_on":"2018-08-22T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/Azure/azure-cli/pulls/7046/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-cli/pulls/7046/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-cli/issues/7046/comments","statuses_url":"https://api.github.com/repos/Azure/azure-cli/statuses/ce09c7f229f4d3c9475597726db74f23e5ae9a3e","head":{"label":"swagatmishra2007:dev","ref":"dev","sha":"ce09c7f229f4d3c9475597726db74f23e5ae9a3e","user":{"login":"swagatmishra2007","id":19970037,"node_id":"MDQ6VXNlcjE5OTcwMDM3","avatar_url":"https://avatars3.githubusercontent.com/u/19970037?v=4","gravatar_id":"","url":"https://api.github.com/users/swagatmishra2007","html_url":"https://github.com/swagatmishra2007","followers_url":"https://api.github.com/users/swagatmishra2007/followers","following_url":"https://api.github.com/users/swagatmishra2007/following{/other_user}","gists_url":"https://api.github.com/users/swagatmishra2007/gists{/gist_id}","starred_url":"https://api.github.com/users/swagatmishra2007/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swagatmishra2007/subscriptions","organizations_url":"https://api.github.com/users/swagatmishra2007/orgs","repos_url":"https://api.github.com/users/swagatmishra2007/repos","events_url":"https://api.github.com/users/swagatmishra2007/events{/privacy}","received_events_url":"https://api.github.com/users/swagatmishra2007/received_events","type":"User","site_admin":false},"repo":{"id":144763535,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ3NjM1MzU=","name":"azure-cli","full_name":"swagatmishra2007/azure-cli","owner":{"login":"swagatmishra2007","id":19970037,"node_id":"MDQ6VXNlcjE5OTcwMDM3","avatar_url":"https://avatars3.githubusercontent.com/u/19970037?v=4","gravatar_id":"","url":"https://api.github.com/users/swagatmishra2007","html_url":"https://github.com/swagatmishra2007","followers_url":"https://api.github.com/users/swagatmishra2007/followers","following_url":"https://api.github.com/users/swagatmishra2007/following{/other_user}","gists_url":"https://api.github.com/users/swagatmishra2007/gists{/gist_id}","starred_url":"https://api.github.com/users/swagatmishra2007/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swagatmishra2007/subscriptions","organizations_url":"https://api.github.com/users/swagatmishra2007/orgs","repos_url":"https://api.github.com/users/swagatmishra2007/repos","events_url":"https://api.github.com/users/swagatmishra2007/events{/privacy}","received_events_url":"https://api.github.com/users/swagatmishra2007/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/swagatmishra2007/azure-cli","description":"Command-line tools for Azure.","fork":true,"url":"https://api.github.com/repos/swagatmishra2007/azure-cli","forks_url":"https://api.github.com/repos/swagatmishra2007/azure-cli/forks","keys_url":"https://api.github.com/repos/swagatmishra2007/azure-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/swagatmishra2007/azure-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/swagatmishra2007/azure-cli/teams","hooks_url":"https://api.github.com/repos/swagatmishra2007/azure-cli/hooks","issue_events_url":"https://api.github.com/repos/swagatmishra2007/azure-cli/issues/events{/number}","events_url":"https://api.github.com/repos/swagatmishra2007/azure-cli/events","assignees_url":"https://api.github.com/repos/swagatmishra2007/azure-cli/assignees{/user}","branches_url":"https://api.github.com/repos/swagatmishra2007/azure-cli/branches{/branch}","tags_url":"https://api.github.com/repos/swagatmishra2007/azure-cli/tags","blobs_url":"https://api.github.com/repos/swagatmishra2007/azure-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/swagatmishra2007/azure-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/swagatmishra2007/azure-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/swagatmishra2007/azure-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/swagatmishra2007/azure-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/swagatmishra2007/azure-cli/languages","stargazers_url":"https://api.github.com/repos/swagatmishra2007/azure-cli/stargazers","contributors_url":"https://api.github.com/repos/swagatmishra2007/azure-cli/contributors","subscribers_url":"https://api.github.com/repos/swagatmishra2007/azure-cli/subscribers","subscription_url":"https://api.github.com/repos/swagatmishra2007/azure-cli/subscription","commits_url":"https://api.github.com/repos/swagatmishra2007/azure-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/swagatmishra2007/azure-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/swagatmishra2007/azure-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/swagatmishra2007/azure-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/swagatmishra2007/azure-cli/contents/{+path}","compare_url":"https://api.github.com/repos/swagatmishra2007/azure-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/swagatmishra2007/azure-cli/merges","archive_url":"https://api.github.com/repos/swagatmishra2007/azure-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/swagatmishra2007/azure-cli/downloads","issues_url":"https://api.github.com/repos/swagatmishra2007/azure-cli/issues{/number}","pulls_url":"https://api.github.com/repos/swagatmishra2007/azure-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/swagatmishra2007/azure-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/swagatmishra2007/azure-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/swagatmishra2007/azure-cli/labels{/name}","releases_url":"https://api.github.com/repos/swagatmishra2007/azure-cli/releases{/id}","deployments_url":"https://api.github.com/repos/swagatmishra2007/azure-cli/deployments","created_at":"2018-08-14T19:27:28Z","updated_at":"2018-08-22T18:38:48Z","pushed_at":"2018-08-22T18:38:46Z","git_url":"git://github.com/swagatmishra2007/azure-cli.git","ssh_url":"git@github.com:swagatmishra2007/azure-cli.git","clone_url":"https://github.com/swagatmishra2007/azure-cli.git","svn_url":"https://github.com/swagatmishra2007/azure-cli","homepage":null,"size":48301,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"Azure:dev","ref":"dev","sha":"ca2f915544bae8f44b766b2f762eca10f19f5358","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":51040886,"node_id":"MDEwOlJlcG9zaXRvcnk1MTA0MDg4Ng==","name":"azure-cli","full_name":"Azure/azure-cli","owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/azure-cli","description":"Command-line tools for Azure.","fork":false,"url":"https://api.github.com/repos/Azure/azure-cli","forks_url":"https://api.github.com/repos/Azure/azure-cli/forks","keys_url":"https://api.github.com/repos/Azure/azure-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-cli/teams","hooks_url":"https://api.github.com/repos/Azure/azure-cli/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-cli/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-cli/events","assignees_url":"https://api.github.com/repos/Azure/azure-cli/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-cli/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-cli/tags","blobs_url":"https://api.github.com/repos/Azure/azure-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-cli/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-cli/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-cli/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-cli/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-cli/subscription","commits_url":"https://api.github.com/repos/Azure/azure-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-cli/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-cli/merges","archive_url":"https://api.github.com/repos/Azure/azure-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-cli/downloads","issues_url":"https://api.github.com/repos/Azure/azure-cli/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-cli/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-cli/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-cli/deployments","created_at":"2016-02-04T00:21:51Z","updated_at":"2018-08-22T17:51:25Z","pushed_at":"2018-08-22T18:38:48Z","git_url":"git://github.com/Azure/azure-cli.git","ssh_url":"git@github.com:Azure/azure-cli.git","clone_url":"https://github.com/Azure/azure-cli.git","svn_url":"https://github.com/Azure/azure-cli","homepage":null,"size":49402,"stargazers_count":853,"watchers_count":853,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":541,"mirror_url":null,"archived":false,"open_issues_count":811,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":541,"open_issues":811,"watchers":853,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-cli/pulls/7046"},"html":{"href":"https://github.com/Azure/azure-cli/pull/7046"},"issue":{"href":"https://api.github.com/repos/Azure/azure-cli/issues/7046"},"comments":{"href":"https://api.github.com/repos/Azure/azure-cli/issues/7046/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-cli/pulls/7046/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-cli/pulls/7046/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-cli/statuses/ce09c7f229f4d3c9475597726db74f23e5ae9a3e"}},"author_association":"NONE"}}
{"actor":{"display_login":"sptramer"}}