{"action":"created","issue":{"url":"https://api.github.com/repos/codingjoe/MusicBeam/issues/58","repository_url":"https://api.github.com/repos/codingjoe/MusicBeam","labels_url":"https://api.github.com/repos/codingjoe/MusicBeam/issues/58/labels{/name}","comments_url":"https://api.github.com/repos/codingjoe/MusicBeam/issues/58/comments","events_url":"https://api.github.com/repos/codingjoe/MusicBeam/issues/58/events","html_url":"https://github.com/codingjoe/MusicBeam/issues/58","id":323414679,"number":58,"title":"The effect's list needs a scroll so more effects can be added (w/ suggestion code)","user":{"login":"LuisMQuinones","id":14282382,"avatar_url":"https://avatars1.githubusercontent.com/u/14282382?v=4","gravatar_id":"","url":"https://api.github.com/users/LuisMQuinones","html_url":"https://github.com/LuisMQuinones","followers_url":"https://api.github.com/users/LuisMQuinones/followers","following_url":"https://api.github.com/users/LuisMQuinones/following{/other_user}","gists_url":"https://api.github.com/users/LuisMQuinones/gists{/gist_id}","starred_url":"https://api.github.com/users/LuisMQuinones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LuisMQuinones/subscriptions","organizations_url":"https://api.github.com/users/LuisMQuinones/orgs","repos_url":"https://api.github.com/users/LuisMQuinones/repos","events_url":"https://api.github.com/users/LuisMQuinones/events{/privacy}","received_events_url":"https://api.github.com/users/LuisMQuinones/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-05-15T23:08:23Z","updated_at":"2018-05-22T08:04:27Z","closed_at":null,"author_association":"NONE","body":"We can't add any new effects to the Effect effectsArray, or better; anymore toggles to RadioButton activeEffect, because the additional toggles are rendered off screen.\r\n\r\nI looked for ways to wrap the activeEffect into one of the scroll controllers like ListBox or ScrollableList.\r\nI think we may need to drop RadioButton activeEffect in favor of a ScrollableList with no visible bar.\r\n\r\nI wrote some short code to test it out:\r\n\r\n![screen shot 2018-05-15 at 7 01 37 pm](https://user-images.githubusercontent.com/14282382/40087878-8a87f552-5872-11e8-869b-3f3b5279b2d8.png)\r\n\r\n\r\n```Java\r\ncp5 = new ControlP5(this);\r\nscroll = cp5.addScrollableList(\"scroll\")\r\n     .setType(ScrollableList.LIST)       \r\n      .setBarHeight(0)\r\n      .setSize(150,150)\r\n      .setItemHeight(20)\r\n      .setBarVisible(false)\r\n      .setPosition(width/2-75,height/2-75) ;\r\n```\r\n```Java\r\nvoid scroll(int i){\r\n     //println(i, cp5.get(ScrollableList.class, \"scroll\").getItem(i));\r\n     Effect effect = (Effect)cp5.get(ScrollableList.class, \"scroll\").getItem(i).get(\"value\");\r\n     println(\"id\",effect.val,\"name\",effect.name,\"was chosen\");\r\n   }\r\n```\r\nI think it looks like the original implementation with an added scrollbar.\r\n@codingjoe I'll love to hear what you think."},"comment":{"url":"https://api.github.com/repos/codingjoe/MusicBeam/issues/comments/390900006","html_url":"https://github.com/codingjoe/MusicBeam/issues/58#issuecomment-390900006","issue_url":"https://api.github.com/repos/codingjoe/MusicBeam/issues/58","id":390900006,"user":{"login":"codingjoe","id":1772890,"avatar_url":"https://avatars1.githubusercontent.com/u/1772890?v=4","gravatar_id":"","url":"https://api.github.com/users/codingjoe","html_url":"https://github.com/codingjoe","followers_url":"https://api.github.com/users/codingjoe/followers","following_url":"https://api.github.com/users/codingjoe/following{/other_user}","gists_url":"https://api.github.com/users/codingjoe/gists{/gist_id}","starred_url":"https://api.github.com/users/codingjoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codingjoe/subscriptions","organizations_url":"https://api.github.com/users/codingjoe/orgs","repos_url":"https://api.github.com/users/codingjoe/repos","events_url":"https://api.github.com/users/codingjoe/events{/privacy}","received_events_url":"https://api.github.com/users/codingjoe/received_events","type":"User","site_admin":false},"created_at":"2018-05-22T08:04:27Z","updated_at":"2018-05-22T08:04:27Z","author_association":"OWNER","body":"@LuisMQuinones thanks for the research good work. I agree this looks like the best solution. We should probably define a frame size, that works on most screens. I would not keep the current one, I would like the bottom button to be only half in the viewport by default. That way it's visually identifiable that the frame can scrolled."}}
{"actor":{"display_login":"codingjoe"}}