{"action":"created","comment":{"url":"https://api.github.com/repos/negz/kuberos/pulls/comments/230613615","pull_request_review_id":171388751,"id":230613615,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDYxMzYxNQ==","diff_hunk":"@@ -317,13 +335,16 @@ func Template(cfg *api.Config) http.HandlerFunc {\n \t\tr.ParseMultipartForm(templateFormParseMemory) //nolint:errcheck\n \t\tp := &extractor.OIDCAuthenticationParams{}\n \n-\t\t// TODO(negz): Return an error if any required parameter is absent.\n \t\tif err := decoder.Decode(p, r.Form); err != nil {\n \t\t\thttp.Error(w, errors.Wrap(err, \"cannot parse URL parameter\").Error(), http.StatusBadRequest)\n \t\t\treturn\n+\t\t} else if len(p.Username) == 0 {\n+\t\t\thttp.Error(w, http.StatusText(http.StatusNotFound), http.StatusNotFound)","path":"kuberos.go","position":78,"original_position":78,"commit_id":"8d96b0fa15a44c4098e2d7a841cee00ec4859f50","original_commit_id":"8d96b0fa15a44c4098e2d7a841cee00ec4859f50","user":{"login":"negz","id":1049349,"node_id":"MDQ6VXNlcjEwNDkzNDk=","avatar_url":"https://avatars2.githubusercontent.com/u/1049349?v=4","gravatar_id":"","url":"https://api.github.com/users/negz","html_url":"https://github.com/negz","followers_url":"https://api.github.com/users/negz/followers","following_url":"https://api.github.com/users/negz/following{/other_user}","gists_url":"https://api.github.com/users/negz/gists{/gist_id}","starred_url":"https://api.github.com/users/negz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/negz/subscriptions","organizations_url":"https://api.github.com/users/negz/orgs","repos_url":"https://api.github.com/users/negz/repos","events_url":"https://api.github.com/users/negz/events{/privacy}","received_events_url":"https://api.github.com/users/negz/received_events","type":"User","site_admin":false},"body":"I'd prefer to return HTTP 401 Unauthorized in this case.","created_at":"2018-11-05T00:48:16Z","updated_at":"2018-11-05T00:51:23Z","html_url":"https://github.com/negz/kuberos/pull/54#discussion_r230613615","pull_request_url":"https://api.github.com/repos/negz/kuberos/pulls/54","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/negz/kuberos/pulls/comments/230613615"},"html":{"href":"https://github.com/negz/kuberos/pull/54#discussion_r230613615"},"pull_request":{"href":"https://api.github.com/repos/negz/kuberos/pulls/54"}}},"pull_request":{"url":"https://api.github.com/repos/negz/kuberos/pulls/54","id":227563418,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3NTYzNDE4","html_url":"https://github.com/negz/kuberos/pull/54","diff_url":"https://github.com/negz/kuberos/pull/54.diff","patch_url":"https://github.com/negz/kuberos/pull/54.patch","issue_url":"https://api.github.com/repos/negz/kuberos/issues/54","number":54,"state":"open","locked":false,"title":"#49 Simple kubecfg.yaml endpoint security.","user":{"login":"joaovrodrigues","id":11519775,"node_id":"MDQ6VXNlcjExNTE5Nzc1","avatar_url":"https://avatars1.githubusercontent.com/u/11519775?v=4","gravatar_id":"","url":"https://api.github.com/users/joaovrodrigues","html_url":"https://github.com/joaovrodrigues","followers_url":"https://api.github.com/users/joaovrodrigues/followers","following_url":"https://api.github.com/users/joaovrodrigues/following{/other_user}","gists_url":"https://api.github.com/users/joaovrodrigues/gists{/gist_id}","starred_url":"https://api.github.com/users/joaovrodrigues/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joaovrodrigues/subscriptions","organizations_url":"https://api.github.com/users/joaovrodrigues/orgs","repos_url":"https://api.github.com/users/joaovrodrigues/repos","events_url":"https://api.github.com/users/joaovrodrigues/events{/privacy}","received_events_url":"https://api.github.com/users/joaovrodrigues/received_events","type":"User","site_admin":false},"body":"Added simple verification to the kubecfg.yaml endpoint, should show the 404 page when user not logged in and by doing so preventing partial credentials from being exposed publicly.","created_at":"2018-11-01T09:44:24Z","updated_at":"2018-11-05T00:51:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ebfb89a608a3629b3240eee91e4213dd3a201d1f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/negz/kuberos/pulls/54/commits","review_comments_url":"https://api.github.com/repos/negz/kuberos/pulls/54/comments","review_comment_url":"https://api.github.com/repos/negz/kuberos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/negz/kuberos/issues/54/comments","statuses_url":"https://api.github.com/repos/negz/kuberos/statuses/8d96b0fa15a44c4098e2d7a841cee00ec4859f50","head":{"label":"joaovrodrigues:master","ref":"master","sha":"8d96b0fa15a44c4098e2d7a841cee00ec4859f50","user":{"login":"joaovrodrigues","id":11519775,"node_id":"MDQ6VXNlcjExNTE5Nzc1","avatar_url":"https://avatars1.githubusercontent.com/u/11519775?v=4","gravatar_id":"","url":"https://api.github.com/users/joaovrodrigues","html_url":"https://github.com/joaovrodrigues","followers_url":"https://api.github.com/users/joaovrodrigues/followers","following_url":"https://api.github.com/users/joaovrodrigues/following{/other_user}","gists_url":"https://api.github.com/users/joaovrodrigues/gists{/gist_id}","starred_url":"https://api.github.com/users/joaovrodrigues/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joaovrodrigues/subscriptions","organizations_url":"https://api.github.com/users/joaovrodrigues/orgs","repos_url":"https://api.github.com/users/joaovrodrigues/repos","events_url":"https://api.github.com/users/joaovrodrigues/events{/privacy}","received_events_url":"https://api.github.com/users/joaovrodrigues/received_events","type":"User","site_admin":false},"repo":{"id":155693339,"node_id":"MDEwOlJlcG9zaXRvcnkxNTU2OTMzMzk=","name":"kuberos","full_name":"joaovrodrigues/kuberos","private":false,"owner":{"login":"joaovrodrigues","id":11519775,"node_id":"MDQ6VXNlcjExNTE5Nzc1","avatar_url":"https://avatars1.githubusercontent.com/u/11519775?v=4","gravatar_id":"","url":"https://api.github.com/users/joaovrodrigues","html_url":"https://github.com/joaovrodrigues","followers_url":"https://api.github.com/users/joaovrodrigues/followers","following_url":"https://api.github.com/users/joaovrodrigues/following{/other_user}","gists_url":"https://api.github.com/users/joaovrodrigues/gists{/gist_id}","starred_url":"https://api.github.com/users/joaovrodrigues/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joaovrodrigues/subscriptions","organizations_url":"https://api.github.com/users/joaovrodrigues/orgs","repos_url":"https://api.github.com/users/joaovrodrigues/repos","events_url":"https://api.github.com/users/joaovrodrigues/events{/privacy}","received_events_url":"https://api.github.com/users/joaovrodrigues/received_events","type":"User","site_admin":false},"html_url":"https://github.com/joaovrodrigues/kuberos","description":"An OIDC authentication helper for Kubernetes' kubectl","fork":true,"url":"https://api.github.com/repos/joaovrodrigues/kuberos","forks_url":"https://api.github.com/repos/joaovrodrigues/kuberos/forks","keys_url":"https://api.github.com/repos/joaovrodrigues/kuberos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joaovrodrigues/kuberos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joaovrodrigues/kuberos/teams","hooks_url":"https://api.github.com/repos/joaovrodrigues/kuberos/hooks","issue_events_url":"https://api.github.com/repos/joaovrodrigues/kuberos/issues/events{/number}","events_url":"https://api.github.com/repos/joaovrodrigues/kuberos/events","assignees_url":"https://api.github.com/repos/joaovrodrigues/kuberos/assignees{/user}","branches_url":"https://api.github.com/repos/joaovrodrigues/kuberos/branches{/branch}","tags_url":"https://api.github.com/repos/joaovrodrigues/kuberos/tags","blobs_url":"https://api.github.com/repos/joaovrodrigues/kuberos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joaovrodrigues/kuberos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joaovrodrigues/kuberos/git/refs{/sha}","trees_url":"https://api.github.com/repos/joaovrodrigues/kuberos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joaovrodrigues/kuberos/statuses/{sha}","languages_url":"https://api.github.com/repos/joaovrodrigues/kuberos/languages","stargazers_url":"https://api.github.com/repos/joaovrodrigues/kuberos/stargazers","contributors_url":"https://api.github.com/repos/joaovrodrigues/kuberos/contributors","subscribers_url":"https://api.github.com/repos/joaovrodrigues/kuberos/subscribers","subscription_url":"https://api.github.com/repos/joaovrodrigues/kuberos/subscription","commits_url":"https://api.github.com/repos/joaovrodrigues/kuberos/commits{/sha}","git_commits_url":"https://api.github.com/repos/joaovrodrigues/kuberos/git/commits{/sha}","comments_url":"https://api.github.com/repos/joaovrodrigues/kuberos/comments{/number}","issue_comment_url":"https://api.github.com/repos/joaovrodrigues/kuberos/issues/comments{/number}","contents_url":"https://api.github.com/repos/joaovrodrigues/kuberos/contents/{+path}","compare_url":"https://api.github.com/repos/joaovrodrigues/kuberos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joaovrodrigues/kuberos/merges","archive_url":"https://api.github.com/repos/joaovrodrigues/kuberos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joaovrodrigues/kuberos/downloads","issues_url":"https://api.github.com/repos/joaovrodrigues/kuberos/issues{/number}","pulls_url":"https://api.github.com/repos/joaovrodrigues/kuberos/pulls{/number}","milestones_url":"https://api.github.com/repos/joaovrodrigues/kuberos/milestones{/number}","notifications_url":"https://api.github.com/repos/joaovrodrigues/kuberos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joaovrodrigues/kuberos/labels{/name}","releases_url":"https://api.github.com/repos/joaovrodrigues/kuberos/releases{/id}","deployments_url":"https://api.github.com/repos/joaovrodrigues/kuberos/deployments","created_at":"2018-11-01T09:41:41Z","updated_at":"2018-11-04T16:46:36Z","pushed_at":"2018-11-04T16:46:34Z","git_url":"git://github.com/joaovrodrigues/kuberos.git","ssh_url":"git@github.com:joaovrodrigues/kuberos.git","clone_url":"https://github.com/joaovrodrigues/kuberos.git","svn_url":"https://github.com/joaovrodrigues/kuberos","homepage":null,"size":2154,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"negz:master","ref":"master","sha":"1d9e46eed69f021fe56d9b9f3f8c6e958bf2111d","user":{"login":"negz","id":1049349,"node_id":"MDQ6VXNlcjEwNDkzNDk=","avatar_url":"https://avatars2.githubusercontent.com/u/1049349?v=4","gravatar_id":"","url":"https://api.github.com/users/negz","html_url":"https://github.com/negz","followers_url":"https://api.github.com/users/negz/followers","following_url":"https://api.github.com/users/negz/following{/other_user}","gists_url":"https://api.github.com/users/negz/gists{/gist_id}","starred_url":"https://api.github.com/users/negz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/negz/subscriptions","organizations_url":"https://api.github.com/users/negz/orgs","repos_url":"https://api.github.com/users/negz/repos","events_url":"https://api.github.com/users/negz/events{/privacy}","received_events_url":"https://api.github.com/users/negz/received_events","type":"User","site_admin":false},"repo":{"id":87504214,"node_id":"MDEwOlJlcG9zaXRvcnk4NzUwNDIxNA==","name":"kuberos","full_name":"negz/kuberos","private":false,"owner":{"login":"negz","id":1049349,"node_id":"MDQ6VXNlcjEwNDkzNDk=","avatar_url":"https://avatars2.githubusercontent.com/u/1049349?v=4","gravatar_id":"","url":"https://api.github.com/users/negz","html_url":"https://github.com/negz","followers_url":"https://api.github.com/users/negz/followers","following_url":"https://api.github.com/users/negz/following{/other_user}","gists_url":"https://api.github.com/users/negz/gists{/gist_id}","starred_url":"https://api.github.com/users/negz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/negz/subscriptions","organizations_url":"https://api.github.com/users/negz/orgs","repos_url":"https://api.github.com/users/negz/repos","events_url":"https://api.github.com/users/negz/events{/privacy}","received_events_url":"https://api.github.com/users/negz/received_events","type":"User","site_admin":false},"html_url":"https://github.com/negz/kuberos","description":"An OIDC authentication helper for Kubernetes' kubectl","fork":false,"url":"https://api.github.com/repos/negz/kuberos","forks_url":"https://api.github.com/repos/negz/kuberos/forks","keys_url":"https://api.github.com/repos/negz/kuberos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/negz/kuberos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/negz/kuberos/teams","hooks_url":"https://api.github.com/repos/negz/kuberos/hooks","issue_events_url":"https://api.github.com/repos/negz/kuberos/issues/events{/number}","events_url":"https://api.github.com/repos/negz/kuberos/events","assignees_url":"https://api.github.com/repos/negz/kuberos/assignees{/user}","branches_url":"https://api.github.com/repos/negz/kuberos/branches{/branch}","tags_url":"https://api.github.com/repos/negz/kuberos/tags","blobs_url":"https://api.github.com/repos/negz/kuberos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/negz/kuberos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/negz/kuberos/git/refs{/sha}","trees_url":"https://api.github.com/repos/negz/kuberos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/negz/kuberos/statuses/{sha}","languages_url":"https://api.github.com/repos/negz/kuberos/languages","stargazers_url":"https://api.github.com/repos/negz/kuberos/stargazers","contributors_url":"https://api.github.com/repos/negz/kuberos/contributors","subscribers_url":"https://api.github.com/repos/negz/kuberos/subscribers","subscription_url":"https://api.github.com/repos/negz/kuberos/subscription","commits_url":"https://api.github.com/repos/negz/kuberos/commits{/sha}","git_commits_url":"https://api.github.com/repos/negz/kuberos/git/commits{/sha}","comments_url":"https://api.github.com/repos/negz/kuberos/comments{/number}","issue_comment_url":"https://api.github.com/repos/negz/kuberos/issues/comments{/number}","contents_url":"https://api.github.com/repos/negz/kuberos/contents/{+path}","compare_url":"https://api.github.com/repos/negz/kuberos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/negz/kuberos/merges","archive_url":"https://api.github.com/repos/negz/kuberos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/negz/kuberos/downloads","issues_url":"https://api.github.com/repos/negz/kuberos/issues{/number}","pulls_url":"https://api.github.com/repos/negz/kuberos/pulls{/number}","milestones_url":"https://api.github.com/repos/negz/kuberos/milestones{/number}","notifications_url":"https://api.github.com/repos/negz/kuberos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/negz/kuberos/labels{/name}","releases_url":"https://api.github.com/repos/negz/kuberos/releases{/id}","deployments_url":"https://api.github.com/repos/negz/kuberos/deployments","created_at":"2017-04-07T04:27:35Z","updated_at":"2018-11-05T00:41:42Z","pushed_at":"2018-11-05T00:41:40Z","git_url":"git://github.com/negz/kuberos.git","ssh_url":"git@github.com:negz/kuberos.git","clone_url":"https://github.com/negz/kuberos.git","svn_url":"https://github.com/negz/kuberos","homepage":null,"size":2079,"stargazers_count":84,"watchers_count":84,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":24,"open_issues":7,"watchers":84,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/negz/kuberos/pulls/54"},"html":{"href":"https://github.com/negz/kuberos/pull/54"},"issue":{"href":"https://api.github.com/repos/negz/kuberos/issues/54"},"comments":{"href":"https://api.github.com/repos/negz/kuberos/issues/54/comments"},"review_comments":{"href":"https://api.github.com/repos/negz/kuberos/pulls/54/comments"},"review_comment":{"href":"https://api.github.com/repos/negz/kuberos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/negz/kuberos/pulls/54/commits"},"statuses":{"href":"https://api.github.com/repos/negz/kuberos/statuses/8d96b0fa15a44c4098e2d7a841cee00ec4859f50"}},"author_association":"NONE"}}
{"actor":{"display_login":"negz"}}