{"action":"created","issue":{"url":"https://api.github.com/repos/greenplum-db/gpbackup/issues/73","repository_url":"https://api.github.com/repos/greenplum-db/gpbackup","labels_url":"https://api.github.com/repos/greenplum-db/gpbackup/issues/73/labels{/name}","comments_url":"https://api.github.com/repos/greenplum-db/gpbackup/issues/73/comments","events_url":"https://api.github.com/repos/greenplum-db/gpbackup/issues/73/events","html_url":"https://github.com/greenplum-db/gpbackup/pull/73","id":319068643,"number":73,"title":"Don't check error for mkfifo command","user":{"login":"khuddlefish","id":4099765,"avatar_url":"https://avatars2.githubusercontent.com/u/4099765?v=4","gravatar_id":"","url":"https://api.github.com/users/khuddlefish","html_url":"https://github.com/khuddlefish","followers_url":"https://api.github.com/users/khuddlefish/followers","following_url":"https://api.github.com/users/khuddlefish/following{/other_user}","gists_url":"https://api.github.com/users/khuddlefish/gists{/gist_id}","starred_url":"https://api.github.com/users/khuddlefish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khuddlefish/subscriptions","organizations_url":"https://api.github.com/users/khuddlefish/orgs","repos_url":"https://api.github.com/users/khuddlefish/repos","events_url":"https://api.github.com/users/khuddlefish/events{/privacy}","received_events_url":"https://api.github.com/users/khuddlefish/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-04-30T23:22:56Z","updated_at":"2018-05-01T08:45:03Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/greenplum-db/gpbackup/pulls/73","html_url":"https://github.com/greenplum-db/gpbackup/pull/73","diff_url":"https://github.com/greenplum-db/gpbackup/pull/73.diff","patch_url":"https://github.com/greenplum-db/gpbackup/pull/73.patch"},"body":"Our tests were failing frequently for \"file exists\" errors with this\r\ncommand. This should not be a reason for the helper to error out. If the\r\ncommand errors out and is unable to create the pipe, we should see the\r\nerror show up somewhere else, so this check is not very useful.\r\n\r\nAuthored-by: Karen Huddleston <khuddleston@pivotal.io>"},"comment":{"url":"https://api.github.com/repos/greenplum-db/gpbackup/issues/comments/385626882","html_url":"https://github.com/greenplum-db/gpbackup/pull/73#issuecomment-385626882","issue_url":"https://api.github.com/repos/greenplum-db/gpbackup/issues/73","id":385626882,"user":{"login":"chrishajas","id":1610524,"avatar_url":"https://avatars3.githubusercontent.com/u/1610524?v=4","gravatar_id":"","url":"https://api.github.com/users/chrishajas","html_url":"https://github.com/chrishajas","followers_url":"https://api.github.com/users/chrishajas/followers","following_url":"https://api.github.com/users/chrishajas/following{/other_user}","gists_url":"https://api.github.com/users/chrishajas/gists{/gist_id}","starred_url":"https://api.github.com/users/chrishajas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrishajas/subscriptions","organizations_url":"https://api.github.com/users/chrishajas/orgs","repos_url":"https://api.github.com/users/chrishajas/repos","events_url":"https://api.github.com/users/chrishajas/events{/privacy}","received_events_url":"https://api.github.com/users/chrishajas/received_events","type":"User","site_admin":false},"created_at":"2018-05-01T08:45:03Z","updated_at":"2018-05-01T08:45:03Z","author_association":"MEMBER","body":"Do we know why we're getting that the file already exists? Is it due to test pollution, the way we're setting up our tests, or is it an assertion that we can't guarantee due to a race condition in the logic? I agree that this change shouldn't change the logic, but I don't know under what conditions a file would already exist."}}
{"actor":{"display_login":"chrishajas"}}