{"action":"created","issue":{"url":"https://api.github.com/repos/aspnet/CORS/issues/163","repository_url":"https://api.github.com/repos/aspnet/CORS","labels_url":"https://api.github.com/repos/aspnet/CORS/issues/163/labels{/name}","comments_url":"https://api.github.com/repos/aspnet/CORS/issues/163/comments","events_url":"https://api.github.com/repos/aspnet/CORS/issues/163/events","html_url":"https://github.com/aspnet/CORS/pull/163","id":331793310,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0NDM3ODU1","number":163,"title":"No CORS headers sent if Exception is thrown","user":{"login":"Lavinski","id":1761789,"node_id":"MDQ6VXNlcjE3NjE3ODk=","avatar_url":"https://avatars0.githubusercontent.com/u/1761789?v=4","gravatar_id":"","url":"https://api.github.com/users/Lavinski","html_url":"https://github.com/Lavinski","followers_url":"https://api.github.com/users/Lavinski/followers","following_url":"https://api.github.com/users/Lavinski/following{/other_user}","gists_url":"https://api.github.com/users/Lavinski/gists{/gist_id}","starred_url":"https://api.github.com/users/Lavinski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lavinski/subscriptions","organizations_url":"https://api.github.com/users/Lavinski/orgs","repos_url":"https://api.github.com/users/Lavinski/repos","events_url":"https://api.github.com/users/Lavinski/events{/privacy}","received_events_url":"https://api.github.com/users/Lavinski/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-06-12T23:52:22Z","updated_at":"2018-06-19T10:53:09Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/aspnet/CORS/pulls/163","html_url":"https://github.com/aspnet/CORS/pull/163","diff_url":"https://github.com/aspnet/CORS/pull/163.diff","patch_url":"https://github.com/aspnet/CORS/pull/163.patch"},"body":"Normally headers are added however if a controller throws an exception then CORS headers not be present.\r\n\r\nAll matching responses should have CORS headers added. This problem affects the use of middleware (including the UseExceptionHandler middleware).\r\n\r\nThis PR fixes the issue by moving the adding of the headers to `Response.OnStarting`.\r\n\r\nhttps://github.com/aspnet/Home/issues/2378\r\nhttps://github.com/aspnet/Home/issues/3220"},"comment":{"url":"https://api.github.com/repos/aspnet/CORS/issues/comments/398357986","html_url":"https://github.com/aspnet/CORS/pull/163#issuecomment-398357986","issue_url":"https://api.github.com/repos/aspnet/CORS/issues/163","id":398357986,"node_id":"MDEyOklzc3VlQ29tbWVudDM5ODM1Nzk4Ng==","user":{"login":"JulijaRamoskiene","id":28706674,"node_id":"MDQ6VXNlcjI4NzA2Njc0","avatar_url":"https://avatars2.githubusercontent.com/u/28706674?v=4","gravatar_id":"","url":"https://api.github.com/users/JulijaRamoskiene","html_url":"https://github.com/JulijaRamoskiene","followers_url":"https://api.github.com/users/JulijaRamoskiene/followers","following_url":"https://api.github.com/users/JulijaRamoskiene/following{/other_user}","gists_url":"https://api.github.com/users/JulijaRamoskiene/gists{/gist_id}","starred_url":"https://api.github.com/users/JulijaRamoskiene/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JulijaRamoskiene/subscriptions","organizations_url":"https://api.github.com/users/JulijaRamoskiene/orgs","repos_url":"https://api.github.com/users/JulijaRamoskiene/repos","events_url":"https://api.github.com/users/JulijaRamoskiene/events{/privacy}","received_events_url":"https://api.github.com/users/JulijaRamoskiene/received_events","type":"User","site_admin":false},"created_at":"2018-06-19T10:53:09Z","updated_at":"2018-06-19T10:53:09Z","author_association":"NONE","body":"I think it is a mistake to have duplicated code in CorsAuthorizationFilter and CorsMiddleware E.g.: preflight requests are now handled differently between them. CorsAuthorizationFilter sets 200 OK response code and CorsMiddleware sets 204 No Content. "}}
{"actor":{"display_login":"JulijaRamoskiene"}}