{"action":"created","issue":{"url":"https://api.github.com/repos/status-im/status-react/issues/4538","repository_url":"https://api.github.com/repos/status-im/status-react","labels_url":"https://api.github.com/repos/status-im/status-react/issues/4538/labels{/name}","comments_url":"https://api.github.com/repos/status-im/status-react/issues/4538/comments","events_url":"https://api.github.com/repos/status-im/status-react/issues/4538/events","html_url":"https://github.com/status-im/status-react/pull/4538","id":327738292,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxNDU4NTU5","number":4538,"title":"bug #4508 - removes tokens and fiat currencies unsupported by cryptoc…","user":{"login":"goranjovic","id":711764,"node_id":"MDQ6VXNlcjcxMTc2NA==","avatar_url":"https://avatars0.githubusercontent.com/u/711764?v=4","gravatar_id":"","url":"https://api.github.com/users/goranjovic","html_url":"https://github.com/goranjovic","followers_url":"https://api.github.com/users/goranjovic/followers","following_url":"https://api.github.com/users/goranjovic/following{/other_user}","gists_url":"https://api.github.com/users/goranjovic/gists{/gist_id}","starred_url":"https://api.github.com/users/goranjovic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goranjovic/subscriptions","organizations_url":"https://api.github.com/users/goranjovic/orgs","repos_url":"https://api.github.com/users/goranjovic/repos","events_url":"https://api.github.com/users/goranjovic/events{/privacy}","received_events_url":"https://api.github.com/users/goranjovic/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"goranjovic","id":711764,"node_id":"MDQ6VXNlcjcxMTc2NA==","avatar_url":"https://avatars0.githubusercontent.com/u/711764?v=4","gravatar_id":"","url":"https://api.github.com/users/goranjovic","html_url":"https://github.com/goranjovic","followers_url":"https://api.github.com/users/goranjovic/followers","following_url":"https://api.github.com/users/goranjovic/following{/other_user}","gists_url":"https://api.github.com/users/goranjovic/gists{/gist_id}","starred_url":"https://api.github.com/users/goranjovic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goranjovic/subscriptions","organizations_url":"https://api.github.com/users/goranjovic/orgs","repos_url":"https://api.github.com/users/goranjovic/repos","events_url":"https://api.github.com/users/goranjovic/events{/privacy}","received_events_url":"https://api.github.com/users/goranjovic/received_events","type":"User","site_admin":false},"assignees":[{"login":"goranjovic","id":711764,"node_id":"MDQ6VXNlcjcxMTc2NA==","avatar_url":"https://avatars0.githubusercontent.com/u/711764?v=4","gravatar_id":"","url":"https://api.github.com/users/goranjovic","html_url":"https://github.com/goranjovic","followers_url":"https://api.github.com/users/goranjovic/followers","following_url":"https://api.github.com/users/goranjovic/following{/other_user}","gists_url":"https://api.github.com/users/goranjovic/gists{/gist_id}","starred_url":"https://api.github.com/users/goranjovic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goranjovic/subscriptions","organizations_url":"https://api.github.com/users/goranjovic/orgs","repos_url":"https://api.github.com/users/goranjovic/repos","events_url":"https://api.github.com/users/goranjovic/events{/privacy}","received_events_url":"https://api.github.com/users/goranjovic/received_events","type":"User","site_admin":false}],"milestone":null,"comments":6,"created_at":"2018-05-30T13:45:41Z","updated_at":"2018-05-31T07:36:05Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/status-im/status-react/pulls/4538","html_url":"https://github.com/status-im/status-react/pull/4538","diff_url":"https://github.com/status-im/status-react/pull/4538.diff","patch_url":"https://github.com/status-im/status-react/pull/4538.patch"},"body":"fixes #4508 \r\n\r\n### Summary:\r\n\r\nRemoves a number of tokens and currencies which are unsupported by cryptocompare. Includes a migration that sets the selected currency in Profile to USD if the previous currency was among the removed ones. Also includes a migration that deselects removed tokens from user's selection of tokens in Wallet.\r\n\r\n\"Removed\" tokens are merely removed from the selection and then hidden from the list of all possible assets. They are not deleted from the code because we still want to show any previous token transactions in the history even if we can't tell their fiat value.\r\n\r\n### Testing notes (optional):\r\n\r\nKeep an eye on migrations. Specific cases are:\r\n- when currency in Profile was one of the removed ones (should be set to USD by migration)\r\n- when currency was not among removed ones (should remain as it was)\r\n- when user had removed tokens in their selection on main Wallet screen (should be removed from both selection and Manage Assets)\r\n- when user had transactions with said tokens in Transaction history (transactions should still appear)\r\n\r\n### Steps to test:\r\n- Open Wallet and check the Token lists\r\n- Open Profile and check the fiat currencies lists\r\n\r\n\r\nstatus: ready\r\n"},"comment":{"url":"https://api.github.com/repos/status-im/status-react/issues/comments/393438266","html_url":"https://github.com/status-im/status-react/pull/4538#issuecomment-393438266","issue_url":"https://api.github.com/repos/status-im/status-react/issues/4538","id":393438266,"node_id":"MDEyOklzc3VlQ29tbWVudDM5MzQzODI2Ng==","user":{"login":"rasom","id":2364994,"node_id":"MDQ6VXNlcjIzNjQ5OTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/2364994?v=4","gravatar_id":"","url":"https://api.github.com/users/rasom","html_url":"https://github.com/rasom","followers_url":"https://api.github.com/users/rasom/followers","following_url":"https://api.github.com/users/rasom/following{/other_user}","gists_url":"https://api.github.com/users/rasom/gists{/gist_id}","starred_url":"https://api.github.com/users/rasom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rasom/subscriptions","organizations_url":"https://api.github.com/users/rasom/orgs","repos_url":"https://api.github.com/users/rasom/repos","events_url":"https://api.github.com/users/rasom/events{/privacy}","received_events_url":"https://api.github.com/users/rasom/received_events","type":"User","site_admin":false},"created_at":"2018-05-31T07:36:05Z","updated_at":"2018-05-31T07:36:05Z","author_association":"MEMBER","body":"ipa uploaded to https://i.diawi.com/4N8K3R for branch PR-4538"}}
{"actor":{"display_login":"rasom"}}