{"action":"created","issue":{"url":"https://api.github.com/repos/apache/jmeter/issues/376","repository_url":"https://api.github.com/repos/apache/jmeter","labels_url":"https://api.github.com/repos/apache/jmeter/issues/376/labels{/name}","comments_url":"https://api.github.com/repos/apache/jmeter/issues/376/comments","events_url":"https://api.github.com/repos/apache/jmeter/issues/376/events","html_url":"https://github.com/apache/jmeter/pull/376","id":297137909,"number":376,"title":"Logging of JUnitSampler exceptions","user":{"login":"dfa1","id":5798698,"avatar_url":"https://avatars1.githubusercontent.com/u/5798698?v=4","gravatar_id":"","url":"https://api.github.com/users/dfa1","html_url":"https://github.com/dfa1","followers_url":"https://api.github.com/users/dfa1/followers","following_url":"https://api.github.com/users/dfa1/following{/other_user}","gists_url":"https://api.github.com/users/dfa1/gists{/gist_id}","starred_url":"https://api.github.com/users/dfa1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dfa1/subscriptions","organizations_url":"https://api.github.com/users/dfa1/orgs","repos_url":"https://api.github.com/users/dfa1/repos","events_url":"https://api.github.com/users/dfa1/events{/privacy}","received_events_url":"https://api.github.com/users/dfa1/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-02-14T15:30:44Z","updated_at":"2018-02-15T21:41:01Z","closed_at":"2018-02-15T20:09:27Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/apache/jmeter/pulls/376","html_url":"https://github.com/apache/jmeter/pull/376","diff_url":"https://github.com/apache/jmeter/pull/376.diff","patch_url":"https://github.com/apache/jmeter/pull/376.patch"},"body":"## Description\r\nLogging of any non-assert exception generated inside a test.\r\n\r\n## Motivation and Context\r\nThe main motivation is to speedup fixing of errors inside test methods.  We have a big test suite that\r\nis run using the JUnitSampler using this pattern:\r\n\r\n```java\r\nprivate final Logger logger = LoggerFactory.getLogger(getClass());\r\n\r\n@Test\r\npublic void testName() {\r\n    try {\r\n       // test body\r\n    } catch (Exception ex) {\r\n        logger.warn(\"caught exception\", ex);\r\n        throw ex;  \r\n   }\r\n}\r\n```\r\n\r\nWith this change the code would be simpler:\r\n\r\n```java\r\n@Test\r\npublic void testName() {\r\n     // test body\r\n}\r\n\r\n```\r\n\r\n## How Has This Been Tested?\r\nStill to be tested. Since we are using jmeter-maven-plugin, we need to install the JMeter core in the local maven repository. There is a quick way to do this using ant?\r\n\r\n## Types of changes\r\n- New feature (non-breaking change which adds functionality)\r\n\r\n## Checklist:\r\n- [x] My code follows the [code style][style-guide] of this project.\r\n- [ ] I have updated the documentation accordingly.\r\n\r\n[style-guide]: https://wiki.apache.org/jmeter/CodeStyleGuidelines\r\n"},"comment":{"url":"https://api.github.com/repos/apache/jmeter/issues/comments/366070719","html_url":"https://github.com/apache/jmeter/pull/376#issuecomment-366070719","issue_url":"https://api.github.com/repos/apache/jmeter/issues/376","id":366070719,"user":{"login":"dfa1","id":5798698,"avatar_url":"https://avatars1.githubusercontent.com/u/5798698?v=4","gravatar_id":"","url":"https://api.github.com/users/dfa1","html_url":"https://github.com/dfa1","followers_url":"https://api.github.com/users/dfa1/followers","following_url":"https://api.github.com/users/dfa1/following{/other_user}","gists_url":"https://api.github.com/users/dfa1/gists{/gist_id}","starred_url":"https://api.github.com/users/dfa1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dfa1/subscriptions","organizations_url":"https://api.github.com/users/dfa1/orgs","repos_url":"https://api.github.com/users/dfa1/repos","events_url":"https://api.github.com/users/dfa1/events{/privacy}","received_events_url":"https://api.github.com/users/dfa1/received_events","type":"User","site_admin":false},"created_at":"2018-02-15T21:41:01Z","updated_at":"2018-02-15T21:41:01Z","author_association":"NONE","body":"Thanks to you for accepting this change. \r\n\r\nNaturally It would be still useful at info or debug level: the important point imho is to see the complete stacktrace when a test throws an exception.  "}}
{"actor":{"display_login":"dfa1"}}