{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/ingress-nginx/pulls/comments/188848480","pull_request_review_id":120907145,"id":188848480,"diff_hunk":"@@ -25,18 +25,12 @@ const (\n \t// This directory contains all the SSL certificates that are specified in Ingress rules.\n \t// The name of each file is <namespace>-<secret name>.pem. The content is the concatenated\n \t// certificate and key.\n-\tDefaultSSLDirectory = \"/ingress-controller/ssl\"\n+\tDefaultSSLDirectory = \"/etc/ingress-controller/ssl\"","path":"internal/file/structure.go","position":5,"original_position":5,"commit_id":"292b95007e421451f0f6332d1b78385c4d779608","original_commit_id":"292b95007e421451f0f6332d1b78385c4d779608","user":{"login":"antoineco","id":3299086,"avatar_url":"https://avatars2.githubusercontent.com/u/3299086?v=4","gravatar_id":"","url":"https://api.github.com/users/antoineco","html_url":"https://github.com/antoineco","followers_url":"https://api.github.com/users/antoineco/followers","following_url":"https://api.github.com/users/antoineco/following{/other_user}","gists_url":"https://api.github.com/users/antoineco/gists{/gist_id}","starred_url":"https://api.github.com/users/antoineco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antoineco/subscriptions","organizations_url":"https://api.github.com/users/antoineco/orgs","repos_url":"https://api.github.com/users/antoineco/repos","events_url":"https://api.github.com/users/antoineco/events{/privacy}","received_events_url":"https://api.github.com/users/antoineco/received_events","type":"User","site_admin":false},"body":"I know this is not directly related to this PR but I've been thinking, since you're making a change to the layout here, could you also set the container work directory to /etc/nginx? :)\r\nThat'd be super convenient to be able to show the config with just `kubectl exec ... -- cat nginx.conf` instead of the full path.\r\nJust a suggestion.","created_at":"2018-05-17T06:17:42Z","updated_at":"2018-05-17T06:17:55Z","html_url":"https://github.com/kubernetes/ingress-nginx/pull/2528#discussion_r188848480","pull_request_url":"https://api.github.com/repos/kubernetes/ingress-nginx/pulls/2528","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/ingress-nginx/pulls/comments/188848480"},"html":{"href":"https://github.com/kubernetes/ingress-nginx/pull/2528#discussion_r188848480"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/ingress-nginx/pulls/2528"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/ingress-nginx/pulls/2528","id":188619784,"html_url":"https://github.com/kubernetes/ingress-nginx/pull/2528","diff_url":"https://github.com/kubernetes/ingress-nginx/pull/2528.diff","patch_url":"https://github.com/kubernetes/ingress-nginx/pull/2528.patch","issue_url":"https://api.github.com/repos/kubernetes/ingress-nginx/issues/2528","number":2528,"state":"open","locked":false,"title":"Remove go-bindata","user":{"login":"aledbf","id":161571,"avatar_url":"https://avatars2.githubusercontent.com/u/161571?v=4","gravatar_id":"","url":"https://api.github.com/users/aledbf","html_url":"https://github.com/aledbf","followers_url":"https://api.github.com/users/aledbf/followers","following_url":"https://api.github.com/users/aledbf/following{/other_user}","gists_url":"https://api.github.com/users/aledbf/gists{/gist_id}","starred_url":"https://api.github.com/users/aledbf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aledbf/subscriptions","organizations_url":"https://api.github.com/users/aledbf/orgs","repos_url":"https://api.github.com/users/aledbf/repos","events_url":"https://api.github.com/users/aledbf/events{/privacy}","received_events_url":"https://api.github.com/users/aledbf/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-05-17T04:18:38Z","updated_at":"2018-05-17T06:17:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d0cb69d42dd3953a338eb8f2c8508a9d48f741c8","assignee":{"login":"ElvinEfendi","id":1150042,"avatar_url":"https://avatars0.githubusercontent.com/u/1150042?v=4","gravatar_id":"","url":"https://api.github.com/users/ElvinEfendi","html_url":"https://github.com/ElvinEfendi","followers_url":"https://api.github.com/users/ElvinEfendi/followers","following_url":"https://api.github.com/users/ElvinEfendi/following{/other_user}","gists_url":"https://api.github.com/users/ElvinEfendi/gists{/gist_id}","starred_url":"https://api.github.com/users/ElvinEfendi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ElvinEfendi/subscriptions","organizations_url":"https://api.github.com/users/ElvinEfendi/orgs","repos_url":"https://api.github.com/users/ElvinEfendi/repos","events_url":"https://api.github.com/users/ElvinEfendi/events{/privacy}","received_events_url":"https://api.github.com/users/ElvinEfendi/received_events","type":"User","site_admin":false},"assignees":[{"login":"ElvinEfendi","id":1150042,"avatar_url":"https://avatars0.githubusercontent.com/u/1150042?v=4","gravatar_id":"","url":"https://api.github.com/users/ElvinEfendi","html_url":"https://github.com/ElvinEfendi","followers_url":"https://api.github.com/users/ElvinEfendi/followers","following_url":"https://api.github.com/users/ElvinEfendi/following{/other_user}","gists_url":"https://api.github.com/users/ElvinEfendi/gists{/gist_id}","starred_url":"https://api.github.com/users/ElvinEfendi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ElvinEfendi/subscriptions","organizations_url":"https://api.github.com/users/ElvinEfendi/orgs","repos_url":"https://api.github.com/users/ElvinEfendi/repos","events_url":"https://api.github.com/users/ElvinEfendi/events{/privacy}","received_events_url":"https://api.github.com/users/ElvinEfendi/received_events","type":"User","site_admin":false},{"login":"antoineco","id":3299086,"avatar_url":"https://avatars2.githubusercontent.com/u/3299086?v=4","gravatar_id":"","url":"https://api.github.com/users/antoineco","html_url":"https://github.com/antoineco","followers_url":"https://api.github.com/users/antoineco/followers","following_url":"https://api.github.com/users/antoineco/following{/other_user}","gists_url":"https://api.github.com/users/antoineco/gists{/gist_id}","starred_url":"https://api.github.com/users/antoineco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antoineco/subscriptions","organizations_url":"https://api.github.com/users/antoineco/orgs","repos_url":"https://api.github.com/users/antoineco/repos","events_url":"https://api.github.com/users/antoineco/events{/privacy}","received_events_url":"https://api.github.com/users/antoineco/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":764356976,"url":"https://api.github.com/repos/kubernetes/ingress-nginx/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":486873161,"url":"https://api.github.com/repos/kubernetes/ingress-nginx/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":679219493,"url":"https://api.github.com/repos/kubernetes/ingress-nginx/labels/size/XL","name":"size/XL","color":"ee5500","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/ingress-nginx/pulls/2528/commits","review_comments_url":"https://api.github.com/repos/kubernetes/ingress-nginx/pulls/2528/comments","review_comment_url":"https://api.github.com/repos/kubernetes/ingress-nginx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/ingress-nginx/issues/2528/comments","statuses_url":"https://api.github.com/repos/kubernetes/ingress-nginx/statuses/292b95007e421451f0f6332d1b78385c4d779608","head":{"label":"aledbf:remove-go-bindata","ref":"remove-go-bindata","sha":"292b95007e421451f0f6332d1b78385c4d779608","user":{"login":"aledbf","id":161571,"avatar_url":"https://avatars2.githubusercontent.com/u/161571?v=4","gravatar_id":"","url":"https://api.github.com/users/aledbf","html_url":"https://github.com/aledbf","followers_url":"https://api.github.com/users/aledbf/followers","following_url":"https://api.github.com/users/aledbf/following{/other_user}","gists_url":"https://api.github.com/users/aledbf/gists{/gist_id}","starred_url":"https://api.github.com/users/aledbf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aledbf/subscriptions","organizations_url":"https://api.github.com/users/aledbf/orgs","repos_url":"https://api.github.com/users/aledbf/repos","events_url":"https://api.github.com/users/aledbf/events{/privacy}","received_events_url":"https://api.github.com/users/aledbf/received_events","type":"User","site_admin":false},"repo":{"id":72895783,"name":"ingress-nginx","full_name":"aledbf/ingress-nginx","owner":{"login":"aledbf","id":161571,"avatar_url":"https://avatars2.githubusercontent.com/u/161571?v=4","gravatar_id":"","url":"https://api.github.com/users/aledbf","html_url":"https://github.com/aledbf","followers_url":"https://api.github.com/users/aledbf/followers","following_url":"https://api.github.com/users/aledbf/following{/other_user}","gists_url":"https://api.github.com/users/aledbf/gists{/gist_id}","starred_url":"https://api.github.com/users/aledbf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aledbf/subscriptions","organizations_url":"https://api.github.com/users/aledbf/orgs","repos_url":"https://api.github.com/users/aledbf/repos","events_url":"https://api.github.com/users/aledbf/events{/privacy}","received_events_url":"https://api.github.com/users/aledbf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aledbf/ingress-nginx","description":"Ingress controllers","fork":true,"url":"https://api.github.com/repos/aledbf/ingress-nginx","forks_url":"https://api.github.com/repos/aledbf/ingress-nginx/forks","keys_url":"https://api.github.com/repos/aledbf/ingress-nginx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aledbf/ingress-nginx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aledbf/ingress-nginx/teams","hooks_url":"https://api.github.com/repos/aledbf/ingress-nginx/hooks","issue_events_url":"https://api.github.com/repos/aledbf/ingress-nginx/issues/events{/number}","events_url":"https://api.github.com/repos/aledbf/ingress-nginx/events","assignees_url":"https://api.github.com/repos/aledbf/ingress-nginx/assignees{/user}","branches_url":"https://api.github.com/repos/aledbf/ingress-nginx/branches{/branch}","tags_url":"https://api.github.com/repos/aledbf/ingress-nginx/tags","blobs_url":"https://api.github.com/repos/aledbf/ingress-nginx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aledbf/ingress-nginx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aledbf/ingress-nginx/git/refs{/sha}","trees_url":"https://api.github.com/repos/aledbf/ingress-nginx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aledbf/ingress-nginx/statuses/{sha}","languages_url":"https://api.github.com/repos/aledbf/ingress-nginx/languages","stargazers_url":"https://api.github.com/repos/aledbf/ingress-nginx/stargazers","contributors_url":"https://api.github.com/repos/aledbf/ingress-nginx/contributors","subscribers_url":"https://api.github.com/repos/aledbf/ingress-nginx/subscribers","subscription_url":"https://api.github.com/repos/aledbf/ingress-nginx/subscription","commits_url":"https://api.github.com/repos/aledbf/ingress-nginx/commits{/sha}","git_commits_url":"https://api.github.com/repos/aledbf/ingress-nginx/git/commits{/sha}","comments_url":"https://api.github.com/repos/aledbf/ingress-nginx/comments{/number}","issue_comment_url":"https://api.github.com/repos/aledbf/ingress-nginx/issues/comments{/number}","contents_url":"https://api.github.com/repos/aledbf/ingress-nginx/contents/{+path}","compare_url":"https://api.github.com/repos/aledbf/ingress-nginx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aledbf/ingress-nginx/merges","archive_url":"https://api.github.com/repos/aledbf/ingress-nginx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aledbf/ingress-nginx/downloads","issues_url":"https://api.github.com/repos/aledbf/ingress-nginx/issues{/number}","pulls_url":"https://api.github.com/repos/aledbf/ingress-nginx/pulls{/number}","milestones_url":"https://api.github.com/repos/aledbf/ingress-nginx/milestones{/number}","notifications_url":"https://api.github.com/repos/aledbf/ingress-nginx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aledbf/ingress-nginx/labels{/name}","releases_url":"https://api.github.com/repos/aledbf/ingress-nginx/releases{/id}","deployments_url":"https://api.github.com/repos/aledbf/ingress-nginx/deployments","created_at":"2016-11-05T00:39:04Z","updated_at":"2018-05-17T02:41:39Z","pushed_at":"2018-05-17T05:11:35Z","git_url":"git://github.com/aledbf/ingress-nginx.git","ssh_url":"git@github.com:aledbf/ingress-nginx.git","clone_url":"https://github.com/aledbf/ingress-nginx.git","svn_url":"https://github.com/aledbf/ingress-nginx","homepage":null,"size":76542,"stargazers_count":4,"watchers_count":4,"language":"Go","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1,"open_issues":0,"watchers":4,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"ee7a63d0501af13aa79a76b3a1cd8439d8ead086","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":72891330,"name":"ingress-nginx","full_name":"kubernetes/ingress-nginx","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/ingress-nginx","description":"NGINX Ingress Controller for Kubernetes","fork":false,"url":"https://api.github.com/repos/kubernetes/ingress-nginx","forks_url":"https://api.github.com/repos/kubernetes/ingress-nginx/forks","keys_url":"https://api.github.com/repos/kubernetes/ingress-nginx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/ingress-nginx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/ingress-nginx/teams","hooks_url":"https://api.github.com/repos/kubernetes/ingress-nginx/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/ingress-nginx/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/ingress-nginx/events","assignees_url":"https://api.github.com/repos/kubernetes/ingress-nginx/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/ingress-nginx/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/ingress-nginx/tags","blobs_url":"https://api.github.com/repos/kubernetes/ingress-nginx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/ingress-nginx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/ingress-nginx/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/ingress-nginx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/ingress-nginx/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/ingress-nginx/languages","stargazers_url":"https://api.github.com/repos/kubernetes/ingress-nginx/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/ingress-nginx/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/ingress-nginx/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/ingress-nginx/subscription","commits_url":"https://api.github.com/repos/kubernetes/ingress-nginx/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/ingress-nginx/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/ingress-nginx/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/ingress-nginx/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/ingress-nginx/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/ingress-nginx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/ingress-nginx/merges","archive_url":"https://api.github.com/repos/kubernetes/ingress-nginx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/ingress-nginx/downloads","issues_url":"https://api.github.com/repos/kubernetes/ingress-nginx/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/ingress-nginx/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/ingress-nginx/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/ingress-nginx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/ingress-nginx/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/ingress-nginx/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/ingress-nginx/deployments","created_at":"2016-11-04T22:54:14Z","updated_at":"2018-05-17T02:14:55Z","pushed_at":"2018-05-17T05:11:37Z","git_url":"git://github.com/kubernetes/ingress-nginx.git","ssh_url":"git@github.com:kubernetes/ingress-nginx.git","clone_url":"https://github.com/kubernetes/ingress-nginx.git","svn_url":"https://github.com/kubernetes/ingress-nginx","homepage":"","size":77603,"stargazers_count":1930,"watchers_count":1930,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1063,"mirror_url":null,"archived":false,"open_issues_count":117,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1063,"open_issues":117,"watchers":1930,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/ingress-nginx/pulls/2528"},"html":{"href":"https://github.com/kubernetes/ingress-nginx/pull/2528"},"issue":{"href":"https://api.github.com/repos/kubernetes/ingress-nginx/issues/2528"},"comments":{"href":"https://api.github.com/repos/kubernetes/ingress-nginx/issues/2528/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/ingress-nginx/pulls/2528/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/ingress-nginx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/ingress-nginx/pulls/2528/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/ingress-nginx/statuses/292b95007e421451f0f6332d1b78385c4d779608"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"antoineco"}}