{"action":"created","comment":{"url":"https://api.github.com/repos/apache/kafka/pulls/comments/182271764","pull_request_review_id":113035884,"id":182271764,"diff_hunk":"@@ -300,9 +300,9 @@ public void poll(long now, long remainingMs) {\n             // awaitMetadataUpdate() initiates new connections with configured backoff and avoids the busy loop.\n             // When group management is used, metadata wait is already performed for this scenario as\n             // coordinator is unknown, hence this check is not required.\n-            if (metadata.updateRequested() && !client.hasReadyNodes()) {\n+            if (metadata.updateRequested() && !client.hasReadyNodes(time.milliseconds())) {","path":"clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java","position":null,"original_position":5,"commit_id":"5496dd98bd9b2ae27f33a050067e395fe359ca77","original_commit_id":"28bec319627b501cca83a8522f0e0c181922f9bd","user":{"login":"jonlee2","id":35585830,"avatar_url":"https://avatars3.githubusercontent.com/u/35585830?v=4","gravatar_id":"","url":"https://api.github.com/users/jonlee2","html_url":"https://github.com/jonlee2","followers_url":"https://api.github.com/users/jonlee2/followers","following_url":"https://api.github.com/users/jonlee2/following{/other_user}","gists_url":"https://api.github.com/users/jonlee2/gists{/gist_id}","starred_url":"https://api.github.com/users/jonlee2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonlee2/subscriptions","organizations_url":"https://api.github.com/users/jonlee2/orgs","repos_url":"https://api.github.com/users/jonlee2/repos","events_url":"https://api.github.com/users/jonlee2/events{/privacy}","received_events_url":"https://api.github.com/users/jonlee2/received_events","type":"User","site_admin":false},"body":"Done","created_at":"2018-04-17T23:31:52Z","updated_at":"2018-04-17T23:31:52Z","html_url":"https://github.com/apache/kafka/pull/4830#discussion_r182271764","pull_request_url":"https://api.github.com/repos/apache/kafka/pulls/4830","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments/182271764"},"html":{"href":"https://github.com/apache/kafka/pull/4830#discussion_r182271764"},"pull_request":{"href":"https://api.github.com/repos/apache/kafka/pulls/4830"}},"in_reply_to_id":180682137},"pull_request":{"url":"https://api.github.com/repos/apache/kafka/pulls/4830","id":179821025,"html_url":"https://github.com/apache/kafka/pull/4830","diff_url":"https://github.com/apache/kafka/pull/4830.diff","patch_url":"https://github.com/apache/kafka/pull/4830.patch","issue_url":"https://api.github.com/repos/apache/kafka/issues/4830","number":4830,"state":"open","locked":false,"title":"KAFKA-6028: Improve the quota throttle communication (KIP-219)","user":{"login":"jonlee2","id":35585830,"avatar_url":"https://avatars3.githubusercontent.com/u/35585830?v=4","gravatar_id":"","url":"https://api.github.com/users/jonlee2","html_url":"https://github.com/jonlee2","followers_url":"https://api.github.com/users/jonlee2/followers","following_url":"https://api.github.com/users/jonlee2/following{/other_user}","gists_url":"https://api.github.com/users/jonlee2/gists{/gist_id}","starred_url":"https://api.github.com/users/jonlee2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonlee2/subscriptions","organizations_url":"https://api.github.com/users/jonlee2/orgs","repos_url":"https://api.github.com/users/jonlee2/repos","events_url":"https://api.github.com/users/jonlee2/events{/privacy}","received_events_url":"https://api.github.com/users/jonlee2/received_events","type":"User","site_admin":false},"body":"This implements KIP-219, where a broker return a response with throttle time on quota violation immediately after processing the corresponding request. After the response is sent out, the broker will keep the channel muted until the throttle time is over. Also, on receiving a response with throttle time, client will also block outgoing communication to the broker for the specified throttle time.\r\n\r\nIn the original KIP, it was stated that \"In order to let the clients know whether the received response is already throttled or not, we will need to bump up all the related request version.\" However, after further discussion with @lindong28 and @becketqin, it was decided to bump up the protocol version of ApiVersionsRequest/Response only, which should be sufficient to detect the throttling behavior of the brokers that each client communicate with. \r\n\r\nInitial review was done by @lindong28. \r\n\r\n### Committer Checklist (excluded from commit message)\r\n- [ ] Verify design and implementation \r\n- [ ] Verify test coverage and CI build status\r\n- [ ] Verify documentation (including upgrade notes)\r\n","created_at":"2018-04-05T23:18:15Z","updated_at":"2018-04-17T23:31:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5250e92252c56b64b5a1f635d367095af3ac920f","assignee":{"login":"lindong28","id":5873403,"avatar_url":"https://avatars0.githubusercontent.com/u/5873403?v=4","gravatar_id":"","url":"https://api.github.com/users/lindong28","html_url":"https://github.com/lindong28","followers_url":"https://api.github.com/users/lindong28/followers","following_url":"https://api.github.com/users/lindong28/following{/other_user}","gists_url":"https://api.github.com/users/lindong28/gists{/gist_id}","starred_url":"https://api.github.com/users/lindong28/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lindong28/subscriptions","organizations_url":"https://api.github.com/users/lindong28/orgs","repos_url":"https://api.github.com/users/lindong28/repos","events_url":"https://api.github.com/users/lindong28/events{/privacy}","received_events_url":"https://api.github.com/users/lindong28/received_events","type":"User","site_admin":false},"assignees":[{"login":"lindong28","id":5873403,"avatar_url":"https://avatars0.githubusercontent.com/u/5873403?v=4","gravatar_id":"","url":"https://api.github.com/users/lindong28","html_url":"https://github.com/lindong28","followers_url":"https://api.github.com/users/lindong28/followers","following_url":"https://api.github.com/users/lindong28/following{/other_user}","gists_url":"https://api.github.com/users/lindong28/gists{/gist_id}","starred_url":"https://api.github.com/users/lindong28/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lindong28/subscriptions","organizations_url":"https://api.github.com/users/lindong28/orgs","repos_url":"https://api.github.com/users/lindong28/repos","events_url":"https://api.github.com/users/lindong28/events{/privacy}","received_events_url":"https://api.github.com/users/lindong28/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/kafka/pulls/4830/commits","review_comments_url":"https://api.github.com/repos/apache/kafka/pulls/4830/comments","review_comment_url":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/kafka/issues/4830/comments","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/5496dd98bd9b2ae27f33a050067e395fe359ca77","head":{"label":"jonlee2:trunk","ref":"trunk","sha":"5496dd98bd9b2ae27f33a050067e395fe359ca77","user":{"login":"jonlee2","id":35585830,"avatar_url":"https://avatars3.githubusercontent.com/u/35585830?v=4","gravatar_id":"","url":"https://api.github.com/users/jonlee2","html_url":"https://github.com/jonlee2","followers_url":"https://api.github.com/users/jonlee2/followers","following_url":"https://api.github.com/users/jonlee2/following{/other_user}","gists_url":"https://api.github.com/users/jonlee2/gists{/gist_id}","starred_url":"https://api.github.com/users/jonlee2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonlee2/subscriptions","organizations_url":"https://api.github.com/users/jonlee2/orgs","repos_url":"https://api.github.com/users/jonlee2/repos","events_url":"https://api.github.com/users/jonlee2/events{/privacy}","received_events_url":"https://api.github.com/users/jonlee2/received_events","type":"User","site_admin":false},"repo":{"id":118066110,"name":"kafka","full_name":"jonlee2/kafka","owner":{"login":"jonlee2","id":35585830,"avatar_url":"https://avatars3.githubusercontent.com/u/35585830?v=4","gravatar_id":"","url":"https://api.github.com/users/jonlee2","html_url":"https://github.com/jonlee2","followers_url":"https://api.github.com/users/jonlee2/followers","following_url":"https://api.github.com/users/jonlee2/following{/other_user}","gists_url":"https://api.github.com/users/jonlee2/gists{/gist_id}","starred_url":"https://api.github.com/users/jonlee2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonlee2/subscriptions","organizations_url":"https://api.github.com/users/jonlee2/orgs","repos_url":"https://api.github.com/users/jonlee2/repos","events_url":"https://api.github.com/users/jonlee2/events{/privacy}","received_events_url":"https://api.github.com/users/jonlee2/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jonlee2/kafka","description":"Mirror of Apache Kafka","fork":true,"url":"https://api.github.com/repos/jonlee2/kafka","forks_url":"https://api.github.com/repos/jonlee2/kafka/forks","keys_url":"https://api.github.com/repos/jonlee2/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jonlee2/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jonlee2/kafka/teams","hooks_url":"https://api.github.com/repos/jonlee2/kafka/hooks","issue_events_url":"https://api.github.com/repos/jonlee2/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/jonlee2/kafka/events","assignees_url":"https://api.github.com/repos/jonlee2/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/jonlee2/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/jonlee2/kafka/tags","blobs_url":"https://api.github.com/repos/jonlee2/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jonlee2/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jonlee2/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/jonlee2/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jonlee2/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/jonlee2/kafka/languages","stargazers_url":"https://api.github.com/repos/jonlee2/kafka/stargazers","contributors_url":"https://api.github.com/repos/jonlee2/kafka/contributors","subscribers_url":"https://api.github.com/repos/jonlee2/kafka/subscribers","subscription_url":"https://api.github.com/repos/jonlee2/kafka/subscription","commits_url":"https://api.github.com/repos/jonlee2/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/jonlee2/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/jonlee2/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/jonlee2/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/jonlee2/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/jonlee2/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jonlee2/kafka/merges","archive_url":"https://api.github.com/repos/jonlee2/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jonlee2/kafka/downloads","issues_url":"https://api.github.com/repos/jonlee2/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/jonlee2/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/jonlee2/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/jonlee2/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jonlee2/kafka/labels{/name}","releases_url":"https://api.github.com/repos/jonlee2/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/jonlee2/kafka/deployments","created_at":"2018-01-19T02:31:48Z","updated_at":"2018-04-17T23:17:30Z","pushed_at":"2018-04-17T23:17:27Z","git_url":"git://github.com/jonlee2/kafka.git","ssh_url":"git@github.com:jonlee2/kafka.git","clone_url":"https://github.com/jonlee2/kafka.git","svn_url":"https://github.com/jonlee2/kafka","homepage":null,"size":63608,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"trunk"}},"base":{"label":"apache:trunk","ref":"trunk","sha":"ac9c3ed0b43ee848e6e555a01c55ea2eee78540a","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":2211243,"name":"kafka","full_name":"apache/kafka","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/kafka","description":"Mirror of Apache Kafka","fork":false,"url":"https://api.github.com/repos/apache/kafka","forks_url":"https://api.github.com/repos/apache/kafka/forks","keys_url":"https://api.github.com/repos/apache/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/kafka/teams","hooks_url":"https://api.github.com/repos/apache/kafka/hooks","issue_events_url":"https://api.github.com/repos/apache/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/apache/kafka/events","assignees_url":"https://api.github.com/repos/apache/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/apache/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/apache/kafka/tags","blobs_url":"https://api.github.com/repos/apache/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/kafka/languages","stargazers_url":"https://api.github.com/repos/apache/kafka/stargazers","contributors_url":"https://api.github.com/repos/apache/kafka/contributors","subscribers_url":"https://api.github.com/repos/apache/kafka/subscribers","subscription_url":"https://api.github.com/repos/apache/kafka/subscription","commits_url":"https://api.github.com/repos/apache/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/apache/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/kafka/merges","archive_url":"https://api.github.com/repos/apache/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/kafka/downloads","issues_url":"https://api.github.com/repos/apache/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/apache/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/kafka/labels{/name}","releases_url":"https://api.github.com/repos/apache/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/apache/kafka/deployments","created_at":"2011-08-15T18:06:16Z","updated_at":"2018-04-17T22:08:22Z","pushed_at":"2018-04-17T23:17:30Z","git_url":"git://github.com/apache/kafka.git","ssh_url":"git@github.com:apache/kafka.git","clone_url":"https://github.com/apache/kafka.git","svn_url":"https://github.com/apache/kafka","homepage":null,"size":64100,"stargazers_count":8008,"watchers_count":8008,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4725,"mirror_url":null,"archived":false,"open_issues_count":449,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":4725,"open_issues":449,"watchers":8008,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/4830"},"html":{"href":"https://github.com/apache/kafka/pull/4830"},"issue":{"href":"https://api.github.com/repos/apache/kafka/issues/4830"},"comments":{"href":"https://api.github.com/repos/apache/kafka/issues/4830/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/kafka/pulls/4830/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/kafka/pulls/4830/commits"},"statuses":{"href":"https://api.github.com/repos/apache/kafka/statuses/5496dd98bd9b2ae27f33a050067e395fe359ca77"}},"author_association":"NONE"}}
{"actor":{"display_login":"jonlee2"}}