{"action":"created","comment":{"url":"https://api.github.com/repos/cilium/cilium/pulls/comments/168639263","pull_request_review_id":97042649,"id":168639263,"diff_hunk":"@@ -79,7 +79,7 @@ all: clean-bins release\n else\n BAZEL_BUILD_OPTS =\n \n-all: clean-bins envoy $(GO_TARGETS)\n+all: envoy $(GO_TARGETS)","path":"envoy/Makefile","position":14,"original_position":14,"commit_id":"b5f7c56619252e178954881683d94acc3770cf07","original_commit_id":"b5f7c56619252e178954881683d94acc3770cf07","user":{"login":"joestringer","id":1243336,"avatar_url":"https://avatars2.githubusercontent.com/u/1243336?v=4","gravatar_id":"","url":"https://api.github.com/users/joestringer","html_url":"https://github.com/joestringer","followers_url":"https://api.github.com/users/joestringer/followers","following_url":"https://api.github.com/users/joestringer/following{/other_user}","gists_url":"https://api.github.com/users/joestringer/gists{/gist_id}","starred_url":"https://api.github.com/users/joestringer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joestringer/subscriptions","organizations_url":"https://api.github.com/users/joestringer/orgs","repos_url":"https://api.github.com/users/joestringer/repos","events_url":"https://api.github.com/users/joestringer/events{/privacy}","received_events_url":"https://api.github.com/users/joestringer/received_events","type":"User","site_admin":false},"body":"Ah. In my setup, this saves an extra few seconds. Probably if I really want to get those back I'd need to look at introducing an option to avoid the version check. I don't plan on doing that at this stage.","created_at":"2018-02-15T23:23:28Z","updated_at":"2018-02-15T23:23:28Z","html_url":"https://github.com/cilium/cilium/pull/2828#discussion_r168639263","pull_request_url":"https://api.github.com/repos/cilium/cilium/pulls/2828","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/cilium/cilium/pulls/comments/168639263"},"html":{"href":"https://github.com/cilium/cilium/pull/2828#discussion_r168639263"},"pull_request":{"href":"https://api.github.com/repos/cilium/cilium/pulls/2828"}},"in_reply_to_id":168638154},"pull_request":{"url":"https://api.github.com/repos/cilium/cilium/pulls/2828","id":169437022,"html_url":"https://github.com/cilium/cilium/pull/2828","diff_url":"https://github.com/cilium/cilium/pull/2828.diff","patch_url":"https://github.com/cilium/cilium/pull/2828.patch","issue_url":"https://api.github.com/repos/cilium/cilium/issues/2828","number":2828,"state":"open","locked":false,"title":"Cache bazel to speed up build","user":{"login":"joestringer","id":1243336,"avatar_url":"https://avatars2.githubusercontent.com/u/1243336?v=4","gravatar_id":"","url":"https://api.github.com/users/joestringer","html_url":"https://github.com/joestringer","followers_url":"https://api.github.com/users/joestringer/followers","following_url":"https://api.github.com/users/joestringer/following{/other_user}","gists_url":"https://api.github.com/users/joestringer/gists{/gist_id}","starred_url":"https://api.github.com/users/joestringer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joestringer/subscriptions","organizations_url":"https://api.github.com/users/joestringer/orgs","repos_url":"https://api.github.com/users/joestringer/repos","events_url":"https://api.github.com/users/joestringer/events{/privacy}","received_events_url":"https://api.github.com/users/joestringer/received_events","type":"User","site_admin":false},"body":"Previously we have used the '--batch' bazel option to ensure that the\r\nbazel daemon is not running after building cilium. However, if bazel\r\ndoesn't continue running, then we don't make use of its build caching\r\neither. Remove the `--batch` option to speed up builds. Also, don't\r\nalways clean the binary; that will force rebuild and slow down builds.\r\n    \r\nIn local builds, this shaves as much as 20s off build time.\r\n","created_at":"2018-02-15T17:33:11Z","updated_at":"2018-02-15T23:23:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4a7be77eabc52c1f648c6bbe4497a860b0f36c00","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":722357775,"url":"https://api.github.com/repos/cilium/cilium/labels/area/misc","name":"area/misc","color":"49e59c","default":false},{"id":403244562,"url":"https://api.github.com/repos/cilium/cilium/labels/wip","name":"wip","color":"fef2c0","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/cilium/cilium/pulls/2828/commits","review_comments_url":"https://api.github.com/repos/cilium/cilium/pulls/2828/comments","review_comment_url":"https://api.github.com/repos/cilium/cilium/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cilium/cilium/issues/2828/comments","statuses_url":"https://api.github.com/repos/cilium/cilium/statuses/b5f7c56619252e178954881683d94acc3770cf07","head":{"label":"joestringer:submit/bazel","ref":"submit/bazel","sha":"b5f7c56619252e178954881683d94acc3770cf07","user":{"login":"joestringer","id":1243336,"avatar_url":"https://avatars2.githubusercontent.com/u/1243336?v=4","gravatar_id":"","url":"https://api.github.com/users/joestringer","html_url":"https://github.com/joestringer","followers_url":"https://api.github.com/users/joestringer/followers","following_url":"https://api.github.com/users/joestringer/following{/other_user}","gists_url":"https://api.github.com/users/joestringer/gists{/gist_id}","starred_url":"https://api.github.com/users/joestringer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joestringer/subscriptions","organizations_url":"https://api.github.com/users/joestringer/orgs","repos_url":"https://api.github.com/users/joestringer/repos","events_url":"https://api.github.com/users/joestringer/events{/privacy}","received_events_url":"https://api.github.com/users/joestringer/received_events","type":"User","site_admin":false},"repo":{"id":103188387,"name":"cilium","full_name":"joestringer/cilium","owner":{"login":"joestringer","id":1243336,"avatar_url":"https://avatars2.githubusercontent.com/u/1243336?v=4","gravatar_id":"","url":"https://api.github.com/users/joestringer","html_url":"https://github.com/joestringer","followers_url":"https://api.github.com/users/joestringer/followers","following_url":"https://api.github.com/users/joestringer/following{/other_user}","gists_url":"https://api.github.com/users/joestringer/gists{/gist_id}","starred_url":"https://api.github.com/users/joestringer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joestringer/subscriptions","organizations_url":"https://api.github.com/users/joestringer/orgs","repos_url":"https://api.github.com/users/joestringer/repos","events_url":"https://api.github.com/users/joestringer/events{/privacy}","received_events_url":"https://api.github.com/users/joestringer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/joestringer/cilium","description":"Linux Native, HTTP Aware Networking and Security for Containers","fork":true,"url":"https://api.github.com/repos/joestringer/cilium","forks_url":"https://api.github.com/repos/joestringer/cilium/forks","keys_url":"https://api.github.com/repos/joestringer/cilium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joestringer/cilium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joestringer/cilium/teams","hooks_url":"https://api.github.com/repos/joestringer/cilium/hooks","issue_events_url":"https://api.github.com/repos/joestringer/cilium/issues/events{/number}","events_url":"https://api.github.com/repos/joestringer/cilium/events","assignees_url":"https://api.github.com/repos/joestringer/cilium/assignees{/user}","branches_url":"https://api.github.com/repos/joestringer/cilium/branches{/branch}","tags_url":"https://api.github.com/repos/joestringer/cilium/tags","blobs_url":"https://api.github.com/repos/joestringer/cilium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joestringer/cilium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joestringer/cilium/git/refs{/sha}","trees_url":"https://api.github.com/repos/joestringer/cilium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joestringer/cilium/statuses/{sha}","languages_url":"https://api.github.com/repos/joestringer/cilium/languages","stargazers_url":"https://api.github.com/repos/joestringer/cilium/stargazers","contributors_url":"https://api.github.com/repos/joestringer/cilium/contributors","subscribers_url":"https://api.github.com/repos/joestringer/cilium/subscribers","subscription_url":"https://api.github.com/repos/joestringer/cilium/subscription","commits_url":"https://api.github.com/repos/joestringer/cilium/commits{/sha}","git_commits_url":"https://api.github.com/repos/joestringer/cilium/git/commits{/sha}","comments_url":"https://api.github.com/repos/joestringer/cilium/comments{/number}","issue_comment_url":"https://api.github.com/repos/joestringer/cilium/issues/comments{/number}","contents_url":"https://api.github.com/repos/joestringer/cilium/contents/{+path}","compare_url":"https://api.github.com/repos/joestringer/cilium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joestringer/cilium/merges","archive_url":"https://api.github.com/repos/joestringer/cilium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joestringer/cilium/downloads","issues_url":"https://api.github.com/repos/joestringer/cilium/issues{/number}","pulls_url":"https://api.github.com/repos/joestringer/cilium/pulls{/number}","milestones_url":"https://api.github.com/repos/joestringer/cilium/milestones{/number}","notifications_url":"https://api.github.com/repos/joestringer/cilium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joestringer/cilium/labels{/name}","releases_url":"https://api.github.com/repos/joestringer/cilium/releases{/id}","deployments_url":"https://api.github.com/repos/joestringer/cilium/deployments","created_at":"2017-09-11T21:09:05Z","updated_at":"2017-09-11T21:09:08Z","pushed_at":"2018-02-15T23:14:37Z","git_url":"git://github.com/joestringer/cilium.git","ssh_url":"git@github.com:joestringer/cilium.git","clone_url":"https://github.com/joestringer/cilium.git","svn_url":"https://github.com/joestringer/cilium","homepage":"","size":39199,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cilium:master","ref":"master","sha":"9ad6ebd8f4267b05009306f8c4547e25f32d13b5","user":{"login":"cilium","id":21054566,"avatar_url":"https://avatars0.githubusercontent.com/u/21054566?v=4","gravatar_id":"","url":"https://api.github.com/users/cilium","html_url":"https://github.com/cilium","followers_url":"https://api.github.com/users/cilium/followers","following_url":"https://api.github.com/users/cilium/following{/other_user}","gists_url":"https://api.github.com/users/cilium/gists{/gist_id}","starred_url":"https://api.github.com/users/cilium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cilium/subscriptions","organizations_url":"https://api.github.com/users/cilium/orgs","repos_url":"https://api.github.com/users/cilium/repos","events_url":"https://api.github.com/users/cilium/events{/privacy}","received_events_url":"https://api.github.com/users/cilium/received_events","type":"Organization","site_admin":false},"repo":{"id":48109239,"name":"cilium","full_name":"cilium/cilium","owner":{"login":"cilium","id":21054566,"avatar_url":"https://avatars0.githubusercontent.com/u/21054566?v=4","gravatar_id":"","url":"https://api.github.com/users/cilium","html_url":"https://github.com/cilium","followers_url":"https://api.github.com/users/cilium/followers","following_url":"https://api.github.com/users/cilium/following{/other_user}","gists_url":"https://api.github.com/users/cilium/gists{/gist_id}","starred_url":"https://api.github.com/users/cilium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cilium/subscriptions","organizations_url":"https://api.github.com/users/cilium/orgs","repos_url":"https://api.github.com/users/cilium/repos","events_url":"https://api.github.com/users/cilium/events{/privacy}","received_events_url":"https://api.github.com/users/cilium/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cilium/cilium","description":"API-aware Networking and Security for Containers based on BPF","fork":false,"url":"https://api.github.com/repos/cilium/cilium","forks_url":"https://api.github.com/repos/cilium/cilium/forks","keys_url":"https://api.github.com/repos/cilium/cilium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cilium/cilium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cilium/cilium/teams","hooks_url":"https://api.github.com/repos/cilium/cilium/hooks","issue_events_url":"https://api.github.com/repos/cilium/cilium/issues/events{/number}","events_url":"https://api.github.com/repos/cilium/cilium/events","assignees_url":"https://api.github.com/repos/cilium/cilium/assignees{/user}","branches_url":"https://api.github.com/repos/cilium/cilium/branches{/branch}","tags_url":"https://api.github.com/repos/cilium/cilium/tags","blobs_url":"https://api.github.com/repos/cilium/cilium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cilium/cilium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cilium/cilium/git/refs{/sha}","trees_url":"https://api.github.com/repos/cilium/cilium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cilium/cilium/statuses/{sha}","languages_url":"https://api.github.com/repos/cilium/cilium/languages","stargazers_url":"https://api.github.com/repos/cilium/cilium/stargazers","contributors_url":"https://api.github.com/repos/cilium/cilium/contributors","subscribers_url":"https://api.github.com/repos/cilium/cilium/subscribers","subscription_url":"https://api.github.com/repos/cilium/cilium/subscription","commits_url":"https://api.github.com/repos/cilium/cilium/commits{/sha}","git_commits_url":"https://api.github.com/repos/cilium/cilium/git/commits{/sha}","comments_url":"https://api.github.com/repos/cilium/cilium/comments{/number}","issue_comment_url":"https://api.github.com/repos/cilium/cilium/issues/comments{/number}","contents_url":"https://api.github.com/repos/cilium/cilium/contents/{+path}","compare_url":"https://api.github.com/repos/cilium/cilium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cilium/cilium/merges","archive_url":"https://api.github.com/repos/cilium/cilium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cilium/cilium/downloads","issues_url":"https://api.github.com/repos/cilium/cilium/issues{/number}","pulls_url":"https://api.github.com/repos/cilium/cilium/pulls{/number}","milestones_url":"https://api.github.com/repos/cilium/cilium/milestones{/number}","notifications_url":"https://api.github.com/repos/cilium/cilium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cilium/cilium/labels{/name}","releases_url":"https://api.github.com/repos/cilium/cilium/releases{/id}","deployments_url":"https://api.github.com/repos/cilium/cilium/deployments","created_at":"2015-12-16T12:33:31Z","updated_at":"2018-02-15T22:10:19Z","pushed_at":"2018-02-15T23:14:39Z","git_url":"git://github.com/cilium/cilium.git","ssh_url":"git@github.com:cilium/cilium.git","clone_url":"https://github.com/cilium/cilium.git","svn_url":"https://github.com/cilium/cilium","homepage":"","size":41419,"stargazers_count":1462,"watchers_count":1462,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":147,"mirror_url":null,"archived":false,"open_issues_count":369,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":147,"open_issues":369,"watchers":1462,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cilium/cilium/pulls/2828"},"html":{"href":"https://github.com/cilium/cilium/pull/2828"},"issue":{"href":"https://api.github.com/repos/cilium/cilium/issues/2828"},"comments":{"href":"https://api.github.com/repos/cilium/cilium/issues/2828/comments"},"review_comments":{"href":"https://api.github.com/repos/cilium/cilium/pulls/2828/comments"},"review_comment":{"href":"https://api.github.com/repos/cilium/cilium/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cilium/cilium/pulls/2828/commits"},"statuses":{"href":"https://api.github.com/repos/cilium/cilium/statuses/b5f7c56619252e178954881683d94acc3770cf07"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"joestringer"}}