{"action":"closed","number":811,"pull_request":{"url":"https://api.github.com/repos/GPflow/GPflow/pulls/811","id":200412643,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwNDEyNjQz","html_url":"https://github.com/GPflow/GPflow/pull/811","diff_url":"https://github.com/GPflow/GPflow/pull/811.diff","patch_url":"https://github.com/GPflow/GPflow/pull/811.patch","issue_url":"https://api.github.com/repos/GPflow/GPflow/issues/811","number":811,"state":"closed","locked":false,"title":"Optimizer's callback accept step number.","user":{"login":"awav","id":24483645,"node_id":"MDQ6VXNlcjI0NDgzNjQ1","avatar_url":"https://avatars0.githubusercontent.com/u/24483645?v=4","gravatar_id":"","url":"https://api.github.com/users/awav","html_url":"https://github.com/awav","followers_url":"https://api.github.com/users/awav/followers","following_url":"https://api.github.com/users/awav/following{/other_user}","gists_url":"https://api.github.com/users/awav/gists{/gist_id}","starred_url":"https://api.github.com/users/awav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awav/subscriptions","organizations_url":"https://api.github.com/users/awav/orgs","repos_url":"https://api.github.com/users/awav/repos","events_url":"https://api.github.com/users/awav/events{/privacy}","received_events_url":"https://api.github.com/users/awav/received_events","type":"User","site_admin":false},"body":"Hello everyone,\r\n\r\nReasons for this PR:\r\n\r\n- `step_callback` docstring states that optimizer doesn't pass arguments to the function and function can have as many arguments as user wants including nil arguments, but an optimizer pass results of `session.run` operation to the `step_callback`, therefore causes failures. [update] Function must be with signature `fun(*args, **kwargs)`, but it is still confusing that nothing is passed into callback.\r\n- Optimizer minimize returns tensorflow operation, which after running this tf.Operation though `session.run` returns `None`.\r\n- It would be nice to expose step number to callback explicitly.\r\n\r\nThanks!","created_at":"2018-07-10T14:18:50Z","updated_at":"2018-07-11T10:58:40Z","closed_at":"2018-07-11T10:58:40Z","merged_at":"2018-07-11T10:58:40Z","merge_commit_sha":"1ff0a873f385b90e68ba9a1de048d5e617215b6c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/GPflow/GPflow/pulls/811/commits","review_comments_url":"https://api.github.com/repos/GPflow/GPflow/pulls/811/comments","review_comment_url":"https://api.github.com/repos/GPflow/GPflow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GPflow/GPflow/issues/811/comments","statuses_url":"https://api.github.com/repos/GPflow/GPflow/statuses/e5150571cc851ab3599e583495b05e10a6ec3a78","head":{"label":"GPflow:awav/optimizers-callback","ref":"awav/optimizers-callback","sha":"e5150571cc851ab3599e583495b05e10a6ec3a78","user":{"login":"GPflow","id":16667412,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NjY3NDEy","avatar_url":"https://avatars2.githubusercontent.com/u/16667412?v=4","gravatar_id":"","url":"https://api.github.com/users/GPflow","html_url":"https://github.com/GPflow","followers_url":"https://api.github.com/users/GPflow/followers","following_url":"https://api.github.com/users/GPflow/following{/other_user}","gists_url":"https://api.github.com/users/GPflow/gists{/gist_id}","starred_url":"https://api.github.com/users/GPflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GPflow/subscriptions","organizations_url":"https://api.github.com/users/GPflow/orgs","repos_url":"https://api.github.com/users/GPflow/repos","events_url":"https://api.github.com/users/GPflow/events{/privacy}","received_events_url":"https://api.github.com/users/GPflow/received_events","type":"Organization","site_admin":false},"repo":{"id":49643229,"node_id":"MDEwOlJlcG9zaXRvcnk0OTY0MzIyOQ==","name":"GPflow","full_name":"GPflow/GPflow","owner":{"login":"GPflow","id":16667412,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NjY3NDEy","avatar_url":"https://avatars2.githubusercontent.com/u/16667412?v=4","gravatar_id":"","url":"https://api.github.com/users/GPflow","html_url":"https://github.com/GPflow","followers_url":"https://api.github.com/users/GPflow/followers","following_url":"https://api.github.com/users/GPflow/following{/other_user}","gists_url":"https://api.github.com/users/GPflow/gists{/gist_id}","starred_url":"https://api.github.com/users/GPflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GPflow/subscriptions","organizations_url":"https://api.github.com/users/GPflow/orgs","repos_url":"https://api.github.com/users/GPflow/repos","events_url":"https://api.github.com/users/GPflow/events{/privacy}","received_events_url":"https://api.github.com/users/GPflow/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GPflow/GPflow","description":"Gaussian processes in TensorFlow","fork":false,"url":"https://api.github.com/repos/GPflow/GPflow","forks_url":"https://api.github.com/repos/GPflow/GPflow/forks","keys_url":"https://api.github.com/repos/GPflow/GPflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GPflow/GPflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GPflow/GPflow/teams","hooks_url":"https://api.github.com/repos/GPflow/GPflow/hooks","issue_events_url":"https://api.github.com/repos/GPflow/GPflow/issues/events{/number}","events_url":"https://api.github.com/repos/GPflow/GPflow/events","assignees_url":"https://api.github.com/repos/GPflow/GPflow/assignees{/user}","branches_url":"https://api.github.com/repos/GPflow/GPflow/branches{/branch}","tags_url":"https://api.github.com/repos/GPflow/GPflow/tags","blobs_url":"https://api.github.com/repos/GPflow/GPflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GPflow/GPflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GPflow/GPflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/GPflow/GPflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GPflow/GPflow/statuses/{sha}","languages_url":"https://api.github.com/repos/GPflow/GPflow/languages","stargazers_url":"https://api.github.com/repos/GPflow/GPflow/stargazers","contributors_url":"https://api.github.com/repos/GPflow/GPflow/contributors","subscribers_url":"https://api.github.com/repos/GPflow/GPflow/subscribers","subscription_url":"https://api.github.com/repos/GPflow/GPflow/subscription","commits_url":"https://api.github.com/repos/GPflow/GPflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/GPflow/GPflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/GPflow/GPflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/GPflow/GPflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/GPflow/GPflow/contents/{+path}","compare_url":"https://api.github.com/repos/GPflow/GPflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GPflow/GPflow/merges","archive_url":"https://api.github.com/repos/GPflow/GPflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GPflow/GPflow/downloads","issues_url":"https://api.github.com/repos/GPflow/GPflow/issues{/number}","pulls_url":"https://api.github.com/repos/GPflow/GPflow/pulls{/number}","milestones_url":"https://api.github.com/repos/GPflow/GPflow/milestones{/number}","notifications_url":"https://api.github.com/repos/GPflow/GPflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GPflow/GPflow/labels{/name}","releases_url":"https://api.github.com/repos/GPflow/GPflow/releases{/id}","deployments_url":"https://api.github.com/repos/GPflow/GPflow/deployments","created_at":"2016-01-14T11:29:24Z","updated_at":"2018-07-10T21:26:02Z","pushed_at":"2018-07-11T10:58:40Z","git_url":"git://github.com/GPflow/GPflow.git","ssh_url":"git@github.com:GPflow/GPflow.git","clone_url":"https://github.com/GPflow/GPflow.git","svn_url":"https://github.com/GPflow/GPflow","homepage":"","size":30339,"stargazers_count":703,"watchers_count":703,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":205,"mirror_url":null,"archived":false,"open_issues_count":48,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":205,"open_issues":48,"watchers":703,"default_branch":"master"}},"base":{"label":"GPflow:master","ref":"master","sha":"b78c1a89a4819cf246aae0724f934349861916cd","user":{"login":"GPflow","id":16667412,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NjY3NDEy","avatar_url":"https://avatars2.githubusercontent.com/u/16667412?v=4","gravatar_id":"","url":"https://api.github.com/users/GPflow","html_url":"https://github.com/GPflow","followers_url":"https://api.github.com/users/GPflow/followers","following_url":"https://api.github.com/users/GPflow/following{/other_user}","gists_url":"https://api.github.com/users/GPflow/gists{/gist_id}","starred_url":"https://api.github.com/users/GPflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GPflow/subscriptions","organizations_url":"https://api.github.com/users/GPflow/orgs","repos_url":"https://api.github.com/users/GPflow/repos","events_url":"https://api.github.com/users/GPflow/events{/privacy}","received_events_url":"https://api.github.com/users/GPflow/received_events","type":"Organization","site_admin":false},"repo":{"id":49643229,"node_id":"MDEwOlJlcG9zaXRvcnk0OTY0MzIyOQ==","name":"GPflow","full_name":"GPflow/GPflow","owner":{"login":"GPflow","id":16667412,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NjY3NDEy","avatar_url":"https://avatars2.githubusercontent.com/u/16667412?v=4","gravatar_id":"","url":"https://api.github.com/users/GPflow","html_url":"https://github.com/GPflow","followers_url":"https://api.github.com/users/GPflow/followers","following_url":"https://api.github.com/users/GPflow/following{/other_user}","gists_url":"https://api.github.com/users/GPflow/gists{/gist_id}","starred_url":"https://api.github.com/users/GPflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GPflow/subscriptions","organizations_url":"https://api.github.com/users/GPflow/orgs","repos_url":"https://api.github.com/users/GPflow/repos","events_url":"https://api.github.com/users/GPflow/events{/privacy}","received_events_url":"https://api.github.com/users/GPflow/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GPflow/GPflow","description":"Gaussian processes in TensorFlow","fork":false,"url":"https://api.github.com/repos/GPflow/GPflow","forks_url":"https://api.github.com/repos/GPflow/GPflow/forks","keys_url":"https://api.github.com/repos/GPflow/GPflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GPflow/GPflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GPflow/GPflow/teams","hooks_url":"https://api.github.com/repos/GPflow/GPflow/hooks","issue_events_url":"https://api.github.com/repos/GPflow/GPflow/issues/events{/number}","events_url":"https://api.github.com/repos/GPflow/GPflow/events","assignees_url":"https://api.github.com/repos/GPflow/GPflow/assignees{/user}","branches_url":"https://api.github.com/repos/GPflow/GPflow/branches{/branch}","tags_url":"https://api.github.com/repos/GPflow/GPflow/tags","blobs_url":"https://api.github.com/repos/GPflow/GPflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GPflow/GPflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GPflow/GPflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/GPflow/GPflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GPflow/GPflow/statuses/{sha}","languages_url":"https://api.github.com/repos/GPflow/GPflow/languages","stargazers_url":"https://api.github.com/repos/GPflow/GPflow/stargazers","contributors_url":"https://api.github.com/repos/GPflow/GPflow/contributors","subscribers_url":"https://api.github.com/repos/GPflow/GPflow/subscribers","subscription_url":"https://api.github.com/repos/GPflow/GPflow/subscription","commits_url":"https://api.github.com/repos/GPflow/GPflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/GPflow/GPflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/GPflow/GPflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/GPflow/GPflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/GPflow/GPflow/contents/{+path}","compare_url":"https://api.github.com/repos/GPflow/GPflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GPflow/GPflow/merges","archive_url":"https://api.github.com/repos/GPflow/GPflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GPflow/GPflow/downloads","issues_url":"https://api.github.com/repos/GPflow/GPflow/issues{/number}","pulls_url":"https://api.github.com/repos/GPflow/GPflow/pulls{/number}","milestones_url":"https://api.github.com/repos/GPflow/GPflow/milestones{/number}","notifications_url":"https://api.github.com/repos/GPflow/GPflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GPflow/GPflow/labels{/name}","releases_url":"https://api.github.com/repos/GPflow/GPflow/releases{/id}","deployments_url":"https://api.github.com/repos/GPflow/GPflow/deployments","created_at":"2016-01-14T11:29:24Z","updated_at":"2018-07-10T21:26:02Z","pushed_at":"2018-07-11T10:58:40Z","git_url":"git://github.com/GPflow/GPflow.git","ssh_url":"git@github.com:GPflow/GPflow.git","clone_url":"https://github.com/GPflow/GPflow.git","svn_url":"https://github.com/GPflow/GPflow","homepage":"","size":30339,"stargazers_count":703,"watchers_count":703,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":205,"mirror_url":null,"archived":false,"open_issues_count":48,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":205,"open_issues":48,"watchers":703,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GPflow/GPflow/pulls/811"},"html":{"href":"https://github.com/GPflow/GPflow/pull/811"},"issue":{"href":"https://api.github.com/repos/GPflow/GPflow/issues/811"},"comments":{"href":"https://api.github.com/repos/GPflow/GPflow/issues/811/comments"},"review_comments":{"href":"https://api.github.com/repos/GPflow/GPflow/pulls/811/comments"},"review_comment":{"href":"https://api.github.com/repos/GPflow/GPflow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GPflow/GPflow/pulls/811/commits"},"statuses":{"href":"https://api.github.com/repos/GPflow/GPflow/statuses/e5150571cc851ab3599e583495b05e10a6ec3a78"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"awav","id":24483645,"node_id":"MDQ6VXNlcjI0NDgzNjQ1","avatar_url":"https://avatars0.githubusercontent.com/u/24483645?v=4","gravatar_id":"","url":"https://api.github.com/users/awav","html_url":"https://github.com/awav","followers_url":"https://api.github.com/users/awav/followers","following_url":"https://api.github.com/users/awav/following{/other_user}","gists_url":"https://api.github.com/users/awav/gists{/gist_id}","starred_url":"https://api.github.com/users/awav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awav/subscriptions","organizations_url":"https://api.github.com/users/awav/orgs","repos_url":"https://api.github.com/users/awav/repos","events_url":"https://api.github.com/users/awav/events{/privacy}","received_events_url":"https://api.github.com/users/awav/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":18,"deletions":23,"changed_files":4}}
{"actor":{"display_login":"awav"}}