{"action":"created","comment":{"url":"https://api.github.com/repos/artsy/metaphysics/pulls/comments/173807655","pull_request_review_id":103055980,"id":173807655,"diff_hunk":"@@ -51,11 +51,17 @@ export const MessageType = new GraphQLObjectType({\n       description: \"True if message is from the user to the partner.\",\n       type: GraphQLBoolean,\n       resolve: (\n-        { from_id, from_email_address, conversation_from_address },\n+        {\n+          from_id,\n+          from_email_address,\n+          conversation_from_address,\n+          from_principal,\n+        },\n         options,\n         req,\n         { rootValue: { userID } }\n       ) =>\n+        from_principal ||","path":"src/schema/me/conversation/message.js","position":15,"original_position":15,"commit_id":"37356734c8bf8dcdb28ebae2308546ab036c0615","original_commit_id":"37356734c8bf8dcdb28ebae2308546ab036c0615","user":{"login":"saolsen","id":508702,"avatar_url":"https://avatars0.githubusercontent.com/u/508702?v=4","gravatar_id":"","url":"https://api.github.com/users/saolsen","html_url":"https://github.com/saolsen","followers_url":"https://api.github.com/users/saolsen/followers","following_url":"https://api.github.com/users/saolsen/following{/other_user}","gists_url":"https://api.github.com/users/saolsen/gists{/gist_id}","starred_url":"https://api.github.com/users/saolsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saolsen/subscriptions","organizations_url":"https://api.github.com/users/saolsen/orgs","repos_url":"https://api.github.com/users/saolsen/repos","events_url":"https://api.github.com/users/saolsen/events{/privacy}","received_events_url":"https://api.github.com/users/saolsen/received_events","type":"User","site_admin":false},"body":"It could still end up being wrong though, if it is from the collector side but not from the original sender. Do we really wanna try to guess here or just return nil for legacy?","created_at":"2018-03-12T14:06:41Z","updated_at":"2018-03-12T14:06:41Z","html_url":"https://github.com/artsy/metaphysics/pull/967#discussion_r173807655","pull_request_url":"https://api.github.com/repos/artsy/metaphysics/pulls/967","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/artsy/metaphysics/pulls/comments/173807655"},"html":{"href":"https://github.com/artsy/metaphysics/pull/967#discussion_r173807655"},"pull_request":{"href":"https://api.github.com/repos/artsy/metaphysics/pulls/967"}},"in_reply_to_id":173805349},"pull_request":{"url":"https://api.github.com/repos/artsy/metaphysics/pulls/967","id":174372959,"html_url":"https://github.com/artsy/metaphysics/pull/967","diff_url":"https://github.com/artsy/metaphysics/pull/967.diff","patch_url":"https://github.com/artsy/metaphysics/pull/967.patch","issue_url":"https://api.github.com/repos/artsy/metaphysics/issues/967","number":967,"state":"open","locked":false,"title":"Update is_from_user to use from_principal if available","user":{"login":"ashkan18","id":1230819,"avatar_url":"https://avatars0.githubusercontent.com/u/1230819?v=4","gravatar_id":"","url":"https://api.github.com/users/ashkan18","html_url":"https://github.com/ashkan18","followers_url":"https://api.github.com/users/ashkan18/followers","following_url":"https://api.github.com/users/ashkan18/following{/other_user}","gists_url":"https://api.github.com/users/ashkan18/gists{/gist_id}","starred_url":"https://api.github.com/users/ashkan18/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashkan18/subscriptions","organizations_url":"https://api.github.com/users/ashkan18/orgs","repos_url":"https://api.github.com/users/ashkan18/repos","events_url":"https://api.github.com/users/ashkan18/events{/privacy}","received_events_url":"https://api.github.com/users/ashkan18/received_events","type":"User","site_admin":false},"body":"# Change\r\nImpulse [now](https://github.com/artsy/impulse/pull/441) offers `from_principal` as one of the fields in `Message` json. We can use that here to detect `is_from_user` and `last_message_from_user` easier.","created_at":"2018-03-12T13:48:49Z","updated_at":"2018-03-12T14:06:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2083f950449cdae69a698433d77be99da8eb8087","assignee":{"login":"joeyAghion","id":28120,"avatar_url":"https://avatars2.githubusercontent.com/u/28120?v=4","gravatar_id":"","url":"https://api.github.com/users/joeyAghion","html_url":"https://github.com/joeyAghion","followers_url":"https://api.github.com/users/joeyAghion/followers","following_url":"https://api.github.com/users/joeyAghion/following{/other_user}","gists_url":"https://api.github.com/users/joeyAghion/gists{/gist_id}","starred_url":"https://api.github.com/users/joeyAghion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joeyAghion/subscriptions","organizations_url":"https://api.github.com/users/joeyAghion/orgs","repos_url":"https://api.github.com/users/joeyAghion/repos","events_url":"https://api.github.com/users/joeyAghion/events{/privacy}","received_events_url":"https://api.github.com/users/joeyAghion/received_events","type":"User","site_admin":false},"assignees":[{"login":"joeyAghion","id":28120,"avatar_url":"https://avatars2.githubusercontent.com/u/28120?v=4","gravatar_id":"","url":"https://api.github.com/users/joeyAghion","html_url":"https://github.com/joeyAghion","followers_url":"https://api.github.com/users/joeyAghion/followers","following_url":"https://api.github.com/users/joeyAghion/following{/other_user}","gists_url":"https://api.github.com/users/joeyAghion/gists{/gist_id}","starred_url":"https://api.github.com/users/joeyAghion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joeyAghion/subscriptions","organizations_url":"https://api.github.com/users/joeyAghion/orgs","repos_url":"https://api.github.com/users/joeyAghion/repos","events_url":"https://api.github.com/users/joeyAghion/events{/privacy}","received_events_url":"https://api.github.com/users/joeyAghion/received_events","type":"User","site_admin":false},{"login":"saolsen","id":508702,"avatar_url":"https://avatars0.githubusercontent.com/u/508702?v=4","gravatar_id":"","url":"https://api.github.com/users/saolsen","html_url":"https://github.com/saolsen","followers_url":"https://api.github.com/users/saolsen/followers","following_url":"https://api.github.com/users/saolsen/following{/other_user}","gists_url":"https://api.github.com/users/saolsen/gists{/gist_id}","starred_url":"https://api.github.com/users/saolsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saolsen/subscriptions","organizations_url":"https://api.github.com/users/saolsen/orgs","repos_url":"https://api.github.com/users/saolsen/repos","events_url":"https://api.github.com/users/saolsen/events{/privacy}","received_events_url":"https://api.github.com/users/saolsen/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"mzikherman","id":1457859,"avatar_url":"https://avatars2.githubusercontent.com/u/1457859?v=4","gravatar_id":"","url":"https://api.github.com/users/mzikherman","html_url":"https://github.com/mzikherman","followers_url":"https://api.github.com/users/mzikherman/followers","following_url":"https://api.github.com/users/mzikherman/following{/other_user}","gists_url":"https://api.github.com/users/mzikherman/gists{/gist_id}","starred_url":"https://api.github.com/users/mzikherman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mzikherman/subscriptions","organizations_url":"https://api.github.com/users/mzikherman/orgs","repos_url":"https://api.github.com/users/mzikherman/repos","events_url":"https://api.github.com/users/mzikherman/events{/privacy}","received_events_url":"https://api.github.com/users/mzikherman/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/artsy/metaphysics/pulls/967/commits","review_comments_url":"https://api.github.com/repos/artsy/metaphysics/pulls/967/comments","review_comment_url":"https://api.github.com/repos/artsy/metaphysics/pulls/comments{/number}","comments_url":"https://api.github.com/repos/artsy/metaphysics/issues/967/comments","statuses_url":"https://api.github.com/repos/artsy/metaphysics/statuses/37356734c8bf8dcdb28ebae2308546ab036c0615","head":{"label":"ashkan18:update-is-from-user","ref":"update-is-from-user","sha":"37356734c8bf8dcdb28ebae2308546ab036c0615","user":{"login":"ashkan18","id":1230819,"avatar_url":"https://avatars0.githubusercontent.com/u/1230819?v=4","gravatar_id":"","url":"https://api.github.com/users/ashkan18","html_url":"https://github.com/ashkan18","followers_url":"https://api.github.com/users/ashkan18/followers","following_url":"https://api.github.com/users/ashkan18/following{/other_user}","gists_url":"https://api.github.com/users/ashkan18/gists{/gist_id}","starred_url":"https://api.github.com/users/ashkan18/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashkan18/subscriptions","organizations_url":"https://api.github.com/users/ashkan18/orgs","repos_url":"https://api.github.com/users/ashkan18/repos","events_url":"https://api.github.com/users/ashkan18/events{/privacy}","received_events_url":"https://api.github.com/users/ashkan18/received_events","type":"User","site_admin":false},"repo":{"id":56707536,"name":"metaphysics","full_name":"ashkan18/metaphysics","owner":{"login":"ashkan18","id":1230819,"avatar_url":"https://avatars0.githubusercontent.com/u/1230819?v=4","gravatar_id":"","url":"https://api.github.com/users/ashkan18","html_url":"https://github.com/ashkan18","followers_url":"https://api.github.com/users/ashkan18/followers","following_url":"https://api.github.com/users/ashkan18/following{/other_user}","gists_url":"https://api.github.com/users/ashkan18/gists{/gist_id}","starred_url":"https://api.github.com/users/ashkan18/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashkan18/subscriptions","organizations_url":"https://api.github.com/users/ashkan18/orgs","repos_url":"https://api.github.com/users/ashkan18/repos","events_url":"https://api.github.com/users/ashkan18/events{/privacy}","received_events_url":"https://api.github.com/users/ashkan18/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ashkan18/metaphysics","description":"Artsy's GraphQL API","fork":true,"url":"https://api.github.com/repos/ashkan18/metaphysics","forks_url":"https://api.github.com/repos/ashkan18/metaphysics/forks","keys_url":"https://api.github.com/repos/ashkan18/metaphysics/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ashkan18/metaphysics/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ashkan18/metaphysics/teams","hooks_url":"https://api.github.com/repos/ashkan18/metaphysics/hooks","issue_events_url":"https://api.github.com/repos/ashkan18/metaphysics/issues/events{/number}","events_url":"https://api.github.com/repos/ashkan18/metaphysics/events","assignees_url":"https://api.github.com/repos/ashkan18/metaphysics/assignees{/user}","branches_url":"https://api.github.com/repos/ashkan18/metaphysics/branches{/branch}","tags_url":"https://api.github.com/repos/ashkan18/metaphysics/tags","blobs_url":"https://api.github.com/repos/ashkan18/metaphysics/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ashkan18/metaphysics/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ashkan18/metaphysics/git/refs{/sha}","trees_url":"https://api.github.com/repos/ashkan18/metaphysics/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ashkan18/metaphysics/statuses/{sha}","languages_url":"https://api.github.com/repos/ashkan18/metaphysics/languages","stargazers_url":"https://api.github.com/repos/ashkan18/metaphysics/stargazers","contributors_url":"https://api.github.com/repos/ashkan18/metaphysics/contributors","subscribers_url":"https://api.github.com/repos/ashkan18/metaphysics/subscribers","subscription_url":"https://api.github.com/repos/ashkan18/metaphysics/subscription","commits_url":"https://api.github.com/repos/ashkan18/metaphysics/commits{/sha}","git_commits_url":"https://api.github.com/repos/ashkan18/metaphysics/git/commits{/sha}","comments_url":"https://api.github.com/repos/ashkan18/metaphysics/comments{/number}","issue_comment_url":"https://api.github.com/repos/ashkan18/metaphysics/issues/comments{/number}","contents_url":"https://api.github.com/repos/ashkan18/metaphysics/contents/{+path}","compare_url":"https://api.github.com/repos/ashkan18/metaphysics/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ashkan18/metaphysics/merges","archive_url":"https://api.github.com/repos/ashkan18/metaphysics/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ashkan18/metaphysics/downloads","issues_url":"https://api.github.com/repos/ashkan18/metaphysics/issues{/number}","pulls_url":"https://api.github.com/repos/ashkan18/metaphysics/pulls{/number}","milestones_url":"https://api.github.com/repos/ashkan18/metaphysics/milestones{/number}","notifications_url":"https://api.github.com/repos/ashkan18/metaphysics/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ashkan18/metaphysics/labels{/name}","releases_url":"https://api.github.com/repos/ashkan18/metaphysics/releases{/id}","deployments_url":"https://api.github.com/repos/ashkan18/metaphysics/deployments","created_at":"2016-04-20T17:38:14Z","updated_at":"2016-04-20T17:38:15Z","pushed_at":"2018-03-12T13:41:08Z","git_url":"git://github.com/ashkan18/metaphysics.git","ssh_url":"git@github.com:ashkan18/metaphysics.git","clone_url":"https://github.com/ashkan18/metaphysics.git","svn_url":"https://github.com/ashkan18/metaphysics","homepage":"","size":3934,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"artsy:master","ref":"master","sha":"3ee28d0d24daf93f45b45c1a4fd976940d952769","user":{"login":"artsy","id":546231,"avatar_url":"https://avatars3.githubusercontent.com/u/546231?v=4","gravatar_id":"","url":"https://api.github.com/users/artsy","html_url":"https://github.com/artsy","followers_url":"https://api.github.com/users/artsy/followers","following_url":"https://api.github.com/users/artsy/following{/other_user}","gists_url":"https://api.github.com/users/artsy/gists{/gist_id}","starred_url":"https://api.github.com/users/artsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artsy/subscriptions","organizations_url":"https://api.github.com/users/artsy/orgs","repos_url":"https://api.github.com/users/artsy/repos","events_url":"https://api.github.com/users/artsy/events{/privacy}","received_events_url":"https://api.github.com/users/artsy/received_events","type":"Organization","site_admin":false},"repo":{"id":42728510,"name":"metaphysics","full_name":"artsy/metaphysics","owner":{"login":"artsy","id":546231,"avatar_url":"https://avatars3.githubusercontent.com/u/546231?v=4","gravatar_id":"","url":"https://api.github.com/users/artsy","html_url":"https://github.com/artsy","followers_url":"https://api.github.com/users/artsy/followers","following_url":"https://api.github.com/users/artsy/following{/other_user}","gists_url":"https://api.github.com/users/artsy/gists{/gist_id}","starred_url":"https://api.github.com/users/artsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artsy/subscriptions","organizations_url":"https://api.github.com/users/artsy/orgs","repos_url":"https://api.github.com/users/artsy/repos","events_url":"https://api.github.com/users/artsy/events{/privacy}","received_events_url":"https://api.github.com/users/artsy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/artsy/metaphysics","description":"Artsy's GraphQL API","fork":false,"url":"https://api.github.com/repos/artsy/metaphysics","forks_url":"https://api.github.com/repos/artsy/metaphysics/forks","keys_url":"https://api.github.com/repos/artsy/metaphysics/keys{/key_id}","collaborators_url":"https://api.github.com/repos/artsy/metaphysics/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/artsy/metaphysics/teams","hooks_url":"https://api.github.com/repos/artsy/metaphysics/hooks","issue_events_url":"https://api.github.com/repos/artsy/metaphysics/issues/events{/number}","events_url":"https://api.github.com/repos/artsy/metaphysics/events","assignees_url":"https://api.github.com/repos/artsy/metaphysics/assignees{/user}","branches_url":"https://api.github.com/repos/artsy/metaphysics/branches{/branch}","tags_url":"https://api.github.com/repos/artsy/metaphysics/tags","blobs_url":"https://api.github.com/repos/artsy/metaphysics/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/artsy/metaphysics/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/artsy/metaphysics/git/refs{/sha}","trees_url":"https://api.github.com/repos/artsy/metaphysics/git/trees{/sha}","statuses_url":"https://api.github.com/repos/artsy/metaphysics/statuses/{sha}","languages_url":"https://api.github.com/repos/artsy/metaphysics/languages","stargazers_url":"https://api.github.com/repos/artsy/metaphysics/stargazers","contributors_url":"https://api.github.com/repos/artsy/metaphysics/contributors","subscribers_url":"https://api.github.com/repos/artsy/metaphysics/subscribers","subscription_url":"https://api.github.com/repos/artsy/metaphysics/subscription","commits_url":"https://api.github.com/repos/artsy/metaphysics/commits{/sha}","git_commits_url":"https://api.github.com/repos/artsy/metaphysics/git/commits{/sha}","comments_url":"https://api.github.com/repos/artsy/metaphysics/comments{/number}","issue_comment_url":"https://api.github.com/repos/artsy/metaphysics/issues/comments{/number}","contents_url":"https://api.github.com/repos/artsy/metaphysics/contents/{+path}","compare_url":"https://api.github.com/repos/artsy/metaphysics/compare/{base}...{head}","merges_url":"https://api.github.com/repos/artsy/metaphysics/merges","archive_url":"https://api.github.com/repos/artsy/metaphysics/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/artsy/metaphysics/downloads","issues_url":"https://api.github.com/repos/artsy/metaphysics/issues{/number}","pulls_url":"https://api.github.com/repos/artsy/metaphysics/pulls{/number}","milestones_url":"https://api.github.com/repos/artsy/metaphysics/milestones{/number}","notifications_url":"https://api.github.com/repos/artsy/metaphysics/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/artsy/metaphysics/labels{/name}","releases_url":"https://api.github.com/repos/artsy/metaphysics/releases{/id}","deployments_url":"https://api.github.com/repos/artsy/metaphysics/deployments","created_at":"2015-09-18T14:51:48Z","updated_at":"2018-03-12T13:59:55Z","pushed_at":"2018-03-12T13:48:49Z","git_url":"git://github.com/artsy/metaphysics.git","ssh_url":"git@github.com:artsy/metaphysics.git","clone_url":"https://github.com/artsy/metaphysics.git","svn_url":"https://github.com/artsy/metaphysics","homepage":"","size":4201,"stargazers_count":136,"watchers_count":136,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":38,"mirror_url":null,"archived":false,"open_issues_count":51,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":38,"open_issues":51,"watchers":136,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/artsy/metaphysics/pulls/967"},"html":{"href":"https://github.com/artsy/metaphysics/pull/967"},"issue":{"href":"https://api.github.com/repos/artsy/metaphysics/issues/967"},"comments":{"href":"https://api.github.com/repos/artsy/metaphysics/issues/967/comments"},"review_comments":{"href":"https://api.github.com/repos/artsy/metaphysics/pulls/967/comments"},"review_comment":{"href":"https://api.github.com/repos/artsy/metaphysics/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/artsy/metaphysics/pulls/967/commits"},"statuses":{"href":"https://api.github.com/repos/artsy/metaphysics/statuses/37356734c8bf8dcdb28ebae2308546ab036c0615"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"saolsen"}}