{"action":"created","issue":{"url":"https://api.github.com/repos/apache/metron/issues/1121","repository_url":"https://api.github.com/repos/apache/metron","labels_url":"https://api.github.com/repos/apache/metron/issues/1121/labels{/name}","comments_url":"https://api.github.com/repos/apache/metron/issues/1121/comments","events_url":"https://api.github.com/repos/apache/metron/issues/1121/events","html_url":"https://github.com/apache/metron/pull/1121","id":342823467,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyNjMzMDYy","number":1121,"title":"METRON-1675: Add Pagination to PCAP","user":{"login":"sardell","id":7304869,"node_id":"MDQ6VXNlcjczMDQ4Njk=","avatar_url":"https://avatars2.githubusercontent.com/u/7304869?v=4","gravatar_id":"","url":"https://api.github.com/users/sardell","html_url":"https://github.com/sardell","followers_url":"https://api.github.com/users/sardell/followers","following_url":"https://api.github.com/users/sardell/following{/other_user}","gists_url":"https://api.github.com/users/sardell/gists{/gist_id}","starred_url":"https://api.github.com/users/sardell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sardell/subscriptions","organizations_url":"https://api.github.com/users/sardell/orgs","repos_url":"https://api.github.com/users/sardell/repos","events_url":"https://api.github.com/users/sardell/events{/privacy}","received_events_url":"https://api.github.com/users/sardell/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-07-19T17:36:19Z","updated_at":"2018-08-07T13:59:23Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/apache/metron/pulls/1121","html_url":"https://github.com/apache/metron/pull/1121","diff_url":"https://github.com/apache/metron/pull/1121.diff","patch_url":"https://github.com/apache/metron/pull/1121.patch"},"body":"## Contributor Comments\r\nThis PR is a subtask of the PCAP feature branch that adds pagination functionality to the PCAP search results. Unit tests are in place.\r\n\r\nYou can test by submitting a PCAP query and paging through the results. \r\n\r\n![pcap-paging](https://user-images.githubusercontent.com/7304869/43132105-04234caa-8f3b-11e8-823f-0df76b075554.gif)\r\n\r\n## Testing\r\nThis has been tested in full dev. In order to test:\r\n\r\n1. Spin up full dev.\r\n1. Put pcap data inside of `/apps/metron/pcap/input` in your VM.\r\n1. Start metron-alerts.\r\n1. Sign in and click on the PCAP tab in the upper left hand corner of the screen.\r\n1. Submit a pcap search which will return a set of results from your loaded pcap data, preferably on that will match at least a few dozen results.\r\n1. Page through the results. The lines should update with the next/previous packets. When you download a file, the results should match the current page shown in the UI.\r\n\r\n## Pull Request Checklist\r\n\r\nThank you for submitting a contribution to Apache Metron.  \r\nPlease refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.  \r\nPlease refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.  \r\n\r\n\r\nIn order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:\r\n\r\n### For all changes:\r\n- [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).\r\n- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen \"-\" character.\r\n- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?\r\n\r\n\r\n### For code changes:\r\n- [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed?\r\n- [x] Have you included steps or a guide to how the change may be verified and tested manually?\r\n- [x] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:\r\n  ```\r\n  mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh \r\n  ```\r\n\r\n- [x] Have you written or updated unit tests and or integration tests to verify your changes?\r\n- [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?\r\n- [x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?\r\n\r\n### For documentation related changes:\r\n- [x] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:\r\n\r\n  ```\r\n  cd site-book\r\n  mvn site\r\n  ```\r\n\r\n#### Note:\r\nPlease ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.\r\nIt is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.\r\n"},"comment":{"url":"https://api.github.com/repos/apache/metron/issues/comments/411066080","html_url":"https://github.com/apache/metron/pull/1121#issuecomment-411066080","issue_url":"https://api.github.com/repos/apache/metron/issues/1121","id":411066080,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMTA2NjA4MA==","user":{"login":"justinleet","id":5077341,"node_id":"MDQ6VXNlcjUwNzczNDE=","avatar_url":"https://avatars2.githubusercontent.com/u/5077341?v=4","gravatar_id":"","url":"https://api.github.com/users/justinleet","html_url":"https://github.com/justinleet","followers_url":"https://api.github.com/users/justinleet/followers","following_url":"https://api.github.com/users/justinleet/following{/other_user}","gists_url":"https://api.github.com/users/justinleet/gists{/gist_id}","starred_url":"https://api.github.com/users/justinleet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinleet/subscriptions","organizations_url":"https://api.github.com/users/justinleet/orgs","repos_url":"https://api.github.com/users/justinleet/repos","events_url":"https://api.github.com/users/justinleet/events{/privacy}","received_events_url":"https://api.github.com/users/justinleet/received_events","type":"User","site_admin":false},"created_at":"2018-08-07T13:59:23Z","updated_at":"2018-08-07T13:59:23Z","author_association":"CONTRIBUTOR","body":"+1, thanks for the contribution!"}}
{"actor":{"display_login":"justinleet"}}