{"action":"created","comment":{"url":"https://api.github.com/repos/Slicer/Slicer/pulls/comments/171604872","pull_request_review_id":100486880,"id":171604872,"diff_hunk":"@@ -667,6 +668,9 @@ QWidget* qSlicerCLIModuleUIHelperPrivate::createImageTagWidget(const ModuleParam\n   QString imageLabel = QString::fromStdString(moduleParameter.GetLabel());\n   QString imageName = QString::fromStdString(moduleParameter.GetName());\n \n+  imageLabel = QCoreApplication::translate(\n+          this->CLIModuleWidget->moduleName().toLatin1(), imageLabel.toLatin1());","path":"Base/QTCLI/qSlicerCLIModuleUIHelper.cxx","position":13,"original_position":13,"commit_id":"94707669f3c0411c9d7dd14e466937c85830c41a","original_commit_id":"d9e9bc9681aabb96c8802926324031a405fd0164","user":{"login":"lassoan","id":307929,"avatar_url":"https://avatars0.githubusercontent.com/u/307929?v=4","gravatar_id":"","url":"https://api.github.com/users/lassoan","html_url":"https://github.com/lassoan","followers_url":"https://api.github.com/users/lassoan/followers","following_url":"https://api.github.com/users/lassoan/following{/other_user}","gists_url":"https://api.github.com/users/lassoan/gists{/gist_id}","starred_url":"https://api.github.com/users/lassoan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lassoan/subscriptions","organizations_url":"https://api.github.com/users/lassoan/orgs","repos_url":"https://api.github.com/users/lassoan/repos","events_url":"https://api.github.com/users/lassoan/events{/privacy}","received_events_url":"https://api.github.com/users/lassoan/received_events","type":"User","site_admin":false},"body":"Need to be careful with enumerated strings. While the values should be translated in the GUI, the original text should be sent on the command-line.\r\n\r\nFor example:\r\n\r\nhttps://github.com/Slicer/Slicer/blob/aa07f6b274778f4cbab626b35228bea8768d38ce/Modules/CLI/ThresholdScalarVolume/ThresholdScalarVolume.xml#L31-L40\r\n\r\nUser will see \"outside\", \"below\", \"above\" translated on GUI, but when the selection is made, the CLI module must receive the original \"outside\", \"below\", \"above\" values.\r\n\r\nThis goes the other direction, too. Returning strings is rare, but eventually, any strings returned by the CLI should be possible to translate.\r\n","created_at":"2018-03-01T15:59:39Z","updated_at":"2018-03-01T15:59:39Z","html_url":"https://github.com/Slicer/Slicer/pull/898#discussion_r171604872","pull_request_url":"https://api.github.com/repos/Slicer/Slicer/pulls/898","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Slicer/Slicer/pulls/comments/171604872"},"html":{"href":"https://github.com/Slicer/Slicer/pull/898#discussion_r171604872"},"pull_request":{"href":"https://api.github.com/repos/Slicer/Slicer/pulls/898"}},"in_reply_to_id":170399806},"pull_request":{"url":"https://api.github.com/repos/Slicer/Slicer/pulls/898","id":170939206,"html_url":"https://github.com/Slicer/Slicer/pull/898","diff_url":"https://github.com/Slicer/Slicer/pull/898.diff","patch_url":"https://github.com/Slicer/Slicer/pull/898.patch","issue_url":"https://api.github.com/repos/Slicer/Slicer/issues/898","number":898,"state":"open","locked":false,"title":"Plenty chinese i18n ts files and code modification","user":{"login":"u8621011","id":271116,"avatar_url":"https://avatars0.githubusercontent.com/u/271116?v=4","gravatar_id":"","url":"https://api.github.com/users/u8621011","html_url":"https://github.com/u8621011","followers_url":"https://api.github.com/users/u8621011/followers","following_url":"https://api.github.com/users/u8621011/following{/other_user}","gists_url":"https://api.github.com/users/u8621011/gists{/gist_id}","starred_url":"https://api.github.com/users/u8621011/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/u8621011/subscriptions","organizations_url":"https://api.github.com/users/u8621011/orgs","repos_url":"https://api.github.com/users/u8621011/repos","events_url":"https://api.github.com/users/u8621011/events{/privacy}","received_events_url":"https://api.github.com/users/u8621011/received_events","type":"User","site_admin":false},"body":"Below is what this PR includes\r\n1. traditional/simplified Chinese translation files\r\n2. i18n related cmake script for loadable module\r\n3. i18n related code fixes.","created_at":"2018-02-23T06:02:16Z","updated_at":"2018-03-01T15:59:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"325de5a22f011e9d54703541fe0c4c2b1a9548e9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":261751230,"url":"https://api.github.com/repos/Slicer/Slicer/labels/wip","name":"wip","color":"fad8c7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Slicer/Slicer/pulls/898/commits","review_comments_url":"https://api.github.com/repos/Slicer/Slicer/pulls/898/comments","review_comment_url":"https://api.github.com/repos/Slicer/Slicer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Slicer/Slicer/issues/898/comments","statuses_url":"https://api.github.com/repos/Slicer/Slicer/statuses/94707669f3c0411c9d7dd14e466937c85830c41a","head":{"label":"u8621011:dtc18n2","ref":"dtc18n2","sha":"94707669f3c0411c9d7dd14e466937c85830c41a","user":{"login":"u8621011","id":271116,"avatar_url":"https://avatars0.githubusercontent.com/u/271116?v=4","gravatar_id":"","url":"https://api.github.com/users/u8621011","html_url":"https://github.com/u8621011","followers_url":"https://api.github.com/users/u8621011/followers","following_url":"https://api.github.com/users/u8621011/following{/other_user}","gists_url":"https://api.github.com/users/u8621011/gists{/gist_id}","starred_url":"https://api.github.com/users/u8621011/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/u8621011/subscriptions","organizations_url":"https://api.github.com/users/u8621011/orgs","repos_url":"https://api.github.com/users/u8621011/repos","events_url":"https://api.github.com/users/u8621011/events{/privacy}","received_events_url":"https://api.github.com/users/u8621011/received_events","type":"User","site_admin":false},"repo":{"id":117036426,"name":"Slicer","full_name":"u8621011/Slicer","owner":{"login":"u8621011","id":271116,"avatar_url":"https://avatars0.githubusercontent.com/u/271116?v=4","gravatar_id":"","url":"https://api.github.com/users/u8621011","html_url":"https://github.com/u8621011","followers_url":"https://api.github.com/users/u8621011/followers","following_url":"https://api.github.com/users/u8621011/following{/other_user}","gists_url":"https://api.github.com/users/u8621011/gists{/gist_id}","starred_url":"https://api.github.com/users/u8621011/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/u8621011/subscriptions","organizations_url":"https://api.github.com/users/u8621011/orgs","repos_url":"https://api.github.com/users/u8621011/repos","events_url":"https://api.github.com/users/u8621011/events{/privacy}","received_events_url":"https://api.github.com/users/u8621011/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/u8621011/Slicer","description":"Multi-platform, free open source software for visualization and image computing.","fork":true,"url":"https://api.github.com/repos/u8621011/Slicer","forks_url":"https://api.github.com/repos/u8621011/Slicer/forks","keys_url":"https://api.github.com/repos/u8621011/Slicer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/u8621011/Slicer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/u8621011/Slicer/teams","hooks_url":"https://api.github.com/repos/u8621011/Slicer/hooks","issue_events_url":"https://api.github.com/repos/u8621011/Slicer/issues/events{/number}","events_url":"https://api.github.com/repos/u8621011/Slicer/events","assignees_url":"https://api.github.com/repos/u8621011/Slicer/assignees{/user}","branches_url":"https://api.github.com/repos/u8621011/Slicer/branches{/branch}","tags_url":"https://api.github.com/repos/u8621011/Slicer/tags","blobs_url":"https://api.github.com/repos/u8621011/Slicer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/u8621011/Slicer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/u8621011/Slicer/git/refs{/sha}","trees_url":"https://api.github.com/repos/u8621011/Slicer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/u8621011/Slicer/statuses/{sha}","languages_url":"https://api.github.com/repos/u8621011/Slicer/languages","stargazers_url":"https://api.github.com/repos/u8621011/Slicer/stargazers","contributors_url":"https://api.github.com/repos/u8621011/Slicer/contributors","subscribers_url":"https://api.github.com/repos/u8621011/Slicer/subscribers","subscription_url":"https://api.github.com/repos/u8621011/Slicer/subscription","commits_url":"https://api.github.com/repos/u8621011/Slicer/commits{/sha}","git_commits_url":"https://api.github.com/repos/u8621011/Slicer/git/commits{/sha}","comments_url":"https://api.github.com/repos/u8621011/Slicer/comments{/number}","issue_comment_url":"https://api.github.com/repos/u8621011/Slicer/issues/comments{/number}","contents_url":"https://api.github.com/repos/u8621011/Slicer/contents/{+path}","compare_url":"https://api.github.com/repos/u8621011/Slicer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/u8621011/Slicer/merges","archive_url":"https://api.github.com/repos/u8621011/Slicer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/u8621011/Slicer/downloads","issues_url":"https://api.github.com/repos/u8621011/Slicer/issues{/number}","pulls_url":"https://api.github.com/repos/u8621011/Slicer/pulls{/number}","milestones_url":"https://api.github.com/repos/u8621011/Slicer/milestones{/number}","notifications_url":"https://api.github.com/repos/u8621011/Slicer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/u8621011/Slicer/labels{/name}","releases_url":"https://api.github.com/repos/u8621011/Slicer/releases{/id}","deployments_url":"https://api.github.com/repos/u8621011/Slicer/deployments","created_at":"2018-01-11T02:02:33Z","updated_at":"2018-01-11T02:02:46Z","pushed_at":"2018-02-24T00:25:19Z","git_url":"git://github.com/u8621011/Slicer.git","ssh_url":"git@github.com:u8621011/Slicer.git","clone_url":"https://github.com/u8621011/Slicer.git","svn_url":"https://github.com/u8621011/Slicer","homepage":"http://www.slicer.org","size":438898,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Slicer:master","ref":"master","sha":"974f0bb48203e57a5384597c8a2eb5e48e920a0d","user":{"login":"Slicer","id":324362,"avatar_url":"https://avatars0.githubusercontent.com/u/324362?v=4","gravatar_id":"","url":"https://api.github.com/users/Slicer","html_url":"https://github.com/Slicer","followers_url":"https://api.github.com/users/Slicer/followers","following_url":"https://api.github.com/users/Slicer/following{/other_user}","gists_url":"https://api.github.com/users/Slicer/gists{/gist_id}","starred_url":"https://api.github.com/users/Slicer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Slicer/subscriptions","organizations_url":"https://api.github.com/users/Slicer/orgs","repos_url":"https://api.github.com/users/Slicer/repos","events_url":"https://api.github.com/users/Slicer/events{/privacy}","received_events_url":"https://api.github.com/users/Slicer/received_events","type":"Organization","site_admin":false},"repo":{"id":2006302,"name":"Slicer","full_name":"Slicer/Slicer","owner":{"login":"Slicer","id":324362,"avatar_url":"https://avatars0.githubusercontent.com/u/324362?v=4","gravatar_id":"","url":"https://api.github.com/users/Slicer","html_url":"https://github.com/Slicer","followers_url":"https://api.github.com/users/Slicer/followers","following_url":"https://api.github.com/users/Slicer/following{/other_user}","gists_url":"https://api.github.com/users/Slicer/gists{/gist_id}","starred_url":"https://api.github.com/users/Slicer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Slicer/subscriptions","organizations_url":"https://api.github.com/users/Slicer/orgs","repos_url":"https://api.github.com/users/Slicer/repos","events_url":"https://api.github.com/users/Slicer/events{/privacy}","received_events_url":"https://api.github.com/users/Slicer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Slicer/Slicer","description":"Multi-platform, free open source software for visualization and image computing.","fork":false,"url":"https://api.github.com/repos/Slicer/Slicer","forks_url":"https://api.github.com/repos/Slicer/Slicer/forks","keys_url":"https://api.github.com/repos/Slicer/Slicer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Slicer/Slicer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Slicer/Slicer/teams","hooks_url":"https://api.github.com/repos/Slicer/Slicer/hooks","issue_events_url":"https://api.github.com/repos/Slicer/Slicer/issues/events{/number}","events_url":"https://api.github.com/repos/Slicer/Slicer/events","assignees_url":"https://api.github.com/repos/Slicer/Slicer/assignees{/user}","branches_url":"https://api.github.com/repos/Slicer/Slicer/branches{/branch}","tags_url":"https://api.github.com/repos/Slicer/Slicer/tags","blobs_url":"https://api.github.com/repos/Slicer/Slicer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Slicer/Slicer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Slicer/Slicer/git/refs{/sha}","trees_url":"https://api.github.com/repos/Slicer/Slicer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Slicer/Slicer/statuses/{sha}","languages_url":"https://api.github.com/repos/Slicer/Slicer/languages","stargazers_url":"https://api.github.com/repos/Slicer/Slicer/stargazers","contributors_url":"https://api.github.com/repos/Slicer/Slicer/contributors","subscribers_url":"https://api.github.com/repos/Slicer/Slicer/subscribers","subscription_url":"https://api.github.com/repos/Slicer/Slicer/subscription","commits_url":"https://api.github.com/repos/Slicer/Slicer/commits{/sha}","git_commits_url":"https://api.github.com/repos/Slicer/Slicer/git/commits{/sha}","comments_url":"https://api.github.com/repos/Slicer/Slicer/comments{/number}","issue_comment_url":"https://api.github.com/repos/Slicer/Slicer/issues/comments{/number}","contents_url":"https://api.github.com/repos/Slicer/Slicer/contents/{+path}","compare_url":"https://api.github.com/repos/Slicer/Slicer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Slicer/Slicer/merges","archive_url":"https://api.github.com/repos/Slicer/Slicer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Slicer/Slicer/downloads","issues_url":"https://api.github.com/repos/Slicer/Slicer/issues{/number}","pulls_url":"https://api.github.com/repos/Slicer/Slicer/pulls{/number}","milestones_url":"https://api.github.com/repos/Slicer/Slicer/milestones{/number}","notifications_url":"https://api.github.com/repos/Slicer/Slicer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Slicer/Slicer/labels{/name}","releases_url":"https://api.github.com/repos/Slicer/Slicer/releases{/id}","deployments_url":"https://api.github.com/repos/Slicer/Slicer/deployments","created_at":"2011-07-06T12:27:18Z","updated_at":"2018-03-01T06:15:10Z","pushed_at":"2018-03-01T15:43:07Z","git_url":"git://github.com/Slicer/Slicer.git","ssh_url":"git@github.com:Slicer/Slicer.git","clone_url":"https://github.com/Slicer/Slicer.git","svn_url":"https://github.com/Slicer/Slicer","homepage":"http://www.slicer.org","size":438949,"stargazers_count":476,"watchers_count":476,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":355,"mirror_url":null,"archived":false,"open_issues_count":21,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":355,"open_issues":21,"watchers":476,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Slicer/Slicer/pulls/898"},"html":{"href":"https://github.com/Slicer/Slicer/pull/898"},"issue":{"href":"https://api.github.com/repos/Slicer/Slicer/issues/898"},"comments":{"href":"https://api.github.com/repos/Slicer/Slicer/issues/898/comments"},"review_comments":{"href":"https://api.github.com/repos/Slicer/Slicer/pulls/898/comments"},"review_comment":{"href":"https://api.github.com/repos/Slicer/Slicer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Slicer/Slicer/pulls/898/commits"},"statuses":{"href":"https://api.github.com/repos/Slicer/Slicer/statuses/94707669f3c0411c9d7dd14e466937c85830c41a"}},"author_association":"NONE"}}
{"actor":{"display_login":"lassoan"}}