{"action":"created","comment":{"url":"https://api.github.com/repos/juju/juju/pulls/comments/209612656","pull_request_review_id":145657589,"id":209612656,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTYxMjY1Ng==","diff_hunk":"@@ -1566,7 +1566,7 @@ func (t *localServerSuite) TestValidateImageMetadata(c *gc.C) {\n \timage_ids, _, err := imagemetadata.ValidateImageMetadata(params)\n \tc.Assert(err, jc.ErrorIsNil)\n \tsort.Strings(image_ids)\n-\tc.Assert(image_ids, gc.DeepEquals, []string{\"ami-00000133\", \"ami-00000135\", \"ami-00000139\"})\n+\tc.Assert(image_ids, gc.DeepEquals, []string{\"ami-00001133\", \"ami-00001135\", \"ami-00001139\"})","path":"provider/ec2/local_test.go","position":5,"original_position":5,"commit_id":"629d8c6fe3f614ae02d3557fe74adce5bad368bb","original_commit_id":"629d8c6fe3f614ae02d3557fe74adce5bad368bb","user":{"login":"mitechie","id":75915,"node_id":"MDQ6VXNlcjc1OTE1","avatar_url":"https://avatars1.githubusercontent.com/u/75915?v=4","gravatar_id":"","url":"https://api.github.com/users/mitechie","html_url":"https://github.com/mitechie","followers_url":"https://api.github.com/users/mitechie/followers","following_url":"https://api.github.com/users/mitechie/following{/other_user}","gists_url":"https://api.github.com/users/mitechie/gists{/gist_id}","starred_url":"https://api.github.com/users/mitechie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitechie/subscriptions","organizations_url":"https://api.github.com/users/mitechie/orgs","repos_url":"https://api.github.com/users/mitechie/repos","events_url":"https://api.github.com/users/mitechie/events{/privacy}","received_events_url":"https://api.github.com/users/mitechie/received_events","type":"User","site_admin":false},"body":"what's this change?","created_at":"2018-08-13T13:42:08Z","updated_at":"2018-08-13T13:47:56Z","html_url":"https://github.com/juju/juju/pull/9054#discussion_r209612656","pull_request_url":"https://api.github.com/repos/juju/juju/pulls/9054","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/juju/juju/pulls/comments/209612656"},"html":{"href":"https://github.com/juju/juju/pull/9054#discussion_r209612656"},"pull_request":{"href":"https://api.github.com/repos/juju/juju/pulls/9054"}}},"pull_request":{"url":"https://api.github.com/repos/juju/juju/pulls/9054","id":207560391,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3NTYwMzkx","html_url":"https://github.com/juju/juju/pull/9054","diff_url":"https://github.com/juju/juju/pull/9054.diff","patch_url":"https://github.com/juju/juju/pull/9054.patch","issue_url":"https://api.github.com/repos/juju/juju/issues/9054","number":9054,"state":"open","locked":false,"title":"Version bionic","user":{"login":"SimonRichardson","id":2562584,"node_id":"MDQ6VXNlcjI1NjI1ODQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2562584?v=4","gravatar_id":"","url":"https://api.github.com/users/SimonRichardson","html_url":"https://github.com/SimonRichardson","followers_url":"https://api.github.com/users/SimonRichardson/followers","following_url":"https://api.github.com/users/SimonRichardson/following{/other_user}","gists_url":"https://api.github.com/users/SimonRichardson/gists{/gist_id}","starred_url":"https://api.github.com/users/SimonRichardson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimonRichardson/subscriptions","organizations_url":"https://api.github.com/users/SimonRichardson/orgs","repos_url":"https://api.github.com/users/SimonRichardson/repos","events_url":"https://api.github.com/users/SimonRichardson/events{/privacy}","received_events_url":"https://api.github.com/users/SimonRichardson/received_events","type":"User","site_admin":false},"body":"Note: this is an update to https://github.com/juju/juju/pull/9023 where\r\nit also featured the feature tests. In order to move this PR forward quicker,\r\nI've remove the go code, so we can merge that and then we can have a\r\nPR just for the feature tests.\r\n\r\n## Description of change\r\n\r\nThis makes sure that all LXD images by default are Bionic for 2.5\r\nrelease. The issue with this is that it can cause issues from this,\r\nbecause we're now bumping the LTS version for EVERYTHING.\r\n\r\nA lot of testing should be done to ensure that we don't cause other\r\nissues for other parts of the system.\r\n\r\n## QA steps\r\n\r\nTest that launching LXD providers is possible AND that other \r\nproviders/machines aren't broken in changing this.\r\n\r\n## Documentation changes\r\n\r\nThe default LTS for juju is changing from Xenial to Bionic. You can still\r\nover ride this using the series flag if required.\r\n\r\n## Bug reference\r\n\r\nhttps://bugs.launchpad.net/juju/+bug/1785124","created_at":"2018-08-10T09:46:25Z","updated_at":"2018-08-13T13:47:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"81dd108f35bbf3120ebe7154f514ed851fd73071","assignee":null,"assignees":[],"requested_reviewers":[{"login":"anastasiamac","id":9034160,"node_id":"MDQ6VXNlcjkwMzQxNjA=","avatar_url":"https://avatars0.githubusercontent.com/u/9034160?v=4","gravatar_id":"","url":"https://api.github.com/users/anastasiamac","html_url":"https://github.com/anastasiamac","followers_url":"https://api.github.com/users/anastasiamac/followers","following_url":"https://api.github.com/users/anastasiamac/following{/other_user}","gists_url":"https://api.github.com/users/anastasiamac/gists{/gist_id}","starred_url":"https://api.github.com/users/anastasiamac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anastasiamac/subscriptions","organizations_url":"https://api.github.com/users/anastasiamac/orgs","repos_url":"https://api.github.com/users/anastasiamac/repos","events_url":"https://api.github.com/users/anastasiamac/events{/privacy}","received_events_url":"https://api.github.com/users/anastasiamac/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/juju/juju/pulls/9054/commits","review_comments_url":"https://api.github.com/repos/juju/juju/pulls/9054/comments","review_comment_url":"https://api.github.com/repos/juju/juju/pulls/comments{/number}","comments_url":"https://api.github.com/repos/juju/juju/issues/9054/comments","statuses_url":"https://api.github.com/repos/juju/juju/statuses/629d8c6fe3f614ae02d3557fe74adce5bad368bb","head":{"label":"SimonRichardson:version-bionic-2","ref":"version-bionic-2","sha":"629d8c6fe3f614ae02d3557fe74adce5bad368bb","user":{"login":"SimonRichardson","id":2562584,"node_id":"MDQ6VXNlcjI1NjI1ODQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2562584?v=4","gravatar_id":"","url":"https://api.github.com/users/SimonRichardson","html_url":"https://github.com/SimonRichardson","followers_url":"https://api.github.com/users/SimonRichardson/followers","following_url":"https://api.github.com/users/SimonRichardson/following{/other_user}","gists_url":"https://api.github.com/users/SimonRichardson/gists{/gist_id}","starred_url":"https://api.github.com/users/SimonRichardson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimonRichardson/subscriptions","organizations_url":"https://api.github.com/users/SimonRichardson/orgs","repos_url":"https://api.github.com/users/SimonRichardson/repos","events_url":"https://api.github.com/users/SimonRichardson/events{/privacy}","received_events_url":"https://api.github.com/users/SimonRichardson/received_events","type":"User","site_admin":false},"repo":{"id":130685543,"node_id":"MDEwOlJlcG9zaXRvcnkxMzA2ODU1NDM=","name":"juju","full_name":"SimonRichardson/juju","owner":{"login":"SimonRichardson","id":2562584,"node_id":"MDQ6VXNlcjI1NjI1ODQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2562584?v=4","gravatar_id":"","url":"https://api.github.com/users/SimonRichardson","html_url":"https://github.com/SimonRichardson","followers_url":"https://api.github.com/users/SimonRichardson/followers","following_url":"https://api.github.com/users/SimonRichardson/following{/other_user}","gists_url":"https://api.github.com/users/SimonRichardson/gists{/gist_id}","starred_url":"https://api.github.com/users/SimonRichardson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimonRichardson/subscriptions","organizations_url":"https://api.github.com/users/SimonRichardson/orgs","repos_url":"https://api.github.com/users/SimonRichardson/repos","events_url":"https://api.github.com/users/SimonRichardson/events{/privacy}","received_events_url":"https://api.github.com/users/SimonRichardson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SimonRichardson/juju","description":"juju is devops distilled","fork":true,"url":"https://api.github.com/repos/SimonRichardson/juju","forks_url":"https://api.github.com/repos/SimonRichardson/juju/forks","keys_url":"https://api.github.com/repos/SimonRichardson/juju/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SimonRichardson/juju/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SimonRichardson/juju/teams","hooks_url":"https://api.github.com/repos/SimonRichardson/juju/hooks","issue_events_url":"https://api.github.com/repos/SimonRichardson/juju/issues/events{/number}","events_url":"https://api.github.com/repos/SimonRichardson/juju/events","assignees_url":"https://api.github.com/repos/SimonRichardson/juju/assignees{/user}","branches_url":"https://api.github.com/repos/SimonRichardson/juju/branches{/branch}","tags_url":"https://api.github.com/repos/SimonRichardson/juju/tags","blobs_url":"https://api.github.com/repos/SimonRichardson/juju/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SimonRichardson/juju/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SimonRichardson/juju/git/refs{/sha}","trees_url":"https://api.github.com/repos/SimonRichardson/juju/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SimonRichardson/juju/statuses/{sha}","languages_url":"https://api.github.com/repos/SimonRichardson/juju/languages","stargazers_url":"https://api.github.com/repos/SimonRichardson/juju/stargazers","contributors_url":"https://api.github.com/repos/SimonRichardson/juju/contributors","subscribers_url":"https://api.github.com/repos/SimonRichardson/juju/subscribers","subscription_url":"https://api.github.com/repos/SimonRichardson/juju/subscription","commits_url":"https://api.github.com/repos/SimonRichardson/juju/commits{/sha}","git_commits_url":"https://api.github.com/repos/SimonRichardson/juju/git/commits{/sha}","comments_url":"https://api.github.com/repos/SimonRichardson/juju/comments{/number}","issue_comment_url":"https://api.github.com/repos/SimonRichardson/juju/issues/comments{/number}","contents_url":"https://api.github.com/repos/SimonRichardson/juju/contents/{+path}","compare_url":"https://api.github.com/repos/SimonRichardson/juju/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SimonRichardson/juju/merges","archive_url":"https://api.github.com/repos/SimonRichardson/juju/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SimonRichardson/juju/downloads","issues_url":"https://api.github.com/repos/SimonRichardson/juju/issues{/number}","pulls_url":"https://api.github.com/repos/SimonRichardson/juju/pulls{/number}","milestones_url":"https://api.github.com/repos/SimonRichardson/juju/milestones{/number}","notifications_url":"https://api.github.com/repos/SimonRichardson/juju/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SimonRichardson/juju/labels{/name}","releases_url":"https://api.github.com/repos/SimonRichardson/juju/releases{/id}","deployments_url":"https://api.github.com/repos/SimonRichardson/juju/deployments","created_at":"2018-04-23T11:21:20Z","updated_at":"2018-08-13T09:16:13Z","pushed_at":"2018-08-13T10:13:09Z","git_url":"git://github.com/SimonRichardson/juju.git","ssh_url":"git@github.com:SimonRichardson/juju.git","clone_url":"https://github.com/SimonRichardson/juju.git","svn_url":"https://github.com/SimonRichardson/juju","homepage":"juju.ubuntu.com","size":226175,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"juju:develop","ref":"develop","sha":"151e24275cb34c449bf0c183ac1c794b8562fcf3","user":{"login":"juju","id":4604548,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2MDQ1NDg=","avatar_url":"https://avatars0.githubusercontent.com/u/4604548?v=4","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"repo":{"id":20445947,"node_id":"MDEwOlJlcG9zaXRvcnkyMDQ0NTk0Nw==","name":"juju","full_name":"juju/juju","owner":{"login":"juju","id":4604548,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2MDQ1NDg=","avatar_url":"https://avatars0.githubusercontent.com/u/4604548?v=4","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/juju/juju","description":"juju is devops distilled","fork":false,"url":"https://api.github.com/repos/juju/juju","forks_url":"https://api.github.com/repos/juju/juju/forks","keys_url":"https://api.github.com/repos/juju/juju/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juju/juju/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juju/juju/teams","hooks_url":"https://api.github.com/repos/juju/juju/hooks","issue_events_url":"https://api.github.com/repos/juju/juju/issues/events{/number}","events_url":"https://api.github.com/repos/juju/juju/events","assignees_url":"https://api.github.com/repos/juju/juju/assignees{/user}","branches_url":"https://api.github.com/repos/juju/juju/branches{/branch}","tags_url":"https://api.github.com/repos/juju/juju/tags","blobs_url":"https://api.github.com/repos/juju/juju/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juju/juju/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juju/juju/git/refs{/sha}","trees_url":"https://api.github.com/repos/juju/juju/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juju/juju/statuses/{sha}","languages_url":"https://api.github.com/repos/juju/juju/languages","stargazers_url":"https://api.github.com/repos/juju/juju/stargazers","contributors_url":"https://api.github.com/repos/juju/juju/contributors","subscribers_url":"https://api.github.com/repos/juju/juju/subscribers","subscription_url":"https://api.github.com/repos/juju/juju/subscription","commits_url":"https://api.github.com/repos/juju/juju/commits{/sha}","git_commits_url":"https://api.github.com/repos/juju/juju/git/commits{/sha}","comments_url":"https://api.github.com/repos/juju/juju/comments{/number}","issue_comment_url":"https://api.github.com/repos/juju/juju/issues/comments{/number}","contents_url":"https://api.github.com/repos/juju/juju/contents/{+path}","compare_url":"https://api.github.com/repos/juju/juju/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juju/juju/merges","archive_url":"https://api.github.com/repos/juju/juju/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juju/juju/downloads","issues_url":"https://api.github.com/repos/juju/juju/issues{/number}","pulls_url":"https://api.github.com/repos/juju/juju/pulls{/number}","milestones_url":"https://api.github.com/repos/juju/juju/milestones{/number}","notifications_url":"https://api.github.com/repos/juju/juju/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juju/juju/labels{/name}","releases_url":"https://api.github.com/repos/juju/juju/releases{/id}","deployments_url":"https://api.github.com/repos/juju/juju/deployments","created_at":"2014-06-03T14:28:10Z","updated_at":"2018-08-10T17:59:14Z","pushed_at":"2018-08-13T09:54:37Z","git_url":"git://github.com/juju/juju.git","ssh_url":"git@github.com:juju/juju.git","clone_url":"https://github.com/juju/juju.git","svn_url":"https://github.com/juju/juju","homepage":"juju.ubuntu.com","size":226108,"stargazers_count":1198,"watchers_count":1198,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":276,"mirror_url":null,"archived":false,"open_issues_count":19,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":276,"open_issues":19,"watchers":1198,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/juju/juju/pulls/9054"},"html":{"href":"https://github.com/juju/juju/pull/9054"},"issue":{"href":"https://api.github.com/repos/juju/juju/issues/9054"},"comments":{"href":"https://api.github.com/repos/juju/juju/issues/9054/comments"},"review_comments":{"href":"https://api.github.com/repos/juju/juju/pulls/9054/comments"},"review_comment":{"href":"https://api.github.com/repos/juju/juju/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/juju/juju/pulls/9054/commits"},"statuses":{"href":"https://api.github.com/repos/juju/juju/statuses/629d8c6fe3f614ae02d3557fe74adce5bad368bb"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"mitechie"}}