{"action":"closed","number":14343,"pull_request":{"url":"https://api.github.com/repos/frappe/erpnext/pulls/14343","id":192363312,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyMzYzMzEy","html_url":"https://github.com/frappe/erpnext/pull/14343","diff_url":"https://github.com/frappe/erpnext/pull/14343.diff","patch_url":"https://github.com/frappe/erpnext/pull/14343.patch","issue_url":"https://api.github.com/repos/frappe/erpnext/issues/14343","number":14343,"state":"closed","locked":false,"title":"Validate response message for frappe call","user":{"login":"sushantnadkar","id":8912289,"node_id":"MDQ6VXNlcjg5MTIyODk=","avatar_url":"https://avatars3.githubusercontent.com/u/8912289?v=4","gravatar_id":"","url":"https://api.github.com/users/sushantnadkar","html_url":"https://github.com/sushantnadkar","followers_url":"https://api.github.com/users/sushantnadkar/followers","following_url":"https://api.github.com/users/sushantnadkar/following{/other_user}","gists_url":"https://api.github.com/users/sushantnadkar/gists{/gist_id}","starred_url":"https://api.github.com/users/sushantnadkar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sushantnadkar/subscriptions","organizations_url":"https://api.github.com/users/sushantnadkar/orgs","repos_url":"https://api.github.com/users/sushantnadkar/repos","events_url":"https://api.github.com/users/sushantnadkar/events{/privacy}","received_events_url":"https://api.github.com/users/sushantnadkar/received_events","type":"User","site_admin":false},"body":"Pull-Request\r\n\r\n- [x] Have you followed the guidelines in our Contributing document?\r\n- [x] Have you checked to ensure there aren't other open [Pull Requests](../pulls) for the same update/change?\r\n- [x] Have you lint your code locally prior to submission?\r\n- [ ] Have you successfully run tests with your changes locally?\r\n- [x] Does your commit message have an explanation for your changes and why you'd like us to include them?\r\n- [ ] Docs have been added / updated\r\n- [ ] Tests for the changes have been added (for bug fixes / features)\r\n- [ ] Did you modify the existing test cases? If yes, why?\r\n\r\n---\r\n\r\nWhat type of a PR is this? \r\n\r\n- [ ] Changes to Existing Features\r\n- [ ] New Feature Submissions\r\n- [x] Bug Fix\r\n- [ ] Breaking Change\r\n\r\n--- \r\n\r\n- Motivation and Context (What existing problem does the pull request solve): NA\r\n- Fix:\r\nIf the response is empty on clicking Link to Material Request in Request for Quotation, there was a console error Unable to handle success response. So added a check to see if r.message exists or not before accessing it.\r\n- Related Issue: NA\r\n- Screenshots (if applicable, remember, a picture tells a thousand words): NA\r\n\r\n","created_at":"2018-06-04T10:26:20Z","updated_at":"2018-06-05T05:03:05Z","closed_at":"2018-06-05T05:03:05Z","merged_at":"2018-06-05T05:03:05Z","merge_commit_sha":"64907e5083f9f8ec2453a8d0492c777afa933c8f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/frappe/erpnext/pulls/14343/commits","review_comments_url":"https://api.github.com/repos/frappe/erpnext/pulls/14343/comments","review_comment_url":"https://api.github.com/repos/frappe/erpnext/pulls/comments{/number}","comments_url":"https://api.github.com/repos/frappe/erpnext/issues/14343/comments","statuses_url":"https://api.github.com/repos/frappe/erpnext/statuses/ef903096052c408d729c80051d89f527ad8ea39e","head":{"label":"sushantnadkar:validate-response-in-buyingjs-frappe","ref":"validate-response-in-buyingjs-frappe","sha":"ef903096052c408d729c80051d89f527ad8ea39e","user":{"login":"sushantnadkar","id":8912289,"node_id":"MDQ6VXNlcjg5MTIyODk=","avatar_url":"https://avatars3.githubusercontent.com/u/8912289?v=4","gravatar_id":"","url":"https://api.github.com/users/sushantnadkar","html_url":"https://github.com/sushantnadkar","followers_url":"https://api.github.com/users/sushantnadkar/followers","following_url":"https://api.github.com/users/sushantnadkar/following{/other_user}","gists_url":"https://api.github.com/users/sushantnadkar/gists{/gist_id}","starred_url":"https://api.github.com/users/sushantnadkar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sushantnadkar/subscriptions","organizations_url":"https://api.github.com/users/sushantnadkar/orgs","repos_url":"https://api.github.com/users/sushantnadkar/repos","events_url":"https://api.github.com/users/sushantnadkar/events{/privacy}","received_events_url":"https://api.github.com/users/sushantnadkar/received_events","type":"User","site_admin":false},"repo":{"id":90947683,"node_id":"MDEwOlJlcG9zaXRvcnk5MDk0NzY4Mw==","name":"erpnext","full_name":"sushantnadkar/erpnext","owner":{"login":"sushantnadkar","id":8912289,"node_id":"MDQ6VXNlcjg5MTIyODk=","avatar_url":"https://avatars3.githubusercontent.com/u/8912289?v=4","gravatar_id":"","url":"https://api.github.com/users/sushantnadkar","html_url":"https://github.com/sushantnadkar","followers_url":"https://api.github.com/users/sushantnadkar/followers","following_url":"https://api.github.com/users/sushantnadkar/following{/other_user}","gists_url":"https://api.github.com/users/sushantnadkar/gists{/gist_id}","starred_url":"https://api.github.com/users/sushantnadkar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sushantnadkar/subscriptions","organizations_url":"https://api.github.com/users/sushantnadkar/orgs","repos_url":"https://api.github.com/users/sushantnadkar/repos","events_url":"https://api.github.com/users/sushantnadkar/events{/privacy}","received_events_url":"https://api.github.com/users/sushantnadkar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sushantnadkar/erpnext","description":"ERP made Simple","fork":true,"url":"https://api.github.com/repos/sushantnadkar/erpnext","forks_url":"https://api.github.com/repos/sushantnadkar/erpnext/forks","keys_url":"https://api.github.com/repos/sushantnadkar/erpnext/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sushantnadkar/erpnext/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sushantnadkar/erpnext/teams","hooks_url":"https://api.github.com/repos/sushantnadkar/erpnext/hooks","issue_events_url":"https://api.github.com/repos/sushantnadkar/erpnext/issues/events{/number}","events_url":"https://api.github.com/repos/sushantnadkar/erpnext/events","assignees_url":"https://api.github.com/repos/sushantnadkar/erpnext/assignees{/user}","branches_url":"https://api.github.com/repos/sushantnadkar/erpnext/branches{/branch}","tags_url":"https://api.github.com/repos/sushantnadkar/erpnext/tags","blobs_url":"https://api.github.com/repos/sushantnadkar/erpnext/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sushantnadkar/erpnext/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sushantnadkar/erpnext/git/refs{/sha}","trees_url":"https://api.github.com/repos/sushantnadkar/erpnext/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sushantnadkar/erpnext/statuses/{sha}","languages_url":"https://api.github.com/repos/sushantnadkar/erpnext/languages","stargazers_url":"https://api.github.com/repos/sushantnadkar/erpnext/stargazers","contributors_url":"https://api.github.com/repos/sushantnadkar/erpnext/contributors","subscribers_url":"https://api.github.com/repos/sushantnadkar/erpnext/subscribers","subscription_url":"https://api.github.com/repos/sushantnadkar/erpnext/subscription","commits_url":"https://api.github.com/repos/sushantnadkar/erpnext/commits{/sha}","git_commits_url":"https://api.github.com/repos/sushantnadkar/erpnext/git/commits{/sha}","comments_url":"https://api.github.com/repos/sushantnadkar/erpnext/comments{/number}","issue_comment_url":"https://api.github.com/repos/sushantnadkar/erpnext/issues/comments{/number}","contents_url":"https://api.github.com/repos/sushantnadkar/erpnext/contents/{+path}","compare_url":"https://api.github.com/repos/sushantnadkar/erpnext/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sushantnadkar/erpnext/merges","archive_url":"https://api.github.com/repos/sushantnadkar/erpnext/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sushantnadkar/erpnext/downloads","issues_url":"https://api.github.com/repos/sushantnadkar/erpnext/issues{/number}","pulls_url":"https://api.github.com/repos/sushantnadkar/erpnext/pulls{/number}","milestones_url":"https://api.github.com/repos/sushantnadkar/erpnext/milestones{/number}","notifications_url":"https://api.github.com/repos/sushantnadkar/erpnext/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sushantnadkar/erpnext/labels{/name}","releases_url":"https://api.github.com/repos/sushantnadkar/erpnext/releases{/id}","deployments_url":"https://api.github.com/repos/sushantnadkar/erpnext/deployments","created_at":"2017-05-11T06:57:11Z","updated_at":"2017-05-11T06:57:23Z","pushed_at":"2018-06-04T10:24:39Z","git_url":"git://github.com/sushantnadkar/erpnext.git","ssh_url":"git@github.com:sushantnadkar/erpnext.git","clone_url":"https://github.com/sushantnadkar/erpnext.git","svn_url":"https://github.com/sushantnadkar/erpnext","homepage":"http://erpnext.com","size":576777,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"frappe:develop","ref":"develop","sha":"37678d48389cb6a642cd9fa65fcc93ea68b2f8ab","user":{"login":"frappe","id":836974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgzNjk3NA==","avatar_url":"https://avatars2.githubusercontent.com/u/836974?v=4","gravatar_id":"","url":"https://api.github.com/users/frappe","html_url":"https://github.com/frappe","followers_url":"https://api.github.com/users/frappe/followers","following_url":"https://api.github.com/users/frappe/following{/other_user}","gists_url":"https://api.github.com/users/frappe/gists{/gist_id}","starred_url":"https://api.github.com/users/frappe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frappe/subscriptions","organizations_url":"https://api.github.com/users/frappe/orgs","repos_url":"https://api.github.com/users/frappe/repos","events_url":"https://api.github.com/users/frappe/events{/privacy}","received_events_url":"https://api.github.com/users/frappe/received_events","type":"Organization","site_admin":false},"repo":{"id":1864233,"node_id":"MDEwOlJlcG9zaXRvcnkxODY0MjMz","name":"erpnext","full_name":"frappe/erpnext","owner":{"login":"frappe","id":836974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgzNjk3NA==","avatar_url":"https://avatars2.githubusercontent.com/u/836974?v=4","gravatar_id":"","url":"https://api.github.com/users/frappe","html_url":"https://github.com/frappe","followers_url":"https://api.github.com/users/frappe/followers","following_url":"https://api.github.com/users/frappe/following{/other_user}","gists_url":"https://api.github.com/users/frappe/gists{/gist_id}","starred_url":"https://api.github.com/users/frappe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frappe/subscriptions","organizations_url":"https://api.github.com/users/frappe/orgs","repos_url":"https://api.github.com/users/frappe/repos","events_url":"https://api.github.com/users/frappe/events{/privacy}","received_events_url":"https://api.github.com/users/frappe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/frappe/erpnext","description":"Open Source ERP built for the web","fork":false,"url":"https://api.github.com/repos/frappe/erpnext","forks_url":"https://api.github.com/repos/frappe/erpnext/forks","keys_url":"https://api.github.com/repos/frappe/erpnext/keys{/key_id}","collaborators_url":"https://api.github.com/repos/frappe/erpnext/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/frappe/erpnext/teams","hooks_url":"https://api.github.com/repos/frappe/erpnext/hooks","issue_events_url":"https://api.github.com/repos/frappe/erpnext/issues/events{/number}","events_url":"https://api.github.com/repos/frappe/erpnext/events","assignees_url":"https://api.github.com/repos/frappe/erpnext/assignees{/user}","branches_url":"https://api.github.com/repos/frappe/erpnext/branches{/branch}","tags_url":"https://api.github.com/repos/frappe/erpnext/tags","blobs_url":"https://api.github.com/repos/frappe/erpnext/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/frappe/erpnext/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/frappe/erpnext/git/refs{/sha}","trees_url":"https://api.github.com/repos/frappe/erpnext/git/trees{/sha}","statuses_url":"https://api.github.com/repos/frappe/erpnext/statuses/{sha}","languages_url":"https://api.github.com/repos/frappe/erpnext/languages","stargazers_url":"https://api.github.com/repos/frappe/erpnext/stargazers","contributors_url":"https://api.github.com/repos/frappe/erpnext/contributors","subscribers_url":"https://api.github.com/repos/frappe/erpnext/subscribers","subscription_url":"https://api.github.com/repos/frappe/erpnext/subscription","commits_url":"https://api.github.com/repos/frappe/erpnext/commits{/sha}","git_commits_url":"https://api.github.com/repos/frappe/erpnext/git/commits{/sha}","comments_url":"https://api.github.com/repos/frappe/erpnext/comments{/number}","issue_comment_url":"https://api.github.com/repos/frappe/erpnext/issues/comments{/number}","contents_url":"https://api.github.com/repos/frappe/erpnext/contents/{+path}","compare_url":"https://api.github.com/repos/frappe/erpnext/compare/{base}...{head}","merges_url":"https://api.github.com/repos/frappe/erpnext/merges","archive_url":"https://api.github.com/repos/frappe/erpnext/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/frappe/erpnext/downloads","issues_url":"https://api.github.com/repos/frappe/erpnext/issues{/number}","pulls_url":"https://api.github.com/repos/frappe/erpnext/pulls{/number}","milestones_url":"https://api.github.com/repos/frappe/erpnext/milestones{/number}","notifications_url":"https://api.github.com/repos/frappe/erpnext/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/frappe/erpnext/labels{/name}","releases_url":"https://api.github.com/repos/frappe/erpnext/releases{/id}","deployments_url":"https://api.github.com/repos/frappe/erpnext/deployments","created_at":"2011-06-08T08:20:56Z","updated_at":"2018-06-05T05:00:11Z","pushed_at":"2018-06-05T05:03:05Z","git_url":"git://github.com/frappe/erpnext.git","ssh_url":"git@github.com:frappe/erpnext.git","clone_url":"https://github.com/frappe/erpnext.git","svn_url":"https://github.com/frappe/erpnext","homepage":"http://erpnext.com","size":579227,"stargazers_count":3149,"watchers_count":3149,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1599,"mirror_url":null,"archived":false,"open_issues_count":1503,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":1599,"open_issues":1503,"watchers":3149,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/frappe/erpnext/pulls/14343"},"html":{"href":"https://github.com/frappe/erpnext/pull/14343"},"issue":{"href":"https://api.github.com/repos/frappe/erpnext/issues/14343"},"comments":{"href":"https://api.github.com/repos/frappe/erpnext/issues/14343/comments"},"review_comments":{"href":"https://api.github.com/repos/frappe/erpnext/pulls/14343/comments"},"review_comment":{"href":"https://api.github.com/repos/frappe/erpnext/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/frappe/erpnext/pulls/14343/commits"},"statuses":{"href":"https://api.github.com/repos/frappe/erpnext/statuses/ef903096052c408d729c80051d89f527ad8ea39e"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"rmehta","id":140076,"node_id":"MDQ6VXNlcjE0MDA3Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/140076?v=4","gravatar_id":"","url":"https://api.github.com/users/rmehta","html_url":"https://github.com/rmehta","followers_url":"https://api.github.com/users/rmehta/followers","following_url":"https://api.github.com/users/rmehta/following{/other_user}","gists_url":"https://api.github.com/users/rmehta/gists{/gist_id}","starred_url":"https://api.github.com/users/rmehta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmehta/subscriptions","organizations_url":"https://api.github.com/users/rmehta/orgs","repos_url":"https://api.github.com/users/rmehta/repos","events_url":"https://api.github.com/users/rmehta/events{/privacy}","received_events_url":"https://api.github.com/users/rmehta/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"rmehta"}}