{"action":"created","issue":{"url":"https://api.github.com/repos/spinnaker/deck/issues/5260","repository_url":"https://api.github.com/repos/spinnaker/deck","labels_url":"https://api.github.com/repos/spinnaker/deck/issues/5260/labels{/name}","comments_url":"https://api.github.com/repos/spinnaker/deck/issues/5260/comments","events_url":"https://api.github.com/repos/spinnaker/deck/issues/5260/events","html_url":"https://github.com/spinnaker/deck/pull/5260","id":320019223,"number":5260,"title":"perf(*): transpile to latest two modern browsers only","user":{"login":"anotherchrisberry","id":73450,"avatar_url":"https://avatars0.githubusercontent.com/u/73450?v=4","gravatar_id":"","url":"https://api.github.com/users/anotherchrisberry","html_url":"https://github.com/anotherchrisberry","followers_url":"https://api.github.com/users/anotherchrisberry/followers","following_url":"https://api.github.com/users/anotherchrisberry/following{/other_user}","gists_url":"https://api.github.com/users/anotherchrisberry/gists{/gist_id}","starred_url":"https://api.github.com/users/anotherchrisberry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anotherchrisberry/subscriptions","organizations_url":"https://api.github.com/users/anotherchrisberry/orgs","repos_url":"https://api.github.com/users/anotherchrisberry/repos","events_url":"https://api.github.com/users/anotherchrisberry/events{/privacy}","received_events_url":"https://api.github.com/users/anotherchrisberry/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-05-03T17:52:44Z","updated_at":"2018-05-03T23:26:39Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/spinnaker/deck/pulls/5260","html_url":"https://github.com/spinnaker/deck/pull/5260","diff_url":"https://github.com/spinnaker/deck/pull/5260.diff","patch_url":"https://github.com/spinnaker/deck/pull/5260.patch"},"body":"There's no need to support the last two versions of all browsers - it's enough to support the major modern evergreen browsers. This allows us to avoid a lot of polyfilled/downgraded method transforms, which shrinks our generated code a fair amount: \r\n* core goes from 2.67MB now to 2.05MB here\r\n* amazon goes from 665K to 550K\r\n\r\nDownside(?): we have to stop using `@BindAll`, as it does not play nicely with ES5+ classes. The way around this is to explicitly use arrow functions where needed, which is fine and maybe more performant?\r\n\r\nI went through all the files changed twice, looking for cases where it will be broken by the bindall conversion, but I'm sure I missed one or two things, so I'll keep a close eye on it when it's deployed."},"comment":{"url":"https://api.github.com/repos/spinnaker/deck/issues/comments/386466378","html_url":"https://github.com/spinnaker/deck/pull/5260#issuecomment-386466378","issue_url":"https://api.github.com/repos/spinnaker/deck/issues/5260","id":386466378,"user":{"login":"anotherchrisberry","id":73450,"avatar_url":"https://avatars0.githubusercontent.com/u/73450?v=4","gravatar_id":"","url":"https://api.github.com/users/anotherchrisberry","html_url":"https://github.com/anotherchrisberry","followers_url":"https://api.github.com/users/anotherchrisberry/followers","following_url":"https://api.github.com/users/anotherchrisberry/following{/other_user}","gists_url":"https://api.github.com/users/anotherchrisberry/gists{/gist_id}","starred_url":"https://api.github.com/users/anotherchrisberry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anotherchrisberry/subscriptions","organizations_url":"https://api.github.com/users/anotherchrisberry/orgs","repos_url":"https://api.github.com/users/anotherchrisberry/repos","events_url":"https://api.github.com/users/anotherchrisberry/events{/privacy}","received_events_url":"https://api.github.com/users/anotherchrisberry/received_events","type":"User","site_admin":false},"created_at":"2018-05-03T23:26:39Z","updated_at":"2018-05-03T23:26:39Z","author_association":"CONTRIBUTOR","body":"Another thing I noticed: in Angular component controllers, the constructor is now being called before the bindings occur. I think it was always assumed that would be happening, but am not sure why it started now.\r\n\r\n@danielpeach or @sbwsg PTAL - there are a few changes in Kubernetes and GAE I could not test."}}
{"actor":{"display_login":"anotherchrisberry"}}