{"action":"opened","issue":{"url":"https://api.github.com/repos/wiseodd/controlled-text-generation/issues/15","repository_url":"https://api.github.com/repos/wiseodd/controlled-text-generation","labels_url":"https://api.github.com/repos/wiseodd/controlled-text-generation/issues/15/labels{/name}","comments_url":"https://api.github.com/repos/wiseodd/controlled-text-generation/issues/15/comments","events_url":"https://api.github.com/repos/wiseodd/controlled-text-generation/issues/15/events","html_url":"https://github.com/wiseodd/controlled-text-generation/issues/15","id":335910847,"node_id":"MDU6SXNzdWUzMzU5MTA4NDc=","number":15,"title":"Un-intuitive naming convention","user":{"login":"nabihach","id":6519168,"node_id":"MDQ6VXNlcjY1MTkxNjg=","avatar_url":"https://avatars0.githubusercontent.com/u/6519168?v=4","gravatar_id":"","url":"https://api.github.com/users/nabihach","html_url":"https://github.com/nabihach","followers_url":"https://api.github.com/users/nabihach/followers","following_url":"https://api.github.com/users/nabihach/following{/other_user}","gists_url":"https://api.github.com/users/nabihach/gists{/gist_id}","starred_url":"https://api.github.com/users/nabihach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nabihach/subscriptions","organizations_url":"https://api.github.com/users/nabihach/orgs","repos_url":"https://api.github.com/users/nabihach/repos","events_url":"https://api.github.com/users/nabihach/events{/privacy}","received_events_url":"https://api.github.com/users/nabihach/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-06-26T16:57:56Z","updated_at":"2018-06-26T16:57:56Z","closed_at":null,"author_association":"NONE","body":"In `train_discriminator.py`, lines 78-79:\r\n```\r\ntrainer_G = optim.Adam(model.encoder_params, lr=lr)\r\ntrainer_E = optim.Adam(model.decoder_params, lr=lr)\r\n```\r\nShouldn't the names be opposite? I.e. `trainer_E` should refer to encoder's params and `trainer_G` should refer to decoder params. I guess I'm finding it a little unintuitive, that's all.\r\n"}}
{"actor":{"display_login":"nabihach"}}