{"action":"created","comment":{"url":"https://api.github.com/repos/PolymerLabs/arcs/pulls/comments/174307348","pull_request_review_id":103639859,"id":174307348,"diff_hunk":"@@ -37,40 +37,46 @@ defineParticle(({TransformationDomParticle}) => {\n           this._connByHostedConn.set(hostedOtherConnection.name, connectionName);\n         }\n       }\n+      this.setState({arc, type: views.get('list').type, hostedParticle, otherMappedViews, otherConnections});\n \n-      this.on(views, 'list', 'change', async e => {\n-        let listHandle = views.get('list');\n-        let list = await listHandle.toList();\n+      super.setViews(views);\n+    }\n \n-        if (list.length > 0) {\n-          this.relevance = 0.1;\n+    async willReceiveProps({list}) {\n+      if (list.length > 0) {\n+        this.relevance = 0.1;\n+      }\n+      let arc = this._state.arc;","path":"shell/artifacts/Common/source/Multiplexer.js","position":18,"original_position":18,"commit_id":"3a1bfbab9c3b565bc13baf8df2ee9a21814e85cf","original_commit_id":"3a1bfbab9c3b565bc13baf8df2ee9a21814e85cf","user":{"login":"sjmiles","id":98045,"avatar_url":"https://avatars2.githubusercontent.com/u/98045?v=4","gravatar_id":"","url":"https://api.github.com/users/sjmiles","html_url":"https://github.com/sjmiles","followers_url":"https://api.github.com/users/sjmiles/followers","following_url":"https://api.github.com/users/sjmiles/following{/other_user}","gists_url":"https://api.github.com/users/sjmiles/gists{/gist_id}","starred_url":"https://api.github.com/users/sjmiles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjmiles/subscriptions","organizations_url":"https://api.github.com/users/sjmiles/orgs","repos_url":"https://api.github.com/users/sjmiles/repos","events_url":"https://api.github.com/users/sjmiles/events{/privacy}","received_events_url":"https://api.github.com/users/sjmiles/received_events","type":"User","site_admin":false},"body":"`state` is also a parameter (`willReceiveProps(props, state, oldProps, oldState)` like all of the lifecycle methods). Suggest you gather these variables via destructuring the parameter (either directly in the signature, or via a `const` declaration [like `const {arc, type, ...} = state;`]).\r\n\r\nFwiw, anytime you use `this._state` or `this._props`, it's a red-flag that something is awry.","created_at":"2018-03-13T22:39:57Z","updated_at":"2018-03-13T22:41:46Z","html_url":"https://github.com/PolymerLabs/arcs/pull/941#discussion_r174307348","pull_request_url":"https://api.github.com/repos/PolymerLabs/arcs/pulls/941","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/PolymerLabs/arcs/pulls/comments/174307348"},"html":{"href":"https://github.com/PolymerLabs/arcs/pull/941#discussion_r174307348"},"pull_request":{"href":"https://api.github.com/repos/PolymerLabs/arcs/pulls/941"}}},"pull_request":{"url":"https://api.github.com/repos/PolymerLabs/arcs/pulls/941","id":174504352,"html_url":"https://github.com/PolymerLabs/arcs/pull/941","diff_url":"https://github.com/PolymerLabs/arcs/pull/941.diff","patch_url":"https://github.com/PolymerLabs/arcs/pull/941.patch","issue_url":"https://api.github.com/repos/PolymerLabs/arcs/issues/941","number":941,"state":"open","locked":false,"title":"DomParticle subclasses to call super impl when overriding `setViews`","user":{"login":"mmandlis","id":25067830,"avatar_url":"https://avatars3.githubusercontent.com/u/25067830?v=4","gravatar_id":"","url":"https://api.github.com/users/mmandlis","html_url":"https://github.com/mmandlis","followers_url":"https://api.github.com/users/mmandlis/followers","following_url":"https://api.github.com/users/mmandlis/following{/other_user}","gists_url":"https://api.github.com/users/mmandlis/gists{/gist_id}","starred_url":"https://api.github.com/users/mmandlis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmandlis/subscriptions","organizations_url":"https://api.github.com/users/mmandlis/orgs","repos_url":"https://api.github.com/users/mmandlis/repos","events_url":"https://api.github.com/users/mmandlis/events{/privacy}","received_events_url":"https://api.github.com/users/mmandlis/received_events","type":"User","site_admin":false},"body":"fixes: https://github.com/PolymerLabs/arcs/issues/928","created_at":"2018-03-12T21:48:25Z","updated_at":"2018-03-13T22:41:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fe50ef0f80957c63f877875f89967487bc60ca5f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/PolymerLabs/arcs/pulls/941/commits","review_comments_url":"https://api.github.com/repos/PolymerLabs/arcs/pulls/941/comments","review_comment_url":"https://api.github.com/repos/PolymerLabs/arcs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PolymerLabs/arcs/issues/941/comments","statuses_url":"https://api.github.com/repos/PolymerLabs/arcs/statuses/3a1bfbab9c3b565bc13baf8df2ee9a21814e85cf","head":{"label":"mmandlis:muxer-setviews","ref":"muxer-setviews","sha":"3a1bfbab9c3b565bc13baf8df2ee9a21814e85cf","user":{"login":"mmandlis","id":25067830,"avatar_url":"https://avatars3.githubusercontent.com/u/25067830?v=4","gravatar_id":"","url":"https://api.github.com/users/mmandlis","html_url":"https://github.com/mmandlis","followers_url":"https://api.github.com/users/mmandlis/followers","following_url":"https://api.github.com/users/mmandlis/following{/other_user}","gists_url":"https://api.github.com/users/mmandlis/gists{/gist_id}","starred_url":"https://api.github.com/users/mmandlis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmandlis/subscriptions","organizations_url":"https://api.github.com/users/mmandlis/orgs","repos_url":"https://api.github.com/users/mmandlis/repos","events_url":"https://api.github.com/users/mmandlis/events{/privacy}","received_events_url":"https://api.github.com/users/mmandlis/received_events","type":"User","site_admin":false},"repo":{"id":90201520,"name":"arcs","full_name":"mmandlis/arcs","owner":{"login":"mmandlis","id":25067830,"avatar_url":"https://avatars3.githubusercontent.com/u/25067830?v=4","gravatar_id":"","url":"https://api.github.com/users/mmandlis","html_url":"https://github.com/mmandlis","followers_url":"https://api.github.com/users/mmandlis/followers","following_url":"https://api.github.com/users/mmandlis/following{/other_user}","gists_url":"https://api.github.com/users/mmandlis/gists{/gist_id}","starred_url":"https://api.github.com/users/mmandlis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmandlis/subscriptions","organizations_url":"https://api.github.com/users/mmandlis/orgs","repos_url":"https://api.github.com/users/mmandlis/repos","events_url":"https://api.github.com/users/mmandlis/events{/privacy}","received_events_url":"https://api.github.com/users/mmandlis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mmandlis/arcs","description":null,"fork":true,"url":"https://api.github.com/repos/mmandlis/arcs","forks_url":"https://api.github.com/repos/mmandlis/arcs/forks","keys_url":"https://api.github.com/repos/mmandlis/arcs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mmandlis/arcs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mmandlis/arcs/teams","hooks_url":"https://api.github.com/repos/mmandlis/arcs/hooks","issue_events_url":"https://api.github.com/repos/mmandlis/arcs/issues/events{/number}","events_url":"https://api.github.com/repos/mmandlis/arcs/events","assignees_url":"https://api.github.com/repos/mmandlis/arcs/assignees{/user}","branches_url":"https://api.github.com/repos/mmandlis/arcs/branches{/branch}","tags_url":"https://api.github.com/repos/mmandlis/arcs/tags","blobs_url":"https://api.github.com/repos/mmandlis/arcs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mmandlis/arcs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mmandlis/arcs/git/refs{/sha}","trees_url":"https://api.github.com/repos/mmandlis/arcs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mmandlis/arcs/statuses/{sha}","languages_url":"https://api.github.com/repos/mmandlis/arcs/languages","stargazers_url":"https://api.github.com/repos/mmandlis/arcs/stargazers","contributors_url":"https://api.github.com/repos/mmandlis/arcs/contributors","subscribers_url":"https://api.github.com/repos/mmandlis/arcs/subscribers","subscription_url":"https://api.github.com/repos/mmandlis/arcs/subscription","commits_url":"https://api.github.com/repos/mmandlis/arcs/commits{/sha}","git_commits_url":"https://api.github.com/repos/mmandlis/arcs/git/commits{/sha}","comments_url":"https://api.github.com/repos/mmandlis/arcs/comments{/number}","issue_comment_url":"https://api.github.com/repos/mmandlis/arcs/issues/comments{/number}","contents_url":"https://api.github.com/repos/mmandlis/arcs/contents/{+path}","compare_url":"https://api.github.com/repos/mmandlis/arcs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mmandlis/arcs/merges","archive_url":"https://api.github.com/repos/mmandlis/arcs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mmandlis/arcs/downloads","issues_url":"https://api.github.com/repos/mmandlis/arcs/issues{/number}","pulls_url":"https://api.github.com/repos/mmandlis/arcs/pulls{/number}","milestones_url":"https://api.github.com/repos/mmandlis/arcs/milestones{/number}","notifications_url":"https://api.github.com/repos/mmandlis/arcs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mmandlis/arcs/labels{/name}","releases_url":"https://api.github.com/repos/mmandlis/arcs/releases{/id}","deployments_url":"https://api.github.com/repos/mmandlis/arcs/deployments","created_at":"2017-05-03T23:20:21Z","updated_at":"2017-05-03T23:20:22Z","pushed_at":"2018-03-13T22:07:43Z","git_url":"git://github.com/mmandlis/arcs.git","ssh_url":"git@github.com:mmandlis/arcs.git","clone_url":"https://github.com/mmandlis/arcs.git","svn_url":"https://github.com/mmandlis/arcs","homepage":null,"size":20947,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PolymerLabs:master","ref":"master","sha":"2ffd557baa49f435a2a200900177141cd1fc722d","user":{"login":"PolymerLabs","id":5912903,"avatar_url":"https://avatars2.githubusercontent.com/u/5912903?v=4","gravatar_id":"","url":"https://api.github.com/users/PolymerLabs","html_url":"https://github.com/PolymerLabs","followers_url":"https://api.github.com/users/PolymerLabs/followers","following_url":"https://api.github.com/users/PolymerLabs/following{/other_user}","gists_url":"https://api.github.com/users/PolymerLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/PolymerLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolymerLabs/subscriptions","organizations_url":"https://api.github.com/users/PolymerLabs/orgs","repos_url":"https://api.github.com/users/PolymerLabs/repos","events_url":"https://api.github.com/users/PolymerLabs/events{/privacy}","received_events_url":"https://api.github.com/users/PolymerLabs/received_events","type":"Organization","site_admin":false},"repo":{"id":80783122,"name":"arcs","full_name":"PolymerLabs/arcs","owner":{"login":"PolymerLabs","id":5912903,"avatar_url":"https://avatars2.githubusercontent.com/u/5912903?v=4","gravatar_id":"","url":"https://api.github.com/users/PolymerLabs","html_url":"https://github.com/PolymerLabs","followers_url":"https://api.github.com/users/PolymerLabs/followers","following_url":"https://api.github.com/users/PolymerLabs/following{/other_user}","gists_url":"https://api.github.com/users/PolymerLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/PolymerLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolymerLabs/subscriptions","organizations_url":"https://api.github.com/users/PolymerLabs/orgs","repos_url":"https://api.github.com/users/PolymerLabs/repos","events_url":"https://api.github.com/users/PolymerLabs/events{/privacy}","received_events_url":"https://api.github.com/users/PolymerLabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PolymerLabs/arcs","description":null,"fork":false,"url":"https://api.github.com/repos/PolymerLabs/arcs","forks_url":"https://api.github.com/repos/PolymerLabs/arcs/forks","keys_url":"https://api.github.com/repos/PolymerLabs/arcs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PolymerLabs/arcs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PolymerLabs/arcs/teams","hooks_url":"https://api.github.com/repos/PolymerLabs/arcs/hooks","issue_events_url":"https://api.github.com/repos/PolymerLabs/arcs/issues/events{/number}","events_url":"https://api.github.com/repos/PolymerLabs/arcs/events","assignees_url":"https://api.github.com/repos/PolymerLabs/arcs/assignees{/user}","branches_url":"https://api.github.com/repos/PolymerLabs/arcs/branches{/branch}","tags_url":"https://api.github.com/repos/PolymerLabs/arcs/tags","blobs_url":"https://api.github.com/repos/PolymerLabs/arcs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PolymerLabs/arcs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PolymerLabs/arcs/git/refs{/sha}","trees_url":"https://api.github.com/repos/PolymerLabs/arcs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PolymerLabs/arcs/statuses/{sha}","languages_url":"https://api.github.com/repos/PolymerLabs/arcs/languages","stargazers_url":"https://api.github.com/repos/PolymerLabs/arcs/stargazers","contributors_url":"https://api.github.com/repos/PolymerLabs/arcs/contributors","subscribers_url":"https://api.github.com/repos/PolymerLabs/arcs/subscribers","subscription_url":"https://api.github.com/repos/PolymerLabs/arcs/subscription","commits_url":"https://api.github.com/repos/PolymerLabs/arcs/commits{/sha}","git_commits_url":"https://api.github.com/repos/PolymerLabs/arcs/git/commits{/sha}","comments_url":"https://api.github.com/repos/PolymerLabs/arcs/comments{/number}","issue_comment_url":"https://api.github.com/repos/PolymerLabs/arcs/issues/comments{/number}","contents_url":"https://api.github.com/repos/PolymerLabs/arcs/contents/{+path}","compare_url":"https://api.github.com/repos/PolymerLabs/arcs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PolymerLabs/arcs/merges","archive_url":"https://api.github.com/repos/PolymerLabs/arcs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PolymerLabs/arcs/downloads","issues_url":"https://api.github.com/repos/PolymerLabs/arcs/issues{/number}","pulls_url":"https://api.github.com/repos/PolymerLabs/arcs/pulls{/number}","milestones_url":"https://api.github.com/repos/PolymerLabs/arcs/milestones{/number}","notifications_url":"https://api.github.com/repos/PolymerLabs/arcs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PolymerLabs/arcs/labels{/name}","releases_url":"https://api.github.com/repos/PolymerLabs/arcs/releases{/id}","deployments_url":"https://api.github.com/repos/PolymerLabs/arcs/deployments","created_at":"2017-02-03T00:32:19Z","updated_at":"2018-03-13T20:23:25Z","pushed_at":"2018-03-13T22:09:20Z","git_url":"git://github.com/PolymerLabs/arcs.git","ssh_url":"git@github.com:PolymerLabs/arcs.git","clone_url":"https://github.com/PolymerLabs/arcs.git","svn_url":"https://github.com/PolymerLabs/arcs","homepage":null,"size":20958,"stargazers_count":14,"watchers_count":14,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":123,"license":null,"forks":13,"open_issues":123,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PolymerLabs/arcs/pulls/941"},"html":{"href":"https://github.com/PolymerLabs/arcs/pull/941"},"issue":{"href":"https://api.github.com/repos/PolymerLabs/arcs/issues/941"},"comments":{"href":"https://api.github.com/repos/PolymerLabs/arcs/issues/941/comments"},"review_comments":{"href":"https://api.github.com/repos/PolymerLabs/arcs/pulls/941/comments"},"review_comment":{"href":"https://api.github.com/repos/PolymerLabs/arcs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PolymerLabs/arcs/pulls/941/commits"},"statuses":{"href":"https://api.github.com/repos/PolymerLabs/arcs/statuses/3a1bfbab9c3b565bc13baf8df2ee9a21814e85cf"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"sjmiles"}}