{"action":"created","comment":{"url":"https://api.github.com/repos/gooddata/gooddata-ruby/pulls/comments/209235899","pull_request_review_id":145211735,"id":209235899,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTIzNTg5OQ==","diff_hunk":"@@ -1,17 +1,17 @@\n-# encoding: UTF-8\n-#\n # Copyright (c) 2010-2017 GoodData Corporation. All rights reserved.\n # This source code is licensed under the BSD-style license found in the\n # LICENSE file in the root directory of this source tree.\n \n require 'bigdecimal'\n \n-class BigDecimal\n-  def duplicable?\n-    true\n-  end\n+module BigDecimalExtensions\n+  refine BigDecimal do\n+    def duplicable?\n+      true\n+    end\n \n-  def pretty_print(p)\n-    p.text to_s\n+    def pretty_print(p)","path":"lib/gooddata/extensions/big_decimal.rb","position":21,"original_position":21,"commit_id":"94a15bf6feba856fa0967a6ee9f413cdf5743dc0","original_commit_id":"94a15bf6feba856fa0967a6ee9f413cdf5743dc0","user":{"login":"yenkins","id":1506393,"node_id":"MDQ6VXNlcjE1MDYzOTM=","avatar_url":"https://avatars1.githubusercontent.com/u/1506393?v=4","gravatar_id":"","url":"https://api.github.com/users/yenkins","html_url":"https://github.com/yenkins","followers_url":"https://api.github.com/users/yenkins/followers","following_url":"https://api.github.com/users/yenkins/following{/other_user}","gists_url":"https://api.github.com/users/yenkins/gists{/gist_id}","starred_url":"https://api.github.com/users/yenkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yenkins/subscriptions","organizations_url":"https://api.github.com/users/yenkins/orgs","repos_url":"https://api.github.com/users/yenkins/repos","events_url":"https://api.github.com/users/yenkins/events{/privacy}","received_events_url":"https://api.github.com/users/yenkins/received_events","type":"User","site_admin":false},"body":"Has the parameter name 'p' (UncommunicativeParameterName)","created_at":"2018-08-10T12:01:35Z","updated_at":"2018-08-10T12:01:35Z","html_url":"https://github.com/gooddata/gooddata-ruby/pull/1252#discussion_r209235899","pull_request_url":"https://api.github.com/repos/gooddata/gooddata-ruby/pulls/1252","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/gooddata/gooddata-ruby/pulls/comments/209235899"},"html":{"href":"https://github.com/gooddata/gooddata-ruby/pull/1252#discussion_r209235899"},"pull_request":{"href":"https://api.github.com/repos/gooddata/gooddata-ruby/pulls/1252"}}},"pull_request":{"url":"https://api.github.com/repos/gooddata/gooddata-ruby/pulls/1252","id":201370603,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxMzcwNjAz","html_url":"https://github.com/gooddata/gooddata-ruby/pull/1252","diff_url":"https://github.com/gooddata/gooddata-ruby/pull/1252.diff","patch_url":"https://github.com/gooddata/gooddata-ruby/pull/1252.patch","issue_url":"https://api.github.com/repos/gooddata/gooddata-ruby/issues/1252","number":1252,"state":"open","locked":false,"title":"Isolate monkey patches","user":{"login":"henrich-m","id":3842497,"node_id":"MDQ6VXNlcjM4NDI0OTc=","avatar_url":"https://avatars0.githubusercontent.com/u/3842497?v=4","gravatar_id":"","url":"https://api.github.com/users/henrich-m","html_url":"https://github.com/henrich-m","followers_url":"https://api.github.com/users/henrich-m/followers","following_url":"https://api.github.com/users/henrich-m/following{/other_user}","gists_url":"https://api.github.com/users/henrich-m/gists{/gist_id}","starred_url":"https://api.github.com/users/henrich-m/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henrich-m/subscriptions","organizations_url":"https://api.github.com/users/henrich-m/orgs","repos_url":"https://api.github.com/users/henrich-m/repos","events_url":"https://api.github.com/users/henrich-m/events{/privacy}","received_events_url":"https://api.github.com/users/henrich-m/received_events","type":"User","site_admin":false},"body":"Monkey patching is really dangerous, specially if we patch the core classes. \r\nThis PR isolates all monkey patches in modules so it be applied only in the needed context.\r\n","created_at":"2018-07-13T18:45:10Z","updated_at":"2018-08-10T12:01:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a7bcfe555ab8d04a49d2d446258597a8996cd152","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/gooddata/gooddata-ruby/pulls/1252/commits","review_comments_url":"https://api.github.com/repos/gooddata/gooddata-ruby/pulls/1252/comments","review_comment_url":"https://api.github.com/repos/gooddata/gooddata-ruby/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gooddata/gooddata-ruby/issues/1252/comments","statuses_url":"https://api.github.com/repos/gooddata/gooddata-ruby/statuses/94a15bf6feba856fa0967a6ee9f413cdf5743dc0","head":{"label":"henrich-m:isolate-monkey-patches","ref":"isolate-monkey-patches","sha":"94a15bf6feba856fa0967a6ee9f413cdf5743dc0","user":{"login":"henrich-m","id":3842497,"node_id":"MDQ6VXNlcjM4NDI0OTc=","avatar_url":"https://avatars0.githubusercontent.com/u/3842497?v=4","gravatar_id":"","url":"https://api.github.com/users/henrich-m","html_url":"https://github.com/henrich-m","followers_url":"https://api.github.com/users/henrich-m/followers","following_url":"https://api.github.com/users/henrich-m/following{/other_user}","gists_url":"https://api.github.com/users/henrich-m/gists{/gist_id}","starred_url":"https://api.github.com/users/henrich-m/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henrich-m/subscriptions","organizations_url":"https://api.github.com/users/henrich-m/orgs","repos_url":"https://api.github.com/users/henrich-m/repos","events_url":"https://api.github.com/users/henrich-m/events{/privacy}","received_events_url":"https://api.github.com/users/henrich-m/received_events","type":"User","site_admin":false},"repo":{"id":139625621,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk2MjU2MjE=","name":"gooddata-ruby","full_name":"henrich-m/gooddata-ruby","owner":{"login":"henrich-m","id":3842497,"node_id":"MDQ6VXNlcjM4NDI0OTc=","avatar_url":"https://avatars0.githubusercontent.com/u/3842497?v=4","gravatar_id":"","url":"https://api.github.com/users/henrich-m","html_url":"https://github.com/henrich-m","followers_url":"https://api.github.com/users/henrich-m/followers","following_url":"https://api.github.com/users/henrich-m/following{/other_user}","gists_url":"https://api.github.com/users/henrich-m/gists{/gist_id}","starred_url":"https://api.github.com/users/henrich-m/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henrich-m/subscriptions","organizations_url":"https://api.github.com/users/henrich-m/orgs","repos_url":"https://api.github.com/users/henrich-m/repos","events_url":"https://api.github.com/users/henrich-m/events{/privacy}","received_events_url":"https://api.github.com/users/henrich-m/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/henrich-m/gooddata-ruby","description":"GoodData API Ruby Gem","fork":true,"url":"https://api.github.com/repos/henrich-m/gooddata-ruby","forks_url":"https://api.github.com/repos/henrich-m/gooddata-ruby/forks","keys_url":"https://api.github.com/repos/henrich-m/gooddata-ruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/henrich-m/gooddata-ruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/henrich-m/gooddata-ruby/teams","hooks_url":"https://api.github.com/repos/henrich-m/gooddata-ruby/hooks","issue_events_url":"https://api.github.com/repos/henrich-m/gooddata-ruby/issues/events{/number}","events_url":"https://api.github.com/repos/henrich-m/gooddata-ruby/events","assignees_url":"https://api.github.com/repos/henrich-m/gooddata-ruby/assignees{/user}","branches_url":"https://api.github.com/repos/henrich-m/gooddata-ruby/branches{/branch}","tags_url":"https://api.github.com/repos/henrich-m/gooddata-ruby/tags","blobs_url":"https://api.github.com/repos/henrich-m/gooddata-ruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/henrich-m/gooddata-ruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/henrich-m/gooddata-ruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/henrich-m/gooddata-ruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/henrich-m/gooddata-ruby/statuses/{sha}","languages_url":"https://api.github.com/repos/henrich-m/gooddata-ruby/languages","stargazers_url":"https://api.github.com/repos/henrich-m/gooddata-ruby/stargazers","contributors_url":"https://api.github.com/repos/henrich-m/gooddata-ruby/contributors","subscribers_url":"https://api.github.com/repos/henrich-m/gooddata-ruby/subscribers","subscription_url":"https://api.github.com/repos/henrich-m/gooddata-ruby/subscription","commits_url":"https://api.github.com/repos/henrich-m/gooddata-ruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/henrich-m/gooddata-ruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/henrich-m/gooddata-ruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/henrich-m/gooddata-ruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/henrich-m/gooddata-ruby/contents/{+path}","compare_url":"https://api.github.com/repos/henrich-m/gooddata-ruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/henrich-m/gooddata-ruby/merges","archive_url":"https://api.github.com/repos/henrich-m/gooddata-ruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/henrich-m/gooddata-ruby/downloads","issues_url":"https://api.github.com/repos/henrich-m/gooddata-ruby/issues{/number}","pulls_url":"https://api.github.com/repos/henrich-m/gooddata-ruby/pulls{/number}","milestones_url":"https://api.github.com/repos/henrich-m/gooddata-ruby/milestones{/number}","notifications_url":"https://api.github.com/repos/henrich-m/gooddata-ruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/henrich-m/gooddata-ruby/labels{/name}","releases_url":"https://api.github.com/repos/henrich-m/gooddata-ruby/releases{/id}","deployments_url":"https://api.github.com/repos/henrich-m/gooddata-ruby/deployments","created_at":"2018-07-03T18:52:07Z","updated_at":"2018-08-09T19:34:54Z","pushed_at":"2018-08-10T11:59:53Z","git_url":"git://github.com/henrich-m/gooddata-ruby.git","ssh_url":"git@github.com:henrich-m/gooddata-ruby.git","clone_url":"https://github.com/henrich-m/gooddata-ruby.git","svn_url":"https://github.com/henrich-m/gooddata-ruby","homepage":"http://developer.gooddata.com/","size":19091,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gooddata:master","ref":"master","sha":"d59e87da47329199bcf202e20b7c078c03930c9e","user":{"login":"gooddata","id":291394,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5MTM5NA==","avatar_url":"https://avatars2.githubusercontent.com/u/291394?v=4","gravatar_id":"","url":"https://api.github.com/users/gooddata","html_url":"https://github.com/gooddata","followers_url":"https://api.github.com/users/gooddata/followers","following_url":"https://api.github.com/users/gooddata/following{/other_user}","gists_url":"https://api.github.com/users/gooddata/gists{/gist_id}","starred_url":"https://api.github.com/users/gooddata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gooddata/subscriptions","organizations_url":"https://api.github.com/users/gooddata/orgs","repos_url":"https://api.github.com/users/gooddata/repos","events_url":"https://api.github.com/users/gooddata/events{/privacy}","received_events_url":"https://api.github.com/users/gooddata/received_events","type":"Organization","site_admin":false},"repo":{"id":891109,"node_id":"MDEwOlJlcG9zaXRvcnk4OTExMDk=","name":"gooddata-ruby","full_name":"gooddata/gooddata-ruby","owner":{"login":"gooddata","id":291394,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5MTM5NA==","avatar_url":"https://avatars2.githubusercontent.com/u/291394?v=4","gravatar_id":"","url":"https://api.github.com/users/gooddata","html_url":"https://github.com/gooddata","followers_url":"https://api.github.com/users/gooddata/followers","following_url":"https://api.github.com/users/gooddata/following{/other_user}","gists_url":"https://api.github.com/users/gooddata/gists{/gist_id}","starred_url":"https://api.github.com/users/gooddata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gooddata/subscriptions","organizations_url":"https://api.github.com/users/gooddata/orgs","repos_url":"https://api.github.com/users/gooddata/repos","events_url":"https://api.github.com/users/gooddata/events{/privacy}","received_events_url":"https://api.github.com/users/gooddata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gooddata/gooddata-ruby","description":"GoodData API Ruby Gem","fork":false,"url":"https://api.github.com/repos/gooddata/gooddata-ruby","forks_url":"https://api.github.com/repos/gooddata/gooddata-ruby/forks","keys_url":"https://api.github.com/repos/gooddata/gooddata-ruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gooddata/gooddata-ruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gooddata/gooddata-ruby/teams","hooks_url":"https://api.github.com/repos/gooddata/gooddata-ruby/hooks","issue_events_url":"https://api.github.com/repos/gooddata/gooddata-ruby/issues/events{/number}","events_url":"https://api.github.com/repos/gooddata/gooddata-ruby/events","assignees_url":"https://api.github.com/repos/gooddata/gooddata-ruby/assignees{/user}","branches_url":"https://api.github.com/repos/gooddata/gooddata-ruby/branches{/branch}","tags_url":"https://api.github.com/repos/gooddata/gooddata-ruby/tags","blobs_url":"https://api.github.com/repos/gooddata/gooddata-ruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gooddata/gooddata-ruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gooddata/gooddata-ruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/gooddata/gooddata-ruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gooddata/gooddata-ruby/statuses/{sha}","languages_url":"https://api.github.com/repos/gooddata/gooddata-ruby/languages","stargazers_url":"https://api.github.com/repos/gooddata/gooddata-ruby/stargazers","contributors_url":"https://api.github.com/repos/gooddata/gooddata-ruby/contributors","subscribers_url":"https://api.github.com/repos/gooddata/gooddata-ruby/subscribers","subscription_url":"https://api.github.com/repos/gooddata/gooddata-ruby/subscription","commits_url":"https://api.github.com/repos/gooddata/gooddata-ruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/gooddata/gooddata-ruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/gooddata/gooddata-ruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/gooddata/gooddata-ruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/gooddata/gooddata-ruby/contents/{+path}","compare_url":"https://api.github.com/repos/gooddata/gooddata-ruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gooddata/gooddata-ruby/merges","archive_url":"https://api.github.com/repos/gooddata/gooddata-ruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gooddata/gooddata-ruby/downloads","issues_url":"https://api.github.com/repos/gooddata/gooddata-ruby/issues{/number}","pulls_url":"https://api.github.com/repos/gooddata/gooddata-ruby/pulls{/number}","milestones_url":"https://api.github.com/repos/gooddata/gooddata-ruby/milestones{/number}","notifications_url":"https://api.github.com/repos/gooddata/gooddata-ruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gooddata/gooddata-ruby/labels{/name}","releases_url":"https://api.github.com/repos/gooddata/gooddata-ruby/releases{/id}","deployments_url":"https://api.github.com/repos/gooddata/gooddata-ruby/deployments","created_at":"2010-09-06T11:19:17Z","updated_at":"2018-07-31T10:44:53Z","pushed_at":"2018-08-10T11:59:55Z","git_url":"git://github.com/gooddata/gooddata-ruby.git","ssh_url":"git@github.com:gooddata/gooddata-ruby.git","clone_url":"https://github.com/gooddata/gooddata-ruby.git","svn_url":"https://github.com/gooddata/gooddata-ruby","homepage":"http://developer.gooddata.com/","size":18960,"stargazers_count":61,"watchers_count":61,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":92,"mirror_url":null,"archived":false,"open_issues_count":25,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":92,"open_issues":25,"watchers":61,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gooddata/gooddata-ruby/pulls/1252"},"html":{"href":"https://github.com/gooddata/gooddata-ruby/pull/1252"},"issue":{"href":"https://api.github.com/repos/gooddata/gooddata-ruby/issues/1252"},"comments":{"href":"https://api.github.com/repos/gooddata/gooddata-ruby/issues/1252/comments"},"review_comments":{"href":"https://api.github.com/repos/gooddata/gooddata-ruby/pulls/1252/comments"},"review_comment":{"href":"https://api.github.com/repos/gooddata/gooddata-ruby/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gooddata/gooddata-ruby/pulls/1252/commits"},"statuses":{"href":"https://api.github.com/repos/gooddata/gooddata-ruby/statuses/94a15bf6feba856fa0967a6ee9f413cdf5743dc0"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"yenkins"}}