{"action":"created","issue":{"url":"https://api.github.com/repos/Automattic/wp-calypso/issues/27059","repository_url":"https://api.github.com/repos/Automattic/wp-calypso","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/27059/labels{/name}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/27059/comments","events_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/27059/events","html_url":"https://github.com/Automattic/wp-calypso/pull/27059","id":357856888,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzNzcyMDE0","number":27059,"title":"Traffic Settings: add Jetpack Search upgrade message","user":{"login":"gibrown","id":820871,"node_id":"MDQ6VXNlcjgyMDg3MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/820871?v=4","gravatar_id":"","url":"https://api.github.com/users/gibrown","html_url":"https://github.com/gibrown","followers_url":"https://api.github.com/users/gibrown/followers","following_url":"https://api.github.com/users/gibrown/following{/other_user}","gists_url":"https://api.github.com/users/gibrown/gists{/gist_id}","starred_url":"https://api.github.com/users/gibrown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gibrown/subscriptions","organizations_url":"https://api.github.com/users/gibrown/orgs","repos_url":"https://api.github.com/users/gibrown/repos","events_url":"https://api.github.com/users/gibrown/events{/privacy}","received_events_url":"https://api.github.com/users/gibrown/received_events","type":"User","site_admin":false},"labels":[{"id":972310385,"node_id":"MDU6TGFiZWw5NzIzMTAzODU=","url":"https://api.github.com/repos/Automattic/wp-calypso/labels/Marketing","name":"Marketing","color":"a1c8ed","default":false},{"id":285009981,"node_id":"MDU6TGFiZWwyODUwMDk5ODE=","url":"https://api.github.com/repos/Automattic/wp-calypso/labels/Site%20Settings","name":"Site Settings","color":"006b75","default":false},{"id":285010018,"node_id":"MDU6TGFiZWwyODUwMTAwMTg=","url":"https://api.github.com/repos/Automattic/wp-calypso/labels/[Status]%20Needs%20Review","name":"[Status] Needs Review","color":"fbca04","default":false},{"id":285009976,"node_id":"MDU6TGFiZWwyODUwMDk5NzY=","url":"https://api.github.com/repos/Automattic/wp-calypso/labels/[Type]%20Enhancement","name":"[Type] Enhancement","color":"c7def8","default":false}],"state":"open","locked":false,"assignee":{"login":"gibrown","id":820871,"node_id":"MDQ6VXNlcjgyMDg3MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/820871?v=4","gravatar_id":"","url":"https://api.github.com/users/gibrown","html_url":"https://github.com/gibrown","followers_url":"https://api.github.com/users/gibrown/followers","following_url":"https://api.github.com/users/gibrown/following{/other_user}","gists_url":"https://api.github.com/users/gibrown/gists{/gist_id}","starred_url":"https://api.github.com/users/gibrown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gibrown/subscriptions","organizations_url":"https://api.github.com/users/gibrown/orgs","repos_url":"https://api.github.com/users/gibrown/repos","events_url":"https://api.github.com/users/gibrown/events{/privacy}","received_events_url":"https://api.github.com/users/gibrown/received_events","type":"User","site_admin":false},"assignees":[{"login":"gibrown","id":820871,"node_id":"MDQ6VXNlcjgyMDg3MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/820871?v=4","gravatar_id":"","url":"https://api.github.com/users/gibrown","html_url":"https://github.com/gibrown","followers_url":"https://api.github.com/users/gibrown/followers","following_url":"https://api.github.com/users/gibrown/following{/other_user}","gists_url":"https://api.github.com/users/gibrown/gists{/gist_id}","starred_url":"https://api.github.com/users/gibrown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gibrown/subscriptions","organizations_url":"https://api.github.com/users/gibrown/orgs","repos_url":"https://api.github.com/users/gibrown/repos","events_url":"https://api.github.com/users/gibrown/events{/privacy}","received_events_url":"https://api.github.com/users/gibrown/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2018-09-06T22:51:38Z","updated_at":"2018-09-07T19:27:21Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/27059","html_url":"https://github.com/Automattic/wp-calypso/pull/27059","diff_url":"https://github.com/Automattic/wp-calypso/pull/27059.diff","patch_url":"https://github.com/Automattic/wp-calypso/pull/27059.patch"},"body":"This adds an upgrade message in traffic settings where the Jetpack Search settings are displayed once a plan has been purchased.\r\n\r\nThe messaging is based on https://github.com/Automattic/jetpack/issues/9747\r\n\r\nI have also reordered the traffic settings page a bit to adjust which items are on top. Some thoughts behind this:\r\n- Put the things the user is more likely to toggle higher up - things that are not on by default for instance\r\n- Put stuff like disabling stats at the bottom since very few folks disable stats\r\n\r\nOne question I have here is that I am seeing \"Warning: Failed prop type: Invalid prop `description` supplied to `Banner`.\" in my console (Chrome). I suspect this has to do with the gnarly html description I have used. Some way around this?\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/Automattic/wp-calypso/issues/comments/419541674","html_url":"https://github.com/Automattic/wp-calypso/pull/27059#issuecomment-419541674","issue_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/27059","id":419541674,"node_id":"MDEyOklzc3VlQ29tbWVudDQxOTU0MTY3NA==","user":{"login":"ebinnion","id":1126811,"node_id":"MDQ6VXNlcjExMjY4MTE=","avatar_url":"https://avatars2.githubusercontent.com/u/1126811?v=4","gravatar_id":"","url":"https://api.github.com/users/ebinnion","html_url":"https://github.com/ebinnion","followers_url":"https://api.github.com/users/ebinnion/followers","following_url":"https://api.github.com/users/ebinnion/following{/other_user}","gists_url":"https://api.github.com/users/ebinnion/gists{/gist_id}","starred_url":"https://api.github.com/users/ebinnion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebinnion/subscriptions","organizations_url":"https://api.github.com/users/ebinnion/orgs","repos_url":"https://api.github.com/users/ebinnion/repos","events_url":"https://api.github.com/users/ebinnion/events{/privacy}","received_events_url":"https://api.github.com/users/ebinnion/received_events","type":"User","site_admin":false},"created_at":"2018-09-07T19:27:21Z","updated_at":"2018-09-07T19:27:21Z","author_association":"CONTRIBUTOR","body":"I pushed a commit to address the prop warning. Besides that, the code looks OK to me. We should probably get a design review for the content in the banner since it seems like more than usual."}}
{"actor":{"display_login":"ebinnion"}}