{"action":"created","comment":{"url":"https://api.github.com/repos/JuliaIntervals/IntervalRootFinding.jl/pulls/comments/181537020","pull_request_review_id":112191798,"id":181537020,"diff_hunk":"@@ -221,9 +181,45 @@ Inputs:\n - `X`: `Interval` or `IntervalBox`\n - `contractor`: function that, when applied to the function `f`, determines\n     the status of a given box `X`. It returns the new box and a symbol indicating\n-    the status. Current possible values are `Bisection` and `Newton`.\n+    the status. Current possible values are `Bisection`, `Newton` and\n+    `Newton(f_prime)` where `f_prime` is the derivative or jacobian of `f`.\n \n \"\"\"\n-roots{C<:Contractor}(f, X, contractor::Type{C}, tol::Float64=1e-3) = branch_and_prune(f, X, contractor, tol)\n+function roots{T, C<:Contractor}(f, X::IntervalLike{T}, contractor::Type{C}, tol::Float64=1e-3)\n+    dim = length(X)","path":"src/branch_and_prune.jl","position":261,"original_position":261,"commit_id":"4964a4c0c836cc5fe8bc3291f7639248b987c7ff","original_commit_id":"4964a4c0c836cc5fe8bc3291f7639248b987c7ff","user":{"login":"dpsanders","id":191822,"avatar_url":"https://avatars0.githubusercontent.com/u/191822?v=4","gravatar_id":"","url":"https://api.github.com/users/dpsanders","html_url":"https://github.com/dpsanders","followers_url":"https://api.github.com/users/dpsanders/followers","following_url":"https://api.github.com/users/dpsanders/following{/other_user}","gists_url":"https://api.github.com/users/dpsanders/gists{/gist_id}","starred_url":"https://api.github.com/users/dpsanders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpsanders/subscriptions","organizations_url":"https://api.github.com/users/dpsanders/orgs","repos_url":"https://api.github.com/users/dpsanders/repos","events_url":"https://api.github.com/users/dpsanders/events{/privacy}","received_events_url":"https://api.github.com/users/dpsanders/received_events","type":"User","site_admin":false},"body":"(Please use the future-proof `where` syntax.)","created_at":"2018-04-14T01:25:45Z","updated_at":"2018-04-14T01:31:47Z","html_url":"https://github.com/JuliaIntervals/IntervalRootFinding.jl/pull/51#discussion_r181537020","pull_request_url":"https://api.github.com/repos/JuliaIntervals/IntervalRootFinding.jl/pulls/51","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/JuliaIntervals/IntervalRootFinding.jl/pulls/comments/181537020"},"html":{"href":"https://github.com/JuliaIntervals/IntervalRootFinding.jl/pull/51#discussion_r181537020"},"pull_request":{"href":"https://api.github.com/repos/JuliaIntervals/IntervalRootFinding.jl/pulls/51"}},"in_reply_to_id":181537011},"pull_request":{"url":"https://api.github.com/repos/JuliaIntervals/IntervalRootFinding.jl/pulls/51","id":181069153,"html_url":"https://github.com/JuliaIntervals/IntervalRootFinding.jl/pull/51","diff_url":"https://github.com/JuliaIntervals/IntervalRootFinding.jl/pull/51.diff","patch_url":"https://github.com/JuliaIntervals/IntervalRootFinding.jl/pull/51.patch","issue_url":"https://api.github.com/repos/JuliaIntervals/IntervalRootFinding.jl/issues/51","number":51,"state":"open","locked":false,"title":"Explicitely give derivative to Newton contractor.","user":{"login":"Kolaru","id":17861033,"avatar_url":"https://avatars2.githubusercontent.com/u/17861033?v=4","gravatar_id":"","url":"https://api.github.com/users/Kolaru","html_url":"https://github.com/Kolaru","followers_url":"https://api.github.com/users/Kolaru/followers","following_url":"https://api.github.com/users/Kolaru/following{/other_user}","gists_url":"https://api.github.com/users/Kolaru/gists{/gist_id}","starred_url":"https://api.github.com/users/Kolaru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kolaru/subscriptions","organizations_url":"https://api.github.com/users/Kolaru/orgs","repos_url":"https://api.github.com/users/Kolaru/repos","events_url":"https://api.github.com/users/Kolaru/events{/privacy}","received_events_url":"https://api.github.com/users/Kolaru/received_events","type":"User","site_admin":false},"body":"Fixes #45 \r\n\r\nThe tests mainly consist of comparing the default `Newton` method which uses `ForwardDiff` and passing the derivative/jacobian generated by `ForwardDiff` with the new syntax\r\n\r\n    roots(f, X, Newton(f_prime))","created_at":"2018-04-12T01:36:42Z","updated_at":"2018-04-14T01:31:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2ee7a63697b82ef1b9b42e7e8c1a591bd4073917","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/JuliaIntervals/IntervalRootFinding.jl/pulls/51/commits","review_comments_url":"https://api.github.com/repos/JuliaIntervals/IntervalRootFinding.jl/pulls/51/comments","review_comment_url":"https://api.github.com/repos/JuliaIntervals/IntervalRootFinding.jl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuliaIntervals/IntervalRootFinding.jl/issues/51/comments","statuses_url":"https://api.github.com/repos/JuliaIntervals/IntervalRootFinding.jl/statuses/4964a4c0c836cc5fe8bc3291f7639248b987c7ff","head":{"label":"Kolaru:pull-request/6e2ef6fb","ref":"pull-request/6e2ef6fb","sha":"4964a4c0c836cc5fe8bc3291f7639248b987c7ff","user":{"login":"Kolaru","id":17861033,"avatar_url":"https://avatars2.githubusercontent.com/u/17861033?v=4","gravatar_id":"","url":"https://api.github.com/users/Kolaru","html_url":"https://github.com/Kolaru","followers_url":"https://api.github.com/users/Kolaru/followers","following_url":"https://api.github.com/users/Kolaru/following{/other_user}","gists_url":"https://api.github.com/users/Kolaru/gists{/gist_id}","starred_url":"https://api.github.com/users/Kolaru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kolaru/subscriptions","organizations_url":"https://api.github.com/users/Kolaru/orgs","repos_url":"https://api.github.com/users/Kolaru/repos","events_url":"https://api.github.com/users/Kolaru/events{/privacy}","received_events_url":"https://api.github.com/users/Kolaru/received_events","type":"User","site_admin":false},"repo":{"id":129175367,"name":"IntervalRootFinding.jl","full_name":"Kolaru/IntervalRootFinding.jl","owner":{"login":"Kolaru","id":17861033,"avatar_url":"https://avatars2.githubusercontent.com/u/17861033?v=4","gravatar_id":"","url":"https://api.github.com/users/Kolaru","html_url":"https://github.com/Kolaru","followers_url":"https://api.github.com/users/Kolaru/followers","following_url":"https://api.github.com/users/Kolaru/following{/other_user}","gists_url":"https://api.github.com/users/Kolaru/gists{/gist_id}","starred_url":"https://api.github.com/users/Kolaru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kolaru/subscriptions","organizations_url":"https://api.github.com/users/Kolaru/orgs","repos_url":"https://api.github.com/users/Kolaru/repos","events_url":"https://api.github.com/users/Kolaru/events{/privacy}","received_events_url":"https://api.github.com/users/Kolaru/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Kolaru/IntervalRootFinding.jl","description":"Find all roots of a function in a guaranteed way with Julia","fork":true,"url":"https://api.github.com/repos/Kolaru/IntervalRootFinding.jl","forks_url":"https://api.github.com/repos/Kolaru/IntervalRootFinding.jl/forks","keys_url":"https://api.github.com/repos/Kolaru/IntervalRootFinding.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Kolaru/IntervalRootFinding.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Kolaru/IntervalRootFinding.jl/teams","hooks_url":"https://api.github.com/repos/Kolaru/IntervalRootFinding.jl/hooks","issue_events_url":"https://api.github.com/repos/Kolaru/IntervalRootFinding.jl/issues/events{/number}","events_url":"https://api.github.com/repos/Kolaru/IntervalRootFinding.jl/events","assignees_url":"https://api.github.com/repos/Kolaru/IntervalRootFinding.jl/assignees{/user}","branches_url":"https://api.github.com/repos/Kolaru/IntervalRootFinding.jl/branches{/branch}","tags_url":"https://api.github.com/repos/Kolaru/IntervalRootFinding.jl/tags","blobs_url":"https://api.github.com/repos/Kolaru/IntervalRootFinding.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Kolaru/IntervalRootFinding.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Kolaru/IntervalRootFinding.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/Kolaru/IntervalRootFinding.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Kolaru/IntervalRootFinding.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/Kolaru/IntervalRootFinding.jl/languages","stargazers_url":"https://api.github.com/repos/Kolaru/IntervalRootFinding.jl/stargazers","contributors_url":"https://api.github.com/repos/Kolaru/IntervalRootFinding.jl/contributors","subscribers_url":"https://api.github.com/repos/Kolaru/IntervalRootFinding.jl/subscribers","subscription_url":"https://api.github.com/repos/Kolaru/IntervalRootFinding.jl/subscription","commits_url":"https://api.github.com/repos/Kolaru/IntervalRootFinding.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/Kolaru/IntervalRootFinding.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/Kolaru/IntervalRootFinding.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/Kolaru/IntervalRootFinding.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/Kolaru/IntervalRootFinding.jl/contents/{+path}","compare_url":"https://api.github.com/repos/Kolaru/IntervalRootFinding.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Kolaru/IntervalRootFinding.jl/merges","archive_url":"https://api.github.com/repos/Kolaru/IntervalRootFinding.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Kolaru/IntervalRootFinding.jl/downloads","issues_url":"https://api.github.com/repos/Kolaru/IntervalRootFinding.jl/issues{/number}","pulls_url":"https://api.github.com/repos/Kolaru/IntervalRootFinding.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/Kolaru/IntervalRootFinding.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/Kolaru/IntervalRootFinding.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Kolaru/IntervalRootFinding.jl/labels{/name}","releases_url":"https://api.github.com/repos/Kolaru/IntervalRootFinding.jl/releases{/id}","deployments_url":"https://api.github.com/repos/Kolaru/IntervalRootFinding.jl/deployments","created_at":"2018-04-12T01:31:27Z","updated_at":"2018-04-12T01:31:29Z","pushed_at":"2018-04-13T23:33:34Z","git_url":"git://github.com/Kolaru/IntervalRootFinding.jl.git","ssh_url":"git@github.com:Kolaru/IntervalRootFinding.jl.git","clone_url":"https://github.com/Kolaru/IntervalRootFinding.jl.git","svn_url":"https://github.com/Kolaru/IntervalRootFinding.jl","homepage":"","size":695,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JuliaIntervals:master","ref":"master","sha":"e235900cc4624c63cc4ba6e7071f460d4607dc8d","user":{"login":"JuliaIntervals","id":26843058,"avatar_url":"https://avatars1.githubusercontent.com/u/26843058?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaIntervals","html_url":"https://github.com/JuliaIntervals","followers_url":"https://api.github.com/users/JuliaIntervals/followers","following_url":"https://api.github.com/users/JuliaIntervals/following{/other_user}","gists_url":"https://api.github.com/users/JuliaIntervals/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaIntervals/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaIntervals/subscriptions","organizations_url":"https://api.github.com/users/JuliaIntervals/orgs","repos_url":"https://api.github.com/users/JuliaIntervals/repos","events_url":"https://api.github.com/users/JuliaIntervals/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaIntervals/received_events","type":"Organization","site_admin":false},"repo":{"id":87006091,"name":"IntervalRootFinding.jl","full_name":"JuliaIntervals/IntervalRootFinding.jl","owner":{"login":"JuliaIntervals","id":26843058,"avatar_url":"https://avatars1.githubusercontent.com/u/26843058?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaIntervals","html_url":"https://github.com/JuliaIntervals","followers_url":"https://api.github.com/users/JuliaIntervals/followers","following_url":"https://api.github.com/users/JuliaIntervals/following{/other_user}","gists_url":"https://api.github.com/users/JuliaIntervals/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaIntervals/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaIntervals/subscriptions","organizations_url":"https://api.github.com/users/JuliaIntervals/orgs","repos_url":"https://api.github.com/users/JuliaIntervals/repos","events_url":"https://api.github.com/users/JuliaIntervals/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaIntervals/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaIntervals/IntervalRootFinding.jl","description":"Find all roots of a function in a guaranteed way with Julia","fork":false,"url":"https://api.github.com/repos/JuliaIntervals/IntervalRootFinding.jl","forks_url":"https://api.github.com/repos/JuliaIntervals/IntervalRootFinding.jl/forks","keys_url":"https://api.github.com/repos/JuliaIntervals/IntervalRootFinding.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaIntervals/IntervalRootFinding.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaIntervals/IntervalRootFinding.jl/teams","hooks_url":"https://api.github.com/repos/JuliaIntervals/IntervalRootFinding.jl/hooks","issue_events_url":"https://api.github.com/repos/JuliaIntervals/IntervalRootFinding.jl/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaIntervals/IntervalRootFinding.jl/events","assignees_url":"https://api.github.com/repos/JuliaIntervals/IntervalRootFinding.jl/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaIntervals/IntervalRootFinding.jl/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaIntervals/IntervalRootFinding.jl/tags","blobs_url":"https://api.github.com/repos/JuliaIntervals/IntervalRootFinding.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaIntervals/IntervalRootFinding.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaIntervals/IntervalRootFinding.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaIntervals/IntervalRootFinding.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaIntervals/IntervalRootFinding.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaIntervals/IntervalRootFinding.jl/languages","stargazers_url":"https://api.github.com/repos/JuliaIntervals/IntervalRootFinding.jl/stargazers","contributors_url":"https://api.github.com/repos/JuliaIntervals/IntervalRootFinding.jl/contributors","subscribers_url":"https://api.github.com/repos/JuliaIntervals/IntervalRootFinding.jl/subscribers","subscription_url":"https://api.github.com/repos/JuliaIntervals/IntervalRootFinding.jl/subscription","commits_url":"https://api.github.com/repos/JuliaIntervals/IntervalRootFinding.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaIntervals/IntervalRootFinding.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaIntervals/IntervalRootFinding.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaIntervals/IntervalRootFinding.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaIntervals/IntervalRootFinding.jl/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaIntervals/IntervalRootFinding.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaIntervals/IntervalRootFinding.jl/merges","archive_url":"https://api.github.com/repos/JuliaIntervals/IntervalRootFinding.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaIntervals/IntervalRootFinding.jl/downloads","issues_url":"https://api.github.com/repos/JuliaIntervals/IntervalRootFinding.jl/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaIntervals/IntervalRootFinding.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaIntervals/IntervalRootFinding.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaIntervals/IntervalRootFinding.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaIntervals/IntervalRootFinding.jl/labels{/name}","releases_url":"https://api.github.com/repos/JuliaIntervals/IntervalRootFinding.jl/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaIntervals/IntervalRootFinding.jl/deployments","created_at":"2017-04-02T18:19:31Z","updated_at":"2018-04-12T22:04:07Z","pushed_at":"2018-04-13T23:33:35Z","git_url":"git://github.com/JuliaIntervals/IntervalRootFinding.jl.git","ssh_url":"git@github.com:JuliaIntervals/IntervalRootFinding.jl.git","clone_url":"https://github.com/JuliaIntervals/IntervalRootFinding.jl.git","svn_url":"https://github.com/JuliaIntervals/IntervalRootFinding.jl","homepage":"","size":687,"stargazers_count":15,"watchers_count":15,"language":"Julia","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":24,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":6,"open_issues":24,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaIntervals/IntervalRootFinding.jl/pulls/51"},"html":{"href":"https://github.com/JuliaIntervals/IntervalRootFinding.jl/pull/51"},"issue":{"href":"https://api.github.com/repos/JuliaIntervals/IntervalRootFinding.jl/issues/51"},"comments":{"href":"https://api.github.com/repos/JuliaIntervals/IntervalRootFinding.jl/issues/51/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaIntervals/IntervalRootFinding.jl/pulls/51/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaIntervals/IntervalRootFinding.jl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuliaIntervals/IntervalRootFinding.jl/pulls/51/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaIntervals/IntervalRootFinding.jl/statuses/4964a4c0c836cc5fe8bc3291f7639248b987c7ff"}},"author_association":"NONE"}}
{"actor":{"display_login":"dpsanders"}}