{"action":"created","comment":{"url":"https://api.github.com/repos/apache/trafodion/pulls/comments/202778388","pull_request_review_id":137540626,"id":202778388,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjc3ODM4OA==","diff_hunk":"@@ -10991,7 +10997,20 @@ CmpSeabaseDDL::setupHbaseOptions(ElemDDLHbaseOptions * hbaseOptionsClause,\n           hbaseOptionsStr += optionStr;\n         }\n     }\n+  if (!flushSize.isNull() && !memstoreFlushSizeOptionSpecified)\n+    {\n+      hbaseOption = new(STMTHEAP) HbaseCreateOption(\"MEMSTORE_FLUSH_SIZE\", \n+                                                    flushSize.data());\n+      hbaseCreateOptions.insert(hbaseOption);\n \n+      if (ActiveSchemaDB()->getDefaults().userDefault\n+          (HBASE_MEMSTORE_FLUSH_SIZE_OPTION) == TRUE)\n+        {\n+          numHbaseOptions += 1;\n+          sprintf(optionStr, \"MEMSTORE_FLUSH_SIZE='%s'|\", flushSize.data());","path":"core/sql/sqlcomp/CmpSeabaseDDLcommon.cpp","position":43,"original_position":43,"commit_id":"86fdb25c09785da8d17b05e38e4f802af97932e9","original_commit_id":"86fdb25c09785da8d17b05e38e4f802af97932e9","user":{"login":"zellerh","id":7062636,"node_id":"MDQ6VXNlcjcwNjI2MzY=","avatar_url":"https://avatars3.githubusercontent.com/u/7062636?v=4","gravatar_id":"","url":"https://api.github.com/users/zellerh","html_url":"https://github.com/zellerh","followers_url":"https://api.github.com/users/zellerh/followers","following_url":"https://api.github.com/users/zellerh/following{/other_user}","gists_url":"https://api.github.com/users/zellerh/gists{/gist_id}","starred_url":"https://api.github.com/users/zellerh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zellerh/subscriptions","organizations_url":"https://api.github.com/users/zellerh/orgs","repos_url":"https://api.github.com/users/zellerh/repos","events_url":"https://api.github.com/users/zellerh/events{/privacy}","received_events_url":"https://api.github.com/users/zellerh/received_events","type":"User","site_admin":false},"body":"I would recommend using snprintf instead of sprintf, to avoid the possibility of a buffer overrun (probably not likely here, but just in case).\r\n\r\n```\r\nsnprintf(optionStr, sizeof(optionStr), ...)\r\n```","created_at":"2018-07-16T18:27:00Z","updated_at":"2018-07-16T18:29:41Z","html_url":"https://github.com/apache/trafodion/pull/1646#discussion_r202778388","pull_request_url":"https://api.github.com/repos/apache/trafodion/pulls/1646","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/trafodion/pulls/comments/202778388"},"html":{"href":"https://github.com/apache/trafodion/pull/1646#discussion_r202778388"},"pull_request":{"href":"https://api.github.com/repos/apache/trafodion/pulls/1646"}}},"pull_request":{"url":"https://api.github.com/repos/apache/trafodion/pulls/1646","id":201526662,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxNTI2NjYy","html_url":"https://github.com/apache/trafodion/pull/1646","diff_url":"https://github.com/apache/trafodion/pull/1646.diff","patch_url":"https://github.com/apache/trafodion/pull/1646.patch","issue_url":"https://api.github.com/repos/apache/trafodion/issues/1646","number":1646,"state":"open","locked":false,"title":"[TRAFODION-3145] Make \"hbase_options\" as default setting and use cqd …","user":{"login":"traflm","id":12948514,"node_id":"MDQ6VXNlcjEyOTQ4NTE0","avatar_url":"https://avatars3.githubusercontent.com/u/12948514?v=4","gravatar_id":"","url":"https://api.github.com/users/traflm","html_url":"https://github.com/traflm","followers_url":"https://api.github.com/users/traflm/followers","following_url":"https://api.github.com/users/traflm/following{/other_user}","gists_url":"https://api.github.com/users/traflm/gists{/gist_id}","starred_url":"https://api.github.com/users/traflm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/traflm/subscriptions","organizations_url":"https://api.github.com/users/traflm/orgs","repos_url":"https://api.github.com/users/traflm/repos","events_url":"https://api.github.com/users/traflm/events{/privacy}","received_events_url":"https://api.github.com/users/traflm/received_events","type":"User","site_admin":false},"body":"…to change the default setting\r\n\r\nAs we know, for performance thinking, we always need to add below syntax in “create table” syntax. And I know in latest version, we have made “ATTRIBUTES ALIGNED FORMAT” as default, do we have a plan that make HBASE_OPTIONS(including ENCODING、COMPRESSION、MEMESTORE) as the default setting when creating table? I think this will be easier for end users?\r\nATTRIBUTES ALIGNED FORMAT\r\nHBASE_OPTIONS\r\n(\r\nDATA_BLOCK_ENCODING = 'FAST_DIFF',\r\nCOMPRESSION = 'SNAPPY',\r\nMEMSTORE_FLUSH_SIZE = '1073741824'\r\n)\r\n;\r\n\r\nTrafodion has\r\ncqd HBASE_DATA_BLOCK_ENCODING_OPTION ‘FAST_DIFF’;\r\ncqd HBASE_COMPRESSION_OPTION ‘SNAPPY’;\r\n\r\nAdd \r\ncqd HBASE_MEMSTORE_FLUSH_SIZE_OPTION '1073741824' ;\r\n\r\nSo one can use these values without explicitly specify them when create table.\r\n","created_at":"2018-07-16T01:36:56Z","updated_at":"2018-07-16T18:29:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bb4168b756d8c31c3ed9ff74db56bb71d6c02274","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/trafodion/pulls/1646/commits","review_comments_url":"https://api.github.com/repos/apache/trafodion/pulls/1646/comments","review_comment_url":"https://api.github.com/repos/apache/trafodion/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/trafodion/issues/1646/comments","statuses_url":"https://api.github.com/repos/apache/trafodion/statuses/86fdb25c09785da8d17b05e38e4f802af97932e9","head":{"label":"traflm:TRAFODION-3145","ref":"TRAFODION-3145","sha":"86fdb25c09785da8d17b05e38e4f802af97932e9","user":{"login":"traflm","id":12948514,"node_id":"MDQ6VXNlcjEyOTQ4NTE0","avatar_url":"https://avatars3.githubusercontent.com/u/12948514?v=4","gravatar_id":"","url":"https://api.github.com/users/traflm","html_url":"https://github.com/traflm","followers_url":"https://api.github.com/users/traflm/followers","following_url":"https://api.github.com/users/traflm/following{/other_user}","gists_url":"https://api.github.com/users/traflm/gists{/gist_id}","starred_url":"https://api.github.com/users/traflm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/traflm/subscriptions","organizations_url":"https://api.github.com/users/traflm/orgs","repos_url":"https://api.github.com/users/traflm/repos","events_url":"https://api.github.com/users/traflm/events{/privacy}","received_events_url":"https://api.github.com/users/traflm/received_events","type":"User","site_admin":false},"repo":{"id":38096376,"node_id":"MDEwOlJlcG9zaXRvcnkzODA5NjM3Ng==","name":"trafodion","full_name":"traflm/trafodion","owner":{"login":"traflm","id":12948514,"node_id":"MDQ6VXNlcjEyOTQ4NTE0","avatar_url":"https://avatars3.githubusercontent.com/u/12948514?v=4","gravatar_id":"","url":"https://api.github.com/users/traflm","html_url":"https://github.com/traflm","followers_url":"https://api.github.com/users/traflm/followers","following_url":"https://api.github.com/users/traflm/following{/other_user}","gists_url":"https://api.github.com/users/traflm/gists{/gist_id}","starred_url":"https://api.github.com/users/traflm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/traflm/subscriptions","organizations_url":"https://api.github.com/users/traflm/orgs","repos_url":"https://api.github.com/users/traflm/repos","events_url":"https://api.github.com/users/traflm/events{/privacy}","received_events_url":"https://api.github.com/users/traflm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/traflm/trafodion","description":"Mirror of Apache Trafodion (Incubating)","fork":true,"url":"https://api.github.com/repos/traflm/trafodion","forks_url":"https://api.github.com/repos/traflm/trafodion/forks","keys_url":"https://api.github.com/repos/traflm/trafodion/keys{/key_id}","collaborators_url":"https://api.github.com/repos/traflm/trafodion/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/traflm/trafodion/teams","hooks_url":"https://api.github.com/repos/traflm/trafodion/hooks","issue_events_url":"https://api.github.com/repos/traflm/trafodion/issues/events{/number}","events_url":"https://api.github.com/repos/traflm/trafodion/events","assignees_url":"https://api.github.com/repos/traflm/trafodion/assignees{/user}","branches_url":"https://api.github.com/repos/traflm/trafodion/branches{/branch}","tags_url":"https://api.github.com/repos/traflm/trafodion/tags","blobs_url":"https://api.github.com/repos/traflm/trafodion/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/traflm/trafodion/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/traflm/trafodion/git/refs{/sha}","trees_url":"https://api.github.com/repos/traflm/trafodion/git/trees{/sha}","statuses_url":"https://api.github.com/repos/traflm/trafodion/statuses/{sha}","languages_url":"https://api.github.com/repos/traflm/trafodion/languages","stargazers_url":"https://api.github.com/repos/traflm/trafodion/stargazers","contributors_url":"https://api.github.com/repos/traflm/trafodion/contributors","subscribers_url":"https://api.github.com/repos/traflm/trafodion/subscribers","subscription_url":"https://api.github.com/repos/traflm/trafodion/subscription","commits_url":"https://api.github.com/repos/traflm/trafodion/commits{/sha}","git_commits_url":"https://api.github.com/repos/traflm/trafodion/git/commits{/sha}","comments_url":"https://api.github.com/repos/traflm/trafodion/comments{/number}","issue_comment_url":"https://api.github.com/repos/traflm/trafodion/issues/comments{/number}","contents_url":"https://api.github.com/repos/traflm/trafodion/contents/{+path}","compare_url":"https://api.github.com/repos/traflm/trafodion/compare/{base}...{head}","merges_url":"https://api.github.com/repos/traflm/trafodion/merges","archive_url":"https://api.github.com/repos/traflm/trafodion/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/traflm/trafodion/downloads","issues_url":"https://api.github.com/repos/traflm/trafodion/issues{/number}","pulls_url":"https://api.github.com/repos/traflm/trafodion/pulls{/number}","milestones_url":"https://api.github.com/repos/traflm/trafodion/milestones{/number}","notifications_url":"https://api.github.com/repos/traflm/trafodion/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/traflm/trafodion/labels{/name}","releases_url":"https://api.github.com/repos/traflm/trafodion/releases{/id}","deployments_url":"https://api.github.com/repos/traflm/trafodion/deployments","created_at":"2015-06-26T07:07:16Z","updated_at":"2018-01-11T02:45:06Z","pushed_at":"2018-07-16T10:29:16Z","git_url":"git://github.com/traflm/trafodion.git","ssh_url":"git@github.com:traflm/trafodion.git","clone_url":"https://github.com/traflm/trafodion.git","svn_url":"https://github.com/traflm/trafodion","homepage":null,"size":88521,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"ab6805dfb4ef1c763b0ad0256ed7316f70f9f7b3","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":36349344,"node_id":"MDEwOlJlcG9zaXRvcnkzNjM0OTM0NA==","name":"trafodion","full_name":"apache/trafodion","owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/trafodion","description":"Apache Trafodion","fork":false,"url":"https://api.github.com/repos/apache/trafodion","forks_url":"https://api.github.com/repos/apache/trafodion/forks","keys_url":"https://api.github.com/repos/apache/trafodion/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/trafodion/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/trafodion/teams","hooks_url":"https://api.github.com/repos/apache/trafodion/hooks","issue_events_url":"https://api.github.com/repos/apache/trafodion/issues/events{/number}","events_url":"https://api.github.com/repos/apache/trafodion/events","assignees_url":"https://api.github.com/repos/apache/trafodion/assignees{/user}","branches_url":"https://api.github.com/repos/apache/trafodion/branches{/branch}","tags_url":"https://api.github.com/repos/apache/trafodion/tags","blobs_url":"https://api.github.com/repos/apache/trafodion/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/trafodion/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/trafodion/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/trafodion/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/trafodion/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/trafodion/languages","stargazers_url":"https://api.github.com/repos/apache/trafodion/stargazers","contributors_url":"https://api.github.com/repos/apache/trafodion/contributors","subscribers_url":"https://api.github.com/repos/apache/trafodion/subscribers","subscription_url":"https://api.github.com/repos/apache/trafodion/subscription","commits_url":"https://api.github.com/repos/apache/trafodion/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/trafodion/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/trafodion/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/trafodion/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/trafodion/contents/{+path}","compare_url":"https://api.github.com/repos/apache/trafodion/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/trafodion/merges","archive_url":"https://api.github.com/repos/apache/trafodion/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/trafodion/downloads","issues_url":"https://api.github.com/repos/apache/trafodion/issues{/number}","pulls_url":"https://api.github.com/repos/apache/trafodion/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/trafodion/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/trafodion/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/trafodion/labels{/name}","releases_url":"https://api.github.com/repos/apache/trafodion/releases{/id}","deployments_url":"https://api.github.com/repos/apache/trafodion/deployments","created_at":"2015-05-27T07:00:05Z","updated_at":"2018-07-16T15:31:17Z","pushed_at":"2018-07-16T15:31:10Z","git_url":"git://github.com/apache/trafodion.git","ssh_url":"git@github.com:apache/trafodion.git","clone_url":"https://github.com/apache/trafodion.git","svn_url":"https://github.com/apache/trafodion","homepage":"","size":89477,"stargazers_count":166,"watchers_count":166,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":121,"mirror_url":null,"archived":false,"open_issues_count":27,"license":null,"forks":121,"open_issues":27,"watchers":166,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/trafodion/pulls/1646"},"html":{"href":"https://github.com/apache/trafodion/pull/1646"},"issue":{"href":"https://api.github.com/repos/apache/trafodion/issues/1646"},"comments":{"href":"https://api.github.com/repos/apache/trafodion/issues/1646/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/trafodion/pulls/1646/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/trafodion/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/trafodion/pulls/1646/commits"},"statuses":{"href":"https://api.github.com/repos/apache/trafodion/statuses/86fdb25c09785da8d17b05e38e4f802af97932e9"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"zellerh"}}