{"action":"created","issue":{"url":"https://api.github.com/repos/jupyterhub/binderhub/issues/459","repository_url":"https://api.github.com/repos/jupyterhub/binderhub","labels_url":"https://api.github.com/repos/jupyterhub/binderhub/issues/459/labels{/name}","comments_url":"https://api.github.com/repos/jupyterhub/binderhub/issues/459/comments","events_url":"https://api.github.com/repos/jupyterhub/binderhub/issues/459/events","html_url":"https://github.com/jupyterhub/binderhub/pull/459","id":298276653,"number":459,"title":"support repo2docker appendix","user":{"login":"minrk","id":151929,"avatar_url":"https://avatars1.githubusercontent.com/u/151929?v=4","gravatar_id":"","url":"https://api.github.com/users/minrk","html_url":"https://github.com/minrk","followers_url":"https://api.github.com/users/minrk/followers","following_url":"https://api.github.com/users/minrk/following{/other_user}","gists_url":"https://api.github.com/users/minrk/gists{/gist_id}","starred_url":"https://api.github.com/users/minrk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minrk/subscriptions","organizations_url":"https://api.github.com/users/minrk/orgs","repos_url":"https://api.github.com/users/minrk/repos","events_url":"https://api.github.com/users/minrk/events{/privacy}","received_events_url":"https://api.github.com/users/minrk/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-02-19T13:33:47Z","updated_at":"2018-03-06T22:41:48Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/jupyterhub/binderhub/pulls/459","html_url":"https://github.com/jupyterhub/binderhub/pull/459","diff_url":"https://github.com/jupyterhub/binderhub/pull/459.diff","patch_url":"https://github.com/jupyterhub/binderhub/pull/459.patch"},"body":"Raw repo2docker appendix can be set via `c.BinderHub.appendix`.\n\nA default appendix ships in the binderhub repo in the `appendix` directory. `Setting BinderHub.binderhub_appendix_url` to a git archive URL,\ne.g. `https://github.com/minrk/binderhub/archive/appendix.tar.gz`, will run the default appendix from the binderhub repo, which does:\n\n\n- download binderhub_appendix_url archive\n- untar `/appendix` subdirectory\n- execute `/appendix/run-appendix`\n\nIn the appendix added here, that results in some extra config that sets a custom `login` page, which is the page you are shown when you don't have access to a Binder (e.g. someone shared a link to a running pod, as in #458). The custom login page eliminates any token/password form, replacing it with a message and link to a new Binder for the current repo. It could also redirect to that link automatically, or do so after some delay, giving people a chance to read the message.\n\nHappy to have some help defining what should be communicated on that page. It's pretty sparse right now.\n\ncloses #458 for the case where the pod is still running, but not the case where the pod has stopped, in which case JupyterHub serves a 403 page and doesn't have enough info to reconstruct the original URL.\n\nTODO:\n\n- [x] decide if the appendix belongs in this repo, standalone, or in a deployment-specific repo, like mybinder.org-deploy\n- [x] add appendix support and defaults to helm charts"},"comment":{"url":"https://api.github.com/repos/jupyterhub/binderhub/issues/comments/370955564","html_url":"https://github.com/jupyterhub/binderhub/pull/459#issuecomment-370955564","issue_url":"https://api.github.com/repos/jupyterhub/binderhub/issues/459","id":370955564,"user":{"login":"betatim","id":1448859,"avatar_url":"https://avatars1.githubusercontent.com/u/1448859?v=4","gravatar_id":"","url":"https://api.github.com/users/betatim","html_url":"https://github.com/betatim","followers_url":"https://api.github.com/users/betatim/followers","following_url":"https://api.github.com/users/betatim/following{/other_user}","gists_url":"https://api.github.com/users/betatim/gists{/gist_id}","starred_url":"https://api.github.com/users/betatim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/betatim/subscriptions","organizations_url":"https://api.github.com/users/betatim/orgs","repos_url":"https://api.github.com/users/betatim/repos","events_url":"https://api.github.com/users/betatim/events{/privacy}","received_events_url":"https://api.github.com/users/betatim/received_events","type":"User","site_admin":false},"created_at":"2018-03-06T22:41:48Z","updated_at":"2018-03-06T22:41:48Z","author_association":"MEMBER","body":"Should a failure to download/run the appendix lead to a failed build? Maybe we should be forgiving especially in the case where we append it to a custom `Dockerfile`. Just thinking that some files might not be where we think they should be or that `wget` isn't installed or something crazy like that. Right now it will lead to very weird errors and \"what the whats??\" from the user who tested their stuff wit h`repo2docker` and now sees errors from things that \"don't exist in my Dockerfile\".\r\n\r\nI am confused about the default behaviour of binderhub wrt appendix. The helm chart sets it to empty values, but the default appendix in the config/traitlet isn't empty, however the default URL is, I think. So default bhub without helm chart will crash? Will read this again tomorrow."}}
{"actor":{"display_login":"betatim"}}