{"action":"created","comment":{"url":"https://api.github.com/repos/dlang/dmd/pulls/comments/228440264","pull_request_review_id":168714031,"id":228440264,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODQ0MDI2NA==","diff_hunk":"@@ -159,6 +159,7 @@ struct Param\n      * used to hide a feature that will have to go through deprecate-then-error\n      * before becoming default.\n      */\n+    bool vmarkdown;         // list instances of Markdown replacements in Ddoc","path":"src/dmd/globals.d","position":4,"original_position":4,"commit_id":"d161b8b39051164e3cc102a20d8c88e70456c79d","original_commit_id":"d161b8b39051164e3cc102a20d8c88e70456c79d","user":{"login":"jacob-carlborg","id":306980,"node_id":"MDQ6VXNlcjMwNjk4MA==","avatar_url":"https://avatars1.githubusercontent.com/u/306980?v=4","gravatar_id":"","url":"https://api.github.com/users/jacob-carlborg","html_url":"https://github.com/jacob-carlborg","followers_url":"https://api.github.com/users/jacob-carlborg/followers","following_url":"https://api.github.com/users/jacob-carlborg/following{/other_user}","gists_url":"https://api.github.com/users/jacob-carlborg/gists{/gist_id}","starred_url":"https://api.github.com/users/jacob-carlborg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacob-carlborg/subscriptions","organizations_url":"https://api.github.com/users/jacob-carlborg/orgs","repos_url":"https://api.github.com/users/jacob-carlborg/repos","events_url":"https://api.github.com/users/jacob-carlborg/events{/privacy}","received_events_url":"https://api.github.com/users/jacob-carlborg/received_events","type":"User","site_admin":false},"body":"What's the `v` for?","created_at":"2018-10-26T08:14:34Z","updated_at":"2018-10-26T08:14:35Z","html_url":"https://github.com/dlang/dmd/pull/8870#discussion_r228440264","pull_request_url":"https://api.github.com/repos/dlang/dmd/pulls/8870","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dlang/dmd/pulls/comments/228440264"},"html":{"href":"https://github.com/dlang/dmd/pull/8870#discussion_r228440264"},"pull_request":{"href":"https://api.github.com/repos/dlang/dmd/pulls/8870"}}},"pull_request":{"url":"https://api.github.com/repos/dlang/dmd/pulls/8870","id":225927213,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1OTI3MjEz","html_url":"https://github.com/dlang/dmd/pull/8870","diff_url":"https://github.com/dlang/dmd/pull/8870.diff","patch_url":"https://github.com/dlang/dmd/pull/8870.patch","issue_url":"https://api.github.com/repos/dlang/dmd/issues/8870","number":8870,"state":"open","locked":false,"title":"Support markdown-style backslash escapes","user":{"login":"dgileadi","id":352830,"node_id":"MDQ6VXNlcjM1MjgzMA==","avatar_url":"https://avatars3.githubusercontent.com/u/352830?v=4","gravatar_id":"","url":"https://api.github.com/users/dgileadi","html_url":"https://github.com/dgileadi","followers_url":"https://api.github.com/users/dgileadi/followers","following_url":"https://api.github.com/users/dgileadi/following{/other_user}","gists_url":"https://api.github.com/users/dgileadi/gists{/gist_id}","starred_url":"https://api.github.com/users/dgileadi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgileadi/subscriptions","organizations_url":"https://api.github.com/users/dgileadi/orgs","repos_url":"https://api.github.com/users/dgileadi/repos","events_url":"https://api.github.com/users/dgileadi/events{/privacy}","received_events_url":"https://api.github.com/users/dgileadi/received_events","type":"User","site_admin":false},"body":"This is a redo of the approved PR (#8043) to support markdown-style backslash escapes in ddoc. The difference is that this time the PR is directly against `master` instead of against a `markdown` feature branch. The original PR (#8043) was approved, so hopefully this will not be a difficult review.\r\n\r\nFor some background as to why I'm redoing this PR, the history is as follows:\r\n\r\n1. I originally created PR #7764 to support markdown syntax in ddoc. I was asked to split that PR into smaller feature PRs to make it easier to work with.\r\n2. I created PR #8043 (the predecessor to this one) as my first feature PR. After much debate in that PR, it was suggested that we create a feature branch to target all the feature PRs against, which would then be merged into `master` when complete. This turned out to be a Bad Idea™️. In any case the `markdown` feature branch was created, and the PR was eventually merged into that branch.\r\n3. I created my next feature PR, #8209, to support markdown-style inline emphasis. It was eventually approved. However it continually failed the automated tests, with errors that weren't related to the changes in the PR.\r\n4. It was proposed that perhaps the automated tests were failing because `markdown` feature branch was out of date. Accordingly another PR (#8325) was created to update the `markdown` feature branch with the latest from `master`. Unfortunately that PR also failed the automated tests.\r\n5. Everything sat this way for a long time.\r\n6. I made [an OT comment on the announce mailing list](https://forum.dlang.org/post/pqinjb$1b47$1@digitalmars.com) about the troubles I had, and Walter suggested I retarget my PRs against `master`.\r\n\r\nThis is the first feature PR to accordingly target `master`.\r\n\r\nBecause I'm targeting master, the markdown-style features will likely be released a few at a time instead of all at once. However I expect they'll all still fall under the `transition=markdown` flag.\r\n\r\nAfter each one is merged, I'll make corresponding PRs for the druntime and phobos documentation to preserve their output.","created_at":"2018-10-25T22:44:40Z","updated_at":"2018-10-26T08:14:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8a25121acc3ceebcf876ca9c88896bbc0a49b05f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"andralex","id":566679,"node_id":"MDQ6VXNlcjU2NjY3OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/566679?v=4","gravatar_id":"","url":"https://api.github.com/users/andralex","html_url":"https://github.com/andralex","followers_url":"https://api.github.com/users/andralex/followers","following_url":"https://api.github.com/users/andralex/following{/other_user}","gists_url":"https://api.github.com/users/andralex/gists{/gist_id}","starred_url":"https://api.github.com/users/andralex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andralex/subscriptions","organizations_url":"https://api.github.com/users/andralex/orgs","repos_url":"https://api.github.com/users/andralex/repos","events_url":"https://api.github.com/users/andralex/events{/privacy}","received_events_url":"https://api.github.com/users/andralex/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dlang/dmd/pulls/8870/commits","review_comments_url":"https://api.github.com/repos/dlang/dmd/pulls/8870/comments","review_comment_url":"https://api.github.com/repos/dlang/dmd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dlang/dmd/issues/8870/comments","statuses_url":"https://api.github.com/repos/dlang/dmd/statuses/d161b8b39051164e3cc102a20d8c88e70456c79d","head":{"label":"dgileadi:markdown-escapes","ref":"markdown-escapes","sha":"d161b8b39051164e3cc102a20d8c88e70456c79d","user":{"login":"dgileadi","id":352830,"node_id":"MDQ6VXNlcjM1MjgzMA==","avatar_url":"https://avatars3.githubusercontent.com/u/352830?v=4","gravatar_id":"","url":"https://api.github.com/users/dgileadi","html_url":"https://github.com/dgileadi","followers_url":"https://api.github.com/users/dgileadi/followers","following_url":"https://api.github.com/users/dgileadi/following{/other_user}","gists_url":"https://api.github.com/users/dgileadi/gists{/gist_id}","starred_url":"https://api.github.com/users/dgileadi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgileadi/subscriptions","organizations_url":"https://api.github.com/users/dgileadi/orgs","repos_url":"https://api.github.com/users/dgileadi/repos","events_url":"https://api.github.com/users/dgileadi/events{/privacy}","received_events_url":"https://api.github.com/users/dgileadi/received_events","type":"User","site_admin":false},"repo":{"id":113372065,"node_id":"MDEwOlJlcG9zaXRvcnkxMTMzNzIwNjU=","name":"dmd","full_name":"dgileadi/dmd","private":false,"owner":{"login":"dgileadi","id":352830,"node_id":"MDQ6VXNlcjM1MjgzMA==","avatar_url":"https://avatars3.githubusercontent.com/u/352830?v=4","gravatar_id":"","url":"https://api.github.com/users/dgileadi","html_url":"https://github.com/dgileadi","followers_url":"https://api.github.com/users/dgileadi/followers","following_url":"https://api.github.com/users/dgileadi/following{/other_user}","gists_url":"https://api.github.com/users/dgileadi/gists{/gist_id}","starred_url":"https://api.github.com/users/dgileadi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgileadi/subscriptions","organizations_url":"https://api.github.com/users/dgileadi/orgs","repos_url":"https://api.github.com/users/dgileadi/repos","events_url":"https://api.github.com/users/dgileadi/events{/privacy}","received_events_url":"https://api.github.com/users/dgileadi/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dgileadi/dmd","description":"dmd D Programming Language compiler","fork":true,"url":"https://api.github.com/repos/dgileadi/dmd","forks_url":"https://api.github.com/repos/dgileadi/dmd/forks","keys_url":"https://api.github.com/repos/dgileadi/dmd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dgileadi/dmd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dgileadi/dmd/teams","hooks_url":"https://api.github.com/repos/dgileadi/dmd/hooks","issue_events_url":"https://api.github.com/repos/dgileadi/dmd/issues/events{/number}","events_url":"https://api.github.com/repos/dgileadi/dmd/events","assignees_url":"https://api.github.com/repos/dgileadi/dmd/assignees{/user}","branches_url":"https://api.github.com/repos/dgileadi/dmd/branches{/branch}","tags_url":"https://api.github.com/repos/dgileadi/dmd/tags","blobs_url":"https://api.github.com/repos/dgileadi/dmd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dgileadi/dmd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dgileadi/dmd/git/refs{/sha}","trees_url":"https://api.github.com/repos/dgileadi/dmd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dgileadi/dmd/statuses/{sha}","languages_url":"https://api.github.com/repos/dgileadi/dmd/languages","stargazers_url":"https://api.github.com/repos/dgileadi/dmd/stargazers","contributors_url":"https://api.github.com/repos/dgileadi/dmd/contributors","subscribers_url":"https://api.github.com/repos/dgileadi/dmd/subscribers","subscription_url":"https://api.github.com/repos/dgileadi/dmd/subscription","commits_url":"https://api.github.com/repos/dgileadi/dmd/commits{/sha}","git_commits_url":"https://api.github.com/repos/dgileadi/dmd/git/commits{/sha}","comments_url":"https://api.github.com/repos/dgileadi/dmd/comments{/number}","issue_comment_url":"https://api.github.com/repos/dgileadi/dmd/issues/comments{/number}","contents_url":"https://api.github.com/repos/dgileadi/dmd/contents/{+path}","compare_url":"https://api.github.com/repos/dgileadi/dmd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dgileadi/dmd/merges","archive_url":"https://api.github.com/repos/dgileadi/dmd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dgileadi/dmd/downloads","issues_url":"https://api.github.com/repos/dgileadi/dmd/issues{/number}","pulls_url":"https://api.github.com/repos/dgileadi/dmd/pulls{/number}","milestones_url":"https://api.github.com/repos/dgileadi/dmd/milestones{/number}","notifications_url":"https://api.github.com/repos/dgileadi/dmd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dgileadi/dmd/labels{/name}","releases_url":"https://api.github.com/repos/dgileadi/dmd/releases{/id}","deployments_url":"https://api.github.com/repos/dgileadi/dmd/deployments","created_at":"2017-12-06T22:05:36Z","updated_at":"2017-12-06T22:05:43Z","pushed_at":"2018-10-26T00:01:31Z","git_url":"git://github.com/dgileadi/dmd.git","ssh_url":"git@github.com:dgileadi/dmd.git","clone_url":"https://github.com/dgileadi/dmd.git","svn_url":"https://github.com/dgileadi/dmd","homepage":"dlang.org","size":93905,"stargazers_count":0,"watchers_count":0,"language":"D","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsl-1.0","name":"Boost Software License 1.0","spdx_id":"BSL-1.0","url":"https://api.github.com/licenses/bsl-1.0","node_id":"MDc6TGljZW5zZTI4"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dlang:master","ref":"master","sha":"eab84c758b78a3974b6c277738413d18c7327b56","user":{"login":"dlang","id":565913,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2NTkxMw==","avatar_url":"https://avatars3.githubusercontent.com/u/565913?v=4","gravatar_id":"","url":"https://api.github.com/users/dlang","html_url":"https://github.com/dlang","followers_url":"https://api.github.com/users/dlang/followers","following_url":"https://api.github.com/users/dlang/following{/other_user}","gists_url":"https://api.github.com/users/dlang/gists{/gist_id}","starred_url":"https://api.github.com/users/dlang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlang/subscriptions","organizations_url":"https://api.github.com/users/dlang/orgs","repos_url":"https://api.github.com/users/dlang/repos","events_url":"https://api.github.com/users/dlang/events{/privacy}","received_events_url":"https://api.github.com/users/dlang/received_events","type":"Organization","site_admin":false},"repo":{"id":1257070,"node_id":"MDEwOlJlcG9zaXRvcnkxMjU3MDcw","name":"dmd","full_name":"dlang/dmd","private":false,"owner":{"login":"dlang","id":565913,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2NTkxMw==","avatar_url":"https://avatars3.githubusercontent.com/u/565913?v=4","gravatar_id":"","url":"https://api.github.com/users/dlang","html_url":"https://github.com/dlang","followers_url":"https://api.github.com/users/dlang/followers","following_url":"https://api.github.com/users/dlang/following{/other_user}","gists_url":"https://api.github.com/users/dlang/gists{/gist_id}","starred_url":"https://api.github.com/users/dlang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlang/subscriptions","organizations_url":"https://api.github.com/users/dlang/orgs","repos_url":"https://api.github.com/users/dlang/repos","events_url":"https://api.github.com/users/dlang/events{/privacy}","received_events_url":"https://api.github.com/users/dlang/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dlang/dmd","description":"dmd D Programming Language compiler","fork":false,"url":"https://api.github.com/repos/dlang/dmd","forks_url":"https://api.github.com/repos/dlang/dmd/forks","keys_url":"https://api.github.com/repos/dlang/dmd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dlang/dmd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dlang/dmd/teams","hooks_url":"https://api.github.com/repos/dlang/dmd/hooks","issue_events_url":"https://api.github.com/repos/dlang/dmd/issues/events{/number}","events_url":"https://api.github.com/repos/dlang/dmd/events","assignees_url":"https://api.github.com/repos/dlang/dmd/assignees{/user}","branches_url":"https://api.github.com/repos/dlang/dmd/branches{/branch}","tags_url":"https://api.github.com/repos/dlang/dmd/tags","blobs_url":"https://api.github.com/repos/dlang/dmd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dlang/dmd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dlang/dmd/git/refs{/sha}","trees_url":"https://api.github.com/repos/dlang/dmd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dlang/dmd/statuses/{sha}","languages_url":"https://api.github.com/repos/dlang/dmd/languages","stargazers_url":"https://api.github.com/repos/dlang/dmd/stargazers","contributors_url":"https://api.github.com/repos/dlang/dmd/contributors","subscribers_url":"https://api.github.com/repos/dlang/dmd/subscribers","subscription_url":"https://api.github.com/repos/dlang/dmd/subscription","commits_url":"https://api.github.com/repos/dlang/dmd/commits{/sha}","git_commits_url":"https://api.github.com/repos/dlang/dmd/git/commits{/sha}","comments_url":"https://api.github.com/repos/dlang/dmd/comments{/number}","issue_comment_url":"https://api.github.com/repos/dlang/dmd/issues/comments{/number}","contents_url":"https://api.github.com/repos/dlang/dmd/contents/{+path}","compare_url":"https://api.github.com/repos/dlang/dmd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dlang/dmd/merges","archive_url":"https://api.github.com/repos/dlang/dmd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dlang/dmd/downloads","issues_url":"https://api.github.com/repos/dlang/dmd/issues{/number}","pulls_url":"https://api.github.com/repos/dlang/dmd/pulls{/number}","milestones_url":"https://api.github.com/repos/dlang/dmd/milestones{/number}","notifications_url":"https://api.github.com/repos/dlang/dmd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dlang/dmd/labels{/name}","releases_url":"https://api.github.com/repos/dlang/dmd/releases{/id}","deployments_url":"https://api.github.com/repos/dlang/dmd/deployments","created_at":"2011-01-15T06:53:53Z","updated_at":"2018-10-25T21:27:06Z","pushed_at":"2018-10-26T07:33:37Z","git_url":"git://github.com/dlang/dmd.git","ssh_url":"git@github.com:dlang/dmd.git","clone_url":"https://github.com/dlang/dmd.git","svn_url":"https://github.com/dlang/dmd","homepage":"dlang.org","size":94704,"stargazers_count":1847,"watchers_count":1847,"language":"D","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":475,"mirror_url":null,"archived":false,"open_issues_count":154,"license":{"key":"bsl-1.0","name":"Boost Software License 1.0","spdx_id":"BSL-1.0","url":"https://api.github.com/licenses/bsl-1.0","node_id":"MDc6TGljZW5zZTI4"},"forks":475,"open_issues":154,"watchers":1847,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dlang/dmd/pulls/8870"},"html":{"href":"https://github.com/dlang/dmd/pull/8870"},"issue":{"href":"https://api.github.com/repos/dlang/dmd/issues/8870"},"comments":{"href":"https://api.github.com/repos/dlang/dmd/issues/8870/comments"},"review_comments":{"href":"https://api.github.com/repos/dlang/dmd/pulls/8870/comments"},"review_comment":{"href":"https://api.github.com/repos/dlang/dmd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dlang/dmd/pulls/8870/commits"},"statuses":{"href":"https://api.github.com/repos/dlang/dmd/statuses/d161b8b39051164e3cc102a20d8c88e70456c79d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jacob-carlborg"}}