{"action":"created","comment":{"url":"https://api.github.com/repos/finnishtransportagency/digiroad2/pulls/comments/211112702","pull_request_review_id":147467556,"id":211112702,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTExMjcwMg==","diff_hunk":"@@ -41,9 +41,9 @@ class ObstacleService(val roadLinkService: RoadLinkService) extends PointAssetOp\n     }\n   }\n \n-  override def update(id: Long, updatedAsset: IncomingObstacle, geometry: Seq[Point], municipality: Int, username: String, linkSource: LinkGeomSource): Long = {\n+  override def update(id: Long, updatedAsset: IncomingObstacle, roadLink: RoadLink, username: String): Long = {\n     withDynTransaction {\n-      updateWithoutTransaction(id, updatedAsset, geometry, municipality, username, linkSource, None, None)\n+      updateWithoutTransaction(id, updatedAsset, roadLink.geometry, roadLink.municipalityCode, username, roadLink.linkSource, None, None)","path":"digiroad2-oracle/src/main/scala/fi/liikennevirasto/digiroad2/service/pointasset/ObstacleService.scala","position":8,"original_position":8,"commit_id":"857c27e297e248fbf8e703d181747f66cb0200dc","original_commit_id":"857c27e297e248fbf8e703d181747f66cb0200dc","user":{"login":"MAC-CGI","id":22151972,"node_id":"MDQ6VXNlcjIyMTUxOTcy","avatar_url":"https://avatars2.githubusercontent.com/u/22151972?v=4","gravatar_id":"","url":"https://api.github.com/users/MAC-CGI","html_url":"https://github.com/MAC-CGI","followers_url":"https://api.github.com/users/MAC-CGI/followers","following_url":"https://api.github.com/users/MAC-CGI/following{/other_user}","gists_url":"https://api.github.com/users/MAC-CGI/gists{/gist_id}","starred_url":"https://api.github.com/users/MAC-CGI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MAC-CGI/subscriptions","organizations_url":"https://api.github.com/users/MAC-CGI/orgs","repos_url":"https://api.github.com/users/MAC-CGI/repos","events_url":"https://api.github.com/users/MAC-CGI/events{/privacy}","received_events_url":"https://api.github.com/users/MAC-CGI/received_events","type":"User","site_admin":false},"body":"instead of , ...roadLink.geometry, roadLink.municipalityCode, username, roadLink.linkSource ...we could only as a parameter roadLink.","created_at":"2018-08-19T19:28:31Z","updated_at":"2018-08-19T19:32:10Z","html_url":"https://github.com/finnishtransportagency/digiroad2/pull/1251#discussion_r211112702","pull_request_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/pulls/1251","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/finnishtransportagency/digiroad2/pulls/comments/211112702"},"html":{"href":"https://github.com/finnishtransportagency/digiroad2/pull/1251#discussion_r211112702"},"pull_request":{"href":"https://api.github.com/repos/finnishtransportagency/digiroad2/pulls/1251"}}},"pull_request":{"url":"https://api.github.com/repos/finnishtransportagency/digiroad2/pulls/1251","id":208312771,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4MzEyNzcx","html_url":"https://github.com/finnishtransportagency/digiroad2/pull/1251","diff_url":"https://github.com/finnishtransportagency/digiroad2/pull/1251.diff","patch_url":"https://github.com/finnishtransportagency/digiroad2/pull/1251.patch","issue_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/issues/1251","number":1251,"state":"open","locked":false,"title":"Droth 1447 update of turning restrictions by traffic signs","user":{"login":"oskarmalmstrom","id":19705734,"node_id":"MDQ6VXNlcjE5NzA1NzM0","avatar_url":"https://avatars3.githubusercontent.com/u/19705734?v=4","gravatar_id":"","url":"https://api.github.com/users/oskarmalmstrom","html_url":"https://github.com/oskarmalmstrom","followers_url":"https://api.github.com/users/oskarmalmstrom/followers","following_url":"https://api.github.com/users/oskarmalmstrom/following{/other_user}","gists_url":"https://api.github.com/users/oskarmalmstrom/gists{/gist_id}","starred_url":"https://api.github.com/users/oskarmalmstrom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oskarmalmstrom/subscriptions","organizations_url":"https://api.github.com/users/oskarmalmstrom/orgs","repos_url":"https://api.github.com/users/oskarmalmstrom/repos","events_url":"https://api.github.com/users/oskarmalmstrom/events{/privacy}","received_events_url":"https://api.github.com/users/oskarmalmstrom/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-08-14T15:02:11Z","updated_at":"2018-08-19T19:32:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/pulls/1251/commits","review_comments_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/pulls/1251/comments","review_comment_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/issues/1251/comments","statuses_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/statuses/857c27e297e248fbf8e703d181747f66cb0200dc","head":{"label":"finnishtransportagency:DROTH-1447_Update_of_turning_restrictions_by_traffic_signs","ref":"DROTH-1447_Update_of_turning_restrictions_by_traffic_signs","sha":"857c27e297e248fbf8e703d181747f66cb0200dc","user":{"login":"finnishtransportagency","id":5737015,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3MzcwMTU=","avatar_url":"https://avatars1.githubusercontent.com/u/5737015?v=4","gravatar_id":"","url":"https://api.github.com/users/finnishtransportagency","html_url":"https://github.com/finnishtransportagency","followers_url":"https://api.github.com/users/finnishtransportagency/followers","following_url":"https://api.github.com/users/finnishtransportagency/following{/other_user}","gists_url":"https://api.github.com/users/finnishtransportagency/gists{/gist_id}","starred_url":"https://api.github.com/users/finnishtransportagency/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/finnishtransportagency/subscriptions","organizations_url":"https://api.github.com/users/finnishtransportagency/orgs","repos_url":"https://api.github.com/users/finnishtransportagency/repos","events_url":"https://api.github.com/users/finnishtransportagency/events{/privacy}","received_events_url":"https://api.github.com/users/finnishtransportagency/received_events","type":"Organization","site_admin":false},"repo":{"id":13739672,"node_id":"MDEwOlJlcG9zaXRvcnkxMzczOTY3Mg==","name":"digiroad2","full_name":"finnishtransportagency/digiroad2","owner":{"login":"finnishtransportagency","id":5737015,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3MzcwMTU=","avatar_url":"https://avatars1.githubusercontent.com/u/5737015?v=4","gravatar_id":"","url":"https://api.github.com/users/finnishtransportagency","html_url":"https://github.com/finnishtransportagency","followers_url":"https://api.github.com/users/finnishtransportagency/followers","following_url":"https://api.github.com/users/finnishtransportagency/following{/other_user}","gists_url":"https://api.github.com/users/finnishtransportagency/gists{/gist_id}","starred_url":"https://api.github.com/users/finnishtransportagency/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/finnishtransportagency/subscriptions","organizations_url":"https://api.github.com/users/finnishtransportagency/orgs","repos_url":"https://api.github.com/users/finnishtransportagency/repos","events_url":"https://api.github.com/users/finnishtransportagency/events{/privacy}","received_events_url":"https://api.github.com/users/finnishtransportagency/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/finnishtransportagency/digiroad2","description":"Digiroad 2 development","fork":false,"url":"https://api.github.com/repos/finnishtransportagency/digiroad2","forks_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/forks","keys_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/teams","hooks_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/hooks","issue_events_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/issues/events{/number}","events_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/events","assignees_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/assignees{/user}","branches_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/branches{/branch}","tags_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/tags","blobs_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/git/refs{/sha}","trees_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/statuses/{sha}","languages_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/languages","stargazers_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/stargazers","contributors_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/contributors","subscribers_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/subscribers","subscription_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/subscription","commits_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/commits{/sha}","git_commits_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/git/commits{/sha}","comments_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/comments{/number}","issue_comment_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/issues/comments{/number}","contents_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/contents/{+path}","compare_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/merges","archive_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/downloads","issues_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/issues{/number}","pulls_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/pulls{/number}","milestones_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/milestones{/number}","notifications_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/labels{/name}","releases_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/releases{/id}","deployments_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/deployments","created_at":"2013-10-21T10:47:36Z","updated_at":"2018-08-17T14:04:54Z","pushed_at":"2018-08-19T18:24:11Z","git_url":"git://github.com/finnishtransportagency/digiroad2.git","ssh_url":"git@github.com:finnishtransportagency/digiroad2.git","clone_url":"https://github.com/finnishtransportagency/digiroad2.git","svn_url":"https://github.com/finnishtransportagency/digiroad2","homepage":"","size":277005,"stargazers_count":10,"watchers_count":10,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":15,"license":null,"forks":8,"open_issues":15,"watchers":10,"default_branch":"master"}},"base":{"label":"finnishtransportagency:master","ref":"master","sha":"d933ec2ace8356d5ad1aa85fac9446c0dc974806","user":{"login":"finnishtransportagency","id":5737015,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3MzcwMTU=","avatar_url":"https://avatars1.githubusercontent.com/u/5737015?v=4","gravatar_id":"","url":"https://api.github.com/users/finnishtransportagency","html_url":"https://github.com/finnishtransportagency","followers_url":"https://api.github.com/users/finnishtransportagency/followers","following_url":"https://api.github.com/users/finnishtransportagency/following{/other_user}","gists_url":"https://api.github.com/users/finnishtransportagency/gists{/gist_id}","starred_url":"https://api.github.com/users/finnishtransportagency/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/finnishtransportagency/subscriptions","organizations_url":"https://api.github.com/users/finnishtransportagency/orgs","repos_url":"https://api.github.com/users/finnishtransportagency/repos","events_url":"https://api.github.com/users/finnishtransportagency/events{/privacy}","received_events_url":"https://api.github.com/users/finnishtransportagency/received_events","type":"Organization","site_admin":false},"repo":{"id":13739672,"node_id":"MDEwOlJlcG9zaXRvcnkxMzczOTY3Mg==","name":"digiroad2","full_name":"finnishtransportagency/digiroad2","owner":{"login":"finnishtransportagency","id":5737015,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3MzcwMTU=","avatar_url":"https://avatars1.githubusercontent.com/u/5737015?v=4","gravatar_id":"","url":"https://api.github.com/users/finnishtransportagency","html_url":"https://github.com/finnishtransportagency","followers_url":"https://api.github.com/users/finnishtransportagency/followers","following_url":"https://api.github.com/users/finnishtransportagency/following{/other_user}","gists_url":"https://api.github.com/users/finnishtransportagency/gists{/gist_id}","starred_url":"https://api.github.com/users/finnishtransportagency/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/finnishtransportagency/subscriptions","organizations_url":"https://api.github.com/users/finnishtransportagency/orgs","repos_url":"https://api.github.com/users/finnishtransportagency/repos","events_url":"https://api.github.com/users/finnishtransportagency/events{/privacy}","received_events_url":"https://api.github.com/users/finnishtransportagency/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/finnishtransportagency/digiroad2","description":"Digiroad 2 development","fork":false,"url":"https://api.github.com/repos/finnishtransportagency/digiroad2","forks_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/forks","keys_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/teams","hooks_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/hooks","issue_events_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/issues/events{/number}","events_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/events","assignees_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/assignees{/user}","branches_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/branches{/branch}","tags_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/tags","blobs_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/git/refs{/sha}","trees_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/statuses/{sha}","languages_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/languages","stargazers_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/stargazers","contributors_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/contributors","subscribers_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/subscribers","subscription_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/subscription","commits_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/commits{/sha}","git_commits_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/git/commits{/sha}","comments_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/comments{/number}","issue_comment_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/issues/comments{/number}","contents_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/contents/{+path}","compare_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/merges","archive_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/downloads","issues_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/issues{/number}","pulls_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/pulls{/number}","milestones_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/milestones{/number}","notifications_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/labels{/name}","releases_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/releases{/id}","deployments_url":"https://api.github.com/repos/finnishtransportagency/digiroad2/deployments","created_at":"2013-10-21T10:47:36Z","updated_at":"2018-08-17T14:04:54Z","pushed_at":"2018-08-19T18:24:11Z","git_url":"git://github.com/finnishtransportagency/digiroad2.git","ssh_url":"git@github.com:finnishtransportagency/digiroad2.git","clone_url":"https://github.com/finnishtransportagency/digiroad2.git","svn_url":"https://github.com/finnishtransportagency/digiroad2","homepage":"","size":277005,"stargazers_count":10,"watchers_count":10,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":15,"license":null,"forks":8,"open_issues":15,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/finnishtransportagency/digiroad2/pulls/1251"},"html":{"href":"https://github.com/finnishtransportagency/digiroad2/pull/1251"},"issue":{"href":"https://api.github.com/repos/finnishtransportagency/digiroad2/issues/1251"},"comments":{"href":"https://api.github.com/repos/finnishtransportagency/digiroad2/issues/1251/comments"},"review_comments":{"href":"https://api.github.com/repos/finnishtransportagency/digiroad2/pulls/1251/comments"},"review_comment":{"href":"https://api.github.com/repos/finnishtransportagency/digiroad2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/finnishtransportagency/digiroad2/pulls/1251/commits"},"statuses":{"href":"https://api.github.com/repos/finnishtransportagency/digiroad2/statuses/857c27e297e248fbf8e703d181747f66cb0200dc"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"MAC-CGI"}}