{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/osquery/issues/4679","repository_url":"https://api.github.com/repos/facebook/osquery","labels_url":"https://api.github.com/repos/facebook/osquery/issues/4679/labels{/name}","comments_url":"https://api.github.com/repos/facebook/osquery/issues/4679/comments","events_url":"https://api.github.com/repos/facebook/osquery/issues/4679/events","html_url":"https://github.com/facebook/osquery/pull/4679","id":339136258,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5ODkxNDcw","number":4679,"title":"Support CDHash algorithms other than SHA-1 (Darwin)","user":{"login":"droe","id":749226,"node_id":"MDQ6VXNlcjc0OTIyNg==","avatar_url":"https://avatars3.githubusercontent.com/u/749226?v=4","gravatar_id":"","url":"https://api.github.com/users/droe","html_url":"https://github.com/droe","followers_url":"https://api.github.com/users/droe/followers","following_url":"https://api.github.com/users/droe/following{/other_user}","gists_url":"https://api.github.com/users/droe/gists{/gist_id}","starred_url":"https://api.github.com/users/droe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/droe/subscriptions","organizations_url":"https://api.github.com/users/droe/orgs","repos_url":"https://api.github.com/users/droe/repos","events_url":"https://api.github.com/users/droe/events{/privacy}","received_events_url":"https://api.github.com/users/droe/received_events","type":"User","site_admin":false},"labels":[{"id":196858822,"node_id":"MDU6TGFiZWwxOTY4NTg4MjI=","url":"https://api.github.com/repos/facebook/osquery/labels/cla%20signed","name":"cla signed","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-07-07T10:42:29Z","updated_at":"2018-07-11T16:54:26Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/facebook/osquery/pulls/4679","html_url":"https://github.com/facebook/osquery/pull/4679","diff_url":"https://github.com/facebook/osquery/pull/4679.diff","patch_url":"https://github.com/facebook/osquery/pull/4679.patch"},"body":"Osquery currently fails to extract the CDHash for signed binaries which use\r\na CDHash produced by a different algorithm than SHA-1.\r\n\r\nCDHash is not guaranteed to be SHA-1.  In fact, the algorithm is being\r\nchanged to SHA-256. Therefore, this pull req removes the dependency on\r\nSHA-1 from the code in order to support CDHashes produced with other\r\nhash algorithms, but still relies on the OS to decide which CDHash to select\r\nif there are multiple hashes produced using different hash algorithms.\r\n\r\nAn alternative approach to the one I've chosen would be to extract all of\r\nthe available CDHashes and make them all available in separate columns.\r\nThis pull request is the least intrusive improvement over failing to extract\r\nthe CDHash entirely where the OS decides to serve up SHA-256 instead\r\nof SHA-1."},"comment":{"url":"https://api.github.com/repos/facebook/osquery/issues/comments/404239255","html_url":"https://github.com/facebook/osquery/pull/4679#issuecomment-404239255","issue_url":"https://api.github.com/repos/facebook/osquery/issues/4679","id":404239255,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNDIzOTI1NQ==","user":{"login":"guliashvili","id":4594711,"node_id":"MDQ6VXNlcjQ1OTQ3MTE=","avatar_url":"https://avatars3.githubusercontent.com/u/4594711?v=4","gravatar_id":"","url":"https://api.github.com/users/guliashvili","html_url":"https://github.com/guliashvili","followers_url":"https://api.github.com/users/guliashvili/followers","following_url":"https://api.github.com/users/guliashvili/following{/other_user}","gists_url":"https://api.github.com/users/guliashvili/gists{/gist_id}","starred_url":"https://api.github.com/users/guliashvili/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guliashvili/subscriptions","organizations_url":"https://api.github.com/users/guliashvili/orgs","repos_url":"https://api.github.com/users/guliashvili/repos","events_url":"https://api.github.com/users/guliashvili/events{/privacy}","received_events_url":"https://api.github.com/users/guliashvili/received_events","type":"User","site_admin":false},"created_at":"2018-07-11T16:54:26Z","updated_at":"2018-07-11T16:54:26Z","author_association":"CONTRIBUTOR","body":"Thanks for raising up this issue @droe \r\n\r\nI like the idea, however as I understand(please correct, if I'm wrong), even though you are extracting it in a different column, the old column is removed. So it's gonna be breaking change. \r\n\r\nIt does not mean, that it will not be merged, just highlighting the fact for others."}}
{"actor":{"display_login":"guliashvili"}}