{"action":"created","issue":{"url":"https://api.github.com/repos/BerkeleyAutomation/Urban_Driving_Simulator/issues/111","repository_url":"https://api.github.com/repos/BerkeleyAutomation/Urban_Driving_Simulator","labels_url":"https://api.github.com/repos/BerkeleyAutomation/Urban_Driving_Simulator/issues/111/labels{/name}","comments_url":"https://api.github.com/repos/BerkeleyAutomation/Urban_Driving_Simulator/issues/111/comments","events_url":"https://api.github.com/repos/BerkeleyAutomation/Urban_Driving_Simulator/issues/111/events","html_url":"https://github.com/BerkeleyAutomation/Urban_Driving_Simulator/pull/111","id":359749690,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1MTY5ODU3","number":111,"title":"added data saver class and integrated with simulator","user":{"login":"raghavanand98","id":17361784,"node_id":"MDQ6VXNlcjE3MzYxNzg0","avatar_url":"https://avatars0.githubusercontent.com/u/17361784?v=4","gravatar_id":"","url":"https://api.github.com/users/raghavanand98","html_url":"https://github.com/raghavanand98","followers_url":"https://api.github.com/users/raghavanand98/followers","following_url":"https://api.github.com/users/raghavanand98/following{/other_user}","gists_url":"https://api.github.com/users/raghavanand98/gists{/gist_id}","starred_url":"https://api.github.com/users/raghavanand98/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raghavanand98/subscriptions","organizations_url":"https://api.github.com/users/raghavanand98/orgs","repos_url":"https://api.github.com/users/raghavanand98/repos","events_url":"https://api.github.com/users/raghavanand98/events{/privacy}","received_events_url":"https://api.github.com/users/raghavanand98/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-09-13T05:40:05Z","updated_at":"2018-09-13T05:57:12Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/BerkeleyAutomation/Urban_Driving_Simulator/pulls/111","html_url":"https://github.com/BerkeleyAutomation/Urban_Driving_Simulator/pull/111","diff_url":"https://github.com/BerkeleyAutomation/Urban_Driving_Simulator/pull/111.diff","patch_url":"https://github.com/BerkeleyAutomation/Urban_Driving_Simulator/pull/111.patch"},"body":"Created a data saver class that's more generic and allows us to save arbitrary data for arbitrary cars. Might be overkill for this use case? I felt that it was the cleanest way to write without adding a bunch of functions/ arguments to the simulator. I could change it to be just more functions in sim.py if needed, but I felt that the number of arguments for the constructor would be too bloated. \r\n\r\nAnother option is to abstract away the data saver class and create it using a function within sim.py, which would allow us to have fewer external class dependencies for the user as well. "},"comment":{"url":"https://api.github.com/repos/BerkeleyAutomation/Urban_Driving_Simulator/issues/comments/420892602","html_url":"https://github.com/BerkeleyAutomation/Urban_Driving_Simulator/pull/111#issuecomment-420892602","issue_url":"https://api.github.com/repos/BerkeleyAutomation/Urban_Driving_Simulator/issues/111","id":420892602,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMDg5MjYwMg==","user":{"login":"coveralls","id":2354108,"node_id":"MDQ6VXNlcjIzNTQxMDg=","avatar_url":"https://avatars1.githubusercontent.com/u/2354108?v=4","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2018-09-13T05:57:12Z","updated_at":"2018-09-13T05:57:12Z","author_association":"NONE","body":"\n[![Coverage Status](https://coveralls.io/builds/18973281/badge)](https://coveralls.io/builds/18973281)\n\nCoverage increased (+0.6%) to 92.958% when pulling **5058245e4ed2b38f2d988c76d9b827d15bb75884 on obs_action_pairs** into **cd3d378f49f50e66c35f82400a6c479481cc104e on v2**.\n"}}
{"actor":{"display_login":"coveralls"}}