{"action":"opened","issue":{"url":"https://api.github.com/repos/openzipkin/zipkin-js/issues/321","repository_url":"https://api.github.com/repos/openzipkin/zipkin-js","labels_url":"https://api.github.com/repos/openzipkin/zipkin-js/issues/321/labels{/name}","comments_url":"https://api.github.com/repos/openzipkin/zipkin-js/issues/321/comments","events_url":"https://api.github.com/repos/openzipkin/zipkin-js/issues/321/events","html_url":"https://github.com/openzipkin/zipkin-js/issues/321","id":395020018,"node_id":"MDU6SXNzdWUzOTUwMjAwMTg=","number":321,"title":"Tags are being sent as a binaryAnnotations to a v2 endpoint","user":{"login":"ewhauser","id":131389,"node_id":"MDQ6VXNlcjEzMTM4OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/131389?v=4","gravatar_id":"","url":"https://api.github.com/users/ewhauser","html_url":"https://github.com/ewhauser","followers_url":"https://api.github.com/users/ewhauser/followers","following_url":"https://api.github.com/users/ewhauser/following{/other_user}","gists_url":"https://api.github.com/users/ewhauser/gists{/gist_id}","starred_url":"https://api.github.com/users/ewhauser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ewhauser/subscriptions","organizations_url":"https://api.github.com/users/ewhauser/orgs","repos_url":"https://api.github.com/users/ewhauser/repos","events_url":"https://api.github.com/users/ewhauser/events{/privacy}","received_events_url":"https://api.github.com/users/ewhauser/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-12-31T19:01:27Z","updated_at":"2018-12-31T19:01:27Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"The HTTP transport sends spans to the endpoint /api/v2/spans, but the endpoint does not support binaryAnnoations (https://zipkin.io/zipkin-api/#/default/post_spans). \r\n\r\nhttps://github.com/openzipkin/zipkin-js/blob/master/packages/zipkin/src/tracer/index.js#L232\r\n\r\n```json\r\n[\r\n  {\r\n    \"traceId\": \"cc747e493eb9020e\",\r\n    \"parentId\": \"cc747e493eb9020e\",\r\n    \"id\": \"1384293d93a10a3f\",\r\n    \"name\": \"post\",\r\n    \"timestamp\": 1546282591272000,\r\n    \"duration\": 111000,\r\n    \"annotations\": [\r\n      {\r\n        \"value\": \"cs\",\r\n        \"timestamp\": 1546282591272000,\r\n        \"endpoint\": {\r\n          \"serviceName\": \"local_service\"\r\n        }\r\n      },\r\n      {\r\n        \"value\": \"cr\",\r\n        \"timestamp\": 1546282591383000,\r\n        \"endpoint\": {\r\n          \"serviceName\": \"local_service\"\r\n        }\r\n      }\r\n    ],\r\n    \"binaryAnnotations\": [\r\n      {\r\n        \"key\": \"http.path\",\r\n        \"value\": \"/api/v1/signin/google\",\r\n        \"endpoint\": {\r\n          \"serviceName\": \"local_service\"\r\n        }\r\n      },\r\n      {\r\n        \"key\": \"error\",\r\n        \"value\": \"...\",\r\n        \"endpoint\": {\r\n          \"serviceName\": \"local_service\"\r\n        }\r\n      },\r\n      {\r\n        \"key\": \"sa\",\r\n        \"value\": true,\r\n        \"endpoint\": {\r\n          \"serviceName\": \"service_name\"\r\n        }\r\n      }\r\n    ]\r\n  }\r\n]\r\n```"}}
{"actor":{"display_login":"ewhauser"}}