{"action":"created","comment":{"url":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/pulls/comments/196533932","pull_request_review_id":130105401,"id":196533932,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NjUzMzkzMg==","diff_hunk":"@@ -143,36 +143,55 @@ data \"aws_ami\" \"user_ami\" {\n   }\n }\n \n-resource \"aws_launch_configuration\" \"container_instance\" {\n-  lifecycle {\n-    create_before_destroy = true\n+resource \"aws_launch_template\" \"container_instance\" {\n+  block_device_mappings {\n+    device_name = \"/dev/sda1\"","path":"main.tf","position":9,"original_position":9,"commit_id":"97e2c855e778d0d087ab1c5c81d7a88b9aaa9826","original_commit_id":"97e2c855e778d0d087ab1c5c81d7a88b9aaa9826","user":{"login":"rbreslow","id":1774125,"node_id":"MDQ6VXNlcjE3NzQxMjU=","avatar_url":"https://avatars2.githubusercontent.com/u/1774125?v=4","gravatar_id":"","url":"https://api.github.com/users/rbreslow","html_url":"https://github.com/rbreslow","followers_url":"https://api.github.com/users/rbreslow/followers","following_url":"https://api.github.com/users/rbreslow/following{/other_user}","gists_url":"https://api.github.com/users/rbreslow/gists{/gist_id}","starred_url":"https://api.github.com/users/rbreslow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rbreslow/subscriptions","organizations_url":"https://api.github.com/users/rbreslow/orgs","repos_url":"https://api.github.com/users/rbreslow/repos","events_url":"https://api.github.com/users/rbreslow/events{/privacy}","received_events_url":"https://api.github.com/users/rbreslow/received_events","type":"User","site_admin":false},"body":"![image](https://user-images.githubusercontent.com/1774125/41617110-a6bc876c-73cd-11e8-9640-a844b9c4ba75.png)\r\n\r\nhttps://docs.aws.amazon.com/AWSEC2/latest/UserGuide/block-device-mapping-concepts.html","created_at":"2018-06-19T18:32:59Z","updated_at":"2018-06-19T18:32:59Z","html_url":"https://github.com/azavea/terraform-aws-ecs-cluster/pull/34#discussion_r196533932","pull_request_url":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/pulls/34","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/pulls/comments/196533932"},"html":{"href":"https://github.com/azavea/terraform-aws-ecs-cluster/pull/34#discussion_r196533932"},"pull_request":{"href":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/pulls/34"}}},"pull_request":{"url":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/pulls/34","id":195917547,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1OTE3NTQ3","html_url":"https://github.com/azavea/terraform-aws-ecs-cluster/pull/34","diff_url":"https://github.com/azavea/terraform-aws-ecs-cluster/pull/34.diff","patch_url":"https://github.com/azavea/terraform-aws-ecs-cluster/pull/34.patch","issue_url":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/issues/34","number":34,"state":"open","locked":false,"title":"WIP: Migrate to using aws_launch_template vs. aws_launch_configuration and add support for T2 Unlimited","user":{"login":"rbreslow","id":1774125,"node_id":"MDQ6VXNlcjE3NzQxMjU=","avatar_url":"https://avatars2.githubusercontent.com/u/1774125?v=4","gravatar_id":"","url":"https://api.github.com/users/rbreslow","html_url":"https://github.com/rbreslow","followers_url":"https://api.github.com/users/rbreslow/followers","following_url":"https://api.github.com/users/rbreslow/following{/other_user}","gists_url":"https://api.github.com/users/rbreslow/gists{/gist_id}","starred_url":"https://api.github.com/users/rbreslow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rbreslow/subscriptions","organizations_url":"https://api.github.com/users/rbreslow/orgs","repos_url":"https://api.github.com/users/rbreslow/repos","events_url":"https://api.github.com/users/rbreslow/events{/privacy}","received_events_url":"https://api.github.com/users/rbreslow/received_events","type":"User","site_admin":false},"body":"## Overview\r\n\r\n* Remove aws_launch_configuration\r\n* Add aws_launch_template\r\n* Add unlimited_cpu variable and update README\r\n\r\nFixes #30 and #31 \r\n\r\n## Notes\r\n\r\nThere was an issue in testing where Terraform was throwing this:\r\n\r\n```\r\n* aws_autoscaling_group.container_instance: Error updating Autoscaling group: InvalidQueryParameter: Invalid launch template: When a network interface is provided, the security groups must be a part of it.\r\n```\r\n\r\nWhen I removed `ebs_optimized = true` from the resource, this error was suppressed. \r\n\r\nSee these docs for more information on using a launch template:\r\n * https://docs.aws.amazon.com/autoscaling/ec2/userguide/create-asg-launch-template.html\r\n * https://www.terraform.io/docs/providers/aws/r/launch_template.html\r\n\r\n## Testing\r\n\r\ntodo\r\n\r\n","created_at":"2018-06-19T18:26:29Z","updated_at":"2018-06-19T18:32:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b09f21673baa4c821f2f54e7e907eb1ff9165b34","assignee":{"login":"rbreslow","id":1774125,"node_id":"MDQ6VXNlcjE3NzQxMjU=","avatar_url":"https://avatars2.githubusercontent.com/u/1774125?v=4","gravatar_id":"","url":"https://api.github.com/users/rbreslow","html_url":"https://github.com/rbreslow","followers_url":"https://api.github.com/users/rbreslow/followers","following_url":"https://api.github.com/users/rbreslow/following{/other_user}","gists_url":"https://api.github.com/users/rbreslow/gists{/gist_id}","starred_url":"https://api.github.com/users/rbreslow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rbreslow/subscriptions","organizations_url":"https://api.github.com/users/rbreslow/orgs","repos_url":"https://api.github.com/users/rbreslow/repos","events_url":"https://api.github.com/users/rbreslow/events{/privacy}","received_events_url":"https://api.github.com/users/rbreslow/received_events","type":"User","site_admin":false},"assignees":[{"login":"rbreslow","id":1774125,"node_id":"MDQ6VXNlcjE3NzQxMjU=","avatar_url":"https://avatars2.githubusercontent.com/u/1774125?v=4","gravatar_id":"","url":"https://api.github.com/users/rbreslow","html_url":"https://github.com/rbreslow","followers_url":"https://api.github.com/users/rbreslow/followers","following_url":"https://api.github.com/users/rbreslow/following{/other_user}","gists_url":"https://api.github.com/users/rbreslow/gists{/gist_id}","starred_url":"https://api.github.com/users/rbreslow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rbreslow/subscriptions","organizations_url":"https://api.github.com/users/rbreslow/orgs","repos_url":"https://api.github.com/users/rbreslow/repos","events_url":"https://api.github.com/users/rbreslow/events{/privacy}","received_events_url":"https://api.github.com/users/rbreslow/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/pulls/34/commits","review_comments_url":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/pulls/34/comments","review_comment_url":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/pulls/comments{/number}","comments_url":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/issues/34/comments","statuses_url":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/statuses/97e2c855e778d0d087ab1c5c81d7a88b9aaa9826","head":{"label":"azavea:feature/jrb/migrate-launch-template","ref":"feature/jrb/migrate-launch-template","sha":"97e2c855e778d0d087ab1c5c81d7a88b9aaa9826","user":{"login":"azavea","id":595231,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5NTIzMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/595231?v=4","gravatar_id":"","url":"https://api.github.com/users/azavea","html_url":"https://github.com/azavea","followers_url":"https://api.github.com/users/azavea/followers","following_url":"https://api.github.com/users/azavea/following{/other_user}","gists_url":"https://api.github.com/users/azavea/gists{/gist_id}","starred_url":"https://api.github.com/users/azavea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azavea/subscriptions","organizations_url":"https://api.github.com/users/azavea/orgs","repos_url":"https://api.github.com/users/azavea/repos","events_url":"https://api.github.com/users/azavea/events{/privacy}","received_events_url":"https://api.github.com/users/azavea/received_events","type":"Organization","site_admin":false},"repo":{"id":85416178,"node_id":"MDEwOlJlcG9zaXRvcnk4NTQxNjE3OA==","name":"terraform-aws-ecs-cluster","full_name":"azavea/terraform-aws-ecs-cluster","owner":{"login":"azavea","id":595231,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5NTIzMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/595231?v=4","gravatar_id":"","url":"https://api.github.com/users/azavea","html_url":"https://github.com/azavea","followers_url":"https://api.github.com/users/azavea/followers","following_url":"https://api.github.com/users/azavea/following{/other_user}","gists_url":"https://api.github.com/users/azavea/gists{/gist_id}","starred_url":"https://api.github.com/users/azavea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azavea/subscriptions","organizations_url":"https://api.github.com/users/azavea/orgs","repos_url":"https://api.github.com/users/azavea/repos","events_url":"https://api.github.com/users/azavea/events{/privacy}","received_events_url":"https://api.github.com/users/azavea/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/azavea/terraform-aws-ecs-cluster","description":"A Terraform module to create an Amazon Web Services (AWS) EC2 Container Service (ECS) cluster.","fork":false,"url":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster","forks_url":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/forks","keys_url":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/keys{/key_id}","collaborators_url":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/teams","hooks_url":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/hooks","issue_events_url":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/issues/events{/number}","events_url":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/events","assignees_url":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/assignees{/user}","branches_url":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/branches{/branch}","tags_url":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/tags","blobs_url":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/git/refs{/sha}","trees_url":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/git/trees{/sha}","statuses_url":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/statuses/{sha}","languages_url":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/languages","stargazers_url":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/stargazers","contributors_url":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/contributors","subscribers_url":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/subscribers","subscription_url":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/subscription","commits_url":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/commits{/sha}","git_commits_url":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/git/commits{/sha}","comments_url":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/comments{/number}","issue_comment_url":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/issues/comments{/number}","contents_url":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/contents/{+path}","compare_url":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/compare/{base}...{head}","merges_url":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/merges","archive_url":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/downloads","issues_url":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/issues{/number}","pulls_url":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/pulls{/number}","milestones_url":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/milestones{/number}","notifications_url":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/labels{/name}","releases_url":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/releases{/id}","deployments_url":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/deployments","created_at":"2017-03-18T16:36:23Z","updated_at":"2018-06-18T15:20:24Z","pushed_at":"2018-06-19T18:28:32Z","git_url":"git://github.com/azavea/terraform-aws-ecs-cluster.git","ssh_url":"git@github.com:azavea/terraform-aws-ecs-cluster.git","clone_url":"https://github.com/azavea/terraform-aws-ecs-cluster.git","svn_url":"https://github.com/azavea/terraform-aws-ecs-cluster","homepage":null,"size":53,"stargazers_count":24,"watchers_count":24,"language":"HCL","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":23,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":23,"open_issues":4,"watchers":24,"default_branch":"develop"}},"base":{"label":"azavea:develop","ref":"develop","sha":"24d4a353a603c7a34f964990569d1353a92a6b49","user":{"login":"azavea","id":595231,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5NTIzMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/595231?v=4","gravatar_id":"","url":"https://api.github.com/users/azavea","html_url":"https://github.com/azavea","followers_url":"https://api.github.com/users/azavea/followers","following_url":"https://api.github.com/users/azavea/following{/other_user}","gists_url":"https://api.github.com/users/azavea/gists{/gist_id}","starred_url":"https://api.github.com/users/azavea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azavea/subscriptions","organizations_url":"https://api.github.com/users/azavea/orgs","repos_url":"https://api.github.com/users/azavea/repos","events_url":"https://api.github.com/users/azavea/events{/privacy}","received_events_url":"https://api.github.com/users/azavea/received_events","type":"Organization","site_admin":false},"repo":{"id":85416178,"node_id":"MDEwOlJlcG9zaXRvcnk4NTQxNjE3OA==","name":"terraform-aws-ecs-cluster","full_name":"azavea/terraform-aws-ecs-cluster","owner":{"login":"azavea","id":595231,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5NTIzMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/595231?v=4","gravatar_id":"","url":"https://api.github.com/users/azavea","html_url":"https://github.com/azavea","followers_url":"https://api.github.com/users/azavea/followers","following_url":"https://api.github.com/users/azavea/following{/other_user}","gists_url":"https://api.github.com/users/azavea/gists{/gist_id}","starred_url":"https://api.github.com/users/azavea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azavea/subscriptions","organizations_url":"https://api.github.com/users/azavea/orgs","repos_url":"https://api.github.com/users/azavea/repos","events_url":"https://api.github.com/users/azavea/events{/privacy}","received_events_url":"https://api.github.com/users/azavea/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/azavea/terraform-aws-ecs-cluster","description":"A Terraform module to create an Amazon Web Services (AWS) EC2 Container Service (ECS) cluster.","fork":false,"url":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster","forks_url":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/forks","keys_url":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/keys{/key_id}","collaborators_url":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/teams","hooks_url":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/hooks","issue_events_url":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/issues/events{/number}","events_url":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/events","assignees_url":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/assignees{/user}","branches_url":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/branches{/branch}","tags_url":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/tags","blobs_url":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/git/refs{/sha}","trees_url":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/git/trees{/sha}","statuses_url":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/statuses/{sha}","languages_url":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/languages","stargazers_url":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/stargazers","contributors_url":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/contributors","subscribers_url":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/subscribers","subscription_url":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/subscription","commits_url":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/commits{/sha}","git_commits_url":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/git/commits{/sha}","comments_url":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/comments{/number}","issue_comment_url":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/issues/comments{/number}","contents_url":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/contents/{+path}","compare_url":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/compare/{base}...{head}","merges_url":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/merges","archive_url":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/downloads","issues_url":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/issues{/number}","pulls_url":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/pulls{/number}","milestones_url":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/milestones{/number}","notifications_url":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/labels{/name}","releases_url":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/releases{/id}","deployments_url":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/deployments","created_at":"2017-03-18T16:36:23Z","updated_at":"2018-06-18T15:20:24Z","pushed_at":"2018-06-19T18:28:32Z","git_url":"git://github.com/azavea/terraform-aws-ecs-cluster.git","ssh_url":"git@github.com:azavea/terraform-aws-ecs-cluster.git","clone_url":"https://github.com/azavea/terraform-aws-ecs-cluster.git","svn_url":"https://github.com/azavea/terraform-aws-ecs-cluster","homepage":null,"size":53,"stargazers_count":24,"watchers_count":24,"language":"HCL","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":23,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":23,"open_issues":4,"watchers":24,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/pulls/34"},"html":{"href":"https://github.com/azavea/terraform-aws-ecs-cluster/pull/34"},"issue":{"href":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/issues/34"},"comments":{"href":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/issues/34/comments"},"review_comments":{"href":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/pulls/34/comments"},"review_comment":{"href":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/pulls/34/commits"},"statuses":{"href":"https://api.github.com/repos/azavea/terraform-aws-ecs-cluster/statuses/97e2c855e778d0d087ab1c5c81d7a88b9aaa9826"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"rbreslow"}}