{"action":"created","issue":{"url":"https://api.github.com/repos/OCA/l10n-belgium/issues/64","repository_url":"https://api.github.com/repos/OCA/l10n-belgium","labels_url":"https://api.github.com/repos/OCA/l10n-belgium/issues/64/labels{/name}","comments_url":"https://api.github.com/repos/OCA/l10n-belgium/issues/64/comments","events_url":"https://api.github.com/repos/OCA/l10n-belgium/issues/64/events","html_url":"https://github.com/OCA/l10n-belgium/pull/64","id":338344304,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5MzAxNjE0","number":64,"title":"[FIX] vat report: add rounding in checks and other fixes","user":{"login":"sbidoul","id":692075,"node_id":"MDQ6VXNlcjY5MjA3NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/692075?v=4","gravatar_id":"","url":"https://api.github.com/users/sbidoul","html_url":"https://github.com/sbidoul","followers_url":"https://api.github.com/users/sbidoul/followers","following_url":"https://api.github.com/users/sbidoul/following{/other_user}","gists_url":"https://api.github.com/users/sbidoul/gists{/gist_id}","starred_url":"https://api.github.com/users/sbidoul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbidoul/subscriptions","organizations_url":"https://api.github.com/users/sbidoul/orgs","repos_url":"https://api.github.com/users/sbidoul/repos","events_url":"https://api.github.com/users/sbidoul/events{/privacy}","received_events_url":"https://api.github.com/users/sbidoul/received_events","type":"User","site_admin":false},"labels":[{"id":770542043,"node_id":"MDU6TGFiZWw3NzA1NDIwNDM=","url":"https://api.github.com/repos/OCA/l10n-belgium/labels/9.0","name":"9.0","color":"000000","default":false},{"id":122066662,"node_id":"MDU6TGFiZWwxMjIwNjY2NjI=","url":"https://api.github.com/repos/OCA/l10n-belgium/labels/needs%20review","name":"needs review","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-07-04T17:33:48Z","updated_at":"2018-08-02T09:47:59Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/OCA/l10n-belgium/pulls/64","html_url":"https://github.com/OCA/l10n-belgium/pull/64","diff_url":"https://github.com/OCA/l10n-belgium/pull/64.diff","patch_url":"https://github.com/OCA/l10n-belgium/pull/64.patch"},"body":"Without these, we can have false positives.\r\n\r\n@vdewulf I'd love to get your review here :)"},"comment":{"url":"https://api.github.com/repos/OCA/l10n-belgium/issues/comments/409870850","html_url":"https://github.com/OCA/l10n-belgium/pull/64#issuecomment-409870850","issue_url":"https://api.github.com/repos/OCA/l10n-belgium/issues/64","id":409870850,"node_id":"MDEyOklzc3VlQ29tbWVudDQwOTg3MDg1MA==","user":{"login":"vdewulf","id":27895270,"node_id":"MDQ6VXNlcjI3ODk1Mjcw","avatar_url":"https://avatars2.githubusercontent.com/u/27895270?v=4","gravatar_id":"","url":"https://api.github.com/users/vdewulf","html_url":"https://github.com/vdewulf","followers_url":"https://api.github.com/users/vdewulf/followers","following_url":"https://api.github.com/users/vdewulf/following{/other_user}","gists_url":"https://api.github.com/users/vdewulf/gists{/gist_id}","starred_url":"https://api.github.com/users/vdewulf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdewulf/subscriptions","organizations_url":"https://api.github.com/users/vdewulf/orgs","repos_url":"https://api.github.com/users/vdewulf/repos","events_url":"https://api.github.com/users/vdewulf/events{/privacy}","received_events_url":"https://api.github.com/users/vdewulf/received_events","type":"User","site_admin":false},"created_at":"2018-08-02T09:47:59Z","updated_at":"2018-08-02T09:47:59Z","author_association":"NONE","body":"Hello,\r\nI tested the last updated check on grid 54.\r\n![image](https://user-images.githubusercontent.com/27895270/43575033-0798bc50-9646-11e8-940a-ca5e2d4a60ea.png)\r\nIt works fine it seems, even when there is no value in grid 01 nor grid 02 at all.\r\n\r\nBut I got errors for the checks on 55 and 87. For these checks, there are no values at all in the corresponding grids.\r\nI changed the check on grid 55 (implementing check P from intervat) by\r\n`u'✔' if abs((grid_84 + grid_86 + grid_88)*0.21 - grid_55) &lt; 62 else u'✘'`\r\n and the check on grid 87 (implementing check Q from intervat) by\r\n`u'✔' if abs((grid_85 + grid_87)*0.21 - (grid_56 + grid_57)) &lt; 62 else u'✘'`\r\n\r\n==> it worked fine:\r\n![image](https://user-images.githubusercontent.com/27895270/43576413-93d4a2c6-9649-11e8-961a-b28fa9dbbc33.png)\r\n\r\n(I don't know if I can commit and push on this PR. I let you do it?!).\r\n\r\nFor the other changes (rounding to 2 decimals), I already tested OK previously.\r\n\r\nFor the other checks for Intervat, I can try and add them. I will need support to add the conditions though (for example : if there is a value in grid xx, then there must be ...). Shall we continue on this PR or open a new one?"}}
{"actor":{"display_login":"vdewulf"}}