{"action":"created","comment":{"url":"https://api.github.com/repos/NCAR/VAPOR/pulls/comments/213126551","pull_request_review_id":149897709,"id":213126551,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMzEyNjU1MQ==","diff_hunk":"@@ -300,25 +310,43 @@ void MapperFunction::hsvValue(float value, float *h, float *s, float *v) const\n   }\n }\n \n+void MapperFunction::checkForOpacityChanges() {\n+\tfor (int i=0; i<getNumOpacityMaps(); i++) {\n+\t\tOpacityMap* om = GetOpacityMap(i);\n+\t\tif (om->GetDirtyBit())\n+\t\t\t_dirtyBit = true;\n+\t\tom->ResetDirtyBit();\n+\t}\n+}\n+\n //----------------------------------------------------------------------------\n // Populate at a RGBA lookup table \n //----------------------------------------------------------------------------\n-void MapperFunction::makeLut(float* clut) const\n+void MapperFunction::makeLut(float* clut) \n {\n-  float step = (getMaxMapValue() - getMinMapValue())/float(_numEntries-1);\n-\n-  for (int i = 0; i< _numEntries; i++)\n-  {\n-    float v = getMinMapValue() + i*step;\n-    m_colorMap->color(v).toRGB(&clut[4*i]);\n-    clut[4*i+3] = getOpacityValueData(v);\n+  checkForOpacityChanges();\n+\n+  if (_dirtyBit) {\n+  \tfloat step = (getMaxMapValue() - getMinMapValue())/float(_numEntries-1);\n+  \tfor (int i = 0; i< _numEntries; i++)\n+  \t{\n+  \t  float v = getMinMapValue() + i*step;\n+  \t  m_colorMap->color(v).toRGB(&clut[4*i]);\n+  \t  clut[4*i+3] = getOpacityValueData(v);\n+  \t}\n+\tmemcpy(_clut, clut, sizeof(float)*_numEntries*4);\n+  }\n+  else {\n+\tmemcpy(clut, _clut, sizeof(float)*_numEntries*4);\n   }\n+\n+  _dirtyBit = false;","path":"lib/params/MapperFunction.cpp","position":87,"original_position":87,"commit_id":"04f7589668d617152e868c1031b5b7e5b4354e92","original_commit_id":"04f7589668d617152e868c1031b5b7e5b4354e92","user":{"login":"sgpearse","id":9522770,"node_id":"MDQ6VXNlcjk1MjI3NzA=","avatar_url":"https://avatars3.githubusercontent.com/u/9522770?v=4","gravatar_id":"","url":"https://api.github.com/users/sgpearse","html_url":"https://github.com/sgpearse","followers_url":"https://api.github.com/users/sgpearse/followers","following_url":"https://api.github.com/users/sgpearse/following{/other_user}","gists_url":"https://api.github.com/users/sgpearse/gists{/gist_id}","starred_url":"https://api.github.com/users/sgpearse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgpearse/subscriptions","organizations_url":"https://api.github.com/users/sgpearse/orgs","repos_url":"https://api.github.com/users/sgpearse/repos","events_url":"https://api.github.com/users/sgpearse/events{/privacy}","received_events_url":"https://api.github.com/users/sgpearse/received_events","type":"User","site_admin":false},"body":"No.  Once we regenerate the lookup table we reset the dirty bit.","created_at":"2018-08-27T21:47:14Z","updated_at":"2018-08-27T21:47:14Z","html_url":"https://github.com/NCAR/VAPOR/pull/975#discussion_r213126551","pull_request_url":"https://api.github.com/repos/NCAR/VAPOR/pulls/975","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/NCAR/VAPOR/pulls/comments/213126551"},"html":{"href":"https://github.com/NCAR/VAPOR/pull/975#discussion_r213126551"},"pull_request":{"href":"https://api.github.com/repos/NCAR/VAPOR/pulls/975"}},"in_reply_to_id":213071689},"pull_request":{"url":"https://api.github.com/repos/NCAR/VAPOR/pulls/975","id":211158280,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExMTU4Mjgw","html_url":"https://github.com/NCAR/VAPOR/pull/975","diff_url":"https://github.com/NCAR/VAPOR/pull/975.diff","patch_url":"https://github.com/NCAR/VAPOR/pull/975.patch","issue_url":"https://api.github.com/repos/NCAR/VAPOR/issues/975","number":975,"state":"open","locked":false,"title":"Issue 954 mapper performance","user":{"login":"sgpearse","id":9522770,"node_id":"MDQ6VXNlcjk1MjI3NzA=","avatar_url":"https://avatars3.githubusercontent.com/u/9522770?v=4","gravatar_id":"","url":"https://api.github.com/users/sgpearse","html_url":"https://github.com/sgpearse","followers_url":"https://api.github.com/users/sgpearse/followers","following_url":"https://api.github.com/users/sgpearse/following{/other_user}","gists_url":"https://api.github.com/users/sgpearse/gists{/gist_id}","starred_url":"https://api.github.com/users/sgpearse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgpearse/subscriptions","organizations_url":"https://api.github.com/users/sgpearse/orgs","repos_url":"https://api.github.com/users/sgpearse/repos","events_url":"https://api.github.com/users/sgpearse/events{/privacy}","received_events_url":"https://api.github.com/users/sgpearse/received_events","type":"User","site_admin":false},"body":"Fix for #954","created_at":"2018-08-27T16:16:13Z","updated_at":"2018-08-27T21:47:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"02ca9729d7418ce47a64ee1178a36e4c44ea35b5","assignee":null,"assignees":[],"requested_reviewers":[{"login":"clyne","id":6777736,"node_id":"MDQ6VXNlcjY3Nzc3MzY=","avatar_url":"https://avatars1.githubusercontent.com/u/6777736?v=4","gravatar_id":"","url":"https://api.github.com/users/clyne","html_url":"https://github.com/clyne","followers_url":"https://api.github.com/users/clyne/followers","following_url":"https://api.github.com/users/clyne/following{/other_user}","gists_url":"https://api.github.com/users/clyne/gists{/gist_id}","starred_url":"https://api.github.com/users/clyne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clyne/subscriptions","organizations_url":"https://api.github.com/users/clyne/orgs","repos_url":"https://api.github.com/users/clyne/repos","events_url":"https://api.github.com/users/clyne/events{/privacy}","received_events_url":"https://api.github.com/users/clyne/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/NCAR/VAPOR/pulls/975/commits","review_comments_url":"https://api.github.com/repos/NCAR/VAPOR/pulls/975/comments","review_comment_url":"https://api.github.com/repos/NCAR/VAPOR/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NCAR/VAPOR/issues/975/comments","statuses_url":"https://api.github.com/repos/NCAR/VAPOR/statuses/04f7589668d617152e868c1031b5b7e5b4354e92","head":{"label":"NCAR:issue_954_mapperPerformance","ref":"issue_954_mapperPerformance","sha":"04f7589668d617152e868c1031b5b7e5b4354e92","user":{"login":"NCAR","id":2007542,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMDc1NDI=","avatar_url":"https://avatars2.githubusercontent.com/u/2007542?v=4","gravatar_id":"","url":"https://api.github.com/users/NCAR","html_url":"https://github.com/NCAR","followers_url":"https://api.github.com/users/NCAR/followers","following_url":"https://api.github.com/users/NCAR/following{/other_user}","gists_url":"https://api.github.com/users/NCAR/gists{/gist_id}","starred_url":"https://api.github.com/users/NCAR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NCAR/subscriptions","organizations_url":"https://api.github.com/users/NCAR/orgs","repos_url":"https://api.github.com/users/NCAR/repos","events_url":"https://api.github.com/users/NCAR/events{/privacy}","received_events_url":"https://api.github.com/users/NCAR/received_events","type":"Organization","site_admin":false},"repo":{"id":94365653,"node_id":"MDEwOlJlcG9zaXRvcnk5NDM2NTY1Mw==","name":"VAPOR","full_name":"NCAR/VAPOR","owner":{"login":"NCAR","id":2007542,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMDc1NDI=","avatar_url":"https://avatars2.githubusercontent.com/u/2007542?v=4","gravatar_id":"","url":"https://api.github.com/users/NCAR","html_url":"https://github.com/NCAR","followers_url":"https://api.github.com/users/NCAR/followers","following_url":"https://api.github.com/users/NCAR/following{/other_user}","gists_url":"https://api.github.com/users/NCAR/gists{/gist_id}","starred_url":"https://api.github.com/users/NCAR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NCAR/subscriptions","organizations_url":"https://api.github.com/users/NCAR/orgs","repos_url":"https://api.github.com/users/NCAR/repos","events_url":"https://api.github.com/users/NCAR/events{/privacy}","received_events_url":"https://api.github.com/users/NCAR/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NCAR/VAPOR","description":"VAPOR is the Visualization and Analysis Platform for Ocean, Atmosphere, and Solar Researchers","fork":false,"url":"https://api.github.com/repos/NCAR/VAPOR","forks_url":"https://api.github.com/repos/NCAR/VAPOR/forks","keys_url":"https://api.github.com/repos/NCAR/VAPOR/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NCAR/VAPOR/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NCAR/VAPOR/teams","hooks_url":"https://api.github.com/repos/NCAR/VAPOR/hooks","issue_events_url":"https://api.github.com/repos/NCAR/VAPOR/issues/events{/number}","events_url":"https://api.github.com/repos/NCAR/VAPOR/events","assignees_url":"https://api.github.com/repos/NCAR/VAPOR/assignees{/user}","branches_url":"https://api.github.com/repos/NCAR/VAPOR/branches{/branch}","tags_url":"https://api.github.com/repos/NCAR/VAPOR/tags","blobs_url":"https://api.github.com/repos/NCAR/VAPOR/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NCAR/VAPOR/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NCAR/VAPOR/git/refs{/sha}","trees_url":"https://api.github.com/repos/NCAR/VAPOR/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NCAR/VAPOR/statuses/{sha}","languages_url":"https://api.github.com/repos/NCAR/VAPOR/languages","stargazers_url":"https://api.github.com/repos/NCAR/VAPOR/stargazers","contributors_url":"https://api.github.com/repos/NCAR/VAPOR/contributors","subscribers_url":"https://api.github.com/repos/NCAR/VAPOR/subscribers","subscription_url":"https://api.github.com/repos/NCAR/VAPOR/subscription","commits_url":"https://api.github.com/repos/NCAR/VAPOR/commits{/sha}","git_commits_url":"https://api.github.com/repos/NCAR/VAPOR/git/commits{/sha}","comments_url":"https://api.github.com/repos/NCAR/VAPOR/comments{/number}","issue_comment_url":"https://api.github.com/repos/NCAR/VAPOR/issues/comments{/number}","contents_url":"https://api.github.com/repos/NCAR/VAPOR/contents/{+path}","compare_url":"https://api.github.com/repos/NCAR/VAPOR/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NCAR/VAPOR/merges","archive_url":"https://api.github.com/repos/NCAR/VAPOR/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NCAR/VAPOR/downloads","issues_url":"https://api.github.com/repos/NCAR/VAPOR/issues{/number}","pulls_url":"https://api.github.com/repos/NCAR/VAPOR/pulls{/number}","milestones_url":"https://api.github.com/repos/NCAR/VAPOR/milestones{/number}","notifications_url":"https://api.github.com/repos/NCAR/VAPOR/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NCAR/VAPOR/labels{/name}","releases_url":"https://api.github.com/repos/NCAR/VAPOR/releases{/id}","deployments_url":"https://api.github.com/repos/NCAR/VAPOR/deployments","created_at":"2017-06-14T19:25:05Z","updated_at":"2018-08-27T21:15:46Z","pushed_at":"2018-08-27T21:15:46Z","git_url":"git://github.com/NCAR/VAPOR.git","ssh_url":"git@github.com:NCAR/VAPOR.git","clone_url":"https://github.com/NCAR/VAPOR.git","svn_url":"https://github.com/NCAR/VAPOR","homepage":"https://www.vapor.ucar.edu/","size":188178,"stargazers_count":16,"watchers_count":16,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":176,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":5,"open_issues":176,"watchers":16,"default_branch":"master"}},"base":{"label":"NCAR:master","ref":"master","sha":"b80fd88930075446657498f09ee4be245d122a0d","user":{"login":"NCAR","id":2007542,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMDc1NDI=","avatar_url":"https://avatars2.githubusercontent.com/u/2007542?v=4","gravatar_id":"","url":"https://api.github.com/users/NCAR","html_url":"https://github.com/NCAR","followers_url":"https://api.github.com/users/NCAR/followers","following_url":"https://api.github.com/users/NCAR/following{/other_user}","gists_url":"https://api.github.com/users/NCAR/gists{/gist_id}","starred_url":"https://api.github.com/users/NCAR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NCAR/subscriptions","organizations_url":"https://api.github.com/users/NCAR/orgs","repos_url":"https://api.github.com/users/NCAR/repos","events_url":"https://api.github.com/users/NCAR/events{/privacy}","received_events_url":"https://api.github.com/users/NCAR/received_events","type":"Organization","site_admin":false},"repo":{"id":94365653,"node_id":"MDEwOlJlcG9zaXRvcnk5NDM2NTY1Mw==","name":"VAPOR","full_name":"NCAR/VAPOR","owner":{"login":"NCAR","id":2007542,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMDc1NDI=","avatar_url":"https://avatars2.githubusercontent.com/u/2007542?v=4","gravatar_id":"","url":"https://api.github.com/users/NCAR","html_url":"https://github.com/NCAR","followers_url":"https://api.github.com/users/NCAR/followers","following_url":"https://api.github.com/users/NCAR/following{/other_user}","gists_url":"https://api.github.com/users/NCAR/gists{/gist_id}","starred_url":"https://api.github.com/users/NCAR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NCAR/subscriptions","organizations_url":"https://api.github.com/users/NCAR/orgs","repos_url":"https://api.github.com/users/NCAR/repos","events_url":"https://api.github.com/users/NCAR/events{/privacy}","received_events_url":"https://api.github.com/users/NCAR/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NCAR/VAPOR","description":"VAPOR is the Visualization and Analysis Platform for Ocean, Atmosphere, and Solar Researchers","fork":false,"url":"https://api.github.com/repos/NCAR/VAPOR","forks_url":"https://api.github.com/repos/NCAR/VAPOR/forks","keys_url":"https://api.github.com/repos/NCAR/VAPOR/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NCAR/VAPOR/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NCAR/VAPOR/teams","hooks_url":"https://api.github.com/repos/NCAR/VAPOR/hooks","issue_events_url":"https://api.github.com/repos/NCAR/VAPOR/issues/events{/number}","events_url":"https://api.github.com/repos/NCAR/VAPOR/events","assignees_url":"https://api.github.com/repos/NCAR/VAPOR/assignees{/user}","branches_url":"https://api.github.com/repos/NCAR/VAPOR/branches{/branch}","tags_url":"https://api.github.com/repos/NCAR/VAPOR/tags","blobs_url":"https://api.github.com/repos/NCAR/VAPOR/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NCAR/VAPOR/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NCAR/VAPOR/git/refs{/sha}","trees_url":"https://api.github.com/repos/NCAR/VAPOR/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NCAR/VAPOR/statuses/{sha}","languages_url":"https://api.github.com/repos/NCAR/VAPOR/languages","stargazers_url":"https://api.github.com/repos/NCAR/VAPOR/stargazers","contributors_url":"https://api.github.com/repos/NCAR/VAPOR/contributors","subscribers_url":"https://api.github.com/repos/NCAR/VAPOR/subscribers","subscription_url":"https://api.github.com/repos/NCAR/VAPOR/subscription","commits_url":"https://api.github.com/repos/NCAR/VAPOR/commits{/sha}","git_commits_url":"https://api.github.com/repos/NCAR/VAPOR/git/commits{/sha}","comments_url":"https://api.github.com/repos/NCAR/VAPOR/comments{/number}","issue_comment_url":"https://api.github.com/repos/NCAR/VAPOR/issues/comments{/number}","contents_url":"https://api.github.com/repos/NCAR/VAPOR/contents/{+path}","compare_url":"https://api.github.com/repos/NCAR/VAPOR/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NCAR/VAPOR/merges","archive_url":"https://api.github.com/repos/NCAR/VAPOR/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NCAR/VAPOR/downloads","issues_url":"https://api.github.com/repos/NCAR/VAPOR/issues{/number}","pulls_url":"https://api.github.com/repos/NCAR/VAPOR/pulls{/number}","milestones_url":"https://api.github.com/repos/NCAR/VAPOR/milestones{/number}","notifications_url":"https://api.github.com/repos/NCAR/VAPOR/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NCAR/VAPOR/labels{/name}","releases_url":"https://api.github.com/repos/NCAR/VAPOR/releases{/id}","deployments_url":"https://api.github.com/repos/NCAR/VAPOR/deployments","created_at":"2017-06-14T19:25:05Z","updated_at":"2018-08-27T21:15:46Z","pushed_at":"2018-08-27T21:15:46Z","git_url":"git://github.com/NCAR/VAPOR.git","ssh_url":"git@github.com:NCAR/VAPOR.git","clone_url":"https://github.com/NCAR/VAPOR.git","svn_url":"https://github.com/NCAR/VAPOR","homepage":"https://www.vapor.ucar.edu/","size":188178,"stargazers_count":16,"watchers_count":16,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":176,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":5,"open_issues":176,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NCAR/VAPOR/pulls/975"},"html":{"href":"https://github.com/NCAR/VAPOR/pull/975"},"issue":{"href":"https://api.github.com/repos/NCAR/VAPOR/issues/975"},"comments":{"href":"https://api.github.com/repos/NCAR/VAPOR/issues/975/comments"},"review_comments":{"href":"https://api.github.com/repos/NCAR/VAPOR/pulls/975/comments"},"review_comment":{"href":"https://api.github.com/repos/NCAR/VAPOR/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NCAR/VAPOR/pulls/975/commits"},"statuses":{"href":"https://api.github.com/repos/NCAR/VAPOR/statuses/04f7589668d617152e868c1031b5b7e5b4354e92"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"sgpearse"}}