{"action":"created","comment":{"url":"https://api.github.com/repos/fossasia/open-event-orga-app/pulls/comments/197888352","pull_request_review_id":131720116,"id":197888352,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5Nzg4ODM1Mg==","diff_hunk":"@@ -37,14 +37,14 @@\n     private LoginFragmentBinding binding;\n     private Validator validator;\n     private SharedViewModel sharedViewModel;\n+    private String password, email;","path":"app/src/main/java/org/fossasia/openevent/app/core/auth/login/LoginFragment.java","position":4,"original_position":4,"commit_id":"9c73fd34e2dae24da8e69ba2f555bab17a345aad","original_commit_id":"9c73fd34e2dae24da8e69ba2f555bab17a345aad","user":{"login":"codacy-bot","id":19940114,"node_id":"MDQ6VXNlcjE5OTQwMTE0","avatar_url":"https://avatars1.githubusercontent.com/u/19940114?v=4","gravatar_id":"","url":"https://api.github.com/users/codacy-bot","html_url":"https://github.com/codacy-bot","followers_url":"https://api.github.com/users/codacy-bot/followers","following_url":"https://api.github.com/users/codacy-bot/following{/other_user}","gists_url":"https://api.github.com/users/codacy-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/codacy-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codacy-bot/subscriptions","organizations_url":"https://api.github.com/users/codacy-bot/orgs","repos_url":"https://api.github.com/users/codacy-bot/repos","events_url":"https://api.github.com/users/codacy-bot/events{/privacy}","received_events_url":"https://api.github.com/users/codacy-bot/received_events","type":"User","site_admin":false},"body":"![Codacy](https://app.codacy.com/assets/images/favicon.png) Issue found: [Avoid unused private fields such as 'email'.](https://app.codacy.com/app/fossasia/open-event-orga-app/pullRequest?prid=1813227)","created_at":"2018-06-25T18:01:16Z","updated_at":"2018-06-25T18:01:17Z","html_url":"https://github.com/fossasia/open-event-orga-app/pull/1120#discussion_r197888352","pull_request_url":"https://api.github.com/repos/fossasia/open-event-orga-app/pulls/1120","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/fossasia/open-event-orga-app/pulls/comments/197888352"},"html":{"href":"https://github.com/fossasia/open-event-orga-app/pull/1120#discussion_r197888352"},"pull_request":{"href":"https://api.github.com/repos/fossasia/open-event-orga-app/pulls/1120"}}},"pull_request":{"url":"https://api.github.com/repos/fossasia/open-event-orga-app/pulls/1120","id":196663080,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2NjYzMDgw","html_url":"https://github.com/fossasia/open-event-orga-app/pull/1120","diff_url":"https://github.com/fossasia/open-event-orga-app/pull/1120.diff","patch_url":"https://github.com/fossasia/open-event-orga-app/pull/1120.patch","issue_url":"https://api.github.com/repos/fossasia/open-event-orga-app/issues/1120","number":1120,"state":"open","locked":false,"title":"[WIP]feat: Improve login functionality","user":{"login":"sridharjajoo","id":20684618,"node_id":"MDQ6VXNlcjIwNjg0NjE4","avatar_url":"https://avatars0.githubusercontent.com/u/20684618?v=4","gravatar_id":"","url":"https://api.github.com/users/sridharjajoo","html_url":"https://github.com/sridharjajoo","followers_url":"https://api.github.com/users/sridharjajoo/followers","following_url":"https://api.github.com/users/sridharjajoo/following{/other_user}","gists_url":"https://api.github.com/users/sridharjajoo/gists{/gist_id}","starred_url":"https://api.github.com/users/sridharjajoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sridharjajoo/subscriptions","organizations_url":"https://api.github.com/users/sridharjajoo/orgs","repos_url":"https://api.github.com/users/sridharjajoo/repos","events_url":"https://api.github.com/users/sridharjajoo/events{/privacy}","received_events_url":"https://api.github.com/users/sridharjajoo/received_events","type":"User","site_admin":false},"body":"Fixes #1095 \r\n\r\nChecklist:\r\n\r\n- [x] I have checked for PMD and check-style issues <!-- please add a note if a false warning could not be suppressed -->\r\n- [x] I have read the [Contribution & Best practices Guide](https://blog.fossasia.org/open-source-developer-guide-and-best-practices-at-fossasia) and my PR follows them.\r\n- [x] My branch is up-to-date with the Upstream development branch.\r\n\r\nChanges: \r\n\r\nAn EncryptionUtils.class was added which handles the encryption and decryption of user email and password. The keys for the encryption of the sensitive information are obtained from the Android Keystore.\r\nThe process of encryption is happening in the following manner:\r\n\r\n1. The string to be encrypted is passes to the encryptString( ) of EncryptionUtils from the LoginFragment.\r\n2. Here the keys from the android key-store are obtained and with the help of which the string is encrypted. \r\n3. When decryption needs to be handled, the keys from the key store are obtained which were used to encrypt the string and the encrypted string is decrypted. \r\n\r\nScreenshots for the change:\r\n![ezgif com-resize 23](https://user-images.githubusercontent.com/20684618/41763390-c23cedce-761b-11e8-94a7-0b73a3082f82.gif)\r\n","created_at":"2018-06-22T07:53:29Z","updated_at":"2018-06-25T18:01:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"637766ca5ff971ae75847dabdec7efff7c3a4aba","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/fossasia/open-event-orga-app/pulls/1120/commits","review_comments_url":"https://api.github.com/repos/fossasia/open-event-orga-app/pulls/1120/comments","review_comment_url":"https://api.github.com/repos/fossasia/open-event-orga-app/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fossasia/open-event-orga-app/issues/1120/comments","statuses_url":"https://api.github.com/repos/fossasia/open-event-orga-app/statuses/9c73fd34e2dae24da8e69ba2f555bab17a345aad","head":{"label":"sridharjajoo:improveLogin","ref":"improveLogin","sha":"9c73fd34e2dae24da8e69ba2f555bab17a345aad","user":{"login":"sridharjajoo","id":20684618,"node_id":"MDQ6VXNlcjIwNjg0NjE4","avatar_url":"https://avatars0.githubusercontent.com/u/20684618?v=4","gravatar_id":"","url":"https://api.github.com/users/sridharjajoo","html_url":"https://github.com/sridharjajoo","followers_url":"https://api.github.com/users/sridharjajoo/followers","following_url":"https://api.github.com/users/sridharjajoo/following{/other_user}","gists_url":"https://api.github.com/users/sridharjajoo/gists{/gist_id}","starred_url":"https://api.github.com/users/sridharjajoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sridharjajoo/subscriptions","organizations_url":"https://api.github.com/users/sridharjajoo/orgs","repos_url":"https://api.github.com/users/sridharjajoo/repos","events_url":"https://api.github.com/users/sridharjajoo/events{/privacy}","received_events_url":"https://api.github.com/users/sridharjajoo/received_events","type":"User","site_admin":false},"repo":{"id":125760454,"node_id":"MDEwOlJlcG9zaXRvcnkxMjU3NjA0NTQ=","name":"open-event-orga-app","full_name":"sridharjajoo/open-event-orga-app","owner":{"login":"sridharjajoo","id":20684618,"node_id":"MDQ6VXNlcjIwNjg0NjE4","avatar_url":"https://avatars0.githubusercontent.com/u/20684618?v=4","gravatar_id":"","url":"https://api.github.com/users/sridharjajoo","html_url":"https://github.com/sridharjajoo","followers_url":"https://api.github.com/users/sridharjajoo/followers","following_url":"https://api.github.com/users/sridharjajoo/following{/other_user}","gists_url":"https://api.github.com/users/sridharjajoo/gists{/gist_id}","starred_url":"https://api.github.com/users/sridharjajoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sridharjajoo/subscriptions","organizations_url":"https://api.github.com/users/sridharjajoo/orgs","repos_url":"https://api.github.com/users/sridharjajoo/repos","events_url":"https://api.github.com/users/sridharjajoo/events{/privacy}","received_events_url":"https://api.github.com/users/sridharjajoo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sridharjajoo/open-event-orga-app","description":"Open Event Mobile App for Organizers and Entry Managers https://github.com/fossasia/open-event-orga-app/raw/apk/test-app-debug.apk","fork":true,"url":"https://api.github.com/repos/sridharjajoo/open-event-orga-app","forks_url":"https://api.github.com/repos/sridharjajoo/open-event-orga-app/forks","keys_url":"https://api.github.com/repos/sridharjajoo/open-event-orga-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sridharjajoo/open-event-orga-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sridharjajoo/open-event-orga-app/teams","hooks_url":"https://api.github.com/repos/sridharjajoo/open-event-orga-app/hooks","issue_events_url":"https://api.github.com/repos/sridharjajoo/open-event-orga-app/issues/events{/number}","events_url":"https://api.github.com/repos/sridharjajoo/open-event-orga-app/events","assignees_url":"https://api.github.com/repos/sridharjajoo/open-event-orga-app/assignees{/user}","branches_url":"https://api.github.com/repos/sridharjajoo/open-event-orga-app/branches{/branch}","tags_url":"https://api.github.com/repos/sridharjajoo/open-event-orga-app/tags","blobs_url":"https://api.github.com/repos/sridharjajoo/open-event-orga-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sridharjajoo/open-event-orga-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sridharjajoo/open-event-orga-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/sridharjajoo/open-event-orga-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sridharjajoo/open-event-orga-app/statuses/{sha}","languages_url":"https://api.github.com/repos/sridharjajoo/open-event-orga-app/languages","stargazers_url":"https://api.github.com/repos/sridharjajoo/open-event-orga-app/stargazers","contributors_url":"https://api.github.com/repos/sridharjajoo/open-event-orga-app/contributors","subscribers_url":"https://api.github.com/repos/sridharjajoo/open-event-orga-app/subscribers","subscription_url":"https://api.github.com/repos/sridharjajoo/open-event-orga-app/subscription","commits_url":"https://api.github.com/repos/sridharjajoo/open-event-orga-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/sridharjajoo/open-event-orga-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/sridharjajoo/open-event-orga-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/sridharjajoo/open-event-orga-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/sridharjajoo/open-event-orga-app/contents/{+path}","compare_url":"https://api.github.com/repos/sridharjajoo/open-event-orga-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sridharjajoo/open-event-orga-app/merges","archive_url":"https://api.github.com/repos/sridharjajoo/open-event-orga-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sridharjajoo/open-event-orga-app/downloads","issues_url":"https://api.github.com/repos/sridharjajoo/open-event-orga-app/issues{/number}","pulls_url":"https://api.github.com/repos/sridharjajoo/open-event-orga-app/pulls{/number}","milestones_url":"https://api.github.com/repos/sridharjajoo/open-event-orga-app/milestones{/number}","notifications_url":"https://api.github.com/repos/sridharjajoo/open-event-orga-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sridharjajoo/open-event-orga-app/labels{/name}","releases_url":"https://api.github.com/repos/sridharjajoo/open-event-orga-app/releases{/id}","deployments_url":"https://api.github.com/repos/sridharjajoo/open-event-orga-app/deployments","created_at":"2018-03-18T19:33:17Z","updated_at":"2018-04-26T14:48:05Z","pushed_at":"2018-06-25T17:59:15Z","git_url":"git://github.com/sridharjajoo/open-event-orga-app.git","ssh_url":"git@github.com:sridharjajoo/open-event-orga-app.git","clone_url":"https://github.com/sridharjajoo/open-event-orga-app.git","svn_url":"https://github.com/sridharjajoo/open-event-orga-app","homepage":"","size":19635,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"development"}},"base":{"label":"fossasia:development","ref":"development","sha":"fc26406848c7c98ed0971ab69f44f13356c8e247","user":{"login":"fossasia","id":6295529,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyOTU1Mjk=","avatar_url":"https://avatars3.githubusercontent.com/u/6295529?v=4","gravatar_id":"","url":"https://api.github.com/users/fossasia","html_url":"https://github.com/fossasia","followers_url":"https://api.github.com/users/fossasia/followers","following_url":"https://api.github.com/users/fossasia/following{/other_user}","gists_url":"https://api.github.com/users/fossasia/gists{/gist_id}","starred_url":"https://api.github.com/users/fossasia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fossasia/subscriptions","organizations_url":"https://api.github.com/users/fossasia/orgs","repos_url":"https://api.github.com/users/fossasia/repos","events_url":"https://api.github.com/users/fossasia/events{/privacy}","received_events_url":"https://api.github.com/users/fossasia/received_events","type":"Organization","site_admin":false},"repo":{"id":65606855,"node_id":"MDEwOlJlcG9zaXRvcnk2NTYwNjg1NQ==","name":"open-event-orga-app","full_name":"fossasia/open-event-orga-app","owner":{"login":"fossasia","id":6295529,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyOTU1Mjk=","avatar_url":"https://avatars3.githubusercontent.com/u/6295529?v=4","gravatar_id":"","url":"https://api.github.com/users/fossasia","html_url":"https://github.com/fossasia","followers_url":"https://api.github.com/users/fossasia/followers","following_url":"https://api.github.com/users/fossasia/following{/other_user}","gists_url":"https://api.github.com/users/fossasia/gists{/gist_id}","starred_url":"https://api.github.com/users/fossasia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fossasia/subscriptions","organizations_url":"https://api.github.com/users/fossasia/orgs","repos_url":"https://api.github.com/users/fossasia/repos","events_url":"https://api.github.com/users/fossasia/events{/privacy}","received_events_url":"https://api.github.com/users/fossasia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fossasia/open-event-orga-app","description":"Open Event Mobile App for Organizers and Entry Managers https://github.com/fossasia/open-event-orga-app/raw/apk/test-app-debug.apk","fork":false,"url":"https://api.github.com/repos/fossasia/open-event-orga-app","forks_url":"https://api.github.com/repos/fossasia/open-event-orga-app/forks","keys_url":"https://api.github.com/repos/fossasia/open-event-orga-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fossasia/open-event-orga-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fossasia/open-event-orga-app/teams","hooks_url":"https://api.github.com/repos/fossasia/open-event-orga-app/hooks","issue_events_url":"https://api.github.com/repos/fossasia/open-event-orga-app/issues/events{/number}","events_url":"https://api.github.com/repos/fossasia/open-event-orga-app/events","assignees_url":"https://api.github.com/repos/fossasia/open-event-orga-app/assignees{/user}","branches_url":"https://api.github.com/repos/fossasia/open-event-orga-app/branches{/branch}","tags_url":"https://api.github.com/repos/fossasia/open-event-orga-app/tags","blobs_url":"https://api.github.com/repos/fossasia/open-event-orga-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fossasia/open-event-orga-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fossasia/open-event-orga-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/fossasia/open-event-orga-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fossasia/open-event-orga-app/statuses/{sha}","languages_url":"https://api.github.com/repos/fossasia/open-event-orga-app/languages","stargazers_url":"https://api.github.com/repos/fossasia/open-event-orga-app/stargazers","contributors_url":"https://api.github.com/repos/fossasia/open-event-orga-app/contributors","subscribers_url":"https://api.github.com/repos/fossasia/open-event-orga-app/subscribers","subscription_url":"https://api.github.com/repos/fossasia/open-event-orga-app/subscription","commits_url":"https://api.github.com/repos/fossasia/open-event-orga-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/fossasia/open-event-orga-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/fossasia/open-event-orga-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/fossasia/open-event-orga-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/fossasia/open-event-orga-app/contents/{+path}","compare_url":"https://api.github.com/repos/fossasia/open-event-orga-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fossasia/open-event-orga-app/merges","archive_url":"https://api.github.com/repos/fossasia/open-event-orga-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fossasia/open-event-orga-app/downloads","issues_url":"https://api.github.com/repos/fossasia/open-event-orga-app/issues{/number}","pulls_url":"https://api.github.com/repos/fossasia/open-event-orga-app/pulls{/number}","milestones_url":"https://api.github.com/repos/fossasia/open-event-orga-app/milestones{/number}","notifications_url":"https://api.github.com/repos/fossasia/open-event-orga-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fossasia/open-event-orga-app/labels{/name}","releases_url":"https://api.github.com/repos/fossasia/open-event-orga-app/releases{/id}","deployments_url":"https://api.github.com/repos/fossasia/open-event-orga-app/deployments","created_at":"2016-08-13T08:08:39Z","updated_at":"2018-06-24T18:45:45Z","pushed_at":"2018-06-25T17:59:16Z","git_url":"git://github.com/fossasia/open-event-orga-app.git","ssh_url":"git@github.com:fossasia/open-event-orga-app.git","clone_url":"https://github.com/fossasia/open-event-orga-app.git","svn_url":"https://github.com/fossasia/open-event-orga-app","homepage":"","size":20986,"stargazers_count":404,"watchers_count":404,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":128,"mirror_url":null,"archived":false,"open_issues_count":56,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":128,"open_issues":56,"watchers":404,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/fossasia/open-event-orga-app/pulls/1120"},"html":{"href":"https://github.com/fossasia/open-event-orga-app/pull/1120"},"issue":{"href":"https://api.github.com/repos/fossasia/open-event-orga-app/issues/1120"},"comments":{"href":"https://api.github.com/repos/fossasia/open-event-orga-app/issues/1120/comments"},"review_comments":{"href":"https://api.github.com/repos/fossasia/open-event-orga-app/pulls/1120/comments"},"review_comment":{"href":"https://api.github.com/repos/fossasia/open-event-orga-app/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fossasia/open-event-orga-app/pulls/1120/commits"},"statuses":{"href":"https://api.github.com/repos/fossasia/open-event-orga-app/statuses/9c73fd34e2dae24da8e69ba2f555bab17a345aad"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"codacy-bot"}}