{"push_id":2977957581,"size":5,"distinct_size":5,"ref":"refs/heads/eh/add_compiler_warnings","head":"e01bea5833ce074cd868790bc5569361ea70a997","before":"818d056579f480fa8b2528d3d9d931b69b0abdc1","commits":[{"sha":"924c566f4187cbf1fd6751a7e0a5a36b58efdae0","author":{"name":"Sylvain Laperche","email":"701d855556b86f2f79e552cf49b30b5d130ca6f0@scality.com"},"message":"remove VLA (fix `-Wvla`).\n\nVLA are not supported in C++, that's a C99 feature not a C++ one (and\neven in C, it becames optional since C11).\n\nEven if they were supported, it's not a good idea to use them\n(especially with an unbounded size such as `this->n`) this is a recipe\nfor easy stack overflows.\n\nNow, dumbly replacing VLAs by `std::vector` simply won't do (the code\nbecomes 50% slower). But, we can implement a scratch space inside the\n`gf::NF4` object that can replaces the VLAs and get a nice 10% speedup :)","distinct":true,"url":"https://api.github.com/repos/slaperche-scality/quadiron/commits/924c566f4187cbf1fd6751a7e0a5a36b58efdae0"},{"sha":"9818934e732b738ba5c6c1e6c5345eee2dce440c","author":{"name":"Sylvain Laperche","email":"701d855556b86f2f79e552cf49b30b5d130ca6f0@scality.com"},"message":"use typename instead of class\n\n`typename` is preferred in this context, and this is what we use in the\nrest of the codebase.","distinct":true,"url":"https://api.github.com/repos/slaperche-scality/quadiron/commits/9818934e732b738ba5c6c1e6c5345eee2dce440c"},{"sha":"9ce64f513d8f447474158b8ecf196145c19d32bb","author":{"name":"Sylvain Laperche","email":"701d855556b86f2f79e552cf49b30b5d130ca6f0@scality.com"},"message":"fix Doxygen documentation (flagged by `-Wdocumentation`)","distinct":true,"url":"https://api.github.com/repos/slaperche-scality/quadiron/commits/9ce64f513d8f447474158b8ecf196145c19d32bb"},{"sha":"0400da6dd3cd4b5ec723ac2f597e00f9090ea6e1","author":{"name":"Sylvain Laperche","email":"701d855556b86f2f79e552cf49b30b5d130ca6f0@gmail.com"},"message":"follow the rule of five for vec::Vector\n\nSince we have a destructor, we add:\n- a copy constructor\n- a move constructor\n- a copy assignment operator\n- a move assignment operator\n\nClang was complaining about it (`-Wdeprecated`), and rightly so!\n\n    definition of implicit copy constructor for 'Vector<unsigned int>'\n    is deprecated because it has a user-declared destructor","distinct":true,"url":"https://api.github.com/repos/slaperche-scality/quadiron/commits/0400da6dd3cd4b5ec723ac2f597e00f9090ea6e1"},{"sha":"e01bea5833ce074cd868790bc5569361ea70a997","author":{"name":"Sylvain Laperche","email":"701d855556b86f2f79e552cf49b30b5d130ca6f0@scality.com"},"message":"add more compiler warnings\n\nThis will definitely help us spot dubious code and maintain a good level\nof code quality.\n\nNext step would be to enable more lint in clang-tidy.","distinct":true,"url":"https://api.github.com/repos/slaperche-scality/quadiron/commits/e01bea5833ce074cd868790bc5569361ea70a997"}]}
{"actor":{"display_login":"slaperche-scality"}}