{"action":"created","issue":{"url":"https://api.github.com/repos/artsy/reaction/issues/1479","repository_url":"https://api.github.com/repos/artsy/reaction","labels_url":"https://api.github.com/repos/artsy/reaction/issues/1479/labels{/name}","comments_url":"https://api.github.com/repos/artsy/reaction/issues/1479/comments","events_url":"https://api.github.com/repos/artsy/reaction/issues/1479/events","html_url":"https://github.com/artsy/reaction/pull/1479","id":376883882,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3OTkzOTY0","number":1479,"title":"Add Sentry to Reaction","user":{"login":"williardx","id":4432348,"node_id":"MDQ6VXNlcjQ0MzIzNDg=","avatar_url":"https://avatars1.githubusercontent.com/u/4432348?v=4","gravatar_id":"","url":"https://api.github.com/users/williardx","html_url":"https://github.com/williardx","followers_url":"https://api.github.com/users/williardx/followers","following_url":"https://api.github.com/users/williardx/following{/other_user}","gists_url":"https://api.github.com/users/williardx/gists{/gist_id}","starred_url":"https://api.github.com/users/williardx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/williardx/subscriptions","organizations_url":"https://api.github.com/users/williardx/orgs","repos_url":"https://api.github.com/users/williardx/repos","events_url":"https://api.github.com/users/williardx/events{/privacy}","received_events_url":"https://api.github.com/users/williardx/received_events","type":"User","site_admin":false},"labels":[{"id":1025470965,"node_id":"MDU6TGFiZWwxMDI1NDcwOTY1","url":"https://api.github.com/repos/artsy/reaction/labels/Jira%20Synced","name":"Jira Synced","color":"0366d6","default":false}],"state":"open","locked":false,"assignee":{"login":"ashfurrow","id":498212,"node_id":"MDQ6VXNlcjQ5ODIxMg==","avatar_url":"https://avatars3.githubusercontent.com/u/498212?v=4","gravatar_id":"","url":"https://api.github.com/users/ashfurrow","html_url":"https://github.com/ashfurrow","followers_url":"https://api.github.com/users/ashfurrow/followers","following_url":"https://api.github.com/users/ashfurrow/following{/other_user}","gists_url":"https://api.github.com/users/ashfurrow/gists{/gist_id}","starred_url":"https://api.github.com/users/ashfurrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashfurrow/subscriptions","organizations_url":"https://api.github.com/users/ashfurrow/orgs","repos_url":"https://api.github.com/users/ashfurrow/repos","events_url":"https://api.github.com/users/ashfurrow/events{/privacy}","received_events_url":"https://api.github.com/users/ashfurrow/received_events","type":"User","site_admin":false},"assignees":[{"login":"ashfurrow","id":498212,"node_id":"MDQ6VXNlcjQ5ODIxMg==","avatar_url":"https://avatars3.githubusercontent.com/u/498212?v=4","gravatar_id":"","url":"https://api.github.com/users/ashfurrow","html_url":"https://github.com/ashfurrow","followers_url":"https://api.github.com/users/ashfurrow/followers","following_url":"https://api.github.com/users/ashfurrow/following{/other_user}","gists_url":"https://api.github.com/users/ashfurrow/gists{/gist_id}","starred_url":"https://api.github.com/users/ashfurrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashfurrow/subscriptions","organizations_url":"https://api.github.com/users/ashfurrow/orgs","repos_url":"https://api.github.com/users/ashfurrow/repos","events_url":"https://api.github.com/users/ashfurrow/events{/privacy}","received_events_url":"https://api.github.com/users/ashfurrow/received_events","type":"User","site_admin":false}],"milestone":null,"comments":11,"created_at":"2018-11-02T16:36:15Z","updated_at":"2018-11-06T01:08:16Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/artsy/reaction/pulls/1479","html_url":"https://github.com/artsy/reaction/pull/1479","diff_url":"https://github.com/artsy/reaction/pull/1479.diff","patch_url":"https://github.com/artsy/reaction/pull/1479.patch"},"body":"~WIP to rebuild commit history -- otherwise, code changes are ready for review.~\r\n\r\nAddresses [PURCHASE-570](https://artsyproduct.atlassian.net/browse/PURCHASE-570).\r\n\r\n### Problem\r\nWe want to be able to factor in client-side errors into our analysis of the buy now checkout funnel.\r\n\r\n### Solution\r\nAdd Sentry to Reaction and capture errors for all apps since currently we don't capture any errors.\r\n\r\n### What changed\r\n- Added `@sentry/browser` package\r\n- Added new `logger` that allows us to add custom behavior before calling out normal `console.*` statements. For `logger.error`, we send an error to Sentry before calling `console.error`.\r\n- Wrapped `Boot` in `ErrorBoundary` component to catch errors\r\n- Replaced `console.error` statements in Order app with `logger.error`"},"comment":{"url":"https://api.github.com/repos/artsy/reaction/issues/comments/436094483","html_url":"https://github.com/artsy/reaction/pull/1479#issuecomment-436094483","issue_url":"https://api.github.com/repos/artsy/reaction/issues/1479","id":436094483,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNjA5NDQ4Mw==","user":{"login":"mzikherman","id":1457859,"node_id":"MDQ6VXNlcjE0NTc4NTk=","avatar_url":"https://avatars2.githubusercontent.com/u/1457859?v=4","gravatar_id":"","url":"https://api.github.com/users/mzikherman","html_url":"https://github.com/mzikherman","followers_url":"https://api.github.com/users/mzikherman/followers","following_url":"https://api.github.com/users/mzikherman/following{/other_user}","gists_url":"https://api.github.com/users/mzikherman/gists{/gist_id}","starred_url":"https://api.github.com/users/mzikherman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mzikherman/subscriptions","organizations_url":"https://api.github.com/users/mzikherman/orgs","repos_url":"https://api.github.com/users/mzikherman/repos","events_url":"https://api.github.com/users/mzikherman/events{/privacy}","received_events_url":"https://api.github.com/users/mzikherman/received_events","type":"User","site_admin":false},"created_at":"2018-11-06T01:08:16Z","updated_at":"2018-11-06T01:08:16Z","author_association":"COLLABORATOR","body":"> In this case we want to be explicitly logging errors that we otherwise catch (and are client-side)-- namely, those from a failed mutation to metaphysics/exchange.\r\n\r\nOh, Sentry doesn't include client-side errors? (I thought it might)."}}
{"actor":{"display_login":"mzikherman"}}