{"action":"opened","number":763,"pull_request":{"url":"https://api.github.com/repos/open-company/open-company-web/pulls/763","id":240204475,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwMjA0NDc1","html_url":"https://github.com/open-company/open-company-web/pull/763","diff_url":"https://github.com/open-company/open-company-web/pull/763.diff","patch_url":"https://github.com/open-company/open-company-web/pull/763.patch","issue_url":"https://api.github.com/repos/open-company/open-company-web/issues/763","number":763,"state":"open","locked":false,"title":"Fix possible race-condition on add comment box","user":{"login":"bago2k4","id":642704,"node_id":"MDQ6VXNlcjY0MjcwNA==","avatar_url":"https://avatars3.githubusercontent.com/u/642704?v=4","gravatar_id":"","url":"https://api.github.com/users/bago2k4","html_url":"https://github.com/bago2k4","followers_url":"https://api.github.com/users/bago2k4/followers","following_url":"https://api.github.com/users/bago2k4/following{/other_user}","gists_url":"https://api.github.com/users/bago2k4/gists{/gist_id}","starred_url":"https://api.github.com/users/bago2k4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bago2k4/subscriptions","organizations_url":"https://api.github.com/users/bago2k4/orgs","repos_url":"https://api.github.com/users/bago2k4/repos","events_url":"https://api.github.com/users/bago2k4/events{/privacy}","received_events_url":"https://api.github.com/users/bago2k4/received_events","type":"User","site_admin":false},"body":"Sean has found himself in this situation:\r\n![carrot leadership communication for growing and distributed teams 2018-12-20 09-39-50](https://user-images.githubusercontent.com/642704/50292756-30061a80-0472-11e9-938f-a858837a9337.png)\r\n\r\nI think it can be a race condition between render cycle. If the \"add-comment\" reference is not available it can be that the `disable-add-comment-if-needed` function disable them even if the user has text typed inside the field or is typing it.\r\n\r\nThis avoid making any action if the reference is not present.\r\n\r\nTo test:\r\n- add the very first comment on a post from AP\r\n- add the very first comment on a post from full post view\r\n- remove your comment from AP\r\n- remove your comment from full post view\r\n- edit a comment from AP\r\n- edit a comment from full post view\r\n- make sure the buttons appear when you focus add comment field (both AP and post view)\r\n- make sure the comment button is enabled when you type something in the field (both AP and post view)","created_at":"2018-12-20T15:16:15Z","updated_at":"2018-12-20T15:16:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"bago2k4","id":642704,"node_id":"MDQ6VXNlcjY0MjcwNA==","avatar_url":"https://avatars3.githubusercontent.com/u/642704?v=4","gravatar_id":"","url":"https://api.github.com/users/bago2k4","html_url":"https://github.com/bago2k4","followers_url":"https://api.github.com/users/bago2k4/followers","following_url":"https://api.github.com/users/bago2k4/following{/other_user}","gists_url":"https://api.github.com/users/bago2k4/gists{/gist_id}","starred_url":"https://api.github.com/users/bago2k4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bago2k4/subscriptions","organizations_url":"https://api.github.com/users/bago2k4/orgs","repos_url":"https://api.github.com/users/bago2k4/repos","events_url":"https://api.github.com/users/bago2k4/events{/privacy}","received_events_url":"https://api.github.com/users/bago2k4/received_events","type":"User","site_admin":false},"assignees":[{"login":"bago2k4","id":642704,"node_id":"MDQ6VXNlcjY0MjcwNA==","avatar_url":"https://avatars3.githubusercontent.com/u/642704?v=4","gravatar_id":"","url":"https://api.github.com/users/bago2k4","html_url":"https://github.com/bago2k4","followers_url":"https://api.github.com/users/bago2k4/followers","following_url":"https://api.github.com/users/bago2k4/following{/other_user}","gists_url":"https://api.github.com/users/bago2k4/gists{/gist_id}","starred_url":"https://api.github.com/users/bago2k4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bago2k4/subscriptions","organizations_url":"https://api.github.com/users/bago2k4/orgs","repos_url":"https://api.github.com/users/bago2k4/repos","events_url":"https://api.github.com/users/bago2k4/events{/privacy}","received_events_url":"https://api.github.com/users/bago2k4/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":766670113,"node_id":"MDU6TGFiZWw3NjY2NzAxMTM=","url":"https://api.github.com/repos/open-company/open-company-web/labels/ready%20for%20review","name":"ready for review","color":"0e8749","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/open-company/open-company-web/pulls/763/commits","review_comments_url":"https://api.github.com/repos/open-company/open-company-web/pulls/763/comments","review_comment_url":"https://api.github.com/repos/open-company/open-company-web/pulls/comments{/number}","comments_url":"https://api.github.com/repos/open-company/open-company-web/issues/763/comments","statuses_url":"https://api.github.com/repos/open-company/open-company-web/statuses/fc8802eb7f14605835b7fc809e973e1c2fdb926e","head":{"label":"open-company:fix-add-comment","ref":"fix-add-comment","sha":"fc8802eb7f14605835b7fc809e973e1c2fdb926e","user":{"login":"open-company","id":13063090,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMDYzMDkw","avatar_url":"https://avatars3.githubusercontent.com/u/13063090?v=4","gravatar_id":"","url":"https://api.github.com/users/open-company","html_url":"https://github.com/open-company","followers_url":"https://api.github.com/users/open-company/followers","following_url":"https://api.github.com/users/open-company/following{/other_user}","gists_url":"https://api.github.com/users/open-company/gists{/gist_id}","starred_url":"https://api.github.com/users/open-company/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-company/subscriptions","organizations_url":"https://api.github.com/users/open-company/orgs","repos_url":"https://api.github.com/users/open-company/repos","events_url":"https://api.github.com/users/open-company/events{/privacy}","received_events_url":"https://api.github.com/users/open-company/received_events","type":"Organization","site_admin":false},"repo":{"id":38428276,"node_id":"MDEwOlJlcG9zaXRvcnkzODQyODI3Ng==","name":"open-company-web","full_name":"open-company/open-company-web","private":false,"owner":{"login":"open-company","id":13063090,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMDYzMDkw","avatar_url":"https://avatars3.githubusercontent.com/u/13063090?v=4","gravatar_id":"","url":"https://api.github.com/users/open-company","html_url":"https://github.com/open-company","followers_url":"https://api.github.com/users/open-company/followers","following_url":"https://api.github.com/users/open-company/following{/other_user}","gists_url":"https://api.github.com/users/open-company/gists{/gist_id}","starred_url":"https://api.github.com/users/open-company/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-company/subscriptions","organizations_url":"https://api.github.com/users/open-company/orgs","repos_url":"https://api.github.com/users/open-company/repos","events_url":"https://api.github.com/users/open-company/events{/privacy}","received_events_url":"https://api.github.com/users/open-company/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/open-company/open-company-web","description":"OpenCompany Web Application - Carrot web UI","fork":false,"url":"https://api.github.com/repos/open-company/open-company-web","forks_url":"https://api.github.com/repos/open-company/open-company-web/forks","keys_url":"https://api.github.com/repos/open-company/open-company-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/open-company/open-company-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/open-company/open-company-web/teams","hooks_url":"https://api.github.com/repos/open-company/open-company-web/hooks","issue_events_url":"https://api.github.com/repos/open-company/open-company-web/issues/events{/number}","events_url":"https://api.github.com/repos/open-company/open-company-web/events","assignees_url":"https://api.github.com/repos/open-company/open-company-web/assignees{/user}","branches_url":"https://api.github.com/repos/open-company/open-company-web/branches{/branch}","tags_url":"https://api.github.com/repos/open-company/open-company-web/tags","blobs_url":"https://api.github.com/repos/open-company/open-company-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/open-company/open-company-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/open-company/open-company-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/open-company/open-company-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/open-company/open-company-web/statuses/{sha}","languages_url":"https://api.github.com/repos/open-company/open-company-web/languages","stargazers_url":"https://api.github.com/repos/open-company/open-company-web/stargazers","contributors_url":"https://api.github.com/repos/open-company/open-company-web/contributors","subscribers_url":"https://api.github.com/repos/open-company/open-company-web/subscribers","subscription_url":"https://api.github.com/repos/open-company/open-company-web/subscription","commits_url":"https://api.github.com/repos/open-company/open-company-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/open-company/open-company-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/open-company/open-company-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/open-company/open-company-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/open-company/open-company-web/contents/{+path}","compare_url":"https://api.github.com/repos/open-company/open-company-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/open-company/open-company-web/merges","archive_url":"https://api.github.com/repos/open-company/open-company-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/open-company/open-company-web/downloads","issues_url":"https://api.github.com/repos/open-company/open-company-web/issues{/number}","pulls_url":"https://api.github.com/repos/open-company/open-company-web/pulls{/number}","milestones_url":"https://api.github.com/repos/open-company/open-company-web/milestones{/number}","notifications_url":"https://api.github.com/repos/open-company/open-company-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/open-company/open-company-web/labels{/name}","releases_url":"https://api.github.com/repos/open-company/open-company-web/releases{/id}","deployments_url":"https://api.github.com/repos/open-company/open-company-web/deployments","created_at":"2015-07-02T11:10:09Z","updated_at":"2018-12-20T12:59:18Z","pushed_at":"2018-12-20T15:06:04Z","git_url":"git://github.com/open-company/open-company-web.git","ssh_url":"git@github.com:open-company/open-company-web.git","clone_url":"https://github.com/open-company/open-company-web.git","svn_url":"https://github.com/open-company/open-company-web","homepage":"https://github.com/open-company","size":142229,"stargazers_count":31,"watchers_count":31,"language":"Clojure","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":2,"watchers":31,"default_branch":"mainline"}},"base":{"label":"open-company:mainline","ref":"mainline","sha":"201da0e807d1bcd6abf568f6c5360ae7360f5da0","user":{"login":"open-company","id":13063090,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMDYzMDkw","avatar_url":"https://avatars3.githubusercontent.com/u/13063090?v=4","gravatar_id":"","url":"https://api.github.com/users/open-company","html_url":"https://github.com/open-company","followers_url":"https://api.github.com/users/open-company/followers","following_url":"https://api.github.com/users/open-company/following{/other_user}","gists_url":"https://api.github.com/users/open-company/gists{/gist_id}","starred_url":"https://api.github.com/users/open-company/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-company/subscriptions","organizations_url":"https://api.github.com/users/open-company/orgs","repos_url":"https://api.github.com/users/open-company/repos","events_url":"https://api.github.com/users/open-company/events{/privacy}","received_events_url":"https://api.github.com/users/open-company/received_events","type":"Organization","site_admin":false},"repo":{"id":38428276,"node_id":"MDEwOlJlcG9zaXRvcnkzODQyODI3Ng==","name":"open-company-web","full_name":"open-company/open-company-web","private":false,"owner":{"login":"open-company","id":13063090,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMDYzMDkw","avatar_url":"https://avatars3.githubusercontent.com/u/13063090?v=4","gravatar_id":"","url":"https://api.github.com/users/open-company","html_url":"https://github.com/open-company","followers_url":"https://api.github.com/users/open-company/followers","following_url":"https://api.github.com/users/open-company/following{/other_user}","gists_url":"https://api.github.com/users/open-company/gists{/gist_id}","starred_url":"https://api.github.com/users/open-company/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-company/subscriptions","organizations_url":"https://api.github.com/users/open-company/orgs","repos_url":"https://api.github.com/users/open-company/repos","events_url":"https://api.github.com/users/open-company/events{/privacy}","received_events_url":"https://api.github.com/users/open-company/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/open-company/open-company-web","description":"OpenCompany Web Application - Carrot web UI","fork":false,"url":"https://api.github.com/repos/open-company/open-company-web","forks_url":"https://api.github.com/repos/open-company/open-company-web/forks","keys_url":"https://api.github.com/repos/open-company/open-company-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/open-company/open-company-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/open-company/open-company-web/teams","hooks_url":"https://api.github.com/repos/open-company/open-company-web/hooks","issue_events_url":"https://api.github.com/repos/open-company/open-company-web/issues/events{/number}","events_url":"https://api.github.com/repos/open-company/open-company-web/events","assignees_url":"https://api.github.com/repos/open-company/open-company-web/assignees{/user}","branches_url":"https://api.github.com/repos/open-company/open-company-web/branches{/branch}","tags_url":"https://api.github.com/repos/open-company/open-company-web/tags","blobs_url":"https://api.github.com/repos/open-company/open-company-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/open-company/open-company-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/open-company/open-company-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/open-company/open-company-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/open-company/open-company-web/statuses/{sha}","languages_url":"https://api.github.com/repos/open-company/open-company-web/languages","stargazers_url":"https://api.github.com/repos/open-company/open-company-web/stargazers","contributors_url":"https://api.github.com/repos/open-company/open-company-web/contributors","subscribers_url":"https://api.github.com/repos/open-company/open-company-web/subscribers","subscription_url":"https://api.github.com/repos/open-company/open-company-web/subscription","commits_url":"https://api.github.com/repos/open-company/open-company-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/open-company/open-company-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/open-company/open-company-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/open-company/open-company-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/open-company/open-company-web/contents/{+path}","compare_url":"https://api.github.com/repos/open-company/open-company-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/open-company/open-company-web/merges","archive_url":"https://api.github.com/repos/open-company/open-company-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/open-company/open-company-web/downloads","issues_url":"https://api.github.com/repos/open-company/open-company-web/issues{/number}","pulls_url":"https://api.github.com/repos/open-company/open-company-web/pulls{/number}","milestones_url":"https://api.github.com/repos/open-company/open-company-web/milestones{/number}","notifications_url":"https://api.github.com/repos/open-company/open-company-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/open-company/open-company-web/labels{/name}","releases_url":"https://api.github.com/repos/open-company/open-company-web/releases{/id}","deployments_url":"https://api.github.com/repos/open-company/open-company-web/deployments","created_at":"2015-07-02T11:10:09Z","updated_at":"2018-12-20T12:59:18Z","pushed_at":"2018-12-20T15:06:04Z","git_url":"git://github.com/open-company/open-company-web.git","ssh_url":"git@github.com:open-company/open-company-web.git","clone_url":"https://github.com/open-company/open-company-web.git","svn_url":"https://github.com/open-company/open-company-web","homepage":"https://github.com/open-company","size":142229,"stargazers_count":31,"watchers_count":31,"language":"Clojure","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":2,"watchers":31,"default_branch":"mainline"}},"_links":{"self":{"href":"https://api.github.com/repos/open-company/open-company-web/pulls/763"},"html":{"href":"https://github.com/open-company/open-company-web/pull/763"},"issue":{"href":"https://api.github.com/repos/open-company/open-company-web/issues/763"},"comments":{"href":"https://api.github.com/repos/open-company/open-company-web/issues/763/comments"},"review_comments":{"href":"https://api.github.com/repos/open-company/open-company-web/pulls/763/comments"},"review_comment":{"href":"https://api.github.com/repos/open-company/open-company-web/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/open-company/open-company-web/pulls/763/commits"},"statuses":{"href":"https://api.github.com/repos/open-company/open-company-web/statuses/fc8802eb7f14605835b7fc809e973e1c2fdb926e"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":8,"deletions":8,"changed_files":1}}
{"actor":{"display_login":"bago2k4"}}