{"action":"created","comment":{"url":"https://api.github.com/repos/knative/serving/pulls/comments/212795997","pull_request_review_id":149507525,"id":212795997,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjc5NTk5Nw==","diff_hunk":"@@ -40,7 +40,9 @@ const (\n // for the container image missing scenario.\n \n func TestContainerErrorMsg(t *testing.T) {\n-\t//t.Skip(\"Skipping until https://github.com/knative/serving/issues/1240 is closed\")\n+\tif strings.HasSuffix(strings.Split(test.Flags.DockerRepo, \"/\")[0], \".local\") {","path":"test/e2e/errorcondition_test.go","position":5,"original_position":5,"commit_id":"07934e620a7874f794d319d5bcdafc1608454877","original_commit_id":"30d4e28f5f79efceac1fe61012733f0053bc4f5e","user":{"login":"markusthoemmes","id":1289147,"node_id":"MDQ6VXNlcjEyODkxNDc=","avatar_url":"https://avatars3.githubusercontent.com/u/1289147?v=4","gravatar_id":"","url":"https://api.github.com/users/markusthoemmes","html_url":"https://github.com/markusthoemmes","followers_url":"https://api.github.com/users/markusthoemmes/followers","following_url":"https://api.github.com/users/markusthoemmes/following{/other_user}","gists_url":"https://api.github.com/users/markusthoemmes/gists{/gist_id}","starred_url":"https://api.github.com/users/markusthoemmes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markusthoemmes/subscriptions","organizations_url":"https://api.github.com/users/markusthoemmes/orgs","repos_url":"https://api.github.com/users/markusthoemmes/repos","events_url":"https://api.github.com/users/markusthoemmes/events{/privacy}","received_events_url":"https://api.github.com/users/markusthoemmes/received_events","type":"User","site_admin":false},"body":"Thanks for the pointer. Fine to keep it as is of course.","created_at":"2018-08-25T11:08:20Z","updated_at":"2018-08-25T11:08:21Z","html_url":"https://github.com/knative/serving/pull/1840#discussion_r212795997","pull_request_url":"https://api.github.com/repos/knative/serving/pulls/1840","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/knative/serving/pulls/comments/212795997"},"html":{"href":"https://github.com/knative/serving/pull/1840#discussion_r212795997"},"pull_request":{"href":"https://api.github.com/repos/knative/serving/pulls/1840"}},"in_reply_to_id":212696475},"pull_request":{"url":"https://api.github.com/repos/knative/serving/pulls/1840","id":207728858,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3NzI4ODU4","html_url":"https://github.com/knative/serving/pull/1840","diff_url":"https://github.com/knative/serving/pull/1840.diff","patch_url":"https://github.com/knative/serving/pull/1840.patch","issue_url":"https://api.github.com/repos/knative/serving/issues/1840","number":1840,"state":"closed","locked":false,"title":"Fix e2e/conformance tests on minikube","user":{"login":"jcrossley3","id":9213,"node_id":"MDQ6VXNlcjkyMTM=","avatar_url":"https://avatars2.githubusercontent.com/u/9213?v=4","gravatar_id":"","url":"https://api.github.com/users/jcrossley3","html_url":"https://github.com/jcrossley3","followers_url":"https://api.github.com/users/jcrossley3/followers","following_url":"https://api.github.com/users/jcrossley3/following{/other_user}","gists_url":"https://api.github.com/users/jcrossley3/gists{/gist_id}","starred_url":"https://api.github.com/users/jcrossley3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcrossley3/subscriptions","organizations_url":"https://api.github.com/users/jcrossley3/orgs","repos_url":"https://api.github.com/users/jcrossley3/repos","events_url":"https://api.github.com/users/jcrossley3/events{/privacy}","received_events_url":"https://api.github.com/users/jcrossley3/received_events","type":"User","site_admin":false},"body":"Fixes #609 \r\n\r\n## Proposed Changes\r\n\r\n  * Provide the ability to specify a docker tag for the test images\r\n  * Document how to configure support for `LoadBalancer` type Services in Minikube\r\n \r\nThat support amounts to two commands:\r\n```\r\nsudo ip route add $(cat ~/.minikube/profiles/minikube/config.json | jq -r \".KubernetesConfig.ServiceCIDR\") via $(minikube ip)\r\nkubectl run minikube-lb-patch --replicas=1 --image=elsonrodriguez/minikube-lb-patch:0.1 --namespace=kube-system\r\n\r\n```\r\nAs odious as those might be, I would argue that they simplify the knative-on-minikube user experience considerably:\r\n\r\n- no special `s/LoadBalancer/NodePort/` install instructions\r\n- no special minikube-only way of obtaining the `$SERVICE_IP` in the samples, including those from 3rd parties porting their platform to knative\r\n- no need to configure a docker registry in minikube\r\n- and most importantly... all the tests pass.\r\n\r\nAnd since minikube considers its lack of `LoadBalancer` support to be a [bug](https://github.com/kubernetes/minikube/issues/2834) anyway, it's hopefully only a temporary hack.\r\n","created_at":"2018-08-10T21:42:05Z","updated_at":"2018-08-25T11:08:21Z","closed_at":"2018-08-24T22:05:00Z","merged_at":"2018-08-24T22:05:00Z","merge_commit_sha":"ff7c297bd36e1a9be96a13abc3353c290a46b44f","assignee":{"login":"jonjohnsonjr","id":17863526,"node_id":"MDQ6VXNlcjE3ODYzNTI2","avatar_url":"https://avatars1.githubusercontent.com/u/17863526?v=4","gravatar_id":"","url":"https://api.github.com/users/jonjohnsonjr","html_url":"https://github.com/jonjohnsonjr","followers_url":"https://api.github.com/users/jonjohnsonjr/followers","following_url":"https://api.github.com/users/jonjohnsonjr/following{/other_user}","gists_url":"https://api.github.com/users/jonjohnsonjr/gists{/gist_id}","starred_url":"https://api.github.com/users/jonjohnsonjr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonjohnsonjr/subscriptions","organizations_url":"https://api.github.com/users/jonjohnsonjr/orgs","repos_url":"https://api.github.com/users/jonjohnsonjr/repos","events_url":"https://api.github.com/users/jonjohnsonjr/events{/privacy}","received_events_url":"https://api.github.com/users/jonjohnsonjr/received_events","type":"User","site_admin":false},"assignees":[{"login":"jonjohnsonjr","id":17863526,"node_id":"MDQ6VXNlcjE3ODYzNTI2","avatar_url":"https://avatars1.githubusercontent.com/u/17863526?v=4","gravatar_id":"","url":"https://api.github.com/users/jonjohnsonjr","html_url":"https://github.com/jonjohnsonjr","followers_url":"https://api.github.com/users/jonjohnsonjr/followers","following_url":"https://api.github.com/users/jonjohnsonjr/following{/other_user}","gists_url":"https://api.github.com/users/jonjohnsonjr/gists{/gist_id}","starred_url":"https://api.github.com/users/jonjohnsonjr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonjohnsonjr/subscriptions","organizations_url":"https://api.github.com/users/jonjohnsonjr/orgs","repos_url":"https://api.github.com/users/jonjohnsonjr/repos","events_url":"https://api.github.com/users/jonjohnsonjr/events{/privacy}","received_events_url":"https://api.github.com/users/jonjohnsonjr/received_events","type":"User","site_admin":false},{"login":"adrcunha","id":35786489,"node_id":"MDQ6VXNlcjM1Nzg2NDg5","avatar_url":"https://avatars3.githubusercontent.com/u/35786489?v=4","gravatar_id":"","url":"https://api.github.com/users/adrcunha","html_url":"https://github.com/adrcunha","followers_url":"https://api.github.com/users/adrcunha/followers","following_url":"https://api.github.com/users/adrcunha/following{/other_user}","gists_url":"https://api.github.com/users/adrcunha/gists{/gist_id}","starred_url":"https://api.github.com/users/adrcunha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrcunha/subscriptions","organizations_url":"https://api.github.com/users/adrcunha/orgs","repos_url":"https://api.github.com/users/adrcunha/repos","events_url":"https://api.github.com/users/adrcunha/events{/privacy}","received_events_url":"https://api.github.com/users/adrcunha/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"srinivashegde86","id":2238582,"node_id":"MDQ6VXNlcjIyMzg1ODI=","avatar_url":"https://avatars1.githubusercontent.com/u/2238582?v=4","gravatar_id":"","url":"https://api.github.com/users/srinivashegde86","html_url":"https://github.com/srinivashegde86","followers_url":"https://api.github.com/users/srinivashegde86/followers","following_url":"https://api.github.com/users/srinivashegde86/following{/other_user}","gists_url":"https://api.github.com/users/srinivashegde86/gists{/gist_id}","starred_url":"https://api.github.com/users/srinivashegde86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srinivashegde86/subscriptions","organizations_url":"https://api.github.com/users/srinivashegde86/orgs","repos_url":"https://api.github.com/users/srinivashegde86/repos","events_url":"https://api.github.com/users/srinivashegde86/events{/privacy}","received_events_url":"https://api.github.com/users/srinivashegde86/received_events","type":"User","site_admin":false},{"login":"vaikas-google","id":11279988,"node_id":"MDQ6VXNlcjExMjc5OTg4","avatar_url":"https://avatars3.githubusercontent.com/u/11279988?v=4","gravatar_id":"","url":"https://api.github.com/users/vaikas-google","html_url":"https://github.com/vaikas-google","followers_url":"https://api.github.com/users/vaikas-google/followers","following_url":"https://api.github.com/users/vaikas-google/following{/other_user}","gists_url":"https://api.github.com/users/vaikas-google/gists{/gist_id}","starred_url":"https://api.github.com/users/vaikas-google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vaikas-google/subscriptions","organizations_url":"https://api.github.com/users/vaikas-google/orgs","repos_url":"https://api.github.com/users/vaikas-google/repos","events_url":"https://api.github.com/users/vaikas-google/events{/privacy}","received_events_url":"https://api.github.com/users/vaikas-google/received_events","type":"User","site_admin":false},{"login":"jessiezcc","id":37942702,"node_id":"MDQ6VXNlcjM3OTQyNzAy","avatar_url":"https://avatars2.githubusercontent.com/u/37942702?v=4","gravatar_id":"","url":"https://api.github.com/users/jessiezcc","html_url":"https://github.com/jessiezcc","followers_url":"https://api.github.com/users/jessiezcc/followers","following_url":"https://api.github.com/users/jessiezcc/following{/other_user}","gists_url":"https://api.github.com/users/jessiezcc/gists{/gist_id}","starred_url":"https://api.github.com/users/jessiezcc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jessiezcc/subscriptions","organizations_url":"https://api.github.com/users/jessiezcc/orgs","repos_url":"https://api.github.com/users/jessiezcc/repos","events_url":"https://api.github.com/users/jessiezcc/events{/privacy}","received_events_url":"https://api.github.com/users/jessiezcc/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":873831452,"node_id":"MDU6TGFiZWw4NzM4MzE0NTI=","url":"https://api.github.com/repos/knative/serving/labels/approved","name":"approved","color":"ededed","default":false},{"id":864751607,"node_id":"MDU6TGFiZWw4NjQ3NTE2MDc=","url":"https://api.github.com/repos/knative/serving/labels/lgtm","name":"lgtm","color":"ededed","default":false},{"id":859757660,"node_id":"MDU6TGFiZWw4NTk3NTc2NjA=","url":"https://api.github.com/repos/knative/serving/labels/size/L","name":"size/L","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/knative/serving/pulls/1840/commits","review_comments_url":"https://api.github.com/repos/knative/serving/pulls/1840/comments","review_comment_url":"https://api.github.com/repos/knative/serving/pulls/comments{/number}","comments_url":"https://api.github.com/repos/knative/serving/issues/1840/comments","statuses_url":"https://api.github.com/repos/knative/serving/statuses/07934e620a7874f794d319d5bcdafc1608454877","head":{"label":"jcrossley3:fix-e2e-on-minikube","ref":"fix-e2e-on-minikube","sha":"07934e620a7874f794d319d5bcdafc1608454877","user":{"login":"jcrossley3","id":9213,"node_id":"MDQ6VXNlcjkyMTM=","avatar_url":"https://avatars2.githubusercontent.com/u/9213?v=4","gravatar_id":"","url":"https://api.github.com/users/jcrossley3","html_url":"https://github.com/jcrossley3","followers_url":"https://api.github.com/users/jcrossley3/followers","following_url":"https://api.github.com/users/jcrossley3/following{/other_user}","gists_url":"https://api.github.com/users/jcrossley3/gists{/gist_id}","starred_url":"https://api.github.com/users/jcrossley3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcrossley3/subscriptions","organizations_url":"https://api.github.com/users/jcrossley3/orgs","repos_url":"https://api.github.com/users/jcrossley3/repos","events_url":"https://api.github.com/users/jcrossley3/events{/privacy}","received_events_url":"https://api.github.com/users/jcrossley3/received_events","type":"User","site_admin":false},"repo":{"id":143469325,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM0NjkzMjU=","name":"serving","full_name":"jcrossley3/serving","owner":{"login":"jcrossley3","id":9213,"node_id":"MDQ6VXNlcjkyMTM=","avatar_url":"https://avatars2.githubusercontent.com/u/9213?v=4","gravatar_id":"","url":"https://api.github.com/users/jcrossley3","html_url":"https://github.com/jcrossley3","followers_url":"https://api.github.com/users/jcrossley3/followers","following_url":"https://api.github.com/users/jcrossley3/following{/other_user}","gists_url":"https://api.github.com/users/jcrossley3/gists{/gist_id}","starred_url":"https://api.github.com/users/jcrossley3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcrossley3/subscriptions","organizations_url":"https://api.github.com/users/jcrossley3/orgs","repos_url":"https://api.github.com/users/jcrossley3/repos","events_url":"https://api.github.com/users/jcrossley3/events{/privacy}","received_events_url":"https://api.github.com/users/jcrossley3/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jcrossley3/serving","description":"Kubernetes-based, scale-to-zero, request-driven compute","fork":true,"url":"https://api.github.com/repos/jcrossley3/serving","forks_url":"https://api.github.com/repos/jcrossley3/serving/forks","keys_url":"https://api.github.com/repos/jcrossley3/serving/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jcrossley3/serving/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jcrossley3/serving/teams","hooks_url":"https://api.github.com/repos/jcrossley3/serving/hooks","issue_events_url":"https://api.github.com/repos/jcrossley3/serving/issues/events{/number}","events_url":"https://api.github.com/repos/jcrossley3/serving/events","assignees_url":"https://api.github.com/repos/jcrossley3/serving/assignees{/user}","branches_url":"https://api.github.com/repos/jcrossley3/serving/branches{/branch}","tags_url":"https://api.github.com/repos/jcrossley3/serving/tags","blobs_url":"https://api.github.com/repos/jcrossley3/serving/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jcrossley3/serving/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jcrossley3/serving/git/refs{/sha}","trees_url":"https://api.github.com/repos/jcrossley3/serving/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jcrossley3/serving/statuses/{sha}","languages_url":"https://api.github.com/repos/jcrossley3/serving/languages","stargazers_url":"https://api.github.com/repos/jcrossley3/serving/stargazers","contributors_url":"https://api.github.com/repos/jcrossley3/serving/contributors","subscribers_url":"https://api.github.com/repos/jcrossley3/serving/subscribers","subscription_url":"https://api.github.com/repos/jcrossley3/serving/subscription","commits_url":"https://api.github.com/repos/jcrossley3/serving/commits{/sha}","git_commits_url":"https://api.github.com/repos/jcrossley3/serving/git/commits{/sha}","comments_url":"https://api.github.com/repos/jcrossley3/serving/comments{/number}","issue_comment_url":"https://api.github.com/repos/jcrossley3/serving/issues/comments{/number}","contents_url":"https://api.github.com/repos/jcrossley3/serving/contents/{+path}","compare_url":"https://api.github.com/repos/jcrossley3/serving/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jcrossley3/serving/merges","archive_url":"https://api.github.com/repos/jcrossley3/serving/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jcrossley3/serving/downloads","issues_url":"https://api.github.com/repos/jcrossley3/serving/issues{/number}","pulls_url":"https://api.github.com/repos/jcrossley3/serving/pulls{/number}","milestones_url":"https://api.github.com/repos/jcrossley3/serving/milestones{/number}","notifications_url":"https://api.github.com/repos/jcrossley3/serving/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jcrossley3/serving/labels{/name}","releases_url":"https://api.github.com/repos/jcrossley3/serving/releases{/id}","deployments_url":"https://api.github.com/repos/jcrossley3/serving/deployments","created_at":"2018-08-03T20:11:40Z","updated_at":"2018-08-06T16:55:11Z","pushed_at":"2018-08-24T21:43:24Z","git_url":"git://github.com/jcrossley3/serving.git","ssh_url":"git@github.com:jcrossley3/serving.git","clone_url":"https://github.com/jcrossley3/serving.git","svn_url":"https://github.com/jcrossley3/serving","homepage":"","size":21695,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"knative:master","ref":"master","sha":"a07eff3a2267fc7b9b997424ae8ef2d0e126c82d","user":{"login":"knative","id":35583233,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NTgzMjMz","avatar_url":"https://avatars2.githubusercontent.com/u/35583233?v=4","gravatar_id":"","url":"https://api.github.com/users/knative","html_url":"https://github.com/knative","followers_url":"https://api.github.com/users/knative/followers","following_url":"https://api.github.com/users/knative/following{/other_user}","gists_url":"https://api.github.com/users/knative/gists{/gist_id}","starred_url":"https://api.github.com/users/knative/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knative/subscriptions","organizations_url":"https://api.github.com/users/knative/orgs","repos_url":"https://api.github.com/users/knative/repos","events_url":"https://api.github.com/users/knative/events{/privacy}","received_events_url":"https://api.github.com/users/knative/received_events","type":"Organization","site_admin":false},"repo":{"id":118828329,"node_id":"MDEwOlJlcG9zaXRvcnkxMTg4MjgzMjk=","name":"serving","full_name":"knative/serving","owner":{"login":"knative","id":35583233,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NTgzMjMz","avatar_url":"https://avatars2.githubusercontent.com/u/35583233?v=4","gravatar_id":"","url":"https://api.github.com/users/knative","html_url":"https://github.com/knative","followers_url":"https://api.github.com/users/knative/followers","following_url":"https://api.github.com/users/knative/following{/other_user}","gists_url":"https://api.github.com/users/knative/gists{/gist_id}","starred_url":"https://api.github.com/users/knative/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knative/subscriptions","organizations_url":"https://api.github.com/users/knative/orgs","repos_url":"https://api.github.com/users/knative/repos","events_url":"https://api.github.com/users/knative/events{/privacy}","received_events_url":"https://api.github.com/users/knative/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/knative/serving","description":"Kubernetes-based, scale-to-zero, request-driven compute","fork":false,"url":"https://api.github.com/repos/knative/serving","forks_url":"https://api.github.com/repos/knative/serving/forks","keys_url":"https://api.github.com/repos/knative/serving/keys{/key_id}","collaborators_url":"https://api.github.com/repos/knative/serving/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/knative/serving/teams","hooks_url":"https://api.github.com/repos/knative/serving/hooks","issue_events_url":"https://api.github.com/repos/knative/serving/issues/events{/number}","events_url":"https://api.github.com/repos/knative/serving/events","assignees_url":"https://api.github.com/repos/knative/serving/assignees{/user}","branches_url":"https://api.github.com/repos/knative/serving/branches{/branch}","tags_url":"https://api.github.com/repos/knative/serving/tags","blobs_url":"https://api.github.com/repos/knative/serving/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/knative/serving/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/knative/serving/git/refs{/sha}","trees_url":"https://api.github.com/repos/knative/serving/git/trees{/sha}","statuses_url":"https://api.github.com/repos/knative/serving/statuses/{sha}","languages_url":"https://api.github.com/repos/knative/serving/languages","stargazers_url":"https://api.github.com/repos/knative/serving/stargazers","contributors_url":"https://api.github.com/repos/knative/serving/contributors","subscribers_url":"https://api.github.com/repos/knative/serving/subscribers","subscription_url":"https://api.github.com/repos/knative/serving/subscription","commits_url":"https://api.github.com/repos/knative/serving/commits{/sha}","git_commits_url":"https://api.github.com/repos/knative/serving/git/commits{/sha}","comments_url":"https://api.github.com/repos/knative/serving/comments{/number}","issue_comment_url":"https://api.github.com/repos/knative/serving/issues/comments{/number}","contents_url":"https://api.github.com/repos/knative/serving/contents/{+path}","compare_url":"https://api.github.com/repos/knative/serving/compare/{base}...{head}","merges_url":"https://api.github.com/repos/knative/serving/merges","archive_url":"https://api.github.com/repos/knative/serving/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/knative/serving/downloads","issues_url":"https://api.github.com/repos/knative/serving/issues{/number}","pulls_url":"https://api.github.com/repos/knative/serving/pulls{/number}","milestones_url":"https://api.github.com/repos/knative/serving/milestones{/number}","notifications_url":"https://api.github.com/repos/knative/serving/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/knative/serving/labels{/name}","releases_url":"https://api.github.com/repos/knative/serving/releases{/id}","deployments_url":"https://api.github.com/repos/knative/serving/deployments","created_at":"2018-01-24T22:07:44Z","updated_at":"2018-08-25T03:13:10Z","pushed_at":"2018-08-24T23:30:57Z","git_url":"git://github.com/knative/serving.git","ssh_url":"git@github.com:knative/serving.git","clone_url":"https://github.com/knative/serving.git","svn_url":"https://github.com/knative/serving","homepage":"","size":21678,"stargazers_count":651,"watchers_count":651,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":92,"mirror_url":null,"archived":false,"open_issues_count":322,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":92,"open_issues":322,"watchers":651,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/knative/serving/pulls/1840"},"html":{"href":"https://github.com/knative/serving/pull/1840"},"issue":{"href":"https://api.github.com/repos/knative/serving/issues/1840"},"comments":{"href":"https://api.github.com/repos/knative/serving/issues/1840/comments"},"review_comments":{"href":"https://api.github.com/repos/knative/serving/pulls/1840/comments"},"review_comment":{"href":"https://api.github.com/repos/knative/serving/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/knative/serving/pulls/1840/commits"},"statuses":{"href":"https://api.github.com/repos/knative/serving/statuses/07934e620a7874f794d319d5bcdafc1608454877"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"markusthoemmes"}}