{"action":"created","issue":{"url":"https://api.github.com/repos/beefproject/beef/issues/1515","repository_url":"https://api.github.com/repos/beefproject/beef","labels_url":"https://api.github.com/repos/beefproject/beef/issues/1515/labels{/name}","comments_url":"https://api.github.com/repos/beefproject/beef/issues/1515/comments","events_url":"https://api.github.com/repos/beefproject/beef/issues/1515/events","html_url":"https://github.com/beefproject/beef/pull/1515","id":300861782,"number":1515,"title":"Minor upgrades and fixes","user":{"login":"amadeus777za","id":36609777,"avatar_url":"https://avatars1.githubusercontent.com/u/36609777?v=4","gravatar_id":"","url":"https://api.github.com/users/amadeus777za","html_url":"https://github.com/amadeus777za","followers_url":"https://api.github.com/users/amadeus777za/followers","following_url":"https://api.github.com/users/amadeus777za/following{/other_user}","gists_url":"https://api.github.com/users/amadeus777za/gists{/gist_id}","starred_url":"https://api.github.com/users/amadeus777za/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amadeus777za/subscriptions","organizations_url":"https://api.github.com/users/amadeus777za/orgs","repos_url":"https://api.github.com/users/amadeus777za/repos","events_url":"https://api.github.com/users/amadeus777za/events{/privacy}","received_events_url":"https://api.github.com/users/amadeus777za/received_events","type":"User","site_admin":false},"labels":[{"id":198840,"url":"https://api.github.com/repos/beefproject/beef/labels/Maintainability","name":"Maintainability","color":"d4c5f9","default":false}],"state":"closed","locked":false,"assignee":{"login":"bcoles","id":434827,"avatar_url":"https://avatars2.githubusercontent.com/u/434827?v=4","gravatar_id":"","url":"https://api.github.com/users/bcoles","html_url":"https://github.com/bcoles","followers_url":"https://api.github.com/users/bcoles/followers","following_url":"https://api.github.com/users/bcoles/following{/other_user}","gists_url":"https://api.github.com/users/bcoles/gists{/gist_id}","starred_url":"https://api.github.com/users/bcoles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcoles/subscriptions","organizations_url":"https://api.github.com/users/bcoles/orgs","repos_url":"https://api.github.com/users/bcoles/repos","events_url":"https://api.github.com/users/bcoles/events{/privacy}","received_events_url":"https://api.github.com/users/bcoles/received_events","type":"User","site_admin":false},"assignees":[{"login":"bcoles","id":434827,"avatar_url":"https://avatars2.githubusercontent.com/u/434827?v=4","gravatar_id":"","url":"https://api.github.com/users/bcoles","html_url":"https://github.com/bcoles","followers_url":"https://api.github.com/users/bcoles/followers","following_url":"https://api.github.com/users/bcoles/following{/other_user}","gists_url":"https://api.github.com/users/bcoles/gists{/gist_id}","starred_url":"https://api.github.com/users/bcoles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcoles/subscriptions","organizations_url":"https://api.github.com/users/bcoles/orgs","repos_url":"https://api.github.com/users/bcoles/repos","events_url":"https://api.github.com/users/bcoles/events{/privacy}","received_events_url":"https://api.github.com/users/bcoles/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2018-02-28T01:56:11Z","updated_at":"2018-03-11T23:39:33Z","closed_at":"2018-03-09T06:43:37Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/beefproject/beef/pulls/1515","html_url":"https://github.com/beefproject/beef/pull/1515","diff_url":"https://github.com/beefproject/beef/pull/1515.diff","patch_url":"https://github.com/beefproject/beef/pull/1515.patch"},"body":"In an attempt to upgrade ruby gems, I found that selenium-webdriver had to remain as 2.53.4 because the latest compatible Firefox version is v48. This pull request also include some javascript library upgrades. The results of my unit and integration tests are:\r\n\r\n```\r\nbundle exec rake unit:\r\n81 tests, 3815 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications\r\n100% passed\r\nbundle exec rake integration:\r\n27 tests, 84 assertions, 0 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications\r\n100% passed\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/beefproject/beef/issues/comments/372160222","html_url":"https://github.com/beefproject/beef/pull/1515#issuecomment-372160222","issue_url":"https://api.github.com/repos/beefproject/beef/issues/1515","id":372160222,"user":{"login":"amadeus777za","id":36609777,"avatar_url":"https://avatars1.githubusercontent.com/u/36609777?v=4","gravatar_id":"","url":"https://api.github.com/users/amadeus777za","html_url":"https://github.com/amadeus777za","followers_url":"https://api.github.com/users/amadeus777za/followers","following_url":"https://api.github.com/users/amadeus777za/following{/other_user}","gists_url":"https://api.github.com/users/amadeus777za/gists{/gist_id}","starred_url":"https://api.github.com/users/amadeus777za/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amadeus777za/subscriptions","organizations_url":"https://api.github.com/users/amadeus777za/orgs","repos_url":"https://api.github.com/users/amadeus777za/repos","events_url":"https://api.github.com/users/amadeus777za/events{/privacy}","received_events_url":"https://api.github.com/users/amadeus777za/received_events","type":"User","site_admin":false},"created_at":"2018-03-11T23:39:33Z","updated_at":"2018-03-11T23:39:33Z","author_association":"NONE","body":"Hi Brendan,\n\nThank you for your comments about keeping PR's smaller and more focussed. I\nagree with this approach and will keep this in mind for future PR's.\n\nKind regards,\nFrancois\n\nOn Fri, Mar 9, 2018 at 4:40 PM, Brendan Coles <notifications@github.com>\nwrote:\n\n> Thanks @amadeus777za <https://github.com/amadeus777za> and @francois777\n> <https://github.com/francois777>\n>\n> Submitting a PR which focuses on a single change or feature significantly\n> increases the chances it will be merged, and the speed with which it will\n> be merged.\n>\n> Making multiple unrelated changes (updating ruby gems, updating JavaScript\n> libraries, changing indentation and typos) makes a mess of the git history,\n> makes the PR much harder to read, and increases the chance of merge\n> conflicts.\n>\n> Changes which may seem minor may not be minor. Unfortunately these changes\n> are not minor and break BeEF on Linux.\n>\n> I'll merge the PR, so you get credit, but some of the changes will need to\n> be reverted.\n>\n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/beefproject/beef/pull/1515#issuecomment-371727440>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/Ai6e8RMN04k88er8na-0_9sE2gwKg3m5ks5tciPzgaJpZM4SV8e1>\n> .\n>\n"}}
{"actor":{"display_login":"amadeus777za"}}