{"action":"closed","number":299,"pull_request":{"url":"https://api.github.com/repos/dhall-lang/dhall-lang/pulls/299","id":233075623,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzMDc1NjIz","html_url":"https://github.com/dhall-lang/dhall-lang/pull/299","diff_url":"https://github.com/dhall-lang/dhall-lang/pull/299.diff","patch_url":"https://github.com/dhall-lang/dhall-lang/pull/299.patch","issue_url":"https://api.github.com/repos/dhall-lang/dhall-lang/issues/299","number":299,"state":"closed","locked":false,"title":"Disallow labels that match builtins or keywords","user":{"login":"Gabriel439","id":1313787,"node_id":"MDQ6VXNlcjEzMTM3ODc=","avatar_url":"https://avatars3.githubusercontent.com/u/1313787?v=4","gravatar_id":"","url":"https://api.github.com/users/Gabriel439","html_url":"https://github.com/Gabriel439","followers_url":"https://api.github.com/users/Gabriel439/followers","following_url":"https://api.github.com/users/Gabriel439/following{/other_user}","gists_url":"https://api.github.com/users/Gabriel439/gists{/gist_id}","starred_url":"https://api.github.com/users/Gabriel439/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gabriel439/subscriptions","organizations_url":"https://api.github.com/users/Gabriel439/orgs","repos_url":"https://api.github.com/users/Gabriel439/repos","events_url":"https://api.github.com/users/Gabriel439/events{/privacy}","received_events_url":"https://api.github.com/users/Gabriel439/received_events","type":"User","site_admin":false},"body":"Fixes https://github.com/dhall-lang/dhall-haskell/issues/683\r\n\r\nBefore this change the grammar allowed variables to be named after\r\nbuiltins or keywords, such as:\r\n\r\n```haskell\r\nlet if = 1 in if\r\n```\r\n\r\nHowever, permitting this deteriorates error messages since an expression\r\nlike this:\r\n\r\n```haskell\r\nif a then b else\r\n```\r\n\r\n... becomes a type error (\"Unbound variable: if\") instead of a parse\r\nerror due to an incomplete `if` expression.\r\n\r\nThe solution is to disallow these sorts of variable names.  Given that\r\nwe don't have a good way to do that in the grammar, we just specify it\r\nas a comment for now.","created_at":"2018-11-22T21:35:30Z","updated_at":"2018-11-26T02:09:59Z","closed_at":"2018-11-26T02:09:59Z","merged_at":"2018-11-26T02:09:59Z","merge_commit_sha":"3aa37b32f12f8e21955999d74e8da4490be09d27","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dhall-lang/dhall-lang/pulls/299/commits","review_comments_url":"https://api.github.com/repos/dhall-lang/dhall-lang/pulls/299/comments","review_comment_url":"https://api.github.com/repos/dhall-lang/dhall-lang/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dhall-lang/dhall-lang/issues/299/comments","statuses_url":"https://api.github.com/repos/dhall-lang/dhall-lang/statuses/d94ffd3c407ea0a02eb1471e04d51f562a61d846","head":{"label":"dhall-lang:gabriel/disallowed_labels","ref":"gabriel/disallowed_labels","sha":"d94ffd3c407ea0a02eb1471e04d51f562a61d846","user":{"login":"dhall-lang","id":31601797,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNjAxNzk3","avatar_url":"https://avatars3.githubusercontent.com/u/31601797?v=4","gravatar_id":"","url":"https://api.github.com/users/dhall-lang","html_url":"https://github.com/dhall-lang","followers_url":"https://api.github.com/users/dhall-lang/followers","following_url":"https://api.github.com/users/dhall-lang/following{/other_user}","gists_url":"https://api.github.com/users/dhall-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dhall-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhall-lang/subscriptions","organizations_url":"https://api.github.com/users/dhall-lang/orgs","repos_url":"https://api.github.com/users/dhall-lang/repos","events_url":"https://api.github.com/users/dhall-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dhall-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":102303588,"node_id":"MDEwOlJlcG9zaXRvcnkxMDIzMDM1ODg=","name":"dhall-lang","full_name":"dhall-lang/dhall-lang","private":false,"owner":{"login":"dhall-lang","id":31601797,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNjAxNzk3","avatar_url":"https://avatars3.githubusercontent.com/u/31601797?v=4","gravatar_id":"","url":"https://api.github.com/users/dhall-lang","html_url":"https://github.com/dhall-lang","followers_url":"https://api.github.com/users/dhall-lang/followers","following_url":"https://api.github.com/users/dhall-lang/following{/other_user}","gists_url":"https://api.github.com/users/dhall-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dhall-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhall-lang/subscriptions","organizations_url":"https://api.github.com/users/dhall-lang/orgs","repos_url":"https://api.github.com/users/dhall-lang/repos","events_url":"https://api.github.com/users/dhall-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dhall-lang/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dhall-lang/dhall-lang","description":"A configuration language guaranteed to terminate","fork":false,"url":"https://api.github.com/repos/dhall-lang/dhall-lang","forks_url":"https://api.github.com/repos/dhall-lang/dhall-lang/forks","keys_url":"https://api.github.com/repos/dhall-lang/dhall-lang/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dhall-lang/dhall-lang/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dhall-lang/dhall-lang/teams","hooks_url":"https://api.github.com/repos/dhall-lang/dhall-lang/hooks","issue_events_url":"https://api.github.com/repos/dhall-lang/dhall-lang/issues/events{/number}","events_url":"https://api.github.com/repos/dhall-lang/dhall-lang/events","assignees_url":"https://api.github.com/repos/dhall-lang/dhall-lang/assignees{/user}","branches_url":"https://api.github.com/repos/dhall-lang/dhall-lang/branches{/branch}","tags_url":"https://api.github.com/repos/dhall-lang/dhall-lang/tags","blobs_url":"https://api.github.com/repos/dhall-lang/dhall-lang/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dhall-lang/dhall-lang/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dhall-lang/dhall-lang/git/refs{/sha}","trees_url":"https://api.github.com/repos/dhall-lang/dhall-lang/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dhall-lang/dhall-lang/statuses/{sha}","languages_url":"https://api.github.com/repos/dhall-lang/dhall-lang/languages","stargazers_url":"https://api.github.com/repos/dhall-lang/dhall-lang/stargazers","contributors_url":"https://api.github.com/repos/dhall-lang/dhall-lang/contributors","subscribers_url":"https://api.github.com/repos/dhall-lang/dhall-lang/subscribers","subscription_url":"https://api.github.com/repos/dhall-lang/dhall-lang/subscription","commits_url":"https://api.github.com/repos/dhall-lang/dhall-lang/commits{/sha}","git_commits_url":"https://api.github.com/repos/dhall-lang/dhall-lang/git/commits{/sha}","comments_url":"https://api.github.com/repos/dhall-lang/dhall-lang/comments{/number}","issue_comment_url":"https://api.github.com/repos/dhall-lang/dhall-lang/issues/comments{/number}","contents_url":"https://api.github.com/repos/dhall-lang/dhall-lang/contents/{+path}","compare_url":"https://api.github.com/repos/dhall-lang/dhall-lang/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dhall-lang/dhall-lang/merges","archive_url":"https://api.github.com/repos/dhall-lang/dhall-lang/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dhall-lang/dhall-lang/downloads","issues_url":"https://api.github.com/repos/dhall-lang/dhall-lang/issues{/number}","pulls_url":"https://api.github.com/repos/dhall-lang/dhall-lang/pulls{/number}","milestones_url":"https://api.github.com/repos/dhall-lang/dhall-lang/milestones{/number}","notifications_url":"https://api.github.com/repos/dhall-lang/dhall-lang/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dhall-lang/dhall-lang/labels{/name}","releases_url":"https://api.github.com/repos/dhall-lang/dhall-lang/releases{/id}","deployments_url":"https://api.github.com/repos/dhall-lang/dhall-lang/deployments","created_at":"2017-09-04T00:41:19Z","updated_at":"2018-11-25T20:08:17Z","pushed_at":"2018-11-26T02:09:59Z","git_url":"git://github.com/dhall-lang/dhall-lang.git","ssh_url":"git@github.com:dhall-lang/dhall-lang.git","clone_url":"https://github.com/dhall-lang/dhall-lang.git","svn_url":"https://github.com/dhall-lang/dhall-lang","homepage":null,"size":632,"stargazers_count":1146,"watchers_count":1146,"language":"Nix","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":41,"mirror_url":null,"archived":false,"open_issues_count":51,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":41,"open_issues":51,"watchers":1146,"default_branch":"master"}},"base":{"label":"dhall-lang:master","ref":"master","sha":"7d8bdb930c6f8b41757004aefc5f69596bb00b28","user":{"login":"dhall-lang","id":31601797,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNjAxNzk3","avatar_url":"https://avatars3.githubusercontent.com/u/31601797?v=4","gravatar_id":"","url":"https://api.github.com/users/dhall-lang","html_url":"https://github.com/dhall-lang","followers_url":"https://api.github.com/users/dhall-lang/followers","following_url":"https://api.github.com/users/dhall-lang/following{/other_user}","gists_url":"https://api.github.com/users/dhall-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dhall-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhall-lang/subscriptions","organizations_url":"https://api.github.com/users/dhall-lang/orgs","repos_url":"https://api.github.com/users/dhall-lang/repos","events_url":"https://api.github.com/users/dhall-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dhall-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":102303588,"node_id":"MDEwOlJlcG9zaXRvcnkxMDIzMDM1ODg=","name":"dhall-lang","full_name":"dhall-lang/dhall-lang","private":false,"owner":{"login":"dhall-lang","id":31601797,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNjAxNzk3","avatar_url":"https://avatars3.githubusercontent.com/u/31601797?v=4","gravatar_id":"","url":"https://api.github.com/users/dhall-lang","html_url":"https://github.com/dhall-lang","followers_url":"https://api.github.com/users/dhall-lang/followers","following_url":"https://api.github.com/users/dhall-lang/following{/other_user}","gists_url":"https://api.github.com/users/dhall-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dhall-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhall-lang/subscriptions","organizations_url":"https://api.github.com/users/dhall-lang/orgs","repos_url":"https://api.github.com/users/dhall-lang/repos","events_url":"https://api.github.com/users/dhall-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dhall-lang/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dhall-lang/dhall-lang","description":"A configuration language guaranteed to terminate","fork":false,"url":"https://api.github.com/repos/dhall-lang/dhall-lang","forks_url":"https://api.github.com/repos/dhall-lang/dhall-lang/forks","keys_url":"https://api.github.com/repos/dhall-lang/dhall-lang/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dhall-lang/dhall-lang/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dhall-lang/dhall-lang/teams","hooks_url":"https://api.github.com/repos/dhall-lang/dhall-lang/hooks","issue_events_url":"https://api.github.com/repos/dhall-lang/dhall-lang/issues/events{/number}","events_url":"https://api.github.com/repos/dhall-lang/dhall-lang/events","assignees_url":"https://api.github.com/repos/dhall-lang/dhall-lang/assignees{/user}","branches_url":"https://api.github.com/repos/dhall-lang/dhall-lang/branches{/branch}","tags_url":"https://api.github.com/repos/dhall-lang/dhall-lang/tags","blobs_url":"https://api.github.com/repos/dhall-lang/dhall-lang/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dhall-lang/dhall-lang/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dhall-lang/dhall-lang/git/refs{/sha}","trees_url":"https://api.github.com/repos/dhall-lang/dhall-lang/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dhall-lang/dhall-lang/statuses/{sha}","languages_url":"https://api.github.com/repos/dhall-lang/dhall-lang/languages","stargazers_url":"https://api.github.com/repos/dhall-lang/dhall-lang/stargazers","contributors_url":"https://api.github.com/repos/dhall-lang/dhall-lang/contributors","subscribers_url":"https://api.github.com/repos/dhall-lang/dhall-lang/subscribers","subscription_url":"https://api.github.com/repos/dhall-lang/dhall-lang/subscription","commits_url":"https://api.github.com/repos/dhall-lang/dhall-lang/commits{/sha}","git_commits_url":"https://api.github.com/repos/dhall-lang/dhall-lang/git/commits{/sha}","comments_url":"https://api.github.com/repos/dhall-lang/dhall-lang/comments{/number}","issue_comment_url":"https://api.github.com/repos/dhall-lang/dhall-lang/issues/comments{/number}","contents_url":"https://api.github.com/repos/dhall-lang/dhall-lang/contents/{+path}","compare_url":"https://api.github.com/repos/dhall-lang/dhall-lang/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dhall-lang/dhall-lang/merges","archive_url":"https://api.github.com/repos/dhall-lang/dhall-lang/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dhall-lang/dhall-lang/downloads","issues_url":"https://api.github.com/repos/dhall-lang/dhall-lang/issues{/number}","pulls_url":"https://api.github.com/repos/dhall-lang/dhall-lang/pulls{/number}","milestones_url":"https://api.github.com/repos/dhall-lang/dhall-lang/milestones{/number}","notifications_url":"https://api.github.com/repos/dhall-lang/dhall-lang/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dhall-lang/dhall-lang/labels{/name}","releases_url":"https://api.github.com/repos/dhall-lang/dhall-lang/releases{/id}","deployments_url":"https://api.github.com/repos/dhall-lang/dhall-lang/deployments","created_at":"2017-09-04T00:41:19Z","updated_at":"2018-11-25T20:08:17Z","pushed_at":"2018-11-26T02:09:59Z","git_url":"git://github.com/dhall-lang/dhall-lang.git","ssh_url":"git@github.com:dhall-lang/dhall-lang.git","clone_url":"https://github.com/dhall-lang/dhall-lang.git","svn_url":"https://github.com/dhall-lang/dhall-lang","homepage":null,"size":632,"stargazers_count":1146,"watchers_count":1146,"language":"Nix","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":41,"mirror_url":null,"archived":false,"open_issues_count":51,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":41,"open_issues":51,"watchers":1146,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dhall-lang/dhall-lang/pulls/299"},"html":{"href":"https://github.com/dhall-lang/dhall-lang/pull/299"},"issue":{"href":"https://api.github.com/repos/dhall-lang/dhall-lang/issues/299"},"comments":{"href":"https://api.github.com/repos/dhall-lang/dhall-lang/issues/299/comments"},"review_comments":{"href":"https://api.github.com/repos/dhall-lang/dhall-lang/pulls/299/comments"},"review_comment":{"href":"https://api.github.com/repos/dhall-lang/dhall-lang/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dhall-lang/dhall-lang/pulls/299/commits"},"statuses":{"href":"https://api.github.com/repos/dhall-lang/dhall-lang/statuses/d94ffd3c407ea0a02eb1471e04d51f562a61d846"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"Gabriel439","id":1313787,"node_id":"MDQ6VXNlcjEzMTM3ODc=","avatar_url":"https://avatars3.githubusercontent.com/u/1313787?v=4","gravatar_id":"","url":"https://api.github.com/users/Gabriel439","html_url":"https://github.com/Gabriel439","followers_url":"https://api.github.com/users/Gabriel439/followers","following_url":"https://api.github.com/users/Gabriel439/following{/other_user}","gists_url":"https://api.github.com/users/Gabriel439/gists{/gist_id}","starred_url":"https://api.github.com/users/Gabriel439/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gabriel439/subscriptions","organizations_url":"https://api.github.com/users/Gabriel439/orgs","repos_url":"https://api.github.com/users/Gabriel439/repos","events_url":"https://api.github.com/users/Gabriel439/events{/privacy}","received_events_url":"https://api.github.com/users/Gabriel439/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":56,"deletions":0,"changed_files":2}}
{"actor":{"display_login":"Gabriel439"}}