{"action":"created","issue":{"url":"https://api.github.com/repos/mesonbuild/meson/issues/4419","repository_url":"https://api.github.com/repos/mesonbuild/meson","labels_url":"https://api.github.com/repos/mesonbuild/meson/issues/4419/labels{/name}","comments_url":"https://api.github.com/repos/mesonbuild/meson/issues/4419/comments","events_url":"https://api.github.com/repos/mesonbuild/meson/issues/4419/events","html_url":"https://github.com/mesonbuild/meson/pull/4419","id":373744519,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1NjAyNDIy","number":4419,"title":"MSVC updated version to 1920 and VS 2017 point to 15.0","user":{"login":"LarryIII","id":33021067,"node_id":"MDQ6VXNlcjMzMDIxMDY3","avatar_url":"https://avatars0.githubusercontent.com/u/33021067?v=4","gravatar_id":"","url":"https://api.github.com/users/LarryIII","html_url":"https://github.com/LarryIII","followers_url":"https://api.github.com/users/LarryIII/followers","following_url":"https://api.github.com/users/LarryIII/following{/other_user}","gists_url":"https://api.github.com/users/LarryIII/gists{/gist_id}","starred_url":"https://api.github.com/users/LarryIII/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LarryIII/subscriptions","organizations_url":"https://api.github.com/users/LarryIII/orgs","repos_url":"https://api.github.com/users/LarryIII/repos","events_url":"https://api.github.com/users/LarryIII/events{/privacy}","received_events_url":"https://api.github.com/users/LarryIII/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-10-25T02:09:34Z","updated_at":"2018-10-30T05:57:46Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/mesonbuild/meson/pulls/4419","html_url":"https://github.com/mesonbuild/meson/pull/4419","diff_url":"https://github.com/mesonbuild/meson/pull/4419.diff","patch_url":"https://github.com/mesonbuild/meson/pull/4419.patch"},"body":"Hello,\r\n\r\nI am on the C++ team in Microsoft. We are testing https://github.com/anholt/libepoxy in an upcoming VS 2017 release. Libepoxy need **meson** source, so it failed with error like below in your source:\r\n      **if float(compiler.get_toolset_version()) < 10.0:\r\n     TypeError: float() argument must be a string or a number, not 'NoneType'**\r\nThis because MSVC version has updated to 1920, but get_toolset_version() is not support this version(out of checking). So could you please approve this now?\r\n\r\nBy the way, VS 2017 is point 15.0, so I also updated this from 14.1 to 15.0.\r\n\r\nThanks,\r\nLarry "},"comment":{"url":"https://api.github.com/repos/mesonbuild/meson/issues/comments/434181328","html_url":"https://github.com/mesonbuild/meson/pull/4419#issuecomment-434181328","issue_url":"https://api.github.com/repos/mesonbuild/meson/issues/4419","id":434181328,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNDE4MTMyOA==","user":{"login":"LarryIII","id":33021067,"node_id":"MDQ6VXNlcjMzMDIxMDY3","avatar_url":"https://avatars0.githubusercontent.com/u/33021067?v=4","gravatar_id":"","url":"https://api.github.com/users/LarryIII","html_url":"https://github.com/LarryIII","followers_url":"https://api.github.com/users/LarryIII/followers","following_url":"https://api.github.com/users/LarryIII/following{/other_user}","gists_url":"https://api.github.com/users/LarryIII/gists{/gist_id}","starred_url":"https://api.github.com/users/LarryIII/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LarryIII/subscriptions","organizations_url":"https://api.github.com/users/LarryIII/orgs","repos_url":"https://api.github.com/users/LarryIII/repos","events_url":"https://api.github.com/users/LarryIII/events{/privacy}","received_events_url":"https://api.github.com/users/LarryIII/received_events","type":"User","site_admin":false},"created_at":"2018-10-30T05:57:46Z","updated_at":"2018-10-30T05:57:46Z","author_association":"NONE","body":"@jon-turney \r\nRight here! For VS 2017 info： MSVC version is 14.1X but compiler version is 15.X.\r\nIn the future VS 2019. MSVC version is not definition, and the compiler version should be 16.X. That's why I approve his suggestion. So if you are want to use MSVC version as the return value. 14.1 is reasonable here for VS 2017!"}}
{"actor":{"display_login":"LarryIII"}}