{"action":"created","issue":{"url":"https://api.github.com/repos/ProtonVPN/protonvpn-cli/issues/149","repository_url":"https://api.github.com/repos/ProtonVPN/protonvpn-cli","labels_url":"https://api.github.com/repos/ProtonVPN/protonvpn-cli/issues/149/labels{/name}","comments_url":"https://api.github.com/repos/ProtonVPN/protonvpn-cli/issues/149/comments","events_url":"https://api.github.com/repos/ProtonVPN/protonvpn-cli/issues/149/events","html_url":"https://github.com/ProtonVPN/protonvpn-cli/issues/149","id":378552753,"node_id":"MDU6SXNzdWUzNzg1NTI3NTM=","number":149,"title":"Store credentials in OS keyring?","user":{"login":"njfox","id":12201350,"node_id":"MDQ6VXNlcjEyMjAxMzUw","avatar_url":"https://avatars3.githubusercontent.com/u/12201350?v=4","gravatar_id":"","url":"https://api.github.com/users/njfox","html_url":"https://github.com/njfox","followers_url":"https://api.github.com/users/njfox/followers","following_url":"https://api.github.com/users/njfox/following{/other_user}","gists_url":"https://api.github.com/users/njfox/gists{/gist_id}","starred_url":"https://api.github.com/users/njfox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/njfox/subscriptions","organizations_url":"https://api.github.com/users/njfox/orgs","repos_url":"https://api.github.com/users/njfox/repos","events_url":"https://api.github.com/users/njfox/events{/privacy}","received_events_url":"https://api.github.com/users/njfox/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2018-11-08T02:32:14Z","updated_at":"2018-12-17T13:53:17Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"Hey @mazen160,\r\n\r\nI've noticed this project is catching a lot of flak on Reddit for storing the OpenVPN credentials in plaintext on disk. I know it's only accessible by root but I was wondering if the team had considered integrating protonvpn-cli with the OS keyring (e.g. `gnome-keyring`, `kde-wallet`, etc.) instead. This seems to be how some other Linux packages manage credential storage and it seems sensible enough to me. Do you have any thoughts on how feasible this would be? I believe Python can use `gnome-keyring` pretty easily for example but I'm not sure about bash."},"comment":{"url":"https://api.github.com/repos/ProtonVPN/protonvpn-cli/issues/comments/447853065","html_url":"https://github.com/ProtonVPN/protonvpn-cli/issues/149#issuecomment-447853065","issue_url":"https://api.github.com/repos/ProtonVPN/protonvpn-cli/issues/149","id":447853065,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0Nzg1MzA2NQ==","user":{"login":"mazen160","id":8996052,"node_id":"MDQ6VXNlcjg5OTYwNTI=","avatar_url":"https://avatars3.githubusercontent.com/u/8996052?v=4","gravatar_id":"","url":"https://api.github.com/users/mazen160","html_url":"https://github.com/mazen160","followers_url":"https://api.github.com/users/mazen160/followers","following_url":"https://api.github.com/users/mazen160/following{/other_user}","gists_url":"https://api.github.com/users/mazen160/gists{/gist_id}","starred_url":"https://api.github.com/users/mazen160/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mazen160/subscriptions","organizations_url":"https://api.github.com/users/mazen160/orgs","repos_url":"https://api.github.com/users/mazen160/repos","events_url":"https://api.github.com/users/mazen160/events{/privacy}","received_events_url":"https://api.github.com/users/mazen160/received_events","type":"User","site_admin":false},"created_at":"2018-12-17T13:53:17Z","updated_at":"2018-12-17T13:53:17Z","author_association":"COLLABORATOR","body":"Hi @Picea !\r\n\r\nNice idea!!\r\n\r\nBut the problem is,\r\n\r\n1) if the connection requires restarting, fetching the auth-user-pass won't work as far as I recall. But I assume since the previous releases, we pvpn uses OpenVPN caching, so this should not be a problem\r\n\r\n2) We need to have a notification message to let users know of a month before the update. Will figure a way (probably via fetching an API message). \r\n\r\n3) We need to automatically generate and fetch a GPG key for users - We should not assume that users have a GPG profile.\r\n\r\n\r\nMaybe a PR would be cool!"}}
{"actor":{"display_login":"mazen160"}}