{"action":"created","comment":{"url":"https://api.github.com/repos/indico/indico-plugins-cern/pulls/comments/237202157","pull_request_review_id":179443819,"id":237202157,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzIwMjE1Nw==","diff_hunk":"@@ -0,0 +1,43 @@\n+# This file is part of the CERN Indico plugins.\n+# Copyright (C) 2014 - 2018 CERN\n+#\n+# The CERN Indico plugins are free software; you can redistribute\n+# them and/or modify them under the terms of the MIT License; see\n+# the LICENSE file for more details.\n+\n+from __future__ import unicode_literals\n+\n+from flask import session\n+from werkzeug.exceptions import Forbidden\n+\n+from indico.modules.events.requests import RequestDefinitionBase\n+from indico.modules.events.requests.models.requests import RequestState\n+\n+from indico_vc_assistance import _\n+from indico_vc_assistance.forms import VCAssistanceRequestForm\n+from indico_vc_assistance.util import can_request_assistance, has_room_with_vc_attached\n+\n+\n+class VCAssistanceRequest(RequestDefinitionBase):\n+    name = 'vc-assistance'\n+    title = _('Videoconference assistance')\n+    form = VCAssistanceRequestForm\n+\n+    @classmethod\n+    def can_be_managed(cls, user):\n+        return False\n+\n+    @classmethod\n+    def render_form(cls, event, **kwargs):\n+        kwargs['user_authorized'] = can_request_assistance(session.user)\n+        kwargs['has_vc_room_attached'] = has_room_with_vc_attached(event)\n+        req = kwargs['req']","path":"vc_assistance/indico_vc_assistance/definition.py","position":34,"original_position":34,"commit_id":"9a6eb5d733907de0ac0fc8bec4582eb54b602185","original_commit_id":"9a6eb5d733907de0ac0fc8bec4582eb54b602185","user":{"login":"ThiefMaster","id":179599,"node_id":"MDQ6VXNlcjE3OTU5OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/179599?v=4","gravatar_id":"","url":"https://api.github.com/users/ThiefMaster","html_url":"https://github.com/ThiefMaster","followers_url":"https://api.github.com/users/ThiefMaster/followers","following_url":"https://api.github.com/users/ThiefMaster/following{/other_user}","gists_url":"https://api.github.com/users/ThiefMaster/gists{/gist_id}","starred_url":"https://api.github.com/users/ThiefMaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThiefMaster/subscriptions","organizations_url":"https://api.github.com/users/ThiefMaster/orgs","repos_url":"https://api.github.com/users/ThiefMaster/repos","events_url":"https://api.github.com/users/ThiefMaster/events{/privacy}","received_events_url":"https://api.github.com/users/ThiefMaster/received_events","type":"User","site_admin":false},"body":"what about moving this up two lines? it interrupts the three `kwargs[...] = ...` lines a bit :smiling_imp: ","created_at":"2018-11-28T18:15:20Z","updated_at":"2018-11-28T18:18:14Z","html_url":"https://github.com/indico/indico-plugins-cern/pull/32#discussion_r237202157","pull_request_url":"https://api.github.com/repos/indico/indico-plugins-cern/pulls/32","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/indico/indico-plugins-cern/pulls/comments/237202157"},"html":{"href":"https://github.com/indico/indico-plugins-cern/pull/32#discussion_r237202157"},"pull_request":{"href":"https://api.github.com/repos/indico/indico-plugins-cern/pulls/32"}}},"pull_request":{"url":"https://api.github.com/repos/indico/indico-plugins-cern/pulls/32","id":233617900,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzNjE3OTAw","html_url":"https://github.com/indico/indico-plugins-cern/pull/32","diff_url":"https://github.com/indico/indico-plugins-cern/pull/32.diff","patch_url":"https://github.com/indico/indico-plugins-cern/pull/32.patch","issue_url":"https://api.github.com/repos/indico/indico-plugins-cern/issues/32","number":32,"state":"open","locked":false,"title":"WIP: VC Assistance plugin","user":{"login":"mvidalgarcia","id":8863238,"node_id":"MDQ6VXNlcjg4NjMyMzg=","avatar_url":"https://avatars1.githubusercontent.com/u/8863238?v=4","gravatar_id":"","url":"https://api.github.com/users/mvidalgarcia","html_url":"https://github.com/mvidalgarcia","followers_url":"https://api.github.com/users/mvidalgarcia/followers","following_url":"https://api.github.com/users/mvidalgarcia/following{/other_user}","gists_url":"https://api.github.com/users/mvidalgarcia/gists{/gist_id}","starred_url":"https://api.github.com/users/mvidalgarcia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mvidalgarcia/subscriptions","organizations_url":"https://api.github.com/users/mvidalgarcia/orgs","repos_url":"https://api.github.com/users/mvidalgarcia/repos","events_url":"https://api.github.com/users/mvidalgarcia/events{/privacy}","received_events_url":"https://api.github.com/users/mvidalgarcia/received_events","type":"User","site_admin":false},"body":"Closes https://github.com/indico/indico/issues/3622","created_at":"2018-11-26T16:25:07Z","updated_at":"2018-11-28T18:18:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"073a63db9aa03016edae07ccd5c8f51d2276677a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/indico/indico-plugins-cern/pulls/32/commits","review_comments_url":"https://api.github.com/repos/indico/indico-plugins-cern/pulls/32/comments","review_comment_url":"https://api.github.com/repos/indico/indico-plugins-cern/pulls/comments{/number}","comments_url":"https://api.github.com/repos/indico/indico-plugins-cern/issues/32/comments","statuses_url":"https://api.github.com/repos/indico/indico-plugins-cern/statuses/9a6eb5d733907de0ac0fc8bec4582eb54b602185","head":{"label":"mvidalgarcia:vc-assistance","ref":"vc-assistance","sha":"9a6eb5d733907de0ac0fc8bec4582eb54b602185","user":{"login":"mvidalgarcia","id":8863238,"node_id":"MDQ6VXNlcjg4NjMyMzg=","avatar_url":"https://avatars1.githubusercontent.com/u/8863238?v=4","gravatar_id":"","url":"https://api.github.com/users/mvidalgarcia","html_url":"https://github.com/mvidalgarcia","followers_url":"https://api.github.com/users/mvidalgarcia/followers","following_url":"https://api.github.com/users/mvidalgarcia/following{/other_user}","gists_url":"https://api.github.com/users/mvidalgarcia/gists{/gist_id}","starred_url":"https://api.github.com/users/mvidalgarcia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mvidalgarcia/subscriptions","organizations_url":"https://api.github.com/users/mvidalgarcia/orgs","repos_url":"https://api.github.com/users/mvidalgarcia/repos","events_url":"https://api.github.com/users/mvidalgarcia/events{/privacy}","received_events_url":"https://api.github.com/users/mvidalgarcia/received_events","type":"User","site_admin":false},"repo":{"id":110120649,"node_id":"MDEwOlJlcG9zaXRvcnkxMTAxMjA2NDk=","name":"indico-plugins-cern","full_name":"mvidalgarcia/indico-plugins-cern","private":false,"owner":{"login":"mvidalgarcia","id":8863238,"node_id":"MDQ6VXNlcjg4NjMyMzg=","avatar_url":"https://avatars1.githubusercontent.com/u/8863238?v=4","gravatar_id":"","url":"https://api.github.com/users/mvidalgarcia","html_url":"https://github.com/mvidalgarcia","followers_url":"https://api.github.com/users/mvidalgarcia/followers","following_url":"https://api.github.com/users/mvidalgarcia/following{/other_user}","gists_url":"https://api.github.com/users/mvidalgarcia/gists{/gist_id}","starred_url":"https://api.github.com/users/mvidalgarcia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mvidalgarcia/subscriptions","organizations_url":"https://api.github.com/users/mvidalgarcia/orgs","repos_url":"https://api.github.com/users/mvidalgarcia/repos","events_url":"https://api.github.com/users/mvidalgarcia/events{/privacy}","received_events_url":"https://api.github.com/users/mvidalgarcia/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mvidalgarcia/indico-plugins-cern","description":"CERN-specific Indico plugins","fork":true,"url":"https://api.github.com/repos/mvidalgarcia/indico-plugins-cern","forks_url":"https://api.github.com/repos/mvidalgarcia/indico-plugins-cern/forks","keys_url":"https://api.github.com/repos/mvidalgarcia/indico-plugins-cern/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mvidalgarcia/indico-plugins-cern/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mvidalgarcia/indico-plugins-cern/teams","hooks_url":"https://api.github.com/repos/mvidalgarcia/indico-plugins-cern/hooks","issue_events_url":"https://api.github.com/repos/mvidalgarcia/indico-plugins-cern/issues/events{/number}","events_url":"https://api.github.com/repos/mvidalgarcia/indico-plugins-cern/events","assignees_url":"https://api.github.com/repos/mvidalgarcia/indico-plugins-cern/assignees{/user}","branches_url":"https://api.github.com/repos/mvidalgarcia/indico-plugins-cern/branches{/branch}","tags_url":"https://api.github.com/repos/mvidalgarcia/indico-plugins-cern/tags","blobs_url":"https://api.github.com/repos/mvidalgarcia/indico-plugins-cern/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mvidalgarcia/indico-plugins-cern/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mvidalgarcia/indico-plugins-cern/git/refs{/sha}","trees_url":"https://api.github.com/repos/mvidalgarcia/indico-plugins-cern/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mvidalgarcia/indico-plugins-cern/statuses/{sha}","languages_url":"https://api.github.com/repos/mvidalgarcia/indico-plugins-cern/languages","stargazers_url":"https://api.github.com/repos/mvidalgarcia/indico-plugins-cern/stargazers","contributors_url":"https://api.github.com/repos/mvidalgarcia/indico-plugins-cern/contributors","subscribers_url":"https://api.github.com/repos/mvidalgarcia/indico-plugins-cern/subscribers","subscription_url":"https://api.github.com/repos/mvidalgarcia/indico-plugins-cern/subscription","commits_url":"https://api.github.com/repos/mvidalgarcia/indico-plugins-cern/commits{/sha}","git_commits_url":"https://api.github.com/repos/mvidalgarcia/indico-plugins-cern/git/commits{/sha}","comments_url":"https://api.github.com/repos/mvidalgarcia/indico-plugins-cern/comments{/number}","issue_comment_url":"https://api.github.com/repos/mvidalgarcia/indico-plugins-cern/issues/comments{/number}","contents_url":"https://api.github.com/repos/mvidalgarcia/indico-plugins-cern/contents/{+path}","compare_url":"https://api.github.com/repos/mvidalgarcia/indico-plugins-cern/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mvidalgarcia/indico-plugins-cern/merges","archive_url":"https://api.github.com/repos/mvidalgarcia/indico-plugins-cern/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mvidalgarcia/indico-plugins-cern/downloads","issues_url":"https://api.github.com/repos/mvidalgarcia/indico-plugins-cern/issues{/number}","pulls_url":"https://api.github.com/repos/mvidalgarcia/indico-plugins-cern/pulls{/number}","milestones_url":"https://api.github.com/repos/mvidalgarcia/indico-plugins-cern/milestones{/number}","notifications_url":"https://api.github.com/repos/mvidalgarcia/indico-plugins-cern/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mvidalgarcia/indico-plugins-cern/labels{/name}","releases_url":"https://api.github.com/repos/mvidalgarcia/indico-plugins-cern/releases{/id}","deployments_url":"https://api.github.com/repos/mvidalgarcia/indico-plugins-cern/deployments","created_at":"2017-11-09T13:45:27Z","updated_at":"2017-11-09T13:45:29Z","pushed_at":"2018-11-28T18:12:18Z","git_url":"git://github.com/mvidalgarcia/indico-plugins-cern.git","ssh_url":"git@github.com:mvidalgarcia/indico-plugins-cern.git","clone_url":"https://github.com/mvidalgarcia/indico-plugins-cern.git","svn_url":"https://github.com/mvidalgarcia/indico-plugins-cern","homepage":null,"size":1240,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"indico:master","ref":"master","sha":"93cce6ae6d1a6a2c07a8ef2c0753979e8389c3fe","user":{"login":"indico","id":715236,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcxNTIzNg==","avatar_url":"https://avatars2.githubusercontent.com/u/715236?v=4","gravatar_id":"","url":"https://api.github.com/users/indico","html_url":"https://github.com/indico","followers_url":"https://api.github.com/users/indico/followers","following_url":"https://api.github.com/users/indico/following{/other_user}","gists_url":"https://api.github.com/users/indico/gists{/gist_id}","starred_url":"https://api.github.com/users/indico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indico/subscriptions","organizations_url":"https://api.github.com/users/indico/orgs","repos_url":"https://api.github.com/users/indico/repos","events_url":"https://api.github.com/users/indico/events{/privacy}","received_events_url":"https://api.github.com/users/indico/received_events","type":"Organization","site_admin":false},"repo":{"id":109959841,"node_id":"MDEwOlJlcG9zaXRvcnkxMDk5NTk4NDE=","name":"indico-plugins-cern","full_name":"indico/indico-plugins-cern","private":false,"owner":{"login":"indico","id":715236,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcxNTIzNg==","avatar_url":"https://avatars2.githubusercontent.com/u/715236?v=4","gravatar_id":"","url":"https://api.github.com/users/indico","html_url":"https://github.com/indico","followers_url":"https://api.github.com/users/indico/followers","following_url":"https://api.github.com/users/indico/following{/other_user}","gists_url":"https://api.github.com/users/indico/gists{/gist_id}","starred_url":"https://api.github.com/users/indico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indico/subscriptions","organizations_url":"https://api.github.com/users/indico/orgs","repos_url":"https://api.github.com/users/indico/repos","events_url":"https://api.github.com/users/indico/events{/privacy}","received_events_url":"https://api.github.com/users/indico/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/indico/indico-plugins-cern","description":"CERN-specific Indico plugins","fork":false,"url":"https://api.github.com/repos/indico/indico-plugins-cern","forks_url":"https://api.github.com/repos/indico/indico-plugins-cern/forks","keys_url":"https://api.github.com/repos/indico/indico-plugins-cern/keys{/key_id}","collaborators_url":"https://api.github.com/repos/indico/indico-plugins-cern/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/indico/indico-plugins-cern/teams","hooks_url":"https://api.github.com/repos/indico/indico-plugins-cern/hooks","issue_events_url":"https://api.github.com/repos/indico/indico-plugins-cern/issues/events{/number}","events_url":"https://api.github.com/repos/indico/indico-plugins-cern/events","assignees_url":"https://api.github.com/repos/indico/indico-plugins-cern/assignees{/user}","branches_url":"https://api.github.com/repos/indico/indico-plugins-cern/branches{/branch}","tags_url":"https://api.github.com/repos/indico/indico-plugins-cern/tags","blobs_url":"https://api.github.com/repos/indico/indico-plugins-cern/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/indico/indico-plugins-cern/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/indico/indico-plugins-cern/git/refs{/sha}","trees_url":"https://api.github.com/repos/indico/indico-plugins-cern/git/trees{/sha}","statuses_url":"https://api.github.com/repos/indico/indico-plugins-cern/statuses/{sha}","languages_url":"https://api.github.com/repos/indico/indico-plugins-cern/languages","stargazers_url":"https://api.github.com/repos/indico/indico-plugins-cern/stargazers","contributors_url":"https://api.github.com/repos/indico/indico-plugins-cern/contributors","subscribers_url":"https://api.github.com/repos/indico/indico-plugins-cern/subscribers","subscription_url":"https://api.github.com/repos/indico/indico-plugins-cern/subscription","commits_url":"https://api.github.com/repos/indico/indico-plugins-cern/commits{/sha}","git_commits_url":"https://api.github.com/repos/indico/indico-plugins-cern/git/commits{/sha}","comments_url":"https://api.github.com/repos/indico/indico-plugins-cern/comments{/number}","issue_comment_url":"https://api.github.com/repos/indico/indico-plugins-cern/issues/comments{/number}","contents_url":"https://api.github.com/repos/indico/indico-plugins-cern/contents/{+path}","compare_url":"https://api.github.com/repos/indico/indico-plugins-cern/compare/{base}...{head}","merges_url":"https://api.github.com/repos/indico/indico-plugins-cern/merges","archive_url":"https://api.github.com/repos/indico/indico-plugins-cern/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/indico/indico-plugins-cern/downloads","issues_url":"https://api.github.com/repos/indico/indico-plugins-cern/issues{/number}","pulls_url":"https://api.github.com/repos/indico/indico-plugins-cern/pulls{/number}","milestones_url":"https://api.github.com/repos/indico/indico-plugins-cern/milestones{/number}","notifications_url":"https://api.github.com/repos/indico/indico-plugins-cern/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/indico/indico-plugins-cern/labels{/name}","releases_url":"https://api.github.com/repos/indico/indico-plugins-cern/releases{/id}","deployments_url":"https://api.github.com/repos/indico/indico-plugins-cern/deployments","created_at":"2017-11-08T10:12:34Z","updated_at":"2018-11-16T11:22:27Z","pushed_at":"2018-11-28T18:12:19Z","git_url":"git://github.com/indico/indico-plugins-cern.git","ssh_url":"git@github.com:indico/indico-plugins-cern.git","clone_url":"https://github.com/indico/indico-plugins-cern.git","svn_url":"https://github.com/indico/indico-plugins-cern","homepage":null,"size":1231,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":8,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/indico/indico-plugins-cern/pulls/32"},"html":{"href":"https://github.com/indico/indico-plugins-cern/pull/32"},"issue":{"href":"https://api.github.com/repos/indico/indico-plugins-cern/issues/32"},"comments":{"href":"https://api.github.com/repos/indico/indico-plugins-cern/issues/32/comments"},"review_comments":{"href":"https://api.github.com/repos/indico/indico-plugins-cern/pulls/32/comments"},"review_comment":{"href":"https://api.github.com/repos/indico/indico-plugins-cern/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/indico/indico-plugins-cern/pulls/32/commits"},"statuses":{"href":"https://api.github.com/repos/indico/indico-plugins-cern/statuses/9a6eb5d733907de0ac0fc8bec4582eb54b602185"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"ThiefMaster"}}