{"action":"created","comment":{"url":"https://api.github.com/repos/codice/ddf/pulls/comments/244200756","pull_request_review_id":188147063,"id":244200756,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDIwMDc1Ng==","diff_hunk":"@@ -54,6 +54,12 @@ class LineRenderView extends GeometryRenderView {\n     if (!linePoints) {\n       return\n     }\n+\n+    linePoints.map(point => {","path":"ui/packages/catalog-ui-search/src/main/webapp/js/widgets/cesium.line.js","position":14,"original_position":14,"commit_id":"d5fc62ecbfc22fd0f46f2d370a002bafb6f1d4f3","original_commit_id":"d5fc62ecbfc22fd0f46f2d370a002bafb6f1d4f3","user":{"login":"willwill96","id":10997562,"node_id":"MDQ6VXNlcjEwOTk3NTYy","avatar_url":"https://avatars1.githubusercontent.com/u/10997562?v=4","gravatar_id":"","url":"https://api.github.com/users/willwill96","html_url":"https://github.com/willwill96","followers_url":"https://api.github.com/users/willwill96/followers","following_url":"https://api.github.com/users/willwill96/following{/other_user}","gists_url":"https://api.github.com/users/willwill96/gists{/gist_id}","starred_url":"https://api.github.com/users/willwill96/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willwill96/subscriptions","organizations_url":"https://api.github.com/users/willwill96/orgs","repos_url":"https://api.github.com/users/willwill96/repos","events_url":"https://api.github.com/users/willwill96/events{/privacy}","received_events_url":"https://api.github.com/users/willwill96/received_events","type":"User","site_admin":false},"body":"```suggestion\r\n    linePoints.forEach(point => {\r\n```","created_at":"2018-12-27T18:10:34Z","updated_at":"2018-12-27T18:10:35Z","html_url":"https://github.com/codice/ddf/pull/4167#discussion_r244200756","pull_request_url":"https://api.github.com/repos/codice/ddf/pulls/4167","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/codice/ddf/pulls/comments/244200756"},"html":{"href":"https://github.com/codice/ddf/pull/4167#discussion_r244200756"},"pull_request":{"href":"https://api.github.com/repos/codice/ddf/pulls/4167"}}},"pull_request":{"url":"https://api.github.com/repos/codice/ddf/pulls/4167","id":241193472,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxMTkzNDcy","html_url":"https://github.com/codice/ddf/pull/4167","diff_url":"https://github.com/codice/ddf/pull/4167.diff","patch_url":"https://github.com/codice/ddf/pull/4167.patch","issue_url":"https://api.github.com/repos/codice/ddf/issues/4167","number":4167,"state":"open","locked":false,"title":"DDF-4418 As a user I would like lat/lon values to only have at most 6 points to the right of the decimal so that my locations are easier to read","user":{"login":"zta6","id":14204943,"node_id":"MDQ6VXNlcjE0MjA0OTQz","avatar_url":"https://avatars3.githubusercontent.com/u/14204943?v=4","gravatar_id":"","url":"https://api.github.com/users/zta6","html_url":"https://github.com/zta6","followers_url":"https://api.github.com/users/zta6/followers","following_url":"https://api.github.com/users/zta6/following{/other_user}","gists_url":"https://api.github.com/users/zta6/gists{/gist_id}","starred_url":"https://api.github.com/users/zta6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zta6/subscriptions","organizations_url":"https://api.github.com/users/zta6/orgs","repos_url":"https://api.github.com/users/zta6/repos","events_url":"https://api.github.com/users/zta6/events{/privacy}","received_events_url":"https://api.github.com/users/zta6/received_events","type":"User","site_admin":false},"body":"<!--\r\nUncomment this block and include PR # of change against 2.13.x where appropriate.\r\nWhen doing so, it is reasonable to delete much of the rest of the PR description, leaving only:\r\n- This uncommented block with link to 2.13.x PR\r\n- Reviewers tagged\r\n- Teams tagged\r\n- Committers tagged\r\n- The link to the \"Notes on Review Process\"\r\n\r\n##### ABBREVIATED REVIEW BETWEEN 2.13.X AND MASTER IS IN EFFECT\r\nLink to 2.13.x PR: #XXXX\r\n____\r\n-->\r\n\r\n#### What does this PR do?\r\nChanges the drawing tools for both 2D and 3D maps to create points with 6 digits of precision, rather than 14 digits. 14 digits of precision makes things hard to read in the UI, and is more precision than is necessary. You can read about the physical precision of various amounts of decimal precision [here](https://en.wikipedia.org/wiki/Decimal_degrees). 6 digits of decimal precision gives about 0.1m of physical precision. \r\n\r\n#### Who is reviewing it? \r\n@middlets719 \r\n@Schachte \r\n@bdeining \r\n@adimka \r\n@gordocanchola \r\n@cantstoptheunk \r\n\r\n<!--(please choose AT LEAST two reviewers that need to approve the PR before it can get merged)-->\r\n#### Select relevant component teams: \r\ncodice/ui \r\n\r\n#### Ask 2 committers to review/merge the PR and tag them here.\r\n<!--\r\nIf you don't know who to ask, you can request reviews in https://groups.google.com/forum/#!forum/ddf-developers .\r\n(please choose ONLY two committers from below, delete the rest)\r\n-->\r\n@andrewkfiedler\r\n@millerw8\r\n\r\n#### How should this be tested?\r\n<!--(List steps with links to updated documentation)-->\r\nPerform anyGeo searches with each shape (bbox, line, polygon, point radius)\r\nverify that the coordinates of the drawn shape only display 6 digits of precision in the search ui\r\n\r\nVerify same functionality in all drawing tools in downstream projects.\r\n\r\n#### Any background context you want to provide?\r\n\r\n#### What are the relevant tickets?\r\n[DDF-4418](https://codice.atlassian.net/browse/DDF-4418)\r\n\r\n#### Screenshots\r\n<!--(if appropriate)-->\r\n\r\n#### Checklist:\r\n- [ ] Documentation Updated\r\n- [ ] Update / Add Threat Dragon models\r\n- [ ] Update / Add Unit Tests\r\n- [ ] Update / Add Integration Tests\r\n\r\n#### Notes on Review Process\r\nPlease see [Notes on Review Process](https://codice.atlassian.net/wiki/spaces/DDF/pages/71946981/Pull+Request+Guidelines) for further guidance on requirements for merging and abbreviated reviews. \r\n\r\n#### Review Comment Legend:\r\n- ✏️ (Pencil) This comment is a nitpick or style suggestion, no action required for approval. This comment should provide a suggestion either as an in line code snippet or a gist. \r\n- ❓ (Question Mark) This comment is to gain a clearer understanding of design or code choices, clarification is required but action may not be necessary for approval.\r\n- ❗ (Exclamation Mark) This comment is critical and requires clarification or action before approval.\r\n","created_at":"2018-12-27T17:20:48Z","updated_at":"2018-12-27T18:10:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"79c6401c459bc71eea51fba55f5e95f765e28cdb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/codice/ddf/pulls/4167/commits","review_comments_url":"https://api.github.com/repos/codice/ddf/pulls/4167/comments","review_comment_url":"https://api.github.com/repos/codice/ddf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/codice/ddf/issues/4167/comments","statuses_url":"https://api.github.com/repos/codice/ddf/statuses/d5fc62ecbfc22fd0f46f2d370a002bafb6f1d4f3","head":{"label":"zta6:DDF-4418","ref":"DDF-4418","sha":"d5fc62ecbfc22fd0f46f2d370a002bafb6f1d4f3","user":{"login":"zta6","id":14204943,"node_id":"MDQ6VXNlcjE0MjA0OTQz","avatar_url":"https://avatars3.githubusercontent.com/u/14204943?v=4","gravatar_id":"","url":"https://api.github.com/users/zta6","html_url":"https://github.com/zta6","followers_url":"https://api.github.com/users/zta6/followers","following_url":"https://api.github.com/users/zta6/following{/other_user}","gists_url":"https://api.github.com/users/zta6/gists{/gist_id}","starred_url":"https://api.github.com/users/zta6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zta6/subscriptions","organizations_url":"https://api.github.com/users/zta6/orgs","repos_url":"https://api.github.com/users/zta6/repos","events_url":"https://api.github.com/users/zta6/events{/privacy}","received_events_url":"https://api.github.com/users/zta6/received_events","type":"User","site_admin":false},"repo":{"id":152115045,"node_id":"MDEwOlJlcG9zaXRvcnkxNTIxMTUwNDU=","name":"ddf","full_name":"zta6/ddf","private":false,"owner":{"login":"zta6","id":14204943,"node_id":"MDQ6VXNlcjE0MjA0OTQz","avatar_url":"https://avatars3.githubusercontent.com/u/14204943?v=4","gravatar_id":"","url":"https://api.github.com/users/zta6","html_url":"https://github.com/zta6","followers_url":"https://api.github.com/users/zta6/followers","following_url":"https://api.github.com/users/zta6/following{/other_user}","gists_url":"https://api.github.com/users/zta6/gists{/gist_id}","starred_url":"https://api.github.com/users/zta6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zta6/subscriptions","organizations_url":"https://api.github.com/users/zta6/orgs","repos_url":"https://api.github.com/users/zta6/repos","events_url":"https://api.github.com/users/zta6/events{/privacy}","received_events_url":"https://api.github.com/users/zta6/received_events","type":"User","site_admin":false},"html_url":"https://github.com/zta6/ddf","description":"DDF Distributed Data Framework - an open source, modular integration framework.","fork":true,"url":"https://api.github.com/repos/zta6/ddf","forks_url":"https://api.github.com/repos/zta6/ddf/forks","keys_url":"https://api.github.com/repos/zta6/ddf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zta6/ddf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zta6/ddf/teams","hooks_url":"https://api.github.com/repos/zta6/ddf/hooks","issue_events_url":"https://api.github.com/repos/zta6/ddf/issues/events{/number}","events_url":"https://api.github.com/repos/zta6/ddf/events","assignees_url":"https://api.github.com/repos/zta6/ddf/assignees{/user}","branches_url":"https://api.github.com/repos/zta6/ddf/branches{/branch}","tags_url":"https://api.github.com/repos/zta6/ddf/tags","blobs_url":"https://api.github.com/repos/zta6/ddf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zta6/ddf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zta6/ddf/git/refs{/sha}","trees_url":"https://api.github.com/repos/zta6/ddf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zta6/ddf/statuses/{sha}","languages_url":"https://api.github.com/repos/zta6/ddf/languages","stargazers_url":"https://api.github.com/repos/zta6/ddf/stargazers","contributors_url":"https://api.github.com/repos/zta6/ddf/contributors","subscribers_url":"https://api.github.com/repos/zta6/ddf/subscribers","subscription_url":"https://api.github.com/repos/zta6/ddf/subscription","commits_url":"https://api.github.com/repos/zta6/ddf/commits{/sha}","git_commits_url":"https://api.github.com/repos/zta6/ddf/git/commits{/sha}","comments_url":"https://api.github.com/repos/zta6/ddf/comments{/number}","issue_comment_url":"https://api.github.com/repos/zta6/ddf/issues/comments{/number}","contents_url":"https://api.github.com/repos/zta6/ddf/contents/{+path}","compare_url":"https://api.github.com/repos/zta6/ddf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zta6/ddf/merges","archive_url":"https://api.github.com/repos/zta6/ddf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zta6/ddf/downloads","issues_url":"https://api.github.com/repos/zta6/ddf/issues{/number}","pulls_url":"https://api.github.com/repos/zta6/ddf/pulls{/number}","milestones_url":"https://api.github.com/repos/zta6/ddf/milestones{/number}","notifications_url":"https://api.github.com/repos/zta6/ddf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zta6/ddf/labels{/name}","releases_url":"https://api.github.com/repos/zta6/ddf/releases{/id}","deployments_url":"https://api.github.com/repos/zta6/ddf/deployments","created_at":"2018-10-08T16:55:09Z","updated_at":"2018-12-27T02:09:40Z","pushed_at":"2018-12-27T02:09:38Z","git_url":"git://github.com/zta6/ddf.git","ssh_url":"git@github.com:zta6/ddf.git","clone_url":"https://github.com/zta6/ddf.git","svn_url":"https://github.com/zta6/ddf","homepage":"http://ddf.codice.org","size":411218,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"codice:master","ref":"master","sha":"15a90b7a5662d6d6eacfc70dcd6a1618171857b0","user":{"login":"codice","id":2386734,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzODY3MzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/2386734?v=4","gravatar_id":"","url":"https://api.github.com/users/codice","html_url":"https://github.com/codice","followers_url":"https://api.github.com/users/codice/followers","following_url":"https://api.github.com/users/codice/following{/other_user}","gists_url":"https://api.github.com/users/codice/gists{/gist_id}","starred_url":"https://api.github.com/users/codice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codice/subscriptions","organizations_url":"https://api.github.com/users/codice/orgs","repos_url":"https://api.github.com/users/codice/repos","events_url":"https://api.github.com/users/codice/events{/privacy}","received_events_url":"https://api.github.com/users/codice/received_events","type":"Organization","site_admin":false},"repo":{"id":15173563,"node_id":"MDEwOlJlcG9zaXRvcnkxNTE3MzU2Mw==","name":"ddf","full_name":"codice/ddf","private":false,"owner":{"login":"codice","id":2386734,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzODY3MzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/2386734?v=4","gravatar_id":"","url":"https://api.github.com/users/codice","html_url":"https://github.com/codice","followers_url":"https://api.github.com/users/codice/followers","following_url":"https://api.github.com/users/codice/following{/other_user}","gists_url":"https://api.github.com/users/codice/gists{/gist_id}","starred_url":"https://api.github.com/users/codice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codice/subscriptions","organizations_url":"https://api.github.com/users/codice/orgs","repos_url":"https://api.github.com/users/codice/repos","events_url":"https://api.github.com/users/codice/events{/privacy}","received_events_url":"https://api.github.com/users/codice/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/codice/ddf","description":"DDF Distributed Data Framework - an open source, modular integration framework.","fork":false,"url":"https://api.github.com/repos/codice/ddf","forks_url":"https://api.github.com/repos/codice/ddf/forks","keys_url":"https://api.github.com/repos/codice/ddf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codice/ddf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codice/ddf/teams","hooks_url":"https://api.github.com/repos/codice/ddf/hooks","issue_events_url":"https://api.github.com/repos/codice/ddf/issues/events{/number}","events_url":"https://api.github.com/repos/codice/ddf/events","assignees_url":"https://api.github.com/repos/codice/ddf/assignees{/user}","branches_url":"https://api.github.com/repos/codice/ddf/branches{/branch}","tags_url":"https://api.github.com/repos/codice/ddf/tags","blobs_url":"https://api.github.com/repos/codice/ddf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codice/ddf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codice/ddf/git/refs{/sha}","trees_url":"https://api.github.com/repos/codice/ddf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codice/ddf/statuses/{sha}","languages_url":"https://api.github.com/repos/codice/ddf/languages","stargazers_url":"https://api.github.com/repos/codice/ddf/stargazers","contributors_url":"https://api.github.com/repos/codice/ddf/contributors","subscribers_url":"https://api.github.com/repos/codice/ddf/subscribers","subscription_url":"https://api.github.com/repos/codice/ddf/subscription","commits_url":"https://api.github.com/repos/codice/ddf/commits{/sha}","git_commits_url":"https://api.github.com/repos/codice/ddf/git/commits{/sha}","comments_url":"https://api.github.com/repos/codice/ddf/comments{/number}","issue_comment_url":"https://api.github.com/repos/codice/ddf/issues/comments{/number}","contents_url":"https://api.github.com/repos/codice/ddf/contents/{+path}","compare_url":"https://api.github.com/repos/codice/ddf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codice/ddf/merges","archive_url":"https://api.github.com/repos/codice/ddf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codice/ddf/downloads","issues_url":"https://api.github.com/repos/codice/ddf/issues{/number}","pulls_url":"https://api.github.com/repos/codice/ddf/pulls{/number}","milestones_url":"https://api.github.com/repos/codice/ddf/milestones{/number}","notifications_url":"https://api.github.com/repos/codice/ddf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codice/ddf/labels{/name}","releases_url":"https://api.github.com/repos/codice/ddf/releases{/id}","deployments_url":"https://api.github.com/repos/codice/ddf/deployments","created_at":"2013-12-13T20:38:28Z","updated_at":"2018-12-21T19:52:16Z","pushed_at":"2018-12-27T17:20:48Z","git_url":"git://github.com/codice/ddf.git","ssh_url":"git@github.com:codice/ddf.git","clone_url":"https://github.com/codice/ddf.git","svn_url":"https://github.com/codice/ddf","homepage":"http://ddf.codice.org","size":416284,"stargazers_count":93,"watchers_count":93,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":158,"mirror_url":null,"archived":false,"open_issues_count":27,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":158,"open_issues":27,"watchers":93,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/codice/ddf/pulls/4167"},"html":{"href":"https://github.com/codice/ddf/pull/4167"},"issue":{"href":"https://api.github.com/repos/codice/ddf/issues/4167"},"comments":{"href":"https://api.github.com/repos/codice/ddf/issues/4167/comments"},"review_comments":{"href":"https://api.github.com/repos/codice/ddf/pulls/4167/comments"},"review_comment":{"href":"https://api.github.com/repos/codice/ddf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/codice/ddf/pulls/4167/commits"},"statuses":{"href":"https://api.github.com/repos/codice/ddf/statuses/d5fc62ecbfc22fd0f46f2d370a002bafb6f1d4f3"}},"author_association":"NONE"}}
{"actor":{"display_login":"willwill96"}}