{"action":"created","comment":{"url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/pulls/comments/215202943","pull_request_review_id":152414995,"id":215202943,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNTIwMjk0Mw==","diff_hunk":"@@ -146,3 +146,4 @@ invalid.format.specifier = unknown format conversion ''{0}''\n invalid.task.config = Task scheduling configuration is invalid\n task.already.running = The task is already running\n task.not.running = The task in not running\n+illegal.format.conversion = illegal format conversion ''{0}''","path":"bvm/ballerina-core/src/main/resources/MessagesBundle_en_US.properties","position":4,"original_position":4,"commit_id":"3d74c4b9be2d84f136c1fbcece06f46dbba51c64","original_commit_id":"3d74c4b9be2d84f136c1fbcece06f46dbba51c64","user":{"login":"riyafa","id":8238078,"node_id":"MDQ6VXNlcjgyMzgwNzg=","avatar_url":"https://avatars2.githubusercontent.com/u/8238078?v=4","gravatar_id":"","url":"https://api.github.com/users/riyafa","html_url":"https://github.com/riyafa","followers_url":"https://api.github.com/users/riyafa/followers","following_url":"https://api.github.com/users/riyafa/following{/other_user}","gists_url":"https://api.github.com/users/riyafa/gists{/gist_id}","starred_url":"https://api.github.com/users/riyafa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riyafa/subscriptions","organizations_url":"https://api.github.com/users/riyafa/orgs","repos_url":"https://api.github.com/users/riyafa/repos","events_url":"https://api.github.com/users/riyafa/events{/privacy}","received_events_url":"https://api.github.com/users/riyafa/received_events","type":"User","site_admin":false},"body":"Since we use %s to give string representation for all supported types in Ballerina, is it a good idea to make everything uppercase? I mean it would uppercase xml/json value if someone tries to print it using %S","created_at":"2018-09-05T09:46:24Z","updated_at":"2018-09-05T09:46:24Z","html_url":"https://github.com/ballerina-platform/ballerina-lang/pull/10282#discussion_r215202943","pull_request_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/pulls/10282","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ballerina-platform/ballerina-lang/pulls/comments/215202943"},"html":{"href":"https://github.com/ballerina-platform/ballerina-lang/pull/10282#discussion_r215202943"},"pull_request":{"href":"https://api.github.com/repos/ballerina-platform/ballerina-lang/pulls/10282"}},"in_reply_to_id":215136407},"pull_request":{"url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/pulls/10282","id":212882425,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyODgyNDI1","html_url":"https://github.com/ballerina-platform/ballerina-lang/pull/10282","diff_url":"https://github.com/ballerina-platform/ballerina-lang/pull/10282.diff","patch_url":"https://github.com/ballerina-platform/ballerina-lang/pull/10282.patch","issue_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/issues/10282","number":10282,"state":"open","locked":false,"title":"Improve sprintf function","user":{"login":"riyafa","id":8238078,"node_id":"MDQ6VXNlcjgyMzgwNzg=","avatar_url":"https://avatars2.githubusercontent.com/u/8238078?v=4","gravatar_id":"","url":"https://api.github.com/users/riyafa","html_url":"https://github.com/riyafa","followers_url":"https://api.github.com/users/riyafa/followers","following_url":"https://api.github.com/users/riyafa/following{/other_user}","gists_url":"https://api.github.com/users/riyafa/gists{/gist_id}","starred_url":"https://api.github.com/users/riyafa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riyafa/subscriptions","organizations_url":"https://api.github.com/users/riyafa/orgs","repos_url":"https://api.github.com/users/riyafa/repos","events_url":"https://api.github.com/users/riyafa/events{/privacy}","received_events_url":"https://api.github.com/users/riyafa/received_events","type":"User","site_admin":false},"body":"## Purpose\r\n- Improve documentation of the sprintf function\r\n- %s specifier would give string representation for all supported types in Ballerina\r\n- %b and %B would support lowercase and uppercase of boolean value\r\n- Remove format specifier for the binary type\r\n- Handle illegal format conversion errors appropriately\r\n\r\nResolve https://github.com/ballerina-platform/ballerina-lang/issues/9323\r\nResolve https://github.com/ballerina-platform/ballerina-lang/issues/10276\r\nResolve https://github.com/ballerina-platform/ballerina-lang/issues/8969","created_at":"2018-09-04T07:41:52Z","updated_at":"2018-09-05T09:46:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e4b2e9617cba728fb319832ad63aad3d486f937d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":830057046,"node_id":"MDU6TGFiZWw4MzAwNTcwNDY=","url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/labels/Component/stdlib","name":"Component/stdlib","color":"006b75","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/pulls/10282/commits","review_comments_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/pulls/10282/comments","review_comment_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/issues/10282/comments","statuses_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/statuses/3d74c4b9be2d84f136c1fbcece06f46dbba51c64","head":{"label":"ballerina-platform:sprintf","ref":"sprintf","sha":"3d74c4b9be2d84f136c1fbcece06f46dbba51c64","user":{"login":"ballerina-platform","id":34733518,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NzMzNTE4","avatar_url":"https://avatars2.githubusercontent.com/u/34733518?v=4","gravatar_id":"","url":"https://api.github.com/users/ballerina-platform","html_url":"https://github.com/ballerina-platform","followers_url":"https://api.github.com/users/ballerina-platform/followers","following_url":"https://api.github.com/users/ballerina-platform/following{/other_user}","gists_url":"https://api.github.com/users/ballerina-platform/gists{/gist_id}","starred_url":"https://api.github.com/users/ballerina-platform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ballerina-platform/subscriptions","organizations_url":"https://api.github.com/users/ballerina-platform/orgs","repos_url":"https://api.github.com/users/ballerina-platform/repos","events_url":"https://api.github.com/users/ballerina-platform/events{/privacy}","received_events_url":"https://api.github.com/users/ballerina-platform/received_events","type":"Organization","site_admin":false},"repo":{"id":73930305,"node_id":"MDEwOlJlcG9zaXRvcnk3MzkzMDMwNQ==","name":"ballerina-lang","full_name":"ballerina-platform/ballerina-lang","owner":{"login":"ballerina-platform","id":34733518,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NzMzNTE4","avatar_url":"https://avatars2.githubusercontent.com/u/34733518?v=4","gravatar_id":"","url":"https://api.github.com/users/ballerina-platform","html_url":"https://github.com/ballerina-platform","followers_url":"https://api.github.com/users/ballerina-platform/followers","following_url":"https://api.github.com/users/ballerina-platform/following{/other_user}","gists_url":"https://api.github.com/users/ballerina-platform/gists{/gist_id}","starred_url":"https://api.github.com/users/ballerina-platform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ballerina-platform/subscriptions","organizations_url":"https://api.github.com/users/ballerina-platform/orgs","repos_url":"https://api.github.com/users/ballerina-platform/repos","events_url":"https://api.github.com/users/ballerina-platform/events{/privacy}","received_events_url":"https://api.github.com/users/ballerina-platform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ballerina-platform/ballerina-lang","description":"Ballerina is a compiled, transactional, statically and strongly typed programming language with textual and graphical syntaxes.","fork":false,"url":"https://api.github.com/repos/ballerina-platform/ballerina-lang","forks_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/forks","keys_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/teams","hooks_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/hooks","issue_events_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/issues/events{/number}","events_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/events","assignees_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/assignees{/user}","branches_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/branches{/branch}","tags_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/tags","blobs_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/git/refs{/sha}","trees_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/statuses/{sha}","languages_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/languages","stargazers_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/stargazers","contributors_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/contributors","subscribers_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/subscribers","subscription_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/subscription","commits_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/commits{/sha}","git_commits_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/git/commits{/sha}","comments_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/comments{/number}","issue_comment_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/issues/comments{/number}","contents_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/contents/{+path}","compare_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/merges","archive_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/downloads","issues_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/issues{/number}","pulls_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/pulls{/number}","milestones_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/milestones{/number}","notifications_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/labels{/name}","releases_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/releases{/id}","deployments_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/deployments","created_at":"2016-11-16T14:58:44Z","updated_at":"2018-09-05T06:52:43Z","pushed_at":"2018-09-05T07:39:47Z","git_url":"git://github.com/ballerina-platform/ballerina-lang.git","ssh_url":"git@github.com:ballerina-platform/ballerina-lang.git","clone_url":"https://github.com/ballerina-platform/ballerina-lang.git","svn_url":"https://github.com/ballerina-platform/ballerina-lang","homepage":"","size":252178,"stargazers_count":1260,"watchers_count":1260,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":389,"mirror_url":null,"archived":false,"open_issues_count":588,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":389,"open_issues":588,"watchers":1260,"default_branch":"master"}},"base":{"label":"ballerina-platform:master","ref":"master","sha":"18eb21f91c809bd4ef8845c5b4b1d84a7670e5b0","user":{"login":"ballerina-platform","id":34733518,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NzMzNTE4","avatar_url":"https://avatars2.githubusercontent.com/u/34733518?v=4","gravatar_id":"","url":"https://api.github.com/users/ballerina-platform","html_url":"https://github.com/ballerina-platform","followers_url":"https://api.github.com/users/ballerina-platform/followers","following_url":"https://api.github.com/users/ballerina-platform/following{/other_user}","gists_url":"https://api.github.com/users/ballerina-platform/gists{/gist_id}","starred_url":"https://api.github.com/users/ballerina-platform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ballerina-platform/subscriptions","organizations_url":"https://api.github.com/users/ballerina-platform/orgs","repos_url":"https://api.github.com/users/ballerina-platform/repos","events_url":"https://api.github.com/users/ballerina-platform/events{/privacy}","received_events_url":"https://api.github.com/users/ballerina-platform/received_events","type":"Organization","site_admin":false},"repo":{"id":73930305,"node_id":"MDEwOlJlcG9zaXRvcnk3MzkzMDMwNQ==","name":"ballerina-lang","full_name":"ballerina-platform/ballerina-lang","owner":{"login":"ballerina-platform","id":34733518,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NzMzNTE4","avatar_url":"https://avatars2.githubusercontent.com/u/34733518?v=4","gravatar_id":"","url":"https://api.github.com/users/ballerina-platform","html_url":"https://github.com/ballerina-platform","followers_url":"https://api.github.com/users/ballerina-platform/followers","following_url":"https://api.github.com/users/ballerina-platform/following{/other_user}","gists_url":"https://api.github.com/users/ballerina-platform/gists{/gist_id}","starred_url":"https://api.github.com/users/ballerina-platform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ballerina-platform/subscriptions","organizations_url":"https://api.github.com/users/ballerina-platform/orgs","repos_url":"https://api.github.com/users/ballerina-platform/repos","events_url":"https://api.github.com/users/ballerina-platform/events{/privacy}","received_events_url":"https://api.github.com/users/ballerina-platform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ballerina-platform/ballerina-lang","description":"Ballerina is a compiled, transactional, statically and strongly typed programming language with textual and graphical syntaxes.","fork":false,"url":"https://api.github.com/repos/ballerina-platform/ballerina-lang","forks_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/forks","keys_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/teams","hooks_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/hooks","issue_events_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/issues/events{/number}","events_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/events","assignees_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/assignees{/user}","branches_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/branches{/branch}","tags_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/tags","blobs_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/git/refs{/sha}","trees_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/statuses/{sha}","languages_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/languages","stargazers_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/stargazers","contributors_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/contributors","subscribers_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/subscribers","subscription_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/subscription","commits_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/commits{/sha}","git_commits_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/git/commits{/sha}","comments_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/comments{/number}","issue_comment_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/issues/comments{/number}","contents_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/contents/{+path}","compare_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/merges","archive_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/downloads","issues_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/issues{/number}","pulls_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/pulls{/number}","milestones_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/milestones{/number}","notifications_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/labels{/name}","releases_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/releases{/id}","deployments_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/deployments","created_at":"2016-11-16T14:58:44Z","updated_at":"2018-09-05T06:52:43Z","pushed_at":"2018-09-05T07:39:47Z","git_url":"git://github.com/ballerina-platform/ballerina-lang.git","ssh_url":"git@github.com:ballerina-platform/ballerina-lang.git","clone_url":"https://github.com/ballerina-platform/ballerina-lang.git","svn_url":"https://github.com/ballerina-platform/ballerina-lang","homepage":"","size":252178,"stargazers_count":1260,"watchers_count":1260,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":389,"mirror_url":null,"archived":false,"open_issues_count":588,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":389,"open_issues":588,"watchers":1260,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ballerina-platform/ballerina-lang/pulls/10282"},"html":{"href":"https://github.com/ballerina-platform/ballerina-lang/pull/10282"},"issue":{"href":"https://api.github.com/repos/ballerina-platform/ballerina-lang/issues/10282"},"comments":{"href":"https://api.github.com/repos/ballerina-platform/ballerina-lang/issues/10282/comments"},"review_comments":{"href":"https://api.github.com/repos/ballerina-platform/ballerina-lang/pulls/10282/comments"},"review_comment":{"href":"https://api.github.com/repos/ballerina-platform/ballerina-lang/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ballerina-platform/ballerina-lang/pulls/10282/commits"},"statuses":{"href":"https://api.github.com/repos/ballerina-platform/ballerina-lang/statuses/3d74c4b9be2d84f136c1fbcece06f46dbba51c64"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"riyafa"}}