{"action":"created","comment":{"url":"https://api.github.com/repos/driverdevteam/tdd-course-3/pulls/comments/231792190","pull_request_review_id":172838225,"id":231792190,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMTc5MjE5MA==","diff_hunk":"@@ -40,4 +40,21 @@ TEST(count_words, test_one_word_ret_one_word) {\n     std::map<std::string, uint32_t> expected = {{word, 1}};\n     ASSERT_EQ(count_words(word), expected);\n }\n+\n+TEST(count_words, test_multiple_words_ret_correct) {","path":"tdd_intro/demo/02_word_count/test.cpp","position":27,"original_position":5,"commit_id":"1450b85167189c06b1fa57aba5b391e7e3af3a05","original_commit_id":"3f7bd22eebfa788615ab57a0f720cecdeaf2b06d","user":{"login":"mettizik","id":25243891,"node_id":"MDQ6VXNlcjI1MjQzODkx","avatar_url":"https://avatars0.githubusercontent.com/u/25243891?v=4","gravatar_id":"","url":"https://api.github.com/users/mettizik","html_url":"https://github.com/mettizik","followers_url":"https://api.github.com/users/mettizik/followers","following_url":"https://api.github.com/users/mettizik/following{/other_user}","gists_url":"https://api.github.com/users/mettizik/gists{/gist_id}","starred_url":"https://api.github.com/users/mettizik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mettizik/subscriptions","organizations_url":"https://api.github.com/users/mettizik/orgs","repos_url":"https://api.github.com/users/mettizik/repos","events_url":"https://api.github.com/users/mettizik/events{/privacy}","received_events_url":"https://api.github.com/users/mettizik/received_events","type":"User","site_admin":false},"body":"этот тест всё же сложноват ибо привёл сразу к двум изменениям в логике, а значит у него две причины для сбоя - если уйдёт цикл - он упадёт, если уйдёт += 1 вместо = 1 он тоже упадёт и это нехорошо.\r\nПравильнее было бы написать сначала парсинг просто двух слов с единым вхождением, чтобы породить цикл, а потом тест на повторное значение, чтобы идентифицировать именно тот кусок логики.","created_at":"2018-11-08T08:04:28Z","updated_at":"2018-11-08T08:04:57Z","html_url":"https://github.com/driverdevteam/tdd-course-3/pull/28#discussion_r231792190","pull_request_url":"https://api.github.com/repos/driverdevteam/tdd-course-3/pulls/28","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/driverdevteam/tdd-course-3/pulls/comments/231792190"},"html":{"href":"https://github.com/driverdevteam/tdd-course-3/pull/28#discussion_r231792190"},"pull_request":{"href":"https://api.github.com/repos/driverdevteam/tdd-course-3/pulls/28"}}},"pull_request":{"url":"https://api.github.com/repos/driverdevteam/tdd-course-3/pulls/28","id":229139442,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5MTM5NDQy","html_url":"https://github.com/driverdevteam/tdd-course-3/pull/28","diff_url":"https://github.com/driverdevteam/tdd-course-3/pull/28.diff","patch_url":"https://github.com/driverdevteam/tdd-course-3/pull/28.patch","issue_url":"https://api.github.com/repos/driverdevteam/tdd-course-3/issues/28","number":28,"state":"open","locked":false,"title":"02 word count","user":{"login":"vaffeine","id":12212688,"node_id":"MDQ6VXNlcjEyMjEyNjg4","avatar_url":"https://avatars3.githubusercontent.com/u/12212688?v=4","gravatar_id":"","url":"https://api.github.com/users/vaffeine","html_url":"https://github.com/vaffeine","followers_url":"https://api.github.com/users/vaffeine/followers","following_url":"https://api.github.com/users/vaffeine/following{/other_user}","gists_url":"https://api.github.com/users/vaffeine/gists{/gist_id}","starred_url":"https://api.github.com/users/vaffeine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vaffeine/subscriptions","organizations_url":"https://api.github.com/users/vaffeine/orgs","repos_url":"https://api.github.com/users/vaffeine/repos","events_url":"https://api.github.com/users/vaffeine/events{/privacy}","received_events_url":"https://api.github.com/users/vaffeine/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-11-07T19:18:43Z","updated_at":"2018-11-08T08:04:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4f4843b8df76983847779316e3c028c249479176","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/driverdevteam/tdd-course-3/pulls/28/commits","review_comments_url":"https://api.github.com/repos/driverdevteam/tdd-course-3/pulls/28/comments","review_comment_url":"https://api.github.com/repos/driverdevteam/tdd-course-3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/driverdevteam/tdd-course-3/issues/28/comments","statuses_url":"https://api.github.com/repos/driverdevteam/tdd-course-3/statuses/1450b85167189c06b1fa57aba5b391e7e3af3a05","head":{"label":"vaffeine:02_word_count","ref":"02_word_count","sha":"1450b85167189c06b1fa57aba5b391e7e3af3a05","user":{"login":"vaffeine","id":12212688,"node_id":"MDQ6VXNlcjEyMjEyNjg4","avatar_url":"https://avatars3.githubusercontent.com/u/12212688?v=4","gravatar_id":"","url":"https://api.github.com/users/vaffeine","html_url":"https://github.com/vaffeine","followers_url":"https://api.github.com/users/vaffeine/followers","following_url":"https://api.github.com/users/vaffeine/following{/other_user}","gists_url":"https://api.github.com/users/vaffeine/gists{/gist_id}","starred_url":"https://api.github.com/users/vaffeine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vaffeine/subscriptions","organizations_url":"https://api.github.com/users/vaffeine/orgs","repos_url":"https://api.github.com/users/vaffeine/repos","events_url":"https://api.github.com/users/vaffeine/events{/privacy}","received_events_url":"https://api.github.com/users/vaffeine/received_events","type":"User","site_admin":false},"repo":{"id":154632249,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQ2MzIyNDk=","name":"tdd-course-3","full_name":"vaffeine/tdd-course-3","private":false,"owner":{"login":"vaffeine","id":12212688,"node_id":"MDQ6VXNlcjEyMjEyNjg4","avatar_url":"https://avatars3.githubusercontent.com/u/12212688?v=4","gravatar_id":"","url":"https://api.github.com/users/vaffeine","html_url":"https://github.com/vaffeine","followers_url":"https://api.github.com/users/vaffeine/followers","following_url":"https://api.github.com/users/vaffeine/following{/other_user}","gists_url":"https://api.github.com/users/vaffeine/gists{/gist_id}","starred_url":"https://api.github.com/users/vaffeine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vaffeine/subscriptions","organizations_url":"https://api.github.com/users/vaffeine/orgs","repos_url":"https://api.github.com/users/vaffeine/repos","events_url":"https://api.github.com/users/vaffeine/events{/privacy}","received_events_url":"https://api.github.com/users/vaffeine/received_events","type":"User","site_admin":false},"html_url":"https://github.com/vaffeine/tdd-course-3","description":null,"fork":true,"url":"https://api.github.com/repos/vaffeine/tdd-course-3","forks_url":"https://api.github.com/repos/vaffeine/tdd-course-3/forks","keys_url":"https://api.github.com/repos/vaffeine/tdd-course-3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vaffeine/tdd-course-3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vaffeine/tdd-course-3/teams","hooks_url":"https://api.github.com/repos/vaffeine/tdd-course-3/hooks","issue_events_url":"https://api.github.com/repos/vaffeine/tdd-course-3/issues/events{/number}","events_url":"https://api.github.com/repos/vaffeine/tdd-course-3/events","assignees_url":"https://api.github.com/repos/vaffeine/tdd-course-3/assignees{/user}","branches_url":"https://api.github.com/repos/vaffeine/tdd-course-3/branches{/branch}","tags_url":"https://api.github.com/repos/vaffeine/tdd-course-3/tags","blobs_url":"https://api.github.com/repos/vaffeine/tdd-course-3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vaffeine/tdd-course-3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vaffeine/tdd-course-3/git/refs{/sha}","trees_url":"https://api.github.com/repos/vaffeine/tdd-course-3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vaffeine/tdd-course-3/statuses/{sha}","languages_url":"https://api.github.com/repos/vaffeine/tdd-course-3/languages","stargazers_url":"https://api.github.com/repos/vaffeine/tdd-course-3/stargazers","contributors_url":"https://api.github.com/repos/vaffeine/tdd-course-3/contributors","subscribers_url":"https://api.github.com/repos/vaffeine/tdd-course-3/subscribers","subscription_url":"https://api.github.com/repos/vaffeine/tdd-course-3/subscription","commits_url":"https://api.github.com/repos/vaffeine/tdd-course-3/commits{/sha}","git_commits_url":"https://api.github.com/repos/vaffeine/tdd-course-3/git/commits{/sha}","comments_url":"https://api.github.com/repos/vaffeine/tdd-course-3/comments{/number}","issue_comment_url":"https://api.github.com/repos/vaffeine/tdd-course-3/issues/comments{/number}","contents_url":"https://api.github.com/repos/vaffeine/tdd-course-3/contents/{+path}","compare_url":"https://api.github.com/repos/vaffeine/tdd-course-3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vaffeine/tdd-course-3/merges","archive_url":"https://api.github.com/repos/vaffeine/tdd-course-3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vaffeine/tdd-course-3/downloads","issues_url":"https://api.github.com/repos/vaffeine/tdd-course-3/issues{/number}","pulls_url":"https://api.github.com/repos/vaffeine/tdd-course-3/pulls{/number}","milestones_url":"https://api.github.com/repos/vaffeine/tdd-course-3/milestones{/number}","notifications_url":"https://api.github.com/repos/vaffeine/tdd-course-3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vaffeine/tdd-course-3/labels{/name}","releases_url":"https://api.github.com/repos/vaffeine/tdd-course-3/releases{/id}","deployments_url":"https://api.github.com/repos/vaffeine/tdd-course-3/deployments","created_at":"2018-10-25T07:59:02Z","updated_at":"2018-11-07T19:57:14Z","pushed_at":"2018-11-07T19:57:13Z","git_url":"git://github.com/vaffeine/tdd-course-3.git","ssh_url":"git@github.com:vaffeine/tdd-course-3.git","clone_url":"https://github.com/vaffeine/tdd-course-3.git","svn_url":"https://github.com/vaffeine/tdd-course-3","homepage":null,"size":1072,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"driverdevteam:master","ref":"master","sha":"6df6d9662084c3be0fedb94bf419185b626da54a","user":{"login":"driverdevteam","id":38471839,"node_id":"MDQ6VXNlcjM4NDcxODM5","avatar_url":"https://avatars0.githubusercontent.com/u/38471839?v=4","gravatar_id":"","url":"https://api.github.com/users/driverdevteam","html_url":"https://github.com/driverdevteam","followers_url":"https://api.github.com/users/driverdevteam/followers","following_url":"https://api.github.com/users/driverdevteam/following{/other_user}","gists_url":"https://api.github.com/users/driverdevteam/gists{/gist_id}","starred_url":"https://api.github.com/users/driverdevteam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/driverdevteam/subscriptions","organizations_url":"https://api.github.com/users/driverdevteam/orgs","repos_url":"https://api.github.com/users/driverdevteam/repos","events_url":"https://api.github.com/users/driverdevteam/events{/privacy}","received_events_url":"https://api.github.com/users/driverdevteam/received_events","type":"User","site_admin":false},"repo":{"id":148801201,"node_id":"MDEwOlJlcG9zaXRvcnkxNDg4MDEyMDE=","name":"tdd-course-3","full_name":"driverdevteam/tdd-course-3","private":false,"owner":{"login":"driverdevteam","id":38471839,"node_id":"MDQ6VXNlcjM4NDcxODM5","avatar_url":"https://avatars0.githubusercontent.com/u/38471839?v=4","gravatar_id":"","url":"https://api.github.com/users/driverdevteam","html_url":"https://github.com/driverdevteam","followers_url":"https://api.github.com/users/driverdevteam/followers","following_url":"https://api.github.com/users/driverdevteam/following{/other_user}","gists_url":"https://api.github.com/users/driverdevteam/gists{/gist_id}","starred_url":"https://api.github.com/users/driverdevteam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/driverdevteam/subscriptions","organizations_url":"https://api.github.com/users/driverdevteam/orgs","repos_url":"https://api.github.com/users/driverdevteam/repos","events_url":"https://api.github.com/users/driverdevteam/events{/privacy}","received_events_url":"https://api.github.com/users/driverdevteam/received_events","type":"User","site_admin":false},"html_url":"https://github.com/driverdevteam/tdd-course-3","description":null,"fork":false,"url":"https://api.github.com/repos/driverdevteam/tdd-course-3","forks_url":"https://api.github.com/repos/driverdevteam/tdd-course-3/forks","keys_url":"https://api.github.com/repos/driverdevteam/tdd-course-3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/driverdevteam/tdd-course-3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/driverdevteam/tdd-course-3/teams","hooks_url":"https://api.github.com/repos/driverdevteam/tdd-course-3/hooks","issue_events_url":"https://api.github.com/repos/driverdevteam/tdd-course-3/issues/events{/number}","events_url":"https://api.github.com/repos/driverdevteam/tdd-course-3/events","assignees_url":"https://api.github.com/repos/driverdevteam/tdd-course-3/assignees{/user}","branches_url":"https://api.github.com/repos/driverdevteam/tdd-course-3/branches{/branch}","tags_url":"https://api.github.com/repos/driverdevteam/tdd-course-3/tags","blobs_url":"https://api.github.com/repos/driverdevteam/tdd-course-3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/driverdevteam/tdd-course-3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/driverdevteam/tdd-course-3/git/refs{/sha}","trees_url":"https://api.github.com/repos/driverdevteam/tdd-course-3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/driverdevteam/tdd-course-3/statuses/{sha}","languages_url":"https://api.github.com/repos/driverdevteam/tdd-course-3/languages","stargazers_url":"https://api.github.com/repos/driverdevteam/tdd-course-3/stargazers","contributors_url":"https://api.github.com/repos/driverdevteam/tdd-course-3/contributors","subscribers_url":"https://api.github.com/repos/driverdevteam/tdd-course-3/subscribers","subscription_url":"https://api.github.com/repos/driverdevteam/tdd-course-3/subscription","commits_url":"https://api.github.com/repos/driverdevteam/tdd-course-3/commits{/sha}","git_commits_url":"https://api.github.com/repos/driverdevteam/tdd-course-3/git/commits{/sha}","comments_url":"https://api.github.com/repos/driverdevteam/tdd-course-3/comments{/number}","issue_comment_url":"https://api.github.com/repos/driverdevteam/tdd-course-3/issues/comments{/number}","contents_url":"https://api.github.com/repos/driverdevteam/tdd-course-3/contents/{+path}","compare_url":"https://api.github.com/repos/driverdevteam/tdd-course-3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/driverdevteam/tdd-course-3/merges","archive_url":"https://api.github.com/repos/driverdevteam/tdd-course-3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/driverdevteam/tdd-course-3/downloads","issues_url":"https://api.github.com/repos/driverdevteam/tdd-course-3/issues{/number}","pulls_url":"https://api.github.com/repos/driverdevteam/tdd-course-3/pulls{/number}","milestones_url":"https://api.github.com/repos/driverdevteam/tdd-course-3/milestones{/number}","notifications_url":"https://api.github.com/repos/driverdevteam/tdd-course-3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/driverdevteam/tdd-course-3/labels{/name}","releases_url":"https://api.github.com/repos/driverdevteam/tdd-course-3/releases{/id}","deployments_url":"https://api.github.com/repos/driverdevteam/tdd-course-3/deployments","created_at":"2018-09-14T14:39:09Z","updated_at":"2018-11-02T11:44:58Z","pushed_at":"2018-11-07T21:24:17Z","git_url":"git://github.com/driverdevteam/tdd-course-3.git","ssh_url":"git@github.com:driverdevteam/tdd-course-3.git","clone_url":"https://github.com/driverdevteam/tdd-course-3.git","svn_url":"https://github.com/driverdevteam/tdd-course-3","homepage":null,"size":1057,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":30,"license":null,"forks":14,"open_issues":30,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/driverdevteam/tdd-course-3/pulls/28"},"html":{"href":"https://github.com/driverdevteam/tdd-course-3/pull/28"},"issue":{"href":"https://api.github.com/repos/driverdevteam/tdd-course-3/issues/28"},"comments":{"href":"https://api.github.com/repos/driverdevteam/tdd-course-3/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/driverdevteam/tdd-course-3/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/driverdevteam/tdd-course-3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/driverdevteam/tdd-course-3/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/driverdevteam/tdd-course-3/statuses/1450b85167189c06b1fa57aba5b391e7e3af3a05"}},"author_association":"NONE"}}
{"actor":{"display_login":"mettizik"}}