{"action":"created","issue":{"url":"https://api.github.com/repos/foosel/OctoPrint/issues/2312","repository_url":"https://api.github.com/repos/foosel/OctoPrint","labels_url":"https://api.github.com/repos/foosel/OctoPrint/issues/2312/labels{/name}","comments_url":"https://api.github.com/repos/foosel/OctoPrint/issues/2312/comments","events_url":"https://api.github.com/repos/foosel/OctoPrint/issues/2312/events","html_url":"https://github.com/foosel/OctoPrint/issues/2312","id":284049370,"node_id":"MDU6SXNzdWUyODQwNDkzNzA=","number":2312,"title":"Software Update fails with (near) full disk","user":{"login":"tonsofpcs","id":34757554,"node_id":"MDQ6VXNlcjM0NzU3NTU0","avatar_url":"https://avatars1.githubusercontent.com/u/34757554?v=4","gravatar_id":"","url":"https://api.github.com/users/tonsofpcs","html_url":"https://github.com/tonsofpcs","followers_url":"https://api.github.com/users/tonsofpcs/followers","following_url":"https://api.github.com/users/tonsofpcs/following{/other_user}","gists_url":"https://api.github.com/users/tonsofpcs/gists{/gist_id}","starred_url":"https://api.github.com/users/tonsofpcs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tonsofpcs/subscriptions","organizations_url":"https://api.github.com/users/tonsofpcs/orgs","repos_url":"https://api.github.com/users/tonsofpcs/repos","events_url":"https://api.github.com/users/tonsofpcs/events{/privacy}","received_events_url":"https://api.github.com/users/tonsofpcs/received_events","type":"User","site_admin":false},"labels":[{"id":245667686,"node_id":"MDU6TGFiZWwyNDU2Njc2ODY=","url":"https://api.github.com/repos/foosel/OctoPrint/labels/grabbed","name":"grabbed","color":"006b75","default":false},{"id":326275261,"node_id":"MDU6TGFiZWwzMjYyNzUyNjE=","url":"https://api.github.com/repos/foosel/OctoPrint/labels/type:confirmed%20bug","name":"type:confirmed bug","color":"e11d21","default":false},{"id":539203555,"node_id":"MDU6TGFiZWw1MzkyMDM1NTU=","url":"https://api.github.com/repos/foosel/OctoPrint/labels/type:improvement","name":"type:improvement","color":"006b75","default":false},{"id":245667418,"node_id":"MDU6TGFiZWwyNDU2Njc0MTg=","url":"https://api.github.com/repos/foosel/OctoPrint/labels/up-for-grabs","name":"up-for-grabs","color":"006b75","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2017-12-22T01:27:39Z","updated_at":"2018-12-26T17:33:59Z","closed_at":null,"author_association":"NONE","body":"#### What were you doing?\r\nAttempted to run software update from the settings interface - without checking free space first.  Space had been filled by timelapses. \r\n\r\n#### What did you expect to happen?\r\nUpdate to detect a lack of free space and stop, displaying a warning.  \r\n\r\n#### What happened instead?\r\nUpdate attempted to run.\r\nAn update failure notice appeared but I attempted to restart octoprint anyway.  Octoprint no longer starts fully (I receive a 503 Service Unavailable error via http) after this, even after clearing additional space. \r\nOctoPrint is now no longer able to launch.\r\n\r\n#### Did the same happen when running OctoPrint in safe mode?\r\nI am unable to launch, even in safe mode.  Cannot recreate.\r\n\r\n#### Version of OctoPrint\r\nUpdate attempted on 1.3.5rc3 (to 1.3.6)\r\n\r\n#### Operating System running OctoPrint\r\nOctoPi 0.12.0\r\n\r\n#### Printer model & used firmware incl. version\r\nSunhokey i3 clone, Marlin (version unknown)\r\n\r\n#### Browser and Version of Browser, Operating System running Browser\r\nChrome 62, Windows 10\r\n\r\n#### Link to octoprint.log\r\nhttps://gist.github.com/tonsofpcs/6cd777277af2bb5d76bbebb90b189600\r\n\r\nI have read the FAQ."},"comment":{"url":"https://api.github.com/repos/foosel/OctoPrint/issues/comments/449998477","html_url":"https://github.com/foosel/OctoPrint/issues/2312#issuecomment-449998477","issue_url":"https://api.github.com/repos/foosel/OctoPrint/issues/2312","id":449998477,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0OTk5ODQ3Nw==","user":{"login":"techfreek","id":3945675,"node_id":"MDQ6VXNlcjM5NDU2NzU=","avatar_url":"https://avatars2.githubusercontent.com/u/3945675?v=4","gravatar_id":"","url":"https://api.github.com/users/techfreek","html_url":"https://github.com/techfreek","followers_url":"https://api.github.com/users/techfreek/followers","following_url":"https://api.github.com/users/techfreek/following{/other_user}","gists_url":"https://api.github.com/users/techfreek/gists{/gist_id}","starred_url":"https://api.github.com/users/techfreek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/techfreek/subscriptions","organizations_url":"https://api.github.com/users/techfreek/orgs","repos_url":"https://api.github.com/users/techfreek/repos","events_url":"https://api.github.com/users/techfreek/events{/privacy}","received_events_url":"https://api.github.com/users/techfreek/received_events","type":"User","site_admin":false},"created_at":"2018-12-26T17:33:59Z","updated_at":"2018-12-26T17:33:59Z","author_association":"NONE","body":"I'm finally looking at this again. Having a few difficulties, so I thought I might share my current thought on approach. This error came from update_script.py, which is called as a result of using the Update functionality in the webui.\r\n\r\nMy thought was that for each target we plan to update, we should figure out the size of that component (as a rough way of guessing how much extra space they may use during upgrade), and make sure the sum is less than the total amount of disk space remaining. In order to not add bloat elsewhere, I added this as a pre-check as I personally didn't think it made sense to allow some targets to update if we didn't have enough space to update all.\r\n\r\nThe problem I'm hitting is that I'm having trouble finding the installed path of the package. I have found the `update_folder` and `checkout_folder`, but it doesn't always seem set. I'm wondering the installed path doesn't normally matter. So maybe this is a case where I should add a get_path method to the different updaters so I can still maintain abstraction. \r\n\r\nLet me know if you have thoughts on my (admittedly rambling) thoughts. Thanks!"}}
{"actor":{"display_login":"techfreek"}}