{"action":"created","comment":{"url":"https://api.github.com/repos/Chocobozzz/PeerTube/pulls/comments/213021052","pull_request_review_id":149767557,"id":213021052,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMzAyMTA1Mg==","diff_hunk":"@@ -0,0 +1,5 @@\n+import { Video } from '@app/shared/video/video.model'\n+\n+export interface RecommendationService {\n+  getRecommendations (uuid: string): Promise<Video[]>","path":"client/src/app/videos/recommendations/recommendations.service.ts","position":4,"original_position":4,"commit_id":"d6a5f3bafba9565797be7a85d7103cf9e44b41e3","original_commit_id":"d6a5f3bafba9565797be7a85d7103cf9e44b41e3","user":{"login":"bradsk88","id":2147630,"node_id":"MDQ6VXNlcjIxNDc2MzA=","avatar_url":"https://avatars1.githubusercontent.com/u/2147630?v=4","gravatar_id":"","url":"https://api.github.com/users/bradsk88","html_url":"https://github.com/bradsk88","followers_url":"https://api.github.com/users/bradsk88/followers","following_url":"https://api.github.com/users/bradsk88/following{/other_user}","gists_url":"https://api.github.com/users/bradsk88/gists{/gist_id}","starred_url":"https://api.github.com/users/bradsk88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradsk88/subscriptions","organizations_url":"https://api.github.com/users/bradsk88/orgs","repos_url":"https://api.github.com/users/bradsk88/repos","events_url":"https://api.github.com/users/bradsk88/events{/privacy}","received_events_url":"https://api.github.com/users/bradsk88/received_events","type":"User","site_admin":false},"body":"Sure, I'm happy to stick to this project's conventions.  Will update later today.","created_at":"2018-08-27T15:43:08Z","updated_at":"2018-08-27T15:43:08Z","html_url":"https://github.com/Chocobozzz/PeerTube/pull/969#discussion_r213021052","pull_request_url":"https://api.github.com/repos/Chocobozzz/PeerTube/pulls/969","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Chocobozzz/PeerTube/pulls/comments/213021052"},"html":{"href":"https://github.com/Chocobozzz/PeerTube/pull/969#discussion_r213021052"},"pull_request":{"href":"https://api.github.com/repos/Chocobozzz/PeerTube/pulls/969"}},"in_reply_to_id":212886138},"pull_request":{"url":"https://api.github.com/repos/Chocobozzz/PeerTube/pulls/969","id":210993474,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwOTkzNDc0","html_url":"https://github.com/Chocobozzz/PeerTube/pull/969","diff_url":"https://github.com/Chocobozzz/PeerTube/pull/969.diff","patch_url":"https://github.com/Chocobozzz/PeerTube/pull/969.patch","issue_url":"https://api.github.com/repos/Chocobozzz/PeerTube/issues/969","number":969,"state":"open","locked":false,"title":"Refactor: Separated \"Other Videos\" section into a dedicated component/service","user":{"login":"bradsk88","id":2147630,"node_id":"MDQ6VXNlcjIxNDc2MzA=","avatar_url":"https://avatars1.githubusercontent.com/u/2147630?v=4","gravatar_id":"","url":"https://api.github.com/users/bradsk88","html_url":"https://github.com/bradsk88","followers_url":"https://api.github.com/users/bradsk88/followers","following_url":"https://api.github.com/users/bradsk88/following{/other_user}","gists_url":"https://api.github.com/users/bradsk88/gists{/gist_id}","starred_url":"https://api.github.com/users/bradsk88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradsk88/subscriptions","organizations_url":"https://api.github.com/users/bradsk88/orgs","repos_url":"https://api.github.com/users/bradsk88/repos","events_url":"https://api.github.com/users/bradsk88/events{/privacy}","received_events_url":"https://api.github.com/users/bradsk88/received_events","type":"User","site_admin":false},"body":"This should be a pure refactor.  The existing behavior of the \"Other Videos\"\r\nsection should remain the way it was before. \r\n\r\n---\r\n\r\nI'm currently working on some proof-of-concepts for recommendation\r\nproviders that could work with PeerTube to provide useful video\r\nsuggestions to the user.\r\n\r\nMore info [here](http://github.com/bradsk88/peertube-recommendations) and [here](https://framacolibri.org/t/suggestion-video/3415/13)\r\n\r\nAs a first step, I want to have great clarity about how PeerTube,\r\nitself, will surface these videos to the user.\r\n\r\nWith this branch, I'm refactoring the \"recommendations\" section to \r\nmake it easier to swap out different recommender implementations \r\nquickly.\r\n\r\n### Proof of performance\r\n(this video was recorded on my instance, running the code in this PR)\r\n![ezgif com-video-to-gif](https://user-images.githubusercontent.com/2147630/44638115-60c9bd80-a972-11e8-8e77-fa5cd9703488.gif)\r\n","created_at":"2018-08-27T02:56:10Z","updated_at":"2018-08-27T15:43:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1000dbbbee109ed158d089c2b6ad5c7855d28fdb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Chocobozzz/PeerTube/pulls/969/commits","review_comments_url":"https://api.github.com/repos/Chocobozzz/PeerTube/pulls/969/comments","review_comment_url":"https://api.github.com/repos/Chocobozzz/PeerTube/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Chocobozzz/PeerTube/issues/969/comments","statuses_url":"https://api.github.com/repos/Chocobozzz/PeerTube/statuses/d6a5f3bafba9565797be7a85d7103cf9e44b41e3","head":{"label":"bradsk88:develop","ref":"develop","sha":"d6a5f3bafba9565797be7a85d7103cf9e44b41e3","user":{"login":"bradsk88","id":2147630,"node_id":"MDQ6VXNlcjIxNDc2MzA=","avatar_url":"https://avatars1.githubusercontent.com/u/2147630?v=4","gravatar_id":"","url":"https://api.github.com/users/bradsk88","html_url":"https://github.com/bradsk88","followers_url":"https://api.github.com/users/bradsk88/followers","following_url":"https://api.github.com/users/bradsk88/following{/other_user}","gists_url":"https://api.github.com/users/bradsk88/gists{/gist_id}","starred_url":"https://api.github.com/users/bradsk88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradsk88/subscriptions","organizations_url":"https://api.github.com/users/bradsk88/orgs","repos_url":"https://api.github.com/users/bradsk88/repos","events_url":"https://api.github.com/users/bradsk88/events{/privacy}","received_events_url":"https://api.github.com/users/bradsk88/received_events","type":"User","site_admin":false},"repo":{"id":146216480,"node_id":"MDEwOlJlcG9zaXRvcnkxNDYyMTY0ODA=","name":"PeerTube","full_name":"bradsk88/PeerTube","owner":{"login":"bradsk88","id":2147630,"node_id":"MDQ6VXNlcjIxNDc2MzA=","avatar_url":"https://avatars1.githubusercontent.com/u/2147630?v=4","gravatar_id":"","url":"https://api.github.com/users/bradsk88","html_url":"https://github.com/bradsk88","followers_url":"https://api.github.com/users/bradsk88/followers","following_url":"https://api.github.com/users/bradsk88/following{/other_user}","gists_url":"https://api.github.com/users/bradsk88/gists{/gist_id}","starred_url":"https://api.github.com/users/bradsk88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradsk88/subscriptions","organizations_url":"https://api.github.com/users/bradsk88/orgs","repos_url":"https://api.github.com/users/bradsk88/repos","events_url":"https://api.github.com/users/bradsk88/events{/privacy}","received_events_url":"https://api.github.com/users/bradsk88/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bradsk88/PeerTube","description":"Federated (ActivityPub) video streaming platform using P2P (BitTorrent) directly in the web browser with WebTorrent and Angular.","fork":true,"url":"https://api.github.com/repos/bradsk88/PeerTube","forks_url":"https://api.github.com/repos/bradsk88/PeerTube/forks","keys_url":"https://api.github.com/repos/bradsk88/PeerTube/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bradsk88/PeerTube/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bradsk88/PeerTube/teams","hooks_url":"https://api.github.com/repos/bradsk88/PeerTube/hooks","issue_events_url":"https://api.github.com/repos/bradsk88/PeerTube/issues/events{/number}","events_url":"https://api.github.com/repos/bradsk88/PeerTube/events","assignees_url":"https://api.github.com/repos/bradsk88/PeerTube/assignees{/user}","branches_url":"https://api.github.com/repos/bradsk88/PeerTube/branches{/branch}","tags_url":"https://api.github.com/repos/bradsk88/PeerTube/tags","blobs_url":"https://api.github.com/repos/bradsk88/PeerTube/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bradsk88/PeerTube/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bradsk88/PeerTube/git/refs{/sha}","trees_url":"https://api.github.com/repos/bradsk88/PeerTube/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bradsk88/PeerTube/statuses/{sha}","languages_url":"https://api.github.com/repos/bradsk88/PeerTube/languages","stargazers_url":"https://api.github.com/repos/bradsk88/PeerTube/stargazers","contributors_url":"https://api.github.com/repos/bradsk88/PeerTube/contributors","subscribers_url":"https://api.github.com/repos/bradsk88/PeerTube/subscribers","subscription_url":"https://api.github.com/repos/bradsk88/PeerTube/subscription","commits_url":"https://api.github.com/repos/bradsk88/PeerTube/commits{/sha}","git_commits_url":"https://api.github.com/repos/bradsk88/PeerTube/git/commits{/sha}","comments_url":"https://api.github.com/repos/bradsk88/PeerTube/comments{/number}","issue_comment_url":"https://api.github.com/repos/bradsk88/PeerTube/issues/comments{/number}","contents_url":"https://api.github.com/repos/bradsk88/PeerTube/contents/{+path}","compare_url":"https://api.github.com/repos/bradsk88/PeerTube/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bradsk88/PeerTube/merges","archive_url":"https://api.github.com/repos/bradsk88/PeerTube/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bradsk88/PeerTube/downloads","issues_url":"https://api.github.com/repos/bradsk88/PeerTube/issues{/number}","pulls_url":"https://api.github.com/repos/bradsk88/PeerTube/pulls{/number}","milestones_url":"https://api.github.com/repos/bradsk88/PeerTube/milestones{/number}","notifications_url":"https://api.github.com/repos/bradsk88/PeerTube/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bradsk88/PeerTube/labels{/name}","releases_url":"https://api.github.com/repos/bradsk88/PeerTube/releases{/id}","deployments_url":"https://api.github.com/repos/bradsk88/PeerTube/deployments","created_at":"2018-08-26T21:06:31Z","updated_at":"2018-08-27T03:25:03Z","pushed_at":"2018-08-27T03:25:01Z","git_url":"git://github.com/bradsk88/PeerTube.git","ssh_url":"git@github.com:bradsk88/PeerTube.git","clone_url":"https://github.com/bradsk88/PeerTube.git","svn_url":"https://github.com/bradsk88/PeerTube","homepage":"","size":13536,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"Chocobozzz:develop","ref":"develop","sha":"6bd9f2f11da2ea998a3c4c533a8dd5c6a70eaf02","user":{"login":"Chocobozzz","id":5180488,"node_id":"MDQ6VXNlcjUxODA0ODg=","avatar_url":"https://avatars0.githubusercontent.com/u/5180488?v=4","gravatar_id":"","url":"https://api.github.com/users/Chocobozzz","html_url":"https://github.com/Chocobozzz","followers_url":"https://api.github.com/users/Chocobozzz/followers","following_url":"https://api.github.com/users/Chocobozzz/following{/other_user}","gists_url":"https://api.github.com/users/Chocobozzz/gists{/gist_id}","starred_url":"https://api.github.com/users/Chocobozzz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Chocobozzz/subscriptions","organizations_url":"https://api.github.com/users/Chocobozzz/orgs","repos_url":"https://api.github.com/users/Chocobozzz/repos","events_url":"https://api.github.com/users/Chocobozzz/events{/privacy}","received_events_url":"https://api.github.com/users/Chocobozzz/received_events","type":"User","site_admin":false},"repo":{"id":45213667,"node_id":"MDEwOlJlcG9zaXRvcnk0NTIxMzY2Nw==","name":"PeerTube","full_name":"Chocobozzz/PeerTube","owner":{"login":"Chocobozzz","id":5180488,"node_id":"MDQ6VXNlcjUxODA0ODg=","avatar_url":"https://avatars0.githubusercontent.com/u/5180488?v=4","gravatar_id":"","url":"https://api.github.com/users/Chocobozzz","html_url":"https://github.com/Chocobozzz","followers_url":"https://api.github.com/users/Chocobozzz/followers","following_url":"https://api.github.com/users/Chocobozzz/following{/other_user}","gists_url":"https://api.github.com/users/Chocobozzz/gists{/gist_id}","starred_url":"https://api.github.com/users/Chocobozzz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Chocobozzz/subscriptions","organizations_url":"https://api.github.com/users/Chocobozzz/orgs","repos_url":"https://api.github.com/users/Chocobozzz/repos","events_url":"https://api.github.com/users/Chocobozzz/events{/privacy}","received_events_url":"https://api.github.com/users/Chocobozzz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Chocobozzz/PeerTube","description":"Federated (ActivityPub) video streaming platform using P2P (BitTorrent) directly in the web browser with WebTorrent and Angular.","fork":false,"url":"https://api.github.com/repos/Chocobozzz/PeerTube","forks_url":"https://api.github.com/repos/Chocobozzz/PeerTube/forks","keys_url":"https://api.github.com/repos/Chocobozzz/PeerTube/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Chocobozzz/PeerTube/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Chocobozzz/PeerTube/teams","hooks_url":"https://api.github.com/repos/Chocobozzz/PeerTube/hooks","issue_events_url":"https://api.github.com/repos/Chocobozzz/PeerTube/issues/events{/number}","events_url":"https://api.github.com/repos/Chocobozzz/PeerTube/events","assignees_url":"https://api.github.com/repos/Chocobozzz/PeerTube/assignees{/user}","branches_url":"https://api.github.com/repos/Chocobozzz/PeerTube/branches{/branch}","tags_url":"https://api.github.com/repos/Chocobozzz/PeerTube/tags","blobs_url":"https://api.github.com/repos/Chocobozzz/PeerTube/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Chocobozzz/PeerTube/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Chocobozzz/PeerTube/git/refs{/sha}","trees_url":"https://api.github.com/repos/Chocobozzz/PeerTube/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Chocobozzz/PeerTube/statuses/{sha}","languages_url":"https://api.github.com/repos/Chocobozzz/PeerTube/languages","stargazers_url":"https://api.github.com/repos/Chocobozzz/PeerTube/stargazers","contributors_url":"https://api.github.com/repos/Chocobozzz/PeerTube/contributors","subscribers_url":"https://api.github.com/repos/Chocobozzz/PeerTube/subscribers","subscription_url":"https://api.github.com/repos/Chocobozzz/PeerTube/subscription","commits_url":"https://api.github.com/repos/Chocobozzz/PeerTube/commits{/sha}","git_commits_url":"https://api.github.com/repos/Chocobozzz/PeerTube/git/commits{/sha}","comments_url":"https://api.github.com/repos/Chocobozzz/PeerTube/comments{/number}","issue_comment_url":"https://api.github.com/repos/Chocobozzz/PeerTube/issues/comments{/number}","contents_url":"https://api.github.com/repos/Chocobozzz/PeerTube/contents/{+path}","compare_url":"https://api.github.com/repos/Chocobozzz/PeerTube/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Chocobozzz/PeerTube/merges","archive_url":"https://api.github.com/repos/Chocobozzz/PeerTube/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Chocobozzz/PeerTube/downloads","issues_url":"https://api.github.com/repos/Chocobozzz/PeerTube/issues{/number}","pulls_url":"https://api.github.com/repos/Chocobozzz/PeerTube/pulls{/number}","milestones_url":"https://api.github.com/repos/Chocobozzz/PeerTube/milestones{/number}","notifications_url":"https://api.github.com/repos/Chocobozzz/PeerTube/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Chocobozzz/PeerTube/labels{/name}","releases_url":"https://api.github.com/repos/Chocobozzz/PeerTube/releases{/id}","deployments_url":"https://api.github.com/repos/Chocobozzz/PeerTube/deployments","created_at":"2015-10-29T22:09:42Z","updated_at":"2018-08-27T14:42:47Z","pushed_at":"2018-08-27T14:42:44Z","git_url":"git://github.com/Chocobozzz/PeerTube.git","ssh_url":"git@github.com:Chocobozzz/PeerTube.git","clone_url":"https://github.com/Chocobozzz/PeerTube.git","svn_url":"https://github.com/Chocobozzz/PeerTube","homepage":"","size":13672,"stargazers_count":3830,"watchers_count":3830,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":319,"mirror_url":null,"archived":false,"open_issues_count":155,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":319,"open_issues":155,"watchers":3830,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Chocobozzz/PeerTube/pulls/969"},"html":{"href":"https://github.com/Chocobozzz/PeerTube/pull/969"},"issue":{"href":"https://api.github.com/repos/Chocobozzz/PeerTube/issues/969"},"comments":{"href":"https://api.github.com/repos/Chocobozzz/PeerTube/issues/969/comments"},"review_comments":{"href":"https://api.github.com/repos/Chocobozzz/PeerTube/pulls/969/comments"},"review_comment":{"href":"https://api.github.com/repos/Chocobozzz/PeerTube/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Chocobozzz/PeerTube/pulls/969/commits"},"statuses":{"href":"https://api.github.com/repos/Chocobozzz/PeerTube/statuses/d6a5f3bafba9565797be7a85d7103cf9e44b41e3"}},"author_association":"NONE"}}
{"actor":{"display_login":"bradsk88"}}