{"action":"created","comment":{"url":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments/183495092","pull_request_review_id":114504298,"id":183495092,"diff_hunk":"@@ -7,6 +7,30 @@ exports_files([\n     \"sh_test_wrapper.sh\",\n ])\n \n+genrule(\n+    name = \"gnu_build_id\",\n+    outs = [\"gnu_build_id.ldscript\"],\n+    cmd = \"\"\"\n+      echo --build-id=0x$$(\n+          grep BUILD_SCM_REVISION bazel-out/volatile-status.txt \\\\\n+        | sed 's/^BUILD_SCM_REVISION //') \\\\\n+        > $@\n+    \"\"\",\n+    stamp = 1,","path":"bazel/BUILD","position":null,"original_position":13,"commit_id":"ae6cf3343bdfa760b315eecbdae55f8a31d1f558","original_commit_id":"786acc75909c95a5ff4dcf4832def39acc4a01f2","user":{"login":"jmillikin-stripe","id":28275929,"avatar_url":"https://avatars3.githubusercontent.com/u/28275929?v=4","gravatar_id":"","url":"https://api.github.com/users/jmillikin-stripe","html_url":"https://github.com/jmillikin-stripe","followers_url":"https://api.github.com/users/jmillikin-stripe/followers","following_url":"https://api.github.com/users/jmillikin-stripe/following{/other_user}","gists_url":"https://api.github.com/users/jmillikin-stripe/gists{/gist_id}","starred_url":"https://api.github.com/users/jmillikin-stripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmillikin-stripe/subscriptions","organizations_url":"https://api.github.com/users/jmillikin-stripe/orgs","repos_url":"https://api.github.com/users/jmillikin-stripe/repos","events_url":"https://api.github.com/users/jmillikin-stripe/events{/privacy}","received_events_url":"https://api.github.com/users/jmillikin-stripe/received_events","type":"User","site_admin":false},"body":"Done.","created_at":"2018-04-23T18:31:31Z","updated_at":"2018-04-23T18:31:31Z","html_url":"https://github.com/envoyproxy/envoy/pull/3021#discussion_r183495092","pull_request_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/3021","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments/183495092"},"html":{"href":"https://github.com/envoyproxy/envoy/pull/3021#discussion_r183495092"},"pull_request":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/3021"}},"in_reply_to_id":183491326},"pull_request":{"url":"https://api.github.com/repos/envoyproxy/envoy/pulls/3021","id":180070444,"html_url":"https://github.com/envoyproxy/envoy/pull/3021","diff_url":"https://github.com/envoyproxy/envoy/pull/3021.diff","patch_url":"https://github.com/envoyproxy/envoy/pull/3021.patch","issue_url":"https://api.github.com/repos/envoyproxy/envoy/issues/3021","number":3021,"state":"open","locked":false,"title":"Replace `git_sha_rewriter.py` with a generated linker option.","user":{"login":"jmillikin-stripe","id":28275929,"avatar_url":"https://avatars3.githubusercontent.com/u/28275929?v=4","gravatar_id":"","url":"https://api.github.com/users/jmillikin-stripe","html_url":"https://github.com/jmillikin-stripe","followers_url":"https://api.github.com/users/jmillikin-stripe/followers","following_url":"https://api.github.com/users/jmillikin-stripe/following{/other_user}","gists_url":"https://api.github.com/users/jmillikin-stripe/gists{/gist_id}","starred_url":"https://api.github.com/users/jmillikin-stripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmillikin-stripe/subscriptions","organizations_url":"https://api.github.com/users/jmillikin-stripe/orgs","repos_url":"https://api.github.com/users/jmillikin-stripe/repos","events_url":"https://api.github.com/users/jmillikin-stripe/events{/privacy}","received_events_url":"https://api.github.com/users/jmillikin-stripe/received_events","type":"User","site_admin":false},"body":"*Description*:\r\nThis replaces Envoy's use of a Python script to poke at raw ELF headers with a generated `--build-id` linker flag, following the example of @oquenchil in https://github.com/envoyproxy/envoy/issues/2625.\r\n\r\nNote: this means the `//source/exe:envoy-static` target is now stamped, instead of having a separate implicit `envoy-static_stamped` target.\r\n\r\nI also edited the workspace status command so it treated the Git commit ID as \"stable\" instead of \"volatile\", so Bazel won't ignore it when relinking.\r\n\r\n*Risk Level*: Low\r\n\r\n*Testing*:\r\nTested locally on a MacOS and Linux build. Both of them have the current Git commit ID embedded in the expected binary sections.\r\n\r\nFixes https://github.com/envoyproxy/envoy/issues/2551\r\nFixes https://github.com/envoyproxy/envoy/issues/2625","created_at":"2018-04-06T22:49:49Z","updated_at":"2018-04-23T18:31:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b7c0bec7f1b769178e36c64c0f0b35a9d0fd6368","assignee":{"login":"mattklein123","id":6305260,"avatar_url":"https://avatars3.githubusercontent.com/u/6305260?v=4","gravatar_id":"","url":"https://api.github.com/users/mattklein123","html_url":"https://github.com/mattklein123","followers_url":"https://api.github.com/users/mattklein123/followers","following_url":"https://api.github.com/users/mattklein123/following{/other_user}","gists_url":"https://api.github.com/users/mattklein123/gists{/gist_id}","starred_url":"https://api.github.com/users/mattklein123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattklein123/subscriptions","organizations_url":"https://api.github.com/users/mattklein123/orgs","repos_url":"https://api.github.com/users/mattklein123/repos","events_url":"https://api.github.com/users/mattklein123/events{/privacy}","received_events_url":"https://api.github.com/users/mattklein123/received_events","type":"User","site_admin":false},"assignees":[{"login":"mattklein123","id":6305260,"avatar_url":"https://avatars3.githubusercontent.com/u/6305260?v=4","gravatar_id":"","url":"https://api.github.com/users/mattklein123","html_url":"https://github.com/mattklein123","followers_url":"https://api.github.com/users/mattklein123/followers","following_url":"https://api.github.com/users/mattklein123/following{/other_user}","gists_url":"https://api.github.com/users/mattklein123/gists{/gist_id}","starred_url":"https://api.github.com/users/mattklein123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattklein123/subscriptions","organizations_url":"https://api.github.com/users/mattklein123/orgs","repos_url":"https://api.github.com/users/mattklein123/repos","events_url":"https://api.github.com/users/mattklein123/events{/privacy}","received_events_url":"https://api.github.com/users/mattklein123/received_events","type":"User","site_admin":false},{"login":"htuch","id":10914751,"avatar_url":"https://avatars1.githubusercontent.com/u/10914751?v=4","gravatar_id":"","url":"https://api.github.com/users/htuch","html_url":"https://github.com/htuch","followers_url":"https://api.github.com/users/htuch/followers","following_url":"https://api.github.com/users/htuch/following{/other_user}","gists_url":"https://api.github.com/users/htuch/gists{/gist_id}","starred_url":"https://api.github.com/users/htuch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htuch/subscriptions","organizations_url":"https://api.github.com/users/htuch/orgs","repos_url":"https://api.github.com/users/htuch/repos","events_url":"https://api.github.com/users/htuch/events{/privacy}","received_events_url":"https://api.github.com/users/htuch/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/3021/commits","review_comments_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/3021/comments","review_comment_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/envoyproxy/envoy/issues/3021/comments","statuses_url":"https://api.github.com/repos/envoyproxy/envoy/statuses/ae6cf3343bdfa760b315eecbdae55f8a31d1f558","head":{"label":"jmillikin-stripe:rm-git-sha-rewriter","ref":"rm-git-sha-rewriter","sha":"ae6cf3343bdfa760b315eecbdae55f8a31d1f558","user":{"login":"jmillikin-stripe","id":28275929,"avatar_url":"https://avatars3.githubusercontent.com/u/28275929?v=4","gravatar_id":"","url":"https://api.github.com/users/jmillikin-stripe","html_url":"https://github.com/jmillikin-stripe","followers_url":"https://api.github.com/users/jmillikin-stripe/followers","following_url":"https://api.github.com/users/jmillikin-stripe/following{/other_user}","gists_url":"https://api.github.com/users/jmillikin-stripe/gists{/gist_id}","starred_url":"https://api.github.com/users/jmillikin-stripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmillikin-stripe/subscriptions","organizations_url":"https://api.github.com/users/jmillikin-stripe/orgs","repos_url":"https://api.github.com/users/jmillikin-stripe/repos","events_url":"https://api.github.com/users/jmillikin-stripe/events{/privacy}","received_events_url":"https://api.github.com/users/jmillikin-stripe/received_events","type":"User","site_admin":false},"repo":{"id":97174038,"name":"envoy","full_name":"jmillikin-stripe/envoy","owner":{"login":"jmillikin-stripe","id":28275929,"avatar_url":"https://avatars3.githubusercontent.com/u/28275929?v=4","gravatar_id":"","url":"https://api.github.com/users/jmillikin-stripe","html_url":"https://github.com/jmillikin-stripe","followers_url":"https://api.github.com/users/jmillikin-stripe/followers","following_url":"https://api.github.com/users/jmillikin-stripe/following{/other_user}","gists_url":"https://api.github.com/users/jmillikin-stripe/gists{/gist_id}","starred_url":"https://api.github.com/users/jmillikin-stripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmillikin-stripe/subscriptions","organizations_url":"https://api.github.com/users/jmillikin-stripe/orgs","repos_url":"https://api.github.com/users/jmillikin-stripe/repos","events_url":"https://api.github.com/users/jmillikin-stripe/events{/privacy}","received_events_url":"https://api.github.com/users/jmillikin-stripe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jmillikin-stripe/envoy","description":"C++ front/service proxy","fork":true,"url":"https://api.github.com/repos/jmillikin-stripe/envoy","forks_url":"https://api.github.com/repos/jmillikin-stripe/envoy/forks","keys_url":"https://api.github.com/repos/jmillikin-stripe/envoy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jmillikin-stripe/envoy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jmillikin-stripe/envoy/teams","hooks_url":"https://api.github.com/repos/jmillikin-stripe/envoy/hooks","issue_events_url":"https://api.github.com/repos/jmillikin-stripe/envoy/issues/events{/number}","events_url":"https://api.github.com/repos/jmillikin-stripe/envoy/events","assignees_url":"https://api.github.com/repos/jmillikin-stripe/envoy/assignees{/user}","branches_url":"https://api.github.com/repos/jmillikin-stripe/envoy/branches{/branch}","tags_url":"https://api.github.com/repos/jmillikin-stripe/envoy/tags","blobs_url":"https://api.github.com/repos/jmillikin-stripe/envoy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jmillikin-stripe/envoy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jmillikin-stripe/envoy/git/refs{/sha}","trees_url":"https://api.github.com/repos/jmillikin-stripe/envoy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jmillikin-stripe/envoy/statuses/{sha}","languages_url":"https://api.github.com/repos/jmillikin-stripe/envoy/languages","stargazers_url":"https://api.github.com/repos/jmillikin-stripe/envoy/stargazers","contributors_url":"https://api.github.com/repos/jmillikin-stripe/envoy/contributors","subscribers_url":"https://api.github.com/repos/jmillikin-stripe/envoy/subscribers","subscription_url":"https://api.github.com/repos/jmillikin-stripe/envoy/subscription","commits_url":"https://api.github.com/repos/jmillikin-stripe/envoy/commits{/sha}","git_commits_url":"https://api.github.com/repos/jmillikin-stripe/envoy/git/commits{/sha}","comments_url":"https://api.github.com/repos/jmillikin-stripe/envoy/comments{/number}","issue_comment_url":"https://api.github.com/repos/jmillikin-stripe/envoy/issues/comments{/number}","contents_url":"https://api.github.com/repos/jmillikin-stripe/envoy/contents/{+path}","compare_url":"https://api.github.com/repos/jmillikin-stripe/envoy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jmillikin-stripe/envoy/merges","archive_url":"https://api.github.com/repos/jmillikin-stripe/envoy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jmillikin-stripe/envoy/downloads","issues_url":"https://api.github.com/repos/jmillikin-stripe/envoy/issues{/number}","pulls_url":"https://api.github.com/repos/jmillikin-stripe/envoy/pulls{/number}","milestones_url":"https://api.github.com/repos/jmillikin-stripe/envoy/milestones{/number}","notifications_url":"https://api.github.com/repos/jmillikin-stripe/envoy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jmillikin-stripe/envoy/labels{/name}","releases_url":"https://api.github.com/repos/jmillikin-stripe/envoy/releases{/id}","deployments_url":"https://api.github.com/repos/jmillikin-stripe/envoy/deployments","created_at":"2017-07-13T23:50:58Z","updated_at":"2017-07-13T23:51:02Z","pushed_at":"2018-04-23T18:31:20Z","git_url":"git://github.com/jmillikin-stripe/envoy.git","ssh_url":"git@github.com:jmillikin-stripe/envoy.git","clone_url":"https://github.com/jmillikin-stripe/envoy.git","svn_url":"https://github.com/jmillikin-stripe/envoy","homepage":"https://lyft.github.io/envoy","size":38389,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"envoyproxy:master","ref":"master","sha":"f8f7f5d640610751d4e97672773ed9039e1c82f6","user":{"login":"envoyproxy","id":30125649,"avatar_url":"https://avatars1.githubusercontent.com/u/30125649?v=4","gravatar_id":"","url":"https://api.github.com/users/envoyproxy","html_url":"https://github.com/envoyproxy","followers_url":"https://api.github.com/users/envoyproxy/followers","following_url":"https://api.github.com/users/envoyproxy/following{/other_user}","gists_url":"https://api.github.com/users/envoyproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/envoyproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/envoyproxy/subscriptions","organizations_url":"https://api.github.com/users/envoyproxy/orgs","repos_url":"https://api.github.com/users/envoyproxy/repos","events_url":"https://api.github.com/users/envoyproxy/events{/privacy}","received_events_url":"https://api.github.com/users/envoyproxy/received_events","type":"Organization","site_admin":false},"repo":{"id":65214191,"name":"envoy","full_name":"envoyproxy/envoy","owner":{"login":"envoyproxy","id":30125649,"avatar_url":"https://avatars1.githubusercontent.com/u/30125649?v=4","gravatar_id":"","url":"https://api.github.com/users/envoyproxy","html_url":"https://github.com/envoyproxy","followers_url":"https://api.github.com/users/envoyproxy/followers","following_url":"https://api.github.com/users/envoyproxy/following{/other_user}","gists_url":"https://api.github.com/users/envoyproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/envoyproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/envoyproxy/subscriptions","organizations_url":"https://api.github.com/users/envoyproxy/orgs","repos_url":"https://api.github.com/users/envoyproxy/repos","events_url":"https://api.github.com/users/envoyproxy/events{/privacy}","received_events_url":"https://api.github.com/users/envoyproxy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/envoyproxy/envoy","description":"C++ front/service proxy","fork":false,"url":"https://api.github.com/repos/envoyproxy/envoy","forks_url":"https://api.github.com/repos/envoyproxy/envoy/forks","keys_url":"https://api.github.com/repos/envoyproxy/envoy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/envoyproxy/envoy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/envoyproxy/envoy/teams","hooks_url":"https://api.github.com/repos/envoyproxy/envoy/hooks","issue_events_url":"https://api.github.com/repos/envoyproxy/envoy/issues/events{/number}","events_url":"https://api.github.com/repos/envoyproxy/envoy/events","assignees_url":"https://api.github.com/repos/envoyproxy/envoy/assignees{/user}","branches_url":"https://api.github.com/repos/envoyproxy/envoy/branches{/branch}","tags_url":"https://api.github.com/repos/envoyproxy/envoy/tags","blobs_url":"https://api.github.com/repos/envoyproxy/envoy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/envoyproxy/envoy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/envoyproxy/envoy/git/refs{/sha}","trees_url":"https://api.github.com/repos/envoyproxy/envoy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/envoyproxy/envoy/statuses/{sha}","languages_url":"https://api.github.com/repos/envoyproxy/envoy/languages","stargazers_url":"https://api.github.com/repos/envoyproxy/envoy/stargazers","contributors_url":"https://api.github.com/repos/envoyproxy/envoy/contributors","subscribers_url":"https://api.github.com/repos/envoyproxy/envoy/subscribers","subscription_url":"https://api.github.com/repos/envoyproxy/envoy/subscription","commits_url":"https://api.github.com/repos/envoyproxy/envoy/commits{/sha}","git_commits_url":"https://api.github.com/repos/envoyproxy/envoy/git/commits{/sha}","comments_url":"https://api.github.com/repos/envoyproxy/envoy/comments{/number}","issue_comment_url":"https://api.github.com/repos/envoyproxy/envoy/issues/comments{/number}","contents_url":"https://api.github.com/repos/envoyproxy/envoy/contents/{+path}","compare_url":"https://api.github.com/repos/envoyproxy/envoy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/envoyproxy/envoy/merges","archive_url":"https://api.github.com/repos/envoyproxy/envoy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/envoyproxy/envoy/downloads","issues_url":"https://api.github.com/repos/envoyproxy/envoy/issues{/number}","pulls_url":"https://api.github.com/repos/envoyproxy/envoy/pulls{/number}","milestones_url":"https://api.github.com/repos/envoyproxy/envoy/milestones{/number}","notifications_url":"https://api.github.com/repos/envoyproxy/envoy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/envoyproxy/envoy/labels{/name}","releases_url":"https://api.github.com/repos/envoyproxy/envoy/releases{/id}","deployments_url":"https://api.github.com/repos/envoyproxy/envoy/deployments","created_at":"2016-08-08T15:07:24Z","updated_at":"2018-04-23T17:58:22Z","pushed_at":"2018-04-23T18:31:21Z","git_url":"git://github.com/envoyproxy/envoy.git","ssh_url":"git@github.com:envoyproxy/envoy.git","clone_url":"https://github.com/envoyproxy/envoy.git","svn_url":"https://github.com/envoyproxy/envoy","homepage":"https://www.envoyproxy.io","size":14515,"stargazers_count":4610,"watchers_count":4610,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":580,"mirror_url":null,"archived":false,"open_issues_count":309,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":580,"open_issues":309,"watchers":4610,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/3021"},"html":{"href":"https://github.com/envoyproxy/envoy/pull/3021"},"issue":{"href":"https://api.github.com/repos/envoyproxy/envoy/issues/3021"},"comments":{"href":"https://api.github.com/repos/envoyproxy/envoy/issues/3021/comments"},"review_comments":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/3021/comments"},"review_comment":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/3021/commits"},"statuses":{"href":"https://api.github.com/repos/envoyproxy/envoy/statuses/ae6cf3343bdfa760b315eecbdae55f8a31d1f558"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jmillikin-stripe"}}