{"action":"created","comment":{"url":"https://api.github.com/repos/ess-dmsc/h5cpp/pulls/comments/197290935","pull_request_review_id":131009144,"id":197290935,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NzI5MDkzNQ==","diff_hunk":"@@ -144,6 +145,20 @@ class DLL_EXPORT Datatype\n   //!\n   virtual void size(size_t size) const;\n \n+  //!\n+  //! @brief get sign of type in bytes\n+  //!\n+  //! @throws std::runtime_error in case of a failure\n+  //!\n+  virtual bool sign() const;\n+\n+  //!\n+  //! @brief set the sign of a type in bytes","path":"src/h5cpp/datatype/datatype.hpp","position":20,"original_position":20,"commit_id":"bb2e1180e0374e8d90278e709de6d332819839a4","original_commit_id":"bb2e1180e0374e8d90278e709de6d332819839a4","user":{"login":"martukas","id":1972005,"node_id":"MDQ6VXNlcjE5NzIwMDU=","avatar_url":"https://avatars1.githubusercontent.com/u/1972005?v=4","gravatar_id":"","url":"https://api.github.com/users/martukas","html_url":"https://github.com/martukas","followers_url":"https://api.github.com/users/martukas/followers","following_url":"https://api.github.com/users/martukas/following{/other_user}","gists_url":"https://api.github.com/users/martukas/gists{/gist_id}","starred_url":"https://api.github.com/users/martukas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martukas/subscriptions","organizations_url":"https://api.github.com/users/martukas/orgs","repos_url":"https://api.github.com/users/martukas/repos","events_url":"https://api.github.com/users/martukas/events{/privacy}","received_events_url":"https://api.github.com/users/martukas/received_events","type":"User","site_admin":false},"body":"Same here. Perhaps:\r\n\"Sets the sign property for an integer type.\"","created_at":"2018-06-21T22:02:01Z","updated_at":"2018-06-21T22:12:19Z","html_url":"https://github.com/ess-dmsc/h5cpp/pull/319#discussion_r197290935","pull_request_url":"https://api.github.com/repos/ess-dmsc/h5cpp/pulls/319","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/ess-dmsc/h5cpp/pulls/comments/197290935"},"html":{"href":"https://github.com/ess-dmsc/h5cpp/pull/319#discussion_r197290935"},"pull_request":{"href":"https://api.github.com/repos/ess-dmsc/h5cpp/pulls/319"}}},"pull_request":{"url":"https://api.github.com/repos/ess-dmsc/h5cpp/pulls/319","id":196573569,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2NTczNTY5","html_url":"https://github.com/ess-dmsc/h5cpp/pull/319","diff_url":"https://github.com/ess-dmsc/h5cpp/pull/319.diff","patch_url":"https://github.com/ess-dmsc/h5cpp/pull/319.patch","issue_url":"https://api.github.com/repos/ess-dmsc/h5cpp/issues/319","number":319,"state":"open","locked":false,"title":"Issue 313","user":{"login":"jkotan","id":10651163,"node_id":"MDQ6VXNlcjEwNjUxMTYz","avatar_url":"https://avatars0.githubusercontent.com/u/10651163?v=4","gravatar_id":"","url":"https://api.github.com/users/jkotan","html_url":"https://github.com/jkotan","followers_url":"https://api.github.com/users/jkotan/followers","following_url":"https://api.github.com/users/jkotan/following{/other_user}","gists_url":"https://api.github.com/users/jkotan/gists{/gist_id}","starred_url":"https://api.github.com/users/jkotan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkotan/subscriptions","organizations_url":"https://api.github.com/users/jkotan/orgs","repos_url":"https://api.github.com/users/jkotan/repos","events_url":"https://api.github.com/users/jkotan/events{/privacy}","received_events_url":"https://api.github.com/users/jkotan/received_events","type":"User","site_admin":false},"body":"it adds sign getter and setter methods to Datatype class.","created_at":"2018-06-21T20:57:57Z","updated_at":"2018-06-21T22:12:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"84b8473b8dbd0865c268e8a2aae67591a5aa7175","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ess-dmsc/h5cpp/pulls/319/commits","review_comments_url":"https://api.github.com/repos/ess-dmsc/h5cpp/pulls/319/comments","review_comment_url":"https://api.github.com/repos/ess-dmsc/h5cpp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ess-dmsc/h5cpp/issues/319/comments","statuses_url":"https://api.github.com/repos/ess-dmsc/h5cpp/statuses/bb2e1180e0374e8d90278e709de6d332819839a4","head":{"label":"ess-dmsc:issue_313","ref":"issue_313","sha":"bb2e1180e0374e8d90278e709de6d332819839a4","user":{"login":"ess-dmsc","id":12100833,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMTAwODMz","avatar_url":"https://avatars1.githubusercontent.com/u/12100833?v=4","gravatar_id":"","url":"https://api.github.com/users/ess-dmsc","html_url":"https://github.com/ess-dmsc","followers_url":"https://api.github.com/users/ess-dmsc/followers","following_url":"https://api.github.com/users/ess-dmsc/following{/other_user}","gists_url":"https://api.github.com/users/ess-dmsc/gists{/gist_id}","starred_url":"https://api.github.com/users/ess-dmsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ess-dmsc/subscriptions","organizations_url":"https://api.github.com/users/ess-dmsc/orgs","repos_url":"https://api.github.com/users/ess-dmsc/repos","events_url":"https://api.github.com/users/ess-dmsc/events{/privacy}","received_events_url":"https://api.github.com/users/ess-dmsc/received_events","type":"Organization","site_admin":false},"repo":{"id":99373936,"node_id":"MDEwOlJlcG9zaXRvcnk5OTM3MzkzNg==","name":"h5cpp","full_name":"ess-dmsc/h5cpp","owner":{"login":"ess-dmsc","id":12100833,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMTAwODMz","avatar_url":"https://avatars1.githubusercontent.com/u/12100833?v=4","gravatar_id":"","url":"https://api.github.com/users/ess-dmsc","html_url":"https://github.com/ess-dmsc","followers_url":"https://api.github.com/users/ess-dmsc/followers","following_url":"https://api.github.com/users/ess-dmsc/following{/other_user}","gists_url":"https://api.github.com/users/ess-dmsc/gists{/gist_id}","starred_url":"https://api.github.com/users/ess-dmsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ess-dmsc/subscriptions","organizations_url":"https://api.github.com/users/ess-dmsc/orgs","repos_url":"https://api.github.com/users/ess-dmsc/repos","events_url":"https://api.github.com/users/ess-dmsc/events{/privacy}","received_events_url":"https://api.github.com/users/ess-dmsc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ess-dmsc/h5cpp","description":"C++ wrapper for the HDF5 C-library","fork":false,"url":"https://api.github.com/repos/ess-dmsc/h5cpp","forks_url":"https://api.github.com/repos/ess-dmsc/h5cpp/forks","keys_url":"https://api.github.com/repos/ess-dmsc/h5cpp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ess-dmsc/h5cpp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ess-dmsc/h5cpp/teams","hooks_url":"https://api.github.com/repos/ess-dmsc/h5cpp/hooks","issue_events_url":"https://api.github.com/repos/ess-dmsc/h5cpp/issues/events{/number}","events_url":"https://api.github.com/repos/ess-dmsc/h5cpp/events","assignees_url":"https://api.github.com/repos/ess-dmsc/h5cpp/assignees{/user}","branches_url":"https://api.github.com/repos/ess-dmsc/h5cpp/branches{/branch}","tags_url":"https://api.github.com/repos/ess-dmsc/h5cpp/tags","blobs_url":"https://api.github.com/repos/ess-dmsc/h5cpp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ess-dmsc/h5cpp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ess-dmsc/h5cpp/git/refs{/sha}","trees_url":"https://api.github.com/repos/ess-dmsc/h5cpp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ess-dmsc/h5cpp/statuses/{sha}","languages_url":"https://api.github.com/repos/ess-dmsc/h5cpp/languages","stargazers_url":"https://api.github.com/repos/ess-dmsc/h5cpp/stargazers","contributors_url":"https://api.github.com/repos/ess-dmsc/h5cpp/contributors","subscribers_url":"https://api.github.com/repos/ess-dmsc/h5cpp/subscribers","subscription_url":"https://api.github.com/repos/ess-dmsc/h5cpp/subscription","commits_url":"https://api.github.com/repos/ess-dmsc/h5cpp/commits{/sha}","git_commits_url":"https://api.github.com/repos/ess-dmsc/h5cpp/git/commits{/sha}","comments_url":"https://api.github.com/repos/ess-dmsc/h5cpp/comments{/number}","issue_comment_url":"https://api.github.com/repos/ess-dmsc/h5cpp/issues/comments{/number}","contents_url":"https://api.github.com/repos/ess-dmsc/h5cpp/contents/{+path}","compare_url":"https://api.github.com/repos/ess-dmsc/h5cpp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ess-dmsc/h5cpp/merges","archive_url":"https://api.github.com/repos/ess-dmsc/h5cpp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ess-dmsc/h5cpp/downloads","issues_url":"https://api.github.com/repos/ess-dmsc/h5cpp/issues{/number}","pulls_url":"https://api.github.com/repos/ess-dmsc/h5cpp/pulls{/number}","milestones_url":"https://api.github.com/repos/ess-dmsc/h5cpp/milestones{/number}","notifications_url":"https://api.github.com/repos/ess-dmsc/h5cpp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ess-dmsc/h5cpp/labels{/name}","releases_url":"https://api.github.com/repos/ess-dmsc/h5cpp/releases{/id}","deployments_url":"https://api.github.com/repos/ess-dmsc/h5cpp/deployments","created_at":"2017-08-04T19:30:31Z","updated_at":"2018-06-13T15:43:54Z","pushed_at":"2018-06-21T20:57:57Z","git_url":"git://github.com/ess-dmsc/h5cpp.git","ssh_url":"git@github.com:ess-dmsc/h5cpp.git","clone_url":"https://github.com/ess-dmsc/h5cpp.git","svn_url":"https://github.com/ess-dmsc/h5cpp","homepage":null,"size":41885,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":51,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":1,"open_issues":51,"watchers":2,"default_branch":"master"}},"base":{"label":"ess-dmsc:master","ref":"master","sha":"223f89a79ffafa71128e0ed356185fac52e5a11c","user":{"login":"ess-dmsc","id":12100833,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMTAwODMz","avatar_url":"https://avatars1.githubusercontent.com/u/12100833?v=4","gravatar_id":"","url":"https://api.github.com/users/ess-dmsc","html_url":"https://github.com/ess-dmsc","followers_url":"https://api.github.com/users/ess-dmsc/followers","following_url":"https://api.github.com/users/ess-dmsc/following{/other_user}","gists_url":"https://api.github.com/users/ess-dmsc/gists{/gist_id}","starred_url":"https://api.github.com/users/ess-dmsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ess-dmsc/subscriptions","organizations_url":"https://api.github.com/users/ess-dmsc/orgs","repos_url":"https://api.github.com/users/ess-dmsc/repos","events_url":"https://api.github.com/users/ess-dmsc/events{/privacy}","received_events_url":"https://api.github.com/users/ess-dmsc/received_events","type":"Organization","site_admin":false},"repo":{"id":99373936,"node_id":"MDEwOlJlcG9zaXRvcnk5OTM3MzkzNg==","name":"h5cpp","full_name":"ess-dmsc/h5cpp","owner":{"login":"ess-dmsc","id":12100833,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMTAwODMz","avatar_url":"https://avatars1.githubusercontent.com/u/12100833?v=4","gravatar_id":"","url":"https://api.github.com/users/ess-dmsc","html_url":"https://github.com/ess-dmsc","followers_url":"https://api.github.com/users/ess-dmsc/followers","following_url":"https://api.github.com/users/ess-dmsc/following{/other_user}","gists_url":"https://api.github.com/users/ess-dmsc/gists{/gist_id}","starred_url":"https://api.github.com/users/ess-dmsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ess-dmsc/subscriptions","organizations_url":"https://api.github.com/users/ess-dmsc/orgs","repos_url":"https://api.github.com/users/ess-dmsc/repos","events_url":"https://api.github.com/users/ess-dmsc/events{/privacy}","received_events_url":"https://api.github.com/users/ess-dmsc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ess-dmsc/h5cpp","description":"C++ wrapper for the HDF5 C-library","fork":false,"url":"https://api.github.com/repos/ess-dmsc/h5cpp","forks_url":"https://api.github.com/repos/ess-dmsc/h5cpp/forks","keys_url":"https://api.github.com/repos/ess-dmsc/h5cpp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ess-dmsc/h5cpp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ess-dmsc/h5cpp/teams","hooks_url":"https://api.github.com/repos/ess-dmsc/h5cpp/hooks","issue_events_url":"https://api.github.com/repos/ess-dmsc/h5cpp/issues/events{/number}","events_url":"https://api.github.com/repos/ess-dmsc/h5cpp/events","assignees_url":"https://api.github.com/repos/ess-dmsc/h5cpp/assignees{/user}","branches_url":"https://api.github.com/repos/ess-dmsc/h5cpp/branches{/branch}","tags_url":"https://api.github.com/repos/ess-dmsc/h5cpp/tags","blobs_url":"https://api.github.com/repos/ess-dmsc/h5cpp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ess-dmsc/h5cpp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ess-dmsc/h5cpp/git/refs{/sha}","trees_url":"https://api.github.com/repos/ess-dmsc/h5cpp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ess-dmsc/h5cpp/statuses/{sha}","languages_url":"https://api.github.com/repos/ess-dmsc/h5cpp/languages","stargazers_url":"https://api.github.com/repos/ess-dmsc/h5cpp/stargazers","contributors_url":"https://api.github.com/repos/ess-dmsc/h5cpp/contributors","subscribers_url":"https://api.github.com/repos/ess-dmsc/h5cpp/subscribers","subscription_url":"https://api.github.com/repos/ess-dmsc/h5cpp/subscription","commits_url":"https://api.github.com/repos/ess-dmsc/h5cpp/commits{/sha}","git_commits_url":"https://api.github.com/repos/ess-dmsc/h5cpp/git/commits{/sha}","comments_url":"https://api.github.com/repos/ess-dmsc/h5cpp/comments{/number}","issue_comment_url":"https://api.github.com/repos/ess-dmsc/h5cpp/issues/comments{/number}","contents_url":"https://api.github.com/repos/ess-dmsc/h5cpp/contents/{+path}","compare_url":"https://api.github.com/repos/ess-dmsc/h5cpp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ess-dmsc/h5cpp/merges","archive_url":"https://api.github.com/repos/ess-dmsc/h5cpp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ess-dmsc/h5cpp/downloads","issues_url":"https://api.github.com/repos/ess-dmsc/h5cpp/issues{/number}","pulls_url":"https://api.github.com/repos/ess-dmsc/h5cpp/pulls{/number}","milestones_url":"https://api.github.com/repos/ess-dmsc/h5cpp/milestones{/number}","notifications_url":"https://api.github.com/repos/ess-dmsc/h5cpp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ess-dmsc/h5cpp/labels{/name}","releases_url":"https://api.github.com/repos/ess-dmsc/h5cpp/releases{/id}","deployments_url":"https://api.github.com/repos/ess-dmsc/h5cpp/deployments","created_at":"2017-08-04T19:30:31Z","updated_at":"2018-06-13T15:43:54Z","pushed_at":"2018-06-21T20:57:57Z","git_url":"git://github.com/ess-dmsc/h5cpp.git","ssh_url":"git@github.com:ess-dmsc/h5cpp.git","clone_url":"https://github.com/ess-dmsc/h5cpp.git","svn_url":"https://github.com/ess-dmsc/h5cpp","homepage":null,"size":41885,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":51,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":1,"open_issues":51,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ess-dmsc/h5cpp/pulls/319"},"html":{"href":"https://github.com/ess-dmsc/h5cpp/pull/319"},"issue":{"href":"https://api.github.com/repos/ess-dmsc/h5cpp/issues/319"},"comments":{"href":"https://api.github.com/repos/ess-dmsc/h5cpp/issues/319/comments"},"review_comments":{"href":"https://api.github.com/repos/ess-dmsc/h5cpp/pulls/319/comments"},"review_comment":{"href":"https://api.github.com/repos/ess-dmsc/h5cpp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ess-dmsc/h5cpp/pulls/319/commits"},"statuses":{"href":"https://api.github.com/repos/ess-dmsc/h5cpp/statuses/bb2e1180e0374e8d90278e709de6d332819839a4"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"martukas"}}