{"action":"created","issue":{"url":"https://api.github.com/repos/rapid7/metasploit-framework/issues/10790","repository_url":"https://api.github.com/repos/rapid7/metasploit-framework","labels_url":"https://api.github.com/repos/rapid7/metasploit-framework/issues/10790/labels{/name}","comments_url":"https://api.github.com/repos/rapid7/metasploit-framework/issues/10790/comments","events_url":"https://api.github.com/repos/rapid7/metasploit-framework/issues/10790/events","html_url":"https://github.com/rapid7/metasploit-framework/pull/10790","id":368885520,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxOTU2Nzky","number":10790,"title":"Remove peer information from the prefix","user":{"login":"TheNaterz","id":2198138,"node_id":"MDQ6VXNlcjIxOTgxMzg=","avatar_url":"https://avatars1.githubusercontent.com/u/2198138?v=4","gravatar_id":"","url":"https://api.github.com/users/TheNaterz","html_url":"https://github.com/TheNaterz","followers_url":"https://api.github.com/users/TheNaterz/followers","following_url":"https://api.github.com/users/TheNaterz/following{/other_user}","gists_url":"https://api.github.com/users/TheNaterz/gists{/gist_id}","starred_url":"https://api.github.com/users/TheNaterz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheNaterz/subscriptions","organizations_url":"https://api.github.com/users/TheNaterz/orgs","repos_url":"https://api.github.com/users/TheNaterz/repos","events_url":"https://api.github.com/users/TheNaterz/events{/privacy}","received_events_url":"https://api.github.com/users/TheNaterz/received_events","type":"User","site_admin":false},"labels":[{"id":124421898,"node_id":"MDU6TGFiZWwxMjQ0MjE4OTg=","url":"https://api.github.com/repos/rapid7/metasploit-framework/labels/bug","name":"bug","color":"e11d21","default":true},{"id":103436071,"node_id":"MDU6TGFiZWwxMDM0MzYwNzE=","url":"https://api.github.com/repos/rapid7/metasploit-framework/labels/library","name":"library","color":"fad8c7","default":false}],"state":"open","locked":false,"assignee":{"login":"busterb","id":4108654,"node_id":"MDQ6VXNlcjQxMDg2NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/4108654?v=4","gravatar_id":"","url":"https://api.github.com/users/busterb","html_url":"https://github.com/busterb","followers_url":"https://api.github.com/users/busterb/followers","following_url":"https://api.github.com/users/busterb/following{/other_user}","gists_url":"https://api.github.com/users/busterb/gists{/gist_id}","starred_url":"https://api.github.com/users/busterb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/busterb/subscriptions","organizations_url":"https://api.github.com/users/busterb/orgs","repos_url":"https://api.github.com/users/busterb/repos","events_url":"https://api.github.com/users/busterb/events{/privacy}","received_events_url":"https://api.github.com/users/busterb/received_events","type":"User","site_admin":false},"assignees":[{"login":"busterb","id":4108654,"node_id":"MDQ6VXNlcjQxMDg2NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/4108654?v=4","gravatar_id":"","url":"https://api.github.com/users/busterb","html_url":"https://github.com/busterb","followers_url":"https://api.github.com/users/busterb/followers","following_url":"https://api.github.com/users/busterb/following{/other_user}","gists_url":"https://api.github.com/users/busterb/gists{/gist_id}","starred_url":"https://api.github.com/users/busterb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/busterb/subscriptions","organizations_url":"https://api.github.com/users/busterb/orgs","repos_url":"https://api.github.com/users/busterb/repos","events_url":"https://api.github.com/users/busterb/events{/privacy}","received_events_url":"https://api.github.com/users/busterb/received_events","type":"User","site_admin":false}],"milestone":null,"comments":10,"created_at":"2018-10-10T22:48:30Z","updated_at":"2018-10-11T17:06:43Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/rapid7/metasploit-framework/pulls/10790","html_url":"https://github.com/rapid7/metasploit-framework/pull/10790","diff_url":"https://github.com/rapid7/metasploit-framework/pull/10790.diff","patch_url":"https://github.com/rapid7/metasploit-framework/pull/10790.patch"},"body":"Currently, when a status message gets printed for a module that has an RHOSTS defined as a file with hundreds of hosts, the prefix takes this gigantic space separated list of hosts and shoves it into a message. Every time the message is printed, you get this really ugly block of text and it makes the output hard to read.\r\n\r\nI propose that peer information isn't necessary enough to include in these messages.\r\n\r\n## Before\r\n\r\n- [ ] Start `msfconsole`\r\n- [ ] `use auxiliary/scanner/ssh/ssh_version` (just as an example)\r\n- [ ] Set RHOSTS to some file with 100 hosts or something.\r\n- [ ] Every scanner progress message looks gross.\r\n\r\n## After\r\n- [ ] Do all the above steps.\r\n- [ ] Bask in the glory of minimal output. Look upon its simplistic face and behold its overwhelming mediocrity. But also it's cleaner and cleanliness is close to godliness.\r\n\r\nIn other words...\r\n\r\nWhen did this:\r\n![selection_002](https://user-images.githubusercontent.com/2198138/46770766-ff557800-ccad-11e8-9239-20598839cbc8.png)\r\nbecome hotter than this?:\r\n![selection_001](https://user-images.githubusercontent.com/2198138/46770755-f2388900-ccad-11e8-956b-61a2460755e7.png)\r\n\r\n\r\nThoughts?"},"comment":{"url":"https://api.github.com/repos/rapid7/metasploit-framework/issues/comments/429038334","html_url":"https://github.com/rapid7/metasploit-framework/pull/10790#issuecomment-429038334","issue_url":"https://api.github.com/repos/rapid7/metasploit-framework/issues/10790","id":429038334,"node_id":"MDEyOklzc3VlQ29tbWVudDQyOTAzODMzNA==","user":{"login":"busterb","id":4108654,"node_id":"MDQ6VXNlcjQxMDg2NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/4108654?v=4","gravatar_id":"","url":"https://api.github.com/users/busterb","html_url":"https://github.com/busterb","followers_url":"https://api.github.com/users/busterb/followers","following_url":"https://api.github.com/users/busterb/following{/other_user}","gists_url":"https://api.github.com/users/busterb/gists{/gist_id}","starred_url":"https://api.github.com/users/busterb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/busterb/subscriptions","organizations_url":"https://api.github.com/users/busterb/orgs","repos_url":"https://api.github.com/users/busterb/repos","events_url":"https://api.github.com/users/busterb/events{/privacy}","received_events_url":"https://api.github.com/users/busterb/received_events","type":"User","site_admin":false},"created_at":"2018-10-11T17:06:43Z","updated_at":"2018-10-11T17:06:43Z","author_association":"CONTRIBUTOR","body":"How about this:\r\n\r\n```\r\n  def print_prefix\r\n    if rhost && rhost.split(' ').length < 2\r\n      super + peer + ' - '\r\n    else\r\n      super\r\n    end\r\n  end\r\n```\r\n\r\nThe point of the 'rhost' check was to see if we are in the context of a host or not. Sometimes 'rhost' ends up mapping to 'rhosts' which ends up being too long. This figures it out and does the right thing that you would expect."}}
{"actor":{"display_login":"busterb"}}