{"action":"created","issue":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/45799","repository_url":"https://api.github.com/repos/NixOS/nixpkgs","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/45799/labels{/name}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/45799/comments","events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/45799/events","html_url":"https://github.com/NixOS/nixpkgs/pull/45799","id":355691797,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyMTYyMDM5","number":45799,"title":"findlib: make #use \"topfind\" work","user":{"login":"xplat","id":425891,"node_id":"MDQ6VXNlcjQyNTg5MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/425891?v=4","gravatar_id":"","url":"https://api.github.com/users/xplat","html_url":"https://github.com/xplat","followers_url":"https://api.github.com/users/xplat/followers","following_url":"https://api.github.com/users/xplat/following{/other_user}","gists_url":"https://api.github.com/users/xplat/gists{/gist_id}","starred_url":"https://api.github.com/users/xplat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xplat/subscriptions","organizations_url":"https://api.github.com/users/xplat/orgs","repos_url":"https://api.github.com/users/xplat/repos","events_url":"https://api.github.com/users/xplat/events{/privacy}","received_events_url":"https://api.github.com/users/xplat/received_events","type":"User","site_admin":false},"labels":[{"id":731735423,"node_id":"MDU6TGFiZWw3MzE3MzU0MjM=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-darwin:%2011-100","name":"10.rebuild-darwin: 11-100","color":"fbca04","default":false},{"id":731734101,"node_id":"MDU6TGFiZWw3MzE3MzQxMDE=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-linux:%2011-100","name":"10.rebuild-linux: 11-100","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-08-30T17:56:51Z","updated_at":"2018-08-31T15:05:44Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/45799","html_url":"https://github.com/NixOS/nixpkgs/pull/45799","diff_url":"https://github.com/NixOS/nixpkgs/pull/45799.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/45799.patch"},"body":"###### Motivation for this change\r\n\r\nUp to now packages that use Ocaml as a scripting language have needed special handholding to work in nix (see `pkgs/development/ocaml-modules/topkg` for instance, because `topfind` which is used by most of them to find libraries is installed as part of this package, not `ocaml` itself, and therefore isn't in the default library search path for the Ocaml toplevel.  This patch solves that issue by adding a setup hook to rewrite uses of `topfind` to use the full path.\r\n\r\nThis improves the situation for #16085 although it does not fully address interactive use.\r\n\r\n###### Things done\r\n\r\n<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->\r\n\r\n- [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)\r\n- Built on platform(s)\r\n   - [x] NixOS\r\n   - [ ] macOS\r\n   - [x] other Linux distributions\r\n- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [x] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)\r\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments/417693318","html_url":"https://github.com/NixOS/nixpkgs/pull/45799#issuecomment-417693318","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/45799","id":417693318,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNzY5MzMxOA==","user":{"login":"vbgl","id":2612464,"node_id":"MDQ6VXNlcjI2MTI0NjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/2612464?v=4","gravatar_id":"","url":"https://api.github.com/users/vbgl","html_url":"https://github.com/vbgl","followers_url":"https://api.github.com/users/vbgl/followers","following_url":"https://api.github.com/users/vbgl/following{/other_user}","gists_url":"https://api.github.com/users/vbgl/gists{/gist_id}","starred_url":"https://api.github.com/users/vbgl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vbgl/subscriptions","organizations_url":"https://api.github.com/users/vbgl/orgs","repos_url":"https://api.github.com/users/vbgl/repos","events_url":"https://api.github.com/users/vbgl/events{/privacy}","received_events_url":"https://api.github.com/users/vbgl/received_events","type":"User","site_admin":false},"created_at":"2018-08-31T15:05:44Z","updated_at":"2018-08-31T15:05:44Z","author_association":"CONTRIBUTOR","body":"Thanks for working on this.\r\n\r\nIf this makes `topkg` work out of the box, can you please simplify the `topkg.run` command accordingly as part of this PR; thanks.\r\n\r\nAs a minor remark, I find the wording “make [it] work” a bit misleading: it still does not work but is automatically rewritten into something that does; right?"}}
{"actor":{"display_login":"vbgl"}}