{"action":"created","issue":{"url":"https://api.github.com/repos/lockedata/namer/issues/18","repository_url":"https://api.github.com/repos/lockedata/namer","labels_url":"https://api.github.com/repos/lockedata/namer/issues/18/labels{/name}","comments_url":"https://api.github.com/repos/lockedata/namer/issues/18/comments","events_url":"https://api.github.com/repos/lockedata/namer/issues/18/events","html_url":"https://github.com/lockedata/namer/pull/18","id":383089079,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyNjQwNTM0","number":18,"title":"Clean latex special characters for bookdown labels","user":{"login":"martinjhnhadley","id":9363263,"node_id":"MDQ6VXNlcjkzNjMyNjM=","avatar_url":"https://avatars0.githubusercontent.com/u/9363263?v=4","gravatar_id":"","url":"https://api.github.com/users/martinjhnhadley","html_url":"https://github.com/martinjhnhadley","followers_url":"https://api.github.com/users/martinjhnhadley/followers","following_url":"https://api.github.com/users/martinjhnhadley/following{/other_user}","gists_url":"https://api.github.com/users/martinjhnhadley/gists{/gist_id}","starred_url":"https://api.github.com/users/martinjhnhadley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinjhnhadley/subscriptions","organizations_url":"https://api.github.com/users/martinjhnhadley/orgs","repos_url":"https://api.github.com/users/martinjhnhadley/repos","events_url":"https://api.github.com/users/martinjhnhadley/events{/privacy}","received_events_url":"https://api.github.com/users/martinjhnhadley/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-11-21T12:08:53Z","updated_at":"2018-12-03T13:13:15Z","closed_at":"2018-11-21T12:52:23Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/lockedata/namer/pulls/18","html_url":"https://github.com/lockedata/namer/pull/18","diff_url":"https://github.com/lockedata/namer/pull/18.diff","patch_url":"https://github.com/lockedata/namer/pull/18.patch"},"body":"Bookdown provides support for captions and other internal referencing via the use of chunk names. \r\n\r\nAs warned here https://bookdown.org/yihui/bookdown/markdown-extensions-by-bookdown.html#text-references it's advised not to use underscores in chunk labels as they're escaped in LateX\r\n\r\nJenny Bryan's excellent \"how to name files\" slide deck https://speakerdeck.com/jennybc/how-to-name-files encourages the following:\r\n\r\nYYYY-MM-DD_semantic-component-1_component-2\r\n\r\nThis PR introduces `clean_latex_special_characters` which replaces all LaTeX special characters in filenames with - and also removes duplicate dashes."},"comment":{"url":"https://api.github.com/repos/lockedata/namer/issues/comments/443705383","html_url":"https://github.com/lockedata/namer/pull/18#issuecomment-443705383","issue_url":"https://api.github.com/repos/lockedata/namer/issues/18","id":443705383,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MzcwNTM4Mw==","user":{"login":"maelle","id":8360597,"node_id":"MDQ6VXNlcjgzNjA1OTc=","avatar_url":"https://avatars0.githubusercontent.com/u/8360597?v=4","gravatar_id":"","url":"https://api.github.com/users/maelle","html_url":"https://github.com/maelle","followers_url":"https://api.github.com/users/maelle/followers","following_url":"https://api.github.com/users/maelle/following{/other_user}","gists_url":"https://api.github.com/users/maelle/gists{/gist_id}","starred_url":"https://api.github.com/users/maelle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maelle/subscriptions","organizations_url":"https://api.github.com/users/maelle/orgs","repos_url":"https://api.github.com/users/maelle/repos","events_url":"https://api.github.com/users/maelle/events{/privacy}","received_events_url":"https://api.github.com/users/maelle/received_events","type":"User","site_admin":false},"created_at":"2018-12-03T13:13:15Z","updated_at":"2018-12-03T13:13:15Z","author_association":"MEMBER","body":"Ok, thanks for clarifying! Do you however consider your (merged) PR to be dangerous too i.e. should the filename cleaning be optional too?"}}
{"actor":{"display_login":"maelle"}}