{"action":"created","issue":{"url":"https://api.github.com/repos/prometheus/tsdb/issues/303","repository_url":"https://api.github.com/repos/prometheus/tsdb","labels_url":"https://api.github.com/repos/prometheus/tsdb/issues/303/labels{/name}","comments_url":"https://api.github.com/repos/prometheus/tsdb/issues/303/comments","events_url":"https://api.github.com/repos/prometheus/tsdb/issues/303/events","html_url":"https://github.com/prometheus/tsdb/pull/303","id":305513046,"number":303,"title":"repair + compact: Improved logging for easier future debug purposes.","user":{"login":"Bplotka","id":6950331,"avatar_url":"https://avatars2.githubusercontent.com/u/6950331?v=4","gravatar_id":"","url":"https://api.github.com/users/Bplotka","html_url":"https://github.com/Bplotka","followers_url":"https://api.github.com/users/Bplotka/followers","following_url":"https://api.github.com/users/Bplotka/following{/other_user}","gists_url":"https://api.github.com/users/Bplotka/gists{/gist_id}","starred_url":"https://api.github.com/users/Bplotka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bplotka/subscriptions","organizations_url":"https://api.github.com/users/Bplotka/orgs","repos_url":"https://api.github.com/users/Bplotka/repos","events_url":"https://api.github.com/users/Bplotka/events{/privacy}","received_events_url":"https://api.github.com/users/Bplotka/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-03-15T11:28:03Z","updated_at":"2018-03-15T14:59:59Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/prometheus/tsdb/pulls/303","html_url":"https://github.com/prometheus/tsdb/pull/303","diff_url":"https://github.com/prometheus/tsdb/pull/303.diff","patch_url":"https://github.com/prometheus/tsdb/pull/303.patch"},"body":"This is based on my experience while debugging https://github.com/prometheus/prometheus/issues/3943.\r\n\r\nI needed to deduct few things, and all that would be just bit easier with these two logs:\r\n- new block's ULID on each compaction.\r\n- actual list of Blocks (ulid + time range) on Prometheus startup (easy to log that while repairing blocks).\r\n\r\nWe don't really need blocks that takes part in compaction - that can be deducted easily based on time ranges of blocks we have currently in system.\r\n\r\nAdditionally, fixed comments.\r\n\r\nWhat do you think @fabxc  @Gouthamve ?\r\n\r\nSigned-off-by: Bartek Plotka <bwplotka@gmail.com>"},"comment":{"url":"https://api.github.com/repos/prometheus/tsdb/issues/comments/373406055","html_url":"https://github.com/prometheus/tsdb/pull/303#issuecomment-373406055","issue_url":"https://api.github.com/repos/prometheus/tsdb/issues/303","id":373406055,"user":{"login":"Bplotka","id":6950331,"avatar_url":"https://avatars2.githubusercontent.com/u/6950331?v=4","gravatar_id":"","url":"https://api.github.com/users/Bplotka","html_url":"https://github.com/Bplotka","followers_url":"https://api.github.com/users/Bplotka/followers","following_url":"https://api.github.com/users/Bplotka/following{/other_user}","gists_url":"https://api.github.com/users/Bplotka/gists{/gist_id}","starred_url":"https://api.github.com/users/Bplotka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bplotka/subscriptions","organizations_url":"https://api.github.com/users/Bplotka/orgs","repos_url":"https://api.github.com/users/Bplotka/repos","events_url":"https://api.github.com/users/Bplotka/events{/privacy}","received_events_url":"https://api.github.com/users/Bplotka/received_events","type":"User","site_admin":false},"created_at":"2018-03-15T14:59:59Z","updated_at":"2018-03-15T14:59:59Z","author_association":"CONTRIBUTOR","body":"@Gouthamve  Sorry for that - I fixed it and tested log line manually."}}
{"actor":{"display_login":"Bplotka"}}