{"action":"created","issue":{"url":"https://api.github.com/repos/Automattic/wp-calypso/issues/26944","repository_url":"https://api.github.com/repos/Automattic/wp-calypso","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/26944/labels{/name}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/26944/comments","events_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/26944/events","html_url":"https://github.com/Automattic/wp-calypso/pull/26944","id":354940728,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExNTg3MzA5","number":26944,"title":"Boot: Don't render empty Layout","user":{"login":"ockham","id":96308,"node_id":"MDQ6VXNlcjk2MzA4","avatar_url":"https://avatars2.githubusercontent.com/u/96308?v=4","gravatar_id":"","url":"https://api.github.com/users/ockham","html_url":"https://github.com/ockham","followers_url":"https://api.github.com/users/ockham/followers","following_url":"https://api.github.com/users/ockham/following{/other_user}","gists_url":"https://api.github.com/users/ockham/gists{/gist_id}","starred_url":"https://api.github.com/users/ockham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ockham/subscriptions","organizations_url":"https://api.github.com/users/ockham/orgs","repos_url":"https://api.github.com/users/ockham/repos","events_url":"https://api.github.com/users/ockham/events{/privacy}","received_events_url":"https://api.github.com/users/ockham/received_events","type":"User","site_admin":false},"labels":[{"id":285009988,"node_id":"MDU6TGFiZWwyODUwMDk5ODg=","url":"https://api.github.com/repos/Automattic/wp-calypso/labels/Framework","name":"Framework","color":"c5def5","default":false},{"id":285010018,"node_id":"MDU6TGFiZWwyODUwMTAwMTg=","url":"https://api.github.com/repos/Automattic/wp-calypso/labels/[Status]%20Needs%20Review","name":"[Status] Needs Review","color":"fbca04","default":false},{"id":838866001,"node_id":"MDU6TGFiZWw4Mzg4NjYwMDE=","url":"https://api.github.com/repos/Automattic/wp-calypso/labels/[Status]%20Needs%20e2e%20Testing","name":"[Status] Needs e2e Testing","color":"ed74b2","default":false}],"state":"open","locked":false,"assignee":{"login":"ockham","id":96308,"node_id":"MDQ6VXNlcjk2MzA4","avatar_url":"https://avatars2.githubusercontent.com/u/96308?v=4","gravatar_id":"","url":"https://api.github.com/users/ockham","html_url":"https://github.com/ockham","followers_url":"https://api.github.com/users/ockham/followers","following_url":"https://api.github.com/users/ockham/following{/other_user}","gists_url":"https://api.github.com/users/ockham/gists{/gist_id}","starred_url":"https://api.github.com/users/ockham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ockham/subscriptions","organizations_url":"https://api.github.com/users/ockham/orgs","repos_url":"https://api.github.com/users/ockham/repos","events_url":"https://api.github.com/users/ockham/events{/privacy}","received_events_url":"https://api.github.com/users/ockham/received_events","type":"User","site_admin":false},"assignees":[{"login":"ockham","id":96308,"node_id":"MDQ6VXNlcjk2MzA4","avatar_url":"https://avatars2.githubusercontent.com/u/96308?v=4","gravatar_id":"","url":"https://api.github.com/users/ockham","html_url":"https://github.com/ockham","followers_url":"https://api.github.com/users/ockham/followers","following_url":"https://api.github.com/users/ockham/following{/other_user}","gists_url":"https://api.github.com/users/ockham/gists{/gist_id}","starred_url":"https://api.github.com/users/ockham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ockham/subscriptions","organizations_url":"https://api.github.com/users/ockham/orgs","repos_url":"https://api.github.com/users/ockham/repos","events_url":"https://api.github.com/users/ockham/events{/privacy}","received_events_url":"https://api.github.com/users/ockham/received_events","type":"User","site_admin":false}],"milestone":null,"comments":19,"created_at":"2018-08-28T23:29:32Z","updated_at":"2018-09-10T21:50:09Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/26944","html_url":"https://github.com/Automattic/wp-calypso/pull/26944","diff_url":"https://github.com/Automattic/wp-calypso/pull/26944.diff","patch_url":"https://github.com/Automattic/wp-calypso/pull/26944.patch"},"body":"This is a left-over that we must've missed when enabling single-tree rendering.\r\n\r\nAll of Calypso's client-side `page()` route definitions now include `makeLayout` and `render` middleware, so rendering an empty `Layout` component during bootstrapping is obsolete.\r\n\r\nDiscovered while working on, and needed for #26930.\r\n\r\nBest viewed [without whitespace changes](https://github.com/Automattic/wp-calypso/pull/26944/files?w=1).\r\n\r\nTo test: \r\n* Verify that Calypso renders and works properly, when landing in different sections\r\n* Be sure to include some logged-out and SSR'd sections"},"comment":{"url":"https://api.github.com/repos/Automattic/wp-calypso/issues/comments/420073009","html_url":"https://github.com/Automattic/wp-calypso/pull/26944#issuecomment-420073009","issue_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/26944","id":420073009,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMDA3MzAwOQ==","user":{"login":"ockham","id":96308,"node_id":"MDQ6VXNlcjk2MzA4","avatar_url":"https://avatars2.githubusercontent.com/u/96308?v=4","gravatar_id":"","url":"https://api.github.com/users/ockham","html_url":"https://github.com/ockham","followers_url":"https://api.github.com/users/ockham/followers","following_url":"https://api.github.com/users/ockham/following{/other_user}","gists_url":"https://api.github.com/users/ockham/gists{/gist_id}","starred_url":"https://api.github.com/users/ockham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ockham/subscriptions","organizations_url":"https://api.github.com/users/ockham/orgs","repos_url":"https://api.github.com/users/ockham/repos","events_url":"https://api.github.com/users/ockham/events{/privacy}","received_events_url":"https://api.github.com/users/ockham/received_events","type":"User","site_admin":false},"created_at":"2018-09-10T21:50:09Z","updated_at":"2018-09-10T21:50:09Z","author_association":"CONTRIBUTOR","body":"> Avoiding that \"onClick + href\" pattern and rewriting `a` elements to `button`s whenever they are not real hyperlinks is a good idea. It also solves a lot of a11y problems.\r\n\r\nI've personally used `a`s with both `href`s and `onClick`s -- the typical use case would be something that navigates somewhere, _and_ fires some sort of tracking event.\r\n\r\nStating navigation/route changes semantically is important IMO -- for various reasons (among them a11y). More discussion around this here: https://github.com/WordPress/gutenberg/issues/7534#issuecomment-420068623"}}
{"actor":{"display_login":"ockham"}}