{"action":"created","issue":{"url":"https://api.github.com/repos/ianstormtaylor/slate/issues/1788","repository_url":"https://api.github.com/repos/ianstormtaylor/slate","labels_url":"https://api.github.com/repos/ianstormtaylor/slate/issues/1788/labels{/name}","comments_url":"https://api.github.com/repos/ianstormtaylor/slate/issues/1788/comments","events_url":"https://api.github.com/repos/ianstormtaylor/slate/issues/1788/events","html_url":"https://github.com/ianstormtaylor/slate/issues/1788","id":316214080,"number":1788,"title":"Decorations are slow","user":{"login":"Soreine","id":5644953,"avatar_url":"https://avatars0.githubusercontent.com/u/5644953?v=4","gravatar_id":"","url":"https://api.github.com/users/Soreine","html_url":"https://github.com/Soreine","followers_url":"https://api.github.com/users/Soreine/followers","following_url":"https://api.github.com/users/Soreine/following{/other_user}","gists_url":"https://api.github.com/users/Soreine/gists{/gist_id}","starred_url":"https://api.github.com/users/Soreine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Soreine/subscriptions","organizations_url":"https://api.github.com/users/Soreine/orgs","repos_url":"https://api.github.com/users/Soreine/repos","events_url":"https://api.github.com/users/Soreine/events{/privacy}","received_events_url":"https://api.github.com/users/Soreine/received_events","type":"User","site_admin":false},"labels":[{"id":404056337,"url":"https://api.github.com/repos/ianstormtaylor/slate/labels/%E2%99%A5%20help%20please","name":"♥ help please","color":"f2cee2","default":false},{"id":404055048,"url":"https://api.github.com/repos/ianstormtaylor/slate/labels/%E2%9A%91%20performance","name":"⚑ performance","color":"eeeeee","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-04-20T10:27:18Z","updated_at":"2018-04-27T19:28:44Z","closed_at":null,"author_association":"COLLABORATOR","body":"We are investigating huge performance issues since we updated our app to Slate 0.33, and have noticed that using a syntax highlighting plugin, like `slate-prism`, slows everything a lot.\r\n\r\n- Slate version: 0.33.3 on Chrome\r\n- Example: visit https://gitbookio.github.io/slate-prism/ paste a non-trivial code snippet (~100 lines) and start typing inside it\r\n\r\nI have measured our the time to `React.renderToString` our app on a reasonable page containing code blocks [like this one](https://redux.js.org/~/revisions/-LAU3Ba0tMiCaOgxoUMb/faq/immutable-data). Here are the times:\r\n\r\n- with highlighting: `16437ms` to render the app and document\r\n- without: `899ms` to render the app and document\r\n\r\nI also measured the time spent in the calls of the [`decorateNode`](https://github.com/GitbookIO/slate-prism/blob/master/lib/index.js#L15) of the plugin, which amounts to `188ms`. So the issue most likely comes from Slate and the way decorations are applied and rendered."},"comment":{"url":"https://api.github.com/repos/ianstormtaylor/slate/issues/comments/385070946","html_url":"https://github.com/ianstormtaylor/slate/issues/1788#issuecomment-385070946","issue_url":"https://api.github.com/repos/ianstormtaylor/slate/issues/1788","id":385070946,"user":{"login":"jacobbloom","id":20777052,"avatar_url":"https://avatars1.githubusercontent.com/u/20777052?v=4","gravatar_id":"","url":"https://api.github.com/users/jacobbloom","html_url":"https://github.com/jacobbloom","followers_url":"https://api.github.com/users/jacobbloom/followers","following_url":"https://api.github.com/users/jacobbloom/following{/other_user}","gists_url":"https://api.github.com/users/jacobbloom/gists{/gist_id}","starred_url":"https://api.github.com/users/jacobbloom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacobbloom/subscriptions","organizations_url":"https://api.github.com/users/jacobbloom/orgs","repos_url":"https://api.github.com/users/jacobbloom/repos","events_url":"https://api.github.com/users/jacobbloom/events{/privacy}","received_events_url":"https://api.github.com/users/jacobbloom/received_events","type":"User","site_admin":false},"created_at":"2018-04-27T19:28:44Z","updated_at":"2018-04-27T19:28:44Z","author_association":"CONTRIBUTOR","body":"@zhujinxuan did you mean to pull me into this or was that an autocomplete mistake?"}}
{"actor":{"display_login":"jacobbloom"}}