{"action":"created","comment":{"url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/pulls/comments/199594495","pull_request_review_id":133744937,"id":199594495,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTU5NDQ5NQ==","diff_hunk":"@@ -432,6 +439,8 @@ export async function activate(context: vscode.ExtensionContext) {\n export function deactivate(): Promise<void> {\n   console.log('SFDX CLI Extension Deactivated');\n \n+  // Send metric data.\n+  telemetryService.sendExtensionDeactivationEvent();","path":"packages/salesforcedx-vscode-core/src/index.ts","position":33,"original_position":33,"commit_id":"b199952d9dde82fe8c03f1d92db9f579babe5ffa","original_commit_id":"b199952d9dde82fe8c03f1d92db9f579babe5ffa","user":{"login":"lcampos","id":1041842,"node_id":"MDQ6VXNlcjEwNDE4NDI=","avatar_url":"https://avatars0.githubusercontent.com/u/1041842?v=4","gravatar_id":"","url":"https://api.github.com/users/lcampos","html_url":"https://github.com/lcampos","followers_url":"https://api.github.com/users/lcampos/followers","following_url":"https://api.github.com/users/lcampos/following{/other_user}","gists_url":"https://api.github.com/users/lcampos/gists{/gist_id}","starred_url":"https://api.github.com/users/lcampos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lcampos/subscriptions","organizations_url":"https://api.github.com/users/lcampos/orgs","repos_url":"https://api.github.com/users/lcampos/repos","events_url":"https://api.github.com/users/lcampos/events{/privacy}","received_events_url":"https://api.github.com/users/lcampos/received_events","type":"User","site_admin":false},"body":"I've seen some issues gathering this specific metric and found this issue on vscode (https://github.com/Microsoft/vscode/issues/47881).","created_at":"2018-07-02T19:12:30Z","updated_at":"2018-07-02T19:12:30Z","html_url":"https://github.com/forcedotcom/salesforcedx-vscode/pull/511#discussion_r199594495","pull_request_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/pulls/511","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/pulls/comments/199594495"},"html":{"href":"https://github.com/forcedotcom/salesforcedx-vscode/pull/511#discussion_r199594495"},"pull_request":{"href":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/pulls/511"}}},"pull_request":{"url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/pulls/511","id":198764469,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4NzY0NDY5","html_url":"https://github.com/forcedotcom/salesforcedx-vscode/pull/511","diff_url":"https://github.com/forcedotcom/salesforcedx-vscode/pull/511.diff","patch_url":"https://github.com/forcedotcom/salesforcedx-vscode/pull/511.patch","issue_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/issues/511","number":511,"state":"open","locked":false,"title":"Lcampos/telemetry","user":{"login":"lcampos","id":1041842,"node_id":"MDQ6VXNlcjEwNDE4NDI=","avatar_url":"https://avatars0.githubusercontent.com/u/1041842?v=4","gravatar_id":"","url":"https://api.github.com/users/lcampos","html_url":"https://github.com/lcampos","followers_url":"https://api.github.com/users/lcampos/followers","following_url":"https://api.github.com/users/lcampos/following{/other_user}","gists_url":"https://api.github.com/users/lcampos/gists{/gist_id}","starred_url":"https://api.github.com/users/lcampos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lcampos/subscriptions","organizations_url":"https://api.github.com/users/lcampos/orgs","repos_url":"https://api.github.com/users/lcampos/repos","events_url":"https://api.github.com/users/lcampos/events{/privacy}","received_events_url":"https://api.github.com/users/lcampos/received_events","type":"User","site_admin":false},"body":"### What does this PR do?\r\nThis is an early PR for adding telemetry to our extensions\r\n\r\n### What issues does this PR fix or reference?\r\nAdds telemetry to our vscode extensions.\r\n\r\nPreview of some metrics being sent.\r\n\r\n<img width=\"925\" alt=\"screen shot 2018-07-02 at 12 05 03 pm\" src=\"https://user-images.githubusercontent.com/1041842/42181650-65a92582-7df0-11e8-8501-dc2ebd30e66b.png\">\r\n\r\n<img width=\"917\" alt=\"screen shot 2018-07-02 at 12 04 16 pm\" src=\"https://user-images.githubusercontent.com/1041842/42181656-6b7975d4-7df0-11e8-92cc-a82789963820.png\">\r\n","created_at":"2018-07-02T19:06:11Z","updated_at":"2018-07-02T19:12:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"acf1d6e6abcba2ef8ac310b0acf4e659c97f9f27","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/pulls/511/commits","review_comments_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/pulls/511/comments","review_comment_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/pulls/comments{/number}","comments_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/issues/511/comments","statuses_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/statuses/b199952d9dde82fe8c03f1d92db9f579babe5ffa","head":{"label":"forcedotcom:lcampos/telemetry","ref":"lcampos/telemetry","sha":"b199952d9dde82fe8c03f1d92db9f579babe5ffa","user":{"login":"forcedotcom","id":464563,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2NDU2Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/464563?v=4","gravatar_id":"","url":"https://api.github.com/users/forcedotcom","html_url":"https://github.com/forcedotcom","followers_url":"https://api.github.com/users/forcedotcom/followers","following_url":"https://api.github.com/users/forcedotcom/following{/other_user}","gists_url":"https://api.github.com/users/forcedotcom/gists{/gist_id}","starred_url":"https://api.github.com/users/forcedotcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forcedotcom/subscriptions","organizations_url":"https://api.github.com/users/forcedotcom/orgs","repos_url":"https://api.github.com/users/forcedotcom/repos","events_url":"https://api.github.com/users/forcedotcom/events{/privacy}","received_events_url":"https://api.github.com/users/forcedotcom/received_events","type":"Organization","site_admin":false},"repo":{"id":95021029,"node_id":"MDEwOlJlcG9zaXRvcnk5NTAyMTAyOQ==","name":"salesforcedx-vscode","full_name":"forcedotcom/salesforcedx-vscode","owner":{"login":"forcedotcom","id":464563,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2NDU2Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/464563?v=4","gravatar_id":"","url":"https://api.github.com/users/forcedotcom","html_url":"https://github.com/forcedotcom","followers_url":"https://api.github.com/users/forcedotcom/followers","following_url":"https://api.github.com/users/forcedotcom/following{/other_user}","gists_url":"https://api.github.com/users/forcedotcom/gists{/gist_id}","starred_url":"https://api.github.com/users/forcedotcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forcedotcom/subscriptions","organizations_url":"https://api.github.com/users/forcedotcom/orgs","repos_url":"https://api.github.com/users/forcedotcom/repos","events_url":"https://api.github.com/users/forcedotcom/events{/privacy}","received_events_url":"https://api.github.com/users/forcedotcom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/forcedotcom/salesforcedx-vscode","description":"Salesforce Extensions for VS Code","fork":false,"url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode","forks_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/forks","keys_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/teams","hooks_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/hooks","issue_events_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/issues/events{/number}","events_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/events","assignees_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/assignees{/user}","branches_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/branches{/branch}","tags_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/tags","blobs_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/git/refs{/sha}","trees_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/statuses/{sha}","languages_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/languages","stargazers_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/stargazers","contributors_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/contributors","subscribers_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/subscribers","subscription_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/subscription","commits_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/commits{/sha}","git_commits_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/git/commits{/sha}","comments_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/comments{/number}","issue_comment_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/issues/comments{/number}","contents_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/contents/{+path}","compare_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/merges","archive_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/downloads","issues_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/issues{/number}","pulls_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/pulls{/number}","milestones_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/milestones{/number}","notifications_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/labels{/name}","releases_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/releases{/id}","deployments_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/deployments","created_at":"2017-06-21T15:53:45Z","updated_at":"2018-07-02T17:51:58Z","pushed_at":"2018-07-02T19:06:12Z","git_url":"git://github.com/forcedotcom/salesforcedx-vscode.git","ssh_url":"git@github.com:forcedotcom/salesforcedx-vscode.git","clone_url":"https://github.com/forcedotcom/salesforcedx-vscode.git","svn_url":"https://github.com/forcedotcom/salesforcedx-vscode","homepage":"","size":98350,"stargazers_count":163,"watchers_count":163,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":32,"mirror_url":null,"archived":false,"open_issues_count":36,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":32,"open_issues":36,"watchers":163,"default_branch":"develop"}},"base":{"label":"forcedotcom:develop","ref":"develop","sha":"fcef6b8b8cd83aabdb0055a1886e378dfa3fe9cd","user":{"login":"forcedotcom","id":464563,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2NDU2Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/464563?v=4","gravatar_id":"","url":"https://api.github.com/users/forcedotcom","html_url":"https://github.com/forcedotcom","followers_url":"https://api.github.com/users/forcedotcom/followers","following_url":"https://api.github.com/users/forcedotcom/following{/other_user}","gists_url":"https://api.github.com/users/forcedotcom/gists{/gist_id}","starred_url":"https://api.github.com/users/forcedotcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forcedotcom/subscriptions","organizations_url":"https://api.github.com/users/forcedotcom/orgs","repos_url":"https://api.github.com/users/forcedotcom/repos","events_url":"https://api.github.com/users/forcedotcom/events{/privacy}","received_events_url":"https://api.github.com/users/forcedotcom/received_events","type":"Organization","site_admin":false},"repo":{"id":95021029,"node_id":"MDEwOlJlcG9zaXRvcnk5NTAyMTAyOQ==","name":"salesforcedx-vscode","full_name":"forcedotcom/salesforcedx-vscode","owner":{"login":"forcedotcom","id":464563,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2NDU2Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/464563?v=4","gravatar_id":"","url":"https://api.github.com/users/forcedotcom","html_url":"https://github.com/forcedotcom","followers_url":"https://api.github.com/users/forcedotcom/followers","following_url":"https://api.github.com/users/forcedotcom/following{/other_user}","gists_url":"https://api.github.com/users/forcedotcom/gists{/gist_id}","starred_url":"https://api.github.com/users/forcedotcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forcedotcom/subscriptions","organizations_url":"https://api.github.com/users/forcedotcom/orgs","repos_url":"https://api.github.com/users/forcedotcom/repos","events_url":"https://api.github.com/users/forcedotcom/events{/privacy}","received_events_url":"https://api.github.com/users/forcedotcom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/forcedotcom/salesforcedx-vscode","description":"Salesforce Extensions for VS Code","fork":false,"url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode","forks_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/forks","keys_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/teams","hooks_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/hooks","issue_events_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/issues/events{/number}","events_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/events","assignees_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/assignees{/user}","branches_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/branches{/branch}","tags_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/tags","blobs_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/git/refs{/sha}","trees_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/statuses/{sha}","languages_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/languages","stargazers_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/stargazers","contributors_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/contributors","subscribers_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/subscribers","subscription_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/subscription","commits_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/commits{/sha}","git_commits_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/git/commits{/sha}","comments_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/comments{/number}","issue_comment_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/issues/comments{/number}","contents_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/contents/{+path}","compare_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/merges","archive_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/downloads","issues_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/issues{/number}","pulls_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/pulls{/number}","milestones_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/milestones{/number}","notifications_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/labels{/name}","releases_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/releases{/id}","deployments_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/deployments","created_at":"2017-06-21T15:53:45Z","updated_at":"2018-07-02T17:51:58Z","pushed_at":"2018-07-02T19:06:12Z","git_url":"git://github.com/forcedotcom/salesforcedx-vscode.git","ssh_url":"git@github.com:forcedotcom/salesforcedx-vscode.git","clone_url":"https://github.com/forcedotcom/salesforcedx-vscode.git","svn_url":"https://github.com/forcedotcom/salesforcedx-vscode","homepage":"","size":98350,"stargazers_count":163,"watchers_count":163,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":32,"mirror_url":null,"archived":false,"open_issues_count":36,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":32,"open_issues":36,"watchers":163,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/pulls/511"},"html":{"href":"https://github.com/forcedotcom/salesforcedx-vscode/pull/511"},"issue":{"href":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/issues/511"},"comments":{"href":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/issues/511/comments"},"review_comments":{"href":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/pulls/511/comments"},"review_comment":{"href":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/pulls/511/commits"},"statuses":{"href":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/statuses/b199952d9dde82fe8c03f1d92db9f579babe5ffa"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"lcampos"}}