{"push_id":2735582919,"size":20,"distinct_size":20,"ref":"refs/heads/rn-from-git-2","head":"f0a022a7604d754a2c666788c3e51b50b63dfe5b","before":"161a88cb0c4bb0e8f2486bafdad7b1fc88d45370","commits":[{"sha":"745db376ad90332a91962753963a4ea13b1509ab","author":{"name":"Kunal Gupta","email":"21fb9ab84a9608fb9702bca05921ea9bbcbb76af@gmail.com"},"message":"webview: Respect the user's setting for 24-hour vs 12-hour time.\n\nMost of the implementation is there already, but at one step of the\nplumbing we drop the information, and pick it up again hardcoded to\n12-hour time.  Fix it by filling in the missing plumbing.\n\nThe explicit hardcoding appeared in ac04b1099, which added a bunch of\ntypes and exposed the gap in passing this flag down.  Before that, the\nrelevant property was simply missing where we actually consult it.\n\nFixes #2765.\n\n[greg: expanded commit message]","distinct":true,"url":"https://api.github.com/repos/jainkuniya/zulip-mobile/commits/745db376ad90332a91962753963a4ea13b1509ab"},{"sha":"2d7f4772d623e57586aeec84f758a3e8438c6754","author":{"name":"Robert Hönig","email":"393c791db0a638e4b2d42a52a355f32b06702ad1@gmail.com"},"message":"timing: Clarify unit for timestamps.","distinct":true,"url":"https://api.github.com/repos/jainkuniya/zulip-mobile/commits/2d7f4772d623e57586aeec84f758a3e8438c6754"},{"sha":"4654fa64d9ea8b8f63b153e5f34f2e0b8304fba4","author":{"name":"Robert Hönig","email":"393c791db0a638e4b2d42a52a355f32b06702ad1@gmail.com"},"message":"timing: Clarify timestamp map identifier name.","distinct":true,"url":"https://api.github.com/repos/jainkuniya/zulip-mobile/commits/4654fa64d9ea8b8f63b153e5f34f2e0b8304fba4"},{"sha":"6935600ed37d4ee7139a2a87af351d61d981cabd","author":{"name":"Robert Hönig","email":"393c791db0a638e4b2d42a52a355f32b06702ad1@gmail.com"},"message":"timing: Remove fractional ms in diagnostics screen.\n\nendMs and startMs are created by Date.now(), which has a precision\nof ±1 ms. Don't suggest a precision that we don't have. Remove all\nfractional digits.","distinct":true,"url":"https://api.github.com/repos/jainkuniya/zulip-mobile/commits/6935600ed37d4ee7139a2a87af351d61d981cabd"},{"sha":"3a91f74665e1903fa4f181802a6110dac0b9b4b1","author":{"name":"Robert Hönig","email":"393c791db0a638e4b2d42a52a355f32b06702ad1@gmail.com"},"message":"flow: Remove redundant annotation in UnreadCards props.\n\nThe annotation of this prop as `UnreadStream[]` was shadowed by the\nannotation as `any`.  Remove the duplicate, and leave it as `any` for\nnow, since setting it to `UnreadStream[]` opens a big box of\ncomplicated typing issues.","distinct":true,"url":"https://api.github.com/repos/jainkuniya/zulip-mobile/commits/3a91f74665e1903fa4f181802a6110dac0b9b4b1"},{"sha":"70f55358ab9259772a882e31e186a5a72844c978","author":{"name":"Robert Hönig","email":"393c791db0a638e4b2d42a52a355f32b06702ad1@gmail.com"},"message":"users: Remove unused function fetchUsers().\n\nThe only reference to fetchUsers() was removed with 8362d617e in 2016\n(the function was named sendGetUsers() at that time).  fetchUsers was\nalso (since b1bd9c7b7 in 2017-10) the only place where INIT_USERS got\ndispatched, so we can remove that action as well.\n\nCurrently, we load an initial list of all users when initializing an\naccount, and update it on EVENT_USER_ADD events.","distinct":true,"url":"https://api.github.com/repos/jainkuniya/zulip-mobile/commits/70f55358ab9259772a882e31e186a5a72844c978"},{"sha":"4030edd61b72616dbacd610116d8a8a073c89a7b","author":{"name":"Robert Hönig","email":"393c791db0a638e4b2d42a52a355f32b06702ad1@gmail.com"},"message":"users: Remove unused selectors.\n\nRemove getUsersStatusOffline, getUsersStatusIdle, and\ngetUsersStatusActive.  As Boris explains their history:\n\n> this was created for a UI version of the thing we call now\n> UserPickerCard and that was not implemented exactly as intended.\n\nAlso remove getActiveUsers, since it was only used by the three\n`getUserStatus*` functions.  In fact, getActiveUsers was broken and\nwould always have returned an empty list, because the `is_active`\nproperty doesn't exist anymore.  `is_active` will be removed in the\nnext commit.","distinct":true,"url":"https://api.github.com/repos/jainkuniya/zulip-mobile/commits/4030edd61b72616dbacd610116d8a8a073c89a7b"},{"sha":"c3e4d4899ad2b55bd435f6ea53e55f2f5d514800","author":{"name":"Robert Hönig","email":"393c791db0a638e4b2d42a52a355f32b06702ad1@gmail.com"},"message":"users: Remove nonexistent is_active property from User.\n\nThe server used to supply an `is_active` property for each user.\nThis is no longer the case; since the server's 305fe6106 (in\n1.8.0), the information is now expressed by the split between\n`realm_active_users` and `realm_non_active_users`.\n\nWe are already using `realm_non_active_users`, but we hadn't\ncleaned out the old, obsolete code yet.  Clean that out.","distinct":true,"url":"https://api.github.com/repos/jainkuniya/zulip-mobile/commits/c3e4d4899ad2b55bd435f6ea53e55f2f5d514800"},{"sha":"74c2bab27b5facdbdd4a3bba3dbf5265dc8dba7e","author":{"name":"Robert Hönig","email":"393c791db0a638e4b2d42a52a355f32b06702ad1@gmail.com"},"message":"Display \"No internet connection\" banner on every screen.\n\nPreviously, the \"No internet connection\" banner was only\ndisplayed in a topic narrow. This made it hard to know\nif the app isn't loading because of a bug or because it\nis disconnected.","distinct":true,"url":"https://api.github.com/repos/jainkuniya/zulip-mobile/commits/74c2bab27b5facdbdd4a3bba3dbf5265dc8dba7e"},{"sha":"13e0e031aa55ba98419a8a6ff144522060e2b7d9","author":{"name":"Robert Hönig","email":"393c791db0a638e4b2d42a52a355f32b06702ad1@gmail.com"},"message":"AnimatedComponent: Also animate on component creation.\n\nPreviously, AnimatedComponent.animate() was only called in the\ncomponentDidUpdate() method, which is not called on the creation of\nthe component.  This works fine for our current uses of\nAnimatedComponent, but it won't work for components that need to be\nanimated right after they have been created.  An example of this is\nOfflineNotice, which will be animated in the next commit.\n\nCurrently, only ComponentMenu uses AnimatedComponent. It is not visibly\naffected by this change, because it is hidden right after creation.","distinct":true,"url":"https://api.github.com/repos/jainkuniya/zulip-mobile/commits/13e0e031aa55ba98419a8a6ff144522060e2b7d9"},{"sha":"90f66db91aaf618c213f6b19f8cee7ecd417733e","author":{"name":"Robert Hönig","email":"393c791db0a638e4b2d42a52a355f32b06702ad1@gmail.com"},"message":"Animate \"No internet connection\" banner.\n\nExpand and collapse <OfflineNotice/>, similar to Facebook Messenger.\nAdd a small delay so that the OfflineNotice is not immediately\ndisplayed when e.g. narrowing to a topic.  This makes its appearance\nmore prominent to the user.\n\nWe don't use the native animation driver, because it doesn't support\nanimating layout properties like `height`.","distinct":true,"url":"https://api.github.com/repos/jainkuniya/zulip-mobile/commits/90f66db91aaf618c213f6b19f8cee7ecd417733e"},{"sha":"935c1f52f9795c2f516a9a1e8531ff0a50bf8143","author":{"name":"Greg Price","email":"79e2475f81a6317276bf7cbb3958b20d289b78df@zulipchat.com"},"message":"async: Loosen a racy test to try to prevent flakes.\n\nThis test failed in a CI build on #2729:\n  https://travis-ci.org/zulip/zulip-mobile/builds/405727850\n\nProbably the system was busy and it took a bit longer to get to this\ntask than the minimum.  That's perfectly normal behavior, and we\nshouldn't fail on it.\n\nIt'd be nice to spruce this up so it e.g. reports the actual duration\nif it fails, but this quick fix should do.","distinct":true,"url":"https://api.github.com/repos/jainkuniya/zulip-mobile/commits/935c1f52f9795c2f516a9a1e8531ff0a50bf8143"},{"sha":"7ab4a0a34c0767238e3e070d9edd369a858b6d77","author":{"name":"Robert Hönig","email":"393c791db0a638e4b2d42a52a355f32b06702ad1@gmail.com"},"message":"types: Add is_announcement_only flag to Stream.\n\nThe server supplies is_announcement_only, but we hadn't documented it.","distinct":true,"url":"https://api.github.com/repos/jainkuniya/zulip-mobile/commits/7ab4a0a34c0767238e3e070d9edd369a858b6d77"},{"sha":"63fe3aaf6a9b47c65448276a0df593586529a873","author":{"name":"Robert Hönig","email":"393c791db0a638e4b2d42a52a355f32b06702ad1@gmail.com"},"message":"styles: Extract disabledCompose* styles.\n\nDo this so we can share the styles in the following commit.","distinct":true,"url":"https://api.github.com/repos/jainkuniya/zulip-mobile/commits/63fe3aaf6a9b47c65448276a0df593586529a873"},{"sha":"7202e4a5d6866b030baad8fdc8e0eb4d276844c7","author":{"name":"Robert Hönig","email":"393c791db0a638e4b2d42a52a355f32b06702ad1@gmail.com"},"message":"compose: Handle narrow to announcement-only stream.\n\nWhen narrowing to an announcement-only stream, display an info box\ninstead of the compose box to explain that a normal user cannot post\nto that stream -- unless the user actually is an admin.\n\nFixes #2711.","distinct":true,"url":"https://api.github.com/repos/jainkuniya/zulip-mobile/commits/7202e4a5d6866b030baad8fdc8e0eb4d276844c7"},{"sha":"1e3b1141aab31e4e616c12356cd69964d8b5221e","author":{"name":"Jack Zhang","email":"61fdb1fe6a758a7ece6431cd73b6d6df6cbae988@gmail.com"},"message":"docs: Draft instructions for testing push notifications.","distinct":true,"url":"https://api.github.com/repos/jainkuniya/zulip-mobile/commits/1e3b1141aab31e4e616c12356cd69964d8b5221e"},{"sha":"52825aa58a5bc5b68f3aa3ad7a01ca1b2bb94dc5","author":{"name":"Greg Price","email":"79e2475f81a6317276bf7cbb3958b20d289b78df@zulipchat.com"},"message":"docs: Add a bit more to instructions for testing push notifications.","distinct":true,"url":"https://api.github.com/repos/jainkuniya/zulip-mobile/commits/52825aa58a5bc5b68f3aa3ad7a01ca1b2bb94dc5"},{"sha":"2024f14880ee60c0f06b7a564aeb3d1c5eb75dee","author":{"name":"Greg Price","email":"79e2475f81a6317276bf7cbb3958b20d289b78df@zulipchat.com"},"message":"docs/notif: Generalize server-change instructions to Android.\n\nThis part should work the same on either mobile platform.","distinct":true,"url":"https://api.github.com/repos/jainkuniya/zulip-mobile/commits/2024f14880ee60c0f06b7a564aeb3d1c5eb75dee"},{"sha":"5e920ccb6a5e5a90cf038243763f39bb68cfcdc2","author":{"name":"Vishwesh Jainkuniya","email":"adfd5c9cc509da49e6dc5c1123db843b98e2a728@gmail.com"},"message":"android: Upgrade gradle to `gradle-4.9-rc-2-all`.\n\nWhat I have observed is, upgrading gradle have reduced gradle build\ntime. Also upgrading gradle version have helped us in using\n`zulip/react-native` (in upcomming commit) from git.","distinct":true,"url":"https://api.github.com/repos/jainkuniya/zulip-mobile/commits/5e920ccb6a5e5a90cf038243763f39bb68cfcdc2"},{"sha":"f0a022a7604d754a2c666788c3e51b50b63dfe5b","author":{"name":"Vishwesh Jainkuniya","email":"adfd5c9cc509da49e6dc5c1123db843b98e2a728@gmail.com"},"message":"android: Build RN from `zulip/react-native` from git.\n\nBefore using/testing this commit, clone `zulip/react-native` adjacent\nto `zulip/zulip-mobile`.\n\nIf you have cloned at some other place then update relative path of\n`zulip/zulip-mobile` & `zulip/react-native` in\n`android/setting.gradle`.","distinct":true,"url":"https://api.github.com/repos/jainkuniya/zulip-mobile/commits/f0a022a7604d754a2c666788c3e51b50b63dfe5b"}]}
{"actor":{"display_login":"jainkuniya"}}