{"action":"created","issue":{"url":"https://api.github.com/repos/ory/hydra-consent-app-go/issues/11","repository_url":"https://api.github.com/repos/ory/hydra-consent-app-go","labels_url":"https://api.github.com/repos/ory/hydra-consent-app-go/issues/11/labels{/name}","comments_url":"https://api.github.com/repos/ory/hydra-consent-app-go/issues/11/comments","events_url":"https://api.github.com/repos/ory/hydra-consent-app-go/issues/11/events","html_url":"https://github.com/ory/hydra-consent-app-go/issues/11","id":318255558,"number":11,"title":"Unclear code","user":{"login":"MOZGIII","id":265507,"avatar_url":"https://avatars3.githubusercontent.com/u/265507?v=4","gravatar_id":"","url":"https://api.github.com/users/MOZGIII","html_url":"https://github.com/MOZGIII","followers_url":"https://api.github.com/users/MOZGIII/followers","following_url":"https://api.github.com/users/MOZGIII/following{/other_user}","gists_url":"https://api.github.com/users/MOZGIII/gists{/gist_id}","starred_url":"https://api.github.com/users/MOZGIII/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MOZGIII/subscriptions","organizations_url":"https://api.github.com/users/MOZGIII/orgs","repos_url":"https://api.github.com/users/MOZGIII/repos","events_url":"https://api.github.com/users/MOZGIII/events{/privacy}","received_events_url":"https://api.github.com/users/MOZGIII/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-04-27T02:18:32Z","updated_at":"2018-04-27T08:10:34Z","closed_at":null,"author_association":"NONE","body":"Consider this code:\r\n\r\nhttps://github.com/ory/hydra-consent-app-go/blob/29e5a465dcb9bc8d3d75f9bea04d20b0c0984ae2/main.go#L66-L73\r\n\r\nAt line 67 `client.GetOAuth2Config()` is called and the value is assigned to `config` var.\r\nAt line 71 `client.GetOAuth2Config()` is called again, and the `config` var in not used.\r\n\r\nWhy is that? Is it a bug, and `client` var should be used on line 71?"},"comment":{"url":"https://api.github.com/repos/ory/hydra-consent-app-go/issues/comments/384898338","html_url":"https://github.com/ory/hydra-consent-app-go/issues/11#issuecomment-384898338","issue_url":"https://api.github.com/repos/ory/hydra-consent-app-go/issues/11","id":384898338,"user":{"login":"MOZGIII","id":265507,"avatar_url":"https://avatars3.githubusercontent.com/u/265507?v=4","gravatar_id":"","url":"https://api.github.com/users/MOZGIII","html_url":"https://github.com/MOZGIII","followers_url":"https://api.github.com/users/MOZGIII/followers","following_url":"https://api.github.com/users/MOZGIII/following{/other_user}","gists_url":"https://api.github.com/users/MOZGIII/gists{/gist_id}","starred_url":"https://api.github.com/users/MOZGIII/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MOZGIII/subscriptions","organizations_url":"https://api.github.com/users/MOZGIII/orgs","repos_url":"https://api.github.com/users/MOZGIII/repos","events_url":"https://api.github.com/users/MOZGIII/events{/privacy}","received_events_url":"https://api.github.com/users/MOZGIII/received_events","type":"User","site_admin":false},"created_at":"2018-04-27T08:10:34Z","updated_at":"2018-04-27T08:10:34Z","author_association":"NONE","body":"Any reason why it's not properly setup on initialization and is written like this? This code is actually not thread-safe: if values are updated via a pointer, multiple goroutines can potentially race over setting those values. Go has happens before semantics if the event ordering is clearly defined in the code (i.e. via channels), and in this case it's not properly specified."}}
{"actor":{"display_login":"MOZGIII"}}