{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/azure-functions-core-tools/pulls/comments/245114857","pull_request_review_id":189159525,"id":245114857,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NTExNDg1Nw==","diff_hunk":"@@ -160,26 +163,40 @@ internal static async Task<Stream> GetPythonDeploymentPackage(IEnumerable<string\n             }\n             else\n             {\n-                return await InternalPreparePythonDeployment(files, functionAppRoot);\n+                return await InternalPreparePythonDeployment(files, functionAppRoot, requirementsTxtFile);\n             }\n         }\n \n-        private static async Task<Stream> InternalPreparePythonDeployment(IEnumerable<string> files, string functionAppRoot)\n+        private static async Task<string> FilterRequirementsTxt(string functionAppRoot, string userRequirements)\n+        {\n+            var userRequirementsContents = FileSystemHelpers.ReadAllLines(userRequirements);\n+\n+            var tmp = Path.Combine(Path.GetTempPath(), Path.GetTempFileName().Replace(\".\", string.Empty));\n+            FileSystemHelpers.EnsureDirectory(tmp);\n+\n+            // Filter the packages that are cached irrespective of their versions\n+            var newRequirements = userRequirementsContents.Where(req => !Constants.CachedPythonPackages.Any(req.Contains));","path":"src/Azure.Functions.Cli/Helpers/PythonHelpers.cs","position":43,"original_position":43,"commit_id":"74cd12d32f95b7ad342fcecd41914b5086f0e5b8","original_commit_id":"74cd12d32f95b7ad342fcecd41914b5086f0e5b8","user":{"login":"ankitkumarr","id":16520682,"node_id":"MDQ6VXNlcjE2NTIwNjgy","avatar_url":"https://avatars1.githubusercontent.com/u/16520682?v=4","gravatar_id":"","url":"https://api.github.com/users/ankitkumarr","html_url":"https://github.com/ankitkumarr","followers_url":"https://api.github.com/users/ankitkumarr/followers","following_url":"https://api.github.com/users/ankitkumarr/following{/other_user}","gists_url":"https://api.github.com/users/ankitkumarr/gists{/gist_id}","starred_url":"https://api.github.com/users/ankitkumarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ankitkumarr/subscriptions","organizations_url":"https://api.github.com/users/ankitkumarr/orgs","repos_url":"https://api.github.com/users/ankitkumarr/repos","events_url":"https://api.github.com/users/ankitkumarr/events{/privacy}","received_events_url":"https://api.github.com/users/ankitkumarr/received_events","type":"User","site_admin":false},"body":"May need to explicitly check instead of doing `contains`. Otherwise, packages named like `azure-functions-wsgi-adapter` may also get ignored.","created_at":"2019-01-03T19:54:58Z","updated_at":"2019-01-03T19:54:59Z","html_url":"https://github.com/Azure/azure-functions-core-tools/pull/900#discussion_r245114857","pull_request_url":"https://api.github.com/repos/Azure/azure-functions-core-tools/pulls/900","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-functions-core-tools/pulls/comments/245114857"},"html":{"href":"https://github.com/Azure/azure-functions-core-tools/pull/900#discussion_r245114857"},"pull_request":{"href":"https://api.github.com/repos/Azure/azure-functions-core-tools/pulls/900"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/azure-functions-core-tools/pulls/900","id":234761736,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0NzYxNzM2","html_url":"https://github.com/Azure/azure-functions-core-tools/pull/900","diff_url":"https://github.com/Azure/azure-functions-core-tools/pull/900.diff","patch_url":"https://github.com/Azure/azure-functions-core-tools/pull/900.patch","issue_url":"https://api.github.com/repos/Azure/azure-functions-core-tools/issues/900","number":900,"state":"open","locked":false,"title":"Fixes #871 - Ignore python worker when packaging","user":{"login":"ankitkumarr","id":16520682,"node_id":"MDQ6VXNlcjE2NTIwNjgy","avatar_url":"https://avatars1.githubusercontent.com/u/16520682?v=4","gravatar_id":"","url":"https://api.github.com/users/ankitkumarr","html_url":"https://github.com/ankitkumarr","followers_url":"https://api.github.com/users/ankitkumarr/followers","following_url":"https://api.github.com/users/ankitkumarr/following{/other_user}","gists_url":"https://api.github.com/users/ankitkumarr/gists{/gist_id}","starred_url":"https://api.github.com/users/ankitkumarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ankitkumarr/subscriptions","organizations_url":"https://api.github.com/users/ankitkumarr/orgs","repos_url":"https://api.github.com/users/ankitkumarr/repos","events_url":"https://api.github.com/users/ankitkumarr/events{/privacy}","received_events_url":"https://api.github.com/users/ankitkumarr/received_events","type":"User","site_admin":false},"body":"IMPORTANT: This change will not work until the python docker image 2.0 is updated.\r\n\r\nTesting is in progress. To test locally, please update [this](https://github.com/Azure/azure-functions-core-tools/blob/78a24dfe505fe3939410c93218b6e47391f06558/src/Azure.Functions.Cli/Common/Constants.cs#L60) docker image tag.\r\n\r\n/cc @ahmelsayed  @asavaritayal @maiqbal11 ","created_at":"2018-11-29T19:40:16Z","updated_at":"2019-01-03T19:54:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"582bada93adc0a0dea3cd76848513b70f0ee8538","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ahmelsayed","id":645740,"node_id":"MDQ6VXNlcjY0NTc0MA==","avatar_url":"https://avatars0.githubusercontent.com/u/645740?v=4","gravatar_id":"","url":"https://api.github.com/users/ahmelsayed","html_url":"https://github.com/ahmelsayed","followers_url":"https://api.github.com/users/ahmelsayed/followers","following_url":"https://api.github.com/users/ahmelsayed/following{/other_user}","gists_url":"https://api.github.com/users/ahmelsayed/gists{/gist_id}","starred_url":"https://api.github.com/users/ahmelsayed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahmelsayed/subscriptions","organizations_url":"https://api.github.com/users/ahmelsayed/orgs","repos_url":"https://api.github.com/users/ahmelsayed/repos","events_url":"https://api.github.com/users/ahmelsayed/events{/privacy}","received_events_url":"https://api.github.com/users/ahmelsayed/received_events","type":"User","site_admin":false},{"login":"fabiocav","id":2507935,"node_id":"MDQ6VXNlcjI1MDc5MzU=","avatar_url":"https://avatars2.githubusercontent.com/u/2507935?v=4","gravatar_id":"","url":"https://api.github.com/users/fabiocav","html_url":"https://github.com/fabiocav","followers_url":"https://api.github.com/users/fabiocav/followers","following_url":"https://api.github.com/users/fabiocav/following{/other_user}","gists_url":"https://api.github.com/users/fabiocav/gists{/gist_id}","starred_url":"https://api.github.com/users/fabiocav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabiocav/subscriptions","organizations_url":"https://api.github.com/users/fabiocav/orgs","repos_url":"https://api.github.com/users/fabiocav/repos","events_url":"https://api.github.com/users/fabiocav/events{/privacy}","received_events_url":"https://api.github.com/users/fabiocav/received_events","type":"User","site_admin":false},{"login":"soninaren","id":8119379,"node_id":"MDQ6VXNlcjgxMTkzNzk=","avatar_url":"https://avatars0.githubusercontent.com/u/8119379?v=4","gravatar_id":"","url":"https://api.github.com/users/soninaren","html_url":"https://github.com/soninaren","followers_url":"https://api.github.com/users/soninaren/followers","following_url":"https://api.github.com/users/soninaren/following{/other_user}","gists_url":"https://api.github.com/users/soninaren/gists{/gist_id}","starred_url":"https://api.github.com/users/soninaren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soninaren/subscriptions","organizations_url":"https://api.github.com/users/soninaren/orgs","repos_url":"https://api.github.com/users/soninaren/repos","events_url":"https://api.github.com/users/soninaren/events{/privacy}","received_events_url":"https://api.github.com/users/soninaren/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1113245881,"node_id":"MDU6TGFiZWwxMTEzMjQ1ODgx","url":"https://api.github.com/repos/Azure/azure-functions-core-tools/labels/Do%20not%20merge%20yet","name":"Do not merge yet","color":"b9e251","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/azure-functions-core-tools/pulls/900/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-functions-core-tools/pulls/900/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-functions-core-tools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-functions-core-tools/issues/900/comments","statuses_url":"https://api.github.com/repos/Azure/azure-functions-core-tools/statuses/74cd12d32f95b7ad342fcecd41914b5086f0e5b8","head":{"label":"Azure:ankikuma-rm-py-worker","ref":"ankikuma-rm-py-worker","sha":"74cd12d32f95b7ad342fcecd41914b5086f0e5b8","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":77990768,"node_id":"MDEwOlJlcG9zaXRvcnk3Nzk5MDc2OA==","name":"azure-functions-core-tools","full_name":"Azure/azure-functions-core-tools","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/azure-functions-core-tools","description":"Command line tools for Azure Functions","fork":false,"url":"https://api.github.com/repos/Azure/azure-functions-core-tools","forks_url":"https://api.github.com/repos/Azure/azure-functions-core-tools/forks","keys_url":"https://api.github.com/repos/Azure/azure-functions-core-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-functions-core-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-functions-core-tools/teams","hooks_url":"https://api.github.com/repos/Azure/azure-functions-core-tools/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-functions-core-tools/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-functions-core-tools/events","assignees_url":"https://api.github.com/repos/Azure/azure-functions-core-tools/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-functions-core-tools/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-functions-core-tools/tags","blobs_url":"https://api.github.com/repos/Azure/azure-functions-core-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-functions-core-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-functions-core-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-functions-core-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-functions-core-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-functions-core-tools/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-functions-core-tools/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-functions-core-tools/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-functions-core-tools/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-functions-core-tools/subscription","commits_url":"https://api.github.com/repos/Azure/azure-functions-core-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-functions-core-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-functions-core-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-functions-core-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-functions-core-tools/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-functions-core-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-functions-core-tools/merges","archive_url":"https://api.github.com/repos/Azure/azure-functions-core-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-functions-core-tools/downloads","issues_url":"https://api.github.com/repos/Azure/azure-functions-core-tools/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-functions-core-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-functions-core-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-functions-core-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-functions-core-tools/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-functions-core-tools/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-functions-core-tools/deployments","created_at":"2017-01-04T07:09:00Z","updated_at":"2019-01-02T05:31:18Z","pushed_at":"2018-12-24T12:28:09Z","git_url":"git://github.com/Azure/azure-functions-core-tools.git","ssh_url":"git@github.com:Azure/azure-functions-core-tools.git","clone_url":"https://github.com/Azure/azure-functions-core-tools.git","svn_url":"https://github.com/Azure/azure-functions-core-tools","homepage":"","size":1370,"stargazers_count":293,"watchers_count":293,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":114,"mirror_url":null,"archived":false,"open_issues_count":200,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":114,"open_issues":200,"watchers":293,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"cd919dc1f4e993a631a9fdc43bd0946660a4ca86","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":77990768,"node_id":"MDEwOlJlcG9zaXRvcnk3Nzk5MDc2OA==","name":"azure-functions-core-tools","full_name":"Azure/azure-functions-core-tools","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/azure-functions-core-tools","description":"Command line tools for Azure Functions","fork":false,"url":"https://api.github.com/repos/Azure/azure-functions-core-tools","forks_url":"https://api.github.com/repos/Azure/azure-functions-core-tools/forks","keys_url":"https://api.github.com/repos/Azure/azure-functions-core-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-functions-core-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-functions-core-tools/teams","hooks_url":"https://api.github.com/repos/Azure/azure-functions-core-tools/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-functions-core-tools/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-functions-core-tools/events","assignees_url":"https://api.github.com/repos/Azure/azure-functions-core-tools/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-functions-core-tools/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-functions-core-tools/tags","blobs_url":"https://api.github.com/repos/Azure/azure-functions-core-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-functions-core-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-functions-core-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-functions-core-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-functions-core-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-functions-core-tools/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-functions-core-tools/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-functions-core-tools/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-functions-core-tools/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-functions-core-tools/subscription","commits_url":"https://api.github.com/repos/Azure/azure-functions-core-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-functions-core-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-functions-core-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-functions-core-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-functions-core-tools/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-functions-core-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-functions-core-tools/merges","archive_url":"https://api.github.com/repos/Azure/azure-functions-core-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-functions-core-tools/downloads","issues_url":"https://api.github.com/repos/Azure/azure-functions-core-tools/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-functions-core-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-functions-core-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-functions-core-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-functions-core-tools/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-functions-core-tools/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-functions-core-tools/deployments","created_at":"2017-01-04T07:09:00Z","updated_at":"2019-01-02T05:31:18Z","pushed_at":"2018-12-24T12:28:09Z","git_url":"git://github.com/Azure/azure-functions-core-tools.git","ssh_url":"git@github.com:Azure/azure-functions-core-tools.git","clone_url":"https://github.com/Azure/azure-functions-core-tools.git","svn_url":"https://github.com/Azure/azure-functions-core-tools","homepage":"","size":1370,"stargazers_count":293,"watchers_count":293,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":114,"mirror_url":null,"archived":false,"open_issues_count":200,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":114,"open_issues":200,"watchers":293,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-functions-core-tools/pulls/900"},"html":{"href":"https://github.com/Azure/azure-functions-core-tools/pull/900"},"issue":{"href":"https://api.github.com/repos/Azure/azure-functions-core-tools/issues/900"},"comments":{"href":"https://api.github.com/repos/Azure/azure-functions-core-tools/issues/900/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-functions-core-tools/pulls/900/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-functions-core-tools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-functions-core-tools/pulls/900/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-functions-core-tools/statuses/74cd12d32f95b7ad342fcecd41914b5086f0e5b8"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"ankitkumarr"}}