{"action":"created","issue":{"url":"https://api.github.com/repos/Luna-Tensorflow/Luna-Tensorflow/issues/28","repository_url":"https://api.github.com/repos/Luna-Tensorflow/Luna-Tensorflow","labels_url":"https://api.github.com/repos/Luna-Tensorflow/Luna-Tensorflow/issues/28/labels{/name}","comments_url":"https://api.github.com/repos/Luna-Tensorflow/Luna-Tensorflow/issues/28/comments","events_url":"https://api.github.com/repos/Luna-Tensorflow/Luna-Tensorflow/issues/28/events","html_url":"https://github.com/Luna-Tensorflow/Luna-Tensorflow/issues/28","id":387459633,"node_id":"MDU6SXNzdWUzODc0NTk2MzM=","number":28,"title":"Implement deduplication","user":{"login":"Swordlash","id":26578969,"node_id":"MDQ6VXNlcjI2NTc4OTY5","avatar_url":"https://avatars3.githubusercontent.com/u/26578969?v=4","gravatar_id":"","url":"https://api.github.com/users/Swordlash","html_url":"https://github.com/Swordlash","followers_url":"https://api.github.com/users/Swordlash/followers","following_url":"https://api.github.com/users/Swordlash/following{/other_user}","gists_url":"https://api.github.com/users/Swordlash/gists{/gist_id}","starred_url":"https://api.github.com/users/Swordlash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Swordlash/subscriptions","organizations_url":"https://api.github.com/users/Swordlash/orgs","repos_url":"https://api.github.com/users/Swordlash/repos","events_url":"https://api.github.com/users/Swordlash/events{/privacy}","received_events_url":"https://api.github.com/users/Swordlash/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-12-04T20:10:23Z","updated_at":"2018-12-06T18:57:52Z","closed_at":"2018-12-06T18:42:15Z","author_association":"COLLABORATOR","body":"In our current graph model, many nodes, when reused, can be computed multiple times. To handle this issue, we have to implement deduplication, not to create nodes that are already in the graph, but to return those existing nodes."},"comment":{"url":"https://api.github.com/repos/Luna-Tensorflow/Luna-Tensorflow/issues/comments/444987423","html_url":"https://github.com/Luna-Tensorflow/Luna-Tensorflow/issues/28#issuecomment-444987423","issue_url":"https://api.github.com/repos/Luna-Tensorflow/Luna-Tensorflow/issues/28","id":444987423,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NDk4NzQyMw==","user":{"login":"Swordlash","id":26578969,"node_id":"MDQ6VXNlcjI2NTc4OTY5","avatar_url":"https://avatars3.githubusercontent.com/u/26578969?v=4","gravatar_id":"","url":"https://api.github.com/users/Swordlash","html_url":"https://github.com/Swordlash","followers_url":"https://api.github.com/users/Swordlash/followers","following_url":"https://api.github.com/users/Swordlash/following{/other_user}","gists_url":"https://api.github.com/users/Swordlash/gists{/gist_id}","starred_url":"https://api.github.com/users/Swordlash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Swordlash/subscriptions","organizations_url":"https://api.github.com/users/Swordlash/orgs","repos_url":"https://api.github.com/users/Swordlash/repos","events_url":"https://api.github.com/users/Swordlash/events{/privacy}","received_events_url":"https://api.github.com/users/Swordlash/received_events","type":"User","site_admin":false},"created_at":"2018-12-06T18:57:52Z","updated_at":"2018-12-06T18:57:52Z","author_association":"COLLABORATOR","body":"Yes, after placeholders/variables are added, we can enable back deduplication of consts. In general, const is a const and two consts of the same value are mathematically the same objects, but in the current implementation consts also serve as variables, so we can't deduplicate them based on their values only."}}
{"actor":{"display_login":"Swordlash"}}