{"action":"created","issue":{"url":"https://api.github.com/repos/tock/tock/issues/1223","repository_url":"https://api.github.com/repos/tock/tock","labels_url":"https://api.github.com/repos/tock/tock/issues/1223/labels{/name}","comments_url":"https://api.github.com/repos/tock/tock/issues/1223/comments","events_url":"https://api.github.com/repos/tock/tock/issues/1223/events","html_url":"https://github.com/tock/tock/pull/1223","id":385306459,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0MzA2ODM4","number":1223,"title":"nrf52[840]dk: correct the ordering of pins","user":{"login":"bradjc","id":1467890,"node_id":"MDQ6VXNlcjE0Njc4OTA=","avatar_url":"https://avatars1.githubusercontent.com/u/1467890?v=4","gravatar_id":"","url":"https://api.github.com/users/bradjc","html_url":"https://github.com/bradjc","followers_url":"https://api.github.com/users/bradjc/followers","following_url":"https://api.github.com/users/bradjc/following{/other_user}","gists_url":"https://api.github.com/users/bradjc/gists{/gist_id}","starred_url":"https://api.github.com/users/bradjc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradjc/subscriptions","organizations_url":"https://api.github.com/users/bradjc/orgs","repos_url":"https://api.github.com/users/bradjc/repos","events_url":"https://api.github.com/users/bradjc/events{/privacy}","received_events_url":"https://api.github.com/users/bradjc/received_events","type":"User","site_admin":false},"labels":[{"id":217293616,"node_id":"MDU6TGFiZWwyMTcyOTM2MTY=","url":"https://api.github.com/repos/tock/tock/labels/bug","name":"bug","color":"fc2929","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-11-28T14:56:48Z","updated_at":"2018-11-29T15:21:48Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/tock/tock/pulls/1223","html_url":"https://github.com/tock/tock/pull/1223","diff_url":"https://github.com/tock/tock/pull/1223.diff","patch_url":"https://github.com/tock/tock/pull/1223.patch"},"body":"The RX pin must be specified last for `UartPins::new()`.\r\n\r\nhttps://github.com/tock/tock/blob/1d8cadd4e45698807c1a9d1a7e8f317fd7a197dc/boards/nordic/nrf52dk_base/src/lib.rs#L69-L73\r\n\r\n\r\n### Testing Strategy\r\n\r\nI tried running `console_timeout` on the nrf52840dk and it didn't do anything, and I tracked it down to this. It looks like the fix is also required on the nrf52dk board, but Amit marked the `console_timeout` test as working, so I'm not sure what to make of that.\r\n\r\n\r\n### TODO or Help Wanted\r\n\r\nn/a\r\n\r\n\r\n### Documentation Updated\r\n\r\n- [x] Updated the relevant files in `/docs`, or no updates are required.\r\n\r\n### Formatting\r\n\r\n- [x] Ran `make formatall`.\r\n"},"comment":{"url":"https://api.github.com/repos/tock/tock/issues/comments/442872503","html_url":"https://github.com/tock/tock/pull/1223#issuecomment-442872503","issue_url":"https://api.github.com/repos/tock/tock/issues/1223","id":442872503,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0Mjg3MjUwMw==","user":{"login":"alevy","id":4689,"node_id":"MDQ6VXNlcjQ2ODk=","avatar_url":"https://avatars1.githubusercontent.com/u/4689?v=4","gravatar_id":"","url":"https://api.github.com/users/alevy","html_url":"https://github.com/alevy","followers_url":"https://api.github.com/users/alevy/followers","following_url":"https://api.github.com/users/alevy/following{/other_user}","gists_url":"https://api.github.com/users/alevy/gists{/gist_id}","starred_url":"https://api.github.com/users/alevy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alevy/subscriptions","organizations_url":"https://api.github.com/users/alevy/orgs","repos_url":"https://api.github.com/users/alevy/repos","events_url":"https://api.github.com/users/alevy/events{/privacy}","received_events_url":"https://api.github.com/users/alevy/received_events","type":"User","site_admin":false},"created_at":"2018-11-29T15:21:48Z","updated_at":"2018-11-29T15:21:48Z","author_association":"MEMBER","body":"bors r+"}}
{"actor":{"display_login":"alevy"}}