{"action":"created","issue":{"url":"https://api.github.com/repos/xeger/kos-ramp/issues/39","repository_url":"https://api.github.com/repos/xeger/kos-ramp","labels_url":"https://api.github.com/repos/xeger/kos-ramp/issues/39/labels{/name}","comments_url":"https://api.github.com/repos/xeger/kos-ramp/issues/39/comments","events_url":"https://api.github.com/repos/xeger/kos-ramp/issues/39/events","html_url":"https://github.com/xeger/kos-ramp/pull/39","id":298425242,"number":39,"title":"Tests, Launch improvements and fixes","user":{"login":"firda-cze","id":11376520,"avatar_url":"https://avatars2.githubusercontent.com/u/11376520?v=4","gravatar_id":"","url":"https://api.github.com/users/firda-cze","html_url":"https://github.com/firda-cze","followers_url":"https://api.github.com/users/firda-cze/followers","following_url":"https://api.github.com/users/firda-cze/following{/other_user}","gists_url":"https://api.github.com/users/firda-cze/gists{/gist_id}","starred_url":"https://api.github.com/users/firda-cze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firda-cze/subscriptions","organizations_url":"https://api.github.com/users/firda-cze/orgs","repos_url":"https://api.github.com/users/firda-cze/repos","events_url":"https://api.github.com/users/firda-cze/events{/privacy}","received_events_url":"https://api.github.com/users/firda-cze/received_events","type":"User","site_admin":false},"labels":[{"id":215201542,"url":"https://api.github.com/repos/xeger/kos-ramp/labels/help%20wanted","name":"help wanted","color":"159818","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":14,"created_at":"2018-02-19T23:12:52Z","updated_at":"2018-02-26T03:42:44Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/xeger/kos-ramp/pulls/39","html_url":"https://github.com/xeger/kos-ramp/pull/39","diff_url":"https://github.com/xeger/kos-ramp/pull/39.diff","patch_url":"https://github.com/xeger/kos-ramp/pull/39.patch"},"body":"I would like to add some tests, that we can all see what individual parts are doing and make sure everything works. Every test rocket/ship/script should either auto-boot and do what is needed or include MD description of same name (will do that later).\r\n\r\nThe rocket is overcomplicated on purpose and already revealed some problems I will address soon:\r\n\r\n1. Staging of booster+tank combo needed better logic - boosters are no longer treated as engines but as tanks. But as I am writing this I also realized this could cause problems on its own - if normal engines are flamed out, they won't wait for the boosters to flame out, damn, will think about that.\r\n\r\n2. Launch script needs improvements. I have my own launch script, will try to get the best of both.\r\n\r\n3. NOAUTO not working as expected. I did some test when pushing it, worked, but not with this test twin. Will fix that too.\r\n\r\nP.S.: Should I change lib_parts so that it also performs actions/events on parts with same tag as executing core if no tag provided (or empty)?"},"comment":{"url":"https://api.github.com/repos/xeger/kos-ramp/issues/comments/368381767","html_url":"https://github.com/xeger/kos-ramp/pull/39#issuecomment-368381767","issue_url":"https://api.github.com/repos/xeger/kos-ramp/issues/39","id":368381767,"user":{"login":"mathuin","id":221823,"avatar_url":"https://avatars2.githubusercontent.com/u/221823?v=4","gravatar_id":"","url":"https://api.github.com/users/mathuin","html_url":"https://github.com/mathuin","followers_url":"https://api.github.com/users/mathuin/followers","following_url":"https://api.github.com/users/mathuin/following{/other_user}","gists_url":"https://api.github.com/users/mathuin/gists{/gist_id}","starred_url":"https://api.github.com/users/mathuin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mathuin/subscriptions","organizations_url":"https://api.github.com/users/mathuin/orgs","repos_url":"https://api.github.com/users/mathuin/repos","events_url":"https://api.github.com/users/mathuin/events{/privacy}","received_events_url":"https://api.github.com/users/mathuin/received_events","type":"User","site_admin":false},"created_at":"2018-02-26T03:42:44Z","updated_at":"2018-02-26T03:42:44Z","author_association":"COLLABORATOR","body":"My thrust vector is in line with the center of mass, so I don't think `utilFaceBurn` is involved.  While I hear you about node.ks not being as precise as circ.ks, all I can tell you is that I got no burn faults with the current master branch, and I did with the code in this pull request.\r\n\r\nMy game time is limited right now, but the next time I start KSP I will ensure I have the latest version of your changes, and I will test your vessels and mine.\r\n"}}
{"actor":{"display_login":"mathuin"}}