{"action":"created","comment":{"url":"https://api.github.com/repos/qmk/qmk_firmware/pulls/comments/233154960","pull_request_review_id":174502104,"id":233154960,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzE1NDk2MA==","diff_hunk":"@@ -7,6 +7,9 @@\n #include <stdlib.h>\n #include \"eeconfig.h\"\n \n+// backlight level store index in serial_master_buffer[] for slave to read\n+#define SERIAL_BACKLIT_START   0x00","path":"quantum/split_common/split_util.h","position":5,"original_position":5,"commit_id":"15b0021b4092127b8d8a21f572642ad3702b46d4","original_commit_id":"15b0021b4092127b8d8a21f572642ad3702b46d4","user":{"login":"drashna","id":2584963,"node_id":"MDQ6VXNlcjI1ODQ5NjM=","avatar_url":"https://avatars2.githubusercontent.com/u/2584963?v=4","gravatar_id":"","url":"https://api.github.com/users/drashna","html_url":"https://github.com/drashna","followers_url":"https://api.github.com/users/drashna/followers","following_url":"https://api.github.com/users/drashna/following{/other_user}","gists_url":"https://api.github.com/users/drashna/gists{/gist_id}","starred_url":"https://api.github.com/users/drashna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drashna/subscriptions","organizations_url":"https://api.github.com/users/drashna/orgs","repos_url":"https://api.github.com/users/drashna/repos","events_url":"https://api.github.com/users/drashna/events{/privacy}","received_events_url":"https://api.github.com/users/drashna/received_events","type":"User","site_admin":false},"body":"Shouldn't this be left in serial.h? ","created_at":"2018-11-13T17:51:29Z","updated_at":"2018-11-13T17:51:48Z","html_url":"https://github.com/qmk/qmk_firmware/pull/4419#discussion_r233154960","pull_request_url":"https://api.github.com/repos/qmk/qmk_firmware/pulls/4419","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/qmk/qmk_firmware/pulls/comments/233154960"},"html":{"href":"https://github.com/qmk/qmk_firmware/pull/4419#discussion_r233154960"},"pull_request":{"href":"https://api.github.com/repos/qmk/qmk_firmware/pulls/4419"}}},"pull_request":{"url":"https://api.github.com/repos/qmk/qmk_firmware/pulls/4419","id":230564147,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwNTY0MTQ3","html_url":"https://github.com/qmk/qmk_firmware/pull/4419","diff_url":"https://github.com/qmk/qmk_firmware/pull/4419.diff","patch_url":"https://github.com/qmk/qmk_firmware/pull/4419.patch","issue_url":"https://api.github.com/repos/qmk/qmk_firmware/issues/4419","number":4419,"state":"open","locked":false,"title":"Make quantum/split_common/serial.[ch] configurable","user":{"login":"mtei","id":2170248,"node_id":"MDQ6VXNlcjIxNzAyNDg=","avatar_url":"https://avatars3.githubusercontent.com/u/2170248?v=4","gravatar_id":"","url":"https://api.github.com/users/mtei","html_url":"https://github.com/mtei","followers_url":"https://api.github.com/users/mtei/followers","following_url":"https://api.github.com/users/mtei/following{/other_user}","gists_url":"https://api.github.com/users/mtei/gists{/gist_id}","starred_url":"https://api.github.com/users/mtei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtei/subscriptions","organizations_url":"https://api.github.com/users/mtei/orgs","repos_url":"https://api.github.com/users/mtei/repos","events_url":"https://api.github.com/users/mtei/events{/privacy}","received_events_url":"https://api.github.com/users/mtei/received_events","type":"User","site_admin":false},"body":"quantum/split_common/serial.c change to helix-serial.c style serial configuration\r\n\r\nThis request does not change the compilation results.\r\n\r\nreffer #3709, #4254.\r\n","created_at":"2018-11-13T17:33:35Z","updated_at":"2018-11-13T17:51:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":155557982,"node_id":"MDU6TGFiZWwxNTU1NTc5ODI=","url":"https://api.github.com/repos/qmk/qmk_firmware/labels/enhancement","name":"enhancement","color":"c5def5","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/qmk/qmk_firmware/pulls/4419/commits","review_comments_url":"https://api.github.com/repos/qmk/qmk_firmware/pulls/4419/comments","review_comment_url":"https://api.github.com/repos/qmk/qmk_firmware/pulls/comments{/number}","comments_url":"https://api.github.com/repos/qmk/qmk_firmware/issues/4419/comments","statuses_url":"https://api.github.com/repos/qmk/qmk_firmware/statuses/15b0021b4092127b8d8a21f572642ad3702b46d4","head":{"label":"mtei:make-quantum_split_common_serial-h-configurable","ref":"make-quantum_split_common_serial-h-configurable","sha":"15b0021b4092127b8d8a21f572642ad3702b46d4","user":{"login":"mtei","id":2170248,"node_id":"MDQ6VXNlcjIxNzAyNDg=","avatar_url":"https://avatars3.githubusercontent.com/u/2170248?v=4","gravatar_id":"","url":"https://api.github.com/users/mtei","html_url":"https://github.com/mtei","followers_url":"https://api.github.com/users/mtei/followers","following_url":"https://api.github.com/users/mtei/following{/other_user}","gists_url":"https://api.github.com/users/mtei/gists{/gist_id}","starred_url":"https://api.github.com/users/mtei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtei/subscriptions","organizations_url":"https://api.github.com/users/mtei/orgs","repos_url":"https://api.github.com/users/mtei/repos","events_url":"https://api.github.com/users/mtei/events{/privacy}","received_events_url":"https://api.github.com/users/mtei/received_events","type":"User","site_admin":false},"repo":{"id":110089908,"node_id":"MDEwOlJlcG9zaXRvcnkxMTAwODk5MDg=","name":"qmk_firmware","full_name":"mtei/qmk_firmware","private":false,"owner":{"login":"mtei","id":2170248,"node_id":"MDQ6VXNlcjIxNzAyNDg=","avatar_url":"https://avatars3.githubusercontent.com/u/2170248?v=4","gravatar_id":"","url":"https://api.github.com/users/mtei","html_url":"https://github.com/mtei","followers_url":"https://api.github.com/users/mtei/followers","following_url":"https://api.github.com/users/mtei/following{/other_user}","gists_url":"https://api.github.com/users/mtei/gists{/gist_id}","starred_url":"https://api.github.com/users/mtei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtei/subscriptions","organizations_url":"https://api.github.com/users/mtei/orgs","repos_url":"https://api.github.com/users/mtei/repos","events_url":"https://api.github.com/users/mtei/events{/privacy}","received_events_url":"https://api.github.com/users/mtei/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mtei/qmk_firmware","description":"keyboard controller firmware for Atmel AVR and ARM USB families","fork":true,"url":"https://api.github.com/repos/mtei/qmk_firmware","forks_url":"https://api.github.com/repos/mtei/qmk_firmware/forks","keys_url":"https://api.github.com/repos/mtei/qmk_firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mtei/qmk_firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mtei/qmk_firmware/teams","hooks_url":"https://api.github.com/repos/mtei/qmk_firmware/hooks","issue_events_url":"https://api.github.com/repos/mtei/qmk_firmware/issues/events{/number}","events_url":"https://api.github.com/repos/mtei/qmk_firmware/events","assignees_url":"https://api.github.com/repos/mtei/qmk_firmware/assignees{/user}","branches_url":"https://api.github.com/repos/mtei/qmk_firmware/branches{/branch}","tags_url":"https://api.github.com/repos/mtei/qmk_firmware/tags","blobs_url":"https://api.github.com/repos/mtei/qmk_firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mtei/qmk_firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mtei/qmk_firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/mtei/qmk_firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mtei/qmk_firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/mtei/qmk_firmware/languages","stargazers_url":"https://api.github.com/repos/mtei/qmk_firmware/stargazers","contributors_url":"https://api.github.com/repos/mtei/qmk_firmware/contributors","subscribers_url":"https://api.github.com/repos/mtei/qmk_firmware/subscribers","subscription_url":"https://api.github.com/repos/mtei/qmk_firmware/subscription","commits_url":"https://api.github.com/repos/mtei/qmk_firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/mtei/qmk_firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/mtei/qmk_firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/mtei/qmk_firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/mtei/qmk_firmware/contents/{+path}","compare_url":"https://api.github.com/repos/mtei/qmk_firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mtei/qmk_firmware/merges","archive_url":"https://api.github.com/repos/mtei/qmk_firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mtei/qmk_firmware/downloads","issues_url":"https://api.github.com/repos/mtei/qmk_firmware/issues{/number}","pulls_url":"https://api.github.com/repos/mtei/qmk_firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/mtei/qmk_firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/mtei/qmk_firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mtei/qmk_firmware/labels{/name}","releases_url":"https://api.github.com/repos/mtei/qmk_firmware/releases{/id}","deployments_url":"https://api.github.com/repos/mtei/qmk_firmware/deployments","created_at":"2017-11-09T08:47:53Z","updated_at":"2018-11-06T20:39:20Z","pushed_at":"2018-11-13T17:29:11Z","git_url":"git://github.com/mtei/qmk_firmware.git","ssh_url":"git@github.com:mtei/qmk_firmware.git","clone_url":"https://github.com/mtei/qmk_firmware.git","svn_url":"https://github.com/mtei/qmk_firmware","homepage":"http://qmk.fm","size":104852,"stargazers_count":2,"watchers_count":2,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":1,"watchers":2,"default_branch":"master"}},"base":{"label":"qmk:master","ref":"master","sha":"4609d68ddcf4b5094e8183f99549fe83af3cc144","user":{"login":"qmk","id":25358678,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MzU4Njc4","avatar_url":"https://avatars3.githubusercontent.com/u/25358678?v=4","gravatar_id":"","url":"https://api.github.com/users/qmk","html_url":"https://github.com/qmk","followers_url":"https://api.github.com/users/qmk/followers","following_url":"https://api.github.com/users/qmk/following{/other_user}","gists_url":"https://api.github.com/users/qmk/gists{/gist_id}","starred_url":"https://api.github.com/users/qmk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qmk/subscriptions","organizations_url":"https://api.github.com/users/qmk/orgs","repos_url":"https://api.github.com/users/qmk/repos","events_url":"https://api.github.com/users/qmk/events{/privacy}","received_events_url":"https://api.github.com/users/qmk/received_events","type":"Organization","site_admin":false},"repo":{"id":27737393,"node_id":"MDEwOlJlcG9zaXRvcnkyNzczNzM5Mw==","name":"qmk_firmware","full_name":"qmk/qmk_firmware","private":false,"owner":{"login":"qmk","id":25358678,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MzU4Njc4","avatar_url":"https://avatars3.githubusercontent.com/u/25358678?v=4","gravatar_id":"","url":"https://api.github.com/users/qmk","html_url":"https://github.com/qmk","followers_url":"https://api.github.com/users/qmk/followers","following_url":"https://api.github.com/users/qmk/following{/other_user}","gists_url":"https://api.github.com/users/qmk/gists{/gist_id}","starred_url":"https://api.github.com/users/qmk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qmk/subscriptions","organizations_url":"https://api.github.com/users/qmk/orgs","repos_url":"https://api.github.com/users/qmk/repos","events_url":"https://api.github.com/users/qmk/events{/privacy}","received_events_url":"https://api.github.com/users/qmk/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/qmk/qmk_firmware","description":"keyboard controller firmware for Atmel AVR and ARM USB families","fork":false,"url":"https://api.github.com/repos/qmk/qmk_firmware","forks_url":"https://api.github.com/repos/qmk/qmk_firmware/forks","keys_url":"https://api.github.com/repos/qmk/qmk_firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qmk/qmk_firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qmk/qmk_firmware/teams","hooks_url":"https://api.github.com/repos/qmk/qmk_firmware/hooks","issue_events_url":"https://api.github.com/repos/qmk/qmk_firmware/issues/events{/number}","events_url":"https://api.github.com/repos/qmk/qmk_firmware/events","assignees_url":"https://api.github.com/repos/qmk/qmk_firmware/assignees{/user}","branches_url":"https://api.github.com/repos/qmk/qmk_firmware/branches{/branch}","tags_url":"https://api.github.com/repos/qmk/qmk_firmware/tags","blobs_url":"https://api.github.com/repos/qmk/qmk_firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qmk/qmk_firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qmk/qmk_firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/qmk/qmk_firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qmk/qmk_firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/qmk/qmk_firmware/languages","stargazers_url":"https://api.github.com/repos/qmk/qmk_firmware/stargazers","contributors_url":"https://api.github.com/repos/qmk/qmk_firmware/contributors","subscribers_url":"https://api.github.com/repos/qmk/qmk_firmware/subscribers","subscription_url":"https://api.github.com/repos/qmk/qmk_firmware/subscription","commits_url":"https://api.github.com/repos/qmk/qmk_firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/qmk/qmk_firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/qmk/qmk_firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/qmk/qmk_firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/qmk/qmk_firmware/contents/{+path}","compare_url":"https://api.github.com/repos/qmk/qmk_firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qmk/qmk_firmware/merges","archive_url":"https://api.github.com/repos/qmk/qmk_firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qmk/qmk_firmware/downloads","issues_url":"https://api.github.com/repos/qmk/qmk_firmware/issues{/number}","pulls_url":"https://api.github.com/repos/qmk/qmk_firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/qmk/qmk_firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/qmk/qmk_firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qmk/qmk_firmware/labels{/name}","releases_url":"https://api.github.com/repos/qmk/qmk_firmware/releases{/id}","deployments_url":"https://api.github.com/repos/qmk/qmk_firmware/deployments","created_at":"2014-12-08T22:02:05Z","updated_at":"2018-11-13T17:25:31Z","pushed_at":"2018-11-13T17:33:36Z","git_url":"git://github.com/qmk/qmk_firmware.git","ssh_url":"git@github.com:qmk/qmk_firmware.git","clone_url":"https://github.com/qmk/qmk_firmware.git","svn_url":"https://github.com/qmk/qmk_firmware","homepage":"http://qmk.fm","size":120723,"stargazers_count":3225,"watchers_count":3225,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":6062,"mirror_url":null,"archived":false,"open_issues_count":308,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":6062,"open_issues":308,"watchers":3225,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/qmk/qmk_firmware/pulls/4419"},"html":{"href":"https://github.com/qmk/qmk_firmware/pull/4419"},"issue":{"href":"https://api.github.com/repos/qmk/qmk_firmware/issues/4419"},"comments":{"href":"https://api.github.com/repos/qmk/qmk_firmware/issues/4419/comments"},"review_comments":{"href":"https://api.github.com/repos/qmk/qmk_firmware/pulls/4419/comments"},"review_comment":{"href":"https://api.github.com/repos/qmk/qmk_firmware/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/qmk/qmk_firmware/pulls/4419/commits"},"statuses":{"href":"https://api.github.com/repos/qmk/qmk_firmware/statuses/15b0021b4092127b8d8a21f572642ad3702b46d4"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"drashna"}}