{"action":"created","issue":{"url":"https://api.github.com/repos/spring-projects/spring-framework/issues/1727","repository_url":"https://api.github.com/repos/spring-projects/spring-framework","labels_url":"https://api.github.com/repos/spring-projects/spring-framework/issues/1727/labels{/name}","comments_url":"https://api.github.com/repos/spring-projects/spring-framework/issues/1727/comments","events_url":"https://api.github.com/repos/spring-projects/spring-framework/issues/1727/events","html_url":"https://github.com/spring-projects/spring-framework/pull/1727","id":303566256,"number":1727,"title":"Polish: inner class calls to super class methods should be unambiguous","user":{"login":"igor-suhorukov","id":10332206,"avatar_url":"https://avatars1.githubusercontent.com/u/10332206?v=4","gravatar_id":"","url":"https://api.github.com/users/igor-suhorukov","html_url":"https://github.com/igor-suhorukov","followers_url":"https://api.github.com/users/igor-suhorukov/followers","following_url":"https://api.github.com/users/igor-suhorukov/following{/other_user}","gists_url":"https://api.github.com/users/igor-suhorukov/gists{/gist_id}","starred_url":"https://api.github.com/users/igor-suhorukov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igor-suhorukov/subscriptions","organizations_url":"https://api.github.com/users/igor-suhorukov/orgs","repos_url":"https://api.github.com/users/igor-suhorukov/repos","events_url":"https://api.github.com/users/igor-suhorukov/events{/privacy}","received_events_url":"https://api.github.com/users/igor-suhorukov/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-03-08T17:32:46Z","updated_at":"2018-03-08T17:50:16Z","closed_at":"2018-03-08T17:50:16Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/spring-projects/spring-framework/pulls/1727","html_url":"https://github.com/spring-projects/spring-framework/pull/1727","diff_url":"https://github.com/spring-projects/spring-framework/pull/1727.diff","patch_url":"https://github.com/spring-projects/spring-framework/pull/1727.patch"},"body":"When an inner class extends another class, and both its outer class and its parent class have a method with the same name, calls to that method can be confusing. The compiler will resolve the call to the superclass method, but maintainers may be confused, so the superclass method should be called explicitly, using super."},"comment":{"url":"https://api.github.com/repos/spring-projects/spring-framework/issues/comments/371567348","html_url":"https://github.com/spring-projects/spring-framework/pull/1727#issuecomment-371567348","issue_url":"https://api.github.com/repos/spring-projects/spring-framework/issues/1727","id":371567348,"user":{"login":"jhoeller","id":1263688,"avatar_url":"https://avatars1.githubusercontent.com/u/1263688?v=4","gravatar_id":"","url":"https://api.github.com/users/jhoeller","html_url":"https://github.com/jhoeller","followers_url":"https://api.github.com/users/jhoeller/followers","following_url":"https://api.github.com/users/jhoeller/following{/other_user}","gists_url":"https://api.github.com/users/jhoeller/gists{/gist_id}","starred_url":"https://api.github.com/users/jhoeller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhoeller/subscriptions","organizations_url":"https://api.github.com/users/jhoeller/orgs","repos_url":"https://api.github.com/users/jhoeller/repos","events_url":"https://api.github.com/users/jhoeller/events{/privacy}","received_events_url":"https://api.github.com/users/jhoeller/received_events","type":"User","site_admin":false},"created_at":"2018-03-08T17:50:16Z","updated_at":"2018-03-08T17:50:16Z","author_association":"CONTRIBUTOR","body":"It's a fair point, but frankly, I don't find that extra qualification important. I'm more concerned about static imports messing up the understanding of method calls than such inner vs super cases. Also, an IDE will point maintainers to the super method there anyway. All in all, I'd rather go with streamlined calls without the rather noisy prefix."}}
{"actor":{"display_login":"jhoeller"}}