{"action":"created","issue":{"url":"https://api.github.com/repos/libuv/libuv/issues/1975","repository_url":"https://api.github.com/repos/libuv/libuv","labels_url":"https://api.github.com/repos/libuv/libuv/issues/1975/labels{/name}","comments_url":"https://api.github.com/repos/libuv/libuv/issues/1975/comments","events_url":"https://api.github.com/repos/libuv/libuv/issues/1975/events","html_url":"https://github.com/libuv/libuv/issues/1975","id":356272695,"node_id":"MDU6SXNzdWUzNTYyNzI2OTU=","number":1975,"title":"Inline functions","user":{"login":"emilbayes","id":416524,"node_id":"MDQ6VXNlcjQxNjUyNA==","avatar_url":"https://avatars1.githubusercontent.com/u/416524?v=4","gravatar_id":"","url":"https://api.github.com/users/emilbayes","html_url":"https://github.com/emilbayes","followers_url":"https://api.github.com/users/emilbayes/followers","following_url":"https://api.github.com/users/emilbayes/following{/other_user}","gists_url":"https://api.github.com/users/emilbayes/gists{/gist_id}","starred_url":"https://api.github.com/users/emilbayes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emilbayes/subscriptions","organizations_url":"https://api.github.com/users/emilbayes/orgs","repos_url":"https://api.github.com/users/emilbayes/repos","events_url":"https://api.github.com/users/emilbayes/events{/privacy}","received_events_url":"https://api.github.com/users/emilbayes/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-09-02T10:59:50Z","updated_at":"2018-09-02T11:14:55Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"Hi!\r\n\r\nI was wondering why most of the functions in https://github.com/libuv/libuv/blob/e4087dedf837f415056a45a838f639a3d9dc3ced/src/uv-data-getter-setters.c are not inline. Is there an advantage to using these over just accessing the data member directly? (which is documented to be public)"},"comment":{"url":"https://api.github.com/repos/libuv/libuv/issues/comments/417923086","html_url":"https://github.com/libuv/libuv/issues/1975#issuecomment-417923086","issue_url":"https://api.github.com/repos/libuv/libuv/issues/1975","id":417923086,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNzkyMzA4Ng==","user":{"login":"addaleax","id":899444,"node_id":"MDQ6VXNlcjg5OTQ0NA==","avatar_url":"https://avatars2.githubusercontent.com/u/899444?v=4","gravatar_id":"","url":"https://api.github.com/users/addaleax","html_url":"https://github.com/addaleax","followers_url":"https://api.github.com/users/addaleax/followers","following_url":"https://api.github.com/users/addaleax/following{/other_user}","gists_url":"https://api.github.com/users/addaleax/gists{/gist_id}","starred_url":"https://api.github.com/users/addaleax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/addaleax/subscriptions","organizations_url":"https://api.github.com/users/addaleax/orgs","repos_url":"https://api.github.com/users/addaleax/repos","events_url":"https://api.github.com/users/addaleax/events{/privacy}","received_events_url":"https://api.github.com/users/addaleax/received_events","type":"User","site_admin":false},"created_at":"2018-09-02T11:14:55Z","updated_at":"2018-09-02T11:14:55Z","author_association":"CONTRIBUTOR","body":"@emilbayes I’m not sure I understand – the point of having these functions is that they don’t get inlined, since once a library user inlines these functions into their (generated) code, they are back to depending on the exact struct layout (which still stable across a single libuv major version, but that’s the situation from before)."}}
{"actor":{"display_login":"addaleax"}}