{"action":"created","issue":{"url":"https://api.github.com/repos/davebryson/py-abci/issues/14","repository_url":"https://api.github.com/repos/davebryson/py-abci","labels_url":"https://api.github.com/repos/davebryson/py-abci/issues/14/labels{/name}","comments_url":"https://api.github.com/repos/davebryson/py-abci/issues/14/comments","events_url":"https://api.github.com/repos/davebryson/py-abci/issues/14/events","html_url":"https://github.com/davebryson/py-abci/pull/14","id":291033450,"number":14,"title":"Proto with gogo","user":{"login":"sbellem","id":125458,"avatar_url":"https://avatars2.githubusercontent.com/u/125458?v=4","gravatar_id":"","url":"https://api.github.com/users/sbellem","html_url":"https://github.com/sbellem","followers_url":"https://api.github.com/users/sbellem/followers","following_url":"https://api.github.com/users/sbellem/following{/other_user}","gists_url":"https://api.github.com/users/sbellem/gists{/gist_id}","starred_url":"https://api.github.com/users/sbellem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbellem/subscriptions","organizations_url":"https://api.github.com/users/sbellem/orgs","repos_url":"https://api.github.com/users/sbellem/repos","events_url":"https://api.github.com/users/sbellem/events{/privacy}","received_events_url":"https://api.github.com/users/sbellem/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-01-23T23:40:03Z","updated_at":"2018-04-06T20:59:13Z","closed_at":"2018-01-24T01:54:39Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/davebryson/py-abci/pulls/14","html_url":"https://github.com/davebryson/py-abci/pull/14","diff_url":"https://github.com/davebryson/py-abci/pull/14.diff","patch_url":"https://github.com/davebryson/py-abci/pull/14.patch"},"body":"Addresses #9 \r\n\r\n@davebryson this PR follows your tip given in https://github.com/davebryson/py-abci/issues/9#issuecomment-358135080: \r\n\r\n* a `gogo_pb2.py`file was generated from the [`gogo.proto`](https://github.com/gogo/protobuf/blob/master/gogoproto/gogo.proto) file, and\r\n* the `proto_pb2.py` was then re-generated;\r\n* the import of `gogo_pb2` was then simplified, manually.\r\n\r\n**Suggestion for the time being**\r\n_Also detailed in #15._ \r\nSince the compiled tendermint proto file is currently distributed with the package I propose we do the same for the gogo one for _now_ and tackle the issue of distributing/compiling proto files in a separate issue (see https://stackoverflow.com/questions/27843481/python-project-using-protocol-buffers-deployment-issues and https://github.com/google/protobuf/blob/master/python/setup.py for instance).\r\n\r\n**About tests**\r\nBesides the current unit tests, I tested the changes manually with the counter example with one node only. Nevertheless, block creation, sending transactions, querying, (check_tx, deliver_tx, query, etc) appear to work as expected. \r\n\r\nI will try to add more tests in the upcoming days, but I won't probably be able to do much before next week. So it would perhaps be best to do so in a separate PR."},"comment":{"url":"https://api.github.com/repos/davebryson/py-abci/issues/comments/379376604","html_url":"https://github.com/davebryson/py-abci/pull/14#issuecomment-379376604","issue_url":"https://api.github.com/repos/davebryson/py-abci/issues/14","id":379376604,"user":{"login":"lsankar4033","id":451947,"avatar_url":"https://avatars1.githubusercontent.com/u/451947?v=4","gravatar_id":"","url":"https://api.github.com/users/lsankar4033","html_url":"https://github.com/lsankar4033","followers_url":"https://api.github.com/users/lsankar4033/followers","following_url":"https://api.github.com/users/lsankar4033/following{/other_user}","gists_url":"https://api.github.com/users/lsankar4033/gists{/gist_id}","starred_url":"https://api.github.com/users/lsankar4033/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsankar4033/subscriptions","organizations_url":"https://api.github.com/users/lsankar4033/orgs","repos_url":"https://api.github.com/users/lsankar4033/repos","events_url":"https://api.github.com/users/lsankar4033/events{/privacy}","received_events_url":"https://api.github.com/users/lsankar4033/received_events","type":"User","site_admin":false},"created_at":"2018-04-06T20:59:13Z","updated_at":"2018-04-06T20:59:13Z","author_association":"NONE","body":"@sbellem what are the steps required to update to a new version of `abci/types.proto`?"}}
{"actor":{"display_login":"lsankar4033"}}