{"action":"created","comment":{"url":"https://api.github.com/repos/fastify/fastify/pulls/comments/217896182","pull_request_review_id":155725813,"id":217896182,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzg5NjE4Mg==","diff_hunk":"@@ -324,19 +324,23 @@ server.setSchemaCompiler(function (schema: object) {\n \n server.addSchema({})\n \n-server.addContentTypeParser('foo/bar', {}, (req, done) => {","path":"test/types/index.ts","position":4,"original_position":4,"commit_id":"91fc1cdbc85e93911aa534c09256264de1157a7e","original_commit_id":"91fc1cdbc85e93911aa534c09256264de1157a7e","user":{"login":"jineshshah36","id":6501089,"node_id":"MDQ6VXNlcjY1MDEwODk=","avatar_url":"https://avatars2.githubusercontent.com/u/6501089?v=4","gravatar_id":"","url":"https://api.github.com/users/jineshshah36","html_url":"https://github.com/jineshshah36","followers_url":"https://api.github.com/users/jineshshah36/followers","following_url":"https://api.github.com/users/jineshshah36/following{/other_user}","gists_url":"https://api.github.com/users/jineshshah36/gists{/gist_id}","starred_url":"https://api.github.com/users/jineshshah36/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jineshshah36/subscriptions","organizations_url":"https://api.github.com/users/jineshshah36/orgs","repos_url":"https://api.github.com/users/jineshshah36/repos","events_url":"https://api.github.com/users/jineshshah36/events{/privacy}","received_events_url":"https://api.github.com/users/jineshshah36/received_events","type":"User","site_admin":false},"body":"This conflicts with your docs. It says:\r\n```\r\nAs you can see, now the function signature is (req, body, done) instead of (req, done)\r\n```","created_at":"2018-09-15T21:41:13Z","updated_at":"2018-09-15T21:41:13Z","html_url":"https://github.com/fastify/fastify/pull/1162#discussion_r217896182","pull_request_url":"https://api.github.com/repos/fastify/fastify/pulls/1162","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/fastify/fastify/pulls/comments/217896182"},"html":{"href":"https://github.com/fastify/fastify/pull/1162#discussion_r217896182"},"pull_request":{"href":"https://api.github.com/repos/fastify/fastify/pulls/1162"}},"in_reply_to_id":217892260},"pull_request":{"url":"https://api.github.com/repos/fastify/fastify/pulls/1162","id":215772951,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1NzcyOTUx","html_url":"https://github.com/fastify/fastify/pull/1162","diff_url":"https://github.com/fastify/fastify/pull/1162.diff","patch_url":"https://github.com/fastify/fastify/pull/1162.patch","issue_url":"https://api.github.com/repos/fastify/fastify/issues/1162","number":1162,"state":"open","locked":false,"title":"Add overloads for { parseAs: \"string\" } or { parseAs: \"buffer\" }","user":{"login":"jineshshah36","id":6501089,"node_id":"MDQ6VXNlcjY1MDEwODk=","avatar_url":"https://avatars2.githubusercontent.com/u/6501089?v=4","gravatar_id":"","url":"https://api.github.com/users/jineshshah36","html_url":"https://github.com/jineshshah36","followers_url":"https://api.github.com/users/jineshshah36/followers","following_url":"https://api.github.com/users/jineshshah36/following{/other_user}","gists_url":"https://api.github.com/users/jineshshah36/gists{/gist_id}","starred_url":"https://api.github.com/users/jineshshah36/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jineshshah36/subscriptions","organizations_url":"https://api.github.com/users/jineshshah36/orgs","repos_url":"https://api.github.com/users/jineshshah36/repos","events_url":"https://api.github.com/users/jineshshah36/events{/privacy}","received_events_url":"https://api.github.com/users/jineshshah36/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nTip: `npm run bench` to compare branches interactively.\r\n\r\nContributors guide: https://github.com/fastify/fastify/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n#### Checklist\r\n\r\n- [x] run `npm run test` and `npm run benchmark`\r\n- [x] tests and/or benchmarks are included\r\n- [ ] documentation is changed or added\r\n- [x] commit message and code follows [Code of conduct](https://github.com/fastify/fastify/blob/master/CODE_OF_CONDUCT.md)\r\n\r\nall tests passed","created_at":"2018-09-15T14:54:52Z","updated_at":"2018-09-15T21:41:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"88c560299457f0f15d396f072c06fbd4e7299eaa","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/fastify/fastify/pulls/1162/commits","review_comments_url":"https://api.github.com/repos/fastify/fastify/pulls/1162/comments","review_comment_url":"https://api.github.com/repos/fastify/fastify/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fastify/fastify/issues/1162/comments","statuses_url":"https://api.github.com/repos/fastify/fastify/statuses/91fc1cdbc85e93911aa534c09256264de1157a7e","head":{"label":"jineshshah36:content-type-parser","ref":"content-type-parser","sha":"91fc1cdbc85e93911aa534c09256264de1157a7e","user":{"login":"jineshshah36","id":6501089,"node_id":"MDQ6VXNlcjY1MDEwODk=","avatar_url":"https://avatars2.githubusercontent.com/u/6501089?v=4","gravatar_id":"","url":"https://api.github.com/users/jineshshah36","html_url":"https://github.com/jineshshah36","followers_url":"https://api.github.com/users/jineshshah36/followers","following_url":"https://api.github.com/users/jineshshah36/following{/other_user}","gists_url":"https://api.github.com/users/jineshshah36/gists{/gist_id}","starred_url":"https://api.github.com/users/jineshshah36/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jineshshah36/subscriptions","organizations_url":"https://api.github.com/users/jineshshah36/orgs","repos_url":"https://api.github.com/users/jineshshah36/repos","events_url":"https://api.github.com/users/jineshshah36/events{/privacy}","received_events_url":"https://api.github.com/users/jineshshah36/received_events","type":"User","site_admin":false},"repo":{"id":148849265,"node_id":"MDEwOlJlcG9zaXRvcnkxNDg4NDkyNjU=","name":"fastify","full_name":"jineshshah36/fastify","private":false,"owner":{"login":"jineshshah36","id":6501089,"node_id":"MDQ6VXNlcjY1MDEwODk=","avatar_url":"https://avatars2.githubusercontent.com/u/6501089?v=4","gravatar_id":"","url":"https://api.github.com/users/jineshshah36","html_url":"https://github.com/jineshshah36","followers_url":"https://api.github.com/users/jineshshah36/followers","following_url":"https://api.github.com/users/jineshshah36/following{/other_user}","gists_url":"https://api.github.com/users/jineshshah36/gists{/gist_id}","starred_url":"https://api.github.com/users/jineshshah36/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jineshshah36/subscriptions","organizations_url":"https://api.github.com/users/jineshshah36/orgs","repos_url":"https://api.github.com/users/jineshshah36/repos","events_url":"https://api.github.com/users/jineshshah36/events{/privacy}","received_events_url":"https://api.github.com/users/jineshshah36/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jineshshah36/fastify","description":"Fast and low overhead web framework, for Node.js","fork":true,"url":"https://api.github.com/repos/jineshshah36/fastify","forks_url":"https://api.github.com/repos/jineshshah36/fastify/forks","keys_url":"https://api.github.com/repos/jineshshah36/fastify/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jineshshah36/fastify/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jineshshah36/fastify/teams","hooks_url":"https://api.github.com/repos/jineshshah36/fastify/hooks","issue_events_url":"https://api.github.com/repos/jineshshah36/fastify/issues/events{/number}","events_url":"https://api.github.com/repos/jineshshah36/fastify/events","assignees_url":"https://api.github.com/repos/jineshshah36/fastify/assignees{/user}","branches_url":"https://api.github.com/repos/jineshshah36/fastify/branches{/branch}","tags_url":"https://api.github.com/repos/jineshshah36/fastify/tags","blobs_url":"https://api.github.com/repos/jineshshah36/fastify/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jineshshah36/fastify/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jineshshah36/fastify/git/refs{/sha}","trees_url":"https://api.github.com/repos/jineshshah36/fastify/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jineshshah36/fastify/statuses/{sha}","languages_url":"https://api.github.com/repos/jineshshah36/fastify/languages","stargazers_url":"https://api.github.com/repos/jineshshah36/fastify/stargazers","contributors_url":"https://api.github.com/repos/jineshshah36/fastify/contributors","subscribers_url":"https://api.github.com/repos/jineshshah36/fastify/subscribers","subscription_url":"https://api.github.com/repos/jineshshah36/fastify/subscription","commits_url":"https://api.github.com/repos/jineshshah36/fastify/commits{/sha}","git_commits_url":"https://api.github.com/repos/jineshshah36/fastify/git/commits{/sha}","comments_url":"https://api.github.com/repos/jineshshah36/fastify/comments{/number}","issue_comment_url":"https://api.github.com/repos/jineshshah36/fastify/issues/comments{/number}","contents_url":"https://api.github.com/repos/jineshshah36/fastify/contents/{+path}","compare_url":"https://api.github.com/repos/jineshshah36/fastify/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jineshshah36/fastify/merges","archive_url":"https://api.github.com/repos/jineshshah36/fastify/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jineshshah36/fastify/downloads","issues_url":"https://api.github.com/repos/jineshshah36/fastify/issues{/number}","pulls_url":"https://api.github.com/repos/jineshshah36/fastify/pulls{/number}","milestones_url":"https://api.github.com/repos/jineshshah36/fastify/milestones{/number}","notifications_url":"https://api.github.com/repos/jineshshah36/fastify/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jineshshah36/fastify/labels{/name}","releases_url":"https://api.github.com/repos/jineshshah36/fastify/releases{/id}","deployments_url":"https://api.github.com/repos/jineshshah36/fastify/deployments","created_at":"2018-09-14T22:52:57Z","updated_at":"2018-09-15T15:00:23Z","pushed_at":"2018-09-15T15:00:21Z","git_url":"git://github.com/jineshshah36/fastify.git","ssh_url":"git@github.com:jineshshah36/fastify.git","clone_url":"https://github.com/jineshshah36/fastify.git","svn_url":"https://github.com/jineshshah36/fastify","homepage":"https://www.fastify.io","size":1731,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fastify:master","ref":"master","sha":"d0d2aa9fe362d6164ff9945083a80494d9b8d434","user":{"login":"fastify","id":24939410,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0OTM5NDEw","avatar_url":"https://avatars3.githubusercontent.com/u/24939410?v=4","gravatar_id":"","url":"https://api.github.com/users/fastify","html_url":"https://github.com/fastify","followers_url":"https://api.github.com/users/fastify/followers","following_url":"https://api.github.com/users/fastify/following{/other_user}","gists_url":"https://api.github.com/users/fastify/gists{/gist_id}","starred_url":"https://api.github.com/users/fastify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fastify/subscriptions","organizations_url":"https://api.github.com/users/fastify/orgs","repos_url":"https://api.github.com/users/fastify/repos","events_url":"https://api.github.com/users/fastify/events{/privacy}","received_events_url":"https://api.github.com/users/fastify/received_events","type":"Organization","site_admin":false},"repo":{"id":69495170,"node_id":"MDEwOlJlcG9zaXRvcnk2OTQ5NTE3MA==","name":"fastify","full_name":"fastify/fastify","private":false,"owner":{"login":"fastify","id":24939410,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0OTM5NDEw","avatar_url":"https://avatars3.githubusercontent.com/u/24939410?v=4","gravatar_id":"","url":"https://api.github.com/users/fastify","html_url":"https://github.com/fastify","followers_url":"https://api.github.com/users/fastify/followers","following_url":"https://api.github.com/users/fastify/following{/other_user}","gists_url":"https://api.github.com/users/fastify/gists{/gist_id}","starred_url":"https://api.github.com/users/fastify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fastify/subscriptions","organizations_url":"https://api.github.com/users/fastify/orgs","repos_url":"https://api.github.com/users/fastify/repos","events_url":"https://api.github.com/users/fastify/events{/privacy}","received_events_url":"https://api.github.com/users/fastify/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/fastify/fastify","description":"Fast and low overhead web framework, for Node.js","fork":false,"url":"https://api.github.com/repos/fastify/fastify","forks_url":"https://api.github.com/repos/fastify/fastify/forks","keys_url":"https://api.github.com/repos/fastify/fastify/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fastify/fastify/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fastify/fastify/teams","hooks_url":"https://api.github.com/repos/fastify/fastify/hooks","issue_events_url":"https://api.github.com/repos/fastify/fastify/issues/events{/number}","events_url":"https://api.github.com/repos/fastify/fastify/events","assignees_url":"https://api.github.com/repos/fastify/fastify/assignees{/user}","branches_url":"https://api.github.com/repos/fastify/fastify/branches{/branch}","tags_url":"https://api.github.com/repos/fastify/fastify/tags","blobs_url":"https://api.github.com/repos/fastify/fastify/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fastify/fastify/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fastify/fastify/git/refs{/sha}","trees_url":"https://api.github.com/repos/fastify/fastify/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fastify/fastify/statuses/{sha}","languages_url":"https://api.github.com/repos/fastify/fastify/languages","stargazers_url":"https://api.github.com/repos/fastify/fastify/stargazers","contributors_url":"https://api.github.com/repos/fastify/fastify/contributors","subscribers_url":"https://api.github.com/repos/fastify/fastify/subscribers","subscription_url":"https://api.github.com/repos/fastify/fastify/subscription","commits_url":"https://api.github.com/repos/fastify/fastify/commits{/sha}","git_commits_url":"https://api.github.com/repos/fastify/fastify/git/commits{/sha}","comments_url":"https://api.github.com/repos/fastify/fastify/comments{/number}","issue_comment_url":"https://api.github.com/repos/fastify/fastify/issues/comments{/number}","contents_url":"https://api.github.com/repos/fastify/fastify/contents/{+path}","compare_url":"https://api.github.com/repos/fastify/fastify/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fastify/fastify/merges","archive_url":"https://api.github.com/repos/fastify/fastify/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fastify/fastify/downloads","issues_url":"https://api.github.com/repos/fastify/fastify/issues{/number}","pulls_url":"https://api.github.com/repos/fastify/fastify/pulls{/number}","milestones_url":"https://api.github.com/repos/fastify/fastify/milestones{/number}","notifications_url":"https://api.github.com/repos/fastify/fastify/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fastify/fastify/labels{/name}","releases_url":"https://api.github.com/repos/fastify/fastify/releases{/id}","deployments_url":"https://api.github.com/repos/fastify/fastify/deployments","created_at":"2016-09-28T19:10:14Z","updated_at":"2018-09-15T20:49:25Z","pushed_at":"2018-09-15T15:00:23Z","git_url":"git://github.com/fastify/fastify.git","ssh_url":"git@github.com:fastify/fastify.git","clone_url":"https://github.com/fastify/fastify.git","svn_url":"https://github.com/fastify/fastify","homepage":"https://www.fastify.io","size":1728,"stargazers_count":8081,"watchers_count":8081,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":437,"mirror_url":null,"archived":false,"open_issues_count":36,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":437,"open_issues":36,"watchers":8081,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fastify/fastify/pulls/1162"},"html":{"href":"https://github.com/fastify/fastify/pull/1162"},"issue":{"href":"https://api.github.com/repos/fastify/fastify/issues/1162"},"comments":{"href":"https://api.github.com/repos/fastify/fastify/issues/1162/comments"},"review_comments":{"href":"https://api.github.com/repos/fastify/fastify/pulls/1162/comments"},"review_comment":{"href":"https://api.github.com/repos/fastify/fastify/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fastify/fastify/pulls/1162/commits"},"statuses":{"href":"https://api.github.com/repos/fastify/fastify/statuses/91fc1cdbc85e93911aa534c09256264de1157a7e"}},"author_association":"NONE"}}
{"actor":{"display_login":"jineshshah36"}}