{"action":"created","comment":{"url":"https://api.github.com/repos/xivanalysis/xivanalysis/pulls/comments/206832404","pull_request_review_id":142319142,"id":206832404,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNjgzMjQwNA==","diff_hunk":"@@ -0,0 +1,136 @@\n+import React, {Fragment} from 'react'\n+\n+import {ActionLink} from 'components/ui/DbLink'\n+import ACTIONS from 'data/ACTIONS'\n+import STATUSES from 'data/STATUSES'\n+import Module from 'parser/core/Module'\n+import {Rule, Requirement} from '../../core/modules/Checklist'\n+import {Suggestion, SEVERITY} from 'parser/core/modules/Suggestions'\n+\n+const JINPU_DURATION = 30000\n+const SHIFU_DURATION = 30000\n+\n+const BUFF_BUFFER = 10000\n+\n+export default class Buffs extends Module {\n+\tstatic handle = 'buffs'\n+\tstatic dependencies = [\n+\t\t'checklist',\n+\t\t'combatants',\n+\t\t'invuln',\n+\t\t'suggestions',\n+\t]\n+\n+\t_JinpuUses = []\n+\t_ShifuUses = []\n+\n+\t_earlyJinpuApplications = 0\n+\t_earlyShifyApplications = 0\n+\n+\tconstructor(...args) {\n+\t\tsuper(...args)\n+\n+\t\tconst filter = {\n+\t\t\tby: 'player',\n+\t\t\tabilityId: [STATUSES.JINPU.id, STATUSES.SHIFU.id],\n+\t\t}\n+\t\tthis.addHook('applybuff', filter, this._onShifuApplication, this._onJinpuApplication)\n+\t\tthis.addHook('refreshbuff', filter, this._onShifuApplication, this._onJinpuApplication)","path":"src/parser/jobs/sam/Buffs.js","position":38,"original_position":38,"commit_id":"0ed04012d187704d68370a651113b0b4317df6ad","original_commit_id":"0ed04012d187704d68370a651113b0b4317df6ad","user":{"login":"ackwell","id":534235,"node_id":"MDQ6VXNlcjUzNDIzNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/534235?v=4","gravatar_id":"","url":"https://api.github.com/users/ackwell","html_url":"https://github.com/ackwell","followers_url":"https://api.github.com/users/ackwell/followers","following_url":"https://api.github.com/users/ackwell/following{/other_user}","gists_url":"https://api.github.com/users/ackwell/gists{/gist_id}","starred_url":"https://api.github.com/users/ackwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ackwell/subscriptions","organizations_url":"https://api.github.com/users/ackwell/orgs","repos_url":"https://api.github.com/users/ackwell/repos","events_url":"https://api.github.com/users/ackwell/events{/privacy}","received_events_url":"https://api.github.com/users/ackwell/received_events","type":"User","site_admin":false},"body":"Yeah the sig is\r\n\r\n```js\r\naddHook(events[, filter], cb)\r\n```\r\n\r\nI'm hesitant to allow multiple callbacks per event. The snipping we're commenting on could theoretically be written as\r\n\r\n```js\r\nthis.addHook(['applybuff', 'refreshbuff'], filter, event => {\r\n\tthis._onShifuApplication(event)\r\n\tthis._onJinpuApplication(event)\r\n})\r\n```\r\n\r\nYou could take it a step further and combine the two callbacks, too - they're doing the same thing.","created_at":"2018-08-01T10:40:40Z","updated_at":"2018-08-01T10:40:40Z","html_url":"https://github.com/xivanalysis/xivanalysis/pull/111#discussion_r206832404","pull_request_url":"https://api.github.com/repos/xivanalysis/xivanalysis/pulls/111","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/xivanalysis/xivanalysis/pulls/comments/206832404"},"html":{"href":"https://github.com/xivanalysis/xivanalysis/pull/111#discussion_r206832404"},"pull_request":{"href":"https://api.github.com/repos/xivanalysis/xivanalysis/pulls/111"}},"in_reply_to_id":206790001},"pull_request":{"url":"https://api.github.com/repos/xivanalysis/xivanalysis/pulls/111","id":205308170,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1MzA4MTcw","html_url":"https://github.com/xivanalysis/xivanalysis/pull/111","diff_url":"https://github.com/xivanalysis/xivanalysis/pull/111.diff","patch_url":"https://github.com/xivanalysis/xivanalysis/pull/111.patch","issue_url":"https://api.github.com/repos/xivanalysis/xivanalysis/issues/111","number":111,"state":"open","locked":false,"title":"Jinpu/Shifu Uptime + bug fixes","user":{"login":"Rjb99","id":37195907,"node_id":"MDQ6VXNlcjM3MTk1OTA3","avatar_url":"https://avatars1.githubusercontent.com/u/37195907?v=4","gravatar_id":"","url":"https://api.github.com/users/Rjb99","html_url":"https://github.com/Rjb99","followers_url":"https://api.github.com/users/Rjb99/followers","following_url":"https://api.github.com/users/Rjb99/following{/other_user}","gists_url":"https://api.github.com/users/Rjb99/gists{/gist_id}","starred_url":"https://api.github.com/users/Rjb99/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rjb99/subscriptions","organizations_url":"https://api.github.com/users/Rjb99/orgs","repos_url":"https://api.github.com/users/Rjb99/repos","events_url":"https://api.github.com/users/Rjb99/events{/privacy}","received_events_url":"https://api.github.com/users/Rjb99/received_events","type":"User","site_admin":false},"body":"-Added Jinpu/Shifu uptime \r\n-Target uptime is set at 95% based on feedback from Boxer, will be fine tuning this number in the coming days\r\n(invuln does make them quite abit borked)\r\n\r\n-Updated About.js to be more about sam then copypasta. \r\n\r\n(has a please note about sen/kenki gen, but that's disabled so it's actually meaningless. :blobsweat:)\r\n\r\n-Fixed a bug that made Higanbana be a minor issue at 0.00 seconds clipping.\r\n\r\nI've got Gauge.js in this PR because I'm stupid. but it's currently disabled so it won't work anyway.\r\n\r\n(because I'm apparently very bad at kenki management)","created_at":"2018-08-01T04:49:22Z","updated_at":"2018-08-01T10:40:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ea6dc5bab36627876266bc960df62b4eecc8d76b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/xivanalysis/xivanalysis/pulls/111/commits","review_comments_url":"https://api.github.com/repos/xivanalysis/xivanalysis/pulls/111/comments","review_comment_url":"https://api.github.com/repos/xivanalysis/xivanalysis/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xivanalysis/xivanalysis/issues/111/comments","statuses_url":"https://api.github.com/repos/xivanalysis/xivanalysis/statuses/0ed04012d187704d68370a651113b0b4317df6ad","head":{"label":"Rjb99:master","ref":"master","sha":"0ed04012d187704d68370a651113b0b4317df6ad","user":{"login":"Rjb99","id":37195907,"node_id":"MDQ6VXNlcjM3MTk1OTA3","avatar_url":"https://avatars1.githubusercontent.com/u/37195907?v=4","gravatar_id":"","url":"https://api.github.com/users/Rjb99","html_url":"https://github.com/Rjb99","followers_url":"https://api.github.com/users/Rjb99/followers","following_url":"https://api.github.com/users/Rjb99/following{/other_user}","gists_url":"https://api.github.com/users/Rjb99/gists{/gist_id}","starred_url":"https://api.github.com/users/Rjb99/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rjb99/subscriptions","organizations_url":"https://api.github.com/users/Rjb99/orgs","repos_url":"https://api.github.com/users/Rjb99/repos","events_url":"https://api.github.com/users/Rjb99/events{/privacy}","received_events_url":"https://api.github.com/users/Rjb99/received_events","type":"User","site_admin":false},"repo":{"id":141950262,"node_id":"MDEwOlJlcG9zaXRvcnkxNDE5NTAyNjI=","name":"xivanalysis","full_name":"Rjb99/xivanalysis","owner":{"login":"Rjb99","id":37195907,"node_id":"MDQ6VXNlcjM3MTk1OTA3","avatar_url":"https://avatars1.githubusercontent.com/u/37195907?v=4","gravatar_id":"","url":"https://api.github.com/users/Rjb99","html_url":"https://github.com/Rjb99","followers_url":"https://api.github.com/users/Rjb99/followers","following_url":"https://api.github.com/users/Rjb99/following{/other_user}","gists_url":"https://api.github.com/users/Rjb99/gists{/gist_id}","starred_url":"https://api.github.com/users/Rjb99/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rjb99/subscriptions","organizations_url":"https://api.github.com/users/Rjb99/orgs","repos_url":"https://api.github.com/users/Rjb99/repos","events_url":"https://api.github.com/users/Rjb99/events{/privacy}","received_events_url":"https://api.github.com/users/Rjb99/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Rjb99/xivanalysis","description":"Automated performance analysis and suggestion platform for Final Fantasy XIV: Stormblood.","fork":true,"url":"https://api.github.com/repos/Rjb99/xivanalysis","forks_url":"https://api.github.com/repos/Rjb99/xivanalysis/forks","keys_url":"https://api.github.com/repos/Rjb99/xivanalysis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Rjb99/xivanalysis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Rjb99/xivanalysis/teams","hooks_url":"https://api.github.com/repos/Rjb99/xivanalysis/hooks","issue_events_url":"https://api.github.com/repos/Rjb99/xivanalysis/issues/events{/number}","events_url":"https://api.github.com/repos/Rjb99/xivanalysis/events","assignees_url":"https://api.github.com/repos/Rjb99/xivanalysis/assignees{/user}","branches_url":"https://api.github.com/repos/Rjb99/xivanalysis/branches{/branch}","tags_url":"https://api.github.com/repos/Rjb99/xivanalysis/tags","blobs_url":"https://api.github.com/repos/Rjb99/xivanalysis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Rjb99/xivanalysis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Rjb99/xivanalysis/git/refs{/sha}","trees_url":"https://api.github.com/repos/Rjb99/xivanalysis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Rjb99/xivanalysis/statuses/{sha}","languages_url":"https://api.github.com/repos/Rjb99/xivanalysis/languages","stargazers_url":"https://api.github.com/repos/Rjb99/xivanalysis/stargazers","contributors_url":"https://api.github.com/repos/Rjb99/xivanalysis/contributors","subscribers_url":"https://api.github.com/repos/Rjb99/xivanalysis/subscribers","subscription_url":"https://api.github.com/repos/Rjb99/xivanalysis/subscription","commits_url":"https://api.github.com/repos/Rjb99/xivanalysis/commits{/sha}","git_commits_url":"https://api.github.com/repos/Rjb99/xivanalysis/git/commits{/sha}","comments_url":"https://api.github.com/repos/Rjb99/xivanalysis/comments{/number}","issue_comment_url":"https://api.github.com/repos/Rjb99/xivanalysis/issues/comments{/number}","contents_url":"https://api.github.com/repos/Rjb99/xivanalysis/contents/{+path}","compare_url":"https://api.github.com/repos/Rjb99/xivanalysis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Rjb99/xivanalysis/merges","archive_url":"https://api.github.com/repos/Rjb99/xivanalysis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Rjb99/xivanalysis/downloads","issues_url":"https://api.github.com/repos/Rjb99/xivanalysis/issues{/number}","pulls_url":"https://api.github.com/repos/Rjb99/xivanalysis/pulls{/number}","milestones_url":"https://api.github.com/repos/Rjb99/xivanalysis/milestones{/number}","notifications_url":"https://api.github.com/repos/Rjb99/xivanalysis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Rjb99/xivanalysis/labels{/name}","releases_url":"https://api.github.com/repos/Rjb99/xivanalysis/releases{/id}","deployments_url":"https://api.github.com/repos/Rjb99/xivanalysis/deployments","created_at":"2018-07-23T02:19:07Z","updated_at":"2018-08-01T04:36:18Z","pushed_at":"2018-08-01T04:36:16Z","git_url":"git://github.com/Rjb99/xivanalysis.git","ssh_url":"git@github.com:Rjb99/xivanalysis.git","clone_url":"https://github.com/Rjb99/xivanalysis.git","svn_url":"https://github.com/Rjb99/xivanalysis","homepage":"https://xivanalysis.com","size":2570,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xivanalysis:master","ref":"master","sha":"9c7db05e49d2adc2542837e02b3ac8dea56ae9c0","user":{"login":"xivanalysis","id":39235942,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MjM1OTQy","avatar_url":"https://avatars0.githubusercontent.com/u/39235942?v=4","gravatar_id":"","url":"https://api.github.com/users/xivanalysis","html_url":"https://github.com/xivanalysis","followers_url":"https://api.github.com/users/xivanalysis/followers","following_url":"https://api.github.com/users/xivanalysis/following{/other_user}","gists_url":"https://api.github.com/users/xivanalysis/gists{/gist_id}","starred_url":"https://api.github.com/users/xivanalysis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xivanalysis/subscriptions","organizations_url":"https://api.github.com/users/xivanalysis/orgs","repos_url":"https://api.github.com/users/xivanalysis/repos","events_url":"https://api.github.com/users/xivanalysis/events{/privacy}","received_events_url":"https://api.github.com/users/xivanalysis/received_events","type":"Organization","site_admin":false},"repo":{"id":132010919,"node_id":"MDEwOlJlcG9zaXRvcnkxMzIwMTA5MTk=","name":"xivanalysis","full_name":"xivanalysis/xivanalysis","owner":{"login":"xivanalysis","id":39235942,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MjM1OTQy","avatar_url":"https://avatars0.githubusercontent.com/u/39235942?v=4","gravatar_id":"","url":"https://api.github.com/users/xivanalysis","html_url":"https://github.com/xivanalysis","followers_url":"https://api.github.com/users/xivanalysis/followers","following_url":"https://api.github.com/users/xivanalysis/following{/other_user}","gists_url":"https://api.github.com/users/xivanalysis/gists{/gist_id}","starred_url":"https://api.github.com/users/xivanalysis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xivanalysis/subscriptions","organizations_url":"https://api.github.com/users/xivanalysis/orgs","repos_url":"https://api.github.com/users/xivanalysis/repos","events_url":"https://api.github.com/users/xivanalysis/events{/privacy}","received_events_url":"https://api.github.com/users/xivanalysis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xivanalysis/xivanalysis","description":"Automated performance analysis and suggestion platform for Final Fantasy XIV: Stormblood.","fork":false,"url":"https://api.github.com/repos/xivanalysis/xivanalysis","forks_url":"https://api.github.com/repos/xivanalysis/xivanalysis/forks","keys_url":"https://api.github.com/repos/xivanalysis/xivanalysis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xivanalysis/xivanalysis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xivanalysis/xivanalysis/teams","hooks_url":"https://api.github.com/repos/xivanalysis/xivanalysis/hooks","issue_events_url":"https://api.github.com/repos/xivanalysis/xivanalysis/issues/events{/number}","events_url":"https://api.github.com/repos/xivanalysis/xivanalysis/events","assignees_url":"https://api.github.com/repos/xivanalysis/xivanalysis/assignees{/user}","branches_url":"https://api.github.com/repos/xivanalysis/xivanalysis/branches{/branch}","tags_url":"https://api.github.com/repos/xivanalysis/xivanalysis/tags","blobs_url":"https://api.github.com/repos/xivanalysis/xivanalysis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xivanalysis/xivanalysis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xivanalysis/xivanalysis/git/refs{/sha}","trees_url":"https://api.github.com/repos/xivanalysis/xivanalysis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xivanalysis/xivanalysis/statuses/{sha}","languages_url":"https://api.github.com/repos/xivanalysis/xivanalysis/languages","stargazers_url":"https://api.github.com/repos/xivanalysis/xivanalysis/stargazers","contributors_url":"https://api.github.com/repos/xivanalysis/xivanalysis/contributors","subscribers_url":"https://api.github.com/repos/xivanalysis/xivanalysis/subscribers","subscription_url":"https://api.github.com/repos/xivanalysis/xivanalysis/subscription","commits_url":"https://api.github.com/repos/xivanalysis/xivanalysis/commits{/sha}","git_commits_url":"https://api.github.com/repos/xivanalysis/xivanalysis/git/commits{/sha}","comments_url":"https://api.github.com/repos/xivanalysis/xivanalysis/comments{/number}","issue_comment_url":"https://api.github.com/repos/xivanalysis/xivanalysis/issues/comments{/number}","contents_url":"https://api.github.com/repos/xivanalysis/xivanalysis/contents/{+path}","compare_url":"https://api.github.com/repos/xivanalysis/xivanalysis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xivanalysis/xivanalysis/merges","archive_url":"https://api.github.com/repos/xivanalysis/xivanalysis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xivanalysis/xivanalysis/downloads","issues_url":"https://api.github.com/repos/xivanalysis/xivanalysis/issues{/number}","pulls_url":"https://api.github.com/repos/xivanalysis/xivanalysis/pulls{/number}","milestones_url":"https://api.github.com/repos/xivanalysis/xivanalysis/milestones{/number}","notifications_url":"https://api.github.com/repos/xivanalysis/xivanalysis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xivanalysis/xivanalysis/labels{/name}","releases_url":"https://api.github.com/repos/xivanalysis/xivanalysis/releases{/id}","deployments_url":"https://api.github.com/repos/xivanalysis/xivanalysis/deployments","created_at":"2018-05-03T14:56:32Z","updated_at":"2018-08-01T10:28:06Z","pushed_at":"2018-08-01T10:28:04Z","git_url":"git://github.com/xivanalysis/xivanalysis.git","ssh_url":"git@github.com:xivanalysis/xivanalysis.git","clone_url":"https://github.com/xivanalysis/xivanalysis.git","svn_url":"https://github.com/xivanalysis/xivanalysis","homepage":"https://xivanalysis.com","size":2568,"stargazers_count":21,"watchers_count":21,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"archived":false,"open_issues_count":20,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":33,"open_issues":20,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xivanalysis/xivanalysis/pulls/111"},"html":{"href":"https://github.com/xivanalysis/xivanalysis/pull/111"},"issue":{"href":"https://api.github.com/repos/xivanalysis/xivanalysis/issues/111"},"comments":{"href":"https://api.github.com/repos/xivanalysis/xivanalysis/issues/111/comments"},"review_comments":{"href":"https://api.github.com/repos/xivanalysis/xivanalysis/pulls/111/comments"},"review_comment":{"href":"https://api.github.com/repos/xivanalysis/xivanalysis/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xivanalysis/xivanalysis/pulls/111/commits"},"statuses":{"href":"https://api.github.com/repos/xivanalysis/xivanalysis/statuses/0ed04012d187704d68370a651113b0b4317df6ad"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ackwell"}}