{"action":"closed","number":6046,"pull_request":{"url":"https://api.github.com/repos/mautic/mautic/pulls/6046","id":186009426,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg2MDA5NDI2","html_url":"https://github.com/mautic/mautic/pull/6046","diff_url":"https://github.com/mautic/mautic/pull/6046.diff","patch_url":"https://github.com/mautic/mautic/pull/6046.patch","issue_url":"https://api.github.com/repos/mautic/mautic/issues/6046","number":6046,"state":"closed","locked":false,"title":"Broken links in tracking results","user":{"login":"shershennm","id":1130311,"node_id":"MDQ6VXNlcjExMzAzMTE=","avatar_url":"https://avatars0.githubusercontent.com/u/1130311?v=4","gravatar_id":"","url":"https://api.github.com/users/shershennm","html_url":"https://github.com/shershennm","followers_url":"https://api.github.com/users/shershennm/followers","following_url":"https://api.github.com/users/shershennm/following{/other_user}","gists_url":"https://api.github.com/users/shershennm/gists{/gist_id}","starred_url":"https://api.github.com/users/shershennm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shershennm/subscriptions","organizations_url":"https://api.github.com/users/shershennm/orgs","repos_url":"https://api.github.com/users/shershennm/repos","events_url":"https://api.github.com/users/shershennm/events{/privacy}","received_events_url":"https://api.github.com/users/shershennm/received_events","type":"User","site_admin":false},"body":"**Please be sure you are submitting this against the _staging_ branch.**\r\n\r\n[//]: # ( Please answer the following questions: )\r\n\r\n| Q  | A\r\n| --- | ---\r\n| Bug fix? | x\r\n| New feature? | \r\n| Automated tests included? |\r\n| Related user documentation PR URL | \r\n| Related developer documentation PR URL | \r\n| Issues addressed (#s or URLs) | #3599\r\n| BC breaks? | x\r\n| Deprecations? | \r\n\r\n[//]: # ( Note that all new features should have a related user and/or developer documentation PR in their respective repositories. )\r\n\r\n[//]: # ( Required: )\r\n#### Description:\r\n\r\n[//]: # ( As applicable: )\r\n#### Steps to reproduce the bug:\r\n1. Go to page with ampersands in url\r\n2. Url will be stored as test.com/test?first_name=John&#38;last_name=Smith&#38;utm_campaign=test\r\n\r\n#### Steps to test this PR:\r\n1. Go to page with ampersands in url\r\n2. Url must be stored without it breaking and clean from xss injections\r\n\r\n# BC Breaks\r\nSolved by https://github.com/mautic/mautic/pull/6712","created_at":"2018-05-04T15:00:14Z","updated_at":"2018-10-11T14:55:54Z","closed_at":"2018-10-11T14:55:54Z","merged_at":"2018-10-11T14:55:54Z","merge_commit_sha":"15721e81b17afed660c322c359bec6bda4818ee2","assignee":{"login":"escopecz","id":1235442,"node_id":"MDQ6VXNlcjEyMzU0NDI=","avatar_url":"https://avatars2.githubusercontent.com/u/1235442?v=4","gravatar_id":"","url":"https://api.github.com/users/escopecz","html_url":"https://github.com/escopecz","followers_url":"https://api.github.com/users/escopecz/followers","following_url":"https://api.github.com/users/escopecz/following{/other_user}","gists_url":"https://api.github.com/users/escopecz/gists{/gist_id}","starred_url":"https://api.github.com/users/escopecz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/escopecz/subscriptions","organizations_url":"https://api.github.com/users/escopecz/orgs","repos_url":"https://api.github.com/users/escopecz/repos","events_url":"https://api.github.com/users/escopecz/events{/privacy}","received_events_url":"https://api.github.com/users/escopecz/received_events","type":"User","site_admin":false},"assignees":[{"login":"escopecz","id":1235442,"node_id":"MDQ6VXNlcjEyMzU0NDI=","avatar_url":"https://avatars2.githubusercontent.com/u/1235442?v=4","gravatar_id":"","url":"https://api.github.com/users/escopecz","html_url":"https://github.com/escopecz","followers_url":"https://api.github.com/users/escopecz/followers","following_url":"https://api.github.com/users/escopecz/following{/other_user}","gists_url":"https://api.github.com/users/escopecz/gists{/gist_id}","starred_url":"https://api.github.com/users/escopecz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/escopecz/subscriptions","organizations_url":"https://api.github.com/users/escopecz/orgs","repos_url":"https://api.github.com/users/escopecz/repos","events_url":"https://api.github.com/users/escopecz/events{/privacy}","received_events_url":"https://api.github.com/users/escopecz/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":908369027,"node_id":"MDU6TGFiZWw5MDgzNjkwMjc=","url":"https://api.github.com/repos/mautic/mautic/labels/BC%20Break","name":"BC Break","color":"ededed","default":false},{"id":154414515,"node_id":"MDU6TGFiZWwxNTQ0MTQ1MTU=","url":"https://api.github.com/repos/mautic/mautic/labels/Bug","name":"Bug","color":"e11d21","default":false},{"id":185161473,"node_id":"MDU6TGFiZWwxODUxNjE0NzM=","url":"https://api.github.com/repos/mautic/mautic/labels/Ready%20To%20Commit","name":"Ready To Commit","color":"60b044","default":false}],"milestone":{"url":"https://api.github.com/repos/mautic/mautic/milestones/48","html_url":"https://github.com/mautic/mautic/milestone/48","labels_url":"https://api.github.com/repos/mautic/mautic/milestones/48/labels","id":3624611,"node_id":"MDk6TWlsZXN0b25lMzYyNDYxMQ==","number":48,"title":"2.14.2","description":"Beta release is planed on Oct 16.","creator":{"login":"npracht","id":14075239,"node_id":"MDQ6VXNlcjE0MDc1MjM5","avatar_url":"https://avatars2.githubusercontent.com/u/14075239?v=4","gravatar_id":"","url":"https://api.github.com/users/npracht","html_url":"https://github.com/npracht","followers_url":"https://api.github.com/users/npracht/followers","following_url":"https://api.github.com/users/npracht/following{/other_user}","gists_url":"https://api.github.com/users/npracht/gists{/gist_id}","starred_url":"https://api.github.com/users/npracht/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/npracht/subscriptions","organizations_url":"https://api.github.com/users/npracht/orgs","repos_url":"https://api.github.com/users/npracht/repos","events_url":"https://api.github.com/users/npracht/events{/privacy}","received_events_url":"https://api.github.com/users/npracht/received_events","type":"User","site_admin":false},"open_issues":51,"closed_issues":58,"state":"open","created_at":"2018-09-05T13:39:45Z","updated_at":"2018-10-11T14:55:54Z","due_on":"2018-10-23T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/mautic/mautic/pulls/6046/commits","review_comments_url":"https://api.github.com/repos/mautic/mautic/pulls/6046/comments","review_comment_url":"https://api.github.com/repos/mautic/mautic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mautic/mautic/issues/6046/comments","statuses_url":"https://api.github.com/repos/mautic/mautic/statuses/0239f63bc4ee72a0b2f66dfdc9c7255e5e9ec61e","head":{"label":"shershennm:bug-page-hit-url","ref":"bug-page-hit-url","sha":"0239f63bc4ee72a0b2f66dfdc9c7255e5e9ec61e","user":{"login":"shershennm","id":1130311,"node_id":"MDQ6VXNlcjExMzAzMTE=","avatar_url":"https://avatars0.githubusercontent.com/u/1130311?v=4","gravatar_id":"","url":"https://api.github.com/users/shershennm","html_url":"https://github.com/shershennm","followers_url":"https://api.github.com/users/shershennm/followers","following_url":"https://api.github.com/users/shershennm/following{/other_user}","gists_url":"https://api.github.com/users/shershennm/gists{/gist_id}","starred_url":"https://api.github.com/users/shershennm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shershennm/subscriptions","organizations_url":"https://api.github.com/users/shershennm/orgs","repos_url":"https://api.github.com/users/shershennm/repos","events_url":"https://api.github.com/users/shershennm/events{/privacy}","received_events_url":"https://api.github.com/users/shershennm/received_events","type":"User","site_admin":false},"repo":{"id":131966179,"node_id":"MDEwOlJlcG9zaXRvcnkxMzE5NjYxNzk=","name":"mautic","full_name":"shershennm/mautic","private":false,"owner":{"login":"shershennm","id":1130311,"node_id":"MDQ6VXNlcjExMzAzMTE=","avatar_url":"https://avatars0.githubusercontent.com/u/1130311?v=4","gravatar_id":"","url":"https://api.github.com/users/shershennm","html_url":"https://github.com/shershennm","followers_url":"https://api.github.com/users/shershennm/followers","following_url":"https://api.github.com/users/shershennm/following{/other_user}","gists_url":"https://api.github.com/users/shershennm/gists{/gist_id}","starred_url":"https://api.github.com/users/shershennm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shershennm/subscriptions","organizations_url":"https://api.github.com/users/shershennm/orgs","repos_url":"https://api.github.com/users/shershennm/repos","events_url":"https://api.github.com/users/shershennm/events{/privacy}","received_events_url":"https://api.github.com/users/shershennm/received_events","type":"User","site_admin":false},"html_url":"https://github.com/shershennm/mautic","description":"Mautic: Open Source Marketing Automation Software.","fork":true,"url":"https://api.github.com/repos/shershennm/mautic","forks_url":"https://api.github.com/repos/shershennm/mautic/forks","keys_url":"https://api.github.com/repos/shershennm/mautic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shershennm/mautic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shershennm/mautic/teams","hooks_url":"https://api.github.com/repos/shershennm/mautic/hooks","issue_events_url":"https://api.github.com/repos/shershennm/mautic/issues/events{/number}","events_url":"https://api.github.com/repos/shershennm/mautic/events","assignees_url":"https://api.github.com/repos/shershennm/mautic/assignees{/user}","branches_url":"https://api.github.com/repos/shershennm/mautic/branches{/branch}","tags_url":"https://api.github.com/repos/shershennm/mautic/tags","blobs_url":"https://api.github.com/repos/shershennm/mautic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shershennm/mautic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shershennm/mautic/git/refs{/sha}","trees_url":"https://api.github.com/repos/shershennm/mautic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shershennm/mautic/statuses/{sha}","languages_url":"https://api.github.com/repos/shershennm/mautic/languages","stargazers_url":"https://api.github.com/repos/shershennm/mautic/stargazers","contributors_url":"https://api.github.com/repos/shershennm/mautic/contributors","subscribers_url":"https://api.github.com/repos/shershennm/mautic/subscribers","subscription_url":"https://api.github.com/repos/shershennm/mautic/subscription","commits_url":"https://api.github.com/repos/shershennm/mautic/commits{/sha}","git_commits_url":"https://api.github.com/repos/shershennm/mautic/git/commits{/sha}","comments_url":"https://api.github.com/repos/shershennm/mautic/comments{/number}","issue_comment_url":"https://api.github.com/repos/shershennm/mautic/issues/comments{/number}","contents_url":"https://api.github.com/repos/shershennm/mautic/contents/{+path}","compare_url":"https://api.github.com/repos/shershennm/mautic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shershennm/mautic/merges","archive_url":"https://api.github.com/repos/shershennm/mautic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shershennm/mautic/downloads","issues_url":"https://api.github.com/repos/shershennm/mautic/issues{/number}","pulls_url":"https://api.github.com/repos/shershennm/mautic/pulls{/number}","milestones_url":"https://api.github.com/repos/shershennm/mautic/milestones{/number}","notifications_url":"https://api.github.com/repos/shershennm/mautic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shershennm/mautic/labels{/name}","releases_url":"https://api.github.com/repos/shershennm/mautic/releases{/id}","deployments_url":"https://api.github.com/repos/shershennm/mautic/deployments","created_at":"2018-05-03T08:38:45Z","updated_at":"2018-05-17T14:36:58Z","pushed_at":"2018-05-17T14:36:50Z","git_url":"git://github.com/shershennm/mautic.git","ssh_url":"git@github.com:shershennm/mautic.git","clone_url":"https://github.com/shershennm/mautic.git","svn_url":"https://github.com/shershennm/mautic","homepage":"https://www.mautic.org","size":80221,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"staging"}},"base":{"label":"mautic:staging","ref":"staging","sha":"e6eababe0e32b5f7ca003b465b28dc196975fb76","user":{"login":"mautic","id":5257677,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyNTc2Nzc=","avatar_url":"https://avatars0.githubusercontent.com/u/5257677?v=4","gravatar_id":"","url":"https://api.github.com/users/mautic","html_url":"https://github.com/mautic","followers_url":"https://api.github.com/users/mautic/followers","following_url":"https://api.github.com/users/mautic/following{/other_user}","gists_url":"https://api.github.com/users/mautic/gists{/gist_id}","starred_url":"https://api.github.com/users/mautic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mautic/subscriptions","organizations_url":"https://api.github.com/users/mautic/orgs","repos_url":"https://api.github.com/users/mautic/repos","events_url":"https://api.github.com/users/mautic/events{/privacy}","received_events_url":"https://api.github.com/users/mautic/received_events","type":"Organization","site_admin":false},"repo":{"id":12204147,"node_id":"MDEwOlJlcG9zaXRvcnkxMjIwNDE0Nw==","name":"mautic","full_name":"mautic/mautic","private":false,"owner":{"login":"mautic","id":5257677,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUyNTc2Nzc=","avatar_url":"https://avatars0.githubusercontent.com/u/5257677?v=4","gravatar_id":"","url":"https://api.github.com/users/mautic","html_url":"https://github.com/mautic","followers_url":"https://api.github.com/users/mautic/followers","following_url":"https://api.github.com/users/mautic/following{/other_user}","gists_url":"https://api.github.com/users/mautic/gists{/gist_id}","starred_url":"https://api.github.com/users/mautic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mautic/subscriptions","organizations_url":"https://api.github.com/users/mautic/orgs","repos_url":"https://api.github.com/users/mautic/repos","events_url":"https://api.github.com/users/mautic/events{/privacy}","received_events_url":"https://api.github.com/users/mautic/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mautic/mautic","description":"Mautic: Open Source Marketing Automation Software.","fork":false,"url":"https://api.github.com/repos/mautic/mautic","forks_url":"https://api.github.com/repos/mautic/mautic/forks","keys_url":"https://api.github.com/repos/mautic/mautic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mautic/mautic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mautic/mautic/teams","hooks_url":"https://api.github.com/repos/mautic/mautic/hooks","issue_events_url":"https://api.github.com/repos/mautic/mautic/issues/events{/number}","events_url":"https://api.github.com/repos/mautic/mautic/events","assignees_url":"https://api.github.com/repos/mautic/mautic/assignees{/user}","branches_url":"https://api.github.com/repos/mautic/mautic/branches{/branch}","tags_url":"https://api.github.com/repos/mautic/mautic/tags","blobs_url":"https://api.github.com/repos/mautic/mautic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mautic/mautic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mautic/mautic/git/refs{/sha}","trees_url":"https://api.github.com/repos/mautic/mautic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mautic/mautic/statuses/{sha}","languages_url":"https://api.github.com/repos/mautic/mautic/languages","stargazers_url":"https://api.github.com/repos/mautic/mautic/stargazers","contributors_url":"https://api.github.com/repos/mautic/mautic/contributors","subscribers_url":"https://api.github.com/repos/mautic/mautic/subscribers","subscription_url":"https://api.github.com/repos/mautic/mautic/subscription","commits_url":"https://api.github.com/repos/mautic/mautic/commits{/sha}","git_commits_url":"https://api.github.com/repos/mautic/mautic/git/commits{/sha}","comments_url":"https://api.github.com/repos/mautic/mautic/comments{/number}","issue_comment_url":"https://api.github.com/repos/mautic/mautic/issues/comments{/number}","contents_url":"https://api.github.com/repos/mautic/mautic/contents/{+path}","compare_url":"https://api.github.com/repos/mautic/mautic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mautic/mautic/merges","archive_url":"https://api.github.com/repos/mautic/mautic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mautic/mautic/downloads","issues_url":"https://api.github.com/repos/mautic/mautic/issues{/number}","pulls_url":"https://api.github.com/repos/mautic/mautic/pulls{/number}","milestones_url":"https://api.github.com/repos/mautic/mautic/milestones{/number}","notifications_url":"https://api.github.com/repos/mautic/mautic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mautic/mautic/labels{/name}","releases_url":"https://api.github.com/repos/mautic/mautic/releases{/id}","deployments_url":"https://api.github.com/repos/mautic/mautic/deployments","created_at":"2013-08-19T00:36:28Z","updated_at":"2018-10-11T08:41:35Z","pushed_at":"2018-10-11T14:55:54Z","git_url":"git://github.com/mautic/mautic.git","ssh_url":"git@github.com:mautic/mautic.git","clone_url":"https://github.com/mautic/mautic.git","svn_url":"https://github.com/mautic/mautic","homepage":"https://www.mautic.org","size":83103,"stargazers_count":2731,"watchers_count":2731,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":994,"mirror_url":null,"archived":false,"open_issues_count":796,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":994,"open_issues":796,"watchers":2731,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/mautic/mautic/pulls/6046"},"html":{"href":"https://github.com/mautic/mautic/pull/6046"},"issue":{"href":"https://api.github.com/repos/mautic/mautic/issues/6046"},"comments":{"href":"https://api.github.com/repos/mautic/mautic/issues/6046/comments"},"review_comments":{"href":"https://api.github.com/repos/mautic/mautic/pulls/6046/comments"},"review_comment":{"href":"https://api.github.com/repos/mautic/mautic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mautic/mautic/pulls/6046/commits"},"statuses":{"href":"https://api.github.com/repos/mautic/mautic/statuses/0239f63bc4ee72a0b2f66dfdc9c7255e5e9ec61e"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"escopecz","id":1235442,"node_id":"MDQ6VXNlcjEyMzU0NDI=","avatar_url":"https://avatars2.githubusercontent.com/u/1235442?v=4","gravatar_id":"","url":"https://api.github.com/users/escopecz","html_url":"https://github.com/escopecz","followers_url":"https://api.github.com/users/escopecz/followers","following_url":"https://api.github.com/users/escopecz/following{/other_user}","gists_url":"https://api.github.com/users/escopecz/gists{/gist_id}","starred_url":"https://api.github.com/users/escopecz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/escopecz/subscriptions","organizations_url":"https://api.github.com/users/escopecz/orgs","repos_url":"https://api.github.com/users/escopecz/repos","events_url":"https://api.github.com/users/escopecz/events{/privacy}","received_events_url":"https://api.github.com/users/escopecz/received_events","type":"User","site_admin":false},"comments":13,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":43,"deletions":3,"changed_files":2}}
{"actor":{"display_login":"escopecz"}}