{"action":"created","comment":{"url":"https://api.github.com/repos/powsybl/powsybl-core/pulls/comments/238214150","pull_request_review_id":180698413,"id":238214150,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzODIxNDE1MA==","diff_hunk":"@@ -134,35 +133,66 @@ public double getQ() {\n                 .map(clazz::cast);\n     }\n \n+    @Override\n     public Iterable<Line> getLines() {\n         return getConnectables(Line.class);\n     }\n \n+    @Override\n     public Stream<Line> getLineStream() {\n         return getConnectableStream(Line.class);\n     }\n \n-    public Iterable<TwoWindingsTransformer> getTwoWindingTransformers() {\n+    @Override\n+    public Iterable<TwoWindingsTransformer> getTwoWindingsTransformers() {\n         return getConnectables(TwoWindingsTransformer.class);\n     }\n \n-    public Stream<TwoWindingsTransformer> getTwoWindingTransformerStream() {\n+    @Deprecated\n+    @Override\n+    public Iterable<TwoWindingsTransformer> getTwoWindingTransformers() {\n+        return getTwoWindingsTransformers();\n+    }\n+\n+    @Override\n+    public Stream<TwoWindingsTransformer> getTwoWindingsTransformerStream() {\n         return getConnectableStream(TwoWindingsTransformer.class);\n     }\n \n+    @Deprecated\n+    @Override\n+    public Stream<TwoWindingsTransformer> getTwoWindingTransformerStream() {","path":"iidm/iidm-impl/src/main/java/com/powsybl/iidm/network/impl/AbstractBus.java","position":88,"original_position":88,"commit_id":"46511afae8017b01af97b0f1431d8d71bb9a803e","original_commit_id":"46511afae8017b01af97b0f1431d8d71bb9a803e","user":{"login":"sonarcloud[bot]","id":39514782,"node_id":"MDM6Qm90Mzk1MTQ3ODI=","avatar_url":"https://avatars2.githubusercontent.com/in/12526?v=4","gravatar_id":"","url":"https://api.github.com/users/sonarcloud%5Bbot%5D","html_url":"https://github.com/apps/sonarcloud","followers_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/followers","following_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/repos","events_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/received_events","type":"Bot","site_admin":false},"body":"![Code Smell](https://sonarsource.github.io/sonar-github/code_smell.png 'Code Smell') Code Smell: Do not forget to remove this deprecated code someday. ([squid:S1133](https://sonarcloud.io/organizations/powsybl-ci-github/rules#rule_key=squid%3AS1133))\n\n[See it in SonarCloud](https://sonarcloud.io/project/issues?id=com.powsybl%3Apowsybl-core&pullRequest=529&issues=AWdznkKR9ZSrbQzILNo7&open=AWdznkKR9ZSrbQzILNo7)\n\n[ISSUE_KEY]: AWdznkKR9ZSrbQzILNo7","created_at":"2018-12-03T10:30:16Z","updated_at":"2018-12-03T10:30:17Z","html_url":"https://github.com/powsybl/powsybl-core/pull/529#discussion_r238214150","pull_request_url":"https://api.github.com/repos/powsybl/powsybl-core/pulls/529","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/powsybl/powsybl-core/pulls/comments/238214150"},"html":{"href":"https://github.com/powsybl/powsybl-core/pull/529#discussion_r238214150"},"pull_request":{"href":"https://api.github.com/repos/powsybl/powsybl-core/pulls/529"}}},"pull_request":{"url":"https://api.github.com/repos/powsybl/powsybl-core/pulls/529","id":235390939,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1MzkwOTM5","html_url":"https://github.com/powsybl/powsybl-core/pull/529","diff_url":"https://github.com/powsybl/powsybl-core/pull/529.diff","patch_url":"https://github.com/powsybl/powsybl-core/pull/529.patch","issue_url":"https://api.github.com/repos/powsybl/powsybl-core/issues/529","number":529,"state":"open","locked":false,"title":"Use Two/ThreeWindingsTransformer instead of Two/ThreeWindingTransformer","user":{"login":"yichen88","id":30594441,"node_id":"MDQ6VXNlcjMwNTk0NDQx","avatar_url":"https://avatars0.githubusercontent.com/u/30594441?v=4","gravatar_id":"","url":"https://api.github.com/users/yichen88","html_url":"https://github.com/yichen88","followers_url":"https://api.github.com/users/yichen88/followers","following_url":"https://api.github.com/users/yichen88/following{/other_user}","gists_url":"https://api.github.com/users/yichen88/gists{/gist_id}","starred_url":"https://api.github.com/users/yichen88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yichen88/subscriptions","organizations_url":"https://api.github.com/users/yichen88/orgs","repos_url":"https://api.github.com/users/yichen88/repos","events_url":"https://api.github.com/users/yichen88/events{/privacy}","received_events_url":"https://api.github.com/users/yichen88/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-12-03T10:14:26Z","updated_at":"2018-12-03T10:30:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eeef18d8a2aacdfa3517d745ebc730648f396df0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/powsybl/powsybl-core/pulls/529/commits","review_comments_url":"https://api.github.com/repos/powsybl/powsybl-core/pulls/529/comments","review_comment_url":"https://api.github.com/repos/powsybl/powsybl-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/powsybl/powsybl-core/issues/529/comments","statuses_url":"https://api.github.com/repos/powsybl/powsybl-core/statuses/46511afae8017b01af97b0f1431d8d71bb9a803e","head":{"label":"powsybl:fix_bus_api_consistency","ref":"fix_bus_api_consistency","sha":"46511afae8017b01af97b0f1431d8d71bb9a803e","user":{"login":"powsybl","id":29916668,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5OTE2NjY4","avatar_url":"https://avatars2.githubusercontent.com/u/29916668?v=4","gravatar_id":"","url":"https://api.github.com/users/powsybl","html_url":"https://github.com/powsybl","followers_url":"https://api.github.com/users/powsybl/followers","following_url":"https://api.github.com/users/powsybl/following{/other_user}","gists_url":"https://api.github.com/users/powsybl/gists{/gist_id}","starred_url":"https://api.github.com/users/powsybl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/powsybl/subscriptions","organizations_url":"https://api.github.com/users/powsybl/orgs","repos_url":"https://api.github.com/users/powsybl/repos","events_url":"https://api.github.com/users/powsybl/events{/privacy}","received_events_url":"https://api.github.com/users/powsybl/received_events","type":"Organization","site_admin":false},"repo":{"id":105284146,"node_id":"MDEwOlJlcG9zaXRvcnkxMDUyODQxNDY=","name":"powsybl-core","full_name":"powsybl/powsybl-core","private":false,"owner":{"login":"powsybl","id":29916668,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5OTE2NjY4","avatar_url":"https://avatars2.githubusercontent.com/u/29916668?v=4","gravatar_id":"","url":"https://api.github.com/users/powsybl","html_url":"https://github.com/powsybl","followers_url":"https://api.github.com/users/powsybl/followers","following_url":"https://api.github.com/users/powsybl/following{/other_user}","gists_url":"https://api.github.com/users/powsybl/gists{/gist_id}","starred_url":"https://api.github.com/users/powsybl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/powsybl/subscriptions","organizations_url":"https://api.github.com/users/powsybl/orgs","repos_url":"https://api.github.com/users/powsybl/repos","events_url":"https://api.github.com/users/powsybl/events{/privacy}","received_events_url":"https://api.github.com/users/powsybl/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/powsybl/powsybl-core","description":"A framework to build power system oriented software","fork":false,"url":"https://api.github.com/repos/powsybl/powsybl-core","forks_url":"https://api.github.com/repos/powsybl/powsybl-core/forks","keys_url":"https://api.github.com/repos/powsybl/powsybl-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/powsybl/powsybl-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/powsybl/powsybl-core/teams","hooks_url":"https://api.github.com/repos/powsybl/powsybl-core/hooks","issue_events_url":"https://api.github.com/repos/powsybl/powsybl-core/issues/events{/number}","events_url":"https://api.github.com/repos/powsybl/powsybl-core/events","assignees_url":"https://api.github.com/repos/powsybl/powsybl-core/assignees{/user}","branches_url":"https://api.github.com/repos/powsybl/powsybl-core/branches{/branch}","tags_url":"https://api.github.com/repos/powsybl/powsybl-core/tags","blobs_url":"https://api.github.com/repos/powsybl/powsybl-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/powsybl/powsybl-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/powsybl/powsybl-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/powsybl/powsybl-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/powsybl/powsybl-core/statuses/{sha}","languages_url":"https://api.github.com/repos/powsybl/powsybl-core/languages","stargazers_url":"https://api.github.com/repos/powsybl/powsybl-core/stargazers","contributors_url":"https://api.github.com/repos/powsybl/powsybl-core/contributors","subscribers_url":"https://api.github.com/repos/powsybl/powsybl-core/subscribers","subscription_url":"https://api.github.com/repos/powsybl/powsybl-core/subscription","commits_url":"https://api.github.com/repos/powsybl/powsybl-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/powsybl/powsybl-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/powsybl/powsybl-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/powsybl/powsybl-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/powsybl/powsybl-core/contents/{+path}","compare_url":"https://api.github.com/repos/powsybl/powsybl-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/powsybl/powsybl-core/merges","archive_url":"https://api.github.com/repos/powsybl/powsybl-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/powsybl/powsybl-core/downloads","issues_url":"https://api.github.com/repos/powsybl/powsybl-core/issues{/number}","pulls_url":"https://api.github.com/repos/powsybl/powsybl-core/pulls{/number}","milestones_url":"https://api.github.com/repos/powsybl/powsybl-core/milestones{/number}","notifications_url":"https://api.github.com/repos/powsybl/powsybl-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/powsybl/powsybl-core/labels{/name}","releases_url":"https://api.github.com/repos/powsybl/powsybl-core/releases{/id}","deployments_url":"https://api.github.com/repos/powsybl/powsybl-core/deployments","created_at":"2017-09-29T14:51:18Z","updated_at":"2018-12-01T11:16:09Z","pushed_at":"2018-12-03T10:28:58Z","git_url":"git://github.com/powsybl/powsybl-core.git","ssh_url":"git@github.com:powsybl/powsybl-core.git","clone_url":"https://github.com/powsybl/powsybl-core.git","svn_url":"https://github.com/powsybl/powsybl-core","homepage":"http://www.powsybl.com","size":15951,"stargazers_count":24,"watchers_count":24,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":52,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":8,"open_issues":52,"watchers":24,"default_branch":"master"}},"base":{"label":"powsybl:master","ref":"master","sha":"5a9cbe9a80a3fd16b85d2f546cb5ecf1b2d10a48","user":{"login":"powsybl","id":29916668,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5OTE2NjY4","avatar_url":"https://avatars2.githubusercontent.com/u/29916668?v=4","gravatar_id":"","url":"https://api.github.com/users/powsybl","html_url":"https://github.com/powsybl","followers_url":"https://api.github.com/users/powsybl/followers","following_url":"https://api.github.com/users/powsybl/following{/other_user}","gists_url":"https://api.github.com/users/powsybl/gists{/gist_id}","starred_url":"https://api.github.com/users/powsybl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/powsybl/subscriptions","organizations_url":"https://api.github.com/users/powsybl/orgs","repos_url":"https://api.github.com/users/powsybl/repos","events_url":"https://api.github.com/users/powsybl/events{/privacy}","received_events_url":"https://api.github.com/users/powsybl/received_events","type":"Organization","site_admin":false},"repo":{"id":105284146,"node_id":"MDEwOlJlcG9zaXRvcnkxMDUyODQxNDY=","name":"powsybl-core","full_name":"powsybl/powsybl-core","private":false,"owner":{"login":"powsybl","id":29916668,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5OTE2NjY4","avatar_url":"https://avatars2.githubusercontent.com/u/29916668?v=4","gravatar_id":"","url":"https://api.github.com/users/powsybl","html_url":"https://github.com/powsybl","followers_url":"https://api.github.com/users/powsybl/followers","following_url":"https://api.github.com/users/powsybl/following{/other_user}","gists_url":"https://api.github.com/users/powsybl/gists{/gist_id}","starred_url":"https://api.github.com/users/powsybl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/powsybl/subscriptions","organizations_url":"https://api.github.com/users/powsybl/orgs","repos_url":"https://api.github.com/users/powsybl/repos","events_url":"https://api.github.com/users/powsybl/events{/privacy}","received_events_url":"https://api.github.com/users/powsybl/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/powsybl/powsybl-core","description":"A framework to build power system oriented software","fork":false,"url":"https://api.github.com/repos/powsybl/powsybl-core","forks_url":"https://api.github.com/repos/powsybl/powsybl-core/forks","keys_url":"https://api.github.com/repos/powsybl/powsybl-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/powsybl/powsybl-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/powsybl/powsybl-core/teams","hooks_url":"https://api.github.com/repos/powsybl/powsybl-core/hooks","issue_events_url":"https://api.github.com/repos/powsybl/powsybl-core/issues/events{/number}","events_url":"https://api.github.com/repos/powsybl/powsybl-core/events","assignees_url":"https://api.github.com/repos/powsybl/powsybl-core/assignees{/user}","branches_url":"https://api.github.com/repos/powsybl/powsybl-core/branches{/branch}","tags_url":"https://api.github.com/repos/powsybl/powsybl-core/tags","blobs_url":"https://api.github.com/repos/powsybl/powsybl-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/powsybl/powsybl-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/powsybl/powsybl-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/powsybl/powsybl-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/powsybl/powsybl-core/statuses/{sha}","languages_url":"https://api.github.com/repos/powsybl/powsybl-core/languages","stargazers_url":"https://api.github.com/repos/powsybl/powsybl-core/stargazers","contributors_url":"https://api.github.com/repos/powsybl/powsybl-core/contributors","subscribers_url":"https://api.github.com/repos/powsybl/powsybl-core/subscribers","subscription_url":"https://api.github.com/repos/powsybl/powsybl-core/subscription","commits_url":"https://api.github.com/repos/powsybl/powsybl-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/powsybl/powsybl-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/powsybl/powsybl-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/powsybl/powsybl-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/powsybl/powsybl-core/contents/{+path}","compare_url":"https://api.github.com/repos/powsybl/powsybl-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/powsybl/powsybl-core/merges","archive_url":"https://api.github.com/repos/powsybl/powsybl-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/powsybl/powsybl-core/downloads","issues_url":"https://api.github.com/repos/powsybl/powsybl-core/issues{/number}","pulls_url":"https://api.github.com/repos/powsybl/powsybl-core/pulls{/number}","milestones_url":"https://api.github.com/repos/powsybl/powsybl-core/milestones{/number}","notifications_url":"https://api.github.com/repos/powsybl/powsybl-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/powsybl/powsybl-core/labels{/name}","releases_url":"https://api.github.com/repos/powsybl/powsybl-core/releases{/id}","deployments_url":"https://api.github.com/repos/powsybl/powsybl-core/deployments","created_at":"2017-09-29T14:51:18Z","updated_at":"2018-12-01T11:16:09Z","pushed_at":"2018-12-03T10:28:58Z","git_url":"git://github.com/powsybl/powsybl-core.git","ssh_url":"git@github.com:powsybl/powsybl-core.git","clone_url":"https://github.com/powsybl/powsybl-core.git","svn_url":"https://github.com/powsybl/powsybl-core","homepage":"http://www.powsybl.com","size":15951,"stargazers_count":24,"watchers_count":24,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":52,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":8,"open_issues":52,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/powsybl/powsybl-core/pulls/529"},"html":{"href":"https://github.com/powsybl/powsybl-core/pull/529"},"issue":{"href":"https://api.github.com/repos/powsybl/powsybl-core/issues/529"},"comments":{"href":"https://api.github.com/repos/powsybl/powsybl-core/issues/529/comments"},"review_comments":{"href":"https://api.github.com/repos/powsybl/powsybl-core/pulls/529/comments"},"review_comment":{"href":"https://api.github.com/repos/powsybl/powsybl-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/powsybl/powsybl-core/pulls/529/commits"},"statuses":{"href":"https://api.github.com/repos/powsybl/powsybl-core/statuses/46511afae8017b01af97b0f1431d8d71bb9a803e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"sonarcloud"}}