{"action":"created","comment":{"url":"https://api.github.com/repos/Cryptonomic/ConseilJS/pulls/comments/220703638","pull_request_review_id":159173846,"id":220703638,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMDcwMzYzOA==","diff_hunk":"@@ -0,0 +1,22 @@\n+import * as ledgerUtils from \"../utils/LedgerUtils\";\n+import {HardwareDeviceType} from \"../types/HardwareDeviceType\";\n+import {base58CheckEncode} from \"../utils/CryptoUtils\";\n+import * as sodium  from 'libsodium-wrappers-sumo';\n+import {KeyStore, StoreType} from \"../types/KeyStore\";\n+\n+export namespace TezosHardwareWallet {\n+\n+    export async function unlockAddress(deviceType: HardwareDeviceType, derivationPath: string): Promise<KeyStore> {","path":"src/tezos/TezosHardwareWallet.ts","position":9,"original_position":9,"commit_id":"22096620e4db8fc8150fb455caa3d17ca8574b5e","original_commit_id":"22096620e4db8fc8150fb455caa3d17ca8574b5e","user":{"login":"ba205","id":7725054,"node_id":"MDQ6VXNlcjc3MjUwNTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/7725054?v=4","gravatar_id":"","url":"https://api.github.com/users/ba205","html_url":"https://github.com/ba205","followers_url":"https://api.github.com/users/ba205/followers","following_url":"https://api.github.com/users/ba205/following{/other_user}","gists_url":"https://api.github.com/users/ba205/gists{/gist_id}","starred_url":"https://api.github.com/users/ba205/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ba205/subscriptions","organizations_url":"https://api.github.com/users/ba205/orgs","repos_url":"https://api.github.com/users/ba205/repos","events_url":"https://api.github.com/users/ba205/events{/privacy}","received_events_url":"https://api.github.com/users/ba205/received_events","type":"User","site_admin":false},"body":"I'm confused here. This returns a Promise<KeyStore>, whereas UnlockIdentityWithMnemonic returns a KeyStore | Error, and neither function is used for the other. Is there a different function signature you want to make consistent?","created_at":"2018-09-26T20:01:09Z","updated_at":"2018-09-26T20:01:10Z","html_url":"https://github.com/Cryptonomic/ConseilJS/pull/50#discussion_r220703638","pull_request_url":"https://api.github.com/repos/Cryptonomic/ConseilJS/pulls/50","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Cryptonomic/ConseilJS/pulls/comments/220703638"},"html":{"href":"https://github.com/Cryptonomic/ConseilJS/pull/50#discussion_r220703638"},"pull_request":{"href":"https://api.github.com/repos/Cryptonomic/ConseilJS/pulls/50"}},"in_reply_to_id":220688112},"pull_request":{"url":"https://api.github.com/repos/Cryptonomic/ConseilJS/pulls/50","id":218033963,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4MDMzOTYz","html_url":"https://github.com/Cryptonomic/ConseilJS/pull/50","diff_url":"https://github.com/Cryptonomic/ConseilJS/pull/50.diff","patch_url":"https://github.com/Cryptonomic/ConseilJS/pull/50.patch","issue_url":"https://api.github.com/repos/Cryptonomic/ConseilJS/issues/50","number":50,"state":"open","locked":false,"title":"Feature/47 ledger support","user":{"login":"ba205","id":7725054,"node_id":"MDQ6VXNlcjc3MjUwNTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/7725054?v=4","gravatar_id":"","url":"https://api.github.com/users/ba205","html_url":"https://github.com/ba205","followers_url":"https://api.github.com/users/ba205/followers","following_url":"https://api.github.com/users/ba205/following{/other_user}","gists_url":"https://api.github.com/users/ba205/gists{/gist_id}","starred_url":"https://api.github.com/users/ba205/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ba205/subscriptions","organizations_url":"https://api.github.com/users/ba205/orgs","repos_url":"https://api.github.com/users/ba205/repos","events_url":"https://api.github.com/users/ba205/events{/privacy}","received_events_url":"https://api.github.com/users/ba205/received_events","type":"User","site_admin":false},"body":"Successful signing of operations using ledgers","created_at":"2018-09-25T15:56:33Z","updated_at":"2018-09-26T20:01:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"787e69c20eafe95662b470ea87002fa721c4323d","assignee":{"login":"ba205","id":7725054,"node_id":"MDQ6VXNlcjc3MjUwNTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/7725054?v=4","gravatar_id":"","url":"https://api.github.com/users/ba205","html_url":"https://github.com/ba205","followers_url":"https://api.github.com/users/ba205/followers","following_url":"https://api.github.com/users/ba205/following{/other_user}","gists_url":"https://api.github.com/users/ba205/gists{/gist_id}","starred_url":"https://api.github.com/users/ba205/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ba205/subscriptions","organizations_url":"https://api.github.com/users/ba205/orgs","repos_url":"https://api.github.com/users/ba205/repos","events_url":"https://api.github.com/users/ba205/events{/privacy}","received_events_url":"https://api.github.com/users/ba205/received_events","type":"User","site_admin":false},"assignees":[{"login":"ba205","id":7725054,"node_id":"MDQ6VXNlcjc3MjUwNTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/7725054?v=4","gravatar_id":"","url":"https://api.github.com/users/ba205","html_url":"https://github.com/ba205","followers_url":"https://api.github.com/users/ba205/followers","following_url":"https://api.github.com/users/ba205/following{/other_user}","gists_url":"https://api.github.com/users/ba205/gists{/gist_id}","starred_url":"https://api.github.com/users/ba205/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ba205/subscriptions","organizations_url":"https://api.github.com/users/ba205/orgs","repos_url":"https://api.github.com/users/ba205/repos","events_url":"https://api.github.com/users/ba205/events{/privacy}","received_events_url":"https://api.github.com/users/ba205/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":945901036,"node_id":"MDU6TGFiZWw5NDU5MDEwMzY=","url":"https://api.github.com/repos/Cryptonomic/ConseilJS/labels/enhancement","name":"enhancement","color":"a2eeef","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/Cryptonomic/ConseilJS/pulls/50/commits","review_comments_url":"https://api.github.com/repos/Cryptonomic/ConseilJS/pulls/50/comments","review_comment_url":"https://api.github.com/repos/Cryptonomic/ConseilJS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Cryptonomic/ConseilJS/issues/50/comments","statuses_url":"https://api.github.com/repos/Cryptonomic/ConseilJS/statuses/22096620e4db8fc8150fb455caa3d17ca8574b5e","head":{"label":"Cryptonomic:feature/47-Ledger-support","ref":"feature/47-Ledger-support","sha":"22096620e4db8fc8150fb455caa3d17ca8574b5e","user":{"login":"Cryptonomic","id":34078414,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MDc4NDE0","avatar_url":"https://avatars0.githubusercontent.com/u/34078414?v=4","gravatar_id":"","url":"https://api.github.com/users/Cryptonomic","html_url":"https://github.com/Cryptonomic","followers_url":"https://api.github.com/users/Cryptonomic/followers","following_url":"https://api.github.com/users/Cryptonomic/following{/other_user}","gists_url":"https://api.github.com/users/Cryptonomic/gists{/gist_id}","starred_url":"https://api.github.com/users/Cryptonomic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cryptonomic/subscriptions","organizations_url":"https://api.github.com/users/Cryptonomic/orgs","repos_url":"https://api.github.com/users/Cryptonomic/repos","events_url":"https://api.github.com/users/Cryptonomic/events{/privacy}","received_events_url":"https://api.github.com/users/Cryptonomic/received_events","type":"Organization","site_admin":false},"repo":{"id":135016498,"node_id":"MDEwOlJlcG9zaXRvcnkxMzUwMTY0OTg=","name":"ConseilJS","full_name":"Cryptonomic/ConseilJS","private":false,"owner":{"login":"Cryptonomic","id":34078414,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MDc4NDE0","avatar_url":"https://avatars0.githubusercontent.com/u/34078414?v=4","gravatar_id":"","url":"https://api.github.com/users/Cryptonomic","html_url":"https://github.com/Cryptonomic","followers_url":"https://api.github.com/users/Cryptonomic/followers","following_url":"https://api.github.com/users/Cryptonomic/following{/other_user}","gists_url":"https://api.github.com/users/Cryptonomic/gists{/gist_id}","starred_url":"https://api.github.com/users/Cryptonomic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cryptonomic/subscriptions","organizations_url":"https://api.github.com/users/Cryptonomic/orgs","repos_url":"https://api.github.com/users/Cryptonomic/repos","events_url":"https://api.github.com/users/Cryptonomic/events{/privacy}","received_events_url":"https://api.github.com/users/Cryptonomic/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Cryptonomic/ConseilJS","description":"Client-side library for building decentralized applications.","fork":false,"url":"https://api.github.com/repos/Cryptonomic/ConseilJS","forks_url":"https://api.github.com/repos/Cryptonomic/ConseilJS/forks","keys_url":"https://api.github.com/repos/Cryptonomic/ConseilJS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Cryptonomic/ConseilJS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Cryptonomic/ConseilJS/teams","hooks_url":"https://api.github.com/repos/Cryptonomic/ConseilJS/hooks","issue_events_url":"https://api.github.com/repos/Cryptonomic/ConseilJS/issues/events{/number}","events_url":"https://api.github.com/repos/Cryptonomic/ConseilJS/events","assignees_url":"https://api.github.com/repos/Cryptonomic/ConseilJS/assignees{/user}","branches_url":"https://api.github.com/repos/Cryptonomic/ConseilJS/branches{/branch}","tags_url":"https://api.github.com/repos/Cryptonomic/ConseilJS/tags","blobs_url":"https://api.github.com/repos/Cryptonomic/ConseilJS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Cryptonomic/ConseilJS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Cryptonomic/ConseilJS/git/refs{/sha}","trees_url":"https://api.github.com/repos/Cryptonomic/ConseilJS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Cryptonomic/ConseilJS/statuses/{sha}","languages_url":"https://api.github.com/repos/Cryptonomic/ConseilJS/languages","stargazers_url":"https://api.github.com/repos/Cryptonomic/ConseilJS/stargazers","contributors_url":"https://api.github.com/repos/Cryptonomic/ConseilJS/contributors","subscribers_url":"https://api.github.com/repos/Cryptonomic/ConseilJS/subscribers","subscription_url":"https://api.github.com/repos/Cryptonomic/ConseilJS/subscription","commits_url":"https://api.github.com/repos/Cryptonomic/ConseilJS/commits{/sha}","git_commits_url":"https://api.github.com/repos/Cryptonomic/ConseilJS/git/commits{/sha}","comments_url":"https://api.github.com/repos/Cryptonomic/ConseilJS/comments{/number}","issue_comment_url":"https://api.github.com/repos/Cryptonomic/ConseilJS/issues/comments{/number}","contents_url":"https://api.github.com/repos/Cryptonomic/ConseilJS/contents/{+path}","compare_url":"https://api.github.com/repos/Cryptonomic/ConseilJS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Cryptonomic/ConseilJS/merges","archive_url":"https://api.github.com/repos/Cryptonomic/ConseilJS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Cryptonomic/ConseilJS/downloads","issues_url":"https://api.github.com/repos/Cryptonomic/ConseilJS/issues{/number}","pulls_url":"https://api.github.com/repos/Cryptonomic/ConseilJS/pulls{/number}","milestones_url":"https://api.github.com/repos/Cryptonomic/ConseilJS/milestones{/number}","notifications_url":"https://api.github.com/repos/Cryptonomic/ConseilJS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Cryptonomic/ConseilJS/labels{/name}","releases_url":"https://api.github.com/repos/Cryptonomic/ConseilJS/releases{/id}","deployments_url":"https://api.github.com/repos/Cryptonomic/ConseilJS/deployments","created_at":"2018-05-27T04:50:05Z","updated_at":"2018-08-21T20:28:56Z","pushed_at":"2018-09-26T17:50:58Z","git_url":"git://github.com/Cryptonomic/ConseilJS.git","ssh_url":"git@github.com:Cryptonomic/ConseilJS.git","clone_url":"https://github.com/Cryptonomic/ConseilJS.git","svn_url":"https://github.com/Cryptonomic/ConseilJS","homepage":null,"size":443,"stargazers_count":4,"watchers_count":4,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":3,"open_issues":13,"watchers":4,"default_branch":"master"}},"base":{"label":"Cryptonomic:master","ref":"master","sha":"560c07674b1e348a0e20af74203d64b17a9608e3","user":{"login":"Cryptonomic","id":34078414,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MDc4NDE0","avatar_url":"https://avatars0.githubusercontent.com/u/34078414?v=4","gravatar_id":"","url":"https://api.github.com/users/Cryptonomic","html_url":"https://github.com/Cryptonomic","followers_url":"https://api.github.com/users/Cryptonomic/followers","following_url":"https://api.github.com/users/Cryptonomic/following{/other_user}","gists_url":"https://api.github.com/users/Cryptonomic/gists{/gist_id}","starred_url":"https://api.github.com/users/Cryptonomic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cryptonomic/subscriptions","organizations_url":"https://api.github.com/users/Cryptonomic/orgs","repos_url":"https://api.github.com/users/Cryptonomic/repos","events_url":"https://api.github.com/users/Cryptonomic/events{/privacy}","received_events_url":"https://api.github.com/users/Cryptonomic/received_events","type":"Organization","site_admin":false},"repo":{"id":135016498,"node_id":"MDEwOlJlcG9zaXRvcnkxMzUwMTY0OTg=","name":"ConseilJS","full_name":"Cryptonomic/ConseilJS","private":false,"owner":{"login":"Cryptonomic","id":34078414,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MDc4NDE0","avatar_url":"https://avatars0.githubusercontent.com/u/34078414?v=4","gravatar_id":"","url":"https://api.github.com/users/Cryptonomic","html_url":"https://github.com/Cryptonomic","followers_url":"https://api.github.com/users/Cryptonomic/followers","following_url":"https://api.github.com/users/Cryptonomic/following{/other_user}","gists_url":"https://api.github.com/users/Cryptonomic/gists{/gist_id}","starred_url":"https://api.github.com/users/Cryptonomic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cryptonomic/subscriptions","organizations_url":"https://api.github.com/users/Cryptonomic/orgs","repos_url":"https://api.github.com/users/Cryptonomic/repos","events_url":"https://api.github.com/users/Cryptonomic/events{/privacy}","received_events_url":"https://api.github.com/users/Cryptonomic/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Cryptonomic/ConseilJS","description":"Client-side library for building decentralized applications.","fork":false,"url":"https://api.github.com/repos/Cryptonomic/ConseilJS","forks_url":"https://api.github.com/repos/Cryptonomic/ConseilJS/forks","keys_url":"https://api.github.com/repos/Cryptonomic/ConseilJS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Cryptonomic/ConseilJS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Cryptonomic/ConseilJS/teams","hooks_url":"https://api.github.com/repos/Cryptonomic/ConseilJS/hooks","issue_events_url":"https://api.github.com/repos/Cryptonomic/ConseilJS/issues/events{/number}","events_url":"https://api.github.com/repos/Cryptonomic/ConseilJS/events","assignees_url":"https://api.github.com/repos/Cryptonomic/ConseilJS/assignees{/user}","branches_url":"https://api.github.com/repos/Cryptonomic/ConseilJS/branches{/branch}","tags_url":"https://api.github.com/repos/Cryptonomic/ConseilJS/tags","blobs_url":"https://api.github.com/repos/Cryptonomic/ConseilJS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Cryptonomic/ConseilJS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Cryptonomic/ConseilJS/git/refs{/sha}","trees_url":"https://api.github.com/repos/Cryptonomic/ConseilJS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Cryptonomic/ConseilJS/statuses/{sha}","languages_url":"https://api.github.com/repos/Cryptonomic/ConseilJS/languages","stargazers_url":"https://api.github.com/repos/Cryptonomic/ConseilJS/stargazers","contributors_url":"https://api.github.com/repos/Cryptonomic/ConseilJS/contributors","subscribers_url":"https://api.github.com/repos/Cryptonomic/ConseilJS/subscribers","subscription_url":"https://api.github.com/repos/Cryptonomic/ConseilJS/subscription","commits_url":"https://api.github.com/repos/Cryptonomic/ConseilJS/commits{/sha}","git_commits_url":"https://api.github.com/repos/Cryptonomic/ConseilJS/git/commits{/sha}","comments_url":"https://api.github.com/repos/Cryptonomic/ConseilJS/comments{/number}","issue_comment_url":"https://api.github.com/repos/Cryptonomic/ConseilJS/issues/comments{/number}","contents_url":"https://api.github.com/repos/Cryptonomic/ConseilJS/contents/{+path}","compare_url":"https://api.github.com/repos/Cryptonomic/ConseilJS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Cryptonomic/ConseilJS/merges","archive_url":"https://api.github.com/repos/Cryptonomic/ConseilJS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Cryptonomic/ConseilJS/downloads","issues_url":"https://api.github.com/repos/Cryptonomic/ConseilJS/issues{/number}","pulls_url":"https://api.github.com/repos/Cryptonomic/ConseilJS/pulls{/number}","milestones_url":"https://api.github.com/repos/Cryptonomic/ConseilJS/milestones{/number}","notifications_url":"https://api.github.com/repos/Cryptonomic/ConseilJS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Cryptonomic/ConseilJS/labels{/name}","releases_url":"https://api.github.com/repos/Cryptonomic/ConseilJS/releases{/id}","deployments_url":"https://api.github.com/repos/Cryptonomic/ConseilJS/deployments","created_at":"2018-05-27T04:50:05Z","updated_at":"2018-08-21T20:28:56Z","pushed_at":"2018-09-26T17:50:58Z","git_url":"git://github.com/Cryptonomic/ConseilJS.git","ssh_url":"git@github.com:Cryptonomic/ConseilJS.git","clone_url":"https://github.com/Cryptonomic/ConseilJS.git","svn_url":"https://github.com/Cryptonomic/ConseilJS","homepage":null,"size":443,"stargazers_count":4,"watchers_count":4,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":3,"open_issues":13,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Cryptonomic/ConseilJS/pulls/50"},"html":{"href":"https://github.com/Cryptonomic/ConseilJS/pull/50"},"issue":{"href":"https://api.github.com/repos/Cryptonomic/ConseilJS/issues/50"},"comments":{"href":"https://api.github.com/repos/Cryptonomic/ConseilJS/issues/50/comments"},"review_comments":{"href":"https://api.github.com/repos/Cryptonomic/ConseilJS/pulls/50/comments"},"review_comment":{"href":"https://api.github.com/repos/Cryptonomic/ConseilJS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Cryptonomic/ConseilJS/pulls/50/commits"},"statuses":{"href":"https://api.github.com/repos/Cryptonomic/ConseilJS/statuses/22096620e4db8fc8150fb455caa3d17ca8574b5e"}},"author_association":"NONE"}}
{"actor":{"display_login":"ba205"}}