{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq-providers-amazon/issues/482","repository_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-amazon","labels_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-amazon/issues/482/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-amazon/issues/482/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-amazon/issues/482/events","html_url":"https://github.com/ManageIQ/manageiq-providers-amazon/pull/482","id":355162702,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExNzU0ODU4","number":482,"title":"avoid blank names by using uids","user":{"login":"AlexanderZagaynov","id":7778414,"node_id":"MDQ6VXNlcjc3Nzg0MTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/7778414?v=4","gravatar_id":"","url":"https://api.github.com/users/AlexanderZagaynov","html_url":"https://github.com/AlexanderZagaynov","followers_url":"https://api.github.com/users/AlexanderZagaynov/followers","following_url":"https://api.github.com/users/AlexanderZagaynov/following{/other_user}","gists_url":"https://api.github.com/users/AlexanderZagaynov/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexanderZagaynov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexanderZagaynov/subscriptions","organizations_url":"https://api.github.com/users/AlexanderZagaynov/orgs","repos_url":"https://api.github.com/users/AlexanderZagaynov/repos","events_url":"https://api.github.com/users/AlexanderZagaynov/events{/privacy}","received_events_url":"https://api.github.com/users/AlexanderZagaynov/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-08-29T13:32:39Z","updated_at":"2018-09-24T16:50:29Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq-providers-amazon/pulls/482","html_url":"https://github.com/ManageIQ/manageiq-providers-amazon/pull/482","diff_url":"https://github.com/ManageIQ/manageiq-providers-amazon/pull/482.diff","patch_url":"https://github.com/ManageIQ/manageiq-providers-amazon/pull/482.patch"},"body":"Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1531117\r\n\r\nResource name tag can be not defined or a blank string.\r\nResource ID will be used in such case.\r\n\r\nMy approach:\r\n1) Change all `get_from_tags` methods to make them return `nil` instead of blank strings, \r\nto make `||` code behave as expected.\r\n```\r\n'' || 'uid' => ''\r\n''.presence || 'uid' => 'uid'\r\n```\r\n2) Find all `name` code references, and fix those, where it can have any sense."},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq-providers-amazon/issues/comments/424045533","html_url":"https://github.com/ManageIQ/manageiq-providers-amazon/pull/482#issuecomment-424045533","issue_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-amazon/issues/482","id":424045533,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNDA0NTUzMw==","user":{"login":"djberg96","id":78529,"node_id":"MDQ6VXNlcjc4NTI5","avatar_url":"https://avatars3.githubusercontent.com/u/78529?v=4","gravatar_id":"","url":"https://api.github.com/users/djberg96","html_url":"https://github.com/djberg96","followers_url":"https://api.github.com/users/djberg96/followers","following_url":"https://api.github.com/users/djberg96/following{/other_user}","gists_url":"https://api.github.com/users/djberg96/gists{/gist_id}","starred_url":"https://api.github.com/users/djberg96/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djberg96/subscriptions","organizations_url":"https://api.github.com/users/djberg96/orgs","repos_url":"https://api.github.com/users/djberg96/repos","events_url":"https://api.github.com/users/djberg96/events{/privacy}","received_events_url":"https://api.github.com/users/djberg96/received_events","type":"User","site_admin":false},"created_at":"2018-09-24T16:50:29Z","updated_at":"2018-09-24T16:50:29Z","author_association":"CONTRIBUTOR","body":"Well, I've made my case. If you think we need to worry about batch saves for orchestration templates in Amazon, then ok. Otherwise, I think my proposal is better."}}
{"actor":{"display_login":"djberg96"}}