{"action":"closed","number":195,"pull_request":{"url":"https://api.github.com/repos/Fotoapparat/Fotoapparat/pulls/195","id":165561871,"html_url":"https://github.com/Fotoapparat/Fotoapparat/pull/195","diff_url":"https://github.com/Fotoapparat/Fotoapparat/pull/195.diff","patch_url":"https://github.com/Fotoapparat/Fotoapparat/pull/195.patch","issue_url":"https://api.github.com/repos/Fotoapparat/Fotoapparat/issues/195","number":195,"state":"closed","locked":false,"title":"Invalidate cachedZoomParameters when updating configuration","user":{"login":"garnele007","id":9914734,"avatar_url":"https://avatars1.githubusercontent.com/u/9914734?v=4","gravatar_id":"","url":"https://api.github.com/users/garnele007","html_url":"https://github.com/garnele007","followers_url":"https://api.github.com/users/garnele007/followers","following_url":"https://api.github.com/users/garnele007/following{/other_user}","gists_url":"https://api.github.com/users/garnele007/gists{/gist_id}","starred_url":"https://api.github.com/users/garnele007/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garnele007/subscriptions","organizations_url":"https://api.github.com/users/garnele007/orgs","repos_url":"https://api.github.com/users/garnele007/repos","events_url":"https://api.github.com/users/garnele007/events{/privacy}","received_events_url":"https://api.github.com/users/garnele007/received_events","type":"User","site_admin":false},"body":"The cachedZoomParameters don't get invalidated when updating the configuration. That's why running this code:\r\n\r\n```\r\nfotoapparat.updateConfiguration(UpdateConfiguration(flashMode = torch()))\r\nfotoapparat.setZoom(0.5f)\r\n```\r\n\r\nresults in the torch being off. By clearing the cachedZoomParameters when calling `updateConfiguration()`, this piece of code results in the torch turned on (as intended).","created_at":"2018-01-28T11:05:07Z","updated_at":"2018-02-02T10:25:59Z","closed_at":"2018-02-02T10:25:59Z","merged_at":null,"merge_commit_sha":"a94630d259ac77bec2071b6f116720fe0de60fbc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/Fotoapparat/Fotoapparat/pulls/195/commits","review_comments_url":"https://api.github.com/repos/Fotoapparat/Fotoapparat/pulls/195/comments","review_comment_url":"https://api.github.com/repos/Fotoapparat/Fotoapparat/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Fotoapparat/Fotoapparat/issues/195/comments","statuses_url":"https://api.github.com/repos/Fotoapparat/Fotoapparat/statuses/6d9e9d61b7ed0b4b2e9f35749a789712ff079311","head":{"label":"garnele007:master","ref":"master","sha":"6d9e9d61b7ed0b4b2e9f35749a789712ff079311","user":{"login":"garnele007","id":9914734,"avatar_url":"https://avatars1.githubusercontent.com/u/9914734?v=4","gravatar_id":"","url":"https://api.github.com/users/garnele007","html_url":"https://github.com/garnele007","followers_url":"https://api.github.com/users/garnele007/followers","following_url":"https://api.github.com/users/garnele007/following{/other_user}","gists_url":"https://api.github.com/users/garnele007/gists{/gist_id}","starred_url":"https://api.github.com/users/garnele007/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garnele007/subscriptions","organizations_url":"https://api.github.com/users/garnele007/orgs","repos_url":"https://api.github.com/users/garnele007/repos","events_url":"https://api.github.com/users/garnele007/events{/privacy}","received_events_url":"https://api.github.com/users/garnele007/received_events","type":"User","site_admin":false},"repo":{"id":119208003,"name":"Fotoapparat","full_name":"garnele007/Fotoapparat","owner":{"login":"garnele007","id":9914734,"avatar_url":"https://avatars1.githubusercontent.com/u/9914734?v=4","gravatar_id":"","url":"https://api.github.com/users/garnele007","html_url":"https://github.com/garnele007","followers_url":"https://api.github.com/users/garnele007/followers","following_url":"https://api.github.com/users/garnele007/following{/other_user}","gists_url":"https://api.github.com/users/garnele007/gists{/gist_id}","starred_url":"https://api.github.com/users/garnele007/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garnele007/subscriptions","organizations_url":"https://api.github.com/users/garnele007/orgs","repos_url":"https://api.github.com/users/garnele007/repos","events_url":"https://api.github.com/users/garnele007/events{/privacy}","received_events_url":"https://api.github.com/users/garnele007/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/garnele007/Fotoapparat","description":"Making Camera for Android more friendly. 📸","fork":true,"url":"https://api.github.com/repos/garnele007/Fotoapparat","forks_url":"https://api.github.com/repos/garnele007/Fotoapparat/forks","keys_url":"https://api.github.com/repos/garnele007/Fotoapparat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/garnele007/Fotoapparat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/garnele007/Fotoapparat/teams","hooks_url":"https://api.github.com/repos/garnele007/Fotoapparat/hooks","issue_events_url":"https://api.github.com/repos/garnele007/Fotoapparat/issues/events{/number}","events_url":"https://api.github.com/repos/garnele007/Fotoapparat/events","assignees_url":"https://api.github.com/repos/garnele007/Fotoapparat/assignees{/user}","branches_url":"https://api.github.com/repos/garnele007/Fotoapparat/branches{/branch}","tags_url":"https://api.github.com/repos/garnele007/Fotoapparat/tags","blobs_url":"https://api.github.com/repos/garnele007/Fotoapparat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/garnele007/Fotoapparat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/garnele007/Fotoapparat/git/refs{/sha}","trees_url":"https://api.github.com/repos/garnele007/Fotoapparat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/garnele007/Fotoapparat/statuses/{sha}","languages_url":"https://api.github.com/repos/garnele007/Fotoapparat/languages","stargazers_url":"https://api.github.com/repos/garnele007/Fotoapparat/stargazers","contributors_url":"https://api.github.com/repos/garnele007/Fotoapparat/contributors","subscribers_url":"https://api.github.com/repos/garnele007/Fotoapparat/subscribers","subscription_url":"https://api.github.com/repos/garnele007/Fotoapparat/subscription","commits_url":"https://api.github.com/repos/garnele007/Fotoapparat/commits{/sha}","git_commits_url":"https://api.github.com/repos/garnele007/Fotoapparat/git/commits{/sha}","comments_url":"https://api.github.com/repos/garnele007/Fotoapparat/comments{/number}","issue_comment_url":"https://api.github.com/repos/garnele007/Fotoapparat/issues/comments{/number}","contents_url":"https://api.github.com/repos/garnele007/Fotoapparat/contents/{+path}","compare_url":"https://api.github.com/repos/garnele007/Fotoapparat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/garnele007/Fotoapparat/merges","archive_url":"https://api.github.com/repos/garnele007/Fotoapparat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/garnele007/Fotoapparat/downloads","issues_url":"https://api.github.com/repos/garnele007/Fotoapparat/issues{/number}","pulls_url":"https://api.github.com/repos/garnele007/Fotoapparat/pulls{/number}","milestones_url":"https://api.github.com/repos/garnele007/Fotoapparat/milestones{/number}","notifications_url":"https://api.github.com/repos/garnele007/Fotoapparat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/garnele007/Fotoapparat/labels{/name}","releases_url":"https://api.github.com/repos/garnele007/Fotoapparat/releases{/id}","deployments_url":"https://api.github.com/repos/garnele007/Fotoapparat/deployments","created_at":"2018-01-27T22:28:03Z","updated_at":"2018-01-27T22:28:05Z","pushed_at":"2018-01-27T22:41:33Z","git_url":"git://github.com/garnele007/Fotoapparat.git","ssh_url":"git@github.com:garnele007/Fotoapparat.git","clone_url":"https://github.com/garnele007/Fotoapparat.git","svn_url":"https://github.com/garnele007/Fotoapparat","homepage":"","size":1267,"stargazers_count":0,"watchers_count":0,"language":"Kotlin","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Fotoapparat:master","ref":"master","sha":"9a8bbb10214acabdd3b60db21e6a093045d38986","user":{"login":"Fotoapparat","id":26844652,"avatar_url":"https://avatars3.githubusercontent.com/u/26844652?v=4","gravatar_id":"","url":"https://api.github.com/users/Fotoapparat","html_url":"https://github.com/Fotoapparat","followers_url":"https://api.github.com/users/Fotoapparat/followers","following_url":"https://api.github.com/users/Fotoapparat/following{/other_user}","gists_url":"https://api.github.com/users/Fotoapparat/gists{/gist_id}","starred_url":"https://api.github.com/users/Fotoapparat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fotoapparat/subscriptions","organizations_url":"https://api.github.com/users/Fotoapparat/orgs","repos_url":"https://api.github.com/users/Fotoapparat/repos","events_url":"https://api.github.com/users/Fotoapparat/events{/privacy}","received_events_url":"https://api.github.com/users/Fotoapparat/received_events","type":"Organization","site_admin":false},"repo":{"id":85997051,"name":"Fotoapparat","full_name":"Fotoapparat/Fotoapparat","owner":{"login":"Fotoapparat","id":26844652,"avatar_url":"https://avatars3.githubusercontent.com/u/26844652?v=4","gravatar_id":"","url":"https://api.github.com/users/Fotoapparat","html_url":"https://github.com/Fotoapparat","followers_url":"https://api.github.com/users/Fotoapparat/followers","following_url":"https://api.github.com/users/Fotoapparat/following{/other_user}","gists_url":"https://api.github.com/users/Fotoapparat/gists{/gist_id}","starred_url":"https://api.github.com/users/Fotoapparat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fotoapparat/subscriptions","organizations_url":"https://api.github.com/users/Fotoapparat/orgs","repos_url":"https://api.github.com/users/Fotoapparat/repos","events_url":"https://api.github.com/users/Fotoapparat/events{/privacy}","received_events_url":"https://api.github.com/users/Fotoapparat/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Fotoapparat/Fotoapparat","description":"Making Camera for Android more friendly. 📸","fork":false,"url":"https://api.github.com/repos/Fotoapparat/Fotoapparat","forks_url":"https://api.github.com/repos/Fotoapparat/Fotoapparat/forks","keys_url":"https://api.github.com/repos/Fotoapparat/Fotoapparat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Fotoapparat/Fotoapparat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Fotoapparat/Fotoapparat/teams","hooks_url":"https://api.github.com/repos/Fotoapparat/Fotoapparat/hooks","issue_events_url":"https://api.github.com/repos/Fotoapparat/Fotoapparat/issues/events{/number}","events_url":"https://api.github.com/repos/Fotoapparat/Fotoapparat/events","assignees_url":"https://api.github.com/repos/Fotoapparat/Fotoapparat/assignees{/user}","branches_url":"https://api.github.com/repos/Fotoapparat/Fotoapparat/branches{/branch}","tags_url":"https://api.github.com/repos/Fotoapparat/Fotoapparat/tags","blobs_url":"https://api.github.com/repos/Fotoapparat/Fotoapparat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Fotoapparat/Fotoapparat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Fotoapparat/Fotoapparat/git/refs{/sha}","trees_url":"https://api.github.com/repos/Fotoapparat/Fotoapparat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Fotoapparat/Fotoapparat/statuses/{sha}","languages_url":"https://api.github.com/repos/Fotoapparat/Fotoapparat/languages","stargazers_url":"https://api.github.com/repos/Fotoapparat/Fotoapparat/stargazers","contributors_url":"https://api.github.com/repos/Fotoapparat/Fotoapparat/contributors","subscribers_url":"https://api.github.com/repos/Fotoapparat/Fotoapparat/subscribers","subscription_url":"https://api.github.com/repos/Fotoapparat/Fotoapparat/subscription","commits_url":"https://api.github.com/repos/Fotoapparat/Fotoapparat/commits{/sha}","git_commits_url":"https://api.github.com/repos/Fotoapparat/Fotoapparat/git/commits{/sha}","comments_url":"https://api.github.com/repos/Fotoapparat/Fotoapparat/comments{/number}","issue_comment_url":"https://api.github.com/repos/Fotoapparat/Fotoapparat/issues/comments{/number}","contents_url":"https://api.github.com/repos/Fotoapparat/Fotoapparat/contents/{+path}","compare_url":"https://api.github.com/repos/Fotoapparat/Fotoapparat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Fotoapparat/Fotoapparat/merges","archive_url":"https://api.github.com/repos/Fotoapparat/Fotoapparat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Fotoapparat/Fotoapparat/downloads","issues_url":"https://api.github.com/repos/Fotoapparat/Fotoapparat/issues{/number}","pulls_url":"https://api.github.com/repos/Fotoapparat/Fotoapparat/pulls{/number}","milestones_url":"https://api.github.com/repos/Fotoapparat/Fotoapparat/milestones{/number}","notifications_url":"https://api.github.com/repos/Fotoapparat/Fotoapparat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Fotoapparat/Fotoapparat/labels{/name}","releases_url":"https://api.github.com/repos/Fotoapparat/Fotoapparat/releases{/id}","deployments_url":"https://api.github.com/repos/Fotoapparat/Fotoapparat/deployments","created_at":"2017-03-23T20:59:37Z","updated_at":"2018-02-02T09:46:29Z","pushed_at":"2018-02-02T10:25:49Z","git_url":"git://github.com/Fotoapparat/Fotoapparat.git","ssh_url":"git@github.com:Fotoapparat/Fotoapparat.git","clone_url":"https://github.com/Fotoapparat/Fotoapparat.git","svn_url":"https://github.com/Fotoapparat/Fotoapparat","homepage":"","size":1265,"stargazers_count":2350,"watchers_count":2350,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":208,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":208,"open_issues":11,"watchers":2350,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Fotoapparat/Fotoapparat/pulls/195"},"html":{"href":"https://github.com/Fotoapparat/Fotoapparat/pull/195"},"issue":{"href":"https://api.github.com/repos/Fotoapparat/Fotoapparat/issues/195"},"comments":{"href":"https://api.github.com/repos/Fotoapparat/Fotoapparat/issues/195/comments"},"review_comments":{"href":"https://api.github.com/repos/Fotoapparat/Fotoapparat/pulls/195/comments"},"review_comment":{"href":"https://api.github.com/repos/Fotoapparat/Fotoapparat/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Fotoapparat/Fotoapparat/pulls/195/commits"},"statuses":{"href":"https://api.github.com/repos/Fotoapparat/Fotoapparat/statuses/6d9e9d61b7ed0b4b2e9f35749a789712ff079311"}},"author_association":"NONE","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":7,"deletions":1,"changed_files":2}}
{"actor":{"display_login":"Diolor"}}