{"action":"created","comment":{"url":"https://api.github.com/repos/gpii-ops/gpii-infra/pulls/comments/189152353","pull_request_review_id":121276863,"id":189152353,"diff_hunk":"@@ -0,0 +1,24 @@\n+# Default values for gpii-preferences.\n+# This is a YAML-formatted file.\n+# Declare variables to be passed into your templates.\n+\n+replicaCount: 1\n+\n+svc_listen_port: 80\n+preferences_listen_port: 8081\n+node_env: gpii.config.preferencesServer.standalone.production\n+\n+image:\n+  repository: gpii/universal\n+  checksum: sha256:57d0a17da505c8bc28c221c88b8de54447c78dc873c355d0bfd435d28f8b09ee\n+  pullPolicy: IfNotPresent\n+\n+issuerRef:\n+  name: letsencrypt-production\n+\n+dnsNames:\n+- preferences.stg.gpii.net","path":"aws/modules/deploy/helms/gpii-preferences/values.yaml","position":20,"original_position":20,"commit_id":"7dfb04e983e24d877263e602da44d9c04ba708ae","original_commit_id":"7dfb04e983e24d877263e602da44d9c04ba708ae","user":{"login":"natarajaya","id":917560,"avatar_url":"https://avatars1.githubusercontent.com/u/917560?v=4","gravatar_id":"","url":"https://api.github.com/users/natarajaya","html_url":"https://github.com/natarajaya","followers_url":"https://api.github.com/users/natarajaya/followers","following_url":"https://api.github.com/users/natarajaya/following{/other_user}","gists_url":"https://api.github.com/users/natarajaya/gists{/gist_id}","starred_url":"https://api.github.com/users/natarajaya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natarajaya/subscriptions","organizations_url":"https://api.github.com/users/natarajaya/orgs","repos_url":"https://api.github.com/users/natarajaya/repos","events_url":"https://api.github.com/users/natarajaya/events{/privacy}","received_events_url":"https://api.github.com/users/natarajaya/received_events","type":"User","site_admin":false},"body":"What default value should go here instead?","created_at":"2018-05-18T02:53:22Z","updated_at":"2018-05-18T02:53:22Z","html_url":"https://github.com/gpii-ops/gpii-infra/pull/26#discussion_r189152353","pull_request_url":"https://api.github.com/repos/gpii-ops/gpii-infra/pulls/26","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/gpii-ops/gpii-infra/pulls/comments/189152353"},"html":{"href":"https://github.com/gpii-ops/gpii-infra/pull/26#discussion_r189152353"},"pull_request":{"href":"https://api.github.com/repos/gpii-ops/gpii-infra/pulls/26"}},"in_reply_to_id":188304059},"pull_request":{"url":"https://api.github.com/repos/gpii-ops/gpii-infra/pulls/26","id":188006128,"html_url":"https://github.com/gpii-ops/gpii-infra/pull/26","diff_url":"https://github.com/gpii-ops/gpii-infra/pull/26.diff","patch_url":"https://github.com/gpii-ops/gpii-infra/pull/26.patch","issue_url":"https://api.github.com/repos/gpii-ops/gpii-infra/issues/26","number":26,"state":"open","locked":false,"title":" GPII-2958: Helm chart for preferences service","user":{"login":"natarajaya","id":917560,"avatar_url":"https://avatars1.githubusercontent.com/u/917560?v=4","gravatar_id":"","url":"https://api.github.com/users/natarajaya","html_url":"https://github.com/natarajaya","followers_url":"https://api.github.com/users/natarajaya/followers","following_url":"https://api.github.com/users/natarajaya/following{/other_user}","gists_url":"https://api.github.com/users/natarajaya/gists{/gist_id}","starred_url":"https://api.github.com/users/natarajaya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natarajaya/subscriptions","organizations_url":"https://api.github.com/users/natarajaya/orgs","repos_url":"https://api.github.com/users/natarajaya/repos","events_url":"https://api.github.com/users/natarajaya/events{/privacy}","received_events_url":"https://api.github.com/users/natarajaya/received_events","type":"User","site_admin":false},"body":"This is not ready to be merged yet.\r\nWhile this works correctly with manual install – there are couple open issues:\r\n* Chart dependencies and install order\r\n* Rolling deployments and app version updates","created_at":"2018-05-15T03:41:43Z","updated_at":"2018-05-18T02:53:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7f499e0b749e3bb8f48ef3d518b9aab544ca8b58","assignee":{"login":"natarajaya","id":917560,"avatar_url":"https://avatars1.githubusercontent.com/u/917560?v=4","gravatar_id":"","url":"https://api.github.com/users/natarajaya","html_url":"https://github.com/natarajaya","followers_url":"https://api.github.com/users/natarajaya/followers","following_url":"https://api.github.com/users/natarajaya/following{/other_user}","gists_url":"https://api.github.com/users/natarajaya/gists{/gist_id}","starred_url":"https://api.github.com/users/natarajaya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natarajaya/subscriptions","organizations_url":"https://api.github.com/users/natarajaya/orgs","repos_url":"https://api.github.com/users/natarajaya/repos","events_url":"https://api.github.com/users/natarajaya/events{/privacy}","received_events_url":"https://api.github.com/users/natarajaya/received_events","type":"User","site_admin":false},"assignees":[{"login":"natarajaya","id":917560,"avatar_url":"https://avatars1.githubusercontent.com/u/917560?v=4","gravatar_id":"","url":"https://api.github.com/users/natarajaya","html_url":"https://github.com/natarajaya","followers_url":"https://api.github.com/users/natarajaya/followers","following_url":"https://api.github.com/users/natarajaya/following{/other_user}","gists_url":"https://api.github.com/users/natarajaya/gists{/gist_id}","starred_url":"https://api.github.com/users/natarajaya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natarajaya/subscriptions","organizations_url":"https://api.github.com/users/natarajaya/orgs","repos_url":"https://api.github.com/users/natarajaya/repos","events_url":"https://api.github.com/users/natarajaya/events{/privacy}","received_events_url":"https://api.github.com/users/natarajaya/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"amatas","id":158641,"avatar_url":"https://avatars3.githubusercontent.com/u/158641?v=4","gravatar_id":"","url":"https://api.github.com/users/amatas","html_url":"https://github.com/amatas","followers_url":"https://api.github.com/users/amatas/followers","following_url":"https://api.github.com/users/amatas/following{/other_user}","gists_url":"https://api.github.com/users/amatas/gists{/gist_id}","starred_url":"https://api.github.com/users/amatas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amatas/subscriptions","organizations_url":"https://api.github.com/users/amatas/orgs","repos_url":"https://api.github.com/users/amatas/repos","events_url":"https://api.github.com/users/amatas/events{/privacy}","received_events_url":"https://api.github.com/users/amatas/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/gpii-ops/gpii-infra/pulls/26/commits","review_comments_url":"https://api.github.com/repos/gpii-ops/gpii-infra/pulls/26/comments","review_comment_url":"https://api.github.com/repos/gpii-ops/gpii-infra/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gpii-ops/gpii-infra/issues/26/comments","statuses_url":"https://api.github.com/repos/gpii-ops/gpii-infra/statuses/7dfb04e983e24d877263e602da44d9c04ba708ae","head":{"label":"natarajaya:master","ref":"master","sha":"7dfb04e983e24d877263e602da44d9c04ba708ae","user":{"login":"natarajaya","id":917560,"avatar_url":"https://avatars1.githubusercontent.com/u/917560?v=4","gravatar_id":"","url":"https://api.github.com/users/natarajaya","html_url":"https://github.com/natarajaya","followers_url":"https://api.github.com/users/natarajaya/followers","following_url":"https://api.github.com/users/natarajaya/following{/other_user}","gists_url":"https://api.github.com/users/natarajaya/gists{/gist_id}","starred_url":"https://api.github.com/users/natarajaya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natarajaya/subscriptions","organizations_url":"https://api.github.com/users/natarajaya/orgs","repos_url":"https://api.github.com/users/natarajaya/repos","events_url":"https://api.github.com/users/natarajaya/events{/privacy}","received_events_url":"https://api.github.com/users/natarajaya/received_events","type":"User","site_admin":false},"repo":{"id":130919780,"name":"gpii-infra","full_name":"natarajaya/gpii-infra","owner":{"login":"natarajaya","id":917560,"avatar_url":"https://avatars1.githubusercontent.com/u/917560?v=4","gravatar_id":"","url":"https://api.github.com/users/natarajaya","html_url":"https://github.com/natarajaya","followers_url":"https://api.github.com/users/natarajaya/followers","following_url":"https://api.github.com/users/natarajaya/following{/other_user}","gists_url":"https://api.github.com/users/natarajaya/gists{/gist_id}","starred_url":"https://api.github.com/users/natarajaya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natarajaya/subscriptions","organizations_url":"https://api.github.com/users/natarajaya/orgs","repos_url":"https://api.github.com/users/natarajaya/repos","events_url":"https://api.github.com/users/natarajaya/events{/privacy}","received_events_url":"https://api.github.com/users/natarajaya/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/natarajaya/gpii-infra","description":null,"fork":true,"url":"https://api.github.com/repos/natarajaya/gpii-infra","forks_url":"https://api.github.com/repos/natarajaya/gpii-infra/forks","keys_url":"https://api.github.com/repos/natarajaya/gpii-infra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/natarajaya/gpii-infra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/natarajaya/gpii-infra/teams","hooks_url":"https://api.github.com/repos/natarajaya/gpii-infra/hooks","issue_events_url":"https://api.github.com/repos/natarajaya/gpii-infra/issues/events{/number}","events_url":"https://api.github.com/repos/natarajaya/gpii-infra/events","assignees_url":"https://api.github.com/repos/natarajaya/gpii-infra/assignees{/user}","branches_url":"https://api.github.com/repos/natarajaya/gpii-infra/branches{/branch}","tags_url":"https://api.github.com/repos/natarajaya/gpii-infra/tags","blobs_url":"https://api.github.com/repos/natarajaya/gpii-infra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/natarajaya/gpii-infra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/natarajaya/gpii-infra/git/refs{/sha}","trees_url":"https://api.github.com/repos/natarajaya/gpii-infra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/natarajaya/gpii-infra/statuses/{sha}","languages_url":"https://api.github.com/repos/natarajaya/gpii-infra/languages","stargazers_url":"https://api.github.com/repos/natarajaya/gpii-infra/stargazers","contributors_url":"https://api.github.com/repos/natarajaya/gpii-infra/contributors","subscribers_url":"https://api.github.com/repos/natarajaya/gpii-infra/subscribers","subscription_url":"https://api.github.com/repos/natarajaya/gpii-infra/subscription","commits_url":"https://api.github.com/repos/natarajaya/gpii-infra/commits{/sha}","git_commits_url":"https://api.github.com/repos/natarajaya/gpii-infra/git/commits{/sha}","comments_url":"https://api.github.com/repos/natarajaya/gpii-infra/comments{/number}","issue_comment_url":"https://api.github.com/repos/natarajaya/gpii-infra/issues/comments{/number}","contents_url":"https://api.github.com/repos/natarajaya/gpii-infra/contents/{+path}","compare_url":"https://api.github.com/repos/natarajaya/gpii-infra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/natarajaya/gpii-infra/merges","archive_url":"https://api.github.com/repos/natarajaya/gpii-infra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/natarajaya/gpii-infra/downloads","issues_url":"https://api.github.com/repos/natarajaya/gpii-infra/issues{/number}","pulls_url":"https://api.github.com/repos/natarajaya/gpii-infra/pulls{/number}","milestones_url":"https://api.github.com/repos/natarajaya/gpii-infra/milestones{/number}","notifications_url":"https://api.github.com/repos/natarajaya/gpii-infra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/natarajaya/gpii-infra/labels{/name}","releases_url":"https://api.github.com/repos/natarajaya/gpii-infra/releases{/id}","deployments_url":"https://api.github.com/repos/natarajaya/gpii-infra/deployments","created_at":"2018-04-24T22:17:14Z","updated_at":"2018-05-15T03:02:46Z","pushed_at":"2018-05-16T01:13:46Z","git_url":"git://github.com/natarajaya/gpii-infra.git","ssh_url":"git@github.com:natarajaya/gpii-infra.git","clone_url":"https://github.com/natarajaya/gpii-infra.git","svn_url":"https://github.com/natarajaya/gpii-infra","homepage":null,"size":468,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gpii-ops:master","ref":"master","sha":"66705872dc09236a881639df7976e2db36fb0e7e","user":{"login":"gpii-ops","id":10503302,"avatar_url":"https://avatars1.githubusercontent.com/u/10503302?v=4","gravatar_id":"","url":"https://api.github.com/users/gpii-ops","html_url":"https://github.com/gpii-ops","followers_url":"https://api.github.com/users/gpii-ops/followers","following_url":"https://api.github.com/users/gpii-ops/following{/other_user}","gists_url":"https://api.github.com/users/gpii-ops/gists{/gist_id}","starred_url":"https://api.github.com/users/gpii-ops/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gpii-ops/subscriptions","organizations_url":"https://api.github.com/users/gpii-ops/orgs","repos_url":"https://api.github.com/users/gpii-ops/repos","events_url":"https://api.github.com/users/gpii-ops/events{/privacy}","received_events_url":"https://api.github.com/users/gpii-ops/received_events","type":"Organization","site_admin":false},"repo":{"id":97767979,"name":"gpii-infra","full_name":"gpii-ops/gpii-infra","owner":{"login":"gpii-ops","id":10503302,"avatar_url":"https://avatars1.githubusercontent.com/u/10503302?v=4","gravatar_id":"","url":"https://api.github.com/users/gpii-ops","html_url":"https://github.com/gpii-ops","followers_url":"https://api.github.com/users/gpii-ops/followers","following_url":"https://api.github.com/users/gpii-ops/following{/other_user}","gists_url":"https://api.github.com/users/gpii-ops/gists{/gist_id}","starred_url":"https://api.github.com/users/gpii-ops/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gpii-ops/subscriptions","organizations_url":"https://api.github.com/users/gpii-ops/orgs","repos_url":"https://api.github.com/users/gpii-ops/repos","events_url":"https://api.github.com/users/gpii-ops/events{/privacy}","received_events_url":"https://api.github.com/users/gpii-ops/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gpii-ops/gpii-infra","description":null,"fork":true,"url":"https://api.github.com/repos/gpii-ops/gpii-infra","forks_url":"https://api.github.com/repos/gpii-ops/gpii-infra/forks","keys_url":"https://api.github.com/repos/gpii-ops/gpii-infra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gpii-ops/gpii-infra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gpii-ops/gpii-infra/teams","hooks_url":"https://api.github.com/repos/gpii-ops/gpii-infra/hooks","issue_events_url":"https://api.github.com/repos/gpii-ops/gpii-infra/issues/events{/number}","events_url":"https://api.github.com/repos/gpii-ops/gpii-infra/events","assignees_url":"https://api.github.com/repos/gpii-ops/gpii-infra/assignees{/user}","branches_url":"https://api.github.com/repos/gpii-ops/gpii-infra/branches{/branch}","tags_url":"https://api.github.com/repos/gpii-ops/gpii-infra/tags","blobs_url":"https://api.github.com/repos/gpii-ops/gpii-infra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gpii-ops/gpii-infra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gpii-ops/gpii-infra/git/refs{/sha}","trees_url":"https://api.github.com/repos/gpii-ops/gpii-infra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gpii-ops/gpii-infra/statuses/{sha}","languages_url":"https://api.github.com/repos/gpii-ops/gpii-infra/languages","stargazers_url":"https://api.github.com/repos/gpii-ops/gpii-infra/stargazers","contributors_url":"https://api.github.com/repos/gpii-ops/gpii-infra/contributors","subscribers_url":"https://api.github.com/repos/gpii-ops/gpii-infra/subscribers","subscription_url":"https://api.github.com/repos/gpii-ops/gpii-infra/subscription","commits_url":"https://api.github.com/repos/gpii-ops/gpii-infra/commits{/sha}","git_commits_url":"https://api.github.com/repos/gpii-ops/gpii-infra/git/commits{/sha}","comments_url":"https://api.github.com/repos/gpii-ops/gpii-infra/comments{/number}","issue_comment_url":"https://api.github.com/repos/gpii-ops/gpii-infra/issues/comments{/number}","contents_url":"https://api.github.com/repos/gpii-ops/gpii-infra/contents/{+path}","compare_url":"https://api.github.com/repos/gpii-ops/gpii-infra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gpii-ops/gpii-infra/merges","archive_url":"https://api.github.com/repos/gpii-ops/gpii-infra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gpii-ops/gpii-infra/downloads","issues_url":"https://api.github.com/repos/gpii-ops/gpii-infra/issues{/number}","pulls_url":"https://api.github.com/repos/gpii-ops/gpii-infra/pulls{/number}","milestones_url":"https://api.github.com/repos/gpii-ops/gpii-infra/milestones{/number}","notifications_url":"https://api.github.com/repos/gpii-ops/gpii-infra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gpii-ops/gpii-infra/labels{/name}","releases_url":"https://api.github.com/repos/gpii-ops/gpii-infra/releases{/id}","deployments_url":"https://api.github.com/repos/gpii-ops/gpii-infra/deployments","created_at":"2017-07-19T22:54:03Z","updated_at":"2018-05-18T02:23:44Z","pushed_at":"2018-05-18T02:47:37Z","git_url":"git://github.com/gpii-ops/gpii-infra.git","ssh_url":"git@github.com:gpii-ops/gpii-infra.git","clone_url":"https://github.com/gpii-ops/gpii-infra.git","svn_url":"https://github.com/gpii-ops/gpii-infra","homepage":null,"size":487,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":5,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gpii-ops/gpii-infra/pulls/26"},"html":{"href":"https://github.com/gpii-ops/gpii-infra/pull/26"},"issue":{"href":"https://api.github.com/repos/gpii-ops/gpii-infra/issues/26"},"comments":{"href":"https://api.github.com/repos/gpii-ops/gpii-infra/issues/26/comments"},"review_comments":{"href":"https://api.github.com/repos/gpii-ops/gpii-infra/pulls/26/comments"},"review_comment":{"href":"https://api.github.com/repos/gpii-ops/gpii-infra/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gpii-ops/gpii-infra/pulls/26/commits"},"statuses":{"href":"https://api.github.com/repos/gpii-ops/gpii-infra/statuses/7dfb04e983e24d877263e602da44d9c04ba708ae"}},"author_association":"NONE"}}
{"actor":{"display_login":"natarajaya"}}