{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/201287351","pull_request_review_id":135756580,"id":201287351,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTI4NzM1MQ==","diff_hunk":"@@ -1493,53 +1496,71 @@ func (proxier *Proxier) syncEndpoint(svcPortName proxy.ServicePortName, onlyNode\n \t\tnewEndpoints.Insert(epInfo.String())\n \t}\n \n-\tif !curEndpoints.Equal(newEndpoints) {\n-\t\t// Create new endpoints\n-\t\tfor _, ep := range newEndpoints.Difference(curEndpoints).UnsortedList() {\n-\t\t\tip, port, err := net.SplitHostPort(ep)\n-\t\t\tif err != nil {\n-\t\t\t\tglog.Errorf(\"Failed to parse endpoint: %v, error: %v\", ep, err)\n+\t// Create new endpoints\n+\tfor _, ep := range newEndpoints.List() {\n+\t\tif curEndpoints.Has(ep) {\n+\t\t\t// check if newEndpoint is in gracefulDelete list, is true, delete this ep immediately\n+\t\t\tuniqueRS := vs.String() + \"/\" + ep\n+\t\t\tif !proxier.gracefuldeleteManager.RSInGracefulDelete(uniqueRS) {\n \t\t\t\tcontinue\n \t\t\t}\n-\t\t\tportNum, err := strconv.Atoi(port)\n+\t\t\tglog.V(5).Infof(\"new ep %q is in graceful delete list\", uniqueRS)\n+\t\t\terr := proxier.gracefuldeleteManager.DeleteRsImmediately(uniqueRS)","path":"pkg/proxy/ipvs/proxier.go","position":108,"original_position":108,"commit_id":"ae44178e961f47984a03fb3eda9125fa6512132e","original_commit_id":"ae44178e961f47984a03fb3eda9125fa6512132e","user":{"login":"jsravn","id":522123,"node_id":"MDQ6VXNlcjUyMjEyMw==","avatar_url":"https://avatars3.githubusercontent.com/u/522123?v=4","gravatar_id":"","url":"https://api.github.com/users/jsravn","html_url":"https://github.com/jsravn","followers_url":"https://api.github.com/users/jsravn/followers","following_url":"https://api.github.com/users/jsravn/following{/other_user}","gists_url":"https://api.github.com/users/jsravn/gists{/gist_id}","starred_url":"https://api.github.com/users/jsravn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsravn/subscriptions","organizations_url":"https://api.github.com/users/jsravn/orgs","repos_url":"https://api.github.com/users/jsravn/repos","events_url":"https://api.github.com/users/jsravn/events{/privacy}","received_events_url":"https://api.github.com/users/jsravn/received_events","type":"User","site_admin":false},"body":"Won't this drop existing connections if an endpoint is flapping? For example, if a pod is under load and goes NotReady temporarily. I don't think we want to drop connections in this case. It should just remove it from the queue rather than deleting the real server.","created_at":"2018-07-10T10:07:51Z","updated_at":"2018-07-10T10:07:51Z","html_url":"https://github.com/kubernetes/kubernetes/pull/66012#discussion_r201287351","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/66012","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/201287351"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/66012#discussion_r201287351"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/66012"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/66012","id":200279983,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwMjc5OTgz","html_url":"https://github.com/kubernetes/kubernetes/pull/66012","diff_url":"https://github.com/kubernetes/kubernetes/pull/66012.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/66012.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/66012","number":66012,"state":"open","locked":false,"title":"[wip]ipvs support graceful termination","user":{"login":"Lion-Wei","id":28696384,"node_id":"MDQ6VXNlcjI4Njk2Mzg0","avatar_url":"https://avatars1.githubusercontent.com/u/28696384?v=4","gravatar_id":"","url":"https://api.github.com/users/Lion-Wei","html_url":"https://github.com/Lion-Wei","followers_url":"https://api.github.com/users/Lion-Wei/followers","following_url":"https://api.github.com/users/Lion-Wei/following{/other_user}","gists_url":"https://api.github.com/users/Lion-Wei/gists{/gist_id}","starred_url":"https://api.github.com/users/Lion-Wei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lion-Wei/subscriptions","organizations_url":"https://api.github.com/users/Lion-Wei/orgs","repos_url":"https://api.github.com/users/Lion-Wei/repos","events_url":"https://api.github.com/users/Lion-Wei/events{/privacy}","received_events_url":"https://api.github.com/users/Lion-Wei/received_events","type":"User","site_admin":false},"body":"\r\n**What this PR does / why we need it**:\r\nAdd a timed queue to handle ipvs graceful delete.\r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nFixes #57841\r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Release note**:\r\n```release-note\r\nIPVS proxier mode now support graceful termination.\r\n```\r\n","created_at":"2018-07-10T04:27:25Z","updated_at":"2018-07-10T10:07:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"299a5e4c67e364ebe413235e5d98d20ed5e82d41","assignee":{"login":"m1093782566","id":4953962,"node_id":"MDQ6VXNlcjQ5NTM5NjI=","avatar_url":"https://avatars1.githubusercontent.com/u/4953962?v=4","gravatar_id":"","url":"https://api.github.com/users/m1093782566","html_url":"https://github.com/m1093782566","followers_url":"https://api.github.com/users/m1093782566/followers","following_url":"https://api.github.com/users/m1093782566/following{/other_user}","gists_url":"https://api.github.com/users/m1093782566/gists{/gist_id}","starred_url":"https://api.github.com/users/m1093782566/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m1093782566/subscriptions","organizations_url":"https://api.github.com/users/m1093782566/orgs","repos_url":"https://api.github.com/users/m1093782566/repos","events_url":"https://api.github.com/users/m1093782566/events{/privacy}","received_events_url":"https://api.github.com/users/m1093782566/received_events","type":"User","site_admin":false},"assignees":[{"login":"m1093782566","id":4953962,"node_id":"MDQ6VXNlcjQ5NTM5NjI=","avatar_url":"https://avatars1.githubusercontent.com/u/4953962?v=4","gravatar_id":"","url":"https://api.github.com/users/m1093782566","html_url":"https://github.com/m1093782566","followers_url":"https://api.github.com/users/m1093782566/followers","following_url":"https://api.github.com/users/m1093782566/following{/other_user}","gists_url":"https://api.github.com/users/m1093782566/gists{/gist_id}","starred_url":"https://api.github.com/users/m1093782566/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m1093782566/subscriptions","organizations_url":"https://api.github.com/users/m1093782566/orgs","repos_url":"https://api.github.com/users/m1093782566/repos","events_url":"https://api.github.com/users/m1093782566/events{/privacy}","received_events_url":"https://api.github.com/users/m1093782566/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"jhorwit2","id":3876739,"node_id":"MDQ6VXNlcjM4NzY3Mzk=","avatar_url":"https://avatars1.githubusercontent.com/u/3876739?v=4","gravatar_id":"","url":"https://api.github.com/users/jhorwit2","html_url":"https://github.com/jhorwit2","followers_url":"https://api.github.com/users/jhorwit2/followers","following_url":"https://api.github.com/users/jhorwit2/following{/other_user}","gists_url":"https://api.github.com/users/jhorwit2/gists{/gist_id}","starred_url":"https://api.github.com/users/jhorwit2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhorwit2/subscriptions","organizations_url":"https://api.github.com/users/jhorwit2/orgs","repos_url":"https://api.github.com/users/jhorwit2/repos","events_url":"https://api.github.com/users/jhorwit2/events{/privacy}","received_events_url":"https://api.github.com/users/jhorwit2/received_events","type":"User","site_admin":false},{"login":"thockin","id":5595220,"node_id":"MDQ6VXNlcjU1OTUyMjA=","avatar_url":"https://avatars0.githubusercontent.com/u/5595220?v=4","gravatar_id":"","url":"https://api.github.com/users/thockin","html_url":"https://github.com/thockin","followers_url":"https://api.github.com/users/thockin/followers","following_url":"https://api.github.com/users/thockin/following{/other_user}","gists_url":"https://api.github.com/users/thockin/gists{/gist_id}","starred_url":"https://api.github.com/users/thockin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thockin/subscriptions","organizations_url":"https://api.github.com/users/thockin/orgs","repos_url":"https://api.github.com/users/thockin/repos","events_url":"https://api.github.com/users/thockin/events{/privacy}","received_events_url":"https://api.github.com/users/thockin/received_events","type":"User","site_admin":false},{"login":"brendandburns","id":5751682,"node_id":"MDQ6VXNlcjU3NTE2ODI=","avatar_url":"https://avatars2.githubusercontent.com/u/5751682?v=4","gravatar_id":"","url":"https://api.github.com/users/brendandburns","html_url":"https://github.com/brendandburns","followers_url":"https://api.github.com/users/brendandburns/followers","following_url":"https://api.github.com/users/brendandburns/following{/other_user}","gists_url":"https://api.github.com/users/brendandburns/gists{/gist_id}","starred_url":"https://api.github.com/users/brendandburns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brendandburns/subscriptions","organizations_url":"https://api.github.com/users/brendandburns/orgs","repos_url":"https://api.github.com/users/brendandburns/repos","events_url":"https://api.github.com/users/brendandburns/events{/privacy}","received_events_url":"https://api.github.com/users/brendandburns/received_events","type":"User","site_admin":false},{"login":"rramkumar1","id":20979322,"node_id":"MDQ6VXNlcjIwOTc5MzIy","avatar_url":"https://avatars1.githubusercontent.com/u/20979322?v=4","gravatar_id":"","url":"https://api.github.com/users/rramkumar1","html_url":"https://github.com/rramkumar1","followers_url":"https://api.github.com/users/rramkumar1/followers","following_url":"https://api.github.com/users/rramkumar1/following{/other_user}","gists_url":"https://api.github.com/users/rramkumar1/gists{/gist_id}","starred_url":"https://api.github.com/users/rramkumar1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rramkumar1/subscriptions","organizations_url":"https://api.github.com/users/rramkumar1/orgs","repos_url":"https://api.github.com/users/rramkumar1/repos","events_url":"https://api.github.com/users/rramkumar1/events{/privacy}","received_events_url":"https://api.github.com/users/rramkumar1/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":477397086,"node_id":"MDU6TGFiZWw0NzczOTcwODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":687500047,"node_id":"MDU6TGFiZWw2ODc1MDAwNDc=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/do-not-merge/work-in-progress","name":"do-not-merge/work-in-progress","color":"e11d21","default":false},{"id":200149833,"node_id":"MDU6TGFiZWwyMDAxNDk4MzM=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note","name":"release-note","color":"c2e0c6","default":false},{"id":253450978,"node_id":"MDU6TGFiZWwyNTM0NTA5Nzg=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/L","name":"size/L","color":"ee9900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/66012/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/66012/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/66012/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/ae44178e961f47984a03fb3eda9125fa6512132e","head":{"label":"Lion-Wei:ipvs-graceful-termination","ref":"ipvs-graceful-termination","sha":"ae44178e961f47984a03fb3eda9125fa6512132e","user":{"login":"Lion-Wei","id":28696384,"node_id":"MDQ6VXNlcjI4Njk2Mzg0","avatar_url":"https://avatars1.githubusercontent.com/u/28696384?v=4","gravatar_id":"","url":"https://api.github.com/users/Lion-Wei","html_url":"https://github.com/Lion-Wei","followers_url":"https://api.github.com/users/Lion-Wei/followers","following_url":"https://api.github.com/users/Lion-Wei/following{/other_user}","gists_url":"https://api.github.com/users/Lion-Wei/gists{/gist_id}","starred_url":"https://api.github.com/users/Lion-Wei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lion-Wei/subscriptions","organizations_url":"https://api.github.com/users/Lion-Wei/orgs","repos_url":"https://api.github.com/users/Lion-Wei/repos","events_url":"https://api.github.com/users/Lion-Wei/events{/privacy}","received_events_url":"https://api.github.com/users/Lion-Wei/received_events","type":"User","site_admin":false},"repo":{"id":99405496,"node_id":"MDEwOlJlcG9zaXRvcnk5OTQwNTQ5Ng==","name":"kubernetes","full_name":"Lion-Wei/kubernetes","owner":{"login":"Lion-Wei","id":28696384,"node_id":"MDQ6VXNlcjI4Njk2Mzg0","avatar_url":"https://avatars1.githubusercontent.com/u/28696384?v=4","gravatar_id":"","url":"https://api.github.com/users/Lion-Wei","html_url":"https://github.com/Lion-Wei","followers_url":"https://api.github.com/users/Lion-Wei/followers","following_url":"https://api.github.com/users/Lion-Wei/following{/other_user}","gists_url":"https://api.github.com/users/Lion-Wei/gists{/gist_id}","starred_url":"https://api.github.com/users/Lion-Wei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lion-Wei/subscriptions","organizations_url":"https://api.github.com/users/Lion-Wei/orgs","repos_url":"https://api.github.com/users/Lion-Wei/repos","events_url":"https://api.github.com/users/Lion-Wei/events{/privacy}","received_events_url":"https://api.github.com/users/Lion-Wei/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Lion-Wei/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/Lion-Wei/kubernetes","forks_url":"https://api.github.com/repos/Lion-Wei/kubernetes/forks","keys_url":"https://api.github.com/repos/Lion-Wei/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Lion-Wei/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Lion-Wei/kubernetes/teams","hooks_url":"https://api.github.com/repos/Lion-Wei/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/Lion-Wei/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/Lion-Wei/kubernetes/events","assignees_url":"https://api.github.com/repos/Lion-Wei/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/Lion-Wei/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/Lion-Wei/kubernetes/tags","blobs_url":"https://api.github.com/repos/Lion-Wei/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Lion-Wei/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Lion-Wei/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/Lion-Wei/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Lion-Wei/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/Lion-Wei/kubernetes/languages","stargazers_url":"https://api.github.com/repos/Lion-Wei/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/Lion-Wei/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/Lion-Wei/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/Lion-Wei/kubernetes/subscription","commits_url":"https://api.github.com/repos/Lion-Wei/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/Lion-Wei/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/Lion-Wei/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/Lion-Wei/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/Lion-Wei/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/Lion-Wei/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Lion-Wei/kubernetes/merges","archive_url":"https://api.github.com/repos/Lion-Wei/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Lion-Wei/kubernetes/downloads","issues_url":"https://api.github.com/repos/Lion-Wei/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/Lion-Wei/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/Lion-Wei/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/Lion-Wei/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Lion-Wei/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/Lion-Wei/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/Lion-Wei/kubernetes/deployments","created_at":"2017-08-05T07:00:07Z","updated_at":"2018-07-06T03:32:44Z","pushed_at":"2018-07-10T06:15:40Z","git_url":"git://github.com/Lion-Wei/kubernetes.git","ssh_url":"git@github.com:Lion-Wei/kubernetes.git","clone_url":"https://github.com/Lion-Wei/kubernetes.git","svn_url":"https://github.com/Lion-Wei/kubernetes","homepage":"http://kubernetes.io","size":563233,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"0ff24a29c0349f2ea117d4fb1b35d2af636a95d8","user":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"node_id":"MDEwOlJlcG9zaXRvcnkyMDU4MDQ5OA==","name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2018-07-10T10:00:37Z","pushed_at":"2018-07-10T09:57:10Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":791830,"stargazers_count":38544,"watchers_count":38544,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13481,"mirror_url":null,"archived":false,"open_issues_count":3086,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":13481,"open_issues":3086,"watchers":38544,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/66012"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/66012"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/66012"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/66012/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/66012/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/66012/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/ae44178e961f47984a03fb3eda9125fa6512132e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jsravn"}}