{"action":"opened","number":503,"pull_request":{"url":"https://api.github.com/repos/apache/lucene-solr/pulls/503","id":232592637,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyNTkyNjM3","html_url":"https://github.com/apache/lucene-solr/pull/503","diff_url":"https://github.com/apache/lucene-solr/pull/503.diff","patch_url":"https://github.com/apache/lucene-solr/pull/503.patch","issue_url":"https://api.github.com/repos/apache/lucene-solr/issues/503","number":503,"state":"open","locked":false,"title":"LUCENE-8571: Don't block on FrozenBufferedUpdates#apply during IW#processEvents","user":{"login":"s1monw","id":973334,"node_id":"MDQ6VXNlcjk3MzMzNA==","avatar_url":"https://avatars0.githubusercontent.com/u/973334?v=4","gravatar_id":"","url":"https://api.github.com/users/s1monw","html_url":"https://github.com/s1monw","followers_url":"https://api.github.com/users/s1monw/followers","following_url":"https://api.github.com/users/s1monw/following{/other_user}","gists_url":"https://api.github.com/users/s1monw/gists{/gist_id}","starred_url":"https://api.github.com/users/s1monw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s1monw/subscriptions","organizations_url":"https://api.github.com/users/s1monw/orgs","repos_url":"https://api.github.com/users/s1monw/repos","events_url":"https://api.github.com/users/s1monw/events{/privacy}","received_events_url":"https://api.github.com/users/s1monw/received_events","type":"User","site_admin":false},"body":"While indexing we try to apply frozen deletes packages concurrently\r\non indexing threads if necessary. This is done in an opaque way via\r\nIndexWriter#processEvents. Yet, when we commit or refresh we have to\r\nensure we apply all frozen update packages before we return.\r\nToday we execute the apply method in a blocking fashion which is unnecessary\r\nwhen we are in a IndexWriter#processEvents context, we block indexing\r\nthreads while they could just continue since it's already being applied.\r\nWe also might wait in BufferedUpdatesStream when we apply all necessary updates\r\nwere we can continue with other work instead of waiting.\r\nThis change also tries to apply the packages that are not currently applied\r\nfirst in order to not unnecessarily block.","created_at":"2018-11-21T09:31:08Z","updated_at":"2018-11-21T09:31:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/lucene-solr/pulls/503/commits","review_comments_url":"https://api.github.com/repos/apache/lucene-solr/pulls/503/comments","review_comment_url":"https://api.github.com/repos/apache/lucene-solr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/lucene-solr/issues/503/comments","statuses_url":"https://api.github.com/repos/apache/lucene-solr/statuses/caeb68509a53766963bbcb1a96ef204ba6cb1492","head":{"label":"s1monw:optimize_apply_frozen_updates","ref":"optimize_apply_frozen_updates","sha":"caeb68509a53766963bbcb1a96ef204ba6cb1492","user":{"login":"s1monw","id":973334,"node_id":"MDQ6VXNlcjk3MzMzNA==","avatar_url":"https://avatars0.githubusercontent.com/u/973334?v=4","gravatar_id":"","url":"https://api.github.com/users/s1monw","html_url":"https://github.com/s1monw","followers_url":"https://api.github.com/users/s1monw/followers","following_url":"https://api.github.com/users/s1monw/following{/other_user}","gists_url":"https://api.github.com/users/s1monw/gists{/gist_id}","starred_url":"https://api.github.com/users/s1monw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s1monw/subscriptions","organizations_url":"https://api.github.com/users/s1monw/orgs","repos_url":"https://api.github.com/users/s1monw/repos","events_url":"https://api.github.com/users/s1monw/events{/privacy}","received_events_url":"https://api.github.com/users/s1monw/received_events","type":"User","site_admin":false},"repo":{"id":137181686,"node_id":"MDEwOlJlcG9zaXRvcnkxMzcxODE2ODY=","name":"lucene-solr","full_name":"s1monw/lucene-solr","private":false,"owner":{"login":"s1monw","id":973334,"node_id":"MDQ6VXNlcjk3MzMzNA==","avatar_url":"https://avatars0.githubusercontent.com/u/973334?v=4","gravatar_id":"","url":"https://api.github.com/users/s1monw","html_url":"https://github.com/s1monw","followers_url":"https://api.github.com/users/s1monw/followers","following_url":"https://api.github.com/users/s1monw/following{/other_user}","gists_url":"https://api.github.com/users/s1monw/gists{/gist_id}","starred_url":"https://api.github.com/users/s1monw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s1monw/subscriptions","organizations_url":"https://api.github.com/users/s1monw/orgs","repos_url":"https://api.github.com/users/s1monw/repos","events_url":"https://api.github.com/users/s1monw/events{/privacy}","received_events_url":"https://api.github.com/users/s1monw/received_events","type":"User","site_admin":false},"html_url":"https://github.com/s1monw/lucene-solr","description":"Mirror of Apache Lucene + Solr","fork":true,"url":"https://api.github.com/repos/s1monw/lucene-solr","forks_url":"https://api.github.com/repos/s1monw/lucene-solr/forks","keys_url":"https://api.github.com/repos/s1monw/lucene-solr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/s1monw/lucene-solr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/s1monw/lucene-solr/teams","hooks_url":"https://api.github.com/repos/s1monw/lucene-solr/hooks","issue_events_url":"https://api.github.com/repos/s1monw/lucene-solr/issues/events{/number}","events_url":"https://api.github.com/repos/s1monw/lucene-solr/events","assignees_url":"https://api.github.com/repos/s1monw/lucene-solr/assignees{/user}","branches_url":"https://api.github.com/repos/s1monw/lucene-solr/branches{/branch}","tags_url":"https://api.github.com/repos/s1monw/lucene-solr/tags","blobs_url":"https://api.github.com/repos/s1monw/lucene-solr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/s1monw/lucene-solr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/s1monw/lucene-solr/git/refs{/sha}","trees_url":"https://api.github.com/repos/s1monw/lucene-solr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/s1monw/lucene-solr/statuses/{sha}","languages_url":"https://api.github.com/repos/s1monw/lucene-solr/languages","stargazers_url":"https://api.github.com/repos/s1monw/lucene-solr/stargazers","contributors_url":"https://api.github.com/repos/s1monw/lucene-solr/contributors","subscribers_url":"https://api.github.com/repos/s1monw/lucene-solr/subscribers","subscription_url":"https://api.github.com/repos/s1monw/lucene-solr/subscription","commits_url":"https://api.github.com/repos/s1monw/lucene-solr/commits{/sha}","git_commits_url":"https://api.github.com/repos/s1monw/lucene-solr/git/commits{/sha}","comments_url":"https://api.github.com/repos/s1monw/lucene-solr/comments{/number}","issue_comment_url":"https://api.github.com/repos/s1monw/lucene-solr/issues/comments{/number}","contents_url":"https://api.github.com/repos/s1monw/lucene-solr/contents/{+path}","compare_url":"https://api.github.com/repos/s1monw/lucene-solr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/s1monw/lucene-solr/merges","archive_url":"https://api.github.com/repos/s1monw/lucene-solr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/s1monw/lucene-solr/downloads","issues_url":"https://api.github.com/repos/s1monw/lucene-solr/issues{/number}","pulls_url":"https://api.github.com/repos/s1monw/lucene-solr/pulls{/number}","milestones_url":"https://api.github.com/repos/s1monw/lucene-solr/milestones{/number}","notifications_url":"https://api.github.com/repos/s1monw/lucene-solr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/s1monw/lucene-solr/labels{/name}","releases_url":"https://api.github.com/repos/s1monw/lucene-solr/releases{/id}","deployments_url":"https://api.github.com/repos/s1monw/lucene-solr/deployments","created_at":"2018-06-13T07:51:37Z","updated_at":"2018-06-13T07:52:17Z","pushed_at":"2018-11-21T09:30:17Z","git_url":"git://github.com/s1monw/lucene-solr.git","ssh_url":"git@github.com:s1monw/lucene-solr.git","clone_url":"https://github.com/s1monw/lucene-solr.git","svn_url":"https://github.com/s1monw/lucene-solr","homepage":null,"size":369199,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"08dd681f0febcf73af94b47ea742294bf4dd8701","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":50229487,"node_id":"MDEwOlJlcG9zaXRvcnk1MDIyOTQ4Nw==","name":"lucene-solr","full_name":"apache/lucene-solr","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/lucene-solr","description":"Mirror of Apache Lucene + Solr","fork":false,"url":"https://api.github.com/repos/apache/lucene-solr","forks_url":"https://api.github.com/repos/apache/lucene-solr/forks","keys_url":"https://api.github.com/repos/apache/lucene-solr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/lucene-solr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/lucene-solr/teams","hooks_url":"https://api.github.com/repos/apache/lucene-solr/hooks","issue_events_url":"https://api.github.com/repos/apache/lucene-solr/issues/events{/number}","events_url":"https://api.github.com/repos/apache/lucene-solr/events","assignees_url":"https://api.github.com/repos/apache/lucene-solr/assignees{/user}","branches_url":"https://api.github.com/repos/apache/lucene-solr/branches{/branch}","tags_url":"https://api.github.com/repos/apache/lucene-solr/tags","blobs_url":"https://api.github.com/repos/apache/lucene-solr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/lucene-solr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/lucene-solr/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/lucene-solr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/lucene-solr/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/lucene-solr/languages","stargazers_url":"https://api.github.com/repos/apache/lucene-solr/stargazers","contributors_url":"https://api.github.com/repos/apache/lucene-solr/contributors","subscribers_url":"https://api.github.com/repos/apache/lucene-solr/subscribers","subscription_url":"https://api.github.com/repos/apache/lucene-solr/subscription","commits_url":"https://api.github.com/repos/apache/lucene-solr/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/lucene-solr/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/lucene-solr/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/lucene-solr/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/lucene-solr/contents/{+path}","compare_url":"https://api.github.com/repos/apache/lucene-solr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/lucene-solr/merges","archive_url":"https://api.github.com/repos/apache/lucene-solr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/lucene-solr/downloads","issues_url":"https://api.github.com/repos/apache/lucene-solr/issues{/number}","pulls_url":"https://api.github.com/repos/apache/lucene-solr/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/lucene-solr/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/lucene-solr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/lucene-solr/labels{/name}","releases_url":"https://api.github.com/repos/apache/lucene-solr/releases{/id}","deployments_url":"https://api.github.com/repos/apache/lucene-solr/deployments","created_at":"2016-01-23T08:00:06Z","updated_at":"2018-11-21T09:29:39Z","pushed_at":"2018-11-21T09:29:18Z","git_url":"git://github.com/apache/lucene-solr.git","ssh_url":"git@github.com:apache/lucene-solr.git","clone_url":"https://github.com/apache/lucene-solr.git","svn_url":"https://github.com/apache/lucene-solr","homepage":null,"size":375460,"stargazers_count":2080,"watchers_count":2080,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1605,"mirror_url":null,"archived":false,"open_issues_count":261,"license":null,"forks":1605,"open_issues":261,"watchers":2080,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/lucene-solr/pulls/503"},"html":{"href":"https://github.com/apache/lucene-solr/pull/503"},"issue":{"href":"https://api.github.com/repos/apache/lucene-solr/issues/503"},"comments":{"href":"https://api.github.com/repos/apache/lucene-solr/issues/503/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/lucene-solr/pulls/503/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/lucene-solr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/lucene-solr/pulls/503/commits"},"statuses":{"href":"https://api.github.com/repos/apache/lucene-solr/statuses/caeb68509a53766963bbcb1a96ef204ba6cb1492"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":148,"deletions":109,"changed_files":3}}
{"actor":{"display_login":"s1monw"}}