{"action":"created","comment":{"url":"https://api.github.com/repos/pytorch/pytorch/pulls/comments/193584436","pull_request_review_id":126585327,"id":193584436,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MzU4NDQzNg==","diff_hunk":"@@ -12,16 +12,23 @@ class IDEEPSumOp final : public IDEEPOperator {\n   virtual ~IDEEPSumOp() {}\n \n   bool RunOnDevice() override {\n-    const auto &X = Input(INPUT0);\n+    const auto& X = Input(INPUT0);\n     auto* Y = Output(OUTPUT);\n \n     if (InputSize() == 1) {\n       ideep::direct_copy::compute(X, *Y);\n \n     } else {\n       vector<itensor> inputs;\n-      vector<float> scales (InputSize(), 1.0);\n+      vector<float> scales(InputSize(), 1.0);\n+      const auto dims = Input(0).get_dims();\n       for (int i = 0; i < InputSize(); ++i) {\n+        if (Input(i).get_dims() != dims) {\n+          CAFFE_ENFORCE_EQ(\n+              dims,\n+              Input(i).get_dims(),\n+              \"Broadcast is not yet supported with MKLDNN.\");","path":"caffe2/ideep/operators/elementwise_sum_op.cc","position":21,"original_position":21,"commit_id":"1ac7a32ecb273f71a49dbb079b2e1c1a54d4bed1","original_commit_id":"1ac7a32ecb273f71a49dbb079b2e1c1a54d4bed1","user":{"login":"yinghai","id":1100089,"node_id":"MDQ6VXNlcjExMDAwODk=","avatar_url":"https://avatars1.githubusercontent.com/u/1100089?v=4","gravatar_id":"","url":"https://api.github.com/users/yinghai","html_url":"https://github.com/yinghai","followers_url":"https://api.github.com/users/yinghai/followers","following_url":"https://api.github.com/users/yinghai/following{/other_user}","gists_url":"https://api.github.com/users/yinghai/gists{/gist_id}","starred_url":"https://api.github.com/users/yinghai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yinghai/subscriptions","organizations_url":"https://api.github.com/users/yinghai/orgs","repos_url":"https://api.github.com/users/yinghai/repos","events_url":"https://api.github.com/users/yinghai/events{/privacy}","received_events_url":"https://api.github.com/users/yinghai/received_events","type":"User","site_admin":false},"body":"This actually bonafide `MKLDNN`. :D ","created_at":"2018-06-06T23:00:01Z","updated_at":"2018-06-06T23:00:01Z","html_url":"https://github.com/pytorch/pytorch/pull/8220#discussion_r193584436","pull_request_url":"https://api.github.com/repos/pytorch/pytorch/pulls/8220","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/comments/193584436"},"html":{"href":"https://github.com/pytorch/pytorch/pull/8220#discussion_r193584436"},"pull_request":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/8220"}},"in_reply_to_id":193583368},"pull_request":{"url":"https://api.github.com/repos/pytorch/pytorch/pulls/8220","id":193160695,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzMTYwNjk1","html_url":"https://github.com/pytorch/pytorch/pull/8220","diff_url":"https://github.com/pytorch/pytorch/pull/8220.diff","patch_url":"https://github.com/pytorch/pytorch/pull/8220.patch","issue_url":"https://api.github.com/repos/pytorch/pytorch/issues/8220","number":8220,"state":"open","locked":false,"title":"[Caffe2] Add ADD operator for IDEEP","user":{"login":"yinghai","id":1100089,"node_id":"MDQ6VXNlcjExMDAwODk=","avatar_url":"https://avatars1.githubusercontent.com/u/1100089?v=4","gravatar_id":"","url":"https://api.github.com/users/yinghai","html_url":"https://github.com/yinghai","followers_url":"https://api.github.com/users/yinghai/followers","following_url":"https://api.github.com/users/yinghai/following{/other_user}","gists_url":"https://api.github.com/users/yinghai/gists{/gist_id}","starred_url":"https://api.github.com/users/yinghai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yinghai/subscriptions","organizations_url":"https://api.github.com/users/yinghai/orgs","repos_url":"https://api.github.com/users/yinghai/repos","events_url":"https://api.github.com/users/yinghai/events{/privacy}","received_events_url":"https://api.github.com/users/yinghai/received_events","type":"User","site_admin":false},"body":"It's basically a clone of `Sum`. ","created_at":"2018-06-06T22:43:37Z","updated_at":"2018-06-06T23:00:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a196ec9c8622fbf9b827560270f32ecb5ba339c5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":890282107,"node_id":"MDU6TGFiZWw4OTAyODIxMDc=","url":"https://api.github.com/repos/pytorch/pytorch/labels/caffe2","name":"caffe2","color":"210aa8","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/pytorch/pytorch/pulls/8220/commits","review_comments_url":"https://api.github.com/repos/pytorch/pytorch/pulls/8220/comments","review_comment_url":"https://api.github.com/repos/pytorch/pytorch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pytorch/pytorch/issues/8220/comments","statuses_url":"https://api.github.com/repos/pytorch/pytorch/statuses/1ac7a32ecb273f71a49dbb079b2e1c1a54d4bed1","head":{"label":"yinghai:ideep_add","ref":"ideep_add","sha":"1ac7a32ecb273f71a49dbb079b2e1c1a54d4bed1","user":{"login":"yinghai","id":1100089,"node_id":"MDQ6VXNlcjExMDAwODk=","avatar_url":"https://avatars1.githubusercontent.com/u/1100089?v=4","gravatar_id":"","url":"https://api.github.com/users/yinghai","html_url":"https://github.com/yinghai","followers_url":"https://api.github.com/users/yinghai/followers","following_url":"https://api.github.com/users/yinghai/following{/other_user}","gists_url":"https://api.github.com/users/yinghai/gists{/gist_id}","starred_url":"https://api.github.com/users/yinghai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yinghai/subscriptions","organizations_url":"https://api.github.com/users/yinghai/orgs","repos_url":"https://api.github.com/users/yinghai/repos","events_url":"https://api.github.com/users/yinghai/events{/privacy}","received_events_url":"https://api.github.com/users/yinghai/received_events","type":"User","site_admin":false},"repo":{"id":117278939,"node_id":"MDEwOlJlcG9zaXRvcnkxMTcyNzg5Mzk=","name":"pytorch","full_name":"yinghai/pytorch","owner":{"login":"yinghai","id":1100089,"node_id":"MDQ6VXNlcjExMDAwODk=","avatar_url":"https://avatars1.githubusercontent.com/u/1100089?v=4","gravatar_id":"","url":"https://api.github.com/users/yinghai","html_url":"https://github.com/yinghai","followers_url":"https://api.github.com/users/yinghai/followers","following_url":"https://api.github.com/users/yinghai/following{/other_user}","gists_url":"https://api.github.com/users/yinghai/gists{/gist_id}","starred_url":"https://api.github.com/users/yinghai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yinghai/subscriptions","organizations_url":"https://api.github.com/users/yinghai/orgs","repos_url":"https://api.github.com/users/yinghai/repos","events_url":"https://api.github.com/users/yinghai/events{/privacy}","received_events_url":"https://api.github.com/users/yinghai/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yinghai/pytorch","description":"Tensors and Dynamic neural networks in Python  with strong GPU acceleration","fork":true,"url":"https://api.github.com/repos/yinghai/pytorch","forks_url":"https://api.github.com/repos/yinghai/pytorch/forks","keys_url":"https://api.github.com/repos/yinghai/pytorch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yinghai/pytorch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yinghai/pytorch/teams","hooks_url":"https://api.github.com/repos/yinghai/pytorch/hooks","issue_events_url":"https://api.github.com/repos/yinghai/pytorch/issues/events{/number}","events_url":"https://api.github.com/repos/yinghai/pytorch/events","assignees_url":"https://api.github.com/repos/yinghai/pytorch/assignees{/user}","branches_url":"https://api.github.com/repos/yinghai/pytorch/branches{/branch}","tags_url":"https://api.github.com/repos/yinghai/pytorch/tags","blobs_url":"https://api.github.com/repos/yinghai/pytorch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yinghai/pytorch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yinghai/pytorch/git/refs{/sha}","trees_url":"https://api.github.com/repos/yinghai/pytorch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yinghai/pytorch/statuses/{sha}","languages_url":"https://api.github.com/repos/yinghai/pytorch/languages","stargazers_url":"https://api.github.com/repos/yinghai/pytorch/stargazers","contributors_url":"https://api.github.com/repos/yinghai/pytorch/contributors","subscribers_url":"https://api.github.com/repos/yinghai/pytorch/subscribers","subscription_url":"https://api.github.com/repos/yinghai/pytorch/subscription","commits_url":"https://api.github.com/repos/yinghai/pytorch/commits{/sha}","git_commits_url":"https://api.github.com/repos/yinghai/pytorch/git/commits{/sha}","comments_url":"https://api.github.com/repos/yinghai/pytorch/comments{/number}","issue_comment_url":"https://api.github.com/repos/yinghai/pytorch/issues/comments{/number}","contents_url":"https://api.github.com/repos/yinghai/pytorch/contents/{+path}","compare_url":"https://api.github.com/repos/yinghai/pytorch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yinghai/pytorch/merges","archive_url":"https://api.github.com/repos/yinghai/pytorch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yinghai/pytorch/downloads","issues_url":"https://api.github.com/repos/yinghai/pytorch/issues{/number}","pulls_url":"https://api.github.com/repos/yinghai/pytorch/pulls{/number}","milestones_url":"https://api.github.com/repos/yinghai/pytorch/milestones{/number}","notifications_url":"https://api.github.com/repos/yinghai/pytorch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yinghai/pytorch/labels{/name}","releases_url":"https://api.github.com/repos/yinghai/pytorch/releases{/id}","deployments_url":"https://api.github.com/repos/yinghai/pytorch/deployments","created_at":"2018-01-12T19:15:32Z","updated_at":"2018-06-06T22:38:36Z","pushed_at":"2018-06-06T22:51:15Z","git_url":"git://github.com/yinghai/pytorch.git","ssh_url":"git@github.com:yinghai/pytorch.git","clone_url":"https://github.com/yinghai/pytorch.git","svn_url":"https://github.com/yinghai/pytorch","homepage":"http://pytorch.org","size":55569,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pytorch:master","ref":"master","sha":"12229afd0054be5ced0ae36fccf7eae3dffa30a1","user":{"login":"pytorch","id":21003710,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDAzNzEw","avatar_url":"https://avatars3.githubusercontent.com/u/21003710?v=4","gravatar_id":"","url":"https://api.github.com/users/pytorch","html_url":"https://github.com/pytorch","followers_url":"https://api.github.com/users/pytorch/followers","following_url":"https://api.github.com/users/pytorch/following{/other_user}","gists_url":"https://api.github.com/users/pytorch/gists{/gist_id}","starred_url":"https://api.github.com/users/pytorch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytorch/subscriptions","organizations_url":"https://api.github.com/users/pytorch/orgs","repos_url":"https://api.github.com/users/pytorch/repos","events_url":"https://api.github.com/users/pytorch/events{/privacy}","received_events_url":"https://api.github.com/users/pytorch/received_events","type":"Organization","site_admin":false},"repo":{"id":65600975,"node_id":"MDEwOlJlcG9zaXRvcnk2NTYwMDk3NQ==","name":"pytorch","full_name":"pytorch/pytorch","owner":{"login":"pytorch","id":21003710,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDAzNzEw","avatar_url":"https://avatars3.githubusercontent.com/u/21003710?v=4","gravatar_id":"","url":"https://api.github.com/users/pytorch","html_url":"https://github.com/pytorch","followers_url":"https://api.github.com/users/pytorch/followers","following_url":"https://api.github.com/users/pytorch/following{/other_user}","gists_url":"https://api.github.com/users/pytorch/gists{/gist_id}","starred_url":"https://api.github.com/users/pytorch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytorch/subscriptions","organizations_url":"https://api.github.com/users/pytorch/orgs","repos_url":"https://api.github.com/users/pytorch/repos","events_url":"https://api.github.com/users/pytorch/events{/privacy}","received_events_url":"https://api.github.com/users/pytorch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pytorch/pytorch","description":"Tensors and Dynamic neural networks in Python  with strong GPU acceleration","fork":false,"url":"https://api.github.com/repos/pytorch/pytorch","forks_url":"https://api.github.com/repos/pytorch/pytorch/forks","keys_url":"https://api.github.com/repos/pytorch/pytorch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pytorch/pytorch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pytorch/pytorch/teams","hooks_url":"https://api.github.com/repos/pytorch/pytorch/hooks","issue_events_url":"https://api.github.com/repos/pytorch/pytorch/issues/events{/number}","events_url":"https://api.github.com/repos/pytorch/pytorch/events","assignees_url":"https://api.github.com/repos/pytorch/pytorch/assignees{/user}","branches_url":"https://api.github.com/repos/pytorch/pytorch/branches{/branch}","tags_url":"https://api.github.com/repos/pytorch/pytorch/tags","blobs_url":"https://api.github.com/repos/pytorch/pytorch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pytorch/pytorch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pytorch/pytorch/git/refs{/sha}","trees_url":"https://api.github.com/repos/pytorch/pytorch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pytorch/pytorch/statuses/{sha}","languages_url":"https://api.github.com/repos/pytorch/pytorch/languages","stargazers_url":"https://api.github.com/repos/pytorch/pytorch/stargazers","contributors_url":"https://api.github.com/repos/pytorch/pytorch/contributors","subscribers_url":"https://api.github.com/repos/pytorch/pytorch/subscribers","subscription_url":"https://api.github.com/repos/pytorch/pytorch/subscription","commits_url":"https://api.github.com/repos/pytorch/pytorch/commits{/sha}","git_commits_url":"https://api.github.com/repos/pytorch/pytorch/git/commits{/sha}","comments_url":"https://api.github.com/repos/pytorch/pytorch/comments{/number}","issue_comment_url":"https://api.github.com/repos/pytorch/pytorch/issues/comments{/number}","contents_url":"https://api.github.com/repos/pytorch/pytorch/contents/{+path}","compare_url":"https://api.github.com/repos/pytorch/pytorch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pytorch/pytorch/merges","archive_url":"https://api.github.com/repos/pytorch/pytorch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pytorch/pytorch/downloads","issues_url":"https://api.github.com/repos/pytorch/pytorch/issues{/number}","pulls_url":"https://api.github.com/repos/pytorch/pytorch/pulls{/number}","milestones_url":"https://api.github.com/repos/pytorch/pytorch/milestones{/number}","notifications_url":"https://api.github.com/repos/pytorch/pytorch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pytorch/pytorch/labels{/name}","releases_url":"https://api.github.com/repos/pytorch/pytorch/releases{/id}","deployments_url":"https://api.github.com/repos/pytorch/pytorch/deployments","created_at":"2016-08-13T05:26:41Z","updated_at":"2018-06-06T22:10:25Z","pushed_at":"2018-06-06T22:58:50Z","git_url":"git://github.com/pytorch/pytorch.git","ssh_url":"git@github.com:pytorch/pytorch.git","clone_url":"https://github.com/pytorch/pytorch.git","svn_url":"https://github.com/pytorch/pytorch","homepage":"http://pytorch.org","size":57084,"stargazers_count":16172,"watchers_count":16172,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3656,"mirror_url":null,"archived":false,"open_issues_count":1194,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3656,"open_issues":1194,"watchers":16172,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/8220"},"html":{"href":"https://github.com/pytorch/pytorch/pull/8220"},"issue":{"href":"https://api.github.com/repos/pytorch/pytorch/issues/8220"},"comments":{"href":"https://api.github.com/repos/pytorch/pytorch/issues/8220/comments"},"review_comments":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/8220/comments"},"review_comment":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/8220/commits"},"statuses":{"href":"https://api.github.com/repos/pytorch/pytorch/statuses/1ac7a32ecb273f71a49dbb079b2e1c1a54d4bed1"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"yinghai"}}