{"action":"closed","issue":{"url":"https://api.github.com/repos/phetsims/beers-law-lab/issues/205","repository_url":"https://api.github.com/repos/phetsims/beers-law-lab","labels_url":"https://api.github.com/repos/phetsims/beers-law-lab/issues/205/labels{/name}","comments_url":"https://api.github.com/repos/phetsims/beers-law-lab/issues/205/comments","events_url":"https://api.github.com/repos/phetsims/beers-law-lab/issues/205/events","html_url":"https://github.com/phetsims/beers-law-lab/issues/205","id":253359946,"node_id":"MDU6SXNzdWUyNTMzNTk5NDY=","number":205,"title":"Some nodes not instrumented for PhET-iO","user":{"login":"samreid","id":679486,"node_id":"MDQ6VXNlcjY3OTQ4Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/679486?v=4","gravatar_id":"","url":"https://api.github.com/users/samreid","html_url":"https://github.com/samreid","followers_url":"https://api.github.com/users/samreid/followers","following_url":"https://api.github.com/users/samreid/following{/other_user}","gists_url":"https://api.github.com/users/samreid/gists{/gist_id}","starred_url":"https://api.github.com/users/samreid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samreid/subscriptions","organizations_url":"https://api.github.com/users/samreid/orgs","repos_url":"https://api.github.com/users/samreid/repos","events_url":"https://api.github.com/users/samreid/events{/privacy}","received_events_url":"https://api.github.com/users/samreid/received_events","type":"User","site_admin":false},"labels":[{"id":252635399,"node_id":"MDU6TGFiZWwyNTI2MzUzOTk=","url":"https://api.github.com/repos/phetsims/beers-law-lab/labels/dev:phet-io","name":"dev:phet-io","color":"1FFFFF","default":false},{"id":325282584,"node_id":"MDU6TGFiZWwzMjUyODI1ODQ=","url":"https://api.github.com/repos/phetsims/beers-law-lab/labels/status:on-hold","name":"status:on-hold","color":"F0FFF0","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2017-08-28T15:09:19Z","updated_at":"2018-11-08T00:03:57Z","closed_at":"2018-11-08T00:03:57Z","author_association":"MEMBER","body":"From https://github.com/phetsims/phet-io/issues/762\r\n\r\n<img width=\"554\" alt=\"screen shot 2016-10-28 at 11 49 42 am\" src=\"https://cloud.githubusercontent.com/assets/5863899/19817135/6b702946-9d07-11e6-9c07-3968d899f0d5.png\">\r\n\r\n<img width=\"555\" alt=\"screen shot 2016-10-28 at 12 08 30 pm\" src=\"https://cloud.githubusercontent.com/assets/5863899/19817137/70d3564c-9d07-11e6-88e0-73dc5e589881.png\">\r\n\r\n**Not Pictured**\r\n\r\nAll of these are missing their associated node:\r\n\r\n`beersLawLab.beersLawScreen.view.wavelengthControls.wavelengthSlider.trackInputListener: TTandemDragHandler`\r\n`beersLawLab.beersLawScreen.view.wavelengthControls.wavelengthSlider.thumbInputListener: TTandemDragHandler`\r\n`beersLawLab.beersLawScreen.view.solutionControls.concentrationControl.slider.track.inputListener: TTandemDragHandler`\r\n`beersLawLab.beersLawScreen.view.solutionControls.concentrationControl.slider.track.inputListener: TTandemDragHandler`\r\n\r\nFor two examples of correctly instrumented nodes and what I mean by \"associated nodes\", both these track and thumb nodes are instrumented:\r\n`beersLawLab.concentrationScreen.view.evaporationControl.slider.track.trackInputListener: TTandemDragHandler`\r\nwith\r\n`beersLawLab.concentrationScreen.view.evaporationControl.slider.track: THSliderTrack`\r\n\r\n`beersLawLab.concentrationScreen.view.evaporationControl.slider.thumbInputListener: TTandemDragHandler`\r\nwith\r\n`beersLawLab.concentrationScreen.view.evaporationControl.slider.thumb: TNode`\r\n\r\nFor phetsims/tasks/issues/718.\r\n\r\n\r\nEdit: now also for phetsims/tasks/issues/724.\r\n\r\n@zepumph can you please investigate?"}}
{"actor":{"display_login":"pixelzoom"}}