{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/20375","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/20375/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/20375/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/20375/events","html_url":"https://github.com/nodejs/node/pull/20375","id":318574196,"number":20375,"title":"http2: compat don't make unnecessary copy of trailers","user":{"login":"ronag","id":3065230,"avatar_url":"https://avatars3.githubusercontent.com/u/3065230?v=4","gravatar_id":"","url":"https://api.github.com/users/ronag","html_url":"https://github.com/ronag","followers_url":"https://api.github.com/users/ronag/followers","following_url":"https://api.github.com/users/ronag/following{/other_user}","gists_url":"https://api.github.com/users/ronag/gists{/gist_id}","starred_url":"https://api.github.com/users/ronag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ronag/subscriptions","organizations_url":"https://api.github.com/users/ronag/orgs","repos_url":"https://api.github.com/users/ronag/repos","events_url":"https://api.github.com/users/ronag/events{/privacy}","received_events_url":"https://api.github.com/users/ronag/received_events","type":"User","site_admin":false},"labels":[{"id":311670452,"url":"https://api.github.com/repos/nodejs/node/labels/dont-land-on-v4.x","name":"dont-land-on-v4.x","color":"eb6420","default":false},{"id":364533783,"url":"https://api.github.com/repos/nodejs/node/labels/dont-land-on-v6.x","name":"dont-land-on-v6.x","color":"c2e0c6","default":false},{"id":647282877,"url":"https://api.github.com/repos/nodejs/node/labels/http2","name":"http2","color":"c2e0c6","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-04-27T23:09:46Z","updated_at":"2018-04-28T16:51:53Z","closed_at":"2018-04-28T16:45:45Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/20375","html_url":"https://github.com/nodejs/node/pull/20375","diff_url":"https://github.com/nodejs/node/pull/20375.diff","patch_url":"https://github.com/nodejs/node/pull/20375.patch"},"body":"Not sure why the trailer objects are copied here? Might as well just use a reference, no?\r\n\r\n##### Checklist\r\n\r\n- [ ] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/385190057","html_url":"https://github.com/nodejs/node/pull/20375#issuecomment-385190057","issue_url":"https://api.github.com/repos/nodejs/node/issues/20375","id":385190057,"user":{"login":"ronag","id":3065230,"avatar_url":"https://avatars3.githubusercontent.com/u/3065230?v=4","gravatar_id":"","url":"https://api.github.com/users/ronag","html_url":"https://github.com/ronag","followers_url":"https://api.github.com/users/ronag/followers","following_url":"https://api.github.com/users/ronag/following{/other_user}","gists_url":"https://api.github.com/users/ronag/gists{/gist_id}","starred_url":"https://api.github.com/users/ronag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ronag/subscriptions","organizations_url":"https://api.github.com/users/ronag/orgs","repos_url":"https://api.github.com/users/ronag/repos","events_url":"https://api.github.com/users/ronag/events{/privacy}","received_events_url":"https://api.github.com/users/ronag/received_events","type":"User","site_admin":false},"created_at":"2018-04-28T16:51:53Z","updated_at":"2018-04-28T16:51:53Z","author_association":"CONTRIBUTOR","body":"e.g.\r\n\r\n```js\r\nfor (const key in req.trailers) {\r\n  if (!req.hasOwnProperty(key)) {\r\n  }\r\n}\r\n```\r\n\r\nWould work in http1 but not in http2 compat."}}
{"actor":{"display_login":"ronag"}}