{"action":"closed","number":2,"pull_request":{"url":"https://api.github.com/repos/QueraTeam/django-qsessions/pulls/2","id":231572428,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxNTcyNDI4","html_url":"https://github.com/QueraTeam/django-qsessions/pull/2","diff_url":"https://github.com/QueraTeam/django-qsessions/pull/2.diff","patch_url":"https://github.com/QueraTeam/django-qsessions/pull/2.patch","issue_url":"https://api.github.com/repos/QueraTeam/django-qsessions/issues/2","number":2,"state":"closed","locked":false,"title":"Miscellaneous fixes and improvements","user":{"login":"akx","id":58669,"node_id":"MDQ6VXNlcjU4NjY5","avatar_url":"https://avatars2.githubusercontent.com/u/58669?v=4","gravatar_id":"","url":"https://api.github.com/users/akx","html_url":"https://github.com/akx","followers_url":"https://api.github.com/users/akx/followers","following_url":"https://api.github.com/users/akx/following{/other_user}","gists_url":"https://api.github.com/users/akx/gists{/gist_id}","starred_url":"https://api.github.com/users/akx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akx/subscriptions","organizations_url":"https://api.github.com/users/akx/orgs","repos_url":"https://api.github.com/users/akx/repos","events_url":"https://api.github.com/users/akx/events{/privacy}","received_events_url":"https://api.github.com/users/akx/received_events","type":"User","site_admin":false},"body":"Hey there!\r\n\r\nI'm evaluating django-qsessions for our product over at @valohai and found some things that could be improved upon... here's the first batch of them. :)\r\n\r\n# Testing\r\n\r\n* Tests are now being run with py.test instead of Django's test runner, to make them simpler and more powerful\r\n* GeoIP functionality is tested using the small test databases provided by MaxMind\r\n* Test coverage is now measurable, and grew from 79% to 96%. :tada: (The only fully untested module – and it's ignored from coverage – is the `download_geoip_db` management command.)\r\n\r\n# Refactoring\r\n\r\n* The copy-pasted `clearsessions` management command now simply re-exports the original `clearsessions` command.\r\n* The `user_id` property on `SessionStore` is now simply read from the session data, which simplifies things.\r\n\r\n# New features\r\n\r\n* `download_geoip_db` now logs progress.\r\n* A new `location_info()` API is added to `Session`s, to get the full session information instead of only the description string.\r\n* `device()` is now available on `Session`s, not only in the admin.","created_at":"2018-11-16T15:47:04Z","updated_at":"2018-12-24T19:59:24Z","closed_at":"2018-12-24T19:59:24Z","merged_at":"2018-12-24T19:59:24Z","merge_commit_sha":"612c579c78d8981cbea5cee086a39553c0954dc3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/QueraTeam/django-qsessions/pulls/2/commits","review_comments_url":"https://api.github.com/repos/QueraTeam/django-qsessions/pulls/2/comments","review_comment_url":"https://api.github.com/repos/QueraTeam/django-qsessions/pulls/comments{/number}","comments_url":"https://api.github.com/repos/QueraTeam/django-qsessions/issues/2/comments","statuses_url":"https://api.github.com/repos/QueraTeam/django-qsessions/statuses/612c579c78d8981cbea5cee086a39553c0954dc3","head":{"label":"valohai:fixies","ref":"fixies","sha":"612c579c78d8981cbea5cee086a39553c0954dc3","user":{"login":"valohai","id":22657901,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNjU3OTAx","avatar_url":"https://avatars0.githubusercontent.com/u/22657901?v=4","gravatar_id":"","url":"https://api.github.com/users/valohai","html_url":"https://github.com/valohai","followers_url":"https://api.github.com/users/valohai/followers","following_url":"https://api.github.com/users/valohai/following{/other_user}","gists_url":"https://api.github.com/users/valohai/gists{/gist_id}","starred_url":"https://api.github.com/users/valohai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/valohai/subscriptions","organizations_url":"https://api.github.com/users/valohai/orgs","repos_url":"https://api.github.com/users/valohai/repos","events_url":"https://api.github.com/users/valohai/events{/privacy}","received_events_url":"https://api.github.com/users/valohai/received_events","type":"Organization","site_admin":false},"repo":{"id":157880480,"node_id":"MDEwOlJlcG9zaXRvcnkxNTc4ODA0ODA=","name":"django-qsessions","full_name":"valohai/django-qsessions","private":false,"owner":{"login":"valohai","id":22657901,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNjU3OTAx","avatar_url":"https://avatars0.githubusercontent.com/u/22657901?v=4","gravatar_id":"","url":"https://api.github.com/users/valohai","html_url":"https://github.com/valohai","followers_url":"https://api.github.com/users/valohai/followers","following_url":"https://api.github.com/users/valohai/following{/other_user}","gists_url":"https://api.github.com/users/valohai/gists{/gist_id}","starred_url":"https://api.github.com/users/valohai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/valohai/subscriptions","organizations_url":"https://api.github.com/users/valohai/orgs","repos_url":"https://api.github.com/users/valohai/repos","events_url":"https://api.github.com/users/valohai/events{/privacy}","received_events_url":"https://api.github.com/users/valohai/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/valohai/django-qsessions","description":"Extends Django's \"cached_db\" session backend (Sessions store IP, User Agent, and foreign key to User)","fork":true,"url":"https://api.github.com/repos/valohai/django-qsessions","forks_url":"https://api.github.com/repos/valohai/django-qsessions/forks","keys_url":"https://api.github.com/repos/valohai/django-qsessions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/valohai/django-qsessions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/valohai/django-qsessions/teams","hooks_url":"https://api.github.com/repos/valohai/django-qsessions/hooks","issue_events_url":"https://api.github.com/repos/valohai/django-qsessions/issues/events{/number}","events_url":"https://api.github.com/repos/valohai/django-qsessions/events","assignees_url":"https://api.github.com/repos/valohai/django-qsessions/assignees{/user}","branches_url":"https://api.github.com/repos/valohai/django-qsessions/branches{/branch}","tags_url":"https://api.github.com/repos/valohai/django-qsessions/tags","blobs_url":"https://api.github.com/repos/valohai/django-qsessions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/valohai/django-qsessions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/valohai/django-qsessions/git/refs{/sha}","trees_url":"https://api.github.com/repos/valohai/django-qsessions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/valohai/django-qsessions/statuses/{sha}","languages_url":"https://api.github.com/repos/valohai/django-qsessions/languages","stargazers_url":"https://api.github.com/repos/valohai/django-qsessions/stargazers","contributors_url":"https://api.github.com/repos/valohai/django-qsessions/contributors","subscribers_url":"https://api.github.com/repos/valohai/django-qsessions/subscribers","subscription_url":"https://api.github.com/repos/valohai/django-qsessions/subscription","commits_url":"https://api.github.com/repos/valohai/django-qsessions/commits{/sha}","git_commits_url":"https://api.github.com/repos/valohai/django-qsessions/git/commits{/sha}","comments_url":"https://api.github.com/repos/valohai/django-qsessions/comments{/number}","issue_comment_url":"https://api.github.com/repos/valohai/django-qsessions/issues/comments{/number}","contents_url":"https://api.github.com/repos/valohai/django-qsessions/contents/{+path}","compare_url":"https://api.github.com/repos/valohai/django-qsessions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/valohai/django-qsessions/merges","archive_url":"https://api.github.com/repos/valohai/django-qsessions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/valohai/django-qsessions/downloads","issues_url":"https://api.github.com/repos/valohai/django-qsessions/issues{/number}","pulls_url":"https://api.github.com/repos/valohai/django-qsessions/pulls{/number}","milestones_url":"https://api.github.com/repos/valohai/django-qsessions/milestones{/number}","notifications_url":"https://api.github.com/repos/valohai/django-qsessions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/valohai/django-qsessions/labels{/name}","releases_url":"https://api.github.com/repos/valohai/django-qsessions/releases{/id}","deployments_url":"https://api.github.com/repos/valohai/django-qsessions/deployments","created_at":"2018-11-16T14:44:48Z","updated_at":"2018-11-16T14:44:50Z","pushed_at":"2018-11-16T15:55:37Z","git_url":"git://github.com/valohai/django-qsessions.git","ssh_url":"git@github.com:valohai/django-qsessions.git","clone_url":"https://github.com/valohai/django-qsessions.git","svn_url":"https://github.com/valohai/django-qsessions","homepage":"","size":63,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"QueraTeam:master","ref":"master","sha":"841660f66d06b285e8a2b7d96e55ae4d713e7cc9","user":{"login":"QueraTeam","id":19687772,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5Njg3Nzcy","avatar_url":"https://avatars2.githubusercontent.com/u/19687772?v=4","gravatar_id":"","url":"https://api.github.com/users/QueraTeam","html_url":"https://github.com/QueraTeam","followers_url":"https://api.github.com/users/QueraTeam/followers","following_url":"https://api.github.com/users/QueraTeam/following{/other_user}","gists_url":"https://api.github.com/users/QueraTeam/gists{/gist_id}","starred_url":"https://api.github.com/users/QueraTeam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QueraTeam/subscriptions","organizations_url":"https://api.github.com/users/QueraTeam/orgs","repos_url":"https://api.github.com/users/QueraTeam/repos","events_url":"https://api.github.com/users/QueraTeam/events{/privacy}","received_events_url":"https://api.github.com/users/QueraTeam/received_events","type":"Organization","site_admin":false},"repo":{"id":118227377,"node_id":"MDEwOlJlcG9zaXRvcnkxMTgyMjczNzc=","name":"django-qsessions","full_name":"QueraTeam/django-qsessions","private":false,"owner":{"login":"QueraTeam","id":19687772,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5Njg3Nzcy","avatar_url":"https://avatars2.githubusercontent.com/u/19687772?v=4","gravatar_id":"","url":"https://api.github.com/users/QueraTeam","html_url":"https://github.com/QueraTeam","followers_url":"https://api.github.com/users/QueraTeam/followers","following_url":"https://api.github.com/users/QueraTeam/following{/other_user}","gists_url":"https://api.github.com/users/QueraTeam/gists{/gist_id}","starred_url":"https://api.github.com/users/QueraTeam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QueraTeam/subscriptions","organizations_url":"https://api.github.com/users/QueraTeam/orgs","repos_url":"https://api.github.com/users/QueraTeam/repos","events_url":"https://api.github.com/users/QueraTeam/events{/privacy}","received_events_url":"https://api.github.com/users/QueraTeam/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/QueraTeam/django-qsessions","description":"Extends Django's \"cached_db\" session backend (Sessions store IP, User Agent, and foreign key to User)","fork":false,"url":"https://api.github.com/repos/QueraTeam/django-qsessions","forks_url":"https://api.github.com/repos/QueraTeam/django-qsessions/forks","keys_url":"https://api.github.com/repos/QueraTeam/django-qsessions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/QueraTeam/django-qsessions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/QueraTeam/django-qsessions/teams","hooks_url":"https://api.github.com/repos/QueraTeam/django-qsessions/hooks","issue_events_url":"https://api.github.com/repos/QueraTeam/django-qsessions/issues/events{/number}","events_url":"https://api.github.com/repos/QueraTeam/django-qsessions/events","assignees_url":"https://api.github.com/repos/QueraTeam/django-qsessions/assignees{/user}","branches_url":"https://api.github.com/repos/QueraTeam/django-qsessions/branches{/branch}","tags_url":"https://api.github.com/repos/QueraTeam/django-qsessions/tags","blobs_url":"https://api.github.com/repos/QueraTeam/django-qsessions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/QueraTeam/django-qsessions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/QueraTeam/django-qsessions/git/refs{/sha}","trees_url":"https://api.github.com/repos/QueraTeam/django-qsessions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/QueraTeam/django-qsessions/statuses/{sha}","languages_url":"https://api.github.com/repos/QueraTeam/django-qsessions/languages","stargazers_url":"https://api.github.com/repos/QueraTeam/django-qsessions/stargazers","contributors_url":"https://api.github.com/repos/QueraTeam/django-qsessions/contributors","subscribers_url":"https://api.github.com/repos/QueraTeam/django-qsessions/subscribers","subscription_url":"https://api.github.com/repos/QueraTeam/django-qsessions/subscription","commits_url":"https://api.github.com/repos/QueraTeam/django-qsessions/commits{/sha}","git_commits_url":"https://api.github.com/repos/QueraTeam/django-qsessions/git/commits{/sha}","comments_url":"https://api.github.com/repos/QueraTeam/django-qsessions/comments{/number}","issue_comment_url":"https://api.github.com/repos/QueraTeam/django-qsessions/issues/comments{/number}","contents_url":"https://api.github.com/repos/QueraTeam/django-qsessions/contents/{+path}","compare_url":"https://api.github.com/repos/QueraTeam/django-qsessions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/QueraTeam/django-qsessions/merges","archive_url":"https://api.github.com/repos/QueraTeam/django-qsessions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/QueraTeam/django-qsessions/downloads","issues_url":"https://api.github.com/repos/QueraTeam/django-qsessions/issues{/number}","pulls_url":"https://api.github.com/repos/QueraTeam/django-qsessions/pulls{/number}","milestones_url":"https://api.github.com/repos/QueraTeam/django-qsessions/milestones{/number}","notifications_url":"https://api.github.com/repos/QueraTeam/django-qsessions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/QueraTeam/django-qsessions/labels{/name}","releases_url":"https://api.github.com/repos/QueraTeam/django-qsessions/releases{/id}","deployments_url":"https://api.github.com/repos/QueraTeam/django-qsessions/deployments","created_at":"2018-01-20T09:09:56Z","updated_at":"2018-11-07T15:23:51Z","pushed_at":"2018-12-24T19:59:23Z","git_url":"git://github.com/QueraTeam/django-qsessions.git","ssh_url":"git@github.com:QueraTeam/django-qsessions.git","clone_url":"https://github.com/QueraTeam/django-qsessions.git","svn_url":"https://github.com/QueraTeam/django-qsessions","homepage":"","size":33,"stargazers_count":24,"watchers_count":24,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2,"open_issues":0,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/QueraTeam/django-qsessions/pulls/2"},"html":{"href":"https://github.com/QueraTeam/django-qsessions/pull/2"},"issue":{"href":"https://api.github.com/repos/QueraTeam/django-qsessions/issues/2"},"comments":{"href":"https://api.github.com/repos/QueraTeam/django-qsessions/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/QueraTeam/django-qsessions/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/QueraTeam/django-qsessions/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/QueraTeam/django-qsessions/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/QueraTeam/django-qsessions/statuses/612c579c78d8981cbea5cee086a39553c0954dc3"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"mjnaderi","id":2115303,"node_id":"MDQ6VXNlcjIxMTUzMDM=","avatar_url":"https://avatars2.githubusercontent.com/u/2115303?v=4","gravatar_id":"","url":"https://api.github.com/users/mjnaderi","html_url":"https://github.com/mjnaderi","followers_url":"https://api.github.com/users/mjnaderi/followers","following_url":"https://api.github.com/users/mjnaderi/following{/other_user}","gists_url":"https://api.github.com/users/mjnaderi/gists{/gist_id}","starred_url":"https://api.github.com/users/mjnaderi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjnaderi/subscriptions","organizations_url":"https://api.github.com/users/mjnaderi/orgs","repos_url":"https://api.github.com/users/mjnaderi/repos","events_url":"https://api.github.com/users/mjnaderi/events{/privacy}","received_events_url":"https://api.github.com/users/mjnaderi/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":13,"additions":274,"deletions":306,"changed_files":27}}
{"actor":{"display_login":"mjnaderi"}}