{"action":"opened","number":57,"pull_request":{"url":"https://api.github.com/repos/googleapis/nodejs-dlp/pulls/57","id":191591696,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxNTkxNjk2","html_url":"https://github.com/googleapis/nodejs-dlp/pull/57","diff_url":"https://github.com/googleapis/nodejs-dlp/pull/57.diff","patch_url":"https://github.com/googleapis/nodejs-dlp/pull/57.patch","issue_url":"https://api.github.com/repos/googleapis/nodejs-dlp/issues/57","number":57,"state":"open","locked":false,"title":"test: updated images for redact sample tests","user":{"login":"alexander-fenster","id":4015807,"node_id":"MDQ6VXNlcjQwMTU4MDc=","avatar_url":"https://avatars1.githubusercontent.com/u/4015807?v=4","gravatar_id":"","url":"https://api.github.com/users/alexander-fenster","html_url":"https://github.com/alexander-fenster","followers_url":"https://api.github.com/users/alexander-fenster/followers","following_url":"https://api.github.com/users/alexander-fenster/following{/other_user}","gists_url":"https://api.github.com/users/alexander-fenster/gists{/gist_id}","starred_url":"https://api.github.com/users/alexander-fenster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexander-fenster/subscriptions","organizations_url":"https://api.github.com/users/alexander-fenster/orgs","repos_url":"https://api.github.com/users/alexander-fenster/repos","events_url":"https://api.github.com/users/alexander-fenster/events{/privacy}","received_events_url":"https://api.github.com/users/alexander-fenster/received_events","type":"User","site_admin":false},"body":"Fixes #56. Looks like the API changes the way they process images so the resulting image are now slightly different. Looks like they misplaced the black rectangle a bit and now fixed that.\r\n\r\nSingle type, before and after the change:\r\n![before](https://github.com/googleapis/nodejs-dlp/blob/master/samples/system-test/resources/redact-single-type.correct.png?raw=true)\r\n![after](https://github.com/googleapis/nodejs-dlp/blob/fix-redact-samples-tests/samples/system-test/resources/redact-single-type.correct.png?raw=true)\r\n\r\nMultiple types, before and after the change:\r\n![before](https://github.com/googleapis/nodejs-dlp/blob/master/samples/system-test/resources/redact-multiple-types.correct.png?raw=true)\r\n![after](https://github.com/googleapis/nodejs-dlp/blob/fix-redact-samples-tests/samples/system-test/resources/redact-multiple-types.correct.png?raw=true)\r\n\r\nNote: the images will stop showing when the PR is merged and the branch is deleted.\r\n\r\n- [x] Tests and linter pass\r\n- [x] Code coverage does not decrease (if any source code was changed)\r\n- [x] Appropriate docs were updated (if necessary)\r\n","created_at":"2018-05-30T21:54:35Z","updated_at":"2018-05-30T21:54:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/googleapis/nodejs-dlp/pulls/57/commits","review_comments_url":"https://api.github.com/repos/googleapis/nodejs-dlp/pulls/57/comments","review_comment_url":"https://api.github.com/repos/googleapis/nodejs-dlp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/googleapis/nodejs-dlp/issues/57/comments","statuses_url":"https://api.github.com/repos/googleapis/nodejs-dlp/statuses/d81a804480d0d0fe8b60f6c0a06d4f4c74118f37","head":{"label":"googleapis:fix-redact-samples-tests","ref":"fix-redact-samples-tests","sha":"d81a804480d0d0fe8b60f6c0a06d4f4c74118f37","user":{"login":"googleapis","id":16785467,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Nzg1NDY3","avatar_url":"https://avatars3.githubusercontent.com/u/16785467?v=4","gravatar_id":"","url":"https://api.github.com/users/googleapis","html_url":"https://github.com/googleapis","followers_url":"https://api.github.com/users/googleapis/followers","following_url":"https://api.github.com/users/googleapis/following{/other_user}","gists_url":"https://api.github.com/users/googleapis/gists{/gist_id}","starred_url":"https://api.github.com/users/googleapis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googleapis/subscriptions","organizations_url":"https://api.github.com/users/googleapis/orgs","repos_url":"https://api.github.com/users/googleapis/repos","events_url":"https://api.github.com/users/googleapis/events{/privacy}","received_events_url":"https://api.github.com/users/googleapis/received_events","type":"Organization","site_admin":false},"repo":{"id":98463615,"node_id":"MDEwOlJlcG9zaXRvcnk5ODQ2MzYxNQ==","name":"nodejs-dlp","full_name":"googleapis/nodejs-dlp","owner":{"login":"googleapis","id":16785467,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Nzg1NDY3","avatar_url":"https://avatars3.githubusercontent.com/u/16785467?v=4","gravatar_id":"","url":"https://api.github.com/users/googleapis","html_url":"https://github.com/googleapis","followers_url":"https://api.github.com/users/googleapis/followers","following_url":"https://api.github.com/users/googleapis/following{/other_user}","gists_url":"https://api.github.com/users/googleapis/gists{/gist_id}","starred_url":"https://api.github.com/users/googleapis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googleapis/subscriptions","organizations_url":"https://api.github.com/users/googleapis/orgs","repos_url":"https://api.github.com/users/googleapis/repos","events_url":"https://api.github.com/users/googleapis/events{/privacy}","received_events_url":"https://api.github.com/users/googleapis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/googleapis/nodejs-dlp","description":"Node.js client for Google Cloud Data Loss Prevention: Understand and manage sensitive data.","fork":false,"url":"https://api.github.com/repos/googleapis/nodejs-dlp","forks_url":"https://api.github.com/repos/googleapis/nodejs-dlp/forks","keys_url":"https://api.github.com/repos/googleapis/nodejs-dlp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/googleapis/nodejs-dlp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/googleapis/nodejs-dlp/teams","hooks_url":"https://api.github.com/repos/googleapis/nodejs-dlp/hooks","issue_events_url":"https://api.github.com/repos/googleapis/nodejs-dlp/issues/events{/number}","events_url":"https://api.github.com/repos/googleapis/nodejs-dlp/events","assignees_url":"https://api.github.com/repos/googleapis/nodejs-dlp/assignees{/user}","branches_url":"https://api.github.com/repos/googleapis/nodejs-dlp/branches{/branch}","tags_url":"https://api.github.com/repos/googleapis/nodejs-dlp/tags","blobs_url":"https://api.github.com/repos/googleapis/nodejs-dlp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/googleapis/nodejs-dlp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/googleapis/nodejs-dlp/git/refs{/sha}","trees_url":"https://api.github.com/repos/googleapis/nodejs-dlp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/googleapis/nodejs-dlp/statuses/{sha}","languages_url":"https://api.github.com/repos/googleapis/nodejs-dlp/languages","stargazers_url":"https://api.github.com/repos/googleapis/nodejs-dlp/stargazers","contributors_url":"https://api.github.com/repos/googleapis/nodejs-dlp/contributors","subscribers_url":"https://api.github.com/repos/googleapis/nodejs-dlp/subscribers","subscription_url":"https://api.github.com/repos/googleapis/nodejs-dlp/subscription","commits_url":"https://api.github.com/repos/googleapis/nodejs-dlp/commits{/sha}","git_commits_url":"https://api.github.com/repos/googleapis/nodejs-dlp/git/commits{/sha}","comments_url":"https://api.github.com/repos/googleapis/nodejs-dlp/comments{/number}","issue_comment_url":"https://api.github.com/repos/googleapis/nodejs-dlp/issues/comments{/number}","contents_url":"https://api.github.com/repos/googleapis/nodejs-dlp/contents/{+path}","compare_url":"https://api.github.com/repos/googleapis/nodejs-dlp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/googleapis/nodejs-dlp/merges","archive_url":"https://api.github.com/repos/googleapis/nodejs-dlp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/googleapis/nodejs-dlp/downloads","issues_url":"https://api.github.com/repos/googleapis/nodejs-dlp/issues{/number}","pulls_url":"https://api.github.com/repos/googleapis/nodejs-dlp/pulls{/number}","milestones_url":"https://api.github.com/repos/googleapis/nodejs-dlp/milestones{/number}","notifications_url":"https://api.github.com/repos/googleapis/nodejs-dlp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/googleapis/nodejs-dlp/labels{/name}","releases_url":"https://api.github.com/repos/googleapis/nodejs-dlp/releases{/id}","deployments_url":"https://api.github.com/repos/googleapis/nodejs-dlp/deployments","created_at":"2017-07-26T20:33:42Z","updated_at":"2018-05-25T04:56:19Z","pushed_at":"2018-05-30T21:49:49Z","git_url":"git://github.com/googleapis/nodejs-dlp.git","ssh_url":"git@github.com:googleapis/nodejs-dlp.git","clone_url":"https://github.com/googleapis/nodejs-dlp.git","svn_url":"https://github.com/googleapis/nodejs-dlp","homepage":"https://cloud.google.com/dlp/","size":1227,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":6,"open_issues":4,"watchers":4,"default_branch":"master"}},"base":{"label":"googleapis:master","ref":"master","sha":"a93e4dd60cc7b6197343c0d96e1abd394ea6100d","user":{"login":"googleapis","id":16785467,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Nzg1NDY3","avatar_url":"https://avatars3.githubusercontent.com/u/16785467?v=4","gravatar_id":"","url":"https://api.github.com/users/googleapis","html_url":"https://github.com/googleapis","followers_url":"https://api.github.com/users/googleapis/followers","following_url":"https://api.github.com/users/googleapis/following{/other_user}","gists_url":"https://api.github.com/users/googleapis/gists{/gist_id}","starred_url":"https://api.github.com/users/googleapis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googleapis/subscriptions","organizations_url":"https://api.github.com/users/googleapis/orgs","repos_url":"https://api.github.com/users/googleapis/repos","events_url":"https://api.github.com/users/googleapis/events{/privacy}","received_events_url":"https://api.github.com/users/googleapis/received_events","type":"Organization","site_admin":false},"repo":{"id":98463615,"node_id":"MDEwOlJlcG9zaXRvcnk5ODQ2MzYxNQ==","name":"nodejs-dlp","full_name":"googleapis/nodejs-dlp","owner":{"login":"googleapis","id":16785467,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Nzg1NDY3","avatar_url":"https://avatars3.githubusercontent.com/u/16785467?v=4","gravatar_id":"","url":"https://api.github.com/users/googleapis","html_url":"https://github.com/googleapis","followers_url":"https://api.github.com/users/googleapis/followers","following_url":"https://api.github.com/users/googleapis/following{/other_user}","gists_url":"https://api.github.com/users/googleapis/gists{/gist_id}","starred_url":"https://api.github.com/users/googleapis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googleapis/subscriptions","organizations_url":"https://api.github.com/users/googleapis/orgs","repos_url":"https://api.github.com/users/googleapis/repos","events_url":"https://api.github.com/users/googleapis/events{/privacy}","received_events_url":"https://api.github.com/users/googleapis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/googleapis/nodejs-dlp","description":"Node.js client for Google Cloud Data Loss Prevention: Understand and manage sensitive data.","fork":false,"url":"https://api.github.com/repos/googleapis/nodejs-dlp","forks_url":"https://api.github.com/repos/googleapis/nodejs-dlp/forks","keys_url":"https://api.github.com/repos/googleapis/nodejs-dlp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/googleapis/nodejs-dlp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/googleapis/nodejs-dlp/teams","hooks_url":"https://api.github.com/repos/googleapis/nodejs-dlp/hooks","issue_events_url":"https://api.github.com/repos/googleapis/nodejs-dlp/issues/events{/number}","events_url":"https://api.github.com/repos/googleapis/nodejs-dlp/events","assignees_url":"https://api.github.com/repos/googleapis/nodejs-dlp/assignees{/user}","branches_url":"https://api.github.com/repos/googleapis/nodejs-dlp/branches{/branch}","tags_url":"https://api.github.com/repos/googleapis/nodejs-dlp/tags","blobs_url":"https://api.github.com/repos/googleapis/nodejs-dlp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/googleapis/nodejs-dlp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/googleapis/nodejs-dlp/git/refs{/sha}","trees_url":"https://api.github.com/repos/googleapis/nodejs-dlp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/googleapis/nodejs-dlp/statuses/{sha}","languages_url":"https://api.github.com/repos/googleapis/nodejs-dlp/languages","stargazers_url":"https://api.github.com/repos/googleapis/nodejs-dlp/stargazers","contributors_url":"https://api.github.com/repos/googleapis/nodejs-dlp/contributors","subscribers_url":"https://api.github.com/repos/googleapis/nodejs-dlp/subscribers","subscription_url":"https://api.github.com/repos/googleapis/nodejs-dlp/subscription","commits_url":"https://api.github.com/repos/googleapis/nodejs-dlp/commits{/sha}","git_commits_url":"https://api.github.com/repos/googleapis/nodejs-dlp/git/commits{/sha}","comments_url":"https://api.github.com/repos/googleapis/nodejs-dlp/comments{/number}","issue_comment_url":"https://api.github.com/repos/googleapis/nodejs-dlp/issues/comments{/number}","contents_url":"https://api.github.com/repos/googleapis/nodejs-dlp/contents/{+path}","compare_url":"https://api.github.com/repos/googleapis/nodejs-dlp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/googleapis/nodejs-dlp/merges","archive_url":"https://api.github.com/repos/googleapis/nodejs-dlp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/googleapis/nodejs-dlp/downloads","issues_url":"https://api.github.com/repos/googleapis/nodejs-dlp/issues{/number}","pulls_url":"https://api.github.com/repos/googleapis/nodejs-dlp/pulls{/number}","milestones_url":"https://api.github.com/repos/googleapis/nodejs-dlp/milestones{/number}","notifications_url":"https://api.github.com/repos/googleapis/nodejs-dlp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/googleapis/nodejs-dlp/labels{/name}","releases_url":"https://api.github.com/repos/googleapis/nodejs-dlp/releases{/id}","deployments_url":"https://api.github.com/repos/googleapis/nodejs-dlp/deployments","created_at":"2017-07-26T20:33:42Z","updated_at":"2018-05-25T04:56:19Z","pushed_at":"2018-05-30T21:49:49Z","git_url":"git://github.com/googleapis/nodejs-dlp.git","ssh_url":"git@github.com:googleapis/nodejs-dlp.git","clone_url":"https://github.com/googleapis/nodejs-dlp.git","svn_url":"https://github.com/googleapis/nodejs-dlp","homepage":"https://cloud.google.com/dlp/","size":1227,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":6,"open_issues":4,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/googleapis/nodejs-dlp/pulls/57"},"html":{"href":"https://github.com/googleapis/nodejs-dlp/pull/57"},"issue":{"href":"https://api.github.com/repos/googleapis/nodejs-dlp/issues/57"},"comments":{"href":"https://api.github.com/repos/googleapis/nodejs-dlp/issues/57/comments"},"review_comments":{"href":"https://api.github.com/repos/googleapis/nodejs-dlp/pulls/57/comments"},"review_comment":{"href":"https://api.github.com/repos/googleapis/nodejs-dlp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/googleapis/nodejs-dlp/pulls/57/commits"},"statuses":{"href":"https://api.github.com/repos/googleapis/nodejs-dlp/statuses/d81a804480d0d0fe8b60f6c0a06d4f4c74118f37"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":0,"deletions":0,"changed_files":2}}
{"actor":{"display_login":"alexander-fenster"}}