{"action":"created","comment":{"url":"https://api.github.com/repos/wso2/carbon-identity-framework/pulls/comments/173363117","pull_request_review_id":102542185,"id":173363117,"diff_hunk":"@@ -119,5 +120,8 @@ privacy.policy.for.more.details=for more details.\n under.construction=This page is under construction \n by.selecting.following.attributes=By selecting following attributes I agree to share them with the above service provider. \n select.all=Select All \n-for.scopes=for Scopes\n-for.attributes=for Attributes\n+requested.scopes=Requested scopes\n+requested.attributes=Requested attributes\n+please.select.approve.always=Please select either \"Approve Always\" or \"Approve\" to provide consent to requested scopes to continue\n+ok=Ok\n+mandatory.claims=Mandatory claims","path":"components/authentication-framework/org.wso2.carbon.identity.application.authentication.endpoint/src/main/resources/org/wso2/carbon/identity/application/authentication/endpoint/i18n/Resources.properties","position":18,"original_position":18,"commit_id":"f719b264e45231b10e75c6c198c04dac37cdb435","original_commit_id":"c17d2bed2cafadf673bb2bf31c9e18931f1b661d","user":{"login":"thusithak","id":11048376,"avatar_url":"https://avatars3.githubusercontent.com/u/11048376?v=4","gravatar_id":"","url":"https://api.github.com/users/thusithak","html_url":"https://github.com/thusithak","followers_url":"https://api.github.com/users/thusithak/followers","following_url":"https://api.github.com/users/thusithak/following{/other_user}","gists_url":"https://api.github.com/users/thusithak/gists{/gist_id}","starred_url":"https://api.github.com/users/thusithak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thusithak/subscriptions","organizations_url":"https://api.github.com/users/thusithak/orgs","repos_url":"https://api.github.com/users/thusithak/repos","events_url":"https://api.github.com/users/thusithak/events{/privacy}","received_events_url":"https://api.github.com/users/thusithak/received_events","type":"User","site_admin":false},"body":"Fixed with f719b264e45231b10e75c6c198c04dac37cdb435","created_at":"2018-03-09T04:27:13Z","updated_at":"2018-03-09T04:27:14Z","html_url":"https://github.com/wso2/carbon-identity-framework/pull/1449#discussion_r173363117","pull_request_url":"https://api.github.com/repos/wso2/carbon-identity-framework/pulls/1449","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/wso2/carbon-identity-framework/pulls/comments/173363117"},"html":{"href":"https://github.com/wso2/carbon-identity-framework/pull/1449#discussion_r173363117"},"pull_request":{"href":"https://api.github.com/repos/wso2/carbon-identity-framework/pulls/1449"}},"in_reply_to_id":173183997},"pull_request":{"url":"https://api.github.com/repos/wso2/carbon-identity-framework/pulls/1449","id":173721242,"html_url":"https://github.com/wso2/carbon-identity-framework/pull/1449","diff_url":"https://github.com/wso2/carbon-identity-framework/pull/1449.diff","patch_url":"https://github.com/wso2/carbon-identity-framework/pull/1449.patch","issue_url":"https://api.github.com/repos/wso2/carbon-identity-framework/issues/1449","number":1449,"state":"open","locked":false,"title":"Scope and Attribute sections style fixes for OpenID user claims UI","user":{"login":"thusithak","id":11048376,"avatar_url":"https://avatars3.githubusercontent.com/u/11048376?v=4","gravatar_id":"","url":"https://api.github.com/users/thusithak","html_url":"https://github.com/thusithak","followers_url":"https://api.github.com/users/thusithak/followers","following_url":"https://api.github.com/users/thusithak/following{/other_user}","gists_url":"https://api.github.com/users/thusithak/gists{/gist_id}","starred_url":"https://api.github.com/users/thusithak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thusithak/subscriptions","organizations_url":"https://api.github.com/users/thusithak/orgs","repos_url":"https://api.github.com/users/thusithak/repos","events_url":"https://api.github.com/users/thusithak/events{/privacy}","received_events_url":"https://api.github.com/users/thusithak/received_events","type":"User","site_admin":false},"body":"### Proposed changes in this pull request\r\n\r\n\r\n- $subject\r\n\r\n### When should this PR be merged\r\n\r\nASAP\r\n\r\n\r\n### Follow up actions\r\n\r\n- None\r\n\r\n\r\n### Checklist (for reviewing)\r\n\r\n#### General\r\n\r\n- [ ] **Is this PR explained thoroughly?** All code changes must be accounted for in the PR description.\r\n- [ ] **Is the PR labeled correctly?**\r\n\r\n#### Functionality\r\n\r\n- [ ] **Are all requirements met?** Compare implemented functionality with the requirements specification.\r\n- [ ] **Does the UI work as expected?** There should be no Javascript errors in the console; all resources should load. There should be no unexpected errors. Deliberately try to break the feature to find out if there are corner cases that are not handled.\r\n\r\n#### Code\r\n\r\n- [ ] **Do you fully understand the introduced changes to the code?** If not ask for clarification, it might uncover ways to solve a problem in a more elegant and efficient way.\r\n- [ ] **Does the PR introduce any inefficient database requests?** Use the debug server to check for duplicate requests.\r\n- [ ] **Are all necessary strings marked for translation?** All strings that are exposed to users via the UI must be [marked for translation](https://docs.djangoproject.com/en/1.10/topics/i18n/translation/).\r\n\r\n#### Tests\r\n\r\n- [ ] **Are there sufficient test cases?** Ensure that all components are tested individually; models, forms, and serializers should be tested in isolation even if a test for a view covers these components.\r\n- [ ] **If this is a bug fix, are tests for the issue in place?**  There must be a test case for the bug to ensure the issue won’t regress. Make sure that the tests break without the new code to fix the issue.\r\n- [ ] **If this is a new feature or a significant change to an existing feature?** has the manual testing spreadsheet been updated with instructions for manual testing?\r\n\r\n#### Security\r\n\r\n- [ ] **Confirm this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.**\r\n- [ ] **Are all UI and API inputs run through forms or serializers?**\r\n- [ ] **Are all external inputs validated and sanitized appropriately?**\r\n- [ ] **Does all branching logic have a default case?**\r\n- [ ] **Does this solution handle outliers and edge cases gracefully?**\r\n- [ ] **Are all external communications secured and restricted to SSL?**\r\n\r\n#### Documentation\r\n\r\n- [ ] **Are changes to the UI documented in the platform docs?** If this PR introduces new platform site functionality or changes existing ones, the changes should be documented.\r\n- [ ] **Are changes to the API documented in the API docs?** If this PR introduces new API functionality or changes existing ones, the changes must be documented.\r\n- [ ] **Are reusable components documented?** If this PR introduces components that are relevant to other developers (for instance a mixin for a view or a generic form) they should be documented in the Wiki.\r\n","created_at":"2018-03-08T12:17:50Z","updated_at":"2018-03-09T04:27:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0fae58012e04ed33e0773d059c860ae56a38fc98","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/wso2/carbon-identity-framework/pulls/1449/commits","review_comments_url":"https://api.github.com/repos/wso2/carbon-identity-framework/pulls/1449/comments","review_comment_url":"https://api.github.com/repos/wso2/carbon-identity-framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wso2/carbon-identity-framework/issues/1449/comments","statuses_url":"https://api.github.com/repos/wso2/carbon-identity-framework/statuses/f719b264e45231b10e75c6c198c04dac37cdb435","head":{"label":"thusithak:user_claims_ui_fixes","ref":"user_claims_ui_fixes","sha":"f719b264e45231b10e75c6c198c04dac37cdb435","user":{"login":"thusithak","id":11048376,"avatar_url":"https://avatars3.githubusercontent.com/u/11048376?v=4","gravatar_id":"","url":"https://api.github.com/users/thusithak","html_url":"https://github.com/thusithak","followers_url":"https://api.github.com/users/thusithak/followers","following_url":"https://api.github.com/users/thusithak/following{/other_user}","gists_url":"https://api.github.com/users/thusithak/gists{/gist_id}","starred_url":"https://api.github.com/users/thusithak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thusithak/subscriptions","organizations_url":"https://api.github.com/users/thusithak/orgs","repos_url":"https://api.github.com/users/thusithak/repos","events_url":"https://api.github.com/users/thusithak/events{/privacy}","received_events_url":"https://api.github.com/users/thusithak/received_events","type":"User","site_admin":false},"repo":{"id":116219605,"name":"carbon-identity-framework","full_name":"thusithak/carbon-identity-framework","owner":{"login":"thusithak","id":11048376,"avatar_url":"https://avatars3.githubusercontent.com/u/11048376?v=4","gravatar_id":"","url":"https://api.github.com/users/thusithak","html_url":"https://github.com/thusithak","followers_url":"https://api.github.com/users/thusithak/followers","following_url":"https://api.github.com/users/thusithak/following{/other_user}","gists_url":"https://api.github.com/users/thusithak/gists{/gist_id}","starred_url":"https://api.github.com/users/thusithak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thusithak/subscriptions","organizations_url":"https://api.github.com/users/thusithak/orgs","repos_url":"https://api.github.com/users/thusithak/repos","events_url":"https://api.github.com/users/thusithak/events{/privacy}","received_events_url":"https://api.github.com/users/thusithak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/thusithak/carbon-identity-framework","description":null,"fork":true,"url":"https://api.github.com/repos/thusithak/carbon-identity-framework","forks_url":"https://api.github.com/repos/thusithak/carbon-identity-framework/forks","keys_url":"https://api.github.com/repos/thusithak/carbon-identity-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thusithak/carbon-identity-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thusithak/carbon-identity-framework/teams","hooks_url":"https://api.github.com/repos/thusithak/carbon-identity-framework/hooks","issue_events_url":"https://api.github.com/repos/thusithak/carbon-identity-framework/issues/events{/number}","events_url":"https://api.github.com/repos/thusithak/carbon-identity-framework/events","assignees_url":"https://api.github.com/repos/thusithak/carbon-identity-framework/assignees{/user}","branches_url":"https://api.github.com/repos/thusithak/carbon-identity-framework/branches{/branch}","tags_url":"https://api.github.com/repos/thusithak/carbon-identity-framework/tags","blobs_url":"https://api.github.com/repos/thusithak/carbon-identity-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thusithak/carbon-identity-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thusithak/carbon-identity-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/thusithak/carbon-identity-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thusithak/carbon-identity-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/thusithak/carbon-identity-framework/languages","stargazers_url":"https://api.github.com/repos/thusithak/carbon-identity-framework/stargazers","contributors_url":"https://api.github.com/repos/thusithak/carbon-identity-framework/contributors","subscribers_url":"https://api.github.com/repos/thusithak/carbon-identity-framework/subscribers","subscription_url":"https://api.github.com/repos/thusithak/carbon-identity-framework/subscription","commits_url":"https://api.github.com/repos/thusithak/carbon-identity-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/thusithak/carbon-identity-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/thusithak/carbon-identity-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/thusithak/carbon-identity-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/thusithak/carbon-identity-framework/contents/{+path}","compare_url":"https://api.github.com/repos/thusithak/carbon-identity-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thusithak/carbon-identity-framework/merges","archive_url":"https://api.github.com/repos/thusithak/carbon-identity-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thusithak/carbon-identity-framework/downloads","issues_url":"https://api.github.com/repos/thusithak/carbon-identity-framework/issues{/number}","pulls_url":"https://api.github.com/repos/thusithak/carbon-identity-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/thusithak/carbon-identity-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/thusithak/carbon-identity-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thusithak/carbon-identity-framework/labels{/name}","releases_url":"https://api.github.com/repos/thusithak/carbon-identity-framework/releases{/id}","deployments_url":"https://api.github.com/repos/thusithak/carbon-identity-framework/deployments","created_at":"2018-01-04T05:42:00Z","updated_at":"2018-01-04T05:42:08Z","pushed_at":"2018-03-09T04:24:09Z","git_url":"git://github.com/thusithak/carbon-identity-framework.git","ssh_url":"git@github.com:thusithak/carbon-identity-framework.git","clone_url":"https://github.com/thusithak/carbon-identity-framework.git","svn_url":"https://github.com/thusithak/carbon-identity-framework","homepage":null,"size":93825,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wso2:5.11.x","ref":"5.11.x","sha":"d4653fee4e506e8cd2374d4659bafe08603a7919","user":{"login":"wso2","id":533043,"avatar_url":"https://avatars3.githubusercontent.com/u/533043?v=4","gravatar_id":"","url":"https://api.github.com/users/wso2","html_url":"https://github.com/wso2","followers_url":"https://api.github.com/users/wso2/followers","following_url":"https://api.github.com/users/wso2/following{/other_user}","gists_url":"https://api.github.com/users/wso2/gists{/gist_id}","starred_url":"https://api.github.com/users/wso2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wso2/subscriptions","organizations_url":"https://api.github.com/users/wso2/orgs","repos_url":"https://api.github.com/users/wso2/repos","events_url":"https://api.github.com/users/wso2/events{/privacy}","received_events_url":"https://api.github.com/users/wso2/received_events","type":"Organization","site_admin":false},"repo":{"id":52329722,"name":"carbon-identity-framework","full_name":"wso2/carbon-identity-framework","owner":{"login":"wso2","id":533043,"avatar_url":"https://avatars3.githubusercontent.com/u/533043?v=4","gravatar_id":"","url":"https://api.github.com/users/wso2","html_url":"https://github.com/wso2","followers_url":"https://api.github.com/users/wso2/followers","following_url":"https://api.github.com/users/wso2/following{/other_user}","gists_url":"https://api.github.com/users/wso2/gists{/gist_id}","starred_url":"https://api.github.com/users/wso2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wso2/subscriptions","organizations_url":"https://api.github.com/users/wso2/orgs","repos_url":"https://api.github.com/users/wso2/repos","events_url":"https://api.github.com/users/wso2/events{/privacy}","received_events_url":"https://api.github.com/users/wso2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wso2/carbon-identity-framework","description":null,"fork":false,"url":"https://api.github.com/repos/wso2/carbon-identity-framework","forks_url":"https://api.github.com/repos/wso2/carbon-identity-framework/forks","keys_url":"https://api.github.com/repos/wso2/carbon-identity-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wso2/carbon-identity-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wso2/carbon-identity-framework/teams","hooks_url":"https://api.github.com/repos/wso2/carbon-identity-framework/hooks","issue_events_url":"https://api.github.com/repos/wso2/carbon-identity-framework/issues/events{/number}","events_url":"https://api.github.com/repos/wso2/carbon-identity-framework/events","assignees_url":"https://api.github.com/repos/wso2/carbon-identity-framework/assignees{/user}","branches_url":"https://api.github.com/repos/wso2/carbon-identity-framework/branches{/branch}","tags_url":"https://api.github.com/repos/wso2/carbon-identity-framework/tags","blobs_url":"https://api.github.com/repos/wso2/carbon-identity-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wso2/carbon-identity-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wso2/carbon-identity-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/wso2/carbon-identity-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wso2/carbon-identity-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/wso2/carbon-identity-framework/languages","stargazers_url":"https://api.github.com/repos/wso2/carbon-identity-framework/stargazers","contributors_url":"https://api.github.com/repos/wso2/carbon-identity-framework/contributors","subscribers_url":"https://api.github.com/repos/wso2/carbon-identity-framework/subscribers","subscription_url":"https://api.github.com/repos/wso2/carbon-identity-framework/subscription","commits_url":"https://api.github.com/repos/wso2/carbon-identity-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/wso2/carbon-identity-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/wso2/carbon-identity-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/wso2/carbon-identity-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/wso2/carbon-identity-framework/contents/{+path}","compare_url":"https://api.github.com/repos/wso2/carbon-identity-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wso2/carbon-identity-framework/merges","archive_url":"https://api.github.com/repos/wso2/carbon-identity-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wso2/carbon-identity-framework/downloads","issues_url":"https://api.github.com/repos/wso2/carbon-identity-framework/issues{/number}","pulls_url":"https://api.github.com/repos/wso2/carbon-identity-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/wso2/carbon-identity-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/wso2/carbon-identity-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wso2/carbon-identity-framework/labels{/name}","releases_url":"https://api.github.com/repos/wso2/carbon-identity-framework/releases{/id}","deployments_url":"https://api.github.com/repos/wso2/carbon-identity-framework/deployments","created_at":"2016-02-23T04:20:26Z","updated_at":"2018-02-05T10:27:51Z","pushed_at":"2018-03-09T04:24:11Z","git_url":"git://github.com/wso2/carbon-identity-framework.git","ssh_url":"git@github.com:wso2/carbon-identity-framework.git","clone_url":"https://github.com/wso2/carbon-identity-framework.git","svn_url":"https://github.com/wso2/carbon-identity-framework","homepage":null,"size":94334,"stargazers_count":13,"watchers_count":13,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":160,"mirror_url":null,"archived":false,"open_issues_count":24,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":160,"open_issues":24,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wso2/carbon-identity-framework/pulls/1449"},"html":{"href":"https://github.com/wso2/carbon-identity-framework/pull/1449"},"issue":{"href":"https://api.github.com/repos/wso2/carbon-identity-framework/issues/1449"},"comments":{"href":"https://api.github.com/repos/wso2/carbon-identity-framework/issues/1449/comments"},"review_comments":{"href":"https://api.github.com/repos/wso2/carbon-identity-framework/pulls/1449/comments"},"review_comment":{"href":"https://api.github.com/repos/wso2/carbon-identity-framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wso2/carbon-identity-framework/pulls/1449/commits"},"statuses":{"href":"https://api.github.com/repos/wso2/carbon-identity-framework/statuses/f719b264e45231b10e75c6c198c04dac37cdb435"}},"author_association":"NONE"}}
{"actor":{"display_login":"thusithak"}}