{"action":"closed","number":58,"pull_request":{"url":"https://api.github.com/repos/UKHomeOffice/asl-service/pulls/58","id":195211932,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1MjExOTMy","html_url":"https://github.com/UKHomeOffice/asl-service/pull/58","diff_url":"https://github.com/UKHomeOffice/asl-service/pull/58.diff","patch_url":"https://github.com/UKHomeOffice/asl-service/pull/58.patch","issue_url":"https://api.github.com/repos/UKHomeOffice/asl-service/issues/58","number":58,"state":"closed","locked":false,"title":"Set locals as static data","user":{"login":"lennym","id":117398,"node_id":"MDQ6VXNlcjExNzM5OA==","avatar_url":"https://avatars3.githubusercontent.com/u/117398?v=4","gravatar_id":"","url":"https://api.github.com/users/lennym","html_url":"https://github.com/lennym","followers_url":"https://api.github.com/users/lennym/followers","following_url":"https://api.github.com/users/lennym/following{/other_user}","gists_url":"https://api.github.com/users/lennym/gists{/gist_id}","starred_url":"https://api.github.com/users/lennym/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lennym/subscriptions","organizations_url":"https://api.github.com/users/lennym/orgs","repos_url":"https://api.github.com/users/lennym/repos","events_url":"https://api.github.com/users/lennym/events{/privacy}","received_events_url":"https://api.github.com/users/lennym/received_events","type":"User","site_admin":false},"body":"Rather than pushing all of the data we ever use into a redux store, which forces us to expose actions and reducers for data that won't ever change on the client, instead keep all of the locals as locals, and then take the subset which is needed to be used in the client and pass to a redux store.","created_at":"2018-06-15T15:37:28Z","updated_at":"2018-06-18T09:35:25Z","closed_at":"2018-06-18T09:35:25Z","merged_at":null,"merge_commit_sha":"f66c03c0fa7710b6b17e89b75b38054085e5acef","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/UKHomeOffice/asl-service/pulls/58/commits","review_comments_url":"https://api.github.com/repos/UKHomeOffice/asl-service/pulls/58/comments","review_comment_url":"https://api.github.com/repos/UKHomeOffice/asl-service/pulls/comments{/number}","comments_url":"https://api.github.com/repos/UKHomeOffice/asl-service/issues/58/comments","statuses_url":"https://api.github.com/repos/UKHomeOffice/asl-service/statuses/39ea91bc764f9daf3c31df0ec8ecce51b4bf20bd","head":{"label":"UKHomeOffice:feature/static-locals","ref":"feature/static-locals","sha":"39ea91bc764f9daf3c31df0ec8ecce51b4bf20bd","user":{"login":"UKHomeOffice","id":3778081,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3NzgwODE=","avatar_url":"https://avatars2.githubusercontent.com/u/3778081?v=4","gravatar_id":"","url":"https://api.github.com/users/UKHomeOffice","html_url":"https://github.com/UKHomeOffice","followers_url":"https://api.github.com/users/UKHomeOffice/followers","following_url":"https://api.github.com/users/UKHomeOffice/following{/other_user}","gists_url":"https://api.github.com/users/UKHomeOffice/gists{/gist_id}","starred_url":"https://api.github.com/users/UKHomeOffice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UKHomeOffice/subscriptions","organizations_url":"https://api.github.com/users/UKHomeOffice/orgs","repos_url":"https://api.github.com/users/UKHomeOffice/repos","events_url":"https://api.github.com/users/UKHomeOffice/events{/privacy}","received_events_url":"https://api.github.com/users/UKHomeOffice/received_events","type":"Organization","site_admin":false},"repo":{"id":118924369,"node_id":"MDEwOlJlcG9zaXRvcnkxMTg5MjQzNjk=","name":"asl-service","full_name":"UKHomeOffice/asl-service","owner":{"login":"UKHomeOffice","id":3778081,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3NzgwODE=","avatar_url":"https://avatars2.githubusercontent.com/u/3778081?v=4","gravatar_id":"","url":"https://api.github.com/users/UKHomeOffice","html_url":"https://github.com/UKHomeOffice","followers_url":"https://api.github.com/users/UKHomeOffice/followers","following_url":"https://api.github.com/users/UKHomeOffice/following{/other_user}","gists_url":"https://api.github.com/users/UKHomeOffice/gists{/gist_id}","starred_url":"https://api.github.com/users/UKHomeOffice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UKHomeOffice/subscriptions","organizations_url":"https://api.github.com/users/UKHomeOffice/orgs","repos_url":"https://api.github.com/users/UKHomeOffice/repos","events_url":"https://api.github.com/users/UKHomeOffice/events{/privacy}","received_events_url":"https://api.github.com/users/UKHomeOffice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/UKHomeOffice/asl-service","description":null,"fork":false,"url":"https://api.github.com/repos/UKHomeOffice/asl-service","forks_url":"https://api.github.com/repos/UKHomeOffice/asl-service/forks","keys_url":"https://api.github.com/repos/UKHomeOffice/asl-service/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UKHomeOffice/asl-service/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UKHomeOffice/asl-service/teams","hooks_url":"https://api.github.com/repos/UKHomeOffice/asl-service/hooks","issue_events_url":"https://api.github.com/repos/UKHomeOffice/asl-service/issues/events{/number}","events_url":"https://api.github.com/repos/UKHomeOffice/asl-service/events","assignees_url":"https://api.github.com/repos/UKHomeOffice/asl-service/assignees{/user}","branches_url":"https://api.github.com/repos/UKHomeOffice/asl-service/branches{/branch}","tags_url":"https://api.github.com/repos/UKHomeOffice/asl-service/tags","blobs_url":"https://api.github.com/repos/UKHomeOffice/asl-service/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UKHomeOffice/asl-service/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UKHomeOffice/asl-service/git/refs{/sha}","trees_url":"https://api.github.com/repos/UKHomeOffice/asl-service/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UKHomeOffice/asl-service/statuses/{sha}","languages_url":"https://api.github.com/repos/UKHomeOffice/asl-service/languages","stargazers_url":"https://api.github.com/repos/UKHomeOffice/asl-service/stargazers","contributors_url":"https://api.github.com/repos/UKHomeOffice/asl-service/contributors","subscribers_url":"https://api.github.com/repos/UKHomeOffice/asl-service/subscribers","subscription_url":"https://api.github.com/repos/UKHomeOffice/asl-service/subscription","commits_url":"https://api.github.com/repos/UKHomeOffice/asl-service/commits{/sha}","git_commits_url":"https://api.github.com/repos/UKHomeOffice/asl-service/git/commits{/sha}","comments_url":"https://api.github.com/repos/UKHomeOffice/asl-service/comments{/number}","issue_comment_url":"https://api.github.com/repos/UKHomeOffice/asl-service/issues/comments{/number}","contents_url":"https://api.github.com/repos/UKHomeOffice/asl-service/contents/{+path}","compare_url":"https://api.github.com/repos/UKHomeOffice/asl-service/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UKHomeOffice/asl-service/merges","archive_url":"https://api.github.com/repos/UKHomeOffice/asl-service/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UKHomeOffice/asl-service/downloads","issues_url":"https://api.github.com/repos/UKHomeOffice/asl-service/issues{/number}","pulls_url":"https://api.github.com/repos/UKHomeOffice/asl-service/pulls{/number}","milestones_url":"https://api.github.com/repos/UKHomeOffice/asl-service/milestones{/number}","notifications_url":"https://api.github.com/repos/UKHomeOffice/asl-service/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UKHomeOffice/asl-service/labels{/name}","releases_url":"https://api.github.com/repos/UKHomeOffice/asl-service/releases{/id}","deployments_url":"https://api.github.com/repos/UKHomeOffice/asl-service/deployments","created_at":"2018-01-25T14:38:05Z","updated_at":"2018-06-18T09:30:11Z","pushed_at":"2018-06-18T09:34:44Z","git_url":"git://github.com/UKHomeOffice/asl-service.git","ssh_url":"git@github.com:UKHomeOffice/asl-service.git","clone_url":"https://github.com/UKHomeOffice/asl-service.git","svn_url":"https://github.com/UKHomeOffice/asl-service","homepage":null,"size":670,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"UKHomeOffice:master","ref":"master","sha":"b9eaa7eb349e666353b2560c905c1c36f2d0dcfa","user":{"login":"UKHomeOffice","id":3778081,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3NzgwODE=","avatar_url":"https://avatars2.githubusercontent.com/u/3778081?v=4","gravatar_id":"","url":"https://api.github.com/users/UKHomeOffice","html_url":"https://github.com/UKHomeOffice","followers_url":"https://api.github.com/users/UKHomeOffice/followers","following_url":"https://api.github.com/users/UKHomeOffice/following{/other_user}","gists_url":"https://api.github.com/users/UKHomeOffice/gists{/gist_id}","starred_url":"https://api.github.com/users/UKHomeOffice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UKHomeOffice/subscriptions","organizations_url":"https://api.github.com/users/UKHomeOffice/orgs","repos_url":"https://api.github.com/users/UKHomeOffice/repos","events_url":"https://api.github.com/users/UKHomeOffice/events{/privacy}","received_events_url":"https://api.github.com/users/UKHomeOffice/received_events","type":"Organization","site_admin":false},"repo":{"id":118924369,"node_id":"MDEwOlJlcG9zaXRvcnkxMTg5MjQzNjk=","name":"asl-service","full_name":"UKHomeOffice/asl-service","owner":{"login":"UKHomeOffice","id":3778081,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3NzgwODE=","avatar_url":"https://avatars2.githubusercontent.com/u/3778081?v=4","gravatar_id":"","url":"https://api.github.com/users/UKHomeOffice","html_url":"https://github.com/UKHomeOffice","followers_url":"https://api.github.com/users/UKHomeOffice/followers","following_url":"https://api.github.com/users/UKHomeOffice/following{/other_user}","gists_url":"https://api.github.com/users/UKHomeOffice/gists{/gist_id}","starred_url":"https://api.github.com/users/UKHomeOffice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UKHomeOffice/subscriptions","organizations_url":"https://api.github.com/users/UKHomeOffice/orgs","repos_url":"https://api.github.com/users/UKHomeOffice/repos","events_url":"https://api.github.com/users/UKHomeOffice/events{/privacy}","received_events_url":"https://api.github.com/users/UKHomeOffice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/UKHomeOffice/asl-service","description":null,"fork":false,"url":"https://api.github.com/repos/UKHomeOffice/asl-service","forks_url":"https://api.github.com/repos/UKHomeOffice/asl-service/forks","keys_url":"https://api.github.com/repos/UKHomeOffice/asl-service/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UKHomeOffice/asl-service/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UKHomeOffice/asl-service/teams","hooks_url":"https://api.github.com/repos/UKHomeOffice/asl-service/hooks","issue_events_url":"https://api.github.com/repos/UKHomeOffice/asl-service/issues/events{/number}","events_url":"https://api.github.com/repos/UKHomeOffice/asl-service/events","assignees_url":"https://api.github.com/repos/UKHomeOffice/asl-service/assignees{/user}","branches_url":"https://api.github.com/repos/UKHomeOffice/asl-service/branches{/branch}","tags_url":"https://api.github.com/repos/UKHomeOffice/asl-service/tags","blobs_url":"https://api.github.com/repos/UKHomeOffice/asl-service/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UKHomeOffice/asl-service/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UKHomeOffice/asl-service/git/refs{/sha}","trees_url":"https://api.github.com/repos/UKHomeOffice/asl-service/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UKHomeOffice/asl-service/statuses/{sha}","languages_url":"https://api.github.com/repos/UKHomeOffice/asl-service/languages","stargazers_url":"https://api.github.com/repos/UKHomeOffice/asl-service/stargazers","contributors_url":"https://api.github.com/repos/UKHomeOffice/asl-service/contributors","subscribers_url":"https://api.github.com/repos/UKHomeOffice/asl-service/subscribers","subscription_url":"https://api.github.com/repos/UKHomeOffice/asl-service/subscription","commits_url":"https://api.github.com/repos/UKHomeOffice/asl-service/commits{/sha}","git_commits_url":"https://api.github.com/repos/UKHomeOffice/asl-service/git/commits{/sha}","comments_url":"https://api.github.com/repos/UKHomeOffice/asl-service/comments{/number}","issue_comment_url":"https://api.github.com/repos/UKHomeOffice/asl-service/issues/comments{/number}","contents_url":"https://api.github.com/repos/UKHomeOffice/asl-service/contents/{+path}","compare_url":"https://api.github.com/repos/UKHomeOffice/asl-service/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UKHomeOffice/asl-service/merges","archive_url":"https://api.github.com/repos/UKHomeOffice/asl-service/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UKHomeOffice/asl-service/downloads","issues_url":"https://api.github.com/repos/UKHomeOffice/asl-service/issues{/number}","pulls_url":"https://api.github.com/repos/UKHomeOffice/asl-service/pulls{/number}","milestones_url":"https://api.github.com/repos/UKHomeOffice/asl-service/milestones{/number}","notifications_url":"https://api.github.com/repos/UKHomeOffice/asl-service/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UKHomeOffice/asl-service/labels{/name}","releases_url":"https://api.github.com/repos/UKHomeOffice/asl-service/releases{/id}","deployments_url":"https://api.github.com/repos/UKHomeOffice/asl-service/deployments","created_at":"2018-01-25T14:38:05Z","updated_at":"2018-06-18T09:30:11Z","pushed_at":"2018-06-18T09:34:44Z","git_url":"git://github.com/UKHomeOffice/asl-service.git","ssh_url":"git@github.com:UKHomeOffice/asl-service.git","clone_url":"https://github.com/UKHomeOffice/asl-service.git","svn_url":"https://github.com/UKHomeOffice/asl-service","homepage":null,"size":670,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/UKHomeOffice/asl-service/pulls/58"},"html":{"href":"https://github.com/UKHomeOffice/asl-service/pull/58"},"issue":{"href":"https://api.github.com/repos/UKHomeOffice/asl-service/issues/58"},"comments":{"href":"https://api.github.com/repos/UKHomeOffice/asl-service/issues/58/comments"},"review_comments":{"href":"https://api.github.com/repos/UKHomeOffice/asl-service/pulls/58/comments"},"review_comment":{"href":"https://api.github.com/repos/UKHomeOffice/asl-service/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/UKHomeOffice/asl-service/pulls/58/commits"},"statuses":{"href":"https://api.github.com/repos/UKHomeOffice/asl-service/statuses/39ea91bc764f9daf3c31df0ec8ecce51b4bf20bd"}},"author_association":"COLLABORATOR","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"unstable","merged_by":null,"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":11,"deletions":32,"changed_files":2}}
{"actor":{"display_login":"joefitter"}}