{"action":"created","issue":{"url":"https://api.github.com/repos/symfony/symfony/issues/29017","repository_url":"https://api.github.com/repos/symfony/symfony","labels_url":"https://api.github.com/repos/symfony/symfony/issues/29017/labels{/name}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/29017/comments","events_url":"https://api.github.com/repos/symfony/symfony/issues/29017/events","html_url":"https://github.com/symfony/symfony/pull/29017","id":375008911,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2NTU0MTMw","number":29017,"title":"Add support for complex expressions in twig globals","user":{"login":"ddegasperi","id":270297,"node_id":"MDQ6VXNlcjI3MDI5Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/270297?v=4","gravatar_id":"","url":"https://api.github.com/users/ddegasperi","html_url":"https://github.com/ddegasperi","followers_url":"https://api.github.com/users/ddegasperi/followers","following_url":"https://api.github.com/users/ddegasperi/following{/other_user}","gists_url":"https://api.github.com/users/ddegasperi/gists{/gist_id}","starred_url":"https://api.github.com/users/ddegasperi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddegasperi/subscriptions","organizations_url":"https://api.github.com/users/ddegasperi/orgs","repos_url":"https://api.github.com/users/ddegasperi/repos","events_url":"https://api.github.com/users/ddegasperi/events{/privacy}","received_events_url":"https://api.github.com/users/ddegasperi/received_events","type":"User","site_admin":false},"labels":[{"id":100378,"node_id":"MDU6TGFiZWwxMDAzNzg=","url":"https://api.github.com/repos/symfony/symfony/labels/Feature","name":"Feature","color":"02e10c","default":false},{"id":237003792,"node_id":"MDU6TGFiZWwyMzcwMDM3OTI=","url":"https://api.github.com/repos/symfony/symfony/labels/Status:%20Needs%20Review","name":"Status: Needs Review","color":"ededed","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/symfony/symfony/milestones/18","html_url":"https://github.com/symfony/symfony/milestone/18","labels_url":"https://api.github.com/repos/symfony/symfony/milestones/18/labels","id":3234645,"node_id":"MDk6TWlsZXN0b25lMzIzNDY0NQ==","number":18,"title":"next","description":"https://symfony.com/roadmap?version=4.2#checker","creator":{"login":"nicolas-grekas","id":243674,"node_id":"MDQ6VXNlcjI0MzY3NA==","avatar_url":"https://avatars3.githubusercontent.com/u/243674?v=4","gravatar_id":"","url":"https://api.github.com/users/nicolas-grekas","html_url":"https://github.com/nicolas-grekas","followers_url":"https://api.github.com/users/nicolas-grekas/followers","following_url":"https://api.github.com/users/nicolas-grekas/following{/other_user}","gists_url":"https://api.github.com/users/nicolas-grekas/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolas-grekas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolas-grekas/subscriptions","organizations_url":"https://api.github.com/users/nicolas-grekas/orgs","repos_url":"https://api.github.com/users/nicolas-grekas/repos","events_url":"https://api.github.com/users/nicolas-grekas/events{/privacy}","received_events_url":"https://api.github.com/users/nicolas-grekas/received_events","type":"User","site_admin":false},"open_issues":159,"closed_issues":8,"state":"open","created_at":"2018-04-02T12:03:21Z","updated_at":"2018-11-12T08:21:02Z","due_on":null,"closed_at":null},"comments":5,"created_at":"2018-10-29T13:13:43Z","updated_at":"2018-11-12T08:21:02Z","closed_at":"2018-11-12T08:21:02Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/29017","html_url":"https://github.com/symfony/symfony/pull/29017","diff_url":"https://github.com/symfony/symfony/pull/29017.diff","patch_url":"https://github.com/symfony/symfony/pull/29017.patch"},"body":"| Q             | A\r\n| ------------- | ---\r\n| Branch?       | master\r\n| Bug fix?      | no\r\n| New feature?  | yes\r\n| BC breaks?    | no\r\n| Deprecations? | no\r\n| Tests pass?   | yes\r\n| Fixed tickets | -\r\n| License       | MIT\r\n| Doc PR        | https://github.com/symfony/symfony-docs/pull/10601\r\n\r\nThis new feature add support to inject values based on complex expressions into twig globals.\r\n\r\nExample:\r\n\r\n```yaml\r\n\r\ntwig:\r\n    globals:\r\n        myvar: '@=service(\"App\\Service\").getMyVar()'\r\n\r\n```"},"comment":{"url":"https://api.github.com/repos/symfony/symfony/issues/comments/437793896","html_url":"https://github.com/symfony/symfony/pull/29017#issuecomment-437793896","issue_url":"https://api.github.com/repos/symfony/symfony/issues/29017","id":437793896,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNzc5Mzg5Ng==","user":{"login":"javiereguiluz","id":73419,"node_id":"MDQ6VXNlcjczNDE5","avatar_url":"https://avatars3.githubusercontent.com/u/73419?v=4","gravatar_id":"","url":"https://api.github.com/users/javiereguiluz","html_url":"https://github.com/javiereguiluz","followers_url":"https://api.github.com/users/javiereguiluz/followers","following_url":"https://api.github.com/users/javiereguiluz/following{/other_user}","gists_url":"https://api.github.com/users/javiereguiluz/gists{/gist_id}","starred_url":"https://api.github.com/users/javiereguiluz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javiereguiluz/subscriptions","organizations_url":"https://api.github.com/users/javiereguiluz/orgs","repos_url":"https://api.github.com/users/javiereguiluz/repos","events_url":"https://api.github.com/users/javiereguiluz/events{/privacy}","received_events_url":"https://api.github.com/users/javiereguiluz/received_events","type":"User","site_admin":false},"created_at":"2018-11-12T08:21:02Z","updated_at":"2018-11-12T08:21:02Z","author_association":"MEMBER","body":"After reading Fabien's comment I think I'm 👎 too about this proposal. The example you showed (`myvar: '@=service(\"App\\Service\").getMyVar()'`) is convenient to use in some cases ... but it looks like trying to develop PHP code using YAML syntax ... so maybe it's better to leave it to a Twig extension.\r\n\r\nGiven the downvotes from the Core Team, I'm closing this pull request. @ddegasperi I'm sorry your proposal didn't make it this time (and it was going to be your first Symfony contribution, so I'm even more sad) but there will be more opportunities to contribute. Thanks!"}}
{"actor":{"display_login":"javiereguiluz"}}