{"action":"created","comment":{"url":"https://api.github.com/repos/google/importlab/pulls/comments/192471099","pull_request_review_id":125262033,"id":192471099,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MjQ3MTA5OQ==","diff_hunk":"@@ -24,10 +24,7 @@ def format_file_node(import_graph, node, indent):\n     if isinstance(f, resolve.Direct):\n         out = '+ ' + f.short_path\n     elif isinstance(f, resolve.Local):\n-        out = os.path.relpath(f.path, f.fs.path)\n-    elif isinstance(f, resolve.Relative):\n-        # TODO(martindemello): Format depending on provenance[f.from_path]\n-        out = '. ' + f.short_path\n+        out = '  ' + os.path.relpath(f.path, f.fs.path)","path":"importlab/output.py","position":11,"original_position":8,"commit_id":"8086ec52206936192095b112ca7ce394079bdac3","original_commit_id":"8086ec52206936192095b112ca7ce394079bdac3","user":{"login":"rchen152","id":4142312,"node_id":"MDQ6VXNlcjQxNDIzMTI=","avatar_url":"https://avatars2.githubusercontent.com/u/4142312?v=4","gravatar_id":"","url":"https://api.github.com/users/rchen152","html_url":"https://github.com/rchen152","followers_url":"https://api.github.com/users/rchen152/followers","following_url":"https://api.github.com/users/rchen152/following{/other_user}","gists_url":"https://api.github.com/users/rchen152/gists{/gist_id}","starred_url":"https://api.github.com/users/rchen152/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rchen152/subscriptions","organizations_url":"https://api.github.com/users/rchen152/orgs","repos_url":"https://api.github.com/users/rchen152/repos","events_url":"https://api.github.com/users/rchen152/events{/privacy}","received_events_url":"https://api.github.com/users/rchen152/received_events","type":"User","site_admin":false},"body":"I'm seeing an attribute error on this line:\r\n```\r\nFile \"/usr/local/lib/python3.6/dist-packages/importlab-0.1.1-py3.6.egg/importlab/output.py\", line 27, in format_file_node\r\n    out = '  ' + os.path.relpath(f.path, f.fs.path)\r\nAttributeError: 'OSFileSystem' object has no attribute 'path'\r\n```","created_at":"2018-06-01T17:57:28Z","updated_at":"2018-06-01T18:04:19Z","html_url":"https://github.com/google/importlab/pull/6#discussion_r192471099","pull_request_url":"https://api.github.com/repos/google/importlab/pulls/6","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/google/importlab/pulls/comments/192471099"},"html":{"href":"https://github.com/google/importlab/pull/6#discussion_r192471099"},"pull_request":{"href":"https://api.github.com/repos/google/importlab/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/google/importlab/pulls/6","id":191872913,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxODcyOTEz","html_url":"https://github.com/google/importlab/pull/6","diff_url":"https://github.com/google/importlab/pull/6.diff","patch_url":"https://github.com/google/importlab/pull/6.patch","issue_url":"https://api.github.com/repos/google/importlab/issues/6","number":6,"state":"open","locked":false,"title":"add a current_module to the resolver to resolve relative module names","user":{"login":"martindemello","id":16215,"node_id":"MDQ6VXNlcjE2MjE1","avatar_url":"https://avatars2.githubusercontent.com/u/16215?v=4","gravatar_id":"","url":"https://api.github.com/users/martindemello","html_url":"https://github.com/martindemello","followers_url":"https://api.github.com/users/martindemello/followers","following_url":"https://api.github.com/users/martindemello/following{/other_user}","gists_url":"https://api.github.com/users/martindemello/gists{/gist_id}","starred_url":"https://api.github.com/users/martindemello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martindemello/subscriptions","organizations_url":"https://api.github.com/users/martindemello/orgs","repos_url":"https://api.github.com/users/martindemello/repos","events_url":"https://api.github.com/users/martindemello/events{/privacy}","received_events_url":"https://api.github.com/users/martindemello/received_events","type":"User","site_admin":false},"body":"Tries to infer the module name for directly added files (relative to the specified pythonpath), so that at the time we create a Resolver, we have a module (a ResolvedFile instance) to use to qualify relative module names.","created_at":"2018-05-31T21:01:57Z","updated_at":"2018-06-01T18:04:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"070c85ba82f8e4fba72386bd5eb3e5116323facc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/google/importlab/pulls/6/commits","review_comments_url":"https://api.github.com/repos/google/importlab/pulls/6/comments","review_comment_url":"https://api.github.com/repos/google/importlab/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/importlab/issues/6/comments","statuses_url":"https://api.github.com/repos/google/importlab/statuses/8086ec52206936192095b112ca7ce394079bdac3","head":{"label":"google:relative-paths","ref":"relative-paths","sha":"8086ec52206936192095b112ca7ce394079bdac3","user":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":123326542,"node_id":"MDEwOlJlcG9zaXRvcnkxMjMzMjY1NDI=","name":"importlab","full_name":"google/importlab","owner":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/importlab","description":null,"fork":false,"url":"https://api.github.com/repos/google/importlab","forks_url":"https://api.github.com/repos/google/importlab/forks","keys_url":"https://api.github.com/repos/google/importlab/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/importlab/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/importlab/teams","hooks_url":"https://api.github.com/repos/google/importlab/hooks","issue_events_url":"https://api.github.com/repos/google/importlab/issues/events{/number}","events_url":"https://api.github.com/repos/google/importlab/events","assignees_url":"https://api.github.com/repos/google/importlab/assignees{/user}","branches_url":"https://api.github.com/repos/google/importlab/branches{/branch}","tags_url":"https://api.github.com/repos/google/importlab/tags","blobs_url":"https://api.github.com/repos/google/importlab/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/importlab/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/importlab/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/importlab/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/importlab/statuses/{sha}","languages_url":"https://api.github.com/repos/google/importlab/languages","stargazers_url":"https://api.github.com/repos/google/importlab/stargazers","contributors_url":"https://api.github.com/repos/google/importlab/contributors","subscribers_url":"https://api.github.com/repos/google/importlab/subscribers","subscription_url":"https://api.github.com/repos/google/importlab/subscription","commits_url":"https://api.github.com/repos/google/importlab/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/importlab/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/importlab/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/importlab/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/importlab/contents/{+path}","compare_url":"https://api.github.com/repos/google/importlab/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/importlab/merges","archive_url":"https://api.github.com/repos/google/importlab/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/importlab/downloads","issues_url":"https://api.github.com/repos/google/importlab/issues{/number}","pulls_url":"https://api.github.com/repos/google/importlab/pulls{/number}","milestones_url":"https://api.github.com/repos/google/importlab/milestones{/number}","notifications_url":"https://api.github.com/repos/google/importlab/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/importlab/labels{/name}","releases_url":"https://api.github.com/repos/google/importlab/releases{/id}","deployments_url":"https://api.github.com/repos/google/importlab/deployments","created_at":"2018-02-28T18:40:33Z","updated_at":"2018-05-29T23:50:57Z","pushed_at":"2018-06-01T08:32:33Z","git_url":"git://github.com/google/importlab.git","ssh_url":"git@github.com:google/importlab.git","clone_url":"https://github.com/google/importlab.git","svn_url":"https://github.com/google/importlab","homepage":null,"size":154,"stargazers_count":14,"watchers_count":14,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3,"open_issues":1,"watchers":14,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"208f210b461429a15a29e4c44499bc0f9759bb54","user":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":123326542,"node_id":"MDEwOlJlcG9zaXRvcnkxMjMzMjY1NDI=","name":"importlab","full_name":"google/importlab","owner":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/importlab","description":null,"fork":false,"url":"https://api.github.com/repos/google/importlab","forks_url":"https://api.github.com/repos/google/importlab/forks","keys_url":"https://api.github.com/repos/google/importlab/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/importlab/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/importlab/teams","hooks_url":"https://api.github.com/repos/google/importlab/hooks","issue_events_url":"https://api.github.com/repos/google/importlab/issues/events{/number}","events_url":"https://api.github.com/repos/google/importlab/events","assignees_url":"https://api.github.com/repos/google/importlab/assignees{/user}","branches_url":"https://api.github.com/repos/google/importlab/branches{/branch}","tags_url":"https://api.github.com/repos/google/importlab/tags","blobs_url":"https://api.github.com/repos/google/importlab/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/importlab/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/importlab/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/importlab/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/importlab/statuses/{sha}","languages_url":"https://api.github.com/repos/google/importlab/languages","stargazers_url":"https://api.github.com/repos/google/importlab/stargazers","contributors_url":"https://api.github.com/repos/google/importlab/contributors","subscribers_url":"https://api.github.com/repos/google/importlab/subscribers","subscription_url":"https://api.github.com/repos/google/importlab/subscription","commits_url":"https://api.github.com/repos/google/importlab/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/importlab/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/importlab/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/importlab/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/importlab/contents/{+path}","compare_url":"https://api.github.com/repos/google/importlab/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/importlab/merges","archive_url":"https://api.github.com/repos/google/importlab/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/importlab/downloads","issues_url":"https://api.github.com/repos/google/importlab/issues{/number}","pulls_url":"https://api.github.com/repos/google/importlab/pulls{/number}","milestones_url":"https://api.github.com/repos/google/importlab/milestones{/number}","notifications_url":"https://api.github.com/repos/google/importlab/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/importlab/labels{/name}","releases_url":"https://api.github.com/repos/google/importlab/releases{/id}","deployments_url":"https://api.github.com/repos/google/importlab/deployments","created_at":"2018-02-28T18:40:33Z","updated_at":"2018-05-29T23:50:57Z","pushed_at":"2018-06-01T08:32:33Z","git_url":"git://github.com/google/importlab.git","ssh_url":"git@github.com:google/importlab.git","clone_url":"https://github.com/google/importlab.git","svn_url":"https://github.com/google/importlab","homepage":null,"size":154,"stargazers_count":14,"watchers_count":14,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3,"open_issues":1,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/importlab/pulls/6"},"html":{"href":"https://github.com/google/importlab/pull/6"},"issue":{"href":"https://api.github.com/repos/google/importlab/issues/6"},"comments":{"href":"https://api.github.com/repos/google/importlab/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/google/importlab/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/google/importlab/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/importlab/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/google/importlab/statuses/8086ec52206936192095b112ca7ce394079bdac3"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"rchen152"}}