{"action":"created","comment":{"url":"https://api.github.com/repos/USGS-Astrogeology/SensorUtils/pulls/comments/211470959","pull_request_review_id":147895253,"id":211470959,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTQ3MDk1OQ==","diff_hunk":"@@ -1,41 +1,61 @@\n-#include <gtest/gtest.h>\n+#include \"gmock/gmock.h\"\n \n #include <cmath>\n #include <vector>\n \n-#include \"sensorcore.h\"\n-#include \"Sensor.h\"\n-\n-TEST(declination, AlphaCentauri) {\n-  Sensor sensor(\"test\", \"test\");\n-   const double rad2deg = 180.0/M_PI;\n-  //coordinates are given in heliocentric-xyz parsecs\n-  //The truth data was taken from SIMBAD:\n-  //http://simbad.u-strasbg.fr/simbad/\n-  CartesianVector coords{-0.495304,-0.414169,-1.15686};\n-  double declination = sensor.declination(coords);\n-  EXPECT_NEAR(-60.83399269, rad2deg * declination, 1e-4);\n-}\n+#include \"../api/sensorcore.h\"\n+#include \"../api/Sensor.h\"\n+#include \"../include/SensorModel.h\"\n+#include \"../include/ShapeModel.h\"","path":"tests/SensorCoreTesting.cpp","position":23,"original_position":23,"commit_id":"c46d8995f8f93d80fabde0da306c393f72fd65fc","original_commit_id":"c46d8995f8f93d80fabde0da306c393f72fd65fc","user":{"login":"jlaura","id":2105468,"node_id":"MDQ6VXNlcjIxMDU0Njg=","avatar_url":"https://avatars3.githubusercontent.com/u/2105468?v=4","gravatar_id":"","url":"https://api.github.com/users/jlaura","html_url":"https://github.com/jlaura","followers_url":"https://api.github.com/users/jlaura/followers","following_url":"https://api.github.com/users/jlaura/following{/other_user}","gists_url":"https://api.github.com/users/jlaura/gists{/gist_id}","starred_url":"https://api.github.com/users/jlaura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlaura/subscriptions","organizations_url":"https://api.github.com/users/jlaura/orgs","repos_url":"https://api.github.com/users/jlaura/repos","events_url":"https://api.github.com/users/jlaura/events{/privacy}","received_events_url":"https://api.github.com/users/jlaura/received_events","type":"User","site_admin":false},"body":"Are includes like this bad form? How does one include the 'private' includes in the implementation?","created_at":"2018-08-21T03:47:57Z","updated_at":"2018-08-21T03:49:21Z","html_url":"https://github.com/USGS-Astrogeology/SensorUtils/pull/158#discussion_r211470959","pull_request_url":"https://api.github.com/repos/USGS-Astrogeology/SensorUtils/pulls/158","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/USGS-Astrogeology/SensorUtils/pulls/comments/211470959"},"html":{"href":"https://github.com/USGS-Astrogeology/SensorUtils/pull/158#discussion_r211470959"},"pull_request":{"href":"https://api.github.com/repos/USGS-Astrogeology/SensorUtils/pulls/158"}}},"pull_request":{"url":"https://api.github.com/repos/USGS-Astrogeology/SensorUtils/pulls/158","id":209700156,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5NzAwMTU2","html_url":"https://github.com/USGS-Astrogeology/SensorUtils/pull/158","diff_url":"https://github.com/USGS-Astrogeology/SensorUtils/pull/158.diff","patch_url":"https://github.com/USGS-Astrogeology/SensorUtils/pull/158.patch","issue_url":"https://api.github.com/repos/USGS-Astrogeology/SensorUtils/issues/158","number":158,"state":"open","locked":false,"title":"Refactoring for dep. injection","user":{"login":"jlaura","id":2105468,"node_id":"MDQ6VXNlcjIxMDU0Njg=","avatar_url":"https://avatars3.githubusercontent.com/u/2105468?v=4","gravatar_id":"","url":"https://api.github.com/users/jlaura","html_url":"https://github.com/jlaura","followers_url":"https://api.github.com/users/jlaura/followers","following_url":"https://api.github.com/users/jlaura/following{/other_user}","gists_url":"https://api.github.com/users/jlaura/gists{/gist_id}","starred_url":"https://api.github.com/users/jlaura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlaura/subscriptions","organizations_url":"https://api.github.com/users/jlaura/orgs","repos_url":"https://api.github.com/users/jlaura/repos","events_url":"https://api.github.com/users/jlaura/events{/privacy}","received_events_url":"https://api.github.com/users/jlaura/received_events","type":"User","site_admin":false},"body":"I am going to add comments inline, since I fear more questions than solutions.","created_at":"2018-08-21T03:39:44Z","updated_at":"2018-08-21T03:49:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e03056745996968c06202d241819befa6dbcddc3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/USGS-Astrogeology/SensorUtils/pulls/158/commits","review_comments_url":"https://api.github.com/repos/USGS-Astrogeology/SensorUtils/pulls/158/comments","review_comment_url":"https://api.github.com/repos/USGS-Astrogeology/SensorUtils/pulls/comments{/number}","comments_url":"https://api.github.com/repos/USGS-Astrogeology/SensorUtils/issues/158/comments","statuses_url":"https://api.github.com/repos/USGS-Astrogeology/SensorUtils/statuses/c46d8995f8f93d80fabde0da306c393f72fd65fc","head":{"label":"jlaura:master","ref":"master","sha":"c46d8995f8f93d80fabde0da306c393f72fd65fc","user":{"login":"jlaura","id":2105468,"node_id":"MDQ6VXNlcjIxMDU0Njg=","avatar_url":"https://avatars3.githubusercontent.com/u/2105468?v=4","gravatar_id":"","url":"https://api.github.com/users/jlaura","html_url":"https://github.com/jlaura","followers_url":"https://api.github.com/users/jlaura/followers","following_url":"https://api.github.com/users/jlaura/following{/other_user}","gists_url":"https://api.github.com/users/jlaura/gists{/gist_id}","starred_url":"https://api.github.com/users/jlaura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlaura/subscriptions","organizations_url":"https://api.github.com/users/jlaura/orgs","repos_url":"https://api.github.com/users/jlaura/repos","events_url":"https://api.github.com/users/jlaura/events{/privacy}","received_events_url":"https://api.github.com/users/jlaura/received_events","type":"User","site_admin":false},"repo":{"id":143326505,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMzMjY1MDU=","name":"SensorUtils","full_name":"jlaura/SensorUtils","owner":{"login":"jlaura","id":2105468,"node_id":"MDQ6VXNlcjIxMDU0Njg=","avatar_url":"https://avatars3.githubusercontent.com/u/2105468?v=4","gravatar_id":"","url":"https://api.github.com/users/jlaura","html_url":"https://github.com/jlaura","followers_url":"https://api.github.com/users/jlaura/followers","following_url":"https://api.github.com/users/jlaura/following{/other_user}","gists_url":"https://api.github.com/users/jlaura/gists{/gist_id}","starred_url":"https://api.github.com/users/jlaura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlaura/subscriptions","organizations_url":"https://api.github.com/users/jlaura/orgs","repos_url":"https://api.github.com/users/jlaura/repos","events_url":"https://api.github.com/users/jlaura/events{/privacy}","received_events_url":"https://api.github.com/users/jlaura/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jlaura/SensorUtils","description":null,"fork":true,"url":"https://api.github.com/repos/jlaura/SensorUtils","forks_url":"https://api.github.com/repos/jlaura/SensorUtils/forks","keys_url":"https://api.github.com/repos/jlaura/SensorUtils/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jlaura/SensorUtils/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jlaura/SensorUtils/teams","hooks_url":"https://api.github.com/repos/jlaura/SensorUtils/hooks","issue_events_url":"https://api.github.com/repos/jlaura/SensorUtils/issues/events{/number}","events_url":"https://api.github.com/repos/jlaura/SensorUtils/events","assignees_url":"https://api.github.com/repos/jlaura/SensorUtils/assignees{/user}","branches_url":"https://api.github.com/repos/jlaura/SensorUtils/branches{/branch}","tags_url":"https://api.github.com/repos/jlaura/SensorUtils/tags","blobs_url":"https://api.github.com/repos/jlaura/SensorUtils/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jlaura/SensorUtils/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jlaura/SensorUtils/git/refs{/sha}","trees_url":"https://api.github.com/repos/jlaura/SensorUtils/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jlaura/SensorUtils/statuses/{sha}","languages_url":"https://api.github.com/repos/jlaura/SensorUtils/languages","stargazers_url":"https://api.github.com/repos/jlaura/SensorUtils/stargazers","contributors_url":"https://api.github.com/repos/jlaura/SensorUtils/contributors","subscribers_url":"https://api.github.com/repos/jlaura/SensorUtils/subscribers","subscription_url":"https://api.github.com/repos/jlaura/SensorUtils/subscription","commits_url":"https://api.github.com/repos/jlaura/SensorUtils/commits{/sha}","git_commits_url":"https://api.github.com/repos/jlaura/SensorUtils/git/commits{/sha}","comments_url":"https://api.github.com/repos/jlaura/SensorUtils/comments{/number}","issue_comment_url":"https://api.github.com/repos/jlaura/SensorUtils/issues/comments{/number}","contents_url":"https://api.github.com/repos/jlaura/SensorUtils/contents/{+path}","compare_url":"https://api.github.com/repos/jlaura/SensorUtils/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jlaura/SensorUtils/merges","archive_url":"https://api.github.com/repos/jlaura/SensorUtils/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jlaura/SensorUtils/downloads","issues_url":"https://api.github.com/repos/jlaura/SensorUtils/issues{/number}","pulls_url":"https://api.github.com/repos/jlaura/SensorUtils/pulls{/number}","milestones_url":"https://api.github.com/repos/jlaura/SensorUtils/milestones{/number}","notifications_url":"https://api.github.com/repos/jlaura/SensorUtils/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jlaura/SensorUtils/labels{/name}","releases_url":"https://api.github.com/repos/jlaura/SensorUtils/releases{/id}","deployments_url":"https://api.github.com/repos/jlaura/SensorUtils/deployments","created_at":"2018-08-02T17:37:51Z","updated_at":"2018-08-21T03:39:04Z","pushed_at":"2018-08-21T03:39:01Z","git_url":"git://github.com/jlaura/SensorUtils.git","ssh_url":"git@github.com:jlaura/SensorUtils.git","clone_url":"https://github.com/jlaura/SensorUtils.git","svn_url":"https://github.com/jlaura/SensorUtils","homepage":null,"size":94,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"USGS-Astrogeology:master","ref":"master","sha":"64db1c7fbd5083ccaa4b9156571483c3d582bd4b","user":{"login":"USGS-Astrogeology","id":8268981,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyNjg5ODE=","avatar_url":"https://avatars2.githubusercontent.com/u/8268981?v=4","gravatar_id":"","url":"https://api.github.com/users/USGS-Astrogeology","html_url":"https://github.com/USGS-Astrogeology","followers_url":"https://api.github.com/users/USGS-Astrogeology/followers","following_url":"https://api.github.com/users/USGS-Astrogeology/following{/other_user}","gists_url":"https://api.github.com/users/USGS-Astrogeology/gists{/gist_id}","starred_url":"https://api.github.com/users/USGS-Astrogeology/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/USGS-Astrogeology/subscriptions","organizations_url":"https://api.github.com/users/USGS-Astrogeology/orgs","repos_url":"https://api.github.com/users/USGS-Astrogeology/repos","events_url":"https://api.github.com/users/USGS-Astrogeology/events{/privacy}","received_events_url":"https://api.github.com/users/USGS-Astrogeology/received_events","type":"Organization","site_admin":false},"repo":{"id":143192079,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMxOTIwNzk=","name":"SensorUtils","full_name":"USGS-Astrogeology/SensorUtils","owner":{"login":"USGS-Astrogeology","id":8268981,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyNjg5ODE=","avatar_url":"https://avatars2.githubusercontent.com/u/8268981?v=4","gravatar_id":"","url":"https://api.github.com/users/USGS-Astrogeology","html_url":"https://github.com/USGS-Astrogeology","followers_url":"https://api.github.com/users/USGS-Astrogeology/followers","following_url":"https://api.github.com/users/USGS-Astrogeology/following{/other_user}","gists_url":"https://api.github.com/users/USGS-Astrogeology/gists{/gist_id}","starred_url":"https://api.github.com/users/USGS-Astrogeology/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/USGS-Astrogeology/subscriptions","organizations_url":"https://api.github.com/users/USGS-Astrogeology/orgs","repos_url":"https://api.github.com/users/USGS-Astrogeology/repos","events_url":"https://api.github.com/users/USGS-Astrogeology/events{/privacy}","received_events_url":"https://api.github.com/users/USGS-Astrogeology/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/USGS-Astrogeology/SensorUtils","description":null,"fork":false,"url":"https://api.github.com/repos/USGS-Astrogeology/SensorUtils","forks_url":"https://api.github.com/repos/USGS-Astrogeology/SensorUtils/forks","keys_url":"https://api.github.com/repos/USGS-Astrogeology/SensorUtils/keys{/key_id}","collaborators_url":"https://api.github.com/repos/USGS-Astrogeology/SensorUtils/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/USGS-Astrogeology/SensorUtils/teams","hooks_url":"https://api.github.com/repos/USGS-Astrogeology/SensorUtils/hooks","issue_events_url":"https://api.github.com/repos/USGS-Astrogeology/SensorUtils/issues/events{/number}","events_url":"https://api.github.com/repos/USGS-Astrogeology/SensorUtils/events","assignees_url":"https://api.github.com/repos/USGS-Astrogeology/SensorUtils/assignees{/user}","branches_url":"https://api.github.com/repos/USGS-Astrogeology/SensorUtils/branches{/branch}","tags_url":"https://api.github.com/repos/USGS-Astrogeology/SensorUtils/tags","blobs_url":"https://api.github.com/repos/USGS-Astrogeology/SensorUtils/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/USGS-Astrogeology/SensorUtils/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/USGS-Astrogeology/SensorUtils/git/refs{/sha}","trees_url":"https://api.github.com/repos/USGS-Astrogeology/SensorUtils/git/trees{/sha}","statuses_url":"https://api.github.com/repos/USGS-Astrogeology/SensorUtils/statuses/{sha}","languages_url":"https://api.github.com/repos/USGS-Astrogeology/SensorUtils/languages","stargazers_url":"https://api.github.com/repos/USGS-Astrogeology/SensorUtils/stargazers","contributors_url":"https://api.github.com/repos/USGS-Astrogeology/SensorUtils/contributors","subscribers_url":"https://api.github.com/repos/USGS-Astrogeology/SensorUtils/subscribers","subscription_url":"https://api.github.com/repos/USGS-Astrogeology/SensorUtils/subscription","commits_url":"https://api.github.com/repos/USGS-Astrogeology/SensorUtils/commits{/sha}","git_commits_url":"https://api.github.com/repos/USGS-Astrogeology/SensorUtils/git/commits{/sha}","comments_url":"https://api.github.com/repos/USGS-Astrogeology/SensorUtils/comments{/number}","issue_comment_url":"https://api.github.com/repos/USGS-Astrogeology/SensorUtils/issues/comments{/number}","contents_url":"https://api.github.com/repos/USGS-Astrogeology/SensorUtils/contents/{+path}","compare_url":"https://api.github.com/repos/USGS-Astrogeology/SensorUtils/compare/{base}...{head}","merges_url":"https://api.github.com/repos/USGS-Astrogeology/SensorUtils/merges","archive_url":"https://api.github.com/repos/USGS-Astrogeology/SensorUtils/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/USGS-Astrogeology/SensorUtils/downloads","issues_url":"https://api.github.com/repos/USGS-Astrogeology/SensorUtils/issues{/number}","pulls_url":"https://api.github.com/repos/USGS-Astrogeology/SensorUtils/pulls{/number}","milestones_url":"https://api.github.com/repos/USGS-Astrogeology/SensorUtils/milestones{/number}","notifications_url":"https://api.github.com/repos/USGS-Astrogeology/SensorUtils/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/USGS-Astrogeology/SensorUtils/labels{/name}","releases_url":"https://api.github.com/repos/USGS-Astrogeology/SensorUtils/releases{/id}","deployments_url":"https://api.github.com/repos/USGS-Astrogeology/SensorUtils/deployments","created_at":"2018-08-01T18:15:03Z","updated_at":"2018-08-17T20:30:25Z","pushed_at":"2018-08-21T03:39:44Z","git_url":"git://github.com/USGS-Astrogeology/SensorUtils.git","ssh_url":"git@github.com:USGS-Astrogeology/SensorUtils.git","clone_url":"https://github.com/USGS-Astrogeology/SensorUtils.git","svn_url":"https://github.com/USGS-Astrogeology/SensorUtils","homepage":null,"size":96,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":70,"license":null,"forks":8,"open_issues":70,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/USGS-Astrogeology/SensorUtils/pulls/158"},"html":{"href":"https://github.com/USGS-Astrogeology/SensorUtils/pull/158"},"issue":{"href":"https://api.github.com/repos/USGS-Astrogeology/SensorUtils/issues/158"},"comments":{"href":"https://api.github.com/repos/USGS-Astrogeology/SensorUtils/issues/158/comments"},"review_comments":{"href":"https://api.github.com/repos/USGS-Astrogeology/SensorUtils/pulls/158/comments"},"review_comment":{"href":"https://api.github.com/repos/USGS-Astrogeology/SensorUtils/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/USGS-Astrogeology/SensorUtils/pulls/158/commits"},"statuses":{"href":"https://api.github.com/repos/USGS-Astrogeology/SensorUtils/statuses/c46d8995f8f93d80fabde0da306c393f72fd65fc"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jlaura"}}