{"action":"created","comment":{"url":"https://api.github.com/repos/snapcore/snapd/pulls/comments/199083431","pull_request_review_id":133132587,"id":199083431,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTA4MzQzMQ==","diff_hunk":"@@ -0,0 +1,74 @@\n+// -*- Mode: Go; indent-tabs-mode: t -*-\n+\n+/*\n+ * Copyright (C) 2016-2018 Canonical Ltd\n+ *\n+ * This program is free software: you can redistribute it and/or modify\n+ * it under the terms of the GNU General Public License version 3 as\n+ * published by the Free Software Foundation.\n+ *\n+ * This program is distributed in the hope that it will be useful,\n+ * but WITHOUT ANY WARRANTY; without even the implied warranty of\n+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the\n+ * GNU General Public License for more details.\n+ *\n+ * You should have received a copy of the GNU General Public License\n+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.\n+ *\n+ */\n+\n+package builtin\n+\n+const cifsMountControlSummary = `allows to mount and unmount CIFS shares`\n+\n+const cifsMountControlBaseDeclarationSlots = `\n+  cifs-mount-control:\n+    allow-installation:\n+      slot-snap-type:\n+        - core\n+    deny-auto-connection: true\n+`\n+\n+const cifsMountControlConnectedPlugSecComp = `\n+# Description: Allow mount and umount syscall access.\n+\n+mount\n+umount\n+umount2\n+`\n+\n+const cifsMountControlConnectedPlugAppArmor = `\n+# Description: Allow to mount and unmount CIFS filesystems.","path":"interfaces/builtin/cifs_mount_control.go","position":41,"original_position":41,"commit_id":"67b848f51a4a8e9c94e1d628b9ed401d8ae35144","original_commit_id":"67b848f51a4a8e9c94e1d628b9ed401d8ae35144","user":{"login":"niemeyer","id":378683,"node_id":"MDQ6VXNlcjM3ODY4Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/378683?v=4","gravatar_id":"","url":"https://api.github.com/users/niemeyer","html_url":"https://github.com/niemeyer","followers_url":"https://api.github.com/users/niemeyer/followers","following_url":"https://api.github.com/users/niemeyer/following{/other_user}","gists_url":"https://api.github.com/users/niemeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/niemeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niemeyer/subscriptions","organizations_url":"https://api.github.com/users/niemeyer/orgs","repos_url":"https://api.github.com/users/niemeyer/repos","events_url":"https://api.github.com/users/niemeyer/events{/privacy}","received_events_url":"https://api.github.com/users/niemeyer/received_events","type":"User","site_admin":false},"body":"\"Allow mounting and unmounting\", maybe","created_at":"2018-06-29T08:04:18Z","updated_at":"2018-06-29T08:06:03Z","html_url":"https://github.com/snapcore/snapd/pull/5340#discussion_r199083431","pull_request_url":"https://api.github.com/repos/snapcore/snapd/pulls/5340","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/comments/199083431"},"html":{"href":"https://github.com/snapcore/snapd/pull/5340#discussion_r199083431"},"pull_request":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/5340"}}},"pull_request":{"url":"https://api.github.com/repos/snapcore/snapd/pulls/5340","id":195494687,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1NDk0Njg3","html_url":"https://github.com/snapcore/snapd/pull/5340","diff_url":"https://github.com/snapcore/snapd/pull/5340.diff","patch_url":"https://github.com/snapcore/snapd/pull/5340.patch","issue_url":"https://api.github.com/repos/snapcore/snapd/issues/5340","number":5340,"state":"open","locked":false,"title":"cifs-mount-control interface (discussed in snapcraft.io forum post 5689)","user":{"login":"datenhahn","id":13999666,"node_id":"MDQ6VXNlcjEzOTk5NjY2","avatar_url":"https://avatars3.githubusercontent.com/u/13999666?v=4","gravatar_id":"","url":"https://api.github.com/users/datenhahn","html_url":"https://github.com/datenhahn","followers_url":"https://api.github.com/users/datenhahn/followers","following_url":"https://api.github.com/users/datenhahn/following{/other_user}","gists_url":"https://api.github.com/users/datenhahn/gists{/gist_id}","starred_url":"https://api.github.com/users/datenhahn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datenhahn/subscriptions","organizations_url":"https://api.github.com/users/datenhahn/orgs","repos_url":"https://api.github.com/users/datenhahn/repos","events_url":"https://api.github.com/users/datenhahn/events{/privacy}","received_events_url":"https://api.github.com/users/datenhahn/received_events","type":"User","site_admin":false},"body":"https://forum.snapcraft.io/t/interface-mount-umount-cifs-share-permission/5689\r\n\r\n- an interface which allows mounting and unmounting of cifs shares\r\n- currently not all permissions needed for mount/umount are included,\r\n  it requires snaps to request the mount-observe interface as well\r\n\r\n  - created development environment description and some basic configs/tools to\r\n  test and reproduce my usecase here : https://github.com/datenhahn/devtools-cifs-mount-control\r\n","created_at":"2018-06-18T11:25:16Z","updated_at":"2018-06-29T08:06:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"291a967e02a1d5bf514d6a10d54116c18abe3015","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jdstrand","id":1663079,"node_id":"MDQ6VXNlcjE2NjMwNzk=","avatar_url":"https://avatars0.githubusercontent.com/u/1663079?v=4","gravatar_id":"","url":"https://api.github.com/users/jdstrand","html_url":"https://github.com/jdstrand","followers_url":"https://api.github.com/users/jdstrand/followers","following_url":"https://api.github.com/users/jdstrand/following{/other_user}","gists_url":"https://api.github.com/users/jdstrand/gists{/gist_id}","starred_url":"https://api.github.com/users/jdstrand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdstrand/subscriptions","organizations_url":"https://api.github.com/users/jdstrand/orgs","repos_url":"https://api.github.com/users/jdstrand/repos","events_url":"https://api.github.com/users/jdstrand/events{/privacy}","received_events_url":"https://api.github.com/users/jdstrand/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/snapcore/snapd/milestones/19","html_url":"https://github.com/snapcore/snapd/milestone/19","labels_url":"https://api.github.com/repos/snapcore/snapd/milestones/19/labels","id":3367828,"node_id":"MDk6TWlsZXN0b25lMzM2NzgyOA==","number":19,"title":"2.34","description":"","creator":{"login":"mvo5","id":914418,"node_id":"MDQ6VXNlcjkxNDQxOA==","avatar_url":"https://avatars3.githubusercontent.com/u/914418?v=4","gravatar_id":"","url":"https://api.github.com/users/mvo5","html_url":"https://github.com/mvo5","followers_url":"https://api.github.com/users/mvo5/followers","following_url":"https://api.github.com/users/mvo5/following{/other_user}","gists_url":"https://api.github.com/users/mvo5/gists{/gist_id}","starred_url":"https://api.github.com/users/mvo5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mvo5/subscriptions","organizations_url":"https://api.github.com/users/mvo5/orgs","repos_url":"https://api.github.com/users/mvo5/repos","events_url":"https://api.github.com/users/mvo5/events{/privacy}","received_events_url":"https://api.github.com/users/mvo5/received_events","type":"User","site_admin":false},"open_issues":11,"closed_issues":11,"state":"open","created_at":"2018-05-23T06:30:45Z","updated_at":"2018-06-29T07:54:11Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/snapcore/snapd/pulls/5340/commits","review_comments_url":"https://api.github.com/repos/snapcore/snapd/pulls/5340/comments","review_comment_url":"https://api.github.com/repos/snapcore/snapd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/snapcore/snapd/issues/5340/comments","statuses_url":"https://api.github.com/repos/snapcore/snapd/statuses/67b848f51a4a8e9c94e1d628b9ed401d8ae35144","head":{"label":"datenhahn:feature/snapcraft.io-5689-cifs-mount-control-interface","ref":"feature/snapcraft.io-5689-cifs-mount-control-interface","sha":"67b848f51a4a8e9c94e1d628b9ed401d8ae35144","user":{"login":"datenhahn","id":13999666,"node_id":"MDQ6VXNlcjEzOTk5NjY2","avatar_url":"https://avatars3.githubusercontent.com/u/13999666?v=4","gravatar_id":"","url":"https://api.github.com/users/datenhahn","html_url":"https://github.com/datenhahn","followers_url":"https://api.github.com/users/datenhahn/followers","following_url":"https://api.github.com/users/datenhahn/following{/other_user}","gists_url":"https://api.github.com/users/datenhahn/gists{/gist_id}","starred_url":"https://api.github.com/users/datenhahn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datenhahn/subscriptions","organizations_url":"https://api.github.com/users/datenhahn/orgs","repos_url":"https://api.github.com/users/datenhahn/repos","events_url":"https://api.github.com/users/datenhahn/events{/privacy}","received_events_url":"https://api.github.com/users/datenhahn/received_events","type":"User","site_admin":false},"repo":{"id":136153973,"node_id":"MDEwOlJlcG9zaXRvcnkxMzYxNTM5NzM=","name":"snapd","full_name":"datenhahn/snapd","owner":{"login":"datenhahn","id":13999666,"node_id":"MDQ6VXNlcjEzOTk5NjY2","avatar_url":"https://avatars3.githubusercontent.com/u/13999666?v=4","gravatar_id":"","url":"https://api.github.com/users/datenhahn","html_url":"https://github.com/datenhahn","followers_url":"https://api.github.com/users/datenhahn/followers","following_url":"https://api.github.com/users/datenhahn/following{/other_user}","gists_url":"https://api.github.com/users/datenhahn/gists{/gist_id}","starred_url":"https://api.github.com/users/datenhahn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datenhahn/subscriptions","organizations_url":"https://api.github.com/users/datenhahn/orgs","repos_url":"https://api.github.com/users/datenhahn/repos","events_url":"https://api.github.com/users/datenhahn/events{/privacy}","received_events_url":"https://api.github.com/users/datenhahn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/datenhahn/snapd","description":"The snapd and snap tools enable systems to work with .snap files.","fork":true,"url":"https://api.github.com/repos/datenhahn/snapd","forks_url":"https://api.github.com/repos/datenhahn/snapd/forks","keys_url":"https://api.github.com/repos/datenhahn/snapd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/datenhahn/snapd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/datenhahn/snapd/teams","hooks_url":"https://api.github.com/repos/datenhahn/snapd/hooks","issue_events_url":"https://api.github.com/repos/datenhahn/snapd/issues/events{/number}","events_url":"https://api.github.com/repos/datenhahn/snapd/events","assignees_url":"https://api.github.com/repos/datenhahn/snapd/assignees{/user}","branches_url":"https://api.github.com/repos/datenhahn/snapd/branches{/branch}","tags_url":"https://api.github.com/repos/datenhahn/snapd/tags","blobs_url":"https://api.github.com/repos/datenhahn/snapd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/datenhahn/snapd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/datenhahn/snapd/git/refs{/sha}","trees_url":"https://api.github.com/repos/datenhahn/snapd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/datenhahn/snapd/statuses/{sha}","languages_url":"https://api.github.com/repos/datenhahn/snapd/languages","stargazers_url":"https://api.github.com/repos/datenhahn/snapd/stargazers","contributors_url":"https://api.github.com/repos/datenhahn/snapd/contributors","subscribers_url":"https://api.github.com/repos/datenhahn/snapd/subscribers","subscription_url":"https://api.github.com/repos/datenhahn/snapd/subscription","commits_url":"https://api.github.com/repos/datenhahn/snapd/commits{/sha}","git_commits_url":"https://api.github.com/repos/datenhahn/snapd/git/commits{/sha}","comments_url":"https://api.github.com/repos/datenhahn/snapd/comments{/number}","issue_comment_url":"https://api.github.com/repos/datenhahn/snapd/issues/comments{/number}","contents_url":"https://api.github.com/repos/datenhahn/snapd/contents/{+path}","compare_url":"https://api.github.com/repos/datenhahn/snapd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/datenhahn/snapd/merges","archive_url":"https://api.github.com/repos/datenhahn/snapd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/datenhahn/snapd/downloads","issues_url":"https://api.github.com/repos/datenhahn/snapd/issues{/number}","pulls_url":"https://api.github.com/repos/datenhahn/snapd/pulls{/number}","milestones_url":"https://api.github.com/repos/datenhahn/snapd/milestones{/number}","notifications_url":"https://api.github.com/repos/datenhahn/snapd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/datenhahn/snapd/labels{/name}","releases_url":"https://api.github.com/repos/datenhahn/snapd/releases{/id}","deployments_url":"https://api.github.com/repos/datenhahn/snapd/deployments","created_at":"2018-06-05T09:32:35Z","updated_at":"2018-06-05T09:32:43Z","pushed_at":"2018-06-20T06:51:50Z","git_url":"git://github.com/datenhahn/snapd.git","ssh_url":"git@github.com:datenhahn/snapd.git","clone_url":"https://github.com/datenhahn/snapd.git","svn_url":"https://github.com/datenhahn/snapd","homepage":"","size":65477,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"snapcore:master","ref":"master","sha":"446917cc7cd874a53af79141091eb79eeadbe4fb","user":{"login":"snapcore","id":19532717,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NTMyNzE3","avatar_url":"https://avatars1.githubusercontent.com/u/19532717?v=4","gravatar_id":"","url":"https://api.github.com/users/snapcore","html_url":"https://github.com/snapcore","followers_url":"https://api.github.com/users/snapcore/followers","following_url":"https://api.github.com/users/snapcore/following{/other_user}","gists_url":"https://api.github.com/users/snapcore/gists{/gist_id}","starred_url":"https://api.github.com/users/snapcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snapcore/subscriptions","organizations_url":"https://api.github.com/users/snapcore/orgs","repos_url":"https://api.github.com/users/snapcore/repos","events_url":"https://api.github.com/users/snapcore/events{/privacy}","received_events_url":"https://api.github.com/users/snapcore/received_events","type":"Organization","site_admin":false},"repo":{"id":44672744,"node_id":"MDEwOlJlcG9zaXRvcnk0NDY3Mjc0NA==","name":"snapd","full_name":"snapcore/snapd","owner":{"login":"snapcore","id":19532717,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NTMyNzE3","avatar_url":"https://avatars1.githubusercontent.com/u/19532717?v=4","gravatar_id":"","url":"https://api.github.com/users/snapcore","html_url":"https://github.com/snapcore","followers_url":"https://api.github.com/users/snapcore/followers","following_url":"https://api.github.com/users/snapcore/following{/other_user}","gists_url":"https://api.github.com/users/snapcore/gists{/gist_id}","starred_url":"https://api.github.com/users/snapcore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snapcore/subscriptions","organizations_url":"https://api.github.com/users/snapcore/orgs","repos_url":"https://api.github.com/users/snapcore/repos","events_url":"https://api.github.com/users/snapcore/events{/privacy}","received_events_url":"https://api.github.com/users/snapcore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/snapcore/snapd","description":"The snapd and snap tools enable systems to work with .snap files.","fork":false,"url":"https://api.github.com/repos/snapcore/snapd","forks_url":"https://api.github.com/repos/snapcore/snapd/forks","keys_url":"https://api.github.com/repos/snapcore/snapd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/snapcore/snapd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/snapcore/snapd/teams","hooks_url":"https://api.github.com/repos/snapcore/snapd/hooks","issue_events_url":"https://api.github.com/repos/snapcore/snapd/issues/events{/number}","events_url":"https://api.github.com/repos/snapcore/snapd/events","assignees_url":"https://api.github.com/repos/snapcore/snapd/assignees{/user}","branches_url":"https://api.github.com/repos/snapcore/snapd/branches{/branch}","tags_url":"https://api.github.com/repos/snapcore/snapd/tags","blobs_url":"https://api.github.com/repos/snapcore/snapd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/snapcore/snapd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/snapcore/snapd/git/refs{/sha}","trees_url":"https://api.github.com/repos/snapcore/snapd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/snapcore/snapd/statuses/{sha}","languages_url":"https://api.github.com/repos/snapcore/snapd/languages","stargazers_url":"https://api.github.com/repos/snapcore/snapd/stargazers","contributors_url":"https://api.github.com/repos/snapcore/snapd/contributors","subscribers_url":"https://api.github.com/repos/snapcore/snapd/subscribers","subscription_url":"https://api.github.com/repos/snapcore/snapd/subscription","commits_url":"https://api.github.com/repos/snapcore/snapd/commits{/sha}","git_commits_url":"https://api.github.com/repos/snapcore/snapd/git/commits{/sha}","comments_url":"https://api.github.com/repos/snapcore/snapd/comments{/number}","issue_comment_url":"https://api.github.com/repos/snapcore/snapd/issues/comments{/number}","contents_url":"https://api.github.com/repos/snapcore/snapd/contents/{+path}","compare_url":"https://api.github.com/repos/snapcore/snapd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/snapcore/snapd/merges","archive_url":"https://api.github.com/repos/snapcore/snapd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/snapcore/snapd/downloads","issues_url":"https://api.github.com/repos/snapcore/snapd/issues{/number}","pulls_url":"https://api.github.com/repos/snapcore/snapd/pulls{/number}","milestones_url":"https://api.github.com/repos/snapcore/snapd/milestones{/number}","notifications_url":"https://api.github.com/repos/snapcore/snapd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/snapcore/snapd/labels{/name}","releases_url":"https://api.github.com/repos/snapcore/snapd/releases{/id}","deployments_url":"https://api.github.com/repos/snapcore/snapd/deployments","created_at":"2015-10-21T11:51:46Z","updated_at":"2018-06-29T07:54:19Z","pushed_at":"2018-06-29T07:56:56Z","git_url":"git://github.com/snapcore/snapd.git","ssh_url":"git@github.com:snapcore/snapd.git","clone_url":"https://github.com/snapcore/snapd.git","svn_url":"https://github.com/snapcore/snapd","homepage":"","size":66375,"stargazers_count":954,"watchers_count":954,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":239,"mirror_url":null,"archived":false,"open_issues_count":42,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":239,"open_issues":42,"watchers":954,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/5340"},"html":{"href":"https://github.com/snapcore/snapd/pull/5340"},"issue":{"href":"https://api.github.com/repos/snapcore/snapd/issues/5340"},"comments":{"href":"https://api.github.com/repos/snapcore/snapd/issues/5340/comments"},"review_comments":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/5340/comments"},"review_comment":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/snapcore/snapd/pulls/5340/commits"},"statuses":{"href":"https://api.github.com/repos/snapcore/snapd/statuses/67b848f51a4a8e9c94e1d628b9ed401d8ae35144"}},"author_association":"NONE"}}
{"actor":{"display_login":"niemeyer"}}