{"action":"created","comment":{"url":"https://api.github.com/repos/apel/ssm/pulls/comments/186752462","pull_request_review_id":118393013,"id":186752462,"diff_hunk":"@@ -112,6 +112,12 @@ def __init__(self, hosts_and_ports, qpath, cert, key, dest=None, listen=None,\n             log.info('Messages will be encrypted using %s', enc_cert)\n             if not os.path.isfile(self._enc_cert):\n                 raise Ssm2Exception('Specified certificate file does not exist: %s.' % self._enc_cert)\n+            # Check that the encyption certificate has not expired.\n+            if not crypto.verify_cert_date(enc_cert):\n+                raise Ssm2Exception(\n+                    'Encryption certificate %s has expired. Please obtain the '\n+                    'current one for the server you are sending to.' % enc_cert","path":"ssm/ssm2.py","position":null,"original_position":8,"commit_id":"42e876ab10ea634a88271205b9f3aefedbf35224","original_commit_id":"36c173ba114d9b2bb63c4f3cc1c161fe7217d5da","user":{"login":"tofu-rocketry","id":4836233,"avatar_url":"https://avatars0.githubusercontent.com/u/4836233?v=4","gravatar_id":"","url":"https://api.github.com/users/tofu-rocketry","html_url":"https://github.com/tofu-rocketry","followers_url":"https://api.github.com/users/tofu-rocketry/followers","following_url":"https://api.github.com/users/tofu-rocketry/following{/other_user}","gists_url":"https://api.github.com/users/tofu-rocketry/gists{/gist_id}","starred_url":"https://api.github.com/users/tofu-rocketry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tofu-rocketry/subscriptions","organizations_url":"https://api.github.com/users/tofu-rocketry/orgs","repos_url":"https://api.github.com/users/tofu-rocketry/repos","events_url":"https://api.github.com/users/tofu-rocketry/events{/privacy}","received_events_url":"https://api.github.com/users/tofu-rocketry/received_events","type":"User","site_admin":false},"body":"Changed somewhat, though I've also made it less accounting specific.","created_at":"2018-05-08T14:42:07Z","updated_at":"2018-05-08T14:42:07Z","html_url":"https://github.com/apel/ssm/pull/59#discussion_r186752462","pull_request_url":"https://api.github.com/repos/apel/ssm/pulls/59","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/apel/ssm/pulls/comments/186752462"},"html":{"href":"https://github.com/apel/ssm/pull/59#discussion_r186752462"},"pull_request":{"href":"https://api.github.com/repos/apel/ssm/pulls/59"}},"in_reply_to_id":186046609},"pull_request":{"url":"https://api.github.com/repos/apel/ssm/pulls/59","id":185358928,"html_url":"https://github.com/apel/ssm/pull/59","diff_url":"https://github.com/apel/ssm/pull/59.diff","patch_url":"https://github.com/apel/ssm/pull/59.patch","issue_url":"https://api.github.com/repos/apel/ssm/issues/59","number":59,"state":"open","locked":false,"title":"Expired server cert check","user":{"login":"tofu-rocketry","id":4836233,"avatar_url":"https://avatars0.githubusercontent.com/u/4836233?v=4","gravatar_id":"","url":"https://api.github.com/users/tofu-rocketry","html_url":"https://github.com/tofu-rocketry","followers_url":"https://api.github.com/users/tofu-rocketry/followers","following_url":"https://api.github.com/users/tofu-rocketry/following{/other_user}","gists_url":"https://api.github.com/users/tofu-rocketry/gists{/gist_id}","starred_url":"https://api.github.com/users/tofu-rocketry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tofu-rocketry/subscriptions","organizations_url":"https://api.github.com/users/tofu-rocketry/orgs","repos_url":"https://api.github.com/users/tofu-rocketry/repos","events_url":"https://api.github.com/users/tofu-rocketry/events{/privacy}","received_events_url":"https://api.github.com/users/tofu-rocketry/received_events","type":"User","site_admin":false},"body":"Follow on from #40. This is fairly minor and in a sense fixes an issue for clients so I'm including it in 2.2.1.\r\n\r\nThis PR:\r\n- changes the comment in the config for `server_cert` to clarify its usage\r\n- adds checking of the server cert expiry\r\n- adds corresponding unit test\r\n- tidies a little whitespace.","created_at":"2018-05-02T07:45:02Z","updated_at":"2018-05-08T14:42:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"227face4e0b9a62162f2ea4da5c61f289a7ebcca","assignee":{"login":"tofu-rocketry","id":4836233,"avatar_url":"https://avatars0.githubusercontent.com/u/4836233?v=4","gravatar_id":"","url":"https://api.github.com/users/tofu-rocketry","html_url":"https://github.com/tofu-rocketry","followers_url":"https://api.github.com/users/tofu-rocketry/followers","following_url":"https://api.github.com/users/tofu-rocketry/following{/other_user}","gists_url":"https://api.github.com/users/tofu-rocketry/gists{/gist_id}","starred_url":"https://api.github.com/users/tofu-rocketry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tofu-rocketry/subscriptions","organizations_url":"https://api.github.com/users/tofu-rocketry/orgs","repos_url":"https://api.github.com/users/tofu-rocketry/repos","events_url":"https://api.github.com/users/tofu-rocketry/events{/privacy}","received_events_url":"https://api.github.com/users/tofu-rocketry/received_events","type":"User","site_admin":false},"assignees":[{"login":"tofu-rocketry","id":4836233,"avatar_url":"https://avatars0.githubusercontent.com/u/4836233?v=4","gravatar_id":"","url":"https://api.github.com/users/tofu-rocketry","html_url":"https://github.com/tofu-rocketry","followers_url":"https://api.github.com/users/tofu-rocketry/followers","following_url":"https://api.github.com/users/tofu-rocketry/following{/other_user}","gists_url":"https://api.github.com/users/tofu-rocketry/gists{/gist_id}","starred_url":"https://api.github.com/users/tofu-rocketry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tofu-rocketry/subscriptions","organizations_url":"https://api.github.com/users/tofu-rocketry/orgs","repos_url":"https://api.github.com/users/tofu-rocketry/repos","events_url":"https://api.github.com/users/tofu-rocketry/events{/privacy}","received_events_url":"https://api.github.com/users/tofu-rocketry/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":15989597,"url":"https://api.github.com/repos/apel/ssm/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"milestone":{"url":"https://api.github.com/repos/apel/ssm/milestones/9","html_url":"https://github.com/apel/ssm/milestone/9","labels_url":"https://api.github.com/repos/apel/ssm/milestones/9/labels","id":2914502,"number":9,"title":"2.2.1","description":"","creator":{"login":"tofu-rocketry","id":4836233,"avatar_url":"https://avatars0.githubusercontent.com/u/4836233?v=4","gravatar_id":"","url":"https://api.github.com/users/tofu-rocketry","html_url":"https://github.com/tofu-rocketry","followers_url":"https://api.github.com/users/tofu-rocketry/followers","following_url":"https://api.github.com/users/tofu-rocketry/following{/other_user}","gists_url":"https://api.github.com/users/tofu-rocketry/gists{/gist_id}","starred_url":"https://api.github.com/users/tofu-rocketry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tofu-rocketry/subscriptions","organizations_url":"https://api.github.com/users/tofu-rocketry/orgs","repos_url":"https://api.github.com/users/tofu-rocketry/repos","events_url":"https://api.github.com/users/tofu-rocketry/events{/privacy}","received_events_url":"https://api.github.com/users/tofu-rocketry/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":5,"state":"open","created_at":"2017-11-15T13:57:02Z","updated_at":"2018-05-02T07:45:02Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/apel/ssm/pulls/59/commits","review_comments_url":"https://api.github.com/repos/apel/ssm/pulls/59/comments","review_comment_url":"https://api.github.com/repos/apel/ssm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apel/ssm/issues/59/comments","statuses_url":"https://api.github.com/repos/apel/ssm/statuses/42e876ab10ea634a88271205b9f3aefedbf35224","head":{"label":"tofu-rocketry:expired-server-cert-check","ref":"expired-server-cert-check","sha":"42e876ab10ea634a88271205b9f3aefedbf35224","user":{"login":"tofu-rocketry","id":4836233,"avatar_url":"https://avatars0.githubusercontent.com/u/4836233?v=4","gravatar_id":"","url":"https://api.github.com/users/tofu-rocketry","html_url":"https://github.com/tofu-rocketry","followers_url":"https://api.github.com/users/tofu-rocketry/followers","following_url":"https://api.github.com/users/tofu-rocketry/following{/other_user}","gists_url":"https://api.github.com/users/tofu-rocketry/gists{/gist_id}","starred_url":"https://api.github.com/users/tofu-rocketry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tofu-rocketry/subscriptions","organizations_url":"https://api.github.com/users/tofu-rocketry/orgs","repos_url":"https://api.github.com/users/tofu-rocketry/repos","events_url":"https://api.github.com/users/tofu-rocketry/events{/privacy}","received_events_url":"https://api.github.com/users/tofu-rocketry/received_events","type":"User","site_admin":false},"repo":{"id":30648706,"name":"ssm","full_name":"tofu-rocketry/ssm","owner":{"login":"tofu-rocketry","id":4836233,"avatar_url":"https://avatars0.githubusercontent.com/u/4836233?v=4","gravatar_id":"","url":"https://api.github.com/users/tofu-rocketry","html_url":"https://github.com/tofu-rocketry","followers_url":"https://api.github.com/users/tofu-rocketry/followers","following_url":"https://api.github.com/users/tofu-rocketry/following{/other_user}","gists_url":"https://api.github.com/users/tofu-rocketry/gists{/gist_id}","starred_url":"https://api.github.com/users/tofu-rocketry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tofu-rocketry/subscriptions","organizations_url":"https://api.github.com/users/tofu-rocketry/orgs","repos_url":"https://api.github.com/users/tofu-rocketry/repos","events_url":"https://api.github.com/users/tofu-rocketry/events{/privacy}","received_events_url":"https://api.github.com/users/tofu-rocketry/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tofu-rocketry/ssm","description":"Secure STOMP Messenger.","fork":true,"url":"https://api.github.com/repos/tofu-rocketry/ssm","forks_url":"https://api.github.com/repos/tofu-rocketry/ssm/forks","keys_url":"https://api.github.com/repos/tofu-rocketry/ssm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tofu-rocketry/ssm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tofu-rocketry/ssm/teams","hooks_url":"https://api.github.com/repos/tofu-rocketry/ssm/hooks","issue_events_url":"https://api.github.com/repos/tofu-rocketry/ssm/issues/events{/number}","events_url":"https://api.github.com/repos/tofu-rocketry/ssm/events","assignees_url":"https://api.github.com/repos/tofu-rocketry/ssm/assignees{/user}","branches_url":"https://api.github.com/repos/tofu-rocketry/ssm/branches{/branch}","tags_url":"https://api.github.com/repos/tofu-rocketry/ssm/tags","blobs_url":"https://api.github.com/repos/tofu-rocketry/ssm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tofu-rocketry/ssm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tofu-rocketry/ssm/git/refs{/sha}","trees_url":"https://api.github.com/repos/tofu-rocketry/ssm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tofu-rocketry/ssm/statuses/{sha}","languages_url":"https://api.github.com/repos/tofu-rocketry/ssm/languages","stargazers_url":"https://api.github.com/repos/tofu-rocketry/ssm/stargazers","contributors_url":"https://api.github.com/repos/tofu-rocketry/ssm/contributors","subscribers_url":"https://api.github.com/repos/tofu-rocketry/ssm/subscribers","subscription_url":"https://api.github.com/repos/tofu-rocketry/ssm/subscription","commits_url":"https://api.github.com/repos/tofu-rocketry/ssm/commits{/sha}","git_commits_url":"https://api.github.com/repos/tofu-rocketry/ssm/git/commits{/sha}","comments_url":"https://api.github.com/repos/tofu-rocketry/ssm/comments{/number}","issue_comment_url":"https://api.github.com/repos/tofu-rocketry/ssm/issues/comments{/number}","contents_url":"https://api.github.com/repos/tofu-rocketry/ssm/contents/{+path}","compare_url":"https://api.github.com/repos/tofu-rocketry/ssm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tofu-rocketry/ssm/merges","archive_url":"https://api.github.com/repos/tofu-rocketry/ssm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tofu-rocketry/ssm/downloads","issues_url":"https://api.github.com/repos/tofu-rocketry/ssm/issues{/number}","pulls_url":"https://api.github.com/repos/tofu-rocketry/ssm/pulls{/number}","milestones_url":"https://api.github.com/repos/tofu-rocketry/ssm/milestones{/number}","notifications_url":"https://api.github.com/repos/tofu-rocketry/ssm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tofu-rocketry/ssm/labels{/name}","releases_url":"https://api.github.com/repos/tofu-rocketry/ssm/releases{/id}","deployments_url":"https://api.github.com/repos/tofu-rocketry/ssm/deployments","created_at":"2015-02-11T13:25:11Z","updated_at":"2018-05-01T18:12:05Z","pushed_at":"2018-05-08T14:41:03Z","git_url":"git://github.com/tofu-rocketry/ssm.git","ssh_url":"git@github.com:tofu-rocketry/ssm.git","clone_url":"https://github.com/tofu-rocketry/ssm.git","svn_url":"https://github.com/tofu-rocketry/ssm","homepage":"apel.github.io","size":227,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"apel:dev","ref":"dev","sha":"b4e9fd83d95b3299dc0ea0e0576facb1b65a6a77","user":{"login":"apel","id":3273995,"avatar_url":"https://avatars2.githubusercontent.com/u/3273995?v=4","gravatar_id":"","url":"https://api.github.com/users/apel","html_url":"https://github.com/apel","followers_url":"https://api.github.com/users/apel/followers","following_url":"https://api.github.com/users/apel/following{/other_user}","gists_url":"https://api.github.com/users/apel/gists{/gist_id}","starred_url":"https://api.github.com/users/apel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apel/subscriptions","organizations_url":"https://api.github.com/users/apel/orgs","repos_url":"https://api.github.com/users/apel/repos","events_url":"https://api.github.com/users/apel/events{/privacy}","received_events_url":"https://api.github.com/users/apel/received_events","type":"Organization","site_admin":false},"repo":{"id":6143301,"name":"ssm","full_name":"apel/ssm","owner":{"login":"apel","id":3273995,"avatar_url":"https://avatars2.githubusercontent.com/u/3273995?v=4","gravatar_id":"","url":"https://api.github.com/users/apel","html_url":"https://github.com/apel","followers_url":"https://api.github.com/users/apel/followers","following_url":"https://api.github.com/users/apel/following{/other_user}","gists_url":"https://api.github.com/users/apel/gists{/gist_id}","starred_url":"https://api.github.com/users/apel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apel/subscriptions","organizations_url":"https://api.github.com/users/apel/orgs","repos_url":"https://api.github.com/users/apel/repos","events_url":"https://api.github.com/users/apel/events{/privacy}","received_events_url":"https://api.github.com/users/apel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apel/ssm","description":"Secure STOMP Messenger.","fork":false,"url":"https://api.github.com/repos/apel/ssm","forks_url":"https://api.github.com/repos/apel/ssm/forks","keys_url":"https://api.github.com/repos/apel/ssm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apel/ssm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apel/ssm/teams","hooks_url":"https://api.github.com/repos/apel/ssm/hooks","issue_events_url":"https://api.github.com/repos/apel/ssm/issues/events{/number}","events_url":"https://api.github.com/repos/apel/ssm/events","assignees_url":"https://api.github.com/repos/apel/ssm/assignees{/user}","branches_url":"https://api.github.com/repos/apel/ssm/branches{/branch}","tags_url":"https://api.github.com/repos/apel/ssm/tags","blobs_url":"https://api.github.com/repos/apel/ssm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apel/ssm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apel/ssm/git/refs{/sha}","trees_url":"https://api.github.com/repos/apel/ssm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apel/ssm/statuses/{sha}","languages_url":"https://api.github.com/repos/apel/ssm/languages","stargazers_url":"https://api.github.com/repos/apel/ssm/stargazers","contributors_url":"https://api.github.com/repos/apel/ssm/contributors","subscribers_url":"https://api.github.com/repos/apel/ssm/subscribers","subscription_url":"https://api.github.com/repos/apel/ssm/subscription","commits_url":"https://api.github.com/repos/apel/ssm/commits{/sha}","git_commits_url":"https://api.github.com/repos/apel/ssm/git/commits{/sha}","comments_url":"https://api.github.com/repos/apel/ssm/comments{/number}","issue_comment_url":"https://api.github.com/repos/apel/ssm/issues/comments{/number}","contents_url":"https://api.github.com/repos/apel/ssm/contents/{+path}","compare_url":"https://api.github.com/repos/apel/ssm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apel/ssm/merges","archive_url":"https://api.github.com/repos/apel/ssm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apel/ssm/downloads","issues_url":"https://api.github.com/repos/apel/ssm/issues{/number}","pulls_url":"https://api.github.com/repos/apel/ssm/pulls{/number}","milestones_url":"https://api.github.com/repos/apel/ssm/milestones{/number}","notifications_url":"https://api.github.com/repos/apel/ssm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apel/ssm/labels{/name}","releases_url":"https://api.github.com/repos/apel/ssm/releases{/id}","deployments_url":"https://api.github.com/repos/apel/ssm/deployments","created_at":"2012-10-09T15:46:44Z","updated_at":"2018-05-01T10:41:36Z","pushed_at":"2018-05-08T14:41:05Z","git_url":"git://github.com/apel/ssm.git","ssh_url":"git@github.com:apel/ssm.git","clone_url":"https://github.com/apel/ssm.git","svn_url":"https://github.com/apel/ssm","homepage":"apel.github.io","size":222,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":5,"open_issues":12,"watchers":3,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/apel/ssm/pulls/59"},"html":{"href":"https://github.com/apel/ssm/pull/59"},"issue":{"href":"https://api.github.com/repos/apel/ssm/issues/59"},"comments":{"href":"https://api.github.com/repos/apel/ssm/issues/59/comments"},"review_comments":{"href":"https://api.github.com/repos/apel/ssm/pulls/59/comments"},"review_comment":{"href":"https://api.github.com/repos/apel/ssm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apel/ssm/pulls/59/commits"},"statuses":{"href":"https://api.github.com/repos/apel/ssm/statuses/42e876ab10ea634a88271205b9f3aefedbf35224"}},"author_association":"OWNER"}}
{"actor":{"display_login":"tofu-rocketry"}}