{"action":"created","comment":{"url":"https://api.github.com/repos/libtom/libtomcrypt/pulls/comments/178459996","pull_request_review_id":108520350,"id":178459996,"diff_hunk":"@@ -11,6 +11,185 @@\n \n #ifdef LTC_MECC\n \n+const struct {\n+   const char *OID;\n+   const char *names[6];\n+} _curve_names[] = {\n+#if defined(LTC_ECC_SECP112R1) || defined(LTC_ECC112)\n+   {\n+      \"1.3.132.0.6\", { \"SECP112R1\", \"ECC-112\", NULL }","path":"src/pk/ecc/ecc_get_curve_by_name.c","position":20,"original_position":10,"commit_id":"4a1d0baa639e8ff016488db1fab655ceb47e5bd1","original_commit_id":"f38a93e12ead43a86c391443fd9aee09b31d7c4f","user":{"login":"karel-m","id":1918753,"avatar_url":"https://avatars2.githubusercontent.com/u/1918753?v=4","gravatar_id":"","url":"https://api.github.com/users/karel-m","html_url":"https://github.com/karel-m","followers_url":"https://api.github.com/users/karel-m/followers","following_url":"https://api.github.com/users/karel-m/following{/other_user}","gists_url":"https://api.github.com/users/karel-m/gists{/gist_id}","starred_url":"https://api.github.com/users/karel-m/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karel-m/subscriptions","organizations_url":"https://api.github.com/users/karel-m/orgs","repos_url":"https://api.github.com/users/karel-m/repos","events_url":"https://api.github.com/users/karel-m/events{/privacy}","received_events_url":"https://api.github.com/users/karel-m/received_events","type":"User","site_admin":false},"body":"Ad P-256 & co. - these names are also used in JSON Web Signature (JWS) related RFCs 7515, 7518. It is perhaps based on curve names from https://nvlpubs.nist.gov/nistpubs/FIPS/NIST.FIPS.186-4.pdf","created_at":"2018-04-01T14:42:03Z","updated_at":"2018-04-01T14:42:03Z","html_url":"https://github.com/libtom/libtomcrypt/pull/236#discussion_r178459996","pull_request_url":"https://api.github.com/repos/libtom/libtomcrypt/pulls/236","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/libtom/libtomcrypt/pulls/comments/178459996"},"html":{"href":"https://github.com/libtom/libtomcrypt/pull/236#discussion_r178459996"},"pull_request":{"href":"https://api.github.com/repos/libtom/libtomcrypt/pulls/236"}},"in_reply_to_id":178428525},"pull_request":{"url":"https://api.github.com/repos/libtom/libtomcrypt/pulls/236","id":126853302,"html_url":"https://github.com/libtom/libtomcrypt/pull/236","diff_url":"https://github.com/libtom/libtomcrypt/pull/236.diff","patch_url":"https://github.com/libtom/libtomcrypt/pull/236.patch","issue_url":"https://api.github.com/repos/libtom/libtomcrypt/issues/236","number":236,"state":"open","locked":false,"title":"ECC-step2: curves y^2 = x^3 + ax + b","user":{"login":"karel-m","id":1918753,"avatar_url":"https://avatars2.githubusercontent.com/u/1918753?v=4","gravatar_id":"","url":"https://api.github.com/users/karel-m","html_url":"https://github.com/karel-m","followers_url":"https://api.github.com/users/karel-m/followers","following_url":"https://api.github.com/users/karel-m/following{/other_user}","gists_url":"https://api.github.com/users/karel-m/gists{/gist_id}","starred_url":"https://api.github.com/users/karel-m/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karel-m/subscriptions","organizations_url":"https://api.github.com/users/karel-m/orgs","repos_url":"https://api.github.com/users/karel-m/repos","events_url":"https://api.github.com/users/karel-m/events{/privacy}","received_events_url":"https://api.github.com/users/karel-m/received_events","type":"User","site_admin":false},"body":"While hacking on `ecc_sign+verify_hash_rfc7518` earlier today I realized that it would be possible to extract from my branch `miko-ecc-enhancements` the crucial part implementing generalized elliptic curves `y^2 = x^3 + ax + b` (current `develop` branch supports only `y^2 = x^3 - 3x + b`).\r\n\r\nThe API changes comprise of the following new functions:\r\n```C\r\nint  ecc_export_raw(unsigned char *out, unsigned long *outlen, int type, ecc_key *key);\r\nint  ecc_import_raw(const unsigned char *in, unsigned long inlen, ecc_key *key, ltc_ecc_set_type *dp);\r\n\r\nltc_ecc_set_type* ecc_dp_find_by_oid(unsigned long *oid, unsigned long oidsize);\r\nltc_ecc_set_type* ecc_dp_find_by_name(char *curve_name);\r\nltc_ecc_set_type* ecc_dp_find_by_params(char *hex_prime, char *hex_A, char *hex_B, char *hex_order, char *hex_Gx, char *hex_Gy, unsigned long cofactor);\r\n```\r\n\r\nThese are missing due to #187\r\n* `ecc_export_full` - export EC key in OpenSSL compatible format\r\n* `ecc_import_full` - import EC key in OpenSSL compatible format\r\n* `ecc_import_pkcs8` - import EC key in PKCS#8 format\r\n","created_at":"2017-06-21T20:28:24Z","updated_at":"2018-04-01T14:42:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b53246cfad69686187c5837d3e63f302d63d83b2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":621636778,"url":"https://api.github.com/repos/libtom/libtomcrypt/labels/enhancement","name":"enhancement","color":"c2e0c6","default":true},{"id":621636159,"url":"https://api.github.com/repos/libtom/libtomcrypt/labels/feature","name":"feature","color":"0e8a16","default":false}],"milestone":{"url":"https://api.github.com/repos/libtom/libtomcrypt/milestones/2","html_url":"https://github.com/libtom/libtomcrypt/milestone/2","labels_url":"https://api.github.com/repos/libtom/libtomcrypt/milestones/2/labels","id":2475932,"number":2,"title":"next","description":"","creator":{"login":"sjaeckel","id":294374,"avatar_url":"https://avatars2.githubusercontent.com/u/294374?v=4","gravatar_id":"","url":"https://api.github.com/users/sjaeckel","html_url":"https://github.com/sjaeckel","followers_url":"https://api.github.com/users/sjaeckel/followers","following_url":"https://api.github.com/users/sjaeckel/following{/other_user}","gists_url":"https://api.github.com/users/sjaeckel/gists{/gist_id}","starred_url":"https://api.github.com/users/sjaeckel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjaeckel/subscriptions","organizations_url":"https://api.github.com/users/sjaeckel/orgs","repos_url":"https://api.github.com/users/sjaeckel/repos","events_url":"https://api.github.com/users/sjaeckel/events{/privacy}","received_events_url":"https://api.github.com/users/sjaeckel/received_events","type":"User","site_admin":false},"open_issues":20,"closed_issues":49,"state":"open","created_at":"2017-04-24T08:35:16Z","updated_at":"2018-03-30T00:02:00Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/libtom/libtomcrypt/pulls/236/commits","review_comments_url":"https://api.github.com/repos/libtom/libtomcrypt/pulls/236/comments","review_comment_url":"https://api.github.com/repos/libtom/libtomcrypt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/libtom/libtomcrypt/issues/236/comments","statuses_url":"https://api.github.com/repos/libtom/libtomcrypt/statuses/4a1d0baa639e8ff016488db1fab655ceb47e5bd1","head":{"label":"libtom:pr/ecc-non-asn1-part","ref":"pr/ecc-non-asn1-part","sha":"4a1d0baa639e8ff016488db1fab655ceb47e5bd1","user":{"login":"libtom","id":449482,"avatar_url":"https://avatars0.githubusercontent.com/u/449482?v=4","gravatar_id":"","url":"https://api.github.com/users/libtom","html_url":"https://github.com/libtom","followers_url":"https://api.github.com/users/libtom/followers","following_url":"https://api.github.com/users/libtom/following{/other_user}","gists_url":"https://api.github.com/users/libtom/gists{/gist_id}","starred_url":"https://api.github.com/users/libtom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libtom/subscriptions","organizations_url":"https://api.github.com/users/libtom/orgs","repos_url":"https://api.github.com/users/libtom/repos","events_url":"https://api.github.com/users/libtom/events{/privacy}","received_events_url":"https://api.github.com/users/libtom/received_events","type":"Organization","site_admin":false},"repo":{"id":777011,"name":"libtomcrypt","full_name":"libtom/libtomcrypt","owner":{"login":"libtom","id":449482,"avatar_url":"https://avatars0.githubusercontent.com/u/449482?v=4","gravatar_id":"","url":"https://api.github.com/users/libtom","html_url":"https://github.com/libtom","followers_url":"https://api.github.com/users/libtom/followers","following_url":"https://api.github.com/users/libtom/following{/other_user}","gists_url":"https://api.github.com/users/libtom/gists{/gist_id}","starred_url":"https://api.github.com/users/libtom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libtom/subscriptions","organizations_url":"https://api.github.com/users/libtom/orgs","repos_url":"https://api.github.com/users/libtom/repos","events_url":"https://api.github.com/users/libtom/events{/privacy}","received_events_url":"https://api.github.com/users/libtom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/libtom/libtomcrypt","description":"LibTomCrypt is a fairly comprehensive, modular and portable cryptographic toolkit that provides developers with a vast array of well known published block ciphers, one-way hash functions, chaining modes, pseudo-random number generators, public key cryptography and a plethora of other routines.","fork":false,"url":"https://api.github.com/repos/libtom/libtomcrypt","forks_url":"https://api.github.com/repos/libtom/libtomcrypt/forks","keys_url":"https://api.github.com/repos/libtom/libtomcrypt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/libtom/libtomcrypt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/libtom/libtomcrypt/teams","hooks_url":"https://api.github.com/repos/libtom/libtomcrypt/hooks","issue_events_url":"https://api.github.com/repos/libtom/libtomcrypt/issues/events{/number}","events_url":"https://api.github.com/repos/libtom/libtomcrypt/events","assignees_url":"https://api.github.com/repos/libtom/libtomcrypt/assignees{/user}","branches_url":"https://api.github.com/repos/libtom/libtomcrypt/branches{/branch}","tags_url":"https://api.github.com/repos/libtom/libtomcrypt/tags","blobs_url":"https://api.github.com/repos/libtom/libtomcrypt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/libtom/libtomcrypt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/libtom/libtomcrypt/git/refs{/sha}","trees_url":"https://api.github.com/repos/libtom/libtomcrypt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/libtom/libtomcrypt/statuses/{sha}","languages_url":"https://api.github.com/repos/libtom/libtomcrypt/languages","stargazers_url":"https://api.github.com/repos/libtom/libtomcrypt/stargazers","contributors_url":"https://api.github.com/repos/libtom/libtomcrypt/contributors","subscribers_url":"https://api.github.com/repos/libtom/libtomcrypt/subscribers","subscription_url":"https://api.github.com/repos/libtom/libtomcrypt/subscription","commits_url":"https://api.github.com/repos/libtom/libtomcrypt/commits{/sha}","git_commits_url":"https://api.github.com/repos/libtom/libtomcrypt/git/commits{/sha}","comments_url":"https://api.github.com/repos/libtom/libtomcrypt/comments{/number}","issue_comment_url":"https://api.github.com/repos/libtom/libtomcrypt/issues/comments{/number}","contents_url":"https://api.github.com/repos/libtom/libtomcrypt/contents/{+path}","compare_url":"https://api.github.com/repos/libtom/libtomcrypt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/libtom/libtomcrypt/merges","archive_url":"https://api.github.com/repos/libtom/libtomcrypt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/libtom/libtomcrypt/downloads","issues_url":"https://api.github.com/repos/libtom/libtomcrypt/issues{/number}","pulls_url":"https://api.github.com/repos/libtom/libtomcrypt/pulls{/number}","milestones_url":"https://api.github.com/repos/libtom/libtomcrypt/milestones{/number}","notifications_url":"https://api.github.com/repos/libtom/libtomcrypt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/libtom/libtomcrypt/labels{/name}","releases_url":"https://api.github.com/repos/libtom/libtomcrypt/releases{/id}","deployments_url":"https://api.github.com/repos/libtom/libtomcrypt/deployments","created_at":"2010-07-15T16:22:58Z","updated_at":"2018-03-28T07:30:59Z","pushed_at":"2018-04-01T14:04:38Z","git_url":"git://github.com/libtom/libtomcrypt.git","ssh_url":"git@github.com:libtom/libtomcrypt.git","clone_url":"https://github.com/libtom/libtomcrypt.git","svn_url":"https://github.com/libtom/libtomcrypt","homepage":"http://www.libtom.net","size":19821,"stargazers_count":661,"watchers_count":661,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":238,"mirror_url":null,"archived":false,"open_issues_count":29,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":238,"open_issues":29,"watchers":661,"default_branch":"develop"}},"base":{"label":"libtom:develop","ref":"develop","sha":"fa759d8ee937b0a787e5c71c2fd1b2b343e57851","user":{"login":"libtom","id":449482,"avatar_url":"https://avatars0.githubusercontent.com/u/449482?v=4","gravatar_id":"","url":"https://api.github.com/users/libtom","html_url":"https://github.com/libtom","followers_url":"https://api.github.com/users/libtom/followers","following_url":"https://api.github.com/users/libtom/following{/other_user}","gists_url":"https://api.github.com/users/libtom/gists{/gist_id}","starred_url":"https://api.github.com/users/libtom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libtom/subscriptions","organizations_url":"https://api.github.com/users/libtom/orgs","repos_url":"https://api.github.com/users/libtom/repos","events_url":"https://api.github.com/users/libtom/events{/privacy}","received_events_url":"https://api.github.com/users/libtom/received_events","type":"Organization","site_admin":false},"repo":{"id":777011,"name":"libtomcrypt","full_name":"libtom/libtomcrypt","owner":{"login":"libtom","id":449482,"avatar_url":"https://avatars0.githubusercontent.com/u/449482?v=4","gravatar_id":"","url":"https://api.github.com/users/libtom","html_url":"https://github.com/libtom","followers_url":"https://api.github.com/users/libtom/followers","following_url":"https://api.github.com/users/libtom/following{/other_user}","gists_url":"https://api.github.com/users/libtom/gists{/gist_id}","starred_url":"https://api.github.com/users/libtom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libtom/subscriptions","organizations_url":"https://api.github.com/users/libtom/orgs","repos_url":"https://api.github.com/users/libtom/repos","events_url":"https://api.github.com/users/libtom/events{/privacy}","received_events_url":"https://api.github.com/users/libtom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/libtom/libtomcrypt","description":"LibTomCrypt is a fairly comprehensive, modular and portable cryptographic toolkit that provides developers with a vast array of well known published block ciphers, one-way hash functions, chaining modes, pseudo-random number generators, public key cryptography and a plethora of other routines.","fork":false,"url":"https://api.github.com/repos/libtom/libtomcrypt","forks_url":"https://api.github.com/repos/libtom/libtomcrypt/forks","keys_url":"https://api.github.com/repos/libtom/libtomcrypt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/libtom/libtomcrypt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/libtom/libtomcrypt/teams","hooks_url":"https://api.github.com/repos/libtom/libtomcrypt/hooks","issue_events_url":"https://api.github.com/repos/libtom/libtomcrypt/issues/events{/number}","events_url":"https://api.github.com/repos/libtom/libtomcrypt/events","assignees_url":"https://api.github.com/repos/libtom/libtomcrypt/assignees{/user}","branches_url":"https://api.github.com/repos/libtom/libtomcrypt/branches{/branch}","tags_url":"https://api.github.com/repos/libtom/libtomcrypt/tags","blobs_url":"https://api.github.com/repos/libtom/libtomcrypt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/libtom/libtomcrypt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/libtom/libtomcrypt/git/refs{/sha}","trees_url":"https://api.github.com/repos/libtom/libtomcrypt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/libtom/libtomcrypt/statuses/{sha}","languages_url":"https://api.github.com/repos/libtom/libtomcrypt/languages","stargazers_url":"https://api.github.com/repos/libtom/libtomcrypt/stargazers","contributors_url":"https://api.github.com/repos/libtom/libtomcrypt/contributors","subscribers_url":"https://api.github.com/repos/libtom/libtomcrypt/subscribers","subscription_url":"https://api.github.com/repos/libtom/libtomcrypt/subscription","commits_url":"https://api.github.com/repos/libtom/libtomcrypt/commits{/sha}","git_commits_url":"https://api.github.com/repos/libtom/libtomcrypt/git/commits{/sha}","comments_url":"https://api.github.com/repos/libtom/libtomcrypt/comments{/number}","issue_comment_url":"https://api.github.com/repos/libtom/libtomcrypt/issues/comments{/number}","contents_url":"https://api.github.com/repos/libtom/libtomcrypt/contents/{+path}","compare_url":"https://api.github.com/repos/libtom/libtomcrypt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/libtom/libtomcrypt/merges","archive_url":"https://api.github.com/repos/libtom/libtomcrypt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/libtom/libtomcrypt/downloads","issues_url":"https://api.github.com/repos/libtom/libtomcrypt/issues{/number}","pulls_url":"https://api.github.com/repos/libtom/libtomcrypt/pulls{/number}","milestones_url":"https://api.github.com/repos/libtom/libtomcrypt/milestones{/number}","notifications_url":"https://api.github.com/repos/libtom/libtomcrypt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/libtom/libtomcrypt/labels{/name}","releases_url":"https://api.github.com/repos/libtom/libtomcrypt/releases{/id}","deployments_url":"https://api.github.com/repos/libtom/libtomcrypt/deployments","created_at":"2010-07-15T16:22:58Z","updated_at":"2018-03-28T07:30:59Z","pushed_at":"2018-04-01T14:04:38Z","git_url":"git://github.com/libtom/libtomcrypt.git","ssh_url":"git@github.com:libtom/libtomcrypt.git","clone_url":"https://github.com/libtom/libtomcrypt.git","svn_url":"https://github.com/libtom/libtomcrypt","homepage":"http://www.libtom.net","size":19821,"stargazers_count":661,"watchers_count":661,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":238,"mirror_url":null,"archived":false,"open_issues_count":29,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":238,"open_issues":29,"watchers":661,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/libtom/libtomcrypt/pulls/236"},"html":{"href":"https://github.com/libtom/libtomcrypt/pull/236"},"issue":{"href":"https://api.github.com/repos/libtom/libtomcrypt/issues/236"},"comments":{"href":"https://api.github.com/repos/libtom/libtomcrypt/issues/236/comments"},"review_comments":{"href":"https://api.github.com/repos/libtom/libtomcrypt/pulls/236/comments"},"review_comment":{"href":"https://api.github.com/repos/libtom/libtomcrypt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/libtom/libtomcrypt/pulls/236/commits"},"statuses":{"href":"https://api.github.com/repos/libtom/libtomcrypt/statuses/4a1d0baa639e8ff016488db1fab655ceb47e5bd1"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"karel-m"}}