{"action":"opened","number":144,"pull_request":{"url":"https://api.github.com/repos/rust-embedded/cortex-m-rt/pulls/144","id":226291295,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2MjkxMjk1","html_url":"https://github.com/rust-embedded/cortex-m-rt/pull/144","diff_url":"https://github.com/rust-embedded/cortex-m-rt/pull/144.diff","patch_url":"https://github.com/rust-embedded/cortex-m-rt/pull/144.patch","issue_url":"https://api.github.com/repos/rust-embedded/cortex-m-rt/issues/144","number":144,"state":"open","locked":false,"title":"[RFC] rename UserHardFault to HardFault","user":{"login":"japaric","id":5018213,"node_id":"MDQ6VXNlcjUwMTgyMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/5018213?v=4","gravatar_id":"","url":"https://api.github.com/users/japaric","html_url":"https://github.com/japaric","followers_url":"https://api.github.com/users/japaric/followers","following_url":"https://api.github.com/users/japaric/following{/other_user}","gists_url":"https://api.github.com/users/japaric/gists{/gist_id}","starred_url":"https://api.github.com/users/japaric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/japaric/subscriptions","organizations_url":"https://api.github.com/users/japaric/orgs","repos_url":"https://api.github.com/users/japaric/repos","events_url":"https://api.github.com/users/japaric/events{/privacy}","received_events_url":"https://api.github.com/users/japaric/received_events","type":"User","site_admin":false},"body":"so it matches the exception name (`#[exception] fn HardFault(..`)\r\n\r\nRight now the symbol name of all exception handlers match the name of the\r\nfunction used with the `#[exception]` attribute *except* for `HardFault`, whose\r\nsymbol name actually is `UserHardFault`.\r\n\r\nThis PR corrects that inconsistency by renaming the `UserHardFault` symbol to\r\n`HardFault`, and the `HardFault` symbol to `HardFaultTrampoline`.\r\n\r\nThis change doesn't break compilation or changes functionality but it does soft\r\nbreak GDB scripts that include the command `break UserHardFault` (e.g. the GDB\r\nscript in cortex-m-quickstart) in the sense that the breakpoint will no longer\r\nwork. However the rest of the GDB script will continue to work.\r\n\r\nRFC questions: (a) do we want to do this rename? (b) if the answer is yes, do we\r\nwant to include this rename in the v0.5.x release, or should we consider it a\r\nbreaking change and postpone it until v0.6.0?","created_at":"2018-10-27T12:32:29Z","updated_at":"2018-10-27T12:32:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1012931090,"node_id":"MDU6TGFiZWwxMDEyOTMxMDkw","url":"https://api.github.com/repos/rust-embedded/cortex-m-rt/labels/needs-decision","name":"needs-decision","color":"c5def5","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/rust-embedded/cortex-m-rt/pulls/144/commits","review_comments_url":"https://api.github.com/repos/rust-embedded/cortex-m-rt/pulls/144/comments","review_comment_url":"https://api.github.com/repos/rust-embedded/cortex-m-rt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-embedded/cortex-m-rt/issues/144/comments","statuses_url":"https://api.github.com/repos/rust-embedded/cortex-m-rt/statuses/c0822ebba363de8c9583cc1c45f41b05355fdb86","head":{"label":"rust-embedded:hard-fault","ref":"hard-fault","sha":"c0822ebba363de8c9583cc1c45f41b05355fdb86","user":{"login":"rust-embedded","id":17707713,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NzA3NzEz","avatar_url":"https://avatars3.githubusercontent.com/u/17707713?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-embedded","html_url":"https://github.com/rust-embedded","followers_url":"https://api.github.com/users/rust-embedded/followers","following_url":"https://api.github.com/users/rust-embedded/following{/other_user}","gists_url":"https://api.github.com/users/rust-embedded/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-embedded/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-embedded/subscriptions","organizations_url":"https://api.github.com/users/rust-embedded/orgs","repos_url":"https://api.github.com/users/rust-embedded/repos","events_url":"https://api.github.com/users/rust-embedded/events{/privacy}","received_events_url":"https://api.github.com/users/rust-embedded/received_events","type":"Organization","site_admin":false},"repo":{"id":84737916,"node_id":"MDEwOlJlcG9zaXRvcnk4NDczNzkxNg==","name":"cortex-m-rt","full_name":"rust-embedded/cortex-m-rt","private":false,"owner":{"login":"rust-embedded","id":17707713,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NzA3NzEz","avatar_url":"https://avatars3.githubusercontent.com/u/17707713?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-embedded","html_url":"https://github.com/rust-embedded","followers_url":"https://api.github.com/users/rust-embedded/followers","following_url":"https://api.github.com/users/rust-embedded/following{/other_user}","gists_url":"https://api.github.com/users/rust-embedded/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-embedded/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-embedded/subscriptions","organizations_url":"https://api.github.com/users/rust-embedded/orgs","repos_url":"https://api.github.com/users/rust-embedded/repos","events_url":"https://api.github.com/users/rust-embedded/events{/privacy}","received_events_url":"https://api.github.com/users/rust-embedded/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/rust-embedded/cortex-m-rt","description":"Minimal startup / runtime for Cortex-M microcontrollers","fork":false,"url":"https://api.github.com/repos/rust-embedded/cortex-m-rt","forks_url":"https://api.github.com/repos/rust-embedded/cortex-m-rt/forks","keys_url":"https://api.github.com/repos/rust-embedded/cortex-m-rt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-embedded/cortex-m-rt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-embedded/cortex-m-rt/teams","hooks_url":"https://api.github.com/repos/rust-embedded/cortex-m-rt/hooks","issue_events_url":"https://api.github.com/repos/rust-embedded/cortex-m-rt/issues/events{/number}","events_url":"https://api.github.com/repos/rust-embedded/cortex-m-rt/events","assignees_url":"https://api.github.com/repos/rust-embedded/cortex-m-rt/assignees{/user}","branches_url":"https://api.github.com/repos/rust-embedded/cortex-m-rt/branches{/branch}","tags_url":"https://api.github.com/repos/rust-embedded/cortex-m-rt/tags","blobs_url":"https://api.github.com/repos/rust-embedded/cortex-m-rt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-embedded/cortex-m-rt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-embedded/cortex-m-rt/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-embedded/cortex-m-rt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-embedded/cortex-m-rt/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-embedded/cortex-m-rt/languages","stargazers_url":"https://api.github.com/repos/rust-embedded/cortex-m-rt/stargazers","contributors_url":"https://api.github.com/repos/rust-embedded/cortex-m-rt/contributors","subscribers_url":"https://api.github.com/repos/rust-embedded/cortex-m-rt/subscribers","subscription_url":"https://api.github.com/repos/rust-embedded/cortex-m-rt/subscription","commits_url":"https://api.github.com/repos/rust-embedded/cortex-m-rt/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-embedded/cortex-m-rt/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-embedded/cortex-m-rt/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-embedded/cortex-m-rt/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-embedded/cortex-m-rt/contents/{+path}","compare_url":"https://api.github.com/repos/rust-embedded/cortex-m-rt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-embedded/cortex-m-rt/merges","archive_url":"https://api.github.com/repos/rust-embedded/cortex-m-rt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-embedded/cortex-m-rt/downloads","issues_url":"https://api.github.com/repos/rust-embedded/cortex-m-rt/issues{/number}","pulls_url":"https://api.github.com/repos/rust-embedded/cortex-m-rt/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-embedded/cortex-m-rt/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-embedded/cortex-m-rt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-embedded/cortex-m-rt/labels{/name}","releases_url":"https://api.github.com/repos/rust-embedded/cortex-m-rt/releases{/id}","deployments_url":"https://api.github.com/repos/rust-embedded/cortex-m-rt/deployments","created_at":"2017-03-12T15:54:13Z","updated_at":"2018-10-26T22:16:17Z","pushed_at":"2018-10-27T12:30:39Z","git_url":"git://github.com/rust-embedded/cortex-m-rt.git","ssh_url":"git@github.com:rust-embedded/cortex-m-rt.git","clone_url":"https://github.com/rust-embedded/cortex-m-rt.git","svn_url":"https://github.com/rust-embedded/cortex-m-rt","homepage":"https://rust-embedded.github.io/cortex-m-rt/","size":4510,"stargazers_count":103,"watchers_count":103,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":28,"mirror_url":null,"archived":false,"open_issues_count":19,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":28,"open_issues":19,"watchers":103,"default_branch":"master"}},"base":{"label":"rust-embedded:master","ref":"master","sha":"a48d8661131353178e1812d4d152f02607f0f2b7","user":{"login":"rust-embedded","id":17707713,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NzA3NzEz","avatar_url":"https://avatars3.githubusercontent.com/u/17707713?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-embedded","html_url":"https://github.com/rust-embedded","followers_url":"https://api.github.com/users/rust-embedded/followers","following_url":"https://api.github.com/users/rust-embedded/following{/other_user}","gists_url":"https://api.github.com/users/rust-embedded/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-embedded/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-embedded/subscriptions","organizations_url":"https://api.github.com/users/rust-embedded/orgs","repos_url":"https://api.github.com/users/rust-embedded/repos","events_url":"https://api.github.com/users/rust-embedded/events{/privacy}","received_events_url":"https://api.github.com/users/rust-embedded/received_events","type":"Organization","site_admin":false},"repo":{"id":84737916,"node_id":"MDEwOlJlcG9zaXRvcnk4NDczNzkxNg==","name":"cortex-m-rt","full_name":"rust-embedded/cortex-m-rt","private":false,"owner":{"login":"rust-embedded","id":17707713,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NzA3NzEz","avatar_url":"https://avatars3.githubusercontent.com/u/17707713?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-embedded","html_url":"https://github.com/rust-embedded","followers_url":"https://api.github.com/users/rust-embedded/followers","following_url":"https://api.github.com/users/rust-embedded/following{/other_user}","gists_url":"https://api.github.com/users/rust-embedded/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-embedded/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-embedded/subscriptions","organizations_url":"https://api.github.com/users/rust-embedded/orgs","repos_url":"https://api.github.com/users/rust-embedded/repos","events_url":"https://api.github.com/users/rust-embedded/events{/privacy}","received_events_url":"https://api.github.com/users/rust-embedded/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/rust-embedded/cortex-m-rt","description":"Minimal startup / runtime for Cortex-M microcontrollers","fork":false,"url":"https://api.github.com/repos/rust-embedded/cortex-m-rt","forks_url":"https://api.github.com/repos/rust-embedded/cortex-m-rt/forks","keys_url":"https://api.github.com/repos/rust-embedded/cortex-m-rt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-embedded/cortex-m-rt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-embedded/cortex-m-rt/teams","hooks_url":"https://api.github.com/repos/rust-embedded/cortex-m-rt/hooks","issue_events_url":"https://api.github.com/repos/rust-embedded/cortex-m-rt/issues/events{/number}","events_url":"https://api.github.com/repos/rust-embedded/cortex-m-rt/events","assignees_url":"https://api.github.com/repos/rust-embedded/cortex-m-rt/assignees{/user}","branches_url":"https://api.github.com/repos/rust-embedded/cortex-m-rt/branches{/branch}","tags_url":"https://api.github.com/repos/rust-embedded/cortex-m-rt/tags","blobs_url":"https://api.github.com/repos/rust-embedded/cortex-m-rt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-embedded/cortex-m-rt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-embedded/cortex-m-rt/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-embedded/cortex-m-rt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-embedded/cortex-m-rt/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-embedded/cortex-m-rt/languages","stargazers_url":"https://api.github.com/repos/rust-embedded/cortex-m-rt/stargazers","contributors_url":"https://api.github.com/repos/rust-embedded/cortex-m-rt/contributors","subscribers_url":"https://api.github.com/repos/rust-embedded/cortex-m-rt/subscribers","subscription_url":"https://api.github.com/repos/rust-embedded/cortex-m-rt/subscription","commits_url":"https://api.github.com/repos/rust-embedded/cortex-m-rt/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-embedded/cortex-m-rt/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-embedded/cortex-m-rt/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-embedded/cortex-m-rt/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-embedded/cortex-m-rt/contents/{+path}","compare_url":"https://api.github.com/repos/rust-embedded/cortex-m-rt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-embedded/cortex-m-rt/merges","archive_url":"https://api.github.com/repos/rust-embedded/cortex-m-rt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-embedded/cortex-m-rt/downloads","issues_url":"https://api.github.com/repos/rust-embedded/cortex-m-rt/issues{/number}","pulls_url":"https://api.github.com/repos/rust-embedded/cortex-m-rt/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-embedded/cortex-m-rt/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-embedded/cortex-m-rt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-embedded/cortex-m-rt/labels{/name}","releases_url":"https://api.github.com/repos/rust-embedded/cortex-m-rt/releases{/id}","deployments_url":"https://api.github.com/repos/rust-embedded/cortex-m-rt/deployments","created_at":"2017-03-12T15:54:13Z","updated_at":"2018-10-26T22:16:17Z","pushed_at":"2018-10-27T12:30:39Z","git_url":"git://github.com/rust-embedded/cortex-m-rt.git","ssh_url":"git@github.com:rust-embedded/cortex-m-rt.git","clone_url":"https://github.com/rust-embedded/cortex-m-rt.git","svn_url":"https://github.com/rust-embedded/cortex-m-rt","homepage":"https://rust-embedded.github.io/cortex-m-rt/","size":4510,"stargazers_count":103,"watchers_count":103,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":28,"mirror_url":null,"archived":false,"open_issues_count":19,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":28,"open_issues":19,"watchers":103,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-embedded/cortex-m-rt/pulls/144"},"html":{"href":"https://github.com/rust-embedded/cortex-m-rt/pull/144"},"issue":{"href":"https://api.github.com/repos/rust-embedded/cortex-m-rt/issues/144"},"comments":{"href":"https://api.github.com/repos/rust-embedded/cortex-m-rt/issues/144/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-embedded/cortex-m-rt/pulls/144/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-embedded/cortex-m-rt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-embedded/cortex-m-rt/pulls/144/commits"},"statuses":{"href":"https://api.github.com/repos/rust-embedded/cortex-m-rt/statuses/c0822ebba363de8c9583cc1c45f41b05355fdb86"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":20,"deletions":20,"changed_files":8}}
{"actor":{"display_login":"japaric"}}