{"action":"created","comment":{"url":"https://api.github.com/repos/iotaledger/entangled/pulls/comments/223279041","pull_request_review_id":162364361,"id":223279041,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzI3OTA0MQ==","diff_hunk":"@@ -236,50 +236,25 @@ void test_bundle_validate_size_4_value_wrong_sig_invalid() {\n   bundle_transactions_t *bundle;\n   bundle_transactions_new(&bundle);\n \n-  flex_trit_t transaction_1_trits[FLEX_TRIT_SIZE_8019];\n-  flex_trit_t transaction_2_trits[FLEX_TRIT_SIZE_8019];\n-  flex_trit_t transaction_3_trits[FLEX_TRIT_SIZE_8019];\n-  flex_trit_t transaction_4_trits[FLEX_TRIT_SIZE_8019];\n-\n-  flex_trits_from_trytes(transaction_1_trits, NUM_TRITS_SERIALIZED_TRANSACTION,\n-                         (tryte_t *)TX_1_OF_4_VALUE_BUNDLE_TRYTES,\n-                         NUM_TRYTES_SERIALIZED_TRANSACTION,\n-                         NUM_TRYTES_SERIALIZED_TRANSACTION);\n-  flex_trits_from_trytes(transaction_2_trits, NUM_TRITS_SERIALIZED_TRANSACTION,\n-                         (tryte_t *)TX_2_OF_4_VALUE_BUNDLE_TRYTES,\n-                         NUM_TRYTES_SERIALIZED_TRANSACTION,\n-                         NUM_TRYTES_SERIALIZED_TRANSACTION);\n-  flex_trits_from_trytes(transaction_3_trits, NUM_TRITS_SERIALIZED_TRANSACTION,\n-                         (tryte_t *)TX_3_OF_4_VALUE_BUNDLE_TRYTES,\n-                         NUM_TRYTES_SERIALIZED_TRANSACTION,\n-                         NUM_TRYTES_SERIALIZED_TRANSACTION);\n-  flex_trits_from_trytes(transaction_4_trits, NUM_TRITS_SERIALIZED_TRANSACTION,\n-                         (tryte_t *)TX_4_OF_4_VALUE_BUNDLE_TRYTES,\n-                         NUM_TRYTES_SERIALIZED_TRANSACTION,\n-                         NUM_TRYTES_SERIALIZED_TRANSACTION);\n-\n-  iota_transaction_t tx1 = transaction_deserialize(transaction_1_trits);\n-  iota_transaction_t tx2 = transaction_deserialize(transaction_2_trits);\n-  iota_transaction_t tx3 = transaction_deserialize(transaction_3_trits);\n-  iota_transaction_t tx4 = transaction_deserialize(transaction_4_trits);\n+  iota_transaction_t txs[4];\n \n-  tx2->signature_or_message[0] = 'A';\n-\n-  TEST_ASSERT(iota_tangle_transaction_store(&tangle, tx1) == RC_OK);\n-  TEST_ASSERT(iota_tangle_transaction_store(&tangle, tx2) == RC_OK);\n-  TEST_ASSERT(iota_tangle_transaction_store(&tangle, tx3) == RC_OK);\n-  TEST_ASSERT(iota_tangle_transaction_store(&tangle, tx4) == RC_OK);\n+  tryte_t *trytes[4] = {\n+      TX_1_OF_4_VALUE_BUNDLE_TRYTES, TX_2_OF_4_VALUE_BUNDLE_TRYTES,\n+      TX_3_OF_4_VALUE_BUNDLE_TRYTES, TX_4_OF_4_VALUE_BUNDLE_TRYTES};\n+  transactions_deserialize(trytes, txs, 4);\n+  txs[1]->address[FLEX_TRIT_SIZE_243 - 1] = 'A';","path":"consensus/bundle_validator/tests/bundle_validator.c","position":51,"original_position":51,"commit_id":"2d7a1c35b30764bd410edb480f985c91a2399ef9","original_commit_id":"2d7a1c35b30764bd410edb480f985c91a2399ef9","user":{"login":"tsvisabo","id":37177579,"node_id":"MDQ6VXNlcjM3MTc3NTc5","avatar_url":"https://avatars3.githubusercontent.com/u/37177579?v=4","gravatar_id":"","url":"https://api.github.com/users/tsvisabo","html_url":"https://github.com/tsvisabo","followers_url":"https://api.github.com/users/tsvisabo/followers","following_url":"https://api.github.com/users/tsvisabo/following{/other_user}","gists_url":"https://api.github.com/users/tsvisabo/gists{/gist_id}","starred_url":"https://api.github.com/users/tsvisabo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsvisabo/subscriptions","organizations_url":"https://api.github.com/users/tsvisabo/orgs","repos_url":"https://api.github.com/users/tsvisabo/repos","events_url":"https://api.github.com/users/tsvisabo/events{/privacy}","received_events_url":"https://api.github.com/users/tsvisabo/received_events","type":"User","site_admin":false},"body":"`A` ends up with last trit not being `0`, but it's hackey a little, will look into changing it","created_at":"2018-10-08T08:14:45Z","updated_at":"2018-10-08T08:14:46Z","html_url":"https://github.com/iotaledger/entangled/pull/366#discussion_r223279041","pull_request_url":"https://api.github.com/repos/iotaledger/entangled/pulls/366","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/iotaledger/entangled/pulls/comments/223279041"},"html":{"href":"https://github.com/iotaledger/entangled/pull/366#discussion_r223279041"},"pull_request":{"href":"https://api.github.com/repos/iotaledger/entangled/pulls/366"}},"in_reply_to_id":223265323},"pull_request":{"url":"https://api.github.com/repos/iotaledger/entangled/pulls/366","id":220951278,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwOTUxMjc4","html_url":"https://github.com/iotaledger/entangled/pull/366","diff_url":"https://github.com/iotaledger/entangled/pull/366.diff","patch_url":"https://github.com/iotaledger/entangled/pull/366.patch","issue_url":"https://api.github.com/repos/iotaledger/entangled/issues/366","number":366,"state":"open","locked":false,"title":"Exit probability validation (Walker validator)","user":{"login":"tsvisabo","id":37177579,"node_id":"MDQ6VXNlcjM3MTc3NTc5","avatar_url":"https://avatars3.githubusercontent.com/u/37177579?v=4","gravatar_id":"","url":"https://api.github.com/users/tsvisabo","html_url":"https://github.com/tsvisabo","followers_url":"https://api.github.com/users/tsvisabo/followers","following_url":"https://api.github.com/users/tsvisabo/following{/other_user}","gists_url":"https://api.github.com/users/tsvisabo/gists{/gist_id}","starred_url":"https://api.github.com/users/tsvisabo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsvisabo/subscriptions","organizations_url":"https://api.github.com/users/tsvisabo/orgs","repos_url":"https://api.github.com/users/tsvisabo/repos","events_url":"https://api.github.com/users/tsvisabo/events{/privacy}","received_events_url":"https://api.github.com/users/tsvisabo/received_events","type":"User","site_admin":false},"body":"Implement exit probability validation\r\nadd tests","created_at":"2018-10-07T14:26:21Z","updated_at":"2018-10-08T08:14:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"43b8977a5d45fb23c69ff5816e99507661b1512e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"th0br0","id":30996,"node_id":"MDQ6VXNlcjMwOTk2","avatar_url":"https://avatars0.githubusercontent.com/u/30996?v=4","gravatar_id":"","url":"https://api.github.com/users/th0br0","html_url":"https://github.com/th0br0","followers_url":"https://api.github.com/users/th0br0/followers","following_url":"https://api.github.com/users/th0br0/following{/other_user}","gists_url":"https://api.github.com/users/th0br0/gists{/gist_id}","starred_url":"https://api.github.com/users/th0br0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/th0br0/subscriptions","organizations_url":"https://api.github.com/users/th0br0/orgs","repos_url":"https://api.github.com/users/th0br0/repos","events_url":"https://api.github.com/users/th0br0/events{/privacy}","received_events_url":"https://api.github.com/users/th0br0/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/iotaledger/entangled/pulls/366/commits","review_comments_url":"https://api.github.com/repos/iotaledger/entangled/pulls/366/comments","review_comment_url":"https://api.github.com/repos/iotaledger/entangled/pulls/comments{/number}","comments_url":"https://api.github.com/repos/iotaledger/entangled/issues/366/comments","statuses_url":"https://api.github.com/repos/iotaledger/entangled/statuses/2d7a1c35b30764bd410edb480f985c91a2399ef9","head":{"label":"tsvisabo:walker_validator","ref":"walker_validator","sha":"2d7a1c35b30764bd410edb480f985c91a2399ef9","user":{"login":"tsvisabo","id":37177579,"node_id":"MDQ6VXNlcjM3MTc3NTc5","avatar_url":"https://avatars3.githubusercontent.com/u/37177579?v=4","gravatar_id":"","url":"https://api.github.com/users/tsvisabo","html_url":"https://github.com/tsvisabo","followers_url":"https://api.github.com/users/tsvisabo/followers","following_url":"https://api.github.com/users/tsvisabo/following{/other_user}","gists_url":"https://api.github.com/users/tsvisabo/gists{/gist_id}","starred_url":"https://api.github.com/users/tsvisabo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsvisabo/subscriptions","organizations_url":"https://api.github.com/users/tsvisabo/orgs","repos_url":"https://api.github.com/users/tsvisabo/repos","events_url":"https://api.github.com/users/tsvisabo/events{/privacy}","received_events_url":"https://api.github.com/users/tsvisabo/received_events","type":"User","site_admin":false},"repo":{"id":137086877,"node_id":"MDEwOlJlcG9zaXRvcnkxMzcwODY4Nzc=","name":"entangled","full_name":"tsvisabo/entangled","private":false,"owner":{"login":"tsvisabo","id":37177579,"node_id":"MDQ6VXNlcjM3MTc3NTc5","avatar_url":"https://avatars3.githubusercontent.com/u/37177579?v=4","gravatar_id":"","url":"https://api.github.com/users/tsvisabo","html_url":"https://github.com/tsvisabo","followers_url":"https://api.github.com/users/tsvisabo/followers","following_url":"https://api.github.com/users/tsvisabo/following{/other_user}","gists_url":"https://api.github.com/users/tsvisabo/gists{/gist_id}","starred_url":"https://api.github.com/users/tsvisabo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsvisabo/subscriptions","organizations_url":"https://api.github.com/users/tsvisabo/orgs","repos_url":"https://api.github.com/users/tsvisabo/repos","events_url":"https://api.github.com/users/tsvisabo/events{/privacy}","received_events_url":"https://api.github.com/users/tsvisabo/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tsvisabo/entangled","description":null,"fork":true,"url":"https://api.github.com/repos/tsvisabo/entangled","forks_url":"https://api.github.com/repos/tsvisabo/entangled/forks","keys_url":"https://api.github.com/repos/tsvisabo/entangled/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tsvisabo/entangled/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tsvisabo/entangled/teams","hooks_url":"https://api.github.com/repos/tsvisabo/entangled/hooks","issue_events_url":"https://api.github.com/repos/tsvisabo/entangled/issues/events{/number}","events_url":"https://api.github.com/repos/tsvisabo/entangled/events","assignees_url":"https://api.github.com/repos/tsvisabo/entangled/assignees{/user}","branches_url":"https://api.github.com/repos/tsvisabo/entangled/branches{/branch}","tags_url":"https://api.github.com/repos/tsvisabo/entangled/tags","blobs_url":"https://api.github.com/repos/tsvisabo/entangled/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tsvisabo/entangled/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tsvisabo/entangled/git/refs{/sha}","trees_url":"https://api.github.com/repos/tsvisabo/entangled/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tsvisabo/entangled/statuses/{sha}","languages_url":"https://api.github.com/repos/tsvisabo/entangled/languages","stargazers_url":"https://api.github.com/repos/tsvisabo/entangled/stargazers","contributors_url":"https://api.github.com/repos/tsvisabo/entangled/contributors","subscribers_url":"https://api.github.com/repos/tsvisabo/entangled/subscribers","subscription_url":"https://api.github.com/repos/tsvisabo/entangled/subscription","commits_url":"https://api.github.com/repos/tsvisabo/entangled/commits{/sha}","git_commits_url":"https://api.github.com/repos/tsvisabo/entangled/git/commits{/sha}","comments_url":"https://api.github.com/repos/tsvisabo/entangled/comments{/number}","issue_comment_url":"https://api.github.com/repos/tsvisabo/entangled/issues/comments{/number}","contents_url":"https://api.github.com/repos/tsvisabo/entangled/contents/{+path}","compare_url":"https://api.github.com/repos/tsvisabo/entangled/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tsvisabo/entangled/merges","archive_url":"https://api.github.com/repos/tsvisabo/entangled/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tsvisabo/entangled/downloads","issues_url":"https://api.github.com/repos/tsvisabo/entangled/issues{/number}","pulls_url":"https://api.github.com/repos/tsvisabo/entangled/pulls{/number}","milestones_url":"https://api.github.com/repos/tsvisabo/entangled/milestones{/number}","notifications_url":"https://api.github.com/repos/tsvisabo/entangled/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tsvisabo/entangled/labels{/name}","releases_url":"https://api.github.com/repos/tsvisabo/entangled/releases{/id}","deployments_url":"https://api.github.com/repos/tsvisabo/entangled/deployments","created_at":"2018-06-12T14:51:30Z","updated_at":"2018-07-03T08:59:13Z","pushed_at":"2018-10-07T18:59:17Z","git_url":"git://github.com/tsvisabo/entangled.git","ssh_url":"git@github.com:tsvisabo/entangled.git","clone_url":"https://github.com/tsvisabo/entangled.git","svn_url":"https://github.com/tsvisabo/entangled","homepage":null,"size":1513,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"iotaledger:develop","ref":"develop","sha":"a6e7ab85571977f96001cf1fc61dfc2b9a99649d","user":{"login":"iotaledger","id":20126597,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMTI2NTk3","avatar_url":"https://avatars3.githubusercontent.com/u/20126597?v=4","gravatar_id":"","url":"https://api.github.com/users/iotaledger","html_url":"https://github.com/iotaledger","followers_url":"https://api.github.com/users/iotaledger/followers","following_url":"https://api.github.com/users/iotaledger/following{/other_user}","gists_url":"https://api.github.com/users/iotaledger/gists{/gist_id}","starred_url":"https://api.github.com/users/iotaledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iotaledger/subscriptions","organizations_url":"https://api.github.com/users/iotaledger/orgs","repos_url":"https://api.github.com/users/iotaledger/repos","events_url":"https://api.github.com/users/iotaledger/events{/privacy}","received_events_url":"https://api.github.com/users/iotaledger/received_events","type":"Organization","site_admin":false},"repo":{"id":137051507,"node_id":"MDEwOlJlcG9zaXRvcnkxMzcwNTE1MDc=","name":"entangled","full_name":"iotaledger/entangled","private":false,"owner":{"login":"iotaledger","id":20126597,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMTI2NTk3","avatar_url":"https://avatars3.githubusercontent.com/u/20126597?v=4","gravatar_id":"","url":"https://api.github.com/users/iotaledger","html_url":"https://github.com/iotaledger","followers_url":"https://api.github.com/users/iotaledger/followers","following_url":"https://api.github.com/users/iotaledger/following{/other_user}","gists_url":"https://api.github.com/users/iotaledger/gists{/gist_id}","starred_url":"https://api.github.com/users/iotaledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iotaledger/subscriptions","organizations_url":"https://api.github.com/users/iotaledger/orgs","repos_url":"https://api.github.com/users/iotaledger/repos","events_url":"https://api.github.com/users/iotaledger/events{/privacy}","received_events_url":"https://api.github.com/users/iotaledger/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/iotaledger/entangled","description":"enTangle'd is an amalgamation of all things Tangle","fork":false,"url":"https://api.github.com/repos/iotaledger/entangled","forks_url":"https://api.github.com/repos/iotaledger/entangled/forks","keys_url":"https://api.github.com/repos/iotaledger/entangled/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iotaledger/entangled/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iotaledger/entangled/teams","hooks_url":"https://api.github.com/repos/iotaledger/entangled/hooks","issue_events_url":"https://api.github.com/repos/iotaledger/entangled/issues/events{/number}","events_url":"https://api.github.com/repos/iotaledger/entangled/events","assignees_url":"https://api.github.com/repos/iotaledger/entangled/assignees{/user}","branches_url":"https://api.github.com/repos/iotaledger/entangled/branches{/branch}","tags_url":"https://api.github.com/repos/iotaledger/entangled/tags","blobs_url":"https://api.github.com/repos/iotaledger/entangled/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iotaledger/entangled/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iotaledger/entangled/git/refs{/sha}","trees_url":"https://api.github.com/repos/iotaledger/entangled/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iotaledger/entangled/statuses/{sha}","languages_url":"https://api.github.com/repos/iotaledger/entangled/languages","stargazers_url":"https://api.github.com/repos/iotaledger/entangled/stargazers","contributors_url":"https://api.github.com/repos/iotaledger/entangled/contributors","subscribers_url":"https://api.github.com/repos/iotaledger/entangled/subscribers","subscription_url":"https://api.github.com/repos/iotaledger/entangled/subscription","commits_url":"https://api.github.com/repos/iotaledger/entangled/commits{/sha}","git_commits_url":"https://api.github.com/repos/iotaledger/entangled/git/commits{/sha}","comments_url":"https://api.github.com/repos/iotaledger/entangled/comments{/number}","issue_comment_url":"https://api.github.com/repos/iotaledger/entangled/issues/comments{/number}","contents_url":"https://api.github.com/repos/iotaledger/entangled/contents/{+path}","compare_url":"https://api.github.com/repos/iotaledger/entangled/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iotaledger/entangled/merges","archive_url":"https://api.github.com/repos/iotaledger/entangled/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iotaledger/entangled/downloads","issues_url":"https://api.github.com/repos/iotaledger/entangled/issues{/number}","pulls_url":"https://api.github.com/repos/iotaledger/entangled/pulls{/number}","milestones_url":"https://api.github.com/repos/iotaledger/entangled/milestones{/number}","notifications_url":"https://api.github.com/repos/iotaledger/entangled/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iotaledger/entangled/labels{/name}","releases_url":"https://api.github.com/repos/iotaledger/entangled/releases{/id}","deployments_url":"https://api.github.com/repos/iotaledger/entangled/deployments","created_at":"2018-06-12T09:49:47Z","updated_at":"2018-10-08T03:31:28Z","pushed_at":"2018-10-08T07:46:38Z","git_url":"git://github.com/iotaledger/entangled.git","ssh_url":"git@github.com:iotaledger/entangled.git","clone_url":"https://github.com/iotaledger/entangled.git","svn_url":"https://github.com/iotaledger/entangled","homepage":"","size":1456,"stargazers_count":31,"watchers_count":31,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"open_issues_count":98,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":24,"open_issues":98,"watchers":31,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/iotaledger/entangled/pulls/366"},"html":{"href":"https://github.com/iotaledger/entangled/pull/366"},"issue":{"href":"https://api.github.com/repos/iotaledger/entangled/issues/366"},"comments":{"href":"https://api.github.com/repos/iotaledger/entangled/issues/366/comments"},"review_comments":{"href":"https://api.github.com/repos/iotaledger/entangled/pulls/366/comments"},"review_comment":{"href":"https://api.github.com/repos/iotaledger/entangled/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/iotaledger/entangled/pulls/366/commits"},"statuses":{"href":"https://api.github.com/repos/iotaledger/entangled/statuses/2d7a1c35b30764bd410edb480f985c91a2399ef9"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"tsvisabo"}}