{"push_id":2897745329,"size":26,"distinct_size":26,"ref":"refs/heads/EMP-416_ommitted_review_comments","head":"a1a315d4b85f4a1745d4d2597623f98ee75e7c85","before":"6ee580bcf094404811d305ec368876a440398920","commits":[{"sha":"7f499919c94d422a2cbc8843fab461baf5b60a9a","author":{"name":"Olliver Schinagl","email":"c539153ba1f947bd4b6f910263b967c4a0a62357@schinagl.nl"},"message":"Whitespace fix\n\nSigned-off-by: Olliver Schinagl <oliver@schinagl.nl>","distinct":true,"url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/commits/7f499919c94d422a2cbc8843fab461baf5b60a9a"},{"sha":"ae8a131301a0827db4d1fce8be227df6812df898","author":{"name":"Olliver Schinagl","email":"c539153ba1f947bd4b6f910263b967c4a0a62357@schinagl.nl"},"message":"Always use the :? parameter substitution parameter with rm\n\nWhile checks and tests are in place, it is a good pattern to use :? on\na variable when using rm -rf.\n\nThe exception being when we are echoing the command, as we would exit\nhalf-way an echo print.\n\nNote, that while set -u should cover for this error, to ensure this\nalways works, it is simply good practice to always do it, even when not\nneeded.\n\nContributes to EMP-416\n\nSigned-off-by: Olliver Schinagl <oliver@schinagl.nl>","distinct":true,"url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/commits/ae8a131301a0827db4d1fce8be227df6812df898"},{"sha":"4a61abd1bbf021b796cb0b82df3e30e40348d890","author":{"name":"Olliver Schinagl","email":"c539153ba1f947bd4b6f910263b967c4a0a62357@schinagl.nl"},"message":"build: Store executable state in git\n\nWe should use our version control system to store the executable state\nof a binary/script in git. As such, we should also not force the\nexecutable state during the build step, but actually only run the\nscript if it is marked as executable on the target.\n\nAttributes to EMP-382, contributes to EMP-416\n\nSigned-off-by: Olliver Schinagl <oliver@schinagl.nl>","distinct":true,"url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/commits/4a61abd1bbf021b796cb0b82df3e30e40348d890"},{"sha":"a98244a6f2f7a945e4c62b0f53202ca90916ed1f","author":{"name":"Olliver Schinagl","email":"c539153ba1f947bd4b6f910263b967c4a0a62357@schinagl.nl"},"message":"build: Do not force a shell for execution\n\nOur scripts have a proper shebang, do not force execution via some\nshell, but let the shebang handle using the proper interpreter.\n\nAddresses to EMP-382, contributes to EMP-416\n\nSigned-off-by: Olliver Schinagl <oliver@schinagl.nl>","distinct":true,"url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/commits/a98244a6f2f7a945e4c62b0f53202ca90916ed1f"},{"sha":"2d6a4ed032aee0f621a2044492bacbe1940e7a2e","author":{"name":"Olliver Schinagl","email":"c539153ba1f947bd4b6f910263b967c4a0a62357@schinagl.nl"},"message":"scripts/start_update: Do not exec functions in an if\n\nTrapping a function in an if statement, causes set -e and set -u to no\nlonger function. This is by design. This would have as a consequence\nthat every command now needs to be appended with || return 1.\n\nThis is error prone when return statements are missing for example, steps would\nstill continue even though something is wrong.\n\nInstead, we have to ensure that our cleanup steps and calling function\ndo the proper thing on failure.\n\nFail early, fail often.\n\nAddresses to EMP-382, contributes to EMP-416\n\nSigned-off-by: Olliver Schinagl <oliver@schinagl.nl>","distinct":true,"url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/commits/2d6a4ed032aee0f621a2044492bacbe1940e7a2e"},{"sha":"15fb368e2344e48bd0da0bf28c4f289f43b84b19","author":{"name":"Olliver Schinagl","email":"c539153ba1f947bd4b6f910263b967c4a0a62357@schinagl.nl"},"message":"build: reduce dependencies\n\nAs we have been using sed throughout this project, we can replace\nenvsubst with sed and drop an otherwise unneeded dependency.\n\nContributes to EMP-416\n\nSigned-off-by: Olliver Schinagl <oliver@schinagl.nl>","distinct":true,"url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/commits/15fb368e2344e48bd0da0bf28c4f289f43b84b19"},{"sha":"f781d110231faacacc25634218f220fa34db4732","author":{"name":"Olliver Schinagl","email":"c539153ba1f947bd4b6f910263b967c4a0a62357@schinagl.nl"},"message":"test/buildenv: Use multi-line string for PACKAGES\n\nTo improve readability and sort ability use a multi-line string for\nPACKAGES.\n\nContributes to EMP-416\n\nSigned-off-by: Olliver Schinagl <oliver@schinagl.nl>","distinct":true,"url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/commits/f781d110231faacacc25634218f220fa34db4732"},{"sha":"d6df73af09d3f50f55139c9f5bcbad93b49280b0","author":{"name":"Olliver Schinagl","email":"c539153ba1f947bd4b6f910263b967c4a0a62357@schinagl.nl"},"message":"build: Safe removal of the build directory\n\nNever rm -rf a directory without checking anything. The tool will\nhappily rm anything you throw at it, including\n\"${EMPTYVAR1}/${EMPTYVAR2}\" resolving to rm -rf /.\n\nNote that in this specific case, shellcheck will warn you and suggest\nusing \"${EMPTYVAR1:?}\" to avoid var1 from being empty. Obviously this\nwon't be trigged when doing PATH=\"${EMPTYVAR1}/${EMPTYVAR2}\"; rm -rf\n\"${PATH}\".\n\nBy using a fixed name template and check for its existence we can\n_reduce_ chances of breakage.\n\nContributes to EMP-416\n\nSigned-off-by: Olliver Schinagl <oliver@schinagl.nl>","distinct":true,"url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/commits/d6df73af09d3f50f55139c9f5bcbad93b49280b0"},{"sha":"20dbe565235f18829003323629e20d69e65ffb62","author":{"name":"Olliver Schinagl","email":"c539153ba1f947bd4b6f910263b967c4a0a62357@schinagl.nl"},"message":"packaging: Define a debian section\n\nThe toolbox is a utility thus lets put it under the utils section.\n\nContributes to EMP-416\n\nSigned-off-by: Olliver Schinagl <oliver@schinagl.nl>","distinct":true,"url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/commits/20dbe565235f18829003323629e20d69e65ffb62"},{"sha":"ef0bb015f66ff5ce11bcf49dfbd88c6c2542832d","author":{"name":"Olliver Schinagl","email":"c539153ba1f947bd4b6f910263b967c4a0a62357@schinagl.nl"},"message":"Use consistent variables for directories\n\nThis patch makes use of more consistent and standard directory naming\nvia variables.\n\nContributes to EMP-416\n\nSigned-off-by: Olliver Schinagl <oliver@schinagl.nl>","distinct":true,"url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/commits/ef0bb015f66ff5ce11bcf49dfbd88c6c2542832d"},{"sha":"b522afe154b09e3fa16501ec8dbb0936e909342c","author":{"name":"Olliver Schinagl","email":"c539153ba1f947bd4b6f910263b967c4a0a62357@schinagl.nl"},"message":"CI: Do not use a custom shell\n\nThe buildenv shouldn't be run with a custom shell (let the shebang\nhandle the shell choice). Further more, we shouldn't force set -x as it\nmakes the output rather noisy.\n\nContributes to EMP-416\n\nSigned-off-by: Olliver Schinagl <oliver@schinagl.nl>","distinct":true,"url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/commits/b522afe154b09e3fa16501ec8dbb0936e909342c"},{"sha":"1a25ad5cd0b31e640464780515181337da1d33c4","author":{"name":"Olliver Schinagl","email":"c539153ba1f947bd4b6f910263b967c4a0a62357@schinagl.nl"},"message":"scripts/prepare_disk: Be more verbal on mandatory arguments\n\nThe prepare disk script has two mandatory arguments. Make this extra\nclear in the usage information and check for them individually to avoid\nhaving to guess which argument is failing.\n\nContributes to EMP-416\n\nSigned-off-by: Olliver Schinagl <oliver@schinagl.nl>","distinct":true,"url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/commits/1a25ad5cd0b31e640464780515181337da1d33c4"},{"sha":"fff97ba5f407f9a7d16a397997c0c4b21708bba8","author":{"name":"Olliver Schinagl","email":"c539153ba1f947bd4b6f910263b967c4a0a62357@schinagl.nl"},"message":"Always use / as path separator\n\nWhen concatenating two variables that are both paths, we should always\nadd a / separator in between. This avoids having to think about how to\nend a path in a variable (PATH=/dir vs PATH=/dir/).\n\nContributes to EMP-416\n\nSigned-off-by: Olliver Schinagl <oliver@schinagl.nl>","distinct":true,"url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/commits/fff97ba5f407f9a7d16a397997c0c4b21708bba8"},{"sha":"901d3752f4d5f385c83f71e8423a91b670dbdb1a","author":{"name":"Olliver Schinagl","email":"c539153ba1f947bd4b6f910263b967c4a0a62357@schinagl.nl"},"message":"scripts/start_update: Do not bind mount procfs\n\nThere is no need to bind mount the proc device. We can just do a\nregular mount, making the function more consistent.\n\nContributes to EMP-416\n\nSigned-off-by: Olliver Schinagl <oliver@schinagl.nl>","distinct":true,"url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/commits/901d3752f4d5f385c83f71e8423a91b670dbdb1a"},{"sha":"86529a973b6a0bd8fc4851386617959440593684","author":{"name":"Olliver Schinagl","email":"c539153ba1f947bd4b6f910263b967c4a0a62357@schinagl.nl"},"message":"scripts/start_update: Do not use an unneeded temporary dir\n\nCurrently, we create a temporary directory, for example /tmp/tempdir1\nand then bind mount this to /toolbox_mount/update_source.\n\nWe do this because /toolbox_mount/update_source is not writable. Much\neasier is of course to mount a tmpfs directory onto this directory\nmaking the it writable instead.\n\nContributes to EMP-416\n\nSigned-off-by: Olliver Schinagl <oliver@schinagl.nl>","distinct":true,"url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/commits/86529a973b6a0bd8fc4851386617959440593684"},{"sha":"0f229aa3def39889890b6929aac5e0eb5735f7d5","author":{"name":"Olliver Schinagl","email":"c539153ba1f947bd4b6f910263b967c4a0a62357@schinagl.nl"},"message":"chroot_environment: Use multi-line strings\n\nBy using multi-line strings we can improve readability and\nsort-ability.\n\nBecause of that, this patch also sorts these strings.\n\nContributes to EMP-416.\n\nSigned-off-by: Olliver Schinagl <oliver@schinagl.nl>","distinct":true,"url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/commits/0f229aa3def39889890b6929aac5e0eb5735f7d5"},{"sha":"688a08257a91fc7ddc287a6822cbaa5c49e60367","author":{"name":"Olliver Schinagl","email":"c539153ba1f947bd4b6f910263b967c4a0a62357@schinagl.nl"},"message":"tar: change how arguments are supplied\n\nCommand line utilities tend to very often use hyphens. We also use\nhyphens throughout the project, except on some instances of tar. Let us\nalso use a hyphen there to be consistent.\n\nFurther more, we should synchronize the order. Most importantly, the f\nparameter, indicating a file is to come, should be last, or rather\nin front of the file.\n\nContributes to EMP-416\n\nSigned-off-by: Olliver Schinagl <oliver@schinagl.nl>","distinct":true,"url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/commits/688a08257a91fc7ddc287a6822cbaa5c49e60367"},{"sha":"ba719eb400a029f3608d4ec1421c356b1bea310b","author":{"name":"Olliver Schinagl","email":"c539153ba1f947bd4b6f910263b967c4a0a62357@schinagl.nl"},"message":"Improve some wording/texts\n\nContributes to EMP-416\n\nSigned-off-by: Olliver Schinagl <oliver@schinagl.nl>","distinct":true,"url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/commits/ba719eb400a029f3608d4ec1421c356b1bea310b"},{"sha":"419a4762340f5a8fdd72faec11f509f9dcac1a02","author":{"name":"Olliver Schinagl","email":"c539153ba1f947bd4b6f910263b967c4a0a62357@schinagl.nl"},"message":"partition_table: Add some comments/cleanups\n\nRemove the actual disk information from the partition table, as that is\nvery target specific.\n\nAdditionally, while here add some comments and improve readability.\n\nContributes to EMP-416\n\nSigned-off-by: Olliver Schinagl <oliver@schinagl.nl>","distinct":true,"url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/commits/419a4762340f5a8fdd72faec11f509f9dcac1a02"},{"sha":"dcf5b8c9447d3c78725fcdbf6f9fcff8e88962a2","author":{"name":"Olliver Schinagl","email":"c539153ba1f947bd4b6f910263b967c4a0a62357@schinagl.nl"},"message":"partition_table: Ensure the names are strings\n\nWhile non quoted strings seem to work, sfdisk expects strings. Lets be\nproper developers and quote the strings, as sfdisk --dump would also\ngenerate them.\n\nContributes to EMP-416\n\nSigned-off-by: Olliver Schinagl <oliver@schinagl.nl>","distinct":true,"url":"https://api.github.com/repos/Ultimaker/um-update_toolbox_armhf/commits/dcf5b8c9447d3c78725fcdbf6f9fcff8e88962a2"}]}
{"actor":{"display_login":"oliv3r"}}