{"action":"created","comment":{"url":"https://api.github.com/repos/ckeditor/ckeditor5-react/pulls/comments/203684749","pull_request_review_id":138620871,"id":203684749,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMzY4NDc0OQ==","diff_hunk":"@@ -33,25 +33,25 @@ export default class CKEditor extends React.Component {\n \n \t// Render <div> element which will be replaced by CKEditor.\n \trender() {\n-\t\treturn <div ref={ ref => ( this.domContainer = ref ) }></div>;\n+\t\treturn (\n+\t\t\t<div ref={ ref => ( this.domContainer = ref ) }></div>\n+\t\t);\n \t}\n \n \t_initializeEditor() {\n \t\tthis.props.editor\n \t\t\t.create( this.domContainer, this.props.config )\n \t\t\t.then( editor => {\n-\t\t\t\tthis.editorInstance = editor;\n-\n-\t\t\t\t// TODO: Pass data via constructor.\n-\t\t\t\tthis.editorInstance.setData( this.props.data );\n+\t\t\t\tthis.editor = editor;\n+\t\t\t\tthis.editor.setData( this.props.data );\n \n-\t\t\t\t// TODO: Add example using it.\n \t\t\t\tif ( this.props.onInit ) {\n-\t\t\t\t\tthis.props.onInit( editor );\n+\t\t\t\t\tthis.props.onInit( this.editor );\n \t\t\t\t}\n \n \t\t\t\tif ( this.props.onChange ) {","path":"src/ckeditor.jsx","position":62,"original_position":62,"commit_id":"4142d9a430a278d03e6f01f88a4e3f0af62bbe66","original_commit_id":"4142d9a430a278d03e6f01f88a4e3f0af62bbe66","user":{"login":"ma2ciek","id":2768047,"node_id":"MDQ6VXNlcjI3NjgwNDc=","avatar_url":"https://avatars2.githubusercontent.com/u/2768047?v=4","gravatar_id":"","url":"https://api.github.com/users/ma2ciek","html_url":"https://github.com/ma2ciek","followers_url":"https://api.github.com/users/ma2ciek/followers","following_url":"https://api.github.com/users/ma2ciek/following{/other_user}","gists_url":"https://api.github.com/users/ma2ciek/gists{/gist_id}","starred_url":"https://api.github.com/users/ma2ciek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ma2ciek/subscriptions","organizations_url":"https://api.github.com/users/ma2ciek/orgs","repos_url":"https://api.github.com/users/ma2ciek/repos","events_url":"https://api.github.com/users/ma2ciek/events{/privacy}","received_events_url":"https://api.github.com/users/ma2ciek/received_events","type":"User","site_admin":false},"body":"I'd move this inside the listener, as this property can be changed at runtime.","created_at":"2018-07-19T10:59:12Z","updated_at":"2018-07-19T10:59:12Z","html_url":"https://github.com/ckeditor/ckeditor5-react/pull/14#discussion_r203684749","pull_request_url":"https://api.github.com/repos/ckeditor/ckeditor5-react/pulls/14","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ckeditor/ckeditor5-react/pulls/comments/203684749"},"html":{"href":"https://github.com/ckeditor/ckeditor5-react/pull/14#discussion_r203684749"},"pull_request":{"href":"https://api.github.com/repos/ckeditor/ckeditor5-react/pulls/14"}}},"pull_request":{"url":"https://api.github.com/repos/ckeditor/ckeditor5-react/pulls/14","id":202187994,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyMTg3OTk0","html_url":"https://github.com/ckeditor/ckeditor5-react/pull/14","diff_url":"https://github.com/ckeditor/ckeditor5-react/pull/14.diff","patch_url":"https://github.com/ckeditor/ckeditor5-react/pull/14.patch","issue_url":"https://api.github.com/repos/ckeditor/ckeditor5-react/issues/14","number":14,"state":"open","locked":false,"title":"Improvements before publishing","user":{"login":"pomek","id":2270764,"node_id":"MDQ6VXNlcjIyNzA3NjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/2270764?v=4","gravatar_id":"","url":"https://api.github.com/users/pomek","html_url":"https://github.com/pomek","followers_url":"https://api.github.com/users/pomek/followers","following_url":"https://api.github.com/users/pomek/following{/other_user}","gists_url":"https://api.github.com/users/pomek/gists{/gist_id}","starred_url":"https://api.github.com/users/pomek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pomek/subscriptions","organizations_url":"https://api.github.com/users/pomek/orgs","repos_url":"https://api.github.com/users/pomek/repos","events_url":"https://api.github.com/users/pomek/events{/privacy}","received_events_url":"https://api.github.com/users/pomek/received_events","type":"User","site_admin":false},"body":"### Suggested merge commit message ([convention](https://github.com/ckeditor/ckeditor5-design/wiki/Git-commit-message-convention))\r\n\r\nOther: First developer preview version. It contains ready-to-use `CKEditor` component that allows using CKEditor 5 Builds and CKEditor 5 Framework in React application. Closes #1. Closes #3. Closes #5. Closes #7. \r\n\r\n---\r\n\r\n### Additional information\r\n\r\nI'm aware of #13 but it can take some time but would be good to see how the component is used by other developers.\r\n","created_at":"2018-07-18T09:18:34Z","updated_at":"2018-07-19T10:59:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a301b5d18318da33719f505303064a5ba1863523","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ckeditor/ckeditor5-react/pulls/14/commits","review_comments_url":"https://api.github.com/repos/ckeditor/ckeditor5-react/pulls/14/comments","review_comment_url":"https://api.github.com/repos/ckeditor/ckeditor5-react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ckeditor/ckeditor5-react/issues/14/comments","statuses_url":"https://api.github.com/repos/ckeditor/ckeditor5-react/statuses/4142d9a430a278d03e6f01f88a4e3f0af62bbe66","head":{"label":"ckeditor:t/5","ref":"t/5","sha":"4142d9a430a278d03e6f01f88a4e3f0af62bbe66","user":{"login":"ckeditor","id":825710,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyNTcxMA==","avatar_url":"https://avatars2.githubusercontent.com/u/825710?v=4","gravatar_id":"","url":"https://api.github.com/users/ckeditor","html_url":"https://github.com/ckeditor","followers_url":"https://api.github.com/users/ckeditor/followers","following_url":"https://api.github.com/users/ckeditor/following{/other_user}","gists_url":"https://api.github.com/users/ckeditor/gists{/gist_id}","starred_url":"https://api.github.com/users/ckeditor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckeditor/subscriptions","organizations_url":"https://api.github.com/users/ckeditor/orgs","repos_url":"https://api.github.com/users/ckeditor/repos","events_url":"https://api.github.com/users/ckeditor/events{/privacy}","received_events_url":"https://api.github.com/users/ckeditor/received_events","type":"Organization","site_admin":false},"repo":{"id":133363789,"node_id":"MDEwOlJlcG9zaXRvcnkxMzMzNjM3ODk=","name":"ckeditor5-react","full_name":"ckeditor/ckeditor5-react","owner":{"login":"ckeditor","id":825710,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyNTcxMA==","avatar_url":"https://avatars2.githubusercontent.com/u/825710?v=4","gravatar_id":"","url":"https://api.github.com/users/ckeditor","html_url":"https://github.com/ckeditor","followers_url":"https://api.github.com/users/ckeditor/followers","following_url":"https://api.github.com/users/ckeditor/following{/other_user}","gists_url":"https://api.github.com/users/ckeditor/gists{/gist_id}","starred_url":"https://api.github.com/users/ckeditor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckeditor/subscriptions","organizations_url":"https://api.github.com/users/ckeditor/orgs","repos_url":"https://api.github.com/users/ckeditor/repos","events_url":"https://api.github.com/users/ckeditor/events{/privacy}","received_events_url":"https://api.github.com/users/ckeditor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ckeditor/ckeditor5-react","description":"Official CKEditor 5 React component.","fork":false,"url":"https://api.github.com/repos/ckeditor/ckeditor5-react","forks_url":"https://api.github.com/repos/ckeditor/ckeditor5-react/forks","keys_url":"https://api.github.com/repos/ckeditor/ckeditor5-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ckeditor/ckeditor5-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ckeditor/ckeditor5-react/teams","hooks_url":"https://api.github.com/repos/ckeditor/ckeditor5-react/hooks","issue_events_url":"https://api.github.com/repos/ckeditor/ckeditor5-react/issues/events{/number}","events_url":"https://api.github.com/repos/ckeditor/ckeditor5-react/events","assignees_url":"https://api.github.com/repos/ckeditor/ckeditor5-react/assignees{/user}","branches_url":"https://api.github.com/repos/ckeditor/ckeditor5-react/branches{/branch}","tags_url":"https://api.github.com/repos/ckeditor/ckeditor5-react/tags","blobs_url":"https://api.github.com/repos/ckeditor/ckeditor5-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ckeditor/ckeditor5-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ckeditor/ckeditor5-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/ckeditor/ckeditor5-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ckeditor/ckeditor5-react/statuses/{sha}","languages_url":"https://api.github.com/repos/ckeditor/ckeditor5-react/languages","stargazers_url":"https://api.github.com/repos/ckeditor/ckeditor5-react/stargazers","contributors_url":"https://api.github.com/repos/ckeditor/ckeditor5-react/contributors","subscribers_url":"https://api.github.com/repos/ckeditor/ckeditor5-react/subscribers","subscription_url":"https://api.github.com/repos/ckeditor/ckeditor5-react/subscription","commits_url":"https://api.github.com/repos/ckeditor/ckeditor5-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/ckeditor/ckeditor5-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/ckeditor/ckeditor5-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/ckeditor/ckeditor5-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/ckeditor/ckeditor5-react/contents/{+path}","compare_url":"https://api.github.com/repos/ckeditor/ckeditor5-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ckeditor/ckeditor5-react/merges","archive_url":"https://api.github.com/repos/ckeditor/ckeditor5-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ckeditor/ckeditor5-react/downloads","issues_url":"https://api.github.com/repos/ckeditor/ckeditor5-react/issues{/number}","pulls_url":"https://api.github.com/repos/ckeditor/ckeditor5-react/pulls{/number}","milestones_url":"https://api.github.com/repos/ckeditor/ckeditor5-react/milestones{/number}","notifications_url":"https://api.github.com/repos/ckeditor/ckeditor5-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ckeditor/ckeditor5-react/labels{/name}","releases_url":"https://api.github.com/repos/ckeditor/ckeditor5-react/releases{/id}","deployments_url":"https://api.github.com/repos/ckeditor/ckeditor5-react/deployments","created_at":"2018-05-14T13:20:55Z","updated_at":"2018-07-13T08:20:09Z","pushed_at":"2018-07-18T13:00:13Z","git_url":"git://github.com/ckeditor/ckeditor5-react.git","ssh_url":"git@github.com:ckeditor/ckeditor5-react.git","clone_url":"https://github.com/ckeditor/ckeditor5-react.git","svn_url":"https://github.com/ckeditor/ckeditor5-react","homepage":"https://ckeditor.com","size":50,"stargazers_count":11,"watchers_count":11,"language":null,"has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":9,"license":null,"forks":2,"open_issues":9,"watchers":11,"default_branch":"master"}},"base":{"label":"ckeditor:master","ref":"master","sha":"ee5461733ddb2f72612e042d4940d759580d3749","user":{"login":"ckeditor","id":825710,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyNTcxMA==","avatar_url":"https://avatars2.githubusercontent.com/u/825710?v=4","gravatar_id":"","url":"https://api.github.com/users/ckeditor","html_url":"https://github.com/ckeditor","followers_url":"https://api.github.com/users/ckeditor/followers","following_url":"https://api.github.com/users/ckeditor/following{/other_user}","gists_url":"https://api.github.com/users/ckeditor/gists{/gist_id}","starred_url":"https://api.github.com/users/ckeditor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckeditor/subscriptions","organizations_url":"https://api.github.com/users/ckeditor/orgs","repos_url":"https://api.github.com/users/ckeditor/repos","events_url":"https://api.github.com/users/ckeditor/events{/privacy}","received_events_url":"https://api.github.com/users/ckeditor/received_events","type":"Organization","site_admin":false},"repo":{"id":133363789,"node_id":"MDEwOlJlcG9zaXRvcnkxMzMzNjM3ODk=","name":"ckeditor5-react","full_name":"ckeditor/ckeditor5-react","owner":{"login":"ckeditor","id":825710,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyNTcxMA==","avatar_url":"https://avatars2.githubusercontent.com/u/825710?v=4","gravatar_id":"","url":"https://api.github.com/users/ckeditor","html_url":"https://github.com/ckeditor","followers_url":"https://api.github.com/users/ckeditor/followers","following_url":"https://api.github.com/users/ckeditor/following{/other_user}","gists_url":"https://api.github.com/users/ckeditor/gists{/gist_id}","starred_url":"https://api.github.com/users/ckeditor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckeditor/subscriptions","organizations_url":"https://api.github.com/users/ckeditor/orgs","repos_url":"https://api.github.com/users/ckeditor/repos","events_url":"https://api.github.com/users/ckeditor/events{/privacy}","received_events_url":"https://api.github.com/users/ckeditor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ckeditor/ckeditor5-react","description":"Official CKEditor 5 React component.","fork":false,"url":"https://api.github.com/repos/ckeditor/ckeditor5-react","forks_url":"https://api.github.com/repos/ckeditor/ckeditor5-react/forks","keys_url":"https://api.github.com/repos/ckeditor/ckeditor5-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ckeditor/ckeditor5-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ckeditor/ckeditor5-react/teams","hooks_url":"https://api.github.com/repos/ckeditor/ckeditor5-react/hooks","issue_events_url":"https://api.github.com/repos/ckeditor/ckeditor5-react/issues/events{/number}","events_url":"https://api.github.com/repos/ckeditor/ckeditor5-react/events","assignees_url":"https://api.github.com/repos/ckeditor/ckeditor5-react/assignees{/user}","branches_url":"https://api.github.com/repos/ckeditor/ckeditor5-react/branches{/branch}","tags_url":"https://api.github.com/repos/ckeditor/ckeditor5-react/tags","blobs_url":"https://api.github.com/repos/ckeditor/ckeditor5-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ckeditor/ckeditor5-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ckeditor/ckeditor5-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/ckeditor/ckeditor5-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ckeditor/ckeditor5-react/statuses/{sha}","languages_url":"https://api.github.com/repos/ckeditor/ckeditor5-react/languages","stargazers_url":"https://api.github.com/repos/ckeditor/ckeditor5-react/stargazers","contributors_url":"https://api.github.com/repos/ckeditor/ckeditor5-react/contributors","subscribers_url":"https://api.github.com/repos/ckeditor/ckeditor5-react/subscribers","subscription_url":"https://api.github.com/repos/ckeditor/ckeditor5-react/subscription","commits_url":"https://api.github.com/repos/ckeditor/ckeditor5-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/ckeditor/ckeditor5-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/ckeditor/ckeditor5-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/ckeditor/ckeditor5-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/ckeditor/ckeditor5-react/contents/{+path}","compare_url":"https://api.github.com/repos/ckeditor/ckeditor5-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ckeditor/ckeditor5-react/merges","archive_url":"https://api.github.com/repos/ckeditor/ckeditor5-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ckeditor/ckeditor5-react/downloads","issues_url":"https://api.github.com/repos/ckeditor/ckeditor5-react/issues{/number}","pulls_url":"https://api.github.com/repos/ckeditor/ckeditor5-react/pulls{/number}","milestones_url":"https://api.github.com/repos/ckeditor/ckeditor5-react/milestones{/number}","notifications_url":"https://api.github.com/repos/ckeditor/ckeditor5-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ckeditor/ckeditor5-react/labels{/name}","releases_url":"https://api.github.com/repos/ckeditor/ckeditor5-react/releases{/id}","deployments_url":"https://api.github.com/repos/ckeditor/ckeditor5-react/deployments","created_at":"2018-05-14T13:20:55Z","updated_at":"2018-07-13T08:20:09Z","pushed_at":"2018-07-18T13:00:13Z","git_url":"git://github.com/ckeditor/ckeditor5-react.git","ssh_url":"git@github.com:ckeditor/ckeditor5-react.git","clone_url":"https://github.com/ckeditor/ckeditor5-react.git","svn_url":"https://github.com/ckeditor/ckeditor5-react","homepage":"https://ckeditor.com","size":50,"stargazers_count":11,"watchers_count":11,"language":null,"has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":9,"license":null,"forks":2,"open_issues":9,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ckeditor/ckeditor5-react/pulls/14"},"html":{"href":"https://github.com/ckeditor/ckeditor5-react/pull/14"},"issue":{"href":"https://api.github.com/repos/ckeditor/ckeditor5-react/issues/14"},"comments":{"href":"https://api.github.com/repos/ckeditor/ckeditor5-react/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/ckeditor/ckeditor5-react/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/ckeditor/ckeditor5-react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ckeditor/ckeditor5-react/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/ckeditor/ckeditor5-react/statuses/4142d9a430a278d03e6f01f88a4e3f0af62bbe66"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"ma2ciek"}}