{"action":"created","issue":{"url":"https://api.github.com/repos/tony/libtmux/issues/68","repository_url":"https://api.github.com/repos/tony/libtmux","labels_url":"https://api.github.com/repos/tony/libtmux/issues/68/labels{/name}","comments_url":"https://api.github.com/repos/tony/libtmux/issues/68/comments","events_url":"https://api.github.com/repos/tony/libtmux/issues/68/events","html_url":"https://github.com/tony/libtmux/pull/68","id":250794018,"number":68,"title":"Make Server.has_session() use returncode","user":{"login":"jlargentaye","id":6608774,"avatar_url":"https://avatars0.githubusercontent.com/u/6608774?v=4","gravatar_id":"","url":"https://api.github.com/users/jlargentaye","html_url":"https://github.com/jlargentaye","followers_url":"https://api.github.com/users/jlargentaye/followers","following_url":"https://api.github.com/users/jlargentaye/following{/other_user}","gists_url":"https://api.github.com/users/jlargentaye/gists{/gist_id}","starred_url":"https://api.github.com/users/jlargentaye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlargentaye/subscriptions","organizations_url":"https://api.github.com/users/jlargentaye/orgs","repos_url":"https://api.github.com/users/jlargentaye/repos","events_url":"https://api.github.com/users/jlargentaye/events{/privacy}","received_events_url":"https://api.github.com/users/jlargentaye/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-08-17T00:02:32Z","updated_at":"2018-02-24T13:58:11Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/tony/libtmux/pulls/68","html_url":"https://github.com/tony/libtmux/pull/68","diff_url":"https://github.com/tony/libtmux/pull/68.diff","patch_url":"https://github.com/tony/libtmux/pull/68.patch"},"body":"has_session() would erroneously return true if tmux returned an unexpected\r\nstring, such as \"no current session\".\r\n\r\nInstead of adding yet another string to the list to check against, use the\r\nreturn code of the 'tmux has-session' command, which is documented to return 0\r\n(Shell true) if targeted session exists, and return 1 (Shell false) in any\r\nother case.\r\n\r\nThis is **untested**. While it passed selftest, so did the unpatched version."},"comment":{"url":"https://api.github.com/repos/tony/libtmux/issues/comments/368230176","html_url":"https://github.com/tony/libtmux/pull/68#issuecomment-368230176","issue_url":"https://api.github.com/repos/tony/libtmux/issues/68","id":368230176,"user":{"login":"tony","id":26336,"avatar_url":"https://avatars0.githubusercontent.com/u/26336?v=4","gravatar_id":"","url":"https://api.github.com/users/tony","html_url":"https://github.com/tony","followers_url":"https://api.github.com/users/tony/followers","following_url":"https://api.github.com/users/tony/following{/other_user}","gists_url":"https://api.github.com/users/tony/gists{/gist_id}","starred_url":"https://api.github.com/users/tony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tony/subscriptions","organizations_url":"https://api.github.com/users/tony/orgs","repos_url":"https://api.github.com/users/tony/repos","events_url":"https://api.github.com/users/tony/events{/privacy}","received_events_url":"https://api.github.com/users/tony/received_events","type":"User","site_admin":false},"created_at":"2018-02-24T13:58:11Z","updated_at":"2018-02-24T13:58:11Z","author_association":"OWNER","body":"I need more time on this, because I need to research and assure consistent behavior across older tmux versions.\r\n\r\nDoes #67 still happen?  Does it happen with all tmux versions, or only certain ones?\r\n\r\nIn https://github.com/tony/libtmux/issues/67#issuecomment-322926711 it says:\r\n\r\n> After doing a \"tmux kill-server\", I can't reproduce the issue. It's looks like previously the tmux server had stayed running after the last session finished.\r\n\r\nCan you try again? Have you ruled out it being a partial/fnmatch of the session name?"}}
{"actor":{"display_login":"tony"}}