{"action":"created","comment":{"url":"https://api.github.com/repos/purpleidea/mgmt/pulls/comments/202238859","pull_request_review_id":136900218,"id":202238859,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjIzODg1OQ==","diff_hunk":"@@ -92,3 +92,41 @@ func TestGraphSync2(t *testing.T) {\n \t\tt.Errorf(\"%s\", s)\n \t}\n }\n+\n+func TestGraphSync3(t *testing.T) {\n+\tv1 := NV(\"v1\")\n+\tv2 := NV(\"v2\")\n+\tv3 := NV(\"v3\")\n+\n+\te1 := NE(\"e1\")\n+\te2 := NE(\"e2\")\n+\te3 := NE(\"e3\")\n+\te4 := NE(\"e4\")\n+\n+\t//Base Graph with 3 edges","path":"pgraph/graphsync_test.go","position":15,"original_position":15,"commit_id":"7b97ddf0c636f9372aaafd9ec71134d126a461d2","original_commit_id":"7b97ddf0c636f9372aaafd9ec71134d126a461d2","user":{"login":"purpleidea","id":135091,"node_id":"MDQ6VXNlcjEzNTA5MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/135091?v=4","gravatar_id":"","url":"https://api.github.com/users/purpleidea","html_url":"https://github.com/purpleidea","followers_url":"https://api.github.com/users/purpleidea/followers","following_url":"https://api.github.com/users/purpleidea/following{/other_user}","gists_url":"https://api.github.com/users/purpleidea/gists{/gist_id}","starred_url":"https://api.github.com/users/purpleidea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/purpleidea/subscriptions","organizations_url":"https://api.github.com/users/purpleidea/orgs","repos_url":"https://api.github.com/users/purpleidea/repos","events_url":"https://api.github.com/users/purpleidea/events{/privacy}","received_events_url":"https://api.github.com/users/purpleidea/received_events","type":"User","site_admin":false},"body":"comments should be full sentences which start with a capital and end with a period, or not full sentences and not be capitalized. in both case the syntax is `// hello` not `//hello` (add a space after the `//`)","created_at":"2018-07-13T04:06:11Z","updated_at":"2018-07-13T04:08:34Z","html_url":"https://github.com/purpleidea/mgmt/pull/396#discussion_r202238859","pull_request_url":"https://api.github.com/repos/purpleidea/mgmt/pulls/396","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/purpleidea/mgmt/pulls/comments/202238859"},"html":{"href":"https://github.com/purpleidea/mgmt/pull/396#discussion_r202238859"},"pull_request":{"href":"https://api.github.com/repos/purpleidea/mgmt/pulls/396"}}},"pull_request":{"url":"https://api.github.com/repos/purpleidea/mgmt/pulls/396","id":201164309,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxMTY0MzA5","html_url":"https://github.com/purpleidea/mgmt/pull/396","diff_url":"https://github.com/purpleidea/mgmt/pull/396.diff","patch_url":"https://github.com/purpleidea/mgmt/pull/396.patch","issue_url":"https://api.github.com/repos/purpleidea/mgmt/issues/396","number":396,"state":"open","locked":false,"title":"Test patch for graphsync_test ","user":{"login":"ginywiny","id":36121273,"node_id":"MDQ6VXNlcjM2MTIxMjcz","avatar_url":"https://avatars0.githubusercontent.com/u/36121273?v=4","gravatar_id":"","url":"https://api.github.com/users/ginywiny","html_url":"https://github.com/ginywiny","followers_url":"https://api.github.com/users/ginywiny/followers","following_url":"https://api.github.com/users/ginywiny/following{/other_user}","gists_url":"https://api.github.com/users/ginywiny/gists{/gist_id}","starred_url":"https://api.github.com/users/ginywiny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ginywiny/subscriptions","organizations_url":"https://api.github.com/users/ginywiny/orgs","repos_url":"https://api.github.com/users/ginywiny/repos","events_url":"https://api.github.com/users/ginywiny/events{/privacy}","received_events_url":"https://api.github.com/users/ginywiny/received_events","type":"User","site_admin":false},"body":"This patch is an addition to graphsync_test.go, while also being used to test git. \r\n\r\nI was looking around the structure of test files from pgraph and added something just as an experiment. \r\n\r\nThe test passed and coverage increased from 72.4% to 72.9%.  \r\n\r\nPlease let me know how the review process will work. ","created_at":"2018-07-13T01:15:31Z","updated_at":"2018-07-13T04:08:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ed78a11c78c3222b2899370794eb7c1533cc44ec","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/purpleidea/mgmt/pulls/396/commits","review_comments_url":"https://api.github.com/repos/purpleidea/mgmt/pulls/396/comments","review_comment_url":"https://api.github.com/repos/purpleidea/mgmt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/purpleidea/mgmt/issues/396/comments","statuses_url":"https://api.github.com/repos/purpleidea/mgmt/statuses/7b97ddf0c636f9372aaafd9ec71134d126a461d2","head":{"label":"ginywiny:test_beginner","ref":"test_beginner","sha":"7b97ddf0c636f9372aaafd9ec71134d126a461d2","user":{"login":"ginywiny","id":36121273,"node_id":"MDQ6VXNlcjM2MTIxMjcz","avatar_url":"https://avatars0.githubusercontent.com/u/36121273?v=4","gravatar_id":"","url":"https://api.github.com/users/ginywiny","html_url":"https://github.com/ginywiny","followers_url":"https://api.github.com/users/ginywiny/followers","following_url":"https://api.github.com/users/ginywiny/following{/other_user}","gists_url":"https://api.github.com/users/ginywiny/gists{/gist_id}","starred_url":"https://api.github.com/users/ginywiny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ginywiny/subscriptions","organizations_url":"https://api.github.com/users/ginywiny/orgs","repos_url":"https://api.github.com/users/ginywiny/repos","events_url":"https://api.github.com/users/ginywiny/events{/privacy}","received_events_url":"https://api.github.com/users/ginywiny/received_events","type":"User","site_admin":false},"repo":{"id":140355713,"node_id":"MDEwOlJlcG9zaXRvcnkxNDAzNTU3MTM=","name":"mgmt","full_name":"ginywiny/mgmt","owner":{"login":"ginywiny","id":36121273,"node_id":"MDQ6VXNlcjM2MTIxMjcz","avatar_url":"https://avatars0.githubusercontent.com/u/36121273?v=4","gravatar_id":"","url":"https://api.github.com/users/ginywiny","html_url":"https://github.com/ginywiny","followers_url":"https://api.github.com/users/ginywiny/followers","following_url":"https://api.github.com/users/ginywiny/following{/other_user}","gists_url":"https://api.github.com/users/ginywiny/gists{/gist_id}","starred_url":"https://api.github.com/users/ginywiny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ginywiny/subscriptions","organizations_url":"https://api.github.com/users/ginywiny/orgs","repos_url":"https://api.github.com/users/ginywiny/repos","events_url":"https://api.github.com/users/ginywiny/events{/privacy}","received_events_url":"https://api.github.com/users/ginywiny/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ginywiny/mgmt","description":"Next generation distributed, event-driven, parallel config management!","fork":true,"url":"https://api.github.com/repos/ginywiny/mgmt","forks_url":"https://api.github.com/repos/ginywiny/mgmt/forks","keys_url":"https://api.github.com/repos/ginywiny/mgmt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ginywiny/mgmt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ginywiny/mgmt/teams","hooks_url":"https://api.github.com/repos/ginywiny/mgmt/hooks","issue_events_url":"https://api.github.com/repos/ginywiny/mgmt/issues/events{/number}","events_url":"https://api.github.com/repos/ginywiny/mgmt/events","assignees_url":"https://api.github.com/repos/ginywiny/mgmt/assignees{/user}","branches_url":"https://api.github.com/repos/ginywiny/mgmt/branches{/branch}","tags_url":"https://api.github.com/repos/ginywiny/mgmt/tags","blobs_url":"https://api.github.com/repos/ginywiny/mgmt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ginywiny/mgmt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ginywiny/mgmt/git/refs{/sha}","trees_url":"https://api.github.com/repos/ginywiny/mgmt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ginywiny/mgmt/statuses/{sha}","languages_url":"https://api.github.com/repos/ginywiny/mgmt/languages","stargazers_url":"https://api.github.com/repos/ginywiny/mgmt/stargazers","contributors_url":"https://api.github.com/repos/ginywiny/mgmt/contributors","subscribers_url":"https://api.github.com/repos/ginywiny/mgmt/subscribers","subscription_url":"https://api.github.com/repos/ginywiny/mgmt/subscription","commits_url":"https://api.github.com/repos/ginywiny/mgmt/commits{/sha}","git_commits_url":"https://api.github.com/repos/ginywiny/mgmt/git/commits{/sha}","comments_url":"https://api.github.com/repos/ginywiny/mgmt/comments{/number}","issue_comment_url":"https://api.github.com/repos/ginywiny/mgmt/issues/comments{/number}","contents_url":"https://api.github.com/repos/ginywiny/mgmt/contents/{+path}","compare_url":"https://api.github.com/repos/ginywiny/mgmt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ginywiny/mgmt/merges","archive_url":"https://api.github.com/repos/ginywiny/mgmt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ginywiny/mgmt/downloads","issues_url":"https://api.github.com/repos/ginywiny/mgmt/issues{/number}","pulls_url":"https://api.github.com/repos/ginywiny/mgmt/pulls{/number}","milestones_url":"https://api.github.com/repos/ginywiny/mgmt/milestones{/number}","notifications_url":"https://api.github.com/repos/ginywiny/mgmt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ginywiny/mgmt/labels{/name}","releases_url":"https://api.github.com/repos/ginywiny/mgmt/releases{/id}","deployments_url":"https://api.github.com/repos/ginywiny/mgmt/deployments","created_at":"2018-07-10T00:18:33Z","updated_at":"2018-07-10T00:18:35Z","pushed_at":"2018-07-13T01:03:55Z","git_url":"git://github.com/ginywiny/mgmt.git","ssh_url":"git@github.com:ginywiny/mgmt.git","clone_url":"https://github.com/ginywiny/mgmt.git","svn_url":"https://github.com/ginywiny/mgmt","homepage":"https://purpleidea.com/tags/mgmtconfig/","size":2758,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"purpleidea:master","ref":"master","sha":"f342e06ef0d0fc173dcb5320e9a376f14d561868","user":{"login":"purpleidea","id":135091,"node_id":"MDQ6VXNlcjEzNTA5MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/135091?v=4","gravatar_id":"","url":"https://api.github.com/users/purpleidea","html_url":"https://github.com/purpleidea","followers_url":"https://api.github.com/users/purpleidea/followers","following_url":"https://api.github.com/users/purpleidea/following{/other_user}","gists_url":"https://api.github.com/users/purpleidea/gists{/gist_id}","starred_url":"https://api.github.com/users/purpleidea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/purpleidea/subscriptions","organizations_url":"https://api.github.com/users/purpleidea/orgs","repos_url":"https://api.github.com/users/purpleidea/repos","events_url":"https://api.github.com/users/purpleidea/events{/privacy}","received_events_url":"https://api.github.com/users/purpleidea/received_events","type":"User","site_admin":false},"repo":{"id":43111018,"node_id":"MDEwOlJlcG9zaXRvcnk0MzExMTAxOA==","name":"mgmt","full_name":"purpleidea/mgmt","owner":{"login":"purpleidea","id":135091,"node_id":"MDQ6VXNlcjEzNTA5MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/135091?v=4","gravatar_id":"","url":"https://api.github.com/users/purpleidea","html_url":"https://github.com/purpleidea","followers_url":"https://api.github.com/users/purpleidea/followers","following_url":"https://api.github.com/users/purpleidea/following{/other_user}","gists_url":"https://api.github.com/users/purpleidea/gists{/gist_id}","starred_url":"https://api.github.com/users/purpleidea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/purpleidea/subscriptions","organizations_url":"https://api.github.com/users/purpleidea/orgs","repos_url":"https://api.github.com/users/purpleidea/repos","events_url":"https://api.github.com/users/purpleidea/events{/privacy}","received_events_url":"https://api.github.com/users/purpleidea/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/purpleidea/mgmt","description":"Next generation distributed, event-driven, parallel config management!","fork":false,"url":"https://api.github.com/repos/purpleidea/mgmt","forks_url":"https://api.github.com/repos/purpleidea/mgmt/forks","keys_url":"https://api.github.com/repos/purpleidea/mgmt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/purpleidea/mgmt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/purpleidea/mgmt/teams","hooks_url":"https://api.github.com/repos/purpleidea/mgmt/hooks","issue_events_url":"https://api.github.com/repos/purpleidea/mgmt/issues/events{/number}","events_url":"https://api.github.com/repos/purpleidea/mgmt/events","assignees_url":"https://api.github.com/repos/purpleidea/mgmt/assignees{/user}","branches_url":"https://api.github.com/repos/purpleidea/mgmt/branches{/branch}","tags_url":"https://api.github.com/repos/purpleidea/mgmt/tags","blobs_url":"https://api.github.com/repos/purpleidea/mgmt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/purpleidea/mgmt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/purpleidea/mgmt/git/refs{/sha}","trees_url":"https://api.github.com/repos/purpleidea/mgmt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/purpleidea/mgmt/statuses/{sha}","languages_url":"https://api.github.com/repos/purpleidea/mgmt/languages","stargazers_url":"https://api.github.com/repos/purpleidea/mgmt/stargazers","contributors_url":"https://api.github.com/repos/purpleidea/mgmt/contributors","subscribers_url":"https://api.github.com/repos/purpleidea/mgmt/subscribers","subscription_url":"https://api.github.com/repos/purpleidea/mgmt/subscription","commits_url":"https://api.github.com/repos/purpleidea/mgmt/commits{/sha}","git_commits_url":"https://api.github.com/repos/purpleidea/mgmt/git/commits{/sha}","comments_url":"https://api.github.com/repos/purpleidea/mgmt/comments{/number}","issue_comment_url":"https://api.github.com/repos/purpleidea/mgmt/issues/comments{/number}","contents_url":"https://api.github.com/repos/purpleidea/mgmt/contents/{+path}","compare_url":"https://api.github.com/repos/purpleidea/mgmt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/purpleidea/mgmt/merges","archive_url":"https://api.github.com/repos/purpleidea/mgmt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/purpleidea/mgmt/downloads","issues_url":"https://api.github.com/repos/purpleidea/mgmt/issues{/number}","pulls_url":"https://api.github.com/repos/purpleidea/mgmt/pulls{/number}","milestones_url":"https://api.github.com/repos/purpleidea/mgmt/milestones{/number}","notifications_url":"https://api.github.com/repos/purpleidea/mgmt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/purpleidea/mgmt/labels{/name}","releases_url":"https://api.github.com/repos/purpleidea/mgmt/releases{/id}","deployments_url":"https://api.github.com/repos/purpleidea/mgmt/deployments","created_at":"2015-09-25T05:15:41Z","updated_at":"2018-07-13T00:02:07Z","pushed_at":"2018-07-13T01:15:32Z","git_url":"git://github.com/purpleidea/mgmt.git","ssh_url":"git@github.com:purpleidea/mgmt.git","clone_url":"https://github.com/purpleidea/mgmt.git","svn_url":"https://github.com/purpleidea/mgmt","homepage":"https://purpleidea.com/tags/mgmtconfig/","size":2783,"stargazers_count":1383,"watchers_count":1383,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":167,"mirror_url":null,"archived":false,"open_issues_count":68,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":167,"open_issues":68,"watchers":1383,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/purpleidea/mgmt/pulls/396"},"html":{"href":"https://github.com/purpleidea/mgmt/pull/396"},"issue":{"href":"https://api.github.com/repos/purpleidea/mgmt/issues/396"},"comments":{"href":"https://api.github.com/repos/purpleidea/mgmt/issues/396/comments"},"review_comments":{"href":"https://api.github.com/repos/purpleidea/mgmt/pulls/396/comments"},"review_comment":{"href":"https://api.github.com/repos/purpleidea/mgmt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/purpleidea/mgmt/pulls/396/commits"},"statuses":{"href":"https://api.github.com/repos/purpleidea/mgmt/statuses/7b97ddf0c636f9372aaafd9ec71134d126a461d2"}},"author_association":"NONE"}}
{"actor":{"display_login":"purpleidea"}}