{"action":"created","issue":{"url":"https://api.github.com/repos/prettier/prettier-atom/issues/454","repository_url":"https://api.github.com/repos/prettier/prettier-atom","labels_url":"https://api.github.com/repos/prettier/prettier-atom/issues/454/labels{/name}","comments_url":"https://api.github.com/repos/prettier/prettier-atom/issues/454/comments","events_url":"https://api.github.com/repos/prettier/prettier-atom/issues/454/events","html_url":"https://github.com/prettier/prettier-atom/pull/454","id":360581925,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1NzkyODAx","number":454,"title":"feat(Add tslint to settings and execution): Add support for prettier-tslint","user":{"login":"jeffrafter","id":4064,"node_id":"MDQ6VXNlcjQwNjQ=","avatar_url":"https://avatars2.githubusercontent.com/u/4064?v=4","gravatar_id":"","url":"https://api.github.com/users/jeffrafter","html_url":"https://github.com/jeffrafter","followers_url":"https://api.github.com/users/jeffrafter/followers","following_url":"https://api.github.com/users/jeffrafter/following{/other_user}","gists_url":"https://api.github.com/users/jeffrafter/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffrafter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffrafter/subscriptions","organizations_url":"https://api.github.com/users/jeffrafter/orgs","repos_url":"https://api.github.com/users/jeffrafter/repos","events_url":"https://api.github.com/users/jeffrafter/events{/privacy}","received_events_url":"https://api.github.com/users/jeffrafter/received_events","type":"User","site_admin":true},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-09-15T22:37:23Z","updated_at":"2018-09-21T17:40:46Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/prettier/prettier-atom/pulls/454","html_url":"https://github.com/prettier/prettier-atom/pull/454","diff_url":"https://github.com/prettier/prettier-atom/pull/454.diff","patch_url":"https://github.com/prettier/prettier-atom/pull/454.patch"},"body":"Currently, tslint support cannot be mixed with prettier directly. This adds support using `prettier-tslint` by following the patterns of the embedded prettier-eslint support.\r\n\r\nFixes #302"},"comment":{"url":"https://api.github.com/repos/prettier/prettier-atom/issues/comments/423617190","html_url":"https://github.com/prettier/prettier-atom/pull/454#issuecomment-423617190","issue_url":"https://api.github.com/repos/prettier/prettier-atom/issues/454","id":423617190,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMzYxNzE5MA==","user":{"login":"robwise","id":6173488,"node_id":"MDQ6VXNlcjYxNzM0ODg=","avatar_url":"https://avatars3.githubusercontent.com/u/6173488?v=4","gravatar_id":"","url":"https://api.github.com/users/robwise","html_url":"https://github.com/robwise","followers_url":"https://api.github.com/users/robwise/followers","following_url":"https://api.github.com/users/robwise/following{/other_user}","gists_url":"https://api.github.com/users/robwise/gists{/gist_id}","starred_url":"https://api.github.com/users/robwise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robwise/subscriptions","organizations_url":"https://api.github.com/users/robwise/orgs","repos_url":"https://api.github.com/users/robwise/repos","events_url":"https://api.github.com/users/robwise/events{/privacy}","received_events_url":"https://api.github.com/users/robwise/received_events","type":"User","site_admin":false},"created_at":"2018-09-21T17:40:46Z","updated_at":"2018-09-21T17:40:46Z","author_association":"COLLABORATOR","body":"Sorry for the slow reply, have been traveling.\r\n\r\n> Thanks @robwise I think you are right... I'm open to making it more either-or and then documenting that. Really whatever you recommend 💃\r\n\r\nI've been trying to think of a good solution, I came up with two alternatives:\r\n\r\n- a dropdown Atom option that lets you select `Prettier, prettier-eslint, prettier-tslint`\r\n- treat it like we do `prettier-stylelint` where we just hardcode certain scopes to automatically use `prettier-tslint` if we detect we're in a TS lint file and the user has enabled it.\r\n\r\nDo you think the second one would work? That would be more consistent because we already do it like that for prettier-stylelint.\r\n\r\n> I also wanted to note that since I have started using my fork I've noticed the TypeScript server crashing occasionally. I don't know that it is related, but I want to be cautious about it.\r\n\r\nHmm, I wonder if it's making calls too frequently to the TS server or something? Do you have it set to constantly lint, or wait until you try and save the file?"}}
{"actor":{"display_login":"robwise"}}