{"action":"created","issue":{"url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/4600","repository_url":"https://api.github.com/repos/FreeRDP/FreeRDP","labels_url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/4600/labels{/name}","comments_url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/4600/comments","events_url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/4600/events","html_url":"https://github.com/FreeRDP/FreeRDP/pull/4600","id":318676279,"number":4600,"title":"X11: Fix fullscreen toggle","user":{"login":"andreesteve","id":942449,"avatar_url":"https://avatars0.githubusercontent.com/u/942449?v=4","gravatar_id":"","url":"https://api.github.com/users/andreesteve","html_url":"https://github.com/andreesteve","followers_url":"https://api.github.com/users/andreesteve/followers","following_url":"https://api.github.com/users/andreesteve/following{/other_user}","gists_url":"https://api.github.com/users/andreesteve/gists{/gist_id}","starred_url":"https://api.github.com/users/andreesteve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreesteve/subscriptions","organizations_url":"https://api.github.com/users/andreesteve/orgs","repos_url":"https://api.github.com/users/andreesteve/repos","events_url":"https://api.github.com/users/andreesteve/events{/privacy}","received_events_url":"https://api.github.com/users/andreesteve/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-04-28T23:28:43Z","updated_at":"2018-05-13T18:15:23Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/4600","html_url":"https://github.com/FreeRDP/FreeRDP/pull/4600","diff_url":"https://github.com/FreeRDP/FreeRDP/pull/4600.diff","patch_url":"https://github.com/FreeRDP/FreeRDP/pull/4600.patch"},"body":"### Issue:\r\n#4579  X11 Client Ctrl+Alt+Enter does not toggle full screen\r\n\r\n### Fixes\r\n\r\n1. Fix fullscreen toggle for window managers that do not have multimonitor fullscreen extension support\r\n2. Fix current monitor detection\r\n3. Fix calculation of vscreen boundaries when single monitor is being used\r\n4. Fix start up position of window when starting (used to always go to the top left corner, now centered)\r\n\r\n### Still a problem:\r\n\r\n1. Window decorations do not show when going windowed (i3 only, gnome works fine)\r\n2. Smart resizing makes i3 really sad :(\r\n3. Moving window across monitors and going fullscreen always maximizes on startup screen (when not using /multimon)\r\n\r\n### Comments\r\n\r\nI did some refactoring on xf_monitor.c, but it should be revisit in the future.\r\nWe currently \"fake\" a single monitor when /multimon is not provided. We should not do that and keep track of all monitors and whether /multimon is enabled or not. This would allow us in the future to support moving the window between monitors and going fullscreen on any monitor.\r\n\r\n### Tested\r\n\r\nOn both i3 and Gnome, fullscreen toggle works.\r\nMultimon works fine on gnome, i3 doesn't support it.\r\n\r\nIdeally we should have other folks testing their WMs to be safe."},"comment":{"url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/comments/388645597","html_url":"https://github.com/FreeRDP/FreeRDP/pull/4600#issuecomment-388645597","issue_url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/4600","id":388645597,"user":{"login":"andreesteve","id":942449,"avatar_url":"https://avatars0.githubusercontent.com/u/942449?v=4","gravatar_id":"","url":"https://api.github.com/users/andreesteve","html_url":"https://github.com/andreesteve","followers_url":"https://api.github.com/users/andreesteve/followers","following_url":"https://api.github.com/users/andreesteve/following{/other_user}","gists_url":"https://api.github.com/users/andreesteve/gists{/gist_id}","starred_url":"https://api.github.com/users/andreesteve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreesteve/subscriptions","organizations_url":"https://api.github.com/users/andreesteve/orgs","repos_url":"https://api.github.com/users/andreesteve/repos","events_url":"https://api.github.com/users/andreesteve/events{/privacy}","received_events_url":"https://api.github.com/users/andreesteve/received_events","type":"User","site_admin":false},"created_at":"2018-05-13T18:15:23Z","updated_at":"2018-05-13T18:15:23Z","author_association":"CONTRIBUTOR","body":"@akallabeth let me know if there are other changes you'd like me to make"}}
{"actor":{"display_login":"andreesteve"}}