{"action":"created","comment":{"url":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/pulls/comments/176937423","pull_request_review_id":106726827,"id":176937423,"diff_hunk":"@@ -0,0 +1,54 @@\n+package com.virtuslab.auctionHouse.perfTests","path":"codebase/gatling-tests/src/main/scala/com/virtuslab/auctionHouse/perfTests/AuctionHouseSimulation.scala","position":1,"original_position":1,"commit_id":"ce397cbe67a0b3410228d3bb6f30541ca1e4bb65","original_commit_id":"ce397cbe67a0b3410228d3bb6f30541ca1e4bb65","user":{"login":"zagorski","id":5765278,"avatar_url":"https://avatars2.githubusercontent.com/u/5765278?v=4","gravatar_id":"","url":"https://api.github.com/users/zagorski","html_url":"https://github.com/zagorski","followers_url":"https://api.github.com/users/zagorski/followers","following_url":"https://api.github.com/users/zagorski/following{/other_user}","gists_url":"https://api.github.com/users/zagorski/gists{/gist_id}","starred_url":"https://api.github.com/users/zagorski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zagorski/subscriptions","organizations_url":"https://api.github.com/users/zagorski/orgs","repos_url":"https://api.github.com/users/zagorski/repos","events_url":"https://api.github.com/users/zagorski/events{/privacy}","received_events_url":"https://api.github.com/users/zagorski/received_events","type":"User","site_admin":false},"body":"Can't we just leave 1 empty class extending AuctionHouseSimulation in test and remove duplicated classes?","created_at":"2018-03-25T11:36:55Z","updated_at":"2018-03-25T11:37:09Z","html_url":"https://github.com/VirtusLab/ReactSphere-reactive-beyond-hype/pull/11#discussion_r176937423","pull_request_url":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/pulls/11","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/pulls/comments/176937423"},"html":{"href":"https://github.com/VirtusLab/ReactSphere-reactive-beyond-hype/pull/11#discussion_r176937423"},"pull_request":{"href":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/pulls/11"}}},"pull_request":{"url":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/pulls/11","id":177263157,"html_url":"https://github.com/VirtusLab/ReactSphere-reactive-beyond-hype/pull/11","diff_url":"https://github.com/VirtusLab/ReactSphere-reactive-beyond-hype/pull/11.diff","patch_url":"https://github.com/VirtusLab/ReactSphere-reactive-beyond-hype/pull/11.patch","issue_url":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/issues/11","number":11,"state":"open","locked":false,"title":"Deploy scripts and gatling as k8s job","user":{"login":"lbialy","id":8607442,"avatar_url":"https://avatars1.githubusercontent.com/u/8607442?v=4","gravatar_id":"","url":"https://api.github.com/users/lbialy","html_url":"https://github.com/lbialy","followers_url":"https://api.github.com/users/lbialy/followers","following_url":"https://api.github.com/users/lbialy/following{/other_user}","gists_url":"https://api.github.com/users/lbialy/gists{/gist_id}","starred_url":"https://api.github.com/users/lbialy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lbialy/subscriptions","organizations_url":"https://api.github.com/users/lbialy/orgs","repos_url":"https://api.github.com/users/lbialy/repos","events_url":"https://api.github.com/users/lbialy/events{/privacy}","received_events_url":"https://api.github.com/users/lbialy/received_events","type":"User","site_admin":false},"body":"Haven't yet decided what to do with Gatling tests having code in both main and test directories. I prefer having runnable docker container though.","created_at":"2018-03-24T22:59:01Z","updated_at":"2018-03-25T11:37:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"37b47821196ea7d83af4ff4b9d9630b9ea06d23f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"pdolega","id":1287963,"avatar_url":"https://avatars1.githubusercontent.com/u/1287963?v=4","gravatar_id":"","url":"https://api.github.com/users/pdolega","html_url":"https://github.com/pdolega","followers_url":"https://api.github.com/users/pdolega/followers","following_url":"https://api.github.com/users/pdolega/following{/other_user}","gists_url":"https://api.github.com/users/pdolega/gists{/gist_id}","starred_url":"https://api.github.com/users/pdolega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdolega/subscriptions","organizations_url":"https://api.github.com/users/pdolega/orgs","repos_url":"https://api.github.com/users/pdolega/repos","events_url":"https://api.github.com/users/pdolega/events{/privacy}","received_events_url":"https://api.github.com/users/pdolega/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/pulls/11/commits","review_comments_url":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/pulls/11/comments","review_comment_url":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/pulls/comments{/number}","comments_url":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/issues/11/comments","statuses_url":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/statuses/ce397cbe67a0b3410228d3bb6f30541ca1e4bb65","head":{"label":"VirtusLab:deploy-scripts-and-gatling-as-k8s-job","ref":"deploy-scripts-and-gatling-as-k8s-job","sha":"ce397cbe67a0b3410228d3bb6f30541ca1e4bb65","user":{"login":"VirtusLab","id":5324131,"avatar_url":"https://avatars0.githubusercontent.com/u/5324131?v=4","gravatar_id":"","url":"https://api.github.com/users/VirtusLab","html_url":"https://github.com/VirtusLab","followers_url":"https://api.github.com/users/VirtusLab/followers","following_url":"https://api.github.com/users/VirtusLab/following{/other_user}","gists_url":"https://api.github.com/users/VirtusLab/gists{/gist_id}","starred_url":"https://api.github.com/users/VirtusLab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VirtusLab/subscriptions","organizations_url":"https://api.github.com/users/VirtusLab/orgs","repos_url":"https://api.github.com/users/VirtusLab/repos","events_url":"https://api.github.com/users/VirtusLab/events{/privacy}","received_events_url":"https://api.github.com/users/VirtusLab/received_events","type":"Organization","site_admin":false},"repo":{"id":120292936,"name":"ReactSphere-reactive-beyond-hype","full_name":"VirtusLab/ReactSphere-reactive-beyond-hype","owner":{"login":"VirtusLab","id":5324131,"avatar_url":"https://avatars0.githubusercontent.com/u/5324131?v=4","gravatar_id":"","url":"https://api.github.com/users/VirtusLab","html_url":"https://github.com/VirtusLab","followers_url":"https://api.github.com/users/VirtusLab/followers","following_url":"https://api.github.com/users/VirtusLab/following{/other_user}","gists_url":"https://api.github.com/users/VirtusLab/gists{/gist_id}","starred_url":"https://api.github.com/users/VirtusLab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VirtusLab/subscriptions","organizations_url":"https://api.github.com/users/VirtusLab/orgs","repos_url":"https://api.github.com/users/VirtusLab/repos","events_url":"https://api.github.com/users/VirtusLab/events{/privacy}","received_events_url":"https://api.github.com/users/VirtusLab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/VirtusLab/ReactSphere-reactive-beyond-hype","description":"Repo for presentation on ReactSphere: Reactive beyond hype","fork":false,"url":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype","forks_url":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/forks","keys_url":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/teams","hooks_url":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/hooks","issue_events_url":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/issues/events{/number}","events_url":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/events","assignees_url":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/assignees{/user}","branches_url":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/branches{/branch}","tags_url":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/tags","blobs_url":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/git/refs{/sha}","trees_url":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/statuses/{sha}","languages_url":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/languages","stargazers_url":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/stargazers","contributors_url":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/contributors","subscribers_url":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/subscribers","subscription_url":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/subscription","commits_url":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/commits{/sha}","git_commits_url":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/git/commits{/sha}","comments_url":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/comments{/number}","issue_comment_url":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/issues/comments{/number}","contents_url":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/contents/{+path}","compare_url":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/merges","archive_url":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/downloads","issues_url":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/issues{/number}","pulls_url":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/pulls{/number}","milestones_url":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/milestones{/number}","notifications_url":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/labels{/name}","releases_url":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/releases{/id}","deployments_url":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/deployments","created_at":"2018-02-05T10:58:55Z","updated_at":"2018-03-24T19:50:41Z","pushed_at":"2018-03-24T22:59:02Z","git_url":"git://github.com/VirtusLab/ReactSphere-reactive-beyond-hype.git","ssh_url":"git@github.com:VirtusLab/ReactSphere-reactive-beyond-hype.git","clone_url":"https://github.com/VirtusLab/ReactSphere-reactive-beyond-hype.git","svn_url":"https://github.com/VirtusLab/ReactSphere-reactive-beyond-hype","homepage":null,"size":196,"stargazers_count":3,"watchers_count":3,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":1,"watchers":3,"default_branch":"master"}},"base":{"label":"VirtusLab:master","ref":"master","sha":"72f6780b79fc3282700c92f7910fbe47e7c8cae5","user":{"login":"VirtusLab","id":5324131,"avatar_url":"https://avatars0.githubusercontent.com/u/5324131?v=4","gravatar_id":"","url":"https://api.github.com/users/VirtusLab","html_url":"https://github.com/VirtusLab","followers_url":"https://api.github.com/users/VirtusLab/followers","following_url":"https://api.github.com/users/VirtusLab/following{/other_user}","gists_url":"https://api.github.com/users/VirtusLab/gists{/gist_id}","starred_url":"https://api.github.com/users/VirtusLab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VirtusLab/subscriptions","organizations_url":"https://api.github.com/users/VirtusLab/orgs","repos_url":"https://api.github.com/users/VirtusLab/repos","events_url":"https://api.github.com/users/VirtusLab/events{/privacy}","received_events_url":"https://api.github.com/users/VirtusLab/received_events","type":"Organization","site_admin":false},"repo":{"id":120292936,"name":"ReactSphere-reactive-beyond-hype","full_name":"VirtusLab/ReactSphere-reactive-beyond-hype","owner":{"login":"VirtusLab","id":5324131,"avatar_url":"https://avatars0.githubusercontent.com/u/5324131?v=4","gravatar_id":"","url":"https://api.github.com/users/VirtusLab","html_url":"https://github.com/VirtusLab","followers_url":"https://api.github.com/users/VirtusLab/followers","following_url":"https://api.github.com/users/VirtusLab/following{/other_user}","gists_url":"https://api.github.com/users/VirtusLab/gists{/gist_id}","starred_url":"https://api.github.com/users/VirtusLab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VirtusLab/subscriptions","organizations_url":"https://api.github.com/users/VirtusLab/orgs","repos_url":"https://api.github.com/users/VirtusLab/repos","events_url":"https://api.github.com/users/VirtusLab/events{/privacy}","received_events_url":"https://api.github.com/users/VirtusLab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/VirtusLab/ReactSphere-reactive-beyond-hype","description":"Repo for presentation on ReactSphere: Reactive beyond hype","fork":false,"url":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype","forks_url":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/forks","keys_url":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/teams","hooks_url":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/hooks","issue_events_url":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/issues/events{/number}","events_url":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/events","assignees_url":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/assignees{/user}","branches_url":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/branches{/branch}","tags_url":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/tags","blobs_url":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/git/refs{/sha}","trees_url":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/statuses/{sha}","languages_url":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/languages","stargazers_url":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/stargazers","contributors_url":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/contributors","subscribers_url":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/subscribers","subscription_url":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/subscription","commits_url":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/commits{/sha}","git_commits_url":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/git/commits{/sha}","comments_url":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/comments{/number}","issue_comment_url":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/issues/comments{/number}","contents_url":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/contents/{+path}","compare_url":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/merges","archive_url":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/downloads","issues_url":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/issues{/number}","pulls_url":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/pulls{/number}","milestones_url":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/milestones{/number}","notifications_url":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/labels{/name}","releases_url":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/releases{/id}","deployments_url":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/deployments","created_at":"2018-02-05T10:58:55Z","updated_at":"2018-03-24T19:50:41Z","pushed_at":"2018-03-24T22:59:02Z","git_url":"git://github.com/VirtusLab/ReactSphere-reactive-beyond-hype.git","ssh_url":"git@github.com:VirtusLab/ReactSphere-reactive-beyond-hype.git","clone_url":"https://github.com/VirtusLab/ReactSphere-reactive-beyond-hype.git","svn_url":"https://github.com/VirtusLab/ReactSphere-reactive-beyond-hype","homepage":null,"size":196,"stargazers_count":3,"watchers_count":3,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":1,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/pulls/11"},"html":{"href":"https://github.com/VirtusLab/ReactSphere-reactive-beyond-hype/pull/11"},"issue":{"href":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/issues/11"},"comments":{"href":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/VirtusLab/ReactSphere-reactive-beyond-hype/statuses/ce397cbe67a0b3410228d3bb6f30541ca1e4bb65"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"zagorski"}}