{"action":"created","issue":{"url":"https://api.github.com/repos/USGS-CIDA/MLR-Legacy-Transformer/issues/18","repository_url":"https://api.github.com/repos/USGS-CIDA/MLR-Legacy-Transformer","labels_url":"https://api.github.com/repos/USGS-CIDA/MLR-Legacy-Transformer/issues/18/labels{/name}","comments_url":"https://api.github.com/repos/USGS-CIDA/MLR-Legacy-Transformer/issues/18/comments","events_url":"https://api.github.com/repos/USGS-CIDA/MLR-Legacy-Transformer/issues/18/events","html_url":"https://github.com/USGS-CIDA/MLR-Legacy-Transformer/pull/18","id":380353351,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwNTcyMzY2","number":18,"title":"MLR-323","user":{"login":"cschroed-usgs","id":3419837,"node_id":"MDQ6VXNlcjM0MTk4Mzc=","avatar_url":"https://avatars1.githubusercontent.com/u/3419837?v=4","gravatar_id":"","url":"https://api.github.com/users/cschroed-usgs","html_url":"https://github.com/cschroed-usgs","followers_url":"https://api.github.com/users/cschroed-usgs/followers","following_url":"https://api.github.com/users/cschroed-usgs/following{/other_user}","gists_url":"https://api.github.com/users/cschroed-usgs/gists{/gist_id}","starred_url":"https://api.github.com/users/cschroed-usgs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cschroed-usgs/subscriptions","organizations_url":"https://api.github.com/users/cschroed-usgs/orgs","repos_url":"https://api.github.com/users/cschroed-usgs/repos","events_url":"https://api.github.com/users/cschroed-usgs/events{/privacy}","received_events_url":"https://api.github.com/users/cschroed-usgs/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-11-13T18:01:24Z","updated_at":"2018-11-14T14:47:07Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/USGS-CIDA/MLR-Legacy-Transformer/pulls/18","html_url":"https://github.com/USGS-CIDA/MLR-Legacy-Transformer/pull/18","diff_url":"https://github.com/USGS-CIDA/MLR-Legacy-Transformer/pull/18.diff","patch_url":"https://github.com/USGS-CIDA/MLR-Legacy-Transformer/pull/18.patch"},"body":"Context:\r\nThe Gateway's unit tests and implementations have different expectations than what the Transformer services actually return. Whereas the gateway's implementation and [unit test mocks](https://github.com/USGS-CIDA/MLR-Gateway/blob/master/src/test/java/gov/usgs/wma/mlrgateway/service/LegacyTransformerServiceTest.java#L48) suggest that the transformer services will return all passed-in attributes, the transformer services actual only return a handful of attributes. To make them consistent with each other, we could either: 1) update the Gateway's implementation and unit test mocks, or 2) adjust the transformer services' behavior. \r\n\r\nI can see compelling advantages and disadvantages for both approaches. The slightly more expedient option is to change the transformer services, so that's what I propose here. The transformer services' new contract is that they return all passed-in attributes instead of swallowing them. If it's better to close this PR and pursue option 1), please let me know."},"comment":{"url":"https://api.github.com/repos/USGS-CIDA/MLR-Legacy-Transformer/issues/comments/438686694","html_url":"https://github.com/USGS-CIDA/MLR-Legacy-Transformer/pull/18#issuecomment-438686694","issue_url":"https://api.github.com/repos/USGS-CIDA/MLR-Legacy-Transformer/issues/18","id":438686694,"node_id":"MDEyOklzc3VlQ29tbWVudDQzODY4NjY5NA==","user":{"login":"mbucknell","id":8104736,"node_id":"MDQ6VXNlcjgxMDQ3MzY=","avatar_url":"https://avatars2.githubusercontent.com/u/8104736?v=4","gravatar_id":"","url":"https://api.github.com/users/mbucknell","html_url":"https://github.com/mbucknell","followers_url":"https://api.github.com/users/mbucknell/followers","following_url":"https://api.github.com/users/mbucknell/following{/other_user}","gists_url":"https://api.github.com/users/mbucknell/gists{/gist_id}","starred_url":"https://api.github.com/users/mbucknell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbucknell/subscriptions","organizations_url":"https://api.github.com/users/mbucknell/orgs","repos_url":"https://api.github.com/users/mbucknell/repos","events_url":"https://api.github.com/users/mbucknell/events{/privacy}","received_events_url":"https://api.github.com/users/mbucknell/received_events","type":"User","site_admin":false},"created_at":"2018-11-14T14:47:07Z","updated_at":"2018-11-14T14:47:07Z","author_association":"MEMBER","body":"The service contract is now different in that you are transforming data and merging the results into an existing object. But this more tightly couples the transformer microservice to the monitoring location schema. I believe this unnecessarily limits the use of this service. I also see no good way to represent what is being done in the swagger documentation. \r\n\r\nMy recommendation would be to not change this microservice."}}
{"actor":{"display_login":"mbucknell"}}