{"action":"created","issue":{"url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-alb/issues/81","repository_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-alb","labels_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-alb/issues/81/labels{/name}","comments_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-alb/issues/81/comments","events_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-alb/issues/81/events","html_url":"https://github.com/terraform-aws-modules/terraform-aws-alb/pull/81","id":360086947,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1NDMxODM2","number":81,"title":"Merge target_groups_defaults","user":{"login":"alkalinecoffee","id":1434559,"node_id":"MDQ6VXNlcjE0MzQ1NTk=","avatar_url":"https://avatars3.githubusercontent.com/u/1434559?v=4","gravatar_id":"","url":"https://api.github.com/users/alkalinecoffee","html_url":"https://github.com/alkalinecoffee","followers_url":"https://api.github.com/users/alkalinecoffee/followers","following_url":"https://api.github.com/users/alkalinecoffee/following{/other_user}","gists_url":"https://api.github.com/users/alkalinecoffee/gists{/gist_id}","starred_url":"https://api.github.com/users/alkalinecoffee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alkalinecoffee/subscriptions","organizations_url":"https://api.github.com/users/alkalinecoffee/orgs","repos_url":"https://api.github.com/users/alkalinecoffee/repos","events_url":"https://api.github.com/users/alkalinecoffee/events{/privacy}","received_events_url":"https://api.github.com/users/alkalinecoffee/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-09-13T22:17:52Z","updated_at":"2018-11-20T15:05:21Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-alb/pulls/81","html_url":"https://github.com/terraform-aws-modules/terraform-aws-alb/pull/81","diff_url":"https://github.com/terraform-aws-modules/terraform-aws-alb/pull/81.diff","patch_url":"https://github.com/terraform-aws-modules/terraform-aws-alb/pull/81.patch"},"body":"Resolves the issue brought up in #80.\r\n\r\nCurrently, a user must specify all `target_group_defaults` even if they wish to override just one value, ie:\r\n\r\n```\r\ntarget_groups_defaults = {\r\n  cookie_duration = 86400\r\n  deregistration_delay = 300\r\n  health_check_healthy_threshold = 3\r\n  health_check_interval = 10\r\n  health_check_matcher = \"200-299\"\r\n  health_check_path = \"/my-custom-health-check-path\"\r\n  health_check_port = \"traffic-port\"\r\n  health_check_timeout = 5\r\n  health_check_unhealthy_threshold = 3\r\n  stickiness_enabled = false\r\n  target_type = \"instance\"\r\n}\r\n```\r\n\r\nWe should merge this module's defaults with those provided by the user, letting the user simply pass in whichever values that should be overridden:\r\n\r\n```\r\ntarget_groups_defaults = {\r\n   health_check_path = \"/my-custom-health-check-path\"\r\n}\r\n```"},"comment":{"url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-alb/issues/comments/440305072","html_url":"https://github.com/terraform-aws-modules/terraform-aws-alb/pull/81#issuecomment-440305072","issue_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-alb/issues/81","id":440305072,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MDMwNTA3Mg==","user":{"login":"Genert","id":1218788,"node_id":"MDQ6VXNlcjEyMTg3ODg=","avatar_url":"https://avatars2.githubusercontent.com/u/1218788?v=4","gravatar_id":"","url":"https://api.github.com/users/Genert","html_url":"https://github.com/Genert","followers_url":"https://api.github.com/users/Genert/followers","following_url":"https://api.github.com/users/Genert/following{/other_user}","gists_url":"https://api.github.com/users/Genert/gists{/gist_id}","starred_url":"https://api.github.com/users/Genert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Genert/subscriptions","organizations_url":"https://api.github.com/users/Genert/orgs","repos_url":"https://api.github.com/users/Genert/repos","events_url":"https://api.github.com/users/Genert/events{/privacy}","received_events_url":"https://api.github.com/users/Genert/received_events","type":"User","site_admin":false},"created_at":"2018-11-20T15:05:21Z","updated_at":"2018-11-20T15:05:21Z","author_association":"NONE","body":"Ping @brandoconnor"}}
{"actor":{"display_login":"Genert"}}