{"action":"created","comment":{"url":"https://api.github.com/repos/containous/traefik/pulls/comments/204224481","pull_request_review_id":139271699,"id":204224481,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDIyNDQ4MQ==","diff_hunk":"@@ -312,6 +314,15 @@ func (p *Provider) loadIngresses(k8sClient Client) (*types.Configuration, error)\n \t\t\t\t\t\t\tprotocol = \"https\"\n \t\t\t\t\t\t}\n \n+\t\t\t\t\t\tswitch getStringValue(i.Annotations, annotationKubernetesProtocol, protocol) {\n+\t\t\t\t\t\tcase allowedProtocolHTTPS:\n+\t\t\t\t\t\t\tprotocol = allowedProtocolHTTPS\n+\t\t\t\t\t\tcase allowedProtocolH2C:\n+\t\t\t\t\t\t\tprotocol = allowedProtocolH2C\n+\t\t\t\t\t\tdefault:\n+\t\t\t\t\t\t\tprotocol = label.DefaultProtocol","path":"provider/kubernetes/kubernetes.go","position":19,"original_position":19,"commit_id":"ed373cd213585d80443030fb7a2ad0f0b541382d","original_commit_id":"ed373cd213585d80443030fb7a2ad0f0b541382d","user":{"login":"timoreimann","id":694826,"node_id":"MDQ6VXNlcjY5NDgyNg==","avatar_url":"https://avatars1.githubusercontent.com/u/694826?v=4","gravatar_id":"","url":"https://api.github.com/users/timoreimann","html_url":"https://github.com/timoreimann","followers_url":"https://api.github.com/users/timoreimann/followers","following_url":"https://api.github.com/users/timoreimann/following{/other_user}","gists_url":"https://api.github.com/users/timoreimann/gists{/gist_id}","starred_url":"https://api.github.com/users/timoreimann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timoreimann/subscriptions","organizations_url":"https://api.github.com/users/timoreimann/orgs","repos_url":"https://api.github.com/users/timoreimann/repos","events_url":"https://api.github.com/users/timoreimann/events{/privacy}","received_events_url":"https://api.github.com/users/timoreimann/received_events","type":"User","site_admin":false},"body":"Assuming we hit line 314 and have protocol be `https`: Aren't we overwriting the value to `http` again if the annotation is missing or empty (as the default of `http` will be returned to `getStringValue`, thereby causing our _default_ switch case to apply)?","created_at":"2018-07-21T23:52:14Z","updated_at":"2018-07-21T23:55:42Z","html_url":"https://github.com/containous/traefik/pull/3648#discussion_r204224481","pull_request_url":"https://api.github.com/repos/containous/traefik/pulls/3648","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/containous/traefik/pulls/comments/204224481"},"html":{"href":"https://github.com/containous/traefik/pull/3648#discussion_r204224481"},"pull_request":{"href":"https://api.github.com/repos/containous/traefik/pulls/3648"}}},"pull_request":{"url":"https://api.github.com/repos/containous/traefik/pulls/3648","id":202677017,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyNjc3MDE3","html_url":"https://github.com/containous/traefik/pull/3648","diff_url":"https://github.com/containous/traefik/pull/3648.diff","patch_url":"https://github.com/containous/traefik/pull/3648.patch","issue_url":"https://api.github.com/repos/containous/traefik/issues/3648","number":3648,"state":"open","locked":false,"title":"add possibility to set a protocol","user":{"login":"SantoDE","id":1031255,"node_id":"MDQ6VXNlcjEwMzEyNTU=","avatar_url":"https://avatars2.githubusercontent.com/u/1031255?v=4","gravatar_id":"","url":"https://api.github.com/users/SantoDE","html_url":"https://github.com/SantoDE","followers_url":"https://api.github.com/users/SantoDE/followers","following_url":"https://api.github.com/users/SantoDE/following{/other_user}","gists_url":"https://api.github.com/users/SantoDE/gists{/gist_id}","starred_url":"https://api.github.com/users/SantoDE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SantoDE/subscriptions","organizations_url":"https://api.github.com/users/SantoDE/orgs","repos_url":"https://api.github.com/users/SantoDE/repos","events_url":"https://api.github.com/users/SantoDE/events{/privacy}","received_events_url":"https://api.github.com/users/SantoDE/received_events","type":"User","site_admin":false},"body":"### What does this PR do?\r\n\r\nAdds posibility to set a custom protocol for an ingress with the K8s provider\r\n\r\n### Motivation\r\n\r\nFixes #3641\r\n\r\n\r\n### More\r\n\r\n- [X] Added/updated tests\r\n- [X] Added/updated documentation\r\n\r\n### Additional Notes\r\n\r\nI'm official dumb and screwed the other pr :)\r\n","created_at":"2018-07-19T20:38:20Z","updated_at":"2018-07-21T23:55:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"77f3861decd5a99fa53243b062b29a416c0af816","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":410567211,"node_id":"MDU6TGFiZWw0MTA1NjcyMTE=","url":"https://api.github.com/repos/containous/traefik/labels/area/provider/k8s","name":"area/provider/k8s","color":"d4c5f9","default":false},{"id":265969105,"node_id":"MDU6TGFiZWwyNjU5NjkxMDU=","url":"https://api.github.com/repos/containous/traefik/labels/contributor/waiting-for-corrections","name":"contributor/waiting-for-corrections","color":"0052cc","default":false},{"id":259872488,"node_id":"MDU6TGFiZWwyNTk4NzI0ODg=","url":"https://api.github.com/repos/containous/traefik/labels/kind/enhancement","name":"kind/enhancement","color":"84b6eb","default":false},{"id":602267628,"node_id":"MDU6TGFiZWw2MDIyNjc2Mjg=","url":"https://api.github.com/repos/containous/traefik/labels/size/S","name":"size/S","color":"0e8a16","default":false},{"id":265100665,"node_id":"MDU6TGFiZWwyNjUxMDA2NjU=","url":"https://api.github.com/repos/containous/traefik/labels/status/2-needs-review","name":"status/2-needs-review","color":"FADECF","default":false}],"milestone":{"url":"https://api.github.com/repos/containous/traefik/milestones/9","html_url":"https://github.com/containous/traefik/milestone/9","labels_url":"https://api.github.com/repos/containous/traefik/milestones/9/labels","id":3212132,"node_id":"MDk6TWlsZXN0b25lMzIxMjEzMg==","number":9,"title":"1.7","description":"","creator":{"login":"ldez","id":5674651,"node_id":"MDQ6VXNlcjU2NzQ2NTE=","avatar_url":"https://avatars0.githubusercontent.com/u/5674651?v=4","gravatar_id":"","url":"https://api.github.com/users/ldez","html_url":"https://github.com/ldez","followers_url":"https://api.github.com/users/ldez/followers","following_url":"https://api.github.com/users/ldez/following{/other_user}","gists_url":"https://api.github.com/users/ldez/gists{/gist_id}","starred_url":"https://api.github.com/users/ldez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldez/subscriptions","organizations_url":"https://api.github.com/users/ldez/orgs","repos_url":"https://api.github.com/users/ldez/repos","events_url":"https://api.github.com/users/ldez/events{/privacy}","received_events_url":"https://api.github.com/users/ldez/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":150,"state":"open","created_at":"2018-03-23T12:54:13Z","updated_at":"2018-07-20T17:15:53Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/containous/traefik/pulls/3648/commits","review_comments_url":"https://api.github.com/repos/containous/traefik/pulls/3648/comments","review_comment_url":"https://api.github.com/repos/containous/traefik/pulls/comments{/number}","comments_url":"https://api.github.com/repos/containous/traefik/issues/3648/comments","statuses_url":"https://api.github.com/repos/containous/traefik/statuses/ed373cd213585d80443030fb7a2ad0f0b541382d","head":{"label":"SantoDE:feature/set_protocol_k8s","ref":"feature/set_protocol_k8s","sha":"ed373cd213585d80443030fb7a2ad0f0b541382d","user":{"login":"SantoDE","id":1031255,"node_id":"MDQ6VXNlcjEwMzEyNTU=","avatar_url":"https://avatars2.githubusercontent.com/u/1031255?v=4","gravatar_id":"","url":"https://api.github.com/users/SantoDE","html_url":"https://github.com/SantoDE","followers_url":"https://api.github.com/users/SantoDE/followers","following_url":"https://api.github.com/users/SantoDE/following{/other_user}","gists_url":"https://api.github.com/users/SantoDE/gists{/gist_id}","starred_url":"https://api.github.com/users/SantoDE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SantoDE/subscriptions","organizations_url":"https://api.github.com/users/SantoDE/orgs","repos_url":"https://api.github.com/users/SantoDE/repos","events_url":"https://api.github.com/users/SantoDE/events{/privacy}","received_events_url":"https://api.github.com/users/SantoDE/received_events","type":"User","site_admin":false},"repo":{"id":67614764,"node_id":"MDEwOlJlcG9zaXRvcnk2NzYxNDc2NA==","name":"traefik","full_name":"SantoDE/traefik","owner":{"login":"SantoDE","id":1031255,"node_id":"MDQ6VXNlcjEwMzEyNTU=","avatar_url":"https://avatars2.githubusercontent.com/u/1031255?v=4","gravatar_id":"","url":"https://api.github.com/users/SantoDE","html_url":"https://github.com/SantoDE","followers_url":"https://api.github.com/users/SantoDE/followers","following_url":"https://api.github.com/users/SantoDE/following{/other_user}","gists_url":"https://api.github.com/users/SantoDE/gists{/gist_id}","starred_url":"https://api.github.com/users/SantoDE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SantoDE/subscriptions","organizations_url":"https://api.github.com/users/SantoDE/orgs","repos_url":"https://api.github.com/users/SantoDE/repos","events_url":"https://api.github.com/users/SantoDE/events{/privacy}","received_events_url":"https://api.github.com/users/SantoDE/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SantoDE/traefik","description":"Træfɪk, a modern reverse proxy","fork":true,"url":"https://api.github.com/repos/SantoDE/traefik","forks_url":"https://api.github.com/repos/SantoDE/traefik/forks","keys_url":"https://api.github.com/repos/SantoDE/traefik/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SantoDE/traefik/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SantoDE/traefik/teams","hooks_url":"https://api.github.com/repos/SantoDE/traefik/hooks","issue_events_url":"https://api.github.com/repos/SantoDE/traefik/issues/events{/number}","events_url":"https://api.github.com/repos/SantoDE/traefik/events","assignees_url":"https://api.github.com/repos/SantoDE/traefik/assignees{/user}","branches_url":"https://api.github.com/repos/SantoDE/traefik/branches{/branch}","tags_url":"https://api.github.com/repos/SantoDE/traefik/tags","blobs_url":"https://api.github.com/repos/SantoDE/traefik/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SantoDE/traefik/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SantoDE/traefik/git/refs{/sha}","trees_url":"https://api.github.com/repos/SantoDE/traefik/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SantoDE/traefik/statuses/{sha}","languages_url":"https://api.github.com/repos/SantoDE/traefik/languages","stargazers_url":"https://api.github.com/repos/SantoDE/traefik/stargazers","contributors_url":"https://api.github.com/repos/SantoDE/traefik/contributors","subscribers_url":"https://api.github.com/repos/SantoDE/traefik/subscribers","subscription_url":"https://api.github.com/repos/SantoDE/traefik/subscription","commits_url":"https://api.github.com/repos/SantoDE/traefik/commits{/sha}","git_commits_url":"https://api.github.com/repos/SantoDE/traefik/git/commits{/sha}","comments_url":"https://api.github.com/repos/SantoDE/traefik/comments{/number}","issue_comment_url":"https://api.github.com/repos/SantoDE/traefik/issues/comments{/number}","contents_url":"https://api.github.com/repos/SantoDE/traefik/contents/{+path}","compare_url":"https://api.github.com/repos/SantoDE/traefik/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SantoDE/traefik/merges","archive_url":"https://api.github.com/repos/SantoDE/traefik/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SantoDE/traefik/downloads","issues_url":"https://api.github.com/repos/SantoDE/traefik/issues{/number}","pulls_url":"https://api.github.com/repos/SantoDE/traefik/pulls{/number}","milestones_url":"https://api.github.com/repos/SantoDE/traefik/milestones{/number}","notifications_url":"https://api.github.com/repos/SantoDE/traefik/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SantoDE/traefik/labels{/name}","releases_url":"https://api.github.com/repos/SantoDE/traefik/releases{/id}","deployments_url":"https://api.github.com/repos/SantoDE/traefik/deployments","created_at":"2016-09-07T14:32:19Z","updated_at":"2018-07-19T20:25:56Z","pushed_at":"2018-07-21T08:02:49Z","git_url":"git://github.com/SantoDE/traefik.git","ssh_url":"git@github.com:SantoDE/traefik.git","clone_url":"https://github.com/SantoDE/traefik.git","svn_url":"https://github.com/SantoDE/traefik","homepage":"https://traefik.io/","size":29297,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"containous:v1.7","ref":"v1.7","sha":"c8ae97fd38acdd4854522f8a069124f07c006dbb","user":{"login":"containous","id":16349663,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MzQ5NjYz","avatar_url":"https://avatars3.githubusercontent.com/u/16349663?v=4","gravatar_id":"","url":"https://api.github.com/users/containous","html_url":"https://github.com/containous","followers_url":"https://api.github.com/users/containous/followers","following_url":"https://api.github.com/users/containous/following{/other_user}","gists_url":"https://api.github.com/users/containous/gists{/gist_id}","starred_url":"https://api.github.com/users/containous/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/containous/subscriptions","organizations_url":"https://api.github.com/users/containous/orgs","repos_url":"https://api.github.com/users/containous/repos","events_url":"https://api.github.com/users/containous/events{/privacy}","received_events_url":"https://api.github.com/users/containous/received_events","type":"Organization","site_admin":false},"repo":{"id":42408804,"node_id":"MDEwOlJlcG9zaXRvcnk0MjQwODgwNA==","name":"traefik","full_name":"containous/traefik","owner":{"login":"containous","id":16349663,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MzQ5NjYz","avatar_url":"https://avatars3.githubusercontent.com/u/16349663?v=4","gravatar_id":"","url":"https://api.github.com/users/containous","html_url":"https://github.com/containous","followers_url":"https://api.github.com/users/containous/followers","following_url":"https://api.github.com/users/containous/following{/other_user}","gists_url":"https://api.github.com/users/containous/gists{/gist_id}","starred_url":"https://api.github.com/users/containous/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/containous/subscriptions","organizations_url":"https://api.github.com/users/containous/orgs","repos_url":"https://api.github.com/users/containous/repos","events_url":"https://api.github.com/users/containous/events{/privacy}","received_events_url":"https://api.github.com/users/containous/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/containous/traefik","description":"The Cloud Native Edge Router","fork":false,"url":"https://api.github.com/repos/containous/traefik","forks_url":"https://api.github.com/repos/containous/traefik/forks","keys_url":"https://api.github.com/repos/containous/traefik/keys{/key_id}","collaborators_url":"https://api.github.com/repos/containous/traefik/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/containous/traefik/teams","hooks_url":"https://api.github.com/repos/containous/traefik/hooks","issue_events_url":"https://api.github.com/repos/containous/traefik/issues/events{/number}","events_url":"https://api.github.com/repos/containous/traefik/events","assignees_url":"https://api.github.com/repos/containous/traefik/assignees{/user}","branches_url":"https://api.github.com/repos/containous/traefik/branches{/branch}","tags_url":"https://api.github.com/repos/containous/traefik/tags","blobs_url":"https://api.github.com/repos/containous/traefik/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/containous/traefik/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/containous/traefik/git/refs{/sha}","trees_url":"https://api.github.com/repos/containous/traefik/git/trees{/sha}","statuses_url":"https://api.github.com/repos/containous/traefik/statuses/{sha}","languages_url":"https://api.github.com/repos/containous/traefik/languages","stargazers_url":"https://api.github.com/repos/containous/traefik/stargazers","contributors_url":"https://api.github.com/repos/containous/traefik/contributors","subscribers_url":"https://api.github.com/repos/containous/traefik/subscribers","subscription_url":"https://api.github.com/repos/containous/traefik/subscription","commits_url":"https://api.github.com/repos/containous/traefik/commits{/sha}","git_commits_url":"https://api.github.com/repos/containous/traefik/git/commits{/sha}","comments_url":"https://api.github.com/repos/containous/traefik/comments{/number}","issue_comment_url":"https://api.github.com/repos/containous/traefik/issues/comments{/number}","contents_url":"https://api.github.com/repos/containous/traefik/contents/{+path}","compare_url":"https://api.github.com/repos/containous/traefik/compare/{base}...{head}","merges_url":"https://api.github.com/repos/containous/traefik/merges","archive_url":"https://api.github.com/repos/containous/traefik/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/containous/traefik/downloads","issues_url":"https://api.github.com/repos/containous/traefik/issues{/number}","pulls_url":"https://api.github.com/repos/containous/traefik/pulls{/number}","milestones_url":"https://api.github.com/repos/containous/traefik/milestones{/number}","notifications_url":"https://api.github.com/repos/containous/traefik/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/containous/traefik/labels{/name}","releases_url":"https://api.github.com/repos/containous/traefik/releases{/id}","deployments_url":"https://api.github.com/repos/containous/traefik/deployments","created_at":"2015-09-13T19:04:02Z","updated_at":"2018-07-21T22:39:34Z","pushed_at":"2018-07-21T08:02:50Z","git_url":"git://github.com/containous/traefik.git","ssh_url":"git@github.com:containous/traefik.git","clone_url":"https://github.com/containous/traefik.git","svn_url":"https://github.com/containous/traefik","homepage":"https://traefik.io","size":30614,"stargazers_count":16464,"watchers_count":16464,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1647,"mirror_url":null,"archived":false,"open_issues_count":268,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1647,"open_issues":268,"watchers":16464,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/containous/traefik/pulls/3648"},"html":{"href":"https://github.com/containous/traefik/pull/3648"},"issue":{"href":"https://api.github.com/repos/containous/traefik/issues/3648"},"comments":{"href":"https://api.github.com/repos/containous/traefik/issues/3648/comments"},"review_comments":{"href":"https://api.github.com/repos/containous/traefik/pulls/3648/comments"},"review_comment":{"href":"https://api.github.com/repos/containous/traefik/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/containous/traefik/pulls/3648/commits"},"statuses":{"href":"https://api.github.com/repos/containous/traefik/statuses/ed373cd213585d80443030fb7a2ad0f0b541382d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"timoreimann"}}