{"action":"created","issue":{"url":"https://api.github.com/repos/ataradov/edbg/issues/53","repository_url":"https://api.github.com/repos/ataradov/edbg","labels_url":"https://api.github.com/repos/ataradov/edbg/issues/53/labels{/name}","comments_url":"https://api.github.com/repos/ataradov/edbg/issues/53/comments","events_url":"https://api.github.com/repos/ataradov/edbg/issues/53/events","html_url":"https://github.com/ataradov/edbg/pull/53","id":300279662,"number":53,"title":"Makefile portability improvements","user":{"login":"ooxi","id":2611835,"avatar_url":"https://avatars1.githubusercontent.com/u/2611835?v=4","gravatar_id":"","url":"https://api.github.com/users/ooxi","html_url":"https://github.com/ooxi","followers_url":"https://api.github.com/users/ooxi/followers","following_url":"https://api.github.com/users/ooxi/following{/other_user}","gists_url":"https://api.github.com/users/ooxi/gists{/gist_id}","starred_url":"https://api.github.com/users/ooxi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ooxi/subscriptions","organizations_url":"https://api.github.com/users/ooxi/orgs","repos_url":"https://api.github.com/users/ooxi/repos","events_url":"https://api.github.com/users/ooxi/events{/privacy}","received_events_url":"https://api.github.com/users/ooxi/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-02-26T15:23:30Z","updated_at":"2018-02-26T17:32:03Z","closed_at":"2018-02-26T16:40:33Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ataradov/edbg/pulls/53","html_url":"https://github.com/ataradov/edbg/pull/53","diff_url":"https://github.com/ataradov/edbg/pull/53.diff","patch_url":"https://github.com/ataradov/edbg/pull/53.patch"},"body":"This set of commits increases the Makefile's portability and use for cross compilation\r\n\r\n* Recursive Makefile invocation honors the environment variables\r\n* Possibility to inject custom C compiler (now Travis CI will automatically use clang in the clang build matrix instead of the hardcoded gcc e.g. [job #7.1](https://travis-ci.org/ataradov/edbg/jobs/339563281#L507) vs [job #11.1](https://travis-ci.org/ooxi/edbg/jobs/346328437#L536))\r\n* Possibility to specify a build target different from the host\r\n"},"comment":{"url":"https://api.github.com/repos/ataradov/edbg/issues/comments/368582272","html_url":"https://github.com/ataradov/edbg/pull/53#issuecomment-368582272","issue_url":"https://api.github.com/repos/ataradov/edbg/issues/53","id":368582272,"user":{"login":"ooxi","id":2611835,"avatar_url":"https://avatars1.githubusercontent.com/u/2611835?v=4","gravatar_id":"","url":"https://api.github.com/users/ooxi","html_url":"https://github.com/ooxi","followers_url":"https://api.github.com/users/ooxi/followers","following_url":"https://api.github.com/users/ooxi/following{/other_user}","gists_url":"https://api.github.com/users/ooxi/gists{/gist_id}","starred_url":"https://api.github.com/users/ooxi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ooxi/subscriptions","organizations_url":"https://api.github.com/users/ooxi/orgs","repos_url":"https://api.github.com/users/ooxi/repos","events_url":"https://api.github.com/users/ooxi/events{/privacy}","received_events_url":"https://api.github.com/users/ooxi/received_events","type":"User","site_admin":false},"created_at":"2018-02-26T17:32:03Z","updated_at":"2018-02-26T17:32:03Z","author_association":"CONTRIBUTOR","body":"> Well, we need to figure out that optional use of plain 'gcc' by default to work, or the patch is going to be reverted. I'm not going to specify the compiler every build.\r\n\r\nOf cause and it looks like `CC` is set to `cc` inside make by default, thus `CC ?= gcc` does not have the desired effect:\r\n\r\n```\r\n$(info $$CC is [${CC}])\r\n```\r\n\r\nWill output `$CC is [cc]` on my system even though `CC` is not defined.\r\n\r\nI suggest using an other variable name like `GCC`. Should I prepare a pull request?"}}
{"actor":{"display_login":"ooxi"}}