{"action":"created","comment":{"url":"https://api.github.com/repos/corda/corda/pulls/comments/171298955","pull_request_review_id":100124561,"id":171298955,"diff_hunk":"@@ -82,6 +82,10 @@ For example running the command on a directory containing these files :\n \n Would generate directories containing three nodes: notary, partya and partyb.\n \n+This tool only bootstraps a network. It cannot dynamically update if a new node needs to join the network or if an existing","path":"docs/source/setting-up-a-corda-network.rst","position":13,"original_position":13,"commit_id":"ee3a5fa0ef8adb4a14eec8c7ab1763bd679d7783","original_commit_id":"ee3a5fa0ef8adb4a14eec8c7ab1763bd679d7783","user":{"login":"kasiastreich","id":24268146,"avatar_url":"https://avatars1.githubusercontent.com/u/24268146?v=4","gravatar_id":"","url":"https://api.github.com/users/kasiastreich","html_url":"https://github.com/kasiastreich","followers_url":"https://api.github.com/users/kasiastreich/followers","following_url":"https://api.github.com/users/kasiastreich/following{/other_user}","gists_url":"https://api.github.com/users/kasiastreich/gists{/gist_id}","starred_url":"https://api.github.com/users/kasiastreich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kasiastreich/subscriptions","organizations_url":"https://api.github.com/users/kasiastreich/orgs","repos_url":"https://api.github.com/users/kasiastreich/repos","events_url":"https://api.github.com/users/kasiastreich/events{/privacy}","received_events_url":"https://api.github.com/users/kasiastreich/received_events","type":"User","site_admin":false},"body":"It cannot dynamically change on new node joining network, but nothing stops us from pregenerating whole network beforehand (nodes don't have to be up, but information still can be copied around). Maybe it's worth mentioning?","created_at":"2018-02-28T16:16:51Z","updated_at":"2018-02-28T16:53:16Z","html_url":"https://github.com/corda/corda/pull/2672#discussion_r171298955","pull_request_url":"https://api.github.com/repos/corda/corda/pulls/2672","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/corda/corda/pulls/comments/171298955"},"html":{"href":"https://github.com/corda/corda/pull/2672#discussion_r171298955"},"pull_request":{"href":"https://api.github.com/repos/corda/corda/pulls/2672"}}},"pull_request":{"url":"https://api.github.com/repos/corda/corda/pulls/2672","id":171996668,"html_url":"https://github.com/corda/corda/pull/2672","diff_url":"https://github.com/corda/corda/pull/2672.diff","patch_url":"https://github.com/corda/corda/pull/2672.patch","issue_url":"https://api.github.com/repos/corda/corda/issues/2672","number":2672,"state":"open","locked":false,"title":"CORDA-1048: Making it simpler to move an existing local deployment of…","user":{"login":"shamsasari","id":3883563,"avatar_url":"https://avatars3.githubusercontent.com/u/3883563?v=4","gravatar_id":"","url":"https://api.github.com/users/shamsasari","html_url":"https://github.com/shamsasari","followers_url":"https://api.github.com/users/shamsasari/followers","following_url":"https://api.github.com/users/shamsasari/following{/other_user}","gists_url":"https://api.github.com/users/shamsasari/gists{/gist_id}","starred_url":"https://api.github.com/users/shamsasari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shamsasari/subscriptions","organizations_url":"https://api.github.com/users/shamsasari/orgs","repos_url":"https://api.github.com/users/shamsasari/repos","events_url":"https://api.github.com/users/shamsasari/events{/privacy}","received_events_url":"https://api.github.com/users/shamsasari/received_events","type":"User","site_admin":false},"body":"… nodes to across different machines.\r\n\r\nThis was achieved by having the hash in the node-info file to be just of the node's X.500 name. This also solves existing duplicate node-info file issues that we've been having.\r\n\r\nAlso updated the docsite.\r\n\r\n","created_at":"2018-02-28T16:02:21Z","updated_at":"2018-02-28T16:53:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0c1c91f49c2c488ff8ac32ef798e8c33abb9a757","assignee":null,"assignees":[],"requested_reviewers":[{"login":"joeldudleyr3","id":24230167,"avatar_url":"https://avatars0.githubusercontent.com/u/24230167?v=4","gravatar_id":"","url":"https://api.github.com/users/joeldudleyr3","html_url":"https://github.com/joeldudleyr3","followers_url":"https://api.github.com/users/joeldudleyr3/followers","following_url":"https://api.github.com/users/joeldudleyr3/following{/other_user}","gists_url":"https://api.github.com/users/joeldudleyr3/gists{/gist_id}","starred_url":"https://api.github.com/users/joeldudleyr3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joeldudleyr3/subscriptions","organizations_url":"https://api.github.com/users/joeldudleyr3/orgs","repos_url":"https://api.github.com/users/joeldudleyr3/repos","events_url":"https://api.github.com/users/joeldudleyr3/events{/privacy}","received_events_url":"https://api.github.com/users/joeldudleyr3/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/corda/corda/pulls/2672/commits","review_comments_url":"https://api.github.com/repos/corda/corda/pulls/2672/comments","review_comment_url":"https://api.github.com/repos/corda/corda/pulls/comments{/number}","comments_url":"https://api.github.com/repos/corda/corda/issues/2672/comments","statuses_url":"https://api.github.com/repos/corda/corda/statuses/ee3a5fa0ef8adb4a14eec8c7ab1763bd679d7783","head":{"label":"corda:shams-1048","ref":"shams-1048","sha":"ee3a5fa0ef8adb4a14eec8c7ab1763bd679d7783","user":{"login":"corda","id":22600631,"avatar_url":"https://avatars1.githubusercontent.com/u/22600631?v=4","gravatar_id":"","url":"https://api.github.com/users/corda","html_url":"https://github.com/corda","followers_url":"https://api.github.com/users/corda/followers","following_url":"https://api.github.com/users/corda/following{/other_user}","gists_url":"https://api.github.com/users/corda/gists{/gist_id}","starred_url":"https://api.github.com/users/corda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corda/subscriptions","organizations_url":"https://api.github.com/users/corda/orgs","repos_url":"https://api.github.com/users/corda/repos","events_url":"https://api.github.com/users/corda/events{/privacy}","received_events_url":"https://api.github.com/users/corda/received_events","type":"Organization","site_admin":false},"repo":{"id":70137417,"name":"corda","full_name":"corda/corda","owner":{"login":"corda","id":22600631,"avatar_url":"https://avatars1.githubusercontent.com/u/22600631?v=4","gravatar_id":"","url":"https://api.github.com/users/corda","html_url":"https://github.com/corda","followers_url":"https://api.github.com/users/corda/followers","following_url":"https://api.github.com/users/corda/following{/other_user}","gists_url":"https://api.github.com/users/corda/gists{/gist_id}","starred_url":"https://api.github.com/users/corda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corda/subscriptions","organizations_url":"https://api.github.com/users/corda/orgs","repos_url":"https://api.github.com/users/corda/repos","events_url":"https://api.github.com/users/corda/events{/privacy}","received_events_url":"https://api.github.com/users/corda/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/corda/corda","description":"Corda is a distributed ledger platform designed to record, manage and automate legal agreements between business partners. Designed by (and for) the world's largest financial institutions yet with applications in multiple industries.  It offers a unique response to the privacy and scalability challenges facing decentralised applications.","fork":false,"url":"https://api.github.com/repos/corda/corda","forks_url":"https://api.github.com/repos/corda/corda/forks","keys_url":"https://api.github.com/repos/corda/corda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/corda/corda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/corda/corda/teams","hooks_url":"https://api.github.com/repos/corda/corda/hooks","issue_events_url":"https://api.github.com/repos/corda/corda/issues/events{/number}","events_url":"https://api.github.com/repos/corda/corda/events","assignees_url":"https://api.github.com/repos/corda/corda/assignees{/user}","branches_url":"https://api.github.com/repos/corda/corda/branches{/branch}","tags_url":"https://api.github.com/repos/corda/corda/tags","blobs_url":"https://api.github.com/repos/corda/corda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/corda/corda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/corda/corda/git/refs{/sha}","trees_url":"https://api.github.com/repos/corda/corda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/corda/corda/statuses/{sha}","languages_url":"https://api.github.com/repos/corda/corda/languages","stargazers_url":"https://api.github.com/repos/corda/corda/stargazers","contributors_url":"https://api.github.com/repos/corda/corda/contributors","subscribers_url":"https://api.github.com/repos/corda/corda/subscribers","subscription_url":"https://api.github.com/repos/corda/corda/subscription","commits_url":"https://api.github.com/repos/corda/corda/commits{/sha}","git_commits_url":"https://api.github.com/repos/corda/corda/git/commits{/sha}","comments_url":"https://api.github.com/repos/corda/corda/comments{/number}","issue_comment_url":"https://api.github.com/repos/corda/corda/issues/comments{/number}","contents_url":"https://api.github.com/repos/corda/corda/contents/{+path}","compare_url":"https://api.github.com/repos/corda/corda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/corda/corda/merges","archive_url":"https://api.github.com/repos/corda/corda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/corda/corda/downloads","issues_url":"https://api.github.com/repos/corda/corda/issues{/number}","pulls_url":"https://api.github.com/repos/corda/corda/pulls{/number}","milestones_url":"https://api.github.com/repos/corda/corda/milestones{/number}","notifications_url":"https://api.github.com/repos/corda/corda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/corda/corda/labels{/name}","releases_url":"https://api.github.com/repos/corda/corda/releases{/id}","deployments_url":"https://api.github.com/repos/corda/corda/deployments","created_at":"2016-10-06T08:46:29Z","updated_at":"2018-02-28T09:33:07Z","pushed_at":"2018-02-28T16:17:10Z","git_url":"git://github.com/corda/corda.git","ssh_url":"git@github.com:corda/corda.git","clone_url":"https://github.com/corda/corda.git","svn_url":"https://github.com/corda/corda","homepage":"https://www.corda.net","size":108885,"stargazers_count":1514,"watchers_count":1514,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":409,"mirror_url":null,"archived":false,"open_issues_count":127,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":409,"open_issues":127,"watchers":1514,"default_branch":"master"}},"base":{"label":"corda:master","ref":"master","sha":"577033441adb590bb88f34f5fdac4f138a4d8fbf","user":{"login":"corda","id":22600631,"avatar_url":"https://avatars1.githubusercontent.com/u/22600631?v=4","gravatar_id":"","url":"https://api.github.com/users/corda","html_url":"https://github.com/corda","followers_url":"https://api.github.com/users/corda/followers","following_url":"https://api.github.com/users/corda/following{/other_user}","gists_url":"https://api.github.com/users/corda/gists{/gist_id}","starred_url":"https://api.github.com/users/corda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corda/subscriptions","organizations_url":"https://api.github.com/users/corda/orgs","repos_url":"https://api.github.com/users/corda/repos","events_url":"https://api.github.com/users/corda/events{/privacy}","received_events_url":"https://api.github.com/users/corda/received_events","type":"Organization","site_admin":false},"repo":{"id":70137417,"name":"corda","full_name":"corda/corda","owner":{"login":"corda","id":22600631,"avatar_url":"https://avatars1.githubusercontent.com/u/22600631?v=4","gravatar_id":"","url":"https://api.github.com/users/corda","html_url":"https://github.com/corda","followers_url":"https://api.github.com/users/corda/followers","following_url":"https://api.github.com/users/corda/following{/other_user}","gists_url":"https://api.github.com/users/corda/gists{/gist_id}","starred_url":"https://api.github.com/users/corda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corda/subscriptions","organizations_url":"https://api.github.com/users/corda/orgs","repos_url":"https://api.github.com/users/corda/repos","events_url":"https://api.github.com/users/corda/events{/privacy}","received_events_url":"https://api.github.com/users/corda/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/corda/corda","description":"Corda is a distributed ledger platform designed to record, manage and automate legal agreements between business partners. Designed by (and for) the world's largest financial institutions yet with applications in multiple industries.  It offers a unique response to the privacy and scalability challenges facing decentralised applications.","fork":false,"url":"https://api.github.com/repos/corda/corda","forks_url":"https://api.github.com/repos/corda/corda/forks","keys_url":"https://api.github.com/repos/corda/corda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/corda/corda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/corda/corda/teams","hooks_url":"https://api.github.com/repos/corda/corda/hooks","issue_events_url":"https://api.github.com/repos/corda/corda/issues/events{/number}","events_url":"https://api.github.com/repos/corda/corda/events","assignees_url":"https://api.github.com/repos/corda/corda/assignees{/user}","branches_url":"https://api.github.com/repos/corda/corda/branches{/branch}","tags_url":"https://api.github.com/repos/corda/corda/tags","blobs_url":"https://api.github.com/repos/corda/corda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/corda/corda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/corda/corda/git/refs{/sha}","trees_url":"https://api.github.com/repos/corda/corda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/corda/corda/statuses/{sha}","languages_url":"https://api.github.com/repos/corda/corda/languages","stargazers_url":"https://api.github.com/repos/corda/corda/stargazers","contributors_url":"https://api.github.com/repos/corda/corda/contributors","subscribers_url":"https://api.github.com/repos/corda/corda/subscribers","subscription_url":"https://api.github.com/repos/corda/corda/subscription","commits_url":"https://api.github.com/repos/corda/corda/commits{/sha}","git_commits_url":"https://api.github.com/repos/corda/corda/git/commits{/sha}","comments_url":"https://api.github.com/repos/corda/corda/comments{/number}","issue_comment_url":"https://api.github.com/repos/corda/corda/issues/comments{/number}","contents_url":"https://api.github.com/repos/corda/corda/contents/{+path}","compare_url":"https://api.github.com/repos/corda/corda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/corda/corda/merges","archive_url":"https://api.github.com/repos/corda/corda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/corda/corda/downloads","issues_url":"https://api.github.com/repos/corda/corda/issues{/number}","pulls_url":"https://api.github.com/repos/corda/corda/pulls{/number}","milestones_url":"https://api.github.com/repos/corda/corda/milestones{/number}","notifications_url":"https://api.github.com/repos/corda/corda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/corda/corda/labels{/name}","releases_url":"https://api.github.com/repos/corda/corda/releases{/id}","deployments_url":"https://api.github.com/repos/corda/corda/deployments","created_at":"2016-10-06T08:46:29Z","updated_at":"2018-02-28T09:33:07Z","pushed_at":"2018-02-28T16:17:10Z","git_url":"git://github.com/corda/corda.git","ssh_url":"git@github.com:corda/corda.git","clone_url":"https://github.com/corda/corda.git","svn_url":"https://github.com/corda/corda","homepage":"https://www.corda.net","size":108885,"stargazers_count":1514,"watchers_count":1514,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":409,"mirror_url":null,"archived":false,"open_issues_count":127,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":409,"open_issues":127,"watchers":1514,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/corda/corda/pulls/2672"},"html":{"href":"https://github.com/corda/corda/pull/2672"},"issue":{"href":"https://api.github.com/repos/corda/corda/issues/2672"},"comments":{"href":"https://api.github.com/repos/corda/corda/issues/2672/comments"},"review_comments":{"href":"https://api.github.com/repos/corda/corda/pulls/2672/comments"},"review_comment":{"href":"https://api.github.com/repos/corda/corda/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/corda/corda/pulls/2672/commits"},"statuses":{"href":"https://api.github.com/repos/corda/corda/statuses/ee3a5fa0ef8adb4a14eec8c7ab1763bd679d7783"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"kasiastreich"}}