{"action":"closed","number":550,"pull_request":{"url":"https://api.github.com/repos/mendersoftware/meta-mender/pulls/550","id":200989549,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwOTg5NTQ5","html_url":"https://github.com/mendersoftware/meta-mender/pull/550","diff_url":"https://github.com/mendersoftware/meta-mender/pull/550.diff","patch_url":"https://github.com/mendersoftware/meta-mender/pull/550.patch","issue_url":"https://api.github.com/repos/mendersoftware/meta-mender/issues/550","number":550,"state":"closed","locked":false,"title":"Add canary value to U-Boot env to catch bootloader/user-space mismatch.","user":{"login":"kacf","id":4037094,"node_id":"MDQ6VXNlcjQwMzcwOTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/4037094?v=4","gravatar_id":"","url":"https://api.github.com/users/kacf","html_url":"https://github.com/kacf","followers_url":"https://api.github.com/users/kacf/followers","following_url":"https://api.github.com/users/kacf/following{/other_user}","gists_url":"https://api.github.com/users/kacf/gists{/gist_id}","starred_url":"https://api.github.com/users/kacf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kacf/subscriptions","organizations_url":"https://api.github.com/users/kacf/orgs","repos_url":"https://api.github.com/users/kacf/repos","events_url":"https://api.github.com/users/kacf/events{/privacy}","received_events_url":"https://api.github.com/users/kacf/received_events","type":"User","site_admin":false},"body":"The way it works is that we store the 'mender_check_saveenv_canary=1'\r\nvariable in the default U-Boot environment. We do not store the\r\ncorresponding 'mender_saveenv_canary=1' value in the default\r\nenvironment, but instead we write this during the boot process. When\r\nthe Mender client finds the former variable, it will look for the\r\nsecond value as well, and produce an error if it is not present. If\r\nthis happens it is an indication that the U-Boot boot loader and the\r\nuser space tools do not agree on the location of the environment. It\r\nwill also catch cases where mender_setup is not run.\r\n\r\nChangelog: Title\r\n\r\nSigned-off-by: Kristian Amlie <kristian.amlie@northern.tech>","created_at":"2018-07-12T12:46:57Z","updated_at":"2018-07-16T15:37:13Z","closed_at":"2018-07-16T15:37:13Z","merged_at":"2018-07-16T15:37:12Z","merge_commit_sha":"69585e6f1e59751dede369e09af3452e8bed0218","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mendersoftware/meta-mender/pulls/550/commits","review_comments_url":"https://api.github.com/repos/mendersoftware/meta-mender/pulls/550/comments","review_comment_url":"https://api.github.com/repos/mendersoftware/meta-mender/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mendersoftware/meta-mender/issues/550/comments","statuses_url":"https://api.github.com/repos/mendersoftware/meta-mender/statuses/b36907b823b4f20df013ca5644ccde8c8ea12e7c","head":{"label":"kacf:env_canary","ref":"env_canary","sha":"b36907b823b4f20df013ca5644ccde8c8ea12e7c","user":{"login":"kacf","id":4037094,"node_id":"MDQ6VXNlcjQwMzcwOTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/4037094?v=4","gravatar_id":"","url":"https://api.github.com/users/kacf","html_url":"https://github.com/kacf","followers_url":"https://api.github.com/users/kacf/followers","following_url":"https://api.github.com/users/kacf/following{/other_user}","gists_url":"https://api.github.com/users/kacf/gists{/gist_id}","starred_url":"https://api.github.com/users/kacf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kacf/subscriptions","organizations_url":"https://api.github.com/users/kacf/orgs","repos_url":"https://api.github.com/users/kacf/repos","events_url":"https://api.github.com/users/kacf/events{/privacy}","received_events_url":"https://api.github.com/users/kacf/received_events","type":"User","site_admin":false},"repo":{"id":50186314,"node_id":"MDEwOlJlcG9zaXRvcnk1MDE4NjMxNA==","name":"meta-mender","full_name":"kacf/meta-mender","owner":{"login":"kacf","id":4037094,"node_id":"MDQ6VXNlcjQwMzcwOTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/4037094?v=4","gravatar_id":"","url":"https://api.github.com/users/kacf","html_url":"https://github.com/kacf","followers_url":"https://api.github.com/users/kacf/followers","following_url":"https://api.github.com/users/kacf/following{/other_user}","gists_url":"https://api.github.com/users/kacf/gists{/gist_id}","starred_url":"https://api.github.com/users/kacf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kacf/subscriptions","organizations_url":"https://api.github.com/users/kacf/orgs","repos_url":"https://api.github.com/users/kacf/repos","events_url":"https://api.github.com/users/kacf/events{/privacy}","received_events_url":"https://api.github.com/users/kacf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kacf/meta-mender","description":"Yocto meta layer","fork":true,"url":"https://api.github.com/repos/kacf/meta-mender","forks_url":"https://api.github.com/repos/kacf/meta-mender/forks","keys_url":"https://api.github.com/repos/kacf/meta-mender/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kacf/meta-mender/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kacf/meta-mender/teams","hooks_url":"https://api.github.com/repos/kacf/meta-mender/hooks","issue_events_url":"https://api.github.com/repos/kacf/meta-mender/issues/events{/number}","events_url":"https://api.github.com/repos/kacf/meta-mender/events","assignees_url":"https://api.github.com/repos/kacf/meta-mender/assignees{/user}","branches_url":"https://api.github.com/repos/kacf/meta-mender/branches{/branch}","tags_url":"https://api.github.com/repos/kacf/meta-mender/tags","blobs_url":"https://api.github.com/repos/kacf/meta-mender/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kacf/meta-mender/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kacf/meta-mender/git/refs{/sha}","trees_url":"https://api.github.com/repos/kacf/meta-mender/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kacf/meta-mender/statuses/{sha}","languages_url":"https://api.github.com/repos/kacf/meta-mender/languages","stargazers_url":"https://api.github.com/repos/kacf/meta-mender/stargazers","contributors_url":"https://api.github.com/repos/kacf/meta-mender/contributors","subscribers_url":"https://api.github.com/repos/kacf/meta-mender/subscribers","subscription_url":"https://api.github.com/repos/kacf/meta-mender/subscription","commits_url":"https://api.github.com/repos/kacf/meta-mender/commits{/sha}","git_commits_url":"https://api.github.com/repos/kacf/meta-mender/git/commits{/sha}","comments_url":"https://api.github.com/repos/kacf/meta-mender/comments{/number}","issue_comment_url":"https://api.github.com/repos/kacf/meta-mender/issues/comments{/number}","contents_url":"https://api.github.com/repos/kacf/meta-mender/contents/{+path}","compare_url":"https://api.github.com/repos/kacf/meta-mender/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kacf/meta-mender/merges","archive_url":"https://api.github.com/repos/kacf/meta-mender/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kacf/meta-mender/downloads","issues_url":"https://api.github.com/repos/kacf/meta-mender/issues{/number}","pulls_url":"https://api.github.com/repos/kacf/meta-mender/pulls{/number}","milestones_url":"https://api.github.com/repos/kacf/meta-mender/milestones{/number}","notifications_url":"https://api.github.com/repos/kacf/meta-mender/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kacf/meta-mender/labels{/name}","releases_url":"https://api.github.com/repos/kacf/meta-mender/releases{/id}","deployments_url":"https://api.github.com/repos/kacf/meta-mender/deployments","created_at":"2016-01-22T14:33:28Z","updated_at":"2018-05-31T14:33:04Z","pushed_at":"2018-07-16T09:43:03Z","git_url":"git://github.com/kacf/meta-mender.git","ssh_url":"git@github.com:kacf/meta-mender.git","clone_url":"https://github.com/kacf/meta-mender.git","svn_url":"https://github.com/kacf/meta-mender","homepage":"https://mender.io","size":1659,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mendersoftware:master","ref":"master","sha":"cabf5b6997bf11d35a8aebe8eb41f6399c5e4d93","user":{"login":"mendersoftware","id":15040539,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MDQwNTM5","avatar_url":"https://avatars1.githubusercontent.com/u/15040539?v=4","gravatar_id":"","url":"https://api.github.com/users/mendersoftware","html_url":"https://github.com/mendersoftware","followers_url":"https://api.github.com/users/mendersoftware/followers","following_url":"https://api.github.com/users/mendersoftware/following{/other_user}","gists_url":"https://api.github.com/users/mendersoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/mendersoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mendersoftware/subscriptions","organizations_url":"https://api.github.com/users/mendersoftware/orgs","repos_url":"https://api.github.com/users/mendersoftware/repos","events_url":"https://api.github.com/users/mendersoftware/events{/privacy}","received_events_url":"https://api.github.com/users/mendersoftware/received_events","type":"Organization","site_admin":false},"repo":{"id":47542851,"node_id":"MDEwOlJlcG9zaXRvcnk0NzU0Mjg1MQ==","name":"meta-mender","full_name":"mendersoftware/meta-mender","owner":{"login":"mendersoftware","id":15040539,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MDQwNTM5","avatar_url":"https://avatars1.githubusercontent.com/u/15040539?v=4","gravatar_id":"","url":"https://api.github.com/users/mendersoftware","html_url":"https://github.com/mendersoftware","followers_url":"https://api.github.com/users/mendersoftware/followers","following_url":"https://api.github.com/users/mendersoftware/following{/other_user}","gists_url":"https://api.github.com/users/mendersoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/mendersoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mendersoftware/subscriptions","organizations_url":"https://api.github.com/users/mendersoftware/orgs","repos_url":"https://api.github.com/users/mendersoftware/repos","events_url":"https://api.github.com/users/mendersoftware/events{/privacy}","received_events_url":"https://api.github.com/users/mendersoftware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mendersoftware/meta-mender","description":"Yocto meta layer","fork":false,"url":"https://api.github.com/repos/mendersoftware/meta-mender","forks_url":"https://api.github.com/repos/mendersoftware/meta-mender/forks","keys_url":"https://api.github.com/repos/mendersoftware/meta-mender/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mendersoftware/meta-mender/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mendersoftware/meta-mender/teams","hooks_url":"https://api.github.com/repos/mendersoftware/meta-mender/hooks","issue_events_url":"https://api.github.com/repos/mendersoftware/meta-mender/issues/events{/number}","events_url":"https://api.github.com/repos/mendersoftware/meta-mender/events","assignees_url":"https://api.github.com/repos/mendersoftware/meta-mender/assignees{/user}","branches_url":"https://api.github.com/repos/mendersoftware/meta-mender/branches{/branch}","tags_url":"https://api.github.com/repos/mendersoftware/meta-mender/tags","blobs_url":"https://api.github.com/repos/mendersoftware/meta-mender/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mendersoftware/meta-mender/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mendersoftware/meta-mender/git/refs{/sha}","trees_url":"https://api.github.com/repos/mendersoftware/meta-mender/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mendersoftware/meta-mender/statuses/{sha}","languages_url":"https://api.github.com/repos/mendersoftware/meta-mender/languages","stargazers_url":"https://api.github.com/repos/mendersoftware/meta-mender/stargazers","contributors_url":"https://api.github.com/repos/mendersoftware/meta-mender/contributors","subscribers_url":"https://api.github.com/repos/mendersoftware/meta-mender/subscribers","subscription_url":"https://api.github.com/repos/mendersoftware/meta-mender/subscription","commits_url":"https://api.github.com/repos/mendersoftware/meta-mender/commits{/sha}","git_commits_url":"https://api.github.com/repos/mendersoftware/meta-mender/git/commits{/sha}","comments_url":"https://api.github.com/repos/mendersoftware/meta-mender/comments{/number}","issue_comment_url":"https://api.github.com/repos/mendersoftware/meta-mender/issues/comments{/number}","contents_url":"https://api.github.com/repos/mendersoftware/meta-mender/contents/{+path}","compare_url":"https://api.github.com/repos/mendersoftware/meta-mender/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mendersoftware/meta-mender/merges","archive_url":"https://api.github.com/repos/mendersoftware/meta-mender/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mendersoftware/meta-mender/downloads","issues_url":"https://api.github.com/repos/mendersoftware/meta-mender/issues{/number}","pulls_url":"https://api.github.com/repos/mendersoftware/meta-mender/pulls{/number}","milestones_url":"https://api.github.com/repos/mendersoftware/meta-mender/milestones{/number}","notifications_url":"https://api.github.com/repos/mendersoftware/meta-mender/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mendersoftware/meta-mender/labels{/name}","releases_url":"https://api.github.com/repos/mendersoftware/meta-mender/releases{/id}","deployments_url":"https://api.github.com/repos/mendersoftware/meta-mender/deployments","created_at":"2015-12-07T09:37:44Z","updated_at":"2018-07-12T10:45:15Z","pushed_at":"2018-07-16T15:37:12Z","git_url":"git://github.com/mendersoftware/meta-mender.git","ssh_url":"git@github.com:mendersoftware/meta-mender.git","clone_url":"https://github.com/mendersoftware/meta-mender.git","svn_url":"https://github.com/mendersoftware/meta-mender","homepage":"https://mender.io","size":1767,"stargazers_count":61,"watchers_count":61,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":48,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":48,"open_issues":5,"watchers":61,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mendersoftware/meta-mender/pulls/550"},"html":{"href":"https://github.com/mendersoftware/meta-mender/pull/550"},"issue":{"href":"https://api.github.com/repos/mendersoftware/meta-mender/issues/550"},"comments":{"href":"https://api.github.com/repos/mendersoftware/meta-mender/issues/550/comments"},"review_comments":{"href":"https://api.github.com/repos/mendersoftware/meta-mender/pulls/550/comments"},"review_comment":{"href":"https://api.github.com/repos/mendersoftware/meta-mender/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mendersoftware/meta-mender/pulls/550/commits"},"statuses":{"href":"https://api.github.com/repos/mendersoftware/meta-mender/statuses/b36907b823b4f20df013ca5644ccde8c8ea12e7c"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"kacf","id":4037094,"node_id":"MDQ6VXNlcjQwMzcwOTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/4037094?v=4","gravatar_id":"","url":"https://api.github.com/users/kacf","html_url":"https://github.com/kacf","followers_url":"https://api.github.com/users/kacf/followers","following_url":"https://api.github.com/users/kacf/following{/other_user}","gists_url":"https://api.github.com/users/kacf/gists{/gist_id}","starred_url":"https://api.github.com/users/kacf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kacf/subscriptions","organizations_url":"https://api.github.com/users/kacf/orgs","repos_url":"https://api.github.com/users/kacf/repos","events_url":"https://api.github.com/users/kacf/events{/privacy}","received_events_url":"https://api.github.com/users/kacf/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":60,"deletions":1,"changed_files":2}}
{"actor":{"display_login":"kacf"}}