{"action":"created","issue":{"url":"https://api.github.com/repos/Skalar/google_distance_matrix/issues/41","repository_url":"https://api.github.com/repos/Skalar/google_distance_matrix","labels_url":"https://api.github.com/repos/Skalar/google_distance_matrix/issues/41/labels{/name}","comments_url":"https://api.github.com/repos/Skalar/google_distance_matrix/issues/41/comments","events_url":"https://api.github.com/repos/Skalar/google_distance_matrix/issues/41/events","html_url":"https://github.com/Skalar/google_distance_matrix/issues/41","id":369963250,"node_id":"MDU6SXNzdWUzNjk5NjMyNTA=","number":41,"title":"Filtered params break caching","user":{"login":"yoniamir","id":3764751,"node_id":"MDQ6VXNlcjM3NjQ3NTE=","avatar_url":"https://avatars2.githubusercontent.com/u/3764751?v=4","gravatar_id":"","url":"https://api.github.com/users/yoniamir","html_url":"https://github.com/yoniamir","followers_url":"https://api.github.com/users/yoniamir/followers","following_url":"https://api.github.com/users/yoniamir/following{/other_user}","gists_url":"https://api.github.com/users/yoniamir/gists{/gist_id}","starred_url":"https://api.github.com/users/yoniamir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yoniamir/subscriptions","organizations_url":"https://api.github.com/users/yoniamir/orgs","repos_url":"https://api.github.com/users/yoniamir/repos","events_url":"https://api.github.com/users/yoniamir/events{/privacy}","received_events_url":"https://api.github.com/users/yoniamir/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-10-15T00:53:28Z","updated_at":"2018-10-20T14:29:54Z","closed_at":null,"author_association":"NONE","body":"When I tried using the cache option provided by this neat gem, I was looking at my web requests and realized that requests are not being cached. \r\nDigging in, it appears that the write key and the read key to the cache differ.\r\nThis happens because of the default filtering of the `filter_parameters_in_logged_url` setting, which excludes `key` from being *written* in the cache but is *read* from the cache, resulting in never working cache.\r\n\r\nSetting the `config.filter_parameters_in_logged_url = []` for example, fixes the caching problem. The obscuring does not work anyway since it's being used to read from the cache."},"comment":{"url":"https://api.github.com/repos/Skalar/google_distance_matrix/issues/comments/431586721","html_url":"https://github.com/Skalar/google_distance_matrix/issues/41#issuecomment-431586721","issue_url":"https://api.github.com/repos/Skalar/google_distance_matrix/issues/41","id":431586721,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMTU4NjcyMQ==","user":{"login":"thhermansen","id":92300,"node_id":"MDQ6VXNlcjkyMzAw","avatar_url":"https://avatars1.githubusercontent.com/u/92300?v=4","gravatar_id":"","url":"https://api.github.com/users/thhermansen","html_url":"https://github.com/thhermansen","followers_url":"https://api.github.com/users/thhermansen/followers","following_url":"https://api.github.com/users/thhermansen/following{/other_user}","gists_url":"https://api.github.com/users/thhermansen/gists{/gist_id}","starred_url":"https://api.github.com/users/thhermansen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thhermansen/subscriptions","organizations_url":"https://api.github.com/users/thhermansen/orgs","repos_url":"https://api.github.com/users/thhermansen/repos","events_url":"https://api.github.com/users/thhermansen/events{/privacy}","received_events_url":"https://api.github.com/users/thhermansen/received_events","type":"User","site_admin":false},"created_at":"2018-10-20T14:29:54Z","updated_at":"2018-10-20T14:29:54Z","author_association":"MEMBER","body":"Hi,\r\n\r\nI tried to reproduce it in tests, but I wasn't able to. Please take a look around here https://github.com/Skalar/google_distance_matrix/blob/80009225b259afbddbb52b0718195727c1544b03/spec/lib/google_distance_matrix/matrix_spec.rb#L141-L181\r\n\r\nAre you able to write a test here which reproduces your reporting? Maybe you have a specific configuration or something? Please fork and write a test which exposes the situation.\r\n\r\nThank you."}}
{"actor":{"display_login":"thhermansen"}}