{"action":"created","comment":{"url":"https://api.github.com/repos/awslabs/aws-cdk/pulls/comments/211202028","pull_request_review_id":147571958,"id":211202028,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTIwMjAyOA==","diff_hunk":"@@ -0,0 +1,225 @@\n+import { Tag } from '../cloudformation/tag';\n+import { Construct } from './construct';\n+import { Token } from './tokens';\n+\n+/**\n+ * ITaggable indicates a entity manages tags via the `tags` property\n+ */\n+export interface ITaggable {\n+    tags: TagManager,\n+}\n+\n+/**\n+ * Properties Tags is a dictionary of tags as strings\n+ */\n+export interface Tags {\n+    [key: string]: string\n+}\n+\n+/**\n+ * A an object of tags with value and properties\n+ *\n+ * This is used internally but not exported\n+ */\n+interface FullTags {\n+    [key: string]: {value: string, props?: TagProps};\n+}\n+\n+/**\n+ * Properties for a tag\n+ */\n+export interface TagProps {\n+    /**\n+     * If true all child taggable `Constructs` will receive this tag\n+     *\n+     * @default true\n+     */\n+    propagate?: boolean;\n+\n+    /**\n+     * If set propagated tags from parents will overwrite tags in children\n+     *\n+     * @default false\n+     */\n+    propagateOverride?: boolean;\n+\n+    /**\n+     * If set this tag will overwrite existing tags","path":"packages/@aws-cdk/cdk/lib/core/tag-manager.ts","position":47,"original_position":47,"commit_id":"8c67baea4a368040bcb6ed9e0016720627f0407d","original_commit_id":"8c67baea4a368040bcb6ed9e0016720627f0407d","user":{"login":"rix0rrr","id":524162,"node_id":"MDQ6VXNlcjUyNDE2Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/524162?v=4","gravatar_id":"","url":"https://api.github.com/users/rix0rrr","html_url":"https://github.com/rix0rrr","followers_url":"https://api.github.com/users/rix0rrr/followers","following_url":"https://api.github.com/users/rix0rrr/following{/other_user}","gists_url":"https://api.github.com/users/rix0rrr/gists{/gist_id}","starred_url":"https://api.github.com/users/rix0rrr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rix0rrr/subscriptions","organizations_url":"https://api.github.com/users/rix0rrr/orgs","repos_url":"https://api.github.com/users/rix0rrr/repos","events_url":"https://api.github.com/users/rix0rrr/events{/privacy}","received_events_url":"https://api.github.com/users/rix0rrr/received_events","type":"User","site_admin":false},"body":"Also for propagated tags?","created_at":"2018-08-20T09:47:59Z","updated_at":"2018-08-20T09:47:59Z","html_url":"https://github.com/awslabs/aws-cdk/pull/538#discussion_r211202028","pull_request_url":"https://api.github.com/repos/awslabs/aws-cdk/pulls/538","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/awslabs/aws-cdk/pulls/comments/211202028"},"html":{"href":"https://github.com/awslabs/aws-cdk/pull/538#discussion_r211202028"},"pull_request":{"href":"https://api.github.com/repos/awslabs/aws-cdk/pulls/538"}}},"pull_request":{"url":"https://api.github.com/repos/awslabs/aws-cdk/pulls/538","id":207394185,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3Mzk0MTg1","html_url":"https://github.com/awslabs/aws-cdk/pull/538","diff_url":"https://github.com/awslabs/aws-cdk/pull/538.diff","patch_url":"https://github.com/awslabs/aws-cdk/pull/538.patch","issue_url":"https://api.github.com/repos/awslabs/aws-cdk/issues/538","number":538,"state":"open","locked":false,"title":"Create A Tag Management for Constructs","user":{"login":"moofish32","id":664280,"node_id":"MDQ6VXNlcjY2NDI4MA==","avatar_url":"https://avatars0.githubusercontent.com/u/664280?v=4","gravatar_id":"","url":"https://api.github.com/users/moofish32","html_url":"https://github.com/moofish32","followers_url":"https://api.github.com/users/moofish32/followers","following_url":"https://api.github.com/users/moofish32/following{/other_user}","gists_url":"https://api.github.com/users/moofish32/gists{/gist_id}","starred_url":"https://api.github.com/users/moofish32/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moofish32/subscriptions","organizations_url":"https://api.github.com/users/moofish32/orgs","repos_url":"https://api.github.com/users/moofish32/repos","events_url":"https://api.github.com/users/moofish32/events{/privacy}","received_events_url":"https://api.github.com/users/moofish32/received_events","type":"User","site_admin":false},"body":"Created a tag-manager in cdk/core as a consistent means to manage tags for constructs. Construct authors are responsible for assigning tags to Cloudformation Resources. Implemented tags for Vpc and VpcSubnet for an initial example.\n\nI will do a self review to highlight some areas that did not end up\nwhere I wanted and I think may need to change.\n\nFocused on #91 and likely impacted by #518, closes #458 (as obsolete)\n\n\nBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.","created_at":"2018-08-09T17:50:00Z","updated_at":"2018-08-20T09:47:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"65c2b358c5b6de3b418913042f49f0d1b1601cb8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/awslabs/aws-cdk/pulls/538/commits","review_comments_url":"https://api.github.com/repos/awslabs/aws-cdk/pulls/538/comments","review_comment_url":"https://api.github.com/repos/awslabs/aws-cdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/awslabs/aws-cdk/issues/538/comments","statuses_url":"https://api.github.com/repos/awslabs/aws-cdk/statuses/8c67baea4a368040bcb6ed9e0016720627f0407d","head":{"label":"moofish32:f-tag-manager","ref":"f-tag-manager","sha":"8c67baea4a368040bcb6ed9e0016720627f0407d","user":{"login":"moofish32","id":664280,"node_id":"MDQ6VXNlcjY2NDI4MA==","avatar_url":"https://avatars0.githubusercontent.com/u/664280?v=4","gravatar_id":"","url":"https://api.github.com/users/moofish32","html_url":"https://github.com/moofish32","followers_url":"https://api.github.com/users/moofish32/followers","following_url":"https://api.github.com/users/moofish32/following{/other_user}","gists_url":"https://api.github.com/users/moofish32/gists{/gist_id}","starred_url":"https://api.github.com/users/moofish32/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moofish32/subscriptions","organizations_url":"https://api.github.com/users/moofish32/orgs","repos_url":"https://api.github.com/users/moofish32/repos","events_url":"https://api.github.com/users/moofish32/events{/privacy}","received_events_url":"https://api.github.com/users/moofish32/received_events","type":"User","site_admin":false},"repo":{"id":143065635,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMwNjU2MzU=","name":"aws-cdk","full_name":"moofish32/aws-cdk","owner":{"login":"moofish32","id":664280,"node_id":"MDQ6VXNlcjY2NDI4MA==","avatar_url":"https://avatars0.githubusercontent.com/u/664280?v=4","gravatar_id":"","url":"https://api.github.com/users/moofish32","html_url":"https://github.com/moofish32","followers_url":"https://api.github.com/users/moofish32/followers","following_url":"https://api.github.com/users/moofish32/following{/other_user}","gists_url":"https://api.github.com/users/moofish32/gists{/gist_id}","starred_url":"https://api.github.com/users/moofish32/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moofish32/subscriptions","organizations_url":"https://api.github.com/users/moofish32/orgs","repos_url":"https://api.github.com/users/moofish32/repos","events_url":"https://api.github.com/users/moofish32/events{/privacy}","received_events_url":"https://api.github.com/users/moofish32/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/moofish32/aws-cdk","description":"The AWS Cloud Development Kit is a framework for defining cloud infrastructure in code","fork":true,"url":"https://api.github.com/repos/moofish32/aws-cdk","forks_url":"https://api.github.com/repos/moofish32/aws-cdk/forks","keys_url":"https://api.github.com/repos/moofish32/aws-cdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/moofish32/aws-cdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/moofish32/aws-cdk/teams","hooks_url":"https://api.github.com/repos/moofish32/aws-cdk/hooks","issue_events_url":"https://api.github.com/repos/moofish32/aws-cdk/issues/events{/number}","events_url":"https://api.github.com/repos/moofish32/aws-cdk/events","assignees_url":"https://api.github.com/repos/moofish32/aws-cdk/assignees{/user}","branches_url":"https://api.github.com/repos/moofish32/aws-cdk/branches{/branch}","tags_url":"https://api.github.com/repos/moofish32/aws-cdk/tags","blobs_url":"https://api.github.com/repos/moofish32/aws-cdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/moofish32/aws-cdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/moofish32/aws-cdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/moofish32/aws-cdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/moofish32/aws-cdk/statuses/{sha}","languages_url":"https://api.github.com/repos/moofish32/aws-cdk/languages","stargazers_url":"https://api.github.com/repos/moofish32/aws-cdk/stargazers","contributors_url":"https://api.github.com/repos/moofish32/aws-cdk/contributors","subscribers_url":"https://api.github.com/repos/moofish32/aws-cdk/subscribers","subscription_url":"https://api.github.com/repos/moofish32/aws-cdk/subscription","commits_url":"https://api.github.com/repos/moofish32/aws-cdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/moofish32/aws-cdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/moofish32/aws-cdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/moofish32/aws-cdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/moofish32/aws-cdk/contents/{+path}","compare_url":"https://api.github.com/repos/moofish32/aws-cdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/moofish32/aws-cdk/merges","archive_url":"https://api.github.com/repos/moofish32/aws-cdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/moofish32/aws-cdk/downloads","issues_url":"https://api.github.com/repos/moofish32/aws-cdk/issues{/number}","pulls_url":"https://api.github.com/repos/moofish32/aws-cdk/pulls{/number}","milestones_url":"https://api.github.com/repos/moofish32/aws-cdk/milestones{/number}","notifications_url":"https://api.github.com/repos/moofish32/aws-cdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/moofish32/aws-cdk/labels{/name}","releases_url":"https://api.github.com/repos/moofish32/aws-cdk/releases{/id}","deployments_url":"https://api.github.com/repos/moofish32/aws-cdk/deployments","created_at":"2018-07-31T20:39:17Z","updated_at":"2018-07-31T20:39:21Z","pushed_at":"2018-08-20T06:06:22Z","git_url":"git://github.com/moofish32/aws-cdk.git","ssh_url":"git@github.com:moofish32/aws-cdk.git","clone_url":"https://github.com/moofish32/aws-cdk.git","svn_url":"https://github.com/moofish32/aws-cdk","homepage":"https://awslabs.github.io/aws-cdk","size":51198,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"awslabs:master","ref":"master","sha":"41732dbd16fa2796b3307f9ee8610754d7d0fbb6","user":{"login":"awslabs","id":3299148,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyOTkxNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/3299148?v=4","gravatar_id":"","url":"https://api.github.com/users/awslabs","html_url":"https://github.com/awslabs","followers_url":"https://api.github.com/users/awslabs/followers","following_url":"https://api.github.com/users/awslabs/following{/other_user}","gists_url":"https://api.github.com/users/awslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/awslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awslabs/subscriptions","organizations_url":"https://api.github.com/users/awslabs/orgs","repos_url":"https://api.github.com/users/awslabs/repos","events_url":"https://api.github.com/users/awslabs/events{/privacy}","received_events_url":"https://api.github.com/users/awslabs/received_events","type":"Organization","site_admin":false},"repo":{"id":105808767,"node_id":"MDEwOlJlcG9zaXRvcnkxMDU4MDg3Njc=","name":"aws-cdk","full_name":"awslabs/aws-cdk","owner":{"login":"awslabs","id":3299148,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyOTkxNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/3299148?v=4","gravatar_id":"","url":"https://api.github.com/users/awslabs","html_url":"https://github.com/awslabs","followers_url":"https://api.github.com/users/awslabs/followers","following_url":"https://api.github.com/users/awslabs/following{/other_user}","gists_url":"https://api.github.com/users/awslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/awslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awslabs/subscriptions","organizations_url":"https://api.github.com/users/awslabs/orgs","repos_url":"https://api.github.com/users/awslabs/repos","events_url":"https://api.github.com/users/awslabs/events{/privacy}","received_events_url":"https://api.github.com/users/awslabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/awslabs/aws-cdk","description":"The AWS Cloud Development Kit is a framework for defining cloud infrastructure in code","fork":false,"url":"https://api.github.com/repos/awslabs/aws-cdk","forks_url":"https://api.github.com/repos/awslabs/aws-cdk/forks","keys_url":"https://api.github.com/repos/awslabs/aws-cdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/awslabs/aws-cdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/awslabs/aws-cdk/teams","hooks_url":"https://api.github.com/repos/awslabs/aws-cdk/hooks","issue_events_url":"https://api.github.com/repos/awslabs/aws-cdk/issues/events{/number}","events_url":"https://api.github.com/repos/awslabs/aws-cdk/events","assignees_url":"https://api.github.com/repos/awslabs/aws-cdk/assignees{/user}","branches_url":"https://api.github.com/repos/awslabs/aws-cdk/branches{/branch}","tags_url":"https://api.github.com/repos/awslabs/aws-cdk/tags","blobs_url":"https://api.github.com/repos/awslabs/aws-cdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/awslabs/aws-cdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/awslabs/aws-cdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/awslabs/aws-cdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/awslabs/aws-cdk/statuses/{sha}","languages_url":"https://api.github.com/repos/awslabs/aws-cdk/languages","stargazers_url":"https://api.github.com/repos/awslabs/aws-cdk/stargazers","contributors_url":"https://api.github.com/repos/awslabs/aws-cdk/contributors","subscribers_url":"https://api.github.com/repos/awslabs/aws-cdk/subscribers","subscription_url":"https://api.github.com/repos/awslabs/aws-cdk/subscription","commits_url":"https://api.github.com/repos/awslabs/aws-cdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/awslabs/aws-cdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/awslabs/aws-cdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/awslabs/aws-cdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/awslabs/aws-cdk/contents/{+path}","compare_url":"https://api.github.com/repos/awslabs/aws-cdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/awslabs/aws-cdk/merges","archive_url":"https://api.github.com/repos/awslabs/aws-cdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/awslabs/aws-cdk/downloads","issues_url":"https://api.github.com/repos/awslabs/aws-cdk/issues{/number}","pulls_url":"https://api.github.com/repos/awslabs/aws-cdk/pulls{/number}","milestones_url":"https://api.github.com/repos/awslabs/aws-cdk/milestones{/number}","notifications_url":"https://api.github.com/repos/awslabs/aws-cdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/awslabs/aws-cdk/labels{/name}","releases_url":"https://api.github.com/repos/awslabs/aws-cdk/releases{/id}","deployments_url":"https://api.github.com/repos/awslabs/aws-cdk/deployments","created_at":"2017-10-04T19:22:36Z","updated_at":"2018-08-20T09:16:57Z","pushed_at":"2018-08-20T07:51:29Z","git_url":"git://github.com/awslabs/aws-cdk.git","ssh_url":"git@github.com:awslabs/aws-cdk.git","clone_url":"https://github.com/awslabs/aws-cdk.git","svn_url":"https://github.com/awslabs/aws-cdk","homepage":"https://awslabs.github.io/aws-cdk","size":80181,"stargazers_count":599,"watchers_count":599,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":27,"mirror_url":null,"archived":false,"open_issues_count":207,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":27,"open_issues":207,"watchers":599,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/awslabs/aws-cdk/pulls/538"},"html":{"href":"https://github.com/awslabs/aws-cdk/pull/538"},"issue":{"href":"https://api.github.com/repos/awslabs/aws-cdk/issues/538"},"comments":{"href":"https://api.github.com/repos/awslabs/aws-cdk/issues/538/comments"},"review_comments":{"href":"https://api.github.com/repos/awslabs/aws-cdk/pulls/538/comments"},"review_comment":{"href":"https://api.github.com/repos/awslabs/aws-cdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/awslabs/aws-cdk/pulls/538/commits"},"statuses":{"href":"https://api.github.com/repos/awslabs/aws-cdk/statuses/8c67baea4a368040bcb6ed9e0016720627f0407d"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"rix0rrr"}}