{"action":"closed","issue":{"url":"https://api.github.com/repos/eBay/ebayui-core/issues/324","repository_url":"https://api.github.com/repos/eBay/ebayui-core","labels_url":"https://api.github.com/repos/eBay/ebayui-core/issues/324/labels{/name}","comments_url":"https://api.github.com/repos/eBay/ebayui-core/issues/324/comments","events_url":"https://api.github.com/repos/eBay/ebayui-core/issues/324/events","html_url":"https://github.com/eBay/ebayui-core/issues/324","id":348534691,"node_id":"MDU6SXNzdWUzNDg1MzQ2OTE=","number":324,"title":"CI: BrowserStack can't run on PRs from forks","user":{"login":"yomed","id":3595986,"node_id":"MDQ6VXNlcjM1OTU5ODY=","avatar_url":"https://avatars3.githubusercontent.com/u/3595986?v=4","gravatar_id":"","url":"https://api.github.com/users/yomed","html_url":"https://github.com/yomed","followers_url":"https://api.github.com/users/yomed/followers","following_url":"https://api.github.com/users/yomed/following{/other_user}","gists_url":"https://api.github.com/users/yomed/gists{/gist_id}","starred_url":"https://api.github.com/users/yomed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yomed/subscriptions","organizations_url":"https://api.github.com/users/yomed/orgs","repos_url":"https://api.github.com/users/yomed/repos","events_url":"https://api.github.com/users/yomed/events{/privacy}","received_events_url":"https://api.github.com/users/yomed/received_events","type":"User","site_admin":false},"labels":[{"id":853146868,"node_id":"MDU6TGFiZWw4NTMxNDY4Njg=","url":"https://api.github.com/repos/eBay/ebayui-core/labels/aspect:%20CI","name":"aspect: CI","color":"006efc","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-08-08T00:42:48Z","updated_at":"2018-08-09T22:13:19Z","closed_at":"2018-08-09T22:13:19Z","author_association":"CONTRIBUTOR","body":"<!-- Delete any sections below that are not relevant. -->\r\n\r\n# Bug Report\r\n\r\n## eBayUI Version: 0.8.0\r\n\r\n## Description\r\n<!-- What's the bug? Include steps to reproduce, actual vs. expected behavior, etc. -->\r\nWe've had a few PRs recently from external contributors who opened up PRs from their personal forks:\r\nhttps://github.com/eBay/ebayui-core/pull/304\r\nhttps://github.com/eBay/ebayui-core/pull/319\r\n\r\nIn both of these, builds failed at the automated browser tests. But when putting those exact commits in an upstream branch, the builds passed fine. In discussing with @DylanPiercey, we found that there are security restrictions in place which prevent loading BrowserStack. Theoretically a rogue PR could dump the environment variables and get access to our private BrowserStack key.\r\n\r\nSome notes:\r\nhttps://github.com/travis-ci/travis-ci/issues/7412#issuecomment-283651393\r\nhttps://docs.travis-ci.com/user/pull-requests#pull-requests-and-security-restrictions\r\n\r\n>If your build relies on encrypted variables to run, for instance to run Selenium tests with BrowserStack or Sauce Labs, your build needs to take this into account. You won’t be able to run these tests for pull requests from external contributors.\r\n\r\nThis is obviously a pretty significant limitation for us, since we rely on those builds for all code that enters the repo. One partial solution might be to run headless Chrome in fork PRs, but run BrowserStack against upstream PRs.\r\n\r\n## Workaround\r\n<!-- Is there a known workaround? If so, what is it? -->\r\nNone."}}
{"actor":{"display_login":"sendlo"}}