{"action":"created","issue":{"url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/issues/7615","repository_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website","labels_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/issues/7615/labels{/name}","comments_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/issues/7615/comments","events_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/issues/7615/events","html_url":"https://github.com/department-of-veterans-affairs/vets-website/pull/7615","id":315673950,"number":7615,"title":"WIP - 3946 review page","user":{"login":"rianfowler","id":4998130,"avatar_url":"https://avatars3.githubusercontent.com/u/4998130?v=4","gravatar_id":"","url":"https://api.github.com/users/rianfowler","html_url":"https://github.com/rianfowler","followers_url":"https://api.github.com/users/rianfowler/followers","following_url":"https://api.github.com/users/rianfowler/following{/other_user}","gists_url":"https://api.github.com/users/rianfowler/gists{/gist_id}","starred_url":"https://api.github.com/users/rianfowler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rianfowler/subscriptions","organizations_url":"https://api.github.com/users/rianfowler/orgs","repos_url":"https://api.github.com/users/rianfowler/repos","events_url":"https://api.github.com/users/rianfowler/events{/privacy}","received_events_url":"https://api.github.com/users/rianfowler/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-04-18T23:13:55Z","updated_at":"2018-04-19T21:06:08Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/pulls/7615","html_url":"https://github.com/department-of-veterans-affairs/vets-website/pull/7615","diff_url":"https://github.com/department-of-veterans-affairs/vets-website/pull/7615.diff","patch_url":"https://github.com/department-of-veterans-affairs/vets-website/pull/7615.patch"},"body":"- Moved some stuff around and eliminated the need for `ReviewPage`\r\n- added `viewedPages` state to redux\r\n- moved state querying logic out of components' render and into `mapStateToProps`\r\n\r\nTODO\r\n- [ ] update unit tests \r\n- [ ] test rendering perf difference on inputs\r\n- [ ] remove `ReviewPage`\r\n- [ ] test scrolling behavior \r\n\r\n\r\n![reviewpage](https://user-images.githubusercontent.com/4998130/38962827-611c8e36-432c-11e8-9529-7348c68e0d57.gif)\r\n"},"comment":{"url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/issues/comments/382880720","html_url":"https://github.com/department-of-veterans-affairs/vets-website/pull/7615#issuecomment-382880720","issue_url":"https://api.github.com/repos/department-of-veterans-affairs/vets-website/issues/7615","id":382880720,"user":{"login":"jbalboni","id":634932,"avatar_url":"https://avatars2.githubusercontent.com/u/634932?v=4","gravatar_id":"","url":"https://api.github.com/users/jbalboni","html_url":"https://github.com/jbalboni","followers_url":"https://api.github.com/users/jbalboni/followers","following_url":"https://api.github.com/users/jbalboni/following{/other_user}","gists_url":"https://api.github.com/users/jbalboni/gists{/gist_id}","starred_url":"https://api.github.com/users/jbalboni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbalboni/subscriptions","organizations_url":"https://api.github.com/users/jbalboni/orgs","repos_url":"https://api.github.com/users/jbalboni/repos","events_url":"https://api.github.com/users/jbalboni/events{/privacy}","received_events_url":"https://api.github.com/users/jbalboni/received_events","type":"User","site_admin":false},"created_at":"2018-04-19T21:06:08Z","updated_at":"2018-04-19T21:06:08Z","author_association":"MEMBER","body":"@rianfowler We're going to have a situation soon where the review page components are going to live in the us-forms-system repo, but our save in progress code will stay in here. So we need to have a review page that doesn't import any save in progress code. The SiP functionality needs to wrap or proxy the standard review page behavior in some way."}}
{"actor":{"display_login":"jbalboni"}}