{"action":"closed","number":4724,"pull_request":{"url":"https://api.github.com/repos/facebook/osquery/pulls/4724","id":202192224,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyMTkyMjI0","html_url":"https://github.com/facebook/osquery/pull/4724","diff_url":"https://github.com/facebook/osquery/pull/4724.diff","patch_url":"https://github.com/facebook/osquery/pull/4724.patch","issue_url":"https://api.github.com/repos/facebook/osquery/issues/4724","number":4724,"state":"closed","locked":false,"title":"Remove preprocessor warning about undefined PATH_MAX","user":{"login":"akindyakov","id":2223470,"node_id":"MDQ6VXNlcjIyMjM0NzA=","avatar_url":"https://avatars1.githubusercontent.com/u/2223470?v=4","gravatar_id":"","url":"https://api.github.com/users/akindyakov","html_url":"https://github.com/akindyakov","followers_url":"https://api.github.com/users/akindyakov/followers","following_url":"https://api.github.com/users/akindyakov/following{/other_user}","gists_url":"https://api.github.com/users/akindyakov/gists{/gist_id}","starred_url":"https://api.github.com/users/akindyakov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akindyakov/subscriptions","organizations_url":"https://api.github.com/users/akindyakov/orgs","repos_url":"https://api.github.com/users/akindyakov/repos","events_url":"https://api.github.com/users/akindyakov/events{/privacy}","received_events_url":"https://api.github.com/users/akindyakov/received_events","type":"User","site_admin":false},"body":"Accoring to osquery development guidelines every warning should reveal some actionable problem.\r\nThis warning just inform about failed attempt to determine max length of the file pathname for the system. There is nothing to do, because some \"safe\" big length will be taken instead. The only possible problem is it could be cause some performance penalty, which can be found without this warning.\r\n\r\nI'd suggest to remove it.","created_at":"2018-07-18T09:33:58Z","updated_at":"2018-07-19T15:21:37Z","closed_at":"2018-07-19T15:21:37Z","merged_at":null,"merge_commit_sha":"b88c048a70d436dce58f8906c30d86f52de1d06f","assignee":{"login":"akindyakov","id":2223470,"node_id":"MDQ6VXNlcjIyMjM0NzA=","avatar_url":"https://avatars1.githubusercontent.com/u/2223470?v=4","gravatar_id":"","url":"https://api.github.com/users/akindyakov","html_url":"https://github.com/akindyakov","followers_url":"https://api.github.com/users/akindyakov/followers","following_url":"https://api.github.com/users/akindyakov/following{/other_user}","gists_url":"https://api.github.com/users/akindyakov/gists{/gist_id}","starred_url":"https://api.github.com/users/akindyakov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akindyakov/subscriptions","organizations_url":"https://api.github.com/users/akindyakov/orgs","repos_url":"https://api.github.com/users/akindyakov/repos","events_url":"https://api.github.com/users/akindyakov/events{/privacy}","received_events_url":"https://api.github.com/users/akindyakov/received_events","type":"User","site_admin":false},"assignees":[{"login":"akindyakov","id":2223470,"node_id":"MDQ6VXNlcjIyMjM0NzA=","avatar_url":"https://avatars1.githubusercontent.com/u/2223470?v=4","gravatar_id":"","url":"https://api.github.com/users/akindyakov","html_url":"https://github.com/akindyakov","followers_url":"https://api.github.com/users/akindyakov/followers","following_url":"https://api.github.com/users/akindyakov/following{/other_user}","gists_url":"https://api.github.com/users/akindyakov/gists{/gist_id}","starred_url":"https://api.github.com/users/akindyakov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akindyakov/subscriptions","organizations_url":"https://api.github.com/users/akindyakov/orgs","repos_url":"https://api.github.com/users/akindyakov/repos","events_url":"https://api.github.com/users/akindyakov/events{/privacy}","received_events_url":"https://api.github.com/users/akindyakov/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"mkareta","id":1892895,"node_id":"MDQ6VXNlcjE4OTI4OTU=","avatar_url":"https://avatars2.githubusercontent.com/u/1892895?v=4","gravatar_id":"","url":"https://api.github.com/users/mkareta","html_url":"https://github.com/mkareta","followers_url":"https://api.github.com/users/mkareta/followers","following_url":"https://api.github.com/users/mkareta/following{/other_user}","gists_url":"https://api.github.com/users/mkareta/gists{/gist_id}","starred_url":"https://api.github.com/users/mkareta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkareta/subscriptions","organizations_url":"https://api.github.com/users/mkareta/orgs","repos_url":"https://api.github.com/users/mkareta/repos","events_url":"https://api.github.com/users/mkareta/events{/privacy}","received_events_url":"https://api.github.com/users/mkareta/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":196858822,"node_id":"MDU6TGFiZWwxOTY4NTg4MjI=","url":"https://api.github.com/repos/facebook/osquery/labels/cla%20signed","name":"cla signed","color":"ededed","default":false},{"id":119503507,"node_id":"MDU6TGFiZWwxMTk1MDM1MDc=","url":"https://api.github.com/repos/facebook/osquery/labels/ready%20for%20review","name":"ready for review","color":"f7c6c7","default":false}],"milestone":{"url":"https://api.github.com/repos/facebook/osquery/milestones/35","html_url":"https://github.com/facebook/osquery/milestone/35","labels_url":"https://api.github.com/repos/facebook/osquery/milestones/35/labels","id":3262851,"node_id":"MDk6TWlsZXN0b25lMzI2Mjg1MQ==","number":35,"title":"3.3.0","description":"The next large feature release of osquery. The plan is for this to contain:\r\n\r\n* Braced initialization codemods\r\n* Process Table Improvements\r\n* Linux services table\r\n* Thread names\r\n* ...\r\n\r\nAmong many other new features in osquery.","creator":{"login":"obelisk","id":2386877,"node_id":"MDQ6VXNlcjIzODY4Nzc=","avatar_url":"https://avatars1.githubusercontent.com/u/2386877?v=4","gravatar_id":"","url":"https://api.github.com/users/obelisk","html_url":"https://github.com/obelisk","followers_url":"https://api.github.com/users/obelisk/followers","following_url":"https://api.github.com/users/obelisk/following{/other_user}","gists_url":"https://api.github.com/users/obelisk/gists{/gist_id}","starred_url":"https://api.github.com/users/obelisk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obelisk/subscriptions","organizations_url":"https://api.github.com/users/obelisk/orgs","repos_url":"https://api.github.com/users/obelisk/repos","events_url":"https://api.github.com/users/obelisk/events{/privacy}","received_events_url":"https://api.github.com/users/obelisk/received_events","type":"User","site_admin":false},"open_issues":9,"closed_issues":115,"state":"open","created_at":"2018-04-12T17:47:57Z","updated_at":"2018-07-19T15:21:37Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/facebook/osquery/pulls/4724/commits","review_comments_url":"https://api.github.com/repos/facebook/osquery/pulls/4724/comments","review_comment_url":"https://api.github.com/repos/facebook/osquery/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/osquery/issues/4724/comments","statuses_url":"https://api.github.com/repos/facebook/osquery/statuses/b4f0e3004378c7e2c8ad2d03e6529d7dd89b369c","head":{"label":"akindyakov:warning_removal_path_max","ref":"warning_removal_path_max","sha":"b4f0e3004378c7e2c8ad2d03e6529d7dd89b369c","user":{"login":"akindyakov","id":2223470,"node_id":"MDQ6VXNlcjIyMjM0NzA=","avatar_url":"https://avatars1.githubusercontent.com/u/2223470?v=4","gravatar_id":"","url":"https://api.github.com/users/akindyakov","html_url":"https://github.com/akindyakov","followers_url":"https://api.github.com/users/akindyakov/followers","following_url":"https://api.github.com/users/akindyakov/following{/other_user}","gists_url":"https://api.github.com/users/akindyakov/gists{/gist_id}","starred_url":"https://api.github.com/users/akindyakov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akindyakov/subscriptions","organizations_url":"https://api.github.com/users/akindyakov/orgs","repos_url":"https://api.github.com/users/akindyakov/repos","events_url":"https://api.github.com/users/akindyakov/events{/privacy}","received_events_url":"https://api.github.com/users/akindyakov/received_events","type":"User","site_admin":false},"repo":{"id":131700076,"node_id":"MDEwOlJlcG9zaXRvcnkxMzE3MDAwNzY=","name":"osquery","full_name":"akindyakov/osquery","owner":{"login":"akindyakov","id":2223470,"node_id":"MDQ6VXNlcjIyMjM0NzA=","avatar_url":"https://avatars1.githubusercontent.com/u/2223470?v=4","gravatar_id":"","url":"https://api.github.com/users/akindyakov","html_url":"https://github.com/akindyakov","followers_url":"https://api.github.com/users/akindyakov/followers","following_url":"https://api.github.com/users/akindyakov/following{/other_user}","gists_url":"https://api.github.com/users/akindyakov/gists{/gist_id}","starred_url":"https://api.github.com/users/akindyakov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akindyakov/subscriptions","organizations_url":"https://api.github.com/users/akindyakov/orgs","repos_url":"https://api.github.com/users/akindyakov/repos","events_url":"https://api.github.com/users/akindyakov/events{/privacy}","received_events_url":"https://api.github.com/users/akindyakov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/akindyakov/osquery","description":"SQL powered operating system instrumentation, monitoring, and analytics.","fork":true,"url":"https://api.github.com/repos/akindyakov/osquery","forks_url":"https://api.github.com/repos/akindyakov/osquery/forks","keys_url":"https://api.github.com/repos/akindyakov/osquery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akindyakov/osquery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akindyakov/osquery/teams","hooks_url":"https://api.github.com/repos/akindyakov/osquery/hooks","issue_events_url":"https://api.github.com/repos/akindyakov/osquery/issues/events{/number}","events_url":"https://api.github.com/repos/akindyakov/osquery/events","assignees_url":"https://api.github.com/repos/akindyakov/osquery/assignees{/user}","branches_url":"https://api.github.com/repos/akindyakov/osquery/branches{/branch}","tags_url":"https://api.github.com/repos/akindyakov/osquery/tags","blobs_url":"https://api.github.com/repos/akindyakov/osquery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akindyakov/osquery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akindyakov/osquery/git/refs{/sha}","trees_url":"https://api.github.com/repos/akindyakov/osquery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akindyakov/osquery/statuses/{sha}","languages_url":"https://api.github.com/repos/akindyakov/osquery/languages","stargazers_url":"https://api.github.com/repos/akindyakov/osquery/stargazers","contributors_url":"https://api.github.com/repos/akindyakov/osquery/contributors","subscribers_url":"https://api.github.com/repos/akindyakov/osquery/subscribers","subscription_url":"https://api.github.com/repos/akindyakov/osquery/subscription","commits_url":"https://api.github.com/repos/akindyakov/osquery/commits{/sha}","git_commits_url":"https://api.github.com/repos/akindyakov/osquery/git/commits{/sha}","comments_url":"https://api.github.com/repos/akindyakov/osquery/comments{/number}","issue_comment_url":"https://api.github.com/repos/akindyakov/osquery/issues/comments{/number}","contents_url":"https://api.github.com/repos/akindyakov/osquery/contents/{+path}","compare_url":"https://api.github.com/repos/akindyakov/osquery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akindyakov/osquery/merges","archive_url":"https://api.github.com/repos/akindyakov/osquery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akindyakov/osquery/downloads","issues_url":"https://api.github.com/repos/akindyakov/osquery/issues{/number}","pulls_url":"https://api.github.com/repos/akindyakov/osquery/pulls{/number}","milestones_url":"https://api.github.com/repos/akindyakov/osquery/milestones{/number}","notifications_url":"https://api.github.com/repos/akindyakov/osquery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akindyakov/osquery/labels{/name}","releases_url":"https://api.github.com/repos/akindyakov/osquery/releases{/id}","deployments_url":"https://api.github.com/repos/akindyakov/osquery/deployments","created_at":"2018-05-01T10:18:25Z","updated_at":"2018-07-19T11:40:54Z","pushed_at":"2018-07-19T15:20:10Z","git_url":"git://github.com/akindyakov/osquery.git","ssh_url":"git@github.com:akindyakov/osquery.git","clone_url":"https://github.com/akindyakov/osquery.git","svn_url":"https://github.com/akindyakov/osquery","homepage":"https://osquery.io","size":15536,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"2a2aa5b5ae141c61161facec45f696b3fd42067e","user":{"login":"facebook","id":69631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NjMx","avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":22394357,"node_id":"MDEwOlJlcG9zaXRvcnkyMjM5NDM1Nw==","name":"osquery","full_name":"facebook/osquery","owner":{"login":"facebook","id":69631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NjMx","avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/osquery","description":"SQL powered operating system instrumentation, monitoring, and analytics.","fork":false,"url":"https://api.github.com/repos/facebook/osquery","forks_url":"https://api.github.com/repos/facebook/osquery/forks","keys_url":"https://api.github.com/repos/facebook/osquery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/osquery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/osquery/teams","hooks_url":"https://api.github.com/repos/facebook/osquery/hooks","issue_events_url":"https://api.github.com/repos/facebook/osquery/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/osquery/events","assignees_url":"https://api.github.com/repos/facebook/osquery/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/osquery/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/osquery/tags","blobs_url":"https://api.github.com/repos/facebook/osquery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/osquery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/osquery/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/osquery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/osquery/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/osquery/languages","stargazers_url":"https://api.github.com/repos/facebook/osquery/stargazers","contributors_url":"https://api.github.com/repos/facebook/osquery/contributors","subscribers_url":"https://api.github.com/repos/facebook/osquery/subscribers","subscription_url":"https://api.github.com/repos/facebook/osquery/subscription","commits_url":"https://api.github.com/repos/facebook/osquery/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/osquery/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/osquery/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/osquery/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/osquery/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/osquery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/osquery/merges","archive_url":"https://api.github.com/repos/facebook/osquery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/osquery/downloads","issues_url":"https://api.github.com/repos/facebook/osquery/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/osquery/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/osquery/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/osquery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/osquery/labels{/name}","releases_url":"https://api.github.com/repos/facebook/osquery/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/osquery/deployments","created_at":"2014-07-29T20:27:33Z","updated_at":"2018-07-19T14:33:27Z","pushed_at":"2018-07-19T14:07:54Z","git_url":"git://github.com/facebook/osquery.git","ssh_url":"git@github.com:facebook/osquery.git","clone_url":"https://github.com/facebook/osquery.git","svn_url":"https://github.com/facebook/osquery","homepage":"https://osquery.io","size":15509,"stargazers_count":12785,"watchers_count":12785,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1505,"mirror_url":null,"archived":false,"open_issues_count":253,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1505,"open_issues":253,"watchers":12785,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/osquery/pulls/4724"},"html":{"href":"https://github.com/facebook/osquery/pull/4724"},"issue":{"href":"https://api.github.com/repos/facebook/osquery/issues/4724"},"comments":{"href":"https://api.github.com/repos/facebook/osquery/issues/4724/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/osquery/pulls/4724/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/osquery/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/osquery/pulls/4724/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/osquery/statuses/b4f0e3004378c7e2c8ad2d03e6529d7dd89b369c"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":0,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"akindyakov"}}