{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/issues/119","repository_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime","labels_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/issues/119/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/issues/119/comments","events_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/issues/119/events","html_url":"https://github.com/kubernetes-sigs/controller-runtime/issues/119","id":353784229,"node_id":"MDU6SXNzdWUzNTM3ODQyMjk=","number":119,"title":"Prometheus metrics","user":{"login":"JoelSpeed","id":9232216,"node_id":"MDQ6VXNlcjkyMzIyMTY=","avatar_url":"https://avatars3.githubusercontent.com/u/9232216?v=4","gravatar_id":"","url":"https://api.github.com/users/JoelSpeed","html_url":"https://github.com/JoelSpeed","followers_url":"https://api.github.com/users/JoelSpeed/followers","following_url":"https://api.github.com/users/JoelSpeed/following{/other_user}","gists_url":"https://api.github.com/users/JoelSpeed/gists{/gist_id}","starred_url":"https://api.github.com/users/JoelSpeed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoelSpeed/subscriptions","organizations_url":"https://api.github.com/users/JoelSpeed/orgs","repos_url":"https://api.github.com/users/JoelSpeed/repos","events_url":"https://api.github.com/users/JoelSpeed/events{/privacy}","received_events_url":"https://api.github.com/users/JoelSpeed/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-08-24T13:29:46Z","updated_at":"2018-08-24T17:39:35Z","closed_at":null,"author_association":"NONE","body":"I would like to add prometheus metrics to the controllers I'm building using kubebuilder.\r\n\r\nIt would be good to have information both from the controller internals themselves as well as from the reconciler loops I'm implementing.\r\n\r\nMy initial idea is to add a [prometheus metric registry](https://godoc.org/github.com/prometheus/client_golang/prometheus#Registry) to the controller manager that it can use itself and can be used by `reconcil.Reconciler`s to register their own metrics. Then have the controller manager start the metrics server when `Start` is called.\r\n\r\nDoes this seem reasonable or should people just handle metrics on their own? PR welcome?"},"comment":{"url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/issues/comments/415830203","html_url":"https://github.com/kubernetes-sigs/controller-runtime/issues/119#issuecomment-415830203","issue_url":"https://api.github.com/repos/kubernetes-sigs/controller-runtime/issues/119","id":415830203,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNTgzMDIwMw==","user":{"login":"DirectXMan12","id":119737,"node_id":"MDQ6VXNlcjExOTczNw==","avatar_url":"https://avatars1.githubusercontent.com/u/119737?v=4","gravatar_id":"","url":"https://api.github.com/users/DirectXMan12","html_url":"https://github.com/DirectXMan12","followers_url":"https://api.github.com/users/DirectXMan12/followers","following_url":"https://api.github.com/users/DirectXMan12/following{/other_user}","gists_url":"https://api.github.com/users/DirectXMan12/gists{/gist_id}","starred_url":"https://api.github.com/users/DirectXMan12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DirectXMan12/subscriptions","organizations_url":"https://api.github.com/users/DirectXMan12/orgs","repos_url":"https://api.github.com/users/DirectXMan12/repos","events_url":"https://api.github.com/users/DirectXMan12/events{/privacy}","received_events_url":"https://api.github.com/users/DirectXMan12/received_events","type":"User","site_admin":false},"created_at":"2018-08-24T17:39:35Z","updated_at":"2018-08-24T17:39:35Z","author_association":"CONTRIBUTOR","body":"PRs definitely welcome.  We already have some metrics that we inherit from the underlying apimachinery, but PRs are definitely welcome to improve this!\r\n\r\n/kind feature"}}
{"actor":{"display_login":"DirectXMan12"}}