{"action":"created","issue":{"url":"https://api.github.com/repos/helm/helm/issues/4657","repository_url":"https://api.github.com/repos/helm/helm","labels_url":"https://api.github.com/repos/helm/helm/issues/4657/labels{/name}","comments_url":"https://api.github.com/repos/helm/helm/issues/4657/comments","events_url":"https://api.github.com/repos/helm/helm/issues/4657/events","html_url":"https://github.com/helm/helm/pull/4657","id":361133096,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2MTgwOTc4","number":4657,"title":"fix(helm): fix regression with TLS flags/environment variables not being parsed","user":{"login":"bacongobbler","id":1360539,"node_id":"MDQ6VXNlcjEzNjA1Mzk=","avatar_url":"https://avatars2.githubusercontent.com/u/1360539?v=4","gravatar_id":"","url":"https://api.github.com/users/bacongobbler","html_url":"https://github.com/bacongobbler","followers_url":"https://api.github.com/users/bacongobbler/followers","following_url":"https://api.github.com/users/bacongobbler/following{/other_user}","gists_url":"https://api.github.com/users/bacongobbler/gists{/gist_id}","starred_url":"https://api.github.com/users/bacongobbler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bacongobbler/subscriptions","organizations_url":"https://api.github.com/users/bacongobbler/orgs","repos_url":"https://api.github.com/users/bacongobbler/repos","events_url":"https://api.github.com/users/bacongobbler/events{/privacy}","received_events_url":"https://api.github.com/users/bacongobbler/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-09-18T04:40:23Z","updated_at":"2018-09-18T18:36:12Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/helm/helm/pulls/4657","html_url":"https://github.com/helm/helm/pull/4657","diff_url":"https://github.com/helm/helm/pull/4657.diff","patch_url":"https://github.com/helm/helm/pull/4657.patch"},"body":"This change fixes some of the assumptions made in #4590. The bug was triggered because environment variables were parsed well before execution (during `settings.AddFlagsTLS`), causing erroneous behaviour at runtime. By re-introducing `environment.Init()`, Helm can properly parse environment variables at the correct time.\r\n\r\nOne change that had to occur in this PR is the fact that we need to call `settings.Init()` each time we call `settings.AddFlagsTLS()`. This is because each command owns its own FlagSet, so we need to parse each flagset to read and propagate the environment variables correctly.\r\n\r\nI've also added some unit tests that were originally used to verify the work being done in #4651 to ensure this regression doesn't occur again.\r\n\r\ncloses #4660 \r\n\r\nSigned-off-by: Matthew Fisher <matt.fisher@microsoft.com>"},"comment":{"url":"https://api.github.com/repos/helm/helm/issues/comments/422501578","html_url":"https://github.com/helm/helm/pull/4657#issuecomment-422501578","issue_url":"https://api.github.com/repos/helm/helm/issues/4657","id":422501578,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMjUwMTU3OA==","user":{"login":"bacongobbler","id":1360539,"node_id":"MDQ6VXNlcjEzNjA1Mzk=","avatar_url":"https://avatars2.githubusercontent.com/u/1360539?v=4","gravatar_id":"","url":"https://api.github.com/users/bacongobbler","html_url":"https://github.com/bacongobbler","followers_url":"https://api.github.com/users/bacongobbler/followers","following_url":"https://api.github.com/users/bacongobbler/following{/other_user}","gists_url":"https://api.github.com/users/bacongobbler/gists{/gist_id}","starred_url":"https://api.github.com/users/bacongobbler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bacongobbler/subscriptions","organizations_url":"https://api.github.com/users/bacongobbler/orgs","repos_url":"https://api.github.com/users/bacongobbler/repos","events_url":"https://api.github.com/users/bacongobbler/events{/privacy}","received_events_url":"https://api.github.com/users/bacongobbler/received_events","type":"User","site_admin":false},"created_at":"2018-09-18T18:36:12Z","updated_at":"2018-09-18T18:36:12Z","author_association":"MEMBER","body":"k, fixed"}}
{"actor":{"display_login":"bacongobbler"}}