{"action":"created","issue":{"url":"https://api.github.com/repos/pmem/libpmemobj-cpp/issues/107","repository_url":"https://api.github.com/repos/pmem/libpmemobj-cpp","labels_url":"https://api.github.com/repos/pmem/libpmemobj-cpp/issues/107/labels{/name}","comments_url":"https://api.github.com/repos/pmem/libpmemobj-cpp/issues/107/comments","events_url":"https://api.github.com/repos/pmem/libpmemobj-cpp/issues/107/events","html_url":"https://github.com/pmem/libpmemobj-cpp/pull/107","id":380663945,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwODA4MDM5","number":107,"title":"Vector skeleton","user":{"login":"szyrom","id":12031346,"node_id":"MDQ6VXNlcjEyMDMxMzQ2","avatar_url":"https://avatars2.githubusercontent.com/u/12031346?v=4","gravatar_id":"","url":"https://api.github.com/users/szyrom","html_url":"https://github.com/szyrom","followers_url":"https://api.github.com/users/szyrom/followers","following_url":"https://api.github.com/users/szyrom/following{/other_user}","gists_url":"https://api.github.com/users/szyrom/gists{/gist_id}","starred_url":"https://api.github.com/users/szyrom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szyrom/subscriptions","organizations_url":"https://api.github.com/users/szyrom/orgs","repos_url":"https://api.github.com/users/szyrom/repos","events_url":"https://api.github.com/users/szyrom/events{/privacy}","received_events_url":"https://api.github.com/users/szyrom/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-11-14T11:53:06Z","updated_at":"2018-11-26T16:12:19Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/pmem/libpmemobj-cpp/pulls/107","html_url":"https://github.com/pmem/libpmemobj-cpp/pull/107","diff_url":"https://github.com/pmem/libpmemobj-cpp/pull/107.diff","patch_url":"https://github.com/pmem/libpmemobj-cpp/pull/107.patch"},"body":"- add pmem::obj::experimental::vector container skeleton with private methods, default ctor, empty() and max_size() methods\r\n- add libcxx default ctor test\r\n- port provided libcxx tests to pmem::obj::experimental::vector usage\r\n- add private methods tests\r\n\r\nthis pull request requires following pull request to be merged:\r\nhttps://github.com/pmem/libpmemobj-cpp/pull/104\r\nhttps://github.com/pmem/libpmemobj-cpp/pull/95\r\n\r\nedit:\r\nwe need support of Valgrind annotations before we can finish implementation of vector skeleton:\r\nhttps://github.com/pmem/libpmemobj-cpp/pull/116\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/pmem/libpmemobj-cpp/107)\r\n<!-- Reviewable:end -->\r\n"},"comment":{"url":"https://api.github.com/repos/pmem/libpmemobj-cpp/issues/comments/441697450","html_url":"https://github.com/pmem/libpmemobj-cpp/pull/107#issuecomment-441697450","issue_url":"https://api.github.com/repos/pmem/libpmemobj-cpp/issues/107","id":441697450,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MTY5NzQ1MA==","user":{"login":"codecov[bot]","id":22429695,"node_id":"MDM6Qm90MjI0Mjk2OTU=","avatar_url":"https://avatars2.githubusercontent.com/in/254?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov%5Bbot%5D","html_url":"https://github.com/apps/codecov","followers_url":"https://api.github.com/users/codecov%5Bbot%5D/followers","following_url":"https://api.github.com/users/codecov%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/codecov%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/codecov%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/codecov%5Bbot%5D/repos","events_url":"https://api.github.com/users/codecov%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/codecov%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-11-26T16:12:19Z","updated_at":"2018-11-26T16:12:19Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/pmem/libpmemobj-cpp/pull/107?src=pr&el=h1) Report\n> Merging [#107](https://codecov.io/gh/pmem/libpmemobj-cpp/pull/107?src=pr&el=desc) into [master](https://codecov.io/gh/pmem/libpmemobj-cpp/commit/0698166bb2f9e194f822081388f0efaa2a41dbf4?src=pr&el=desc) will **increase** coverage by `0.07%`.\n> The diff coverage is `91.3%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/pmem/libpmemobj-cpp/pull/107/graphs/tree.svg?width=650&token=YSdAG9N8v2&height=150&src=pr)](https://codecov.io/gh/pmem/libpmemobj-cpp/pull/107?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff             @@\n##           master     #107      +/-   ##\n==========================================\n+ Coverage   90.73%   90.81%   +0.07%     \n==========================================\n  Files          27       27              \n  Lines        1036     1045       +9     \n==========================================\n+ Hits          940      949       +9     \n  Misses         96       96\n```\n\n| Flag | Coverage Δ | |\n|---|---|---|\n| #tests_clang_debug_cpp17 | `56.3% <100%> (-6.63%)` | :arrow_down: |\n| #tests_clang_release | `55.45% <100%> (-7.25%)` | :arrow_down: |\n| #tests_gcc_debug | `93.01% <91.3%> (-0.29%)` | :arrow_down: |\n| #tests_gcc_release_cpp17 | `88.56% <87.87%> (-0.69%)` | :arrow_down: |\n\n| [Impacted Files](https://codecov.io/gh/pmem/libpmemobj-cpp/pull/107?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [include/libpmemobj++/experimental/vector.hpp](https://codecov.io/gh/pmem/libpmemobj-cpp/pull/107/diff?src=pr&el=tree#diff-aW5jbHVkZS9saWJwbWVtb2JqKysvZXhwZXJpbWVudGFsL3ZlY3Rvci5ocHA=) | `91.3% <91.3%> (ø)` | |\n| [...lude/libpmemobj++/make\\_persistent\\_array\\_atomic.hpp](https://codecov.io/gh/pmem/libpmemobj-cpp/pull/107/diff?src=pr&el=tree#diff-aW5jbHVkZS9saWJwbWVtb2JqKysvbWFrZV9wZXJzaXN0ZW50X2FycmF5X2F0b21pYy5ocHA=) | `94.73% <0%> (-5.27%)` | :arrow_down: |\n| [include/libpmemobj++/detail/pexceptions.hpp](https://codecov.io/gh/pmem/libpmemobj-cpp/pull/107/diff?src=pr&el=tree#diff-aW5jbHVkZS9saWJwbWVtb2JqKysvZGV0YWlsL3BleGNlcHRpb25zLmhwcA==) | `71.42% <0%> (-3.58%)` | :arrow_down: |\n| [include/libpmemobj++/pool.hpp](https://codecov.io/gh/pmem/libpmemobj-cpp/pull/107/diff?src=pr&el=tree#diff-aW5jbHVkZS9saWJwbWVtb2JqKysvcG9vbC5ocHA=) | `96.55% <0%> (-0.68%)` | :arrow_down: |\n| [include/libpmemobj++/detail/ctl.hpp](https://codecov.io/gh/pmem/libpmemobj-cpp/pull/107/diff?src=pr&el=tree#diff-aW5jbHVkZS9saWJwbWVtb2JqKysvZGV0YWlsL2N0bC5ocHA=) | | |\n| [include/libpmemobj++/transaction.hpp](https://codecov.io/gh/pmem/libpmemobj-cpp/pull/107/diff?src=pr&el=tree#diff-aW5jbHVkZS9saWJwbWVtb2JqKysvdHJhbnNhY3Rpb24uaHBw) | `81.08% <0%> (+1.59%)` | :arrow_up: |\n| [include/libpmemobj++/detail/life.hpp](https://codecov.io/gh/pmem/libpmemobj-cpp/pull/107/diff?src=pr&el=tree#diff-aW5jbHVkZS9saWJwbWVtb2JqKysvZGV0YWlsL2xpZmUuaHBw) | `100% <0%> (+7.69%)` | :arrow_up: |\n| [include/libpmemobj++/make\\_persistent.hpp](https://codecov.io/gh/pmem/libpmemobj-cpp/pull/107/diff?src=pr&el=tree#diff-aW5jbHVkZS9saWJwbWVtb2JqKysvbWFrZV9wZXJzaXN0ZW50LmhwcA==) | `84.21% <0%> (+8.02%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/pmem/libpmemobj-cpp/pull/107?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/pmem/libpmemobj-cpp/pull/107?src=pr&el=footer). Last update [0698166...630600b](https://codecov.io/gh/pmem/libpmemobj-cpp/pull/107?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov"}}