{"action":"created","comment":{"url":"https://api.github.com/repos/supercollider/supercollider/pulls/comments/171428164","pull_request_review_id":100276778,"id":171428164,"diff_hunk":"@@ -1326,6 +1326,74 @@ int prPipeOpen(struct VMGlobals *g, int numArgsPushed)\n \treturn errNone;\n }\n \n+int prPipeOpenArgv(struct VMGlobals *g, int numArgsPushed)\n+{\n+\tPyrSlot *a, *b, *c;\n+\tchar mode[12];\n+\n+\ta = g->sp - 2;\n+\tb = g->sp - 1; //argv\n+\tc = g->sp;     //mode\n+\n+\tif (NotObj(b)) return errWrongType;\n+\n+\tif (NotObj(c) || !isKindOf(slotRawObject(c), class_string))\n+\t\treturn errWrongType;\n+\tif (slotRawObject(c)->size > 11) return errFailed;\n+\n+\tPyrFile *pfile = (PyrFile*)slotRawObject(a);\n+\n+\tPyrObject *obj = slotRawObject(b);","path":"lang/LangPrimSource/PyrFilePrim.cpp","position":21,"original_position":21,"commit_id":"51f232e9b8eebdae80040fb80a04da8eaf60938c","original_commit_id":"51f232e9b8eebdae80040fb80a04da8eaf60938c","user":{"login":"brianlheim","id":15369640,"avatar_url":"https://avatars3.githubusercontent.com/u/15369640?v=4","gravatar_id":"","url":"https://api.github.com/users/brianlheim","html_url":"https://github.com/brianlheim","followers_url":"https://api.github.com/users/brianlheim/followers","following_url":"https://api.github.com/users/brianlheim/following{/other_user}","gists_url":"https://api.github.com/users/brianlheim/gists{/gist_id}","starred_url":"https://api.github.com/users/brianlheim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianlheim/subscriptions","organizations_url":"https://api.github.com/users/brianlheim/orgs","repos_url":"https://api.github.com/users/brianlheim/repos","events_url":"https://api.github.com/users/brianlheim/events{/privacy}","received_events_url":"https://api.github.com/users/brianlheim/received_events","type":"User","site_admin":false},"body":"could use a more descriptive name than `obj` here, maybe `argvColl` since it's supposed to be a collection containing `argv`.","created_at":"2018-03-01T00:10:59Z","updated_at":"2018-03-01T00:13:52Z","html_url":"https://github.com/supercollider/supercollider/pull/3539#discussion_r171428164","pull_request_url":"https://api.github.com/repos/supercollider/supercollider/pulls/3539","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/supercollider/supercollider/pulls/comments/171428164"},"html":{"href":"https://github.com/supercollider/supercollider/pull/3539#discussion_r171428164"},"pull_request":{"href":"https://api.github.com/repos/supercollider/supercollider/pulls/3539"}}},"pull_request":{"url":"https://api.github.com/repos/supercollider/supercollider/pulls/3539","id":171332045,"html_url":"https://github.com/supercollider/supercollider/pull/3539","diff_url":"https://github.com/supercollider/supercollider/pull/3539.diff","patch_url":"https://github.com/supercollider/supercollider/pull/3539.patch","issue_url":"https://api.github.com/repos/supercollider/supercollider/issues/3539","number":3539,"state":"open","locked":false,"title":"Add SequenceableCollection#unixCmdGetStdOut","user":{"login":"miguel-negrao","id":382777,"avatar_url":"https://avatars3.githubusercontent.com/u/382777?v=4","gravatar_id":"","url":"https://api.github.com/users/miguel-negrao","html_url":"https://github.com/miguel-negrao","followers_url":"https://api.github.com/users/miguel-negrao/followers","following_url":"https://api.github.com/users/miguel-negrao/following{/other_user}","gists_url":"https://api.github.com/users/miguel-negrao/gists{/gist_id}","starred_url":"https://api.github.com/users/miguel-negrao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miguel-negrao/subscriptions","organizations_url":"https://api.github.com/users/miguel-negrao/orgs","repos_url":"https://api.github.com/users/miguel-negrao/repos","events_url":"https://api.github.com/users/miguel-negrao/events{/privacy}","received_events_url":"https://api.github.com/users/miguel-negrao/received_events","type":"User","site_admin":false},"body":"This adds a method unixCmdGetStdOut to SequenceableCollection similar to the method in String. Internally it uses Pipe#*argv . A new primitive was added to Pipe for this. Also added documentation.","created_at":"2018-02-26T10:17:03Z","updated_at":"2018-03-01T00:13:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"75cdd337b18fe9610fac763dd17dc3f5c822102c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/supercollider/supercollider/pulls/3539/commits","review_comments_url":"https://api.github.com/repos/supercollider/supercollider/pulls/3539/comments","review_comment_url":"https://api.github.com/repos/supercollider/supercollider/pulls/comments{/number}","comments_url":"https://api.github.com/repos/supercollider/supercollider/issues/3539/comments","statuses_url":"https://api.github.com/repos/supercollider/supercollider/statuses/51f232e9b8eebdae80040fb80a04da8eaf60938c","head":{"label":"miguel-negrao:sequencableCollectionUnixCmdGetStdOut","ref":"sequencableCollectionUnixCmdGetStdOut","sha":"51f232e9b8eebdae80040fb80a04da8eaf60938c","user":{"login":"miguel-negrao","id":382777,"avatar_url":"https://avatars3.githubusercontent.com/u/382777?v=4","gravatar_id":"","url":"https://api.github.com/users/miguel-negrao","html_url":"https://github.com/miguel-negrao","followers_url":"https://api.github.com/users/miguel-negrao/followers","following_url":"https://api.github.com/users/miguel-negrao/following{/other_user}","gists_url":"https://api.github.com/users/miguel-negrao/gists{/gist_id}","starred_url":"https://api.github.com/users/miguel-negrao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miguel-negrao/subscriptions","organizations_url":"https://api.github.com/users/miguel-negrao/orgs","repos_url":"https://api.github.com/users/miguel-negrao/repos","events_url":"https://api.github.com/users/miguel-negrao/events{/privacy}","received_events_url":"https://api.github.com/users/miguel-negrao/received_events","type":"User","site_admin":false},"repo":{"id":4271470,"name":"supercollider","full_name":"miguel-negrao/supercollider","owner":{"login":"miguel-negrao","id":382777,"avatar_url":"https://avatars3.githubusercontent.com/u/382777?v=4","gravatar_id":"","url":"https://api.github.com/users/miguel-negrao","html_url":"https://github.com/miguel-negrao","followers_url":"https://api.github.com/users/miguel-negrao/followers","following_url":"https://api.github.com/users/miguel-negrao/following{/other_user}","gists_url":"https://api.github.com/users/miguel-negrao/gists{/gist_id}","starred_url":"https://api.github.com/users/miguel-negrao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miguel-negrao/subscriptions","organizations_url":"https://api.github.com/users/miguel-negrao/orgs","repos_url":"https://api.github.com/users/miguel-negrao/repos","events_url":"https://api.github.com/users/miguel-negrao/events{/privacy}","received_events_url":"https://api.github.com/users/miguel-negrao/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/miguel-negrao/supercollider","description":"an environment and programming language for real time audio synthesis and algorithmic composition","fork":true,"url":"https://api.github.com/repos/miguel-negrao/supercollider","forks_url":"https://api.github.com/repos/miguel-negrao/supercollider/forks","keys_url":"https://api.github.com/repos/miguel-negrao/supercollider/keys{/key_id}","collaborators_url":"https://api.github.com/repos/miguel-negrao/supercollider/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/miguel-negrao/supercollider/teams","hooks_url":"https://api.github.com/repos/miguel-negrao/supercollider/hooks","issue_events_url":"https://api.github.com/repos/miguel-negrao/supercollider/issues/events{/number}","events_url":"https://api.github.com/repos/miguel-negrao/supercollider/events","assignees_url":"https://api.github.com/repos/miguel-negrao/supercollider/assignees{/user}","branches_url":"https://api.github.com/repos/miguel-negrao/supercollider/branches{/branch}","tags_url":"https://api.github.com/repos/miguel-negrao/supercollider/tags","blobs_url":"https://api.github.com/repos/miguel-negrao/supercollider/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/miguel-negrao/supercollider/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/miguel-negrao/supercollider/git/refs{/sha}","trees_url":"https://api.github.com/repos/miguel-negrao/supercollider/git/trees{/sha}","statuses_url":"https://api.github.com/repos/miguel-negrao/supercollider/statuses/{sha}","languages_url":"https://api.github.com/repos/miguel-negrao/supercollider/languages","stargazers_url":"https://api.github.com/repos/miguel-negrao/supercollider/stargazers","contributors_url":"https://api.github.com/repos/miguel-negrao/supercollider/contributors","subscribers_url":"https://api.github.com/repos/miguel-negrao/supercollider/subscribers","subscription_url":"https://api.github.com/repos/miguel-negrao/supercollider/subscription","commits_url":"https://api.github.com/repos/miguel-negrao/supercollider/commits{/sha}","git_commits_url":"https://api.github.com/repos/miguel-negrao/supercollider/git/commits{/sha}","comments_url":"https://api.github.com/repos/miguel-negrao/supercollider/comments{/number}","issue_comment_url":"https://api.github.com/repos/miguel-negrao/supercollider/issues/comments{/number}","contents_url":"https://api.github.com/repos/miguel-negrao/supercollider/contents/{+path}","compare_url":"https://api.github.com/repos/miguel-negrao/supercollider/compare/{base}...{head}","merges_url":"https://api.github.com/repos/miguel-negrao/supercollider/merges","archive_url":"https://api.github.com/repos/miguel-negrao/supercollider/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/miguel-negrao/supercollider/downloads","issues_url":"https://api.github.com/repos/miguel-negrao/supercollider/issues{/number}","pulls_url":"https://api.github.com/repos/miguel-negrao/supercollider/pulls{/number}","milestones_url":"https://api.github.com/repos/miguel-negrao/supercollider/milestones{/number}","notifications_url":"https://api.github.com/repos/miguel-negrao/supercollider/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/miguel-negrao/supercollider/labels{/name}","releases_url":"https://api.github.com/repos/miguel-negrao/supercollider/releases{/id}","deployments_url":"https://api.github.com/repos/miguel-negrao/supercollider/deployments","created_at":"2012-05-09T12:35:14Z","updated_at":"2018-01-14T12:53:51Z","pushed_at":"2018-02-28T20:41:25Z","git_url":"git://github.com/miguel-negrao/supercollider.git","ssh_url":"git@github.com:miguel-negrao/supercollider.git","clone_url":"https://github.com/miguel-negrao/supercollider.git","svn_url":"https://github.com/miguel-negrao/supercollider","homepage":null,"size":134339,"stargazers_count":3,"watchers_count":3,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":0,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"supercollider:develop","ref":"develop","sha":"691c17931da1042bc8316cac5ea4d51c5f88fd33","user":{"login":"supercollider","id":1706741,"avatar_url":"https://avatars1.githubusercontent.com/u/1706741?v=4","gravatar_id":"","url":"https://api.github.com/users/supercollider","html_url":"https://github.com/supercollider","followers_url":"https://api.github.com/users/supercollider/followers","following_url":"https://api.github.com/users/supercollider/following{/other_user}","gists_url":"https://api.github.com/users/supercollider/gists{/gist_id}","starred_url":"https://api.github.com/users/supercollider/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/supercollider/subscriptions","organizations_url":"https://api.github.com/users/supercollider/orgs","repos_url":"https://api.github.com/users/supercollider/repos","events_url":"https://api.github.com/users/supercollider/events{/privacy}","received_events_url":"https://api.github.com/users/supercollider/received_events","type":"Organization","site_admin":false},"repo":{"id":4228314,"name":"supercollider","full_name":"supercollider/supercollider","owner":{"login":"supercollider","id":1706741,"avatar_url":"https://avatars1.githubusercontent.com/u/1706741?v=4","gravatar_id":"","url":"https://api.github.com/users/supercollider","html_url":"https://github.com/supercollider","followers_url":"https://api.github.com/users/supercollider/followers","following_url":"https://api.github.com/users/supercollider/following{/other_user}","gists_url":"https://api.github.com/users/supercollider/gists{/gist_id}","starred_url":"https://api.github.com/users/supercollider/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/supercollider/subscriptions","organizations_url":"https://api.github.com/users/supercollider/orgs","repos_url":"https://api.github.com/users/supercollider/repos","events_url":"https://api.github.com/users/supercollider/events{/privacy}","received_events_url":"https://api.github.com/users/supercollider/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/supercollider/supercollider","description":"An audio server, programming language, and IDE for sound synthesis and algorithmic composition.","fork":false,"url":"https://api.github.com/repos/supercollider/supercollider","forks_url":"https://api.github.com/repos/supercollider/supercollider/forks","keys_url":"https://api.github.com/repos/supercollider/supercollider/keys{/key_id}","collaborators_url":"https://api.github.com/repos/supercollider/supercollider/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/supercollider/supercollider/teams","hooks_url":"https://api.github.com/repos/supercollider/supercollider/hooks","issue_events_url":"https://api.github.com/repos/supercollider/supercollider/issues/events{/number}","events_url":"https://api.github.com/repos/supercollider/supercollider/events","assignees_url":"https://api.github.com/repos/supercollider/supercollider/assignees{/user}","branches_url":"https://api.github.com/repos/supercollider/supercollider/branches{/branch}","tags_url":"https://api.github.com/repos/supercollider/supercollider/tags","blobs_url":"https://api.github.com/repos/supercollider/supercollider/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/supercollider/supercollider/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/supercollider/supercollider/git/refs{/sha}","trees_url":"https://api.github.com/repos/supercollider/supercollider/git/trees{/sha}","statuses_url":"https://api.github.com/repos/supercollider/supercollider/statuses/{sha}","languages_url":"https://api.github.com/repos/supercollider/supercollider/languages","stargazers_url":"https://api.github.com/repos/supercollider/supercollider/stargazers","contributors_url":"https://api.github.com/repos/supercollider/supercollider/contributors","subscribers_url":"https://api.github.com/repos/supercollider/supercollider/subscribers","subscription_url":"https://api.github.com/repos/supercollider/supercollider/subscription","commits_url":"https://api.github.com/repos/supercollider/supercollider/commits{/sha}","git_commits_url":"https://api.github.com/repos/supercollider/supercollider/git/commits{/sha}","comments_url":"https://api.github.com/repos/supercollider/supercollider/comments{/number}","issue_comment_url":"https://api.github.com/repos/supercollider/supercollider/issues/comments{/number}","contents_url":"https://api.github.com/repos/supercollider/supercollider/contents/{+path}","compare_url":"https://api.github.com/repos/supercollider/supercollider/compare/{base}...{head}","merges_url":"https://api.github.com/repos/supercollider/supercollider/merges","archive_url":"https://api.github.com/repos/supercollider/supercollider/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/supercollider/supercollider/downloads","issues_url":"https://api.github.com/repos/supercollider/supercollider/issues{/number}","pulls_url":"https://api.github.com/repos/supercollider/supercollider/pulls{/number}","milestones_url":"https://api.github.com/repos/supercollider/supercollider/milestones{/number}","notifications_url":"https://api.github.com/repos/supercollider/supercollider/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/supercollider/supercollider/labels{/name}","releases_url":"https://api.github.com/repos/supercollider/supercollider/releases{/id}","deployments_url":"https://api.github.com/repos/supercollider/supercollider/deployments","created_at":"2012-05-04T19:24:51Z","updated_at":"2018-02-27T14:16:51Z","pushed_at":"2018-02-28T20:41:27Z","git_url":"git://github.com/supercollider/supercollider.git","ssh_url":"git@github.com:supercollider/supercollider.git","clone_url":"https://github.com/supercollider/supercollider.git","svn_url":"https://github.com/supercollider/supercollider","homepage":"http://supercollider.github.io","size":154097,"stargazers_count":1832,"watchers_count":1832,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":349,"mirror_url":null,"archived":false,"open_issues_count":592,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":349,"open_issues":592,"watchers":1832,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/supercollider/supercollider/pulls/3539"},"html":{"href":"https://github.com/supercollider/supercollider/pull/3539"},"issue":{"href":"https://api.github.com/repos/supercollider/supercollider/issues/3539"},"comments":{"href":"https://api.github.com/repos/supercollider/supercollider/issues/3539/comments"},"review_comments":{"href":"https://api.github.com/repos/supercollider/supercollider/pulls/3539/comments"},"review_comment":{"href":"https://api.github.com/repos/supercollider/supercollider/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/supercollider/supercollider/pulls/3539/commits"},"statuses":{"href":"https://api.github.com/repos/supercollider/supercollider/statuses/51f232e9b8eebdae80040fb80a04da8eaf60938c"}},"author_association":"OWNER"}}
{"actor":{"display_login":"brianlheim"}}