{"action":"created","issue":{"url":"https://api.github.com/repos/wordbots/wordbots-core/issues/571","repository_url":"https://api.github.com/repos/wordbots/wordbots-core","labels_url":"https://api.github.com/repos/wordbots/wordbots-core/issues/571/labels{/name}","comments_url":"https://api.github.com/repos/wordbots/wordbots-core/issues/571/comments","events_url":"https://api.github.com/repos/wordbots/wordbots-core/issues/571/events","html_url":"https://github.com/wordbots/wordbots-core/issues/571","id":297702740,"number":571,"title":"End of turn effects don't correctly trigger a player win","user":{"login":"john-patterson","id":17716252,"avatar_url":"https://avatars3.githubusercontent.com/u/17716252?v=4","gravatar_id":"","url":"https://api.github.com/users/john-patterson","html_url":"https://github.com/john-patterson","followers_url":"https://api.github.com/users/john-patterson/followers","following_url":"https://api.github.com/users/john-patterson/following{/other_user}","gists_url":"https://api.github.com/users/john-patterson/gists{/gist_id}","starred_url":"https://api.github.com/users/john-patterson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/john-patterson/subscriptions","organizations_url":"https://api.github.com/users/john-patterson/orgs","repos_url":"https://api.github.com/users/john-patterson/repos","events_url":"https://api.github.com/users/john-patterson/events{/privacy}","received_events_url":"https://api.github.com/users/john-patterson/received_events","type":"User","site_admin":false},"labels":[{"id":487794179,"url":"https://api.github.com/repos/wordbots/wordbots-core/labels/bug","name":"bug","color":"ee0701","default":true}],"state":"open","locked":false,"assignee":{"login":"john-patterson","id":17716252,"avatar_url":"https://avatars3.githubusercontent.com/u/17716252?v=4","gravatar_id":"","url":"https://api.github.com/users/john-patterson","html_url":"https://github.com/john-patterson","followers_url":"https://api.github.com/users/john-patterson/followers","following_url":"https://api.github.com/users/john-patterson/following{/other_user}","gists_url":"https://api.github.com/users/john-patterson/gists{/gist_id}","starred_url":"https://api.github.com/users/john-patterson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/john-patterson/subscriptions","organizations_url":"https://api.github.com/users/john-patterson/orgs","repos_url":"https://api.github.com/users/john-patterson/repos","events_url":"https://api.github.com/users/john-patterson/events{/privacy}","received_events_url":"https://api.github.com/users/john-patterson/received_events","type":"User","site_admin":false},"assignees":[{"login":"john-patterson","id":17716252,"avatar_url":"https://avatars3.githubusercontent.com/u/17716252?v=4","gravatar_id":"","url":"https://api.github.com/users/john-patterson","html_url":"https://github.com/john-patterson","followers_url":"https://api.github.com/users/john-patterson/followers","following_url":"https://api.github.com/users/john-patterson/following{/other_user}","gists_url":"https://api.github.com/users/john-patterson/gists{/gist_id}","starred_url":"https://api.github.com/users/john-patterson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/john-patterson/subscriptions","organizations_url":"https://api.github.com/users/john-patterson/orgs","repos_url":"https://api.github.com/users/john-patterson/repos","events_url":"https://api.github.com/users/john-patterson/events{/privacy}","received_events_url":"https://api.github.com/users/john-patterson/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-02-16T07:39:53Z","updated_at":"2018-02-17T21:18:37Z","closed_at":null,"author_association":"COLLABORATOR","body":"Given an enemy kernel with health K. If a player has a card with an effect like \"deal M damage to the opponent at the end of your turn\" where M >= K, I would expect this to result in a win for the player. Instead the enemy is given one more turn, and it is at the end of the player's next turn that the win is decided. \r\n\r\nThere's another interesting edge case to consider wherein both players have cards to this effect and a sufficient amount of health to die in one turn. Player A will defeat the kernel of player B at the end of their turn, and then player B will defeat the kernel of player A at the end of player B's turn. Presumably this would result in a win for player A."},"comment":{"url":"https://api.github.com/repos/wordbots/wordbots-core/issues/comments/366472141","html_url":"https://github.com/wordbots/wordbots-core/issues/571#issuecomment-366472141","issue_url":"https://api.github.com/repos/wordbots/wordbots-core/issues/571","id":366472141,"user":{"login":"AlexNisnevich","id":415965,"avatar_url":"https://avatars0.githubusercontent.com/u/415965?v=4","gravatar_id":"","url":"https://api.github.com/users/AlexNisnevich","html_url":"https://github.com/AlexNisnevich","followers_url":"https://api.github.com/users/AlexNisnevich/followers","following_url":"https://api.github.com/users/AlexNisnevich/following{/other_user}","gists_url":"https://api.github.com/users/AlexNisnevich/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexNisnevich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexNisnevich/subscriptions","organizations_url":"https://api.github.com/users/AlexNisnevich/orgs","repos_url":"https://api.github.com/users/AlexNisnevich/repos","events_url":"https://api.github.com/users/AlexNisnevich/events{/privacy}","received_events_url":"https://api.github.com/users/AlexNisnevich/received_events","type":"User","site_admin":false},"created_at":"2018-02-17T21:18:37Z","updated_at":"2018-02-17T21:18:37Z","author_association":"OWNER","body":"Alternatively, maybe the `triggerEvent` method should have a `checkVictoryConditions` call at the end?"}}
{"actor":{"display_login":"AlexNisnevich"}}