{"action":"created","comment":{"url":"https://api.github.com/repos/material-components/material-components-web/pulls/comments/224102446","pull_request_review_id":163387617,"id":224102446,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDEwMjQ0Ng==","diff_hunk":"@@ -77,47 +84,89 @@ class MDCSelectFoundation extends MDCFoundation {\n     super(Object.assign(MDCSelectFoundation.defaultAdapter, adapter));\n   }\n \n-  /**\n-   * Updates the styles of the select to show the disasbled state.\n-   * @param {boolean} disabled\n-   */\n-  updateDisabledStyle(disabled) {\n-    const {DISABLED} = MDCSelectFoundation.cssClasses;\n-    if (disabled) {\n-      this.adapter_.addClass(DISABLED);\n-    } else {\n-      this.adapter_.removeClass(DISABLED);\n-    }\n+  setSelectedIndex(index) {\n+    this.adapter_.setSelectedIndex(index);\n+    this.adapter_.closeMenu();\n+    const didChange = true;\n+    this.handleChange(didChange);\n+  }\n+\n+  setValue(value) {\n+    this.adapter_.setValue(value);\n+    const didChange = true;\n+    this.handleChange(didChange);\n+  }\n+\n+  getValue() {\n+    return this.adapter_.getValue();\n+  }\n+\n+  setDisabled(isDisabled) {","path":"packages/mdc-select/foundation.js","position":55,"original_position":55,"commit_id":"b88e05c41eca02522ca8a575266cab2daead1915","original_commit_id":"b88e05c41eca02522ca8a575266cab2daead1915","user":{"login":"kfranqueiro","id":398379,"node_id":"MDQ6VXNlcjM5ODM3OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/398379?v=4","gravatar_id":"","url":"https://api.github.com/users/kfranqueiro","html_url":"https://github.com/kfranqueiro","followers_url":"https://api.github.com/users/kfranqueiro/followers","following_url":"https://api.github.com/users/kfranqueiro/following{/other_user}","gists_url":"https://api.github.com/users/kfranqueiro/gists{/gist_id}","starred_url":"https://api.github.com/users/kfranqueiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kfranqueiro/subscriptions","organizations_url":"https://api.github.com/users/kfranqueiro/orgs","repos_url":"https://api.github.com/users/kfranqueiro/repos","events_url":"https://api.github.com/users/kfranqueiro/events{/privacy}","received_events_url":"https://api.github.com/users/kfranqueiro/received_events","type":"User","site_admin":false},"body":"I noticed you removed the code that adds/removes a CSS class in `setDisabled`... isn't that still needed?\r\n\r\nIt looks like you baked in the root class addition/removal into the adapter for enhanced only, but AFAICT it is still needed for both variants, so I'm not sure why that was removed from the foundation.","created_at":"2018-10-10T14:32:37Z","updated_at":"2018-10-10T14:55:55Z","html_url":"https://github.com/material-components/material-components-web/pull/3608#discussion_r224102446","pull_request_url":"https://api.github.com/repos/material-components/material-components-web/pulls/3608","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/material-components/material-components-web/pulls/comments/224102446"},"html":{"href":"https://github.com/material-components/material-components-web/pull/3608#discussion_r224102446"},"pull_request":{"href":"https://api.github.com/repos/material-components/material-components-web/pulls/3608"}}},"pull_request":{"url":"https://api.github.com/repos/material-components/material-components-web/pulls/3608","id":217349383,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3MzQ5Mzgz","html_url":"https://github.com/material-components/material-components-web/pull/3608","diff_url":"https://github.com/material-components/material-components-web/pull/3608.diff","patch_url":"https://github.com/material-components/material-components-web/pull/3608.patch","issue_url":"https://api.github.com/repos/material-components/material-components-web/issues/3608","number":3608,"state":"open","locked":false,"title":"feat(select): Add enhanced select","user":{"login":"williamernest","id":34519388,"node_id":"MDQ6VXNlcjM0NTE5Mzg4","avatar_url":"https://avatars3.githubusercontent.com/u/34519388?v=4","gravatar_id":"","url":"https://api.github.com/users/williamernest","html_url":"https://github.com/williamernest","followers_url":"https://api.github.com/users/williamernest/followers","following_url":"https://api.github.com/users/williamernest/following{/other_user}","gists_url":"https://api.github.com/users/williamernest/gists{/gist_id}","starred_url":"https://api.github.com/users/williamernest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/williamernest/subscriptions","organizations_url":"https://api.github.com/users/williamernest/orgs","repos_url":"https://api.github.com/users/williamernest/repos","events_url":"https://api.github.com/users/williamernest/events{/privacy}","received_events_url":"https://api.github.com/users/williamernest/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-09-21T17:21:00Z","updated_at":"2018-10-10T14:55:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d456a34ff41df2072d087686524e1835a3798441","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1036895551,"node_id":"MDU6TGFiZWwxMDM2ODk1NTUx","url":"https://api.github.com/repos/material-components/material-components-web/labels/cla:%20yes","name":"cla: yes","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/material-components/material-components-web/pulls/3608/commits","review_comments_url":"https://api.github.com/repos/material-components/material-components-web/pulls/3608/comments","review_comment_url":"https://api.github.com/repos/material-components/material-components-web/pulls/comments{/number}","comments_url":"https://api.github.com/repos/material-components/material-components-web/issues/3608/comments","statuses_url":"https://api.github.com/repos/material-components/material-components-web/statuses/b88e05c41eca02522ca8a575266cab2daead1915","head":{"label":"material-components:feat/select/enhanced-select","ref":"feat/select/enhanced-select","sha":"b88e05c41eca02522ca8a575266cab2daead1915","user":{"login":"material-components","id":19478152,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDc4MTUy","avatar_url":"https://avatars3.githubusercontent.com/u/19478152?v=4","gravatar_id":"","url":"https://api.github.com/users/material-components","html_url":"https://github.com/material-components","followers_url":"https://api.github.com/users/material-components/followers","following_url":"https://api.github.com/users/material-components/following{/other_user}","gists_url":"https://api.github.com/users/material-components/gists{/gist_id}","starred_url":"https://api.github.com/users/material-components/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/material-components/subscriptions","organizations_url":"https://api.github.com/users/material-components/orgs","repos_url":"https://api.github.com/users/material-components/repos","events_url":"https://api.github.com/users/material-components/events{/privacy}","received_events_url":"https://api.github.com/users/material-components/received_events","type":"Organization","site_admin":false},"repo":{"id":75642389,"node_id":"MDEwOlJlcG9zaXRvcnk3NTY0MjM4OQ==","name":"material-components-web","full_name":"material-components/material-components-web","private":false,"owner":{"login":"material-components","id":19478152,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDc4MTUy","avatar_url":"https://avatars3.githubusercontent.com/u/19478152?v=4","gravatar_id":"","url":"https://api.github.com/users/material-components","html_url":"https://github.com/material-components","followers_url":"https://api.github.com/users/material-components/followers","following_url":"https://api.github.com/users/material-components/following{/other_user}","gists_url":"https://api.github.com/users/material-components/gists{/gist_id}","starred_url":"https://api.github.com/users/material-components/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/material-components/subscriptions","organizations_url":"https://api.github.com/users/material-components/orgs","repos_url":"https://api.github.com/users/material-components/repos","events_url":"https://api.github.com/users/material-components/events{/privacy}","received_events_url":"https://api.github.com/users/material-components/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/material-components/material-components-web","description":"Modular and customizable Material Design UI components for the web","fork":false,"url":"https://api.github.com/repos/material-components/material-components-web","forks_url":"https://api.github.com/repos/material-components/material-components-web/forks","keys_url":"https://api.github.com/repos/material-components/material-components-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/material-components/material-components-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/material-components/material-components-web/teams","hooks_url":"https://api.github.com/repos/material-components/material-components-web/hooks","issue_events_url":"https://api.github.com/repos/material-components/material-components-web/issues/events{/number}","events_url":"https://api.github.com/repos/material-components/material-components-web/events","assignees_url":"https://api.github.com/repos/material-components/material-components-web/assignees{/user}","branches_url":"https://api.github.com/repos/material-components/material-components-web/branches{/branch}","tags_url":"https://api.github.com/repos/material-components/material-components-web/tags","blobs_url":"https://api.github.com/repos/material-components/material-components-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/material-components/material-components-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/material-components/material-components-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/material-components/material-components-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/material-components/material-components-web/statuses/{sha}","languages_url":"https://api.github.com/repos/material-components/material-components-web/languages","stargazers_url":"https://api.github.com/repos/material-components/material-components-web/stargazers","contributors_url":"https://api.github.com/repos/material-components/material-components-web/contributors","subscribers_url":"https://api.github.com/repos/material-components/material-components-web/subscribers","subscription_url":"https://api.github.com/repos/material-components/material-components-web/subscription","commits_url":"https://api.github.com/repos/material-components/material-components-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/material-components/material-components-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/material-components/material-components-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/material-components/material-components-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/material-components/material-components-web/contents/{+path}","compare_url":"https://api.github.com/repos/material-components/material-components-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/material-components/material-components-web/merges","archive_url":"https://api.github.com/repos/material-components/material-components-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/material-components/material-components-web/downloads","issues_url":"https://api.github.com/repos/material-components/material-components-web/issues{/number}","pulls_url":"https://api.github.com/repos/material-components/material-components-web/pulls{/number}","milestones_url":"https://api.github.com/repos/material-components/material-components-web/milestones{/number}","notifications_url":"https://api.github.com/repos/material-components/material-components-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/material-components/material-components-web/labels{/name}","releases_url":"https://api.github.com/repos/material-components/material-components-web/releases{/id}","deployments_url":"https://api.github.com/repos/material-components/material-components-web/deployments","created_at":"2016-12-05T16:04:09Z","updated_at":"2018-10-10T14:52:07Z","pushed_at":"2018-10-10T01:58:14Z","git_url":"git://github.com/material-components/material-components-web.git","ssh_url":"git@github.com:material-components/material-components-web.git","clone_url":"https://github.com/material-components/material-components-web.git","svn_url":"https://github.com/material-components/material-components-web","homepage":"https://material.io/develop/","size":70699,"stargazers_count":10532,"watchers_count":10532,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1267,"mirror_url":null,"archived":false,"open_issues_count":321,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1267,"open_issues":321,"watchers":10532,"default_branch":"master"}},"base":{"label":"material-components:feat/select-new","ref":"feat/select-new","sha":"9be1500cb254aa8c619195b45f10bd4bcfd60ef8","user":{"login":"material-components","id":19478152,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDc4MTUy","avatar_url":"https://avatars3.githubusercontent.com/u/19478152?v=4","gravatar_id":"","url":"https://api.github.com/users/material-components","html_url":"https://github.com/material-components","followers_url":"https://api.github.com/users/material-components/followers","following_url":"https://api.github.com/users/material-components/following{/other_user}","gists_url":"https://api.github.com/users/material-components/gists{/gist_id}","starred_url":"https://api.github.com/users/material-components/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/material-components/subscriptions","organizations_url":"https://api.github.com/users/material-components/orgs","repos_url":"https://api.github.com/users/material-components/repos","events_url":"https://api.github.com/users/material-components/events{/privacy}","received_events_url":"https://api.github.com/users/material-components/received_events","type":"Organization","site_admin":false},"repo":{"id":75642389,"node_id":"MDEwOlJlcG9zaXRvcnk3NTY0MjM4OQ==","name":"material-components-web","full_name":"material-components/material-components-web","private":false,"owner":{"login":"material-components","id":19478152,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDc4MTUy","avatar_url":"https://avatars3.githubusercontent.com/u/19478152?v=4","gravatar_id":"","url":"https://api.github.com/users/material-components","html_url":"https://github.com/material-components","followers_url":"https://api.github.com/users/material-components/followers","following_url":"https://api.github.com/users/material-components/following{/other_user}","gists_url":"https://api.github.com/users/material-components/gists{/gist_id}","starred_url":"https://api.github.com/users/material-components/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/material-components/subscriptions","organizations_url":"https://api.github.com/users/material-components/orgs","repos_url":"https://api.github.com/users/material-components/repos","events_url":"https://api.github.com/users/material-components/events{/privacy}","received_events_url":"https://api.github.com/users/material-components/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/material-components/material-components-web","description":"Modular and customizable Material Design UI components for the web","fork":false,"url":"https://api.github.com/repos/material-components/material-components-web","forks_url":"https://api.github.com/repos/material-components/material-components-web/forks","keys_url":"https://api.github.com/repos/material-components/material-components-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/material-components/material-components-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/material-components/material-components-web/teams","hooks_url":"https://api.github.com/repos/material-components/material-components-web/hooks","issue_events_url":"https://api.github.com/repos/material-components/material-components-web/issues/events{/number}","events_url":"https://api.github.com/repos/material-components/material-components-web/events","assignees_url":"https://api.github.com/repos/material-components/material-components-web/assignees{/user}","branches_url":"https://api.github.com/repos/material-components/material-components-web/branches{/branch}","tags_url":"https://api.github.com/repos/material-components/material-components-web/tags","blobs_url":"https://api.github.com/repos/material-components/material-components-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/material-components/material-components-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/material-components/material-components-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/material-components/material-components-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/material-components/material-components-web/statuses/{sha}","languages_url":"https://api.github.com/repos/material-components/material-components-web/languages","stargazers_url":"https://api.github.com/repos/material-components/material-components-web/stargazers","contributors_url":"https://api.github.com/repos/material-components/material-components-web/contributors","subscribers_url":"https://api.github.com/repos/material-components/material-components-web/subscribers","subscription_url":"https://api.github.com/repos/material-components/material-components-web/subscription","commits_url":"https://api.github.com/repos/material-components/material-components-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/material-components/material-components-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/material-components/material-components-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/material-components/material-components-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/material-components/material-components-web/contents/{+path}","compare_url":"https://api.github.com/repos/material-components/material-components-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/material-components/material-components-web/merges","archive_url":"https://api.github.com/repos/material-components/material-components-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/material-components/material-components-web/downloads","issues_url":"https://api.github.com/repos/material-components/material-components-web/issues{/number}","pulls_url":"https://api.github.com/repos/material-components/material-components-web/pulls{/number}","milestones_url":"https://api.github.com/repos/material-components/material-components-web/milestones{/number}","notifications_url":"https://api.github.com/repos/material-components/material-components-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/material-components/material-components-web/labels{/name}","releases_url":"https://api.github.com/repos/material-components/material-components-web/releases{/id}","deployments_url":"https://api.github.com/repos/material-components/material-components-web/deployments","created_at":"2016-12-05T16:04:09Z","updated_at":"2018-10-10T14:52:07Z","pushed_at":"2018-10-10T01:58:14Z","git_url":"git://github.com/material-components/material-components-web.git","ssh_url":"git@github.com:material-components/material-components-web.git","clone_url":"https://github.com/material-components/material-components-web.git","svn_url":"https://github.com/material-components/material-components-web","homepage":"https://material.io/develop/","size":70699,"stargazers_count":10532,"watchers_count":10532,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1267,"mirror_url":null,"archived":false,"open_issues_count":321,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1267,"open_issues":321,"watchers":10532,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/material-components/material-components-web/pulls/3608"},"html":{"href":"https://github.com/material-components/material-components-web/pull/3608"},"issue":{"href":"https://api.github.com/repos/material-components/material-components-web/issues/3608"},"comments":{"href":"https://api.github.com/repos/material-components/material-components-web/issues/3608/comments"},"review_comments":{"href":"https://api.github.com/repos/material-components/material-components-web/pulls/3608/comments"},"review_comment":{"href":"https://api.github.com/repos/material-components/material-components-web/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/material-components/material-components-web/pulls/3608/commits"},"statuses":{"href":"https://api.github.com/repos/material-components/material-components-web/statuses/b88e05c41eca02522ca8a575266cab2daead1915"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kfranqueiro"}}