{"action":"opened","issue":{"url":"https://api.github.com/repos/k3erg/marantz-denon-telnet/issues/4","repository_url":"https://api.github.com/repos/k3erg/marantz-denon-telnet","labels_url":"https://api.github.com/repos/k3erg/marantz-denon-telnet/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/k3erg/marantz-denon-telnet/issues/4/comments","events_url":"https://api.github.com/repos/k3erg/marantz-denon-telnet/issues/4/events","html_url":"https://github.com/k3erg/marantz-denon-telnet/issues/4","id":356642127,"node_id":"MDU6SXNzdWUzNTY2NDIxMjc=","number":4,"title":"setInput callback doesn't pass data parameter on success","user":{"login":"ascl00","id":30010670,"node_id":"MDQ6VXNlcjMwMDEwNjcw","avatar_url":"https://avatars1.githubusercontent.com/u/30010670?v=4","gravatar_id":"","url":"https://api.github.com/users/ascl00","html_url":"https://github.com/ascl00","followers_url":"https://api.github.com/users/ascl00/followers","following_url":"https://api.github.com/users/ascl00/following{/other_user}","gists_url":"https://api.github.com/users/ascl00/gists{/gist_id}","starred_url":"https://api.github.com/users/ascl00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ascl00/subscriptions","organizations_url":"https://api.github.com/users/ascl00/orgs","repos_url":"https://api.github.com/users/ascl00/repos","events_url":"https://api.github.com/users/ascl00/events{/privacy}","received_events_url":"https://api.github.com/users/ascl00/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-09-04T03:38:55Z","updated_at":"2018-09-04T03:38:55Z","closed_at":null,"author_association":"NONE","body":"```\r\nMarantzDenonTelnet.prototype.setInput = function(input, callback, zone) {\r\n    var commandPrefix = (!zone || (zone == 'ZM')) ? 'SI' : zone;\r\n\r\n    this.telnet(commandPrefix + input, function(error, data) {\r\n        if (!error) {\r\n            callback(null);\r\n        } else {\r\n            callback(error);\r\n        }\r\n    });\r\n};\r\n```\r\n\r\nEvery other callback passes data back on success, so this method should be defined as:\r\n```\r\nMarantzDenonTelnet.prototype.setInput = function(input, callback, zone) {\r\n    var commandPrefix = (!zone || (zone == 'ZM')) ? 'SI' : zone;\r\n\r\n    this.telnet(commandPrefix + input, function(error, data) {\r\n        if (!error) {\r\n            callback(null, data);\r\n        } else {\r\n            callback(error);\r\n        }\r\n    });\r\n};\r\n```\r\n"}}
{"actor":{"display_login":"ascl00"}}