{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/vsts-tasks/pulls/comments/192994234","pull_request_review_id":125873063,"id":192994234,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5Mjk5NDIzNA==","diff_hunk":"@@ -172,29 +196,10 @@ function Publish-UpgradedServiceFabricApplication\n         throw\n     }\n \n-    # If ApplicationName is not specified on command line get application name from Application parameter file.\n-    if (!$ApplicationName)\n-    {\n-        $ApplicationName = Get-ApplicationNameFromApplicationParameterFile $ApplicationParameterFilePath\n-    }\n-\n-    if (!$ApplicationName)\n-    {\n-        Write-Error (Get-VstsLocString -Key EmptyApplicationName)\n-    }\n-\n-    $names = Get-NamesFromApplicationManifest -ApplicationManifestPath $ApplicationManifestPath\n-    if (!$names)\n-    {\n-        return\n-    }\n-\n     $ApplicationTypeAlreadyRegistered = $false\n     if ($Action.Equals('RegisterAndUpgrade') -or $Action.Equals('Register'))\n     {\n         ## Check existence of the application\n-        $oldApplication = Get-ServiceFabricApplication -ApplicationName $ApplicationName\n-\n         if (!$oldApplication)","path":"Tasks/ServiceFabricDeployV1/ServiceFabricSDK/Publish-UpgradedServiceFabricApplication.ps1","position":69,"original_position":69,"commit_id":"0a65594e1deedcb9f1c92b5f3a9aa18e0dc51b10","original_commit_id":"0a65594e1deedcb9f1c92b5f3a9aa18e0dc51b10","user":{"login":"bishal-pdMSFT","id":7830141,"node_id":"MDQ6VXNlcjc4MzAxNDE=","avatar_url":"https://avatars3.githubusercontent.com/u/7830141?v=4","gravatar_id":"","url":"https://api.github.com/users/bishal-pdMSFT","html_url":"https://github.com/bishal-pdMSFT","followers_url":"https://api.github.com/users/bishal-pdMSFT/followers","following_url":"https://api.github.com/users/bishal-pdMSFT/following{/other_user}","gists_url":"https://api.github.com/users/bishal-pdMSFT/gists{/gist_id}","starred_url":"https://api.github.com/users/bishal-pdMSFT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bishal-pdMSFT/subscriptions","organizations_url":"https://api.github.com/users/bishal-pdMSFT/orgs","repos_url":"https://api.github.com/users/bishal-pdMSFT/repos","events_url":"https://api.github.com/users/bishal-pdMSFT/events{/privacy}","received_events_url":"https://api.github.com/users/bishal-pdMSFT/received_events","type":"User","site_admin":false},"body":"Infact move this check to before checking for skip upgrade","created_at":"2018-06-05T08:51:26Z","updated_at":"2018-06-05T08:51:44Z","html_url":"https://github.com/Microsoft/vsts-tasks/pull/7373#discussion_r192994234","pull_request_url":"https://api.github.com/repos/Microsoft/vsts-tasks/pulls/7373","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/vsts-tasks/pulls/comments/192994234"},"html":{"href":"https://github.com/Microsoft/vsts-tasks/pull/7373#discussion_r192994234"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/vsts-tasks/pulls/7373"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/vsts-tasks/pulls/7373","id":192630022,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyNjMwMDIy","html_url":"https://github.com/Microsoft/vsts-tasks/pull/7373","diff_url":"https://github.com/Microsoft/vsts-tasks/pull/7373.diff","patch_url":"https://github.com/Microsoft/vsts-tasks/pull/7373.patch","issue_url":"https://api.github.com/repos/Microsoft/vsts-tasks/issues/7373","number":7373,"state":"open","locked":false,"title":"Moving up the logic for skip upgrade","user":{"login":"kuvinodms","id":29225848,"node_id":"MDQ6VXNlcjI5MjI1ODQ4","avatar_url":"https://avatars1.githubusercontent.com/u/29225848?v=4","gravatar_id":"","url":"https://api.github.com/users/kuvinodms","html_url":"https://github.com/kuvinodms","followers_url":"https://api.github.com/users/kuvinodms/followers","following_url":"https://api.github.com/users/kuvinodms/following{/other_user}","gists_url":"https://api.github.com/users/kuvinodms/gists{/gist_id}","starred_url":"https://api.github.com/users/kuvinodms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kuvinodms/subscriptions","organizations_url":"https://api.github.com/users/kuvinodms/orgs","repos_url":"https://api.github.com/users/kuvinodms/repos","events_url":"https://api.github.com/users/kuvinodms/events{/privacy}","received_events_url":"https://api.github.com/users/kuvinodms/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-06-05T08:40:18Z","updated_at":"2018-06-05T08:51:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a7797ea862937d01452ea17ed24354bb4d27cdd3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/vsts-tasks/pulls/7373/commits","review_comments_url":"https://api.github.com/repos/Microsoft/vsts-tasks/pulls/7373/comments","review_comment_url":"https://api.github.com/repos/Microsoft/vsts-tasks/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/vsts-tasks/issues/7373/comments","statuses_url":"https://api.github.com/repos/Microsoft/vsts-tasks/statuses/0a65594e1deedcb9f1c92b5f3a9aa18e0dc51b10","head":{"label":"Microsoft:users/kuvinod-skipupgrades","ref":"users/kuvinod-skipupgrades","sha":"0a65594e1deedcb9f1c92b5f3a9aa18e0dc51b10","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":27631673,"node_id":"MDEwOlJlcG9zaXRvcnkyNzYzMTY3Mw==","name":"vsts-tasks","full_name":"Microsoft/vsts-tasks","owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/vsts-tasks","description":"Build and Release Tasks for Visual Studio Team Services and Team Foundation Server","fork":false,"url":"https://api.github.com/repos/Microsoft/vsts-tasks","forks_url":"https://api.github.com/repos/Microsoft/vsts-tasks/forks","keys_url":"https://api.github.com/repos/Microsoft/vsts-tasks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/vsts-tasks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/vsts-tasks/teams","hooks_url":"https://api.github.com/repos/Microsoft/vsts-tasks/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/vsts-tasks/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/vsts-tasks/events","assignees_url":"https://api.github.com/repos/Microsoft/vsts-tasks/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/vsts-tasks/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/vsts-tasks/tags","blobs_url":"https://api.github.com/repos/Microsoft/vsts-tasks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/vsts-tasks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/vsts-tasks/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/vsts-tasks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/vsts-tasks/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/vsts-tasks/languages","stargazers_url":"https://api.github.com/repos/Microsoft/vsts-tasks/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/vsts-tasks/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/vsts-tasks/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/vsts-tasks/subscription","commits_url":"https://api.github.com/repos/Microsoft/vsts-tasks/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/vsts-tasks/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/vsts-tasks/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/vsts-tasks/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/vsts-tasks/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/vsts-tasks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/vsts-tasks/merges","archive_url":"https://api.github.com/repos/Microsoft/vsts-tasks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/vsts-tasks/downloads","issues_url":"https://api.github.com/repos/Microsoft/vsts-tasks/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/vsts-tasks/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/vsts-tasks/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/vsts-tasks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/vsts-tasks/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/vsts-tasks/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/vsts-tasks/deployments","created_at":"2014-12-06T11:11:46Z","updated_at":"2018-06-05T08:25:22Z","pushed_at":"2018-06-05T08:40:19Z","git_url":"git://github.com/Microsoft/vsts-tasks.git","ssh_url":"git@github.com:Microsoft/vsts-tasks.git","clone_url":"https://github.com/Microsoft/vsts-tasks.git","svn_url":"https://github.com/Microsoft/vsts-tasks","homepage":"https://aka.ms/tfbuild","size":49107,"stargazers_count":881,"watchers_count":881,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":812,"mirror_url":null,"archived":false,"open_issues_count":349,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":812,"open_issues":349,"watchers":881,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"f244f437e461a3d331cc684e7ba417188d96bda7","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":27631673,"node_id":"MDEwOlJlcG9zaXRvcnkyNzYzMTY3Mw==","name":"vsts-tasks","full_name":"Microsoft/vsts-tasks","owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/vsts-tasks","description":"Build and Release Tasks for Visual Studio Team Services and Team Foundation Server","fork":false,"url":"https://api.github.com/repos/Microsoft/vsts-tasks","forks_url":"https://api.github.com/repos/Microsoft/vsts-tasks/forks","keys_url":"https://api.github.com/repos/Microsoft/vsts-tasks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/vsts-tasks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/vsts-tasks/teams","hooks_url":"https://api.github.com/repos/Microsoft/vsts-tasks/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/vsts-tasks/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/vsts-tasks/events","assignees_url":"https://api.github.com/repos/Microsoft/vsts-tasks/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/vsts-tasks/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/vsts-tasks/tags","blobs_url":"https://api.github.com/repos/Microsoft/vsts-tasks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/vsts-tasks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/vsts-tasks/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/vsts-tasks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/vsts-tasks/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/vsts-tasks/languages","stargazers_url":"https://api.github.com/repos/Microsoft/vsts-tasks/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/vsts-tasks/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/vsts-tasks/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/vsts-tasks/subscription","commits_url":"https://api.github.com/repos/Microsoft/vsts-tasks/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/vsts-tasks/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/vsts-tasks/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/vsts-tasks/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/vsts-tasks/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/vsts-tasks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/vsts-tasks/merges","archive_url":"https://api.github.com/repos/Microsoft/vsts-tasks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/vsts-tasks/downloads","issues_url":"https://api.github.com/repos/Microsoft/vsts-tasks/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/vsts-tasks/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/vsts-tasks/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/vsts-tasks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/vsts-tasks/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/vsts-tasks/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/vsts-tasks/deployments","created_at":"2014-12-06T11:11:46Z","updated_at":"2018-06-05T08:25:22Z","pushed_at":"2018-06-05T08:40:19Z","git_url":"git://github.com/Microsoft/vsts-tasks.git","ssh_url":"git@github.com:Microsoft/vsts-tasks.git","clone_url":"https://github.com/Microsoft/vsts-tasks.git","svn_url":"https://github.com/Microsoft/vsts-tasks","homepage":"https://aka.ms/tfbuild","size":49107,"stargazers_count":881,"watchers_count":881,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":812,"mirror_url":null,"archived":false,"open_issues_count":349,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":812,"open_issues":349,"watchers":881,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/vsts-tasks/pulls/7373"},"html":{"href":"https://github.com/Microsoft/vsts-tasks/pull/7373"},"issue":{"href":"https://api.github.com/repos/Microsoft/vsts-tasks/issues/7373"},"comments":{"href":"https://api.github.com/repos/Microsoft/vsts-tasks/issues/7373/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/vsts-tasks/pulls/7373/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/vsts-tasks/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/vsts-tasks/pulls/7373/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/vsts-tasks/statuses/0a65594e1deedcb9f1c92b5f3a9aa18e0dc51b10"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"bishal-pdMSFT"}}