{"action":"opened","number":2669,"pull_request":{"url":"https://api.github.com/repos/processing/p5.js/pulls/2669","id":171554689,"html_url":"https://github.com/processing/p5.js/pull/2669","diff_url":"https://github.com/processing/p5.js/pull/2669.diff","patch_url":"https://github.com/processing/p5.js/pull/2669.patch","issue_url":"https://api.github.com/repos/processing/p5.js/issues/2669","number":2669,"state":"open","locked":false,"title":"Add initial support for other draw modes in beginShape().","user":{"login":"tau-","id":1418502,"avatar_url":"https://avatars0.githubusercontent.com/u/1418502?v=4","gravatar_id":"","url":"https://api.github.com/users/tau-","html_url":"https://github.com/tau-","followers_url":"https://api.github.com/users/tau-/followers","following_url":"https://api.github.com/users/tau-/following{/other_user}","gists_url":"https://api.github.com/users/tau-/gists{/gist_id}","starred_url":"https://api.github.com/users/tau-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tau-/subscriptions","organizations_url":"https://api.github.com/users/tau-/orgs","repos_url":"https://api.github.com/users/tau-/repos","events_url":"https://api.github.com/users/tau-/events{/privacy}","received_events_url":"https://api.github.com/users/tau-/received_events","type":"User","site_admin":false},"body":"Pass through shapeMode in _drawStrokeImmediateMode and update the immediate vertex and fragment shaders to support setting gl_PointSize as a uniform. Set new uniforms in RendererGL.strokeWeight. Stroke color and material shader can conflict (z-fight). The current line.vert shader attempts to render lines with thickness, but this can cause strange behavior if gl_PointSize is set so that is removed. Ideally this shader would nicely handle all point and line drawing options.\r\n\r\nDefinitely a WIP. An immediate mode vertex shader with a better implementation of the line options we want to support is ideal. For some examples see: https://mattdesl.svbtle.com/drawing-lines-is-hard","created_at":"2018-02-27T03:29:41Z","updated_at":"2018-02-27T03:29:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/processing/p5.js/pulls/2669/commits","review_comments_url":"https://api.github.com/repos/processing/p5.js/pulls/2669/comments","review_comment_url":"https://api.github.com/repos/processing/p5.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/processing/p5.js/issues/2669/comments","statuses_url":"https://api.github.com/repos/processing/p5.js/statuses/72838945490fa21d791e021c68199f92428fd681","head":{"label":"tau-:2662-webgl-points","ref":"2662-webgl-points","sha":"72838945490fa21d791e021c68199f92428fd681","user":{"login":"tau-","id":1418502,"avatar_url":"https://avatars0.githubusercontent.com/u/1418502?v=4","gravatar_id":"","url":"https://api.github.com/users/tau-","html_url":"https://github.com/tau-","followers_url":"https://api.github.com/users/tau-/followers","following_url":"https://api.github.com/users/tau-/following{/other_user}","gists_url":"https://api.github.com/users/tau-/gists{/gist_id}","starred_url":"https://api.github.com/users/tau-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tau-/subscriptions","organizations_url":"https://api.github.com/users/tau-/orgs","repos_url":"https://api.github.com/users/tau-/repos","events_url":"https://api.github.com/users/tau-/events{/privacy}","received_events_url":"https://api.github.com/users/tau-/received_events","type":"User","site_admin":false},"repo":{"id":119022173,"name":"p5.js","full_name":"tau-/p5.js","owner":{"login":"tau-","id":1418502,"avatar_url":"https://avatars0.githubusercontent.com/u/1418502?v=4","gravatar_id":"","url":"https://api.github.com/users/tau-","html_url":"https://github.com/tau-","followers_url":"https://api.github.com/users/tau-/followers","following_url":"https://api.github.com/users/tau-/following{/other_user}","gists_url":"https://api.github.com/users/tau-/gists{/gist_id}","starred_url":"https://api.github.com/users/tau-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tau-/subscriptions","organizations_url":"https://api.github.com/users/tau-/orgs","repos_url":"https://api.github.com/users/tau-/repos","events_url":"https://api.github.com/users/tau-/events{/privacy}","received_events_url":"https://api.github.com/users/tau-/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tau-/p5.js","description":"p5.js is a JS client-side library for creating graphic and interactive experiences, based on the core principles of Processing. http://twitter.com/p5xjs —","fork":true,"url":"https://api.github.com/repos/tau-/p5.js","forks_url":"https://api.github.com/repos/tau-/p5.js/forks","keys_url":"https://api.github.com/repos/tau-/p5.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tau-/p5.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tau-/p5.js/teams","hooks_url":"https://api.github.com/repos/tau-/p5.js/hooks","issue_events_url":"https://api.github.com/repos/tau-/p5.js/issues/events{/number}","events_url":"https://api.github.com/repos/tau-/p5.js/events","assignees_url":"https://api.github.com/repos/tau-/p5.js/assignees{/user}","branches_url":"https://api.github.com/repos/tau-/p5.js/branches{/branch}","tags_url":"https://api.github.com/repos/tau-/p5.js/tags","blobs_url":"https://api.github.com/repos/tau-/p5.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tau-/p5.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tau-/p5.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/tau-/p5.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tau-/p5.js/statuses/{sha}","languages_url":"https://api.github.com/repos/tau-/p5.js/languages","stargazers_url":"https://api.github.com/repos/tau-/p5.js/stargazers","contributors_url":"https://api.github.com/repos/tau-/p5.js/contributors","subscribers_url":"https://api.github.com/repos/tau-/p5.js/subscribers","subscription_url":"https://api.github.com/repos/tau-/p5.js/subscription","commits_url":"https://api.github.com/repos/tau-/p5.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/tau-/p5.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/tau-/p5.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/tau-/p5.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/tau-/p5.js/contents/{+path}","compare_url":"https://api.github.com/repos/tau-/p5.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tau-/p5.js/merges","archive_url":"https://api.github.com/repos/tau-/p5.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tau-/p5.js/downloads","issues_url":"https://api.github.com/repos/tau-/p5.js/issues{/number}","pulls_url":"https://api.github.com/repos/tau-/p5.js/pulls{/number}","milestones_url":"https://api.github.com/repos/tau-/p5.js/milestones{/number}","notifications_url":"https://api.github.com/repos/tau-/p5.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tau-/p5.js/labels{/name}","releases_url":"https://api.github.com/repos/tau-/p5.js/releases{/id}","deployments_url":"https://api.github.com/repos/tau-/p5.js/deployments","created_at":"2018-01-26T07:48:55Z","updated_at":"2018-01-26T07:48:59Z","pushed_at":"2018-02-27T03:26:58Z","git_url":"git://github.com/tau-/p5.js.git","ssh_url":"git@github.com:tau-/p5.js.git","clone_url":"https://github.com/tau-/p5.js.git","svn_url":"https://github.com/tau-/p5.js","homepage":"http://p5js.org/","size":65521,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"processing:master","ref":"master","sha":"bdd7cf634d25a52b7c8c0dc5415a8c645897f987","user":{"login":"processing","id":1617169,"avatar_url":"https://avatars2.githubusercontent.com/u/1617169?v=4","gravatar_id":"","url":"https://api.github.com/users/processing","html_url":"https://github.com/processing","followers_url":"https://api.github.com/users/processing/followers","following_url":"https://api.github.com/users/processing/following{/other_user}","gists_url":"https://api.github.com/users/processing/gists{/gist_id}","starred_url":"https://api.github.com/users/processing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/processing/subscriptions","organizations_url":"https://api.github.com/users/processing/orgs","repos_url":"https://api.github.com/users/processing/repos","events_url":"https://api.github.com/users/processing/events{/privacy}","received_events_url":"https://api.github.com/users/processing/received_events","type":"Organization","site_admin":false},"repo":{"id":8424040,"name":"p5.js","full_name":"processing/p5.js","owner":{"login":"processing","id":1617169,"avatar_url":"https://avatars2.githubusercontent.com/u/1617169?v=4","gravatar_id":"","url":"https://api.github.com/users/processing","html_url":"https://github.com/processing","followers_url":"https://api.github.com/users/processing/followers","following_url":"https://api.github.com/users/processing/following{/other_user}","gists_url":"https://api.github.com/users/processing/gists{/gist_id}","starred_url":"https://api.github.com/users/processing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/processing/subscriptions","organizations_url":"https://api.github.com/users/processing/orgs","repos_url":"https://api.github.com/users/processing/repos","events_url":"https://api.github.com/users/processing/events{/privacy}","received_events_url":"https://api.github.com/users/processing/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/processing/p5.js","description":"p5.js is a JS client-side library for creating graphic and interactive experiences, based on the core principles of Processing. http://twitter.com/p5xjs —","fork":false,"url":"https://api.github.com/repos/processing/p5.js","forks_url":"https://api.github.com/repos/processing/p5.js/forks","keys_url":"https://api.github.com/repos/processing/p5.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/processing/p5.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/processing/p5.js/teams","hooks_url":"https://api.github.com/repos/processing/p5.js/hooks","issue_events_url":"https://api.github.com/repos/processing/p5.js/issues/events{/number}","events_url":"https://api.github.com/repos/processing/p5.js/events","assignees_url":"https://api.github.com/repos/processing/p5.js/assignees{/user}","branches_url":"https://api.github.com/repos/processing/p5.js/branches{/branch}","tags_url":"https://api.github.com/repos/processing/p5.js/tags","blobs_url":"https://api.github.com/repos/processing/p5.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/processing/p5.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/processing/p5.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/processing/p5.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/processing/p5.js/statuses/{sha}","languages_url":"https://api.github.com/repos/processing/p5.js/languages","stargazers_url":"https://api.github.com/repos/processing/p5.js/stargazers","contributors_url":"https://api.github.com/repos/processing/p5.js/contributors","subscribers_url":"https://api.github.com/repos/processing/p5.js/subscribers","subscription_url":"https://api.github.com/repos/processing/p5.js/subscription","commits_url":"https://api.github.com/repos/processing/p5.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/processing/p5.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/processing/p5.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/processing/p5.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/processing/p5.js/contents/{+path}","compare_url":"https://api.github.com/repos/processing/p5.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/processing/p5.js/merges","archive_url":"https://api.github.com/repos/processing/p5.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/processing/p5.js/downloads","issues_url":"https://api.github.com/repos/processing/p5.js/issues{/number}","pulls_url":"https://api.github.com/repos/processing/p5.js/pulls{/number}","milestones_url":"https://api.github.com/repos/processing/p5.js/milestones{/number}","notifications_url":"https://api.github.com/repos/processing/p5.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/processing/p5.js/labels{/name}","releases_url":"https://api.github.com/repos/processing/p5.js/releases{/id}","deployments_url":"https://api.github.com/repos/processing/p5.js/deployments","created_at":"2013-02-26T03:14:47Z","updated_at":"2018-02-27T02:26:36Z","pushed_at":"2018-02-25T18:43:42Z","git_url":"git://github.com/processing/p5.js.git","ssh_url":"git@github.com:processing/p5.js.git","clone_url":"https://github.com/processing/p5.js.git","svn_url":"https://github.com/processing/p5.js","homepage":"http://p5js.org/","size":65520,"stargazers_count":7474,"watchers_count":7474,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1097,"mirror_url":null,"archived":false,"open_issues_count":86,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1"},"forks":1097,"open_issues":86,"watchers":7474,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/processing/p5.js/pulls/2669"},"html":{"href":"https://github.com/processing/p5.js/pull/2669"},"issue":{"href":"https://api.github.com/repos/processing/p5.js/issues/2669"},"comments":{"href":"https://api.github.com/repos/processing/p5.js/issues/2669/comments"},"review_comments":{"href":"https://api.github.com/repos/processing/p5.js/pulls/2669/comments"},"review_comment":{"href":"https://api.github.com/repos/processing/p5.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/processing/p5.js/pulls/2669/commits"},"statuses":{"href":"https://api.github.com/repos/processing/p5.js/statuses/72838945490fa21d791e021c68199f92428fd681"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":15,"deletions":2,"changed_files":3}}
{"actor":{"display_login":"tau-"}}