{"action":"closed","number":1476,"pull_request":{"url":"https://api.github.com/repos/enactjs/enact/pulls/1476","id":173358902,"html_url":"https://github.com/enactjs/enact/pull/1476","diff_url":"https://github.com/enactjs/enact/pull/1476.diff","patch_url":"https://github.com/enactjs/enact/pull/1476.patch","issue_url":"https://api.github.com/repos/enactjs/enact/issues/1476","number":1476,"state":"closed","locked":false,"title":"ENYO-5054 background-color of progress is different from Enyo","user":{"login":"Sangwook-Lee","id":11263018,"avatar_url":"https://avatars3.githubusercontent.com/u/11263018?v=4","gravatar_id":"","url":"https://api.github.com/users/Sangwook-Lee","html_url":"https://github.com/Sangwook-Lee","followers_url":"https://api.github.com/users/Sangwook-Lee/followers","following_url":"https://api.github.com/users/Sangwook-Lee/following{/other_user}","gists_url":"https://api.github.com/users/Sangwook-Lee/gists{/gist_id}","starred_url":"https://api.github.com/users/Sangwook-Lee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sangwook-Lee/subscriptions","organizations_url":"https://api.github.com/users/Sangwook-Lee/orgs","repos_url":"https://api.github.com/users/Sangwook-Lee/repos","events_url":"https://api.github.com/users/Sangwook-Lee/events{/privacy}","received_events_url":"https://api.github.com/users/Sangwook-Lee/received_events","type":"User","site_admin":false},"body":"### Issue Resolved / Feature Added\r\n[//]: # (Describe the issue resolved or feature added by this pull request)\r\nI found the differences of both `ProgressBar` and `Slider` between Enyo and Enact.\r\nI think these colors should be same to Enyo's.\r\n\r\n### Resolution\r\n[//]: # (Does the code work as intended?)\r\n[//]: # (What is the impact of this change and *why* was it made?)\r\nWe recieved updated GUI guideline. And then I fixed `@moon-progress-bar-loaded-bg-color` and `@moon-progress-bar-fill-bg-color` for both `black` and `white` theme.\r\n\r\n\r\n### Additional Considerations\r\n[//]: # (How should the change be tested?)\r\n[//]: # (Are there any outstanding questions?)\r\n[//]: # (Were any side-effects caused by the change?)\r\n\r\n\r\n### Links\r\n[//]: # (Related issues, references)\r\nENYO-5054 background-color of progress is different from Enyo\r\n\r\n\r\n### Comments\r\nEnact-DCO-1.0-Signed-off-by: Sangwook Lee (sangwook1203.lee@lge.com)","created_at":"2018-03-07T05:49:45Z","updated_at":"2018-03-30T22:41:26Z","closed_at":"2018-03-30T22:41:26Z","merged_at":null,"merge_commit_sha":"0774de8d577b36b5b68765a45b940551a088a16e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"Djspaceg","id":386529,"avatar_url":"https://avatars2.githubusercontent.com/u/386529?v=4","gravatar_id":"","url":"https://api.github.com/users/Djspaceg","html_url":"https://github.com/Djspaceg","followers_url":"https://api.github.com/users/Djspaceg/followers","following_url":"https://api.github.com/users/Djspaceg/following{/other_user}","gists_url":"https://api.github.com/users/Djspaceg/gists{/gist_id}","starred_url":"https://api.github.com/users/Djspaceg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Djspaceg/subscriptions","organizations_url":"https://api.github.com/users/Djspaceg/orgs","repos_url":"https://api.github.com/users/Djspaceg/repos","events_url":"https://api.github.com/users/Djspaceg/events{/privacy}","received_events_url":"https://api.github.com/users/Djspaceg/received_events","type":"User","site_admin":false},{"login":"viodragon2","id":3284947,"avatar_url":"https://avatars0.githubusercontent.com/u/3284947?v=4","gravatar_id":"","url":"https://api.github.com/users/viodragon2","html_url":"https://github.com/viodragon2","followers_url":"https://api.github.com/users/viodragon2/followers","following_url":"https://api.github.com/users/viodragon2/following{/other_user}","gists_url":"https://api.github.com/users/viodragon2/gists{/gist_id}","starred_url":"https://api.github.com/users/viodragon2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/viodragon2/subscriptions","organizations_url":"https://api.github.com/users/viodragon2/orgs","repos_url":"https://api.github.com/users/viodragon2/repos","events_url":"https://api.github.com/users/viodragon2/events{/privacy}","received_events_url":"https://api.github.com/users/viodragon2/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/enactjs/enact/pulls/1476/commits","review_comments_url":"https://api.github.com/repos/enactjs/enact/pulls/1476/comments","review_comment_url":"https://api.github.com/repos/enactjs/enact/pulls/comments{/number}","comments_url":"https://api.github.com/repos/enactjs/enact/issues/1476/comments","statuses_url":"https://api.github.com/repos/enactjs/enact/statuses/142d1c0af124f54ba58adc0a3c0701cb71e86ae9","head":{"label":"enactjs:ENYO-5054-sangwook","ref":"ENYO-5054-sangwook","sha":"142d1c0af124f54ba58adc0a3c0701cb71e86ae9","user":{"login":"enactjs","id":22086053,"avatar_url":"https://avatars2.githubusercontent.com/u/22086053?v=4","gravatar_id":"","url":"https://api.github.com/users/enactjs","html_url":"https://github.com/enactjs","followers_url":"https://api.github.com/users/enactjs/followers","following_url":"https://api.github.com/users/enactjs/following{/other_user}","gists_url":"https://api.github.com/users/enactjs/gists{/gist_id}","starred_url":"https://api.github.com/users/enactjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enactjs/subscriptions","organizations_url":"https://api.github.com/users/enactjs/orgs","repos_url":"https://api.github.com/users/enactjs/repos","events_url":"https://api.github.com/users/enactjs/events{/privacy}","received_events_url":"https://api.github.com/users/enactjs/received_events","type":"Organization","site_admin":false},"repo":{"id":67653065,"name":"enact","full_name":"enactjs/enact","owner":{"login":"enactjs","id":22086053,"avatar_url":"https://avatars2.githubusercontent.com/u/22086053?v=4","gravatar_id":"","url":"https://api.github.com/users/enactjs","html_url":"https://github.com/enactjs","followers_url":"https://api.github.com/users/enactjs/followers","following_url":"https://api.github.com/users/enactjs/following{/other_user}","gists_url":"https://api.github.com/users/enactjs/gists{/gist_id}","starred_url":"https://api.github.com/users/enactjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enactjs/subscriptions","organizations_url":"https://api.github.com/users/enactjs/orgs","repos_url":"https://api.github.com/users/enactjs/repos","events_url":"https://api.github.com/users/enactjs/events{/privacy}","received_events_url":"https://api.github.com/users/enactjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/enactjs/enact","description":"An app development framework built atop React that’s easy to use, performant and customizable.","fork":false,"url":"https://api.github.com/repos/enactjs/enact","forks_url":"https://api.github.com/repos/enactjs/enact/forks","keys_url":"https://api.github.com/repos/enactjs/enact/keys{/key_id}","collaborators_url":"https://api.github.com/repos/enactjs/enact/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/enactjs/enact/teams","hooks_url":"https://api.github.com/repos/enactjs/enact/hooks","issue_events_url":"https://api.github.com/repos/enactjs/enact/issues/events{/number}","events_url":"https://api.github.com/repos/enactjs/enact/events","assignees_url":"https://api.github.com/repos/enactjs/enact/assignees{/user}","branches_url":"https://api.github.com/repos/enactjs/enact/branches{/branch}","tags_url":"https://api.github.com/repos/enactjs/enact/tags","blobs_url":"https://api.github.com/repos/enactjs/enact/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/enactjs/enact/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/enactjs/enact/git/refs{/sha}","trees_url":"https://api.github.com/repos/enactjs/enact/git/trees{/sha}","statuses_url":"https://api.github.com/repos/enactjs/enact/statuses/{sha}","languages_url":"https://api.github.com/repos/enactjs/enact/languages","stargazers_url":"https://api.github.com/repos/enactjs/enact/stargazers","contributors_url":"https://api.github.com/repos/enactjs/enact/contributors","subscribers_url":"https://api.github.com/repos/enactjs/enact/subscribers","subscription_url":"https://api.github.com/repos/enactjs/enact/subscription","commits_url":"https://api.github.com/repos/enactjs/enact/commits{/sha}","git_commits_url":"https://api.github.com/repos/enactjs/enact/git/commits{/sha}","comments_url":"https://api.github.com/repos/enactjs/enact/comments{/number}","issue_comment_url":"https://api.github.com/repos/enactjs/enact/issues/comments{/number}","contents_url":"https://api.github.com/repos/enactjs/enact/contents/{+path}","compare_url":"https://api.github.com/repos/enactjs/enact/compare/{base}...{head}","merges_url":"https://api.github.com/repos/enactjs/enact/merges","archive_url":"https://api.github.com/repos/enactjs/enact/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/enactjs/enact/downloads","issues_url":"https://api.github.com/repos/enactjs/enact/issues{/number}","pulls_url":"https://api.github.com/repos/enactjs/enact/pulls{/number}","milestones_url":"https://api.github.com/repos/enactjs/enact/milestones{/number}","notifications_url":"https://api.github.com/repos/enactjs/enact/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/enactjs/enact/labels{/name}","releases_url":"https://api.github.com/repos/enactjs/enact/releases{/id}","deployments_url":"https://api.github.com/repos/enactjs/enact/deployments","created_at":"2016-09-08T00:14:51Z","updated_at":"2018-03-30T20:37:27Z","pushed_at":"2018-03-30T22:38:54Z","git_url":"git://github.com/enactjs/enact.git","ssh_url":"git@github.com:enactjs/enact.git","clone_url":"https://github.com/enactjs/enact.git","svn_url":"https://github.com/enactjs/enact","homepage":"http://enactjs.com","size":14517,"stargazers_count":45,"watchers_count":45,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":62,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":3,"open_issues":62,"watchers":45,"default_branch":"master"}},"base":{"label":"enactjs:develop","ref":"develop","sha":"d62689dd2f06dc6f24d29d3c8bcae6e8e8f47302","user":{"login":"enactjs","id":22086053,"avatar_url":"https://avatars2.githubusercontent.com/u/22086053?v=4","gravatar_id":"","url":"https://api.github.com/users/enactjs","html_url":"https://github.com/enactjs","followers_url":"https://api.github.com/users/enactjs/followers","following_url":"https://api.github.com/users/enactjs/following{/other_user}","gists_url":"https://api.github.com/users/enactjs/gists{/gist_id}","starred_url":"https://api.github.com/users/enactjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enactjs/subscriptions","organizations_url":"https://api.github.com/users/enactjs/orgs","repos_url":"https://api.github.com/users/enactjs/repos","events_url":"https://api.github.com/users/enactjs/events{/privacy}","received_events_url":"https://api.github.com/users/enactjs/received_events","type":"Organization","site_admin":false},"repo":{"id":67653065,"name":"enact","full_name":"enactjs/enact","owner":{"login":"enactjs","id":22086053,"avatar_url":"https://avatars2.githubusercontent.com/u/22086053?v=4","gravatar_id":"","url":"https://api.github.com/users/enactjs","html_url":"https://github.com/enactjs","followers_url":"https://api.github.com/users/enactjs/followers","following_url":"https://api.github.com/users/enactjs/following{/other_user}","gists_url":"https://api.github.com/users/enactjs/gists{/gist_id}","starred_url":"https://api.github.com/users/enactjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enactjs/subscriptions","organizations_url":"https://api.github.com/users/enactjs/orgs","repos_url":"https://api.github.com/users/enactjs/repos","events_url":"https://api.github.com/users/enactjs/events{/privacy}","received_events_url":"https://api.github.com/users/enactjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/enactjs/enact","description":"An app development framework built atop React that’s easy to use, performant and customizable.","fork":false,"url":"https://api.github.com/repos/enactjs/enact","forks_url":"https://api.github.com/repos/enactjs/enact/forks","keys_url":"https://api.github.com/repos/enactjs/enact/keys{/key_id}","collaborators_url":"https://api.github.com/repos/enactjs/enact/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/enactjs/enact/teams","hooks_url":"https://api.github.com/repos/enactjs/enact/hooks","issue_events_url":"https://api.github.com/repos/enactjs/enact/issues/events{/number}","events_url":"https://api.github.com/repos/enactjs/enact/events","assignees_url":"https://api.github.com/repos/enactjs/enact/assignees{/user}","branches_url":"https://api.github.com/repos/enactjs/enact/branches{/branch}","tags_url":"https://api.github.com/repos/enactjs/enact/tags","blobs_url":"https://api.github.com/repos/enactjs/enact/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/enactjs/enact/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/enactjs/enact/git/refs{/sha}","trees_url":"https://api.github.com/repos/enactjs/enact/git/trees{/sha}","statuses_url":"https://api.github.com/repos/enactjs/enact/statuses/{sha}","languages_url":"https://api.github.com/repos/enactjs/enact/languages","stargazers_url":"https://api.github.com/repos/enactjs/enact/stargazers","contributors_url":"https://api.github.com/repos/enactjs/enact/contributors","subscribers_url":"https://api.github.com/repos/enactjs/enact/subscribers","subscription_url":"https://api.github.com/repos/enactjs/enact/subscription","commits_url":"https://api.github.com/repos/enactjs/enact/commits{/sha}","git_commits_url":"https://api.github.com/repos/enactjs/enact/git/commits{/sha}","comments_url":"https://api.github.com/repos/enactjs/enact/comments{/number}","issue_comment_url":"https://api.github.com/repos/enactjs/enact/issues/comments{/number}","contents_url":"https://api.github.com/repos/enactjs/enact/contents/{+path}","compare_url":"https://api.github.com/repos/enactjs/enact/compare/{base}...{head}","merges_url":"https://api.github.com/repos/enactjs/enact/merges","archive_url":"https://api.github.com/repos/enactjs/enact/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/enactjs/enact/downloads","issues_url":"https://api.github.com/repos/enactjs/enact/issues{/number}","pulls_url":"https://api.github.com/repos/enactjs/enact/pulls{/number}","milestones_url":"https://api.github.com/repos/enactjs/enact/milestones{/number}","notifications_url":"https://api.github.com/repos/enactjs/enact/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/enactjs/enact/labels{/name}","releases_url":"https://api.github.com/repos/enactjs/enact/releases{/id}","deployments_url":"https://api.github.com/repos/enactjs/enact/deployments","created_at":"2016-09-08T00:14:51Z","updated_at":"2018-03-30T20:37:27Z","pushed_at":"2018-03-30T22:38:54Z","git_url":"git://github.com/enactjs/enact.git","ssh_url":"git@github.com:enactjs/enact.git","clone_url":"https://github.com/enactjs/enact.git","svn_url":"https://github.com/enactjs/enact","homepage":"http://enactjs.com","size":14517,"stargazers_count":45,"watchers_count":45,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":62,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":3,"open_issues":62,"watchers":45,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/enactjs/enact/pulls/1476"},"html":{"href":"https://github.com/enactjs/enact/pull/1476"},"issue":{"href":"https://api.github.com/repos/enactjs/enact/issues/1476"},"comments":{"href":"https://api.github.com/repos/enactjs/enact/issues/1476/comments"},"review_comments":{"href":"https://api.github.com/repos/enactjs/enact/pulls/1476/comments"},"review_comment":{"href":"https://api.github.com/repos/enactjs/enact/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/enactjs/enact/pulls/1476/commits"},"statuses":{"href":"https://api.github.com/repos/enactjs/enact/statuses/142d1c0af124f54ba58adc0a3c0701cb71e86ae9"}},"author_association":"NONE","merged":false,"mergeable":false,"rebaseable":false,"mergeable_state":"dirty","merged_by":null,"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":4,"additions":8,"deletions":6,"changed_files":3}}
{"actor":{"display_login":"ryanjduffy"}}