{"action":"created","comment":{"url":"https://api.github.com/repos/libero/content-store/pulls/comments/211552590","pull_request_review_id":147993885,"id":211552590,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTU1MjU5MA==","diff_hunk":"@@ -5,6 +5,7 @@ name = \"pypi\"\n \n [dev-packages]\n pytest = \"~=3.7.1\"\n+pylint = \"*\"","path":"Pipfile","position":4,"original_position":4,"commit_id":"5ca6c822eb33b2dc49ef57212c57638619a3afdb","original_commit_id":"54dde88da761a04cb7cd873813ae27611c26a8d2","user":{"login":"giorgiosironi","id":160299,"node_id":"MDQ6VXNlcjE2MDI5OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/160299?v=4","gravatar_id":"","url":"https://api.github.com/users/giorgiosironi","html_url":"https://github.com/giorgiosironi","followers_url":"https://api.github.com/users/giorgiosironi/followers","following_url":"https://api.github.com/users/giorgiosironi/following{/other_user}","gists_url":"https://api.github.com/users/giorgiosironi/gists{/gist_id}","starred_url":"https://api.github.com/users/giorgiosironi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giorgiosironi/subscriptions","organizations_url":"https://api.github.com/users/giorgiosironi/orgs","repos_url":"https://api.github.com/users/giorgiosironi/repos","events_url":"https://api.github.com/users/giorgiosironi/events{/privacy}","received_events_url":"https://api.github.com/users/giorgiosironi/received_events","type":"User","site_admin":false},"body":"The lock file deals with the exact version separately, but a major version here (can't see it at the moment?) should be handy as if we run an upgrade we don't want to end up with an hypothetical future Pylint 3 that has introduced backward-incompatible changes like a different format for `.pylintrc`, etc.\r\n\r\nI understand that people importing a `requirements.txt` will end up with things like `1.2.3.4rc2_0ubuntu1` which is brittle.","created_at":"2018-08-21T10:16:53Z","updated_at":"2018-08-21T10:16:53Z","html_url":"https://github.com/libero/content-store/pull/9#discussion_r211552590","pull_request_url":"https://api.github.com/repos/libero/content-store/pulls/9","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/libero/content-store/pulls/comments/211552590"},"html":{"href":"https://github.com/libero/content-store/pull/9#discussion_r211552590"},"pull_request":{"href":"https://api.github.com/repos/libero/content-store/pulls/9"}},"in_reply_to_id":211520055},"pull_request":{"url":"https://api.github.com/repos/libero/content-store/pulls/9","id":208922625,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4OTIyNjI1","html_url":"https://github.com/libero/content-store/pull/9","diff_url":"https://github.com/libero/content-store/pull/9.diff","patch_url":"https://github.com/libero/content-store/pull/9.patch","issue_url":"https://api.github.com/repos/libero/content-store/issues/9","number":9,"state":"open","locked":false,"title":"pylint code checks","user":{"login":"de-code","id":1016473,"node_id":"MDQ6VXNlcjEwMTY0NzM=","avatar_url":"https://avatars0.githubusercontent.com/u/1016473?v=4","gravatar_id":"","url":"https://api.github.com/users/de-code","html_url":"https://github.com/de-code","followers_url":"https://api.github.com/users/de-code/followers","following_url":"https://api.github.com/users/de-code/following{/other_user}","gists_url":"https://api.github.com/users/de-code/gists{/gist_id}","starred_url":"https://api.github.com/users/de-code/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/de-code/subscriptions","organizations_url":"https://api.github.com/users/de-code/orgs","repos_url":"https://api.github.com/users/de-code/repos","events_url":"https://api.github.com/users/de-code/events{/privacy}","received_events_url":"https://api.github.com/users/de-code/received_events","type":"User","site_admin":false},"body":"Issue: https://github.com/libero/libero/issues/35\r\n\r\nThere are some pylint issues with [implicit namespace packages](https://docs.python.org/3/whatsnew/3.3.html#pep-420-implicit-namespace-packages):\r\n- https://github.com/PyCQA/pylint/issues/2108\r\n- https://github.com/PyCQA/pylint/issues/352\r\n- https://github.com/PyCQA/pylint/issues/842 (closed)\r\n\r\nI'm proposing to just add the `__init__.py` files for now.\r\n\r\nI am planning to create separate PRs for other code checking tools.","created_at":"2018-08-16T16:56:17Z","updated_at":"2018-08-21T10:16:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1a99c1736e14eaf4606278957e161564974264f4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/libero/content-store/pulls/9/commits","review_comments_url":"https://api.github.com/repos/libero/content-store/pulls/9/comments","review_comment_url":"https://api.github.com/repos/libero/content-store/pulls/comments{/number}","comments_url":"https://api.github.com/repos/libero/content-store/issues/9/comments","statuses_url":"https://api.github.com/repos/libero/content-store/statuses/5ca6c822eb33b2dc49ef57212c57638619a3afdb","head":{"label":"de-code:code-checks","ref":"code-checks","sha":"5ca6c822eb33b2dc49ef57212c57638619a3afdb","user":{"login":"de-code","id":1016473,"node_id":"MDQ6VXNlcjEwMTY0NzM=","avatar_url":"https://avatars0.githubusercontent.com/u/1016473?v=4","gravatar_id":"","url":"https://api.github.com/users/de-code","html_url":"https://github.com/de-code","followers_url":"https://api.github.com/users/de-code/followers","following_url":"https://api.github.com/users/de-code/following{/other_user}","gists_url":"https://api.github.com/users/de-code/gists{/gist_id}","starred_url":"https://api.github.com/users/de-code/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/de-code/subscriptions","organizations_url":"https://api.github.com/users/de-code/orgs","repos_url":"https://api.github.com/users/de-code/repos","events_url":"https://api.github.com/users/de-code/events{/privacy}","received_events_url":"https://api.github.com/users/de-code/received_events","type":"User","site_admin":false},"repo":{"id":144831182,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ4MzExODI=","name":"content-store","full_name":"de-code/content-store","owner":{"login":"de-code","id":1016473,"node_id":"MDQ6VXNlcjEwMTY0NzM=","avatar_url":"https://avatars0.githubusercontent.com/u/1016473?v=4","gravatar_id":"","url":"https://api.github.com/users/de-code","html_url":"https://github.com/de-code","followers_url":"https://api.github.com/users/de-code/followers","following_url":"https://api.github.com/users/de-code/following{/other_user}","gists_url":"https://api.github.com/users/de-code/gists{/gist_id}","starred_url":"https://api.github.com/users/de-code/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/de-code/subscriptions","organizations_url":"https://api.github.com/users/de-code/orgs","repos_url":"https://api.github.com/users/de-code/repos","events_url":"https://api.github.com/users/de-code/events{/privacy}","received_events_url":"https://api.github.com/users/de-code/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/de-code/content-store","description":null,"fork":true,"url":"https://api.github.com/repos/de-code/content-store","forks_url":"https://api.github.com/repos/de-code/content-store/forks","keys_url":"https://api.github.com/repos/de-code/content-store/keys{/key_id}","collaborators_url":"https://api.github.com/repos/de-code/content-store/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/de-code/content-store/teams","hooks_url":"https://api.github.com/repos/de-code/content-store/hooks","issue_events_url":"https://api.github.com/repos/de-code/content-store/issues/events{/number}","events_url":"https://api.github.com/repos/de-code/content-store/events","assignees_url":"https://api.github.com/repos/de-code/content-store/assignees{/user}","branches_url":"https://api.github.com/repos/de-code/content-store/branches{/branch}","tags_url":"https://api.github.com/repos/de-code/content-store/tags","blobs_url":"https://api.github.com/repos/de-code/content-store/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/de-code/content-store/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/de-code/content-store/git/refs{/sha}","trees_url":"https://api.github.com/repos/de-code/content-store/git/trees{/sha}","statuses_url":"https://api.github.com/repos/de-code/content-store/statuses/{sha}","languages_url":"https://api.github.com/repos/de-code/content-store/languages","stargazers_url":"https://api.github.com/repos/de-code/content-store/stargazers","contributors_url":"https://api.github.com/repos/de-code/content-store/contributors","subscribers_url":"https://api.github.com/repos/de-code/content-store/subscribers","subscription_url":"https://api.github.com/repos/de-code/content-store/subscription","commits_url":"https://api.github.com/repos/de-code/content-store/commits{/sha}","git_commits_url":"https://api.github.com/repos/de-code/content-store/git/commits{/sha}","comments_url":"https://api.github.com/repos/de-code/content-store/comments{/number}","issue_comment_url":"https://api.github.com/repos/de-code/content-store/issues/comments{/number}","contents_url":"https://api.github.com/repos/de-code/content-store/contents/{+path}","compare_url":"https://api.github.com/repos/de-code/content-store/compare/{base}...{head}","merges_url":"https://api.github.com/repos/de-code/content-store/merges","archive_url":"https://api.github.com/repos/de-code/content-store/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/de-code/content-store/downloads","issues_url":"https://api.github.com/repos/de-code/content-store/issues{/number}","pulls_url":"https://api.github.com/repos/de-code/content-store/pulls{/number}","milestones_url":"https://api.github.com/repos/de-code/content-store/milestones{/number}","notifications_url":"https://api.github.com/repos/de-code/content-store/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/de-code/content-store/labels{/name}","releases_url":"https://api.github.com/repos/de-code/content-store/releases{/id}","deployments_url":"https://api.github.com/repos/de-code/content-store/deployments","created_at":"2018-08-15T09:07:45Z","updated_at":"2018-08-15T09:07:47Z","pushed_at":"2018-08-21T09:09:53Z","git_url":"git://github.com/de-code/content-store.git","ssh_url":"git@github.com:de-code/content-store.git","clone_url":"https://github.com/de-code/content-store.git","svn_url":"https://github.com/de-code/content-store","homepage":null,"size":31,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"libero:master","ref":"master","sha":"305bf2ed475e1699fc5e7cc602b875a6c618a534","user":{"login":"libero","id":37089447,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MDg5NDQ3","avatar_url":"https://avatars1.githubusercontent.com/u/37089447?v=4","gravatar_id":"","url":"https://api.github.com/users/libero","html_url":"https://github.com/libero","followers_url":"https://api.github.com/users/libero/followers","following_url":"https://api.github.com/users/libero/following{/other_user}","gists_url":"https://api.github.com/users/libero/gists{/gist_id}","starred_url":"https://api.github.com/users/libero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libero/subscriptions","organizations_url":"https://api.github.com/users/libero/orgs","repos_url":"https://api.github.com/users/libero/repos","events_url":"https://api.github.com/users/libero/events{/privacy}","received_events_url":"https://api.github.com/users/libero/received_events","type":"Organization","site_admin":false},"repo":{"id":144592946,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ1OTI5NDY=","name":"content-store","full_name":"libero/content-store","owner":{"login":"libero","id":37089447,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MDg5NDQ3","avatar_url":"https://avatars1.githubusercontent.com/u/37089447?v=4","gravatar_id":"","url":"https://api.github.com/users/libero","html_url":"https://github.com/libero","followers_url":"https://api.github.com/users/libero/followers","following_url":"https://api.github.com/users/libero/following{/other_user}","gists_url":"https://api.github.com/users/libero/gists{/gist_id}","starred_url":"https://api.github.com/users/libero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libero/subscriptions","organizations_url":"https://api.github.com/users/libero/orgs","repos_url":"https://api.github.com/users/libero/repos","events_url":"https://api.github.com/users/libero/events{/privacy}","received_events_url":"https://api.github.com/users/libero/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/libero/content-store","description":null,"fork":false,"url":"https://api.github.com/repos/libero/content-store","forks_url":"https://api.github.com/repos/libero/content-store/forks","keys_url":"https://api.github.com/repos/libero/content-store/keys{/key_id}","collaborators_url":"https://api.github.com/repos/libero/content-store/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/libero/content-store/teams","hooks_url":"https://api.github.com/repos/libero/content-store/hooks","issue_events_url":"https://api.github.com/repos/libero/content-store/issues/events{/number}","events_url":"https://api.github.com/repos/libero/content-store/events","assignees_url":"https://api.github.com/repos/libero/content-store/assignees{/user}","branches_url":"https://api.github.com/repos/libero/content-store/branches{/branch}","tags_url":"https://api.github.com/repos/libero/content-store/tags","blobs_url":"https://api.github.com/repos/libero/content-store/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/libero/content-store/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/libero/content-store/git/refs{/sha}","trees_url":"https://api.github.com/repos/libero/content-store/git/trees{/sha}","statuses_url":"https://api.github.com/repos/libero/content-store/statuses/{sha}","languages_url":"https://api.github.com/repos/libero/content-store/languages","stargazers_url":"https://api.github.com/repos/libero/content-store/stargazers","contributors_url":"https://api.github.com/repos/libero/content-store/contributors","subscribers_url":"https://api.github.com/repos/libero/content-store/subscribers","subscription_url":"https://api.github.com/repos/libero/content-store/subscription","commits_url":"https://api.github.com/repos/libero/content-store/commits{/sha}","git_commits_url":"https://api.github.com/repos/libero/content-store/git/commits{/sha}","comments_url":"https://api.github.com/repos/libero/content-store/comments{/number}","issue_comment_url":"https://api.github.com/repos/libero/content-store/issues/comments{/number}","contents_url":"https://api.github.com/repos/libero/content-store/contents/{+path}","compare_url":"https://api.github.com/repos/libero/content-store/compare/{base}...{head}","merges_url":"https://api.github.com/repos/libero/content-store/merges","archive_url":"https://api.github.com/repos/libero/content-store/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/libero/content-store/downloads","issues_url":"https://api.github.com/repos/libero/content-store/issues{/number}","pulls_url":"https://api.github.com/repos/libero/content-store/pulls{/number}","milestones_url":"https://api.github.com/repos/libero/content-store/milestones{/number}","notifications_url":"https://api.github.com/repos/libero/content-store/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/libero/content-store/labels{/name}","releases_url":"https://api.github.com/repos/libero/content-store/releases{/id}","deployments_url":"https://api.github.com/repos/libero/content-store/deployments","created_at":"2018-08-13T14:41:52Z","updated_at":"2018-08-20T07:14:57Z","pushed_at":"2018-08-21T09:09:54Z","git_url":"git://github.com/libero/content-store.git","ssh_url":"git@github.com:libero/content-store.git","clone_url":"https://github.com/libero/content-store.git","svn_url":"https://github.com/libero/content-store","homepage":null,"size":20,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":6,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/libero/content-store/pulls/9"},"html":{"href":"https://github.com/libero/content-store/pull/9"},"issue":{"href":"https://api.github.com/repos/libero/content-store/issues/9"},"comments":{"href":"https://api.github.com/repos/libero/content-store/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/libero/content-store/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/libero/content-store/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/libero/content-store/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/libero/content-store/statuses/5ca6c822eb33b2dc49ef57212c57638619a3afdb"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"giorgiosironi"}}