{"action":"created","issue":{"url":"https://api.github.com/repos/rintoj/ngx-virtual-scroller/issues/253","repository_url":"https://api.github.com/repos/rintoj/ngx-virtual-scroller","labels_url":"https://api.github.com/repos/rintoj/ngx-virtual-scroller/issues/253/labels{/name}","comments_url":"https://api.github.com/repos/rintoj/ngx-virtual-scroller/issues/253/comments","events_url":"https://api.github.com/repos/rintoj/ngx-virtual-scroller/issues/253/events","html_url":"https://github.com/rintoj/ngx-virtual-scroller/issues/253","id":367591104,"node_id":"MDU6SXNzdWUzNjc1OTExMDQ=","number":253,"title":"Projects using ngx-virtual-scroller will not compile when \"noImplicitAny\" is set in tsconfig.json","user":{"login":"jamesmikesell","id":18224226,"node_id":"MDQ6VXNlcjE4MjI0MjI2","avatar_url":"https://avatars1.githubusercontent.com/u/18224226?v=4","gravatar_id":"","url":"https://api.github.com/users/jamesmikesell","html_url":"https://github.com/jamesmikesell","followers_url":"https://api.github.com/users/jamesmikesell/followers","following_url":"https://api.github.com/users/jamesmikesell/following{/other_user}","gists_url":"https://api.github.com/users/jamesmikesell/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesmikesell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesmikesell/subscriptions","organizations_url":"https://api.github.com/users/jamesmikesell/orgs","repos_url":"https://api.github.com/users/jamesmikesell/repos","events_url":"https://api.github.com/users/jamesmikesell/events{/privacy}","received_events_url":"https://api.github.com/users/jamesmikesell/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-10-07T20:34:04Z","updated_at":"2018-10-07T21:47:59Z","closed_at":null,"author_association":"NONE","body":"# Problem\r\nAngular projects using ngx-virtual-scoller which have their `tsconfig.json` `compilerOptions.noImplicitAny` set to `true` fail to compile with the following error:\r\n\r\n```shell\r\nERROR in node_modules/ngx-virtual-scroller/dist/virtual-scroller.d.ts(2,24): error TS7016: Could not find a declaration file for module '@tweenjs/tween.js'. '/test-app/node_modules/@tweenjs/tween.js' implicitly has an 'any' type.\r\n  Try `npm install @types/tweenjs__tween.js` if it exists or add a new declaration (.d.ts) file containing `declare module 'tweenjs__tween.js';`\r\n```\r\n\r\nWhile this can be remedied by adding `\"@types/tween.js\": \"^16.9.0\"` to the package.json, I believe the underlying issue is that nxg-virtual-scroller should have `@types/tween.js` added to it's `package.json` `dependencies` section instead of it's current location in the `devDependencies`.\r\n\r\nI believe this is the underlying problem in issues #210 and #227.\r\n\r\n# Suggested Resolution\r\nMove `@types/tween.js` in [package.json line 59](https://github.com/rintoj/ngx-virtual-scroller/blob/144e6271e4f3f9bb8cd86128fe2814c7b1215b6e/package.json#L59) into the `dependencies` section (instead of it's current location of `devDependencies`)."},"comment":{"url":"https://api.github.com/repos/rintoj/ngx-virtual-scroller/issues/comments/427689892","html_url":"https://github.com/rintoj/ngx-virtual-scroller/issues/253#issuecomment-427689892","issue_url":"https://api.github.com/repos/rintoj/ngx-virtual-scroller/issues/253","id":427689892,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNzY4OTg5Mg==","user":{"login":"jamesmikesell","id":18224226,"node_id":"MDQ6VXNlcjE4MjI0MjI2","avatar_url":"https://avatars1.githubusercontent.com/u/18224226?v=4","gravatar_id":"","url":"https://api.github.com/users/jamesmikesell","html_url":"https://github.com/jamesmikesell","followers_url":"https://api.github.com/users/jamesmikesell/followers","following_url":"https://api.github.com/users/jamesmikesell/following{/other_user}","gists_url":"https://api.github.com/users/jamesmikesell/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesmikesell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesmikesell/subscriptions","organizations_url":"https://api.github.com/users/jamesmikesell/orgs","repos_url":"https://api.github.com/users/jamesmikesell/repos","events_url":"https://api.github.com/users/jamesmikesell/events{/privacy}","received_events_url":"https://api.github.com/users/jamesmikesell/received_events","type":"User","site_admin":false},"created_at":"2018-10-07T21:47:59Z","updated_at":"2018-10-07T21:47:59Z","author_association":"NONE","body":"Just realized that in addition to the above, I had to remove `\"types\": []` from `tsconfig.app.json` in the project that uses ngx-virtual-scroller."}}
{"actor":{"display_login":"jamesmikesell"}}