{"action":"closed","number":16849,"pull_request":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/16849","id":202295961,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyMjk1OTYx","html_url":"https://github.com/ampproject/amphtml/pull/16849","diff_url":"https://github.com/ampproject/amphtml/pull/16849.diff","patch_url":"https://github.com/ampproject/amphtml/pull/16849.patch","issue_url":"https://api.github.com/repos/ampproject/amphtml/issues/16849","number":16849,"state":"closed","locked":false,"title":"Removed unused delayed impression code path.","user":{"login":"glevitzky","id":20518281,"node_id":"MDQ6VXNlcjIwNTE4Mjgx","avatar_url":"https://avatars1.githubusercontent.com/u/20518281?v=4","gravatar_id":"","url":"https://api.github.com/users/glevitzky","html_url":"https://github.com/glevitzky","followers_url":"https://api.github.com/users/glevitzky/followers","following_url":"https://api.github.com/users/glevitzky/following{/other_user}","gists_url":"https://api.github.com/users/glevitzky/gists{/gist_id}","starred_url":"https://api.github.com/users/glevitzky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glevitzky/subscriptions","organizations_url":"https://api.github.com/users/glevitzky/orgs","repos_url":"https://api.github.com/users/glevitzky/repos","events_url":"https://api.github.com/users/glevitzky/events{/privacy}","received_events_url":"https://api.github.com/users/glevitzky/received_events","type":"User","site_admin":false},"body":"The removed code path fired erroneously when a fluid + multi-size request returned a multi-size creative, causing the impression to be double-counted.","created_at":"2018-07-18T15:38:02Z","updated_at":"2018-07-20T13:58:31Z","closed_at":"2018-07-20T13:58:31Z","merged_at":"2018-07-20T13:58:31Z","merge_commit_sha":"1df02b272a7de6d41620edb446077472a4aa4cf5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":596633554,"node_id":"MDU6TGFiZWw1OTY2MzM1NTQ=","url":"https://api.github.com/repos/ampproject/amphtml/labels/cla:%20yes","name":"cla: yes","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ampproject/amphtml/pulls/16849/commits","review_comments_url":"https://api.github.com/repos/ampproject/amphtml/pulls/16849/comments","review_comment_url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ampproject/amphtml/issues/16849/comments","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/d9ae9e8b5091dd4074ddbe2812b62146d5c55fd4","head":{"label":"glevitzky:drfix","ref":"drfix","sha":"d9ae9e8b5091dd4074ddbe2812b62146d5c55fd4","user":{"login":"glevitzky","id":20518281,"node_id":"MDQ6VXNlcjIwNTE4Mjgx","avatar_url":"https://avatars1.githubusercontent.com/u/20518281?v=4","gravatar_id":"","url":"https://api.github.com/users/glevitzky","html_url":"https://github.com/glevitzky","followers_url":"https://api.github.com/users/glevitzky/followers","following_url":"https://api.github.com/users/glevitzky/following{/other_user}","gists_url":"https://api.github.com/users/glevitzky/gists{/gist_id}","starred_url":"https://api.github.com/users/glevitzky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glevitzky/subscriptions","organizations_url":"https://api.github.com/users/glevitzky/orgs","repos_url":"https://api.github.com/users/glevitzky/repos","events_url":"https://api.github.com/users/glevitzky/events{/privacy}","received_events_url":"https://api.github.com/users/glevitzky/received_events","type":"User","site_admin":false},"repo":{"id":107138995,"node_id":"MDEwOlJlcG9zaXRvcnkxMDcxMzg5OTU=","name":"amphtml","full_name":"glevitzky/amphtml","owner":{"login":"glevitzky","id":20518281,"node_id":"MDQ6VXNlcjIwNTE4Mjgx","avatar_url":"https://avatars1.githubusercontent.com/u/20518281?v=4","gravatar_id":"","url":"https://api.github.com/users/glevitzky","html_url":"https://github.com/glevitzky","followers_url":"https://api.github.com/users/glevitzky/followers","following_url":"https://api.github.com/users/glevitzky/following{/other_user}","gists_url":"https://api.github.com/users/glevitzky/gists{/gist_id}","starred_url":"https://api.github.com/users/glevitzky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glevitzky/subscriptions","organizations_url":"https://api.github.com/users/glevitzky/orgs","repos_url":"https://api.github.com/users/glevitzky/repos","events_url":"https://api.github.com/users/glevitzky/events{/privacy}","received_events_url":"https://api.github.com/users/glevitzky/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/glevitzky/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":true,"url":"https://api.github.com/repos/glevitzky/amphtml","forks_url":"https://api.github.com/repos/glevitzky/amphtml/forks","keys_url":"https://api.github.com/repos/glevitzky/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/glevitzky/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/glevitzky/amphtml/teams","hooks_url":"https://api.github.com/repos/glevitzky/amphtml/hooks","issue_events_url":"https://api.github.com/repos/glevitzky/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/glevitzky/amphtml/events","assignees_url":"https://api.github.com/repos/glevitzky/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/glevitzky/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/glevitzky/amphtml/tags","blobs_url":"https://api.github.com/repos/glevitzky/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/glevitzky/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/glevitzky/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/glevitzky/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/glevitzky/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/glevitzky/amphtml/languages","stargazers_url":"https://api.github.com/repos/glevitzky/amphtml/stargazers","contributors_url":"https://api.github.com/repos/glevitzky/amphtml/contributors","subscribers_url":"https://api.github.com/repos/glevitzky/amphtml/subscribers","subscription_url":"https://api.github.com/repos/glevitzky/amphtml/subscription","commits_url":"https://api.github.com/repos/glevitzky/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/glevitzky/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/glevitzky/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/glevitzky/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/glevitzky/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/glevitzky/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/glevitzky/amphtml/merges","archive_url":"https://api.github.com/repos/glevitzky/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/glevitzky/amphtml/downloads","issues_url":"https://api.github.com/repos/glevitzky/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/glevitzky/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/glevitzky/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/glevitzky/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/glevitzky/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/glevitzky/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/glevitzky/amphtml/deployments","created_at":"2017-10-16T14:29:01Z","updated_at":"2018-07-16T01:01:40Z","pushed_at":"2018-07-18T21:42:00Z","git_url":"git://github.com/glevitzky/amphtml.git","ssh_url":"git@github.com:glevitzky/amphtml.git","clone_url":"https://github.com/glevitzky/amphtml.git","svn_url":"https://github.com/glevitzky/amphtml","homepage":"https://www.ampproject.org","size":486051,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ampproject:master","ref":"master","sha":"6470c1ef601e75e656c318b1cde370dfb347a2b1","user":{"login":"ampproject","id":14114390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTE0Mzkw","avatar_url":"https://avatars3.githubusercontent.com/u/14114390?v=4","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"repo":{"id":41766002,"node_id":"MDEwOlJlcG9zaXRvcnk0MTc2NjAwMg==","name":"amphtml","full_name":"ampproject/amphtml","owner":{"login":"ampproject","id":14114390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTE0Mzkw","avatar_url":"https://avatars3.githubusercontent.com/u/14114390?v=4","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ampproject/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":false,"url":"https://api.github.com/repos/ampproject/amphtml","forks_url":"https://api.github.com/repos/ampproject/amphtml/forks","keys_url":"https://api.github.com/repos/ampproject/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ampproject/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ampproject/amphtml/teams","hooks_url":"https://api.github.com/repos/ampproject/amphtml/hooks","issue_events_url":"https://api.github.com/repos/ampproject/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/ampproject/amphtml/events","assignees_url":"https://api.github.com/repos/ampproject/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/ampproject/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/ampproject/amphtml/tags","blobs_url":"https://api.github.com/repos/ampproject/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ampproject/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ampproject/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/ampproject/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/ampproject/amphtml/languages","stargazers_url":"https://api.github.com/repos/ampproject/amphtml/stargazers","contributors_url":"https://api.github.com/repos/ampproject/amphtml/contributors","subscribers_url":"https://api.github.com/repos/ampproject/amphtml/subscribers","subscription_url":"https://api.github.com/repos/ampproject/amphtml/subscription","commits_url":"https://api.github.com/repos/ampproject/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/ampproject/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/ampproject/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/ampproject/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/ampproject/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/ampproject/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ampproject/amphtml/merges","archive_url":"https://api.github.com/repos/ampproject/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ampproject/amphtml/downloads","issues_url":"https://api.github.com/repos/ampproject/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/ampproject/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/ampproject/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/ampproject/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ampproject/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/ampproject/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/ampproject/amphtml/deployments","created_at":"2015-09-01T22:10:53Z","updated_at":"2018-07-20T13:52:45Z","pushed_at":"2018-07-20T13:58:31Z","git_url":"git://github.com/ampproject/amphtml.git","ssh_url":"git@github.com:ampproject/amphtml.git","clone_url":"https://github.com/ampproject/amphtml.git","svn_url":"https://github.com/ampproject/amphtml","homepage":"https://www.ampproject.org","size":485758,"stargazers_count":11777,"watchers_count":11777,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":2500,"mirror_url":null,"archived":false,"open_issues_count":1355,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2500,"open_issues":1355,"watchers":11777,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/16849"},"html":{"href":"https://github.com/ampproject/amphtml/pull/16849"},"issue":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/16849"},"comments":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/16849/comments"},"review_comments":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/16849/comments"},"review_comment":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/16849/commits"},"statuses":{"href":"https://api.github.com/repos/ampproject/amphtml/statuses/d9ae9e8b5091dd4074ddbe2812b62146d5c55fd4"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"bradfrizzell","id":4276992,"node_id":"MDQ6VXNlcjQyNzY5OTI=","avatar_url":"https://avatars1.githubusercontent.com/u/4276992?v=4","gravatar_id":"","url":"https://api.github.com/users/bradfrizzell","html_url":"https://github.com/bradfrizzell","followers_url":"https://api.github.com/users/bradfrizzell/followers","following_url":"https://api.github.com/users/bradfrizzell/following{/other_user}","gists_url":"https://api.github.com/users/bradfrizzell/gists{/gist_id}","starred_url":"https://api.github.com/users/bradfrizzell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradfrizzell/subscriptions","organizations_url":"https://api.github.com/users/bradfrizzell/orgs","repos_url":"https://api.github.com/users/bradfrizzell/repos","events_url":"https://api.github.com/users/bradfrizzell/events{/privacy}","received_events_url":"https://api.github.com/users/bradfrizzell/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":6,"deletions":32,"changed_files":2}}
{"actor":{"display_login":"bradfrizzell"}}