{"action":"closed","number":6409,"pull_request":{"url":"https://api.github.com/repos/NativeScript/NativeScript/pulls/6409","id":222620679,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyNjIwNjc5","html_url":"https://github.com/NativeScript/NativeScript/pull/6409","diff_url":"https://github.com/NativeScript/NativeScript/pull/6409.diff","patch_url":"https://github.com/NativeScript/NativeScript/pull/6409.patch","issue_url":"https://api.github.com/repos/NativeScript/NativeScript/issues/6409","number":6409,"state":"closed","locked":false,"title":"feat(view): added iOS parameter for modal presentation style","user":{"login":"surdu","id":11520795,"node_id":"MDQ6VXNlcjExNTIwNzk1","avatar_url":"https://avatars3.githubusercontent.com/u/11520795?v=4","gravatar_id":"","url":"https://api.github.com/users/surdu","html_url":"https://github.com/surdu","followers_url":"https://api.github.com/users/surdu/followers","following_url":"https://api.github.com/users/surdu/following{/other_user}","gists_url":"https://api.github.com/users/surdu/gists{/gist_id}","starred_url":"https://api.github.com/users/surdu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/surdu/subscriptions","organizations_url":"https://api.github.com/users/surdu/orgs","repos_url":"https://api.github.com/users/surdu/repos","events_url":"https://api.github.com/users/surdu/events{/privacy}","received_events_url":"https://api.github.com/users/surdu/received_events","type":"User","site_admin":false},"body":"## PR Checklist\r\n\r\n- [x] The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages.\r\n- [x] There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.\r\n- [x] You have signed the [CLA](http://www.nativescript.org/cla).\r\n- [ ] All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/DevelopmentWorkflow.md#running-unit-tests.\r\n- [ ] Tests for the changes are included - https://github.com/NativeScript/NativeScript/blob/master/WritingUnitTests.md.\r\n\r\n## What is the current behavior?\r\nOther than fullscreen or not, there is no way to set the rest of modal presentation styles for a modal on iOS\r\n\r\n## What is the new behavior?\r\nYou can now pass an extra parameter called `iOSPresentationStyle` to `.showModal()`\r\n\r\nImplements #6387 ","created_at":"2018-10-13T02:00:43Z","updated_at":"2018-12-13T15:03:26Z","closed_at":"2018-12-13T15:03:26Z","merged_at":"2018-12-13T15:03:26Z","merge_commit_sha":"540b2b4f8206660980e4f0a8eb62a3c06dca1ec6","assignee":{"login":"vakrilov","id":4092076,"node_id":"MDQ6VXNlcjQwOTIwNzY=","avatar_url":"https://avatars3.githubusercontent.com/u/4092076?v=4","gravatar_id":"","url":"https://api.github.com/users/vakrilov","html_url":"https://github.com/vakrilov","followers_url":"https://api.github.com/users/vakrilov/followers","following_url":"https://api.github.com/users/vakrilov/following{/other_user}","gists_url":"https://api.github.com/users/vakrilov/gists{/gist_id}","starred_url":"https://api.github.com/users/vakrilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vakrilov/subscriptions","organizations_url":"https://api.github.com/users/vakrilov/orgs","repos_url":"https://api.github.com/users/vakrilov/repos","events_url":"https://api.github.com/users/vakrilov/events{/privacy}","received_events_url":"https://api.github.com/users/vakrilov/received_events","type":"User","site_admin":false},"assignees":[{"login":"SvetoslavTsenov","id":3598759,"node_id":"MDQ6VXNlcjM1OTg3NTk=","avatar_url":"https://avatars0.githubusercontent.com/u/3598759?v=4","gravatar_id":"","url":"https://api.github.com/users/SvetoslavTsenov","html_url":"https://github.com/SvetoslavTsenov","followers_url":"https://api.github.com/users/SvetoslavTsenov/followers","following_url":"https://api.github.com/users/SvetoslavTsenov/following{/other_user}","gists_url":"https://api.github.com/users/SvetoslavTsenov/gists{/gist_id}","starred_url":"https://api.github.com/users/SvetoslavTsenov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SvetoslavTsenov/subscriptions","organizations_url":"https://api.github.com/users/SvetoslavTsenov/orgs","repos_url":"https://api.github.com/users/SvetoslavTsenov/repos","events_url":"https://api.github.com/users/SvetoslavTsenov/events{/privacy}","received_events_url":"https://api.github.com/users/SvetoslavTsenov/received_events","type":"User","site_admin":false},{"login":"vakrilov","id":4092076,"node_id":"MDQ6VXNlcjQwOTIwNzY=","avatar_url":"https://avatars3.githubusercontent.com/u/4092076?v=4","gravatar_id":"","url":"https://api.github.com/users/vakrilov","html_url":"https://github.com/vakrilov","followers_url":"https://api.github.com/users/vakrilov/followers","following_url":"https://api.github.com/users/vakrilov/following{/other_user}","gists_url":"https://api.github.com/users/vakrilov/gists{/gist_id}","starred_url":"https://api.github.com/users/vakrilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vakrilov/subscriptions","organizations_url":"https://api.github.com/users/vakrilov/orgs","repos_url":"https://api.github.com/users/vakrilov/repos","events_url":"https://api.github.com/users/vakrilov/events{/privacy}","received_events_url":"https://api.github.com/users/vakrilov/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"MartoYankov","id":3806145,"node_id":"MDQ6VXNlcjM4MDYxNDU=","avatar_url":"https://avatars3.githubusercontent.com/u/3806145?v=4","gravatar_id":"","url":"https://api.github.com/users/MartoYankov","html_url":"https://github.com/MartoYankov","followers_url":"https://api.github.com/users/MartoYankov/followers","following_url":"https://api.github.com/users/MartoYankov/following{/other_user}","gists_url":"https://api.github.com/users/MartoYankov/gists{/gist_id}","starred_url":"https://api.github.com/users/MartoYankov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MartoYankov/subscriptions","organizations_url":"https://api.github.com/users/MartoYankov/orgs","repos_url":"https://api.github.com/users/MartoYankov/repos","events_url":"https://api.github.com/users/MartoYankov/events{/privacy}","received_events_url":"https://api.github.com/users/MartoYankov/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":203722174,"node_id":"MDU6TGFiZWwyMDM3MjIxNzQ=","url":"https://api.github.com/repos/NativeScript/NativeScript/labels/cla:%20yes","name":"cla: yes","color":"007241","default":false},{"id":203720953,"node_id":"MDU6TGFiZWwyMDM3MjA5NTM=","url":"https://api.github.com/repos/NativeScript/NativeScript/labels/in%20progress","name":"in progress","color":"ededed","default":false},{"id":656135855,"node_id":"MDU6TGFiZWw2NTYxMzU4NTU=","url":"https://api.github.com/repos/NativeScript/NativeScript/labels/%E2%99%A5%20community%20PR","name":"♥ community PR","color":"00AF64","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/NativeScript/NativeScript/pulls/6409/commits","review_comments_url":"https://api.github.com/repos/NativeScript/NativeScript/pulls/6409/comments","review_comment_url":"https://api.github.com/repos/NativeScript/NativeScript/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NativeScript/NativeScript/issues/6409/comments","statuses_url":"https://api.github.com/repos/NativeScript/NativeScript/statuses/7dcc2a11966c5d9df13b7d109196b4d5c09ef0ae","head":{"label":"surdu:modal-style","ref":"modal-style","sha":"7dcc2a11966c5d9df13b7d109196b4d5c09ef0ae","user":{"login":"surdu","id":11520795,"node_id":"MDQ6VXNlcjExNTIwNzk1","avatar_url":"https://avatars3.githubusercontent.com/u/11520795?v=4","gravatar_id":"","url":"https://api.github.com/users/surdu","html_url":"https://github.com/surdu","followers_url":"https://api.github.com/users/surdu/followers","following_url":"https://api.github.com/users/surdu/following{/other_user}","gists_url":"https://api.github.com/users/surdu/gists{/gist_id}","starred_url":"https://api.github.com/users/surdu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/surdu/subscriptions","organizations_url":"https://api.github.com/users/surdu/orgs","repos_url":"https://api.github.com/users/surdu/repos","events_url":"https://api.github.com/users/surdu/events{/privacy}","received_events_url":"https://api.github.com/users/surdu/received_events","type":"User","site_admin":false},"repo":{"id":152110095,"node_id":"MDEwOlJlcG9zaXRvcnkxNTIxMTAwOTU=","name":"NativeScript","full_name":"surdu/NativeScript","private":false,"owner":{"login":"surdu","id":11520795,"node_id":"MDQ6VXNlcjExNTIwNzk1","avatar_url":"https://avatars3.githubusercontent.com/u/11520795?v=4","gravatar_id":"","url":"https://api.github.com/users/surdu","html_url":"https://github.com/surdu","followers_url":"https://api.github.com/users/surdu/followers","following_url":"https://api.github.com/users/surdu/following{/other_user}","gists_url":"https://api.github.com/users/surdu/gists{/gist_id}","starred_url":"https://api.github.com/users/surdu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/surdu/subscriptions","organizations_url":"https://api.github.com/users/surdu/orgs","repos_url":"https://api.github.com/users/surdu/repos","events_url":"https://api.github.com/users/surdu/events{/privacy}","received_events_url":"https://api.github.com/users/surdu/received_events","type":"User","site_admin":false},"html_url":"https://github.com/surdu/NativeScript","description":"NativeScript is an open source framework for building truly native mobile apps with JavaScript. Use web skills, like Angular and Vue.js, FlexBox and CSS, and get native UI and performance on iOS and Android.","fork":true,"url":"https://api.github.com/repos/surdu/NativeScript","forks_url":"https://api.github.com/repos/surdu/NativeScript/forks","keys_url":"https://api.github.com/repos/surdu/NativeScript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/surdu/NativeScript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/surdu/NativeScript/teams","hooks_url":"https://api.github.com/repos/surdu/NativeScript/hooks","issue_events_url":"https://api.github.com/repos/surdu/NativeScript/issues/events{/number}","events_url":"https://api.github.com/repos/surdu/NativeScript/events","assignees_url":"https://api.github.com/repos/surdu/NativeScript/assignees{/user}","branches_url":"https://api.github.com/repos/surdu/NativeScript/branches{/branch}","tags_url":"https://api.github.com/repos/surdu/NativeScript/tags","blobs_url":"https://api.github.com/repos/surdu/NativeScript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/surdu/NativeScript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/surdu/NativeScript/git/refs{/sha}","trees_url":"https://api.github.com/repos/surdu/NativeScript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/surdu/NativeScript/statuses/{sha}","languages_url":"https://api.github.com/repos/surdu/NativeScript/languages","stargazers_url":"https://api.github.com/repos/surdu/NativeScript/stargazers","contributors_url":"https://api.github.com/repos/surdu/NativeScript/contributors","subscribers_url":"https://api.github.com/repos/surdu/NativeScript/subscribers","subscription_url":"https://api.github.com/repos/surdu/NativeScript/subscription","commits_url":"https://api.github.com/repos/surdu/NativeScript/commits{/sha}","git_commits_url":"https://api.github.com/repos/surdu/NativeScript/git/commits{/sha}","comments_url":"https://api.github.com/repos/surdu/NativeScript/comments{/number}","issue_comment_url":"https://api.github.com/repos/surdu/NativeScript/issues/comments{/number}","contents_url":"https://api.github.com/repos/surdu/NativeScript/contents/{+path}","compare_url":"https://api.github.com/repos/surdu/NativeScript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/surdu/NativeScript/merges","archive_url":"https://api.github.com/repos/surdu/NativeScript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/surdu/NativeScript/downloads","issues_url":"https://api.github.com/repos/surdu/NativeScript/issues{/number}","pulls_url":"https://api.github.com/repos/surdu/NativeScript/pulls{/number}","milestones_url":"https://api.github.com/repos/surdu/NativeScript/milestones{/number}","notifications_url":"https://api.github.com/repos/surdu/NativeScript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/surdu/NativeScript/labels{/name}","releases_url":"https://api.github.com/repos/surdu/NativeScript/releases{/id}","deployments_url":"https://api.github.com/repos/surdu/NativeScript/deployments","created_at":"2018-10-08T16:15:23Z","updated_at":"2018-10-19T20:22:41Z","pushed_at":"2018-12-13T14:28:12Z","git_url":"git://github.com/surdu/NativeScript.git","ssh_url":"git@github.com:surdu/NativeScript.git","clone_url":"https://github.com/surdu/NativeScript.git","svn_url":"https://github.com/surdu/NativeScript","homepage":"https://www.nativescript.org","size":28933,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NativeScript:master","ref":"master","sha":"44dba1a0b7bcbc0c4fb496595a48bcda9ef135ec","user":{"login":"NativeScript","id":7392261,"node_id":"MDEyOk9yZ2FuaXphdGlvbjczOTIyNjE=","avatar_url":"https://avatars1.githubusercontent.com/u/7392261?v=4","gravatar_id":"","url":"https://api.github.com/users/NativeScript","html_url":"https://github.com/NativeScript","followers_url":"https://api.github.com/users/NativeScript/followers","following_url":"https://api.github.com/users/NativeScript/following{/other_user}","gists_url":"https://api.github.com/users/NativeScript/gists{/gist_id}","starred_url":"https://api.github.com/users/NativeScript/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NativeScript/subscriptions","organizations_url":"https://api.github.com/users/NativeScript/orgs","repos_url":"https://api.github.com/users/NativeScript/repos","events_url":"https://api.github.com/users/NativeScript/events{/privacy}","received_events_url":"https://api.github.com/users/NativeScript/received_events","type":"Organization","site_admin":false},"repo":{"id":31492490,"node_id":"MDEwOlJlcG9zaXRvcnkzMTQ5MjQ5MA==","name":"NativeScript","full_name":"NativeScript/NativeScript","private":false,"owner":{"login":"NativeScript","id":7392261,"node_id":"MDEyOk9yZ2FuaXphdGlvbjczOTIyNjE=","avatar_url":"https://avatars1.githubusercontent.com/u/7392261?v=4","gravatar_id":"","url":"https://api.github.com/users/NativeScript","html_url":"https://github.com/NativeScript","followers_url":"https://api.github.com/users/NativeScript/followers","following_url":"https://api.github.com/users/NativeScript/following{/other_user}","gists_url":"https://api.github.com/users/NativeScript/gists{/gist_id}","starred_url":"https://api.github.com/users/NativeScript/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NativeScript/subscriptions","organizations_url":"https://api.github.com/users/NativeScript/orgs","repos_url":"https://api.github.com/users/NativeScript/repos","events_url":"https://api.github.com/users/NativeScript/events{/privacy}","received_events_url":"https://api.github.com/users/NativeScript/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/NativeScript/NativeScript","description":"NativeScript is an open source framework for building truly native mobile apps with JavaScript. Use web skills, like Angular and Vue.js, FlexBox and CSS, and get native UI and performance on iOS and Android.","fork":false,"url":"https://api.github.com/repos/NativeScript/NativeScript","forks_url":"https://api.github.com/repos/NativeScript/NativeScript/forks","keys_url":"https://api.github.com/repos/NativeScript/NativeScript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NativeScript/NativeScript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NativeScript/NativeScript/teams","hooks_url":"https://api.github.com/repos/NativeScript/NativeScript/hooks","issue_events_url":"https://api.github.com/repos/NativeScript/NativeScript/issues/events{/number}","events_url":"https://api.github.com/repos/NativeScript/NativeScript/events","assignees_url":"https://api.github.com/repos/NativeScript/NativeScript/assignees{/user}","branches_url":"https://api.github.com/repos/NativeScript/NativeScript/branches{/branch}","tags_url":"https://api.github.com/repos/NativeScript/NativeScript/tags","blobs_url":"https://api.github.com/repos/NativeScript/NativeScript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NativeScript/NativeScript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NativeScript/NativeScript/git/refs{/sha}","trees_url":"https://api.github.com/repos/NativeScript/NativeScript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NativeScript/NativeScript/statuses/{sha}","languages_url":"https://api.github.com/repos/NativeScript/NativeScript/languages","stargazers_url":"https://api.github.com/repos/NativeScript/NativeScript/stargazers","contributors_url":"https://api.github.com/repos/NativeScript/NativeScript/contributors","subscribers_url":"https://api.github.com/repos/NativeScript/NativeScript/subscribers","subscription_url":"https://api.github.com/repos/NativeScript/NativeScript/subscription","commits_url":"https://api.github.com/repos/NativeScript/NativeScript/commits{/sha}","git_commits_url":"https://api.github.com/repos/NativeScript/NativeScript/git/commits{/sha}","comments_url":"https://api.github.com/repos/NativeScript/NativeScript/comments{/number}","issue_comment_url":"https://api.github.com/repos/NativeScript/NativeScript/issues/comments{/number}","contents_url":"https://api.github.com/repos/NativeScript/NativeScript/contents/{+path}","compare_url":"https://api.github.com/repos/NativeScript/NativeScript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NativeScript/NativeScript/merges","archive_url":"https://api.github.com/repos/NativeScript/NativeScript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NativeScript/NativeScript/downloads","issues_url":"https://api.github.com/repos/NativeScript/NativeScript/issues{/number}","pulls_url":"https://api.github.com/repos/NativeScript/NativeScript/pulls{/number}","milestones_url":"https://api.github.com/repos/NativeScript/NativeScript/milestones{/number}","notifications_url":"https://api.github.com/repos/NativeScript/NativeScript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NativeScript/NativeScript/labels{/name}","releases_url":"https://api.github.com/repos/NativeScript/NativeScript/releases{/id}","deployments_url":"https://api.github.com/repos/NativeScript/NativeScript/deployments","created_at":"2015-03-01T09:47:08Z","updated_at":"2018-12-13T14:27:18Z","pushed_at":"2018-12-13T15:03:26Z","git_url":"git://github.com/NativeScript/NativeScript.git","ssh_url":"git@github.com:NativeScript/NativeScript.git","clone_url":"https://github.com/NativeScript/NativeScript.git","svn_url":"https://github.com/NativeScript/NativeScript","homepage":"https://www.nativescript.org","size":29454,"stargazers_count":15662,"watchers_count":15662,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1169,"mirror_url":null,"archived":false,"open_issues_count":403,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1169,"open_issues":403,"watchers":15662,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NativeScript/NativeScript/pulls/6409"},"html":{"href":"https://github.com/NativeScript/NativeScript/pull/6409"},"issue":{"href":"https://api.github.com/repos/NativeScript/NativeScript/issues/6409"},"comments":{"href":"https://api.github.com/repos/NativeScript/NativeScript/issues/6409/comments"},"review_comments":{"href":"https://api.github.com/repos/NativeScript/NativeScript/pulls/6409/comments"},"review_comment":{"href":"https://api.github.com/repos/NativeScript/NativeScript/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NativeScript/NativeScript/pulls/6409/commits"},"statuses":{"href":"https://api.github.com/repos/NativeScript/NativeScript/statuses/7dcc2a11966c5d9df13b7d109196b4d5c09ef0ae"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"vakrilov","id":4092076,"node_id":"MDQ6VXNlcjQwOTIwNzY=","avatar_url":"https://avatars3.githubusercontent.com/u/4092076?v=4","gravatar_id":"","url":"https://api.github.com/users/vakrilov","html_url":"https://github.com/vakrilov","followers_url":"https://api.github.com/users/vakrilov/followers","following_url":"https://api.github.com/users/vakrilov/following{/other_user}","gists_url":"https://api.github.com/users/vakrilov/gists{/gist_id}","starred_url":"https://api.github.com/users/vakrilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vakrilov/subscriptions","organizations_url":"https://api.github.com/users/vakrilov/orgs","repos_url":"https://api.github.com/users/vakrilov/repos","events_url":"https://api.github.com/users/vakrilov/events{/privacy}","received_events_url":"https://api.github.com/users/vakrilov/received_events","type":"User","site_admin":false},"comments":8,"review_comments":1,"maintainer_can_modify":false,"commits":12,"additions":263,"deletions":107,"changed_files":6}}
{"actor":{"display_login":"vakrilov"}}