{"action":"created","issue":{"url":"https://api.github.com/repos/CocoaPods/CocoaPods/issues/6401","repository_url":"https://api.github.com/repos/CocoaPods/CocoaPods","labels_url":"https://api.github.com/repos/CocoaPods/CocoaPods/issues/6401/labels{/name}","comments_url":"https://api.github.com/repos/CocoaPods/CocoaPods/issues/6401/comments","events_url":"https://api.github.com/repos/CocoaPods/CocoaPods/issues/6401/events","html_url":"https://github.com/CocoaPods/CocoaPods/pull/6401","id":200205111,"number":6401,"title":"[Generator] Replace -iquote by -isystem for frameworks in xcconfig","user":{"login":"guillaumealgis","id":1041337,"avatar_url":"https://avatars2.githubusercontent.com/u/1041337?v=4","gravatar_id":"","url":"https://api.github.com/users/guillaumealgis","html_url":"https://github.com/guillaumealgis","followers_url":"https://api.github.com/users/guillaumealgis/followers","following_url":"https://api.github.com/users/guillaumealgis/following{/other_user}","gists_url":"https://api.github.com/users/guillaumealgis/gists{/gist_id}","starred_url":"https://api.github.com/users/guillaumealgis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guillaumealgis/subscriptions","organizations_url":"https://api.github.com/users/guillaumealgis/orgs","repos_url":"https://api.github.com/users/guillaumealgis/repos","events_url":"https://api.github.com/users/guillaumealgis/events{/privacy}","received_events_url":"https://api.github.com/users/guillaumealgis/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":33,"created_at":"2017-01-11T20:55:48Z","updated_at":"2018-03-06T18:13:33Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/CocoaPods/CocoaPods/pulls/6401","html_url":"https://github.com/CocoaPods/CocoaPods/pull/6401","diff_url":"https://github.com/CocoaPods/CocoaPods/pull/6401.diff","patch_url":"https://github.com/CocoaPods/CocoaPods/pull/6401.patch"},"body":"🌈\r\n\r\n- Replace usage of the `-iquote` compiler flag by `-isystem` when searching for framework headers. This will silence compilation warning in the Pods' headers files.\r\n> \"Header files found in directories added to the search path with the `-isystem` and `-idirafter` command-line options are treated as system headers for the purposes of diagnostics\"\r\n> \"All warnings [...] are suppressed while GCC is processing a system header\"\r\n[https://gcc.gnu.org/onlinedocs/cpp/System-Headers.html](https://gcc.gnu.org/onlinedocs/cpp/System-Headers.html)\r\n\r\n- Update unit tests to reflect the above change.\r\n\r\nIntegrations tests are updated in https://github.com/CocoaPods/cocoapods-integration-specs/pull/94.\r\n\r\nThis fixes #5589.\r\n\r\nWhen I tested locally with `bundle exec rake spec:all`, it failed on the Alamofire example, but I *think* this is normal and the example was not updated for Xcode 8 (please correct me if I'm wrong). When running the same tests as Travis thought, everything passed.\r\n\r\n```\r\nbundle exec bacon spec/functional/command/cache/clean_spec.rb spec/unit/installer/pod_source_installer_spec.rb spec/unit/installer/xcode/pods_project_generator/target_installer_spec.rb spec/unit/target/pod_target_spec.rb spec/unit/validator_spec.rb spec/unit/installer/analyzer/pod_variant_set_spec.rb spec/unit/installer/xcode/pods_project_generator_spec.rb spec/unit/installer/pre_install_hooks_context_spec.rb spec/functional/command/ipc/list_spec.rb spec/unit/downloader/cache_spec.rb spec/functional/command/init_spec.rb spec/functional/command/spec_spec.rb spec/functional/command/install_spec.rb spec/functional/command_spec.rb spec/unit/sandbox/pod_dir_cleaner_spec.rb spec/unit/hooks_manager_spec.rb spec/unit/generator/module_map_spec.rb spec/unit/external_sources/abstract_external_source_spec.rb spec/functional/command/ipc/spec_spec.rb spec/unit/generator/header_spec.rb spec/unit/generator/acknowledgements/markdown_spec.rb spec/unit/external_sources/downloader_source_spec.rb spec/unit/installer/post_install_hooks_context_spec.rb spec/unit/installer/user_project_integrator/target_integrator/xcconfig_integrator_spec.rb spec/functional/command/repo/update_spec.rb spec/unit/generator/info_plist_file_spec.rb spec/unit/user_interface/inspector_reporter_spec.rb spec/unit/user_interface_spec.rb spec/unit/generator/dummy_source_spec.rb spec/unit/sandbox_spec.rb spec/functional/command/lib/create_spec.rb spec/unit/external_sources/path_source_spec.rb spec/functional/command/lib/list_spec.rb spec/unit/sandbox/file_accessor_spec.rb spec/unit/config_spec.rb spec/unit/user_interface/error_report_spec.rb spec/unit/generator/prefix_header_spec.rb spec/unit/installer_spec.rb spec/functional/user_interface_spec.rb spec/unit/sandbox/podspec_finder_spec.rb spec/unit/command_spec.rb spec/unit/installer/xcode/pods_project_generator/file_references_installer_spec.rb spec/functional/command/repo/push_spec.rb spec/functional/command/repo_spec.rb spec/unit/executable_spec.rb spec/unit/generator/embed_frameworks_script_spec.rb spec/unit/external_sources/podspec_source_spec.rb spec/unit/installer/analyzer/target_inspector_spec.rb spec/functional/command/repo/lint_spec.rb spec/functional/command/outdated_spec.rb spec/unit/generator/acknowledgements_spec.rb spec/functional/command/setup_spec.rb spec/unit/installer/podfile_validator_spec.rb spec/functional/command/cache/list_spec.rb spec/functional/command/update_spec.rb spec/unit/generator/xcconfig/pod_xcconfig_spec.rb spec/functional/command/ipc/update_search_index_spec.rb spec/unit/downloader_spec.rb spec/unit/installer/installation_options_spec.rb spec/functional/command/list_spec.rb spec/unit/installer/analyzer/pod_variant_spec.rb spec/unit/installer/user_project_integrator_spec.rb spec/unit/generator/copy_resources_script_spec.rb spec/unit/target_spec.rb spec/unit/project_spec.rb spec/unit/installer/source_provider_hooks_context_spec.rb spec/unit/downloader/request_spec.rb spec/unit/installer/xcode/pods_project_generator/aggregate_target_installer_spec.rb spec/unit/installer/analyzer/sandbox_analyzer_spec.rb spec/functional/command/repo/list_spec.rb spec/unit/target/aggregate_target_spec.rb spec/unit/installer/analyzer_spec.rb spec/unit/installer/user_project_integrator/target_integrator_spec.rb spec/functional/command/repo/remove_spec.rb spec/functional/command/repo/add_spec.rb spec/unit/sandbox/headers_store_spec.rb spec/unit/installer/xcode/pods_project_generator/pod_target_installer_spec.rb spec/unit/sources_manager_spec.rb spec/unit/generator/xcconfig_spec.rb spec/unit/resolver_spec.rb spec/unit/generator/xcconfig/aggregate_xcconfig_spec.rb spec/unit/external_sources_spec.rb spec/unit/generator/bridge_support_spec.rb spec/functional/command/ipc/repl_spec.rb spec/unit/generator/acknowledgements/plist_spec.rb spec/unit/sandbox/path_list_spec.rb spec/functional/command/ipc/podfile_spec.rb spec/unit/generator/xcconfig/xcconfig_helper_spec.rb spec/unit/library_spec.rb\r\n```\r\n\r\nThis is my first PR to CocoaPods, please let me know if I missed anything 👍"},"comment":{"url":"https://api.github.com/repos/CocoaPods/CocoaPods/issues/comments/370875506","html_url":"https://github.com/CocoaPods/CocoaPods/pull/6401#issuecomment-370875506","issue_url":"https://api.github.com/repos/CocoaPods/CocoaPods/issues/6401","id":370875506,"user":{"login":"guillaumealgis","id":1041337,"avatar_url":"https://avatars2.githubusercontent.com/u/1041337?v=4","gravatar_id":"","url":"https://api.github.com/users/guillaumealgis","html_url":"https://github.com/guillaumealgis","followers_url":"https://api.github.com/users/guillaumealgis/followers","following_url":"https://api.github.com/users/guillaumealgis/following{/other_user}","gists_url":"https://api.github.com/users/guillaumealgis/gists{/gist_id}","starred_url":"https://api.github.com/users/guillaumealgis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guillaumealgis/subscriptions","organizations_url":"https://api.github.com/users/guillaumealgis/orgs","repos_url":"https://api.github.com/users/guillaumealgis/repos","events_url":"https://api.github.com/users/guillaumealgis/events{/privacy}","received_events_url":"https://api.github.com/users/guillaumealgis/received_events","type":"User","site_admin":false},"created_at":"2018-03-06T18:13:32Z","updated_at":"2018-03-06T18:13:32Z","author_association":"NONE","body":"Here you go @dnkoutso, should be good now.\r\n\r\nNote that :\r\n- 968877a should be removed before merging\r\n- the changes in the integration specs are done on top of the branch `seg-fix-storing-headers` (because I needed these fixes too) https://github.com/CocoaPods/cocoapods-integration-specs/tree/seg-fix-storing-headers\r\n\r\n\r\nI tested the changes on our (closed-source) project's moderately complex Podfile, and everything worked fine :\r\n\r\n<details>\r\n<summary>Podfile</summary>\r\n\r\n    source 'https://github.com/CocoaPods/Specs.git'\r\n\r\n    platform :ios, '10.0'\r\n    use_frameworks!\r\n    inhibit_all_warnings!\r\n\r\n    target 'Foo' do\r\n        libextobjc_version = '0.4.1'\r\n        pod 'libextobjc/EXTKeyPathCoding', libextobjc_version\r\n        pod 'libextobjc/EXTScope', libextobjc_version\r\n\r\n        pod 'PSPDFKit', podspec:'https://customers.pspdfkit.com/cocoapods/<REDACTED>/pspdfkit/6.9.2.podspec'\r\n\r\n        pod 'Crashlytics', '3.8.4'\r\n        pod 'DejalActivityView', '1.2'\r\n        pod 'Fabric', '1.6.11'\r\n        pod 'GDIIndexBar', '0.3.5'\r\n        pod 'handlebars-objc', '1.4.4'\r\n        pod 'iCarousel', '1.8.3'\r\n        pod 'JDStatusBarNotification', '1.5.5'\r\n        pod 'JRSwizzle', '1.0'\r\n        pod 'Masonry', '1.0.2'\r\n        pod 'MBProgressHUD', '1.0.0'\r\n        pod 'MMDrawerController', '0.6.0'\r\n        pod 'MPColorTools', '1.6.1'\r\n        pod 'NJKWebViewProgress', '0.2.3'\r\n        pod 'Ono', '1.2.2'\r\n        pod 'OrderedDictionary', '1.4'\r\n        pod 'PBWebViewController', '0.4'\r\n        pod 'Reachability', '3.2'\r\n        pod 'Shimmer', '1.0.2'\r\n        pod 'UIView+Shake', '1.3.0'\r\n\r\n        pod 'Reveal-SDK', :configurations => ['Debug']\r\n\r\n        pod 'NSAttributedStringMarkdownParser', :git => 'https://github.com/ipsosante/markdown.git', :branch => 'master'\r\n        pod 'TOCropViewController', :git => 'https://github.com/ipsosante/TOCropViewController.git', :branch => 'master'\r\n        pod 'MCPanelViewController', :git => 'https://github.com/ipsosante/MCPanelViewController.git', :branch => 'master'\r\n    end\r\n</details>"}}
{"actor":{"display_login":"guillaumealgis"}}