{"action":"created","issue":{"url":"https://api.github.com/repos/grame-cncm/faust/issues/150","repository_url":"https://api.github.com/repos/grame-cncm/faust","labels_url":"https://api.github.com/repos/grame-cncm/faust/issues/150/labels{/name}","comments_url":"https://api.github.com/repos/grame-cncm/faust/issues/150/comments","events_url":"https://api.github.com/repos/grame-cncm/faust/issues/150/events","html_url":"https://github.com/grame-cncm/faust/issues/150","id":304182380,"number":150,"title":"want to add to the library","user":{"login":"magnetophon","id":7645711,"avatar_url":"https://avatars0.githubusercontent.com/u/7645711?v=4","gravatar_id":"","url":"https://api.github.com/users/magnetophon","html_url":"https://github.com/magnetophon","followers_url":"https://api.github.com/users/magnetophon/followers","following_url":"https://api.github.com/users/magnetophon/following{/other_user}","gists_url":"https://api.github.com/users/magnetophon/gists{/gist_id}","starred_url":"https://api.github.com/users/magnetophon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magnetophon/subscriptions","organizations_url":"https://api.github.com/users/magnetophon/orgs","repos_url":"https://api.github.com/users/magnetophon/repos","events_url":"https://api.github.com/users/magnetophon/events{/privacy}","received_events_url":"https://api.github.com/users/magnetophon/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":14,"created_at":"2018-03-11T18:42:42Z","updated_at":"2018-03-24T17:29:30Z","closed_at":null,"author_association":"NONE","body":"I'd like to add most of [faustCompressors](https://github.com/magnetophon/faustCompressors/) to the library.\r\n\r\nIf possible, I'd like it to include proper comment and explanation, in particular for the ``slidingReduce`` function that lays at the base of it, because without, that code is unreadable.\r\nI had trouble understanding my own code, using the comments I wrote 2 years ago, so I re-wrote them.\r\n\r\nMy questions are:\r\n- Would you agree good comments are desireable in the library?\r\n- Does [this explanation](https://github.com/magnetophon/faustCompressors/blob/master/slidingReduce.lib) make sense?\r\n- anything I should add/remove?\r\n- the code in the \"working principle\" block is not needed for the library itself, and just serves educational purposes. Maybe I should comment it out?\r\n- is GPLv3 OK?\r\n\r\nps: Thanks @rmichon for encouraging me to add this to the libs.  I still postponed it for way too long afterwards, mainly because of the above issues..."},"comment":{"url":"https://api.github.com/repos/grame-cncm/faust/issues/comments/375910314","html_url":"https://github.com/grame-cncm/faust/issues/150#issuecomment-375910314","issue_url":"https://api.github.com/repos/grame-cncm/faust/issues/150","id":375910314,"user":{"login":"rmichon","id":3201552,"avatar_url":"https://avatars1.githubusercontent.com/u/3201552?v=4","gravatar_id":"","url":"https://api.github.com/users/rmichon","html_url":"https://github.com/rmichon","followers_url":"https://api.github.com/users/rmichon/followers","following_url":"https://api.github.com/users/rmichon/following{/other_user}","gists_url":"https://api.github.com/users/rmichon/gists{/gist_id}","starred_url":"https://api.github.com/users/rmichon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmichon/subscriptions","organizations_url":"https://api.github.com/users/rmichon/orgs","repos_url":"https://api.github.com/users/rmichon/repos","events_url":"https://api.github.com/users/rmichon/events{/privacy}","received_events_url":"https://api.github.com/users/rmichon/received_events","type":"User","site_admin":false},"created_at":"2018-03-24T17:29:30Z","updated_at":"2018-03-24T17:29:30Z","author_association":"COLLABORATOR","body":"@sletz +1\r\n\r\n@magnetophon I merged your PR here: https://github.com/grame-cncm/faustlibraries/commit/521c28637a2954b53b2b432675a6a7a21228fe02\r\n\r\nI'll let you figure out the potential naming conflicts with @josmithiii but I would personally vote for not barking backward compatibility simply by using different names as Julius suggested. @magnetophon just make a PR to add your compressor functions. I'll review it and I'll make some adjustments if necessary. Moving forward, that's all really great!  "}}
{"actor":{"display_login":"rmichon"}}