{"action":"created","issue":{"url":"https://api.github.com/repos/HDF-NI/hdf5.node/issues/98","repository_url":"https://api.github.com/repos/HDF-NI/hdf5.node","labels_url":"https://api.github.com/repos/HDF-NI/hdf5.node/issues/98/labels{/name}","comments_url":"https://api.github.com/repos/HDF-NI/hdf5.node/issues/98/comments","events_url":"https://api.github.com/repos/HDF-NI/hdf5.node/issues/98/events","html_url":"https://github.com/HDF-NI/hdf5.node/issues/98","id":388493241,"node_id":"MDU6SXNzdWUzODg0OTMyNDE=","number":98,"title":"windows-build-tools / vs2017?","user":{"login":"chadbr","id":3179452,"node_id":"MDQ6VXNlcjMxNzk0NTI=","avatar_url":"https://avatars2.githubusercontent.com/u/3179452?v=4","gravatar_id":"","url":"https://api.github.com/users/chadbr","html_url":"https://github.com/chadbr","followers_url":"https://api.github.com/users/chadbr/followers","following_url":"https://api.github.com/users/chadbr/following{/other_user}","gists_url":"https://api.github.com/users/chadbr/gists{/gist_id}","starred_url":"https://api.github.com/users/chadbr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chadbr/subscriptions","organizations_url":"https://api.github.com/users/chadbr/orgs","repos_url":"https://api.github.com/users/chadbr/repos","events_url":"https://api.github.com/users/chadbr/events{/privacy}","received_events_url":"https://api.github.com/users/chadbr/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":25,"created_at":"2018-12-07T03:39:17Z","updated_at":"2018-12-17T19:53:08Z","closed_at":null,"author_association":"NONE","body":"using https://www.npmjs.com/package/windows-build-tools\r\n\r\ninstalling the default windows-build-tools `npm install -g windows-build-tools` installs vs2017 build infrastructure. Is there any reason hdf5.node shouldn't be configured to use this build install? \r\n\r\nThis is the log from trying to install it:\r\n\r\n```\r\nC:\\dev\\simulator-service\\node_modules\\hdf5>if not defined npm_config_node_gyp (node \"C:\\Program Files\\nodejs\\node_modules\\npm\\bin\\node-gyp-bin\\\\..\\..\\node_modules\\node-gyp\\bin\\node-gyp.js\" rebuild --jobs max )  else (node \"\" rebuild --jobs max )\r\ngyp info it worked if it ends with ok\r\ngyp info using node-gyp@3.8.0\r\ngyp info using node@10.14.1 | win32 | x64\r\ngyp info spawn C:\\Users\\chadb\\.windows-build-tools\\python27\\python.EXE\r\ngyp info spawn args [ 'C:\\\\Program Files\\\\nodejs\\\\node_modules\\\\npm\\\\node_modules\\\\node-gyp\\\\gyp\\\\gyp_main.py',\r\ngyp info spawn args   'binding.gyp',\r\ngyp info spawn args   '-f',\r\ngyp info spawn args   'msvs',\r\ngyp info spawn args   '-G',\r\ngyp info spawn args   'msvs_version=2015',\r\ngyp info spawn args   '-I',\r\ngyp info spawn args   'C:\\\\dev\\\\simulator-service\\\\node_modules\\\\hdf5\\\\build\\\\config.gypi',\r\ngyp info spawn args   '-I',\r\ngyp info spawn args   'C:\\\\Program Files\\\\nodejs\\\\node_modules\\\\npm\\\\node_modules\\\\node-gyp\\\\addon.gypi',\r\ngyp info spawn args   '-I',\r\ngyp info spawn args   'C:\\\\Users\\\\chadb\\\\.node-gyp\\\\10.14.1\\\\include\\\\node\\\\common.gypi',\r\ngyp info spawn args   '-Dlibrary=shared_library',\r\ngyp info spawn args   '-Dvisibility=default',\r\ngyp info spawn args   '-Dnode_root_dir=C:\\\\Users\\\\chadb\\\\.node-gyp\\\\10.14.1',\r\ngyp info spawn args   '-Dnode_gyp_dir=C:\\\\Program Files\\\\nodejs\\\\node_modules\\\\npm\\\\node_modules\\\\node-gyp',\r\ngyp info spawn args   '-Dnode_lib_file=C:\\\\Users\\\\chadb\\\\.node-gyp\\\\10.14.1\\\\<(target_arch)\\\\node.lib',\r\ngyp info spawn args   '-Dmodule_root_dir=C:\\\\dev\\\\simulator-service\\\\node_modules\\\\hdf5',\r\ngyp info spawn args   '-Dnode_engine=v8',\r\ngyp info spawn args   '--depth=.',\r\ngyp info spawn args   '--no-parallel',\r\ngyp info spawn args   '--generator-output',\r\ngyp info spawn args   'C:\\\\dev\\\\simulator-service\\\\node_modules\\\\hdf5\\\\build',\r\ngyp info spawn args   '-Goutput_dir=.' ]\r\ngyp info spawn C:\\Program Files (x86)\\Microsoft Visual Studio\\2017\\BuildTools\\MSBuild\\15.0\\Bin\\MSBuild.exe\r\ngyp info spawn args [ 'build/binding.sln',\r\ngyp info spawn args   '/clp:Verbosity=minimal',\r\ngyp info spawn args   '/nologo',\r\ngyp info spawn args   '/p:Configuration=Release;Platform=x64',\r\ngyp info spawn args   '/m:8' ]\r\nC:\\Program Files (x86)\\Microsoft Visual Studio\\2017\\BuildTools\\Common7\\IDE\\VC\\VCTargets\\Microsoft.Cpp.Platform.targets(67,5): error MSB8020: The build tools for v120 (Platform Toolset = 'v120') cannot be found. To build using the v120 build tools, please install v120 build tools.  Alternatively, you may upgrade to the current Visual Studio tools by selecting the Project menu or right-click the solution, and then selecting \"Retarget solution\". [C:\\dev\\simulator-service\\node_modules\\hdf5\\build\\h5ds.vcxproj]\r\nC:\\Program Files (x86)\\Microsoft Visual Studio\\2017\\BuildTools\\Common7\\IDE\\VC\\VCTargets\\Microsoft.Cpp.Platform.targets(67,5): error MSB8020: The build tools for v120 (Platform Toolset = 'v120') cannot be found. To build using the v120 build tools, please install v120 build tools.  Alternatively, you may upgrade to the current Visual Studio tools by selecting the Project menu or right-click the solution, and then selecting \"Retarget solution\". [C:\\dev\\simulator-service\\node_modules\\hdf5\\build\\h5im.vcxproj]\r\nC:\\Program Files (x86)\\Microsoft Visual Studio\\2017\\BuildTools\\Common7\\IDE\\VC\\VCTargets\\Microsoft.Cpp.Platform.targets(67,5): error MSB8020: The build tools for v120 (Platform Toolset = 'v120') cannot be found. To build using the v120 build tools, please install v120 build tools.  Alternatively, you may upgrade to the current Visual Studio tools by selecting the Project menu or right-click the solution, and then selecting \"Retarget solution\". [C:\\dev\\simulator-service\\node_modules\\hdf5\\build\\h5lt.vcxproj]\r\nC:\\Program Files (x86)\\Microsoft Visual Studio\\2017\\BuildTools\\Common7\\IDE\\VC\\VCTargets\\Microsoft.Cpp.Platform.targets(67,5): error MSB8020: The build tools for v120 (Platform Toolset = 'v120') cannot be found. To build using the v120 build tools, please install v120 build tools.  Alternatively, you may upgrade to the current Visual Studio tools by selecting the Project menu or right-click the solution, and then selecting \"Retarget solution\". [C:\\dev\\simulator-service\\node_modules\\hdf5\\build\\h5pt.vcxproj]\r\nC:\\Program Files (x86)\\Microsoft Visual Studio\\2017\\BuildTools\\Common7\\IDE\\VC\\VCTargets\\Microsoft.Cpp.Platform.targets(67,5): error MSB8020: The build tools for v120 (Platform Toolset = 'v120') cannot be found. To build using the v120 build tools, please install v120 build tools.  Alternatively, you may upgrade to the current Visual Studio tools by selecting the Project menu or right-click the solution, and then selecting \"Retarget solution\". [C:\\dev\\simulator-service\\node_modules\\hdf5\\build\\h5tb.vcxproj]\r\nC:\\Program Files (x86)\\Microsoft Visual Studio\\2017\\BuildTools\\Common7\\IDE\\VC\\VCTargets\\Microsoft.Cpp.Platform.targets(67,5): error MSB8020: The build tools for v120 (Platform Toolset = 'v120') cannot be found. To build using the v120 build tools, please install v120 build tools.  Alternatively, you may upgrade to the current Visual Studio tools by selecting the Project menu or right-click the solution, and then selecting \"Retarget solution\". [C:\\dev\\simulator-service\\node_modules\\hdf5\\build\\hdf5.vcxproj]\r\ngyp ERR! build error\r\ngyp ERR! stack Error: `C:\\Program Files (x86)\\Microsoft Visual Studio\\2017\\BuildTools\\MSBuild\\15.0\\Bin\\MSBuild.exe` failed with exit code: 1\r\ngyp ERR! stack     at ChildProcess.onExit (C:\\Program Files\\nodejs\\node_modules\\npm\\node_modules\\node-gyp\\lib\\build.js:262:23)\r\ngyp ERR! stack     at ChildProcess.emit (events.js:182:13)\r\ngyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:240:12)\r\ngyp ERR! System Windows_NT 10.0.18290\r\ngyp ERR! command \"C:\\\\Program Files\\\\nodejs\\\\node.exe\" \"C:\\\\Program Files\\\\nodejs\\\\node_modules\\\\npm\\\\node_modules\\\\node-gyp\\\\bin\\\\node-gyp.js\" \"rebuild\" \"--jobs\" \"max\"\r\ngyp ERR! cwd C:\\dev\\simulator-service\\node_modules\\hdf5\r\ngyp ERR! node -v v10.14.1\r\n\r\n```\r\nThey have an option for installing vs2015 tools -- I'll try that now... but any reason it shouldn't be bumped up now that MS packages it all up for npm now?\r\n\r\nThanks! Chad\r\n"},"comment":{"url":"https://api.github.com/repos/HDF-NI/hdf5.node/issues/comments/447976411","html_url":"https://github.com/HDF-NI/hdf5.node/issues/98#issuecomment-447976411","issue_url":"https://api.github.com/repos/HDF-NI/hdf5.node/issues/98","id":447976411,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0Nzk3NjQxMQ==","user":{"login":"rimmartin","id":6502360,"node_id":"MDQ6VXNlcjY1MDIzNjA=","avatar_url":"https://avatars1.githubusercontent.com/u/6502360?v=4","gravatar_id":"","url":"https://api.github.com/users/rimmartin","html_url":"https://github.com/rimmartin","followers_url":"https://api.github.com/users/rimmartin/followers","following_url":"https://api.github.com/users/rimmartin/following{/other_user}","gists_url":"https://api.github.com/users/rimmartin/gists{/gist_id}","starred_url":"https://api.github.com/users/rimmartin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rimmartin/subscriptions","organizations_url":"https://api.github.com/users/rimmartin/orgs","repos_url":"https://api.github.com/users/rimmartin/repos","events_url":"https://api.github.com/users/rimmartin/events{/privacy}","received_events_url":"https://api.github.com/users/rimmartin/received_events","type":"User","site_admin":false},"created_at":"2018-12-17T19:53:08Z","updated_at":"2018-12-17T19:53:08Z","author_association":"COLLABORATOR","body":"No sorries @chadbr :-)  I'm busy too"}}
{"actor":{"display_login":"rimmartin"}}