{"action":"created","comment":{"url":"https://api.github.com/repos/Carthage/Carthage/pulls/comments/227879278","pull_request_review_id":168020336,"id":227879278,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNzg3OTI3OA==","diff_hunk":"@@ -303,21 +304,35 @@ public func createVersionFileForCommitish(\n \t\tplatformCaches[platform.rawValue] = []\n \t}\n \n+\tstruct FrameworkDetail {\n+\t\tlet platformName: String\n+\t\tlet frameworkName: String\n+\t\tlet frameworkSwiftVersion: String\n+\t}\n+\n \tif !buildProducts.isEmpty {\n \t\treturn SignalProducer<URL, CarthageError>(buildProducts)\n-\t\t\t.flatMap(.merge) { url -> SignalProducer<(String, (String, String)), CarthageError> in\n+\t\t\t.flatMap(.merge) { url -> SignalProducer<(String, FrameworkDetail), CarthageError> in\n \t\t\t\tlet frameworkName = url.deletingPathExtension().lastPathComponent\n \t\t\t\tlet platformName = url.deletingLastPathComponent().lastPathComponent\n-\t\t\t\tlet frameworkURL = url.appendingPathComponent(frameworkName, isDirectory: false)\n-\t\t\t\tlet details = SignalProducer<(String, String), CarthageError>(value: (platformName, frameworkName))\n-\t\t\t\treturn SignalProducer.zip(hashForFileAtURL(frameworkURL), details)\n+\t\t\t\treturn frameworkSwiftVersion(url)","path":"Source/CarthageKit/VersionFile.swift","position":40,"original_position":40,"commit_id":"3d6c8b55fe5b9479a3c165e4a7c11d85b2c3a388","original_commit_id":"3d6c8b55fe5b9479a3c165e4a7c11d85b2c3a388","user":{"login":"blender","id":196761,"node_id":"MDQ6VXNlcjE5Njc2MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/196761?v=4","gravatar_id":"","url":"https://api.github.com/users/blender","html_url":"https://github.com/blender","followers_url":"https://api.github.com/users/blender/followers","following_url":"https://api.github.com/users/blender/following{/other_user}","gists_url":"https://api.github.com/users/blender/gists{/gist_id}","starred_url":"https://api.github.com/users/blender/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blender/subscriptions","organizations_url":"https://api.github.com/users/blender/orgs","repos_url":"https://api.github.com/users/blender/repos","events_url":"https://api.github.com/users/blender/events{/privacy}","received_events_url":"https://api.github.com/users/blender/received_events","type":"User","site_admin":false},"body":"probably this will change: see #2622 \r\n\r\nDon't worry just yet","created_at":"2018-10-24T17:07:59Z","updated_at":"2018-10-24T17:11:27Z","html_url":"https://github.com/Carthage/Carthage/pull/2585#discussion_r227879278","pull_request_url":"https://api.github.com/repos/Carthage/Carthage/pulls/2585","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Carthage/Carthage/pulls/comments/227879278"},"html":{"href":"https://github.com/Carthage/Carthage/pull/2585#discussion_r227879278"},"pull_request":{"href":"https://api.github.com/repos/Carthage/Carthage/pulls/2585"}}},"pull_request":{"url":"https://api.github.com/repos/Carthage/Carthage/pulls/2585","id":216922925,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2OTIyOTI1","html_url":"https://github.com/Carthage/Carthage/pull/2585","diff_url":"https://github.com/Carthage/Carthage/pull/2585.diff","patch_url":"https://github.com/Carthage/Carthage/pull/2585.patch","issue_url":"https://api.github.com/repos/Carthage/Carthage/issues/2585","number":2585,"state":"open","locked":false,"title":"Add Xcode version information to VersionFile","user":{"login":"giginet","id":147051,"node_id":"MDQ6VXNlcjE0NzA1MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/147051?v=4","gravatar_id":"","url":"https://api.github.com/users/giginet","html_url":"https://github.com/giginet","followers_url":"https://api.github.com/users/giginet/followers","following_url":"https://api.github.com/users/giginet/following{/other_user}","gists_url":"https://api.github.com/users/giginet/gists{/gist_id}","starred_url":"https://api.github.com/users/giginet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giginet/subscriptions","organizations_url":"https://api.github.com/users/giginet/orgs","repos_url":"https://api.github.com/users/giginet/repos","events_url":"https://api.github.com/users/giginet/events{/privacy}","received_events_url":"https://api.github.com/users/giginet/received_events","type":"User","site_admin":false},"body":"## Motivation & Context\r\n\r\nI want to use [`carthage-verify`](https://github.com/Carthage/workflows/blob/master/carthage-verify) on workflows to skip duplicated builds.\r\n\r\nHowever, current `.Package.version` file doesn't contains Xcode version information.\r\nSo we can't detect which Xcode version is used to build.\r\n\r\nI added `xcodeVersion` to VersionFile.\r\nThanks to this PR, we can detect whether Xcode version is changed or not.\r\n\r\n```json\r\n{\r\n  \"commitish\" : \"3.2.0\",\r\n  \"iOS\" : [\r\n    {\r\n      \"name\" : \"Himotoki\",\r\n      \"hash\" : \"1ab62a1d2a04eb8fdc00d9ed2a843d4a944789eeda0b4ac8250462995754c825\",\r\n      \"swiftVersion\" : \"4.2 (swiftlang-1000.11.37.1 clang-1000.11.45.1)\"\r\n    }\r\n  ]\r\n}\r\n```\r\n\r\nIf this value is different with current `xcodebuild --version`, `carthage-verify` have to try to rebuild the package.\r\n\r\n## Description\r\n\r\nI added `XcodeVersion` to `VersionFile`.\r\n\r\nYou can try this feature like following:\r\n\r\n```console\r\n$ carthage build --platform iOS\r\n$ cat Carthage/Build/.Himotoki.version\r\n```\r\n\r\n`xcodeVersion` is optional. So backward-compatibility is well.","created_at":"2018-09-20T10:34:34Z","updated_at":"2018-10-24T17:11:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"38d43f7d10c704873db5d311062d6484d4ded68c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Carthage/Carthage/pulls/2585/commits","review_comments_url":"https://api.github.com/repos/Carthage/Carthage/pulls/2585/comments","review_comment_url":"https://api.github.com/repos/Carthage/Carthage/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Carthage/Carthage/issues/2585/comments","statuses_url":"https://api.github.com/repos/Carthage/Carthage/statuses/3d6c8b55fe5b9479a3c165e4a7c11d85b2c3a388","head":{"label":"giginet:add-xcode-version-to-build-version","ref":"add-xcode-version-to-build-version","sha":"3d6c8b55fe5b9479a3c165e4a7c11d85b2c3a388","user":{"login":"giginet","id":147051,"node_id":"MDQ6VXNlcjE0NzA1MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/147051?v=4","gravatar_id":"","url":"https://api.github.com/users/giginet","html_url":"https://github.com/giginet","followers_url":"https://api.github.com/users/giginet/followers","following_url":"https://api.github.com/users/giginet/following{/other_user}","gists_url":"https://api.github.com/users/giginet/gists{/gist_id}","starred_url":"https://api.github.com/users/giginet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giginet/subscriptions","organizations_url":"https://api.github.com/users/giginet/orgs","repos_url":"https://api.github.com/users/giginet/repos","events_url":"https://api.github.com/users/giginet/events{/privacy}","received_events_url":"https://api.github.com/users/giginet/received_events","type":"User","site_admin":false},"repo":{"id":69113117,"node_id":"MDEwOlJlcG9zaXRvcnk2OTExMzExNw==","name":"Carthage","full_name":"giginet/Carthage","private":false,"owner":{"login":"giginet","id":147051,"node_id":"MDQ6VXNlcjE0NzA1MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/147051?v=4","gravatar_id":"","url":"https://api.github.com/users/giginet","html_url":"https://github.com/giginet","followers_url":"https://api.github.com/users/giginet/followers","following_url":"https://api.github.com/users/giginet/following{/other_user}","gists_url":"https://api.github.com/users/giginet/gists{/gist_id}","starred_url":"https://api.github.com/users/giginet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giginet/subscriptions","organizations_url":"https://api.github.com/users/giginet/orgs","repos_url":"https://api.github.com/users/giginet/repos","events_url":"https://api.github.com/users/giginet/events{/privacy}","received_events_url":"https://api.github.com/users/giginet/received_events","type":"User","site_admin":false},"html_url":"https://github.com/giginet/Carthage","description":"A simple, decentralized dependency manager for Cocoa","fork":true,"url":"https://api.github.com/repos/giginet/Carthage","forks_url":"https://api.github.com/repos/giginet/Carthage/forks","keys_url":"https://api.github.com/repos/giginet/Carthage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/giginet/Carthage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/giginet/Carthage/teams","hooks_url":"https://api.github.com/repos/giginet/Carthage/hooks","issue_events_url":"https://api.github.com/repos/giginet/Carthage/issues/events{/number}","events_url":"https://api.github.com/repos/giginet/Carthage/events","assignees_url":"https://api.github.com/repos/giginet/Carthage/assignees{/user}","branches_url":"https://api.github.com/repos/giginet/Carthage/branches{/branch}","tags_url":"https://api.github.com/repos/giginet/Carthage/tags","blobs_url":"https://api.github.com/repos/giginet/Carthage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/giginet/Carthage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/giginet/Carthage/git/refs{/sha}","trees_url":"https://api.github.com/repos/giginet/Carthage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/giginet/Carthage/statuses/{sha}","languages_url":"https://api.github.com/repos/giginet/Carthage/languages","stargazers_url":"https://api.github.com/repos/giginet/Carthage/stargazers","contributors_url":"https://api.github.com/repos/giginet/Carthage/contributors","subscribers_url":"https://api.github.com/repos/giginet/Carthage/subscribers","subscription_url":"https://api.github.com/repos/giginet/Carthage/subscription","commits_url":"https://api.github.com/repos/giginet/Carthage/commits{/sha}","git_commits_url":"https://api.github.com/repos/giginet/Carthage/git/commits{/sha}","comments_url":"https://api.github.com/repos/giginet/Carthage/comments{/number}","issue_comment_url":"https://api.github.com/repos/giginet/Carthage/issues/comments{/number}","contents_url":"https://api.github.com/repos/giginet/Carthage/contents/{+path}","compare_url":"https://api.github.com/repos/giginet/Carthage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/giginet/Carthage/merges","archive_url":"https://api.github.com/repos/giginet/Carthage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/giginet/Carthage/downloads","issues_url":"https://api.github.com/repos/giginet/Carthage/issues{/number}","pulls_url":"https://api.github.com/repos/giginet/Carthage/pulls{/number}","milestones_url":"https://api.github.com/repos/giginet/Carthage/milestones{/number}","notifications_url":"https://api.github.com/repos/giginet/Carthage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/giginet/Carthage/labels{/name}","releases_url":"https://api.github.com/repos/giginet/Carthage/releases{/id}","deployments_url":"https://api.github.com/repos/giginet/Carthage/deployments","created_at":"2016-09-24T16:14:46Z","updated_at":"2016-09-24T16:14:47Z","pushed_at":"2018-10-24T16:13:29Z","git_url":"git://github.com/giginet/Carthage.git","ssh_url":"git@github.com:giginet/Carthage.git","clone_url":"https://github.com/giginet/Carthage.git","svn_url":"https://github.com/giginet/Carthage","homepage":"","size":18651,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Carthage:master","ref":"master","sha":"380d492480a785c706e15c3d2527a881ed8fcbf3","user":{"login":"Carthage","id":9146792,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDY3OTI=","avatar_url":"https://avatars1.githubusercontent.com/u/9146792?v=4","gravatar_id":"","url":"https://api.github.com/users/Carthage","html_url":"https://github.com/Carthage","followers_url":"https://api.github.com/users/Carthage/followers","following_url":"https://api.github.com/users/Carthage/following{/other_user}","gists_url":"https://api.github.com/users/Carthage/gists{/gist_id}","starred_url":"https://api.github.com/users/Carthage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Carthage/subscriptions","organizations_url":"https://api.github.com/users/Carthage/orgs","repos_url":"https://api.github.com/users/Carthage/repos","events_url":"https://api.github.com/users/Carthage/events{/privacy}","received_events_url":"https://api.github.com/users/Carthage/received_events","type":"Organization","site_admin":false},"repo":{"id":25050844,"node_id":"MDEwOlJlcG9zaXRvcnkyNTA1MDg0NA==","name":"Carthage","full_name":"Carthage/Carthage","private":false,"owner":{"login":"Carthage","id":9146792,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDY3OTI=","avatar_url":"https://avatars1.githubusercontent.com/u/9146792?v=4","gravatar_id":"","url":"https://api.github.com/users/Carthage","html_url":"https://github.com/Carthage","followers_url":"https://api.github.com/users/Carthage/followers","following_url":"https://api.github.com/users/Carthage/following{/other_user}","gists_url":"https://api.github.com/users/Carthage/gists{/gist_id}","starred_url":"https://api.github.com/users/Carthage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Carthage/subscriptions","organizations_url":"https://api.github.com/users/Carthage/orgs","repos_url":"https://api.github.com/users/Carthage/repos","events_url":"https://api.github.com/users/Carthage/events{/privacy}","received_events_url":"https://api.github.com/users/Carthage/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Carthage/Carthage","description":"A simple, decentralized dependency manager for Cocoa","fork":false,"url":"https://api.github.com/repos/Carthage/Carthage","forks_url":"https://api.github.com/repos/Carthage/Carthage/forks","keys_url":"https://api.github.com/repos/Carthage/Carthage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Carthage/Carthage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Carthage/Carthage/teams","hooks_url":"https://api.github.com/repos/Carthage/Carthage/hooks","issue_events_url":"https://api.github.com/repos/Carthage/Carthage/issues/events{/number}","events_url":"https://api.github.com/repos/Carthage/Carthage/events","assignees_url":"https://api.github.com/repos/Carthage/Carthage/assignees{/user}","branches_url":"https://api.github.com/repos/Carthage/Carthage/branches{/branch}","tags_url":"https://api.github.com/repos/Carthage/Carthage/tags","blobs_url":"https://api.github.com/repos/Carthage/Carthage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Carthage/Carthage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Carthage/Carthage/git/refs{/sha}","trees_url":"https://api.github.com/repos/Carthage/Carthage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Carthage/Carthage/statuses/{sha}","languages_url":"https://api.github.com/repos/Carthage/Carthage/languages","stargazers_url":"https://api.github.com/repos/Carthage/Carthage/stargazers","contributors_url":"https://api.github.com/repos/Carthage/Carthage/contributors","subscribers_url":"https://api.github.com/repos/Carthage/Carthage/subscribers","subscription_url":"https://api.github.com/repos/Carthage/Carthage/subscription","commits_url":"https://api.github.com/repos/Carthage/Carthage/commits{/sha}","git_commits_url":"https://api.github.com/repos/Carthage/Carthage/git/commits{/sha}","comments_url":"https://api.github.com/repos/Carthage/Carthage/comments{/number}","issue_comment_url":"https://api.github.com/repos/Carthage/Carthage/issues/comments{/number}","contents_url":"https://api.github.com/repos/Carthage/Carthage/contents/{+path}","compare_url":"https://api.github.com/repos/Carthage/Carthage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Carthage/Carthage/merges","archive_url":"https://api.github.com/repos/Carthage/Carthage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Carthage/Carthage/downloads","issues_url":"https://api.github.com/repos/Carthage/Carthage/issues{/number}","pulls_url":"https://api.github.com/repos/Carthage/Carthage/pulls{/number}","milestones_url":"https://api.github.com/repos/Carthage/Carthage/milestones{/number}","notifications_url":"https://api.github.com/repos/Carthage/Carthage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Carthage/Carthage/labels{/name}","releases_url":"https://api.github.com/repos/Carthage/Carthage/releases{/id}","deployments_url":"https://api.github.com/repos/Carthage/Carthage/deployments","created_at":"2014-10-10T19:54:55Z","updated_at":"2018-10-24T15:17:46Z","pushed_at":"2018-10-24T16:13:31Z","git_url":"git://github.com/Carthage/Carthage.git","ssh_url":"git@github.com:Carthage/Carthage.git","clone_url":"https://github.com/Carthage/Carthage.git","svn_url":"https://github.com/Carthage/Carthage","homepage":"","size":18600,"stargazers_count":12133,"watchers_count":12133,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1152,"mirror_url":null,"archived":false,"open_issues_count":142,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1152,"open_issues":142,"watchers":12133,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Carthage/Carthage/pulls/2585"},"html":{"href":"https://github.com/Carthage/Carthage/pull/2585"},"issue":{"href":"https://api.github.com/repos/Carthage/Carthage/issues/2585"},"comments":{"href":"https://api.github.com/repos/Carthage/Carthage/issues/2585/comments"},"review_comments":{"href":"https://api.github.com/repos/Carthage/Carthage/pulls/2585/comments"},"review_comment":{"href":"https://api.github.com/repos/Carthage/Carthage/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Carthage/Carthage/pulls/2585/commits"},"statuses":{"href":"https://api.github.com/repos/Carthage/Carthage/statuses/3d6c8b55fe5b9479a3c165e4a7c11d85b2c3a388"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"blender"}}