{"action":"created","issue":{"url":"https://api.github.com/repos/agnwinds/python/issues/338","repository_url":"https://api.github.com/repos/agnwinds/python","labels_url":"https://api.github.com/repos/agnwinds/python/issues/338/labels{/name}","comments_url":"https://api.github.com/repos/agnwinds/python/issues/338/comments","events_url":"https://api.github.com/repos/agnwinds/python/issues/338/events","html_url":"https://github.com/agnwinds/python/issues/338","id":295296509,"number":338,"title":"extra diagnostics - unification of approach","user":{"login":"kslong","id":2530901,"avatar_url":"https://avatars0.githubusercontent.com/u/2530901?v=4","gravatar_id":"","url":"https://api.github.com/users/kslong","html_url":"https://github.com/kslong","followers_url":"https://api.github.com/users/kslong/followers","following_url":"https://api.github.com/users/kslong/following{/other_user}","gists_url":"https://api.github.com/users/kslong/gists{/gist_id}","starred_url":"https://api.github.com/users/kslong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kslong/subscriptions","organizations_url":"https://api.github.com/users/kslong/orgs","repos_url":"https://api.github.com/users/kslong/repos","events_url":"https://api.github.com/users/kslong/events{/privacy}","received_events_url":"https://api.github.com/users/kslong/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-02-07T21:19:38Z","updated_at":"2018-02-09T12:07:30Z","closed_at":null,"author_association":"COLLABORATOR","body":"Right now, we have a bunch of extra diagnostics that can be turned on, and when this is done extra results are printed to a diagnostic file.  This is a part of the code of course that we don't use once a problem has been solved, and so we don't have a uniform philosophy about how to do this.  The result is that for some of the diagnostics write things out \"in line\".  An example of this modes.track_resonant_scatters\r\nwhere in trans_phot we open a file with a pointer to the file, and then we write to that file.  On the other hand, for modes.save_extract_photons \r\nthe relevant code is in diag.c  (the same is true of ispy with code in ispy.c).   \r\n\r\nI think we ought to systematize this a bit.  My suggestion is that we write to one extra file in diag_whatever, and that all of the write statements to this begin with a keyword that identifies which of the various types of extra diagnostic is being printed out.  \r\n\r\nAnd I would put all of this into diag.c, so that we would see how it works together.  The advantage I see from this is that it would make life easier if we want to add to write everything about a current photons position and frequency  (which is what I need to do now for the import problem I am trying to solve with @jhmatthews ).\r\n\r\nDoes anyone have thoughts/objections to this @Higginbottom @smangham ?  \r\n\r\nAlso, does any one use ispy? or should I simply remove this. "},"comment":{"url":"https://api.github.com/repos/agnwinds/python/issues/comments/364416720","html_url":"https://github.com/agnwinds/python/issues/338#issuecomment-364416720","issue_url":"https://api.github.com/repos/agnwinds/python/issues/338","id":364416720,"user":{"login":"jhmatthews","id":3007249,"avatar_url":"https://avatars1.githubusercontent.com/u/3007249?v=4","gravatar_id":"","url":"https://api.github.com/users/jhmatthews","html_url":"https://github.com/jhmatthews","followers_url":"https://api.github.com/users/jhmatthews/followers","following_url":"https://api.github.com/users/jhmatthews/following{/other_user}","gists_url":"https://api.github.com/users/jhmatthews/gists{/gist_id}","starred_url":"https://api.github.com/users/jhmatthews/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhmatthews/subscriptions","organizations_url":"https://api.github.com/users/jhmatthews/orgs","repos_url":"https://api.github.com/users/jhmatthews/repos","events_url":"https://api.github.com/users/jhmatthews/events{/privacy}","received_events_url":"https://api.github.com/users/jhmatthews/received_events","type":"User","site_admin":false},"created_at":"2018-02-09T12:07:30Z","updated_at":"2018-02-09T12:07:30Z","author_association":"COLLABORATOR","body":"Hi Knox. I agree with the suggestion, I think it makes things a bit more \"modular\" so that's good. \r\n\r\nI noted in the parameter docs that ispy is very similar to cell_photon_stats but I believe the latter is slightly more complete. One can certainly be deprecated I think, probably ispy. "}}
{"actor":{"display_login":"jhmatthews"}}