{"action":"closed","number":137,"pull_request":{"url":"https://api.github.com/repos/babenkoivan/scout-elasticsearch-driver/pulls/137","id":214346971,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0MzQ2OTcx","html_url":"https://github.com/babenkoivan/scout-elasticsearch-driver/pull/137","diff_url":"https://github.com/babenkoivan/scout-elasticsearch-driver/pull/137.diff","patch_url":"https://github.com/babenkoivan/scout-elasticsearch-driver/pull/137.patch","issue_url":"https://api.github.com/repos/babenkoivan/scout-elasticsearch-driver/issues/137","number":137,"state":"closed","locked":false,"title":"Check if the model its using soft deletes to enable soft deletes in the query builder","user":{"login":"nerones","id":429848,"node_id":"MDQ6VXNlcjQyOTg0OA==","avatar_url":"https://avatars0.githubusercontent.com/u/429848?v=4","gravatar_id":"","url":"https://api.github.com/users/nerones","html_url":"https://github.com/nerones","followers_url":"https://api.github.com/users/nerones/followers","following_url":"https://api.github.com/users/nerones/following{/other_user}","gists_url":"https://api.github.com/users/nerones/gists{/gist_id}","starred_url":"https://api.github.com/users/nerones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nerones/subscriptions","organizations_url":"https://api.github.com/users/nerones/orgs","repos_url":"https://api.github.com/users/nerones/repos","events_url":"https://api.github.com/users/nerones/events{/privacy}","received_events_url":"https://api.github.com/users/nerones/received_events","type":"User","site_admin":false},"body":"Add an extra check to see if the query builder should use soft deletes, checking only for the config value lead to unexpected behaviour.\r\n\r\nPlease see #136 for a more detailed explanation.","created_at":"2018-09-10T15:05:54Z","updated_at":"2018-11-25T09:52:48Z","closed_at":"2018-11-25T09:52:48Z","merged_at":"2018-11-25T09:52:48Z","merge_commit_sha":"ab0d0b1233e18bccd9879d44b36a83530b948e8f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/babenkoivan/scout-elasticsearch-driver/pulls/137/commits","review_comments_url":"https://api.github.com/repos/babenkoivan/scout-elasticsearch-driver/pulls/137/comments","review_comment_url":"https://api.github.com/repos/babenkoivan/scout-elasticsearch-driver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/babenkoivan/scout-elasticsearch-driver/issues/137/comments","statuses_url":"https://api.github.com/repos/babenkoivan/scout-elasticsearch-driver/statuses/64546553319a370e10ba375ccd5f96bc1937a583","head":{"label":"nerones:master","ref":"master","sha":"64546553319a370e10ba375ccd5f96bc1937a583","user":{"login":"nerones","id":429848,"node_id":"MDQ6VXNlcjQyOTg0OA==","avatar_url":"https://avatars0.githubusercontent.com/u/429848?v=4","gravatar_id":"","url":"https://api.github.com/users/nerones","html_url":"https://github.com/nerones","followers_url":"https://api.github.com/users/nerones/followers","following_url":"https://api.github.com/users/nerones/following{/other_user}","gists_url":"https://api.github.com/users/nerones/gists{/gist_id}","starred_url":"https://api.github.com/users/nerones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nerones/subscriptions","organizations_url":"https://api.github.com/users/nerones/orgs","repos_url":"https://api.github.com/users/nerones/repos","events_url":"https://api.github.com/users/nerones/events{/privacy}","received_events_url":"https://api.github.com/users/nerones/received_events","type":"User","site_admin":false},"repo":{"id":148171636,"node_id":"MDEwOlJlcG9zaXRvcnkxNDgxNzE2MzY=","name":"scout-elasticsearch-driver","full_name":"nerones/scout-elasticsearch-driver","private":false,"owner":{"login":"nerones","id":429848,"node_id":"MDQ6VXNlcjQyOTg0OA==","avatar_url":"https://avatars0.githubusercontent.com/u/429848?v=4","gravatar_id":"","url":"https://api.github.com/users/nerones","html_url":"https://github.com/nerones","followers_url":"https://api.github.com/users/nerones/followers","following_url":"https://api.github.com/users/nerones/following{/other_user}","gists_url":"https://api.github.com/users/nerones/gists{/gist_id}","starred_url":"https://api.github.com/users/nerones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nerones/subscriptions","organizations_url":"https://api.github.com/users/nerones/orgs","repos_url":"https://api.github.com/users/nerones/repos","events_url":"https://api.github.com/users/nerones/events{/privacy}","received_events_url":"https://api.github.com/users/nerones/received_events","type":"User","site_admin":false},"html_url":"https://github.com/nerones/scout-elasticsearch-driver","description":"This package offers advanced functionality for searching and filtering data in Elasticsearch.","fork":true,"url":"https://api.github.com/repos/nerones/scout-elasticsearch-driver","forks_url":"https://api.github.com/repos/nerones/scout-elasticsearch-driver/forks","keys_url":"https://api.github.com/repos/nerones/scout-elasticsearch-driver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nerones/scout-elasticsearch-driver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nerones/scout-elasticsearch-driver/teams","hooks_url":"https://api.github.com/repos/nerones/scout-elasticsearch-driver/hooks","issue_events_url":"https://api.github.com/repos/nerones/scout-elasticsearch-driver/issues/events{/number}","events_url":"https://api.github.com/repos/nerones/scout-elasticsearch-driver/events","assignees_url":"https://api.github.com/repos/nerones/scout-elasticsearch-driver/assignees{/user}","branches_url":"https://api.github.com/repos/nerones/scout-elasticsearch-driver/branches{/branch}","tags_url":"https://api.github.com/repos/nerones/scout-elasticsearch-driver/tags","blobs_url":"https://api.github.com/repos/nerones/scout-elasticsearch-driver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nerones/scout-elasticsearch-driver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nerones/scout-elasticsearch-driver/git/refs{/sha}","trees_url":"https://api.github.com/repos/nerones/scout-elasticsearch-driver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nerones/scout-elasticsearch-driver/statuses/{sha}","languages_url":"https://api.github.com/repos/nerones/scout-elasticsearch-driver/languages","stargazers_url":"https://api.github.com/repos/nerones/scout-elasticsearch-driver/stargazers","contributors_url":"https://api.github.com/repos/nerones/scout-elasticsearch-driver/contributors","subscribers_url":"https://api.github.com/repos/nerones/scout-elasticsearch-driver/subscribers","subscription_url":"https://api.github.com/repos/nerones/scout-elasticsearch-driver/subscription","commits_url":"https://api.github.com/repos/nerones/scout-elasticsearch-driver/commits{/sha}","git_commits_url":"https://api.github.com/repos/nerones/scout-elasticsearch-driver/git/commits{/sha}","comments_url":"https://api.github.com/repos/nerones/scout-elasticsearch-driver/comments{/number}","issue_comment_url":"https://api.github.com/repos/nerones/scout-elasticsearch-driver/issues/comments{/number}","contents_url":"https://api.github.com/repos/nerones/scout-elasticsearch-driver/contents/{+path}","compare_url":"https://api.github.com/repos/nerones/scout-elasticsearch-driver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nerones/scout-elasticsearch-driver/merges","archive_url":"https://api.github.com/repos/nerones/scout-elasticsearch-driver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nerones/scout-elasticsearch-driver/downloads","issues_url":"https://api.github.com/repos/nerones/scout-elasticsearch-driver/issues{/number}","pulls_url":"https://api.github.com/repos/nerones/scout-elasticsearch-driver/pulls{/number}","milestones_url":"https://api.github.com/repos/nerones/scout-elasticsearch-driver/milestones{/number}","notifications_url":"https://api.github.com/repos/nerones/scout-elasticsearch-driver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nerones/scout-elasticsearch-driver/labels{/name}","releases_url":"https://api.github.com/repos/nerones/scout-elasticsearch-driver/releases{/id}","deployments_url":"https://api.github.com/repos/nerones/scout-elasticsearch-driver/deployments","created_at":"2018-09-10T14:51:36Z","updated_at":"2018-09-10T15:02:22Z","pushed_at":"2018-09-10T15:02:21Z","git_url":"git://github.com/nerones/scout-elasticsearch-driver.git","ssh_url":"git@github.com:nerones/scout-elasticsearch-driver.git","clone_url":"https://github.com/nerones/scout-elasticsearch-driver.git","svn_url":"https://github.com/nerones/scout-elasticsearch-driver","homepage":"","size":250,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"babenkoivan:master","ref":"master","sha":"be363a67ff280924e726df12b290c294a3d736d7","user":{"login":"babenkoivan","id":25812954,"node_id":"MDQ6VXNlcjI1ODEyOTU0","avatar_url":"https://avatars3.githubusercontent.com/u/25812954?v=4","gravatar_id":"","url":"https://api.github.com/users/babenkoivan","html_url":"https://github.com/babenkoivan","followers_url":"https://api.github.com/users/babenkoivan/followers","following_url":"https://api.github.com/users/babenkoivan/following{/other_user}","gists_url":"https://api.github.com/users/babenkoivan/gists{/gist_id}","starred_url":"https://api.github.com/users/babenkoivan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/babenkoivan/subscriptions","organizations_url":"https://api.github.com/users/babenkoivan/orgs","repos_url":"https://api.github.com/users/babenkoivan/repos","events_url":"https://api.github.com/users/babenkoivan/events{/privacy}","received_events_url":"https://api.github.com/users/babenkoivan/received_events","type":"User","site_admin":false},"repo":{"id":83650803,"node_id":"MDEwOlJlcG9zaXRvcnk4MzY1MDgwMw==","name":"scout-elasticsearch-driver","full_name":"babenkoivan/scout-elasticsearch-driver","private":false,"owner":{"login":"babenkoivan","id":25812954,"node_id":"MDQ6VXNlcjI1ODEyOTU0","avatar_url":"https://avatars3.githubusercontent.com/u/25812954?v=4","gravatar_id":"","url":"https://api.github.com/users/babenkoivan","html_url":"https://github.com/babenkoivan","followers_url":"https://api.github.com/users/babenkoivan/followers","following_url":"https://api.github.com/users/babenkoivan/following{/other_user}","gists_url":"https://api.github.com/users/babenkoivan/gists{/gist_id}","starred_url":"https://api.github.com/users/babenkoivan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/babenkoivan/subscriptions","organizations_url":"https://api.github.com/users/babenkoivan/orgs","repos_url":"https://api.github.com/users/babenkoivan/repos","events_url":"https://api.github.com/users/babenkoivan/events{/privacy}","received_events_url":"https://api.github.com/users/babenkoivan/received_events","type":"User","site_admin":false},"html_url":"https://github.com/babenkoivan/scout-elasticsearch-driver","description":"This package offers advanced functionality for searching and filtering data in Elasticsearch.","fork":false,"url":"https://api.github.com/repos/babenkoivan/scout-elasticsearch-driver","forks_url":"https://api.github.com/repos/babenkoivan/scout-elasticsearch-driver/forks","keys_url":"https://api.github.com/repos/babenkoivan/scout-elasticsearch-driver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/babenkoivan/scout-elasticsearch-driver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/babenkoivan/scout-elasticsearch-driver/teams","hooks_url":"https://api.github.com/repos/babenkoivan/scout-elasticsearch-driver/hooks","issue_events_url":"https://api.github.com/repos/babenkoivan/scout-elasticsearch-driver/issues/events{/number}","events_url":"https://api.github.com/repos/babenkoivan/scout-elasticsearch-driver/events","assignees_url":"https://api.github.com/repos/babenkoivan/scout-elasticsearch-driver/assignees{/user}","branches_url":"https://api.github.com/repos/babenkoivan/scout-elasticsearch-driver/branches{/branch}","tags_url":"https://api.github.com/repos/babenkoivan/scout-elasticsearch-driver/tags","blobs_url":"https://api.github.com/repos/babenkoivan/scout-elasticsearch-driver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/babenkoivan/scout-elasticsearch-driver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/babenkoivan/scout-elasticsearch-driver/git/refs{/sha}","trees_url":"https://api.github.com/repos/babenkoivan/scout-elasticsearch-driver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/babenkoivan/scout-elasticsearch-driver/statuses/{sha}","languages_url":"https://api.github.com/repos/babenkoivan/scout-elasticsearch-driver/languages","stargazers_url":"https://api.github.com/repos/babenkoivan/scout-elasticsearch-driver/stargazers","contributors_url":"https://api.github.com/repos/babenkoivan/scout-elasticsearch-driver/contributors","subscribers_url":"https://api.github.com/repos/babenkoivan/scout-elasticsearch-driver/subscribers","subscription_url":"https://api.github.com/repos/babenkoivan/scout-elasticsearch-driver/subscription","commits_url":"https://api.github.com/repos/babenkoivan/scout-elasticsearch-driver/commits{/sha}","git_commits_url":"https://api.github.com/repos/babenkoivan/scout-elasticsearch-driver/git/commits{/sha}","comments_url":"https://api.github.com/repos/babenkoivan/scout-elasticsearch-driver/comments{/number}","issue_comment_url":"https://api.github.com/repos/babenkoivan/scout-elasticsearch-driver/issues/comments{/number}","contents_url":"https://api.github.com/repos/babenkoivan/scout-elasticsearch-driver/contents/{+path}","compare_url":"https://api.github.com/repos/babenkoivan/scout-elasticsearch-driver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/babenkoivan/scout-elasticsearch-driver/merges","archive_url":"https://api.github.com/repos/babenkoivan/scout-elasticsearch-driver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/babenkoivan/scout-elasticsearch-driver/downloads","issues_url":"https://api.github.com/repos/babenkoivan/scout-elasticsearch-driver/issues{/number}","pulls_url":"https://api.github.com/repos/babenkoivan/scout-elasticsearch-driver/pulls{/number}","milestones_url":"https://api.github.com/repos/babenkoivan/scout-elasticsearch-driver/milestones{/number}","notifications_url":"https://api.github.com/repos/babenkoivan/scout-elasticsearch-driver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/babenkoivan/scout-elasticsearch-driver/labels{/name}","releases_url":"https://api.github.com/repos/babenkoivan/scout-elasticsearch-driver/releases{/id}","deployments_url":"https://api.github.com/repos/babenkoivan/scout-elasticsearch-driver/deployments","created_at":"2017-03-02T07:57:58Z","updated_at":"2018-11-23T12:56:37Z","pushed_at":"2018-11-25T09:52:48Z","git_url":"git://github.com/babenkoivan/scout-elasticsearch-driver.git","ssh_url":"git@github.com:babenkoivan/scout-elasticsearch-driver.git","clone_url":"https://github.com/babenkoivan/scout-elasticsearch-driver.git","svn_url":"https://github.com/babenkoivan/scout-elasticsearch-driver","homepage":"","size":247,"stargazers_count":364,"watchers_count":364,"language":"PHP","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":68,"mirror_url":null,"archived":false,"open_issues_count":50,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":68,"open_issues":50,"watchers":364,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/babenkoivan/scout-elasticsearch-driver/pulls/137"},"html":{"href":"https://github.com/babenkoivan/scout-elasticsearch-driver/pull/137"},"issue":{"href":"https://api.github.com/repos/babenkoivan/scout-elasticsearch-driver/issues/137"},"comments":{"href":"https://api.github.com/repos/babenkoivan/scout-elasticsearch-driver/issues/137/comments"},"review_comments":{"href":"https://api.github.com/repos/babenkoivan/scout-elasticsearch-driver/pulls/137/comments"},"review_comment":{"href":"https://api.github.com/repos/babenkoivan/scout-elasticsearch-driver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/babenkoivan/scout-elasticsearch-driver/pulls/137/commits"},"statuses":{"href":"https://api.github.com/repos/babenkoivan/scout-elasticsearch-driver/statuses/64546553319a370e10ba375ccd5f96bc1937a583"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"babenkoivan","id":25812954,"node_id":"MDQ6VXNlcjI1ODEyOTU0","avatar_url":"https://avatars3.githubusercontent.com/u/25812954?v=4","gravatar_id":"","url":"https://api.github.com/users/babenkoivan","html_url":"https://github.com/babenkoivan","followers_url":"https://api.github.com/users/babenkoivan/followers","following_url":"https://api.github.com/users/babenkoivan/following{/other_user}","gists_url":"https://api.github.com/users/babenkoivan/gists{/gist_id}","starred_url":"https://api.github.com/users/babenkoivan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/babenkoivan/subscriptions","organizations_url":"https://api.github.com/users/babenkoivan/orgs","repos_url":"https://api.github.com/users/babenkoivan/repos","events_url":"https://api.github.com/users/babenkoivan/events{/privacy}","received_events_url":"https://api.github.com/users/babenkoivan/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"babenkoivan"}}