{"action":"created","issue":{"url":"https://api.github.com/repos/ecohealthalliance/eidith/issues/66","repository_url":"https://api.github.com/repos/ecohealthalliance/eidith","labels_url":"https://api.github.com/repos/ecohealthalliance/eidith/issues/66/labels{/name}","comments_url":"https://api.github.com/repos/ecohealthalliance/eidith/issues/66/comments","events_url":"https://api.github.com/repos/ecohealthalliance/eidith/issues/66/events","html_url":"https://github.com/ecohealthalliance/eidith/pull/66","id":300086811,"number":66,"title":"Eidith2","user":{"login":"calebasaraba","id":21368926,"avatar_url":"https://avatars3.githubusercontent.com/u/21368926?v=4","gravatar_id":"","url":"https://api.github.com/users/calebasaraba","html_url":"https://github.com/calebasaraba","followers_url":"https://api.github.com/users/calebasaraba/followers","following_url":"https://api.github.com/users/calebasaraba/following{/other_user}","gists_url":"https://api.github.com/users/calebasaraba/gists{/gist_id}","starred_url":"https://api.github.com/users/calebasaraba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calebasaraba/subscriptions","organizations_url":"https://api.github.com/users/calebasaraba/orgs","repos_url":"https://api.github.com/users/calebasaraba/repos","events_url":"https://api.github.com/users/calebasaraba/events{/privacy}","received_events_url":"https://api.github.com/users/calebasaraba/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-02-26T02:02:33Z","updated_at":"2018-03-05T00:54:17Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/ecohealthalliance/eidith/pulls/66","html_url":"https://github.com/ecohealthalliance/eidith/pull/66","diff_url":"https://github.com/ecohealthalliance/eidith/pull/66.diff","patch_url":"https://github.com/ecohealthalliance/eidith/pull/66.patch"},"body":"Addresses #62 and #63 \r\n\r\n__Key functions / changes:__\r\n\r\n- On startup, new banner displays status of local P1 / P2 database download and download dates, `ed_db_check_status()` runs on load and will check which tables need to be downloaded because they are missing or are malformed, then prompt user to do so. \r\n\r\n- `ed_db_download()` now takes both a `p1_tables` and `p2_tables` argument, letting the user download P1/P2 data to a local SQLite database. `ed_db_download()` still downloads all new tables to a temporary local database, and checks whether they are present and as expected, but now will not discard entire download if there are errors; instead the well-formed tables will be transferred to the local database while the corrupt tables are discarded.\r\n\r\n- `ed2_get()` function mirrors `ed_get()` function to download tables from IM team P2 API. Both `ed_get()` and `ed2_get()` should work safely, returning messages to the user but not breaking in the event that an API is not responding or there are unexpected fields in tables. \r\n\r\n- `ed_table_()` adds attributes for P2 tables that have note columns or have duplicate unique identifiers. This is communicated to the user when they do a local pull via an `ed_table_()` call or when they print any eidith P2 table.\r\n\r\n- status checking and status display functions have been split into `R/status-checks.R` because `R/database.R` was getting ungainly.\r\n\r\n*Note: not all metadata is compiled for P2 Human questionnaire tables (#61) but will be continuously pushed up as it is finished. Until then `metadata_tables` is a placeholder indicating which tables are finished so that status_check-ing functions don't worry about inconsistencies in uncleaned tables.*\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/ecohealthalliance/eidith/issues/comments/370281317","html_url":"https://github.com/ecohealthalliance/eidith/pull/66#issuecomment-370281317","issue_url":"https://api.github.com/repos/ecohealthalliance/eidith/issues/66","id":370281317,"user":{"login":"calebasaraba","id":21368926,"avatar_url":"https://avatars3.githubusercontent.com/u/21368926?v=4","gravatar_id":"","url":"https://api.github.com/users/calebasaraba","html_url":"https://github.com/calebasaraba","followers_url":"https://api.github.com/users/calebasaraba/followers","following_url":"https://api.github.com/users/calebasaraba/following{/other_user}","gists_url":"https://api.github.com/users/calebasaraba/gists{/gist_id}","starred_url":"https://api.github.com/users/calebasaraba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calebasaraba/subscriptions","organizations_url":"https://api.github.com/users/calebasaraba/orgs","repos_url":"https://api.github.com/users/calebasaraba/repos","events_url":"https://api.github.com/users/calebasaraba/events{/privacy}","received_events_url":"https://api.github.com/users/calebasaraba/received_events","type":"User","site_admin":false},"created_at":"2018-03-05T00:54:17Z","updated_at":"2018-03-05T00:54:17Z","author_association":"COLLABORATOR","body":"Just tested on windows side, everything looks good for pull into dev with your approval @noamross . I've added the documentation loose ends to issue #67 to be dealt with later on. "}}
{"actor":{"display_login":"calebasaraba"}}