{"action":"created","comment":{"url":"https://api.github.com/repos/nordnet/nordnet-ui-kit/pulls/comments/184978033","pull_request_review_id":116276108,"id":184978033,"diff_hunk":"@@ -75,7 +75,8 @@\n     \"classnames\": \"^2.2.3\",\n     \"color\": \"^1.0.3\",\n     \"lodash\": \"^4.17.4\",\n-    \"react-transition-group\": \"^2.2.0\"\n+    \"react-router-dom\": \"^4.2.2\",","path":"package.json","position":5,"original_position":5,"commit_id":"7102300cb0155893dbb87d47ccd2081f20dd669f","original_commit_id":"7102300cb0155893dbb87d47ccd2081f20dd669f","user":{"login":"esundqvist","id":11274205,"avatar_url":"https://avatars0.githubusercontent.com/u/11274205?v=4","gravatar_id":"","url":"https://api.github.com/users/esundqvist","html_url":"https://github.com/esundqvist","followers_url":"https://api.github.com/users/esundqvist/followers","following_url":"https://api.github.com/users/esundqvist/following{/other_user}","gists_url":"https://api.github.com/users/esundqvist/gists{/gist_id}","starred_url":"https://api.github.com/users/esundqvist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esundqvist/subscriptions","organizations_url":"https://api.github.com/users/esundqvist/orgs","repos_url":"https://api.github.com/users/esundqvist/repos","events_url":"https://api.github.com/users/esundqvist/events{/privacy}","received_events_url":"https://api.github.com/users/esundqvist/received_events","type":"User","site_admin":false},"body":"I understand, but I don't see an easy solution for handling the states of each <PopupMenuItem /> without using <Link />. We would move a lot of logic to the component implementing <PopupMenu /> and bloat those instead.","created_at":"2018-04-30T12:53:32Z","updated_at":"2018-04-30T12:53:32Z","html_url":"https://github.com/nordnet/nordnet-ui-kit/pull/386#discussion_r184978033","pull_request_url":"https://api.github.com/repos/nordnet/nordnet-ui-kit/pulls/386","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/nordnet/nordnet-ui-kit/pulls/comments/184978033"},"html":{"href":"https://github.com/nordnet/nordnet-ui-kit/pull/386#discussion_r184978033"},"pull_request":{"href":"https://api.github.com/repos/nordnet/nordnet-ui-kit/pulls/386"}},"in_reply_to_id":184929117},"pull_request":{"url":"https://api.github.com/repos/nordnet/nordnet-ui-kit/pulls/386","id":184337064,"html_url":"https://github.com/nordnet/nordnet-ui-kit/pull/386","diff_url":"https://github.com/nordnet/nordnet-ui-kit/pull/386.diff","patch_url":"https://github.com/nordnet/nordnet-ui-kit/pull/386.patch","issue_url":"https://api.github.com/repos/nordnet/nordnet-ui-kit/issues/386","number":386,"state":"open","locked":false,"title":"feat(popup-menu): adds popup menu","user":{"login":"esundqvist","id":11274205,"avatar_url":"https://avatars0.githubusercontent.com/u/11274205?v=4","gravatar_id":"","url":"https://api.github.com/users/esundqvist","html_url":"https://github.com/esundqvist","followers_url":"https://api.github.com/users/esundqvist/followers","following_url":"https://api.github.com/users/esundqvist/following{/other_user}","gists_url":"https://api.github.com/users/esundqvist/gists{/gist_id}","starred_url":"https://api.github.com/users/esundqvist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esundqvist/subscriptions","organizations_url":"https://api.github.com/users/esundqvist/orgs","repos_url":"https://api.github.com/users/esundqvist/repos","events_url":"https://api.github.com/users/esundqvist/events{/privacy}","received_events_url":"https://api.github.com/users/esundqvist/received_events","type":"User","site_admin":false},"body":"adds popup menu previously used only in page-watchlist","created_at":"2018-04-26T13:18:05Z","updated_at":"2018-04-30T12:53:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"555fbb95613c24dc501dd9a20d538da7e81bb841","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/nordnet/nordnet-ui-kit/pulls/386/commits","review_comments_url":"https://api.github.com/repos/nordnet/nordnet-ui-kit/pulls/386/comments","review_comment_url":"https://api.github.com/repos/nordnet/nordnet-ui-kit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nordnet/nordnet-ui-kit/issues/386/comments","statuses_url":"https://api.github.com/repos/nordnet/nordnet-ui-kit/statuses/7102300cb0155893dbb87d47ccd2081f20dd669f","head":{"label":"nordnet:popup-menu","ref":"popup-menu","sha":"7102300cb0155893dbb87d47ccd2081f20dd669f","user":{"login":"nordnet","id":1134179,"avatar_url":"https://avatars3.githubusercontent.com/u/1134179?v=4","gravatar_id":"","url":"https://api.github.com/users/nordnet","html_url":"https://github.com/nordnet","followers_url":"https://api.github.com/users/nordnet/followers","following_url":"https://api.github.com/users/nordnet/following{/other_user}","gists_url":"https://api.github.com/users/nordnet/gists{/gist_id}","starred_url":"https://api.github.com/users/nordnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nordnet/subscriptions","organizations_url":"https://api.github.com/users/nordnet/orgs","repos_url":"https://api.github.com/users/nordnet/repos","events_url":"https://api.github.com/users/nordnet/events{/privacy}","received_events_url":"https://api.github.com/users/nordnet/received_events","type":"Organization","site_admin":false},"repo":{"id":50519452,"name":"nordnet-ui-kit","full_name":"nordnet/nordnet-ui-kit","owner":{"login":"nordnet","id":1134179,"avatar_url":"https://avatars3.githubusercontent.com/u/1134179?v=4","gravatar_id":"","url":"https://api.github.com/users/nordnet","html_url":"https://github.com/nordnet","followers_url":"https://api.github.com/users/nordnet/followers","following_url":"https://api.github.com/users/nordnet/following{/other_user}","gists_url":"https://api.github.com/users/nordnet/gists{/gist_id}","starred_url":"https://api.github.com/users/nordnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nordnet/subscriptions","organizations_url":"https://api.github.com/users/nordnet/orgs","repos_url":"https://api.github.com/users/nordnet/repos","events_url":"https://api.github.com/users/nordnet/events{/privacy}","received_events_url":"https://api.github.com/users/nordnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nordnet/nordnet-ui-kit","description":"Nordnet UI Kit","fork":false,"url":"https://api.github.com/repos/nordnet/nordnet-ui-kit","forks_url":"https://api.github.com/repos/nordnet/nordnet-ui-kit/forks","keys_url":"https://api.github.com/repos/nordnet/nordnet-ui-kit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nordnet/nordnet-ui-kit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nordnet/nordnet-ui-kit/teams","hooks_url":"https://api.github.com/repos/nordnet/nordnet-ui-kit/hooks","issue_events_url":"https://api.github.com/repos/nordnet/nordnet-ui-kit/issues/events{/number}","events_url":"https://api.github.com/repos/nordnet/nordnet-ui-kit/events","assignees_url":"https://api.github.com/repos/nordnet/nordnet-ui-kit/assignees{/user}","branches_url":"https://api.github.com/repos/nordnet/nordnet-ui-kit/branches{/branch}","tags_url":"https://api.github.com/repos/nordnet/nordnet-ui-kit/tags","blobs_url":"https://api.github.com/repos/nordnet/nordnet-ui-kit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nordnet/nordnet-ui-kit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nordnet/nordnet-ui-kit/git/refs{/sha}","trees_url":"https://api.github.com/repos/nordnet/nordnet-ui-kit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nordnet/nordnet-ui-kit/statuses/{sha}","languages_url":"https://api.github.com/repos/nordnet/nordnet-ui-kit/languages","stargazers_url":"https://api.github.com/repos/nordnet/nordnet-ui-kit/stargazers","contributors_url":"https://api.github.com/repos/nordnet/nordnet-ui-kit/contributors","subscribers_url":"https://api.github.com/repos/nordnet/nordnet-ui-kit/subscribers","subscription_url":"https://api.github.com/repos/nordnet/nordnet-ui-kit/subscription","commits_url":"https://api.github.com/repos/nordnet/nordnet-ui-kit/commits{/sha}","git_commits_url":"https://api.github.com/repos/nordnet/nordnet-ui-kit/git/commits{/sha}","comments_url":"https://api.github.com/repos/nordnet/nordnet-ui-kit/comments{/number}","issue_comment_url":"https://api.github.com/repos/nordnet/nordnet-ui-kit/issues/comments{/number}","contents_url":"https://api.github.com/repos/nordnet/nordnet-ui-kit/contents/{+path}","compare_url":"https://api.github.com/repos/nordnet/nordnet-ui-kit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nordnet/nordnet-ui-kit/merges","archive_url":"https://api.github.com/repos/nordnet/nordnet-ui-kit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nordnet/nordnet-ui-kit/downloads","issues_url":"https://api.github.com/repos/nordnet/nordnet-ui-kit/issues{/number}","pulls_url":"https://api.github.com/repos/nordnet/nordnet-ui-kit/pulls{/number}","milestones_url":"https://api.github.com/repos/nordnet/nordnet-ui-kit/milestones{/number}","notifications_url":"https://api.github.com/repos/nordnet/nordnet-ui-kit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nordnet/nordnet-ui-kit/labels{/name}","releases_url":"https://api.github.com/repos/nordnet/nordnet-ui-kit/releases{/id}","deployments_url":"https://api.github.com/repos/nordnet/nordnet-ui-kit/deployments","created_at":"2016-01-27T16:07:19Z","updated_at":"2018-04-26T08:43:31Z","pushed_at":"2018-04-26T14:53:37Z","git_url":"git://github.com/nordnet/nordnet-ui-kit.git","ssh_url":"git@github.com:nordnet/nordnet-ui-kit.git","clone_url":"https://github.com/nordnet/nordnet-ui-kit.git","svn_url":"https://github.com/nordnet/nordnet-ui-kit","homepage":"https://nordnet.github.io/nordnet-ui-kit/","size":13901,"stargazers_count":99,"watchers_count":99,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":28,"mirror_url":null,"archived":false,"open_issues_count":14,"license":null,"forks":28,"open_issues":14,"watchers":99,"default_branch":"master"}},"base":{"label":"nordnet:master","ref":"master","sha":"d2ee208ae802c8cd29b9dc8bca9d14f213ce30e7","user":{"login":"nordnet","id":1134179,"avatar_url":"https://avatars3.githubusercontent.com/u/1134179?v=4","gravatar_id":"","url":"https://api.github.com/users/nordnet","html_url":"https://github.com/nordnet","followers_url":"https://api.github.com/users/nordnet/followers","following_url":"https://api.github.com/users/nordnet/following{/other_user}","gists_url":"https://api.github.com/users/nordnet/gists{/gist_id}","starred_url":"https://api.github.com/users/nordnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nordnet/subscriptions","organizations_url":"https://api.github.com/users/nordnet/orgs","repos_url":"https://api.github.com/users/nordnet/repos","events_url":"https://api.github.com/users/nordnet/events{/privacy}","received_events_url":"https://api.github.com/users/nordnet/received_events","type":"Organization","site_admin":false},"repo":{"id":50519452,"name":"nordnet-ui-kit","full_name":"nordnet/nordnet-ui-kit","owner":{"login":"nordnet","id":1134179,"avatar_url":"https://avatars3.githubusercontent.com/u/1134179?v=4","gravatar_id":"","url":"https://api.github.com/users/nordnet","html_url":"https://github.com/nordnet","followers_url":"https://api.github.com/users/nordnet/followers","following_url":"https://api.github.com/users/nordnet/following{/other_user}","gists_url":"https://api.github.com/users/nordnet/gists{/gist_id}","starred_url":"https://api.github.com/users/nordnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nordnet/subscriptions","organizations_url":"https://api.github.com/users/nordnet/orgs","repos_url":"https://api.github.com/users/nordnet/repos","events_url":"https://api.github.com/users/nordnet/events{/privacy}","received_events_url":"https://api.github.com/users/nordnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nordnet/nordnet-ui-kit","description":"Nordnet UI Kit","fork":false,"url":"https://api.github.com/repos/nordnet/nordnet-ui-kit","forks_url":"https://api.github.com/repos/nordnet/nordnet-ui-kit/forks","keys_url":"https://api.github.com/repos/nordnet/nordnet-ui-kit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nordnet/nordnet-ui-kit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nordnet/nordnet-ui-kit/teams","hooks_url":"https://api.github.com/repos/nordnet/nordnet-ui-kit/hooks","issue_events_url":"https://api.github.com/repos/nordnet/nordnet-ui-kit/issues/events{/number}","events_url":"https://api.github.com/repos/nordnet/nordnet-ui-kit/events","assignees_url":"https://api.github.com/repos/nordnet/nordnet-ui-kit/assignees{/user}","branches_url":"https://api.github.com/repos/nordnet/nordnet-ui-kit/branches{/branch}","tags_url":"https://api.github.com/repos/nordnet/nordnet-ui-kit/tags","blobs_url":"https://api.github.com/repos/nordnet/nordnet-ui-kit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nordnet/nordnet-ui-kit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nordnet/nordnet-ui-kit/git/refs{/sha}","trees_url":"https://api.github.com/repos/nordnet/nordnet-ui-kit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nordnet/nordnet-ui-kit/statuses/{sha}","languages_url":"https://api.github.com/repos/nordnet/nordnet-ui-kit/languages","stargazers_url":"https://api.github.com/repos/nordnet/nordnet-ui-kit/stargazers","contributors_url":"https://api.github.com/repos/nordnet/nordnet-ui-kit/contributors","subscribers_url":"https://api.github.com/repos/nordnet/nordnet-ui-kit/subscribers","subscription_url":"https://api.github.com/repos/nordnet/nordnet-ui-kit/subscription","commits_url":"https://api.github.com/repos/nordnet/nordnet-ui-kit/commits{/sha}","git_commits_url":"https://api.github.com/repos/nordnet/nordnet-ui-kit/git/commits{/sha}","comments_url":"https://api.github.com/repos/nordnet/nordnet-ui-kit/comments{/number}","issue_comment_url":"https://api.github.com/repos/nordnet/nordnet-ui-kit/issues/comments{/number}","contents_url":"https://api.github.com/repos/nordnet/nordnet-ui-kit/contents/{+path}","compare_url":"https://api.github.com/repos/nordnet/nordnet-ui-kit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nordnet/nordnet-ui-kit/merges","archive_url":"https://api.github.com/repos/nordnet/nordnet-ui-kit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nordnet/nordnet-ui-kit/downloads","issues_url":"https://api.github.com/repos/nordnet/nordnet-ui-kit/issues{/number}","pulls_url":"https://api.github.com/repos/nordnet/nordnet-ui-kit/pulls{/number}","milestones_url":"https://api.github.com/repos/nordnet/nordnet-ui-kit/milestones{/number}","notifications_url":"https://api.github.com/repos/nordnet/nordnet-ui-kit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nordnet/nordnet-ui-kit/labels{/name}","releases_url":"https://api.github.com/repos/nordnet/nordnet-ui-kit/releases{/id}","deployments_url":"https://api.github.com/repos/nordnet/nordnet-ui-kit/deployments","created_at":"2016-01-27T16:07:19Z","updated_at":"2018-04-26T08:43:31Z","pushed_at":"2018-04-26T14:53:37Z","git_url":"git://github.com/nordnet/nordnet-ui-kit.git","ssh_url":"git@github.com:nordnet/nordnet-ui-kit.git","clone_url":"https://github.com/nordnet/nordnet-ui-kit.git","svn_url":"https://github.com/nordnet/nordnet-ui-kit","homepage":"https://nordnet.github.io/nordnet-ui-kit/","size":13901,"stargazers_count":99,"watchers_count":99,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":28,"mirror_url":null,"archived":false,"open_issues_count":14,"license":null,"forks":28,"open_issues":14,"watchers":99,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nordnet/nordnet-ui-kit/pulls/386"},"html":{"href":"https://github.com/nordnet/nordnet-ui-kit/pull/386"},"issue":{"href":"https://api.github.com/repos/nordnet/nordnet-ui-kit/issues/386"},"comments":{"href":"https://api.github.com/repos/nordnet/nordnet-ui-kit/issues/386/comments"},"review_comments":{"href":"https://api.github.com/repos/nordnet/nordnet-ui-kit/pulls/386/comments"},"review_comment":{"href":"https://api.github.com/repos/nordnet/nordnet-ui-kit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nordnet/nordnet-ui-kit/pulls/386/commits"},"statuses":{"href":"https://api.github.com/repos/nordnet/nordnet-ui-kit/statuses/7102300cb0155893dbb87d47ccd2081f20dd669f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"esundqvist"}}