{"action":"created","comment":{"url":"https://api.github.com/repos/javaparser/javaparser/pulls/comments/231640838","pull_request_review_id":172654343,"id":231640838,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMTY0MDgzOA==","diff_hunk":"@@ -12,11 +12,11 @@\n  * Helper class for {@link GeneratedJavaParser}\n  */\n class ModifierHolder {","path":"javaparser-core/src/main/javacc-support/com/github/javaparser/ModifierHolder.java","position":3,"original_position":3,"commit_id":"e0daa5027206978b86781348d579d68bce05040b","original_commit_id":"a108ca27dbce2a5e409eab0d45520d52f40638e0","user":{"login":"matozoid","id":55701,"node_id":"MDQ6VXNlcjU1NzAx","avatar_url":"https://avatars3.githubusercontent.com/u/55701?v=4","gravatar_id":"","url":"https://api.github.com/users/matozoid","html_url":"https://github.com/matozoid","followers_url":"https://api.github.com/users/matozoid/followers","following_url":"https://api.github.com/users/matozoid/following{/other_user}","gists_url":"https://api.github.com/users/matozoid/gists{/gist_id}","starred_url":"https://api.github.com/users/matozoid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matozoid/subscriptions","organizations_url":"https://api.github.com/users/matozoid/orgs","repos_url":"https://api.github.com/users/matozoid/repos","events_url":"https://api.github.com/users/matozoid/events{/privacy}","received_events_url":"https://api.github.com/users/matozoid/received_events","type":"User","site_admin":false},"body":"It is produced when parsing modifiers and annotations. It holds both. This is where we need to have the discussion whether we want annotations and modifiers stored separately, or if we want to make them the same thing... Maybe it's better to keep them apart for now, it would make the API very \"unspecific.\"","created_at":"2018-11-07T19:15:38Z","updated_at":"2018-11-07T19:15:38Z","html_url":"https://github.com/javaparser/javaparser/pull/1754#discussion_r231640838","pull_request_url":"https://api.github.com/repos/javaparser/javaparser/pulls/1754","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/javaparser/javaparser/pulls/comments/231640838"},"html":{"href":"https://github.com/javaparser/javaparser/pull/1754#discussion_r231640838"},"pull_request":{"href":"https://api.github.com/repos/javaparser/javaparser/pulls/1754"}},"in_reply_to_id":230385287},"pull_request":{"url":"https://api.github.com/repos/javaparser/javaparser/pulls/1754","id":208944108,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4OTQ0MTA4","html_url":"https://github.com/javaparser/javaparser/pull/1754","diff_url":"https://github.com/javaparser/javaparser/pull/1754.diff","patch_url":"https://github.com/javaparser/javaparser/pull/1754.patch","issue_url":"https://api.github.com/repos/javaparser/javaparser/issues/1754","number":1754,"state":"open","locked":false,"title":"Create a Modifier node","user":{"login":"matozoid","id":55701,"node_id":"MDQ6VXNlcjU1NzAx","avatar_url":"https://avatars3.githubusercontent.com/u/55701?v=4","gravatar_id":"","url":"https://api.github.com/users/matozoid","html_url":"https://github.com/matozoid","followers_url":"https://api.github.com/users/matozoid/followers","following_url":"https://api.github.com/users/matozoid/following{/other_user}","gists_url":"https://api.github.com/users/matozoid/gists{/gist_id}","starred_url":"https://api.github.com/users/matozoid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matozoid/subscriptions","organizations_url":"https://api.github.com/users/matozoid/orgs","repos_url":"https://api.github.com/users/matozoid/repos","events_url":"https://api.github.com/users/matozoid/events{/privacy}","received_events_url":"https://api.github.com/users/matozoid/received_events","type":"User","site_admin":false},"body":"Here's the first step towards JP4, and I need some help :-(\r\n\r\nThe symbol solver is pretty confused and I don't know how to fix it.\r\n\r\nWhat's being modified: `Modifier` is no longer an enum, it's a real `Node` now, so it's officially part of the AST. The enum is still there, it's called `Modifier.Keyword` now. `Modifier` has a field of that type.\r\nModifiers are no longer stored in an `EnumSet`, but in a `NodeList`.\r\n\r\nFixes #912 ","created_at":"2018-08-16T18:23:19Z","updated_at":"2018-11-07T19:15:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6495a41d654801131dc1ed45493e735b3f902d01","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/javaparser/javaparser/pulls/1754/commits","review_comments_url":"https://api.github.com/repos/javaparser/javaparser/pulls/1754/comments","review_comment_url":"https://api.github.com/repos/javaparser/javaparser/pulls/comments{/number}","comments_url":"https://api.github.com/repos/javaparser/javaparser/issues/1754/comments","statuses_url":"https://api.github.com/repos/javaparser/javaparser/statuses/e0daa5027206978b86781348d579d68bce05040b","head":{"label":"matozoid:issue_912_modifier_node","ref":"issue_912_modifier_node","sha":"e0daa5027206978b86781348d579d68bce05040b","user":{"login":"matozoid","id":55701,"node_id":"MDQ6VXNlcjU1NzAx","avatar_url":"https://avatars3.githubusercontent.com/u/55701?v=4","gravatar_id":"","url":"https://api.github.com/users/matozoid","html_url":"https://github.com/matozoid","followers_url":"https://api.github.com/users/matozoid/followers","following_url":"https://api.github.com/users/matozoid/following{/other_user}","gists_url":"https://api.github.com/users/matozoid/gists{/gist_id}","starred_url":"https://api.github.com/users/matozoid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matozoid/subscriptions","organizations_url":"https://api.github.com/users/matozoid/orgs","repos_url":"https://api.github.com/users/matozoid/repos","events_url":"https://api.github.com/users/matozoid/events{/privacy}","received_events_url":"https://api.github.com/users/matozoid/received_events","type":"User","site_admin":false},"repo":{"id":62242732,"node_id":"MDEwOlJlcG9zaXRvcnk2MjI0MjczMg==","name":"javaparser","full_name":"matozoid/javaparser","private":false,"owner":{"login":"matozoid","id":55701,"node_id":"MDQ6VXNlcjU1NzAx","avatar_url":"https://avatars3.githubusercontent.com/u/55701?v=4","gravatar_id":"","url":"https://api.github.com/users/matozoid","html_url":"https://github.com/matozoid","followers_url":"https://api.github.com/users/matozoid/followers","following_url":"https://api.github.com/users/matozoid/following{/other_user}","gists_url":"https://api.github.com/users/matozoid/gists{/gist_id}","starred_url":"https://api.github.com/users/matozoid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matozoid/subscriptions","organizations_url":"https://api.github.com/users/matozoid/orgs","repos_url":"https://api.github.com/users/matozoid/repos","events_url":"https://api.github.com/users/matozoid/events{/privacy}","received_events_url":"https://api.github.com/users/matozoid/received_events","type":"User","site_admin":false},"html_url":"https://github.com/matozoid/javaparser","description":"PRIVATE FORK","fork":true,"url":"https://api.github.com/repos/matozoid/javaparser","forks_url":"https://api.github.com/repos/matozoid/javaparser/forks","keys_url":"https://api.github.com/repos/matozoid/javaparser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matozoid/javaparser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matozoid/javaparser/teams","hooks_url":"https://api.github.com/repos/matozoid/javaparser/hooks","issue_events_url":"https://api.github.com/repos/matozoid/javaparser/issues/events{/number}","events_url":"https://api.github.com/repos/matozoid/javaparser/events","assignees_url":"https://api.github.com/repos/matozoid/javaparser/assignees{/user}","branches_url":"https://api.github.com/repos/matozoid/javaparser/branches{/branch}","tags_url":"https://api.github.com/repos/matozoid/javaparser/tags","blobs_url":"https://api.github.com/repos/matozoid/javaparser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matozoid/javaparser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matozoid/javaparser/git/refs{/sha}","trees_url":"https://api.github.com/repos/matozoid/javaparser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matozoid/javaparser/statuses/{sha}","languages_url":"https://api.github.com/repos/matozoid/javaparser/languages","stargazers_url":"https://api.github.com/repos/matozoid/javaparser/stargazers","contributors_url":"https://api.github.com/repos/matozoid/javaparser/contributors","subscribers_url":"https://api.github.com/repos/matozoid/javaparser/subscribers","subscription_url":"https://api.github.com/repos/matozoid/javaparser/subscription","commits_url":"https://api.github.com/repos/matozoid/javaparser/commits{/sha}","git_commits_url":"https://api.github.com/repos/matozoid/javaparser/git/commits{/sha}","comments_url":"https://api.github.com/repos/matozoid/javaparser/comments{/number}","issue_comment_url":"https://api.github.com/repos/matozoid/javaparser/issues/comments{/number}","contents_url":"https://api.github.com/repos/matozoid/javaparser/contents/{+path}","compare_url":"https://api.github.com/repos/matozoid/javaparser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matozoid/javaparser/merges","archive_url":"https://api.github.com/repos/matozoid/javaparser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matozoid/javaparser/downloads","issues_url":"https://api.github.com/repos/matozoid/javaparser/issues{/number}","pulls_url":"https://api.github.com/repos/matozoid/javaparser/pulls{/number}","milestones_url":"https://api.github.com/repos/matozoid/javaparser/milestones{/number}","notifications_url":"https://api.github.com/repos/matozoid/javaparser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matozoid/javaparser/labels{/name}","releases_url":"https://api.github.com/repos/matozoid/javaparser/releases{/id}","deployments_url":"https://api.github.com/repos/matozoid/javaparser/deployments","created_at":"2016-06-29T16:54:59Z","updated_at":"2018-10-28T19:50:59Z","pushed_at":"2018-11-07T19:13:35Z","git_url":"git://github.com/matozoid/javaparser.git","ssh_url":"git@github.com:matozoid/javaparser.git","clone_url":"https://github.com/matozoid/javaparser.git","svn_url":"https://github.com/matozoid/javaparser","homepage":"https://github.com/javaparser/javaparser","size":20354,"stargazers_count":6,"watchers_count":6,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3,"open_issues":0,"watchers":6,"default_branch":"master"}},"base":{"label":"javaparser:master","ref":"master","sha":"f34d7b6c147c97781108d3fb00a6e0072140715d","user":{"login":"javaparser","id":9988471,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5ODg0NzE=","avatar_url":"https://avatars2.githubusercontent.com/u/9988471?v=4","gravatar_id":"","url":"https://api.github.com/users/javaparser","html_url":"https://github.com/javaparser","followers_url":"https://api.github.com/users/javaparser/followers","following_url":"https://api.github.com/users/javaparser/following{/other_user}","gists_url":"https://api.github.com/users/javaparser/gists{/gist_id}","starred_url":"https://api.github.com/users/javaparser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javaparser/subscriptions","organizations_url":"https://api.github.com/users/javaparser/orgs","repos_url":"https://api.github.com/users/javaparser/repos","events_url":"https://api.github.com/users/javaparser/events{/privacy}","received_events_url":"https://api.github.com/users/javaparser/received_events","type":"Organization","site_admin":false},"repo":{"id":2675355,"node_id":"MDEwOlJlcG9zaXRvcnkyNjc1MzU1","name":"javaparser","full_name":"javaparser/javaparser","private":false,"owner":{"login":"javaparser","id":9988471,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5ODg0NzE=","avatar_url":"https://avatars2.githubusercontent.com/u/9988471?v=4","gravatar_id":"","url":"https://api.github.com/users/javaparser","html_url":"https://github.com/javaparser","followers_url":"https://api.github.com/users/javaparser/followers","following_url":"https://api.github.com/users/javaparser/following{/other_user}","gists_url":"https://api.github.com/users/javaparser/gists{/gist_id}","starred_url":"https://api.github.com/users/javaparser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javaparser/subscriptions","organizations_url":"https://api.github.com/users/javaparser/orgs","repos_url":"https://api.github.com/users/javaparser/repos","events_url":"https://api.github.com/users/javaparser/events{/privacy}","received_events_url":"https://api.github.com/users/javaparser/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/javaparser/javaparser","description":" Java 1-11 Parser and Abstract Syntax Tree for Java –","fork":false,"url":"https://api.github.com/repos/javaparser/javaparser","forks_url":"https://api.github.com/repos/javaparser/javaparser/forks","keys_url":"https://api.github.com/repos/javaparser/javaparser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/javaparser/javaparser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/javaparser/javaparser/teams","hooks_url":"https://api.github.com/repos/javaparser/javaparser/hooks","issue_events_url":"https://api.github.com/repos/javaparser/javaparser/issues/events{/number}","events_url":"https://api.github.com/repos/javaparser/javaparser/events","assignees_url":"https://api.github.com/repos/javaparser/javaparser/assignees{/user}","branches_url":"https://api.github.com/repos/javaparser/javaparser/branches{/branch}","tags_url":"https://api.github.com/repos/javaparser/javaparser/tags","blobs_url":"https://api.github.com/repos/javaparser/javaparser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/javaparser/javaparser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/javaparser/javaparser/git/refs{/sha}","trees_url":"https://api.github.com/repos/javaparser/javaparser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/javaparser/javaparser/statuses/{sha}","languages_url":"https://api.github.com/repos/javaparser/javaparser/languages","stargazers_url":"https://api.github.com/repos/javaparser/javaparser/stargazers","contributors_url":"https://api.github.com/repos/javaparser/javaparser/contributors","subscribers_url":"https://api.github.com/repos/javaparser/javaparser/subscribers","subscription_url":"https://api.github.com/repos/javaparser/javaparser/subscription","commits_url":"https://api.github.com/repos/javaparser/javaparser/commits{/sha}","git_commits_url":"https://api.github.com/repos/javaparser/javaparser/git/commits{/sha}","comments_url":"https://api.github.com/repos/javaparser/javaparser/comments{/number}","issue_comment_url":"https://api.github.com/repos/javaparser/javaparser/issues/comments{/number}","contents_url":"https://api.github.com/repos/javaparser/javaparser/contents/{+path}","compare_url":"https://api.github.com/repos/javaparser/javaparser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/javaparser/javaparser/merges","archive_url":"https://api.github.com/repos/javaparser/javaparser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/javaparser/javaparser/downloads","issues_url":"https://api.github.com/repos/javaparser/javaparser/issues{/number}","pulls_url":"https://api.github.com/repos/javaparser/javaparser/pulls{/number}","milestones_url":"https://api.github.com/repos/javaparser/javaparser/milestones{/number}","notifications_url":"https://api.github.com/repos/javaparser/javaparser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/javaparser/javaparser/labels{/name}","releases_url":"https://api.github.com/repos/javaparser/javaparser/releases{/id}","deployments_url":"https://api.github.com/repos/javaparser/javaparser/deployments","created_at":"2011-10-30T14:03:44Z","updated_at":"2018-11-07T15:15:28Z","pushed_at":"2018-11-07T19:13:37Z","git_url":"git://github.com/javaparser/javaparser.git","ssh_url":"git@github.com:javaparser/javaparser.git","clone_url":"https://github.com/javaparser/javaparser.git","svn_url":"https://github.com/javaparser/javaparser","homepage":"https://javaparser.org","size":19516,"stargazers_count":2051,"watchers_count":2051,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":480,"mirror_url":null,"archived":false,"open_issues_count":299,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":480,"open_issues":299,"watchers":2051,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/javaparser/javaparser/pulls/1754"},"html":{"href":"https://github.com/javaparser/javaparser/pull/1754"},"issue":{"href":"https://api.github.com/repos/javaparser/javaparser/issues/1754"},"comments":{"href":"https://api.github.com/repos/javaparser/javaparser/issues/1754/comments"},"review_comments":{"href":"https://api.github.com/repos/javaparser/javaparser/pulls/1754/comments"},"review_comment":{"href":"https://api.github.com/repos/javaparser/javaparser/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/javaparser/javaparser/pulls/1754/commits"},"statuses":{"href":"https://api.github.com/repos/javaparser/javaparser/statuses/e0daa5027206978b86781348d579d68bce05040b"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"matozoid"}}