{"action":"closed","number":18606,"pull_request":{"url":"https://api.github.com/repos/magento/magento2/pulls/18606","id":222716413,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyNzE2NDEz","html_url":"https://github.com/magento/magento2/pull/18606","diff_url":"https://github.com/magento/magento2/pull/18606.diff","patch_url":"https://github.com/magento/magento2/pull/18606.patch","issue_url":"https://api.github.com/repos/magento/magento2/issues/18606","number":18606,"state":"closed","locked":false,"title":"Remove wrong test expectation","user":{"login":"markoshust","id":437029,"node_id":"MDQ6VXNlcjQzNzAyOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/437029?v=4","gravatar_id":"","url":"https://api.github.com/users/markoshust","html_url":"https://github.com/markoshust","followers_url":"https://api.github.com/users/markoshust/followers","following_url":"https://api.github.com/users/markoshust/following{/other_user}","gists_url":"https://api.github.com/users/markoshust/gists{/gist_id}","starred_url":"https://api.github.com/users/markoshust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markoshust/subscriptions","organizations_url":"https://api.github.com/users/markoshust/orgs","repos_url":"https://api.github.com/users/markoshust/repos","events_url":"https://api.github.com/users/markoshust/events{/privacy}","received_events_url":"https://api.github.com/users/markoshust/received_events","type":"User","site_admin":false},"body":"### Description (*)\r\nRemoving wrong test expectation which fails unit tests\r\n\r\n### Fixed Issues (if relevant)\r\n1. Fixes https://github.com/magento/magento2/issues/12419\r\n\r\n### Manual testing scenarios (*)\r\n1. Run `bin/magento dev:tests:run unit`, which fails with:\r\n\r\n```\r\nThere was 1 failure:\r\n\r\n1) Magento\\ProductVideo\\Test\\Unit\\Controller\\Adminhtml\\Product\\Gallery\\RetrieveImageTest::testExecute\r\nExpectation failed for method name is equal to <string:getDirectoryWrite> when invoked 1 time(s).\r\nMethod was expected to be called 1 times, actually called 0 times.\r\n```\r\n\r\n### Contribution checklist (*)\r\n - [ x ] Pull request has a meaningful description of its purpose\r\n - [ x ] All commits are accompanied by meaningful commit messages\r\n - [ x ] All new or changed code is covered with unit/integration tests (if applicable)\r\n - [ x ] All automated tests passed successfully (all builds on Travis CI are green)\r\n","created_at":"2018-10-14T13:41:10Z","updated_at":"2018-10-14T13:45:28Z","closed_at":"2018-10-14T13:45:28Z","merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":944433568,"node_id":"MDU6TGFiZWw5NDQ0MzM1Njg=","url":"https://api.github.com/repos/magento/magento2/labels/Component:%20AdminNotification","name":"Component: AdminNotification","color":"7fb703","default":false},{"id":721429227,"node_id":"MDU6TGFiZWw3MjE0MjkyMjc=","url":"https://api.github.com/repos/magento/magento2/labels/Release%20Line:%202.3","name":"Release Line: 2.3","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/magento/magento2/pulls/18606/commits","review_comments_url":"https://api.github.com/repos/magento/magento2/pulls/18606/comments","review_comment_url":"https://api.github.com/repos/magento/magento2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/magento/magento2/issues/18606/comments","statuses_url":"https://api.github.com/repos/magento/magento2/statuses/5b37f61fd065e7c8a8da0ca0dbb4269d578a6efc","head":{"label":"markoshust:feature/12419","ref":"feature/12419","sha":"5b37f61fd065e7c8a8da0ca0dbb4269d578a6efc","user":{"login":"markoshust","id":437029,"node_id":"MDQ6VXNlcjQzNzAyOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/437029?v=4","gravatar_id":"","url":"https://api.github.com/users/markoshust","html_url":"https://github.com/markoshust","followers_url":"https://api.github.com/users/markoshust/followers","following_url":"https://api.github.com/users/markoshust/following{/other_user}","gists_url":"https://api.github.com/users/markoshust/gists{/gist_id}","starred_url":"https://api.github.com/users/markoshust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markoshust/subscriptions","organizations_url":"https://api.github.com/users/markoshust/orgs","repos_url":"https://api.github.com/users/markoshust/repos","events_url":"https://api.github.com/users/markoshust/events{/privacy}","received_events_url":"https://api.github.com/users/markoshust/received_events","type":"User","site_admin":false},"repo":{"id":135636055,"node_id":"MDEwOlJlcG9zaXRvcnkxMzU2MzYwNTU=","name":"magento2","full_name":"markoshust/magento2","private":false,"owner":{"login":"markoshust","id":437029,"node_id":"MDQ6VXNlcjQzNzAyOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/437029?v=4","gravatar_id":"","url":"https://api.github.com/users/markoshust","html_url":"https://github.com/markoshust","followers_url":"https://api.github.com/users/markoshust/followers","following_url":"https://api.github.com/users/markoshust/following{/other_user}","gists_url":"https://api.github.com/users/markoshust/gists{/gist_id}","starred_url":"https://api.github.com/users/markoshust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markoshust/subscriptions","organizations_url":"https://api.github.com/users/markoshust/orgs","repos_url":"https://api.github.com/users/markoshust/repos","events_url":"https://api.github.com/users/markoshust/events{/privacy}","received_events_url":"https://api.github.com/users/markoshust/received_events","type":"User","site_admin":false},"html_url":"https://github.com/markoshust/magento2","description":"All Submissions you make to Magento Inc. (“Magento\") through GitHub are subject to the following terms and conditions: (1) You grant Magento a perpetual, worldwide, non-exclusive, no charge, royalty free, irrevocable license under your applicable copyrights and patents to reproduce, prepare derivative works of, display, publically perform, sublicense and distribute any feedback, ideas, code, or other information (“Submission\") you submit through GitHub. (2) Your Submission is an original work of authorship and you are the owner or are legally entitled to grant the license stated above. (3) You agree to the Contributor License Agreement found here:  https://github.com/magento/magento2/blob/master/CONTRIBUTOR_LICENSE_AGREEMENT.html","fork":true,"url":"https://api.github.com/repos/markoshust/magento2","forks_url":"https://api.github.com/repos/markoshust/magento2/forks","keys_url":"https://api.github.com/repos/markoshust/magento2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/markoshust/magento2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/markoshust/magento2/teams","hooks_url":"https://api.github.com/repos/markoshust/magento2/hooks","issue_events_url":"https://api.github.com/repos/markoshust/magento2/issues/events{/number}","events_url":"https://api.github.com/repos/markoshust/magento2/events","assignees_url":"https://api.github.com/repos/markoshust/magento2/assignees{/user}","branches_url":"https://api.github.com/repos/markoshust/magento2/branches{/branch}","tags_url":"https://api.github.com/repos/markoshust/magento2/tags","blobs_url":"https://api.github.com/repos/markoshust/magento2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/markoshust/magento2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/markoshust/magento2/git/refs{/sha}","trees_url":"https://api.github.com/repos/markoshust/magento2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/markoshust/magento2/statuses/{sha}","languages_url":"https://api.github.com/repos/markoshust/magento2/languages","stargazers_url":"https://api.github.com/repos/markoshust/magento2/stargazers","contributors_url":"https://api.github.com/repos/markoshust/magento2/contributors","subscribers_url":"https://api.github.com/repos/markoshust/magento2/subscribers","subscription_url":"https://api.github.com/repos/markoshust/magento2/subscription","commits_url":"https://api.github.com/repos/markoshust/magento2/commits{/sha}","git_commits_url":"https://api.github.com/repos/markoshust/magento2/git/commits{/sha}","comments_url":"https://api.github.com/repos/markoshust/magento2/comments{/number}","issue_comment_url":"https://api.github.com/repos/markoshust/magento2/issues/comments{/number}","contents_url":"https://api.github.com/repos/markoshust/magento2/contents/{+path}","compare_url":"https://api.github.com/repos/markoshust/magento2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/markoshust/magento2/merges","archive_url":"https://api.github.com/repos/markoshust/magento2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/markoshust/magento2/downloads","issues_url":"https://api.github.com/repos/markoshust/magento2/issues{/number}","pulls_url":"https://api.github.com/repos/markoshust/magento2/pulls{/number}","milestones_url":"https://api.github.com/repos/markoshust/magento2/milestones{/number}","notifications_url":"https://api.github.com/repos/markoshust/magento2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/markoshust/magento2/labels{/name}","releases_url":"https://api.github.com/repos/markoshust/magento2/releases{/id}","deployments_url":"https://api.github.com/repos/markoshust/magento2/deployments","created_at":"2018-05-31T21:15:24Z","updated_at":"2018-10-14T13:38:02Z","pushed_at":"2018-10-14T13:42:28Z","git_url":"git://github.com/markoshust/magento2.git","ssh_url":"git@github.com:markoshust/magento2.git","clone_url":"https://github.com/markoshust/magento2.git","svn_url":"https://github.com/markoshust/magento2","homepage":"http://www.magento.com","size":465436,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"2.2-develop"}},"base":{"label":"magento:2.3-develop","ref":"2.3-develop","sha":"8a7f23e95ebecfbfc47779b39640ac3f2b26962a","user":{"login":"magento","id":168457,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2ODQ1Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/168457?v=4","gravatar_id":"","url":"https://api.github.com/users/magento","html_url":"https://github.com/magento","followers_url":"https://api.github.com/users/magento/followers","following_url":"https://api.github.com/users/magento/following{/other_user}","gists_url":"https://api.github.com/users/magento/gists{/gist_id}","starred_url":"https://api.github.com/users/magento/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magento/subscriptions","organizations_url":"https://api.github.com/users/magento/orgs","repos_url":"https://api.github.com/users/magento/repos","events_url":"https://api.github.com/users/magento/events{/privacy}","received_events_url":"https://api.github.com/users/magento/received_events","type":"Organization","site_admin":false},"repo":{"id":2884111,"node_id":"MDEwOlJlcG9zaXRvcnkyODg0MTEx","name":"magento2","full_name":"magento/magento2","private":false,"owner":{"login":"magento","id":168457,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2ODQ1Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/168457?v=4","gravatar_id":"","url":"https://api.github.com/users/magento","html_url":"https://github.com/magento","followers_url":"https://api.github.com/users/magento/followers","following_url":"https://api.github.com/users/magento/following{/other_user}","gists_url":"https://api.github.com/users/magento/gists{/gist_id}","starred_url":"https://api.github.com/users/magento/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magento/subscriptions","organizations_url":"https://api.github.com/users/magento/orgs","repos_url":"https://api.github.com/users/magento/repos","events_url":"https://api.github.com/users/magento/events{/privacy}","received_events_url":"https://api.github.com/users/magento/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/magento/magento2","description":"All Submissions you make to Magento Inc. (\"Magento\") through GitHub are subject to the following terms and conditions: (1) You grant Magento a perpetual, worldwide, non-exclusive, no charge, royalty free, irrevocable license under your applicable copyrights and patents to reproduce, prepare derivative works of, display, publically perform, sublicense and distribute any feedback, ideas, code, or other information (“Submission\") you submit through GitHub. (2) Your Submission is an original work of authorship and you are the owner or are legally entitled to grant the license stated above. (3) You agree to the Contributor License Agreement found here:  https://github.com/magento/magento2/blob/master/CONTRIBUTOR_LICENSE_AGREEMENT.html","fork":false,"url":"https://api.github.com/repos/magento/magento2","forks_url":"https://api.github.com/repos/magento/magento2/forks","keys_url":"https://api.github.com/repos/magento/magento2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/magento/magento2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/magento/magento2/teams","hooks_url":"https://api.github.com/repos/magento/magento2/hooks","issue_events_url":"https://api.github.com/repos/magento/magento2/issues/events{/number}","events_url":"https://api.github.com/repos/magento/magento2/events","assignees_url":"https://api.github.com/repos/magento/magento2/assignees{/user}","branches_url":"https://api.github.com/repos/magento/magento2/branches{/branch}","tags_url":"https://api.github.com/repos/magento/magento2/tags","blobs_url":"https://api.github.com/repos/magento/magento2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/magento/magento2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/magento/magento2/git/refs{/sha}","trees_url":"https://api.github.com/repos/magento/magento2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/magento/magento2/statuses/{sha}","languages_url":"https://api.github.com/repos/magento/magento2/languages","stargazers_url":"https://api.github.com/repos/magento/magento2/stargazers","contributors_url":"https://api.github.com/repos/magento/magento2/contributors","subscribers_url":"https://api.github.com/repos/magento/magento2/subscribers","subscription_url":"https://api.github.com/repos/magento/magento2/subscription","commits_url":"https://api.github.com/repos/magento/magento2/commits{/sha}","git_commits_url":"https://api.github.com/repos/magento/magento2/git/commits{/sha}","comments_url":"https://api.github.com/repos/magento/magento2/comments{/number}","issue_comment_url":"https://api.github.com/repos/magento/magento2/issues/comments{/number}","contents_url":"https://api.github.com/repos/magento/magento2/contents/{+path}","compare_url":"https://api.github.com/repos/magento/magento2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/magento/magento2/merges","archive_url":"https://api.github.com/repos/magento/magento2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/magento/magento2/downloads","issues_url":"https://api.github.com/repos/magento/magento2/issues{/number}","pulls_url":"https://api.github.com/repos/magento/magento2/pulls{/number}","milestones_url":"https://api.github.com/repos/magento/magento2/milestones{/number}","notifications_url":"https://api.github.com/repos/magento/magento2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/magento/magento2/labels{/name}","releases_url":"https://api.github.com/repos/magento/magento2/releases{/id}","deployments_url":"https://api.github.com/repos/magento/magento2/deployments","created_at":"2011-11-30T15:30:13Z","updated_at":"2018-10-14T12:54:14Z","pushed_at":"2018-10-14T13:41:11Z","git_url":"git://github.com/magento/magento2.git","ssh_url":"git@github.com:magento/magento2.git","clone_url":"https://github.com/magento/magento2.git","svn_url":"https://github.com/magento/magento2","homepage":"http://www.magento.com","size":486644,"stargazers_count":6217,"watchers_count":6217,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5391,"mirror_url":null,"archived":false,"open_issues_count":1351,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":5391,"open_issues":1351,"watchers":6217,"default_branch":"2.3-develop"}},"_links":{"self":{"href":"https://api.github.com/repos/magento/magento2/pulls/18606"},"html":{"href":"https://github.com/magento/magento2/pull/18606"},"issue":{"href":"https://api.github.com/repos/magento/magento2/issues/18606"},"comments":{"href":"https://api.github.com/repos/magento/magento2/issues/18606/comments"},"review_comments":{"href":"https://api.github.com/repos/magento/magento2/pulls/18606/comments"},"review_comment":{"href":"https://api.github.com/repos/magento/magento2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/magento/magento2/pulls/18606/commits"},"statuses":{"href":"https://api.github.com/repos/magento/magento2/statuses/5b37f61fd065e7c8a8da0ca0dbb4269d578a6efc"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":false,"rebaseable":false,"mergeable_state":"dirty","merged_by":null,"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":10000,"additions":250301,"deletions":82787,"changed_files":6928}}
{"actor":{"display_login":"markoshust"}}