{"action":"created","comment":{"url":"https://api.github.com/repos/learningequality/kolibri-installer-debian/pulls/comments/179893015","pull_request_review_id":110229266,"id":179893015,"diff_hunk":"@@ -303,4 +310,5 @@ kolibri_preinst()\n kolibri_prerm()\n {\n     stop_kolibri_service\n+    clean_kolibri_pyc","path":"debian/kolibri.scripts-common","position":18,"original_position":18,"commit_id":"9d0ed1aca8b9164365593c411598802e145afce3","original_commit_id":"9d0ed1aca8b9164365593c411598802e145afce3","user":{"login":"benjaoming","id":374612,"avatar_url":"https://avatars0.githubusercontent.com/u/374612?v=4","gravatar_id":"","url":"https://api.github.com/users/benjaoming","html_url":"https://github.com/benjaoming","followers_url":"https://api.github.com/users/benjaoming/followers","following_url":"https://api.github.com/users/benjaoming/following{/other_user}","gists_url":"https://api.github.com/users/benjaoming/gists{/gist_id}","starred_url":"https://api.github.com/users/benjaoming/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjaoming/subscriptions","organizations_url":"https://api.github.com/users/benjaoming/orgs","repos_url":"https://api.github.com/users/benjaoming/repos","events_url":"https://api.github.com/users/benjaoming/events{/privacy}","received_events_url":"https://api.github.com/users/benjaoming/received_events","type":"User","site_admin":false},"body":"You could normalize this by replacing this line with just `py3clean -p kolibri` :)","created_at":"2018-04-06T22:51:34Z","updated_at":"2018-04-06T22:51:34Z","html_url":"https://github.com/learningequality/kolibri-installer-debian/pull/28#discussion_r179893015","pull_request_url":"https://api.github.com/repos/learningequality/kolibri-installer-debian/pulls/28","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/learningequality/kolibri-installer-debian/pulls/comments/179893015"},"html":{"href":"https://github.com/learningequality/kolibri-installer-debian/pull/28#discussion_r179893015"},"pull_request":{"href":"https://api.github.com/repos/learningequality/kolibri-installer-debian/pulls/28"}}},"pull_request":{"url":"https://api.github.com/repos/learningequality/kolibri-installer-debian/pulls/28","id":179192391,"html_url":"https://github.com/learningequality/kolibri-installer-debian/pull/28","diff_url":"https://github.com/learningequality/kolibri-installer-debian/pull/28.diff","patch_url":"https://github.com/learningequality/kolibri-installer-debian/pull/28.patch","issue_url":"https://api.github.com/repos/learningequality/kolibri-installer-debian/issues/28","number":28,"state":"open","locked":false,"title":"Call py3clean to remove .pyc files for kolibri remove+purge","user":{"login":"lyw07","id":19424916,"avatar_url":"https://avatars2.githubusercontent.com/u/19424916?v=4","gravatar_id":"","url":"https://api.github.com/users/lyw07","html_url":"https://github.com/lyw07","followers_url":"https://api.github.com/users/lyw07/followers","following_url":"https://api.github.com/users/lyw07/following{/other_user}","gists_url":"https://api.github.com/users/lyw07/gists{/gist_id}","starred_url":"https://api.github.com/users/lyw07/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyw07/subscriptions","organizations_url":"https://api.github.com/users/lyw07/orgs","repos_url":"https://api.github.com/users/lyw07/repos","events_url":"https://api.github.com/users/lyw07/events{/privacy}","received_events_url":"https://api.github.com/users/lyw07/received_events","type":"User","site_admin":false},"body":"This PR includes an additional function in the `kolibri.scripts-common` -- `clean_kolibri_pyc`, which is called right after stopping the kolibri service during `remove+purge`. \r\n\r\nRemoving all the .pyc files in the Kolibri directory can help us completely remove the Kolibri package when we call `apt-get remove kolibri` or `apt-get purge kolibri`. \r\n\r\nThis should fix https://github.com/learningequality/kolibri-installer-debian/issues/21\r\n\r\nI have tested on a Debian machine by installing kolibri from PPA, directly made changes to the `kolibri.prerm` and then removing kolibri by either `apt-get remove kolibri` or `apt-get purge kolibri`. The errors listed in the issue above don't exist in this case.\r\n\r\nPlease let me know if you find any problems. Thank you!","created_at":"2018-04-03T19:11:00Z","updated_at":"2018-04-06T22:51:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aa28171106b618ff779805d0287bb70f375cd146","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/learningequality/kolibri-installer-debian/pulls/28/commits","review_comments_url":"https://api.github.com/repos/learningequality/kolibri-installer-debian/pulls/28/comments","review_comment_url":"https://api.github.com/repos/learningequality/kolibri-installer-debian/pulls/comments{/number}","comments_url":"https://api.github.com/repos/learningequality/kolibri-installer-debian/issues/28/comments","statuses_url":"https://api.github.com/repos/learningequality/kolibri-installer-debian/statuses/9d0ed1aca8b9164365593c411598802e145afce3","head":{"label":"lyw07:master","ref":"master","sha":"9d0ed1aca8b9164365593c411598802e145afce3","user":{"login":"lyw07","id":19424916,"avatar_url":"https://avatars2.githubusercontent.com/u/19424916?v=4","gravatar_id":"","url":"https://api.github.com/users/lyw07","html_url":"https://github.com/lyw07","followers_url":"https://api.github.com/users/lyw07/followers","following_url":"https://api.github.com/users/lyw07/following{/other_user}","gists_url":"https://api.github.com/users/lyw07/gists{/gist_id}","starred_url":"https://api.github.com/users/lyw07/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyw07/subscriptions","organizations_url":"https://api.github.com/users/lyw07/orgs","repos_url":"https://api.github.com/users/lyw07/repos","events_url":"https://api.github.com/users/lyw07/events{/privacy}","received_events_url":"https://api.github.com/users/lyw07/received_events","type":"User","site_admin":false},"repo":{"id":127321680,"name":"kolibri-installer-debian","full_name":"lyw07/kolibri-installer-debian","owner":{"login":"lyw07","id":19424916,"avatar_url":"https://avatars2.githubusercontent.com/u/19424916?v=4","gravatar_id":"","url":"https://api.github.com/users/lyw07","html_url":"https://github.com/lyw07","followers_url":"https://api.github.com/users/lyw07/followers","following_url":"https://api.github.com/users/lyw07/following{/other_user}","gists_url":"https://api.github.com/users/lyw07/gists{/gist_id}","starred_url":"https://api.github.com/users/lyw07/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyw07/subscriptions","organizations_url":"https://api.github.com/users/lyw07/orgs","repos_url":"https://api.github.com/users/lyw07/repos","events_url":"https://api.github.com/users/lyw07/events{/privacy}","received_events_url":"https://api.github.com/users/lyw07/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lyw07/kolibri-installer-debian","description":"Kolibri installer source for Debian","fork":true,"url":"https://api.github.com/repos/lyw07/kolibri-installer-debian","forks_url":"https://api.github.com/repos/lyw07/kolibri-installer-debian/forks","keys_url":"https://api.github.com/repos/lyw07/kolibri-installer-debian/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lyw07/kolibri-installer-debian/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lyw07/kolibri-installer-debian/teams","hooks_url":"https://api.github.com/repos/lyw07/kolibri-installer-debian/hooks","issue_events_url":"https://api.github.com/repos/lyw07/kolibri-installer-debian/issues/events{/number}","events_url":"https://api.github.com/repos/lyw07/kolibri-installer-debian/events","assignees_url":"https://api.github.com/repos/lyw07/kolibri-installer-debian/assignees{/user}","branches_url":"https://api.github.com/repos/lyw07/kolibri-installer-debian/branches{/branch}","tags_url":"https://api.github.com/repos/lyw07/kolibri-installer-debian/tags","blobs_url":"https://api.github.com/repos/lyw07/kolibri-installer-debian/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lyw07/kolibri-installer-debian/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lyw07/kolibri-installer-debian/git/refs{/sha}","trees_url":"https://api.github.com/repos/lyw07/kolibri-installer-debian/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lyw07/kolibri-installer-debian/statuses/{sha}","languages_url":"https://api.github.com/repos/lyw07/kolibri-installer-debian/languages","stargazers_url":"https://api.github.com/repos/lyw07/kolibri-installer-debian/stargazers","contributors_url":"https://api.github.com/repos/lyw07/kolibri-installer-debian/contributors","subscribers_url":"https://api.github.com/repos/lyw07/kolibri-installer-debian/subscribers","subscription_url":"https://api.github.com/repos/lyw07/kolibri-installer-debian/subscription","commits_url":"https://api.github.com/repos/lyw07/kolibri-installer-debian/commits{/sha}","git_commits_url":"https://api.github.com/repos/lyw07/kolibri-installer-debian/git/commits{/sha}","comments_url":"https://api.github.com/repos/lyw07/kolibri-installer-debian/comments{/number}","issue_comment_url":"https://api.github.com/repos/lyw07/kolibri-installer-debian/issues/comments{/number}","contents_url":"https://api.github.com/repos/lyw07/kolibri-installer-debian/contents/{+path}","compare_url":"https://api.github.com/repos/lyw07/kolibri-installer-debian/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lyw07/kolibri-installer-debian/merges","archive_url":"https://api.github.com/repos/lyw07/kolibri-installer-debian/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lyw07/kolibri-installer-debian/downloads","issues_url":"https://api.github.com/repos/lyw07/kolibri-installer-debian/issues{/number}","pulls_url":"https://api.github.com/repos/lyw07/kolibri-installer-debian/pulls{/number}","milestones_url":"https://api.github.com/repos/lyw07/kolibri-installer-debian/milestones{/number}","notifications_url":"https://api.github.com/repos/lyw07/kolibri-installer-debian/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lyw07/kolibri-installer-debian/labels{/name}","releases_url":"https://api.github.com/repos/lyw07/kolibri-installer-debian/releases{/id}","deployments_url":"https://api.github.com/repos/lyw07/kolibri-installer-debian/deployments","created_at":"2018-03-29T16:59:57Z","updated_at":"2018-04-03T19:04:53Z","pushed_at":"2018-04-03T19:04:51Z","git_url":"git://github.com/lyw07/kolibri-installer-debian.git","ssh_url":"git@github.com:lyw07/kolibri-installer-debian.git","clone_url":"https://github.com/lyw07/kolibri-installer-debian.git","svn_url":"https://github.com/lyw07/kolibri-installer-debian","homepage":null,"size":64,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"learningequality:master","ref":"master","sha":"a64bee41a8f6443182c9dcb7880094468023ec8e","user":{"login":"learningequality","id":3926525,"avatar_url":"https://avatars1.githubusercontent.com/u/3926525?v=4","gravatar_id":"","url":"https://api.github.com/users/learningequality","html_url":"https://github.com/learningequality","followers_url":"https://api.github.com/users/learningequality/followers","following_url":"https://api.github.com/users/learningequality/following{/other_user}","gists_url":"https://api.github.com/users/learningequality/gists{/gist_id}","starred_url":"https://api.github.com/users/learningequality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/learningequality/subscriptions","organizations_url":"https://api.github.com/users/learningequality/orgs","repos_url":"https://api.github.com/users/learningequality/repos","events_url":"https://api.github.com/users/learningequality/events{/privacy}","received_events_url":"https://api.github.com/users/learningequality/received_events","type":"Organization","site_admin":false},"repo":{"id":88869793,"name":"kolibri-installer-debian","full_name":"learningequality/kolibri-installer-debian","owner":{"login":"learningequality","id":3926525,"avatar_url":"https://avatars1.githubusercontent.com/u/3926525?v=4","gravatar_id":"","url":"https://api.github.com/users/learningequality","html_url":"https://github.com/learningequality","followers_url":"https://api.github.com/users/learningequality/followers","following_url":"https://api.github.com/users/learningequality/following{/other_user}","gists_url":"https://api.github.com/users/learningequality/gists{/gist_id}","starred_url":"https://api.github.com/users/learningequality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/learningequality/subscriptions","organizations_url":"https://api.github.com/users/learningequality/orgs","repos_url":"https://api.github.com/users/learningequality/repos","events_url":"https://api.github.com/users/learningequality/events{/privacy}","received_events_url":"https://api.github.com/users/learningequality/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/learningequality/kolibri-installer-debian","description":"Kolibri installer source for Debian","fork":false,"url":"https://api.github.com/repos/learningequality/kolibri-installer-debian","forks_url":"https://api.github.com/repos/learningequality/kolibri-installer-debian/forks","keys_url":"https://api.github.com/repos/learningequality/kolibri-installer-debian/keys{/key_id}","collaborators_url":"https://api.github.com/repos/learningequality/kolibri-installer-debian/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/learningequality/kolibri-installer-debian/teams","hooks_url":"https://api.github.com/repos/learningequality/kolibri-installer-debian/hooks","issue_events_url":"https://api.github.com/repos/learningequality/kolibri-installer-debian/issues/events{/number}","events_url":"https://api.github.com/repos/learningequality/kolibri-installer-debian/events","assignees_url":"https://api.github.com/repos/learningequality/kolibri-installer-debian/assignees{/user}","branches_url":"https://api.github.com/repos/learningequality/kolibri-installer-debian/branches{/branch}","tags_url":"https://api.github.com/repos/learningequality/kolibri-installer-debian/tags","blobs_url":"https://api.github.com/repos/learningequality/kolibri-installer-debian/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/learningequality/kolibri-installer-debian/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/learningequality/kolibri-installer-debian/git/refs{/sha}","trees_url":"https://api.github.com/repos/learningequality/kolibri-installer-debian/git/trees{/sha}","statuses_url":"https://api.github.com/repos/learningequality/kolibri-installer-debian/statuses/{sha}","languages_url":"https://api.github.com/repos/learningequality/kolibri-installer-debian/languages","stargazers_url":"https://api.github.com/repos/learningequality/kolibri-installer-debian/stargazers","contributors_url":"https://api.github.com/repos/learningequality/kolibri-installer-debian/contributors","subscribers_url":"https://api.github.com/repos/learningequality/kolibri-installer-debian/subscribers","subscription_url":"https://api.github.com/repos/learningequality/kolibri-installer-debian/subscription","commits_url":"https://api.github.com/repos/learningequality/kolibri-installer-debian/commits{/sha}","git_commits_url":"https://api.github.com/repos/learningequality/kolibri-installer-debian/git/commits{/sha}","comments_url":"https://api.github.com/repos/learningequality/kolibri-installer-debian/comments{/number}","issue_comment_url":"https://api.github.com/repos/learningequality/kolibri-installer-debian/issues/comments{/number}","contents_url":"https://api.github.com/repos/learningequality/kolibri-installer-debian/contents/{+path}","compare_url":"https://api.github.com/repos/learningequality/kolibri-installer-debian/compare/{base}...{head}","merges_url":"https://api.github.com/repos/learningequality/kolibri-installer-debian/merges","archive_url":"https://api.github.com/repos/learningequality/kolibri-installer-debian/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/learningequality/kolibri-installer-debian/downloads","issues_url":"https://api.github.com/repos/learningequality/kolibri-installer-debian/issues{/number}","pulls_url":"https://api.github.com/repos/learningequality/kolibri-installer-debian/pulls{/number}","milestones_url":"https://api.github.com/repos/learningequality/kolibri-installer-debian/milestones{/number}","notifications_url":"https://api.github.com/repos/learningequality/kolibri-installer-debian/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/learningequality/kolibri-installer-debian/labels{/name}","releases_url":"https://api.github.com/repos/learningequality/kolibri-installer-debian/releases{/id}","deployments_url":"https://api.github.com/repos/learningequality/kolibri-installer-debian/deployments","created_at":"2017-04-20T13:39:36Z","updated_at":"2018-04-03T10:51:29Z","pushed_at":"2018-04-03T19:11:00Z","git_url":"git://github.com/learningequality/kolibri-installer-debian.git","ssh_url":"git@github.com:learningequality/kolibri-installer-debian.git","clone_url":"https://github.com/learningequality/kolibri-installer-debian.git","svn_url":"https://github.com/learningequality/kolibri-installer-debian","homepage":null,"size":63,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":2,"open_issues":10,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/learningequality/kolibri-installer-debian/pulls/28"},"html":{"href":"https://github.com/learningequality/kolibri-installer-debian/pull/28"},"issue":{"href":"https://api.github.com/repos/learningequality/kolibri-installer-debian/issues/28"},"comments":{"href":"https://api.github.com/repos/learningequality/kolibri-installer-debian/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/learningequality/kolibri-installer-debian/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/learningequality/kolibri-installer-debian/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/learningequality/kolibri-installer-debian/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/learningequality/kolibri-installer-debian/statuses/9d0ed1aca8b9164365593c411598802e145afce3"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"benjaoming"}}